WebKit-https.git
13 years ago2009-08-14 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Sat, 15 Aug 2009 05:19:27 +0000 (05:19 +0000)]
2009-08-14  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Rubber-stamped by Gustavo Noronha.

        Initialize CFLAGS and CXXFLAGS before the main body of the
        WEBKIT_INIT macro so C files don't get built with "-g -O2".

        * autotools/webkit.m4:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoNot reviewed, adding new test to Skipped on gtk and Qt.
dimich@chromium.org [Sat, 15 Aug 2009 02:53:15 +0000 (02:53 +0000)]
Not reviewed, adding new test to Skipped on gtk and Qt.
DRT on these ports does not yet support layoutTestController.overridePreference.

* platform/gtk/Skipped: skip LayoutTests/fast/harness/use-page-cache.html
* platform/qt/Skipped: ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago* parser/Parser.h:
barraclough@apple.com [Sat, 15 Aug 2009 01:36:51 +0000 (01:36 +0000)]
* parser/Parser.h:
(JSC::EvalExecutable::parse):
(JSC::ProgramExecutable::parse):
* runtime/Executable.h:

Reviewed by NOBODY (build fix).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agohttps://bugs.webkit.org/show_bug.cgi?id=28324
dimich@chromium.org [Sat, 15 Aug 2009 01:20:38 +0000 (01:20 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=28324
First ever test using page cache!
The test verifies that override setting that enables page cache works correctly.
It navigates forward and then back and checks that onload is not fired again
but the timer continues firing.

Reviewed by Eric Seidel.

* fast/harness/resources/cached-page-1.html: Added.
* fast/harness/resources/cached-page-2.html: Added.
* fast/harness/use-page-cache-expected.txt: Added.
* fast/harness/use-page-cache.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-08-14 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Sat, 15 Aug 2009 01:14:47 +0000 (01:14 +0000)]
2009-08-14  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dave Hyatt.

        Fix an assertion when bringing up the Inspector.
        https://bugs.webkit.org/show_bug.cgi?id=28318

        The fix for bug 28295 assumed that image clients count the number of times
        addClient/removeClient is called. That was true for CachedResource clients,
        but not StyleGeneratedImage clients, which pass the call onto CSSImageGeneratorValue.

        Fix by making CSSImageGeneratorValue count the number of times a client is
        added/removed.

        * css/CSSCanvasValue.cpp:
        (WebCore::CSSCanvasValue::canvasChanged):
        (WebCore::CSSCanvasValue::canvasResized):
        * css/CSSImageGeneratorValue.cpp:
        (WebCore::CSSImageGeneratorValue::addClient):
        (WebCore::CSSImageGeneratorValue::removeClient):
        (WebCore::CSSImageGeneratorValue::getImage):
        * css/CSSImageGeneratorValue.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoRemove AST nodes from use within the Runtime (outside of parsing), stage 1
barraclough@apple.com [Sat, 15 Aug 2009 01:14:00 +0000 (01:14 +0000)]
Remove AST nodes from use within the Runtime (outside of parsing), stage 1
https://bugs.webkit.org/show_bug.cgi?id=28330

Reviewed by Oliver Hunt.

Remove the EvalNode and ProgramNode from use in the runtime.  They still exist
after this patch, but are hidden behind EvalExecutable and FunctionExecutable,
and are also still reachable behind CodeBlock::m_ownerNode.

The next step will be to beat back FunctionBodyNode in the same fashion.
Then remove the usage via CodeBlock, then only construct these nodes only on
demand during bytecode generation.

* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/CodeBlock.h:
(JSC::GlobalCodeBlock::GlobalCodeBlock):
(JSC::GlobalCodeBlock::~GlobalCodeBlock):
(JSC::ProgramCodeBlock::ProgramCodeBlock):
(JSC::EvalCodeBlock::EvalCodeBlock):
(JSC::FunctionCodeBlock::FunctionCodeBlock):
(JSC::NativeCodeBlock::NativeCodeBlock):
* bytecode/EvalCodeCache.h:
(JSC::EvalCodeCache::get):
* debugger/Debugger.cpp:
(JSC::evaluateInGlobalCallFrame):
* debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::evaluate):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::callEval):
(JSC::Interpreter::execute):
* interpreter/Interpreter.h:
* parser/Nodes.cpp:
(JSC::FunctionBodyNode::createNativeThunk):
(JSC::FunctionBodyNode::generateBytecode):
(JSC::FunctionBodyNode::bytecodeForExceptionInfoReparse):
* parser/Parser.h:
(JSC::Parser::parse):
(JSC::Parser::reparse):
(JSC::Parser::parseFunctionFromGlobalCode):
(JSC::::parse):
* runtime/Completion.cpp:
(JSC::checkSyntax):
(JSC::evaluate):
* runtime/Error.cpp:
(JSC::throwError):
* runtime/Error.h:
* runtime/Executable.h: Added.
(JSC::TemplateExecutable::TemplateExecutable):
(JSC::TemplateExecutable::markAggregate):
(JSC::TemplateExecutable::sourceURL):
(JSC::TemplateExecutable::lineNo):
(JSC::TemplateExecutable::bytecode):
(JSC::TemplateExecutable::jitCode):
(JSC::EvalExecutable::EvalExecutable):
(JSC::ProgramExecutable::ProgramExecutable):
* runtime/FunctionConstructor.cpp:
(JSC::constructFunction):
* runtime/FunctionConstructor.h:
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::numericCompareFunction):
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::~JSGlobalObject):
(JSC::JSGlobalObject::markChildren):
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::codeBlocks):
* runtime/JSGlobalObjectFunctions.cpp:
(JSC::globalFuncEval):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBuild fix.
mrowe@apple.com [Fri, 14 Aug 2009 23:25:47 +0000 (23:25 +0000)]
Build fix.

* Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::enumerate):  Add the necessary .get() calls.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebKit/mac: <rdar://problem/7091546> - Assertion failure in plugins/return-error...
beidson@apple.com [Fri, 14 Aug 2009 23:21:30 +0000 (23:21 +0000)]
WebKit/mac: <rdar://problem/7091546> - Assertion failure in plugins/return-error-from-new-stream-doesnt-invoke-destroy-stream.html
on 64-bit SnowLeopard

Reviewed by Anders Carlsson.

* Plugins/Hosted/HostedNetscapePluginStream.mm:
(WebKit::HostedNetscapePluginStream::cancelLoad): Since this might be called while the FrameLoader is switching DocumentLoaders
  during the brief moment where there is no activeDocumentLoader(), accept and handle a validly null DocumentLoader.

LayoutTests: <rdar://problem/7091546> - Re-enable 3 plugins tests that now won't crash

Reviewed by Anders Carlsson.

* platform/mac-snowleopard/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix leaks of NSNumber and NSMutableArray objects seen during layout tests.
mrowe@apple.com [Fri, 14 Aug 2009 23:18:48 +0000 (23:18 +0000)]
Fix leaks of NSNumber and NSMutableArray objects seen during layout tests.

Reviewed by Brady Eidson.

* Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::enumerate): Don't leak an NSMutableArray that we allocate.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix leaks of HostedNetscapePluginStream and NetscapePlugInStreamLoader objects seen...
mrowe@apple.com [Fri, 14 Aug 2009 23:18:45 +0000 (23:18 +0000)]
Fix leaks of HostedNetscapePluginStream and NetscapePlugInStreamLoader objects seen during layout tests.

Reviewed by Anders Carlsson.

* Plugins/Hosted/HostedNetscapePluginStream.mm:
(WebKit::HostedNetscapePluginStream::didFail): Disconnect the stream from the plug-in instance proxy
when the load fails.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoCorrect libcurl crash when downloading local files.
bfulgham@webkit.org [Fri, 14 Aug 2009 22:06:00 +0000 (22:06 +0000)]
Correct libcurl crash when downloading local files.
https://bugs.webkit.org/show_bug.cgi?id=28312

Reviewed by Kevin Ollivier.

No new tests. Test is covered by fast/encoding/char-encoding-mac.html.

* platform/network/curl/ResourceHandleManager.cpp:
(WebCore::handleLocalReceiveResponse): New static function that
  performs the local setting of valid URL and firing didReceiveResponse.
  This code was moved from writeCallback.
(WebCore::writeCallback): Move local file handling to static function
  (above) and use the function instead.
(WebCore::readCallback): Add check
  for responseFired, and handle as a local file if it was not.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdding two more to the skipped list.
beidson@apple.com [Fri, 14 Aug 2009 21:54:08 +0000 (21:54 +0000)]
Adding two more to the skipped list.
Radars 7144571 and 7144583 track exploring them.

* platform/mac-snowleopard/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoDisable media/controls-drag-timebar.html on SnowLeopard.
beidson@apple.com [Fri, 14 Aug 2009 20:54:28 +0000 (20:54 +0000)]
Disable media/controls-drag-timebar.html on SnowLeopard.
<rdar://problem/7144385> tracks exploring the failure.

* platform/mac-snowleopard/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-08-14 Maxime Simon <simon.maxime@gmail.com>
eric@webkit.org [Fri, 14 Aug 2009 20:52:09 +0000 (20:52 +0000)]
2009-08-14  Maxime Simon  <simon.maxime@gmail.com>

        Reviewed by Oliver Hunt.

        [Haiku] Fix RenderThemeHaiku build.
        https://bugs.webkit.org/show_bug.cgi?id=28307

        * platform/haiku/RenderThemeHaiku.cpp: Included RenderThemeHaiku.h
        instead of RenderTheme.h.
        (WebCore::RenderThemeHaiku::paintCheckbox): Removed the wrong 'virtual'
        before the function.
        (WebCore::RenderThemeHaiku::paintRadio): Removed the wrong 'virtual'
        before the function.
        * platform/haiku/RenderThemeHaiku.h: Corrected wrong function definitions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-08-14 Maxime Simon <simon.maxime@gmail.com>
eric@webkit.org [Fri, 14 Aug 2009 20:35:33 +0000 (20:35 +0000)]
2009-08-14  Maxime Simon  <simon.maxime@gmail.com>

        Reviewed by Oliver Hunt.

        [Haiku] Adding SharedBufferHaiku to WebCore.
        https://bugs.webkit.org/show_bug.cgi?id=28309

        * platform/haiku/SharedBufferHaiku.cpp: Added.
        (WebCore::SharedBuffer::createWithContentsOfFile):
        * platform/haiku/TemporaryLinkStubs.cpp: Removed unnecessary headers
        and functions.
        (WebCore::signedPublicKeyAndChallengeString):
        (WebCore::getSupportedKeySizes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-08-14 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 14 Aug 2009 20:29:42 +0000 (20:29 +0000)]
2009-08-14  Eric Seidel  <eric@webkit.org>

        No review.  Fix 5-space indent to be 4-spaces.

        * Scripts/bugzilla-tool:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-08-14 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Fri, 14 Aug 2009 20:20:30 +0000 (20:20 +0000)]
2009-08-14  Nate Chapin  <japhet@chromium.org>

        Reviewed by Dimitri Glazkov.

        Ensure we're getting the right v8 context in the V8 DOMWindowEvent custom getter.

        https://bugs.webkit.org/show_bug.cgi?id=28311

        This should fix Chromium failing LayoutTests/fast/events/set-event-in-another-frame.html.

        * bindings/v8/custom/V8DOMWindowCustom.cpp:
        (WebCore::ACCESSOR_GETTER):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago[ES5] Arguments object should inherit from Array
oliver@apple.com [Fri, 14 Aug 2009 20:18:09 +0000 (20:18 +0000)]
[ES5] Arguments object should inherit from Array
https://bugs.webkit.org/show_bug.cgi?id=28298

Reviewed by Gavin Barraclough

Make the Arguments object conform to the behaviour specified in ES5.
The simple portion of this is to make Arguments use Array.prototype
as its prototype rather than Object.prototype.

The spec then requires us to set instance.constructor to the pristine
Object constructor, and instance.toString and instance.toLocaleString
to the pristine versions from Object.prototype.  To do this we now
make the ObjectPrototype constructor return its toString and
toLocaleString functions (similar to the call and apply functions
from FunctionPrototype).

Oddly enough this reports itself as a slight win, but given the code
isn't hit in the tests that claim to have improved I put this down to
code motion.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-08-14 Aaron Boodman <aa@chromium.org>
eric@webkit.org [Fri, 14 Aug 2009 19:25:37 +0000 (19:25 +0000)]
2009-08-14  Aaron Boodman  <aa@chromium.org>

        Reviewed by Alexey Proskuryakov.

        BUG 28134: Move the remaining parts of Access Control from XMLHttpRequest to ThreadableDocumentLoader.
        https://bugs.webkit.org/show_bug.cgi?id=28134

        No new tests added since Access Control was already well tested and this is a pure refactor.

        * loader/DocumentThreadableLoader.cpp: Move a lot of the access control code from XHR in, preserving its
        basic strategy. Also, modify the synchronous path to not be a special case, but reuse more of the async
        path.

        (WebCore::DocumentThreadableLoader::loadResourceSynchronously): Go through the async path and pass additional flags.
        (WebCore::DocumentThreadableLoader::create): Group enum params into an options struct.
        (WebCore::DocumentThreadableLoader::DocumentThreadableLoader): Ditto.
        (WebCore::DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest): Brought mostly from XHR.
        (WebCore::DocumentThreadableLoader::makeCrossOriginAccessRequestWithPreflight): Ditto.
        (WebCore::DocumentThreadableLoader::willSendRequest): Handle preflight case.
        (WebCore::DocumentThreadableLoader::didReceiveResponse): Ditto.
        (WebCore::DocumentThreadableLoader::didFinishLoading): Ditto.
        (WebCore::DocumentThreadableLoader::getShouldUseCredentialStorage): Ditto.
        (WebCore::DocumentThreadableLoader::preflightSuccess): Preflight handling.
        (WebCore::DocumentThreadableLoader::preflightFailure): Ditto.
        (WebCore::DocumentThreadableLoader::loadRequest): Common request function that handles async/sync.
        * loader/DocumentThreadableLoader.h: Group enum params into an options struct.
        * loader/ThreadableLoader.cpp: Ditto.
        (WebCore::ThreadableLoader::create): Ditto.
        (WebCore::ThreadableLoader::loadResourceSynchronously): Ditto.
        * loader/ThreadableLoader.h: Ditto.
        (WebCore::ThreadableLoaderOptions::ThreadableLoaderOptions): Ditto.
        * loader/WorkerThreadableLoader.cpp: Ditto.
        (WebCore::WorkerThreadableLoader::WorkerThreadableLoader):Ditto.
        (WebCore::WorkerThreadableLoader::loadResourceSynchronously): Ditto.
        (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge): Ditto.
        (WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCreateLoader): Ditto.
        * loader/WorkerThreadableLoader.h: Ditto.
        (WebCore::WorkerThreadableLoader::create): Ditto.
        * platform/CrossThreadCopier.h: Allow ThreadableLoaderOptions to be copied across threads.
        (WebCore::):
        * workers/WorkerScriptLoader.cpp: More enum->struct grouping.
        (WebCore::WorkerScriptLoader::loadSynchronously): More enum->struct grouping.
        (WebCore::WorkerScriptLoader::loadAsynchronously): More enum->struct grouping.
        * xml/XMLHttpRequest.cpp: Remove all the access control code and some supporting state.
        (WebCore::XMLHttpRequest::XMLHttpRequest): Ditto.
        (WebCore::XMLHttpRequest::createRequest): Ditto.
        (WebCore::XMLHttpRequest::didFinishLoading): Ditto.
        (WebCore::XMLHttpRequest::didReceiveResponse): Ditto.
        (WebCore::XMLHttpRequest::didReceiveData): Ditto.
        * xml/XMLHttpRequest.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoRename the confusing isObject(<class>) to inherits(<class>).
darin@apple.com [Fri, 14 Aug 2009 18:49:29 +0000 (18:49 +0000)]
Rename the confusing isObject(<class>) to inherits(<class>).
It still works on non-objects, returning false.

Patch by Darin Adler <darin@apple.com> on 2009-08-14
Reviewed by Sam Weinig.

* JSUtils.cpp:
(KJSValueToJSObject):
(KJSValueToCFTypeInternal):
Changed from isObject to inherits.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-08-14 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Fri, 14 Aug 2009 18:25:31 +0000 (18:25 +0000)]
2009-08-14  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Adam Roben.

        Remove media/video-played.html from the Windows skipped list, fixed
        as part of https://bugs.webkit.org/show_bug.cgi?id=28275. Add
        media/video-played-collapse.html for now.

        https://bugs.webkit.org/show_bug.cgi?id=28275

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore: Rename the confusing isObject(<class>) to inherits(<class>).
darin@apple.com [Fri, 14 Aug 2009 18:12:49 +0000 (18:12 +0000)]
JavaScriptCore: Rename the confusing isObject(<class>) to inherits(<class>).
It still works on non-objects, returning false.

Patch by Darin Adler <darin@apple.com> on 2009-08-14
Reviewed by Sam Weinig.

* runtime/ArrayConstructor.cpp:
(JSC::arrayConstructorIsArray): Removed unneeded isObject call
and updated remaining isObject call to new name, inherits.

* runtime/JSCell.h: Renamed isObject(<class>) to inherits(<class>)
but more importantly, made it non-virtual (it was already inline)
so it is now as fast as JSObject::inherits was.

* runtime/JSObject.h: Removed inherits function since the one
in the base class is fine as-is. Also made various JSCell functions
that should not be called on JSObject uncallable by making them
both private and not implemented.
(JSC::JSCell::inherits): Updated name.
(JSC::JSValue::inherits): Ditto.

* debugger/Debugger.cpp:
(JSC::Debugger::recompileAllJSFunctions):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::unwindCallFrame):
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncToString):
(JSC::arrayProtoFuncToLocaleString):
(JSC::arrayProtoFuncConcat):
* runtime/BooleanPrototype.cpp:
(JSC::booleanProtoFuncToString):
(JSC::booleanProtoFuncValueOf):
* runtime/DateConstructor.cpp:
(JSC::constructDate):
* runtime/DatePrototype.cpp:
(JSC::dateProtoFuncToString):
(JSC::dateProtoFuncToUTCString):
(JSC::dateProtoFuncToISOString):
(JSC::dateProtoFuncToDateString):
(JSC::dateProtoFuncToTimeString):
(JSC::dateProtoFuncToLocaleString):
(JSC::dateProtoFuncToLocaleDateString):
(JSC::dateProtoFuncToLocaleTimeString):
(JSC::dateProtoFuncGetTime):
(JSC::dateProtoFuncGetFullYear):
(JSC::dateProtoFuncGetUTCFullYear):
(JSC::dateProtoFuncToGMTString):
(JSC::dateProtoFuncGetMonth):
(JSC::dateProtoFuncGetUTCMonth):
(JSC::dateProtoFuncGetDate):
(JSC::dateProtoFuncGetUTCDate):
(JSC::dateProtoFuncGetDay):
(JSC::dateProtoFuncGetUTCDay):
(JSC::dateProtoFuncGetHours):
(JSC::dateProtoFuncGetUTCHours):
(JSC::dateProtoFuncGetMinutes):
(JSC::dateProtoFuncGetUTCMinutes):
(JSC::dateProtoFuncGetSeconds):
(JSC::dateProtoFuncGetUTCSeconds):
(JSC::dateProtoFuncGetMilliSeconds):
(JSC::dateProtoFuncGetUTCMilliseconds):
(JSC::dateProtoFuncGetTimezoneOffset):
(JSC::dateProtoFuncSetTime):
(JSC::setNewValueFromTimeArgs):
(JSC::setNewValueFromDateArgs):
(JSC::dateProtoFuncSetYear):
(JSC::dateProtoFuncGetYear):
* runtime/FunctionPrototype.cpp:
(JSC::functionProtoFuncToString):
* runtime/JSActivation.cpp:
(JSC::JSActivation::argumentsGetter):
* runtime/JSValue.h:
* runtime/RegExpConstructor.cpp:
(JSC::constructRegExp):
* runtime/RegExpPrototype.cpp:
(JSC::regExpProtoFuncTest):
(JSC::regExpProtoFuncExec):
(JSC::regExpProtoFuncCompile):
(JSC::regExpProtoFuncToString):
* runtime/ScopeChain.cpp:
(JSC::ScopeChain::localDepth):
* runtime/StringPrototype.cpp:
(JSC::stringProtoFuncReplace):
(JSC::stringProtoFuncToString):
(JSC::stringProtoFuncMatch):
(JSC::stringProtoFuncSearch):
(JSC::stringProtoFuncSplit):
Updated to new name, inherits, from old name, isObject.

WebCore: Rename the confusing isObject(<class>) to inherits(<class>).
It still works on non-objects, returning false.

Patch by Darin Adler <darin@apple.com> on 2009-08-14
Reviewed by Sam Weinig.

* bindings/js/JSEventTarget.cpp:
(WebCore::toEventTarget):
* bindings/js/JSGeolocationCustom.cpp:
(WebCore::createPositionCallback):
(WebCore::createPositionErrorCallback):
* bindings/js/JSNodeFilterCustom.cpp:
(WebCore::toNodeFilter):
* bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::send):
* bindings/js/JSXSLTProcessorCustom.cpp:
(WebCore::JSXSLTProcessor::importStylesheet):
(WebCore::JSXSLTProcessor::transformToFragment):
(WebCore::JSXSLTProcessor::transformToDocument):
* bindings/scripts/CodeGeneratorJS.pm:
* bridge/objc/objc_runtime.mm:
(JSC::Bindings::callObjCFallbackObject):
* bridge/runtime_method.cpp:
(JSC::callRuntimeMethod):
Updated to new name, inherits, from old name, isObject.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-08-14 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Fri, 14 Aug 2009 17:58:15 +0000 (17:58 +0000)]
2009-08-14  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Simon Fraser.

        media/video-played.html always times out on Windows
        https://bugs.webkit.org/show_bug.cgi?id=28275

        * media/video-played-collapse.html:
            Make sub-test assumptions obvious for someone reading this later.

        * media/video-played.html: Removed.
        * media/video-played-expected.txt: Removed.
        * media/video-played-ranges-1-expected.txt: Copied from LayoutTests/media/video-played-expected.txt.
        * media/video-played-ranges-1.html: Copied from LayoutTests/media/video-played.html.
            Split video-played.html into video-played-ranges-1.html and video-played-ranges-2.html.

        * media/video-played-reset.html:
            Make sub-test assumptions obvious for someone reading this later.

        * media/video-played.js:
        (logRanges):
            New but not currently called. Allows all ranges to be logged for debugging.
        (testRanges):
            Log ranges and the amount of time each test takes when logTestTiming != 0.
        (nextTest):
            Record test start time when logTestTiming is true;
        (startPlaying):
            Run each sub-test for 100ms instead of 250ms to decrease overall test time.
        (playForMillisecs.callPauseIfTimeIsReached):
        (playForMillisecs):
            Make error conditions trigger immediate failure instead of just logging.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-08-14 Benjamin Otte <otte@gnome.org>
kov@webkit.org [Fri, 14 Aug 2009 15:51:17 +0000 (15:51 +0000)]
2009-08-14  Benjamin Otte  <otte@gnome.org>

        Reviewed by Gustavo Noronha.

        Fix webkit_web_view_set_highlight_text_matches() so that highlighting
        works properly in documents with frames.

        * webkit/webkitwebview.cpp:
        (webkit_web_view_set_highlight_text_matches):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoRVCT elftran fails to resolve QPainter::staticMetaObject coming with
hausmann@webkit.org [Fri, 14 Aug 2009 14:50:19 +0000 (14:50 +0000)]
RVCT elftran fails to resolve QPainter::staticMetaObject coming with
QWebView::RenderHints property.

Patch by Yongjun Zhang <yongjun.zhang@nokia.com> on 2009-08-14
Reviewed by Simon Hausmann.

This is a temporary fix and will be revereted when the right symbols
exported from Qt lib in S60.

https://bugs.webkit.org/show_bug.cgi?id=28181

* Api/qwebview.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdding QNX as a platform. Currently only tested with Qt.
hausmann@webkit.org [Fri, 14 Aug 2009 14:44:34 +0000 (14:44 +0000)]
Adding QNX as a platform. Currently only tested with Qt.

Patch by Harald Fernengel <harald.fernengel@nokia.com> on 2009-07-31
Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=27885

* JavaScriptCore/runtime/Collector.cpp: Added retrieving of stack base
  since QNX doesn't have the pthread _nt functions
* JavaScriptCore/wtf/Platform.h: Added WTF_PLATFORM_QNX and corresponding
  defines
* WebCore/bridge/npapi.h: Build fix for missing typedefs on QNX

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebKit/qt: [Qt] Public API to configure the storage path for HTML5 localStorage
hausmann@webkit.org [Fri, 14 Aug 2009 14:21:06 +0000 (14:21 +0000)]
WebKit/qt: [Qt] Public API to configure the storage path for HTML5 localStorage
https://bugs.webkit.org/show_bug.cgi?id=28036

Patch by Laszlo Gombos <laszlo.1.gombos@nokia.com> on 2009-08-14
Reviewed by Simon Hausmann.

Disables LocalStorage for QtWebKit by default by setting
QWebSettings::LocalStorageEnabled to false.

Sets up a default for the LocalStorage path so that clients would only
need to enable the LocalStorageEnabled setting to turn on LocalStoragre
support.

Turn on LocalStorage support for QtLauncher and the relevant test
since LocalStorage is now disabled by default for QtWebkit.

* Api/qwebpage.cpp:
(defaultCachePath):
(initializeApplicationCachePathIfNecessary):
(QWebPagePrivate::QWebPagePrivate):
* Api/qwebsettings.cpp:
(QWebSettingsPrivate::apply):
(QWebSettings::QWebSettings):
(QWebSettings::setLocalStoragePath):
(QWebSettings::localStoragePath):
* Api/qwebsettings.h:
* QtLauncher/main.cpp:
(main):
* tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::multiplePageGroupsAndLocalStorage):

WebKitTools: [Qt] Public API to configure the storage path for HTML5 localStorage
https://bugs.webkit.org/show_bug.cgi?id=28036

Patch by Laszlo Gombos <laszlo.1.gombos@nokia.com> on 2009-08-14
Reviewed by Simon Hausmann.

Turn on LocalStorage support for Qt DumpRenderTree since
LocalStorage is now disabled by defult for QtWebkit.

* DumpRenderTree/qt/DumpRenderTree.cpp:
(WebCore::WebPage::WebPage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore: Allow Qt API to list and to remove URL schemes that were registered as
yael.aharon@nokia.com [Fri, 14 Aug 2009 14:19:57 +0000 (14:19 +0000)]
WebCore: Allow Qt API to list and to remove URL schemes that were registered as
local URL schemes.
[Qt] Allow applications to register their own local URL scheme.
https://bugs.webkit.org/show_bug.cgi?id=28240

Patch by Yael Aharon <yael.aharon@nokia.com> on 2009-08-14
Reviewed by Simon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd the blog of University of Szeged.
hausmann@webkit.org [Fri, 14 Aug 2009 12:54:29 +0000 (12:54 +0000)]
Add the blog of University of Szeged.
https://bugs.webkit.org/show_bug.cgi?id=28301

Patch by Csaba Osztrogonac <oszi@inf.u-szeged.hu> on 2009-08-14
Reviewed by Simon Hausmann.

* config.ini:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-08-14 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Fri, 14 Aug 2009 12:05:32 +0000 (12:05 +0000)]
2009-08-14  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Jan Alonzo.

        Do not unref the main webview, it's owned by its parent
        container. Instead destroy the container, which should take care
        of everything (not terribly important since we exit right after
        that, but still).

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-08-14 Ariya Hidayat <ariya.hidayat@nokia.com>
ariya@webkit.org [Fri, 14 Aug 2009 12:01:55 +0000 (12:01 +0000)]
2009-08-14  Ariya Hidayat  <ariya.hidayat@nokia.com>

        Rubber-stamped by Tor Arne Vestbø.

        [Qt] Add test result after r47255.

        * platform/qt/fast/block/float/avoidance-percent-width-compat-expected.txt: Added.
        * platform/qt/fast/block/float/avoidance-percent-width-strict-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoCurrently generic ARM and ARMv7 platforms work only with JSVALUE32
hausmann@webkit.org [Fri, 14 Aug 2009 11:49:56 +0000 (11:49 +0000)]
Currently generic ARM and ARMv7 platforms work only with JSVALUE32
https://bugs.webkit.org/show_bug.cgi?id=28300

Patch by Gabor Loki <loki@inf.u-szeged.hu> on 2009-08-14
Reviewed by Simon Hausmann.

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-08-14 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Fri, 14 Aug 2009 11:39:16 +0000 (11:39 +0000)]
2009-08-14  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        WebInspector: Wrap console objects late (in the frontend) so that injected
        script was already in place.

        https://bugs.webkit.org/show_bug.cgi?id=28297

        * inspector/ConsoleMessage.cpp:
        (WebCore::ConsoleMessage::ConsoleMessage):
        * inspector/ConsoleMessage.h:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::addMessageToConsole):
        (WebCore::InspectorController::startGroup):
        (WebCore::InspectorController::setFrontendProxyObject):
        * inspector/InspectorController.h:
        * inspector/InspectorFrontend.cpp:
        (WebCore::InspectorFrontend::InspectorFrontend):
        (WebCore::InspectorFrontend::addMessageToConsole):
        * inspector/InspectorFrontend.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoTry to fix the build when !JIT_OPTIMIZE_NATIVE_CALL
vestbo@webkit.org [Fri, 14 Aug 2009 10:56:11 +0000 (10:56 +0000)]
Try to fix the build when !JIT_OPTIMIZE_NATIVE_CALL

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-08-14 Ariya Hidayat <ariya.hidayat@nokia.com>
ariya@webkit.org [Fri, 14 Aug 2009 10:12:15 +0000 (10:12 +0000)]
2009-08-14  Ariya Hidayat  <ariya.hidayat@nokia.com>

        Reviewed by Tor Arne Vestbø.

        [Qt] Update test result after r47255.
        Also while I am at it, add pixel test result.

        * platform/qt/fast/block/float/035-expected.checksum: Added.
        * platform/qt/fast/block/float/035-expected.png: Added.
        * platform/qt/fast/block/float/035-expected.txt: Adjusted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoEnable JIT on ARM for QT by default
hausmann@webkit.org [Fri, 14 Aug 2009 09:17:48 +0000 (09:17 +0000)]
Enable JIT on ARM for QT by default
https://bugs.webkit.org/show_bug.cgi?id=28259

Patch by Gabor Loki <loki@inf.u-szeged.hu> on 2009-08-14
Reviewed by Simon Hausmann.

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoEnable YARR_JIT on ARM for QT by default
hausmann@webkit.org [Fri, 14 Aug 2009 09:17:40 +0000 (09:17 +0000)]
Enable YARR_JIT on ARM for QT by default
https://bugs.webkit.org/show_bug.cgi?id=28259

Patch by Gabor Loki <loki@inf.u-szeged.hu> on 2009-08-14
Reviewed by Simon Hausmann.

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoRemove MarkStack::drain from the JSC exports file
oliver@apple.com [Fri, 14 Aug 2009 07:09:21 +0000 (07:09 +0000)]
Remove MarkStack::drain from the JSC exports file

MarkStack::drain is now marked inline, the including it in the exports file
produces an ld warning

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago[ES5] Implement Array.isArray
oliver@apple.com [Fri, 14 Aug 2009 07:00:12 +0000 (07:00 +0000)]
[ES5] Implement Array.isArray
https://bugs.webkit.org/show_bug.cgi?id=28296

Reviewed by Maciej Stachowiak

Add support for Array.isArray to the Array constructor

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-08-13 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 14 Aug 2009 06:22:08 +0000 (06:22 +0000)]
2009-08-13  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Fix logic in RenderObject::updateFillImages() that led to incorrect client
        counts if an image was used twice in the background-image property.
        https://bugs.webkit.org/show_bug.cgi?id=28295

        Test: fast/backgrounds/multiple-backgrounds-assert.html

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::updateFillImages):
        Simplify the logic to call addClient()/removeClient() for every background
        image, but go through the new layers first to avoid removing all the
        clients of an image.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoRemove accidentally left in debugging statement.
weinig@apple.com [Fri, 14 Aug 2009 06:11:08 +0000 (06:11 +0000)]
Remove accidentally left in debugging statement.

Reviewed by Oliver Hunt.

* runtime/JSArray.h:
(JSC::MarkStack::drain):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAttempt to fix windows build
oliver@apple.com [Fri, 14 Aug 2009 05:41:20 +0000 (05:41 +0000)]
Attempt to fix windows build

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoDevirtualise marking
oliver@apple.com [Fri, 14 Aug 2009 05:35:33 +0000 (05:35 +0000)]
Devirtualise marking
https://bugs.webkit.org/show_bug.cgi?id=28294

Reviewed by Maciej Stachowiak.

Add a bit to TypeInfo to indicate that an object uses the standard
JSObject::markChildren method.  This allows us to devirtualise marking
of most objects (though a branch is still needed).  We also add a branch
to identify arrays thus devirtualising marking in that case as well.

In order to make the best use of this devirtualisation I've also reworked
the MarkStack::drain() logic to make the iteration more efficient.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoRevert "2009-08-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>"
jmalonzo@webkit.org [Fri, 14 Aug 2009 04:31:12 +0000 (04:31 +0000)]
Revert "2009-08-13  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>"

Revert http://trac.webkit.org/changeset/47203 as it makes the http/XHR tests fail.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore: Some small bits of housekeeping.
darin@apple.com [Fri, 14 Aug 2009 01:15:15 +0000 (01:15 +0000)]
JavaScriptCore: Some small bits of housekeeping.

Patch by Darin Adler <darin@apple.com> on 2009-08-13
Reviewed by Mark Rowe.

* JavaScriptCore.xcodeproj/project.pbxproj: Make Parser.h
project instead of private. Remove JSONObject.lut.h.

* assembler/ARMAssembler.h: Remove unneeded WTF prefix.
* assembler/AssemblerBufferWithConstantPool.h: Ditto.
* bytecompiler/BytecodeGenerator.h: Ditto.

* wtf/SegmentedVector.h: Add a "using" statement as we do
with the other WTF headers.

WebCore: Follow-up to earlier work to remove dependencies on JavaScriptCore.

Patch by Darin Adler <darin@apple.com> on 2009-08-13
Reviewed by Mark Rowe.

* ForwardingHeaders/parser/Parser.h: Removed.
* inspector/JavaScriptDebugServer.cpp: Removed now-unneeded includes
of Parser.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix Tiger build.
darin@apple.com [Fri, 14 Aug 2009 01:11:38 +0000 (01:11 +0000)]
Fix Tiger build.

Patch by Darin Adler <darin@apple.com> on 2009-08-13
* parser/Grammar.y: Use a template function so we can compile
setStatementLocation even if it comes before YYLTYPE is defined.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoToo much use of void* in Grammar.y
darin@apple.com [Fri, 14 Aug 2009 00:58:06 +0000 (00:58 +0000)]
Too much use of void* in Grammar.y
https://bugs.webkit.org/show_bug.cgi?id=28287

Patch by Darin Adler <darin@apple.com> on 2009-08-13
Reviewed by George Staikos.

* parser/Grammar.y: Changed all the helper functions to
take a JSGlobalData* instead of a void*. A couple formatting
tweaks that I missed when breaking this into pieces.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAnother part of https://bugs.webkit.org/show_bug.cgi?id=28287
darin@apple.com [Fri, 14 Aug 2009 00:56:42 +0000 (00:56 +0000)]
Another part of https://bugs.webkit.org/show_bug.cgi?id=28287

Patch by Darin Adler <darin@apple.com> on 2009-08-13
Reviewed by George Staikos.

* parser/Grammar.y: Reduced and sorted includes. Tweaked comment
format. Marked a few more functions inline.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore: 'box-orient: block-axis' behaves like 'box-orient: horizontal', causes
mitz@apple.com [Fri, 14 Aug 2009 00:52:56 +0000 (00:52 +0000)]
WebCore: 'box-orient: block-axis' behaves like 'box-orient: horizontal', causes
an assertion failure in debug builds
https://bugs.webkit.org/show_bug.cgi?id=28279

Reviewed by Eric Seidel.

Test: fast/flexbox/block-axis.html

* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::operator EBoxOrient): Map block-axis to
vertical.

LayoutTests:     2009-08-13  Dan Bernstein  <mitz@apple.com>

Reviewed by Eric Seidel.

'box-orient: block-axis' behaves like 'box-orient: horizontal', causes
an assertion failure in debug builds
https://bugs.webkit.org/show_bug.cgi?id=28279

* fast/flexbox/block-axis-expected.checksum: Added.
* fast/flexbox/block-axis-expected.png: Added.
* fast/flexbox/block-axis-expected.txt: Added.
* fast/flexbox/block-axis.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-08-13 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 14 Aug 2009 00:51:12 +0000 (00:51 +0000)]
2009-08-13  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Fix crash when removing reflection on an absolutely-positioned image.
        https://bugs.webkit.org/show_bug.cgi?id=28289

        Make sure we clean up the reflection layer when removing the reflection,
        so that the RenderLayer tree does not contain pointers to deleted layers.

        Test: fast/reflections/reflected-img-crash.html

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::~RenderLayer):
        (WebCore::RenderLayer::styleChanged):
        (WebCore::RenderLayer::removeReflection):
        * rendering/RenderLayer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAnother part of https://bugs.webkit.org/show_bug.cgi?id=28287
darin@apple.com [Fri, 14 Aug 2009 00:49:42 +0000 (00:49 +0000)]
Another part of https://bugs.webkit.org/show_bug.cgi?id=28287

Patch by Darin Adler <darin@apple.com> on 2009-08-13
Reviewed by George Staikos.

* parser/Grammar.y: Pass the number to the PropertyNode instead of
first turning it into an Identifier.

* parser/NodeConstructors.h:
(JSC::PropertyNode::PropertyNode): Add an overload that takes a double
so the code to convert to a string can be here instead of Grammar.y.
* parser/Nodes.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAnother part of https://bugs.webkit.org/show_bug.cgi?id=28287
darin@apple.com [Fri, 14 Aug 2009 00:47:55 +0000 (00:47 +0000)]
Another part of https://bugs.webkit.org/show_bug.cgi?id=28287

Patch by Darin Adler <darin@apple.com> on 2009-08-13
Reviewed by George Staikos.

* parser/Grammar.y: Eliminate the DBG macro.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAnother part of https://bugs.webkit.org/show_bug.cgi?id=28287
darin@apple.com [Fri, 14 Aug 2009 00:46:23 +0000 (00:46 +0000)]
Another part of https://bugs.webkit.org/show_bug.cgi?id=28287

Patch by Darin Adler <darin@apple.com> on 2009-08-13
Reviewed by George Staikos.

* parser/Grammar.y: Eliminate the SET_EXCEPTION_LOCATION macro.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoGeorge asked me to break the patch from
darin@apple.com [Fri, 14 Aug 2009 00:44:47 +0000 (00:44 +0000)]
George asked me to break the patch from
https://bugs.webkit.org/show_bug.cgi?id=28287
into smaller pieces and land it in stages.

Patch by Darin Adler <darin@apple.com> on 2009-08-13
Reviewed by George Staikos.

* parser/Grammar.y: Eliminate the LEXER macro.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore: misalignment because of float:left of <div> tag
mitz@apple.com [Fri, 14 Aug 2009 00:40:12 +0000 (00:40 +0000)]
WebCore: misalignment because of float:left of <div> tag
https://bugs.webkit.org/show_bug.cgi?id=15869

Reviewed by Simon Fraser.

One section of http://edgar.sec.gov site draws to the right of the rest
of the content
<rdar://problem/7135951>

Tests: fast/block/float/avoidance-percent-width-compat.html
       fast/block/float/avoidance-percent-width-strict.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::getClearDelta): Changed to apply the same float
    avoidance logic in strict mode and in compatibility mode, which
    matches Firefox and IE. Changed to compute and use the computed
    width of the child, instead of ignoring non-fixed widths.

LayoutTests: misalignment because of float:left of <div> tag
https://bugs.webkit.org/show_bug.cgi?id=15869

Reviewed by Simon Fraser.

One section of http://edgar.sec.gov site draws to the right of the rest
of the content
<rdar://problem/7135951>

* fast/block/float/avoidance-percent-width-compat.html: Added.
* fast/block/float/avoidance-percent-width-strict.html: Added.
* platform/mac/fast/block/float/035-expected.checksum:
* platform/mac/fast/block/float/035-expected.png:
* platform/mac/fast/block/float/035-expected.txt:
* platform/mac/fast/block/float/avoidance-percent-width-compat-expected.checksum: Added.
* platform/mac/fast/block/float/avoidance-percent-width-compat-expected.png: Added.
* platform/mac/fast/block/float/avoidance-percent-width-compat-expected.txt: Added.
* platform/mac/fast/block/float/avoidance-percent-width-strict-expected.checksum: Added.
* platform/mac/fast/block/float/avoidance-percent-width-strict-expected.png: Added.
* platform/mac/fast/block/float/avoidance-percent-width-strict-expected.txt: Added.
* platform/mac/fast/block/float/float-avoidance-expected.checksum:
* platform/mac/fast/block/float/float-avoidance-expected.png:
* platform/mac/fast/block/float/float-avoidance-expected.txt:
* platform/mac/fast/overflow/004-expected.checksum:
* platform/mac/fast/overflow/004-expected.png:
* platform/mac/fast/overflow/004-expected.txt:
* platform/mac/tables/mozilla/bugs/bug106158-1-expected.checksum:
* platform/mac/tables/mozilla/bugs/bug106158-1-expected.png:
* platform/mac/tables/mozilla/bugs/bug106158-1-expected.txt:
* platform/mac/tables/mozilla/bugs/bug106158-2-expected.checksum:
* platform/mac/tables/mozilla/bugs/bug106158-2-expected.png:
* platform/mac/tables/mozilla/bugs/bug106158-2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-08-13 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 14 Aug 2009 00:14:12 +0000 (00:14 +0000)]
2009-08-13  Eric Seidel  <eric@webkit.org>

        No review, only skipping tests.

        Qt: Font Sizes are wrong for font families including monospace
        https://bugs.webkit.org/show_bug.cgi?id=28288

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-08-13 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 13 Aug 2009 23:34:21 +0000 (23:34 +0000)]
2009-08-13  Eric Seidel  <eric@webkit.org>

        No review, correcting obvious python error seen in the commit queue.

        args can be a string or an array.  Assuming args is always an array results in
        double-spaced text in error logs.

        * Scripts/bugzilla-tool:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore: Geolocation PositionOptions does not use correct default values.
darin@apple.com [Thu, 13 Aug 2009 23:34:12 +0000 (23:34 +0000)]
WebCore: Geolocation PositionOptions does not use correct default values.
https://bugs.webkit.org/show_bug.cgi?id=27254

Patch by Steve Block <steveblock@google.com> on 2009-08-13
Reviewed by Darin Adler.

Sets the correct default values for the properties of the PositionOptions object
passed to Geolocation methods. See http://www.w3.org/TR/geolocation-API/.

Also adds checking to throw an exception if arguments of the incorrect type are
passed to Geolocation methods. Adds a layout test to test this. This test should
pass on all platforms where Geolocation is implemented.

Test: fast/dom/Geolocation/argument-types.html

* bindings/js/JSGeolocationCustom.cpp:
(WebCore::createPositionCallback): Added. Creates the callback.
(WebCore::createPositionErrorCallback): Added. Creates the calback.
(WebCore::createPositionOptions): Added. Creates the PositionOptions object, setting defaults where required.
(WebCore::JSGeolocation::getCurrentPosition): Modified. Now uses above helper functions.
(WebCore::JSGeolocation::watchPosition): Modified. Now uses above helper functions.
* page/Geolocation.cpp:
(WebCore::Geolocation::GeoNotifier::GeoNotifier): Modified. Asserts that PositionOptions object is present.
(WebCore::Geolocation::GeoNotifier::startTimer): Modified. Only starts timer if timeout has been set.
* page/PositionOptions.h:
(WebCore::PositionOptions::create): Modified. Creates object with default values.
(WebCore::PositionOptions::timeout): Modified. Uses correct type.
(WebCore::PositionOptions::hasTimeout): Added. Determines whether a timeout has been set.
(WebCore::PositionOptions::setTimeout): Modified. Uses correct type.
(WebCore::PositionOptions::maximumAge): Modified. Uses correct type.
(WebCore::PositionOptions::setMaximumAge): Modified. Uses correct type.
(WebCore::PositionOptions::PositionOptions): Modified. Creates object with default values.

LayoutTests: Geolocation PositionOptions does not use correct default values.
https://bugs.webkit.org/show_bug.cgi?id=27254

Patch by Steve Block <steveblock@google.com> on 2009-08-13
Reviewed by Darin Adler.

Adds a layout test to check the acceptable types for arguments to Geolocation methods.

* fast/dom/Geolocation/resources/argument-types.js: Added. Tests the types of the arguments that can be passed to Geolocation methods.
* fast/dom/Geolocation/argument-types.html: Added. HTML wrapper for above JS test.
* fast/dom/Geolocation/argument-types-expected.txt: Added. Expected output for above test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-08-13 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 13 Aug 2009 23:31:38 +0000 (23:31 +0000)]
2009-08-13  Eric Seidel  <eric@webkit.org>

        Rubber-stamped by Mark Rowe.

        wrong font size when css font-family includes monospace
        https://bugs.webkit.org/show_bug.cgi?id=19161

        Removing results which are expected to change, but that I have no way to update.

        * platform/mac-tiger/fast/text/monospace-width-cache-expected.checksum: Removed.
        * platform/mac-tiger/fast/text/monospace-width-cache-expected.png: Removed.
        * platform/qt/fast/text/monospace-width-cache-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-08-13 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 13 Aug 2009 23:28:53 +0000 (23:28 +0000)]
2009-08-13  Eric Seidel  <eric@webkit.org>

        No review, it is expected that this would change.

        wrong font size when css font-family includes monospace
        https://bugs.webkit.org/show_bug.cgi?id=19161

        Update Tiger results from the bot.  I have no way to update the pixel results.

        * platform/mac-tiger/fast/text/monospace-width-cache-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-08-13 David Levin <levin@chromium.org>
levin@chromium.org [Thu, 13 Aug 2009 23:24:23 +0000 (23:24 +0000)]
2009-08-13  David Levin  <levin@chromium.org>

        Unreviewed chromium build fix.

        [Chromium] Let CodeGeneratorV8.pm know that RGBColor is ref-counted.

        * bindings/scripts/CodeGeneratorV8.pm:

* bindings/scripts/CodeGeneratorV8.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-08-13 Drew Wilson <atwilson@google.com>
eric@webkit.org [Thu, 13 Aug 2009 22:55:51 +0000 (22:55 +0000)]
2009-08-13  Drew Wilson  <atwilson@google.com>

        Reviewed by David Levin.

        Merge error in SharedWorker code
        https://bugs.webkit.org/show_bug.cgi?id=28277

        Fixed merge error that prevents WebKit from compiling with SHARED_WORKERS enabled.
        No new tests needed.

        * workers/DefaultSharedWorkerRepository.cpp:
        Removed duplicated functions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoChromium: Show a "Playback Disabled" button on media error.
ajwong@chromium.org [Thu, 13 Aug 2009 22:48:25 +0000 (22:48 +0000)]
Chromium: Show a "Playback Disabled" button on media error.
https://bugs.webkit.org/show_bug.cgi?id=28196
Use a disabled play button when the media file cannot be played.

Patch by Kyle Prete <kylep@chromium.org> on 2009-08-13
Reviewed by Dave Levin.

No new tests needed. Covered by LayoutTests/media/video-empty-source.html

* rendering/RenderThemeChromiumSkia.cpp:
(WebCore::RenderThemeChromiumSkia::paintMediaPlayButton):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoTry some more to fix the Windows build.
mrowe@apple.com [Thu, 13 Aug 2009 22:46:06 +0000 (22:46 +0000)]
Try some more to fix the Windows build.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Export a new symbol.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-08-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Thu, 13 Aug 2009 22:45:31 +0000 (22:45 +0000)]
2009-08-13  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Unreviewed build fix. Include stdio.h for using stdout, stderr,
        and fprintf.

        * DumpRenderTree/LayoutTestController.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoTry and fix the Qt build.
mrowe@apple.com [Thu, 13 Aug 2009 22:42:53 +0000 (22:42 +0000)]
Try and fix the Qt build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-08-13 Zan Dobersek <zandobersek@gmail.com>
eric@webkit.org [Thu, 13 Aug 2009 22:38:12 +0000 (22:38 +0000)]
2009-08-13  Zan Dobersek  <zandobersek@gmail.com>

        Reviewed by Gustavo Noronha.

        [GTK] Drag and drop support
        https://bugs.webkit.org/show_bug.cgi?id=23642

        Adds support for drag actions in WebKitWebView and DragClient.

        Defines a support structure that can hold additional drag and drop data,
        such as selection data or target IDs (infos) and can be passed through
        clipboard requests.

        Implements DragClient functions that gather start position of the drag
        and start the GTK drag.

        * WebCoreSupport/DragClientGtk.cpp:
        (WebKit::DragClient::DragClient):
        (WebKit::DragClient::willPerformDragSourceAction):
        (WebKit::DragClient::startDrag):
        (WebKit::DragClient::createDragImageForLink): A small style fix.
        * WebCoreSupport/DragClientGtk.h:
        * webkit/webkitwebview.cpp:
        (webkit_web_view_drag_end):
        (clipboard_contents_received): GtkClipboard callback.
        (webkit_web_view_drag_data_get):
        (webkit_web_view_class_init):
        (webkit_web_view_init):
        * webkit/webkitwebview.h: Add GTK selection targets.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoTry and fix the Windows build.
mrowe@apple.com [Thu, 13 Aug 2009 22:38:05 +0000 (22:38 +0000)]
Try and fix the Windows build.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Export a new symbol.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-08-13 Zan Dobersek <zandobersek@gmail.com>
eric@webkit.org [Thu, 13 Aug 2009 22:31:23 +0000 (22:31 +0000)]
2009-08-13  Zan Dobersek  <zandobersek@gmail.com>

        Reviewed by Gustavo Noronha.

        [GTK] Drag and drop support
        https://bugs.webkit.org/show_bug.cgi?id=23642

        Utilizes functions that are being called upon drag and drop actions.
        Uses different GTK clipboards that hold different types
        of drag data - images, HTML markup, text, URL, URL label.
        Also clears each clipboard before setting new data to it.

        No new tests - despite some implementations, no new functionality
        is added until implementations of the GTK drag and drop protocol
        in WebKit part.

        * platform/gtk/ClipboardGtk.cpp:
        (WebCore::ClipboardGtk::ClipboardGtk):
        (WebCore::ClipboardGtk::~ClipboardGtk):
        (WebCore::getCachedImage):
        (WebCore::ClipboardGtk::declareAndWriteDragImage):
        (WebCore::ClipboardGtk::writeURL):
        (WebCore::ClipboardGtk::writeRange):
        * platform/gtk/ClipboardGtk.h: ClipboardGdk -> ClipboardGtk

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoRoll out r47237 as it was mistakenly landed.
mrowe@apple.com [Thu, 13 Aug 2009 22:27:53 +0000 (22:27 +0000)]
Roll out r47237 as it was mistakenly landed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBuild fix so JavaScriptCore builds, might fail linking WebCore or WebKit. Added inclu...
bweinstein@apple.com [Thu, 13 Aug 2009 22:22:50 +0000 (22:22 +0000)]
Build fix so JavaScriptCore builds, might fail linking WebCore or WebKit. Added includes and removed a missing function from JavaScriptCore_debug.def and JavascriptCore.def.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-08-13 Shinichiro Hamaji <hamaji@chromium.org>
eric@webkit.org [Thu, 13 Aug 2009 22:22:45 +0000 (22:22 +0000)]
2009-08-13  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Eric Seidel.

        rename make-js-test-wrappers to make-script-test-wrappers
        https://bugs.webkit.org/show_bug.cgi?id=28212

        * Scripts/make-script-test-wrappers: Renamed from WebKitTools/Scripts/make-js-test-wrappers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoDRT improvements for Database stuff.
bweinstein@apple.com [Thu, 13 Aug 2009 22:17:14 +0000 (22:17 +0000)]
DRT improvements for Database stuff.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore: JavaScriptCore tweaks to get ready for the parser arena
darin@apple.com [Thu, 13 Aug 2009 21:51:50 +0000 (21:51 +0000)]
JavaScriptCore: JavaScriptCore tweaks to get ready for the parser arena
https://bugs.webkit.org/show_bug.cgi?id=28243

Patch by Darin Adler <darin@apple.com> on 2009-08-13
Reviewed by David Levin.

Eliminate dependencies on Nodes.h outside JavaScriptCore,
and cut down on them inside JavaScriptCore.

Change regular expression parsing to use identifiers as
with other strings we parse.

Fix a couple things that are needed to use const Identifier
more, which will be part of the parser arena work.

* JavaScriptCore.exp: Resorted and updated.

* JavaScriptCore.xcodeproj/project.pbxproj: Changed
CollectorHeapIterator.h to be project-internal.

* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitPushNewScope): Added const.
* bytecompiler/BytecodeGenerator.h: Ditto.

* debugger/Debugger.cpp:
(JSC::Debugger::recompileAllJSFunctions): Moved this function
here from WebCore. Here is better since it uses so many internals.
Removed unimportant optimization for the no listener case.
* debugger/Debugger.h: Ditto. Also removed unneeded include
and tweaked formatting and comments.

* debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::functionName): Call asFunction instead
of doing the unchecked static_cast.
(JSC::DebuggerCallFrame::calculatedFunctionName): Ditto.

* jit/JITStubs.cpp:
(JSC::op_call_JSFunction): Call isHostFunction on the body rather
than on the JSFunction.
(JSC::vm_lazyLinkCall): Ditto.
(JSC::op_construct_JSConstruct): Ditto.

* parser/Grammar.y: Changed callers to use new scanRegExp with
out arguments instead of relying on state in the Lexer. And
callers that just want to skip a regular expression to use
skipRegExp.

* parser/Lexer.cpp:
(JSC::Lexer::scanRegExp): Changed to use out arguments, and to
add a prefix argument so we can add in the "=" character as needed.
Also rewrote to streamline the logic a bit inspired by suggestions
by David Levin.
(JSC::Lexer::skipRegExp): Added. Version of the function above that
does not actually put the regular expression into a string.
(JSC::Lexer::clear): Removed code to clear m_pattern and m_flags.
* parser/Lexer.h: Changed scanRegExp to have out arguments. Added
skipRegExp. Eliminated pattern, flags, m_pattern, and m_flags.

* parser/NodeConstructors.h:
(JSC::RegExpNode::RegExpNode): Changed to take const Identifier&.
* parser/Nodes.cpp:
(JSC::RegExpNode::emitBytecode): Changed since m_pattern and
m_flags are now Identifier instead of UString.
(JSC::FunctionBodyNode::make): Moved this function here instead
of putting it in the JSFunction.h header.
* parser/Nodes.h: Changed RegExpNode to use Identifier.

* profiler/Profiler.cpp:
(JSC::Profiler::createCallIdentifier): Changed to use isHostFunction
on the body instead of on the JSFunction object.
* runtime/FunctionPrototype.cpp:
(JSC::functionProtoFuncToString): Ditto.

* runtime/JSFunction.cpp:
(JSC::JSFunction::isHostFunction): Moved here from header.
(JSC::JSFunction::isHostFunctionNonInline): Added.
(JSC::JSFunction::JSFunction): Removed unneeded initialization of
m_body to 0.
(JSC::JSFunction::setBody): Moved here from header.

* runtime/JSFunction.h: Removed unneeded includes. Moved private
constructor down to the private section. Made virtual functions
private. Removed unneeded overload of setBody and moved the body
of the function into the .cpp file. Changed assertions to use
the non-inline version of isHostFunction.

* runtime/PropertySlot.cpp:
(JSC::PropertySlot::functionGetter): Use asFunction instead
of doing the unchecked static_cast.

* wtf/SegmentedVector.h:
(WTF::SegmentedVector::isEmpty): Added.

WebCore: JavaScriptCore tweaks to get ready for the parser arena
https://bugs.webkit.org/show_bug.cgi?id=28243

Patch by Darin Adler <darin@apple.com> on 2009-08-13
Reviewed by David Levin.

* ForwardingHeaders/runtime/CollectorHeapIterator.h: Removed.

* WebCore.xcodeproj/project.pbxproj: Exposed a couple header
files as Private that are now needed to compile Mac WebKit.

* bindings/js/JSAudioConstructor.cpp:
* bindings/js/JSDOMBinding.cpp:
* bindings/js/JSDOMBinding.h:
* bindings/js/JSDOMWindowCustom.cpp:
* bindings/js/JSHTMLInputElementCustom.cpp:
* bindings/js/JSHistoryCustom.cpp:
* bindings/js/JSImageConstructor.cpp:
* bindings/js/JSLazyEventListener.cpp:
* bindings/js/JSLocationCustom.cpp:
* bindings/js/JSMessageChannelConstructor.cpp:
* bindings/js/JSOptionConstructor.cpp:
* bindings/js/JSWebSocketConstructor.cpp:
* bindings/js/JSWebSocketCustom.cpp:
* bindings/js/JSWorkerConstructor.cpp:
* bindings/js/JSXMLHttpRequestConstructor.cpp:
* bridge/jni/jni_jsobject.mm:
Updated includes.

* inspector/JavaScriptDebugServer.cpp:
(WebCore::JavaScriptDebugServer::sourceParsed):
Change to not assert if this is called with no listeners.
I don't think this was guaranteed before, and we now use
this code path when recompiling. Slightly less efficient,
but this is a one-time cost when turning on the debugger.
(WebCore::JavaScriptDebugServer::recompileAllJSFunctions):
Change to call Debugger::recompileAllJSFunctions.

WebKit/mac: * Plugins/Hosted/NetscapePluginInstanceProxy.mm: Updated includes.
* WebView/WebScriptDebugger.mm: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-08-13 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 13 Aug 2009 21:38:54 +0000 (21:38 +0000)]
2009-08-13  Eric Seidel  <eric@webkit.org>

        Rubber-stamped by Adam Roben.

        REGRESSION: 6 media tests regressed while the windows bot was broken
        https://bugs.webkit.org/show_bug.cgi?id=28281

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUnreviewed.
atwilson@chromium.org [Thu, 13 Aug 2009 21:36:12 +0000 (21:36 +0000)]
Unreviewed.

Patch by Drew Wilson <atwilson@chromium.org> on 2009-08-13
Add myself to list of committers.

* Scripts/modules/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore: <rdar://problem/7138591> and https://bugs.webkit.org/show_bug.cgi?id=28260
beidson@apple.com [Thu, 13 Aug 2009 21:35:30 +0000 (21:35 +0000)]
WebCore: <rdar://problem/7138591> and https://bugs.webkit.org/show_bug.cgi?id=28260
onhashchange property cannot be set from javascript.

Reviewed by Eric Seidel.

Test: fast/loader/onhashchange-attribute-listeners.html

* html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::onhashchange):
(WebCore::HTMLBodyElement::setOnhashchange):
* html/HTMLBodyElement.h:
* html/HTMLBodyElement.idl:

* html/HTMLFrameSetElement.cpp:
(WebCore::HTMLFrameSetElement::onhashchange):
(WebCore::HTMLFrameSetElement::setOnhashchange):
* html/HTMLFrameSetElement.h:
* html/HTMLFrameSetElement.idl:

* page/DOMWindow.cpp:
(WebCore::DOMWindow::onhashchange):
(WebCore::DOMWindow::setOnhashchange):
* page/DOMWindow.h:
* page/DOMWindow.idl:

LayoutTests: <rdar://problem/7138591> and https://bugs.webkit.org/show_bug.cgi?id=28260
onhashchange property cannot be set from javascript.

Reviewed by Eric Seidel.

* fast/dom/Window/window-properties-expected.txt:
* fast/loader/onhashchange-attribute-listeners-expected.txt: Added.
* fast/loader/onhashchange-attribute-listeners.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix leaks of RGBColor instances from below SVGColor::rgbColor.
mrowe@apple.com [Thu, 13 Aug 2009 21:27:03 +0000 (21:27 +0000)]
Fix leaks of RGBColor instances from below SVGColor::rgbColor.

Reviewed by Geoff Garen.

* svg/SVGColor.cpp:
(WebCore::SVGColor::rgbColor): Return a PassRefPtr to ensure that the newly-allocated
RGBColor is cleaned up by the caller.
* svg/SVGColor.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-08-13 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 13 Aug 2009 21:12:29 +0000 (21:12 +0000)]
2009-08-13  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        WebInspector: Migrate to DOMAgent (serialized access to DOM).

        https://bugs.webkit.org/show_bug.cgi?id=28177

        * bindings/js/JSInspectorBackendCustom.cpp:
        (WebCore::JSInspectorBackend::highlightDOMNode):
        (WebCore::JSInspectorBackend::nodeForId):
        (WebCore::JSInspectorBackend::idForNode):
        (WebCore::JSInspectorBackend::wrapObject):
        (WebCore::JSInspectorBackend::unwrapObject):
        (WebCore::JSInspectorBackend::pushNodePathToFrontend):
        (WebCore::JSInspectorBackend::selectDatabase):
        (WebCore::JSInspectorBackend::selectDOMStorage):
        * bindings/js/ScriptObjectQuarantine.cpp:
        (WebCore::getQuarantinedScriptObject):
        * bindings/js/ScriptObjectQuarantine.h:
        * bindings/js/ScriptValue.cpp:
        (WebCore::ScriptValue::isObject):
        * bindings/js/ScriptValue.h:
        * bindings/v8/ScriptObjectQuarantine.cpp:
        (WebCore::getQuarantinedScriptObject):
        * bindings/v8/ScriptObjectQuarantine.h:
        * bindings/v8/ScriptValue.h:
        (WebCore::ScriptValue::isObject):
        * bindings/v8/custom/V8CustomBinding.h:
        * bindings/v8/custom/V8InspectorBackendCustom.cpp:
        (WebCore::CALLBACK_FUNC_DECL):
        * inspector/ConsoleMessage.cpp:
        (WebCore::ConsoleMessage::ConsoleMessage):
        * inspector/ConsoleMessage.h:
        * inspector/InspectorBackend.cpp:
        (WebCore::InspectorBackend::clearMessages):
        (WebCore::InspectorBackend::loaded):
        (WebCore::InspectorBackend::highlight):
        (WebCore::InspectorBackend::nodeForId):
        (WebCore::InspectorBackend::idForNode):
        (WebCore::InspectorBackend::wrapObject):
        (WebCore::InspectorBackend::unwrapObject):
        (WebCore::InspectorBackend::pushNodePathToFrontend):
        (WebCore::InspectorBackend::addNodesToSearchResult):
        (WebCore::InspectorBackend::selectDatabase):
        (WebCore::InspectorBackend::selectDOMStorage):
        * inspector/InspectorBackend.h:
        * inspector/InspectorBackend.idl:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::InspectorController):
        (WebCore::InspectorController::focusNode):
        (WebCore::InspectorController::addMessageToConsole):
        (WebCore::InspectorController::clearConsoleMessages):
        (WebCore::InspectorController::startGroup):
        (WebCore::InspectorController::scriptObjectReady):
        (WebCore::InspectorController::setFrontendProxyObject):
        (WebCore::InspectorController::close):
        (WebCore::InspectorController::didCommitLoad):
        (WebCore::InspectorController::wrapObject):
        (WebCore::InspectorController::unwrapObject):
        * inspector/InspectorController.h:
        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::setDocument):
        (WebCore::InspectorDOMAgent::handleEvent):
        (WebCore::InspectorDOMAgent::pushDocumentToFrontend):
        (WebCore::InspectorDOMAgent::pushChildNodesToFrontend):
        (WebCore::InspectorDOMAgent::nodeForId):
        (WebCore::InspectorDOMAgent::pushNodePathToFrontend):
        (WebCore::InspectorDOMAgent::buildObjectForNode):
        (WebCore::InspectorDOMAgent::buildArrayForContainerChildren):
        (WebCore::InspectorDOMAgent::innerParentElement):
        * inspector/InspectorDOMAgent.h:
        * inspector/InspectorDOMStorageResource.cpp:
        (WebCore::InspectorDOMStorageResource::bind):
        * inspector/InspectorFrontend.cpp:
        (WebCore::InspectorFrontend::clearConsoleMessages):
        (WebCore::InspectorFrontend::updateFocusedNode):
        (WebCore::InspectorFrontend::setDocument):
        (WebCore::InspectorFrontend::selectDatabase):
        (WebCore::InspectorFrontend::selectDOMStorage):
        (WebCore::InspectorFrontend::addNodesToSearchResult):
        * inspector/InspectorFrontend.h:
        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView.prototype.clearMessages):
        (WebInspector.ConsoleView.prototype.completions):
        (WebInspector.ConsoleView.prototype._reportCompletions):
        (WebInspector.ConsoleView.prototype._messagesClicked):
        (WebInspector.ConsoleView.prototype.doEvalInWindow.evalCallback):
        (WebInspector.ConsoleView.prototype.doEvalInWindow):
        (WebInspector.ConsoleView.prototype._format):
        (WebInspector.ConsoleView.prototype._formatfunction):
        (WebInspector.ConsoleView.prototype._formatdate):
        (WebInspector.ConsoleView.prototype._formatregexp):
        (WebInspector.ConsoleView.prototype._formatnode):
        (WebInspector.ConsoleView.prototype._formatobject):
        * inspector/front-end/DOMAgent.js:
        (WebInspector.DOMNode):
        (WebInspector.DOMNode.prototype._renumber):
        (WebInspector.DOMDocument):
        (WebInspector.DOMAgent):
        (WebInspector.DOMAgent.prototype.getChildNodesAsync):
        (WebInspector.DOMAgent.prototype.setAttributeAsync):
        (WebInspector.DOMAgent.prototype.removeAttributeAsync):
        (WebInspector.DOMAgent.prototype.setTextNodeValueAsync):
        (WebInspector.DOMAgent.prototype.nodeForId):
        (WebInspector.DOMAgent.prototype._setDocument):
        (WebInspector.DOMAgent.prototype._setChildNodes):
        (WebInspector.DOMAgent.prototype._bindNodes):
        (WebInspector.DOMAgent.prototype._childNodeInserted):
        (WebInspector.CSSStyleDeclaration):
        (WebInspector.CSSStyleDeclaration.parseRule):
        (WebInspector.setDocument):
        (InspectorController.getStyles):
        (InspectorController.getComputedStyle):
        (InspectorController.getInlineStyle):
        (InspectorController.applyStyleText):
        (InspectorController.setStyleText):
        (InspectorController.toggleStyleEnabled):
        (InspectorController.applyStyleRuleText):
        (InspectorController.addStyleSelector):
        (InspectorController.setStyleProperty):
        (InspectorController.getPrototypes):
        (InspectorController.getProperties):
        (InspectorController.setPropertyValue):
        (InspectorController.evaluate):
        (InspectorController.addInspectedNode):
        (InspectorController.performSearch):
        (InspectorController.searchCanceled):
        * inspector/front-end/ElementsPanel.js:
        (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged):
        (WebInspector.ElementsPanel.prototype.searchCanceled):
        (WebInspector.ElementsPanel.prototype.performSearch):
        (WebInspector.ElementsPanel.prototype._updateMatchesCount):
        (WebInspector.ElementsPanel.prototype._updateMatchesCountSoon):
        (WebInspector.ElementsPanel.prototype.addNodesToSearchResult):
        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeOutline.prototype.set focusedDOMNode.restoreHighlightToHoveredNode):
        (WebInspector.ElementsTreeOutline.prototype.set focusedDOMNode):
        (WebInspector.ElementsTreeElement.prototype.updateChildren):
        (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted):
        * inspector/front-end/InjectedScript.js:
        (InjectedScript.applyStyleRuleText):
        (InjectedScript.addStyleSelector):
        (InjectedScript._doesSelectorAffectNode):
        (InjectedScript._serializeRule):
        (InjectedScript._serializeStyle):
        (InjectedScript.getProperties):
        (InjectedScript.evaluate):
        (InjectedScript.addInspectedNode):
        (InjectedScript.performSearch.addNodesToResults):
        (InjectedScript.performSearch.matchExactItems):
        (InjectedScript.performSearch.matchExactId.addNodesToResults.call):
        (InjectedScript.performSearch.matchExactId):
        (InjectedScript.performSearch):
        (InjectedScript.performSearch.matchExactTagNames):
        (InjectedScript.performSearch.matchExactAttributeNames):
        (InjectedScript.performSearch.matchPartialTagNames):
        (InjectedScript.performSearch.matchStartOfTagNames):
        (InjectedScript.performSearch.matchPartialTagNamesAndAttributeValues):
        (InjectedScript.performSearch.matchPartialAttributeValues):
        (InjectedScript.performSearch.matchStyleSelector):
        (InjectedScript.performSearch.matchPlainText):
        (InjectedScript.performSearch.matchXPathQuery):
        (InjectedScript.performSearch.finishedSearching):
        (InjectedScript.performSearch.processChunk):
        (InjectedScript.searchCanceled):
        (InjectedScript._ensureCommandLineAPIInstalled.inspectObject):
        (InjectedScript._ensureCommandLineAPIInstalled):
        (InjectedScript._resolveObject):
        (InjectedScript._nodeForId):
        (InjectedScript._objectForId):
        (InjectedScript._createProxyObject):
        * inspector/front-end/ObjectPropertiesSection.js:
        (WebInspector.ObjectPropertyTreeElement.prototype.onpopulate):
        (WebInspector.ObjectPropertyTreeElement.prototype.update):
        * inspector/front-end/ObjectProxy.js:
        (WebInspector.ObjectProxy):
        (WebInspector.ObjectPropertyProxy):
        * inspector/front-end/PropertiesSidebarPane.js:
        (WebInspector.PropertiesSidebarPane.prototype.update.callback):
        (WebInspector.PropertiesSidebarPane.prototype.update):
        * inspector/front-end/StylesSidebarPane.js:
        (WebInspector.StylesSidebarPane.prototype.update.callback):
        (WebInspector.StylesSidebarPane.prototype.update):
        (WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted):
        (WebInspector.StylePropertiesSection.prototype.editingSelectorCancelled):
        (WebInspector.BlankStylePropertiesSection.prototype.editingCommitted.callback):
        (WebInspector.BlankStylePropertiesSection.prototype.editingCommitted):
        (WebInspector.StylePropertyTreeElement.prototype):
        * inspector/front-end/inspector.js:
        (WebInspector._updateHoverHighlight):
        (WebInspector.loaded):
        (WebInspector.clearConsoleMessages):
        (WebInspector.selectDatabase):
        (WebInspector.selectDOMStorage):
        (WebInspector.updateFocusedNode):
        (WebInspector.addNodesToSearchResult):
        * inspector/front-end/utilities.js:
        (Object.proxyType):
        * storage/Storage.h:
        (WebCore::Storage::frame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix leaks of RGBColor instances from below CSSPrimitiveValue::getRGBColorValue.
mrowe@apple.com [Thu, 13 Aug 2009 20:57:43 +0000 (20:57 +0000)]
Fix leaks of RGBColor instances from below CSSPrimitiveValue::getRGBColorValue.

Reviewed by Geoff Garen.

* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::getRGBColorValue): Return a PassRefPtr to ensure that the
newly-allocated RGBColor is cleaned up by the caller.
* css/CSSPrimitiveValue.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-08-13 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 13 Aug 2009 20:56:46 +0000 (20:56 +0000)]
2009-08-13  Eric Seidel  <eric@webkit.org>

        Reviewed by David Hyatt.

        wrong font size when css font-family includes monospace
        https://bugs.webkit.org/show_bug.cgi?id=19161

        Update test results now that only "font-family: monospace" is 13px.
        All other combinations of font-family are 16px default size.

        Add two tests:
        font-family-fallback-reset: catches a bug in inheriting font-family fallback.
        computed-style-font-family-monospace: tests this bug, that only "font-family: monospace" is 13px.

        * fast/css/getComputedStyle/computed-style-font-family-expected.txt:
        * fast/css/getComputedStyle/computed-style-font-family-monospace-expected.txt: Added.
        * fast/css/getComputedStyle/computed-style-font-family-monospace.html: Added.
        * fast/css/getComputedStyle/font-family-fallback-reset-expected.txt: Added.
        * fast/css/getComputedStyle/font-family-fallback-reset.html: Added.
        * fast/css/getComputedStyle/resources/computed-style-font-family-monospace.js: Added.
        (fontSizeForFamilies):
        * fast/css/getComputedStyle/resources/font-family-fallback-reset.js: Added.
        * fast/js/method-check.html:
        * platform/mac/css1/font_properties/font_family-expected.txt:
        * platform/mac/css2.1/t1503-c522-font-family-00-b-expected.txt:
        * platform/mac/fast/text/monospace-width-cache-expected.txt:

2009-08-13  Eric Seidel  <eric@webkit.org>

        Reviewed by David Hyatt.

        wrong font size when css font-family includes monospace
        https://bugs.webkit.org/show_bug.cgi?id=19161

        Firefox only uses fixed-width default size for exactly "font-family: monospace;".
        WebKit has historically used fixed-width default size any time a
        font-family includes monospace in the fallback list.

        This patch corrects WebKit's behavior to match Firefox.
        I also had to fix a bug in WebKit's font-family fallback behavior where
        child elements would inherit parts of their parents fallback lists.

        This patch is mostly just replacing all cases where we used to check for:
        fontDescription.genericFontFamily() == MonospaceFamily
        with:
        fontDescription.useFixedDefaultSize()

        Tests: fast/css/getComputedStyle/computed-style-font-family-monospace.html
               fast/css/getComputedStyle/font-family-fallback-reset.html

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):
           Deploy useFixedDefaultSize().  Also fix the bug where child
           FontDescriptions would carry part of the parent font-family fallback list.
        (WebCore::CSSStyleSelector::checkForGenericFamilyChange):
           It's no longer alright to just check genericFontFamily(),
           we have to check to make sure the changed style has a matching useFixedDefaultSize().
        * platform/graphics/FontDescription.h:
        (WebCore::FontDescription::useFixedDefaultSize):
           Only use the fixed default size if we have one font family and it is "monospace".
           "-webkit-monospace" is the internal representation of the CSS identifier "monospace".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUnreviewed.
sullivan@apple.com [Thu, 13 Aug 2009 20:48:44 +0000 (20:48 +0000)]
Unreviewed.

Add myself to list of committers.

* Scripts/modules/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-08-13 Christian Plesner Hansen <christian.plesner.hansen@gmail.com>
eric@webkit.org [Thu, 13 Aug 2009 20:18:04 +0000 (20:18 +0000)]
2009-08-13  Christian Plesner Hansen  <christian.plesner.hansen@gmail.com>

        Reviewed by Dimitri Glazkov.

        [v8] Fix atomic string externalization crash.
        Atomic string externalization assumes that all non-empty strings
        can be externalized which is untrue on 64-bit.  This change fixed
        that.

        https://bugs.webkit.org/show_bug.cgi?id=28215

        This bug causes loads of test crashes, no need to add new tests
        specifically for this.

        * bindings/v8/V8Binding.cpp:
        (WebCore::v8StringToAtomicWebCoreString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoDoc - Some cleanup on the documentation of QWebElement
hausmann@webkit.org [Thu, 13 Aug 2009 19:49:40 +0000 (19:49 +0000)]
Doc - Some cleanup on the documentation of QWebElement

Patch by Kavindra Devi Palaraja <kavindra.palaraja@nokia.com> on 2009-08-13
Reviewed by Simon Hausmann.

* Api/qwebelement.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUse the version of operator new that takes a JSGlobalData when allocating FuncDeclNod...
mrowe@apple.com [Thu, 13 Aug 2009 19:39:51 +0000 (19:39 +0000)]
Use the version of operator new that takes a JSGlobalData when allocating FuncDeclNode and FuncExprNode
from within the grammar to prevent these nodes from being leaked.

Rubber-stamped by Darin Adler.

* parser/Grammar.y:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-08-13 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 13 Aug 2009 19:01:59 +0000 (19:01 +0000)]
2009-08-13  Eric Seidel  <eric@webkit.org>

        Correct spelling error in file name.  No review.

        * Scripts/modules/committers_unittest.py: Renamed from WebKitTools/Scripts/modules/commiters_unittest.py.
        * Scripts/run-webkit-unittests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-08-13 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 13 Aug 2009 18:34:57 +0000 (18:34 +0000)]
2009-08-13  Eric Seidel  <eric@webkit.org>

        Reviewed by Simon Fraser.

        REGRESSION(r47175): error running run-webkit-tests
        https://bugs.webkit.org/show_bug.cgi?id=28261

        Fix "Use of uninitialized value in concatenation (.) or string at
        WebKitTools/Scripts/run-webkit-tests line 191." by setting
        $testsPerDumpTool to 1000 by default.

        * Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-08-13 George Staikos <george.staikos@torchmobile.com>
staikos@webkit.org [Thu, 13 Aug 2009 18:32:49 +0000 (18:32 +0000)]
2009-08-13  George Staikos  <george.staikos@torchmobile.com>

        Rubberstamped by Darin Adler.

        Use ASSERT_UNUSED instead of UNUSED_PARAM

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-08-13 Steve Block <steveblock@google.com>
eric@webkit.org [Thu, 13 Aug 2009 18:21:32 +0000 (18:21 +0000)]
2009-08-13  Steve Block  <steveblock@google.com>

        Reviewed by Darin Adler.

        Fixes a couple of bugs in SecurityOrigin::createFromDatabaseIdentifier.
        https://bugs.webkit.org/show_bug.cgi?id=28262

        No new tests possible.

        * page/SecurityOrigin.cpp:
        (WebCore::SecurityOrigin::createFromDatabaseIdentifier):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-08-13 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Thu, 13 Aug 2009 18:11:18 +0000 (18:11 +0000)]
2009-08-13  Nate Chapin  <japhet@chromium.org>

        Unreviewed.

        Add myself to list of committers.

        * Scripts/modules/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-08-13 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Thu, 13 Aug 2009 18:09:17 +0000 (18:09 +0000)]
2009-08-13  Daniel Bates  <dbates@webkit.org>

        Unreviewed.

        Added 'Daniel Bates' (myself) to the list of committers.

        * Scripts/modules/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUnreviewed.
bfulgham@webkit.org [Thu, 13 Aug 2009 18:06:06 +0000 (18:06 +0000)]
Unreviewed.

Add 'Brent Fulgham' to the committers list.

* Scripts/modules/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-08-13 Yong Li <yong.li@torchmobile.com>
yong.li@torchmobile.com [Thu, 13 Aug 2009 18:04:25 +0000 (18:04 +0000)]
2009-08-13 Yong Li <yong.li@torchmobile.com>

    Unreviewed.
    Added 'Yong Li' to the committers list.

    * Scripts/modules/committers.py

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-08-13 Adam Langley <agl@chromium.org>
agl@chromium.org [Thu, 13 Aug 2009 18:03:26 +0000 (18:03 +0000)]
2009-08-13  Adam Langley  <agl@chromium.org>

        Review not required.

        * Scripts/modules/committers.py:
          Adding myself to this list because Eric told me to.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUnreviewed.
bolsinga@apple.com [Thu, 13 Aug 2009 18:01:33 +0000 (18:01 +0000)]
Unreviewed.

Add 'Greg Bolsinga' to the committers list.

* Scripts/modules/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoRemove media/video-test.js's redundant hang timer
aroben@apple.com [Thu, 13 Aug 2009 17:59:30 +0000 (17:59 +0000)]
Remove media/video-test.js's redundant hang timer

DRT already has a timer that does the same thing.

Reviewed by Mark Rowe.

* media/video-test.js: Remove the hang timer, since DRT does the same
thing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix off-by-one result comparisons in media tests on Windows Debug builds
aroben@apple.com [Thu, 13 Aug 2009 17:58:55 +0000 (17:58 +0000)]
Fix off-by-one result comparisons in media tests on Windows Debug builds

media/video-played.html seems always to time out in Windows Debug
builds. A race condition between media/video-test.js's "hang" timer and
DumpRenderTree's built-in "watchdog" timer was causing results for
media/video-played.html to be printed twice, causing all future media
tests to be compared to the previous test's results.

The fix is to make the watchdog timer got through the same code path
as calling notifyDone manually, so that the results will only get
printed once. A subsequent patch will remove video-test.js's hang
timer entirely, since it is redundant.

Fixes <http://webkit.org/b/28265>.

Reviewed by Mark Rowe.

* DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::waitToDumpWatchdogTimerFired): Added. Code came
from Gtk/Mac/Win's watchdog timer handlers, but we now call
notifyDone() instead of dump() so that a subsequent call to
notifyDone() won't print the results out again.

* DumpRenderTree/LayoutTestController.h: Added
waitToDumpWatchdogTimerFired.

* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(waitToDumpWatchdogFired):
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(waitUntilDoneWatchdogFired):
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(waitUntilDoneWatchdogFired):
Changed to call waitToDumpWatchdogTimerFired.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Unreviewed.
eric.carlson@apple.com [Thu, 13 Aug 2009 17:55:24 +0000 (17:55 +0000)]
    Unreviewed.

        Added 'Eric Carlson' to the committers list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-08-13 Dirk Schulze <krit@webkit.org>
eric@webkit.org [Thu, 13 Aug 2009 17:52:26 +0000 (17:52 +0000)]
2009-08-13  Dirk Schulze  <krit@webkit.org>

        Reviewed by Eric Seidel.

        [CAIRO] getImageData fails on a given rect bigger than the image rect

        The destination image and the source image was mixed up on creating the
        imageData.

        This is just a clean up and doesn't affect the current behavior. It's not
        possible to test this failure in a LayoutTest. Only canvas uses getImageData
        at the moment and returns before calling getImageData, if the image rect does
        not contain the requested rect.

        * platform/graphics/cairo/ImageBufferCairo.cpp:
        (WebCore::getImageData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-08-13 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Thu, 13 Aug 2009 17:38:11 +0000 (17:38 +0000)]
2009-08-13  Dirk Schulze  <krit@webkit.org>

        Unreviewed.
        Added 'Dirk Schulze' to the committers list.

        * Scripts/modules/committers.py

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47210 268f45cc-cd09-0410-ab3c-d52691b4dbfc