WebKit-https.git
10 years agoRemove empty inline RenderStyle destructor.
kling@webkit.org [Sat, 24 Dec 2011 20:15:21 +0000 (20:15 +0000)]
Remove empty inline RenderStyle destructor.
<http://webkit.org/b/75188>

Rubber-stamped by Anders "Ordvits" Carlsson.

* rendering/style/RenderStyle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake build-webkit aware of additional Xcode build location defaults.
mitz@apple.com [Sat, 24 Dec 2011 19:30:08 +0000 (19:30 +0000)]
Make build-webkit aware of additional Xcode build location defaults.

Reviewed by Anders Carlsson.

* Scripts/webkitdirs.pm:
(determineXcodeVersion): Added. This was previously in determineBaseProductDir().
(readXcodeUserDefault): Added. Factored out from determineBaseProductDir().
(determineBaseProductDir): Changed to check for a custom build location
style specified as an absolute location.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r103619.
rniwa@webkit.org [Sat, 24 Dec 2011 19:26:09 +0000 (19:26 +0000)]
Unreviewed, rolling out r103619.
http://trac.webkit.org/changeset/103619
https://bugs.webkit.org/show_bug.cgi?id=66509

Broke chromium clang build

Source/WebKit/chromium:

* WebKit.gyp:
* public/WebCommonWorkerClient.h:
(WebKit::WebCommonWorkerClient::postConsoleMessageToWorkerObject):
(WebKit::WebCommonWorkerClient::allowFileSystem):
(WebKit::WebCommonWorkerClient::openFileSystem):
(WebKit::WebCommonWorkerClient::dispatchDevToolsMessage):
(WebKit::WebCommonWorkerClient::saveDevToolsAgentState):
(WebKit::WebCommonWorkerClient::~WebCommonWorkerClient):
* public/WebSharedWorker.h:
* public/WebSharedWorkerClient.h: Removed.
* public/WebWorkerClient.h:
(WebKit::WebWorkerClient::~WebWorkerClient):
* src/DatabaseObserver.cpp:
(WebKit::AllowDatabaseMainThreadBridge::create):
(WebKit::AllowDatabaseMainThreadBridge::AllowDatabaseMainThreadBridge):
(WebKit::AllowDatabaseMainThreadBridge::allowDatabaseTask):
(WebKit::allowDatabaseForWorker):
(WebCore::DatabaseObserver::canEstablishDatabase):
* src/IDBFactoryBackendProxy.cpp:
(WebKit::IDBFactoryBackendProxy::openFromWorker):
* src/LocalFileSystemChromium.cpp:
(WebCore::openFileSystemHelper):
* src/WebSharedWorkerImpl.cpp:
(WebKit::WebSharedWorkerImpl::WebSharedWorkerImpl):
(WebKit::WebSharedWorkerImpl::~WebSharedWorkerImpl):
(WebKit::WebSharedWorkerImpl::client):
(WebKit::WebSharedWorker::create):
* src/WebSharedWorkerImpl.h:
(WebKit::WebSharedWorkerImpl::commonClient):
(WebKit::WebSharedWorkerImpl::newCommonClient):
* src/WebWorkerBase.cpp:
(WebKit::initializeWebKitStaticValues):
(WebKit::WebWorkerBase::WebWorkerBase):
(WebKit::WebWorkerBase::~WebWorkerBase):
(WebKit::WebWorkerBase::stopWorkerThread):
(WebKit::WebWorkerBase::initializeLoader):
(WebKit::WebWorkerBase::dispatchTaskToMainThread):
(WebKit::WebWorkerBase::invokeTaskMethod):
(WebKit::WebWorkerBase::didCreateDataSource):
(WebKit::WebWorkerBase::createApplicationCacheHost):
(WebKit::WebWorkerBase::postMessageToWorkerObject):
(WebKit::WebWorkerBase::postMessageTask):
(WebKit::WebWorkerBase::postExceptionToWorkerObject):
(WebKit::WebWorkerBase::postExceptionTask):
(WebKit::WebWorkerBase::postConsoleMessageToWorkerObject):
(WebKit::WebWorkerBase::postConsoleMessageTask):
(WebKit::WebWorkerBase::postMessageToPageInspector):
(WebKit::WebWorkerBase::postMessageToPageInspectorTask):
(WebKit::WebWorkerBase::updateInspectorStateCookie):
(WebKit::WebWorkerBase::updateInspectorStateCookieTask):
(WebKit::WebWorkerBase::confirmMessageFromWorkerObject):
(WebKit::WebWorkerBase::confirmMessageTask):
(WebKit::WebWorkerBase::reportPendingActivity):
(WebKit::WebWorkerBase::reportPendingActivityTask):
(WebKit::WebWorkerBase::workerContextClosed):
(WebKit::WebWorkerBase::workerContextClosedTask):
(WebKit::WebWorkerBase::workerContextDestroyed):
(WebKit::WebWorkerBase::workerContextDestroyedTask):
(WebKit::WebWorkerBase::postTaskToLoader):
(WebKit::WebWorkerBase::postTaskForModeToWorkerContext):
* src/WebWorkerBase.h:
(WebKit::WebWorkerBase::view):
(WebKit::WebWorkerBase::setWorkerThread):
(WebKit::WebWorkerBase::workerThread):
* src/WebWorkerClientImpl.cpp:
* src/WebWorkerClientImpl.h:
(WebKit::WebWorkerClientImpl::newCommonClient):
* src/WebWorkerImpl.cpp: Added.
(WebKit::WebWorker::create):
(WebKit::WebWorkerImpl::WebWorkerImpl):
(WebKit::WebWorkerImpl::~WebWorkerImpl):
(WebKit::WebWorkerImpl::newCommonClient):
(WebKit::WebWorkerImpl::commonClient):
(WebKit::WebWorkerImpl::postMessageToWorkerContextTask):
(WebKit::WebWorkerImpl::startWorkerContext):
(WebKit::WebWorkerImpl::terminateWorkerContext):
(WebKit::WebWorkerImpl::postMessageToWorkerContext):
(WebKit::WebWorkerImpl::workerObjectDestroyed):
(WebKit::WebWorkerImpl::clientDestroyed):
* src/WebWorkerImpl.h: Copied from Source/WebKit/chromium/src/WebWorkerBase.cpp.
(WebKit::WebWorkerImpl::client):
* src/WorkerFileSystemCallbacksBridge.cpp:
(WebKit::WorkerFileSystemCallbacksBridge::postOpenFileSystemToMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::openFileSystemOnMainThread):
* src/WorkerFileSystemCallbacksBridge.h:

Tools:

* DumpRenderTree/chromium/TestWebWorker.h:
(TestWebWorker::createWorker):
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::createWorker):
* DumpRenderTree/chromium/WebViewHost.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChromium CG Mac rebaseline after r103651.
rniwa@webkit.org [Sat, 24 Dec 2011 18:53:18 +0000 (18:53 +0000)]
Chromium CG Mac rebaseline after r103651.

* platform/chromium-cg-mac-snowleopard/fast/images/ycbcr-with-cmyk-color-profile-expected.png: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRenderStyle: Inline the destructor.
kling@webkit.org [Sat, 24 Dec 2011 18:32:08 +0000 (18:32 +0000)]
RenderStyle: Inline the destructor.
<http://webkit.org/b/75188>

Reviewed by Kenneth Rohde Christiansen.

The (empty) RenderStyle destructor gets a little hot sometimes, reaching up
to 0.4% when loading the full HTML5 spec. Inline it to remove the pointless
function call.

* rendering/style/RenderStyle.cpp:
* rendering/style/RenderStyle.h:
(WebCore::RenderStyleBitfields::~RenderStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed test result gardening.
jarred@sencha.com [Sat, 24 Dec 2011 15:52:16 +0000 (15:52 +0000)]
Unreviewed test result gardening.

* platform/chromium/fast/xmlhttprequest/xmlhttprequest-responsetype-arraybuffer-expected.txt: Removed.
Identical to the expected result shared by all ports.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAnother rebaseline for font-weight-bold-for-b-and-strong.html.
rniwa@webkit.org [Sat, 24 Dec 2011 09:07:24 +0000 (09:07 +0000)]
Another rebaseline for font-weight-bold-for-b-and-strong.html.
Also revert a part of r103645.

* platform/chromium-linux-x86/fast/html: Removed.
* platform/chromium-linux/fast/html/font-weight-bold-for-b-and-strong-expected.png: Added.
* platform/chromium/fast/html: Removed.
* platform/chromium/fast/html/font-weight-bold-for-b-and-strong-expected.txt: Removed.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd image test expectation for fast/images/ycbcr-with-cmyk-color-profile.html on...
rniwa@webkit.org [Sat, 24 Dec 2011 07:06:16 +0000 (07:06 +0000)]
Add image test expectation for fast/images/ycbcr-with-cmyk-color-profile.html on Chromium.
The test started failing since r103651.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChromium Mac build fix.
rniwa@webkit.org [Sat, 24 Dec 2011 06:12:35 +0000 (06:12 +0000)]
Chromium Mac build fix.

* WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoJPEG decoders should only save color profile markers if color management is enabled
noel.gordon@gmail.com [Sat, 24 Dec 2011 05:45:33 +0000 (05:45 +0000)]
JPEG decoders should only save color profile markers if color management is enabled
https://bugs.webkit.org/show_bug.cgi?id=75182

Reviewed by Adam Barth.

No new tests. Covered by existing tests.
    fast/images/ycbcr-with-cmyk-color-profile.html
    fast/images/gray-scale-jpeg-with-color-profile.html
    fast/images/cmyk-jpeg-with-color-profile.html
    fast/images/color-jpeg-with-color-profile.html

* platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
(WebCore::JPEGImageReader::JPEGImageReader):  Store color profile (JPEG_APP0 + 2) markers
using the iccjpeg helper setup_read_icc_profile() if color management is enabled.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix crash when adding paragraph in contenteditable with role=textbox.
aboxhall@chromium.org [Sat, 24 Dec 2011 05:41:56 +0000 (05:41 +0000)]
Fix crash when adding paragraph in contenteditable with role=textbox.
https://bugs.webkit.org/show_bug.cgi?id=75159

Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: accessibility/textbox-role-on-contenteditable-crash.html

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::childrenChanged): Use rendererIsEditable() rather than isContentEditable()
as this method is called during render layouts, and isContentEditable() triggers a layout update, which crashes.

LayoutTests:

* accessibility/textbox-role-on-contenteditable-crash-expected.txt: Added.
* accessibility/textbox-role-on-contenteditable-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMac rebaseline after r103468.
rniwa@webkit.org [Sat, 24 Dec 2011 05:35:58 +0000 (05:35 +0000)]
Mac rebaseline after r103468.

* platform/mac/fast/html/font-weight-bold-for-b-and-strong-expected.png:
* platform/mac/fast/html/font-weight-bold-for-b-and-strong-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] JPEG image with CMYK ICC color profile renders color-inverted and squashed
noel.gordon@gmail.com [Sat, 24 Dec 2011 05:08:06 +0000 (05:08 +0000)]
[chromium] JPEG image with CMYK ICC color profile renders color-inverted and squashed
https://bugs.webkit.org/show_bug.cgi?id=74400

Reviewed by Adam Barth.

Source/WebCore:

Use color profiles for GRAYSCALE, RGB, YCbCr, CMYK and YCCK jpeg images only if their
embedded color profile is from an RGB color space input device.

Test:
   fast/images/ycbcr-with-cmyk-color-profile.html
       - YCbCr image, with CMYK output device color profile.
Existing Tests:
   fast/images/gray-scale-jpeg-with-color-profile.html
       - YCbCr image, with GRAY input device color profile.
   fast/images/cmyk-jpeg-with-color-profile.html
       - YCCK image, with CMYK output device color profile.
   fast/images/color-jpeg-with-color-profile.html
       - YCbCr image, with RGB input device color profile.

* platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
(WebCore::rgbColorProfile): Return true if the profile has an RGB color space.
(WebCore::inputDeviceColorProfile): Return true if the profile is from an input device.
(WebCore::readColorProfile): Ignore the embedded color profile unless if it is from
an RGB color space input device.
(WebCore::JPEGImageReader::decode):

LayoutTests:

* fast/images/resources/ycbcr-with-cmyk-color-profile.jpg: Added.
* fast/images/resources/ycbcr-with-no-color-profile.jpg: Added.
* fast/images/ycbcr-with-cmyk-color-profile-expected.txt: Added.
* fast/images/ycbcr-with-cmyk-color-profile.html: Added.
* platform/mac/fast/images/ycbcr-with-cmyk-color-profile-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoPrint dlerror() when dyld functions fail unexpectedly
mitz@apple.com [Sat, 24 Dec 2011 04:35:22 +0000 (04:35 +0000)]
Print dlerror() when dyld functions fail unexpectedly
https://bugs.webkit.org/show_bug.cgi?id=75185

Reviewed by Sam Weinig.

* platform/mac/SoftLinking.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSkip 10 CanPlayType W3C audio / video tests imported in r103470.
rniwa@webkit.org [Sat, 24 Dec 2011 04:11:44 +0000 (04:11 +0000)]
Skip 10 CanPlayType W3C audio / video tests imported in r103470.
The failure is tracked by the bug 75184.

* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChromium rebaseline for font-weight-bold-for-b-and-strong.html.
rniwa@webkit.org [Sat, 24 Dec 2011 03:59:26 +0000 (03:59 +0000)]
Chromium rebaseline for font-weight-bold-for-b-and-strong.html.

Also remove crash expectations for the bug 74788 since these tests are no longer asserting.

* fast/html/font-weight-bold-for-b-and-strong-expected.txt: Removed.
* platform/chromium-cg-mac-leopard/fast/html/font-weight-bold-for-b-and-strong-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/html: Added.
* platform/chromium-cg-mac-snowleopard/fast/html/font-weight-bold-for-b-and-strong-expected.png: Added.
* platform/chromium-mac-leopard/fast/html/font-weight-bold-for-b-and-strong-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/html: Added.
* platform/chromium-mac-snowleopard/fast/html/font-weight-bold-for-b-and-strong-expected.png: Added.
* platform/chromium-win-vista/fast/html: Removed.
* platform/chromium-win/fast/html/font-weight-bold-for-b-and-strong-expected.png: Added.
* platform/chromium-win/fast/html/font-weight-bold-for-b-and-strong-expected.txt: Added.
* platform/chromium/fast/html: Added.
* platform/chromium/fast/html/font-weight-bold-for-b-and-strong-expected.txt: Added.
* platform/chromium/test_expectations.txt:
* platform/mac/fast/html/font-weight-bold-for-b-and-strong-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMac rebaselines after r102471 and r102968.
rniwa@webkit.org [Sat, 24 Dec 2011 03:48:32 +0000 (03:48 +0000)]
Mac rebaselines after r102471 and r102968.

* fast/dom/constructed-objects-prototypes-expected.txt:
* platform/mac/fast/dom/Window/window-properties-expected.txt:
* platform/mac/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/mac/fast/dom/prototype-inheritance-2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoStart extracting platform specific bits out of PlatformEvents
weinig@apple.com [Sat, 24 Dec 2011 03:45:50 +0000 (03:45 +0000)]
Start extracting platform specific bits out of PlatformEvents
https://bugs.webkit.org/show_bug.cgi?id=75063

Reviewed by Anders Carlsson.

Source/WebCore:

* WebCore.exp.in:
Update exports.

* WebCore.xcodeproj/project.pbxproj:
Add factory, remove implementation files for mac PlatformWheelEvent
and PlatformMouseEvent.

* page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::wheelEvent):
(WebCore::EventHandler::keyEvent):
(WebCore::EventHandler::currentPlatformMouseEvent):
Switch to use the factory.

* platform/PlatformEvent.h:
(WebCore::PlatformEvent::shiftKey):
(WebCore::PlatformEvent::ctrlKey):
(WebCore::PlatformEvent::altKey):
(WebCore::PlatformEvent::metaKey):
(WebCore::PlatformEvent::modifiers):
(WebCore::PlatformEvent::PlatformEvent):
Switch to storing the modifiers as bits on an unsigned
instead of as individual bools.

* platform/PlatformGestureEvent.h:
Remove unused timestamp member.

* platform/PlatformKeyboardEvent.h:
(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
(WebCore::PlatformKeyboardEvent::keyIdentifier):
(WebCore::PlatformKeyboardEvent::macCharCode):
(WebCore::PlatformKeyboardEvent::isSystemKey):
Give this class a more consistent interface across platforms,
and remove constructor that took an NSEvent.

* platform/PlatformMouseEvent.h:
Remove constructor that took an NSEvent (and an unused constructor that took
many arguments) as well as some free functions for point conversion.

* platform/PlatformWheelEvent.h:
Remove constructor that took an NSEvent and an unnecessary override of the timestamp()
function.

* platform/mac/KeyEventMac.mm:
Removed constructor and moved helpers to PlatformEventFactory.

* platform/mac/PlatformEventFactory.h: Added.
* platform/mac/PlatformEventFactory.mm: Added.
(WebCore::globalPoint):
(WebCore::globalPointForEvent):
(WebCore::pointForEvent):
(WebCore::mouseButtonForEvent):
(WebCore::mouseEventTypeForEvent):
(WebCore::clickCountForEvent):
(WebCore::momentumPhaseForEvent):
(WebCore::phaseForEvent):
(WebCore::gestureEventTypeForEvent):
(WebCore::textFromEvent):
(WebCore::unmodifiedTextFromEvent):
(WebCore::keyIdentifierForKeyEvent):
(WebCore::isKeypadEvent):
(WebCore::windowsKeyCodeForKeyEvent):
(WebCore::isKeyUpEvent):
(WebCore::modifiersForEvent):
(WebCore::PlatformMouseEventBuilder::PlatformMouseEventBuilder):
(WebCore::PlatformEventFactory::createPlatformMouseEvent):
(WebCore::PlatformWheelEventBuilder::PlatformWheelEventBuilder):
(WebCore::PlatformEventFactory::createPlatformWheelEvent):
(WebCore::PlatformKeyboardEventBuilder::PlatformKeyboardEventBuilder):
(WebCore::PlatformEventFactory::createPlatformKeyboardEvent):
(WebCore::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
(WebCore::PlatformEventFactory::createPlatformGestureEvent):
Consolidate platform event creation logic and add factory functions.

* platform/mac/PlatformMouseEventMac.mm: Removed.
* platform/mac/WheelEventMac.mm: Removed.

* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:
Expose wkGetNSEventKeyChar in WebCore.

* platform/gtk/PlatformKeyboardEventGtk.cpp:
(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
* platform/gtk/PlatformMouseEventGtk.cpp:
(WebCore::PlatformMouseEvent::PlatformMouseEvent):
* platform/gtk/PlatformWheelEventGtk.cpp:
(WebCore::PlatformWheelEvent::PlatformWheelEvent):
* platform/qt/PlatformKeyboardEventQt.cpp:
(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
* platform/qt/PlatformMouseEventQt.cpp:
(WebCore::mouseEventModifiersFromQtKeyboardModifiers):
(WebCore::PlatformMouseEvent::PlatformMouseEvent):
* platform/qt/PlatformTouchEventQt.cpp:
(WebCore::PlatformTouchEvent::PlatformTouchEvent):
* platform/win/KeyEventWin.cpp:
(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
* platform/win/WheelEventWin.cpp:
(WebCore::PlatformWheelEvent::PlatformWheelEvent):
Update for new variables/names.

Source/WebKit/chromium:

* src/WebInputEventConversion.cpp:
(WebKit::PlatformMouseEventBuilder::PlatformMouseEventBuilder):
(WebKit::PlatformWheelEventBuilder::PlatformWheelEventBuilder):
(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
(WebKit::PlatformKeyboardEventBuilder::PlatformKeyboardEventBuilder):
(WebKit::PlatformTouchEventBuilder::PlatformTouchEventBuilder):

Source/WebKit/mac:

* WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
* WebView/WebFrame.mm:
* WebView/WebHTMLView.mm:
(-[WebHTMLView menuForEvent:]):
(-[WebHTMLView acceptsFirstMouse:]):
(-[WebHTMLView shouldDelayWindowOrderingForEvent:]):
(currentKeyboardEvent):
(-[WebHTMLView flagsChanged:]):
* WebView/WebPDFView.mm:
(-[WebPDFView PDFViewWillClickOnLink:withURL:]):
* WebView/WebView.mm:

Source/WebKit2:

* Shared/WebEventConversion.cpp:
(WebKit::WebKit2PlatformMouseEvent::WebKit2PlatformMouseEvent):
(WebKit::WebKit2PlatformWheelEvent::WebKit2PlatformWheelEvent):
(WebKit::WebKit2PlatformKeyboardEvent::WebKit2PlatformKeyboardEvent):
(WebKit::WebKit2PlatformGestureEvent::WebKit2PlatformGestureEvent):
(WebKit::WebKit2PlatformTouchEvent::WebKit2PlatformTouchEvent):
* UIProcess/API/mac/WKView.mm:
* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChromium Chromium DEPS from 115012 to 115743.
rniwa@webkit.org [Sat, 24 Dec 2011 03:33:25 +0000 (03:33 +0000)]
Chromium Chromium DEPS from 115012 to 115743.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoInlined Yarr::execute
ggaren@apple.com [Sat, 24 Dec 2011 00:04:32 +0000 (00:04 +0000)]
Inlined Yarr::execute
https://bugs.webkit.org/show_bug.cgi?id=75180

Reviewed reluctantly by Beth Dakin.

Tiny speedup on SunSpider string tests. Removes some samples from
Instruments. A step toward removing -fomit-frame-pointer.

* yarr/YarrJIT.cpp:
* yarr/YarrJIT.h:
(JSC::Yarr::execute): ONE LINE FUNCTION, Y U NOT INLINED?!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoProvide option to disable Mac OS 10.7 application resume when using
dbates@webkit.org [Fri, 23 Dec 2011 23:47:00 +0000 (23:47 +0000)]
Provide option to disable Mac OS 10.7 application resume when using
{debug, run}-{safari, minibrowser, test-runner, test-webkit-api}, and run-webkit-app
https://bugs.webkit.org/show_bug.cgi?id=66902

Reviewed by David Kilzer.

Add an optional command line argument --no-saved-state to disable
application resume (state restoration) for the session on Mac OS 10.7.

For instance, when debugging an issue in Safari it is useful to be able
to temporarily disable application resume. Currently you can disable
application resume when launching Safari from within Xcode. We should
expose a similar option in our command line tools.

* Scripts/debug-minibrowser: Call printHelpAndExitForRunAndDebugWebKitAppIfNeeded()
to print a help message and exit() if the command line argument --help was given.
* Scripts/debug-safari: Ditto.
* Scripts/debug-test-runner: Ditto.
* Scripts/run-minibrowser: Ditto.
* Scripts/run-safari: Ditto.
* Scripts/run-test-runner: Ditto.
* Scripts/run-test-webkit-api: Ditto.
* Scripts/run-webkit-app: Ditto.
* Scripts/webkitdirs.pm:
(printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Added.
(argumentsForRunAndDebugMacWebKitApp): Added.
(runMacWebKitApp): If the --no-saved-state command line argument was given then
disable application resume for the session.
(execMacWebKitAppForDebugging): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCSSParser: Avoid creating dummy declaration in parseColor() slow path.
kling@webkit.org [Fri, 23 Dec 2011 22:33:58 +0000 (22:33 +0000)]
CSSParser: Avoid creating dummy declaration in parseColor() slow path.
<http://webkit.org/b/75104>

Patch by Andreas Kling <kling@webkit.org> on 2011-12-22
Reviewed by Darin Adler.

We only needed the dummy declaration to trigger the instantiation of
a CSSValuePool. Added an ensureCSSValuePool() method and have parseColor()
call that instead.

Also renamed the fast-path parseColor() to fastParseColor() and reordered
the arguments for consistency with the slow-path parseColor().

* css/CSSParser.cpp:
(WebCore::parseColorValue):
(WebCore::CSSParser::parseColor):
(WebCore::CSSParser::ensureCSSValuePool):
(WebCore::CSSParser::fastParseColor):
(WebCore::CSSParser::parseColorFromValue):
* css/CSSParser.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAutomate elements' registration as document namedItem/extraNamedItem.
kling@webkit.org [Fri, 23 Dec 2011 21:36:59 +0000 (21:36 +0000)]
Automate elements' registration as document namedItem/extraNamedItem.
<http://webkit.org/b/74991>

Patch by Andreas Kling <kling@webkit.org> on 2011-12-21
Reviewed by Antti Koivisto.

Remove caching of the "id" and "name" attributes on applet, embed, form,
image and object elements. We were caching them to keep the document's
map of named and "extra named" (named by id) item counts in sync.

Instead, add a hook to Element::willModifyAttribute() that detects when
the attributes are being changed and handle the registration/unregistration
automatically if the element returns true for shouldRegisterAsNamedItem()
or shouldRegisterAsExtraNamedItem() respectively.

This shrinks the elements by two AtomicStrings (8 or 16 bytes) each.

IFrame elements retain the old mechanism for now, as there are some subtle
differences to how that's handled.

* dom/Node.h:
(WebCore::Node::hasName):
(WebCore::Node::setHasName):

    Cache whether we have a "name" attribute or not (1 bit on Node.)
    This is done in order to minimize the overhead added to Element's
    insertedIntoDocument() and removeFromDocument().

* dom/StyledElement.cpp:
(WebCore::StyledElement::attributeChanged):

    Update the Node's has-name flag as appropriate.

* dom/Element.cpp:
(WebCore::Element::updateNamedItemRegistration):
(WebCore::Element::updateExtraNamedItemRegistration):

    Added. Called when the "name" and "id" attributes are changed.
    Updates the document's named item maps accordingly.

(WebCore::Element::insertedIntoDocument):
(WebCore::Element::removedFromDocument):

    Make sure updateName() is called in addition to updateId() when applicable.

* dom/Element.h:
(WebCore::Element::shouldRegisterAsNamedItem):
(WebCore::Element::shouldRegisterAsExtraNamedItem):

    Added. If an element returns true for these, it will be automatically
    registered with the document when the name/id attribute changes.

(WebCore::Element::updateId):
(WebCore::Element::updateName):

    Register/unregister from the document's named item maps as appropriate.

(WebCore::Element::willModifyAttribute):

    Add updateName() hook in addition to the existing updateId() hook.

* dom/NamedNodeMap.cpp:
(WebCore::NamedNodeMap::setAttributes):

    Make sure updateName() is called when we're cloning the attributes
    from another element.

* html/HTMLAppletElement.cpp:
(WebCore::HTMLAppletElement::parseMappedAttribute):
* html/HTMLAppletElement.h:
* html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::parseMappedAttribute):
(WebCore::HTMLEmbedElement::insertedIntoDocument):
* html/HTMLEmbedElement.h:
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::insertedIntoDocument):
(WebCore::HTMLFormElement::removedFromDocument):
(WebCore::HTMLFormElement::parseMappedAttribute):
* html/HTMLFormElement.h:
* html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::parseMappedAttribute):
(WebCore::HTMLImageElement::insertedIntoDocument):
* html/HTMLImageElement.h:
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::parseMappedAttribute):
(WebCore::HTMLObjectElement::insertedIntoDocument):
(WebCore::HTMLObjectElement::removedFromDocument):
* html/HTMLObjectElement.h:
* html/HTMLPlugInElement.h:

    Remove duplicated code that is now handled by Element.

* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::updateDocNamedItem):
(WebCore::HTMLObjectElement::formControlName):

    Use fastGetAttribute() since we no longer cache the name.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDFG loads from signed 8-bit and 16-bit typed arrays are broken
fpizlo@apple.com [Fri, 23 Dec 2011 21:08:12 +0000 (21:08 +0000)]
DFG loads from signed 8-bit and 16-bit typed arrays are broken
https://bugs.webkit.org/show_bug.cgi?id=75163

Source/JavaScriptCore:

Reviewed by Geoffrey Garen.

Added 8-bit and 16-bit signed loads. Because doing so on ARM is less trivial, I'm
currently disabling Int8Array and Int16Array optimizations on ARM.

* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::load8Signed):
(JSC::MacroAssemblerX86Common::load16Signed):
* assembler/X86Assembler.h:
(JSC::X86Assembler::movswl_mr):
(JSC::X86Assembler::movsbl_mr):
* bytecode/PredictedType.h:
(JSC::isActionableMutableArrayPrediction):
* dfg/DFGNode.h:
(JSC::DFG::Node::shouldSpeculateInt8Array):
(JSC::DFG::Node::shouldSpeculateInt16Array):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileGetByValOnIntTypedArray):

LayoutTests:

Reviewed by Geoffrey Garen.

Fixed some minor goofs in the previously comitted typed array tests, and added
new ones to cover this bug.

* fast/js/dfg-int16array-expected.txt: Added.
* fast/js/dfg-int16array.html: Added.
* fast/js/dfg-int8array-expected.txt: Added.
* fast/js/dfg-int8array.html: Added.
* fast/js/script-tests/dfg-float32array.js:
(getters.getter1.a):
(.a):
(setters.setter1.a):
(safeGetter):
* fast/js/script-tests/dfg-int16array.js: Added.
(getter1):
(setter1):
(getter2):
(setter2):
(getter3):
(setter3):
(getter4):
(setter4):
(getters.getter1.a):
(.a):
(setters.setter1.a):
(safeGetter):
(safeSetter):
* fast/js/script-tests/dfg-int32array.js:
(getters.getter1.a):
(.a):
(setters.setter1.a):
(safeGetter):
* fast/js/script-tests/dfg-int8array.js: Added.
(getter1):
(setter1):
(getter2):
(setter2):
(getter3):
(setter3):
(getter4):
(setter4):
(getters.getter1.a):
(.a):
(setters.setter1.a):
(safeGetter):
(safeSetter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDFG does double-to-int conversion incorrectly when storing into int typed arrays
fpizlo@apple.com [Fri, 23 Dec 2011 21:05:46 +0000 (21:05 +0000)]
DFG does double-to-int conversion incorrectly when storing into int typed arrays
https://bugs.webkit.org/show_bug.cgi?id=75164
<rdar://problem/10557547>

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::branchTruncateDoubleToUint32):
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::branchTruncateDoubleToUint32):
(JSC::MacroAssemblerX86Common::truncateDoubleToUint32):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):

LayoutTests:

* fast/js/dfg-int32array-overflow-values-expected.txt: Added.
* fast/js/dfg-int32array-overflow-values.html: Added.
* fast/js/dfg-uint32array-overflow-values-expected.txt: Added.
* fast/js/dfg-uint32array-overflow-values.html: Added.
* fast/js/script-tests/dfg-int32array-overflow-values.js: Added.
(getter1):
(setter1):
(getter2):
(setter2):
(getter3):
(setter3):
(getter4):
(setter4):
(getters.getter1.a):
(.a):
(setters.setter1.a):
(safeGetter):
(safeSetter):
* fast/js/script-tests/dfg-uint32array-overflow-values.js: Added.
(getter1):
(setter1):
(getter2):
(setter2):
(getter3):
(setter3):
(getter4):
(setter4):
(getters.getter1.a):
(.a):
(setters.setter1.a):
(safeGetter):
(safeSetter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed; fix build with ENABLE(NETSCAPE_PLUGIN_API).
kubo@profusion.mobi [Fri, 23 Dec 2011 19:01:26 +0000 (19:01 +0000)]
Unreviewed; fix build with ENABLE(NETSCAPE_PLUGIN_API).

* ewk/ewk_js.cpp: Include ewk_logging.h for ERR().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd two (currently unused) new member functions to ScrollElasticityControllerClient
andersca@apple.com [Fri, 23 Dec 2011 18:18:23 +0000 (18:18 +0000)]
Add two (currently unused) new member functions to ScrollElasticityControllerClient
https://bugs.webkit.org/show_bug.cgi?id=75179

Reviewed by Dan Bernstein.

This is so we'll be able to move more code to ScrollElasticityController.

* platform/mac/ScrollAnimatorMac.h:
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::pinnedInDirection):
(WebCore::ScrollAnimatorMac::immediateScrollByWithoutContentEdgeConstraints):
* platform/mac/ScrollElasticityController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Mac] fast/events/autoscroll-should-not-stop-on-keypress.html fails
commit-queue@webkit.org [Fri, 23 Dec 2011 17:34:34 +0000 (17:34 +0000)]
[Mac] fast/events/autoscroll-should-not-stop-on-keypress.html fails
https://bugs.webkit.org/show_bug.cgi?id=74538

Patch by Rakesh KN <rakesh.kn@motorola.com> on 2011-12-23
Reviewed by Alexey Proskuryakov.

* fast/events/autoscroll-should-not-stop-on-keypress-expected.txt:
* fast/events/autoscroll-should-not-stop-on-keypress.html:
Modified test to use iframe for testing autoscroll.
* platform/mac/Skipped:
Removed this test entry.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdate the test result (whitespace difference).
simon.fraser@apple.com [Fri, 23 Dec 2011 17:18:00 +0000 (17:18 +0000)]
Update the test result (whitespace difference).

* css3/filters/custom-filter-property-parsing-invalid-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBlur filter doesn't invalidate enough
simon.fraser@apple.com [Fri, 23 Dec 2011 17:01:47 +0000 (17:01 +0000)]
Blur filter doesn't invalidate enough
https://bugs.webkit.org/show_bug.cgi?id=74891

Source/WebCore:

Reviewed by Darin Adler.

Take the effects of filters into account for repainting; we need
to inflate the repaint rect by the outsets provided by the filter.

Test: css3/filters/filter-repaint.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeRectForRepaint):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::computeRectForRepaint):

LayoutTests:

Reviewed by Darin Adler.

Repaint test for the effects of a blur filter.

* css3/filters/filter-repaint-expected.txt: Added.
* css3/filters/filter-repaint-expected.png: Added.
* css3/filters/filter-repaint.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFilters should apply to inline elements
simon.fraser@apple.com [Fri, 23 Dec 2011 16:56:35 +0000 (16:56 +0000)]
Filters should apply to inline elements
https://bugs.webkit.org/show_bug.cgi?id=75152

Source/WebCore:

Reviewed by Darin Adler.

Filters need to cause creation of RenderLayers for inlines, just like
opacity and masks do.

Test: css3/filters/filtered-inline.html

* rendering/RenderInline.h:
(WebCore::RenderInline::requiresLayer):
* rendering/RenderTableRow.h: Remove an obviously incorrect comment.

LayoutTests:

Reviewed by Darin Adler.

Test for filter on an inline.

* css3/filters/filtered-inline-expected.png: Added.
* css3/filters/filtered-inline-expected.txt: Added.
* css3/filters/filtered-inline.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSynchronous XHR in window context should not support new XHR responseTypes for HTTP...
jarred@sencha.com [Fri, 23 Dec 2011 16:36:18 +0000 (16:36 +0000)]
Synchronous XHR in window context should not support new XHR responseTypes for HTTP(S) requests
https://bugs.webkit.org/show_bug.cgi?id=72154

Source/WebCore:

Per the latest W3C editor draft: http://dvcs.w3.org/hg/xhr/raw-file/tip/Overview.html
This is a spec-mandated attempt to thwart and otherwise discourage the use of synchronous XHR
in the window context by deliberately not exposing newer functionality. Here we are disabling
the use of responseType in synchronous HTTP(S) XHR requests from the window context.

When a user attempts this action, an InvalidAccessError exception is thrown and a message is
printed to the console to further explain.

Renamed reportUnsafeUsage to a more generic name, and hoisted it up so it would be defined
earlier and thus referenceable by setResponseType.

Reviewed by Alexey Proskuryakov.

Test: fast/xmlhttprequest/xmlhttprequest-responsetype-sync-request.html

* xml/XMLHttpRequest.cpp:
(WebCore::logConsoleError):
reportUnsafeUsage -> logConsoleError
(WebCore::XMLHttpRequest::setResponseType):
(WebCore::XMLHttpRequest::setRequestHeader):
reportUnsafeUsage -> logConsoleError
(WebCore::XMLHttpRequest::getResponseHeader):
reportUnsafeUsage -> logConsoleError
(WebCore::XMLHttpRequest::didFail):
reportUnsafeUsage -> logConsoleError

LayoutTests:

New tests that validate synchronous HTTP(S) XHR requests from the window context
cannot use responseType, while other protocols continue to work.

Reviewed by Alexey Proskuryakov.

* fast/xmlhttprequest/xmlhttprequest-responsetype-sync-request-expected.txt: Added.
* fast/xmlhttprequest/xmlhttprequest-responsetype-sync-request.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed rebaseline.
loislo@chromium.org [Fri, 23 Dec 2011 15:53:09 +0000 (15:53 +0000)]
Unreviewed rebaseline.

* platform/chromium-gpu/media/video-colorspace-yuv420-expected.png: Renamed from LayoutTests/platform/chromium-gpu-mac/media/video-colorspace-yuv420-expected.png.
* platform/chromium-gpu/media/video-colorspace-yuv422-expected.png: Renamed from LayoutTests/platform/chromium-gpu-mac/media/video-colorspace-yuv422-expected.png.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: Implement a worker for parsing out JavaScript function data
apavlov@chromium.org [Fri, 23 Dec 2011 15:40:47 +0000 (15:40 +0000)]
Web Inspector: Implement a worker for parsing out JavaScript function data
https://bugs.webkit.org/show_bug.cgi?id=75166

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/debugger/script-extract-outline.html

* inspector/front-end/ScriptFormatter.js:
(WebInspector.ScriptFormatter.prototype.formatContent):
* inspector/front-end/ScriptFormatterWorker.js:
(onmessage):
(format):
(getChunkCount):
():
(Array.prototype.keySet):

LayoutTests:

* inspector/debugger/script-extract-outline-expected.txt: Added.
* inspector/debugger/script-extract-outline.html: Added.
* inspector/debugger/script-formatter.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRefactored String.prototype.replace
ggaren@apple.com [Fri, 23 Dec 2011 15:38:43 +0000 (15:38 +0000)]
Refactored String.prototype.replace
https://bugs.webkit.org/show_bug.cgi?id=75114

Reviewed by Darin Adler.

No performance difference.

I think this is a step toward removing -fomit-frame-pointer.

* runtime/JSString.cpp:
* runtime/JSString.h: Removed the test and special case for a single-character
search string because the standard path does this test and special case
for us. (As an aside, if we do come up with a unique single-character
replace optimization in future, it probably belongs in the replace function,
and not in JSString.)

* runtime/StringPrototype.cpp:
(JSC::stringProtoFuncReplace): Split this mega-sized function into:
(JSC::replaceUsingStringSearch): - This reasonably sized function, and
(JSC::replaceUsingRegExpSearch): - This still mega-sized function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r103624.
loislo@chromium.org [Fri, 23 Dec 2011 15:35:12 +0000 (15:35 +0000)]
Unreviewed, rolling out r103624.
http://trac.webkit.org/changeset/103624
https://bugs.webkit.org/show_bug.cgi?id=68916

Broke Snow Leopard builders

Source/WebCore:

* CMakeLists.txt:
* DerivedSources.cpp:
* DerivedSources.pri:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSDirectoryEntryCustom.cpp:
(WebCore::JSDirectoryEntry::getFile):
(WebCore::JSDirectoryEntry::getDirectory):
* bindings/js/JSDirectoryEntrySyncCustom.cpp:
(WebCore::getFlags):
* bindings/v8/custom/V8DirectoryEntryCustom.cpp:
(WebCore::V8DirectoryEntry::getDirectoryCallback):
(WebCore::V8DirectoryEntry::getFileCallback):
* bindings/v8/custom/V8DirectoryEntrySyncCustom.cpp:
(WebCore::getFlags):
* fileapi/WebKitFlags.idl: Added.
* page/DOMWindow.idl:
* workers/WorkerContext.idl:

LayoutTests:

* fast/filesystem/flags-passing-expected.txt:
* fast/filesystem/script-tests/flags-passing.js:
(runNextTest):
(runObjectTest):
(runObjectTestWithExclusive):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago [fileapi] WebKitFlags should not be constructable per Directories & System...
ericu@chromium.org [Fri, 23 Dec 2011 13:23:18 +0000 (13:23 +0000)]
   [fileapi] WebKitFlags should not be constructable per Directories & System spec
       https://bugs.webkit.org/show_bug.cgi?id=68916

       Reviewed by Eric Seidel.

Source/WebCore:

       Remove IDL for the object and all DOM references to it.
       * fileapi/WebKitFlags.idl: Removed.
       * page/DOMWindow.idl:
       * workers/WorkerContext.idl:
       Remove references to the JSC/V8 objects compiled from the IDL.
       * bindings/js/JSDirectoryEntryCustom.cpp:
       (WebCore::JSDirectoryEntry::getFile):
       (WebCore::JSDirectoryEntry::getDirectory):
       * bindings/js/JSDirectoryEntrySyncCustom.cpp:
       (WebCore::getFlags):
       * bindings/v8/custom/V8DirectoryEntryCustom.cpp:
       (WebCore::V8DirectoryEntry::getDirectoryCallback):
       (WebCore::V8DirectoryEntry::getFileCallback):
       * bindings/v8/custom/V8DirectoryEntrySyncCustom.cpp:
       (WebCore::getFlags):
       Fix up build files.
       * WebCore.gypi:
       * WebCore.vcproj/WebCore.vcproj:
       * WebCore.xcodeproj/project.pbxproj:
       * WebCore/CMakeLists.txt:
       * WebCore/CodeGenerators.pri:
       * WebCore/DerivedSources.cpp:
       * WebCore/GNUmakefile.list.am:

LayoutTests:

       Remove a test that constructed the object; add one that tests error-handling for non-object parameters while I'm in there.
       * fast/filesystem/flags-passing-expected.txt:
       * fast/filesystem/script-tests/flags-passing.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: Migrate to native Function.prototype.bind; fix front-end compilation...
pfeldman@chromium.org [Fri, 23 Dec 2011 13:16:20 +0000 (13:16 +0000)]
Web Inspector: Migrate to native Function.prototype.bind; fix front-end compilation with the
version of compiler that respects Function.prototype.bind.
https://bugs.webkit.org/show_bug.cgi?id=75170

Reviewed by Yury Semikhatsky.

* inspector/front-end/ApplicationCacheModel.js:
* inspector/front-end/CSSKeywordCompletions.js:
(WebInspector.CSSKeywordCompletions.colors):
* inspector/front-end/CSSStyleModel.js:
* inspector/front-end/CompilerSourceMapping.js:
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMAgent.prototype.pushNodeToFrontend):
(WebInspector.DOMAgent.prototype.pushNodeByPathToFrontend):
(WebInspector.DOMAgent.prototype._dispatchWhenDocumentAvailable.onDocumentAvailable):
(WebInspector.DOMAgent.prototype._dispatchWhenDocumentAvailable):
(WebInspector.DOMAgent.prototype._loadNodeAttributes):
(WebInspector.DOMAgent.prototype.querySelector):
(WebInspector.DOMAgent.prototype.querySelectorAll):
* inspector/front-end/DebuggerModel.js:
* inspector/front-end/DebuggerPresentationModel.js:
* inspector/front-end/ExtensionAPI.js:
(injectedExtensionAPI.InspectorExtensionAPI):
(injectedExtensionAPI):
* inspector/front-end/ExtensionPanel.js:
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkManager.prototype.enableResourceTracking):
(WebInspector.NetworkManager.prototype.disableResourceTracking):
* inspector/front-end/Script.js:
* inspector/front-end/Settings.js:
* inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.prototype.complete):
* inspector/front-end/utilities.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[BlackBerry] Add the BlackBerry specific pauseLoad(bool) to ResourceHandle
leo.yang@torchmobile.com.cn [Fri, 23 Dec 2011 12:49:31 +0000 (12:49 +0000)]
[BlackBerry] Add the BlackBerry specific pauseLoad(bool) to ResourceHandle
https://bugs.webkit.org/show_bug.cgi?id=75162

Reviewed by George Staikos.

The porting can be built now, no new tests so far.

* platform/network/ResourceHandle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] MAC: should pass CSS3 elliptical gradient tests
noel.gordon@gmail.com [Fri, 23 Dec 2011 12:05:46 +0000 (12:05 +0000)]
[chromium] MAC: should pass CSS3 elliptical gradient tests
https://bugs.webkit.org/show_bug.cgi?id=56736

Reviewed by Stephen White.

Skia on mac draws ellipsoids on OSX 10.5 and 10.6 making these tests pass.  Rebaseline
the results, restrict the test failures to the Chromium CG port (CPU-CG).

* platform/chromium-mac-snowleopard/fast/gradients/css3-radial-gradients-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/gradients/css3-radial-gradients2-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/gradients/css3-radial-gradients3-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/gradients/css3-repeating-radial-gradients-expected.png: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoGive embedders a chance to handle postMessage calls
commit-queue@webkit.org [Fri, 23 Dec 2011 11:45:31 +0000 (11:45 +0000)]
Give embedders a chance to handle postMessage calls
https://bugs.webkit.org/show_bug.cgi?id=73883

Source/WebCore:

To support cross-process postMessage calls in Chromium (bug 73337), we need to intercept
postMessage calls to proxy windows. Originally we were just going to add a native event
listener on the Chromium side, but that required more changes to WebKit and was a bit of
a hack. See bug 73359 for a discuss about moving to this approach.

Patch by Karl Koscher <supersat@chromium.org> on 2011-12-23
Reviewed by Adam Barth.

Test: platform/chromium/fast/events/intercept-postmessage.html

* loader/FrameLoaderClient.h:
(WebCore::FrameLoaderClient::willCheckAndDispatchPostMessage): new method to allow the
    embedder to intercept postMessage calls
* page/DOMWindow.cpp:
(WebCore::DOMWindow::postMessageTimerFired): add a call to
    FrameLoaderClient::willCheckAndDispatchPostMessage

Source/WebKit/chromium:

Patch by Karl Koscher <supersat@chromium.org> on 2011-12-23
Reviewed by Adam Barth.

* public/WebFrameClient.h:
(WebKit::WebFrameClient::willCheckAndDispatchMessageEvent):
    interface to give the embedder a chance to handle this postMessage call
* src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::willCheckAndDispatchMessageEvent): Call
    willCheckAndDispatchMessageEvent on WebFrameClient
* src/FrameLoaderClientImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSource/WebKit/chromium: [WebWorkers][Chromium] Remove remains of cross-process dedica...
dslomov@google.com [Fri, 23 Dec 2011 10:59:01 +0000 (10:59 +0000)]
Source/WebKit/chromium: [WebWorkers][Chromium] Remove remains of cross-process dedicated worker implementation.
https://bugs.webkit.org/show_bug.cgi?id=66509
Just renames, merges and removal of dead code. Here are the list of renames:
  - WebCommonWorkerClient merged with WebWorkerClient and renamed to WebSharedWorkerClient
  - NewWebCommonWorkerClient renamed to WebCommonWorkerClient
  - WebWorkerBase merged into WebSharedWorkerImpl
  - NewWebWorkerBase renamed into WebWorkerBase
WebWorkerClient.h has a "#define WebWorkerClient WebSharedWorkerClient" to keep chromium building.
Will be removed after coordinated patch in chromium.

Reviewed by David Levin.

* WebKit.gyp:
* public/WebCommonWorkerClient.h:
* public/WebSharedWorker.h:
* public/WebSharedWorkerClient.h: Copied from Source/WebKit/chromium/public/WebCommonWorkerClient.h.
(WebKit::WebSharedWorkerClient::postConsoleMessageToWorkerObject):
(WebKit::WebSharedWorkerClient::allowFileSystem):
(WebKit::WebSharedWorkerClient::openFileSystem):
(WebKit::WebSharedWorkerClient::dispatchDevToolsMessage):
(WebKit::WebSharedWorkerClient::saveDevToolsAgentState):
(WebKit::WebSharedWorkerClient::~WebSharedWorkerClient):
* public/WebWorkerClient.h:
* src/DatabaseObserver.cpp:
(WebKit::AllowDatabaseMainThreadBridge::create):
(WebKit::AllowDatabaseMainThreadBridge::AllowDatabaseMainThreadBridge):
(WebKit::AllowDatabaseMainThreadBridge::allowDatabaseTask):
(WebKit::allowDatabaseForWorker):
(WebCore::DatabaseObserver::canEstablishDatabase):
* src/IDBFactoryBackendProxy.cpp:
(WebKit::IDBFactoryBackendProxy::openFromWorker):
* src/LocalFileSystemChromium.cpp:
(WebCore::openFileSystemHelper):
* src/WebSharedWorkerImpl.cpp:
(WebKit::initializeWebKitStaticValues):
(WebKit::WebSharedWorkerImpl::WebSharedWorkerImpl):
(WebKit::WebSharedWorkerImpl::~WebSharedWorkerImpl):
(WebKit::WebSharedWorkerImpl::stopWorkerThread):
(WebKit::WebSharedWorkerImpl::initializeLoader):
(WebKit::WebSharedWorkerImpl::didCreateDataSource):
(WebKit::WebSharedWorkerImpl::createApplicationCacheHost):
(WebKit::WebSharedWorkerImpl::postMessageToWorkerObject):
(WebKit::WebSharedWorkerImpl::postMessageTask):
(WebKit::WebSharedWorkerImpl::postExceptionToWorkerObject):
(WebKit::WebSharedWorkerImpl::postExceptionTask):
(WebKit::WebSharedWorkerImpl::postConsoleMessageToWorkerObject):
(WebKit::WebSharedWorkerImpl::postConsoleMessageTask):
(WebKit::WebSharedWorkerImpl::postMessageToPageInspector):
(WebKit::WebSharedWorkerImpl::postMessageToPageInspectorTask):
(WebKit::WebSharedWorkerImpl::updateInspectorStateCookie):
(WebKit::WebSharedWorkerImpl::updateInspectorStateCookieTask):
(WebKit::WebSharedWorkerImpl::confirmMessageFromWorkerObject):
(WebKit::WebSharedWorkerImpl::confirmMessageTask):
(WebKit::WebSharedWorkerImpl::reportPendingActivity):
(WebKit::WebSharedWorkerImpl::reportPendingActivityTask):
(WebKit::WebSharedWorkerImpl::workerContextClosed):
(WebKit::WebSharedWorkerImpl::workerContextClosedTask):
(WebKit::WebSharedWorkerImpl::workerContextDestroyed):
(WebKit::WebSharedWorkerImpl::workerContextDestroyedTask):
(WebKit::WebSharedWorkerImpl::postTaskToLoader):
(WebKit::WebSharedWorkerImpl::postTaskForModeToWorkerContext):
(WebKit::WebSharedWorker::create):
* src/WebSharedWorkerImpl.h:
(WebKit::WebSharedWorkerImpl::view):
(WebKit::WebSharedWorkerImpl::commonClient):
(WebKit::WebSharedWorkerImpl::client):
(WebKit::WebSharedWorkerImpl::setWorkerThread):
(WebKit::WebSharedWorkerImpl::workerThread):
* src/WebWorkerBase.cpp:
(WebKit::invokeTaskMethod):
(WebKit::WebWorkerBase::dispatchTaskToMainThread):
* src/WebWorkerBase.h:
* src/WebWorkerClientImpl.cpp:
* src/WebWorkerClientImpl.h:
(WebKit::WebWorkerClientImpl::commonClient):
* src/WebWorkerImpl.cpp: Removed.
* src/WebWorkerImpl.h: Removed.
* src/WorkerFileSystemCallbacksBridge.cpp:
(WebKit::WorkerFileSystemCallbacksBridge::postOpenFileSystemToMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::openFileSystemOnMainThread):
* src/WorkerFileSystemCallbacksBridge.h:

Tools: [WebWorkers][Chromium] Remove remains of cross-process dedicated worker implementation.
https://bugs.webkit.org/show_bug.cgi?id=66509
Just renames, merges and removal of dead code. Here are the list of renames:
  - WebCommonWorkerClient merged with WebWorkerClient and renamed to WebSharedWorkerClient
  - NewWebCommonWorkerClient renamed to WebCommonWorkerClient
  - WebWorkerBase merged into WebSharedWorkerImpl
  - NewWebWorkerBase renamed into WebWorkerBase

Reviewed by David Levin.

* DumpRenderTree/chromium/TestWebWorker.h:
(TestWebWorker::createWorker):
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::createWorker):
* DumpRenderTree/chromium/WebViewHost.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] fast/canvas/canvas-largedraws.html crashes with newer Qt5
ossy@webkit.org [Fri, 23 Dec 2011 10:54:02 +0000 (10:54 +0000)]
[Qt] fast/canvas/canvas-largedraws.html crashes with newer Qt5
https://bugs.webkit.org/show_bug.cgi?id=75167

* platform/qt-5.0/Skipped: Skip the crashing test to paint the bots green.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoXSLT-created HTML documents do not inherit content-security-policy from originally...
tsepez@chromium.org [Fri, 23 Dec 2011 10:40:25 +0000 (10:40 +0000)]
XSLT-created HTML documents do not inherit content-security-policy from originally loaded XML.
https://bugs.webkit.org/show_bug.cgi?id=75043

Reviewed by Adam Barth.

Source/WebCore:

Test: http/tests/security/contentSecurityPolicy/xsl-img-blocked.php

* page/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::copyStateFrom):
(WebCore::ContentSecurityPolicy::didReceiveHeader):
* page/ContentSecurityPolicy.h:
* xml/XSLTProcessor.cpp:
(WebCore::XSLTProcessor::createDocumentFromSource):

LayoutTests:

* http/tests/security/contentSecurityPolicy/resources/transform-to-img.xsl: Added.
* http/tests/security/contentSecurityPolicy/xsl-img-blocked-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/xsl-img-blocked.php: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSION (r97533): Optgroup label is not disabled
darin@apple.com [Fri, 23 Dec 2011 10:20:39 +0000 (10:20 +0000)]
REGRESSION (r97533): Optgroup label is not disabled
https://bugs.webkit.org/show_bug.cgi?id=74869

Reviewed by Alexey Proskuryakov.

* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::itemIsEnabled): Added back a line of code that was
accidentally deleted as part of the refactoring in r97533. This line of code
ensures that any items that are not option elements are disabled.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: Add CSSStyleSelector instrumentation calls towards implementing a...
apavlov@chromium.org [Fri, 23 Dec 2011 10:06:59 +0000 (10:06 +0000)]
Web Inspector: Add CSSStyleSelector instrumentation calls towards implementing a CSS selector profiler
https://bugs.webkit.org/show_bug.cgi?id=74863

Performance checks run on PerformanceTest/Parser/html5-full-render.html did not result in any noticeable
perf regression, as the instrumentation calls are inline and bail out early if there are no
Web Inspector frontends open.

Reviewed by Antti Koivisto.

No new tests, as the functionality is not bound to any user-visible outputs.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::matchRulesForList):
(WebCore::CSSStyleSelector::applyDeclaration):
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::willMatchRuleImpl):
(WebCore::InspectorInstrumentation::didMatchRuleImpl):
(WebCore::InspectorInstrumentation::willProcessRuleImpl):
(WebCore::InspectorInstrumentation::didProcessRuleImpl):
* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::willMatchRule):
(WebCore::InspectorInstrumentation::didMatchRule):
(WebCore::InspectorInstrumentation::willProcessRule):
(WebCore::InspectorInstrumentation::didProcessRule):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[EFL] Fix building with Glib support disabled
commit-queue@webkit.org [Fri, 23 Dec 2011 10:05:55 +0000 (10:05 +0000)]
[EFL] Fix building with Glib support disabled
https://bugs.webkit.org/show_bug.cgi?id=70990

Patch by Ivan Briano <ivan@profusion.mobi> on 2011-12-23
Reviewed by Martin Robinson.

Add forward declaration for cairo_surface_t, missing when building
the EFL port with Glib disabled.

* platform/cairo/WidgetBackingStore.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed upstream expectations.
loislo@chromium.org [Fri, 23 Dec 2011 09:58:58 +0000 (09:58 +0000)]
Unreviewed upstream expectations.

* platform/chromium/test_expectations.txt:
BUGRNIWA GPU-CG : media/video-colorspace-yuv420.html = IMAGE
BUGRNIWA GPU-CG : media/video-colorspace-yuv422.html = IMAGE

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd unit tests for AssociatedURLLoader to check redirect handling and
bbudge@chromium.org [Fri, 23 Dec 2011 09:52:23 +0000 (09:52 +0000)]
Add unit tests for AssociatedURLLoader to check redirect handling and
cross-origin access control.
https://bugs.webkit.org/show_bug.cgi?id=74952

Reviewed by Adam Barth.

* tests/AssociatedURLLoaderTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMinimize callsites and duplication of before/after advice for attribute mutations
adamk@chromium.org [Fri, 23 Dec 2011 09:12:28 +0000 (09:12 +0000)]
Minimize callsites and duplication of before/after advice for attribute mutations
https://bugs.webkit.org/show_bug.cgi?id=75054

Reviewed by Ryosuke Niwa.

Source/WebCore:

r103452 helpfully made before and after advice regarding attribute
changes symmetrical. This change finishes that work, by pulling
together all the before/after work, not just the crumbs previously
covered. This includes incrementing Document::domTreeVersion()
when an attribute is about to be changed, Inspector instrumentation,
and MutationEvent dispatch. This is in addition to the previous code,
which handled enqueueing MutationRecords for MutationObservers and
updating the Document's list of IDs.

The only change in behavior should be in InspectorInstrumentation,
which causes DOM breakpoints to occur for more cases of Attribute
mutation. This seems like more correct behavior, and a test has
been included to exercise it.

Hopefully the last Attribute-related refactor for awhile.

* dom/Attr.cpp:
(WebCore::Attr::setValue): Update to call didModifyAttribute instead
of attributeChanged.
* dom/Element.cpp:
(WebCore::Element::removeAttribute): Got rid of
removeAttributeInternal as most of that logic moved back into
NamedNodeMap::removeAttribute.
(WebCore::Element::setAttributeInternal): Reorganized to read better
now that only some cases result in calls to will/didModifyAttribute.
(WebCore::Element::willModifyAttribute): Un-inlined and added
incDOMTreeVersion and InspectorInstrumentation calls.
(WebCore::Element::didModifyAttribute): New method which encapsulates
calling attributeChanged, InspectorInstrumentation, and MutationEvents.
(WebCore::Element::didRemoveAttribute): New method which encapsulates
calling attributeChanged, InspectorInstrumentation, and MutationEvents.
Separate from didModifyAttribute because it has special handling of
the removed Attribute's value.
* dom/Element.h:
(WebCore::Element::willRemoveAttribute): New method which delegates to
willModifyAttribute as appropriate.
* dom/NamedNodeMap.cpp:
(WebCore::NamedNodeMap::setNamedItem): Simplified.
(WebCore::NamedNodeMap::removeNamedItem): Simplified.
(WebCore::NamedNodeMap::addAttribute): Added calls to will/didModifyAttribute.
(WebCore::NamedNodeMap::removeAttribute): ditto.
(WebCore::NamedNodeMap::replaceAttribute): ditto.
* svg/properties/SVGAnimatedPropertySynchronizer.h: Reverted changes
made in r103452 now that addAttribute/removeAttribute once again
call attributeChanged appropriately.

LayoutTests:

* inspector/debugger/dom-breakpoints.html: Add tests for breakpoints
due to mutation of Attr nodes/NamedNodeLists.
* platform/chromium/inspector/debugger/dom-breakpoints-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] REGRESSION(r103467): It broke fast/images/animated-gif-restored-from-bfcache...
pierre.rossi@gmail.com [Fri, 23 Dec 2011 08:32:05 +0000 (08:32 +0000)]
[Qt] REGRESSION(r103467): It broke fast/images/animated-gif-restored-from-bfcache.html
https://bugs.webkit.org/show_bug.cgi?id=75087

Source/JavaScriptCore:

monotonicallyIncreasingTime needs to hava a higher resolution than milliseconds.

Reviewed by Darin Adler.

* wtf/CurrentTime.cpp:
(WTF::monotonicallyIncreasingTime):

LayoutTests:

Unskipping the offending test.

Reviewed by Darin Adler.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoLet parser_unittests.pl call different language parsers
haraken@chromium.org [Fri, 23 Dec 2011 08:18:51 +0000 (08:18 +0000)]
Let parser_unittests.pl call different language parsers
https://bugs.webkit.org/show_bug.cgi?id=75081

Reviewed by David Kilzer.

We introduced parser_unittests.pl in bug 74994 , but it is implemented
to always call get_function_line_ranges_for_perl(). In order to enable unittests
for other languages, this patch lets parser_unittests.pl call different language
parsers depending on the languages.

Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl

* Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMap 'lang' and xml:lang attributes to '-webkit-locale' CSS property for use with...
commit-queue@webkit.org [Fri, 23 Dec 2011 07:29:32 +0000 (07:29 +0000)]
Map 'lang' and xml:lang attributes to '-webkit-locale' CSS property for use with font fallback and text-transform
https://bugs.webkit.org/show_bug.cgi?id=67586

Original patch by Jungshik Shin <jshin@chromium.org>

Patch by Matt Falkenhagen <falken@chromium.org> on 2011-12-22
Reviewed by Darin Adler.

Source/WebCore:

Tests: fast/text/lang-mapped-to-webkit-locale.xhtml
       fast/text/xml-lang-ignored-in-html.html

* html/HTMLElement.cpp:
(WebCore::HTMLElement::mapLanguageAttributeToLocale):
(WebCore::HTMLElement::parseMappedAttribute): Map 'lang' and 'xml:lang' to -webkit-locale.
* html/HTMLElement.h:

LayoutTests:

* fast/text/lang-mapped-to-webkit-locale-expected.txt: Added.
* fast/text/lang-mapped-to-webkit-locale.xhtml: Added.
* fast/text/xml-lang-ignored-in-html-expected.txt: Added.
* fast/text/xml-lang-ignored-in-html.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Update chromium test expectations.
loislo@chromium.org [Fri, 23 Dec 2011 06:30:59 +0000 (06:30 +0000)]
Unreviewed. Update chromium test expectations.

* platform/chromium/test_expectations.txt:
removed: BUGCR99500 WIN : svg/custom/simple-text-double-shadow.svg = IMAGE
removed: BUGCR99500 WIN : svg/css/group-with-shadow.svg = IMAGE
removed: BUGCR99500 WIN : compositing/shadows/shadow-drawing.html = IMAGE

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Update chromium test expectations.
loislo@chromium.org [Fri, 23 Dec 2011 06:07:56 +0000 (06:07 +0000)]
Unreviewed. Update chromium test expectations.

* platform/chromium/test_expectations.txt:
BUGWK75161 GPU : media/video-poster-blocked-by-willsendrequest.html = PASS TEXT
BUGWK75161 CPU : media/video-poster-blocked-by-willsendrequest.html = TEXT

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWinCE build fix after r103539.
rniwa@webkit.org [Fri, 23 Dec 2011 05:58:52 +0000 (05:58 +0000)]
WinCE build fix after r103539.

* rendering/svg/RenderSVGResource.cpp:
(WebCore::RenderSVGResource::removeFromFilterCache):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDFG should not speculate array even when predictions say that the base is not an...
fpizlo@apple.com [Fri, 23 Dec 2011 05:47:17 +0000 (05:47 +0000)]
DFG should not speculate array even when predictions say that the base is not an array
https://bugs.webkit.org/show_bug.cgi?id=75160
<rdar://problem/10622646>
<rdar://problem/10622649>

Reviewed by Oliver Hunt.

Added the ability to call slow path when the base is known to not be an array.
Also rationalized the logic for deciding when the index is not an int, and
cleaned up the logic for deciding when to speculate typed array.

Neutral for the most part, with odd speed-ups and slow-downs. The slow-downs can
likely be mitigated by having the notion of a polymorphic array access, where we
try, but don't speculate, to access the array one way before either trying some
other ways or calling slow path.

* bytecode/PredictedType.h:
(JSC::isActionableMutableArrayPrediction):
(JSC::isActionableArrayPrediction):
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGNode.h:
(JSC::DFG::Node::shouldSpeculateInt8Array):
(JSC::DFG::Node::shouldSpeculateInt16Array):
(JSC::DFG::Node::shouldSpeculateInt32Array):
(JSC::DFG::Node::shouldSpeculateUint8Array):
(JSC::DFG::Node::shouldSpeculateUint16Array):
(JSC::DFG::Node::shouldSpeculateUint32Array):
(JSC::DFG::Node::shouldSpeculateFloat32Array):
(JSC::DFG::Node::shouldSpeculateFloat64Array):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::byValIsPure):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileGetIndexedPropertyStorage):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChromium rebaselines after r103595 and r103477.
rniwa@webkit.org [Fri, 23 Dec 2011 03:53:40 +0000 (03:53 +0000)]
Chromium rebaselines after r103595 and r103477.

* platform/chromium-cg-mac-leopard/compositing/overflow/theme-affects-visual-overflow-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/compositing/overflow: Added.
* platform/chromium-cg-mac-snowleopard/compositing/overflow/theme-affects-visual-overflow-expected.png: Added.
* platform/chromium-gpu-linux/media/video-colorspace-yuv420-expected.png: Added.
* platform/chromium-gpu-linux/media/video-colorspace-yuv422-expected.png: Added.
* platform/chromium-gpu-mac/media/video-colorspace-yuv420-expected.png: Added.
* platform/chromium-gpu-mac/media/video-colorspace-yuv422-expected.png: Added.
* platform/chromium-gpu-win/media/video-colorspace-yuv420-expected.png: Added.
* platform/chromium-gpu-win/media/video-colorspace-yuv422-expected.png: Added.
* platform/chromium-linux/compositing/overflow/theme-affects-visual-overflow-expected.png: Added.
* platform/chromium-mac-leopard/compositing/overflow/theme-affects-visual-overflow-expected.png: Added.
* platform/chromium-mac-snowleopard/compositing/overflow: Added.
* platform/chromium-mac-snowleopard/compositing/overflow/theme-affects-visual-overflow-expected.png: Added.
* platform/chromium-win/compositing/overflow/theme-affects-visual-overflow-expected.png: Added.
* platform/chromium-win/compositing/overflow/theme-affects-visual-overflow-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChromium CG Mac rebaseline for SVG tests.
rniwa@webkit.org [Fri, 23 Dec 2011 03:38:51 +0000 (03:38 +0000)]
Chromium CG Mac rebaseline for SVG tests.

* platform/chromium-cg-mac-leopard/svg/W3C-SVG-1.1/animate-elem-33-t-expected.png: Added.
* platform/chromium-cg-mac-leopard/svg/W3C-SVG-1.1/animate-elem-34-t-expected.png: Added.
* platform/chromium-cg-mac-leopard/svg/W3C-SVG-1.1/metadata-example-01-b-expected.png: Added.
* platform/chromium-cg-mac-leopard/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.png: Added.
* platform/chromium-cg-mac-leopard/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png: Added.
* platform/chromium-cg-mac-leopard/svg/W3C-SVG-1.1/text-text-01-b-expected.png: Added.
* platform/chromium-cg-mac-leopard/svg/batik/text/textOnPath2-expected.png: Added.
* platform/chromium-cg-mac-leopard/svg/batik/text/verticalTextOnPath-expected.png: Added.
* platform/chromium-cg-mac-leopard/svg/carto.net/slider-expected.png: Added.
* platform/chromium-cg-mac-leopard/svg/css/composite-shadow-text-expected.png: Added.
* platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.png: Added.
* platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.png: Added.
* platform/chromium-cg-mac-leopard/svg/hixie/perf/007-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed - fix stylebot issues from last patch.
barraclough@apple.com [Fri, 23 Dec 2011 01:44:25 +0000 (01:44 +0000)]
Unreviewed - fix stylebot issues from last patch.

* runtime/JSArray.cpp:
(JSC::JSArray::putSlowCase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=75151
barraclough@apple.com [Fri, 23 Dec 2011 01:41:04 +0000 (01:41 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=75151
Add attributes field to JSArray's SparseMap

Reviewed by Sam Weinig.

This will be necessary to be able to support non- writable/configurable/enumerable
properties, and helpful for getters/setters.

Added a concept of being 'inSparseMode' - this indicates the array has a non-standard

* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncSort):
    - JSArray::sort methods not allowed on arrays that are 'inSparseMode'.
      (must fall back to generic sort alogrithm).
* runtime/JSArray.cpp:
(JSC::JSArray::finishCreation):
    - moved reportedMapCapacity into the SparseArrayValueMap object.
(JSC::SparseArrayValueMap::find):
(JSC::SparseArrayValueMap::put):
(JSC::SparseArrayValueMap::visitChildren):
    - Added.
(JSC::JSArray::getOwnPropertySlotByIndex):
(JSC::JSArray::getOwnPropertyDescriptor):
(JSC::JSArray::putSlowCase):
(JSC::JSArray::deletePropertyByIndex):
(JSC::JSArray::getOwnPropertyNames):
(JSC::JSArray::setLength):
(JSC::JSArray::pop):
(JSC::JSArray::visitChildren):
    - Updated for changes in SparseArrayValueMap.
(JSC::JSArray::sortNumeric):
(JSC::JSArray::sort):
(JSC::JSArray::compactForSorting):
    - Disallow on 'SparseMode' arrays.
* runtime/JSArray.h:
(JSC::SparseArrayEntry::SparseArrayEntry):
    - An entry in the sparse array - value (WriteBarrier) + attributes.
(JSC::SparseArrayValueMap::SparseArrayValueMap):
(JSC::SparseArrayValueMap::sparseMode):
(JSC::SparseArrayValueMap::setSparseMode):
    - Flags to track whether an Array is forced into SparseMode.
(JSC::SparseArrayValueMap::remove):
(JSC::SparseArrayValueMap::notFound):
(JSC::SparseArrayValueMap::isEmpty):
(JSC::SparseArrayValueMap::contains):
(JSC::SparseArrayValueMap::size):
(JSC::SparseArrayValueMap::begin):
(JSC::SparseArrayValueMap::end):
    - accessors to the map
(JSC::SparseArrayValueMap::take):
    - only for use on non-SpareMode arrays.
(JSC::JSArray::inSparseMode):
    - Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCrash and incorrect behavior when switching between hardware and software CSS filters
cmarrin@apple.com [Fri, 23 Dec 2011 01:08:56 +0000 (01:08 +0000)]
Crash and incorrect behavior when switching between hardware and software CSS filters
https://bugs.webkit.org/show_bug.cgi?id=75130

Reviewed by Simon Fraser.

Source/WebCore:

Test: css3/filters/crash-hw-sw-switch.html

Backing store on layer gets fixed up (added or removed) after style change is evaluated
so the state of the m_filter variable might not match the current filter state. Added
updateOrRemoveFilterEffect() call to ensureBacking() and clearBacking() to get the
m_filter property in the right state. Also added an ASSERT() where the crash was
occuring.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayer):
(WebCore::RenderLayer::ensureBacking):
(WebCore::RenderLayer::clearBacking):

LayoutTests:

* css3/filters/crash-hw-sw-switch-expected.txt: Added.
* css3/filters/crash-hw-sw-switch.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNeeds baseline for r103593.
jonlee@apple.com [Fri, 23 Dec 2011 01:03:33 +0000 (01:03 +0000)]
Needs baseline for r103593.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDFG CFA sometimes generates an incorrect proof that a node is known to be a typed...
fpizlo@apple.com [Fri, 23 Dec 2011 00:27:39 +0000 (00:27 +0000)]
DFG CFA sometimes generates an incorrect proof that a node is known to be a typed array
https://bugs.webkit.org/show_bug.cgi?id=75150
<rdar://problem/10621900>

Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):

LayoutTests:

* fast/js/dfg-float32array-expected.txt: Added.
* fast/js/dfg-float32array.html: Added.
* fast/js/dfg-int32array-expected.txt: Added.
* fast/js/dfg-int32array.html: Added.
* fast/js/script-tests/dfg-float32array.js: Added.
(getter1):
(setter1):
(getter2):
(setter2):
(getter3):
(setter3):
(getter4):
(setter4):
(getters.getter1.a):
(.a):
(setters.setter1.a):
(safeGetter):
(safeSetter):
* fast/js/script-tests/dfg-int32array.js: Added.
(getter1):
(setter1):
(getter2):
(setter2):
(getter3):
(setter3):
(getter4):
(setter4):
(getters.getter1.a):
(.a):
(setters.setter1.a):
(safeGetter):
(safeSetter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRadio buttons cut in download movie sheet
jonlee@apple.com [Fri, 23 Dec 2011 00:08:59 +0000 (00:08 +0000)]
Radio buttons cut in download movie sheet
https://bugs.webkit.org/show_bug.cgi?id=75128
<rdar://problem/9399450>

Reviewed by Dan Bernstein.

Source/WebCore:

Test: compositing/overflow/theme-affects-visual-overflow.html

The clipping comes from the fact the visual overflow rect of the radio button's
RenderBlock is not expanded to accommodate for the size of the button on the Mac
platform. We use the existing RenderTheme::adjustRepaintRect() to make the
appropriate adjustment. This, consequently, makes it unnecessary to have to
recalculate it for repaint.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeOverflow): As part of the overflow computation, we
make a call to addVisualOverflowFromTheme().
(WebCore::RenderBlock::addVisualOverflowFromTheme): Ask the theme to inflate the
RenderBlock's rect if necessary, and add that to the visual overflow rect.
* rendering/RenderBlock.h: Added addVisualOverflowFromTheme().
* rendering/RenderBox.cpp:
(WebCore::RenderBox::clippedOverflowRectForRepaint): Remove the call to
adjustRepaintRect() since the rectangle r already uses the new visual overflow
rect.
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::clippedOverflowRectForRepaint): Remove the call to
adjustRepaintRect() since the rectangle r already uses the new visual overflow
rect.

LayoutTests:

New test to ensure that visual overflow rect for form elements is expanded if the
block size is too small.

* compositing/overflow/theme-affects-visual-overflow.html: Added.
* platform/chromium/test_expectations.txt: Needs baseline.
* platform/mac/compositing/overflow/theme-affects-visual-overflow-expected.png: Added.
* platform/mac/compositing/overflow/theme-affects-visual-overflow-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChromium test expectation updates.
rniwa@webkit.org [Fri, 23 Dec 2011 00:03:57 +0000 (00:03 +0000)]
Chromium test expectation updates.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix mac build breakage - add SincResampler files to WebCore.xcodeproj
crogers@google.com [Thu, 22 Dec 2011 23:37:46 +0000 (23:37 +0000)]
Fix mac build breakage - add SincResampler files to WebCore.xcodeproj
https://bugs.webkit.org/show_bug.cgi?id=75139

Unreviewed build fix.

* WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDFG JIT does exactly the wrong thing when doing strict equality on two known cells
fpizlo@apple.com [Thu, 22 Dec 2011 23:24:21 +0000 (23:24 +0000)]
DFG JIT does exactly the wrong thing when doing strict equality on two known cells
https://bugs.webkit.org/show_bug.cgi?id=75138
<rdar://problem/10621526>

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq):

LayoutTests:

* fast/js/dfg-string-stricteq-expected.txt: Added.
* fast/js/dfg-string-stricteq.html: Added.
* fast/js/script-tests/dfg-string-stricteq.js: Added.
(foo):
(bar):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAnimating some CSS filter values is wrong
simon.fraser@apple.com [Thu, 22 Dec 2011 23:19:24 +0000 (23:19 +0000)]
Animating some CSS filter values is wrong
https://bugs.webkit.org/show_bug.cgi?id=75122

Source/WebCore:

Reviewed by Chris Marrin.

Fix some reversed filter animation behavior for brightness,
contrast and drop-shadow filters.

Test: css3/filters/filter-animation-from-none.html

* platform/graphics/filters/FilterOperation.cpp:
(WebCore::BasicComponentTransferFilterOperation::blend): Just use the global blend() function.
(WebCore::BasicComponentTransferFilterOperation::passthroughAmount): Add CONTRAST and BRIGHTNESS to the sswitch.
(WebCore::GammaFilterOperation::blend): Fix the ordering.
(WebCore::DropShadowFilterOperation::blend): Fix the ordering.

LayoutTests:

Reviewed by Chris Marrin.

Add a new test that exercises the "from none" code path.

Fix filter-animation.html, which used too-loose tolerance values
that resulted in some tests always passing.

* css3/filters/filter-animation-from-none-expected.txt: Added.
* css3/filters/filter-animation-from-none.html: Copied from LayoutTests/css3/filters/filter-animation.html.
* css3/filters/filter-animation.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix mac build caused by improper include of "Locker.h"
crogers@google.com [Thu, 22 Dec 2011 23:12:15 +0000 (23:12 +0000)]
Fix mac build caused by improper include of "Locker.h"
https://bugs.webkit.org/show_bug.cgi?id=75134

Unreviewed build fix.

* webaudio/MediaElementAudioSourceNode.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebMediaPlayerClientImpl::AudioClientImpl wrapper object should exist only if wrapped...
crogers@google.com [Thu, 22 Dec 2011 22:52:22 +0000 (22:52 +0000)]
WebMediaPlayerClientImpl::AudioClientImpl wrapper object should exist only if wrapped object exists
https://bugs.webkit.org/show_bug.cgi?id=75113

Reviewed by Kenneth Russell.

* src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::AudioSourceProviderImpl::wrap):
(WebKit::WebMediaPlayerClientImpl::AudioSourceProviderImpl::setClient):
* src/WebMediaPlayerClientImpl.h:
(WebKit::WebMediaPlayerClientImpl::AudioClientImpl::AudioClientImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix Chromium test expectation.
rniwa@webkit.org [Thu, 22 Dec 2011 22:47:35 +0000 (22:47 +0000)]
Fix Chromium test expectation.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMore ScrollAnimatorMac cleanup
andersca@apple.com [Thu, 22 Dec 2011 22:42:47 +0000 (22:42 +0000)]
More ScrollAnimatorMac cleanup
https://bugs.webkit.org/show_bug.cgi?id=75127

Reviewed by Andreas Kling.

Introduce a immediateScrollByWithoutContentEdgeConstraints and use it whenever we want to scroll by an
offset instead of doing the setConstrainsScrollingToContentEdge dance.

* platform/mac/ScrollAnimatorMac.h:
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::immediateScrollByWithoutContentEdgeConstraints):
(WebCore::ScrollAnimatorMac::smoothScrollWithEvent):
(WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoImplement MediaElementAudioSourceNode::setFormat() so numberOfChannels and sampleRate...
crogers@google.com [Thu, 22 Dec 2011 22:40:00 +0000 (22:40 +0000)]
Implement MediaElementAudioSourceNode::setFormat() so numberOfChannels and sampleRate are accounted for
https://bugs.webkit.org/show_bug.cgi?id=75057

Reviewed by Eric Carlson.

* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
Add MultiChannelResampler source files to makefiles.
* platform/audio/MultiChannelResampler.cpp: Added.
(WebCore::MultiChannelResampler::MultiChannelResampler):
(WebCore::MultiChannelResampler::process):
* platform/audio/MultiChannelResampler.h: Added.
Add MultiChannelResampler implementation which uses one SincResampler per channel.
* webaudio/MediaElementAudioSourceNode.cpp:
(WebCore::MediaElementAudioSourceNode::create):
(WebCore::MediaElementAudioSourceNode::MediaElementAudioSourceNode):
(WebCore::MediaElementAudioSourceNode::setFormat):
(WebCore::MediaElementAudioSourceNode::process):
Implement MediaElementAudioSourceNode::setFormat() so that we can
properly setup a sample-rate converter and set the number of channels
of the MediaElementAudioSourceNode output.
* webaudio/MediaElementAudioSourceNode.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAX: WebKit should ignore ARIA role=presentation on focusable elements
cfleizach@apple.com [Thu, 22 Dec 2011 22:30:25 +0000 (22:30 +0000)]
AX: WebKit should ignore ARIA role=presentation on focusable elements
https://bugs.webkit.org/show_bug.cgi?id=75101

Reviewed by Darin Adler.

Source/WebCore:

If an element is focusable, the presentational role must be ignored, lest the user not be able
to interact with something important.

Test: accessibility/presentational-elements-with-focus.html

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::determineAriaRoleAttribute):
(WebCore::AccessibilityRenderObject::inheritsPresentationalRole):

LayoutTests:

* accessibility/presentational-elements-with-focus-expected.txt: Added.
* accessibility/presentational-elements-with-focus.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUse immediateScrollBy instead of immediateScrollTo where possible
andersca@apple.com [Thu, 22 Dec 2011 22:17:21 +0000 (22:17 +0000)]
Use immediateScrollBy instead of immediateScrollTo where possible
https://bugs.webkit.org/show_bug.cgi?id=75124

Reviewed by Sam Weinig.

Instead of computing the position to scroll to, just compute the delta and use scrollBy instead.

* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::smoothScrollWithEvent):
(WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChromium Mac Leopard rebaseline; it's a clear progression. New result resembles the...
rniwa@webkit.org [Thu, 22 Dec 2011 22:06:14 +0000 (22:06 +0000)]
Chromium Mac Leopard rebaseline; it's a clear progression. New result resembles the cross-platform result:
http://trac.webkit.org/browser/trunk/LayoutTests/fast/repaint/text-emphasis-h-expected.png?rev=103570

Snow Leopard result is still pathologically wrong.

* platform/chromium-mac-leopard/fast/repaint/text-emphasis-h-expected.png:
* platform/chromium-mac-snowleopard/fast/repaint/text-emphasis-h-expected.png: Added.
* platform/chromium-mac/fast/repaint/text-emphasis-h-expected.png: Removed.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove a private ScrollAnimatorMac getter/setter and just update the member variable...
andersca@apple.com [Thu, 22 Dec 2011 22:01:19 +0000 (22:01 +0000)]
Remove a private ScrollAnimatorMac getter/setter and just update the member variable directly
https://bugs.webkit.org/show_bug.cgi?id=75121

Reviewed by Sam Weinig.

* platform/mac/ScrollAnimatorMac.h:
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::setIsActive):
(WebCore::ScrollAnimatorMac::updateScrollerStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSimplify ScrollAnimatorMac scrollByDelta functions
andersca@apple.com [Thu, 22 Dec 2011 21:39:20 +0000 (21:39 +0000)]
Simplify ScrollAnimatorMac scrollByDelta functions
https://bugs.webkit.org/show_bug.cgi?id=75120

Reviewed by Sam Weinig.

Merge immediateScrollByDeltaX and immediateScrollByDeltaY to a single function and rename it
to immediateScrollBy. Also, rename immediateScrollToPoint to immediateScrollTo.

* platform/mac/ScrollAnimatorMac.h:
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::scrollToOffsetWithoutAnimation):
(WebCore::ScrollAnimatorMac::immediateScrollTo):
(WebCore::ScrollAnimatorMac::immediateScrollBy):
(WebCore::ScrollAnimatorMac::immediateScrollToPointForScrollAnimation):
(WebCore::ScrollAnimatorMac::smoothScrollWithEvent):
(WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix Chromium test expectation.
rniwa@webkit.org [Thu, 22 Dec 2011 21:28:14 +0000 (21:28 +0000)]
Fix Chromium test expectation.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake some ScrollAnimatorMac member functions private
andersca@apple.com [Thu, 22 Dec 2011 21:22:15 +0000 (21:22 +0000)]
Make some ScrollAnimatorMac member functions private
https://bugs.webkit.org/show_bug.cgi?id=75117

Reviewed by Sam Weinig.

Make virtual member functions and functions that are only called from ScrollAnimatorMac private.

* platform/mac/ScrollAnimatorMac.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] [WK2] Use HashMap instead of Vector in the builtin bundle
caio.oliveira@openbossa.org [Thu, 22 Dec 2011 21:17:49 +0000 (21:17 +0000)]
[Qt] [WK2] Use HashMap instead of Vector in the builtin bundle
https://bugs.webkit.org/show_bug.cgi?id=75112

Reviewed by Andreas Kling.

Fix my own FIXME now that HashMap have support to hold OwnPtr as value.

* WebProcess/qt/QtBuiltinBundle.cpp:
(WebKit::QtBuiltinBundle::didCreatePage):
(WebKit::QtBuiltinBundle::willDestroyPage):
(WebKit::QtBuiltinBundle::handleMessageToNavigatorQtObject):
(WebKit::QtBuiltinBundle::handleSetNavigatorQtObjectEnabled):
* WebProcess/qt/QtBuiltinBundle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMove some member variables out of ScrollElasticityController
andersca@apple.com [Thu, 22 Dec 2011 21:08:42 +0000 (21:08 +0000)]
Move some member variables out of ScrollElasticityController
https://bugs.webkit.org/show_bug.cgi?id=75115

Reviewed by Adam Roben.

Move a couple of member variables that aren't related to rubberbanding out from
ScrollElasticityController and back into ScrollAnimatorMac and remove now unneeded
ScrollElasticityControllerClient member functions as well.

* platform/mac/ScrollAnimatorMac.h:
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::handleWheelEvent):
(WebCore::ScrollAnimatorMac::beginScrollGesture):
* platform/mac/ScrollElasticityController.h:
* platform/mac/ScrollElasticityController.mm:
(WebCore::ScrollElasticityController::ScrollElasticityController):
(WebCore::ScrollElasticityController::beginScrollGesture):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix debug build with assertions disabled
kbalazs@webkit.org [Thu, 22 Dec 2011 20:37:08 +0000 (20:37 +0000)]
Fix debug build with assertions disabled
https://bugs.webkit.org/show_bug.cgi?id=75075

Reviewed by Darin Adler.

Check whether assertions are disabled instead of NDEBUG
where appropriate to avoid "defined but not used" warnings.

Source/JavaScriptCore:

* wtf/DateMath.cpp:
(WTF::initializeDates):

Source/WebCore:

No change in behaviour so no new tests.

* loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::insertInLRUList):
(WebCore::MemoryCache::removeFromLiveDecodedResourcesList):
(WebCore::MemoryCache::insertInLiveDecodedResourcesList):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlockChild):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPositions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChromium test expectation update.
rniwa@webkit.org [Thu, 22 Dec 2011 20:32:20 +0000 (20:32 +0000)]
Chromium test expectation update.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd TIMEOUT PASS expectation to use-same-database-in-page-and-workers.html on Chromium.
rniwa@webkit.org [Thu, 22 Dec 2011 20:27:21 +0000 (20:27 +0000)]
Add TIMEOUT PASS expectation to use-same-database-in-page-and-workers.html on Chromium.
The failure is tracked by the bug 75111.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd failing expectation for fast/filesystem/op-restricted-chars.html on Chromium...
rniwa@webkit.org [Thu, 22 Dec 2011 20:19:15 +0000 (20:19 +0000)]
Add failing expectation for fast/filesystem/op-restricted-chars.html on Chromium Windows.
The failure is tracked by the bug 75110.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove the last of the WebKit2 display throttling
andersca@apple.com [Thu, 22 Dec 2011 20:06:10 +0000 (20:06 +0000)]
Remove the last of the WebKit2 display throttling
https://bugs.webkit.org/show_bug.cgi?id=75109

Reviewed by Adam Roben.

The code to do display throttling in WebKit2 is complex and doesn't really help us except
on an old benchmark that's no longer representative of real-world behavior; let's rip it out instead.

* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::DrawingAreaImpl):
(WebKit::DrawingAreaImpl::displayTimerFired):
(WebKit::DrawingAreaImpl::display):
* WebProcess/WebPage/DrawingAreaImpl.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::wheelEvent):
(WebKit::WebPage::wheelEventSyncForTesting):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoGet rid of didStartAnimatedScroll and didCompleteAnimatedScroll
andersca@apple.com [Thu, 22 Dec 2011 19:56:31 +0000 (19:56 +0000)]
Get rid of didStartAnimatedScroll and didCompleteAnimatedScroll
https://bugs.webkit.org/show_bug.cgi?id=75107

Reviewed by Adam Roben.

This is another step towards removing the display throttling in WebKit2.

Source/WebCore:

* page/ChromeClient.h:
* page/FrameView.cpp:
* page/FrameView.h:
* platform/ScrollableArea.h:
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::scroll):
(WebCore::ScrollAnimatorMac::immediateScrollToPointForScrollAnimation):

Source/WebKit2:

* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::dispatchViewportPropertiesDidChange):
* WebProcess/WebCoreSupport/WebChromeClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChromium SVG rebaselines. Also optimize results for those tests.
rniwa@webkit.org [Thu, 22 Dec 2011 19:52:48 +0000 (19:52 +0000)]
Chromium SVG rebaselines. Also optimize results for those tests.

* platform/chromium-cg-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-03-t-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-33-t-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-34-t-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/svg/W3C-SVG-1.1/metadata-example-01-b-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/svg/W3C-SVG-1.1/paths-data-03-f-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/svg/W3C-SVG-1.1/paths-data-15-t-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/svg/W3C-SVG-1.1/text-path-01-b-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/svg/W3C-SVG-1.1/text-text-01-b-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/svg/as-object/object-box-sizing-no-width-height-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/svg/batik/text/textOnPath2-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/svg/batik/text/verticalTextOnPath-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/svg/carto.net/slider-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/svg/css/composite-shadow-text-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/svg/custom/fill-opacity-update-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/svg/custom/invalid-css-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/svg/custom/js-late-clipPath-and-object-creation-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/svg/custom/js-late-clipPath-creation-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/svg/custom/nested-pattern-boundingBoxModeContent-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/svg/hixie/perf/007-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/svg/wicd/test-scalable-background-image2-expected.png: Added.
* platform/chromium-linux/svg/custom/nested-pattern-boundingBoxModeContent-expected.png: Removed.
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-03-t-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/as-object/object-box-sizing-no-width-height-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/css/composite-shadow-text-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/custom/fill-opacity-update-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/custom/nested-pattern-boundingBoxModeContent-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.png: Added.
* platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-03-t-expected.png: Removed.
* platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.png: Removed.
* platform/chromium-mac/svg/as-object/object-box-sizing-no-width-height-expected.png: Removed.
* platform/chromium-mac/svg/batik/text/verticalTextOnPath-expected.png: Removed.
* platform/chromium-mac/svg/css/composite-shadow-text-expected.png: Removed.
* platform/chromium-mac/svg/custom/fill-opacity-update-expected.png: Removed.
* platform/chromium-mac/svg/custom/nested-pattern-boundingBoxModeContent-expected.png: Removed.
* platform/chromium-mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.png: Removed.
* platform/chromium-mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.png: Removed.
* platform/chromium-win-xp/svg/custom/nested-pattern-boundingBoxModeContent-expected.png: Removed.
* platform/gtk/svg/custom/fill-opacity-update-expected.txt: Removed.
* platform/gtk/svg/custom/nested-pattern-boundingBoxModeContent-expected.txt: Removed.
* platform/mac/svg/custom/fill-opacity-update-expected.txt: Removed.
* platform/mac/svg/custom/nested-pattern-boundingBoxModeContent-expected.txt: Removed.
* platform/qt/svg/custom/fill-opacity-update-expected.txt: Removed.
* platform/qt/svg/custom/nested-pattern-boundingBoxModeContent-expected.txt: Removed.
* svg/custom/fill-opacity-update-expected.txt: Added.
* svg/custom/nested-pattern-boundingBoxModeContent-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove didStartRubberBand and didCompleteRubberBand callbacks
andersca@apple.com [Thu, 22 Dec 2011 19:44:36 +0000 (19:44 +0000)]
Remove didStartRubberBand and didCompleteRubberBand callbacks
https://bugs.webkit.org/show_bug.cgi?id=75102

Reviewed by Adam Roben.

The code to do display throttling in WebKit2 is complex and doesn't really help us except
on an old benchmark that's no longer representative of real-world behavior; let's rip it out instead.

Source/WebCore:

* page/ChromeClient.h:
* page/FrameView.cpp:
* page/FrameView.h:
* platform/ScrollView.cpp:
* platform/ScrollView.h:
* platform/ScrollableArea.h:
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):
* rendering/RenderLayer.cpp:
* rendering/RenderLayer.h:

Source/WebKit2:

* WebProcess/WebCoreSupport/WebChromeClient.cpp:
* WebProcess/WebCoreSupport/WebChromeClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[WinCairo] Update Skipped file to match Apple's port, and to
bfulgham@webkit.org [Thu, 22 Dec 2011 19:31:04 +0000 (19:31 +0000)]
[WinCairo] Update Skipped file to match Apple's port, and to
turn off some failing tests.

* platform/wincairo/Skipped: Update to match Apple's port.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: [Regression] Network item view is not displayed.
vsevik@chromium.org [Thu, 22 Dec 2011 19:24:18 +0000 (19:24 +0000)]
Web Inspector: [Regression] Network item view is not displayed.
https://bugs.webkit.org/show_bug.cgi?id=75100

Not reviewed, one line css fix.

* inspector/front-end/networkPanel.css:
(.network-item-view.visible):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChromium rebaseline after r103539.
rniwa@webkit.org [Thu, 22 Dec 2011 19:07:30 +0000 (19:07 +0000)]
Chromium rebaseline after r103539.

* platform/chromium-cg-mac-snowleopard/svg/filters/filter-refresh-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoThis test doesn't time out anymore now that I've sharded it into
abarth@webkit.org [Thu, 22 Dec 2011 19:01:57 +0000 (19:01 +0000)]
This test doesn't time out anymore now that I've sharded it into
smaller pieces.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChromium rebaseline after r103419. Also add the failing expectation to
rniwa@webkit.org [Thu, 22 Dec 2011 18:58:01 +0000 (18:58 +0000)]
Chromium rebaseline after r103419. Also add the failing expectation to
media/track/track-cue-rendering.html since the cue color is incorrect.
The failure is tracked by the bug 75098.

* platform/chromium/compositing/iframes/scrolling-iframe-expected.txt: Replaced.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNamedNodeMap: Get rid of declCount().
kling@webkit.org [Thu, 22 Dec 2011 18:44:24 +0000 (18:44 +0000)]
NamedNodeMap: Get rid of declCount().
<http://webkit.org/b/74948>

Reviewed by Darin Adler.

We already have the number of mapped attribute declarations in the map
stored in m_mappedAttributeCount (updated by declAdded()/declRemoved())
so compare that in mappedMapsEquivalent() to skip one loop over the map.

* dom/NamedNodeMap.cpp:
(WebCore::NamedNodeMap::mappedMapsEquivalent):
* dom/NamedNodeMap.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSnowLeopard crashes due to thread-unsafe EventListenerIterator ASSERTs
kling@webkit.org [Thu, 22 Dec 2011 18:38:08 +0000 (18:38 +0000)]
SnowLeopard crashes due to thread-unsafe EventListenerIterator ASSERTs
<http://webkit.org/b/74260>

Reviewed by Darin Adler.

Guard EventListenerMap::m_activeIteratorCount with a mutex.

* dom/EventListenerMap.cpp:
(WebCore::activeIteratorCountMutex):
(WebCore::EventListenerMap::assertNoActiveIterators):
(WebCore::EventListenerMap::clear):
(WebCore::EventListenerMap::add):
(WebCore::EventListenerMap::remove):
(WebCore::EventListenerMap::find):
(WebCore::EventListenerMap::removeFirstEventListenerCreatedFromMarkup):
(WebCore::EventListenerMap::copyEventListenersNotCreatedFromMarkupToTarget):
(WebCore::EventListenerIterator::EventListenerIterator):
(WebCore::EventListenerIterator::~EventListenerIterator):
* dom/EventListenerMap.h:
(WebCore::EventListenerMap::assertNoActiveIterators):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: TabbedPane should support closeable tabs, hiding tabs into drop down...
vsevik@chromium.org [Thu, 22 Dec 2011 18:31:20 +0000 (18:31 +0000)]
Web Inspector: TabbedPane should support closeable tabs, hiding tabs into drop down menu.
https://bugs.webkit.org/show_bug.cgi?id=75085

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/tabbed-pane-tabs-to-show.html

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/front-end/ScriptsNavigator.js:
(WebInspector.ScriptsNavigator):
* inspector/front-end/TabbedPane.js:
(WebInspector.TabbedPane):
(WebInspector.TabbedPane.prototype.set shrinkableTabs):
(WebInspector.TabbedPane.prototype.set closeableTabs):
(WebInspector.TabbedPane.prototype.appendTab):
(WebInspector.TabbedPane.prototype.closeTab):
(WebInspector.TabbedPane.prototype.selectTab):
(WebInspector.TabbedPane.prototype.onResize):
(WebInspector.TabbedPane.prototype._updateTabElements):
(WebInspector.TabbedPane.prototype._showTabElement):
(WebInspector.TabbedPane.prototype._hideTabElement):
(WebInspector.TabbedPane.prototype._createDropDownButton):
(WebInspector.TabbedPane.prototype._updateTabsDropDown):
(WebInspector.TabbedPane.prototype._populateDropDownFromIndex):
(WebInspector.TabbedPane.prototype._tabsSelectChanged):
(WebInspector.TabbedPane.prototype._measureDropDownButton):
(WebInspector.TabbedPane.prototype._updateWidths):
(WebInspector.TabbedPane.prototype._calculateMaxWidth.var):
(WebInspector.TabbedPane.prototype._calculateMaxWidth):
(WebInspector.TabbedPane.prototype._hideCurrentTab):
(WebInspector.TabbedPaneTab):
(WebInspector.TabbedPaneTab.prototype.get id):
(WebInspector.TabbedPaneTab.prototype.get tabElement):
(WebInspector.TabbedPaneTab.prototype.get measuredWidth):
(WebInspector.TabbedPaneTab.prototype.get width):
(WebInspector.TabbedPaneTab.prototype.set width):
(WebInspector.TabbedPaneTab.prototype._createTabElement):
(WebInspector.TabbedPaneTab.prototype._measure):
(WebInspector.TabbedPaneTab.prototype._tabSelected):
(WebInspector.TabbedPaneTab.prototype._tabClosed):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.css:
* inspector/front-end/scriptsPanel.css:
(#scripts-navigator-tabbed-pane .tabbed-pane-header-contents):
* inspector/front-end/tabbedPane.css: Added.

LayoutTests:

* inspector/tabbed-pane-tabs-to-show-expected.txt: Added.
* inspector/tabbed-pane-tabs-to-show.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSnow Leopard test fix
aroben@apple.com [Thu, 22 Dec 2011 18:30:54 +0000 (18:30 +0000)]
Snow Leopard test fix

* Scripts/webkitpy/test/main.py:
(Tester.run_tests): Python 2.6.1 doesn't seem to like specifying testRunner=None to
unittest.main, even though that's the default. So now we explicitly specify a
TextTestRunner.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@103554 268f45cc-cd09-0410-ab3c-d52691b4dbfc