WebKit-https.git
13 years ago2008-09-29 Thiago Macieira <thiago.macieira@nokia.com>
hausmann@webkit.org [Mon, 29 Sep 2008 12:47:08 +0000 (12:47 +0000)]
2008-09-29  Thiago Macieira  <thiago.macieira@nokia.com>

        Reviewed by Simon.

        Changed copyright from Trolltech ASA to Nokia.

        Nokia acquired Trolltech ASA, assets were transferred on September 26th 2008.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
jchaffraix@webkit.org [Mon, 29 Sep 2008 11:48:08 +0000 (11:48 +0000)]
WebCore:

2008-09-26  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Eric Seidel.

        Bug 5727: We want to evaluate scripts in viewless documents
        https://bugs.webkit.org/show_bug.cgi?id=5727

        Add the posibility to evaluate script or fetch resources on viewless
        document using the EmptyClient workaround.

        Test: fast/loader/viewless-document.html

        * dom/Document.h:
        (WebCore::Document::setFrame): Method to set the Document's
        Frame, added a warning that it should be used under special
        circumstances.

        * dom/ScriptElement.cpp:
        (WebCore::ScriptElementData::requestScript): If the
        frame is empty (viewless document), get a dummy Frame to be
        able to evalute the script.
        (WebCore::ScriptElementData::evaluateScript): Ditto.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::init): Take a bool to toogle
        empty Document creation.

        (WebCore::FrameLoader::fakeLoad): Fake remote resource load.

        (WebCore::FrameLoader::createDummyFrame):
        * loader/FrameLoader.h:
        * page/Frame.cpp:
        (WebCore::Frame::isDummyFrame):
        (WebCore::Frame::setIsDummyFrame):
        (WebCore::Frame::setDocument):

        (WebCore::FramePrivate::FramePrivate): Added m_isDummyFrame.
        (WebCore::FramePrivate::~FramePrivate): We have to free the Page if it is a dummyFrame
        (a dummyFrame own its Page).

        * page/Frame.h:
        * page/FramePrivate.h:

        * svg/graphics/SVGImage.cpp:
        (WebCore::SVGImage::SVGImage):
        (WebCore::SVGImage::dataChanged): Use the dummy Frame
        work-around.

        * svg/graphics/SVGImage.h: Removed unused members.

LayoutTests:

2008-09-26  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Eric Seidel.

        Bug 5727: We want to evaluate scripts in viewless documents
        https://bugs.webkit.org/show_bug.cgi?id=5727

        * fast/loader/viewless-document-expected.txt: Added.
        * fast/loader/viewless-document.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-09-29 Thiago Macieira <thiago.macieira@trolltech.com>
hausmann@webkit.org [Mon, 29 Sep 2008 09:03:09 +0000 (09:03 +0000)]
2008-09-29  Thiago Macieira  <thiago.macieira@trolltech.com>

        Reviewed by Simon

        Fix compilation with gcc 4.3

         gcc 4.3 is stricter and ctype.h isn't getting included
        automatically here by dependencies. So do it directly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-09-29 Morten Sørvig <msorvig@trolltech.com>
hausmann@webkit.org [Mon, 29 Sep 2008 09:02:56 +0000 (09:02 +0000)]
2008-09-29  Morten Sørvig  <msorvig@trolltech.com>

        Reviewed by Simon.

        Fix compilation with Qt/Mac without plugins.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-09-29 Simon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Mon, 29 Sep 2008 09:02:42 +0000 (09:02 +0000)]
2008-09-29  Simon Hausmann  <hausmann@webkit.org>

        Reviewed by Lars.

        Don't accidentially install libJavaScriptCore.a for the build inside
        Qt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoApply the ASCII fast path optimization from StringImpl::lower to StringImpl::upper.
mrowe@apple.com [Mon, 29 Sep 2008 08:20:37 +0000 (08:20 +0000)]
Apply the ASCII fast path optimization from StringImpl::lower to StringImpl::upper.
In the few places that we call .upper() in WebCore the strings represent things like
tag and attribute names, which are nearly always going to be ASCII.

Reviewed by Sam Weinig.

* platform/text/StringImpl.cpp:
(WebCore::StringImpl::lower): If we have to resize the buffer, be sure to pass the new length
in to Unicode::toLower the second time.
(WebCore::StringImpl::upper):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoSpeed up getPropertyValue('clip') by 25% by using a Vector<UChar> for building a...
mrowe@apple.com [Mon, 29 Sep 2008 08:19:14 +0000 (08:19 +0000)]
Speed up getPropertyValue('clip') by 25% by using a Vector<UChar> for building a string,
rather than String::operator+=.

Reviewed by Sam Weinig.

* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::cssText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoSpeed up computedStyle.getPropertyValue('color') by 4.5x.
mrowe@apple.com [Mon, 29 Sep 2008 08:19:09 +0000 (08:19 +0000)]
Speed up computedStyle.getPropertyValue('color') by 4.5x.

Using a Vector<UChar> while building up the property's cssText is substantially cheaper than using String::operator+=
as it avoids many memory reallocations.

This also speeds up the jQuery .offset() benchmark at <http://dev.jquery.com/~john/speed/1.2.6/offset-1.2.6.html>
by 20% due to jQuery's strange need to call getPropertyValue('color') when retrieving the computed styles for
unrelated properties on an element.

Reviewed by Oliver Hunt.

* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::cssText): Build the result for the color types into a Vector<UChar>
and use appendNumber rather than the String::number in order to cut down on memory allocations.
* platform/text/PlatformString.h:
(WebCore::appendNumber): A helper function for formatting an unsigned character as a number
into a Vector<UChar>.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix spelling
weinig@apple.com [Mon, 29 Sep 2008 04:17:33 +0000 (04:17 +0000)]
Fix spelling

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-09-28 Sam Weinig <sam@webkit.org>
weinig@apple.com [Mon, 29 Sep 2008 04:16:15 +0000 (04:16 +0000)]
2008-09-28  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Remove spurious call to lower().

        * css/MediaQueryEvaluator.cpp:
        (WebCore::MediaQueryEvaluator):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-09-28 Sam Weinig <sam@webkit.org>
weinig@apple.com [Mon, 29 Sep 2008 03:41:35 +0000 (03:41 +0000)]
2008-09-28  Sam Weinig  <sam@webkit.org>

        Reviewed by Dan Bernstein.

        Use a CaseFoldingHash instead of calling lower on family strings.

        * css/CSSFontSelector.cpp:
        (WebCore::CSSFontSelector::addFontFaceRule):
        (WebCore::CSSFontSelector::getFontData):
        * css/CSSFontSelector.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-09-28 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Mon, 29 Sep 2008 03:04:08 +0000 (03:04 +0000)]
2008-09-28  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Maciej Stachowiak.

        Bug 21200: Allow direct access to 'arguments' without using op_resolve
        <https://bugs.webkit.org/show_bug.cgi?id=21200>

        Allow fast access to the 'arguments' object by adding an extra slot to
        the callframe to store it.

        * JavaScriptCore.exp:
        * VM/CTI.cpp:
        (JSC::CTI::privateCompileMainPass):
        * VM/CodeBlock.cpp:
        (JSC::CodeBlock::dump):
        * VM/CodeGenerator.cpp:
        (JSC::CodeGenerator::CodeGenerator):
        (JSC::CodeGenerator::registerFor):
        * VM/CodeGenerator.h:
        (JSC::CodeGenerator::registerFor):
        * VM/Machine.cpp:
        (JSC::Machine::initializeCallFrame):
        (JSC::Machine::dumpRegisters):
        (JSC::Machine::privateExecute):
        (JSC::Machine::retrieveArguments):
        (JSC::Machine::cti_op_call_JSFunction):
        (JSC::Machine::cti_op_create_arguments):
        (JSC::Machine::cti_op_construct_JSConstruct):
        * VM/Machine.h:
        * VM/Opcode.h:
        * VM/RegisterFile.h:
        (JSC::RegisterFile::):
        * kjs/JSActivation.cpp:
        (JSC::JSActivation::mark):
        (JSC::JSActivation::argumentsGetter):
        * kjs/JSActivation.h:
        (JSC::JSActivation::JSActivationData::JSActivationData):
        * kjs/NodeInfo.h:
        * kjs/Parser.cpp:
        (JSC::Parser::didFinishParsing):
        * kjs/Parser.h:
        (JSC::Parser::parse):
        * kjs/grammar.y:
        * kjs/nodes.cpp:
        (JSC::ScopeNode::ScopeNode):
        (JSC::ProgramNode::ProgramNode):
        (JSC::ProgramNode::create):
        (JSC::EvalNode::EvalNode):
        (JSC::EvalNode::create):
        (JSC::FunctionBodyNode::FunctionBodyNode):
        (JSC::FunctionBodyNode::create):
        * kjs/nodes.h:
        (JSC::ScopeNode::usesArguments):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd an ASCII fast-path to toLowerCase and toUpperCase.
mrowe@apple.com [Mon, 29 Sep 2008 02:45:12 +0000 (02:45 +0000)]
Add an ASCII fast-path to toLowerCase and toUpperCase.

The fast path speeds up the common case of an ASCII-only string by up to 60% while adding a less than 5% penalty
to the less common non-ASCII case.

This also removes stringProtoFuncToLocaleLowerCase and stringProtoFuncToLocaleUpperCase, which were identical
to the non-locale variants of the functions.  toLocaleLowerCase and toLocaleUpperCase now use the non-locale
variants of the functions directly.

Reviewed by Sam Weinig.

* kjs/StringPrototype.cpp:
(JSC::stringProtoFuncToLowerCase):
(JSC::stringProtoFuncToUpperCase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoSpeed up parseInt and parseFloat.
mrowe@apple.com [Mon, 29 Sep 2008 02:00:42 +0000 (02:00 +0000)]
Speed up parseInt and parseFloat.

Repeatedly indexing into a UString is slow, so retrieve a pointer into the underlying buffer once up front
and use that instead.  This is a 7% win on a parseInt/parseFloat micro-benchmark.

Reviewed by Cameron Zwarich.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Bug 21185: resolve-ChangeLogs should be able to fix poorly merged ChangeLog...
ddkilzer@apple.com [Sun, 28 Sep 2008 23:57:03 +0000 (23:57 +0000)]
    Bug 21185: resolve-ChangeLogs should be able to fix poorly merged ChangeLog entries after a git svn rebase

        <https://bugs.webkit.org/show_bug.cgi?id=21185>

        Reviewed by Adam.

        * Scripts/resolve-ChangeLogs: Added new -f|--fix-merge switch that
        will attempt to reapply the last commit to a ChangeLog file such
        that the ChangeLog entry appears at the top of the file.
        (findChangeLog): Added prototype and moved method below the exit
        statement.
        (fixMergedChangeLog): Added.  Method to fix incorrectly merged
        ChangeLog entries.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoImproves the Web Inspector node highlight so it does not scroll to reveal the node...
timothy@apple.com [Sun, 28 Sep 2008 23:31:25 +0000 (23:31 +0000)]
Improves the Web Inspector node highlight so it does not scroll to reveal the node in the page.

WebCore:

2008-09-28  Timothy Hatcher  <timothy@apple.com>

        Remove the scrollIntoViewIfNeeded() call when drawing the
        Inspector node highlight.

        <rdar://problem/6115804> Don't scroll when highlighting (21000)
        https://bugs.webkit.org/show_bug.cgi?id=21000

        Reviewed by Dan Bernstein.

        * page/InspectorController.cpp:
        (WebCore::InspectorController::drawNodeHighlight):

WebKit/mac:

2008-09-28  Timothy Hatcher  <timothy@apple.com>

        Improves the Web Inspector node highlight so it does not scroll
        to reveal the node in the page. This makes the highlight less
        invasive and causes less things to change on screen. Also makes
        the highlight redraw when the WebView draws, so it stays current
        if the node changes on the page for any reason.

        <rdar://problem/6115804> Don't scroll when highlighting (21000)
        https://bugs.webkit.org/show_bug.cgi?id=21000

        Reviewed by Dan Bernstein.

        * WebCoreSupport/WebInspectorClient.mm:
        (-[WebInspectorWindowController highlightNode:]): Call setNeedsDisplay:YES
        if there is an existing highlight.
        (-[WebInspectorWindowController didAttachWebNodeHighlight:]): Set the current
        highlight node on the inspected WebView.
        (-[WebInspectorWindowController willDetachWebNodeHighlight:]): Set the current
        highlight node on the inspected WebView to nil.
        * WebInspector/WebNodeHighlight.m:
        (-[WebNodeHighlight setNeedsUpdateInTargetViewRect:]): Disable screen updates
        until flush for the inspected window. Invalidate the whole highlight view since
        we don't know the rect that needs updated since the highlight can be larger than
        the highlighted element due to the margins and other factors.
        * WebInspector/WebNodeHighlightView.m:
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView drawSingleRect:]): Call setNeedsUpdateInTargetViewRect: on the
        current highlight node.
        * WebView/WebView.mm:
        (-[WebViewPrivate dealloc]): Release the current highlight node.
        (-[WebView setCurrentNodeHighlight:]): Set the current highlight node.
        (-[WebView currentNodeHighlight]): Return the current highlight node.
        * WebView/WebViewInternal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-09-28 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Sun, 28 Sep 2008 19:58:14 +0000 (19:58 +0000)]
2008-09-28  David Hyatt  <hyatt@apple.com>

        Fix crash when WebKit has no instantiated Scrollbars and the appearance prefs for scrollbars are
        changed.

        Reviewed by Dan Bernstein

        * platform/mac/ScrollbarThemeMac.mm:
        (+[ScrollbarPrefsObserver appearancePrefsChanged:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Clear the current search results in the Inspector when
timothy@apple.com [Sun, 28 Sep 2008 19:52:30 +0000 (19:52 +0000)]
    Clear the current search results in the Inspector when
        the search query is less than 3 characters long. Incremental
        searches only occur for 3 characters or longer, but deleting
        under this limit would not clear the results unless the whole
        query was deleted.

        https://bugs.webkit.org/show_bug.cgi?id=21196

        Reviewed by Dan Bernstein.

        * page/inspector/inspector.js:
        (WebInspector.performSearch): Check for short queries in the
        if statement that triggers the clear.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix typo noticed by Hyatt in review, which I forgot to fix before checking in.
mitz@apple.com [Sun, 28 Sep 2008 19:41:30 +0000 (19:41 +0000)]
Fix typo noticed by Hyatt in review, which I forgot to fix before checking in.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Dave Hyatt.
mitz@apple.com [Sun, 28 Sep 2008 19:38:50 +0000 (19:38 +0000)]
    Reviewed by Dave Hyatt.

        - fix <rdar://problem/6202962> "Tibetan Machine Uni" font does not work as a web font on Windows because TTLoadEmbeddedFont fails with E_NAMECHANGEFAILED

        * platform/graphics/win/FontCustomPlatformData.cpp:
        (WebCore::EOTStream::EOTStream): Added overlayDst, overlaySrc and
        overlayLength parameters.
        (WebCore::EOTStream::read): Added code to overlay the the
        m_overlayLength bytes starting at m_overlayDst with the same number of
        bytes from m_overlaySrc.
        (WebCore::createFontCustomPlatformData): Changed to get overlay
        parameters from getEOTHeader.
        * platform/graphics/win/GetEOTHeader.cpp:
        (WebCore::getEOTHeader): Added code to specify overlaying of the
        family name with the prefix of the full name if they differ, because
        that such a difference causes TTLoadEmbeddedFont to fail.
        * platform/graphics/win/GetEOTHeader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-09-28 Simon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Sun, 28 Sep 2008 18:57:16 +0000 (18:57 +0000)]
2008-09-28  Simon Hausmann  <hausmann@webkit.org>

        Reviewed by David Hyatt.

        Ensure the mainThreadIdentifier is set as well as other bits and pieces of
        the threading machinery, by calling JSC::initializeThreading().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-09-28 Simon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Sun, 28 Sep 2008 18:56:50 +0000 (18:56 +0000)]
2008-09-28  Simon Hausmann  <hausmann@webkit.org>

        Reviewed by David Hyatt.

        In Qt's initializeThreading re-use an existing thread identifier for the main
        thread if it exists.

        currentThread() implicitly creates new identifiers and it could be that
        it is called before initializeThreading().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix build warning in WebDefaultUIDelegate.m
ddkilzer@apple.com [Sun, 28 Sep 2008 18:22:05 +0000 (18:22 +0000)]
    Fix build warning in WebDefaultUIDelegate.m

        Reviewed by Dan Bernstein.

        This fixes a warning noticed by the clang static analyzer:
        .../WebDefaultUIDelegate.m: In function ‘-[WebDefaultUIDelegate webViewFirstResponder:]’:
        .../WebDefaultUIDelegate.m:92: warning: initialization from distinct Objective-C type

        Note that this doesn't actually cause any change in behavior since
        the gcc compiler ignores the semi-colon anyway.

        * DefaultDelegates/WebDefaultUIDelegate.m:
        (-[WebDefaultUIDelegate webViewFirstResponder:]): Removed semi-colon
        from method signature.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Eric Seidel.
ap@webkit.org [Sun, 28 Sep 2008 13:23:51 +0000 (13:23 +0000)]
    Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=20366
        Reproducible test failure for editing/undo/undo-iframe-location-change.html

        This does not fix the problem, but makes the test more predictable by using iframe onload.
        Also, makes the test runnable in browser. Turns out that the test reliably fails there too,
        even without any special steps needed in DRT.

        * editing/undo/undo-iframe-location-change-expected.txt:
        * editing/undo/undo-iframe-location-change.html:

        * ChangeLog-2007-10-14: Added bug URLs for a patch that included this test.

WebCore:
        * ChangeLog-2006-05-10: Added bug URLs for a fix that included this test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-09-28 Darin Adler <darin@apple.com>
darin@apple.com [Sun, 28 Sep 2008 09:35:06 +0000 (09:35 +0000)]
2008-09-28  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig (except for a few comment and header tweaks).

        - https://bugs.webkit.org/show_bug.cgi?id=21158
          reduce use of virtual functions in Node for speed

        Speeds up Dromaeo a bit less than 1%.

        * bindings/js/JSNamedNodesCollection.cpp: Include Element.h instead of
        Node.h now that some inlines are in there.

        * dom/Attr.h: Override both the virtual and non-virtual name functions.

        * dom/ChildNodeList.cpp:
        (WebCore::ChildNodeList::nodeMatches): Updated to take an Element.
        * dom/ChildNodeList.h: Ditto.
        * dom/ClassNodeList.cpp:
        (WebCore::ClassNodeList::nodeMatches): Ditto.
        * dom/ClassNodeList.h: Ditto.

        * dom/Document.h: Put the Node::isDocumentNode() function's inline
        definition here where it can see the Document class definition.

        * dom/DynamicNodeList.cpp:
        (WebCore::DynamicNodeList::length): Changed to pass an Element.
        (WebCore::DynamicNodeList::itemForwardsFromCurrent): Ditto.
        (WebCore::DynamicNodeList::itemBackwardsFromCurrent): Ditto.
        (WebCore::DynamicNodeList::itemWithName): Ditto.
        * dom/DynamicNodeList.h: Ditto.

        * dom/Element.cpp: Removed virtualHasTagName.
        * dom/Element.h: Made localName, prefix, namespaceURI, and
        styleForRenderer non-virtual. Added virtualPrefix, virtualLocalName,
        virtualNamespaceURI, and removed virtualHasTagName. Put the
        Node::hasTagName, Node::hasAttributes, and Node::attributes
        functions' inline definitions here where they can see the Element
        class definition.

        * dom/NameNodeList.cpp:
        (WebCore::NameNodeList::nodeMatches): Updated to take an Element.
        * dom/NameNodeList.h: Ditto.

        * dom/Node.cpp:
        (WebCore::Node::virtualPrefix): Renamed from prefix.
        (WebCore::Node::virtualLocalName): Renamed from localName.
        (WebCore::Node::virtualNamespaceURI): Renamed from namespaceURI.
        (WebCore::Node::styleForRenderer): Handle the Element case here.

        * dom/Node.h: Removed definition of hasTagName that calls virtual,
        since we now have a non-virtual version. Made hasAttributes,
        attributes, remove, localName, namespaceURI, prefix, isDocumentNode,
        and styleForRenderer non-virtual. Added virtualPrefix,
        virtualLocalName, and virtualNamespaceURI. Removed isMalformed
        and setMalformed, which are used only on HTMLFormElement objects.

        * dom/TagNodeList.cpp:
        (WebCore::TagNodeList::nodeMatches): Updated to take an Element.
        * dom/TagNodeList.h: Ditto.

        * html/HTMLAnchorElement.cpp: Added a comment.
        * html/HTMLFormControlElement.cpp: Ditto.

        * html/HTMLAnchorElement.h: Removed unused, unimplemented setTabIndex
        function. Marked tabIndex function virtual explicitly for clarity.

        * html/HTMLAreaElement.h: Removed unused, unimplemented setTabIndex
        function. Marked isFocusable function virtual explicitly for clarity.

        * html/HTMLElement.h: Marked tabIndex function virtual explicitly for
        clarity.
        * html/HTMLFormControlElement.h: Ditto.

        * html/HTMLFormElement.h: Made isMalformed non-virtual.

        * html/HTMLParser.cpp:
        (WebCore::HTMLParser::handleError): Use the already-cast-to-HTMLElement
        pointer to call localName since that one does not need to call a virtual
        function.

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::layoutBlock): Cast to HTMLFormElement before
        calling isMalformed. We already did a tag name check so we know it's
        an HTMLFormELement.

        * xml/XPathUtil.cpp:
        (WebCore::XPath::isValidContextNode): Rewrote to not make so many calls
        to nodeType(), since it's a virtual function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix wx bustage.
hyatt@apple.com [Sun, 28 Sep 2008 09:33:46 +0000 (09:33 +0000)]
Fix wx bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-09-28 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Sun, 28 Sep 2008 08:52:26 +0000 (08:52 +0000)]
2008-09-28  David Hyatt  <hyatt@apple.com>

        Make frameRectsChanged() cross-platform on ScrollView.

        Reviewed by Oliver Hunt

        * platform/ScrollView.cpp:
        (WebCore::ScrollView::frameRectsChanged):
        * platform/ScrollView.h:
        * platform/gtk/ScrollViewGtk.cpp:
        * platform/qt/ScrollViewQt.cpp:
        * platform/win/ScrollViewWin.cpp:
        * platform/wx/ScrollViewWx.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBug 21141: REGRESSION: Exception messages for user entered commands are poor
oliver@apple.com [Sun, 28 Sep 2008 08:36:39 +0000 (08:36 +0000)]
Bug 21141: REGRESSION: Exception messages for user entered commands are poor
<https://bugs.webkit.org/show_bug.cgi?id=21141>

Reviewed by Maciej Stachowiak.

The bug repsonsible for this was the the JSInspectedObjectWrapper instances
were not initialising their StructureID's to indicate that the wrapper
overrides hasInstance, etc.  The solution is simply to use the createStructureID
helper on JSQuarantinedObjectWrapper to create a correct StructureID.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix GTK bustage.
hyatt@apple.com [Sun, 28 Sep 2008 08:30:43 +0000 (08:30 +0000)]
Fix GTK bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-09-28 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Sun, 28 Sep 2008 08:29:47 +0000 (08:29 +0000)]
2008-09-28  David Hyatt  <hyatt@apple.com>

        Make sure pixel wheel scrolls (formerly "continuous" wheel events) send deltas to DOM wheel events in
        terms of lines.

        Reviewed by Oliver Hunt

        * dom/EventTargetNode.cpp:
        (WebCore::EventTargetNode::dispatchWheelEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-09-28 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Sun, 28 Sep 2008 08:21:09 +0000 (08:21 +0000)]
2008-09-28  David Hyatt  <hyatt@apple.com>

        https://bugs.webkit.org/show_bug.cgi?id=21191

        Rework mouse wheeling significantly to make the platform event less messy and to enable wheelEvent
        on ScrollView to be cross-platform.

        Give the wheel event a concept of granularity (pixel, line or page).  What used to be called continuous
        events are now pixel wheel events.

        Page scrolling as implemented in bug 17589 was completely broken.  It had the following problems:
        (1) Page scrolling has been corrected to be properly detected (on Windows
        page wheeling is only done in the vertical direction and it is keyed off a special return value of -1).  The
        old code had some bizarre incorrect heuristic for "guessing" that you should page scroll and also thought
        you could page scroll horizontally.
        (2) Page scrolling a layer used the enclosing ScrollView's width/height instead of the layer's width/height.
        This caused the scroll amount for page scrolling to be way too large on layers.

        Bug 17589 got the default horizontal scrolling value wrong.  It assumed 1, when the Vista default is 3.

        Incorporate WebCore's line multiplier right into the deltas of the event.  This eliminates the need
        for separate multiplier fields (or for the need to ask if you're looking for line sensitivity).

        Reviewed by Oliver Hunt

        * editing/EditorCommand.cpp:
        (WebCore::verticalScrollDistance):
        * page/EventHandler.cpp:
        (WebCore::scrollAndAcceptEvent):
        (WebCore::EventHandler::handleWheelEvent):
        * platform/PlatformWheelEvent.h:
        (WebCore::):
        (WebCore::PlatformWheelEvent::pos):
        (WebCore::PlatformWheelEvent::globalPos):
        (WebCore::PlatformWheelEvent::deltaX):
        (WebCore::PlatformWheelEvent::deltaY):
        (WebCore::PlatformWheelEvent::granularity):
        (WebCore::PlatformWheelEvent::x):
        (WebCore::PlatformWheelEvent::globalX):
        (WebCore::PlatformWheelEvent::ignore):
        (WebCore::PlatformWheelEvent::horizontalLineMultiplier):
        (WebCore::PlatformWheelEvent::verticalLineMultiplier):
        * platform/ScrollView.cpp:
        (WebCore::ScrollView::wheelEvent):
        * platform/Scrollbar.h:
        * platform/gtk/ScrollViewGtk.cpp:
        (WebCore::ScrollView::updateScrollbars):
        * platform/gtk/WheelEventGtk.cpp:
        (WebCore::PlatformWheelEvent::PlatformWheelEvent):
        * platform/mac/ScrollViewMac.mm:
        * platform/mac/WheelEventMac.mm:
        (WebCore::PlatformWheelEvent::PlatformWheelEvent):
        * platform/qt/ScrollViewQt.cpp:
        (WebCore::ScrollView::updateScrollbars):
        * platform/qt/WheelEventQt.cpp:
        * platform/win/ScrollViewWin.cpp:
        (WebCore::ScrollView::updateScrollbars):
        * platform/win/WheelEventWin.cpp:
        (WebCore::PlatformWheelEvent::horizontalLineMultiplier):
        (WebCore::PlatformWheelEvent::verticalLineMultiplier):
        (WebCore::PlatformWheelEvent::PlatformWheelEvent):
        * platform/wx/ScrollViewWx.cpp:
        (WebCore::ScrollView::ScrollViewPrivate::OnScrollWinEvents):
        (WebCore::ScrollView::wheelEvent):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::updateScrollInfoAfterLayout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-09-27 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Sun, 28 Sep 2008 05:38:57 +0000 (05:38 +0000)]
2008-09-27  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Sam Weinig.

        fix https://bugs.webkit.org/show_bug.cgi?id=20994
        <rdar://problem/6171023> HTMLVideoElement width and height attributes are now unsigned

        HTML5 spec says HTMLVideoElement width and height attributes should be unsigned. Convert
        all unsigned media attributes from string with toUInt() instead of toInt().

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::playCount): convert from attribute with toUInt().

        * html/HTMLVideoElement.cpp:
        (WebCore::HTMLVideoElement::videoWidth):
        (WebCore::HTMLVideoElement::videoHeight): return unsigned to match idl.
        (WebCore::HTMLVideoElement::width): convert from attribute with toUInt() and return
          unsigned value.
        (WebCore::HTMLVideoElement::height): Ditto.
        (WebCore::HTMLVideoElement::setWidth): take unsigned value.
        (WebCore::HTMLVideoElement::setHeight): Ditto.

        * html/HTMLVideoElement.h: width, height, videoWidth, and videoHeight are unsigned.

        * html/HTMLVideoElement.idl: make width and height unsigned to match HTML5 spec.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix indentation error from bug 17589 fix made in WheelEventMac.mm
hyatt@apple.com [Sun, 28 Sep 2008 04:59:43 +0000 (04:59 +0000)]
Fix indentation error from bug 17589 fix made in WheelEventMac.mm

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoIt's SENSITIVE. SENSITIVE. Not SENSIBLE.
hyatt@apple.com [Sun, 28 Sep 2008 04:57:58 +0000 (04:57 +0000)]
It's SENSITIVE. SENSITIVE. Not SENSIBLE.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fixes an exception when typing a command in the Console.
timothy@apple.com [Sun, 28 Sep 2008 04:40:58 +0000 (04:40 +0000)]
    Fixes an exception when typing a command in the Console.

        Reviewed by Oliver Hunt.

        * page/inspector/Console.js:
        (WebInspector.Console.prototype.addMessage): Null check
        this.previosMessage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fixes a bug where the Profiles panel sidebar would be empty
timothy@apple.com [Sun, 28 Sep 2008 04:40:53 +0000 (04:40 +0000)]
    Fixes a bug where the Profiles panel sidebar would be empty
        after closing and reopening the Web Inspector.

        https://bugs.webkit.org/show_bug.cgi?id=21179

        Reviewed by Sam Weinig.

        * page/inspector/ProfilesPanel.js:
        (WebInspector.ProfilesPanel.prototype.reset): Don't call
        populateInterface, it is called automatically.
        (WebInspector.ProfilesPanel.prototype._populateProfiles):
        Return early if the sidebar is already populated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix for line step being too small on Windows.
hyatt@apple.com [Sun, 28 Sep 2008 04:38:21 +0000 (04:38 +0000)]
Fix for line step being too small on Windows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37025 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-09-27 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Sun, 28 Sep 2008 03:51:41 +0000 (03:51 +0000)]
2008-09-27  David Hyatt  <hyatt@apple.com>

        Make the scrollbarUnderMouse method cross-platform.

        Reviewed by Sam Weinig

        * platform/ScrollView.cpp:
        (WebCore::ScrollView::scrollbarUnderMouse):
        * platform/gtk/ScrollViewGtk.cpp:
        * platform/mac/ScrollViewMac.mm:
        * platform/qt/ScrollViewQt.cpp:
        * platform/win/ScrollViewWin.cpp:
        * platform/wx/ScrollViewWx.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoGtk+ build fix.
zecke@webkit.org [Sun, 28 Sep 2008 01:50:42 +0000 (01:50 +0000)]
Gtk+ build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago/
zecke@webkit.org [Sun, 28 Sep 2008 01:49:45 +0000 (01:49 +0000)]
/
2008-09-27  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Holger Freyther.

        https://bugs.webkit.org/show_bug.cgi?id=20287
        [Gtk] disable plugins for gtk/directfb target

        Introduce WTF_PLATFORM_X11 for X11 builds.
        Also use target-specific packages when building the port

        * configure.ac: Do not check for cairo-ft for directfb builds.

WebCore
2008-09-27  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Holger Freyther.

        https://bugs.webkit.org/show_bug.cgi?id=20287
        [Gtk] disable plugins for gtk/directfb target

        Introduce WTF_PLATFORM_X11 for X11 builds.
        Also use target-specific packages when building the port

        * platform/gtk/PlatformScreenGtk.cpp:
        * plugins/gtk/PluginViewGtk.cpp:
        (WebCore::PluginView::updatePluginWidget):
        (WebCore::PluginView::getValueStatic):
        (WebCore::PluginView::getValue):
        (WebCore::PluginView::init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoMissed WebKit single line change.
hyatt@apple.com [Sun, 28 Sep 2008 01:08:44 +0000 (01:08 +0000)]
Missed WebKit single line change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoOops. Checked in stale file.
hyatt@apple.com [Sun, 28 Sep 2008 01:07:36 +0000 (01:07 +0000)]
Oops. Checked in stale file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-09-27 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Sun, 28 Sep 2008 01:07:05 +0000 (01:07 +0000)]
2008-09-27  David Hyatt  <hyatt@apple.com>

        https://bugs.webkit.org/show_bug.cgi?id=21188

        Make scrollbar suppression and resizer avoidance cross-platform.

        Reviewed by Anders

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::transitionToCommitted):
        * page/FrameView.cpp:
        (WebCore::FrameView::resetScrollbars):
        (WebCore::FrameView::clear):
        (WebCore::FrameView::layout):
        (WebCore::FrameView::restoreScrollbar):
        (WebCore::FrameView::windowResizerRect):
        * page/FrameView.h:
        * platform/ScrollView.cpp:
        (WebCore::ScrollView::init):
        (WebCore::ScrollView::resizerOverlapsContent):
        (WebCore::ScrollView::adjustScrollbarsAvoidingResizerCount):
        (WebCore::ScrollView::setParent):
        (WebCore::ScrollView::setScrollbarsSuppressed):
        (WebCore::ScrollView::platformSetScrollbarsSuppressed):
        * platform/ScrollView.h:
        (WebCore::ScrollView::scrollbarsSuppressed):
        (WebCore::ScrollView::windowResizerRect):
        * platform/Scrollbar.cpp:
        (WebCore::Scrollbar::setFrameRect):
        (WebCore::Scrollbar::setParent):
        * platform/gtk/ScrollViewGtk.cpp:
        (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
        (WebCore::ScrollView::ScrollViewPrivate::adjustmentChanged):
        (WebCore::ScrollView::updateScrollbars):
        (WebCore::ScrollView::paint):
        * platform/mac/ScrollViewMac.mm:
        (WebCore::ScrollView::ScrollView):
        (WebCore::ScrollView::~ScrollView):
        (WebCore::ScrollView::platformSetScrollbarsSuppressed):
        (WebCore::ScrollView::setScrollPosition):
        * platform/qt/ScrollViewQt.cpp:
        (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
        (WebCore::ScrollView::ScrollViewPrivate::valueChanged):
        (WebCore::ScrollView::frameRectsChanged):
        (WebCore::ScrollView::updateScrollbars):
        (WebCore::ScrollView::paint):
        * platform/win/ScrollViewWin.cpp:
        (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
        (WebCore::ScrollView::ScrollViewPrivate::valueChanged):
        (WebCore::ScrollView::updateScrollbars):
        (WebCore::ScrollView::paint):
        * platform/wx/ScrollViewWx.cpp:
        (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUpdate a layout test result to add console.trace.
timothy@apple.com [Sat, 27 Sep 2008 23:58:28 +0000 (23:58 +0000)]
Update a layout test result to add console.trace.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-09-27 Holger Hans Peter Freyther <zecke@selfish.org>
zecke@webkit.org [Sat, 27 Sep 2008 23:46:50 +0000 (23:46 +0000)]
2008-09-27  Holger Hans Peter Freyther  <zecke@selfish.org>

        Rubber-stamped by Anders Carlsson.

        Compile fix.

        * plugins/PluginView.cpp:
        (WebCore::PluginView::load):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix <https://bugs.webkit.org/show_bug.cgi?id=21184>.
mrowe@apple.com [Sat, 27 Sep 2008 23:23:24 +0000 (23:23 +0000)]
Fix <https://bugs.webkit.org/show_bug.cgi?id=21184>.
Bug 21184: REGRESSION: Reproducible crash below StringImpl::hash while running editing/deleting/5408255.html

Remove an assertion that was incorrect and that if made correct would have duplicated a check that occurred earlier in the function.

Rubber-stamped by Sam Weinig.

* loader/CachedResource.cpp:
(WebCore::CachedResource::~CachedResource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-09-27 Marco Barisione <marco.barisione@collabora.co.uk>
zecke@webkit.org [Sat, 27 Sep 2008 22:56:56 +0000 (22:56 +0000)]
2008-09-27  Marco Barisione  <marco.barisione@collabora.co.uk>

        Reviewed by Holger Freyther.

        http://bugs.webkit.org/show_bug.cgi?id=21174
        [GTK][AUTOTOOLS] Enable large file support at configure time

        * configure.ac: Enable large file support with AC_SYS_LARGEFILE.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago[qt] Use QImageReader to figure out which image formats are supported
zecke@webkit.org [Sat, 27 Sep 2008 22:46:55 +0000 (22:46 +0000)]
[qt] Use QImageReader to figure out which image formats are supported
    - Qt can have many different plugins for different image formats. Instead
      of checking only for a few in WebCore use Qt to determine if this data
      can be treated as an image.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago[qt] Clean the pattern code
zecke@webkit.org [Sat, 27 Sep 2008 22:45:21 +0000 (22:45 +0000)]
[qt] Clean the pattern code
    - Use save/restore on the painter after manipulating the
      pen/brush
    - Make the context and object null checking consistent. CG is using
      the object unconditionally so the Qt webkit platform can do the
      same.
    - Move code below the early exit. Only use the m_ownerElement before
      the early exit as the CG code is doing it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdded support for console.trace.
timothy@apple.com [Sat, 27 Sep 2008 22:18:35 +0000 (22:18 +0000)]
Added support for console.trace.

JavaScriptCore:

2008-09-27  Keishi Hattori  <casey.hattori@gmail.com>

        Added Machine::retrieveCaller to the export list.

        Reviewed by Kevin McCullough and Tim Hatcher.

        * JavaScriptCore.exp: Added Machine::retrieveCaller.

WebCore:

2008-09-27  Keishi Hattori  <casey.hattori@gmail.com>

        Added support for console.trace.

        https://bugs.webkit.org/show_bug.cgi?id=19157

        Reviewed by Kevin McCullough and Tim Hatcher.

        * bindings/js/JSConsoleCustom.cpp:
        (WebCore::JSConsole::trace):
        * page/Console.cpp:
        (WebCore::Console::trace): Calls Machine::retrieveCaller to
        get a stack trace.
        * page/Console.h:
        (WebCore::): Added TraceMessageLevel.
        * page/Console.idl: Added console.trace.
        * page/inspector/Console.js:
        (ConsoleMessage): Added case for TraceMessageLevel.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-09-27 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Sat, 27 Sep 2008 22:18:20 +0000 (22:18 +0000)]
2008-09-27  David Hyatt  <hyatt@apple.com>

        Fix for https://bugs.webkit.org/show_bug.cgi?id=21182

        Make sure Mac null checks the view like the other platforms do now that Mac goes through WebCore
        to call setAllowsScrolling.

        Reviewed by Mark Rowe

        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::createFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebKit/qt:
hyatt@apple.com [Sat, 27 Sep 2008 22:15:57 +0000 (22:15 +0000)]
WebKit/qt:

2008-09-27  David Hyatt  <hyatt@apple.com>

        Forgot to land renaming changes in WebKit.

        * Api/qwebframe.cpp:
        (QWebFrame::render):
        (QWebFrame::pos):
        (QWebFrame::geometry):
        * Api/qwebpage.cpp:
        (QWebPage::viewportSize):
        (QWebPage::setViewportSize):

WebKit/win:

2008-09-27  David Hyatt  <hyatt@apple.com>

        Land the frameGeometry->frameRect changes that I forgot to land in WebKit.

        * Interfaces/IWebScrollBarPrivate.idl:
        * WebCoreSupport/EmbeddedWidget.cpp:
        (EmbeddedWidget::setFrameRect):
        (EmbeddedWidget::frameRectsChanged):
        * WebCoreSupport/EmbeddedWidget.h:
        * WebScrollBar.cpp:
        (WebScrollBar::setRect):
        (WebScrollBar::frameRect):
        * WebScrollBar.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Rubber-stamped by Sam Weinig.
mitz@apple.com [Sat, 27 Sep 2008 21:30:45 +0000 (21:30 +0000)]
    Rubber-stamped by Sam Weinig.

        - fix typo in test name

        * media/video-click-dblckick-standalone-expected.txt: Copied from media/video-click-dlbclick-standalone-expected.txt.
        * media/video-click-dblckick-standalone.html: Copied from media/video-click-dlbclick-standalone.html.
        * media/video-click-dlbclick-standalone-expected.txt: Removed.
        * media/video-click-dlbclick-standalone.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
andersca@apple.com [Sat, 27 Sep 2008 21:28:40 +0000 (21:28 +0000)]
WebCore:

2008-09-27  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=21178
        <rdar://problem/6248651>

        Check if the plug-in is allowed to load the resource. This matches Firefox.

        Test: http/tests/plugins/local-geturl-from-remote.html

        * plugins/PluginView.cpp:
        (WebCore::PluginView::load):

WebKit/mac:

2008-09-27  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=21178
        <rdar://problem/6248651>

        Check if the plug-in is allowed to load the resource. This matches Firefox.

        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):

WebKitTools:

2008-09-27  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=21178
        <rdar://problem/6248651>

        Return the result value from getURL.

        * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
        (getURL):

LayoutTests:

2008-09-27  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=21178
        <rdar://problem/6248651>

        Add tests.

        * http/tests/plugins/local-geturl-from-remote-expected.txt: Added.
        * http/tests/plugins/local-geturl-from-remote.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-09-27 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Sat, 27 Sep 2008 21:13:36 +0000 (21:13 +0000)]
2008-09-27  Anders Carlsson  <andersca@apple.com>

        Fix build.

        * WebCoreSupport/EmbeddedWidget.cpp:
        (EmbeddedWidget::setFrameRect):
        (EmbeddedWidget::frameRectsChanged):
        * WebCoreSupport/EmbeddedWidget.h:
        * WebScrollBar.cpp:
        (WebScrollBar::setRect):
        (WebScrollBar::frameGeometry):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-09-22 Dirk Schulze <vbs85@gmx.de>
zecke@webkit.org [Sat, 27 Sep 2008 21:06:35 +0000 (21:06 +0000)]
2008-09-22  Dirk Schulze  <vbs85@gmx.de>

        Reviewed by Eric Seidel.

        Added SVG pattern support to Qt.

        [Qt] SVG patterns are missing
        https://bugs.webkit.org/show_bug.cgi?id=20973

        * svg/graphics/qt/SVGPaintServerPatternQt.cpp:
        (WebCore::SVGPaintServerPattern::setup):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fixed a bug in the JS syntax highlighter with multiple line tokens.
timothy@apple.com [Sat, 27 Sep 2008 20:18:08 +0000 (20:18 +0000)]
    Fixed a bug in the JS syntax highlighter with multiple line tokens.

        https://bugs.webkit.org/show_bug.cgi?id=21171

        Reviewed by Tim Hatcher.

        * page/inspector/SourceFrame.js:
        (syntaxHighlightJavascriptLine): Initialize previousMatchLength.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Change searching in the Profiles panel to not match the
timothy@apple.com [Sat, 27 Sep 2008 20:18:03 +0000 (20:18 +0000)]
    Change searching in the Profiles panel to not match the
        Self and Total columns when there are no units. The only
        column that is matched for unitless number searches is
        now the Calls column.

        https://bugs.webkit.org/show_bug.cgi?id=21169

        Reviewed by Sam Weinig.

        * page/inspector/ProfileView.js:
        (WebInspector.ProfileView.prototype.performSearch):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-09-27 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Sat, 27 Sep 2008 19:56:56 +0000 (19:56 +0000)]
2008-09-27  David Hyatt  <hyatt@apple.com>

        Rename boundsGeometry -> boundsRect.  Rename geometryChanged -> frameRectsChanged.

        Reviewed by Sam Weinig

        * platform/ScrollView.h:
        * platform/Widget.h:
        (WebCore::Widget::boundsRect):
        (WebCore::Widget::invalidate):
        (WebCore::Widget::frameRectsChanged):
        * platform/gtk/ScrollViewGtk.cpp:
        (WebCore::ScrollViewScrollbar::frameRectsChanged):
        (WebCore::ScrollView::ScrollViewPrivate::scrollBackingStore):
        (WebCore::ScrollView::setFrameRect):
        (WebCore::ScrollView::updateScrollbars):
        (WebCore::ScrollView::frameRectsChanged):
        * platform/gtk/ScrollbarGtk.cpp:
        (ScrollbarGtk::setFrameRect):
        (ScrollbarGtk::frameRectsChanged):
        * platform/gtk/ScrollbarGtk.h:
        * platform/gtk/WidgetGtk.cpp:
        * platform/qt/ScrollViewQt.cpp:
        (WebCore::ScrollView::ScrollViewPrivate::scrollBackingStore):
        (WebCore::ScrollView::setFrameRect):
        (WebCore::ScrollView::frameRectsChanged):
        (WebCore::ScrollView::updateScrollbars):
        * platform/win/ScrollViewWin.cpp:
        (WebCore::ScrollView::ScrollViewPrivate::scrollBackingStore):
        (WebCore::ScrollView::setFrameRect):
        (WebCore::ScrollView::updateScrollbars):
        (WebCore::ScrollView::frameRectsChanged):
        * plugins/PluginView.cpp:
        (WebCore::PluginView::frameRectsChanged):
        * plugins/PluginView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-09-27 Simon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Sat, 27 Sep 2008 19:49:01 +0000 (19:49 +0000)]
2008-09-27  Simon Hausmann  <hausmann@webkit.org>

        Refix the previous build fix to compile on non-Qt platforms, too.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-09-27 Simon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Sat, 27 Sep 2008 19:15:15 +0000 (19:15 +0000)]
2008-09-27  Simon Hausmann  <hausmann@webkit.org>

        Fix compilation with gcc 4.3 (probably > 4.0)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-09-27 Simon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Sat, 27 Sep 2008 18:32:39 +0000 (18:32 +0000)]
2008-09-27  Simon Hausmann  <hausmann@webkit.org>

        Qt build fix - use frameRect instead of frameGeometry, adapt
        to renamed scrollbar frameview methods.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-09-27 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Sat, 27 Sep 2008 17:41:55 +0000 (17:41 +0000)]
2008-09-27  Anders Carlsson  <andersca@apple.com>

        Fix build.

        * VM/CTI.cpp:
        (JSC::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdded bug #
ggaren@apple.com [Sat, 27 Sep 2008 17:20:14 +0000 (17:20 +0000)]
Added bug #

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-09-27 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Sat, 27 Sep 2008 17:19:39 +0000 (17:19 +0000)]
2008-09-27  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Cameron Zwarich.

        Store the callee CodeBlock, not the caller CodeBlock, in the call frame
        header. Nix the "codeBlock" local variable, and access the callee
        CodeBlock through the call frame header instead.

        Profit: call + return are simpler, because they don't have to update the
        "codeBlock" local variable.

        Because CTI keeps "r" in a register, reading the callee CodeBlock relative
        to "r" can be very fast, in any cases we care to optimize. Presently,
        no such cases seem important.

        Also, stop writing "dst" to the call frame header. CTI doesn't use it.

        21.6% speedup on empty function call benchmark.
        3.8% speedup on SunSpider --v8.
        2.1% speedup on v8 benchmark.
        0.7% speedup on SunSpider (6% speedup on controlflow-recursive).

        Small regression in bytecode, because currently every op_ret reads the
        callee CodeBlock to check needsFullScopeChain, and bytecode does not
        keep "r" in a register. On-balance, this is probably OK, since CTI is
        our high-performance execution model. Also, this should go away once
        we make needsFullScopeChain statically determinable at parse time.

        * VM/CTI.cpp:
        (JSC::CTI::compileOpCall): The speedup!
        (JSC::CTI::privateCompileSlowCases): ditto

        * VM/CTI.h:
        (JSC::): Fixed up magic trampoline constants to account for the nixed
        "codeBlock" argument.
        (JSC::CTI::execute): Changed trampoline function not to take a "codeBlock"
        argument, since codeBlock is now stored in the call frame header.

        * VM/Machine.cpp: Read the callee CodeBlock from the register file. Use
        a NULL CallerRegisters in the call frame header to signal a built-in
        caller, since CodeBlock is now never NULL.

        * VM/Machine.h: Made some stand-alone functions Machine member functions
        so they could call the private codeBlock() accessor in the Register
        class, of which Machine is a friend. Renamed "CallerCodeBlock" to
        "CodeBlock", since it's no longer the caller's CodeBlock.

        * VM/RegisterFile.h: Marked some methods const to accommodate a
        const RegisterFile* being passed around in Machine.cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-09-27 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Sat, 27 Sep 2008 08:23:29 +0000 (08:23 +0000)]
2008-09-27  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Qt build fix - rename frameGeometry to frameRect per r36995.

        * Api/qwebframe.cpp:
        (QWebFrame::render):
        (QWebFrame::pos):
        (QWebFrame::geometry):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-09-27 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Sat, 27 Sep 2008 08:01:26 +0000 (08:01 +0000)]
2008-09-27  David Hyatt  <hyatt@apple.com>

        Rename frameGeometry to frameRect.  Rename setFrameGeometry to setFrameRect.

        Reviewed by Dan Bernstein

        * WebCore.base.exp:
        * page/FrameView.cpp:
        (WebCore::FrameView::FrameView):
        (WebCore::FrameView::updateControlTints):
        * platform/ScrollView.h:
        * platform/Scrollbar.cpp:
        (WebCore::Scrollbar::Scrollbar):
        (WebCore::Scrollbar::paint):
        (WebCore::Scrollbar::setFrameRect):
        * platform/Scrollbar.h:
        * platform/ScrollbarThemeComposite.cpp:
        (WebCore::ScrollbarThemeComposite::paint):
        * platform/Widget.h:
        (WebCore::Widget::x):
        (WebCore::Widget::y):
        (WebCore::Widget::width):
        (WebCore::Widget::height):
        (WebCore::Widget::size):
        (WebCore::Widget::pos):
        (WebCore::Widget::resize):
        (WebCore::Widget::move):
        * platform/gtk/ScrollViewGtk.cpp:
        (WebCore::ScrollViewScrollbar::geometryChanged):
        (WebCore::ScrollView::update):
        (WebCore::ScrollView::setFrameRect):
        (WebCore::ScrollView::updateScrollbars):
        (WebCore::ScrollView::scrollbarUnderMouse):
        (WebCore::ScrollView::paint):
        * platform/gtk/ScrollbarGtk.cpp:
        (ScrollbarGtk::setFrameRect):
        (ScrollbarGtk::geometryChanged):
        * platform/gtk/ScrollbarGtk.h:
        * platform/gtk/WidgetGtk.cpp:
        (WebCore::Widget::frameRect):
        (WebCore::Widget::setFrameRect):
        * platform/mac/ScrollbarThemeMac.mm:
        (WebCore::ScrollbarThemeMac::trackRect):
        (WebCore::ScrollbarThemeMac::paint):
        * platform/mac/WidgetMac.mm:
        (WebCore::Widget::frameRect):
        (WebCore::Widget::setFrameRect):
        * platform/qt/ScrollViewQt.cpp:
        (WebCore::ScrollView::setFrameRect):
        (WebCore::ScrollView::updateScrollbars):
        (WebCore::ScrollView::scrollbarUnderMouse):
        (WebCore::ScrollView::paint):
        * platform/qt/ScrollbarThemeQt.cpp:
        (WebCore::styleOptionSlider):
        * platform/qt/WidgetQt.cpp:
        (WebCore::Widget::frameRect):
        (WebCore::Widget::setFrameRect):
        * platform/win/PopupMenuWin.cpp:
        (WebCore::PopupMenu::invalidateItem):
        (WebCore::PopupMenu::valueChanged):
        (WebCore::PopupWndProc):
        * platform/win/ScrollViewWin.cpp:
        (WebCore::ScrollView::setFrameRect):
        (WebCore::ScrollView::updateScrollbars):
        (WebCore::ScrollView::scrollbarUnderMouse):
        (WebCore::ScrollView::paint):
        * platform/win/ScrollbarThemeSafari.cpp:
        (WebCore::ScrollbarThemeSafari::trackRect):
        * platform/win/WidgetWin.cpp:
        (WebCore::Widget::frameRect):
        (WebCore::Widget::setFrameRect):
        * platform/wx/WidgetWx.cpp:
        (WebCore::Widget::frameRect):
        (WebCore::Widget::setFrameRect):
        * plugins/PluginView.cpp:
        (WebCore::PluginView::setFrameRect):
        * plugins/PluginView.h:
        * plugins/gtk/PluginViewGtk.cpp:
        (WebCore::PluginView::updatePluginWidget):
        (WebCore::PluginView::paint):
        (WebCore::PluginView::init):
        * plugins/qt/PluginViewQt.cpp:
        (WebCore::PluginView::updatePluginWidget):
        (WebCore::PluginView::init):
        * plugins/win/PluginViewWin.cpp:
        (WebCore::PluginView::updatePluginWidget):
        (WebCore::PluginView::paintMissingPluginIcon):
        (WebCore::PluginView::paint):
        (WebCore::PluginView::init):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::positionOverflowControls):
        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::paintScrollbar):
        * rendering/RenderPart.cpp:
        (WebCore::RenderPart::updateWidgetPosition):
        * rendering/RenderWidget.cpp:
        (WebCore::RenderWidget::setWidgetGeometry):
        (WebCore::RenderWidget::updateWidgetPosition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix wx bustage.
hyatt@apple.com [Sat, 27 Sep 2008 07:51:00 +0000 (07:51 +0000)]
Fix wx bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agogit-svn-id: https://svn.webkit.org/repository/webkit/trunk@36993 268f45cc-cd09-0410...
hyatt@apple.com [Sat, 27 Sep 2008 07:43:52 +0000 (07:43 +0000)]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-09-27 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Sat, 27 Sep 2008 07:43:38 +0000 (07:43 +0000)]
2008-09-27  David Hyatt  <hyatt@apple.com>

        <rdar://problem/6252041> REGRESSION (4dp-TOT): Crash in Widget::platformWidget() when closing a PDF

        This crash was lurking for a while and basically got exposed by my changes to visibleContentRect() to
        access an actual member variable.

        Reviewed by Dan Bernstein

        * page/FocusController.cpp:
        (WebCore::FocusController::setFocusedFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-09-27 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Sat, 27 Sep 2008 07:38:30 +0000 (07:38 +0000)]
2008-09-27  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Attempt to fix QT Build. Not reviewed.

        * WebCore.pro: add -n WebCore parameter to create_hash_table

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-09-26 Gwenole Beauchesne <gbeauchesne@splitted-desktop.org>
jmalonzo@webkit.org [Sat, 27 Sep 2008 06:48:23 +0000 (06:48 +0000)]
2008-09-26  Gwenole Beauchesne  <gbeauchesne@splitted-desktop.org>

        Reviewed by Eric Seidel.

        http://bugs.webkit.org/show_bug.cgi?id=18905
        [GTK] Fix build with older pango (1.14.8)

        * platform/graphics/gtk/FontGtk.cpp:
        * platform/gtk/Language.cpp:
        (_pango_get_lc_ctype):
        (pango_language_get_default):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-09-26 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Sat, 27 Sep 2008 06:36:42 +0000 (06:36 +0000)]
2008-09-26  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Gtk build fix. Not reviewed.

        Narrow-down the target of the JavaScriptCore .lut.h generator so
        it won't try to create the WebCore .lut.hs.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-09-26 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Sat, 27 Sep 2008 06:23:58 +0000 (06:23 +0000)]
2008-09-26  David Hyatt  <hyatt@apple.com>

        https://bugs.webkit.org/show_bug.cgi?id=21168

        Make contentsToWindow/windowToContents cross-platform.

        Reviewed by Oliver Hunt

        * platform/ScrollView.cpp:
        (WebCore::ScrollView::windowToContents):
        (WebCore::ScrollView::contentsToWindow):
        * platform/ScrollView.h:
        * platform/gtk/ScrollViewGtk.cpp:
        * platform/mac/ScrollViewMac.mm:
        * platform/qt/ScrollViewQt.cpp:
        * platform/win/ScrollViewWin.cpp:
        * platform/wx/ScrollViewWx.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-09-26 Sam Weinig <sam@webkit.org>
weinig@apple.com [Sat, 27 Sep 2008 06:15:45 +0000 (06:15 +0000)]
2008-09-26  Sam Weinig  <sam@webkit.org>

        GTK build fix.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
pewtermoose@webkit.org [Sat, 27 Sep 2008 05:47:56 +0000 (05:47 +0000)]
JavaScriptCore:

2008-09-26  Matt Lilek  <webkit@mattlilek.com>

        Reviewed by Tim Hatcher.

        Update FEATURE_DEFINES after ENABLE_CROSS_DOCUMENT_MESSAGING was removed.

        * Configurations/JavaScriptCore.xcconfig:

WebKit/mac:

2008-09-26  Matt Lilek  <webkit@mattlilek.com>

        Reviewed by Tim Hatcher.

        Update FEATURE_DEFINES after ENABLE_CROSS_DOCUMENT_MESSAGING was removed.

        * Configurations/WebKit.xcconfig:

WebKitTools:

2008-09-26  Matt Lilek  <webkit@mattlilek.com>

        Reviewed by Tim Hatcher.

        Update FEATURE_DEFINES after ENABLE_CROSS_DOCUMENT_MESSAGING was removed.

        * Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-09-26 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Sat, 27 Sep 2008 05:26:38 +0000 (05:26 +0000)]
2008-09-26  David Hyatt  <hyatt@apple.com>

        Eliminate shouldUpdateWhileOffscreen from ScrollView.  Make the concept of not invalidating while
        offscreen cross-platform.  Rename the inWindow method to isOffscreen (which flips the boolean), since that
        more clearly conveys the intent of the method.  Make isOffscreen also check NSWindow visibility on Mac.

        Reviewed by Oliver Hunt

        * page/FrameView.cpp:
        (WebCore::FrameView::repaintContentRectangle):
        * page/FrameView.h:
        * platform/ScrollView.h:
        * platform/gtk/ScrollViewGtk.cpp:
        (WebCore::ScrollView::isOffscreen):
        * platform/mac/ScrollViewMac.mm:
        (WebCore::ScrollView::updateContents):
        (WebCore::ScrollView::isOffscreen):
        * platform/qt/ScrollViewQt.cpp:
        (WebCore::ScrollView::isOffscreen):
        * platform/win/ScrollViewWin.cpp:
        (WebCore::ScrollView::isOffscreen):
        * platform/wx/ScrollViewWx.cpp:
        (WebCore::ScrollView::isOffscreen):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::willRenderImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix WIndows bustage.
hyatt@apple.com [Sat, 27 Sep 2008 05:24:16 +0000 (05:24 +0000)]
Fix WIndows bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLand new result.
hyatt@apple.com [Sat, 27 Sep 2008 04:44:52 +0000 (04:44 +0000)]
Land new result.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
hyatt@apple.com [Sat, 27 Sep 2008 04:43:00 +0000 (04:43 +0000)]
WebCore:

2008-09-26  David Hyatt  <hyatt@apple.com>

        https://bugs.webkit.org/show_bug.cgi?id=21164

        Rework concept of allowsScrolling/setAllowsScrolling to be cross-platform.

        Reviewed by Sam Weinig

        * WebCore.base.exp:
        * page/FrameView.cpp:
        (WebCore::FrameView::setAllowsScrolling):
        * page/FrameView.h:
        * platform/ScrollView.cpp:
        (WebCore::ScrollView::setAllowsScrolling):
        * platform/ScrollView.h:
        (WebCore::ScrollView::allowsScrolling):
        * platform/win/ScrollViewWin.cpp:
        (WebCore::ScrollView::wheelEvent):

WebKit/mac:

2008-09-26  David Hyatt  <hyatt@apple.com>

        https://bugs.webkit.org/show_bug.cgi?id=21164

        Rework concept of allowsScrolling/setAllowsScrolling to be cross-platform.

        Reviewed by Sam Weinig

        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::createFrame):
        * WebView/WebDynamicScrollBarsView.h:
        * WebView/WebDynamicScrollBarsView.m:
        * WebView/WebDynamicScrollBarsViewInternal.h:
        * WebView/WebFrameView.mm:
        (-[WebFrameView setAllowsScrolling:]):
        (-[WebFrameView allowsScrolling]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-09-26 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Sat, 27 Sep 2008 03:23:18 +0000 (03:23 +0000)]
2008-09-26  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Rubber-stamped by Anders Carlson.

        Change the name 'sc' to 'scopeChainNode' in a few places.

        * kjs/nodes.cpp:
        (JSC::EvalNode::generateCode):
        (JSC::FunctionBodyNode::generateCode):
        (JSC::ProgramNode::generateCode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agowx build fixes after Widget/ScrollView changes.
kevino@webkit.org [Sat, 27 Sep 2008 03:22:11 +0000 (03:22 +0000)]
wx build fixes after Widget/ScrollView changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Add screenshots of searching in the Web Inspector.
timothy@apple.com [Sat, 27 Sep 2008 02:44:10 +0000 (02:44 +0000)]
    Add screenshots of searching in the Web Inspector.

        Not reviewed.

        * blog-files/inspector-searching-elements.png: Added.
        * blog-files/inspector-searching-profiles.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Allow searching for paths by always performing the
timothy@apple.com [Sat, 27 Sep 2008 02:44:05 +0000 (02:44 +0000)]
    Allow searching for paths by always performing the
        three search methods in the Elements panel and not
        assume a search with a "/" is a XPath query.

        https://bugs.webkit.org/show_bug.cgi?id=21159

        Reviewed by Geoff Garen.

        * page/inspector/ElementsPanel.js:
        (WebInspector.ElementsPanel.prototype.performSearch):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
weinig@apple.com [Sat, 27 Sep 2008 02:36:15 +0000 (02:36 +0000)]
JavaScriptCore:

2008-09-26  Sam Weinig  <sam@webkit.org>

        Reviewed by Darin Adler.

        Patch for https://bugs.webkit.org/show_bug.cgi?id=21152
        Speedup static property get/put

        Convert getting/setting static property values to use static functions
        instead of storing an integer and switching in getValueProperty/putValueProperty.

        * kjs/JSObject.cpp:
        (JSC::JSObject::deleteProperty):
        (JSC::JSObject::getPropertyAttributes):
        * kjs/MathObject.cpp:
        (JSC::MathObject::getOwnPropertySlot):
        * kjs/NumberConstructor.cpp:
        (JSC::numberConstructorNaNValue):
        (JSC::numberConstructorNegInfinity):
        (JSC::numberConstructorPosInfinity):
        (JSC::numberConstructorMaxValue):
        (JSC::numberConstructorMinValue):
        * kjs/PropertySlot.h:
        (JSC::PropertySlot::):
        * kjs/RegExpConstructor.cpp:
        (JSC::regExpConstructorDollar1):
        (JSC::regExpConstructorDollar2):
        (JSC::regExpConstructorDollar3):
        (JSC::regExpConstructorDollar4):
        (JSC::regExpConstructorDollar5):
        (JSC::regExpConstructorDollar6):
        (JSC::regExpConstructorDollar7):
        (JSC::regExpConstructorDollar8):
        (JSC::regExpConstructorDollar9):
        (JSC::regExpConstructorInput):
        (JSC::regExpConstructorMultiline):
        (JSC::regExpConstructorLastMatch):
        (JSC::regExpConstructorLastParen):
        (JSC::regExpConstructorLeftContext):
        (JSC::regExpConstructorRightContext):
        (JSC::setRegExpConstructorInput):
        (JSC::setRegExpConstructorMultiline):
        (JSC::RegExpConstructor::setInput):
        (JSC::RegExpConstructor::setMultiline):
        (JSC::RegExpConstructor::multiline):
        * kjs/RegExpConstructor.h:
        * kjs/RegExpObject.cpp:
        (JSC::regExpObjectGlobal):
        (JSC::regExpObjectIgnoreCase):
        (JSC::regExpObjectMultiline):
        (JSC::regExpObjectSource):
        (JSC::regExpObjectLastIndex):
        (JSC::setRegExpObjectLastIndex):
        * kjs/RegExpObject.h:
        (JSC::RegExpObject::setLastIndex):
        (JSC::RegExpObject::lastIndex):
        (JSC::RegExpObject::RegExpObjectData::RegExpObjectData):
        * kjs/StructureID.cpp:
        (JSC::StructureID::getEnumerablePropertyNames):
        * kjs/create_hash_table:
        * kjs/lexer.cpp:
        (JSC::Lexer::lex):
        * kjs/lookup.cpp:
        (JSC::HashTable::createTable):
        (JSC::HashTable::deleteTable):
        (JSC::setUpStaticFunctionSlot):
        * kjs/lookup.h:
        (JSC::HashEntry::initialize):
        (JSC::HashEntry::setKey):
        (JSC::HashEntry::key):
        (JSC::HashEntry::attributes):
        (JSC::HashEntry::function):
        (JSC::HashEntry::functionLength):
        (JSC::HashEntry::propertyGetter):
        (JSC::HashEntry::propertyPutter):
        (JSC::HashEntry::lexerValue):
        (JSC::HashEntry::):
        (JSC::HashTable::entry):
        (JSC::getStaticPropertySlot):
        (JSC::getStaticValueSlot):
        (JSC::lookupPut):

WebCore:

2008-09-26  Sam Weinig  <sam@webkit.org>

        Reviewed by Darin Adler.

        Patch for https://bugs.webkit.org/show_bug.cgi?id=21152
        Speedup static property get/put

        * DerivedSources.make:
        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSDOMBinding.cpp:
        * bindings/js/JSDOMBinding.h:
        * bindings/js/JSDOMWindowBase.cpp:
        (WebCore::getDOMConstructor):
        (WebCore::jsDOMWindowBaseCrypto):
        (WebCore::jsDOMWindowBaseEvent):
        (WebCore::jsDOMWindowBaseImage):
        (WebCore::jsDOMWindowBaseMessageChannel):
        (WebCore::jsDOMWindowBaseOption):
        (WebCore::jsDOMWindowBaseXMLHttpRequest):
        (WebCore::jsDOMWindowBaseAudio):
        (WebCore::jsDOMWindowBaseXSLTProcessor):
        (WebCore::jsDOMWindowBaseOnabort):
        (WebCore::jsDOMWindowBaseOnblur):
        (WebCore::jsDOMWindowBaseOnchange):
        (WebCore::jsDOMWindowBaseOnclick):
        (WebCore::jsDOMWindowBaseOndblclick):
        (WebCore::jsDOMWindowBaseOnerror):
        (WebCore::jsDOMWindowBaseOnfocus):
        (WebCore::jsDOMWindowBaseOnkeydown):
        (WebCore::jsDOMWindowBaseOnkeypress):
        (WebCore::jsDOMWindowBaseOnkeyup):
        (WebCore::jsDOMWindowBaseOnload):
        (WebCore::jsDOMWindowBaseOnmousedown):
        (WebCore::jsDOMWindowBaseOnmousemove):
        (WebCore::jsDOMWindowBaseOnmouseout):
        (WebCore::jsDOMWindowBaseOnmouseover):
        (WebCore::jsDOMWindowBaseOnmouseup):
        (WebCore::jsDOMWindowBaseOnMouseWheel):
        (WebCore::jsDOMWindowBaseOnreset):
        (WebCore::jsDOMWindowBaseOnresize):
        (WebCore::jsDOMWindowBaseOnscroll):
        (WebCore::jsDOMWindowBaseOnsearch):
        (WebCore::jsDOMWindowBaseOnselect):
        (WebCore::jsDOMWindowBaseOnsubmit):
        (WebCore::jsDOMWindowBaseOnbeforeunload):
        (WebCore::jsDOMWindowBaseOnunload):
        (WebCore::jsDOMWindowBaseOnWebKitAnimationStart):
        (WebCore::jsDOMWindowBaseOnWebKitAnimationIteration):
        (WebCore::jsDOMWindowBaseOnWebKitAnimationEnd):
        (WebCore::jsDOMWindowBaseOnWebKitTransitionEnd):
        (WebCore::JSDOMWindowBase::getOwnPropertySlot):
        (WebCore::JSDOMWindowBase::put):
        (WebCore::setJSDOMWindowBaseOnabort):
        (WebCore::setJSDOMWindowBaseOnblur):
        (WebCore::setJSDOMWindowBaseOnchange):
        (WebCore::setJSDOMWindowBaseOnclick):
        (WebCore::setJSDOMWindowBaseOndblclick):
        (WebCore::setJSDOMWindowBaseOnerror):
        (WebCore::setJSDOMWindowBaseOnfocus):
        (WebCore::setJSDOMWindowBaseOnkeydown):
        (WebCore::setJSDOMWindowBaseOnkeypress):
        (WebCore::setJSDOMWindowBaseOnkeyup):
        (WebCore::setJSDOMWindowBaseOnload):
        (WebCore::setJSDOMWindowBaseOnmousedown):
        (WebCore::setJSDOMWindowBaseOnmousemove):
        (WebCore::setJSDOMWindowBaseOnmouseout):
        (WebCore::setJSDOMWindowBaseOnmouseover):
        (WebCore::setJSDOMWindowBaseOnmouseup):
        (WebCore::setJSDOMWindowBaseOnMouseWheel):
        (WebCore::setJSDOMWindowBaseOnreset):
        (WebCore::setJSDOMWindowBaseOnresize):
        (WebCore::setJSDOMWindowBaseOnscroll):
        (WebCore::setJSDOMWindowBaseOnsearch):
        (WebCore::setJSDOMWindowBaseOnselect):
        (WebCore::setJSDOMWindowBaseOnsubmit):
        (WebCore::setJSDOMWindowBaseOnbeforeunload):
        (WebCore::setJSDOMWindowBaseOnunload):
        (WebCore::setJSDOMWindowBaseOnWebKitAnimationStart):
        (WebCore::setJSDOMWindowBaseOnWebKitAnimationIteration):
        (WebCore::setJSDOMWindowBaseOnWebKitAnimationEnd):
        (WebCore::setJSDOMWindowBaseOnWebKitTransitionEnd):
        (WebCore::setJSDOMWindowBaseEvent):
        (WebCore::setJSDOMWindowBaseAudio):
        (WebCore::setJSDOMWindowBaseImage):
        (WebCore::setJSDOMWindowBaseMessageChannel):
        (WebCore::setJSDOMWindowBaseOption):
        (WebCore::setJSDOMWindowBaseXMLHttpRequest):
        (WebCore::setJSDOMWindowBaseXSLTProcessor):
        * bindings/js/JSDOMWindowBase.h:
        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::nonCachingStaticCloseFunctionGetter):
        (WebCore::nonCachingStaticBlurFunctionGetter):
        (WebCore::nonCachingStaticFocusFunctionGetter):
        (WebCore::nonCachingStaticPostMessageFunctionGetter):
        * bindings/js/JSDOMWindowCustom.h:
        (WebCore::JSDOMWindow::customGetOwnPropertySlot):
        * bindings/js/JSEventTargetBase.cpp:
        * bindings/js/JSEventTargetBase.h:
        (WebCore::JSEventTargetBasePrototype::getOwnPropertySlot):
        (WebCore::JSEventTargetBasePrototype::classInfo):
        * bindings/js/JSEventTargetNode.cpp:
        (WebCore::):
        (WebCore::JSEventTargetNode::getOwnPropertySlot):
        (WebCore::JSEventTargetNode::put):
        * bindings/js/JSEventTargetNode.h:
        (WebCore::JSEventTargetNode::classInfo):
        (WebCore::JSEventTargetNode::prototypeClassName):
        * bindings/js/JSEventTargetSVGElementInstance.cpp:
        (WebCore::):
        (WebCore::JSEventTargetSVGElementInstance::getOwnPropertySlot):
        (WebCore::JSEventTargetSVGElementInstance::put):
        * bindings/js/JSEventTargetSVGElementInstance.h:
        (WebCore::JSEventTargetSVGElementInstance::classInfo):
        (WebCore::JSEventTargetSVGElementInstance::prototypeClassName):
        * bindings/js/JSHTMLInputElementCustom.cpp:
        (WebCore::JSHTMLInputElement::customGetOwnPropertySlot):
        * bindings/js/JSHistoryCustom.cpp:
        (WebCore::nonCachingStaticBackFunctionGetter):
        (WebCore::nonCachingStaticForwardFunctionGetter):
        (WebCore::nonCachingStaticGoFunctionGetter):
        (WebCore::JSHistory::customGetOwnPropertySlot):
        * bindings/js/JSLocationCustom.cpp:
        (WebCore::nonCachingStaticReplaceFunctionGetter):
        (WebCore::nonCachingStaticReloadFunctionGetter):
        (WebCore::nonCachingStaticAssignFunctionGetter):
        (WebCore::JSLocation::customGetOwnPropertySlot):
        (WebCore::JSLocation::customPut):
        * bindings/scripts/CodeGeneratorJS.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-09-26 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Sat, 27 Sep 2008 01:44:15 +0000 (01:44 +0000)]
2008-09-26  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Maciej Stachowiak & Oliver Hunt.

        Add support for reusing temporary JSNumberCells.  This change is based on the observation
        that if the result of certain operations is a JSNumberCell and is consumed by a subsequent
        operation that would produce a JSNumberCell, we can reuse the object rather than allocating
        a fresh one.  E.g. given the expression ((a * b) * c), we can statically determine that
        (a * b) will have a numeric result (or else it will have thrown an exception), so the result
        will either be a JSNumberCell or a JSImmediate.

        This patch changes three areas of JSC:
            * The AST now tracks type information about the result of each node.
            * This information is consumed in bytecode compilation, and certain bytecode operations
              now carry the statically determined type information about their operands.
            * CTI uses the information in a number of fashions:
                * Where an operand to certain arithmetic operations is reusable, it will plant code
                  to try to perform the operation in JIT code & reuse the cell, where appropriate.
                * Where it can be statically determined that an operand can only be numeric (typically
                  the result of another arithmetic operation) the code will not redundantly check that
                  the JSCell is a JSNumberCell.
                * Where either of the operands to an add are non-numeric do not plant an optimized
                  arithmetic code path, just call straight out to the C function.

        +6% Sunspider (10% progression on 3D, 16% progression on math, 60% progression on access-nbody),
        +1% v8-tests (improvements in raytrace & crypto)

        * VM/CTI.cpp: Add optimized code generation with reuse of temporary JSNumberCells.
        * VM/CTI.h:
        * kjs/JSNumberCell.h:
        * masm/X86Assembler.h:

        * VM/CodeBlock.cpp: Add type information to specific bytecodes.
        * VM/CodeGenerator.cpp:
        * VM/CodeGenerator.h:
        * VM/Machine.cpp:

        * kjs/nodes.cpp: Track static type information for nodes.
        * kjs/nodes.h:
        * kjs/ResultDescriptor.h: (Added)
        * JavaScriptCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-09-26 Alice Liu <alice.liu@apple.com>
alice.liu@apple.com [Fri, 26 Sep 2008 23:01:03 +0000 (23:01 +0000)]
2008-09-26  Alice Liu  <alice.liu@apple.com>

        Remove usage of atlstr.h and CString for VCExpress compatibility

        Reviewed by Stephanie Lewis.

        * record-memory-win/main.cpp:
        (ProcessArgs):
        (UseImage):
        (QueryContinuously):
        (OneQuery):
        (OneQueryMP):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-09-26 Yichao Yin <yichao.yin@torchmobile.com.cn>
staikos@webkit.org [Fri, 26 Sep 2008 22:45:51 +0000 (22:45 +0000)]
2008-09-26  Yichao Yin  <yichao.yin@torchmobile.com.cn>

        Reviewed by George Staikos, Maciej Stachowiak.

        Add utility functions needed for upcoming WML code.

        * wtf/ASCIICType.h:
        (WTF::isASCIIPrintable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-09-26 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Fri, 26 Sep 2008 22:43:16 +0000 (22:43 +0000)]
2008-09-26  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Darin Adler.

        Reverted the part of r36614 that used static data because static data
        is not thread-safe.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-09-26 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Fri, 26 Sep 2008 22:40:26 +0000 (22:40 +0000)]
2008-09-26  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Maciej Stachowiak.

        Removed dynamic check for whether the callee needs an activation object.
        Replaced with callee code to create the activation object.

        0.5% speedup on SunSpider.
        No change on v8 benchmark. (Might be a speedup, but it's in range of the
        variance.)

        0.7% speedup on v8 benchmark in bytecode.
        1.3% speedup on empty call benchmark in bytecode.

        * VM/CTI.cpp:
        (JSC::CTI::privateCompileMainPass): Added support for op_init_activation,
        the new opcode that specifies that the callee's initialization should
        create an activation object.
        (JSC::CTI::privateCompile): Removed previous code that did a similar
        thing in an ad-hoc way.

        * VM/CodeBlock.cpp:
        (JSC::CodeBlock::dump): Added a case for dumping op_init_activation.

        * VM/CodeGenerator.cpp:
        (JSC::CodeGenerator::generate): Added fixup code to change op_init to
        op_init_activation if necessary. (With a better parser, we would know
        which to use from the beginning.)

        * VM/Instruction.h:
        (JSC::Instruction::Instruction):
        (WTF::): Faster traits for the instruction vector. An earlier version
        of this patch relied on inserting at the beginning of the vector, and
        depended on this change for speed.

        * VM/Machine.cpp:
        (JSC::Machine::execute): Removed clients of setScopeChain, the old
        abstraction for dynamically checking for whether an activation object
        needed to be created.
        (JSC::Machine::privateExecute): ditto

        (JSC::Machine::cti_op_push_activation): Renamed this function from
        cti_vm_updateScopeChain, and made it faster by removing the call to
        setScopeChain.
        * VM/Machine.h:

        * VM/Opcode.h: Declared op_init_activation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agofix Win bustage.
hyatt@apple.com [Fri, 26 Sep 2008 21:57:52 +0000 (21:57 +0000)]
fix Win bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agofix Win bustage.
hyatt@apple.com [Fri, 26 Sep 2008 21:53:19 +0000 (21:53 +0000)]
fix Win bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix Win bustage.
hyatt@apple.com [Fri, 26 Sep 2008 21:45:49 +0000 (21:45 +0000)]
Fix Win bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix Qt bustage.
hyatt@apple.com [Fri, 26 Sep 2008 21:35:55 +0000 (21:35 +0000)]
Fix Qt bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agowx build fix. Update the version of libpng.
kevino@webkit.org [Fri, 26 Sep 2008 21:35:06 +0000 (21:35 +0000)]
wx build fix. Update the version of libpng.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix Qt bustage.
hyatt@apple.com [Fri, 26 Sep 2008 21:22:41 +0000 (21:22 +0000)]
Fix Qt bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix gtk bustage.
hyatt@apple.com [Fri, 26 Sep 2008 21:00:05 +0000 (21:00 +0000)]
Fix gtk bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix gtk bustage.
hyatt@apple.com [Fri, 26 Sep 2008 20:54:48 +0000 (20:54 +0000)]
Fix gtk bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
hyatt@apple.com [Fri, 26 Sep 2008 20:49:34 +0000 (20:49 +0000)]
WebCore:

2008-09-26  David Hyatt  <hyatt@apple.com>

        https://bugs.webkit.org/show_bug.cgi?id=21149

        Make the concept of scroll modes cross-platform.  Move the scrollbars up into ScrollView as well.
        Eliminate the unused isScrollable() method.

        Reviewed by Sam Weinig

        * WebCore.base.exp:
        * page/FrameView.cpp:
        (WebCore::FrameView::resetScrollbars):
        (WebCore::FrameView::initScrollbars):
        (WebCore::FrameView::layout):
        * page/FrameView.h:
        * page/mac/WebCoreFrameView.h:
        * platform/ScrollView.cpp:
        (WebCore::ScrollView::init):
        (WebCore::ScrollView::setScrollbarModes):
        (WebCore::ScrollView::scrollbarModes):
        (WebCore::ScrollView::platformSetScrollbarModes):
        (WebCore::ScrollView::platformScrollbarModes):
        * platform/ScrollView.h:
        (WebCore::ScrollView::horizontalScrollbar):
        (WebCore::ScrollView::verticalScrollbar):
        (WebCore::ScrollView::isScrollViewScrollbar):
        (WebCore::ScrollView::setHorizontalScrollbarMode):
        (WebCore::ScrollView::setVerticalScrollbarMode):
        (WebCore::ScrollView::horizontalScrollbarMode):
        (WebCore::ScrollView::verticalScrollbarMode):
        (WebCore::ScrollView::convertSelfToChild):
        * platform/gtk/ScrollViewGtk.cpp:
        (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
        (WebCore::ScrollView::ScrollViewPrivate::setHasHorizontalScrollbar):
        (WebCore::ScrollView::ScrollViewPrivate::setHasVerticalScrollbar):
        (WebCore::ScrollView::ScrollViewPrivate::valueChanged):
        (WebCore::ScrollView::updateScrollbars):
        (WebCore::ScrollView::scrollbarUnderMouse):
        (WebCore::ScrollView::isScrollViewScrollbar):
        (WebCore::ScrollView::paint):
        (WebCore::ScrollView::scroll):
        * platform/mac/ScrollViewMac.mm:
        (WebCore::ScrollView::platformSetScrollbarModes):
        (WebCore::ScrollView::platformScrollbarModes):
        * platform/qt/ScrollViewQt.cpp:
        (WebCore::ScrollView::ScrollViewPrivate::setHasHorizontalScrollbar):
        (WebCore::ScrollView::ScrollViewPrivate::setHasVerticalScrollbar):
        (WebCore::ScrollView::ScrollViewPrivate::valueChanged):
        (WebCore::ScrollView::horizontalScrollbar):
        (WebCore::ScrollView::verticalScrollbar):
        (WebCore::ScrollView::invalidateScrollbars):
        (WebCore::ScrollView::updateScrollbars):
        (WebCore::ScrollView::scrollbarUnderMouse):
        (WebCore::ScrollView::paint):
        (WebCore::ScrollView::scroll):
        * platform/win/ScrollViewWin.cpp:
        (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
        (WebCore::ScrollView::ScrollViewPrivate::setHasHorizontalScrollbar):
        (WebCore::ScrollView::ScrollViewPrivate::setHasVerticalScrollbar):
        (WebCore::ScrollView::ScrollViewPrivate::valueChanged):
        (WebCore::ScrollView::ScrollViewPrivate::setAllowsScrolling):
        (WebCore::ScrollView::ScrollViewPrivate::allowsScrolling):
        (WebCore::ScrollView::suppressScrollbars):
        (WebCore::ScrollView::updateScrollbars):
        (WebCore::ScrollView::scrollbarUnderMouse):
        (WebCore::ScrollView::paint):
        (WebCore::ScrollView::scroll):
        * platform/wx/ScrollViewWx.cpp:
        (WebCore::ScrollView::platformSetScrollbarModes):
        (WebCore::ScrollView::platformScrollbarModes):

WebKit/mac:

2008-09-26  David Hyatt  <hyatt@apple.com>

        https://bugs.webkit.org/show_bug.cgi?id=21149

        More refactoring to make scrollbar modes cross-platform.  Reduce the protocol that
        WebDynamicScrollBarsView has to implement for communicating with WebCore to just three methods.

        Reviewed by Sam Weinig

        * WebView/WebDynamicScrollBarsView.m:
        (-[WebDynamicScrollBarsView scrollingModes:WebCore::vertical:WebCore::]):
        (-[WebDynamicScrollBarsView setHorizontalScrollingMode:andLock:]):
        (-[WebDynamicScrollBarsView setVerticalScrollingMode:andLock:]):
        (-[WebDynamicScrollBarsView setScrollingModes:vertical:andLock:]):
        * WebView/WebDynamicScrollBarsViewInternal.h:
        * WebView/WebFrameView.mm:
        (-[WebFrameView setAllowsScrolling:]):
        * WebView/WebView.mm:
        (-[WebView setAlwaysShowVerticalScroller:]):
        (-[WebView setAlwaysShowHorizontalScroller:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix Mac build with XPATH and XSLT disabled
ddkilzer@apple.com [Fri, 26 Sep 2008 20:47:58 +0000 (20:47 +0000)]
Fix Mac build with XPATH and XSLT disabled

WebCore:

        Fix Mac build with XPATH and XSLT disabled

        Reviewed by Alexey.

        * bindings/objc/DOMUtility.mm:
        (JSC::createDOMWrapper): Conditionalize code with ENABLE(XPATH).
        * dom/XMLTokenizerLibxml2.cpp:
        (WebCore::errorFunc): Conditionalize method with ENABLE(XSLT) to
        prevent an unused code warning.

WebKit/mac:

        Fix Mac build with XSLT disabled

        Reviewed by Alexey.

        * Misc/WebCache.mm:
        (+[WebCache statistics]): Populate xslStyleSheet statistics with
        zeros if XSLT is disabled.

WebKit/win:

        Speculative Windows build fix with XSLT disabled

        Reviewed by Alexey.

        * WebCache.cpp:
        (WebCache::statistics): Populate xslStyleSheet statistics with
        zeros if XSLT is disabled.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36961 268f45cc-cd09-0410-ab3c-d52691b4dbfc