levin@chromium.org [Thu, 16 Jul 2009 00:14:36 +0000 (00:14 +0000)]
WebCore:
2009-07-15 David Levin <levin@chromium.org>
Layout test fix, reverting previous change.
Reverting r45962 as it caused several layout test failures.
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::parseMappedAttribute):
* rendering/RenderTextControlMultiLine.cpp:
(WebCore::RenderTextControlMultiLine::createInnerTextStyle):
LayoutTests:
2009-07-15 David Levin <levin@chromium.org>
Layout test fix, reverting previous change.
Reverting r45962 as it caused several layout test failures.
* fast/forms/basic-textareas.html:
* platform/mac/fast/forms/basic-textareas-expected.checksum:
* platform/mac/fast/forms/basic-textareas-expected.png:
* platform/mac/fast/forms/basic-textareas-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45963
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Wed, 15 Jul 2009 23:46:09 +0000 (23:46 +0000)]
2009-06-08 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Eric Seidel.
Setting white-space and word-wrap via CSS in textarea doesn't override the wrap attribute
https://bugs.webkit.org/show_bug.cgi?id=26254
WebCore:
Make it so that setting white-space and word-wrap via CSS
overrides the wrap attribute.
This involves having the shadow div in the textarea inherit
the CSS from its parent instead of hard-coding it in
RenderTextControlMultiline.
* css/html4.css:
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::parseMappedAttribute):
* rendering/RenderTextControlMultiLine.cpp:
(WebCore::RenderTextControlMultiLine::createInnerTextStyle):
LayoutTests:
Make it so that setting white-space and word-wrap via CSS
overrides the wrap attribute.
This involves having the shadow div in the textarea inherit
the CSS from its parent instead of hard-coding it in
RenderTextControlMultiline.
* fast/forms/basic-textareas.html:
* platform/mac/fast/forms/basic-textareas-expected.checksum:
* platform/mac/fast/forms/basic-textareas-expected.png:
* platform/mac/fast/forms/basic-textareas-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45962
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
japhet@chromium.org [Wed, 15 Jul 2009 23:18:57 +0000 (23:18 +0000)]
2009-07-15 Dumitru Daniliuc <dumi@chromium.org>
Reviewed by Dimitri Glazkov.
Adding the Win SQLite VFS implementation for Chromium.
https://bugs.webkit.org/show_bug.cgi?id=26940
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45959
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jianli@chromium.org [Wed, 15 Jul 2009 23:15:40 +0000 (23:15 +0000)]
WebCore:
2009-07-15 Jian Li <jianli@chromium.org>
Reviewed by David Levin.
Bug 25151 - workers that fail to load scripts not firing error event.
https://bugs.webkit.org/show_bug.cgi?id=25151
This fixes the problem that an error event is not fired when the worker
script fails to load. Some reasons this may occur are an invalid URL for
the worker script or a cross-origin redirect.
We also moves the code to complete the URL and check its origin from
Worker constructor to WorkerScriptLoader loading functions in order to
move the exception throwing logic out of the scope of Worker constructor.
Due to this change, we also remove the output ExceptionCode parameter
in the worker constructor. Corresponding JS/V8 binding codes have been
updated to reflect this change.
* bindings/js/JSWorkerConstructor.cpp:
(WebCore::constructWorker):
* bindings/v8/custom/V8WorkerCustom.cpp:
(WebCore::CALLBACK_FUNC_DECL):
* workers/Worker.cpp:
(WebCore::Worker::Worker):
(WebCore::Worker::notifyFinished):
* workers/Worker.h:
(WebCore::Worker::create):
* workers/WorkerContext.cpp:
(WebCore::WorkerContext::importScripts):
* workers/WorkerScriptLoader.cpp:
(WebCore::toCrossOriginRedirectPolicy):
(WebCore::WorkerScriptLoader::loadSynchronously):
(WebCore::WorkerScriptLoader::loadAsynchronously):
(WebCore::notifyLoadErrorTask):
(WebCore::WorkerScriptLoader::createResourceRequest):
(WebCore::WorkerScriptLoader::didFail):
(WebCore::WorkerScriptLoader::didFailRedirectCheck):
(WebCore::WorkerScriptLoader::didReceiveAuthenticationCancellation):
(WebCore::WorkerScriptLoader::notifyError):
* workers/WorkerScriptLoader.h:
(WebCore::):
(WebCore::WorkerScriptLoader::url):
LayoutTests:
2009-07-15 Jian Li <jianli@chromium.org>
Reviewed by David Levin.
Bug 25151 - workers that fail to load scripts not firing error event.
https://bugs.webkit.org/show_bug.cgi?id=25151
Updates layout test cases for bug 25151.
* fast/workers/worker-constructor-expected.txt:
* fast/workers/worker-constructor.html:
* http/tests/workers/worker-redirect-expected.txt:
* http/tests/workers/worker-redirect.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45958
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Wed, 15 Jul 2009 23:11:18 +0000 (23:11 +0000)]
WebCore:
Reviewed by Dave Hyatt.
text-shadow is not drawn for text with transparent colour
https://bugs.webkit.org/show_bug.cgi?id=21374
Test: fast/text/shadow-translucent-fill.html
* rendering/InlineTextBox.cpp:
(WebCore::paintTextWithShadows): If the text fill color is not opaque,
paint all shadows separately from the text, by casting them from
clipped-out opaque text.
LayoutTests:
Reviewed by Dave Hyatt.
text-shadow is not drawn for text with transparent colour
https://bugs.webkit.org/show_bug.cgi?id=21374
* fast/text/shadow-translucent-fill.html: Added.
* platform/mac/fast/css/shadow-multiple-expected.checksum:
* platform/mac/fast/css/shadow-multiple-expected.png:
* platform/mac/fast/text/shadow-translucent-fill-expected.checksum: Added.
* platform/mac/fast/text/shadow-translucent-fill-expected.png: Added.
* platform/mac/fast/text/shadow-translucent-fill-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45956
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
treat@webkit.org [Wed, 15 Jul 2009 23:02:01 +0000 (23:02 +0000)]
2009-07-15 Adam Treat <adam.treat@torchmobile.com>
Fix the Qt build.
* html/HTMLAreaElement.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45955
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@chromium.org [Wed, 15 Jul 2009 22:56:00 +0000 (22:56 +0000)]
2009-07-15 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Fisher.
Cleanup DOM Storage dependencies.
https://bugs.webkit.org/show_bug.cgi?id=27180
DOM Storage had several unnecessary (and probably unintended)
dependencies. This patch replaces many includes of header files with
forward declaration of classes, making some destructors explicit, and
taking some factories out of the header files.
This will allow things like StorageAreaSync to take a StorageAreaImpl*
(as it should) rather than a StorageArea* which previously weren't
possible because the dependencies were such a tangled mess.
* storage/LocalStorageTask.cpp:
(WebCore::LocalStorageTask::~LocalStorageTask):
* storage/LocalStorageTask.h:
* storage/Storage.cpp:
(WebCore::Storage::~Storage):
* storage/Storage.h:
* storage/StorageArea.cpp:
* storage/StorageArea.h:
* storage/StorageAreaImpl.cpp:
* storage/StorageAreaImpl.h:
* storage/StorageAreaSync.cpp:
(WebCore::StorageAreaSync::~StorageAreaSync):
* storage/StorageAreaSync.h:
* storage/StorageEvent.cpp:
(WebCore::StorageEvent::create):
(WebCore::StorageEvent::StorageEvent):
* storage/StorageEvent.h:
* storage/StorageNamespace.h:
* storage/StorageNamespaceImpl.cpp:
* storage/StorageNamespaceImpl.h:
* storage/StorageSyncManager.cpp:
(WebCore::StorageSyncManager::~StorageSyncManager):
* storage/StorageSyncManager.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45954
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cmarrin@apple.com [Wed, 15 Jul 2009 22:33:18 +0000 (22:33 +0000)]
Incorrect animation when trying to duplicate effect of transform-origin
https://bugs.webkit.org/show_bug.cgi?id=27310
The bug is that matrix animation is being used when animating
a list of transform functions that match in the from and to states.
This sometimes works. But because of the way CA does matrix animation
function lists like the one shown in the testcase animate incorrectly.
This fixes the bug by always doing component animation
as long as the function lists match. This allows CA
to animate the components and then recompose the result
into the correct matrix.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45953
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jianli@chromium.org [Wed, 15 Jul 2009 22:29:27 +0000 (22:29 +0000)]
2009-07-15 Albert J. Wong <ajwong@chromium.org>
Reviewed by David Levin.
Upstream the V8NPObject and NPV8Object build changes for WebCore.gypi.
Add upstreamed V8 bindings files into WebCore.gypi so they can be seen
downstream
https://bugs.webkit.org/show_bug.cgi?id=27274
Changes the build file for chromium. Test built the chromium tree
to verify.
* WebCore.gypi:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45952
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Wed, 15 Jul 2009 22:24:25 +0000 (22:24 +0000)]
I like it when the code compiles.
* WebCore.base.exp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45951
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Wed, 15 Jul 2009 22:02:04 +0000 (22:02 +0000)]
2009-07-15 Steve Falkenburg <sfalken@apple.com>
Windows Build fix.
Visual Studio reset our intermediate directory on us.
This sets it back.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.vcproj/testapi/testapi.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45949
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Wed, 15 Jul 2009 21:50:57 +0000 (21:50 +0000)]
WebCore:
2009-07-15 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
Renamed parseURL to deprecatedParseURL.
* bindings/js/JSAttrCustom.cpp:
(WebCore::JSAttr::setValue): Renamed.
* bindings/js/JSElementCustom.cpp:
(WebCore::allowSettingSrcToJavascriptURL): Renamed.
* bindings/js/JSHTMLFrameElementCustom.cpp:
(WebCore::allowSettingJavascriptURL): Renamed.
* bindings/js/JSHTMLIFrameElementCustom.cpp:
(WebCore::JSHTMLIFrameElement::setSrc): Renamed.
* bindings/objc/DOM.mm:
(-[DOMElement _getURLAttribute:]): Renamed.
* bindings/objc/DOMHTML.mm:
(-[DOMHTMLDocument _createDocumentFragmentWithMarkupString:baseURLString:]): Renamed.
* bindings/v8/custom/V8CustomBinding.cpp:
(WebCore::allowSettingFrameSrcToJavascriptUrl): Renamed.
* css/CSSHelper.cpp:
(WebCore::deprecatedParseURL): Renamed.
* css/CSSHelper.h: Renamed and updated comment.
* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::defaultEventHandler): Renamed.
(WebCore::HTMLAnchorElement::parseMappedAttribute): Renamed.
* html/HTMLBaseElement.cpp:
(WebCore::HTMLBaseElement::parseMappedAttribute): Renamed.
* html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::parseMappedAttribute): Renamed.
* html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::parseMappedAttribute): Renamed.
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::parseMappedAttribute): Renamed.
* html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::parseMappedAttribute): Renamed.
* html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::parseMappedAttribute): Renamed.
* html/HTMLImageLoader.cpp:
(WebCore::HTMLImageLoader::sourceURI): Renamed.
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::parseMappedAttribute): Renamed.
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::parseMappedAttribute): Renamed.
* html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::parseMappedAttribute): Renamed.
* html/HTMLTablePartElement.cpp:
(WebCore::HTMLTablePartElement::parseMappedAttribute): Renamed.
* html/HTMLTokenizer.cpp:
(WebCore::HTMLTokenizer::parseTag): Renamed.
* html/PreloadScanner.cpp:
(WebCore::PreloadScanner::processAttribute): Renamed.
(WebCore::PreloadScanner::emitCSSRule): Renamed.
* platform/chromium/ClipboardChromium.cpp:
(WebCore::ClipboardChromium::declareAndWriteDragImage): Renamed.
* platform/chromium/PasteboardChromium.cpp:
(WebCore::Pasteboard::writeImage): Renamed.
* platform/qt/ClipboardQt.cpp:
(WebCore::ClipboardQt::declareAndWriteDragImage): Renamed.
* platform/win/ClipboardWin.cpp:
(WebCore::ClipboardWin::declareAndWriteDragImage): Renamed.
* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::absoluteImageURL): Renamed.
(WebCore::HitTestResult::absoluteMediaURL): Renamed.
(WebCore::HitTestResult::absoluteLinkURL): Renamed.
* svg/SVGAElement.cpp:
(WebCore::SVGAElement::defaultEventHandler): Renamed.
* svg/SVGImageLoader.cpp:
(WebCore::SVGImageLoader::sourceURI): Renamed.
* wml/WMLAElement.cpp:
(WebCore::WMLAElement::defaultEventHandler): Renamed.
* wml/WMLImageLoader.cpp:
(WebCore::WMLImageLoader::sourceURI): Renamed.
WebKit/mac:
2009-07-15 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
Renamed parseURL to deprecatedParseURL.
* DOM/WebDOMOperations.mm:
(-[DOMDocument URLWithAttributeString:]): Renamed.
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::createPlugin): Renamed.
WebKit/win:
2009-07-15 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
Renamed parseURL to deprecatedParseURL.
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::createPlugin): Renamed.
WebKitTools:
2009-07-15 Darin Adler <darin@apple.com>
* Scripts/do-webcore-rename: Check in the version used to
rename parseURL to deprecatedParseURL.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45947
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Wed, 15 Jul 2009 21:44:21 +0000 (21:44 +0000)]
WebCore:
2009-07-15 Darin Adler <darin@apple.com>
Reviewed by Dan Bernstein.
CSSHelper.h's parseURL is a function that no one should ever call
Part 1: Eliminate callers in the CSS parser.
https://bugs.webkit.org/show_bug.cgi?id=26599
Test: fast/css/uri-token-parsing.html
* css/CSSHelper.h: Added a comment explaining why nobody should ever call this
function. A FIXME suggests a next step, which would be to rename it deprecatedParseURL.
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue): Removed unneeded call to parseURL;
CSSParser::text already takes care of parsing the URI token syntax, and the
parseURL function does no good.
(WebCore::CSSParser::parseContent): Ditto.
(WebCore::CSSParser::parseFillImage): Ditto.
(WebCore::CSSParser::parseFontFaceSrc): Ditto.
(WebCore::CSSParser::parseBorderImage): Ditto.
(WebCore::isCSSWhitespace): Added. Helper function that makes the text function
easier to read.
(WebCore::CSSParser::text): Tweak logic so that leading and trailing whitespace
are both trimmed before removing the quote marks. Changed to use the
isCSSWhitespace, isASCIIHexDigit, and toASCIIHexValue functions for clarity.
* css/CSSParser.h: Removed stray "public:" in this header.
* platform/text/StringImpl.cpp:
(WebCore::StringImpl::substring): Optimized the case where the substring covers
the entire string, so we just share the StringImpl instead of making a new one.
This case came up in earlier versions of the CSS parser changes above.
(WebCore::StringImpl::substringCopy): Streamlined the logic here and made it
not call substring any more. Before, this was relying on the substring function
always making a copy of any non-empty substring.
LayoutTests:
2009-07-15 Darin Adler <darin@apple.com>
Reviewed by Dan Bernstein.
CSSHelper.h's parseURL is a function that no one should ever call
Part 1: Eliminate callers in the CSS parser.
https://bugs.webkit.org/show_bug.cgi?id=26599
* fast/css/uri-token-parsing-expected.txt: Added.
* fast/css/uri-token-parsing.html: Added. Tests URI token parsing cases, many of which
were handled wrong before due to stripping quotes and URL() twice.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45946
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Wed, 15 Jul 2009 21:35:36 +0000 (21:35 +0000)]
WebCore:
2009-07-15 Darin Adler <darin@apple.com>
Reviewed by John Sullivan.
After double-clicking a word, using Shift-arrow to select behaves unpredictably
https://bugs.webkit.org/show_bug.cgi?id=27177
rdar://problem/
7034324
Test: editing/selection/extend-selection-after-double-click.html
The bug was due to the m_lastChangeWasHorizontalExtension flag, which was not
being cleared in many cases where it should have been.
* editing/SelectionController.cpp:
(WebCore::SelectionController::setSelection): Set m_lastChangeWasHorizontalExtension
to false. This catches all sorts of cases that don't flow through the modify function.
Before, the flag would reflect the last call to the modify function, which was not
necessarily the last selection change.
(WebCore::SelectionController::willBeModified): Rearrange function for clarity.
Remove code that sets m_lastChangeWasHorizontalExtension; that is now handled elsewhere.
(WebCore::SelectionController::modify): Call setLastChangeWasHorizontalExtension after
setSelection when setting up a trial selection controller, since setSelection now
clears that flag. Also changed both trial selection controller cases to set the flag,
although it's not strictly necessary in both cases. Added code to set
m_lastChangeWasHorizontalExtension when extending the selection, which used to be
handled in willBeModified. Now we need to do it after the selection change.
LayoutTests:
2009-07-15 Darin Adler <darin@apple.com>
Reviewed by John Sullivan.
After double-clicking a word, using Shift-arrow to select behaves unpredictably
https://bugs.webkit.org/show_bug.cgi?id=27177
rdar://problem/
7034324
* editing/selection/extend-selection-after-double-click-expected.txt: Added.
* editing/selection/extend-selection-after-double-click.html:
Copied from LayoutTests/editing/selection/word-granularity.html.
Then turned it into a new test.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45945
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Wed, 15 Jul 2009 21:16:30 +0000 (21:16 +0000)]
2009-07-15 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Dimitri Glazkov.
Need to update DOM Storage files in GYPI file.
https://bugs.webkit.org/show_bug.cgi?id=27317
Need to update DOM Storage files in the GYPI file. They're pretty out
of date and we're on the path towards enabling them for everyone!
* WebCore.gypi:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45944
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Wed, 15 Jul 2009 20:55:08 +0000 (20:55 +0000)]
JavaScriptCore:
2009-07-15 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=26794
Make Yacc-generated parsers to use fastMalloc/fastFree.
Define YYMALLOC and YYFREE to fastMalloc and fastFree
respectively.
* parser/Grammar.y:
WebCore:
2009-07-15 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=26794
Make Yacc-generated parsers to use fastMalloc/fastFree.
Define YYMALLOC and YYFREE to fastMalloc and fastFree
respectively.
* css/CSSGrammar.y:
* xml/XPathGrammar.y:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45943
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kov@webkit.org [Wed, 15 Jul 2009 20:49:10 +0000 (20:49 +0000)]
2009-07-15 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Rubber-stamped by Jan Alonzo.
Fix enable-xss-auditor property documentation, and default value
to match the fact that it is now enabled by default.
* webkit/webkitwebsettings.cpp:
(webkit_web_settings_class_init):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45942
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Wed, 15 Jul 2009 20:43:46 +0000 (20:43 +0000)]
WebCore:
2009-07-15 David Hyatt <hyatt@apple.com>
Reviewed by Adam Roben.
https://bugs.webkit.org/show_bug.cgi?id=27193
Don't run in to anonymous blocks. No other browsers do this, and our implementation of run-in
is effectively broken as a result.
No new tests. Changed fast/runin/001.html and fast/runin/generated.html to match new behavior.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::handleRunInChild):
LayoutTests:
2009-07-15 David Hyatt <hyatt@apple.com>
Reviewed by Adam Roben.
https://bugs.webkit.org/show_bug.cgi?id=27193
Don't let run-ins run in to anonymous blocks.
* fast/runin/001.html:
* fast/runin/generated.html:
* platform/mac/fast/runin/001-expected.checksum:
* platform/mac/fast/runin/001-expected.png:
* platform/mac/fast/runin/001-expected.txt:
* platform/mac/fast/runin/generated-expected.checksum:
* platform/mac/fast/runin/generated-expected.png:
* platform/mac/fast/runin/generated-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45941
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Wed, 15 Jul 2009 20:15:32 +0000 (20:15 +0000)]
2009-07-10 David Kilzer <ddkilzer@apple.com>
bugzilla-tool: create CommitMessage class
Reviewed by Eric Seidel.
Create a CommitMessage class to encapsulate related code.
* Scripts/bugzilla-tool:
(bug_id_from_commit_message): Moved to
CommitMessage.parse_bug_id().
(commit_message_for_this_commit): Return a CommitMessage.
(ApplyPatchesFromBug.apply_patches): Use CommitMessage.message().
(LandPatchesFromBugs.build_and_commit): Ditto.
(CommitMessageForCurrentDiff.execute): Ditto.
(PostCommitsAsPatchesToBug.execute): Switched from
Git.commit_message_for_commit() to
Git.commit_message_for_local_commit(). Switched from
bug_id_from_commit_message() to CommitMessage.parse_bug_id().
* Scripts/modules/scm.py:
(first_non_empty_line_after_index): Added.
(CommitMessage.__init__): Added.
(CommitMessage.body): Added.
(CommitMessage.description): Added.
(CommitMessage.message): Added.
(CommitMessage.parse_bug_id): Added. Moved from
bug_id_from_commit_message() in bugzilla-tool.
(Git.commit_message_for_local_commit): Renamed from
commit_message_for_commit(). Return a CommitMessage.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45940
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Wed, 15 Jul 2009 20:11:01 +0000 (20:11 +0000)]
2009-07-15 Joseph Pecoraro <joepeck02@gmail.com>
Reviewed by David Kilzer.
bugzilla-tool/svn-apply can't handle patches made from a non-root directory
https://bugs.webkit.org/show_bug.cgi?id=26999
* Scripts/svn-create-patch:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45939
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Wed, 15 Jul 2009 20:08:50 +0000 (20:08 +0000)]
WebCore:
2009-07-15 Yuzo Fujishima <yuzo@google.com>
Reviewed by Darin Adler.
Test: fast/js/instanceof-operator.html
Fix for: Bug 25205 - XMLHttpRequest instance is not an instanceof XMLHttpRequest
https://bugs.webkit.org/show_bug.cgi?id=25205
In addition to for XMLHttpRequest, this also fixes for:
- Audio
- Image
- MessageChannel
- Option
- WebKitCSSMatrix
- WebKitPoint
- Worker
- XSLTProcessor
* bindings/js/JSAudioConstructor.cpp:
(WebCore::JSAudioConstructor::JSAudioConstructor):
* bindings/js/JSAudioConstructor.h:
* bindings/js/JSDOMBinding.h:
(WebCore::DOMConstructorObject::createStructure):
(WebCore::DOMConstructorObject::DOMConstructorObject):
* bindings/js/JSImageConstructor.cpp:
(WebCore::JSImageConstructor::JSImageConstructor):
* bindings/js/JSImageConstructor.h:
* bindings/js/JSMessageChannelConstructor.cpp:
(WebCore::JSMessageChannelConstructor::JSMessageChannelConstructor):
* bindings/js/JSMessageChannelConstructor.h:
* bindings/js/JSOptionConstructor.cpp:
(WebCore::JSOptionConstructor::JSOptionConstructor):
* bindings/js/JSOptionConstructor.h:
* bindings/js/JSWebKitCSSMatrixConstructor.cpp:
(WebCore::JSWebKitCSSMatrixConstructor::JSWebKitCSSMatrixConstructor):
* bindings/js/JSWebKitCSSMatrixConstructor.h:
* bindings/js/JSWebKitPointConstructor.cpp:
(WebCore::JSWebKitPointConstructor::JSWebKitPointConstructor):
* bindings/js/JSWebKitPointConstructor.h:
* bindings/js/JSWorkerConstructor.cpp:
(WebCore::JSWorkerConstructor::JSWorkerConstructor):
* bindings/js/JSWorkerConstructor.h:
* bindings/js/JSXMLHttpRequestConstructor.cpp:
(WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor):
* bindings/js/JSXMLHttpRequestConstructor.h:
* bindings/js/JSXSLTProcessorConstructor.cpp:
(WebCore::JSXSLTProcessorConstructor::JSXSLTProcessorConstructor):
* bindings/js/JSXSLTProcessorConstructor.h:
LayoutTests:
2009-07-15 Yuzo Fujishima <yuzo@google.com>
Reviewed by Darin Adler.
Fix for: Bug 25205 - XMLHttpRequest instance is not an instanceof XMLHttpRequest
https://bugs.webkit.org/show_bug.cgi?id=25205
In addition to for XMLHttpRequest, this also fixes for:
- Audio
- Image
- MessageChannel
- Option
- WebKitCSSMatrix
- WebKitPoint
- Worker
- XSLTProcessor
* fast/js/instanceof-operator-expected.txt: Added.
* fast/js/instanceof-operator.html: Added.
* fast/js/resources/instanceof-operator-dummy-worker.js: Added.
* fast/js/resources/instanceof-operator.js: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45938
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Wed, 15 Jul 2009 19:51:15 +0000 (19:51 +0000)]
WebCore:
2009-07-15 Kai Bruning <kai@granus.net>
Reviewed by Dave Hyatt.
CSS21 attribute selectors not dynamic for xml.
https://bugs.webkit.org/show_bug.cgi?id=25072
Moved the relevant test in StyledElement::attributeChanged()
to a new function Element::recalcStyleIfNeededAfterAttributeChanged()
so it can be called from both StyledElement::attributeChanged()
and Element::attributeChanged().
Refactored Element::attributeChanged() into
Element::updateAfterAttributeChanged() and
Element::recalcStyleIfNeededAfterAttributeChanged(), which are called
separately from StyledElement::attributeChanged().
Test: fast/css/attribute-selector-dynamic.xml
* dom/Element.cpp:
(WebCore::Element::attributeChanged):
(WebCore::Element::updateAfterAttributeChanged):
(WebCore::Element::recalcStyleIfNeededAfterAttributeChanged):
* dom/Element.h:
* dom/StyledElement.cpp:
(WebCore::StyledElement::attributeChanged):
LayoutTests:
2009-07-15 Kai Bruning <kai@granus.net>
Reviewed by Dave Hyatt.
CSS21 attribute selectors not dynamic for xml.
https://bugs.webkit.org/show_bug.cgi?id=25072
Test that CSS21 attribute selectors take effect when the attribute is
dynamically changed in an xml dom.
* fast/css/attribute-selector-dynamic.xml: Added.
* platform/mac/fast/css/attribute-selector-dynamic-expected.checksum: Added.
* platform/mac/fast/css/attribute-selector-dynamic-expected.png: Added.
* platform/mac/fast/css/attribute-selector-dynamic-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45937
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Wed, 15 Jul 2009 19:27:19 +0000 (19:27 +0000)]
2009-07-15 Alpha Lam <hclam@chromium.org>
Reviewed by David Levin.
[V8] Layout test failures for drawImage in Canvas
https://bugs.webkit.org/show_bug.cgi?id=27311
Fixing several canvas layout tests failures due to a
missing return statement in CanvasRenderingContext2DDrawImage() which
was accidentally removed in r45929.
* bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45936
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Wed, 15 Jul 2009 19:16:50 +0000 (19:16 +0000)]
2009-07-15 Robert Hogan <robert@roberthogan.net>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=26969
If the httpMethod() of the request passed to SubresourceLoader::create is not
supported by the client we must expect to call didFail() while m_loader is still null.
* loader/DocumentThreadableLoader.cpp:
(DocumentThreadableLoader::didFail):Changed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45935
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 15 Jul 2009 18:34:18 +0000 (18:34 +0000)]
2009-07-15 Joseph Pecoraro <joepeck02@gmail.com>
Reviewed by Sam Weinig.
Side bar linking to "DOM Interfaces" returns 404
https://bugs.webkit.org/show_bug.cgi?id=24000
* nav.inc:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45934
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Wed, 15 Jul 2009 18:28:04 +0000 (18:28 +0000)]
2009-07-15 Darin Adler <darin@apple.com>
Fix a build for a particular Apple configuration.
* wtf/FastAllocBase.h: Change include to use "" style for
including another wtf header. This is the style we use for
including other public headers in the same directory.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45933
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Wed, 15 Jul 2009 18:25:05 +0000 (18:25 +0000)]
Add bug link to changelog entry.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45932
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
treat@webkit.org [Wed, 15 Jul 2009 18:23:28 +0000 (18:23 +0000)]
2009-07-15 George Staikos <george.staikos@torchmobile.com>
Reviewed by Adam Treat.
https://bugs.webkit.org/show_bug.cgi?id=27303
Implement createThreadInternal for WinCE.
Contains changes by George Staikos <george.staikos@torchmobile.com> and Joe Mason <joe.mason@torchmobile.com>
* wtf/ThreadingWin.cpp:
(WTF::createThreadInternal):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45931
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Wed, 15 Jul 2009 18:22:29 +0000 (18:22 +0000)]
Fix the Mac build.
* WebCore.base.exp:
* css/MediaQueryEvaluator.cpp:
* rendering/SVGRenderTreeAsText.cpp:
* rendering/style/SVGRenderStyle.cpp:
* svg/graphics/SVGPaintServer.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45930
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Wed, 15 Jul 2009 18:21:14 +0000 (18:21 +0000)]
2009-07-15 Alpha Lam <hclam@chromium.org>
Reviewed by Dimitri Glazkov.
Changed CanvasRenderingContext2DDrawImage() to accept HTMLVideoElement
as a parameter of drawImage() for HTMLCanvasElement.
* bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45929
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 15 Jul 2009 18:14:23 +0000 (18:14 +0000)]
2009-07-15 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
[V8] Fix isolated world constructors
https://bugs.webkit.org/show_bug.cgi?id=27287
Don't enter V8Proxy::m_context before creating DOM constructors.
Instead, use getWrapperContext to get the right context.
After this patch, all my tests pass. I'll enable the feature
downstream and land the tests.
* bindings/scripts/CodeGeneratorV8.pm:
* bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::getConstructor):
(WebCore::V8DOMWrapper::lookupDOMWrapper):
* bindings/v8/V8DOMWrapper.h:
* bindings/v8/V8IsolatedWorld.cpp:
(WebCore::V8IsolatedWorld::evaluate):
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::createWrapperFromCache):
(WebCore::V8Proxy::isContextInitialized):
(WebCore::V8Proxy::disposeContextHandles):
(WebCore::V8Proxy::installDOMWindow):
(WebCore::V8Proxy::initContextIfNeeded):
(WebCore::V8Proxy::getHiddenObjectPrototype):
(WebCore::V8Proxy::installHiddenObjectPrototype):
* bindings/v8/V8Proxy.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45928
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
treat@webkit.org [Wed, 15 Jul 2009 18:12:33 +0000 (18:12 +0000)]
2009-07-15 Joe Mason <joe.mason@torchmobile.com>
Reviewed by George Staikos.
https://bugs.webkit.org/show_bug.cgi?id=27298
Platform defines for WINCE.
Contains changes by Yong Li <yong.li@torchmobile.com>,
George Staikos <george.staikos@torchmobile.com> and Joe Mason <joe.mason@torchmobile.com>
* wtf/Platform.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45927
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Wed, 15 Jul 2009 18:07:14 +0000 (18:07 +0000)]
2009-07-15 Antonio Gomes <antonio.gomes@openbossa.org>
Reviewed by Darin Adler.
useless null-check statement in visible_units.cpp@logicalStartOfLine
https://bugs.webkit.org/show_bug.cgi?id=27154
Simple fix.
* editing/visible_units.cpp:
(WebCore::logicalStartOfLine): Doubled honorEditableBoundaryAtOrAfter() call removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45926
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Wed, 15 Jul 2009 17:44:46 +0000 (17:44 +0000)]
Attempted Mac Build Fix.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45925
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
treat@webkit.org [Wed, 15 Jul 2009 17:34:49 +0000 (17:34 +0000)]
2009-07-15 Yong Li <yong.li@torchmobile.com>
Reviewed by Adam Treat.
https://bugs.webkit.org/show_bug.cgi?id=27306
Use RegisterClass instead of RegisterClassEx on WinCE.
* wtf/win/MainThreadWin.cpp:
(WTF::initializeMainThreadPlatform):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45924
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Wed, 15 Jul 2009 17:32:33 +0000 (17:32 +0000)]
WebCore:
2009-07-15 Brady Eidson <beidson@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=27304
WebKit should provide usage and eligibility information about the page cache.
* WebCore.base.exp:
* history/CachedFrame.cpp:
(WebCore::CachedFrame::childFrameCount):
* history/CachedFrame.h:
* history/PageCache.cpp:
(WebCore::PageCache::frameCount):
(WebCore::PageCache::autoreleasedPageCount):
* history/PageCache.h:
(WebCore::PageCache::pageCount):
WebKit/mac:
2009-07-15 Brady Eidson <beidson@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=27304
WebKit should provide usage and eligibility information about the page cache.
* Misc/WebCoreStatistics.h:
* Misc/WebCoreStatistics.mm:
(+[WebCoreStatistics numberCachedPages]):
(+[WebCoreStatistics numberCachedFrames]):
(+[WebCoreStatistics numberAutoreleasedPages]):
* WebKit.exp:
* WebView/WebFrame.mm:
(-[WebFrame _cacheabilityDictionary]): Returns a dictionary with all the data about
why the frame is not cacheable. If the frame *is* cacheable, the dictionary is
empty.
* WebView/WebFramePrivate.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45923
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Wed, 15 Jul 2009 17:31:12 +0000 (17:31 +0000)]
2009-07-15 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by David Levin.
Chromium's canvas forgets its context after fillText again
https://bugs.webkit.org/show_bug.cgi?id=27293
No new tests because the test for this was already added in
https://bugs.webkit.org/show_bug.cgi?id=26436
* platform/graphics/chromium/TransparencyWin.cpp:
(WebCore::TransparencyWin::compositeTextComposite):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45922
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
treat@webkit.org [Wed, 15 Jul 2009 17:20:11 +0000 (17:20 +0000)]
2009-07-15 Yong Li <yong.li@torchmobile.com>
Reviewed by George Staikos.
https://bugs.webkit.org/show_bug.cgi?id=27301
Use OutputDebugStringW on WinCE since OutputDebugStringA is not supported
Originally written by Yong Li <yong.li@torchmobile.com> and refactored by
Joe Mason <joe.mason@torchmobile.com>
* wtf/Assertions.cpp: vprintf_stderr_common
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45921
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Wed, 15 Jul 2009 17:07:51 +0000 (17:07 +0000)]
2009-07-15 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by David Levin.
Move cpplint.py to module directory
https://bugs.webkit.org/show_bug.cgi?id=27302
* Scripts/modules/cpplint.py: Renamed from WebKitTools/Scripts/cpplint.py.
* Scripts/modules/cpplint_unittest.py: Renamed from WebKitTools/Scripts/cpplint_unittest.py.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45920
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Wed, 15 Jul 2009 17:02:30 +0000 (17:02 +0000)]
WebCore:
2009-07-14 David Hyatt <hyatt@apple.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=27283
Implement the new 'rem' unit from CSS3.
Added some rem-* tests in fast/css.
* css/CSSGrammar.y:
* css/CSSParser.cpp:
(WebCore::CSSParser::validUnit):
(WebCore::unitFromString):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::lex):
* css/CSSParserValues.cpp:
(WebCore::CSSParserValue::createCSSValue):
* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::computeLengthInt):
(WebCore::CSSPrimitiveValue::computeLengthIntForLength):
(WebCore::CSSPrimitiveValue::computeLengthShort):
(WebCore::CSSPrimitiveValue::computeLengthFloat):
(WebCore::CSSPrimitiveValue::computeLengthDouble):
(WebCore::CSSPrimitiveValue::cssText):
(WebCore::CSSPrimitiveValue::parserValue):
* css/CSSPrimitiveValue.h:
(WebCore::CSSPrimitiveValue::):
(WebCore::CSSPrimitiveValue::isUnitTypeLength):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::initForStyleResolve):
(WebCore::convertToLength):
(WebCore::CSSStyleSelector::applyProperty):
(WebCore::CSSStyleSelector::mapFillSize):
(WebCore::CSSStyleSelector::mapFillXPosition):
(WebCore::CSSStyleSelector::mapFillYPosition):
(WebCore::CSSStyleSelector::createTransformOperations):
* css/CSSStyleSelector.h:
* css/MediaQueryEvaluator.cpp:
(WebCore::device_heightMediaFeatureEval):
(WebCore::device_widthMediaFeatureEval):
(WebCore::heightMediaFeatureEval):
(WebCore::widthMediaFeatureEval):
* css/WebKitCSSMatrix.cpp:
(WebCore::WebKitCSSMatrix::setMatrixValue):
* css/tokenizer.flex:
* dom/Document.cpp:
(WebCore::Document::Document):
* dom/Document.h:
(WebCore::Document::usesRemUnits):
(WebCore::Document::setUsesRemUnits):
* dom/Element.cpp:
(WebCore::Element::recalcStyle):
* rendering/SVGRenderTreeAsText.cpp:
(WebCore::writeStyle):
* rendering/style/SVGRenderStyle.cpp:
(WebCore::SVGRenderStyle::cssPrimitiveToLength):
* svg/graphics/SVGPaintServer.cpp:
(WebCore::applyStrokeStyleToContext):
(WebCore::dashArrayFromRenderingStyle):
* svg/graphics/SVGPaintServer.h:
LayoutTests:
2009-07-14 David Hyatt <hyatt@apple.com>
Reviewed by Simon Fraser.
Add layout tests for the new CSS3 'rem' unit type.
* fast/css/rem-dynamic-scaling.html: Added.
* fast/css/rem-units-on-root.html: Added.
* fast/css/remove-shorthand-expected.checksum: Added.
* fast/css/remove-shorthand-expected.png: Added.
* platform/mac/fast/css/rem-dynamic-scaling-expected.checksum: Added.
* platform/mac/fast/css/rem-dynamic-scaling-expected.png: Added.
* platform/mac/fast/css/rem-dynamic-scaling-expected.txt: Added.
* platform/mac/fast/css/rem-units-on-root-expected.checksum: Added.
* platform/mac/fast/css/rem-units-on-root-expected.png: Added.
* platform/mac/fast/css/rem-units-on-root-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45919
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
treat@webkit.org [Wed, 15 Jul 2009 16:58:36 +0000 (16:58 +0000)]
2009-07-15 Yong Li <yong.li@torchmobile.com>
Reviewed by George Staikos.
https://bugs.webkit.org/show_bug.cgi?id=27020
msToGregorianDateTime should set utcOffset to 0 when outputIsUTC is false
* wtf/DateMath.cpp:
(WTF::gregorianDateTimeToMS):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45918
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Wed, 15 Jul 2009 16:56:53 +0000 (16:56 +0000)]
2009-07-15 Brian Weinstein <bweinstein@apple.com>
Rubberstamped by Mark Rowe.
Add one more test to Windows Skipped List to hopefully get it to stay green.
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45917
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Wed, 15 Jul 2009 16:27:30 +0000 (16:27 +0000)]
2009-07-15 Dimitri Glazkov <dglazkov@chromium.org>
Unreviewed, build fix.
Remove extraneous qualifier, accidentally added in http://trac.webkit.org/changeset/45884.
* bindings/v8/V8DOMWrapper.h: Removed extraneous qualifier.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45916
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Wed, 15 Jul 2009 16:17:49 +0000 (16:17 +0000)]
2009-07-15 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Fisher.
[V8] Update bindings for ValiditeState patch.
https://bugs.webkit.org/show_bug.cgi?id=19562
* bindings/v8/DOMObjectsInclude.h:
* bindings/v8/DerivedSourcesAllInOne.cpp:
* bindings/v8/V8Index.cpp:
* bindings/v8/V8Index.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45915
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Wed, 15 Jul 2009 15:49:49 +0000 (15:49 +0000)]
JavaScriptCore:
2009-07-15 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Cleanup - Remove obsolete code from the make system
https://bugs.webkit.org/show_bug.cgi?id=27299
* JavaScriptCore.pro:
* jsc.pro:
WebCore:
2009-07-15 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Cleanup - Remove obsolete code from the make system
https://bugs.webkit.org/show_bug.cgi?id=27299
* WebCore.pro:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45914
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Wed, 15 Jul 2009 15:41:55 +0000 (15:41 +0000)]
2009-07-15 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Simon Hausmann.
https://bugs.webkit.org/show_bug.cgi?id=27285
When the user clicks a link with a target attribute, the newly created window should be visible.
Make new windows created in Qtlauncher visible.
* QtLauncher/main.cpp:
(WebPage::createWindow):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45913
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Wed, 15 Jul 2009 15:33:37 +0000 (15:33 +0000)]
2009-07-15 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Ariya Hidayat.
Fix the build without media elements.
* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::absoluteMediaURL): Add #if ENABLE(VIDEO)
markers around the body of the method.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45912
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Wed, 15 Jul 2009 15:18:42 +0000 (15:18 +0000)]
2009-07-07 Norbert Leser <norbert.leser@nokia.com>
Reviewed by Simon Hausmann.
https://bugs.webkit.org/show_bug.cgi?id=27056
Alternate bool operator for codewarrior compiler (WINSCW).
Compiler (latest b482) reports error for UnspecifiedBoolType construct:
"illegal explicit conversion from 'WTF::OwnArrayPtr<JSC::Register>' to 'bool'"
Same fix as in r38391.
* JavaScriptCore/wtf/OwnArrayPtr.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45911
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Wed, 15 Jul 2009 15:14:53 +0000 (15:14 +0000)]
2009-07-15 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Rubber-stamped by Simon Hausmann.
Fix the Qt/Mac build by disabling TestNetscapePlugin
We should fix and enable this once we run DRT for Qt/Mac
* WebKit.pro:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45910
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Wed, 15 Jul 2009 15:14:15 +0000 (15:14 +0000)]
2009-07-15 Norbert Leser <norbert.leser@nokia.com>
Reviewed by Darin Adler.
Qualify include path with wtf to fix compilation
on Symbian.
https://bugs.webkit.org/show_bug.cgi?id=27055
* interpreter/Interpreter.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45909
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Wed, 15 Jul 2009 14:18:38 +0000 (14:18 +0000)]
2009-07-15 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Dave Kilzer.
Turn off non-portable date manipulations for SYMBIAN
https://bugs.webkit.org/show_bug.cgi?id=27064
Introduce HAVE(TM_GMTOFF), HAVE(TM_ZONE) and HAVE(TIMEGM) guards
and place the rules for controlling the guards in Platform.h.
Turn off these newly introduced guards for SYMBIAN.
* wtf/DateMath.cpp:
(WTF::calculateUTCOffset):
* wtf/DateMath.h:
(WTF::GregorianDateTime::GregorianDateTime):
(WTF::GregorianDateTime::operator tm):
* wtf/Platform.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45908
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Wed, 15 Jul 2009 14:04:13 +0000 (14:04 +0000)]
2009-07-15 Norbert Leser <norbert.leser@nokia.com>
Reviewed by Simon Hausmann.
Undef ASSERT on Symbian, to avoid excessive warnings
https://bugs.webkit.org/show_bug.cgi?id=27052
* wtf/Assertions.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45907
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Wed, 15 Jul 2009 12:51:45 +0000 (12:51 +0000)]
2009-07-15 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Adam Treat.
https://bugs.webkit.org/show_bug.cgi?id=27295
Re-implement QWebPage::shouldInterruptJavaScript to disable
js interruption and avoid showing a messagebox during Qt DRT
runs when script execution takes a bit longer.
* DumpRenderTree/qt/DumpRenderTree.cpp:
(WebCore::WebPage::shouldInterruptJavaScript): Return false
in re-implemented slot.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45906
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jmalonzo@webkit.org [Wed, 15 Jul 2009 12:49:12 +0000 (12:49 +0000)]
2009-07-15 Aron Xu <aronmalache@163.com>
Rubber-stamped by Jan Alonzo.
Simplified Chinese translation
https://bugs.webkit.org/show_bug.cgi?id=27252
* zh_CN.po: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45905
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Wed, 15 Jul 2009 12:16:38 +0000 (12:16 +0000)]
REGRESSION: fast/js/postfix-syntax.html fails with interpreter
https://bugs.webkit.org/show_bug.cgi?id=27294
Reviewed by Simon Hausmann.
When postfix operators operating on locals assign to the same local
the order of operations has to be to store the incremented value, then
store the unmodified number. Rather than implementing this subtle
semantic in the interpreter I've just made the logic explicit in the
bytecode generator, so x=x++ effectively becomes x=ToNumber(x) (for a
local var x).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45904
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Wed, 15 Jul 2009 09:59:23 +0000 (09:59 +0000)]
REGRESSION(43559): fast/js/kde/arguments-scope.html fails with interpreter
https://bugs.webkit.org/show_bug.cgi?id=27259
Reviewed by Simon Hausmann
The interpreter was incorrectly basing its need to create the arguments object
based on the presence of the callframe's argument reference rather than the local
arguments reference. Based on this it then overrode the local variable reference.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45903
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jmalonzo@webkit.org [Wed, 15 Jul 2009 09:32:18 +0000 (09:32 +0000)]
Fix ChangeLog attribution to Bruce Cowan
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45902
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jmalonzo@webkit.org [Wed, 15 Jul 2009 09:29:09 +0000 (09:29 +0000)]
2009-07-15 Jan Michael Alonzo <jmalonzo@webkit.org>
Rubber-stamped by Jan Alonzo.
[Gtk] en_GB translation
https://bugs.webkit.org/show_bug.cgi?id=27244
* en_GB.po: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45901
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jmalonzo@webkit.org [Wed, 15 Jul 2009 09:12:14 +0000 (09:12 +0000)]
2009-07-15 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Jan Alonzo.
Fix the DumpRenderTree GTK+ build
https://bugs.webkit.org/show_bug.cgi?id=27290
Set USE_SYSTEM_MALLOC macro for the DumpRenderTree build to
disable using TCmalloc in DumpRenderTree.
* GNUmakefile.am:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45900
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Wed, 15 Jul 2009 08:10:52 +0000 (08:10 +0000)]
2009-07-14 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
WebInspector: Move storeLastActivePanel out of the
ifdef ENABLE_JAVASCRIPT_DEBUGGER section in IDL;
Add default panel for the first opening of the
WebInspector.
https://bugs.webkit.org/show_bug.cgi?id=27263
* inspector/InspectorController.cpp:
(InspectorController::setWindowVisible):
* inspector/InspectorController.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45899
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Wed, 15 Jul 2009 06:44:27 +0000 (06:44 +0000)]
2009-07-14 Brian Weinstein <bweinstein@apple.com>
Rubberstamped by Mark Rowe.
Add tests to Windows Skip list to get it back in green.
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45898
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Wed, 15 Jul 2009 06:00:24 +0000 (06:00 +0000)]
2009-07-14 Steve Falkenburg <sfalken@apple.com>
Reorganize JavaScriptCore headers into:
API: include/JavaScriptCore/
Private: include/private/JavaScriptCore/
Reviewed by Darin Adler.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make:
* JavaScriptCore.vcproj/testapi/testapi.vcproj:
* JavaScriptCore.vcproj/testapi/testapiCommon.vsprops:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45897
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Wed, 15 Jul 2009 05:58:27 +0000 (05:58 +0000)]
2009-07-14 Darin Adler <darin@apple.com>
Try to fix Windows build.
* bindings/scripts/CodeGeneratorCOM.pm: Add Reflect and ReflectURL support.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45896
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Wed, 15 Jul 2009 05:40:35 +0000 (05:40 +0000)]
Clear stray executable bits that have crept in over time.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45895
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pdherbemont@apple.com [Wed, 15 Jul 2009 05:40:07 +0000 (05:40 +0000)]
2009-07-14 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by Oliver Hunt.
HTMLMediaElement::supportsFullscreen() should return false
https://bugs.webkit.org/show_bug.cgi?id=27284
(Reverting a part of 45875)
HTMLVideoElement::supportsFullscreen() will properly do the
job, and check if the backend supports fullscreen.
HTMLVideoElement is the only subclass to support fullscreen
(conditionnaly). HTMLAudioElement fullscreen is not supported
and is a different kind of fullscreen, if it comes to be wanted.
No test can be done currently given that none of the media
backends support fullscreen.
* html/HTMLMediaElement.cpp:
* html/HTMLMediaElement.h:
(WebCore::HTMLMediaElement::supportsFullscreen):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45894
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Wed, 15 Jul 2009 05:26:46 +0000 (05:26 +0000)]
2009-07-14 Darin Adler <darin@apple.com>
Reviewed by Dimitri Glazkov.
Next step in making DOM attribute getter/setters consistently use AtomicString
https://bugs.webkit.org/show_bug.cgi?id=25425
This covers eight DOM classes, and for each one of the classes:
- Changes the IDL to use the Reflect syntax for all simple cases.
- Removes unused functions in the classes, mainly newly unused ones that were
used for reflection before.
- Removes unneeded explicitly defined destructors.
- Explicitly declares destructors as virtual.
- Removes unneeded includes.
- Makes members protected or private rather than public where possible.
- Renames "doc" to "document".
- Tweaks formatting to match our latest style in a few places.
- Improves some FIXME comments.
Over time we'll want to do this for all HTML DOM classes.
* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::HTMLAnchorElement):
* html/HTMLAnchorElement.h:
(WebCore::HTMLAnchorElement::endTagRequirement):
(WebCore::HTMLAnchorElement::tagPriority):
* html/HTMLAnchorElement.idl:
* html/HTMLAppletElement.cpp:
* html/HTMLAppletElement.h:
* html/HTMLAppletElement.idl:
* html/HTMLAreaElement.cpp:
(WebCore::HTMLAreaElement::parseMappedAttribute):
* html/HTMLAreaElement.h:
(WebCore::HTMLAreaElement::endTagRequirement):
(WebCore::HTMLAreaElement::tagPriority):
* html/HTMLAreaElement.idl:
* html/HTMLBRElement.cpp:
(WebCore::HTMLBRElement::parseMappedAttribute):
* html/HTMLBRElement.h:
* html/HTMLBRElement.idl:
* html/HTMLBaseElement.cpp:
(WebCore::HTMLBaseElement::HTMLBaseElement):
(WebCore::HTMLBaseElement::removedFromDocument):
(WebCore::HTMLBaseElement::process):
* html/HTMLBaseElement.h:
* html/HTMLBaseElement.idl:
* html/HTMLBaseFontElement.cpp:
(WebCore::HTMLBaseFontElement::HTMLBaseFontElement):
* html/HTMLBaseFontElement.h:
(WebCore::HTMLBaseFontElement::endTagRequirement):
(WebCore::HTMLBaseFontElement::tagPriority):
* html/HTMLBaseFontElement.idl:
* html/HTMLBlockquoteElement.cpp:
(WebCore::HTMLBlockquoteElement::HTMLBlockquoteElement):
* html/HTMLBlockquoteElement.h:
(WebCore::HTMLBlockquoteElement::tagPriority):
* html/HTMLBlockquoteElement.idl:
* html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::HTMLBodyElement):
(WebCore::HTMLBodyElement::addSubresourceAttributeURLs):
* html/HTMLBodyElement.h:
(WebCore::HTMLBodyElement::endTagRequirement):
(WebCore::HTMLBodyElement::tagPriority):
* html/HTMLBodyElement.idl:
Made changes as described above.
* loader/FrameLoader.cpp: Removed unneeded include of HTMLAnchorElement.h.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45893
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Wed, 15 Jul 2009 05:22:46 +0000 (05:22 +0000)]
JavaScriptCore:
2009-07-14 Steve Falkenburg <sfalken@apple.com>
Reorganize JavaScriptCore headers into:
API: include/JavaScriptCore/
Private: include/private/JavaScriptCore/
Reviewed by Darin Adler.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make:
* JavaScriptCore.vcproj/testapi/testapi.vcproj:
* JavaScriptCore.vcproj/testapi/testapiCommon.vsprops:
WebCore:
2009-07-14 Steve Falkenburg <sfalken@apple.com>
Reorganize JavaScriptCore headers into:
API: include/JavaScriptCore/
Private: include/private/JavaScriptCore/
Reviewed by Darin Adler.
* WebCore.vcproj/QTMovieWin.vcproj:
* WebCore.vcproj/WebCoreCommon.vsprops:
* WebCore.vcproj/build-generated-files.sh:
WebKit/win:
2009-07-14 Steve Falkenburg <sfalken@apple.com>
Reorganize JavaScriptCore headers into:
API: include/JavaScriptCore/
Private: include/private/JavaScriptCore/
Reviewed by Darin Adler.
* WebKit.vcproj/WebKit.vcproj:
WebKitTools:
2009-07-14 Steve Falkenburg <sfalken@apple.com>
Reorganize JavaScriptCore headers into:
API: include/JavaScriptCore/
Private: include/private/JavaScriptCore/
Reviewed by Darin Adler.
* DumpRenderTree/win/DumpRenderTree.vcproj:
* DumpRenderTree/win/ImageDiff.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45892
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Wed, 15 Jul 2009 05:13:00 +0000 (05:13 +0000)]
JavaScriptCore:
2009-07-14 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Darin Adler.
Change all Noncopyable inheriting visibility to public.
https://bugs.webkit.org/show_bug.cgi?id=27225
Change all Noncopyable inheriting visibility to public because
it is needed to the custom allocation framework (bug #20422).
* bytecode/SamplingTool.h:
* bytecompiler/RegisterID.h:
* interpreter/CachedCall.h:
* interpreter/RegisterFile.h:
* parser/Lexer.h:
* parser/Parser.h:
* runtime/ArgList.h:
* runtime/BatchedTransitionOptimizer.h:
* runtime/Collector.h:
* runtime/CommonIdentifiers.h:
* runtime/JSCell.h:
* runtime/JSGlobalObject.h:
* runtime/JSLock.h:
* runtime/JSONObject.cpp:
* runtime/SmallStrings.cpp:
* runtime/SmallStrings.h:
* wtf/CrossThreadRefCounted.h:
* wtf/GOwnPtr.h:
* wtf/Locker.h:
* wtf/MessageQueue.h:
* wtf/OwnArrayPtr.h:
* wtf/OwnFastMallocPtr.h:
* wtf/OwnPtr.h:
* wtf/RefCounted.h:
* wtf/ThreadSpecific.h:
* wtf/Threading.h:
* wtf/Vector.h:
* wtf/unicode/Collator.h:
WebCore:
2009-07-14 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Darin Adler.
Change all Noncopyable inheriting visibility to public.
https://bugs.webkit.org/show_bug.cgi?id=27225
Change all Noncopyable inheriting visibility to public because
it is needed to the custom allocation framework (bug #20422).
* bindings/js/GCController.h:
* bindings/js/WorkerScriptController.h:
* bindings/v8/V8DOMMap.cpp:
(WebCore::):
* bridge/runtime.h:
* css/CSSSelector.h:
* css/CSSSelectorList.h:
* css/CSSStyleSelector.h:
* dom/ClassNames.h:
* dom/MessagePortChannel.h:
* dom/XMLTokenizerLibxml2.cpp:
* dom/XMLTokenizerScope.h:
* editing/ReplaceSelectionCommand.cpp:
* editing/SelectionController.h:
* editing/TextIterator.cpp:
* history/PageCache.h:
* html/CanvasRenderingContext2D.h:
* html/HTMLParser.h:
* html/HTMLParserQuirks.h:
* html/PreloadScanner.h:
* loader/Cache.h:
* loader/CrossOriginPreflightResultCache.h:
* loader/FrameLoader.h:
* loader/ProgressTracker.h:
* loader/ThreadableLoader.h:
* loader/appcache/ApplicationCacheGroup.h:
* loader/archive/ArchiveResourceCollection.h:
* loader/icon/IconDatabase.h:
* loader/icon/IconLoader.h:
* loader/icon/PageURLRecord.h:
* loader/loader.h:
* page/ContextMenuController.h:
* page/EventHandler.h:
* page/FrameTree.h:
* page/Page.h:
* page/PageGroup.h:
* page/PageGroupLoadDeferrer.h:
* page/mac/EventHandlerMac.mm:
* platform/AutodrainedPool.h:
* platform/ContextMenu.h:
* platform/EventLoop.h:
* platform/HostWindow.h:
* platform/Pasteboard.h:
* platform/PurgeableBuffer.h:
* platform/RunLoopTimer.h:
* platform/ThreadGlobalData.h:
* platform/ThreadTimers.h:
* platform/Timer.h:
* platform/TreeShared.h:
* platform/graphics/FontData.h:
* platform/graphics/GlyphWidthMap.h:
* platform/graphics/GraphicsContext.h:
* platform/graphics/ImageBuffer.h:
* platform/graphics/ImageSource.h:
* platform/graphics/MediaPlayer.h:
* platform/graphics/skia/GraphicsContextPlatformPrivate.h:
* platform/graphics/skia/PlatformContextSkia.h:
* platform/graphics/win/QTMovieWin.cpp:
* platform/mac/LocalCurrentGraphicsContext.h:
* platform/network/FormDataBuilder.h:
* platform/network/ResourceHandleInternal.h:
* platform/network/soup/ResourceHandleSoup.cpp:
* platform/text/StringBuffer.h:
* platform/text/TextCodec.h:
* platform/win/WindowMessageBroadcaster.h:
* rendering/CounterNode.h:
* rendering/LayoutState.h:
* rendering/RenderFrameSet.h:
* rendering/RenderView.h:
* rendering/TransformState.h:
* svg/SVGAnimatedProperty.h:
* svg/SynchronizableTypeWrapper.h:
* workers/WorkerMessagingProxy.h:
* workers/WorkerRunLoop.cpp:
* xml/XPathExpressionNode.h:
* xml/XPathParser.h:
* xml/XPathPredicate.h:
* xml/XPathStep.h:
WebKit/gtk:
2009-07-14 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Darin Adler.
Change all Noncopyable inheriting visibility to public.
https://bugs.webkit.org/show_bug.cgi?id=27225
Change all Noncopyable inheriting visibility to public because
it is needed to the custom allocation framework (bug #20422).
* webkit/webkitdownload.cpp:
WebKit/win:
2009-07-14 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Darin Adler.
Change all Noncopyable inheriting visibility to public.
https://bugs.webkit.org/show_bug.cgi?id=27225
Change all Noncopyable inheriting visibility to public because
it is needed to the custom allocation framework (bug #20422).
* COMEnumVariant.h:
* WebDatabaseManager.cpp:
* WebInspector.h:
* WebLocalizableStrings.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45891
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@chromium.org [Wed, 15 Jul 2009 05:04:54 +0000 (05:04 +0000)]
2009-07-14 Darin Fisher <darin@chromium.org>
Reviewed by Darin Adler.
Fails to save document state when navigating away from a page with a
reference fragment.
https://bugs.webkit.org/show_bug.cgi?id=27281
Test: fast/history/saves-state-after-fragment-nav.html
* history/HistoryItem.cpp:
(WebCore::HistoryItem::isCurrentDocument): Use equalIgnoringRef
to compare URLs.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45890
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Wed, 15 Jul 2009 03:43:17 +0000 (03:43 +0000)]
2009-07-14 Joseph Pecoraro <joepeck02@gmail.com>
Reviewed by Sam Weinig.
Inspector: Remove Unintended Global Variables
https://bugs.webkit.org/show_bug.cgi?id=27203
* inspector/front-end/Console.js:
(WebInspector.Console.prototype._ensureCommandLineAPIInstalled):
* inspector/front-end/DatabasesPanel.js:
(WebInspector.DatabasesPanel.prototype.dataGridForDOMStorage):
* inspector/front-end/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertyTreeElement.prototype.update):
* inspector/front-end/inspector.js:
(WebInspector.animateStyle):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45889
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pkasting@chromium.org [Wed, 15 Jul 2009 02:03:02 +0000 (02:03 +0000)]
WebCore:
2009-07-14 Michelangelo De Simone <micdesim@gmail.com>
Reviewed by Adele Peterson.
https://bugs.webkit.org/show_bug.cgi?id=19562
Added build stuff and stub for the ValidityState class, part of HTML5
section Forms:
http://www.whatwg.org/specs/web-apps/current-work/multipage/forms.html#validitystate
Test: fast/forms/ValidityState-001.html
* DerivedSources.cpp: Inclusion of ValidityState files
* DerivedSources.make: ditto
* GNUmakefile.am: ditto
* WebCore.gypi: ditto
* WebCore.pro: ditto
* WebCore.vcproj/WebCore.vcproj: ditto
* WebCore.xcodeproj/project.pbxproj: ditto
* WebCoreSources.bkl: ditto
* html/HTMLButtonElement.idl: validity attribute
* html/HTMLFieldSetElement.idl: ditto
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::validity): ValidityState getter
* html/HTMLFormControlElement.h: ditto
* html/HTMLInputElement.idl: validity attribute
* html/HTMLSelectElement.idl: ditto
* html/HTMLTextAreaElement.idl: ditto
* html/ValidityState.cpp: Added.
(WebCore::ValidityState::ValidityState):
(WebCore::ValidityState::valid): validation flag
* html/ValidityState.h: Added.
(WebCore::ValidityState::create): validation flag
(WebCore::ValidityState::control): ditto
(WebCore::ValidityState::valueMissing): ditto
(WebCore::ValidityState::typeMismatch): ditto
(WebCore::ValidityState::patternMismatch): ditto
(WebCore::ValidityState::tooLong): ditto
(WebCore::ValidityState::rangeUnderflow): ditto
(WebCore::ValidityState::rangeOverflow): ditto
(WebCore::ValidityState::stepMismatch): ditto
(WebCore::ValidityState::customError): ditto
* html/ValidityState.idl: Added.
LayoutTests:
2009-07-14 Michelangelo De Simone <micdesim@gmail.com>
Reviewed by Adele Peterson.
https://bugs.webkit.org/show_bug.cgi?id=19562
Minimal test case for ValidityState; more tests are going to be added
along with specific validation routines.
* fast/dom/domListEnumeration-expected.txt: increased expected value
of 1 to match the new "validity" attribute
* fast/dom/resources/domListEnumeration.js: ditto
* fast/forms/ValidityState-001-expected.txt: Added.
* fast/forms/ValidityState-001.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45888
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Wed, 15 Jul 2009 01:11:29 +0000 (01:11 +0000)]
2009-07-14 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Darin Adler.
Change ParserArenaRefCounted's superclass to RefCountedCustomAllocated
https://bugs.webkit.org/show_bug.cgi?id=27249
ParserArenaDeletable customizes operator new, to avoid double inheritance
ParserArenaDeletable's superclass has been changed to RefCountedCustomAllocated.
* parser/Nodes.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45887
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jparent@chromium.org [Wed, 15 Jul 2009 01:02:12 +0000 (01:02 +0000)]
WebCore:
2009-07-14 Ryosuke Niwa <rniwa@google.com>
Reviewed by Eric Seidel.
Outdenting a line inside a blockquote tag does nothing
https://bugs.webkit.org/show_bug.cgi?id=25316
The bug was caused by the code checking whether the blockquote is created by WebKit or not.
We simply remove this code to be consistent with Firefox and Internet Explorer.
Also, enclosingBlockFlow == enclosingNode in outdentParagraph isn't a sufficient condition to insert
the placeholder before the enclosingNode because there could be contents before the current paragraph.
Instead, we should split the enclosingNode (which is a blockquote) at the starting position of outdentation.
It turned out that this solves the bug 25315 also: https://bugs.webkit.org/show_bug.cgi?id=25315
Test: editing/execCommand/outdent-regular-blockquote.html
* editing/IndentOutdentCommand.cpp:
(WebCore::isIndentBlockquote): no longer checks whether a blockquote is created by WebKit or not.
(WebCore::IndentOutdentCommand::outdentParagraph): takes care of the case enclosingBlockFlow == enclosingNode
LayoutTests:
2009-07-14 Ryosuke Niwa <rniwa@google.com>
Reviewed by Eric Seidel.
Outdenting a line inside a blockquote tag does nothing
https://bugs.webkit.org/show_bug.cgi?id=25315
https://bugs.webkit.org/show_bug.cgi?id=25316
The expected result for /editing/execCommand/outdent-selection-expected.html
was rebaselined since the original expected result was wrong (Bug 25315).
Namely, "ipsum" moved to the same paragraph as "more Lorem!"
("ipsum" was in the blockblock immediately below "more Lorem!")
and "Dolor" was moved above the list items "Foo", "Bar", and "Baz".
* editing/execCommand/outdent-regular-blockquote-expected.txt: Added.
* editing/execCommand/outdent-regular-blockquote.html: Added.
* platform/mac/editing/execCommand/outdent-selection-expected.checksum:
* platform/mac/editing/execCommand/outdent-selection-expected.png:
* platform/mac/editing/execCommand/outdent-selection-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45886
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Wed, 15 Jul 2009 00:47:46 +0000 (00:47 +0000)]
2009-07-14 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Darin Adler.
Add RefCountedCustomAllocated to RefCounted.h
https://bugs.webkit.org/show_bug.cgi?id=27232
Some class which are inherited from RefCounted customize
operator new, but RefCounted is inherited from Noncopyable
which will be inherited from FastAllocBase. To avoid
conflicts Noncopyable inheriting was moved down to RefCounted
and to avoid double inheritance this class has been added.
* wtf/RefCounted.h:
(WTF::RefCountedCustomAllocated::deref):
(WTF::RefCountedCustomAllocated::~RefCountedCustomAllocated):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45885
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 15 Jul 2009 00:10:46 +0000 (00:10 +0000)]
2009-07-14 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
[V8] Fix isolated world wrappers for Node prototypes
https://bugs.webkit.org/show_bug.cgi?id=27277
This change does two things:
1) We bypass the wrapper cache in the isolated world. This is because
the wrapper template cache has prototypes that lead to the main
world. We can add a template cache for the isolated world if
performance warrants.
2) We introduce a smarter way to grab the wrapper context for a frame
that is aware that proxy <-> context do not stand in one-to-one
correspondence. This generalizes our solution for the node wrapper
case to prototypes.
The net result is that Node wrappers get the right prototypes. As
before, tests to follow.
* bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::setHiddenWindowReference):
(WebCore::V8DOMWrapper::instantiateV8Object):
(WebCore::V8DOMWrapper::convertNodeToV8Object):
(WebCore::V8DOMWrapper::convertWindowToV8Object):
(WebCore::V8DOMWrapper::getWrapperContext):
* bindings/v8/V8DOMWrapper.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45884
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Wed, 15 Jul 2009 00:05:12 +0000 (00:05 +0000)]
2009-07-14 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Darin Adler.
Add NoncopyableCustomAllocated to Noncopyable.h.
https://bugs.webkit.org/show_bug.cgi?id=27228
Some classes which inherited from Noncopyable overrides operator new
since Noncopyable'll be inherited from FastAllocBase, Noncopyable.h
needs to be extended with this new class to support the overriding.
* wtf/Noncopyable.h:
(WTFNoncopyable::NoncopyableCustomAllocated::NoncopyableCustomAllocated):
(WTFNoncopyable::NoncopyableCustomAllocated::~NoncopyableCustomAllocated):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45883
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 14 Jul 2009 23:36:49 +0000 (23:36 +0000)]
2009-07-14 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
[V8] Fix isolated world wrappers for Nodes
https://bugs.webkit.org/show_bug.cgi?id=27271
Previously, we keepy a pointer to the DOMMap on V8Proxy, but this
caused us to miss the branch in V8DOMMap.cpp for isolated worlds.
I have tests, but I can't land them until I get this feature under
control.
* bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::convertNodeToV8Object):
* bindings/v8/V8Proxy.h:
(WebCore::V8Proxy::V8Proxy):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45882
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Tue, 14 Jul 2009 23:16:12 +0000 (23:16 +0000)]
2009-07-14 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Darin Adler.
Allow custom memory allocation control for JavaScriptCore's IdentifierTable class
https://bugs.webkit.org/show_bug.cgi?id=27260
Inherits IdentifierTable class from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/runtime/Identifier.cpp:70.
* runtime/Identifier.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45881
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 14 Jul 2009 23:09:09 +0000 (23:09 +0000)]
2009-07-14 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
[V8] Fix isolated world crash on getting window.location
https://bugs.webkit.org/show_bug.cgi?id=27268
I have a test for this locally, but it requires a compile-time hack to
run. Once I get the feature's stability under control, we can turn the
feature on and add the tests.
* bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::setHiddenWindowReference):
* bindings/v8/V8IsolatedWorld.h:
(WebCore::V8IsolatedWorld::context):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45880
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Tue, 14 Jul 2009 23:02:40 +0000 (23:02 +0000)]
2009-07-14 Brent Fulgham <bfulgham@webkit.org>
Correct failing tests after r45875. The original patch did not
test the m_player member for null, causing crashes. This will
happen fairly frequently in real use. Was this original patch
ever tested?
https://bugs.webkit.org/show_bug.cgi?id=27246
Test via existing media tests.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::supportsFullscreen): Check for null pointer.
(WebCore::HTMLMediaElement::supportsSave): Check for null pointer.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45879
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@chromium.org [Tue, 14 Jul 2009 22:50:06 +0000 (22:50 +0000)]
2009-07-14 Avi Drissman <avi@chromium.org>
Reviewed by Darin Fisher.
Explicitly mark the HTML generated for the Mac as being UTF-8 encoded.
The Windows clipboard format is explicitly documented as being UTF-8,
and all Linux apps assume UTF-8. On the Mac, though, unless otherwise
indicated, Windows-1252 is assumed, which is wrong.
Bug: https://bugs.webkit.org/show_bug.cgi?id=27262
No new tests.
* platform/chromium/ClipboardChromium.cpp:
(WebCore::ClipboardChromium::writeRange):
* platform/chromium/PasteboardChromium.cpp:
(WebCore::Pasteboard::writeSelection):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45878
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Tue, 14 Jul 2009 22:43:30 +0000 (22:43 +0000)]
2009-07-14 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Darin Adler.
Allow custom memory allocation control for JavaScriptCore's Profiler class
https://bugs.webkit.org/show_bug.cgi?id=27253
Inherits Profiler class from FastAllocBase because it has been instantiated by
'new' in JavaScriptCore/profiler/Profiler.cpp:56.
* profiler/Profiler.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45877
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
japhet@chromium.org [Tue, 14 Jul 2009 22:35:31 +0000 (22:35 +0000)]
2009-07-14 Albert J. Wong <ajwong@chromium.org>
Reviewed by Dimitri Glazkov.
Upstream V8NPObject.h and V8NPObject.cpp.
https://bugs.webkit.org/show_bug.cgi?id=27103
This just upstreams the files from the chromium code base. Only
minor changes to formatting and similar were done, so no testing
is required because nothing really changed. Code verified to compile.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45876
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Tue, 14 Jul 2009 22:20:19 +0000 (22:20 +0000)]
2009-07-14 Albert J. Wong <ajwong@chromium.org>
Reviewed by Darin Adler.
Add HTMLMediaElement::supportSave() and a
HitTestResult::absoluteMediaURL() functions
https://bugs.webkit.org/show_bug.cgi?id=27246
Added an implementation of supportsSave() into HTMLMediaElement
that delegates to MediaPlayerPrivateImpl so that the media engine
is able to signal whether or not a media source supports saving.
Also added a function to HitTestResult that allows for retrieval
of the currentSrc associated with the "hit" media element.
These functions are just pipeing with no visible UI change so there
are no related layout test changes.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::supportsFullscreen):
(WebCore::HTMLMediaElement::supportsSave):
* html/HTMLMediaElement.h:
* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::supportsSave):
* platform/graphics/MediaPlayer.h:
* platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::supportsFullscreen):
(WebCore::MediaPlayerPrivateInterface::supportsSave):
* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::altDisplayString):
(WebCore::HitTestResult::absoluteMediaURL):
* rendering/HitTestResult.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45875
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Tue, 14 Jul 2009 22:00:24 +0000 (22:00 +0000)]
2009-07-14 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Adam Barth.
[V8] Implement Reflect and ReflectURL attribute support.
https://bugs.webkit.org/show_bug.cgi?id=27273
* bindings/scripts/CodeGeneratorV8.pm: Added support for Reflect and ReflectURL attributes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45874
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Tue, 14 Jul 2009 21:28:38 +0000 (21:28 +0000)]
2009-07-14 Dmitry Titov <dimich@chromium.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=27266
Add hasCurrentPoint() to WebCore::Path.
This fixes Skia-based Chromium regression caused by the fix for
https://bugs.webkit.org/show_bug.cgi?id=27187.
For Skia, the new method always returns 'true', pending actual implementation.
This means Chromium still will differ from Gecko behavior, but at least its Canvas
will not be completely broken.
Existing Canvas Layout Tests should pass in Chromium after this change.
* html/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::lineTo): insteand of Path::isEmpty() test for hasCurrentPoint().
(WebCore::CanvasRenderingContext2D::quadraticCurveTo): ditto.
(WebCore::CanvasRenderingContext2D::bezierCurveTo): ditto.
* platform/graphics/Path.h:
* platform/graphics/cairo/PathCairo.cpp:
(WebCore::Path::hasCurrentPoint):
* platform/graphics/cg/PathCG.cpp:
(WebCore::Path::isEmpty):
(WebCore::Path::hasCurrentPoint):
* platform/graphics/qt/PathQt.cpp:
(WebCore::Path::hasCurrentPoint):
* platform/graphics/skia/PathSkia.cpp:
(WebCore::Path::hasCurrentPoint):
* platform/graphics/wx/PathWx.cpp:
(WebCore::Path::hasCurrentPoint):
All these files add a Path::hasCurrentPoint() for various platforms.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45873
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
japhet@chromium.org [Tue, 14 Jul 2009 21:15:24 +0000 (21:15 +0000)]
2009-07-14 Nate Chapin <japhet@chromium.org>
Reviewed by Sam Weinig.
Upstream RGBColor from src.chromium.org.
https://bugs.webkit.org/show_bug.cgi?id=27133
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45872
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mpcomplete@chromium.org [Tue, 14 Jul 2009 21:05:05 +0000 (21:05 +0000)]
2009-07-10 Matt Perry <mpcomplete@chromium.org>
Reviewed by Darin Fisher.
[V8] Rename the didCreate/DestroyScriptContext calls to make it
clear that that those refer to the frame's contxt. Add another
similar call for when creating contexts via evaluateInNewContext.
https://bugs.webkit.org/show_bug.cgi?id=27104
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::evaluateInNewContext):
(WebCore::V8Proxy::disposeContextHandles):
(WebCore::V8Proxy::initContextIfNeeded):
* loader/EmptyClients.h:
(WebCore::EmptyFrameLoaderClient::didCreateScriptContextForFrame):
(WebCore::EmptyFrameLoaderClient::didDestroyScriptContextForFrame):
(WebCore::EmptyFrameLoaderClient::didCreateIsolatedScriptContext):
* loader/FrameLoaderClient.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45871
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Tue, 14 Jul 2009 20:39:17 +0000 (20:39 +0000)]
2009-07-14 Brent Fulgham <bfulgham@webkit.org>
Revert http://trac.webkit.org/changeset/45864 after
breaking of Windows build.
* storage/LocalStorageTask.cpp:
* storage/LocalStorageTask.h:
* storage/Storage.cpp:
* storage/Storage.h:
* storage/StorageArea.cpp:
* storage/StorageArea.h:
* storage/StorageAreaImpl.cpp:
* storage/StorageAreaImpl.h:
* storage/StorageAreaSync.cpp:
* storage/StorageAreaSync.h:
* storage/StorageEvent.cpp:
* storage/StorageEvent.h:
(WebCore::StorageEvent::create):
(WebCore::StorageEvent::StorageEvent):
* storage/StorageNamespace.h:
* storage/StorageNamespaceImpl.cpp:
* storage/StorageNamespaceImpl.h:
* storage/StorageSyncManager.cpp:
* storage/StorageSyncManager.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45866
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
treat@webkit.org [Tue, 14 Jul 2009 20:21:59 +0000 (20:21 +0000)]
2009-07-06 George Staikos <george.staikos@torchmobile.com>
Reviewed by Adam Treat.
Authors: George Staikos <george.staikos@torchmobile.com>, Joe Mason <joe.mason@torchmobile.com>, Makoto Matsumoto <matumoto@math.keio.ac.jp>, Takuji Nishimura
https://bugs.webkit.org/show_bug.cgi?id=27030
Implement custom RNG for WinCE using Mersenne Twister
* wtf/RandomNumber.cpp:
(WTF::randomNumber):
* wtf/RandomNumberSeed.h:
(WTF::initializeRandomNumberGenerator):
* wtf/wince/mt19937ar.c: Added.
(init_genrand):
(init_by_array):
(genrand_int32):
(genrand_int31):
(genrand_real1):
(genrand_real2):
(genrand_real3):
(genrand_res53):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45865
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Tue, 14 Jul 2009 19:36:50 +0000 (19:36 +0000)]
2009-07-11 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Adler.
Cleanup DOM Storage dependencies.
https://bugs.webkit.org/show_bug.cgi?id=27180
DOM Storage had several unnecessary (and probably unintended)
dependencies. This patch replaces many includes of header files with
forward declaration of classes, making some destructors explicit, and
taking some factories out of the header files.
This will allow things like StorageAreaSync to take a StorageAreaImpl*
(as it should) rather than a StorageArea* which previously weren't
possible because the dependencies were such a tangled mess.
* storage/LocalStorageTask.cpp:
(WebCore::LocalStorageTask::~LocalStorageTask):
* storage/LocalStorageTask.h:
* storage/Storage.cpp:
(WebCore::Storage::~Storage):
* storage/Storage.h:
* storage/StorageArea.cpp:
* storage/StorageArea.h:
* storage/StorageAreaImpl.cpp:
* storage/StorageAreaImpl.h:
* storage/StorageAreaSync.cpp:
(WebCore::StorageAreaSync::~StorageAreaSync):
* storage/StorageAreaSync.h:
* storage/StorageEvent.cpp:
(WebCore::StorageEvent::create):
(WebCore::StorageEvent::StorageEvent):
* storage/StorageEvent.h:
* storage/StorageNamespace.h:
* storage/StorageNamespaceImpl.cpp:
* storage/StorageNamespaceImpl.h:
* storage/StorageSyncManager.cpp:
(WebCore::StorageSyncManager::~StorageSyncManager):
* storage/StorageSyncManager.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45864
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
treat@webkit.org [Tue, 14 Jul 2009 17:54:23 +0000 (17:54 +0000)]
2009-07-14 Adam Treat <adam.treat@torchmobile.com>
Reviewed by David Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=26983
Check to make sure the view is attached to a frame() in the visibleContentsResized()
method as it can be triggered before the view is attached by Frame::createView(...)
setting various values such as setScrollBarModes(...) for example. An ASSERT is
triggered when a view is layout before being attached to a frame().
* page/FrameView.cpp:
(WebCore::FrameView::visibleContentsResized):
* page/FrameView.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45863
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
treat@webkit.org [Tue, 14 Jul 2009 16:56:10 +0000 (16:56 +0000)]
2009-07-14 Adam Treat <adam.treat@torchmobile.com>
Reviewed by Zack Rusin.
https://bugs.webkit.org/show_bug.cgi?id=26983
The default constructed values for QSize and WebCore::IntSize are different. The former
produces an invalid size whereas the latter produces a size of zero. This was causing
a layout to be triggered when constructing a view and an assert to be hit. This patch fixes
the crash by taking care not to cause an unnecessary layout triggered by ScrollView::setFixedL
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::transitionToCommittedForNewPage):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45862
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Tue, 14 Jul 2009 16:29:16 +0000 (16:29 +0000)]
2009-07-14 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
WebInspector: show last opened panel when invoking inspector.
https://bugs.webkit.org/show_bug.cgi?id=27263
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::setWindowVisible):
(WebCore::InspectorController::storeLastActivePanel):
(WebCore::InspectorController::specialPanelForJSName):
* inspector/InspectorController.h:
(WebCore::InspectorController::Setting::Setting):
* inspector/InspectorController.idl:
* inspector/front-end/inspector.js:
(WebInspector.set currentPanel):
(WebInspector.loaded):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45861
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Tue, 14 Jul 2009 16:25:28 +0000 (16:25 +0000)]
2009-07-14 Anton Muhin <antonm@chromium.org>
Reviewed by Dimitri Glazkov.
Speed up access to NodeList length.
https://bugs.webkit.org/show_bug.cgi?id=27264
That's a minimal alternation of the code.
* bindings/v8/custom/V8NodeListCustom.cpp:
(WebCore::NAMED_PROPERTY_GETTER): 1) use AtomicString for comparison, 2) use
v8::Integer::New instead of v8::Number::New.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45860
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Tue, 14 Jul 2009 16:16:10 +0000 (16:16 +0000)]
2009-07-14 Anton Muhin <antonm@chromium.org>
Reviewed by Dimitri Glazkov.
Do not do unnecessary conversions from v8::Handle<v8::Value> to
v8::Handle<v8::Object> and accompanying changes.
https://bugs.webkit.org/show_bug.cgi?id=26953
Three things:
1) do not cast from v8::Value to v8::Object if unnecessary---casts are cheap,
but are not free (they check for emptiness of handle);
2) inline conversion from wrapper to node;
3) simplify case to an ASSERT.
This is just a refactoring, so no new tests are needed.
* bindings/scripts/CodeGeneratorV8.pm:
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::evaluateInNewContext):
(WebCore::V8Proxy::convertToSVGPODTypeImpl):
* bindings/v8/V8Proxy.h:
(WebCore::V8Proxy::convertDOMWrapperToNative):
(WebCore::V8Proxy::convertToNativeObject):
(WebCore::V8Proxy::convertToNativeEvent):
* bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
(WebCore::toCanvasStyle):
(WebCore::CALLBACK_FUNC_DECL):
* bindings/v8/custom/V8CustomBinding.cpp:
(WebCore::V8Custom::GetTargetFrame):
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::CALLBACK_FUNC_DECL):
(WebCore::V8Custom::ClearTimeoutImpl):
(WebCore::NAMED_ACCESS_CHECK):
(WebCore::INDEXED_ACCESS_CHECK):
* bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::CALLBACK_FUNC_DECL):
* bindings/v8/custom/V8LocationCustom.cpp:
(WebCore::CALLBACK_FUNC_DECL):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45859
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Tue, 14 Jul 2009 16:06:18 +0000 (16:06 +0000)]
WebCore:
2009-07-14 Darin Adler <darin@apple.com>
Reviewed by Dan Bernstein.
Straight quotes should match fancy quotes in in-page search
https://bugs.webkit.org/show_bug.cgi?id=27217
Tests: fast/text/find-quotes.html
* editing/TextIterator.cpp:
(WebCore::foldQuoteMark): Added.
(WebCore::foldQuoteMarks): Added.
(WebCore::SearchBuffer::SearchBuffer): Call foldQuoteMarks on the target string.
(WebCore::SearchBuffer::append): Call foldQuoteMarks on characters as they are
added to the search buffer.
* platform/text/CharacterNames.h: Added more quotation mark character names.
Sorted character names with the sort tool.
LayoutTests:
2009-07-14 Darin Adler <darin@apple.com>
Reviewed by Dan Bernstein.
Straight quotes should match fancy quotes in in-page search
https://bugs.webkit.org/show_bug.cgi?id=27217
* fast/text/find-quotes-expected.txt: Added.
* fast/text/find-quotes.html: Copied from LayoutTests/fast/text/find-case-folding.html.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45858
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Tue, 14 Jul 2009 15:42:12 +0000 (15:42 +0000)]
2009-07-14 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by David Levin.
WebKit needs a style linting tool
https://bugs.webkit.org/show_bug.cgi?id=25884
Modifies cpplint (http://google-styleguide.googlecode.com/svn/trunk/cpplint/)
based on WebKit's style guide.
* Scripts/cpplint.py: Added.
* Scripts/cpplint_unittest.py: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45857
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Tue, 14 Jul 2009 13:04:35 +0000 (13:04 +0000)]
2009-07-14 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Simon Hausmann.
[Qt] DumpRenderTree no longer builds with Qt4.4
https://bugs.webkit.org/show_bug.cgi?id=27257
Flag Qt 4.5 dependency to allow building with Qt 4.4.
* DumpRenderTree/qt/main.cpp:
(main):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45856
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Tue, 14 Jul 2009 05:35:40 +0000 (05:35 +0000)]
2009-07-13 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
WebInspector: handle debugger shortcuts while on source frame or on
script file selector.
https://bugs.webkit.org/show_bug.cgi?id=27224
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._loaded):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45855
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
git://git.webkit.org / WebKit-https.git / log