WebKit-https.git
10 years ago<http://webkit.org/b/59838> Implement HTTP pipelining for CoreFoundation-based networking
ddkilzer@apple.com [Tue, 3 May 2011 23:25:15 +0000 (23:25 +0000)]
<webkit.org/b/59838> Implement HTTP pipelining for CoreFoundation-based networking

Reviewed by Antti Koivisto.

Source/WebCore:

* platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::ResourceRequest::doUpdatePlatformRequest): Set the
priority on the request if HTTP pipelining is enabled.
(WebCore::ResourceRequest::doUpdateResourceRequest): Read the
priority from the request if HTTP pipelining is enabled.
(readBooleanPreference): Enable code when compiling with
USE(CFNETWORK).
(WebCore::initializeMaximumHTTPConnectionCountPerHost): Ditto.
Comment out setting the minimum fast lane priority on Windows
since it's not currently available.

Source/WebKit/win:

* Interfaces/IWebViewPrivate.idl:
(IWebViewPrivate::httpPipeliningEnabled): Added declaration.
(IWebViewPrivate::setHTTPPipeliningEnabled): Added declaration.
* WebView.cpp:
(WebView::httpPipeliningEnabled): Added.
(WebView::setHTTPPipeliningEnabled): Added.
* WebView.h:
(WebView::httpPipeliningEnabled): Added declaration.
(WebView::setHTTPPipeliningEnabled): Added declaration.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-03 Tony Chang <tony@chromium.org>
tony@chromium.org [Tue, 3 May 2011 23:20:43 +0000 (23:20 +0000)]
2011-05-03  Tony Chang  <tony@chromium.org>

        Add a bug number for a recent regression to test_expectations.txt.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-03 Alpha Lam <hclam@chromium.org>
hclam@chromium.org [Tue, 3 May 2011 23:18:20 +0000 (23:18 +0000)]
2011-05-03  Alpha Lam  <hclam@chromium.org>

        Not reviewed. Build fix.

        Test expectations.

        * platform/chromium-win/editing/selection/select-across-readonly-input-1-expected.png: Added.
        * platform/chromium-win/editing/selection/select-across-readonly-input-1-expected.txt: Added.
        * platform/chromium-win/editing/selection/select-across-readonly-input-2-expected.png: Added.
        * platform/chromium-win/editing/selection/select-across-readonly-input-2-expected.txt: Added.
        * platform/chromium-win/editing/selection/select-across-readonly-input-3-expected.png: Added.
        * platform/chromium-win/editing/selection/select-across-readonly-input-3-expected.txt: Added.
        * platform/chromium-win/editing/selection/select-across-readonly-input-4-expected.png: Added.
        * platform/chromium-win/editing/selection/select-across-readonly-input-4-expected.txt: Added.
        * platform/chromium-win/editing/selection/select-across-readonly-input-5-expected.png: Added.
        * platform/chromium-win/editing/selection/select-across-readonly-input-5-expected.txt: Added.
        * platform/chromium-win/fast/forms/input-readonly-autoscroll-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-03 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 3 May 2011 23:14:31 +0000 (23:14 +0000)]
2011-05-03  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        <rdar://problem/9278296> Flicker zooming on Google Maps satellite view with accelerated compositing turned on

        Conditionalize compositing tiled layer size-constraining logic to older
        OSes.

        * platform/graphics/ca/GraphicsLayerCA.cpp:
        (WebCore::GraphicsLayerCA::constrainedSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-03 Roland Steiner <rolandsteiner@chromium.org>
rolandsteiner@chromium.org [Tue, 3 May 2011 23:08:21 +0000 (23:08 +0000)]
2011-05-03  Roland Steiner  <rolandsteiner@chromium.org>

        Reviewed by Dimitri Glazkov.

        Allow access keys to be used in shadow DOM
        https://bugs.webkit.org/show_bug.cgi?id=59979

        Move access key methods and members back to Document from TreeScope.
        Also traverse into shadow trees when building the access key map.

        No new tests. (refactoring)

        * dom/Document.cpp:
        (WebCore::Document::Document):
        (WebCore::Document::getElementByAccessKey):
        (WebCore::Document::buildAccessKeyMap):
        (WebCore::Document::invalidateAccessKeyMap):
        * dom/Document.h:
        * dom/TreeScope.cpp:
        (WebCore::TreeScope::TreeScope):
        (WebCore::TreeScope::destroyTreeScopeData):
        * dom/TreeScope.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-03 Alpha Lam <hclam@chromium.org>
hclam@chromium.org [Tue, 3 May 2011 23:00:59 +0000 (23:00 +0000)]
2011-05-03  Alpha Lam  <hclam@chromium.org>

        Build fix. Not reviewed.

        Add test expectations for new tests.

        * platform/chromium-linux/editing/selection/select-across-readonly-input-1-expected.png: Added.
        * platform/chromium-linux/editing/selection/select-across-readonly-input-1-expected.txt: Added.
        * platform/chromium-linux/editing/selection/select-across-readonly-input-2-expected.png: Added.
        * platform/chromium-linux/editing/selection/select-across-readonly-input-2-expected.txt: Added.
        * platform/chromium-linux/editing/selection/select-across-readonly-input-3-expected.png: Added.
        * platform/chromium-linux/editing/selection/select-across-readonly-input-3-expected.txt: Added.
        * platform/chromium-linux/editing/selection/select-across-readonly-input-4-expected.png: Added.
        * platform/chromium-linux/editing/selection/select-across-readonly-input-4-expected.txt: Added.
        * platform/chromium-linux/editing/selection/select-across-readonly-input-5-expected.png: Added.
        * platform/chromium-linux/editing/selection/select-across-readonly-input-5-expected.txt: Added.
        * platform/chromium-linux/fast/forms/input-readonly-autoscroll-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/8891395> -[DOMRange textRects] returns incorrect results for vertical...
mitz@apple.com [Tue, 3 May 2011 22:33:25 +0000 (22:33 +0000)]
<rdar://problem/8891395> -[DOMRange textRects] returns incorrect results for vertical or flipped text
https://bugs.webkit.org/show_bug.cgi?id=60067

Reviewed by Darin Adler.

No test because this code path is only used by the Objective-C API, which is not testable from DumpRenderTree.

* rendering/RenderText.cpp:
(WebCore::RenderText::absoluteRectsForRange): Use width/height instead of logicalWidth/logicalHeight here,
and perform the local-to-absolute mapping on the rects rather than their origin, in order to get the right
results for flipped writing modes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAccount for font metric differences exposed by r85411.
mitz@apple.com [Tue, 3 May 2011 22:30:45 +0000 (22:30 +0000)]
Account for font metric differences exposed by r85411.
Fixes <rdar://problem/9377892> REGRESSION (r85403-r85475): platform/mac/fast/text/ligature-subdivision.html failing

Rubber-stamped by Darin Adler.

* platform/mac/fast/text/script-tests/ligature-subdivision.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-03 Tony Chang <tony@chromium.org>
tony@chromium.org [Tue, 3 May 2011 22:29:41 +0000 (22:29 +0000)]
2011-05-03  Tony Chang  <tony@chromium.org>

        Update results for fast/harness/results.html.  We shouldn't be
        ignoring these failures :(

        * fast/harness/results-expected.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-03 Tony Chang <tony@chromium.org>
tony@chromium.org [Tue, 3 May 2011 22:25:57 +0000 (22:25 +0000)]
2011-05-03  Tony Chang  <tony@chromium.org>

        Update chromium linux test results after r85013.  The vertical
        positioning of the glyphs have improved.

        * platform/chromium-linux/fast/text/atsui-negative-spacing-features-expected.png:
        * platform/chromium-linux/fast/text/atsui-spacing-features-expected.png:
        * platform/chromium-linux/fast/text/international/hebrew-vowels-expected.png:
        * platform/chromium-linux/fast/text/international/thai-baht-space-expected.png:
        * platform/chromium-linux/fast/text/international/thai-line-breaks-expected.png:
        * platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
        * platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
        * platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
        * platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
        * platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
        * platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
        * platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
        * platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
        * platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
        * platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
        * platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
        * platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
        * platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
        * platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
        * platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
        * platform/chromium-linux/svg/W3C-I18N/text-anchor-no-markup-expected.png:
        * platform/chromium-linux/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png:
        * platform/chromium-linux/svg/text/text-intro-05-t-expected.png:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-03 Anton Muhin <antonm@chromium.org>
antonm@chromium.org [Tue, 3 May 2011 22:22:49 +0000 (22:22 +0000)]
2011-05-03  Anton Muhin  <antonm@chromium.org>

        Reviewed by Yury Semikhatsky.

        [v8] remove an ASSERT from grouping logic
        https://bugs.webkit.org/show_bug.cgi?id=60024

        This ASSERT was exploratory.  Alas, right now I am aware of no easy way to
        repro it.  Removing for now for greener bots.

        No new tests, only an ASSERT removal.

        * bindings/v8/V8GCController.cpp:
        (WebCore::calculateGroupId):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-03 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 3 May 2011 22:20:34 +0000 (22:20 +0000)]
2011-05-03  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Roben.

        webkit-patch post-commits HEAD^.. throws an exception
        https://bugs.webkit.org/show_bug.cgi?id=60027

        * Scripts/webkitpy/common/checkout/scm/git.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] REGRESSION(r85648) Skip data-transfer-items.html test because data-transfer...
ossy@webkit.org [Tue, 3 May 2011 22:16:47 +0000 (22:16 +0000)]
[Qt] REGRESSION(r85648) Skip data-transfer-items.html test because data-transfer-items is not a Qt default build option
https://bugs.webkit.org/show_bug.cgi?id=60068

Patch by Igor Oliveira <igor.oliveira@openbossa.org> on 2011-05-03
Reviewed by Csaba Osztrogon√°c.

Skip data-transfer-items.html test because data-transfer-items
is not a Qt default build option

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Layout tests may timeout if loadFinished receives false
luiz@webkit.org [Tue, 3 May 2011 22:16:31 +0000 (22:16 +0000)]
[Qt] Layout tests may timeout if loadFinished receives false
https://bugs.webkit.org/show_bug.cgi?id=60064

Fixing ChangeLog.

* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::maybeDump):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-03 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Tue, 3 May 2011 22:14:46 +0000 (22:14 +0000)]
2011-05-03  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        WebKit allows selection that crosses the shadow boundary of a readonly input element
        https://bugs.webkit.org/show_bug.cgi?id=60000

        Added pixel tests to ensure WebKit doesn't create a selection that spans across
        the shadow DOM boundary of a readonly input element. Also rebaselined a test that
        previously exhibited this behavior.

        * editing/selection/resources/select-across-readonly-input.js: Added.
        (moveMouseToMiddleOfElement):
        * editing/selection/select-across-readonly-input-1.html: Added.
        * editing/selection/select-across-readonly-input-2.html: Added.
        * editing/selection/select-across-readonly-input-3.html: Added.
        * editing/selection/select-across-readonly-input-4.html: Added.
        * editing/selection/select-across-readonly-input-5.html: Added.
        * platform/mac/editing/selection/select-across-readonly-input-1-expected.png: Added.
        * platform/mac/editing/selection/select-across-readonly-input-1-expected.txt: Added.
        * platform/mac/editing/selection/select-across-readonly-input-2-expected.png: Added.
        * platform/mac/editing/selection/select-across-readonly-input-2-expected.txt: Added.
        * platform/mac/editing/selection/select-across-readonly-input-3-expected.png: Added.
        * platform/mac/editing/selection/select-across-readonly-input-3-expected.txt: Added.
        * platform/mac/editing/selection/select-across-readonly-input-4-expected.png: Added.
        * platform/mac/editing/selection/select-across-readonly-input-4-expected.txt: Added.
        * platform/mac/editing/selection/select-across-readonly-input-5-expected.png: Added.
        * platform/mac/editing/selection/select-across-readonly-input-5-expected.txt: Added.
        * platform/mac/fast/forms/input-readonly-autoscroll-expected.txt:
2011-05-03  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        WebKit allows selection that crosses the shadow boundary of a readonly input element
        https://bugs.webkit.org/show_bug.cgi?id=60000

        The bug was caused by VisibleSelection's not validating shadow DOM boundaries.
        Fixed the bug by adding an extra adjustment, adjustSelectionToAvoidCrossingShadowBoundaries,
        in its validation process.

        Tests: editing/selection/select-across-readonly-input-1.html
               editing/selection/select-across-readonly-input-2.html
               editing/selection/select-across-readonly-input-3.html
               editing/selection/select-across-readonly-input-4.html
               editing/selection/select-across-readonly-input-5.html

        * editing/VisibleSelection.cpp:
        (WebCore::VisibleSelection::validate): Calls adjustSelectionToAvoidCrossingShadowBoundaries.
        (WebCore::VisibleSelection::adjustSelectionToAvoidCrossingShadowBoundaries): Added.
        * editing/VisibleSelection.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-03 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 3 May 2011 22:11:39 +0000 (22:11 +0000)]
2011-05-03  Eric Seidel  <eric@webkit.org>

        Reviewed by Ryosuke Niwa.

        Split out layoutRunsAndFloats from layoutInlineChildren
        https://bugs.webkit.org/show_bug.cgi?id=60052

        No new tests, just moving code here.  There should be
        no change in behavior.

        * rendering/RenderBlock.h:
        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::RenderBlock::layoutRunsAndFloats):
        (WebCore::RenderBlock::layoutInlineChildren):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Layout tests may timeout if loadFinished receives false
luiz@webkit.org [Tue, 3 May 2011 22:05:22 +0000 (22:05 +0000)]
[Qt] Layout tests may timeout if loadFinished receives false
https://bugs.webkit.org/show_bug.cgi?id=60064

Reviewed by NOBODY Kenneth Rohde Christiansen.

When using layoutTestController.queueLoad(), if QWebPage::loadFinished(bool) receives false
then the layout test may timout. It happens that QWebPage::loadFinished() receives false when
a response is ignored, like it should be for 204 responses. It is a problem for creating
tests for 204 responses for example.

This change has been tested and it causes no regressions in layout tests.

* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::maybeDump):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-03 Alpha Lam <hclam@chromium.org>
hclam@chromium.org [Tue, 3 May 2011 22:05:14 +0000 (22:05 +0000)]
2011-05-03  Alpha Lam  <hclam@chromium.org>

        Not reviewed. Build fix.

        Add expectation to suppress new failure.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-03 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Tue, 3 May 2011 21:51:33 +0000 (21:51 +0000)]
2011-05-03  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, rolling out r85659.
        http://trac.webkit.org/changeset/85659
        https://bugs.webkit.org/show_bug.cgi?id=59977

        restarting isn't working correctly

        * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
        * Scripts/webkitpy/layout_tests/port/http_server.py:
        * Scripts/webkitpy/layout_tests/port/http_server_base.py:
        * Scripts/webkitpy/layout_tests/port/websocket_server.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt][WK2] Support PageGroup in QGraphicsWKView/QWKPage constructors
ossy@webkit.org [Tue, 3 May 2011 21:47:07 +0000 (21:47 +0000)]
[Qt][WK2] Support PageGroup in QGraphicsWKView/QWKPage constructors
https://bugs.webkit.org/show_bug.cgi?id=59638

* platform/qt-wk2/Skipped: Add failing tests until fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-03 James Robinson <jamesr@chromium.org>
hclam@chromium.org [Tue, 3 May 2011 21:40:29 +0000 (21:40 +0000)]
2011-05-03  James Robinson  <jamesr@chromium.org>

        Reviewed by Kenneth Russell.

        [chromium] Resizing a 2d canvas to huge dimensions after compositing crashes with accelerated 2d canvas option enabled
        https://bugs.webkit.org/show_bug.cgi?id=59965

        Adds a test with a canvas rendered once with normal width/height dimensions then resized to very large dimensions.

        * fast/canvas/canvas-resize-after-paint-expected.txt: Added.
        * fast/canvas/canvas-resize-after-paint.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/9250444> Enter key doesn't work in a web text field (but Return key...
darin@apple.com [Tue, 3 May 2011 21:33:23 +0000 (21:33 +0000)]
<rdar://problem/9250444> Enter key doesn't work in a web text field (but Return key does)

Reviewed by Sam Weinig.

No test at this time because the WebKit2 eventSender doesn't use this code path.

* Shared/mac/WebEventFactory.mm:
(WebKit::WebEventFactory::createWebKeyboardEvent): Copied the code to special-case certain
keys from the corresponding Mac WebKit1 code path.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-03 James Robinson <jamesr@chromium.org>
jamesr@google.com [Tue, 3 May 2011 21:21:27 +0000 (21:21 +0000)]
2011-05-03  James Robinson  <jamesr@chromium.org>

        Reviewed by Kenneth Russell.

        [chromium] Resizing a 2d canvas to huge dimensions after compositing crashes with accelerated 2d canvas option enabled
        https://bugs.webkit.org/show_bug.cgi?id=59965

        Adds a test with a canvas rendered once with normal width/height dimensions then resized to very large dimensions.

        * fast/canvas/canvas-resize-after-paint-expected.txt: Added.
        * fast/canvas/canvas-resize-after-paint.html: Added.
2011-05-03  James Robinson  <jamesr@chromium.org>

        Reviewed by Kenneth Russell.

        [chromium] Resizing a 2d canvas to huge dimensions after compositing crashes with accelerated 2d canvas option enabled
        https://bugs.webkit.org/show_bug.cgi?id=59965

        Fixes a few bugs leading to a crash if a canvas already being composited was resized to huge dimensions.

        Test: fast/canvas/canvas-resize-after-paint.html

        * html/canvas/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::reset):
            Mark the canvas's layer as needing a synthetic style recalculation when creating or destroying the backing
            DrawingBuffer so that we exit compositing mode properly if we can't handle the canvas dimensions.
        * platform/graphics/chromium/Canvas2DLayerChromium.cpp:
        (WebCore::Canvas2DLayerChromium::setLayerRenderer):
            Add a null check for m_drawingBuffer
        * platform/graphics/gpu/DrawingBuffer.cpp:
        (WebCore::DrawingBuffer::clear):
            Avoid clearing the m_context pointer in reset() - we destroy the DrawingBuffer whenever reset() fails, so
            this is unnecessary.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-03 Tony Chang <tony@chromium.org>
tony@chromium.org [Tue, 3 May 2011 21:21:15 +0000 (21:21 +0000)]
2011-05-03  Tony Chang  <tony@chromium.org>

        Unreviewed, rolling the version of chromium to r83922.

        * DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-03 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Tue, 3 May 2011 21:18:43 +0000 (21:18 +0000)]
2011-05-03  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Ojan Vafai.

        new-run-webkit-tests: fix http server startup/shutdown

        Previous versions of the code had three problems that made startup
        and shutdown flaky. The first is that it would throw exceptions
        if it couldn't delete stale log files, which was overly
        paranoid. The second is that some of the exceptions weren't
        defined properly. The third, and most important, is that it was
        using urllib to check if ports were available, which was leaving
        sockets in a half-closed state, and keeping ports from being
        reused. By switching to raw sockets, we are able to now reliably
        restart.

        This change also switches the code to using Executives to stop
        processes, which will let us delete a bunch of code in the
        port/* implementations and fix a weird layering problem in a
        subsequent patch.

        https://bugs.webkit.org/show_bug.cgi?id=59977

        * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
        * Scripts/webkitpy/layout_tests/port/http_server.py:
        * Scripts/webkitpy/layout_tests/port/http_server_base.py:
        * Scripts/webkitpy/layout_tests/port/websocket_server.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-03 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Tue, 3 May 2011 21:14:48 +0000 (21:14 +0000)]
2011-05-03  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Adam Barth.

        fix failing printing_unittest on win32
        https://bugs.webkit.org/show_bug.cgi?id=59963

        * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-03 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
caio.oliveira@openbossa.org [Tue, 3 May 2011 20:57:14 +0000 (20:57 +0000)]
2011-05-03  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>

        Reviewed by Adam Roben.

        Add tests to PrettyPatch
        https://bugs.webkit.org/show_bug.cgi?id=57298

        Verify that 'prettify' parse the right number of files and parts
        (add/remove/shared) by checking a set of patches available in
        bugs.webkit.org.

        * PrettyPatch/PrettyPatch.rb: exported a couple a globals with
        statistics information for our test script.
        * PrettyPatch/PrettyPatch_test.rb: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd some missing virtual keywords on derived-class destructors
aroben@apple.com [Tue, 3 May 2011 20:55:44 +0000 (20:55 +0000)]
Add some missing virtual keywords on derived-class destructors

Darin Adler noticed one, I noticed the other. This doesn't change the generated code; it
just matches our style of explicitly marking overrides "virtual".

* WebCoreSupport/WebInspectorClient.h: Made the WebInspectorClient and
WebInspectorFrontendClient destructors explicitly virtual.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-03 Jeff Miller <jeffm@apple.com>
jeffm@apple.com [Tue, 3 May 2011 20:54:26 +0000 (20:54 +0000)]
2011-05-03  Jeff Miller  <jeffm@apple.com>

        Reviewed by Darin Adler.

        Unreachable URL is lost when canceling load of a new page
        https://bugs.webkit.org/show_bug.cgi?id=60057
        <rdar://problem/9049135>

        When setting the unreachable URL in the WebFrameProxy, keep track of any previous unreachable URL
        so we can restore it if the page load fails.

        * UIProcess/WebFrameProxy.cpp:
        (WebKit::WebFrameProxy::didFailProvisionalLoad): Restore m_unreachableURL to previous value.
        (WebKit::WebFrameProxy::setUnreachableURL): Keep track of previous unreachable URL in m_lastUnreachableURL.
        * UIProcess/WebFrameProxy.h: Moved setUnreachableURL() implementation to .cpp file, added m_lastUnreachableURL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-03 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Tue, 3 May 2011 20:51:46 +0000 (20:51 +0000)]
2011-05-03  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Tony Chang.

        store results.html options in localstorage
        https://bugs.webkit.org/show_bug.cgi?id=60048

        This makes options persistent per-domain. It's not perfect,
        but it should make it possible to have preferences for how
        people would like the results.html page to render.

        * fast/harness/resources/results-test.js:
        * fast/harness/results.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix most strict PassOwnPtr violations on Windows
aroben@apple.com [Tue, 3 May 2011 20:51:30 +0000 (20:51 +0000)]
Fix most strict PassOwnPtr violations on Windows

Fixes <http://webkit.org/b/60025> Windows should (almost) build with strict PassOwnPtr
enabled

Reviewed by Anders Carlsson.

Source/WebCore:

* loader/EmptyClients.h:
* platform/GeolocationService.cpp:
* platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
* platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
* platform/mock/GeolocationServiceMock.cpp:
* rendering/RenderTheme.cpp:
* rendering/RenderThemeSafari.cpp:

Source/WebKit/win:

* WebCoreSupport/WebInspectorClient.h: Made the destructor public, which is required now
that this type is put into a PassOwnPtr. (Previously, only
WebCore::InspectorFrontendClientLocal was put into a [Pass]OwnPtr.)

* FullscreenVideoController.cpp:
* WebCoreSupport/WebFrameLoaderClient.cpp:
* WebCoreSupport/WebInspectorClient.cpp:
* WebHistory.cpp:
* WebHistoryItem.cpp:
* WebView.cpp:

Source/WebKit2:

* Platform/CoreIPC/win/ConnectionWin.cpp:
(CoreIPC::Connection::writeEventHandler): Use nullptr.

Tools:

* WebKitAPITest/Test.h: Use adoptPtr.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-03 Levi Weintraub <leviw@chromium.org>
leviw@chromium.org [Tue, 3 May 2011 20:49:15 +0000 (20:49 +0000)]
2011-05-03  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Eric Seidel.

        Extract LineInfo class
        https://bugs.webkit.org/show_bug.cgi?id=60044

        Created a LineInfo class in RenderBlockLineLayout.cpp that brings together the relevant
        layout information about a line. This simplifies function signatures and clears up initialization.

        No new tests as this is refactoring.

        * rendering/RenderBlock.h: Updated internal layout function signatures to use LineInfo.
        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::LineInfo::LineInfo):
        (WebCore::LineInfo::isFirstLine):
        (WebCore::LineInfo::isLastLine):
        (WebCore::LineInfo::isEmpty):
        (WebCore::LineInfo::previousLineBrokeCleanly):
        (WebCore::LineInfo::setFirstLine):
        (WebCore::LineInfo::setLastLine):
        (WebCore::LineInfo::setEmpty):
        (WebCore::LineInfo::setPreviousLineBrokeCleanly):
        (WebCore::RenderBlock::createLineBoxes):
        (WebCore::RenderBlock::constructLine):
        (WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
        (WebCore::RenderBlock::layoutInlineChildren):
        (WebCore::RenderBlock::determineStartPosition):
        (WebCore::skipNonBreakingSpace):
        (WebCore::shouldCollapseWhiteSpace):
        (WebCore::requiresLineBox): Moved from RenderBlock.h and made it locally scoped to RenderBlockLineLayout.cpp
        (WebCore::RenderBlock::generatesLineBoxesForInlineChild):
        (WebCore::RenderBlock::skipTrailingWhitespace):
        (WebCore::RenderBlock::skipLeadingWhitespace):
        (WebCore::RenderBlock::findNextLineBreak):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-03 Leandro Pereira <leandro@profusion.mobi>
leandro@webkit.org [Tue, 3 May 2011 20:39:14 +0000 (20:39 +0000)]
2011-05-03  Leandro Pereira  <leandro@profusion.mobi>

        [EFL] Unreviewed build fix for NETWORK_BACKEND=curl.

        Force linking with zlib so that uncompress() exists.

        * Source/cmake/OptionsEfl.cmake: Find zlib.
2011-05-03  Leandro Pereira  <leandro@profusion.mobi>

        [EFL] Unreviewed build fix for NETWORK_BACKEND=curl.

        Force linking with zlib so that uncompress() exists.

        * CMakeListsEfl.txt: Append zlib libraries.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-03 Roland Steiner <rolandsteiner@chromium.org>
rolandsteiner@chromium.org [Tue, 3 May 2011 20:35:39 +0000 (20:35 +0000)]
2011-05-03  Roland Steiner  <rolandsteiner@chromium.org>

        Reviewed by Dimitri Glazkov.

        Update node list cache count on the containing TreeScope rather than the Document
        https://bugs.webkit.org/show_bug.cgi?id=59983

        Change code to call add/removeNodeListCache() and hasNodeListCaches() on the proper tree scope.
        Move updating of the node list cache count from setDocument() to setTreeScopeRecursively().
        Make setDocument() and setDocumentRecursively() private.

        No new tests. (refactoring)

        * dom/ContainerNode.cpp:
        (WebCore::ContainerNode::childrenChanged):
        * dom/Node.cpp:
        (WebCore::Node::~Node):
        (WebCore::Node::setDocument):
        (WebCore::Node::setTreeScopeRecursively):
        (WebCore::Node::childNodes):
        (WebCore::Node::registerDynamicNodeList):
        (WebCore::Node::unregisterDynamicNodeList):
        (WebCore::Node::notifyLocalNodeListsAttributeChanged):
        (WebCore::Node::notifyLocalNodeListsChildrenChanged):
        (WebCore::Node::getElementsByTagName):
        (WebCore::Node::getElementsByTagNameNS):
        (WebCore::Node::getElementsByName):
        (WebCore::Node::getElementsByClassName):
        * dom/Node.h:
        * html/HTMLFormControlElement.cpp:
        (WebCore::HTMLFormControlElement::labels):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-03 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Tue, 3 May 2011 20:33:25 +0000 (20:33 +0000)]
2011-05-03  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        Bundle trailingSpaceObject and trailingPositionedBoxes in findNextLineBreak as a class
        https://bugs.webkit.org/show_bug.cgi?id=60046

        Extracted TrailingObjects that encapsulates trailingSpaceObject and trailingPositionedBoxes.

        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::TrailingObjects::TrailingObjects):
        (WebCore::TrailingObjects::setTrailingWhitespace):
        (WebCore::TrailingObjects::clear):
        (WebCore::TrailingObjects::appendBoxIfNeeded):
        (WebCore::TrailingObjects::addMidpoints):
        (WebCore::RenderBlock::findNextLineBreak):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-03 Igor Oliveira <igor.oliveira@openbossa.org>
commit-queue@webkit.org [Tue, 3 May 2011 20:29:58 +0000 (20:29 +0000)]
2011-05-03  Igor Oliveira  <igor.oliveira@openbossa.org>

        Reviewed by Eric Seidel.

        [Qt] Implement initial support to DataTransferItems
        https://bugs.webkit.org/show_bug.cgi?id=58448

        Remove data-transfer-items.html from Qt skipped tests and create an expected
        result file for data-transfer-items.html test. The need to create a expected result
        file is because the test presuppose that the type of the first element in
        DataTransferItems list is a html but when Qt selects a data, it first copies a text
        and then it copies the html, so for Qt expected test file the first element is a
        text and the second one is a html.

        * platform/qt/Skipped:
        * platform/qt/editing/pasteboard/data-transfer-items-expected.txt: Added.
2011-05-03  Igor Oliveira  <igor.oliveira@openbossa.org>

        Reviewed by Eric Seidel.

        [Qt] Implement initial support to DataTransferItems
        https://bugs.webkit.org/show_bug.cgi?id=58448

        Implement initial support to DataTransferItems. DataTransferItems are used to
        hold data for drag and drop operations. DataTransferItems hold a list of
        DataTransferItem objects each of which holds an item being dragged.

        * WebCore.pro:
        * dom/DataTransferItems.idl:
        * editing/qt/EditorQt.cpp:
        (WebCore::Editor::newGeneralClipboard):
        * page/qt/EventHandlerQt.cpp:
        (WebCore::EventHandler::createDraggingClipboard):
        * platform/chromium/DataTransferItemsChromium.h:
        * platform/qt/ClipboardQt.cpp:
        (WebCore::Clipboard::create):
        (WebCore::ClipboardQt::ClipboardQt):
        (WebCore::ClipboardQt::items):
        * platform/qt/ClipboardQt.h:
        (WebCore::ClipboardQt::create):
        * platform/qt/DataTransferItemQt.cpp: Added.
        (WebCore::DataTransferItem::create):
        (WebCore::DataTransferItemQt::createFromPasteboard):
        (WebCore::DataTransferItemQt::create):
        (WebCore::DataTransferItemQt::DataTransferItemQt):
        (WebCore::DataTransferItemQt::getAsString):
        (WebCore::DataTransferItemQt::getAsFile):
        * platform/qt/DataTransferItemQt.h: Added.
        * platform/qt/DataTransferItemsQt.cpp: Copied from Source/WebCore/editing/qt/EditorQt.cpp.
        (WebCore::DataTransferItemsQt::create):
        (WebCore::DataTransferItemsQt::DataTransferItemsQt):
        (WebCore::DataTransferItemsQt::addPasteboardItem):
        * platform/qt/DataTransferItemsQt.h: Copied from Source/WebCore/editing/qt/EditorQt.cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-03 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
caio.oliveira@openbossa.org [Tue, 3 May 2011 20:22:04 +0000 (20:22 +0000)]
2011-05-03  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>

        Reviewed by Andreas Kling.

        Add myself to the committers list.

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-03 Alpha Lam <hclam@chromium.org>
hclam@chromium.org [Tue, 3 May 2011 20:16:10 +0000 (20:16 +0000)]
2011-05-03  Alpha Lam  <hclam@chromium.org>

        Not reviewed. Build fix.

        new baseline for SVG test.

        * platform/chromium-win-vista/svg/text/text-intro-05-t-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-03 Alpha Lam <hclam@chromium.org>
hclam@chromium.org [Tue, 3 May 2011 20:11:39 +0000 (20:11 +0000)]
2011-05-03  Alpha Lam  <hclam@chromium.org>

        Not reviewed. Build fix.

        New baseline for GPU layout tests.

        * platform/chromium-gpu-mac/animations/3d/matrix-transform-type-animation-expected.png: Added.
        * platform/chromium-gpu-mac/animations/3d/state-at-end-event-transform-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-03 Julien Chaffraix <jchaffraix@codeaurora.org>
commit-queue@webkit.org [Tue, 3 May 2011 20:08:26 +0000 (20:08 +0000)]
2011-05-03  Julien Chaffraix  <jchaffraix@codeaurora.org>

        Reviewed by Dimitri Glazkov.

        Element:shadowRoot & Element::ensureShadowRoot should return ShadowRoot*
        https://bugs.webkit.org/show_bug.cgi?id=58703

        No new tests, refactoring only.

        * dom/Element.cpp:
        (WebCore::Element::copyNonAttributeProperties):
        (WebCore::Element::insertedIntoDocument):
        (WebCore::Element::removedFromDocument):
        (WebCore::Element::insertedIntoTree):
        (WebCore::Element::removedFromTree):
        (WebCore::Element::attach):
        (WebCore::Element::detach):
        (WebCore::Element::recalcStyle):
        (WebCore::Element::shadowRoot):
        (WebCore::Element::ensureShadowRoot):
        (WebCore::Element::childrenChanged):
        * dom/Node.cpp:
        (WebCore::Node::setTreeScopeRecursively):
        (WebCore::shadowRoot):
        (WebCore::Node::setDocumentRecursively):
        (WebCore::NodeRendererFactory::findVisualParent):
        Updated all the call sites for shadowRoot and ensureShadowRoot in the 2
        previous classes.

        * dom/Element.h: Updated 2 methods' signature to return a ShadowRoot*.

        * dom/ShadowRoot.h: Removed toShadowRoot as it is not used anymore.

        * html/HTMLDetailsElement.cpp:
        * html/HTMLSummaryElement.cpp:
        Added #include for ShadowRoot.h.
2011-05-03  Julien Chaffraix  <jchaffraix@codeaurora.org>

        Reviewed by Dimitri Glazkov.

        Element:shadowRoot & Element::ensureShadowRoot should return ShadowRoot*
        https://bugs.webkit.org/show_bug.cgi?id=58703

        * src/WebElement.cpp: Added #include for ShadowRoot.h.
2011-05-03  Julien Chaffraix  <jchaffraix@codeaurora.org>

        Reviewed by Dimitri Glazkov.

        Element:shadowRoot & Element::ensureShadowRoot should return ShadowRoot*
        https://bugs.webkit.org/show_bug.cgi?id=58703

        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp: Added #include for ShadowRoot.h.
2011-05-03  Julien Chaffraix  <jchaffraix@codeaurora.org>

        Reviewed by Dimitri Glazkov.

        Element:shadowRoot & Element::ensureShadowRoot should return ShadowRoot*
        https://bugs.webkit.org/show_bug.cgi?id=58703

        * DOM/WebDOMOperations.mm: Added #include for ShadowRoot.h.
2011-05-03  Julien Chaffraix  <jchaffraix@codeaurora.org>

        Reviewed by Dimitri Glazkov.

        Element:shadowRoot & Element::ensureShadowRoot should return ShadowRoot*
        https://bugs.webkit.org/show_bug.cgi?id=58703

        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
        (DumpRenderTreeSupportQt::shadowRoot): Added #include for ShadowRoot.h.
2011-05-03  Julien Chaffraix  <jchaffraix@codeaurora.org>

        Reviewed by Dimitri Glazkov.

        Element:shadowRoot & Element::ensureShadowRoot should return ShadowRoot*
        https://bugs.webkit.org/show_bug.cgi?id=58703

        * WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp: Added #include for ShadowRoot.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-03 Gyuyoung Kim <gyuyoung.kim@samsung.com>
gyuyoung.kim@samsung.com [Tue, 3 May 2011 20:07:20 +0000 (20:07 +0000)]
2011-05-03  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Reviewed by Kenneth Rohde Christiansen.

        [EFL] Implement mediaSliderTrack
        https://bugs.webkit.org/show_bug.cgi?id=59998

        Implement paintMediaSliderTrack.

        * platform/efl/RenderThemeEfl.cpp:
        (WebCore::RenderThemeEfl::RenderThemeEfl):
        (WebCore::RenderThemeEfl::paintMediaSliderTrack):
        * platform/efl/RenderThemeEfl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-03 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Tue, 3 May 2011 20:03:34 +0000 (20:03 +0000)]
2011-05-03  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        WebInspector: [Chromium] Fix slowness of Summary view nodes expansion in detailed heap profiles.
        https://bugs.webkit.org/show_bug.cgi?id=60023

        * inspector/front-end/DetailedHeapshotGridNodes.js:
        (WebInspector.HeapSnapshotConstructorNode):
        (WebInspector.HeapSnapshotConstructorNode.prototype._createNodesProvider):
        * inspector/front-end/HeapSnapshot.js:
        (WebInspector.HeapSnapshot.prototype.dispose):
        (WebInspector.HeapSnapshot.prototype.aggregates):
        (WebInspector.HeapSnapshot.prototype._buildAggregates):
        (WebInspector.HeapSnapshot.prototype._sortAggregateIndexes):
        (WebInspector.HeapSnapshot.prototype.createNodesProviderForClass):
        (WebInspector.HeapSnapshotFilteredOrderedIterator):
        (WebInspector.HeapSnapshotNodesProvider):
        * inspector/front-end/HeapSnapshotProxy.js:
        (WebInspector.HeapSnapshotProxy.prototype.aggregates):
        (WebInspector.HeapSnapshotProxy.prototype.createNodesProviderForClass):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-03 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Tue, 3 May 2011 19:52:59 +0000 (19:52 +0000)]
2011-05-03  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        WebInspector: [Chromium] Hint user that to display retaining paths, an object entry must be clicked.
        https://bugs.webkit.org/show_bug.cgi?id=60029

        * English.lproj/localizedStrings.js:
        * inspector/front-end/DetailedHeapshotView.js:
        (WebInspector.HeapSnapshotRetainingPathsList.prototype.reset):
        (WebInspector.DetailedHeapshotView.prototype._mouseClickInContainmentGrid):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-03 Keith Kyzivat <keith.kyzivat@nokia.com>
commit-queue@webkit.org [Tue, 3 May 2011 19:51:24 +0000 (19:51 +0000)]
2011-05-03  Keith Kyzivat  <keith.kyzivat@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] QtDeclarative Webview element has a fixed white background
        https://bugs.webkit.org/show_bug.cgi?id=40918

        QProperty REVISION feature is not present in certain Qt Trunk clones.
        These builds report their version as 4.8.0, and therefore break on the
        prior #if QT_VERSION >= 0x040704.  The proper fix is to check based on
        the existance of Q_REVISION.

        * declarative/plugin.cpp:
        (WebKitQmlPlugin::registerTypes):
        * declarative/qdeclarativewebview.cpp:
        * declarative/qdeclarativewebview_p.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-03 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Tue, 3 May 2011 19:50:26 +0000 (19:50 +0000)]
2011-05-03  Mario Sanchez Prada  <msanchez@igalia.com>

        Unreviewed, skipping test timing out in the GTK 64-bit bot.

        * platform/gtk/Skipped: Skipped media/video-volume-slider.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-03 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Tue, 3 May 2011 19:47:40 +0000 (19:47 +0000)]
2011-05-03  Ojan Vafai  <ojan@chromium.org>

        improve styling of options menu in results.html file

        * fast/harness/results.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-03 Alpha Lam <hclam@chromium.org>
hclam@chromium.org [Tue, 3 May 2011 19:42:09 +0000 (19:42 +0000)]
2011-05-03  Alpha Lam  <hclam@chromium.org>

        Not reviewed. Build fix.

        New baseline and add test expectation to suppress failure.

        * platform/chromium-gpu-win/animations/3d/replace-filling-transform-expected.png: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-03 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Tue, 3 May 2011 19:34:36 +0000 (19:34 +0000)]
2011-05-03  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Tony Chang.

        Don't include the test itself in expanded test results
        https://bugs.webkit.org/show_bug.cgi?id=60051

        When loading from local disk, we can't force it to render as
        plain text, which causes the page to actually run. Also,
        the extra clutter of another iframe is probably not worth it.

        If we decide we want this later, we can add it back in as a
        preference that's off by default.

        * fast/harness/results.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-03 Alpha Lam <hclam@chromium.org>
hclam@chromium.org [Tue, 3 May 2011 19:31:34 +0000 (19:31 +0000)]
2011-05-03  Alpha Lam  <hclam@chromium.org>

        Not reviewed. Build fix.

        Test expectation for a slow test to avoid flakiness.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-03 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Tue, 3 May 2011 19:25:08 +0000 (19:25 +0000)]
2011-05-03  Ojan Vafai  <ojan@chromium.org>

        Fix test that broke after adding CSS animations.

        * fast/harness/resources/results-test.js:
        * fast/harness/results-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-03 Alpha Lam <hclam@chromium.org>
ojan@chromium.org [Tue, 3 May 2011 19:19:25 +0000 (19:19 +0000)]
2011-05-03  Alpha Lam  <hclam@chromium.org>

        Not reviewed. Build fix.

        Adding test expectations for some SVG tests on Windows.

        * platform/chromium-win-vista/svg/text/text-fonts-01-t-expected.png: Removed.
        * platform/chromium-win-vista/svg/text/text-intro-05-t-expected.png: Added.
        * platform/chromium-win-xp/svg/text/text-fonts-01-t-expected.png: Added.
        * platform/chromium-win-xp/svg/text/text-intro-05-t-expected.png: Added.
        * platform/chromium-win/svg/text/text-fonts-01-t-expected.png: Added.
        * platform/chromium-win/svg/text/text-fonts-01-t-expected.txt: Added.
        * platform/chromium-win/svg/text/text-intro-05-t-expected.png:
        * platform/chromium-win/svg/text/text-intro-05-t-expected.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-03 Alpha Lam <hclam@chromium.org>
hclam@chromium.org [Tue, 3 May 2011 19:17:19 +0000 (19:17 +0000)]
2011-05-03  Alpha Lam  <hclam@chromium.org>

        Not reviewed. Build fix.

        Adding test expectations for some SVG tests on Windows.

        * platform/chromium-win-vista/svg/text/text-fonts-01-t-expected.png: Removed.
        * platform/chromium-win-vista/svg/text/text-intro-05-t-expected.png: Added.
        * platform/chromium-win-xp/svg/text/text-fonts-01-t-expected.png: Added.
        * platform/chromium-win-xp/svg/text/text-intro-05-t-expected.png: Added.
        * platform/chromium-win/svg/text/text-fonts-01-t-expected.png: Added.
        * platform/chromium-win/svg/text/text-fonts-01-t-expected.txt: Added.
        * platform/chromium-win/svg/text/text-intro-05-t-expected.png:
        * platform/chromium-win/svg/text/text-intro-05-t-expected.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-03 Mark Pilgrim <pilgrim@chromium.org>
commit-queue@webkit.org [Tue, 3 May 2011 19:11:39 +0000 (19:11 +0000)]
2011-05-03  Mark Pilgrim  <pilgrim@chromium.org>

        Reviewed by Tony Chang.

        Port Mozilla's IndexedDB tests: cursor update updates indexes
        https://bugs.webkit.org/show_bug.cgi?id=59995

        This test creates an object store, adds both a unique and a non-unique index,
        adds a record, opens a cursor, changes the record, and verifies that both
        indexes correctly updated to reflect the modified record.

        * storage/indexeddb/mozilla/cursor-update-updates-indexes-expected.txt: Added.
        * storage/indexeddb/mozilla/cursor-update-updates-indexes.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-03 James Robinson <jamesr@chromium.org>
jamesr@google.com [Tue, 3 May 2011 18:45:46 +0000 (18:45 +0000)]
2011-05-03  James Robinson  <jamesr@chromium.org>

        Remove stale expectations for animations/3d in chromium test_expectations.txt

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=60045
bdakin@apple.com [Tue, 3 May 2011 18:45:23 +0000 (18:45 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=60045
Scrollbar thumb sometimes leaves artifacts in the track after scrolling
-and corresponding-
<rdar://problem/9015376>

Reviewed by Dan Bernstein.

When we're using WK_SCROLLBAR_PAINTER, the AppleScrollBarVariant default should
always be ignored.
* platform/mac/ScrollbarThemeMac.mm:
(WebCore::updateArrowPlacement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-03 James Robinson <jamesr@chromium.org>
jamesr@google.com [Tue, 3 May 2011 18:43:42 +0000 (18:43 +0000)]
2011-05-03  James Robinson  <jamesr@chromium.org>

        Reviewed by Kenneth Russell.

        [chromium] Layout test animations/3d/replace-filling-transform.html failing
        https://bugs.webkit.org/show_bug.cgi?id=59839

        Ignore animations/3d when run in CPU mode as these are compositor tests.

        * platform/chromium/test_expectations.txt:
2011-05-03  James Robinson  <jamesr@chromium.org>

        Reviewed by Kenneth Russell.

        [chromium] Layout test animations/3d/replace-filling-transform.html failing
        https://bugs.webkit.org/show_bug.cgi?id=59839

        Add animations/3d to the list of tests run in the chromium-gpu configuration since these tests exercise the compositor.

        * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-03 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Tue, 3 May 2011 18:18:06 +0000 (18:18 +0000)]
2011-05-03  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Tony Chang.

        make pixel zooming in results.html file less jarring
        https://bugs.webkit.org/show_bug.cgi?id=60038

        -Hide zoomed images when you mouse out of the document or
        mouseover an iframe.
        -Handle the case where the zoomed images overlap the actual images.

        * fast/harness/results.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-03 Lucas De Marchi <lucas.demarchi@profusion.mobi>
demarchi@webkit.org [Tue, 3 May 2011 18:15:51 +0000 (18:15 +0000)]
2011-05-03  Lucas De Marchi  <lucas.demarchi@profusion.mobi>

        Unreviewed, rolling out r85471.
        http://trac.webkit.org/changeset/85471
        https://bugs.webkit.org/show_bug.cgi?id=59922

        The rule of thumb in EFL is that you init in all the places
        you use it. So, if in your application you call ecore_evas_*
        functions, you have to call ecore_evas_init() first.

        * EWebLauncher/main.c: always call *_init() functions when you use
        that namespace.
        (quit):
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-03 Lucas De Marchi <lucas.demarchi@profusion.mobi>
demarchi@webkit.org [Tue, 3 May 2011 18:10:59 +0000 (18:10 +0000)]
2011-05-03  Lucas De Marchi  <lucas.demarchi@profusion.mobi>

        [CMAKE] Unreviewed build fix for gcc >= 4.6

        Same fix as done in r84123. CMake explicitly pass the arguments to
        make_names.pl, so let's make them the same.

        * Source/cmake/OptionsCommon.cmake: ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=60040
hyatt@apple.com [Tue, 3 May 2011 18:00:23 +0000 (18:00 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=60040
<rdar://problem/9261591>

Reviewed by Dan Bernstein.

Links broken at iplanwebsites.com. Make sure that culledInlineAbsoluteQuads still does
a translation of a 0,0 point to absolute coordinates so that the top left position is
accurate.

Source/WebCore:

Added fast/inline/skipped-whitespace-client-rect.html

* rendering/RenderInline.cpp:
(WebCore::RenderInline::culledInlineAbsoluteQuads):

LayoutTests:

Added fast/inline/skipped-whitespace-client-rect.html

* fast/inline/skipped-whitespace-client-rect-expected.txt: Added.
* fast/inline/skipped-whitespace-client-rect.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMore quarantine related sandbox denial when downloading files
weinig@apple.com [Tue, 3 May 2011 17:43:44 +0000 (17:43 +0000)]
More quarantine related sandbox denial when downloading files
<rdar://problem/9362626>

Reviewed by Anders Carlsson.

* WebProcess/com.apple.WebProcess.sb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-03 Xan Lopez <xlopez@igalia.com>
alexis.menard@openbossa.org [Tue, 3 May 2011 17:34:15 +0000 (17:34 +0000)]
2011-05-03  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Anders Carlsson.

        Compile error with GCC 4.6.0, tries to assign unsigned& to bitfield
        https://bugs.webkit.org/show_bug.cgi?id=59261

        Use unary '+' to force proper type detection in template arguments
        with GCC 4.6.0. See bug report for more details.

        * runtime/Structure.cpp:
        (JSC::StructureTransitionTable::remove): Use '+' to force precise type detection.
        (JSC::StructureTransitionTable::add): ditto.
        * runtime/Structure.h:
        (JSC::StructureTransitionTable::keyForWeakGCMapFinalizer): ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix chromium build.
weinig@apple.com [Tue, 3 May 2011 17:27:01 +0000 (17:27 +0000)]
Fix chromium build.

* page/Settings.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-02 Roland Steiner <rolandsteiner@chromium.org>
rolandsteiner@chromium.org [Tue, 3 May 2011 17:20:17 +0000 (17:20 +0000)]
2011-05-02  Roland Steiner  <rolandsteiner@chromium.org>

        Reviewed by Dimitri Glazkov.

        Bug 59974 - Update image map on the containing TreeScope rather than the Document
        https://bugs.webkit.org/show_bug.cgi?id=59974

        No new tests. (reefactoring)

        * html/HTMLMapElement.cpp:
        (WebCore::HTMLMapElement::parseMappedAttribute):
        (WebCore::HTMLMapElement::insertedIntoDocument):
        (WebCore::HTMLMapElement::removedFromDocument):
        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::imageMap):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix chromium build.
weinig@apple.com [Tue, 3 May 2011 17:18:28 +0000 (17:18 +0000)]
Fix chromium build.

* loader/HistoryController.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-02 Roland Steiner <rolandsteiner@chromium.org>
rolandsteiner@chromium.org [Tue, 3 May 2011 17:17:44 +0000 (17:17 +0000)]
2011-05-02  Roland Steiner  <rolandsteiner@chromium.org>

        Reviewed by Dimitri Glazkov.

        Bug 59966 - Update ID hash on the containing TreeScope rather than the Document
        https://bugs.webkit.org/show_bug.cgi?id=59966

        No new tests. (refactoring)

        * accessibility/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::elementsFromAttribute):
        (WebCore::AccessibilityRenderObject::activeDescendant):
        * accessibility/AccessibilityRenderObject.h:
        (WebCore::AccessibilityRenderObject::isAccessibilityRenderObject):
        * css/CSSCursorImageValue.cpp:
        (WebCore::resourceReferencedByCursorElement):
        (WebCore::CSSCursorImageValue::~CSSCursorImageValue):
        (WebCore::CSSCursorImageValue::updateIfSVGCursorIsUsed):
        (WebCore::CSSCursorImageValue::cachedImage):
        * dom/DynamicNodeList.cpp:
        (WebCore::DynamicNodeList::itemWithName):
        * dom/Element.h:
        (WebCore::Element::updateId):
        * dom/Node.cpp:
        (WebCore::Node::querySelector):
        * html/FormAssociatedElement.cpp:
        (WebCore::FormAssociatedElement::insertedIntoTree):
        (WebCore::FormAssociatedElement::resetFormOwner):
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::dataList):
        * html/HTMLLabelElement.cpp:
        (WebCore::HTMLLabelElement::control):
        * rendering/svg/RenderSVGTextPath.cpp:
        (WebCore::RenderSVGTextPath::layoutPath):
        * svg/SVGAElement.cpp:
        (WebCore::SVGAElement::defaultEventHandler):
        * svg/SVGAltGlyphElement.cpp:
        (WebCore::SVGAltGlyphElement::glyphElement):
        * svg/SVGFEImageElement.cpp:
        (WebCore::SVGFEImageElement::requestImageResource):
        (WebCore::SVGFEImageElement::build):
        * svg/SVGLinearGradientElement.cpp:
        (WebCore::SVGLinearGradientElement::collectGradientAttributes):
        * svg/SVGMPathElement.cpp:
        (WebCore::SVGMPathElement::pathElement):
        * svg/SVGPatternElement.cpp:
        (WebCore::SVGPatternElement::collectPatternAttributes):
        * svg/SVGRadialGradientElement.cpp:
        (WebCore::SVGRadialGradientElement::collectGradientAttributes):
        * svg/SVGSVGElement.cpp:
        (WebCore::SVGSVGElement::getElementById):
        * svg/SVGTRefElement.cpp:
        (WebCore::SVGTRefElement::updateReferencedText):
        * svg/SVGTextPathElement.cpp:
        (WebCore::SVGTextPathElement::insertedIntoDocument):
        * svg/SVGUseElement.cpp:
        (WebCore::SVGUseElement::buildPendingResource):
        (WebCore::SVGUseElement::hasCycleUseReferencing):
        (WebCore::SVGUseElement::expandUseElementsInShadowTree):
        * svg/SVGViewSpec.cpp:
        (WebCore::SVGViewSpec::viewTarget):
        * svg/animation/SVGSMILElement.cpp:
        (WebCore::SVGSMILElement::eventBaseFor):
        (WebCore::SVGSMILElement::connectConditions):
        (WebCore::SVGSMILElement::targetElement):
        * xml/XPathFunctions.cpp:
        (WebCore::XPath::FunId::evaluate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix chromium build.
weinig@apple.com [Tue, 3 May 2011 17:14:56 +0000 (17:14 +0000)]
Fix chromium build.

* css/StyleMedia.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoPrune #includes from FrameView.h (Part 1)
weinig@apple.com [Tue, 3 May 2011 17:11:29 +0000 (17:11 +0000)]
Prune #includes from FrameView.h (Part 1)
https://bugs.webkit.org/show_bug.cgi?id=59957

Reviewed by Anders Carlsson.

* page/FrameView.h:
Prune #includes.

* accessibility/chromium/AXObjectCacheChromium.cpp:
* page/win/FrameCGWin.cpp:
* platform/Scrollbar.cpp:
Add not necessary #includes.

* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
Add now necessary forward declaration.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-03 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Tue, 3 May 2011 16:45:30 +0000 (16:45 +0000)]
2011-05-03  Ojan Vafai  <ojan@chromium.org>

        Fix test accidentally modified in http://trac.webkit.org/changeset/85610.

        * fullscreen/full-screen-zIndex.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-02 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Tue, 3 May 2011 16:39:45 +0000 (16:39 +0000)]
2011-05-02  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Tony Chang.

        remove no longer used method
        https://bugs.webkit.org/show_bug.cgi?id=59981

        * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
        * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoPart 1 of 2: <http://webkit.org/b/59838> Implement HTTP pipelining for CoreFoundation...
ddkilzer@apple.com [Tue, 3 May 2011 16:33:47 +0000 (16:33 +0000)]
Part 1 of 2: <webkit.org/b/59838> Implement HTTP pipelining for CoreFoundation-based networking
<rdar://problem/8924448>

Reviewed by Adam Roben.

* win/include/WebKitSystemInterface/WebKitSystemInterface.h:
(wkGetHTTPPipeliningPriority): Added declaration.
(wkSetHTTPPipeliningMaximumPriority): Added declaration.
(wkSetHTTPPipeliningPriority): Added declaration.
* win/lib/WebKitSystemInterface.lib: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-02 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Tue, 3 May 2011 16:30:44 +0000 (16:30 +0000)]
2011-05-02  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Tony Chang.

        add image toggling behavior from old-run-webkit-tests
        https://bugs.webkit.org/show_bug.cgi?id=59978

        Add a checkbox to switch between image toggling (default)
        and just showing results for expected/actual images.

        * fast/harness/resources/results-test.js:
        * fast/harness/results-expected.txt:
        * fast/harness/results.html:
2011-05-02  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Tony Chang.

        add image toggling behavior from old-run-webkit-tests
        https://bugs.webkit.org/show_bug.cgi?id=59978

        Output -diffs.html files. This matches old-run-webkit-tests.
        In theory, we could use data urls in the results.html file, but
        data urls don't currently have access to local files.

        * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-02 Tony Chang <tony@chromium.org>
tony@chromium.org [Tue, 3 May 2011 16:25:30 +0000 (16:25 +0000)]
2011-05-02  Tony Chang  <tony@chromium.org>

        Reviewed by Ojan Vafai.

        [nrwt] remove some obsolete references to .checksum files
        https://bugs.webkit.org/show_bug.cgi?id=59971

        * Scripts/webkitpy/layout_tests/layout_package/printing.py:
        * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
        * Scripts/webkitpy/layout_tests/port/test.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-03 Satish Sampath <satish@chromium.org>
satish@chromium.org [Tue, 3 May 2011 16:22:06 +0000 (16:22 +0000)]
2011-05-03  Satish Sampath  <satish@chromium.org>

        Unreviewed, update test expectations for chromium.

        * platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.png:
        * platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.txt:
        * platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.png:
        * platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.txt:
        * platform/chromium-linux/fast/speech/input-appearance-speechbutton-expected.png:
        * platform/chromium-linux/fast/speech/input-appearance-speechbutton-expected.txt:
        * platform/chromium-mac-leopard/fast/speech/input-appearance-speechbutton-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-02 Adam Klein <adamk@chromium.org>
adamk@chromium.org [Tue, 3 May 2011 16:21:43 +0000 (16:21 +0000)]
2011-05-02  Adam Klein  <adamk@chromium.org>

        Reviewed by Tony Chang.

        Roll chromium DEPS to r83722, add new crypto directory to DEPS
        https://bugs.webkit.org/show_bug.cgi?id=59992

        * .gitignore:
        Ignore new chromium/crypto directory.
2011-05-02  Adam Klein  <adamk@chromium.org>

        Reviewed by Tony Chang.

        Roll chromium DEPS to r83722, add new crypto directory to DEPS
        https://bugs.webkit.org/show_bug.cgi?id=59992

        * DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-03 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Tue, 3 May 2011 16:18:29 +0000 (16:18 +0000)]
2011-05-03  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Dimitri Glazkov.

        [Chromium] toV8(Node*) will enter infinite recursion when called with a node of type SHADOW_ROOT_NODE
        https://bugs.webkit.org/show_bug.cgi?id=60026

        Return a wrapper for Node in toV8(Node*) when called with a node of type
        SHADOW_ROOT_NODE instead of entering infinite recursion.

        * bindings/v8/custom/V8NodeCustom.cpp:
        (WebCore::toV8Slow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRevert r85550 and r85575.
jberlin@webkit.org [Tue, 3 May 2011 15:41:28 +0000 (15:41 +0000)]
Revert r85550 and r85575.

Rubber-stamped by Adam Roben.

Variables cannot be exported via the .def file. Instead, they should be annotated with
JS_EXPORTDATA.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* runtime/Structure.cpp:
(JSC::Structure::materializePropertyMap):
* runtime/Structure.h:
(JSC::Structure::typeInfo):
(JSC::Structure::previousID):
(JSC::Structure::propertyStorageCapacity):
(JSC::Structure::propertyStorageSize):
(JSC::Structure::get):
(JSC::Structure::materializePropertyMapIfNecessary):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-03 Satish Sampath <satish@chromium.org>
satish@chromium.org [Tue, 3 May 2011 15:05:59 +0000 (15:05 +0000)]
2011-05-03  Satish Sampath  <satish@chromium.org>

        Reviewed by Tony Gentilcore.

        Rebaseline speech input layout test expectations for chromium.
        https://bugs.webkit.org/show_bug.cgi?id=59742

        * platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.png:
        * platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.txt:
        * platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.png:
        * platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.txt:
        * platform/chromium-linux/fast/speech/input-appearance-speechbutton-expected.png:
        * platform/chromium-linux/fast/speech/input-appearance-speechbutton-expected.txt:
        * platform/chromium-mac-leopard/fast/speech/input-appearance-speechbutton-expected.png:
        * platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.png:
        * platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.png:
        * platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAllow implicit conversion from nullptr_t to PassOwnPtr
aroben@apple.com [Tue, 3 May 2011 13:54:58 +0000 (13:54 +0000)]
Allow implicit conversion from nullptr_t to PassOwnPtr

This makes it a lot easier to write code that just wants a null PassOwnPtr, especially in
strict PassOwnPtr mode.

Fixes <http://webkit.org/b/59964> Implicit conversion from std::nullptr_t to PassOwnPtr
doesn't work, but should

Reviewed by Adam Barth.

Source/JavaScriptCore:

* wtf/PassOwnPtr.h:
(WTF::PassOwnPtr::PassOwnPtr): Added a non-explicit constructor that takes a nullptr_t.

* wtf/MessageQueue.h:
(WTF::::waitForMessageFilteredWithTimeout):
(WTF::::tryGetMessage):
Use the new implicit conversion.

Source/WebCore:

Take advantage of implicit conversion from nullptr_t to PassOwnPtr

* bindings/js/ScheduledAction.cpp:
* css/CSSStyleSelector.cpp:
* css/MediaList.cpp:
* css/MediaQueryMatcher.cpp:
* css/SVGCSSStyleSelector.cpp:
* dom/MessagePort.cpp:
* html/InputType.cpp:
* html/canvas/WebGLRenderingContext.cpp:
* inspector/InspectorStyleSheet.cpp:
* page/ContextMenuController.cpp:
* page/Page.cpp:
* platform/PlatformGestureRecognizer.cpp:
* platform/PurgeableBuffer.h:
* platform/graphics/ImageBuffer.h:
* platform/leveldb/LevelDBDatabase.cpp:
* platform/mac/PurgeableBufferMac.cpp:
* platform/text/RegularExpression.cpp:
* rendering/RenderTheme.cpp:
* rendering/RenderThemeMac.mm:
* rendering/style/RenderStyle.h:
* rendering/style/SVGRenderStyleDefs.cpp:
* rendering/style/ShadowData.cpp:
* rendering/style/StyleRareInheritedData.cpp:
* rendering/style/StyleRareNonInheritedData.cpp:
* rendering/svg/RenderSVGResourcePattern.cpp:

Source/WebKit/chromium:

Take advantage of implicit conversion from nullptr_t to PassOwnPtr

* src/WebMediaPlayerClientImpl.cpp:

Source/WebKit/mac:

Take advantage of implicit conversion from nullptr_t to PassOwnPtr

* History/WebHistory.mm:
* Plugins/WebNetscapePluginEventHandler.mm:
* WebView/WebView.mm:

Source/WebKit2:

Take advantage of implicit conversion from nullptr_t to PassOwnPtr

* Platform/CoreIPC/Connection.cpp:
* UIProcess/qt/WebContextMenuProxyQt.cpp:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
* WebProcess/WebPage/DrawingArea.cpp:

Tools:

Take advantage of implicit nullptr_t -> PassOwnPtr conversion

* DumpRenderTree/chromium/CppBoundClass.h:
* DumpRenderTree/chromium/WebViewHost.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-03 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Tue, 3 May 2011 13:25:00 +0000 (13:25 +0000)]
2011-05-03  Pavel Feldman  <pfeldman@google.com>

        Not reviewed: fix inspector status bar image glyph reference in network panel.

        * inspector/front-end/networkPanel.css:
        (.network-larger-resources-status-bar-item .glyph):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-03 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Tue, 3 May 2011 13:11:52 +0000 (13:11 +0000)]
2011-05-03  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed. Provide Chromium test expectaions for new test.

        * platform/chromium/inspector/console/console-log-document-proto-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-03 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Tue, 3 May 2011 13:10:59 +0000 (13:10 +0000)]
2011-05-03  Pavel Feldman  <pfeldman@google.com>

        Not reviewed: rebaseline inspector test.

        * inspector/storage-panel-dom-storage-expected.txt:
        * inspector/storage-panel-dom-storage.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Add failing tests to ARM specific Skipped list
rgabor@webkit.org [Tue, 3 May 2011 13:02:58 +0000 (13:02 +0000)]
[Qt] Add failing tests to ARM specific Skipped list

Rubber-stamped by Csaba Osztrogon√°c.

* platform/qt-arm/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-03 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Tue, 3 May 2011 12:56:07 +0000 (12:56 +0000)]
2011-05-03  Pavel Feldman  <pfeldman@google.com>

        Reviewed by Yury Semikhatsky.

        Web Inspector: rename BrowserDebugger agent to DOMDebugger.
        https://bugs.webkit.org/show_bug.cgi?id=60019

        * inspector/CodeGeneratorInspector.pm:
        * inspector/Inspector.json:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::connectFrontend):
        * inspector/front-end/BreakpointsSidebarPane.js:
        (WebInspector.XHRBreakpointsSidebarPane.prototype._setBreakpoint):
        (WebInspector.XHRBreakpointsSidebarPane.prototype._removeBreakpoint):
        (WebInspector.XHRBreakpointsSidebarPane.prototype._checkboxClicked):
        (WebInspector.EventListenerBreakpointsSidebarPane.prototype._setBreakpoint):
        (WebInspector.EventListenerBreakpointsSidebarPane.prototype._removeBreakpoint):
        * inspector/generate-inspector-idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-03 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Tue, 3 May 2011 12:48:30 +0000 (12:48 +0000)]
2011-05-03  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: remove special logic for type of document.__proto__
        https://bugs.webkit.org/show_bug.cgi?id=60014

        * inspector/console/console-log-document-proto-expected.txt: Added.
        * inspector/console/console-log-document-proto.html: Added.
        * inspector/console/console-log-toString-object-expected.txt:
        * inspector/console/console-log-toString-object.html:
2011-05-03  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: remove special logic for type of document.__proto__
        https://bugs.webkit.org/show_bug.cgi?id=60014

        Test: inspector/console/console-log-document-proto.html

        * inspector/InjectedScriptSource.js: removed unnecessary check nodeType === undefined

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-03 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Tue, 3 May 2011 09:53:26 +0000 (09:53 +0000)]
2011-05-03  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Eric Seidel.

        [GTK] Build webkit1 even when webkit2 is enabled
        https://bugs.webkit.org/show_bug.cgi?id=59695

        * GNUmakefile.am:
        * configure.ac:
2011-05-03  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Eric Seidel.

        [GTK] Build webkit1 even when webkit2 is enabled
        https://bugs.webkit.org/show_bug.cgi?id=59695

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-03 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Tue, 3 May 2011 09:30:54 +0000 (09:30 +0000)]
2011-05-03  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, unskip now passing test.

        [GTK] media/video-controls-transformed.html fails
        https://bugs.webkit.org/show_bug.cgi?id=50706

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-03 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Tue, 3 May 2011 09:17:07 +0000 (09:17 +0000)]
2011-05-03  Pavel Feldman  <pfeldman@google.com>

        Not reviewed: fixed typo in inspector style.

        * inspector/front-end/inspector.css:
        (.status-bar-item > .glyph):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-03 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Tue, 3 May 2011 09:13:32 +0000 (09:13 +0000)]
2011-05-03  Pavel Feldman  <pfeldman@google.com>

        Not reviewed: re-applied r85589.

        * src/js/DevTools.js:
        (.WebInspector.InspectorFrontendHostStub.prototype.inspectedURLChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-03 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 3 May 2011 09:01:34 +0000 (09:01 +0000)]
2011-05-03  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: revision history storage is too slow.
        https://bugs.webkit.org/show_bug.cgi?id=59939

        It turns out that iterating localStorage keys is very
        expensive (results in slow inspector start), refactor revision
        history in order not to rely upon that operation.

        * inspector/front-end/Resource.js:
        (WebInspector.Resource):
        (WebInspector.Resource._resourceRevisionRegistry):
        (WebInspector.Resource.restoreRevisions.persist):
        (WebInspector.Resource.restoreRevisions):
        (WebInspector.Resource.persistRevision):
        (WebInspector.Resource.prototype._persistRevision):
        * inspector/front-end/ResourceTreeModel.js:
        (WebInspector.ResourceTreeModel.prototype._processCachedResources):
        (WebInspector.ResourceTreeModel.prototype._frameNavigated):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-03 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Tue, 3 May 2011 08:55:44 +0000 (08:55 +0000)]
2011-05-03  Mario Sanchez Prada  <msanchez@igalia.com>

        Unreviewed, needed rebaseline after revision r85499.

        * platform/gtk/fast/replaced/table-percent-height-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-03 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Tue, 3 May 2011 08:00:21 +0000 (08:00 +0000)]
2011-05-03  Pavel Feldman  <pfeldman@google.com>

        Reviewed by Yury Semikhatsky.

        Web Inspector: [remote debugging] use document.title to set window name.
        https://bugs.webkit.org/show_bug.cgi?id=60012

        * src/js/DevTools.js:
        (WebInspector.InspectorFrontendHostStub.prototype.inspectedURLChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-03 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 3 May 2011 07:54:35 +0000 (07:54 +0000)]
2011-05-03  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: combine toolbar icon images.
        https://bugs.webkit.org/show_bug.cgi?id=59931

        * WebCore.gypi:
        * inspector/front-end/Images/auditsIcon.png: Removed.
        * inspector/front-end/Images/consoleIcon.png: Removed.
        * inspector/front-end/Images/elementsIcon.png: Removed.
        * inspector/front-end/Images/networkIcon.png: Removed.
        * inspector/front-end/Images/profilesIcon.png: Removed.
        * inspector/front-end/Images/resourcesIcon.png: Removed.
        * inspector/front-end/Images/scriptsIcon.png: Removed.
        * inspector/front-end/Images/timelineIcon.png: Removed.
        * inspector/front-end/Images/toolbarIcons.png: Added.
        * inspector/front-end/Images/toolbarIconsSmall.png: Added.
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.css:
        (.toolbar-icon):
        (#toolbar-dropdown .toolbar-icon):
        (.toolbar-item:active .toolbar-icon):
        (#toolbar-dropdown .toolbar-item:active .toolbar-icon):
        (.toolbar-item.elements .toolbar-icon):
        (.toolbar-item.resources .toolbar-icon):
        (#toolbar-dropdown .toolbar-item.resources .toolbar-icon):
        (.toolbar-item.network .toolbar-icon):
        (#toolbar-dropdown .toolbar-item.network .toolbar-icon):
        (.toolbar-item.scripts .toolbar-icon):
        (#toolbar-dropdown .toolbar-item.scripts .toolbar-icon):
        (.toolbar-item.timeline .toolbar-icon):
        (#toolbar-dropdown .toolbar-item.timeline .toolbar-icon):
        (.toolbar-item.profiles .toolbar-icon):
        (#toolbar-dropdown .toolbar-item.profiles .toolbar-icon):
        (.toolbar-item.audits .toolbar-icon):
        (#toolbar-dropdown .toolbar-item.audits .toolbar-icon):
        (.toolbar-item.console .toolbar-icon):
        (#toolbar-dropdown .toolbar-item.console .toolbar-icon):
        (.status-bar-item > .glyph):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-03 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 3 May 2011 07:52:39 +0000 (07:52 +0000)]
2011-05-03  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: combine status bar button glyphs.
        https://bugs.webkit.org/show_bug.cgi?id=59885

        * WebCore.gypi:
        * inspector/front-end/Images/breakpointsActivateButtonGlyph.png: Removed.
        * inspector/front-end/Images/breakpointsDeactivateButtonGlyph.png: Removed.
        * inspector/front-end/Images/clearConsoleButtonGlyph.png: Removed.
        * inspector/front-end/Images/consoleButtonGlyph.png: Removed.
        * inspector/front-end/Images/dockButtonGlyph.png: Removed.
        * inspector/front-end/Images/enableOutlineButtonGlyph.png: Removed.
        * inspector/front-end/Images/enableSolidButtonGlyph.png: Removed.
        * inspector/front-end/Images/excludeButtonGlyph.png: Removed.
        * inspector/front-end/Images/focusButtonGlyph.png: Removed.
        * inspector/front-end/Images/garbageCollectButtonGlyph.png: Removed.
        * inspector/front-end/Images/gearButtonGlyph.png: Removed.
        * inspector/front-end/Images/helpButtonGlyph.png: Removed.
        * inspector/front-end/Images/largerResourcesButtonGlyph.png: Removed.
        * inspector/front-end/Images/nodeSearchButtonGlyph.png: Removed.
        * inspector/front-end/Images/pauseOnExceptionButtonGlyph.png: Removed.
        * inspector/front-end/Images/percentButtonGlyph.png: Removed.
        * inspector/front-end/Images/prettyPrintButtonGlyph.png: Removed.
        * inspector/front-end/Images/recordButtonGlyph.png: Removed.
        * inspector/front-end/Images/recordToggledButtonGlyph.png: Removed.
        * inspector/front-end/Images/reloadButtonGlyph.png: Removed.
        * inspector/front-end/Images/statusBarButtonGlyphs.png: Added.
        * inspector/front-end/Images/undockButtonGlyph.png: Removed.
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.css:
        (.status-bar-item > .glyph):
        (#dock-status-bar-item .glyph):
        (body.detached #dock-status-bar-item .glyph):
        (#console-status-bar-item .glyph):
        (.clear-status-bar-item .glyph):
        (button.enable-toggle-status-bar-item .glyph):
        (button.enable-toggle-status-bar-item.toggled-on .glyph):
        (.scripts-pause-on-exceptions-status-bar-item .glyph):
        (.scripts-toggle-pretty-print-status-bar-item .glyph):
        (.toggle-breakpoints .glyph):
        (.toggle-breakpoints.toggled-on .glyph):
        (.resources-larger-resources-status-bar-item .glyph):
        (.timeline-filter-status-bar-item .glyph):
        (.garbage-collect-status-bar-item .glyph):
        (.record-profile-status-bar-item .glyph):
        (.record-profile-status-bar-item.toggled-on .glyph):
        (.heap-snapshot-status-bar-item .glyph):
        (.node-search-status-bar-item .glyph):
        (.percent-time-status-bar-item .glyph):
        (.focus-profile-node-status-bar-item .glyph):
        (.exclude-profile-node-status-bar-item .glyph):
        (.reset-profile-status-bar-item .glyph):
        (.delete-storage-status-bar-item .glyph):
        (.refresh-storage-status-bar-item .glyph):
        * inspector/front-end/inspector.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-02 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 3 May 2011 06:04:54 +0000 (06:04 +0000)]
2011-05-02  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Possible crash when removing elements with reflections
        https://bugs.webkit.org/show_bug.cgi?id=60009

        RenderLayer's destructor deleted its z-order list Vector pointers
        before removing the reflection layer. However, the reflection cleanup
        code could call back into the RenderLayer to dirty z-order lists,
        so move reflection cleanup to before z-order vector deletion.

        The test crashes when run manually a few times with MallocScribble enabled,
        but I was not able to create a test that crashed reliably.

        Test: fast/reflections/remove-reflection-crash.html

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::~RenderLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-02 Ian Henderson <ianh@apple.com>
commit-queue@webkit.org [Tue, 3 May 2011 05:07:52 +0000 (05:07 +0000)]
2011-05-02  Ian Henderson  <ianh@apple.com>

        Reviewed by Dan Bernstein.

        CSS !important not respected by JavaScript
        https://bugs.webkit.org/show_bug.cgi?id=60007

        * fast/css/important-js-override-expected.txt: Added.
        * fast/css/important-js-override.html: Added.
2011-05-02  Ian Henderson  <ianh@apple.com>

        Reviewed by Dan Bernstein.

        CSS !important not respected by JavaScript
        https://bugs.webkit.org/show_bug.cgi?id=60007

        The addParsedProperty and addParsedProperties methods were subtly
        different.  The former did not check for !important before setting the
        given property.

        Change addParsedProperties to call addParsedProperty and move the
        relevant code.  The one other caller of this method, in
        editing/markup.cpp, probably wanted this behavior anyway.

        Test: fast/css/important-js-override.html

        * css/CSSMutableStyleDeclaration.cpp:
        (WebCore::CSSMutableStyleDeclaration::addParsedProperties):
        (WebCore::CSSMutableStyleDeclaration::addParsedProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-02 Yael Aharon <yael.aharon@nokia.com>
yael.aharon@nokia.com [Tue, 3 May 2011 05:02:39 +0000 (05:02 +0000)]
2011-05-02  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] White screen displays when using MiniBrowser with DrawingAreaImpl
        https://bugs.webkit.org/show_bug.cgi?id=60003

        When using DrawingAreaImpl, we need to properly pass the viewSize to the WebPage.
        Otherwise, the dirty rect will always be empty and we will not draw.

        * UIProcess/API/qt/qwkpage.cpp:
        (QWKPagePrivate::viewSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-02 Martin Robinson <mrobinson@igalia.com>
commit-queue@webkit.org [Tue, 3 May 2011 04:45:58 +0000 (04:45 +0000)]
2011-05-02  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Compiler warning in Tools/MiniBrowser/main.c
        https://bugs.webkit.org/show_bug.cgi?id=59986

        Remove a compiler warning.

        * MiniBrowser/gtk/main.c: Use full array initializers to prevent some compilers
        from complaining.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-02 Alpha Lam <hclam@chromium.org>
hclam@chromium.org [Tue, 3 May 2011 04:03:59 +0000 (04:03 +0000)]
2011-05-02  Alpha Lam  <hclam@chromium.org>

        Not reviewed. Build fix.

        Fix Chromium test expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-02 Gyuyoung Kim <gyuyoung.kim@samsung.com>
gyuyoung.kim@samsung.com [Tue, 3 May 2011 04:03:42 +0000 (04:03 +0000)]
2011-05-02  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Unreviewed. Style error fix.

        * WebCoreSupport/ChromeClientEfl.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85581 268f45cc-cd09-0410-ab3c-d52691b4dbfc