loislo@chromium.org [Thu, 16 Sep 2010 19:13:05 +0000 (19:13 +0000)]
2010-09-16 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: move resourceTracking flag under control of BackendSettings.
Four Inspector API methods about resourceTracking flag were removed.
Actual state of the flag is transfered as the response of setResourceTracking request.
Initial state of the flag on the frontend side is obtained from settings.backend.
https://bugs.webkit.org/show_bug.cgi?id=45887
WebCore:
* inspector/Inspector.idl:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::getBackendSettings):
(WebCore::InspectorController::populateScriptObjects):
(WebCore::InspectorController::setResourceTracking):
* inspector/InspectorController.h:
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype._toggleResourceTracking):
* inspector/front-end/Settings.js:
(WebInspector.Settings.initialize.populateBackendSettings):
(WebInspector.Settings.initialize):
* inspector/front-end/inspector.js:
WebKit/chromium:
* src/WebDevToolsAgentImpl.cpp:
(WebKit::WebDevToolsAgentImpl::setRuntimeProperty):
(WebKit::WebDevToolsAgentImpl::setApuAgentEnabled):
LayoutTests:
* http/tests/inspector/inspector-test2.js:
(initialize_InspectorTest.InspectorTest.enableResourceTracking):
(initialize_InspectorTest.InspectorTest.disableResourceTracking):
* http/tests/inspector/resource-parameters.html:
* inspector/audits-panel-functional.html:
* inspector/report-API-errors-expected.txt:
* inspector/report-API-errors.html:
* inspector/styles-source-offsets.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67647
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jianli@chromium.org [Thu, 16 Sep 2010 19:09:36 +0000 (19:09 +0000)]
BlobData should be copied for it to be used cross-thread in ThreadableBlobRegistry.
https://bugs.webkit.org/show_bug.cgi?id=45909
Reviewed by David Levin.
WebCore:
* fileapi/ThreadableBlobRegistry.cpp:
(WebCore::BlobRegistryContext::BlobRegistryContext):
LayoutTests:
Also fix a test issue that we do not calculate the right position to move
mouse to on some platform.
* fast/files/apply-blob-url-to-img.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67646
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 16 Sep 2010 19:05:30 +0000 (19:05 +0000)]
2010-09-16 Daniel Cheng <dcheng@chromium.org>
Reviewed by Simon Fraser.
[chromium] Fix incorrect drag node/selection painting.
https://bugs.webkit.org/show_bug.cgi?id=45573
Drag selections were being incorrectly clipped when dragging a selection
near the bottom of a page that was taller than the viewport. To fix
this, we use paintContents() instead of paint().
* page/chromium/FrameChromium.cpp:
(WebCore::Frame::nodeImage):
(WebCore::Frame::dragImageForSelection):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67645
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zmo@google.com [Thu, 16 Sep 2010 18:36:06 +0000 (18:36 +0000)]
2010-09-16 Zhenyao Mo <zmo@google.com>
Unreviewed, TAG fix for two webgl tests in Linux/Win.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67643
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 16 Sep 2010 18:19:03 +0000 (18:19 +0000)]
2010-09-16 Patrick Gansterer <paroga@paroga.com>
Reviewed by Darin Adler.
[Mac] Always use a valid string when setting WebKitUserStyleSheetLocationPreferenceKey.
https://bugs.webkit.org/show_bug.cgi?id=41510
* platform/mac/fast/loader/user-stylesheet-fast-path-expected.txt:
* platform/mac/fast/loader/user-stylesheet-fast-path.html:
2010-09-16 Patrick Gansterer <paroga@paroga.com>
Reviewed by Darin Adler.
Always use a valid string when setting WebKitUserStyleSheetLocationPreferenceKey.
https://bugs.webkit.org/show_bug.cgi?id=41510
This prevents usage of nil value, which would cause an uncaught exception.
* WebView/WebPreferences.mm:
(-[WebPreferences setUserStyleSheetLocation:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67642
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 16 Sep 2010 18:06:48 +0000 (18:06 +0000)]
2010-09-16 Daniel Cheng <dcheng@chromium.org>
Reviewed by Tony Chang.
Fix incorrect usage of dissolveDragImageToFraction().
https://bugs.webkit.org/show_bug.cgi?id=45835
createDragImageForSelection() was ignoring the return value of
dissolveDragImageToFraction(). This didn't happen to crash on most
platforms, since most implementations simply modified the image that was
passed in. However, Chromium Mac's implementation actually creates a new
image and returns that instead. This caused us to crash when copying the
image from the renderer to the browser process, since the memory had
already been freed.
* manual-tests/selection-drag-crash.html: Added.
* platform/DragImage.cpp:
(WebCore::createDragImageForSelection):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67641
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zmo@google.com [Thu, 16 Sep 2010 17:59:22 +0000 (17:59 +0000)]
2010-09-16 Zhenyao Mo <zmo@google.com>
Unreviewed, test TAG fix.
* platform/chromium/test_expectations.txt: should be IMAGE+TEXT, not TEXT+IMAGE.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67640
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Thu, 16 Sep 2010 17:52:13 +0000 (17:52 +0000)]
Reverted the previous change because r67628 has been reverted.
WebKit:
* English.lproj/Localizable.strings:
WebKit/mac:
* WebCoreSupport/WebPlatformStrategies.h:
* WebCoreSupport/WebPlatformStrategies.mm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67639
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Thu, 16 Sep 2010 17:39:09 +0000 (17:39 +0000)]
WebKit: Updated localizable strings.
* English.lproj/Localizable.strings:
WebKit/mac: Build fix after r67628. Added context menu item localizable strings for the items
added in r67628, following equivalent menu items in Mac OS X when possible. However,
this set of menu items does not make much sense for Mac OS X, and this should be
addressed separately.
* WebCoreSupport/WebPlatformStrategies.h:
* WebCoreSupport/WebPlatformStrategies.mm:
(WebPlatformStrategies::contextMenuItemTagOpenMediaInNewWindow):
(WebPlatformStrategies::contextMenuItemTagCopyMediaLinkToClipboard):
(WebPlatformStrategies::contextMenuItemTagToggleMediaControls):
(WebPlatformStrategies::contextMenuItemTagToggleMediaLoop):
(WebPlatformStrategies::contextMenuItemTagEnterVideoFullscreen):
(WebPlatformStrategies::contextMenuItemTagMediaPlay):
(WebPlatformStrategies::contextMenuItemTagMediaPause):
(WebPlatformStrategies::contextMenuItemTagMediaMute):
(WebPlatformStrategies::contextMenuItemTagMediaUnMute):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67638
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbalazs@webkit.org [Thu, 16 Sep 2010 17:37:51 +0000 (17:37 +0000)]
2010-09-16 Balazs Kelemen <kbalazs@webkit.org>
Unreviewed trivial typo fix.
Remove old debug helper code inside |#if 0| from ConnectionQt.cpp
* Platform/CoreIPC/qt/ConnectionQt.cpp:
(CoreIPC::Connection::readyReadHandler):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67637
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Thu, 16 Sep 2010 17:33:22 +0000 (17:33 +0000)]
2010-09-16 Martin Robinson <mrobinson@igalia.com>
Unskip some tests that are now passing after libxml fixes in r66336.
* platform/gtk/Skipped: Unskip passing tests.
* platform/gtk/svg/custom/js-update-stop-linked-gradient-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67636
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 16 Sep 2010 17:32:33 +0000 (17:32 +0000)]
2010-09-16 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r67628.
http://trac.webkit.org/changeset/67628
https://bugs.webkit.org/show_bug.cgi?id=45904
broke the build (Requested by eric_carlson on #webkit).
* media/context-menu-actions-expected.txt: Removed.
* media/context-menu-actions.html: Removed.
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
2010-09-16 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r67628.
http://trac.webkit.org/changeset/67628
https://bugs.webkit.org/show_bug.cgi?id=45904
broke the build (Requested by eric_carlson on #webkit).
* page/ContextMenuController.cpp:
(WebCore::ContextMenuController::contextMenuItemSelected):
* platform/ContextMenu.cpp:
(WebCore::ContextMenu::populate):
(WebCore::ContextMenu::checkOrEnableIfNeeded):
* platform/ContextMenuItem.h:
* platform/LocalizationStrategy.h:
* platform/LocalizedStrings.cpp:
* platform/LocalizedStrings.h:
* platform/android/LocalizedStringsAndroid.cpp:
* platform/brew/LocalizedStringsBrew.cpp:
* platform/efl/LocalizedStringsEfl.cpp:
* platform/gtk/ContextMenuItemGtk.cpp:
(WebCore::gtkStockIDFromContextMenuAction):
* platform/gtk/LocalizedStringsGtk.cpp:
* platform/haiku/LocalizedStringsHaiku.cpp:
* platform/wx/LocalizedStringsWx.cpp:
* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::absoluteMediaURL):
* rendering/HitTestResult.h:
2010-09-16 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r67628.
http://trac.webkit.org/changeset/67628
https://bugs.webkit.org/show_bug.cgi?id=45904
broke the build (Requested by eric_carlson on #webkit).
* DumpRenderTree/gtk/EventSender.cpp:
(contextClickCallback):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67635
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Thu, 16 Sep 2010 17:21:02 +0000 (17:21 +0000)]
2010-09-16 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Simon Fraser.
CSS: Fix crash in getTimingFunctionValue()
https://bugs.webkit.org/show_bug.cgi?id=45896
Use a RefPtr to avoid deleting the TimingFunction prematurely.
This is covered by existing tests, e.g transitions/inherit-other-props.html
but will only actually crash on picky platforms (or in valgrind.)
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::getTimingFunctionValue):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67634
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zmo@google.com [Thu, 16 Sep 2010 17:15:10 +0000 (17:15 +0000)]
2010-09-16 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Turn on WebGL layout tests for Chromium win/linux
https://bugs.webkit.org/show_bug.cgi?id=45859
* platform/chromium/test_expectations.txt: Re-enabling WebGL tests.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67633
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
johnnyg@google.com [Thu, 16 Sep 2010 17:04:13 +0000 (17:04 +0000)]
2010-09-16 John Gregg <johnnyg@google.com>
Unreviewed; chromium test expectations.
editing/selection/context-menu-on-text.html fails on chromium
https://bugs.webkit.org/show_bug.cgi?id=45898
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67632
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enrica@apple.com [Thu, 16 Sep 2010 16:28:41 +0000 (16:28 +0000)]
Pasteboard doesn't work in WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=42317
<rdar://problem/
7660537>
Reviewed by Sam Weinig.
Initial work to support cut, copy, paste and selectAll in WebKit2.
It still does not support RTF and RTFD format for Mac and the selective
enabling of the editing menu entries.
* Shared/CoreIPCSupport/WebPageMessageKinds.h: Added messages to support the
new editing commands.
* UIProcess/API/mac/WKView.mm:
(-[WKView validateUserInterfaceItem:]): Added.
(-[WKView copy:]): Added.
(-[WKView cut:]): Added.
(-[WKView paste:]): Addded.
(-[WKView selectAll:]): Added.
* UIProcess/WebPageProxy.cpp: Added all the proxy methods.
(WebKit::WebPageProxy::selectAll):
(WebKit::WebPageProxy::copy):
(WebKit::WebPageProxy::cut):
(WebKit::WebPageProxy::paste):
* UIProcess/WebPageProxy.h:
* WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::documentFragmentFromAttributedString): Added but not
implemented. This is needed to support RTF and RTFD.
(WebKit::WebEditorClient::setInsertionPasteboard): Added but not implemented.
This is needed only to support Mail on the Mac.
* WebProcess/WebPage/WebPage.cpp: Added all the stub methods.
(WebKit::WebPage::selectAll):
(WebKit::WebPage::copy):
(WebKit::WebPage::cut):
(WebKit::WebPage::paste):
(WebKit::WebPage::didReceiveMessage): Modified to handle the new messages from
the UI process.
* WebProcess/WebPage/WebPage.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67631
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbalazs@webkit.org [Thu, 16 Sep 2010 16:27:58 +0000 (16:27 +0000)]
2010-09-16 Balazs Kelemen <kbalazs@webkit.org>
Unreviewed.
Adding myself as a comitter.
* Scripts/webkitpy/common/config/committers.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67630
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Thu, 16 Sep 2010 16:24:50 +0000 (16:24 +0000)]
2010-09-16 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: prevent resource timing popover from having scrollers.
https://bugs.webkit.org/show_bug.cgi?id=45883
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype._showPopover):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67629
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Thu, 16 Sep 2010 16:21:44 +0000 (16:21 +0000)]
2010-09-15 Philippe Normand <pnormand@igalia.com>
Reviewed by Eric Carlson.
[GTK] enhanced context menu for media elements
https://bugs.webkit.org/show_bug.cgi?id=45021
New items in the media Element context menu:
- play/pause
- mute/unmute
- controls display control
- switch to fullscreen (for video only)
- loop playback control
- copy media url to clipboard
- open in new window
Test: media/context-menu-actions.html
* page/ContextMenuController.cpp:
(WebCore::ContextMenuController::contextMenuItemSelected):
* platform/ContextMenu.cpp:
(WebCore::ContextMenu::populate):
(WebCore::ContextMenu::checkOrEnableIfNeeded):
* platform/ContextMenuItem.h:
* platform/LocalizationStrategy.h:
* platform/LocalizedStrings.cpp:
(WebCore::contextMenuItemTagOpenMediaInNewWindow):
(WebCore::contextMenuItemTagCopyMediaLinkToClipboard):
(WebCore::contextMenuItemTagToggleMediaControls):
(WebCore::contextMenuItemTagToggleMediaLoop):
(WebCore::contextMenuItemTagEnterVideoFullscreen):
(WebCore::contextMenuItemTagMediaPlay):
(WebCore::contextMenuItemTagMediaPause):
(WebCore::contextMenuItemTagMediaMute):
(WebCore::contextMenuItemTagMediaUnMute):
* platform/LocalizedStrings.h:
* platform/android/LocalizedStringsAndroid.cpp:
(WebCore::contextMenuItemTagOpenMediaInNewWindow):
(WebCore::contextMenuItemTagCopyMediaLinkToClipboard):
(WebCore::contextMenuItemTagToggleMediaControls):
(WebCore::contextMenuItemTagToggleMediaLoop):
(WebCore::contextMenuItemTagEnterVideoFullscreen):
(WebCore::contextMenuItemTagMediaPlay):
(WebCore::contextMenuItemTagMediaPause):
(WebCore::contextMenuItemTagMediaMute):
(WebCore::contextMenuItemTagMediaUnMute):
* platform/brew/LocalizedStringsBrew.cpp:
(WebCore::contextMenuItemTagOpenMediaInNewWindow):
(WebCore::contextMenuItemTagCopyMediaLinkToClipboard):
(WebCore::contextMenuItemTagToggleMediaControls):
(WebCore::contextMenuItemTagToggleMediaLoop):
(WebCore::contextMenuItemTagEnterVideoFullscreen):
(WebCore::contextMenuItemTagMediaPlay):
(WebCore::contextMenuItemTagMediaPause):
(WebCore::contextMenuItemTagMediaMute):
(WebCore::contextMenuItemTagMediaUnMute):
* platform/efl/LocalizedStringsEfl.cpp:
(WebCore::contextMenuItemTagOpenMediaInNewWindow):
(WebCore::contextMenuItemTagCopyMediaLinkToClipboard):
(WebCore::contextMenuItemTagToggleMediaControls):
(WebCore::contextMenuItemTagToggleMediaLoop):
(WebCore::contextMenuItemTagEnterVideoFullscreen):
(WebCore::contextMenuItemTagMediaPlay):
(WebCore::contextMenuItemTagMediaPause):
(WebCore::contextMenuItemTagMediaMute):
(WebCore::contextMenuItemTagMediaUnMute):
* platform/gtk/ContextMenuItemGtk.cpp:
(WebCore::gtkStockIDFromContextMenuAction):
* platform/gtk/LocalizedStringsGtk.cpp:
(WebCore::contextMenuItemTagOpenMediaInNewWindow):
(WebCore::contextMenuItemTagCopyMediaLinkToClipboard):
(WebCore::contextMenuItemTagToggleMediaControls):
(WebCore::contextMenuItemTagToggleMediaLoop):
(WebCore::contextMenuItemTagEnterVideoFullscreen):
(WebCore::contextMenuItemTagMediaPlay):
(WebCore::contextMenuItemTagMediaPause):
(WebCore::contextMenuItemTagMediaMute):
(WebCore::contextMenuItemTagMediaUnMute):
* platform/haiku/LocalizedStringsHaiku.cpp:
(WebCore::contextMenuItemTagOpenMediaInNewWindow):
(WebCore::contextMenuItemTagCopyMediaLinkToClipboard):
(WebCore::contextMenuItemTagToggleMediaControls):
(WebCore::contextMenuItemTagToggleMediaLoop):
(WebCore::contextMenuItemTagEnterVideoFullscreen):
(WebCore::contextMenuItemTagMediaPlay):
(WebCore::contextMenuItemTagMediaPause):
(WebCore::contextMenuItemTagMediaMute):
(WebCore::contextMenuItemTagMediaUnMute):
* platform/wx/LocalizedStringsWx.cpp:
(WebCore::contextMenuItemTagOpenMediaInNewWindow):
(WebCore::contextMenuItemTagCopyMediaLinkToClipboard):
(WebCore::contextMenuItemTagToggleMediaControls):
(WebCore::contextMenuItemTagToggleMediaLoop):
(WebCore::contextMenuItemTagEnterVideoFullscreen):
(WebCore::contextMenuItemTagMediaPlay):
(WebCore::contextMenuItemTagMediaPause):
(WebCore::contextMenuItemTagMediaMute):
(WebCore::contextMenuItemTagMediaUnMute):
* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::absoluteMediaURL):
(WebCore::HitTestResult::mediaSupportsFullscreen):
(WebCore::HitTestResult::mediaElement):
(WebCore::HitTestResult::toggleMediaControlsDisplay):
(WebCore::HitTestResult::toggleMediaLoopPlayback):
(WebCore::HitTestResult::enterFullscreenForVideo):
(WebCore::HitTestResult::mediaControlsEnabled):
(WebCore::HitTestResult::mediaLoopEnabled):
(WebCore::HitTestResult::mediaPlaying):
(WebCore::HitTestResult::toggleMediaPlayState):
(WebCore::HitTestResult::mediaHasAudio):
(WebCore::HitTestResult::mediaMuted):
(WebCore::HitTestResult::toggleMediaMuteState):
* rendering/HitTestResult.h:
WebKitTools:
Reviewed by Eric Carlson.
[GTK] enhanced context menu for media elements
https://bugs.webkit.org/show_bug.cgi?id=45021
EventSender::contextClick() now returns an array of js
objects. Each object has a title property and a click() method.
* DumpRenderTree/gtk/EventSender.cpp:
(getMenuItemTitleCallback):
(setMenuItemTitleCallback):
(menuItemClickCallback):
(getMenuItemClass):
(contextClickCallback):
LayoutTests:
Reviewed by Eric Carlson.
[GTK] enhanced context menu for media elements
https://bugs.webkit.org/show_bug.cgi?id=45021
New test checking the actions that can be triggered by activating
the contex-menu of the media element. Skipped on mac, qt and win
because of lack of DRT support.
* media/context-menu-actions-expected.txt: Added.
* media/context-menu-actions.html: Added.
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67628
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonyg@chromium.org [Thu, 16 Sep 2010 16:12:23 +0000 (16:12 +0000)]
2010-09-16 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Adam Barth.
Crash in WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions
https://bugs.webkit.org/show_bug.cgi?id=45833
* fast/parser/x-frame-options-detached-document-crash-expected.txt: Added.
* fast/parser/x-frame-options-detached-document-crash.html: Added. Crashes before this patch.
2010-09-16 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Adam Barth.
Crash in WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions
https://bugs.webkit.org/show_bug.cgi?id=45833
Test: fast/parser/x-frame-options-detached-document-crash.html
* dom/Document.cpp:
(WebCore::Document::processHttpEquiv): Other branches in this method already test for a null frame. So it seems to make sense to test that here as well.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67627
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Thu, 16 Sep 2010 16:06:46 +0000 (16:06 +0000)]
2010-09-14 Philippe Normand <pnormand@igalia.com>
Reviewed by Eric Carlson and Martin Robinson.
[GTK] eventSender.contextClick() should return the contents of the context menu
https://bugs.webkit.org/show_bug.cgi?id=39102
Make the eventSender use the new private WebKitGtk+ API to
retrieve the context-menu item titles and store them in an array.
* DumpRenderTree/gtk/EventSender.cpp:
(contextClickCallback):
WebKit/gtk:
Reviewed by Eric Carlson and Martin Robinson.
[GTK] eventSender.contextClick() should return the contents of the context menu
https://bugs.webkit.org/show_bug.cgi?id=39102
New private WebView API to retrieve the context-menu widget. This
is used by DRT only.
* webkit/webkitprivate.h:
* webkit/webkitwebview.cpp:
(webkit_web_view_get_context_menu):
LayoutTests:
Reviewed by Eric Carlson and Martin Robinson.
[GTK] eventSender.contextClick() should return the contents of the context menu
https://bugs.webkit.org/show_bug.cgi?id=39102
New test checking the return value of eventSender.contextClick()
on a non-editable element. Skipped on qt and win.
* editing/selection/context-menu-on-text-expected.txt: Added.
* editing/selection/context-menu-on-text.html: Added.
* platform/qt/Skipped:
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67626
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vangelis@chromium.org [Thu, 16 Sep 2010 15:58:41 +0000 (15:58 +0000)]
2010-09-16 Vangelis Kokkevis <vangelis@chromium.org>
Reviewed by Darin Fisher.
[chromium] ImageLayerChromium needs to keep a ref to the Image it uses
so that it never tries to access an already destroyed Image.
https://bugs.webkit.org/show_bug.cgi?id=45869
* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::setContentsToImage):
* platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerChromium::setContents):
(WebCore::ImageLayerChromium::updateContents):
* platform/graphics/chromium/ImageLayerChromium.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67625
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Thu, 16 Sep 2010 15:57:20 +0000 (15:57 +0000)]
2010-09-16 Patrick Gansterer <paroga@paroga.com>
Reviewed by Adam Roben.
[WINCE] Add platform-specific Image methods
https://bugs.webkit.org/show_bug.cgi?id=28272
* platform/graphics/wince/ImageWinCE.cpp: Added.
(WebCore::RGBA32Buffer::asNewNativeImage):
(WebCore::FrameData::clear):
(WebCore::BitmapImage::getHBITMAPOfSize):
(WebCore::BitmapImage::drawFrameMatchingSourceSize):
(WebCore::BitmapImage::draw):
(WebCore::Image::drawPattern):
(WebCore::BitmapImage::drawPattern):
(WebCore::BitmapImage::checkForSolidColor):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67624
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Thu, 16 Sep 2010 15:37:56 +0000 (15:37 +0000)]
2010-09-16 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [REGRESSION] Scripts disappear from scripts panel after navigation
https://bugs.webkit.org/show_bug.cgi?id=45890
* inspector/InspectorController.cpp:
(WebCore::InspectorController::populateScriptObjects):
(WebCore::InspectorController::restoreDebugger):
(WebCore::InspectorController::restoreProfiler):
* inspector/InspectorController.h:
2010-09-16 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [REGRESSION] Scripts disappear from scripts panel after navigation
https://bugs.webkit.org/show_bug.cgi?id=45890
* src/WebDevToolsAgentImpl.cpp:
(WebKit::WebDevToolsAgentImpl::setRuntimeProperty): make sure debugger and profiler
are initialized when inspected page navigation leads to renderer process change.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67623
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
satish@chromium.org [Thu, 16 Sep 2010 15:33:25 +0000 (15:33 +0000)]
2010-09-16 Satish Sampath <satish@chromium.org>
Unreviewed, fixing a build break with VS 2008.
Fix build break, add the namespace in a friend declaration to get MSVC recognize it properly.
https://bugs.webkit.org/show_bug.cgi?id=45893
* fileapi/FileWriter.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67622
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Thu, 16 Sep 2010 15:30:13 +0000 (15:30 +0000)]
2010-09-15 Philippe Normand <pnormand@igalia.com>
Reviewed by Martin Robinson.
[GStreamer] XOverlay API changes break the build
https://bugs.webkit.org/show_bug.cgi?id=45810
Cope with the GStreamer XOverlay API change for the upcoming
0.10.31 version.
No new tests, build fix only.
* platform/graphics/gstreamer/GStreamerGWorld.cpp:
(WebCore::GStreamerGWorld::setWindowOverlay):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67621
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 16 Sep 2010 15:24:06 +0000 (15:24 +0000)]
2010-09-16 Patrick Gansterer <paroga@paroga.com>
Reviewed by Adam Roben.
[WINCE] Add missing FrameNetworkingContextWinCE::blockedError
https://bugs.webkit.org/show_bug.cgi?id=45680
* WebCoreSupport/FrameNetworkingContextWinCE.cpp:
(WebKit::FrameNetworkingContextWinCE::blockedError):
* WebCoreSupport/FrameNetworkingContextWinCE.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67620
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Thu, 16 Sep 2010 15:17:46 +0000 (15:17 +0000)]
2010-09-16 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] V8 port: Fix debug build
Add missing inclusion of <wtf/text/CString.h> where necessary for debug builds.
* history/PageCache.cpp:
* html/HTMLElement.cpp:
* html/HTMLMediaElement.cpp:
* loader/DocumentLoader.cpp:
* loader/icon/IconDatabase.cpp:
* loader/icon/IconLoader.cpp:
* storage/AbstractDatabase.cpp:
* storage/Database.cpp:
* storage/DatabaseSync.cpp:
* storage/DatabaseTracker.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67619
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Thu, 16 Sep 2010 15:05:58 +0000 (15:05 +0000)]
2010-09-16 Alexey Proskuryakov <ap@apple.com>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=45852
Range::selectNode and selectNodeContents misbehave when argument is in another document
* fast/dom/Range/select-node-different-document-expected.txt: Added.
* fast/dom/Range/select-node-different-document.html: Added.
2010-09-16 Alexey Proskuryakov <ap@apple.com>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=45852
Range::selectNode and selectNodeContents misbehave when argument is in another document
Test: fast/dom/Range/select-node-different-document.html
There is nothing in DOM Traversal spec that says this shouldn't work, and it does work in
Firefox.
* dom/Range.cpp:
(WebCore::Range::setDocument):
(WebCore::Range::selectNode):
(WebCore::Range::selectNodeContents):
* dom/Range.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67618
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
satish@chromium.org [Thu, 16 Sep 2010 14:44:07 +0000 (14:44 +0000)]
2010-09-16 Satish Sampath <satish@chromium.org>
Unreviewed, build fix after checking in the wrong location.
Moving a test expectation which should have been under the chromium platform.
* platform/chromium/fast/images/gif-large-checkerboard-expected.txt: Renamed from LayoutTests/fast/images/gif-large-checkerboard-expected.txt.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67617
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
satish@chromium.org [Thu, 16 Sep 2010 14:08:48 +0000 (14:08 +0000)]
2010-09-16 Satish Sampath <satish@chromium.org>
Reviewed by Jeremy Orlow.
Add chromium baselines for a recently added layout test.
https://bugs.webkit.org/show_bug.cgi?id=45886
* fast/images/gif-large-checkerboard-expected.txt: Added.
* platform/chromium-linux/fast/images/gif-large-checkerboard-expected.checksum: Added.
* platform/chromium-linux/fast/images/gif-large-checkerboard-expected.png: Added.
* platform/chromium-mac/fast/images/gif-large-checkerboard-expected.checksum: Added.
* platform/chromium-mac/fast/images/gif-large-checkerboard-expected.png: Added.
* platform/chromium-win/fast/images/gif-large-checkerboard-expected.checksum: Added.
* platform/chromium-win/fast/images/gif-large-checkerboard-expected.png: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67616
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Thu, 16 Sep 2010 13:56:43 +0000 (13:56 +0000)]
2010-09-16 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Resources panel] [HAR] Need a way to save timing data.
Added support to export HAR to file from Resources panel (conditional on Preferences)
Added support for HARLog (a higher-level aggregate than HAREntry)
https://bugs.webkit.org/show_bug.cgi?id=45663
* English.lproj/localizedStrings.js:
* inspector/front-end/HAREntry.js:
(WebInspector.HAREntry.prototype.build):
(WebInspector.HAREntry.prototype._buildTimings):
(WebInspector.HAREntry._toMilliseconds):
(WebInspector.HARLog):
(WebInspector.HARLog.prototype.build):
(WebInspector.HARLog.prototype._buildPages):
(WebInspector.HARLog.prototype._buildMainResourceTimings):
(WebInspector.HARLog.prototype._convertResource):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel):
(WebInspector.ResourcesPanel.prototype.hide):
(WebInspector.ResourcesPanel.prototype._contextMenu):
(WebInspector.ResourcesPanel.prototype._exportAll):
(WebInspector.ResourcesPanel.prototype._exportResource):
* inspector/front-end/Settings.js:
* inspector/front-end/utilities.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67615
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 16 Sep 2010 13:45:02 +0000 (13:45 +0000)]
2010-09-16 Eric Uhrhane <ericu@chromium.org>
Reviewed by Jian Li.
Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM.
https://bugs.webkit.org/show_bug.cgi?id=45798
* configure.ac:
2010-09-16 Eric Uhrhane <ericu@chromium.org>
Reviewed by Jian Li.
Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM.
https://bugs.webkit.org/show_bug.cgi?id=45798
* Configurations/FeatureDefines.xcconfig:
2010-09-16 Eric Uhrhane <ericu@chromium.org>
Reviewed by Jian Li.
Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM.
https://bugs.webkit.org/show_bug.cgi?id=45798
* CMakeLists.txt:
* Configurations/FeatureDefines.xcconfig:
* GNUmakefile.am:
* WebCore.pro:
* dom/EventTarget.cpp:
* dom/EventTarget.h:
* dom/ExceptionCode.h:
* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
* dom/ScriptExecutionContext.h:
* fileapi/AsyncFileWriter.h:
* fileapi/FileEntry.cpp:
* fileapi/FileEntry.h:
* fileapi/FileEntry.idl:
* fileapi/FileError.h:
* fileapi/FileError.idl:
* fileapi/FileException.h:
* fileapi/FileException.idl:
* fileapi/FileStreamProxy.cpp:
* fileapi/FileStreamProxy.h:
* fileapi/FileThread.cpp:
* fileapi/FileThread.h:
* fileapi/FileWriter.cpp:
* fileapi/FileWriter.h:
* fileapi/FileWriter.idl:
* fileapi/FileWriterCallback.h:
* fileapi/FileWriterCallback.idl:
* fileapi/FileWriterClient.h:
* page/DOMWindow.idl:
* platform/AsyncFileStream.h:
* platform/FileStream.cpp:
* platform/FileStream.h:
* platform/FileStreamClient.h:
2010-09-16 Eric Uhrhane <ericu@chromium.org>
Reviewed by Jian Li.
Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM.
https://bugs.webkit.org/show_bug.cgi?id=45798
* src/AsyncFileWriterChromium.h:
* src/AsyncFileWriterChromium.cpp:
2010-09-16 Eric Uhrhane <ericu@chromium.org>
Reviewed by Jian Li.
Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM.
https://bugs.webkit.org/show_bug.cgi?id=45798
* Configurations/FeatureDefines.xcconfig:
2010-09-16 Eric Uhrhane <ericu@chromium.org>
Reviewed by Jian Li.
Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM.
https://bugs.webkit.org/show_bug.cgi?id=45798
* Configurations/FeatureDefines.xcconfig:
2010-09-16 Eric Uhrhane <ericu@chromium.org>
Reviewed by Jian Li.
Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM.
https://bugs.webkit.org/show_bug.cgi?id=45798
* win/tools/vsprops/FeatureDefines.vsprops:
* win/tools/vsprops/FeatureDefinesCairo.vsprops:
2010-09-16 Eric Uhrhane <ericu@chromium.org>
Reviewed by Jian Li.
Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM.
https://bugs.webkit.org/show_bug.cgi?id=45798
* Scripts/build-webkit:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67614
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
satish@chromium.org [Thu, 16 Sep 2010 13:19:16 +0000 (13:19 +0000)]
Rename an image file to all lower case matching how it is used in the layout test. The original patch and layout test is at https://bugs.webkit.org/show_bug.cgi?id=45322
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67613
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
robert@webkit.org [Thu, 16 Sep 2010 13:15:02 +0000 (13:15 +0000)]
2010-09-16 Robert Hogan <robert@webkit.org>
Reviewed by Antonio Gomes.
[Qt] Support globalhistory tests
https://bugs.webkit.org/show_bug.cgi?id=45774
* platform/qt/Skipped:
2010-09-16 Robert Hogan <robert@webkit.org>
Reviewed by Antonio Gomes.
[Qt] Support globalhistory tests
https://bugs.webkit.org/show_bug.cgi?id=45774
* WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::populateVisitedLinks):
* WebCoreSupport/ChromeClientQt.h:
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::dumpHistoryCallbacks):
(DumpRenderTreeSupportQt::dumpVisitedLinksCallbacks):
* WebCoreSupport/DumpRenderTreeSupportQt.h:
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::setTitle):
(WebCore::FrameLoaderClientQt::updateGlobalHistory):
(WebCore::FrameLoaderClientQt::updateGlobalHistoryRedirectLinks):
* WebCoreSupport/FrameLoaderClientQt.h:
2010-09-16 Robert Hogan <robert@webkit.org>
Reviewed by Antonio Gomes.
[Qt] Support globalhistory tests
https://bugs.webkit.org/show_bug.cgi?id=45774
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::isGlobalHistoryTest):
(WebCore::DumpRenderTree::open):
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::reset):
(LayoutTestController::dumpHistoryCallbacks):
(LayoutTestController::removeAllVisitedLinks):
* DumpRenderTree/qt/LayoutTestControllerQt.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67612
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 16 Sep 2010 13:03:03 +0000 (13:03 +0000)]
2010-09-16 Marc-Antoine Ruel <maruel@chromium.org>
Reviewed by Dimitri Glazkov.
Convert WebCore.gyp to use regexp to excludes files instead of listing them in sources!.
This is necessary because sources! is processed before sources/. This makes
applying broader pattern in sources/ more difficult since it overrides the files
listed in sources!. Having all them in sources/ permits controlling the ordering
of the regexp, thus the final list of included files.
Fix Harfbuzz and VDMX source files includes in WebCore.gypi and WebCore.gyp
https://bugs.webkit.org/show_bug.cgi?id=45823
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67611
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 16 Sep 2010 12:51:07 +0000 (12:51 +0000)]
2010-09-16 Nat Duca <nduca@chromium.org>
Reviewed by Darin Fisher.
[chromium] Make compositor obey finish flag
https://bugs.webkit.org/show_bug.cgi?id=45552
The compositor should obey the finish flag on doComposite. This
flag causes the compositor to finish rendering before returning,
which is needed when resizing the window to avoid flashes of green.
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::finish):
* platform/graphics/chromium/LayerRendererChromium.h:
2010-09-16 Nat Duca <nduca@chromium.org>
Reviewed by Darin Fisher.
[chromium] Make compositor obey finish flag
https://bugs.webkit.org/show_bug.cgi?id=45552
The compositor should obey the finish flag on doComposite. This
flag causes the compositor to finish rendering before returning,
which is needed when resizing the window to avoid flashes of green.
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::composite):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67610
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alex@webkit.org [Thu, 16 Sep 2010 12:47:59 +0000 (12:47 +0000)]
2010-09-16 Alejandro G. Castro <alex@igalia.com>
Reviewed by Xan Lopez.
GTK+ 3.x. updates, gtk_widget_size_request is deprecated and
"activate-slider" style property for scrollbars is gone.
* platform/gtk/PopupMenuGtk.cpp:
(WebCore::PopupMenuGtk::show):
* platform/gtk/gtk2drawing.c:
(moz_gtk_scrollbar_thumb_paint):
(moz_gtk_combo_box_paint):
2010-09-16 Alejandro G. Castro <alex@igalia.com>
Reviewed by Xan Lopez.
GTK+ 3.x. updates, gtk_widget_size_request is deprecated and
"activate-slider" style property for scrollbars is gone.
* webkit/webkitwebview.cpp:
(PopupMenuPositionFunc):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67609
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
diegohcg@webkit.org [Thu, 16 Sep 2010 12:38:54 +0000 (12:38 +0000)]
2010-09-16 Diego Gonzalez <diegohcg@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Remove FrameLoaderClientQt::webFrame() to use NetworkingContext to get the WebFrame to avoid layering violations
https://bugs.webkit.org/show_bug.cgi?id=42293
* platform/graphics/qt/MediaPlayerPrivateQt.cpp:
(WebCore::MediaPlayerPrivate::commitLoad):
2010-09-16 Diego Gonzalez <diegohcg@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Remove FrameLoaderClientQt::webFrame() to use NetworkingContext to get the WebFrame to avoid layering violations
https://bugs.webkit.org/show_bug.cgi?id=42293
* Api/qwebframe.cpp:
(QWebFrame::childFrames):
(QWebFramePrivate::kit):
* Api/qwebpage.cpp:
(QWebPage::currentFrame):
* WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::runJavaScriptAlert):
(WebCore::ChromeClientQt::runJavaScriptConfirm):
(WebCore::ChromeClientQt::runJavaScriptPrompt):
(WebCore::ChromeClientQt::contentsSizeChanged):
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::chooseFile):
* WebCoreSupport/FrameLoaderClientQt.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67608
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
demarchi@webkit.org [Thu, 16 Sep 2010 12:07:05 +0000 (12:07 +0000)]
2010-09-16 Ryuan Choi <ryuan.choi@samsung.com>
Unreviewed build fix for EFL
[EFL] REGRESSION(67567) FontCacheCairo was removed
https://bugs.webkit.org/show_bug.cgi?id=45858
* CMakeListsEfl.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67607
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 16 Sep 2010 11:47:53 +0000 (11:47 +0000)]
2010-09-16 Yong Li <yoli@rim.com>
Reviewed by George Staikos.
https://bugs.webkit.org/show_bug.cgi?id=37117
Add platform-independent JPEG/PNG image encoders that
work with big endian RGBA source data.
There's no layout test because this patch does't make
any port start using the encoders.
* platform/image-encoders/JPEGImageEncoder.cpp: Added.
* platform/image-encoders/JPEGImageEncoder.h: Added.
* platform/image-encoders/PNGImageEncoder.cpp: Added.
* platform/image-encoders/PNGImageEncoder.h: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67606
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jorlow@chromium.org [Thu, 16 Sep 2010 11:27:46 +0000 (11:27 +0000)]
2010-09-15 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Steve Block.
Allow the embedder to specify the base path for IndexedDB.
https://bugs.webkit.org/show_bug.cgi?id=45815
Existing tests provide coverage. Use the indexedDBPath parameter that's
already on the group settings object. Pass this parameter into the backend
which will use it rather than a hard coded tmp directory location. If
nothing is specified, assume it should be an in-memory temporary database.
(This is useful for bringup and Chromium's incognito mode.)
* storage/IDBFactory.cpp:
(WebCore::IDBFactory::open):
* storage/IDBFactoryBackendImpl.cpp:
(WebCore::openSQLiteDatabase):
(WebCore::createTables):
(WebCore::IDBFactoryBackendImpl::open):
* storage/IDBFactoryBackendImpl.h:
* storage/IDBFactoryBackendInterface.h:
2010-09-15 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Steve Block.
Allow the embedder to specify the base path for IndexedDB.
https://bugs.webkit.org/show_bug.cgi?id=45815
Need to add the extra .open() parameter to make this all work.
* public/WebIDBFactory.h:
(WebKit::WebIDBFactory::open):
* src/IDBFactoryBackendProxy.cpp:
(WebCore::IDBFactoryBackendProxy::open):
* src/IDBFactoryBackendProxy.h:
* src/WebIDBFactoryImpl.cpp:
(WebKit::WebIDBFactoryImpl::open):
* src/WebIDBFactoryImpl.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67605
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 16 Sep 2010 11:16:16 +0000 (11:16 +0000)]
2010-09-16 Yong Li <yoli@rim.com>
Reviewed by George Staikos.
Add a test for GIF down sampling.
GIF image down sampling can miss some lines
https://bugs.webkit.org/show_bug.cgi?id=45322
* fast/images/gif-large-checkerboard.html: Added.
* fast/images/resources/large-gif-checkerboard.GIF: Added.
2010-09-16 Yong Li <yoli@rim.com>
Reviewed by George Staikos.
Fix the bug that GIF image down sampling can miss some lines.
https://bugs.webkit.org/show_bug.cgi?id=45322
Test: fast/images/gif-large-checkerboard.html
* platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::haveDecodedRow):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67604
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jorlow@chromium.org [Thu, 16 Sep 2010 11:13:15 +0000 (11:13 +0000)]
2010-09-16 Jeremy Orlow <jorlow@chromium.org>
Speculative build fix.
* src/IDBIndexBackendProxy.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67603
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Thu, 16 Sep 2010 10:50:03 +0000 (10:50 +0000)]
2010-09-16 Philippe Normand <pnormand@igalia.com>
Reviewed by Andreas Kling.
[GStreamer] un-needed header includes in MediaPlayerPrivate
https://bugs.webkit.org/show_bug.cgi?id=45877
Include only the headers we need.
No new tests, #includes cleanup only.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67602
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Thu, 16 Sep 2010 10:41:27 +0000 (10:41 +0000)]
2010-09-16 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: console.group(object) does not allow object to be expanded.
https://bugs.webkit.org/show_bug.cgi?id=45806
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleGroup.prototype.addMessage):
* inspector/front-end/treeoutline.js:
(TreeElement.treeElementToggled):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67601
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jorlow@chromium.org [Thu, 16 Sep 2010 10:23:58 +0000 (10:23 +0000)]
2010-09-08 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Steve Block.
Complete index support for IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=45386
* storage/indexeddb/index-basics-expected.txt: Added.
* storage/indexeddb/index-basics.html: Added.
* storage/indexeddb/index-cursor-expected.txt: Added.
* storage/indexeddb/index-cursor.html: Added.
* storage/indexeddb/objectstore-basics-expected.txt:
* storage/indexeddb/objectstore-basics.html:
* storage/indexeddb/script-tests/objectstore-basics.js: Removed.
2010-09-08 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Steve Block.
Complete index support for IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=45386
Add the rest of the index related API for IndexedDB. This
includes cursor suport. A bunch of code was also refactored
since it is shared between indexes and objectStores.
Tests: storage/indexeddb/index-basics.html
storage/indexeddb/index-cursor.html
+ additions to others.
* storage/IDBAny.cpp:
(WebCore::IDBAny::set):
* storage/IDBCursor.cpp:
(WebCore::IDBCursor::value):
* storage/IDBCursorBackendImpl.cpp:
(WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl):
(WebCore::IDBCursorBackendImpl::value):
(WebCore::IDBCursorBackendImpl::update):
(WebCore::IDBCursorBackendImpl::continueFunction):
(WebCore::IDBCursorBackendImpl::remove):
(WebCore::IDBCursorBackendImpl::loadCurrentRow):
(WebCore::IDBCursorBackendImpl::database):
* storage/IDBCursorBackendImpl.h:
(WebCore::IDBCursorBackendImpl::create):
* storage/IDBCursorBackendInterface.h:
* storage/IDBFactoryBackendImpl.cpp:
(WebCore::createTables):
* storage/IDBIndex.cpp:
(WebCore::IDBIndex::openObjectCursor):
(WebCore::IDBIndex::openCursor):
(WebCore::IDBIndex::getObject):
(WebCore::IDBIndex::get):
* storage/IDBIndex.h:
(WebCore::IDBIndex::storeName):
* storage/IDBIndex.idl:
* storage/IDBIndexBackendImpl.cpp:
(WebCore::IDBIndexBackendImpl::storeName):
(WebCore::openCursorInternal):
(WebCore::IDBIndexBackendImpl::openObjectCursor):
(WebCore::IDBIndexBackendImpl::openCursor):
(WebCore::getInternal):
(WebCore::IDBIndexBackendImpl::getObject):
(WebCore::IDBIndexBackendImpl::get):
* storage/IDBIndexBackendImpl.h:
(WebCore::IDBIndexBackendImpl::objectStore):
* storage/IDBIndexBackendInterface.h:
* storage/IDBKey.cpp:
(WebCore::IDBKey::fromQuery):
(WebCore::IDBKey::whereSyntax):
(WebCore::IDBKey::leftCursorWhereFragment):
(WebCore::IDBKey::rightCursorWhereFragment):
* storage/IDBKey.h:
* storage/IDBKeyRange.cpp:
(WebCore::IDBKeyRange::leftWhereClauseComparisonOperator):
(WebCore::IDBKeyRange::rightWhereClauseComparisonOperator):
* storage/IDBKeyRange.h:
* storage/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::openCursor):
* storage/IDBRequest.cpp:
(WebCore::IDBRequest::timerFired):
2010-09-08 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Steve Block.
Complete index support for IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=45386
* public/WebIDBCursor.h:
(WebKit::WebIDBCursor::direction):
(WebKit::WebIDBCursor::key):
(WebKit::WebIDBCursor::value):
(WebKit::WebIDBCursor::update):
(WebKit::WebIDBCursor::continueFunction):
(WebKit::WebIDBCursor::remove):
* public/WebIDBIndex.h:
(WebKit::WebIDBIndex::storeName):
(WebKit::WebIDBIndex::openObjectCursor):
(WebKit::WebIDBIndex::openCursor):
(WebKit::WebIDBIndex::getObject):
(WebKit::WebIDBIndex::get):
* public/WebIDBKey.h:
* src/IDBCursorBackendProxy.cpp:
(WebCore::IDBCursorBackendProxy::value):
* src/IDBCursorBackendProxy.h:
* src/IDBIndexBackendProxy.cpp:
(WebCore::IDBIndexBackendProxy::storeName):
(WebCore::IDBIndexBackendProxy::openObjectCursor):
(WebCore::IDBIndexBackendProxy::openCursor):
(WebCore::IDBIndexBackendProxy::getObject):
(WebCore::IDBIndexBackendProxy::get):
* src/IDBIndexBackendProxy.h:
* src/WebIDBCursorImpl.cpp:
(WebKit::WebIDBCursorImpl::value):
* src/WebIDBCursorImpl.h:
* src/WebIDBIndexImpl.cpp:
(WebKit::WebIDBIndexImpl::storeName):
(WebKit::WebIDBIndexImpl::openCursor):
(WebKit::WebIDBIndexImpl::openObjectCursor):
(WebKit::WebIDBIndexImpl::getObject):
(WebKit::WebIDBIndexImpl::get):
* src/WebIDBIndexImpl.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67600
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 16 Sep 2010 09:07:59 +0000 (09:07 +0000)]
2010-09-15 Commit Queue <commit-queue@webkit.org>
Unreviewed. Test commit for commit-queue@webkit.org.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67599
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dumi@chromium.org [Thu, 16 Sep 2010 05:47:19 +0000 (05:47 +0000)]
Overload WebHTTPBody::appendFileRange() to take a double modification time argument.
https://bugs.webkit.org/show_bug.cgi?id=45829
Reviewed by Darin Fisher.
The plan is to change all callers of
WebHTTPBody::appendFileRange(..., const WebFileInfo&) to use the
new method, and then remove it.
* public/WebHTTPBody.h:
* src/WebHTTPBody.cpp:
(WebKit::WebHTTPBody::elementAt):
(WebKit::WebHTTPBody::appendFileRange):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67598
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Thu, 16 Sep 2010 02:45:19 +0000 (02:45 +0000)]
2010-09-15 Jessie Berlin <jberlin@apple.com>
Reviewed by Sam Weinig.
WebKit2 should be able to encode and decode objects of type APIObject::TypeURL.
https://bugs.webkit.org/show_bug.cgi?id=45819
* Shared/UserMessageCoders.h:
Add the ability to encode and decode the URL type.
(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67597
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Thu, 16 Sep 2010 02:18:37 +0000 (02:18 +0000)]
2010-09-15 Martin Robinson <mrobinson@igalia.com>
Reviewed by David Levin.
[GTK] [REGRESSION] r67591 broke the testwebbackforwardlist API test and introduced a memory leak
https://bugs.webkit.org/show_bug.cgi?id=45865
When initializing the backForwardList private member of the WebView, do
so with adoptPlatformRef to prevent a memory leak.
* webkit/webkitwebview.cpp:
(webkit_web_view_init): Initialize member with adoptPlatformRef.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67596
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Thu, 16 Sep 2010 02:15:16 +0000 (02:15 +0000)]
Add user message coding for WebUInt64 type.
Reviewed by Jon Honeycutt.
* Shared/UserMessageCoders.h:
(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67595
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Thu, 16 Sep 2010 01:52:14 +0000 (01:52 +0000)]
2010-09-15 Adam Barth <abarth@webkit.org>
Unreviewed.
Only show the review-in-context link if there are contextual comments.
* code-review.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67594
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Thu, 16 Sep 2010 01:50:37 +0000 (01:50 +0000)]
2010-09-15 Jessie Berlin <jberlin@apple.com>
Reviewed by Jon Honeycutt.
We should save messages that can't be sent when postMessageToInjectedBundle is called and
send them in ensureWebProcess.
https://bugs.webkit.org/show_bug.cgi?id=45822
* UIProcess/WebContext.cpp:
(WebKit::WebContext::ensureWebProcess):
Post any messages to the Injected Bundle that couldn't be sent earlier because the
WebProcess hadn't been initialized yet.
(WebKit::WebContext::postMessageToInjectedBundle):
* UIProcess/WebContext.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67593
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Thu, 16 Sep 2010 01:48:11 +0000 (01:48 +0000)]
2010-09-15 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[reviewtool] Show the status bubbles on the toolbar
https://bugs.webkit.org/show_bug.cgi?id=45861
* PrettyPatch/PrettyPatch.rb:
* code-review.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67592
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Thu, 16 Sep 2010 01:34:00 +0000 (01:34 +0000)]
2010-09-15 Martin Robinson <mrobinson@igalia.com>
Reviewed by Eric Seidel.
[Gtk] Use GOwnPtr for code that needs it
https://bugs.webkit.org/show_bug.cgi?id=21594
Convert as reference counted private members of WebKitWebView to
smart pointers as possible. This removes a lot of unecessary manual
memory management. Also convert some pointer members away from pointer
types, now that we are sure their destructors are called.
* WebCoreSupport/ContextMenuClientGtk.cpp:
(WebKit::inputMethodsMenuItem): Updated to reflect PlatformRefPtr changes.
* WebCoreSupport/DragClientGtk.cpp:
(WebKit::DragClient::startDrag): Ditto.
* WebCoreSupport/EditorClientGtk.cpp:
(WebKit::EditorClient::setInputMethodState): Ditto.
(WebKit::EditorClient::respondToChangedSelection): Ditto.
(WebKit::EditorClient::handleInputMethodKeydown): Ditto.
(WebKit::EditorClient::handleInputMethodMousePress): Ditto.
(WebKit::EditorClient::EditorClient): Ditto.
(WebKit::EditorClient::~EditorClient): Ditto.
* WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::postCommitFrameViewSetup): Ditto.
* webkit/webkitprivate.h: Ditto.
* webkit/webkitwebview.cpp: Ditto.
(destroy_menu_cb): Ditto.
(webkit_web_view_forward_context_menu_event): Ditto.
(webkit_web_view_key_release_event): Ditto.
(webkit_web_view_button_press_event): Ditto.
(webkit_web_view_button_release_event): Ditto.
(webkit_web_view_focus_in_event): Ditto.
(webkit_web_view_focus_out_event): Ditto.
(webkit_web_view_realize): Ditto.
(webkit_web_view_set_scroll_adjustments): Ditto.
(webkit_web_view_dispose): Changed all g_object_unref calls to
PlatformRefPtr.clear(). Although this will also be done by the manual
call to the WebKitWebViewPrivate destructor, the order that these
fields are zero'd in is still very sensitive.
(webkit_web_view_finalize): Updated to reflect PlatformRefPtr changes.
(webViewGetDPI): Ditto.
(webkit_web_view_screen_changed): Ditto.
(webkit_web_view_drag_end): Ditto.
(webkit_web_view_drag_data_get): Ditto.
(doDragLeaveLater): Ditto.
(webkit_web_view_drag_leave): Ditto.
(webkit_web_view_drag_motion): Ditto.
(webkit_web_view_drag_data_received): Ditto.
(webkit_web_view_drag_drop): Ditto.
(webkit_web_view_get_im_context): Ditto.
(webkit_web_view_update_settings): Ditto.
(webkit_web_view_init): Ditto.
(webkit_web_view_set_settings): Ditto.
(webkit_web_view_get_settings): Ditto.
(webkit_web_view_get_inspector): Ditto.
(webkit_web_view_set_window_features): Ditto.
(webkit_web_view_get_window_features): Ditto.
(webkit_web_view_get_back_forward_list): Ditto.
(webkit_web_view_zoom_in): Ditto.
(webkit_web_view_zoom_out): Ditto.
(webkit_web_view_add_resource): Ditto.
(webkit_web_view_get_resource): Ditto.
(webkit_web_view_get_main_resource): Ditto.
(webkit_web_view_clear_resources): Ditto.
(webkit_web_view_get_subresources): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67591
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Thu, 16 Sep 2010 01:19:25 +0000 (01:19 +0000)]
2010-09-15 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[reviewtool] Allow setting review and commit-queue flags from main review screen
https://bugs.webkit.org/show_bug.cgi?id=45860
This patch adds drop down menus for adjusting the review and
commit-queue flags from the main review screen. These controls don't
appear immediately because we need to read the state of the flags off
the details page.
It's a slight sadness that bugzilla doesn't have a clean way of
identifying which select control is associated with a given flag. The
flags seem to have some sort of id, but it's unclear to me how to map
that id back to a notion of "review" or "commit-queue". Instead, we
look for some magic strings in the title. I'm sure this will come back
to bit us at some point, but I'm not sure what to do that's better.
(The webkitpy solution to this problem is to assume that the flags are
in a given order, but this seems better.)
* PrettyPatch/PrettyPatch.rb:
- Bump version number to bust throuh caches.
* code-review.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67590
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Thu, 16 Sep 2010 01:13:09 +0000 (01:13 +0000)]
2010-09-15 Simon Fraser <simon.fraser@apple.com>
Reviewed by Sam Weinig.
<rdar://problem/
8214099> Mousewheel scrolling in WebKit2 is wonky
Use floats so that fractional scrollwheel deltas don't get lost.
* Shared/mac/WebEventFactory.mm:
(WebKit::WebEventFactory::createWebWheelEvent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67589
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Thu, 16 Sep 2010 00:40:00 +0000 (00:40 +0000)]
2010-09-10 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
deduplicate-tests should be runnable from any WebKit directory
https://bugs.webkit.org/show_bug.cgi?id=44709
* Scripts/webkitpy/layout_tests/deduplicate_tests.py:
* Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67588
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
johnnyg@google.com [Thu, 16 Sep 2010 00:30:17 +0000 (00:30 +0000)]
2010-09-15 John Gregg <johnnyg@google.com>
Unreviewed, build fix after incomplete revert.
Remove layout test added in 67570 that wasn't reverted in 67574.
https://bugs.webkit.org/show_bug.cgi?id=45854
* fast/css/test-setting-canvas-color-expected.txt: Removed.
* fast/css/test-setting-canvas-color.html: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67587
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 16 Sep 2010 00:29:49 +0000 (00:29 +0000)]
2010-09-15 Eric Seidel <eric@webkit.org>
Unreviewed. Test commit for commit-queue@webkit.org.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67586
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Thu, 16 Sep 2010 00:09:48 +0000 (00:09 +0000)]
2010-09-15 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] sort testing methods in DRT
https://bugs.webkit.org/show_bug.cgi?id=45850
* DumpRenderTree/chromium/EventSender.cpp:
(EventSender::EventSender):
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
* DumpRenderTree/chromium/TextInputController.cpp:
(TextInputController::TextInputController):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67585
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 16 Sep 2010 00:05:46 +0000 (00:05 +0000)]
2010-09-15 Mihai Parparita <mihaip@chromium.org>
Reviewed by Adam Barth.
CQ status shows items out of order
https://bugs.webkit.org/show_bug.cgi?id=45846
Only group consecutive status items with the same patch ID into the same
group, so that overall item ordering is preserved.
Also don't indent status items that only have a single item in their
group.
* QueueStatusServer/handlers/queuestatus.py:
* QueueStatusServer/templates/includes/singlequeuestatus.html: Added.
* QueueStatusServer/templates/queuestatus.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67584
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Thu, 16 Sep 2010 00:05:13 +0000 (00:05 +0000)]
2010-09-15 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Use free variable analysis to improve activation performance
https://bugs.webkit.org/show_bug.cgi?id=45837
Adds free and captured variable tracking to the JS parser. This
allows us to avoid construction of an activation object in some
cases. Future patches will make more use of this information to
improve those cases where activations are still needed.
* parser/ASTBuilder.h:
* parser/JSParser.cpp:
(JSC::JSParser::Scope::Scope):
(JSC::JSParser::Scope::declareVariable):
(JSC::JSParser::Scope::useVariable):
(JSC::JSParser::Scope::collectFreeVariables):
(JSC::JSParser::Scope::capturedVariables):
(JSC::JSParser::ScopeRef::ScopeRef):
(JSC::JSParser::ScopeRef::operator->):
(JSC::JSParser::ScopeRef::index):
(JSC::JSParser::currentScope):
(JSC::JSParser::pushScope):
(JSC::JSParser::popScope):
(JSC::JSParser::parseProgram):
(JSC::JSParser::parseVarDeclarationList):
(JSC::JSParser::parseConstDeclarationList):
(JSC::JSParser::parseTryStatement):
(JSC::JSParser::parseFormalParameters):
(JSC::JSParser::parseFunctionInfo):
(JSC::JSParser::parseFunctionDeclaration):
(JSC::JSParser::parsePrimaryExpression):
* parser/Nodes.cpp:
(JSC::ScopeNodeData::ScopeNodeData):
(JSC::ScopeNode::ScopeNode):
(JSC::ProgramNode::ProgramNode):
(JSC::ProgramNode::create):
(JSC::EvalNode::EvalNode):
(JSC::EvalNode::create):
(JSC::FunctionBodyNode::FunctionBodyNode):
(JSC::FunctionBodyNode::create):
* parser/Nodes.h:
(JSC::ScopeNode::needsActivation):
(JSC::ScopeNode::hasCapturedVariables):
* parser/Parser.cpp:
(JSC::Parser::didFinishParsing):
* parser/Parser.h:
(JSC::Parser::parse):
* parser/SyntaxChecker.h:
* runtime/Executable.cpp:
(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):
* runtime/Executable.h:
(JSC::ScriptExecutable::needsActivation):
(JSC::ScriptExecutable::recordParse):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67583
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 16 Sep 2010 00:04:16 +0000 (00:04 +0000)]
2010-09-15 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Add queue start/stop messages
https://bugs.webkit.org/show_bug.cgi?id=45853
I ended up needing to clean up a bunch of our unit testing
in order to test this new code path nicely.
There are also a few PEP8 changes needed to pass check-webkit-style.
* Scripts/webkitpy/tool/bot/queueengine.py:
* Scripts/webkitpy/tool/bot/queueengine_unittest.py:
* Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
* Scripts/webkitpy/tool/commands/queues.py:
* Scripts/webkitpy/tool/commands/queues_unittest.py:
* Scripts/webkitpy/tool/commands/queuestest.py:
* Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67582
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Wed, 15 Sep 2010 23:56:06 +0000 (23:56 +0000)]
Add WKUInt64Ref wrapper for sending uint64_ts.
Reviewed by Jon Honeycutt.
* Shared/APIObject.h:
* Shared/WebNumber.h:
* UIProcess/API/C/WKAPICast.h:
* UIProcess/API/C/WKBase.h:
* UIProcess/API/C/WKNumber.cpp:
(WKUInt64GetTypeID):
(WKUInt64Create):
(WKUInt64GetValue):
(WKUInt64SetValue):
* UIProcess/API/C/WKNumber.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67581
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Wed, 15 Sep 2010 23:51:06 +0000 (23:51 +0000)]
2010-09-15 Simon Fraser <simon.fraser@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=45849
WKURLCreateWithCFURL crashes with null url
Fix MiniBrowser crash when the url is not parseable.
* MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController fetch:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67580
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Wed, 15 Sep 2010 23:43:50 +0000 (23:43 +0000)]
2010-09-15 Simon Fraser <simon.fraser@apple.com>
Fix chromium build.
* platform/graphics/chromium/GraphicsLayerChromium.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67579
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Wed, 15 Sep 2010 23:29:49 +0000 (23:29 +0000)]
2010-09-15 Patrick Gansterer <paroga@paroga.com>
Unreviewed.
Adding myself to the committers list.
* Scripts/webkitpy/common/config/committers.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67577
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Wed, 15 Sep 2010 23:27:15 +0000 (23:27 +0000)]
2010-09-15 Simon Fraser <simon.fraser@apple.com>
Reviewed by Adam Roben.
https://bugs.webkit.org/show_bug.cgi?id=44715
maps.google.com flips upside down when zooming map using trackpad in WebKit2 on Mac
Remove the concept of geometry flipping from GraphicsLayer; geometry flipping will
be taken care of in platform code without the need to complicate the GraphicsLayer API.
RenderLayerCompositor no longer sets the geometry orientation for the root
platform layer; platform-specific code does this instead.
This fixes flipped layers in WebKit2, since WebKit2 was already flipping
geometry, and then RenderLayerCompositor was doing an additional flip.
* platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::GraphicsLayer):
* platform/graphics/GraphicsLayer.h:
* platform/graphics/chromium/GraphicsLayerChromium.cpp:
* platform/graphics/chromium/GraphicsLayerChromium.h:
* platform/graphics/mac/GraphicsLayerCA.h:
* platform/graphics/mac/GraphicsLayerCA.mm:
(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):
(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
(WebCore::GraphicsLayerCA::defaultContentsOrientation):
* platform/graphics/qt/GraphicsLayerQt.cpp:
(WebCore::GraphicsLayerQtImpl::flushChanges):
* platform/graphics/qt/GraphicsLayerQt.h:
* platform/graphics/win/GraphicsLayerCACF.cpp:
(WebCore::GraphicsLayerCACF::swapFromOrToTiledLayer):
* platform/graphics/win/GraphicsLayerCACF.h:
* platform/graphics/win/WKCACFLayerRenderer.cpp:
(WebCore::WKCACFLayerRenderer::setRootChildLayer):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::ensureRootPlatformLayer):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67576
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 15 Sep 2010 23:25:34 +0000 (23:25 +0000)]
2010-09-15 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[reviewtool] Comments should quote previous comments on the same line
https://bugs.webkit.org/show_bug.cgi?id=45847
Now when you reply to a previous comment, the tool will quote the
previous comment in the bugs.webkit.org post. This makes it eaiser for
folks following along in email to understand the discussion.
While I was editing this code, I also cleaned up some of the whitespace
handling in comments.
* code-review.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67575
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jchaffraix@webkit.org [Wed, 15 Sep 2010 22:57:04 +0000 (22:57 +0000)]
Unreviewed.
Reverting my changes as it is breaking several tests on Gtk and Qt.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67574
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino@webkit.org [Wed, 15 Sep 2010 22:55:36 +0000 (22:55 +0000)]
[wx] Build fixes for wxMSW.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67573
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Wed, 15 Sep 2010 22:43:32 +0000 (22:43 +0000)]
2010-09-14 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Make it possible to run more than one commit-queue instance
https://bugs.webkit.org/show_bug.cgi?id=45786
Mostly we need to make sure the two (or more) instances get
different patches to work on. To do this, I re-worked
the code responsible for getting the next work item to
round trip through the status server. The status server only
vends patches from the work items list, only if those patches
have not had status reported for them in the last hour.
This is another step towards making all queues go through the
status server, thus making it possible to run more than one
instance of various EWS bots (as requested in bug 44292).
The webkitpy changes are already covered by existing unit tests.
The QueueStatusSever sadly has no testing infrastructure yet. :(
* QueueStatusServer/handlers/nextpatch.py: Added.
* QueueStatusServer/index.yaml:
* QueueStatusServer/main.py:
* Scripts/webkitpy/tool/commands/queues.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67572
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
arv@chromium.org [Wed, 15 Sep 2010 22:43:28 +0000 (22:43 +0000)]
2010-09-15 Erik Arvidsson <arv@chromium.org>
Reviewed by Adam Barth.
Fix regression from bug 32230. The test needed to be updated to reflect the zoom adjusted font-size.
https://bugs.webkit.org/show_bug.cgi?id=45841
* editing/pasteboard/page-zoom.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67571
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jchaffraix@webkit.org [Wed, 15 Sep 2010 22:31:49 +0000 (22:31 +0000)]
WebCore: Parse system colors in the HTML5 canvas context.
https://bugs.webkit.org/show_bug.cgi?id=39168
Reviewed by Andreas Kling.
Test: fast/css/test-setting-canvas-color.html
Based on previous work by Jan Erik Hanssen <jhanssen@codeaurora.org>
* css/CSSParser.cpp:
(WebCore::CSSParser::parseColor): Changed the function to better match our
early return policy. Also we now return false when we don't parse the color.
This is needed for createFromString to fallback to using parseSystemColor.
(WebCore::CSSParser::parseSystemColor): Made use of the RenderTheme to get
the system colors.
* css/CSSParser.h: Added the new parseSystemColor method.
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::setStrokeColor): Pass the document to createFromString.
(WebCore::CanvasRenderingContext2D::setFillColor): Ditto.
* html/canvas/CanvasStyle.cpp:
(WebCore::CanvasStyle::createFromString): Try to parse the color using CSSParser::parseColor
and fall back to parseSystemColor if it did not work.
* html/canvas/CanvasStyle.h: Added the new Document* parameter to createFromString.
LayoutTests: Test for: Parse system colors in the HTML5 canvas context.
https://bugs.webkit.org/show_bug.cgi?id=39168
Reviewed by Andreas Kling.
This tests that svg color, deprecated system color and different
type of colors and invalid inputs are still parsed as such.
* fast/css/test-setting-canvas-color-expected.txt: Added.
* fast/css/test-setting-canvas-color.html: Added.
* platform/mac/Skipped:
* platform/qt/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67570
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 15 Sep 2010 22:10:04 +0000 (22:10 +0000)]
2010-09-15 Adam Barth <abarth@webkit.org>
Minor UI tweak to the review tool. We want to display newlines in
previous and frozen comments instead of collapsing them.
* PrettyPatch/PrettyPatch.rb:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67569
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
arv@chromium.org [Wed, 15 Sep 2010 21:23:52 +0000 (21:23 +0000)]
2010-09-14 Erik Arvidsson <arv@chromium.org>
Reviewed by Darin Adler.
getComputedStyle() returns different values for different zoom levels
https://bugs.webkit.org/show_bug.cgi?id=32230
Test: fast/css/getComputedStyle/computed-style-with-zoom.html
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::zoomAdjustedPixelValue):
(WebCore::zoomAdjustedNumberValue):
(WebCore::valueForReflection):
(WebCore::getPositionOffsetValue):
(WebCore::getBorderRadiusCornerValue):
(WebCore::computedTransform):
(WebCore::CSSComputedStyleDeclaration::getFontSizeCSSValuePreferringKeyword):
(WebCore::CSSComputedStyleDeclaration::valueForShadow):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSComputedStyleDeclaration.h:
* css/SVGCSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):
* rendering/RenderObject.h:
(WebCore::adjustForAbsoluteZoom):
* rendering/style/RenderStyle.h:
(WebCore::adjustForAbsoluteZoom):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67568
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Wed, 15 Sep 2010 19:52:35 +0000 (19:52 +0000)]
2010-09-14 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Fully separate Pango and FreeType font backends
https://bugs.webkit.org/show_bug.cgi?id=27442
Split FontPlatformData.h into separate versions for Pango, FreeType and WinCairo.
Include the correct file via #ifdef'd includes, like the Chromium port. Also split
FontCacheCairo.cpp into Pango and FreeType versions, as they had almost no code in
common. Finally, rename FontPlatformDataCairo to FontPlatformDataFreeType, as this
compilation unit is used only by the FreeType backend. This change is important to
prevent upcoming fixes to the FreeType backend from affecting other backends.
No new tests as functionality has not changed.
* CMakeListsEfl.txt: Update source lists.
* GNUmakefile.am: Update source lists.
* platform/graphics/cairo/FontCacheCairo.cpp: Removed.
* platform/graphics/cairo/FontCacheFreeType.cpp: Added.
(WebCore::FontCache::platformInit):
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
(WebCore::FontCache::getTraitsInFamily):
(WebCore::isWellKnownFontName):
(WebCore::FontCache::createFontPlatformData):
* platform/graphics/cairo/FontPlatformData.h:
* platform/graphics/cairo/FontPlatformDataFreeType.cpp: Renamed from WebCore/platform/graphics/cairo/FontPlatformDataCairo.cpp.
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::operator=):
(WebCore::FontPlatformData::init):
(WebCore::FontPlatformData::~FontPlatformData):
(WebCore::FontPlatformData::isFixedPitch):
(WebCore::FontPlatformData::operator==):
(WebCore::FontPlatformData::description):
* platform/graphics/cairo/FontPlatformDataFreeType.h: Added.
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::size):
(WebCore::FontPlatformData::setSize):
(WebCore::FontPlatformData::syntheticBold):
(WebCore::FontPlatformData::syntheticOblique):
(WebCore::FontPlatformData::scaledFont):
(WebCore::FontPlatformData::hash):
(WebCore::FontPlatformData::isHashTableDeletedValue):
(WebCore::FontPlatformData::hashTableDeletedFontValue):
* platform/graphics/gtk/FontCachePango.cpp: Added.
(WebCore::FontCache::platformInit):
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
(WebCore::FontCache::getTraitsInFamily):
(WebCore::FontCache::createFontPlatformData):
* platform/graphics/gtk/FontPlatformDataPango.h: Added.
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::size):
(WebCore::FontPlatformData::setSize):
(WebCore::FontPlatformData::syntheticBold):
(WebCore::FontPlatformData::syntheticOblique):
(WebCore::FontPlatformData::scaledFont):
(WebCore::FontPlatformData::hash):
(WebCore::FontPlatformData::isHashTableDeletedValue):
(WebCore::FontPlatformData::hashTableDeletedFontValue):
* platform/graphics/win/FontPlatformDataCairoWin.h: Added.
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::hfont):
(WebCore::FontPlatformData::useGDI):
(WebCore::FontPlatformData::fontFace):
(WebCore::FontPlatformData::size):
(WebCore::FontPlatformData::setSize):
(WebCore::FontPlatformData::syntheticBold):
(WebCore::FontPlatformData::syntheticOblique):
(WebCore::FontPlatformData::scaledFont):
(WebCore::FontPlatformData::hash):
(WebCore::FontPlatformData::isHashTableDeletedValue):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67567
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Wed, 15 Sep 2010 19:19:00 +0000 (19:19 +0000)]
2010-09-14 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] fast/events/keydown-numpad-keys.html produces many GLib warnings
https://bugs.webkit.org/show_bug.cgi?id=45775
Handle the toggle-overwrite signal on the GtkTextView used for generating editing
commands. Ignore this signals, as the default handler assumes that the GtkTextView
has a layout and this one does not.
* WebCoreSupport/EditorClientGtk.cpp:
(WebKit::toggleOverwriteCallback): Added. Cancels the default handler.
(WebKit::EditorClient::EditorClient): Attach a handler for toggle-overwrite.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67566
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
wsiegrist@apple.com [Wed, 15 Sep 2010 19:16:17 +0000 (19:16 +0000)]
2010-09-15 William Siegrist <wsiegrist@apple.com>
Allow for narrow columns in waterfall.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67565
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
wsiegrist@apple.com [Wed, 15 Sep 2010 19:10:57 +0000 (19:10 +0000)]
2010-09-15 William Siegrist <wsiegrist@apple.com>
Darken and improve contrast for success and failure boxes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67564
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cfleizach@apple.com [Wed, 15 Sep 2010 17:51:08 +0000 (17:51 +0000)]
AX: when text is auto-truncated, accessibility bounds are wrong
https://bugs.webkit.org/show_bug.cgi?id=45793
Adding ellipsis-text.html to the skip list for GTK until the reason for its failure
is determined.
* platform/gtk/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67563
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Wed, 15 Sep 2010 17:34:42 +0000 (17:34 +0000)]
2010-09-15 Tony Chang <tony@chromium.org>
Unreviewed, remove test that is now passing in test_shell and DRT.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67562
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cfleizach@apple.com [Wed, 15 Sep 2010 17:07:46 +0000 (17:07 +0000)]
AX: when text is auto-truncated, accessibility bounds are wrong
https://bugs.webkit.org/show_bug.cgi?id=45793
Reviewed by Simon Fraser.
WebCore:
Allow accessibility to retrieve the absoluteQuads of a text node that
clips to the ellipsis.
Test: accessibility/ellipsis-text.html
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::boundingBoxRect):
* rendering/RenderText.cpp:
(WebCore::ellipsisRectForBox):
Make a common method to retrieve the ellipsis rect.
(WebCore::RenderText::absoluteQuads):
Default into the absoluteQuads method that allows for ellipsis clipping.
(WebCore::RenderText::selectionRectForRepaint):
Use the common method for retrieving the ellipsis.
* rendering/RenderText.h:
LayoutTests:
* accessibility/ellipsis-text-expected.txt: Added.
* accessibility/ellipsis-text.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67561
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 15 Sep 2010 17:05:56 +0000 (17:05 +0000)]
2010-09-15 Mihai Parparita <mihaip@chromium.org>
Reviewed by Tony Chang.
NRWT fails with UnicodeDecodeError on editing/selection/mixed-editability-10.html
https://bugs.webkit.org/show_bug.cgi?id=45791
Force filenames to be raw bytes before running difflib.unified_diff.
* Scripts/webkitpy/layout_tests/port/base.py:
* Scripts/webkitpy/layout_tests/port/base_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67560
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ariya@webkit.org [Wed, 15 Sep 2010 16:44:31 +0000 (16:44 +0000)]
2010-09-15 Ariya Hidayat <ariya@sencha.com>
[Qt] Improve the speed of blur shadow
https://bugs.webkit.org/show_bug.cgi?id=44222
Update pixel test result.
* platform/qt/fast/box-shadow/basic-shadows-expected.checksum:
* platform/qt/fast/box-shadow/basic-shadows-expected.png:
2010-09-15 Ariya Hidayat <ariya@sencha.com>
[Qt] Improve the speed of blur shadow
https://bugs.webkit.org/show_bug.cgi?id=44222
Rewrite the shadow blur function with loop unrolls and sliding step
unification for both horizontal and vertical directions.
This gives significant performance improvement on most cases.
* platform/graphics/qt/ContextShadow.cpp:
(WebCore::shadowBlur):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67559
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
wsiegrist@apple.com [Wed, 15 Sep 2010 16:06:32 +0000 (16:06 +0000)]
2010-09-15 William Siegrist <wsiegrist@apple.com>
Sync buildbot files after upgrade to v0.8.1
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67558
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
steveblock@google.com [Wed, 15 Sep 2010 15:52:58 +0000 (15:52 +0000)]
2010-09-15 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
fast/dom/DeviceOrientation/add-listener-from-callback flaky
https://bugs.webkit.org/show_bug.cgi?id=45814
When we call addEventListener(), an event is sent to all registered
event listeners on that page. So in the existing test, both the calls
to setMockDeviceOrientation() and addEventListener() will trigger events
to fire asynchronously on both listeners (both will be registered by the
time the event fires), giving a total of five events. A race condition
exists as to whether the test finishes after the third event, before
the fourth event fires.
This patch fixes the problem by expecting the correct number of events
to fire. We also remove the call to setMockDeviceOrientation() as this
adds extra complication and is tested in update.html.
* fast/dom/DeviceOrientation/add-listener-from-callback-expected.txt:
* fast/dom/DeviceOrientation/script-tests/add-listener-from-callback.js:
(checkOrientation):
(firstListener):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67557
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Wed, 15 Sep 2010 15:35:54 +0000 (15:35 +0000)]
Use Qt Labs' WebKit category feed instead of filtering on "webkit"
Looks like the URL of the WebKit category feed changed since this blog
was first added to Planet WebKit.
Rubber-stamped by David Kilzer.
* config.ini:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67556
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Wed, 15 Sep 2010 15:20:20 +0000 (15:20 +0000)]
Only include Qt Labs posts that mention WebKit
All other feeds are either WebKit-specific or are filtered on
"webkit". This makes Qt Labs match all the others. This should help
keep off-topic posts off of Planet WebKit.
Fixes <http://webkit.org/b/45818> Planet WebKit contains many
off-topic posts from Qt Labs
Reviewed by David Kilzer.
* config.ini: Filter the Qt Labs feed on "webkit" like we do for all
other non-WebKit-specific feeds.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67555
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Wed, 15 Sep 2010 13:32:02 +0000 (13:32 +0000)]
[Qt] QtTestBrowser crashes when enabling QGraphicsView mode after first loading page without it enabled
https://bugs.webkit.org/show_bug.cgi?id=35247
Reviewed by Tor Arne Vestbø.
The main issue when changing the views is that the plugins and any other components that
depend on view specific attributes such as the native window id are not teared down.
Even if we had a tear-down procedure, we'd have to re-initialize the plugin after
switching to the new view (QGraphicsWebView). This is a rather uncommon situation, so
we decided to work around this in QtTestBrowser by making toggling between QWebView
and QGraphicsWebView also re-create the page.
* QtTestBrowser/launcherwindow.cpp:
(LauncherWindow::initializeView):
* QtTestBrowser/mainwindow.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67554
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Wed, 15 Sep 2010 13:25:59 +0000 (13:25 +0000)]
2010-09-14 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Provide network-based load timing.
Before this change, inspector used timers taken from
within WebCore notifications (that are by definition
synchronous and serialized). As a result, timing was
affected by the routines running on the main thread
(JavaScript and such).
https://bugs.webkit.org/show_bug.cgi?id=45664
* inspector/InspectorController.cpp:
(WebCore::InspectorController::willSendRequest):
(WebCore::InspectorController::didFinishLoading):
(WebCore::InspectorController::didFailLoading):
* inspector/InspectorController.h:
* inspector/InspectorResource.cpp:
(WebCore::InspectorResource::endTiming):
* inspector/InspectorResource.h:
* loader/PingLoader.h:
(WebCore::PingLoader::didFinishLoading):
* loader/ResourceLoadNotifier.cpp:
(WebCore::ResourceLoadNotifier::dispatchDidFinishLoading):
* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::didFinishLoading):
* loader/ResourceLoader.h:
* loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::didFinishLoading):
* loader/appcache/ApplicationCacheGroup.h:
* loader/icon/IconFetcher.cpp:
(WebCore::IconFetcher::didFinishLoading):
* loader/icon/IconFetcher.h:
* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(StreamingClient::didFinishLoading):
* platform/network/BlobResourceHandle.cpp:
(WebCore::BlobResourceHandle::notifyFinish):
* platform/network/ResourceHandleClient.h:
(WebCore::ResourceHandleClient::didFinishLoading):
* platform/network/ResourceLoadTiming.h:
(WebCore::ResourceLoadTiming::deepCopy):
(WebCore::ResourceLoadTiming::operator==):
(WebCore::ResourceLoadTiming::ResourceLoadTiming):
* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::didFinishLoading):
* platform/network/curl/ResourceHandleCurl.cpp:
(WebCore::WebCoreSynchronousLoader::didFinishLoading):
* platform/network/curl/ResourceHandleManager.cpp:
(WebCore::ResourceHandleManager::downloadTimerCallback):
(WebCore::parseDataUrl):
* platform/network/mac/ResourceHandleMac.mm:
(-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]):
(WebCoreSynchronousLoaderClient::didFinishLoading):
* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::finish):
* platform/network/qt/ResourceHandleQt.cpp:
(WebCore::WebCoreSynchronousLoader::didFinishLoading):
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::WebCoreSynchronousLoader::didFinishLoading):
(WebCore::WebCoreSynchronousLoader::didFail):
* platform/network/win/ResourceHandleWin.cpp:
(WebCore::WebCoreSynchronousLoader::didFinishLoading):
(WebCore::ResourceHandle::onRequestComplete):
(WebCore::ResourceHandle::fileLoadTimer):
(WebCore::ResourceHandle::cancel):
2010-09-14 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Provide network-based load timing.
Before this change, inspector used timers taken from
within WebCore notifications (that are by definition
synchronous and serialized). As a result, timing was
affected by the routines running on the main thread
(JavaScript and such).
https://bugs.webkit.org/show_bug.cgi?id=45664
* public/WebURLLoadTiming.h:
* public/WebURLLoaderClient.h:
(WebKit::WebURLLoaderClient::didFinishLoading):
* src/ResourceHandle.cpp:
(WebCore::ResourceHandleInternal::didFinishLoading):
* src/WebDevToolsAgentImpl.cpp:
(WebKit::WebDevToolsAgentImpl::didFinishLoading):
* src/WebURLLoadTiming.cpp:
(WebKit::WebURLLoadTiming::receiveHeadersStart):
(WebKit::WebURLLoadTiming::setReceiveHeadersStart):
2010-09-14 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Provide network-based load timing.
Before this change, inspector used timers taken from
within WebCore notifications (that are by definition
synchronous and serialized). As a result, timing was
affected by the routines running on the main thread
(JavaScript and such).
https://bugs.webkit.org/show_bug.cgi?id=45664
* webkit/webkitdownload.cpp:
(DownloadClient::didFinishLoading):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67553
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Wed, 15 Sep 2010 12:56:25 +0000 (12:56 +0000)]
2010-09-15 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r67551.
http://trac.webkit.org/changeset/67551
https://bugs.webkit.org/show_bug.cgi?id=45816
"Plugin tests fail" (Requested by yurys on #webkit).
* inspector/InspectorController.cpp:
(WebCore::InspectorController::willSendRequest):
(WebCore::InspectorController::didFinishLoading):
(WebCore::InspectorController::didFailLoading):
(WebCore::InspectorController::didCloseWebSocket):
* inspector/InspectorController.h:
* inspector/InspectorResource.cpp:
(WebCore::InspectorResource::endTiming):
* inspector/InspectorResource.h:
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::substituteResourceDeliveryTimerFired):
* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::continueAfterContentPolicy):
(WebCore::MainResourceLoader::didFinishLoading):
* loader/MainResourceLoader.h:
* loader/NetscapePlugInStreamLoader.cpp:
(WebCore::NetscapePlugInStreamLoader::didFinishLoading):
* loader/PingLoader.h:
(WebCore::PingLoader::didFinishLoading):
* loader/ResourceLoadNotifier.cpp:
(WebCore::ResourceLoadNotifier::didFinishLoad):
(WebCore::ResourceLoadNotifier::dispatchDidFinishLoading):
(WebCore::ResourceLoadNotifier::sendRemainingDelegateMessages):
* loader/ResourceLoadNotifier.h:
* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::didFinishLoading):
(WebCore::ResourceLoader::didFinishLoadingOnePart):
* loader/ResourceLoader.h:
* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::didReceiveResponse):
(WebCore::SubresourceLoader::didFinishLoading):
* loader/SubresourceLoader.h:
* loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::didFinishLoading):
* loader/appcache/ApplicationCacheGroup.h:
* loader/icon/IconFetcher.cpp:
(WebCore::IconFetcher::didFinishLoading):
* loader/icon/IconFetcher.h:
* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(StreamingClient::didFinishLoading):
* platform/network/BlobResourceHandle.cpp:
(WebCore::BlobResourceHandle::notifyFinish):
* platform/network/ResourceHandleClient.h:
(WebCore::ResourceHandleClient::didFinishLoading):
* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::didFinishLoading):
(WebCore::WebCoreSynchronousLoaderClient::didFinishLoading):
* platform/network/curl/ResourceHandleCurl.cpp:
(WebCore::WebCoreSynchronousLoader::didFinishLoading):
* platform/network/curl/ResourceHandleManager.cpp:
(WebCore::ResourceHandleManager::downloadTimerCallback):
(WebCore::parseDataUrl):
* platform/network/mac/ResourceHandleMac.mm:
(-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]):
(WebCoreSynchronousLoaderClient::didFinishLoading):
* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::finish):
* platform/network/qt/ResourceHandleQt.cpp:
(WebCore::WebCoreSynchronousLoader::didFinishLoading):
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::WebCoreSynchronousLoader::didFinishLoading):
(WebCore::WebCoreSynchronousLoader::didFail):
(WebCore::finishedCallback):
(WebCore::parseDataUrl):
* platform/network/win/ResourceHandleWin.cpp:
(WebCore::WebCoreSynchronousLoader::didFinishLoading):
(WebCore::ResourceHandle::onRequestComplete):
(WebCore::ResourceHandle::fileLoadTimer):
(WebCore::ResourceHandle::cancel):
2010-09-15 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r67551.
http://trac.webkit.org/changeset/67551
https://bugs.webkit.org/show_bug.cgi?id=45816
"Plugin tests fail" (Requested by yurys on #webkit).
* public/WebURLLoaderClient.h:
(WebKit::WebURLLoaderClient::didFinishLoading):
* src/ResourceHandle.cpp:
(WebCore::ResourceHandleInternal::didFinishLoading):
* src/WebDevToolsAgentImpl.cpp:
(WebKit::WebDevToolsAgentImpl::didFinishLoading):
2010-09-15 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r67551.
http://trac.webkit.org/changeset/67551
https://bugs.webkit.org/show_bug.cgi?id=45816
"Plugin tests fail" (Requested by yurys on #webkit).
* webkit/webkitdownload.cpp:
(DownloadClient::didFinishLoading):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67552
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Wed, 15 Sep 2010 12:04:07 +0000 (12:04 +0000)]
2010-09-14 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Provide network-based load timing.
Before this change, inspector used timers taken from
within WebCore notifications (that are by definition
synchronous and serialized). As a result, timing was
affected by the routines running on the main thread
(JavaScript and such).
https://bugs.webkit.org/show_bug.cgi?id=45664
* inspector/InspectorController.cpp:
(WebCore::InspectorController::willSendRequest):
(WebCore::InspectorController::didFinishLoading):
(WebCore::InspectorController::didFailLoading):
* inspector/InspectorController.h:
* inspector/InspectorResource.cpp:
(WebCore::InspectorResource::endTiming):
* inspector/InspectorResource.h:
* loader/PingLoader.h:
(WebCore::PingLoader::didFinishLoading):
* loader/ResourceLoadNotifier.cpp:
(WebCore::ResourceLoadNotifier::dispatchDidFinishLoading):
* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::didFinishLoading):
* loader/ResourceLoader.h:
* loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::didFinishLoading):
* loader/appcache/ApplicationCacheGroup.h:
* loader/icon/IconFetcher.cpp:
(WebCore::IconFetcher::didFinishLoading):
* loader/icon/IconFetcher.h:
* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(StreamingClient::didFinishLoading):
* platform/network/BlobResourceHandle.cpp:
(WebCore::BlobResourceHandle::notifyFinish):
* platform/network/ResourceHandleClient.h:
(WebCore::ResourceHandleClient::didFinishLoading):
* platform/network/ResourceLoadTiming.h:
(WebCore::ResourceLoadTiming::deepCopy):
(WebCore::ResourceLoadTiming::operator==):
(WebCore::ResourceLoadTiming::ResourceLoadTiming):
* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::didFinishLoading):
* platform/network/curl/ResourceHandleCurl.cpp:
(WebCore::WebCoreSynchronousLoader::didFinishLoading):
* platform/network/curl/ResourceHandleManager.cpp:
(WebCore::ResourceHandleManager::downloadTimerCallback):
(WebCore::parseDataUrl):
* platform/network/mac/ResourceHandleMac.mm:
(-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]):
(WebCoreSynchronousLoaderClient::didFinishLoading):
* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::finish):
* platform/network/qt/ResourceHandleQt.cpp:
(WebCore::WebCoreSynchronousLoader::didFinishLoading):
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::WebCoreSynchronousLoader::didFinishLoading):
(WebCore::WebCoreSynchronousLoader::didFail):
* platform/network/win/ResourceHandleWin.cpp:
(WebCore::WebCoreSynchronousLoader::didFinishLoading):
(WebCore::ResourceHandle::onRequestComplete):
(WebCore::ResourceHandle::fileLoadTimer):
(WebCore::ResourceHandle::cancel):
2010-09-14 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Provide network-based load timing.
Before this change, inspector used timers taken from
within WebCore notifications (that are by definition
synchronous and serialized). As a result, timing was
affected by the routines running on the main thread
(JavaScript and such).
https://bugs.webkit.org/show_bug.cgi?id=45664
* public/WebURLLoadTiming.h:
* public/WebURLLoaderClient.h:
(WebKit::WebURLLoaderClient::didFinishLoading):
* src/ResourceHandle.cpp:
(WebCore::ResourceHandleInternal::didFinishLoading):
* src/WebDevToolsAgentImpl.cpp:
(WebKit::WebDevToolsAgentImpl::didFinishLoading):
* src/WebURLLoadTiming.cpp:
(WebKit::WebURLLoadTiming::receiveHeadersStart):
(WebKit::WebURLLoadTiming::setReceiveHeadersStart):
2010-09-14 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Provide network-based load timing.
Before this change, inspector used timers taken from
within WebCore notifications (that are by definition
synchronous and serialized). As a result, timing was
affected by the routines running on the main thread
(JavaScript and such).
https://bugs.webkit.org/show_bug.cgi?id=45664
* webkit/webkitdownload.cpp:
(DownloadClient::didFinishLoading):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67551
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Wed, 15 Sep 2010 11:45:15 +0000 (11:45 +0000)]
2010-09-15 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
[Chromium] rebaseline 10 new svg tests added in 67544
https://bugs.webkit.org/show_bug.cgi?id=45813
* platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.checksum: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr-expected.checksum: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr-expected.checksum: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.checksum: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr-expected.checksum: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.checksum: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop-expected.checksum: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop-expected.checksum: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.checksum: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop-expected.checksum: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.checksum: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr-expected.checksum: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr-expected.checksum: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.checksum: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr-expected.checksum: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.checksum: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop-expected.checksum: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop-expected.checksum: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.checksum: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop-expected.checksum: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop-expected.png: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67550
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Wed, 15 Sep 2010 11:34:25 +0000 (11:34 +0000)]
[Qt] Update the Symbian def files
Re-freeze with the viewport meta tag updates.
* symbian/eabi/QtWebKitu.def:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67549
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Wed, 15 Sep 2010 11:34:23 +0000 (11:34 +0000)]
2010-09-15 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
[Chromium] mark new viewport tests as failing rather then skip them
https://bugs.webkit.org/show_bug.cgi?id=45652
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67548
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Wed, 15 Sep 2010 11:17:48 +0000 (11:17 +0000)]
2010-09-14 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
WebInspector: small refactoring for monitorXHR backend property.
Our Inspector API is quite big and can be simplified a bit.
As example for single backend property like monitoringXHR we
have 4 functions in the API. Two functions for frontend
enableMonitoringXHR/disableMonitoringXHR and
two functions for backend monitoringXHRWasEnabled and
monitoringXHRWasDisabled. These functions can be replaced by
one setMonitoringXHR with one 'in' and one 'out' argument.
The initial state of the flag can be gathered from backend
with help of getSettings call where additional section was
added for backend state information.
https://bugs.webkit.org/show_bug.cgi?id=45759
* inspector/Inspector.idl:
* inspector/InspectorController.cpp:
* inspector/InspectorController.h:
* inspector/front-end/ConsoleView.js:
* inspector/front-end/Settings.js:
* inspector/front-end/inspector.js:
2010-09-14 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
WebInspector: small refactoring for monitorXHR backend property.
Our Inspector API is quite big and can be simplified a bit.
As example for single backend property like monitoringXHR we
have 4 functions in the API. Two functions for frontend
enableMonitoringXHR/disableMonitoringXHR and
two functions for backend monitoringXHRWasEnabled and
monitoringXHRWasDisabled. These functions can be replaced by
one setMonitoringXHR with one 'in' and one 'out' argument.
The initial state of the flag can be gathered from backend
with help of getSettings call where additional section was
added for backend state information.
https://bugs.webkit.org/show_bug.cgi?id=45759
* inspector/Inspector.idl:
* inspector/InspectorController.cpp:
* inspector/InspectorController.h:
* inspector/front-end/ConsoleView.js:
* inspector/front-end/Settings.js:
* inspector/front-end/inspector.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67547
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
steveblock@google.com [Wed, 15 Sep 2010 10:05:52 +0000 (10:05 +0000)]
2010-09-15 Steve Block <steveblock@google.com>
Reviewed by Kent Tamura.
LayoutTest fast/dom/Geolocation/clear-watch-invalid-id-crash.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=45783
This test synchronously navigates the page to a new URL from its main script file.
This navigation causes WebView.onPageFinished() to be called for the test page.
The problem is that this may occur before js-test-post.js, which is included by the
test and calls layoutTestController.waitUntilDone(), is loaded and parsed. As a
result, the test is incorrectly deemed to have finished as soon as the navigation
is started and the output will therefore be incorrect.
This patch fixes the problem by initiating the page navigation from
the onload handler, which is not fired until all resources have been
loaded and parsed. This guarantees that WebView.onPageFinished() is
not called until after layoutTestController.waitUntilDone() has been
called.
* fast/dom/Geolocation/script-tests/clear-watch-invalid-id-crash.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67546
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
git://git.webkit.org / WebKit-https.git / log