WebKit-https.git
9 years ago[Qt][WK2] Move non-api classes to WebKit namespace at WebKit2/UiProcess/qt
commit-queue@webkit.org [Mon, 23 Apr 2012 14:43:41 +0000 (14:43 +0000)]
[Qt][WK2] Move non-api classes to WebKit namespace at WebKit2/UiProcess/qt
https://bugs.webkit.org/show_bug.cgi?id=84528

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-04-23
Reviewed by Simon Hausmann.

Fix namespace usage in non-api classes for Qt.

* UIProcess/API/qt/qquickwebpage.cpp:
* UIProcess/API/qt/qquickwebpage_p.h:
(WebKit):
* UIProcess/API/qt/qquickwebpage_p_p.h:
(WebKit):
(QQuickWebPagePrivate):
* UIProcess/API/qt/qquickwebview.cpp:
* UIProcess/API/qt/qquickwebview_p.h:
(WebKit):
* UIProcess/API/qt/qquickwebview_p_p.h:
(WebKit):
(QQuickWebViewPrivate::viewportInteractionEngine):
(QQuickWebViewPrivate):
(QQuickWebViewFlickablePrivate::viewportInteractionEngine):
(QQuickWebViewFlickablePrivate):
* UIProcess/API/qt/qwebdownloaditem_p.h:
(WebKit):
* UIProcess/API/qt/qwebviewportinfo.cpp:
* UIProcess/qt/LayerBackingStore.cpp:
* UIProcess/qt/LayerBackingStore.h:
(WebKit):
* UIProcess/qt/QtDialogRunner.cpp:
(WebKit):
* UIProcess/qt/QtDialogRunner.h:
(WebKit):
* UIProcess/qt/QtDownloadManager.cpp:
* UIProcess/qt/QtDownloadManager.h:
(WebKit):
* UIProcess/qt/QtGestureRecognizer.cpp:
* UIProcess/qt/QtGestureRecognizer.h:
(WebKit):
* UIProcess/qt/QtPageClient.cpp:
(WebKit):
* UIProcess/qt/QtPageClient.h:
(WebKit):
(QtPageClient):
* UIProcess/qt/QtPanGestureRecognizer.cpp:
* UIProcess/qt/QtPanGestureRecognizer.h:
* UIProcess/qt/QtPinchGestureRecognizer.cpp:
* UIProcess/qt/QtPinchGestureRecognizer.h:
* UIProcess/qt/QtTapGestureRecognizer.h:
(WebKit):
* UIProcess/qt/QtViewportInteractionEngine.cpp:
* UIProcess/qt/QtViewportInteractionEngine.h:
* UIProcess/qt/QtWebContext.cpp:
* UIProcess/qt/QtWebContext.h:
* UIProcess/qt/QtWebError.cpp:
(WebKit):
* UIProcess/qt/QtWebError.h:
(WebKit):
* UIProcess/qt/QtWebIconDatabaseClient.cpp:
(WebKit):
* UIProcess/qt/QtWebIconDatabaseClient.h:
(WTF):
(WebKit):
(QtWebIconDatabaseClient):
* UIProcess/qt/QtWebPageEventHandler.cpp:
(WebKit):
* UIProcess/qt/QtWebPageEventHandler.h:
(WebCore):
(WebKit):
* UIProcess/qt/QtWebPageLoadClient.cpp:
(WebKit):
* UIProcess/qt/QtWebPageLoadClient.h:
(WebKit):
* UIProcess/qt/QtWebPagePolicyClient.cpp:
(WebKit):
* UIProcess/qt/QtWebPagePolicyClient.h:
(WebKit):
* UIProcess/qt/QtWebPageSGNode.cpp:
* UIProcess/qt/QtWebPageSGNode.h:
(WebKit):
* UIProcess/qt/QtWebPageUIClient.cpp:
* UIProcess/qt/QtWebPageUIClient.h:
(WebKit):
* UIProcess/qt/QtWebUndoController.cpp:
(WebKit):
* UIProcess/qt/QtWebUndoController.h:
(WebKit):
* UIProcess/qt/WebContextMenuProxyQt.cpp:
* UIProcess/qt/WebContextQt.cpp:
* UIProcess/qt/WebFullScreenManagerProxyQt.cpp:
* UIProcess/qt/WebGeolocationProviderQt.cpp:
(WebKit):
* UIProcess/qt/WebGeolocationProviderQt.h:
(WebKit):
* UIProcess/qt/WebPopupMenuProxyQt.cpp:
(WebKit):
* UIProcess/qt/WebPopupMenuProxyQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Unreviewed test expectations update.
mnaganov@chromium.org [Mon, 23 Apr 2012 14:35:13 +0000 (14:35 +0000)]
[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=84596

Mark media/encrypted-media/encrypted-media-events.html as flaky.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSimplify CSSParser::parseFont.
alexis.menard@openbossa.org [Mon, 23 Apr 2012 14:26:55 +0000 (14:26 +0000)]
Simplify CSSParser::parseFont.
https://bugs.webkit.org/show_bug.cgi?id=78698

Reviewed by Antti Koivisto.

Source/WebCore:

Simplify parseFont by sharing the code we have for
the longhands of the font property.

No new tests : Extend the existing font shorthand test and modify expected files
as now the order of the longhands added in the property list of the style
has changed. It's very unlikely that some code is relying on this order though. It will
also match the way the spec order them http://www.w3.org/TR/css3-fonts/#font-prop
even though the order is arbitrary for some values.

* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFont):
(WebCore::CSSParser::parseLineHeight):
(WebCore):
(WebCore::CSSParser::parseFontSize):
(WebCore::CSSParser::parseFontWeight):  Fix a bug discovered while using parseFontWeight from
the parseFont (case font: 0/0, Arial, sans-serif; in a layout test), we should return true only
when we add something in the property list.
* css/CSSParser.h:

LayoutTests:

Added new incorrect values to improve the test coverage of the font shorthand property.

The patch changed the order the longhands are added to the list
of properties for the style so the expected files need to be updated.

* fast/css/font-shorthand-expected.txt:
* fast/css/font-shorthand.html:
* fast/inspector-support/style-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: improve the way heap snapshot diff is calculated
yurys@chromium.org [Mon, 23 Apr 2012 13:48:57 +0000 (13:48 +0000)]
Web Inspector: improve the way heap snapshot diff is calculated
https://bugs.webkit.org/show_bug.cgi?id=84590

Diff calculation now consists of the following steps:
1. Collect data about nodes in the base heap snapshot
2. Pass it to the second snapshot.
3. Calculate delta for each class.

Reviewed by Pavel Feldman.

* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshot):
(WebInspector.HeapSnapshot.prototype.dispose):
(WebInspector.HeapSnapshot.prototype.aggregatesForDiff):
(WebInspector.HeapSnapshot.prototype.calculateSnapshotDiff):
(WebInspector.HeapSnapshot.prototype._calculateDiffForClass):
(WebInspector.HeapSnapshot.prototype.createAddedNodesProvider):
(WebInspector.HeapSnapshot.prototype.createDeletedNodesProvider):
* inspector/front-end/HeapSnapshotDataGrids.js:
(WebInspector.HeapSnapshotDiffDataGrid.prototype._populateChildren.aggregatesForDiffReceived.didCalculateSnapshotDiff):
(WebInspector.HeapSnapshotDiffDataGrid.prototype._populateChildren):
* inspector/front-end/HeapSnapshotGridNodes.js:
(WebInspector.HeapSnapshotIteratorsTuple):
(WebInspector.HeapSnapshotDiffNode):
(WebInspector.HeapSnapshotDiffNode.prototype._createChildNode):
(WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider):
* inspector/front-end/HeapSnapshotProxy.js:
(WebInspector.HeapSnapshotProxy.prototype.aggregatesForDiff):
(WebInspector.HeapSnapshotProxy.prototype.calculateSnapshotDiff):
(WebInspector.HeapSnapshotProxy.prototype.createAddedNodesProvider):
(WebInspector.HeapSnapshotProxy.prototype.createDeletedNodesProvider):
* inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapSnapshotView.prototype._changeBase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Unreviewed test expectations update.
mnaganov@chromium.org [Mon, 23 Apr 2012 13:39:24 +0000 (13:39 +0000)]
[Chromium] Unreviewed test expectations update.
http://webkit.org/b/72402

Unmark compositing/layer-creation/overflow-scroll-overlap.html as failing

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Rename and extract UISourceCodeImpl into JavaScriptSource
pfeldman@chromium.org [Mon, 23 Apr 2012 13:26:20 +0000 (13:26 +0000)]
Web Inspector: Rename and extract UISourceCodeImpl into JavaScriptSource
https://bugs.webkit.org/show_bug.cgi?id=84587

Reviewed by Yury Semikhatsky.

Source/WebCore:

No changes other than extraction here. This is the first step in the Resource
hierarchy refactoring described in bug 84586.

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/compile-front-end.py:
* inspector/front-end/CompilerScriptMapping.js:
(WebInspector.CompilerScriptMapping.prototype.addScript):
* inspector/front-end/DebuggerPresentationModel.js:
* inspector/front-end/JavaScriptSource.js: Added.
(WebInspector.JavaScriptSource):
(WebInspector.JavaScriptSource.prototype.breakpoints):
(WebInspector.JavaScriptSource.prototype.breakpointAdded):
(WebInspector.JavaScriptSource.prototype.breakpointRemoved):
(WebInspector.JavaScriptSource.prototype.consoleMessages):
(WebInspector.JavaScriptSource.prototype.consoleMessageAdded):
(WebInspector.JavaScriptSource.prototype.consoleMessagesCleared):
* inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode.prototype._createUISourceCode):
* inspector/front-end/SnippetsModel.js:
(WebInspector.SnippetsScriptMapping.prototype._snippetAdded):
(WebInspector.SnippetsScriptMapping.prototype._createUISourceCodeForScript):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:

LayoutTests:

* inspector/debugger/breakpoint-manager.html:
* inspector/debugger/scripts-panel.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoChromium roll from r133348 to r133422.
mnaganov@chromium.org [Mon, 23 Apr 2012 13:15:09 +0000 (13:15 +0000)]
Chromium roll from r133348 to r133422.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMove ReferrerPolicy out of SecurityPolicy class into its own header in platform.
gavinp@chromium.org [Mon, 23 Apr 2012 12:53:24 +0000 (12:53 +0000)]
Move ReferrerPolicy out of SecurityPolicy class into its own header in platform.
https://bugs.webkit.org/show_bug.cgi?id=84516

Source/WebCore:

Reviewed by Adam Barth.

No change in behaviour; same enum, different class.

* GNUmakefile.list.am:
* Target.pri:
* WebCore.exp.in:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::processReferrerPolicy):
* dom/Document.h:
(WebCore::Document::referrerPolicy):
(Document):
* page/SecurityPolicy.h:
* platform/ReferrerPolicy.h: Added.
(WebCore):

Source/WebKit/chromium:

Reviewed by Adam Barth.

No change in behaviour; same enum, different class.

* src/AssertMatchingEnums.cpp:
* src/WebSecurityPolicy.cpp:
(WebKit::WebSecurityPolicy::generateReferrerHeader):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Unreviewed test expectations update.
mnaganov@chromium.org [Mon, 23 Apr 2012 12:37:50 +0000 (12:37 +0000)]
[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=70765

Unmark fast/forms/listbox-clip.html on Windows

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Unreviewed test expectations update.
mnaganov@chromium.org [Mon, 23 Apr 2012 12:15:43 +0000 (12:15 +0000)]
[Chromium] Unreviewed test expectations update.
http://crbug.com/23494

Unmark css2.1/t1503-c522-font-family-00-b.html on Leopard.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoJS binding code generator doesn't handle "attribute unsigned long[]" well
commit-queue@webkit.org [Mon, 23 Apr 2012 11:34:27 +0000 (11:34 +0000)]
JS binding code generator doesn't handle "attribute unsigned long[]" well
https://bugs.webkit.org/show_bug.cgi?id=84540

Patch by Vineet Chaudhary <rgf748@motorola.com> on 2012-04-23
Reviewed by Kentaro Hara.

Codegenerator should handle spaces with the sequence<> to support
numeric types like "unsigned long", "int" .. etc. and primitive types
like "boolean", "Date" etc.

Tests: bindings/scripts/test/TestObj.idl

* bindings/scripts/CodeGenerator.pm:
(SkipIncludeHeader): Rename AvoidInclusionOfType to SkipIncludeHeader.
(GetArrayType):
* bindings/scripts/CodeGeneratorJS.pm:
(AddIncludesForType):
(NativeToJSValue):
* bindings/scripts/CodeGeneratorObjC.pm:
(AddIncludesForType):
(GenerateImplementation):
* bindings/scripts/CodeGeneratorV8.pm:
(AddIncludesForType):
(GetHeaderClassInclude):
(GenerateNormalAttrGetter):
(NativeToJSValue):
* bindings/scripts/IDLStructure.pm:
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore):
(WebCore::jsTestObjIntSequenceAttr):
(WebCore::jsTestObjShortSequenceAttr):
(WebCore::jsTestObjLongSequenceAttr):
(WebCore::jsTestObjLongLongSequenceAttr):
(WebCore::jsTestObjUnsignedIntSequenceAttr):
(WebCore::jsTestObjUnsignedShortSequenceAttr):
(WebCore::jsTestObjUnsignedLongSequenceAttr):
(WebCore::jsTestObjUnsignedLongLongSequenceAttr):
(WebCore::jsTestObjFloatSequenceAttr):
(WebCore::jsTestObjDoubleSequenceAttr):
(WebCore::jsTestObjBooleanSequenceAttr):
(WebCore::jsTestObjVoidSequenceAttr):
(WebCore::jsTestObjDateSequenceAttr):
(WebCore::setJSTestObjSequenceAttr):
(WebCore::setJSTestObjIntSequenceAttr):
(WebCore::setJSTestObjShortSequenceAttr):
(WebCore::setJSTestObjLongSequenceAttr):
(WebCore::setJSTestObjLongLongSequenceAttr):
(WebCore::setJSTestObjUnsignedIntSequenceAttr):
(WebCore::setJSTestObjUnsignedShortSequenceAttr):
(WebCore::setJSTestObjUnsignedLongSequenceAttr):
(WebCore::setJSTestObjUnsignedLongLongSequenceAttr):
(WebCore::setJSTestObjFloatSequenceAttr):
(WebCore::setJSTestObjDoubleSequenceAttr):
(WebCore::setJSTestObjBooleanSequenceAttr):
(WebCore::setJSTestObjVoidSequenceAttr):
(WebCore::setJSTestObjDateSequenceAttr):
* bindings/scripts/test/JS/JSTestObj.h:
(WebCore):
* bindings/scripts/test/ObjC/DOMTestObj.h:
* bindings/scripts/test/TestObj.idl:
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::intSequenceAttrAttrGetter):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::intSequenceAttrAttrSetter):
(WebCore::TestObjV8Internal::shortSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::shortSequenceAttrAttrSetter):
(WebCore::TestObjV8Internal::longSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::longSequenceAttrAttrSetter):
(WebCore::TestObjV8Internal::longLongSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::longLongSequenceAttrAttrSetter):
(WebCore::TestObjV8Internal::unsignedIntSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::unsignedIntSequenceAttrAttrSetter):
(WebCore::TestObjV8Internal::unsignedShortSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::unsignedShortSequenceAttrAttrSetter):
(WebCore::TestObjV8Internal::unsignedLongSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::unsignedLongSequenceAttrAttrSetter):
(WebCore::TestObjV8Internal::unsignedLongLongSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::unsignedLongLongSequenceAttrAttrSetter):
(WebCore::TestObjV8Internal::floatSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::floatSequenceAttrAttrSetter):
(WebCore::TestObjV8Internal::doubleSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::doubleSequenceAttrAttrSetter):
(WebCore::TestObjV8Internal::booleanSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::booleanSequenceAttrAttrSetter):
(WebCore::TestObjV8Internal::voidSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::voidSequenceAttrAttrSetter):
(WebCore::TestObjV8Internal::dateSequenceAttrAttrGetter):
(WebCore::TestObjV8Internal::dateSequenceAttrAttrSetter):
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed rolling out r114881, because it broke upload buildstep.
ossy@webkit.org [Mon, 23 Apr 2012 10:50:20 +0000 (10:50 +0000)]
Unreviewed rolling out r114881, because it broke upload buildstep.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(ConfigureBuild.__init__):
(ConfigureBuild.start):
(CompileWebKit.start):
(UploadBuiltProduct):
(UploadBuiltProduct.determineExtraFeatures):
(Factory.__init__):
(BuildFactory.__init__):
(TestFactory.__init__):
(loadBuilderConfig):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed assertion fix for Chromium bots.
kling@webkit.org [Mon, 23 Apr 2012 10:44:27 +0000 (10:44 +0000)]
Unreviewed assertion fix for Chromium bots.

Skip unnecessary Attr::attachToElement() after constructing an Attr using the
constructor that attaches to an Element.

* dom/ElementAttributeData.cpp:
(WebCore::ElementAttributeData::ensureAttr):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Unreviewed test expectations update.
mnaganov@chromium.org [Mon, 23 Apr 2012 10:38:00 +0000 (10:38 +0000)]
[Chromium] Unreviewed test expectations update.

Unmark fast/regex/unicodeCaseInsensitive.html -- the bug has been
fixed long ago, and the test is passing now.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION(r114870): Assertion failure in ElementAttributeData::setAttr().
kling@webkit.org [Mon, 23 Apr 2012 10:17:23 +0000 (10:17 +0000)]
REGRESSION(r114870): Assertion failure in ElementAttributeData::setAttr().
<http://webkit.org/b/84581>

Reviewed by Antti Koivisto.

Attach the Attr and bump m_attrCount manually in ensureAttr() instead of calling
setAttr(). The latter asserts that the Attr isn't present in the map, which
obviously isn't true after we've just added it.

This has the added effect of removing one unnecessary hash lookup.

* dom/ElementAttributeData.cpp:
(WebCore::ElementAttributeData::ensureAttr):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: make ParsedURL.prototype.displayName data url friendly.
pfeldman@chromium.org [Mon, 23 Apr 2012 09:42:55 +0000 (09:42 +0000)]
Web Inspector: make ParsedURL.prototype.displayName data url friendly.
https://bugs.webkit.org/show_bug.cgi?id=84578

Reviewed by Yury Semikhatsky.

We'd like to define valid URL as the one that has scheme, host and path.
We can append to this URL and manipulate its content. We still want
possibly invalid specs (such as data or about) to exist and have nice
display names.

* inspector/front-end/ResourceUtils.js:
(WebInspector.ParsedURL):
(WebInspector.ParsedURL.prototype.get displayName):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agomaster.cfg cleanup, remove dead codes after r92792.
ossy@webkit.org [Mon, 23 Apr 2012 08:51:11 +0000 (08:51 +0000)]
cfg cleanup, remove dead codes after r92792.
https://bugs.webkit.org/show_bug.cgi?id=84433

Reviewed by Ryosuke Niwa.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: introduce String.prototype.starts/endsWith and use it all over the...
pfeldman@chromium.org [Mon, 23 Apr 2012 08:49:38 +0000 (08:49 +0000)]
Web Inspector: introduce String.prototype.starts/endsWith and use it all over the place.
https://bugs.webkit.org/show_bug.cgi?id=84574

Reviewed by Yury Semikhatsky.

* inspector/front-end/AuditRules.js:
(WebInspector.AuditRules.VendorPrefixedCSSProperties.prototype.visitProperty):
* inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.EventListenerBreakpointsSidebarPane.prototype._setBreakpoint):
(WebInspector.EventListenerBreakpointsSidebarPane.prototype._removeBreakpoint):
* inspector/front-end/CSSCompletions.js:
(WebInspector.CSSCompletions.prototype.startsWith):
(WebInspector.CSSCompletions.prototype._firstIndexOfPrefix):
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._reportCompletions):
* inspector/front-end/CookieItemsView.js:
(WebInspector.Cookies.cookieMatchesResourceURL):
* inspector/front-end/DatabaseQueryView.js:
(WebInspector.DatabaseQueryView.prototype.completions):
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype._buildAttributeDOM):
* inspector/front-end/ProfileView.js:
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype.addProfileHeader):
(WebInspector.ProfilesPanel.prototype.displayTitleForProfileLink):
(WebInspector.ProfileSidebarTreeElement):
(WebInspector.ProfileSidebarTreeElement.prototype.get mainTitle):
* inspector/front-end/ResourceUtils.js:
(WebInspector.ParsedURL):
(WebInspector.displayNameForURL):
(WebInspector.linkifyStringAsFragmentWithCustomLinkifier):
(WebInspector.completeURL):
* inspector/front-end/SnippetsModel.js:
(WebInspector.SnippetsModel.prototype.snippetIdForSourceURL):
* inspector/front-end/SourceCSSTokenizer.js:
(WebInspector.SourceCSSTokenizer.prototype.nextToken):
* inspector/front-end/SourceCSSTokenizer.re2js:
* inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.prototype._completeCommonPrefix):
* inspector/front-end/UIUtils.js:
(WebInspector.startEditing):
* inspector/front-end/utilities.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION(r114870): Performance hit on DOM/CloneNodes and DOM/CreateNodes.
kling@webkit.org [Mon, 23 Apr 2012 08:40:07 +0000 (08:40 +0000)]
REGRESSION(r114870): Performance hit on DOM/CloneNodes and DOM/CreateNodes.
<http://webkit.org/b/84575>

Reviewed by Antti Koivisto.

Simplify the cloning of Attributes from one Element to another by simply
assigning to m_attributes. This avoids default-constructing a bunch of
Attribute objects that we overwrite immediately anyway (this used to be
fine because they were RefPtr<Attribute> but now that a default-constructed
Attribute contains a QualifiedName, we were doing a bunch of extra hash
lookups, etc.)

* dom/ElementAttributeData.cpp:
(WebCore::ElementAttributeData::setAttributes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: implement "open stylesheet" dialog.
pfeldman@chromium.org [Mon, 23 Apr 2012 08:05:36 +0000 (08:05 +0000)]
Web Inspector: implement "open stylesheet" dialog.
https://bugs.webkit.org/show_bug.cgi?id=84466

Reviewed by Yury Semikhatsky.

This change introduces abstract OpenResourceDialog and re-uses it in OpenScriptDialog and OpenStylesheetDialog.
Drive-by fix for data: url representation in the navigator and open resource dialogs.

* inspector/front-end/FilteredItemSelectionDialog.js:
(WebInspector.FilteredItemSelectionDialog.prototype.position):
(WebInspector.OpenResourceDialog.filterOutEmptyURLs):
(WebInspector.OpenResourceDialog.compareFunction):
(WebInspector.OpenResourceDialog):
(WebInspector.OpenResourceDialog.prototype.itemTitleAt):
(WebInspector.OpenResourceDialog.prototype.itemKeyAt):
(WebInspector.OpenResourceDialog.prototype.itemsCount):
(WebInspector.OpenResourceDialog.prototype.requestItems):
(WebInspector.OpenResourceDialog.prototype.selectItem):
(WebInspector.OpenScriptDialog):
(WebInspector.OpenScriptDialog.install):
(WebInspector.OpenScriptDialog._show):
(WebInspector.OpenScriptDialog.prototype.selectItem):
* inspector/front-end/ResourceUtils.js:
(WebInspector.ParsedURL):
* inspector/front-end/ScriptsPanel.js:
* inspector/front-end/StylesPanel.js:
(WebInspector.StylesPanel):
(WebInspector.StylesPanel.prototype._showOpenStylesheetDialog):
(WebInspector.OpenStylesheetDialog):
(WebInspector.OpenStylesheetDialog.prototype.selectItem):
* inspector/front-end/inspector.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd test function to get placeholder string
tkent@chromium.org [Mon, 23 Apr 2012 08:00:08 +0000 (08:00 +0000)]
Add test function to get placeholder string
https://bugs.webkit.org/show_bug.cgi?id=84536

Reviewed by Ryosuke Niwa.

.:

* Source/autotools/symbols.filter:
Expose Node::textContent and HTMLTextFormControlElement::placeholderShouldBeVisible.

Source/WebCore:

Add window.internals.visiblePlaceholder(element), which returns a
placeholder string only when it's visible.

* WebCore.exp.in: Expose HTMLTextFormControlElement::placeholderShouldBeVisible().
* testing/Internals.cpp:
(WebCore::Internals::visiblePlaceholder): Added.
(WebCore::Internals::selectColorInColorChooser): Omit HTMLNames::.
* testing/Internals.h:
(Internals): Add visiblePlaceholder().
* testing/Internals.idl: ditto.

Source/WebKit2:

* win/WebKit2.def: Expose HTMLNames::inputTag,
HTMLTextFormControlElement::placeholderShouldBeVisible(), and
Node::textContent.
* win/WebKit2CFLite.def: ditto.

LayoutTests:

Make placeholder-stripped.html a dumpAsText test.

* fast/forms/placeholder-stripped-expected.html: Removed.
* fast/forms/placeholder-stripped-expected.txt: Added.
* fast/forms/placeholder-stripped.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: Incorrect handling of CSS escape sequences that encode surrogates
commit-queue@webkit.org [Mon, 23 Apr 2012 07:47:39 +0000 (07:47 +0000)]
Source/WebCore: Incorrect handling of CSS escape sequences that encode surrogates
https://bugs.webkit.org/show_bug.cgi?id=76152

Patch by Szilard Ledan <szledan@inf.u-szeged.hu> on 2012-04-23
Reviewed by Kent Tamura.

Test: fast/css/parsing-css-surrogate-pairs.html

* css/CSSParser.cpp:
(WebCore::CSSParser::parseEscape):

LayoutTests: Added a test for css surrogate pairs parser
https://bugs.webkit.org/show_bug.cgi?id=76152

Patch by Szilard Ledan <szledan@inf.u-szeged.hu> on 2012-04-23
Reviewed by Kent Tamura.

* fast/css/parsing-css-surrogate-pairs-expected.txt: Added.
* fast/css/parsing-css-surrogate-pairs.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Make DRT not dump pixel results if test is calling layoutTestController.dumpAsText()
commit-queue@webkit.org [Mon, 23 Apr 2012 07:10:29 +0000 (07:10 +0000)]
[Qt] Make DRT not dump pixel results if test is calling layoutTestController.dumpAsText()
https://bugs.webkit.org/show_bug.cgi?id=84327

Patch by Milian Wolff <mail@milianw.de> on 2012-04-23
Reviewed by Csaba Osztrogon√°c.

* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::dump):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd Notification constructor
ossy@webkit.org [Mon, 23 Apr 2012 06:37:47 +0000 (06:37 +0000)]
Add Notification constructor
https://bugs.webkit.org/show_bug.cgi?id=80477

[Qt] Unreviewed gardening after r114855.

* platform/qt-4.8/fast/dom/Window/window-properties-expected.txt:
* platform/qt-5.0-wk2/fast/dom/Window/window-properties-expected.txt:
* platform/qt-5.0-wk2/fast/dom/prototype-inheritance-2-expected.txt:
* platform/qt-5.0/fast/dom/Window/window-properties-expected.txt:
* platform/qt-5.0/fast/dom/prototype-inheritance-2-expected.txt:
* platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
* platform/qt/fast/js/global-constructors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, add a baseline for computed style test after r114766.
zandobersek@gmail.com [Mon, 23 Apr 2012 06:30:12 +0000 (06:30 +0000)]
Unreviewed, add a baseline for computed style test after r114766.

* platform/gtk/fast/css/getComputedStyle/computed-style-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: make populateChildren methods private in heap profiler front-end
yurys@chromium.org [Mon, 23 Apr 2012 06:16:49 +0000 (06:16 +0000)]
Web Inspector: make populateChildren methods private in heap profiler front-end
https://bugs.webkit.org/show_bug.cgi?id=84562

Source/WebCore:

- populateChildren method on HeapSnapshotConstructorsDataGrid and
HeapSnapshotDiffDataGrid now is private.
- Made _defaultPopulateCount a public method on HeapSnapshotSortableDataGrid which
is overriden in some descendants
- Removed unused HeapSnapshotPathFinderProxy
- added closure compiler annotations

Reviewed by Pavel Feldman.

* inspector/front-end/HeapSnapshotDataGrids.js:
(WebInspector.HeapSnapshotSortableDataGrid.prototype.defaultPopulateCount):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype.setDataSource):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype._filterSelectIndexChanged):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.defaultPopulateCount):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.setBaseDataSource):
(WebInspector.HeapSnapshotDominatorsDataGrid.prototype.defaultPopulateCount):
* inspector/front-end/HeapSnapshotGridNodes.js:
(WebInspector.HeapSnapshotGridNode):
(WebInspector.HeapSnapshotGridNode.prototype.populateChildren.callSerialize):
(WebInspector.HeapSnapshotDiffNode):
(WebInspector.HeapSnapshotDiffNode.prototype.populateChildren.firstProviderPopulated):
* inspector/front-end/HeapSnapshotProxy.js:

LayoutTests:

- Made _defaultPopulateCount a public method on HeapSnapshotSortableDataGrid which
is overriden in some descendants

Reviewed by Pavel Feldman.

* inspector/profiler/heap-snapshot-test.js:
(initialize_HeapSnapshotTest.InspectorTest.startProfilerTest.detailedHeapProfilesEnabled.WebInspector.HeapSnapshotContainmentDataGrid.prototype.defaultPopulateCount):
(initialize_HeapSnapshotTest.InspectorTest.startProfilerTest.detailedHeapProfilesEnabled.WebInspector.HeapSnapshotConstructorsDataGrid.prototype.defaultPopulateCount):
(initialize_HeapSnapshotTest.InspectorTest.startProfilerTest.detailedHeapProfilesEnabled.WebInspector.HeapSnapshotDiffDataGrid.prototype.defaultPopulateCount):
(initialize_HeapSnapshotTest.InspectorTest.startProfilerTest.detailedHeapProfilesEnabled.WebInspector.HeapSnapshotDominatorsDataGrid.prototype.defaultPopulateCount):
(initialize_HeapSnapshotTest.InspectorTest.startProfilerTest.detailedHeapProfilesEnabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed build fix, remove Attribute.cpp from DOMAllInOne.cpp.
kling@webkit.org [Mon, 23 Apr 2012 05:59:55 +0000 (05:59 +0000)]
Unreviewed build fix, remove Attribute.cpp from DOMAllInOne.cpp.

* dom/DOMAllInOne.cpp: My nemesis.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoOptimize Element attribute storage for the common case (no Attr objects.)
kling@webkit.org [Mon, 23 Apr 2012 05:40:02 +0000 (05:40 +0000)]
Optimize Element attribute storage for the common case (no Attr objects.)
<http://webkit.org/b/83440>

Reviewed by Antti Koivisto.

Source/WebCore:

Reduce Attribute to its smallest possible size; a qname/value pair.
They are no-longer ref-counted, which allows us to store them in Vectors.

Refactored the DOM Attr object to go with the new Attribute:
Attr now wraps either {element, qname} or {qname, value}. The latter is for
the case where a standalone Attr object is instantiated via DOM APIs.

ElementAttributeData.cpp manages a map of pair<element, qname> => Attr.
Each Element (well, ElementAttributeData) keeps track of how many Attr
objects are pointing to it. This is so we can avoid hash lookups during
common operations in the typical case where you have zero Attrs.

Also removed the inline capacity (was 4) from AttributeVector as that
would significantly increase bloat now that we store Attribute (2 pointers)
rather than RefPtr<Attribute>. We trade this one piece of indirection
for the removal of per-Attribute indirection.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/Attr.cpp:
(WebCore::Attr::Attr):
(WebCore):
(WebCore::Attr::create):
(WebCore::Attr::~Attr):
(WebCore::Attr::createTextChild):
(WebCore::Attr::setPrefix):
(WebCore::Attr::setValue):
(WebCore::Attr::cloneNode):
(WebCore::Attr::childrenChanged):
(WebCore::Attr::style):
(WebCore::Attr::value):
(WebCore::Attr::elementAttribute):
(WebCore::Attr::detachFromElementWithValue):
(WebCore::Attr::attachToElement):
* dom/Attr.h:
(WebCore):
(Attr):
(WebCore::Attr::qualifiedName):
(WebCore::Attr::localName):
(WebCore::Attr::namespaceURI):
(WebCore::Attr::prefix):
* dom/Attribute.cpp: Removed.
* dom/Attribute.h:
(WebCore::Attribute::Attribute):
(Attribute):
* dom/Document.cpp:
(WebCore::Document::importNode):
(WebCore::Document::createAttributeNS):
* dom/Element.cpp:
(WebCore::Element::~Element):
(WebCore::Element::detachAttribute):
(WebCore):
(WebCore::Element::removeAttribute):
(WebCore::Element::setAttributeInternal):
(WebCore::Element::parserSetAttributes):
(WebCore::Element::setAttributeNode):
(WebCore::Element::removeAttributeNode):
(WebCore::Element::normalizeAttributes):
(WebCore::Element::didRemoveAttribute):
(WebCore::Element::attrIfExists):
(WebCore::Element::ensureAttr):
* dom/Element.h:
(Element):
(WebCore::Element::getAttributeItemIndex):
* dom/ElementAttributeData.cpp:
(WebCore):
(WebCore::attrMap):
(WebCore::ElementAttributeData::attrIfExists):
(WebCore::ElementAttributeData::ensureAttr):
(WebCore::ElementAttributeData::setAttr):
(WebCore::ElementAttributeData::removeAttr):
(WebCore::AttributeVector::removeAttribute):
(WebCore::ElementAttributeData::~ElementAttributeData):
(WebCore::ElementAttributeData::addAttribute):
(WebCore::ElementAttributeData::removeAttribute):
(WebCore::ElementAttributeData::isEquivalent):
(WebCore::ElementAttributeData::detachAttributesFromElement):
(WebCore::ElementAttributeData::getAttributeItemIndexSlowCase):
(WebCore::ElementAttributeData::setAttributes):
(WebCore::ElementAttributeData::clearAttributes):
(WebCore::ElementAttributeData::replaceAttribute):
(WebCore::ElementAttributeData::getAttributeNode):
* dom/ElementAttributeData.h:
(WebCore):
(WebCore::AttributeVector::AttributeVector):
(AttributeVector):
(WebCore::AttributeVector::getAttributeItem):
(WebCore::AttributeVector::getAttributeItemIndex):
(WebCore::AttributeVector::insertAttribute):
(WebCore::ElementAttributeData::attributeItem):
(ElementAttributeData):
(WebCore::ElementAttributeData::ElementAttributeData):
(WebCore::ElementAttributeData::attributeVector):
(WebCore::ElementAttributeData::clonedAttributeVector):
(WebCore::ElementAttributeData::removeAttribute):
(WebCore::ElementAttributeData::getAttributeItem):
(WebCore::ElementAttributeData::getAttributeItemIndex):
* dom/NamedNodeMap.cpp:
(WebCore::NamedNodeMap::getNamedItem):
(WebCore::NamedNodeMap::getNamedItemNS):
(WebCore::NamedNodeMap::removeNamedItem):
(WebCore::NamedNodeMap::removeNamedItemNS):
(WebCore::NamedNodeMap::item):
* dom/Node.cpp:
(WebCore::Node::compareDocumentPosition):
* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::parseAttribute):
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::parseAttribute):
* html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagBeforeHTML):
(WebCore::HTMLConstructionSite::mergeAttributesFromTokenIntoElement):
(WebCore::HTMLConstructionSite::insertScriptElement):
(WebCore::HTMLConstructionSite::createElement):
(WebCore::HTMLConstructionSite::createHTMLElement):
(WebCore::HTMLConstructionSite::createHTMLElementFromSavedElement):
* html/parser/HTMLToken.h:
(WebCore::AtomicHTMLToken::AtomicHTMLToken):
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processFakeStartTag):
(WebCore::HTMLTreeBuilder::attributesForIsindexInput):
(WebCore::HTMLTreeBuilder::processIsindexStartTagForInBody):
(WebCore):
(WebCore::HTMLTreeBuilder::processStartTagForInBody):
* html/parser/HTMLTreeBuilder.h:
* html/parser/TextDocumentParser.cpp:
(WebCore::TextDocumentParser::insertFakePreElement):
* page/PageSerializer.cpp:
(WebCore::SerializerMarkupAccumulator::appendCustomAttributes):
* svg/SVGFitToViewBox.cpp:
* svg/properties/SVGAnimatedPropertySynchronizer.h:
* xml/XMLErrors.cpp:
(WebCore::createXHTMLParserErrorHeader):
(WebCore::XMLErrors::insertErrorMessageBlock):
* xml/XPathNodeSet.cpp:
(WebCore::XPath::NodeSet::traversalSort):
* xml/XPathStep.cpp:
(WebCore::XPath::Step::nodesInAxis):
* xml/parser/MarkupTokenBase.h:
(WebCore::AtomicMarkupTokenBase::AtomicMarkupTokenBase):
(WebCore::AtomicMarkupTokenBase::getAttributeItem):
(WebCore::AtomicMarkupTokenBase::attributes):
(AtomicMarkupTokenBase):
(WebCore::::initializeAttributes):
* xml/parser/XMLToken.h:
(WebCore::AtomicXMLToken::AtomicXMLToken):
* xml/parser/XMLTreeBuilder.cpp:
(WebCore::XMLTreeBuilder::processNamespaces):
(WebCore::XMLTreeBuilder::processAttributes):

Source/WebKit/chromium:

Remove the WebNamedNodeMap and WebAttribute API classes since they are no
longer needed by chromium after <http://crrev.com/133299>.

* WebKit.gyp:
* public/WebAttribute.h: Removed.
* public/WebElement.h:
* public/WebNamedNodeMap.h: Removed.
* src/WebAttribute.cpp: Removed.
* src/WebElement.cpp:
* src/WebNamedNodeMap.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago.: [Gtk] Added MOZ_X11 build flag for TARGET_X11
commit-queue@webkit.org [Mon, 23 Apr 2012 05:30:39 +0000 (05:30 +0000)]
.: [Gtk] Added MOZ_X11 build flag for TARGET_X11
[Qt]  Added MOZ_X11 build flag for !embedded
[CMake]  Added MOZ_X11 build flag for WTF_OS_UNIX
https://bugs.webkit.org/show_bug.cgi?id=40785

Patch by Sriram Neelakandan <sriram.neelakandan@gmail.com> on 2012-04-22
Reviewed by Anders Carlsson.

* GNUmakefile.am:
* Source/cmake/OptionsCommon.cmake:

Source/WebCore: Sync the MOZ_X11 changes from r14 of http://code.google.com/p/npapi-sdk/
also, modified required build flags for Qt,Gtk and CMake
[Qt]  Added MOZ_X11 build flag for !embedded
https://bugs.webkit.org/show_bug.cgi?id=40785

Patch by Sriram Neelakandan <sriram.neelakandan@gmail.com> on 2012-04-22
Reviewed by Anders Carlsson.

No new tests. This does not change functionality. Affects all X11 Ports. Build should break if MOZ_X11 is not passed where required

* WebCore.pri:
* plugins/npapi.h:

Source/WebKit2: [Gtk] Added MOZ_X11 build flag for TARGET_X11
[Qt]  Added MOZ_X11 build flag for !embedded
https://bugs.webkit.org/show_bug.cgi?id=40785

Patch by Sriram Neelakandan <sriram.neelakandan@gmail.com> on 2012-04-22
Reviewed by Anders Carlsson.

* GNUmakefile.am:
* Target.pri:

Tools: [Gtk] Added MOZ_X11 build flag for TARGET_X11
https://bugs.webkit.org/show_bug.cgi?id=40785

Patch by Sriram Neelakandan <sriram.neelakandan@gmail.com> on 2012-04-22
Reviewed by Anders Carlsson.

* GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[TestResultsServer] Impossible to inspect builds on non-Chromium builders
zandobersek@gmail.com [Mon, 23 Apr 2012 05:22:58 +0000 (05:22 +0000)]
[TestResultsServer] Impossible to inspect builds on non-Chromium builders
https://bugs.webkit.org/show_bug.cgi?id=84544

Reviewed by Ryosuke Niwa.

Use the groupEnum parameter that is passed through to the onBuilderListLoad
function rather than an undefined attribute of the BuilderGroup object. This
makes it again possible to inspect builds on non-Chromium builders in the
test results server by not trying to always add Chromium revision links.

* TestResultServer/static-dashboards/builders.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReset event propagation and canceled flags in Event.initEvent
commit-queue@webkit.org [Mon, 23 Apr 2012 05:19:46 +0000 (05:19 +0000)]
Reset event propagation and canceled flags in Event.initEvent
https://bugs.webkit.org/show_bug.cgi?id=83964

Patch by Pablo Flouret <pablof@motorola.com> on 2012-04-22
Reviewed by Ryosuke Niwa.

Step 3 in http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#dom-event-initevent
Useful for re-configuring an event before dispatching.

Source/WebCore:

Test: fast/events/flags-unset-on-init-event.html

* dom/Event.cpp:
(WebCore::Event::initEvent):

LayoutTests:

* fast/events/flags-unset-on-init-event-expected.txt: Added.
* fast/events/flags-unset-on-init-event.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReplace an undefined variable with a constant
hbono@chromium.org [Mon, 23 Apr 2012 04:48:58 +0000 (04:48 +0000)]
Replace an undefined variable with a constant
https://bugs.webkit.org/show_bug.cgi?id=84427

Reviewed by Ryosuke Niwa.

Unfortunately, my r114605 uses an undefined variable 'sleepPeriod' and it
causes a JavaScript exception. This change replaces this variable with 1.

* platform/chromium/editing/spelling/delete-misspelled-word.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Remove the obsolete Hildon UI extensions
commit-queue@webkit.org [Mon, 23 Apr 2012 02:13:52 +0000 (02:13 +0000)]
[GTK] Remove the obsolete Hildon UI extensions
https://bugs.webkit.org/show_bug.cgi?id=83420

Patch by Adrian Bunk <bunk@stusta.de> on 2012-04-22
Reviewed by Martin Robinson.

.:

* configure.ac:

Source/WebKit/gtk:

* GNUmakefile.am:
* WebCoreSupport/EditorClientGtk.cpp:
(WebKit::EditorClient::setInputMethodState):
* webkit/webkitwebview.cpp:
(webkit_web_view_button_release_event):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Cairo] Implement CompositeDifference
mrobinson@webkit.org [Mon, 23 Apr 2012 00:56:59 +0000 (00:56 +0000)]
[Cairo] Implement CompositeDifference
https://bugs.webkit.org/show_bug.cgi?id=77354

Reviewed by Alejandro G. Castro.

No new tests. The difference compositing operator are not exposed
to web content, so this change is simply in preparation for a time
in which it is used.

Properly map the difference compositing blend modes to a Cairo operator.

* platform/graphics/cairo/CairoUtilities.cpp:
(WebCore::toCairoOperator): Add a mapping for difference. Remove
code supporting versions of Cairo before 1.10, since the Cairo backend
requires 1.10 or greater already.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove notifications support on Mac Lion.
jonlee@apple.com [Sun, 22 Apr 2012 23:01:53 +0000 (23:01 +0000)]
Remove notifications support on Mac Lion.
https://bugs.webkit.org/show_bug.cgi?id=84554
<rdar://problem/11297128>

Reviewed by Sam Weinig.

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Fix clang build after r114827, unreviewed.
mnaganov@chromium.org [Sun, 22 Apr 2012 22:27:18 +0000 (22:27 +0000)]
[Chromium] Fix clang build after r114827, unreviewed.

* tests/LayerTextureUpdaterTest.cpp:
(WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Unreviewed test expectations update.
mnaganov@chromium.org [Sun, 22 Apr 2012 21:27:38 +0000 (21:27 +0000)]
[Chromium] Unreviewed test expectations update.

Mark fast/canvas/2d.text.draw.fill.maxWidth.gradient.html as flaky on Mac 10.6

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Unreviewed test expectations update.
mnaganov@chromium.org [Sun, 22 Apr 2012 21:17:20 +0000 (21:17 +0000)]
[Chromium] Unreviewed test expectations update.

fast/workers/storage/interrupt-database.html can also TIMEOUT in debug.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Unreviewed test expectations update.
mnaganov@chromium.org [Sun, 22 Apr 2012 21:06:58 +0000 (21:06 +0000)]
[Chromium] Unreviewed test expectations update.

css3/zoom-coords-expected.txt now passes on Mac
According to bot logs this is after <http://trac.webkit.org/changeset/114813>

* platform/chromium-mac/css3/zoom-coords-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Damage Tracker needs to use CCMathUtil transforms
shawnsingh@chromium.org [Sun, 22 Apr 2012 20:22:24 +0000 (20:22 +0000)]
[chromium] Damage Tracker needs to use CCMathUtil transforms
https://bugs.webkit.org/show_bug.cgi?id=84070

Reviewed by Adrienne Walker.

Source/WebCore:

Unit test added to CCDamageTracker.cpp.

This patch makes CCDamageTracker use CCMathUtil transforms, so
that perspective w < 0 problem is correctly handled.

* platform/graphics/chromium/cc/CCDamageTracker.cpp:
(WebCore::CCDamageTracker::extendDamageForLayer):
(WebCore::CCDamageTracker::extendDamageForRenderSurface):

Source/WebKit/chromium:

* tests/CCDamageTrackerTest.cpp:
(WebKitTests::TEST_F):
(WebKitTests):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Multi-level tap-to-zoom.
commit-queue@webkit.org [Sun, 22 Apr 2012 16:43:27 +0000 (16:43 +0000)]
[Qt] Multi-level tap-to-zoom.
https://bugs.webkit.org/show_bug.cgi?id=84456

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-22
Reviewed by Kenneth Rohde Christiansen.

Replace tap-to-zoomed flag with a stack of progressively higher zoom levels,
and zoom out to last zoom-level when attempting to zoom to current level.

Additionally detect a series of tap-to-zoom gestures on the same level and
continue to zoom out.

* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::QtViewportInteractionEngine):
(WebKit::QtViewportInteractionEngine::zoomToAreaGestureEnded):
(WebKit::QtViewportInteractionEngine::pinchGestureStarted):
* UIProcess/qt/QtViewportInteractionEngine.h:
(QtViewportInteractionEngine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd Notification constructor
jonlee@apple.com [Sun, 22 Apr 2012 00:18:23 +0000 (00:18 +0000)]
Add Notification constructor
https://bugs.webkit.org/show_bug.cgi?id=80477
<rdar://problem/10912431>

Reviewed by Jian Li.

Source/WebCore:

Tests will be added once there is support for web notifications on the Mac ports.

* WebCore.exp.in: Export finalize() function.

Modify Dictionary to support creation of event listeners.
* bindings/js/Dictionary.h:
(WebCore::Dictionary::isObject): Return true if the JSDictionary is valid.
(WebCore::Dictionary::isUndefinedOrNull): Return true if the JSDictionary is not valid.
(WebCore::Dictionary::get): Add convenience function to take const char* for
property name, to prevent having to do implicit conversion to WTF::String.
(WebCore::Dictionary::getEventListener): Add function to create event listener
from the dictionary.
(WebCore::Dictionary::asJSObject): Helper to convert WebCore objects to JS wrapper.
* bindings/js/Dictionary.cpp:
(WebCore::Notification): Implement asJSObject() for Notification.
* bindings/js/JSDictionary.h:
(WebCore::JSDictionary::execState): Expose the exec state so that the Dictionary
can obtain its world for creating the event listener.

* bindings/v8/Dictionary.h:
(WebCore::Dictionary::getEventListener): Stub implementation.

Add new constructor to idl definitions.
* notifications/DOMWindowNotifications.idl: Add Notification constructor, if
ENABLE(NOTIFICATIONS) is on.
* notifications/Notification.idl: If ENABLE(NOTIFICATIONS) is turned on, define
the constructor. Otherwise, use OmitConstructor.
* notifications/NotificationCenter.idl: Wrap creation functions in
ENABLE(LEGACY_NOTIFICATIONS).
* notifications/NotificationCenter.h: Ditto.
(NotificationCenter):

* notifications/Notification.h:
(Notification): Wrap legacy constructors in ENABLE(LEGACY_NOTIFICATIONS).
(WebCore::Notification::create): New creation function based on discussions in WG.
* notifications/Notification.cpp:
(WebCore::getAndAddEventListener): Helper function to get the listener from the
dictionary, and attach to the notification.
(WebCore::Notification::create): Create the notification, then apply whatever
properties can be found in the dictionary to the notification. In order to
attach the event listeners, the notification has to have been created, which is
why this all happens in the factory method and not in the constructor.
(WebCore::Notification::setBody): Added so that it can be set if we find it in the
dictionary.

The new constructor queues a task to show when it is created. To support this, we
use a one-shot timer that calls show() in the next iteration of the run loop.
(WebCore::Notification::Notification): Start the timer.
(WebCore::Notification::showTaskTimerFired): Call show().

Notifications, not being attached to the DOM, could be GC'ed by the JS engine
before its life cycle has completed. We add calls to setPendingActivity() when the
notification has been shown, and when it is closed, we unsetPendingActivity().
To guarantee that we only call this once, we add a new state to the Notification
state machine, called NotificationState::Closed.
(WebCore::Notification::show): Call setPendingActivity() for all ports. Remove conditional on Mac.
(WebCore::Notification::close): Include Closed state to machine; do nothing.
(WebCore::Notification::dispatchCloseEvent): Call finalize().
(WebCore::Notification::finalize): If the state is not Closed, we unsetPendingActivity()
to make it available for GC.
(WebCore::Notification::finishLoading): Remove the unsetPendingActivity(). That call
was to balance the setPendingActivity() called for loading the icon. Instead of wrapping
around the icon load, we wrap around the show() -> finalize() loop.

In Notification, rename some of the stages and functions to more clearly communicate
that they mostly deal with the icon of the notification, instead of general loading.
(WebCore::Notification::show): Refactored to use LoadingIcon and CancelledIcon.
(WebCore::Notification::close): Refactored to use LoadingIcon and CancelledIcon.
(WebCore::Notification::~Notification): Refactor to use LoadingIcon.
(WebCore::Notification::startLoadingIcon): Renamed from startLoading().
(WebCore::Notification::stopLoadingIcon): Renamed from stopLoading().
(WebCore::Notification::finishLoadingIcon): Renamed from finishLoading().
(WebCore::Notification::didFinishLoading):
(WebCore::Notification::didFail):
(WebCore::Notification::didFailRedirectCheck):
(WebCore::Notification::didReceiveResponse):
(WebCore::Notification::finishLoading):

Add Dictionary.cpp.
* GNUmakefile.list.am:
* Target.pri:
* UseJSC.cmake:
* WebCore.gypi:

Fix bug in V8 bindings generation code. If the constructor doesn't raise an exception,
don't use an exception code.
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateParametersCheck):
* bindings/scripts/test/V8/V8TestObj.cpp: Reset results.
(WebCore::TestObjV8Internal::optionsObjectCallback):

Source/WebKit/mac:

* WebCoreSupport/WebNotificationClient.mm:
(WebNotificationClient::clearNotifications): When clearing notifications, finalize
them so that they can be cleaned up by the GC.

Source/WebKit2:

* WebProcess/Notifications/WebNotificationManager.cpp:
(WebKit::WebNotificationManager::show): If the notification doesn't get shown,
we should return false, since it will not go through a setPendingActivity cycle.
(WebKit::WebNotificationManager::clearNotifications): When clearing notifications,
finalize them so that they can be cleaned up by the GC.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDon't hard code the plugins that blackberry supports.
commit-queue@webkit.org [Sat, 21 Apr 2012 23:19:00 +0000 (23:19 +0000)]
Don't hard code the plugins that blackberry supports.
https://bugs.webkit.org/show_bug.cgi?id=84535

Use the existing PluginDatabase to query for the plugins we can handle.

The original implemention of FrameLoaderClientBlackBerry::createPlugin
was a partial copy from another port.  In the Qt port there is some
workarounds for flash which is why this exists there.  Sadly the bits
that were copied made it so only flash worked, but as flash was the only
plugin on the system this issue was not noticed until QNX tried to get
jnext working.  Tracing it down to this bit of code rather then
correcting it they hardcoded the jnext into the same block as flash was.

The blackberry port isn't specifically suppose to only allow jnext and
flash, but was an accident due to the way this code was developed.

Patch by Benjamin C Meyer <bmeyer@rim.com> on 2012-04-21
Reviewed by Adam Treat.

* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::createPlugin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSupport loading the same plugin in multiple locations in the Blackberry port.
commit-queue@webkit.org [Sat, 21 Apr 2012 22:40:25 +0000 (22:40 +0000)]
Support loading the same plugin in multiple locations in the Blackberry port.
https://bugs.webkit.org/show_bug.cgi?id=84537

The hash for the plugin is only based upon the plugin meta information
which will be the same for the same plugin in the system and user's
plugin folders.

It looks like this code was copied/based on the windows port
which doesn't allow the same plugin to be loaded more than once.

Because we want to support multiple copies of the same plugin
in the blackberry port we want to incorperate the path of the plugin
into the hash.

PR 150404

Patch by Benjamin C Meyer <bmeyer@rim.com> on 2012-04-21
Reviewed by Adam Treat.

* plugins/blackberry/PluginPackageBlackBerry.cpp:
(WebCore::PluginPackage::hash):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoChromium roll attempt from r133173 to r133348.
rniwa@webkit.org [Sat, 21 Apr 2012 22:02:07 +0000 (22:02 +0000)]
Chromium roll attempt from r133173 to r133348.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSystem plugins are preferred over application plugins
commit-queue@webkit.org [Sat, 21 Apr 2012 20:11:22 +0000 (20:11 +0000)]
System plugins are preferred over application plugins
https://bugs.webkit.org/show_bug.cgi?id=84538

Set the preferred paths for plugins so that plugins that reside
inside of the bar will be preferred over plugins that are in the
system folder.

PR 150404

Patch by Benjamin C Meyer <bmeyer@rim.com> on 2012-04-21
Reviewed by Adam Treat.

* plugins/PluginDatabase.cpp:
(WebCore::PluginDatabase::isPreferredPluginDirectory):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoChange JavaScript lexer to use 0 instead of -1 for sentinel, eliminating the need...
darin@apple.com [Sat, 21 Apr 2012 20:03:13 +0000 (20:03 +0000)]
Change JavaScript lexer to use 0 instead of -1 for sentinel, eliminating the need to put characters into ints
https://bugs.webkit.org/show_bug.cgi?id=84523

Reviewed by Oliver Hunt.

Profiles showed that checks against -1 were costly, and I saw they could be eliminated.
Streamlined this code to use standard character types and 0 rather than -1. One benefit
of this is that there's no widening and narrowing. Another is that there are many cases
where we already have the correct behavior for 0, so can eliminate a branch that was
used to test for -1 before. Also eliminates typecasts in the code.

* parser/Lexer.cpp:
(JSC::Lexer::invalidCharacterMessage): Updated use of String::format since m_current is now a
character type, not an int.
(JSC::Lexer::setCode): Use 0 rather than -1 when past the end.
(JSC::Lexer::shift): Ditto. Also spruced up the comment a bit.
(JSC::Lexer::atEnd): Added. New function that distinguishes an actual 0 character from the end
of the code. This can be used places we used to cheeck for -1.
(JSC::Lexer::peek): Updated to use -1 instead of 0. Removed meaningless comment.
(JSC::Lexer::parseFourDigitUnicodeHex): Changed to use character types instead of int.
(JSC::Lexer::shiftLineTerminator): Removed now-unneeded type casts. Changed local variable that
had a data-member-style name.
(JSC::Lexer::parseIdentifier): Removed now-unneeded explicit checks for -1, since the isIdentPart
function already returns false for the 0 character. Updated types in a couple other places. Used
the atEnd function where needed.
(JSC::Lexer::parseIdentifierSlowCase): More of the same.
(JSC::characterRequiresParseStringSlowCase): Added overloaded helper function for parseString.
(JSC::Lexer::parseString): Ditto.
(JSC::Lexer::parseStringSlowCase): Ditto.
(JSC::Lexer::parseMultilineComment): Ditto.
(JSC::Lexer::lex): More of the same. Also changed code to set the startOffset directly in
the tokenInfo instead of putting it in a local variable first, saving some memory access.
(JSC::Lexer::scanRegExp): Ditto.
(JSC::Lexer::skipRegExp): Ditto.

* parser/Lexer.h: Changed return type of the peek function and type of m_current from int to
the character type. Added atEnd function.
(JSC::Lexer::setOffset): Used 0 instead of -1 and removed an overzealous attempt to optimize.
(JSC::Lexer::lexExpectIdentifier): Used 0 instead of -1.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoChange JavaScript lexer to use 0 instead of -1 for sentinel, eliminating the need...
darin@apple.com [Sat, 21 Apr 2012 19:46:02 +0000 (19:46 +0000)]
Change JavaScript lexer to use 0 instead of -1 for sentinel, eliminating the need to put characters into ints
https://bugs.webkit.org/show_bug.cgi?id=84523

Reviewed by Oliver Hunt.

Separate preparation step of copyright dates, renaming, and other small tweaks.

* parser/Lexer.cpp:
(JSC::Lexer::invalidCharacterMessage): Removed "get" from name to match WebKit naming conventions.
(JSC::Lexer::peek): Removed meaningless comment.
(JSC::Lexer::parseFourDigitUnicodeHex): Renamed from getUnicodeCharacter to be more precise about
what this function does.
(JSC::Lexer::shiftLineTerminator): Renamed local variable that had a data-member-style name.
(JSC::Lexer::parseStringSlowCase): Updated for new name of parseFourDigitUnicodeHex.
(JSC::Lexer::lex): Updated for new name of invalidCharacterMessage.

* parser/Lexer.h: Removed an unneeded forward declaration of the RegExp class.
Renamed getInvalidCharMessage to invalidCharacterMessage and made it const. Renamed
getUnicodeCharacter to parseFourDigitUnicodeHex.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImprove performance of removing user and password from URLs
darin@apple.com [Sat, 21 Apr 2012 16:43:25 +0000 (16:43 +0000)]
Improve performance of removing user and password from URLs
https://bugs.webkit.org/show_bug.cgi?id=84525

Reviewed by Dan Bernstein.

Performance improvement only. Correctness covered by existing regression tests.

The most common use of KURL::setUser and KURL::setPass, by far, is to remove
the user and password from a URL that already has neither. Optimize this by
not re-parsing the URL in that case.

* platform/KURL.cpp:
(WebCore::KURL::setUser): Restructure code so that the code path that removes
the user does no work when there is nothing to remove. Otherwise, leave the
logic of the function untouched.
(WebCore::KURL::setPass): Same thing, only for password rather than user.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed - move some expectations added in r114839 to their proper location.
zandobersek@gmail.com [Sat, 21 Apr 2012 10:46:53 +0000 (10:46 +0000)]
Unreviewed - move some expectations added in r114839 to their proper location.

* platform/gtk/css2.1/20110323/abspos-containing-block-initial-007-expected.txt: Copied from LayoutTests/platform/gtk/css2.1/abspos-containing-block-initial-007-expected.txt.
* platform/gtk/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.txt: Copied from LayoutTests/platform/gtk/css2.1/abspos-non-replaced-width-margin-000-expected.txt.
* platform/gtk/css2.1/20110323/abspos-replaced-width-margin-000-expected.txt: Copied from LayoutTests/platform/gtk/css2.1/abspos-replaced-width-margin-000-expected.txt.
* platform/gtk/css2.1/abspos-containing-block-initial-007-expected.txt: Removed.
* platform/gtk/css2.1/abspos-non-replaced-width-margin-000-expected.txt: Removed.
* platform/gtk/css2.1/abspos-replaced-width-margin-000-expected.txt: Removed.
* platform/gtk/tables/bug137388-2-expected.txt: Removed.
* platform/gtk/tables/bug29314-expected.txt: Removed.
* platform/gtk/tables/mozilla/bugs/bug137388-2-expected.txt: Copied from LayoutTests/platform/gtk/tables/bug137388-2-expected.txt.
* platform/gtk/tables/mozilla/bugs/bug29314-expected.txt: Copied from LayoutTests/platform/gtk/tables/bug29314-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed weekend gardening, skip new failing reftests.
ossy@webkit.org [Sat, 21 Apr 2012 08:49:12 +0000 (08:49 +0000)]
[Qt] Unreviewed weekend gardening, skip new failing reftests.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening after r114766.
ossy@webkit.org [Sat, 21 Apr 2012 08:37:00 +0000 (08:37 +0000)]
Unreviewed gardening after r114766.

* fast/css/getComputedStyle/computed-style-expected.txt:
* fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/qt/svg/css/getComputedStyle-basic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRebaseline the last set of GTK+ tests after font metrics and mock scrollbar changes.
mrobinson@webkit.org [Sat, 21 Apr 2012 07:21:15 +0000 (07:21 +0000)]
Rebaseline the last set of GTK+ tests after font metrics and mock scrollbar changes.

* platform/gtk: Rebaseline tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, GTK svg rebaseline after r114799.
philn@webkit.org [Sat, 21 Apr 2012 06:24:48 +0000 (06:24 +0000)]
Unreviewed, GTK svg rebaseline after r114799.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r114768.
commit-queue@webkit.org [Sat, 21 Apr 2012 05:14:41 +0000 (05:14 +0000)]
Unreviewed, rolling out r114768.
http://trac.webkit.org/changeset/114768
https://bugs.webkit.org/show_bug.cgi?id=84521

Original patch was not the problem, re-applying (Requested by
pfeldman_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-20

* bindings/v8/V8IsolatedContext.cpp:
(WebCore::setInjectedScriptContextDebugId):
(WebCore):
(WebCore::V8IsolatedContext::V8IsolatedContext):
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::evaluateInIsolatedWorld):
* bindings/v8/V8Proxy.h:
(V8Proxy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRebaseline more GTK tests after <http://trac.webkit.org/changeset/114799>.
kov@webkit.org [Sat, 21 Apr 2012 03:07:52 +0000 (03:07 +0000)]
Rebaseline more GTK tests after <trac.webkit.org/changeset/114799>.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake the Web Inspector be the first responder when opening docked.
timothy@apple.com [Sat, 21 Apr 2012 02:51:15 +0000 (02:51 +0000)]
Make the Web Inspector be the first responder when opening docked.

<rdar://problem/11294217>

Reviewed by Brian Weinstein.

Source/WebKit/mac:

* WebCoreSupport/WebInspectorClient.mm:
(-[WebInspectorWindowController showWindow:]): Call makeFirstResponder: on
the window and pass the Inspector's WebView.

Source/WebKit2:

* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformAttach): Call makeFirstResponder: on
the window and pass the Inspector's WKView.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUndoing undesired changes.
kov@webkit.org [Sat, 21 Apr 2012 02:27:58 +0000 (02:27 +0000)]
Undoing undesired changes.

* fast/block/float/008-expected.txt:
* fast/block/float/019-expected.txt:
* fast/block/float/035-expected.txt:
* fast/block/float/relative-painted-twice-expected.txt:
* fast/block/positioning/negative-rel-position-expected.txt:
* fast/canvas/canvas-bg-expected.txt:
* fast/css-generated-content/table-parts-before-and-after-expected.txt:
* fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* fast/flexbox/flex-hang-expected.txt:
* fast/forms/file/get-file-upload-expected.txt:
* fast/forms/select/listbox-in-multi-column-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRebaseline more GTK fast tests after <http://trac.webkit.org/changeset/114799>.
kov@webkit.org [Sat, 21 Apr 2012 02:21:42 +0000 (02:21 +0000)]
Rebaseline more GTK fast tests after <trac.webkit.org/changeset/114799>.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRebaseline more GTK CSS3 and editing tests after <http://trac.webkit.org/changeset...
dbates@webkit.org [Sat, 21 Apr 2012 02:19:45 +0000 (02:19 +0000)]
Rebaseline more GTK CSS3 and editing tests after <trac.webkit.org/changeset/114799>.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRebaseline more GTK CSS2.1 tests after <http://trac.webkit.org/changeset/114799>.
dbates@webkit.org [Sat, 21 Apr 2012 02:10:00 +0000 (02:10 +0000)]
Rebaseline more GTK CSS2.1 tests after <trac.webkit.org/changeset/114799>.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRebaseline more GTK editing, fast tests after <http://trac.webkit.org/changeset/114799>.
kov@webkit.org [Sat, 21 Apr 2012 02:05:57 +0000 (02:05 +0000)]
Rebaseline more GTK editing, fast tests after <trac.webkit.org/changeset/114799>.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRebaseline more GTK CSS3 and animation tests after <http://trac.webkit.org/changeset...
dbates@webkit.org [Sat, 21 Apr 2012 02:01:00 +0000 (02:01 +0000)]
Rebaseline more GTK CSS3 and animation tests after <trac.webkit.org/changeset/114799>.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRebaseline more GTK CSS2.1 tests after <http://trac.webkit.org/changeset/114799>.
dbates@webkit.org [Sat, 21 Apr 2012 01:50:53 +0000 (01:50 +0000)]
Rebaseline more GTK CSS2.1 tests after <trac.webkit.org/changeset/114799>.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Refactor opaque content transform out of Skia context
enne@google.com [Sat, 21 Apr 2012 01:48:26 +0000 (01:48 +0000)]
[chromium] Refactor opaque content transform out of Skia context
https://bugs.webkit.org/show_bug.cgi?id=83608

Reviewed by James Robinson.

Source/WebCore:

Having PlatformContextSkia know about the transform into content space
for a layer is a layering violation. This change lets the
PlatformContextSkia deal with opaque rects in its own space and lets
the caller handle transforming it into its own space. This also
prevents a matrix multiply per draw into the Skia canvas and does it
just once at the end to transform the final rect.

This is an incremental refactoring so that additional tracking for
text rects can be added and use the same space as opaque rects.

Tests: LayerTextureUpdaterTest.testPartialOpaqueRectNoTransform
       LayerTextureUpdaterTest.testPartialOpaqueRectTranslation
       LayerTextureUpdaterTest.testPartialOpaqueRectScale

* platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.cpp:
(WebCore::BitmapCanvasLayerTextureUpdater::prepareToUpdate):
* platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.h:
(BitmapCanvasLayerTextureUpdater):
* platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.cpp:
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::prepareToUpdate):
* platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.h:
(BitmapSkPictureCanvasLayerTextureUpdater):
* platform/graphics/chromium/CanvasLayerTextureUpdater.cpp:
(WebCore::CanvasLayerTextureUpdater::paintContents):
* platform/graphics/chromium/CanvasLayerTextureUpdater.h:
(CanvasLayerTextureUpdater):
* platform/graphics/chromium/LayerTextureUpdater.h:
(WebCore::LayerTextureUpdater::prepareToUpdate):
* platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.cpp:
(WebCore::SkPictureCanvasLayerTextureUpdater::prepareToUpdate):
* platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.h:
(SkPictureCanvasLayerTextureUpdater):
* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::updateTiles):
* platform/graphics/skia/OpaqueRegionSkia.cpp:
(WebCore::OpaqueRegionSkia::didDrawRect):
(WebCore::OpaqueRegionSkia::didDrawPath):
(WebCore::OpaqueRegionSkia::didDrawPoints):
(WebCore::OpaqueRegionSkia::didDrawBounded):
(WebCore::OpaqueRegionSkia::didDraw):
* platform/graphics/skia/OpaqueRegionSkia.h:
(OpaqueRegionSkia):
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::didDrawRect):
(WebCore::PlatformContextSkia::didDrawPath):
(WebCore::PlatformContextSkia::didDrawPoints):
(WebCore::PlatformContextSkia::didDrawBounded):
* platform/graphics/skia/PlatformContextSkia.h:
(PlatformContextSkia):

Source/WebKit/chromium:

Add tests for opaque tracking in LayerTextureUpdater, since the
transform logic has moved there.

* tests/CCTiledLayerTestCommon.cpp:
(WebKitTests::FakeLayerTextureUpdater::prepareToUpdate):
* tests/CCTiledLayerTestCommon.h:
(FakeLayerTextureUpdater):
* tests/LayerTextureUpdaterTest.cpp:
(WebCore::PaintFillPartialOpaque::PaintFillPartialOpaque):
(PaintFillPartialOpaque):
(WebCore::PaintFillPartialOpaque::operator()):
(WebCore):
(WebCore::TEST):
* tests/PlatformContextSkiaTest.cpp:
(WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRebaseline more GTK editing, dom, fast tests after <http://trac.webkit.org/changeset...
kov@webkit.org [Sat, 21 Apr 2012 01:45:25 +0000 (01:45 +0000)]
Rebaseline more GTK editing, dom, fast tests after <trac.webkit.org/changeset/114799>.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRebaseline more GTK CSS3 tests after <http://trac.webkit.org/changeset/114799>.
dbates@webkit.org [Sat, 21 Apr 2012 01:43:10 +0000 (01:43 +0000)]
Rebaseline more GTK CSS3 tests after <trac.webkit.org/changeset/114799>.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRebaseline more GTK fast/block tests after <http://trac.webkit.org/changeset/114799>.
kov@webkit.org [Sat, 21 Apr 2012 01:36:16 +0000 (01:36 +0000)]
Rebaseline more GTK fast/block tests after <trac.webkit.org/changeset/114799>.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRebaseline more GTK css1 tests after <http://trac.webkit.org/changeset/114799>.
dbates@webkit.org [Sat, 21 Apr 2012 01:34:10 +0000 (01:34 +0000)]
Rebaseline more GTK css1 tests after <trac.webkit.org/changeset/114799>.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRebaseline more GTK css2.1 tests after <http://trac.webkit.org/changeset/114799>.
dbates@webkit.org [Sat, 21 Apr 2012 01:30:04 +0000 (01:30 +0000)]
Rebaseline more GTK css2.1 tests after <trac.webkit.org/changeset/114799>.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRebaseline more GTK css3 and editing tests after <http://trac.webkit.org/changeset...
kov@webkit.org [Sat, 21 Apr 2012 01:25:13 +0000 (01:25 +0000)]
Rebaseline more GTK css3 and editing tests after <trac.webkit.org/changeset/114799>.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRebaseline GTK fast/block tests after <http://trac.webkit.org/changeset/114799>.
dbates@webkit.org [Sat, 21 Apr 2012 01:22:24 +0000 (01:22 +0000)]
Rebaseline GTK fast/block tests after <trac.webkit.org/changeset/114799>.

* platform/gtk/fast/block/float/001-expected.txt:
* platform/gtk/fast/block/float/002-expected.txt:
* platform/gtk/fast/block/float/003-expected.txt:
* platform/gtk/fast/block/float/004-expected.txt:
* platform/gtk/fast/block/float/005-expected.txt:
* platform/gtk/fast/block/float/006-expected.txt:
* platform/gtk/fast/block/float/007-expected.txt:
* platform/gtk/fast/block/float/010-expected.txt:
* platform/gtk/fast/block/float/011-expected.txt:
* platform/gtk/fast/block/float/012-expected.txt:
* platform/gtk/fast/block/float/013-expected.txt:
* platform/gtk/fast/block/float/014-expected.txt:
* platform/gtk/fast/block/float/015-expected.txt:
* platform/gtk/fast/block/float/016-expected.txt:
* platform/gtk/fast/block/float/017-expected.txt:
* platform/gtk/fast/block/float/018-expected.txt:
* platform/gtk/fast/block/margin-collapse/001-expected.txt:
* platform/gtk/fast/block/margin-collapse/002-expected.txt:
* platform/gtk/fast/block/margin-collapse/003-expected.txt:
* platform/gtk/fast/block/margin-collapse/004-expected.txt:
* platform/gtk/fast/block/margin-collapse/005-expected.txt:
* platform/gtk/fast/block/margin-collapse/006-expected.txt:
* platform/gtk/fast/block/margin-collapse/block-inside-inline/001-expected.txt:
* platform/gtk/fast/block/margin-collapse/block-inside-inline/002-expected.txt:
* platform/gtk/fast/block/margin-collapse/block-inside-inline/003-expected.txt:
* platform/gtk/fast/block/margin-collapse/block-inside-inline/004-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRebasing fast/background results after r114799.
kov@webkit.org [Sat, 21 Apr 2012 01:17:52 +0000 (01:17 +0000)]
Rebasing fast/background results after r114799.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRebaseline more GTK css1 tests after <http://trac.webkit.org/changeset/114799>.
dbates@webkit.org [Sat, 21 Apr 2012 01:12:26 +0000 (01:12 +0000)]
Rebaseline more GTK css1 tests after <trac.webkit.org/changeset/114799>.

* platform/gtk/css1/box_properties/border_width_inline-expected.txt:
* platform/gtk/css1/box_properties/clear-expected.txt:
* platform/gtk/css1/box_properties/clear_float-expected.txt:
* platform/gtk/css1/box_properties/float-expected.txt:
* platform/gtk/css1/box_properties/float_margin-expected.txt:
* platform/gtk/css1/box_properties/float_on_text_elements-expected.txt:
* platform/gtk/css1/box_properties/height-expected.txt:
* platform/gtk/css1/box_properties/margin-expected.txt:
* platform/gtk/css1/box_properties/margin_bottom-expected.txt:
* platform/gtk/css1/box_properties/margin_bottom_inline-expected.txt:
* platform/gtk/css1/box_properties/margin_inline-expected.txt:
* platform/gtk/css1/box_properties/margin_left-expected.txt:
* platform/gtk/css1/box_properties/margin_left_inline-expected.txt:
* platform/gtk/css1/box_properties/margin_right-expected.txt:
* platform/gtk/css1/box_properties/margin_right_inline-expected.txt:
* platform/gtk/css1/box_properties/margin_top-expected.txt:
* platform/gtk/css1/box_properties/margin_top_inline-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCRASH at WebCore::ReplaceSelectionCommand::removeRedundantMarkup
enrica@apple.com [Sat, 21 Apr 2012 01:08:30 +0000 (01:08 +0000)]
CRASH at WebCore::ReplaceSelectionCommand::removeRedundantMarkup
https://bugs.webkit.org/show_bug.cgi?id=84518
<rdar://problem/10714790>

Reviewed by Simon Fraser.

Source/WebCore:

There are cases where the m_lastNodeInserted is NULL to begin with or
gets deleted by removeRedundantStylesAndKeepStyleSpanInline.
This change handles those cases properly.

Tests: editing/pasteboard/paste-sanitize-crash-1.html
       editing/pasteboard/paste-sanitize-crash-2.html

* editing/ReplaceSelectionCommand.h:
(WebCore::ReplaceSelectionCommand::InsertedNodes::pastLastLeaf):
* editing/SimplifyMarkupCommand.cpp:
(WebCore::SimplifyMarkupCommand::doApply):

LayoutTests:

* editing/pasteboard/paste-sanitize-crash-1-expected.txt: Added.
* editing/pasteboard/paste-sanitize-crash-1.html: Added.
* editing/pasteboard/paste-sanitize-crash-2-expected.txt: Added.
* editing/pasteboard/paste-sanitize-crash-2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRebasing editing results after r114799.
kov@webkit.org [Sat, 21 Apr 2012 01:06:27 +0000 (01:06 +0000)]
Rebasing editing results after r114799.

Baselines for more of css2.1 and dom.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRebaseline GTK animations tests after <http://trac.webkit.org/changeset/114799>.
dbates@webkit.org [Sat, 21 Apr 2012 01:03:20 +0000 (01:03 +0000)]
Rebaseline GTK animations tests after <trac.webkit.org/changeset/114799>.

* platform/gtk/animations/cross-fade-background-image-expected.txt:
* platform/gtk/animations/cross-fade-border-image-source-expected.txt:
* platform/gtk/animations/cross-fade-list-style-image-expected.txt:
* platform/gtk/animations/cross-fade-webkit-mask-box-image-expected.txt:
* platform/gtk/animations/cross-fade-webkit-mask-image-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Tiny change to DomStorage v8 bindings to avoid a relatively expensive...
michaeln@google.com [Sat, 21 Apr 2012 01:02:51 +0000 (01:02 +0000)]
[chromium] Tiny change to DomStorage v8 bindings to avoid a relatively expensive test in a couple
of places by reordering the expressions in compound conditions, if (fastTest && moreExpensiveTest)
https://bugs.webkit.org/show_bug.cgi?id=84500

Reviewed by Kentaro Hara.

No new tests, no new functionality.

* bindings/v8/custom/V8StorageCustom.cpp:
(WebCore::storageGetter):
(WebCore::V8Storage::namedPropertyQuery):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION (r114784): svg/text/foreignObject-text-clipping-bug.xml failing on Mountai...
mitz@apple.com [Sat, 21 Apr 2012 00:58:49 +0000 (00:58 +0000)]
REGRESSION (r114784): svg/text/foreignObject-text-clipping-bug.xml failing on Mountain Lion Debug Tests
https://bugs.webkit.org/show_bug.cgi?id=84505

Reviewed by Anders Carlsson.

Source/WebCore:

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::blockBeforeWithinSelectionRoot): Changed to not assume that boxes only
have boxes as siblings.

LayoutTests:

* platform/mac/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRebaseline GTK CSS1 tests after <http://trac.webkit.org/changeset/114799>.
kov@webkit.org [Sat, 21 Apr 2012 00:56:15 +0000 (00:56 +0000)]
Rebaseline GTK CSS1 tests after <trac.webkit.org/changeset/114799>.

Patch by Daniel Bates <dbates@webkit.org> on 2012-04-20

* platform/gtk/css1/basic/class_as_selector-expected.txt:
* platform/gtk/css1/basic/comments-expected.txt:
* platform/gtk/css1/basic/containment-expected.txt:
* platform/gtk/css1/basic/contextual_selectors-expected.txt:
* platform/gtk/css1/basic/grouping-expected.txt:
* platform/gtk/css1/basic/id_as_selector-expected.txt:
* platform/gtk/css1/basic/inheritance-expected.txt:
* platform/gtk/css1/box_properties/acid_test-expected.txt:
* platform/gtk/css1/box_properties/border-expected.txt:
* platform/gtk/css1/box_properties/border_bottom-expected.txt:
* platform/gtk/css1/box_properties/border_bottom_inline-expected.txt:
* platform/gtk/css1/box_properties/border_bottom_width-expected.txt:
* platform/gtk/css1/box_properties/border_bottom_width_inline-expected.txt:
* platform/gtk/css1/box_properties/border_color-expected.txt:
* platform/gtk/css1/box_properties/border_color_inline-expected.txt:
* platform/gtk/css1/box_properties/border_inline-expected.txt:
* platform/gtk/css1/box_properties/border_left-expected.txt:
* platform/gtk/css1/box_properties/border_left_inline-expected.txt:
* platform/gtk/css1/box_properties/border_left_width-expected.txt:
* platform/gtk/css1/box_properties/border_left_width_inline-expected.txt:
* platform/gtk/css1/box_properties/border_right-expected.txt:
* platform/gtk/css1/box_properties/border_right_inline-expected.txt:
* platform/gtk/css1/box_properties/border_right_width-expected.txt:
* platform/gtk/css1/box_properties/border_right_width_inline-expected.txt:
* platform/gtk/css1/box_properties/border_style-expected.txt:
* platform/gtk/css1/box_properties/border_style_inline-expected.txt:
* platform/gtk/css1/box_properties/border_top-expected.txt:
* platform/gtk/css1/box_properties/border_top_inline-expected.txt:
* platform/gtk/css1/box_properties/border_top_width-expected.txt:
* platform/gtk/css1/box_properties/border_top_width_inline-expected.txt:
* platform/gtk/css1/box_properties/border_width-expected.txt:
* platform/gtk/css1/cascade/cascade_order-expected.txt:
* platform/gtk/css1/cascade/important-expected.txt:
* platform/gtk/css1/classification/display-expected.txt:
* platform/gtk/css1/classification/list_style-expected.txt:
* platform/gtk/css1/classification/list_style_image-expected.txt:
* platform/gtk/css1/classification/list_style_position-expected.txt:
* platform/gtk/css1/classification/list_style_type-expected.txt:
* platform/gtk/css1/classification/white_space-expected.txt:
* platform/gtk/css1/color_and_background/background-expected.txt:
* platform/gtk/css1/color_and_background/background_attachment-expected.txt:
* platform/gtk/css1/color_and_background/background_color-expected.txt:
* platform/gtk/css1/color_and_background/background_image-expected.txt:
* platform/gtk/css1/color_and_background/background_position-expected.txt:
* platform/gtk/css1/color_and_background/background_repeat-expected.txt:
* platform/gtk/css1/color_and_background/color-expected.txt:
* platform/gtk/css1/conformance/forward_compatible_parsing-expected.txt:
* platform/gtk/css1/font_properties/font-expected.txt:
* platform/gtk/css1/font_properties/font_family-expected.txt:
* platform/gtk/css1/font_properties/font_size-expected.txt:
* platform/gtk/css1/font_properties/font_style-expected.txt:
* platform/gtk/css1/font_properties/font_variant-expected.txt:
* platform/gtk/css1/font_properties/font_weight-expected.txt:
* platform/gtk/css1/formatting_model/canvas-expected.txt:
* platform/gtk/css1/formatting_model/floating_elements-expected.txt:
* platform/gtk/css1/formatting_model/height_of_lines-expected.txt:
* platform/gtk/css1/formatting_model/horizontal_formatting-expected.txt:
* platform/gtk/css1/formatting_model/inline_elements-expected.txt:
* platform/gtk/css1/formatting_model/replaced_elements-expected.txt:
* platform/gtk/css1/formatting_model/vertical_formatting-expected.txt:
* platform/gtk/css1/pseudo/anchor-expected.txt:
* platform/gtk/css1/pseudo/firstletter-expected.txt:
* platform/gtk/css1/pseudo/firstline-expected.txt:
* platform/gtk/css1/pseudo/multiple_pseudo_elements-expected.txt:
* platform/gtk/css1/pseudo/pseudo_elements_in_selectors-expected.txt:
* platform/gtk/css1/text_properties/letter_spacing-expected.txt:
* platform/gtk/css1/text_properties/line_height-expected.txt:
* platform/gtk/css1/text_properties/text_align-expected.txt:
* platform/gtk/css1/text_properties/text_decoration-expected.txt:
* platform/gtk/css1/text_properties/text_indent-expected.txt:
* platform/gtk/css1/text_properties/text_transform-expected.txt:
* platform/gtk/css1/text_properties/vertical_align-expected.txt:
* platform/gtk/css1/text_properties/word_spacing-expected.txt:
* platform/gtk/css1/units/color_units-expected.txt:
* platform/gtk/css1/units/length_units-expected.txt:
* platform/gtk/css1/units/percentage_units-expected.txt:
* platform/gtk/css1/units/urls-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRebaseline GTK CSS1 tests after <http://trac.webkit.org/changeset/114799>.
dbates@webkit.org [Sat, 21 Apr 2012 00:50:46 +0000 (00:50 +0000)]
Rebaseline GTK CSS1 tests after <trac.webkit.org/changeset/114799>.

* platform/gtk/css1/basic/class_as_selector-expected.txt:
* platform/gtk/css1/basic/comments-expected.txt:
* platform/gtk/css1/basic/containment-expected.txt:
* platform/gtk/css1/basic/contextual_selectors-expected.txt:
* platform/gtk/css1/basic/grouping-expected.txt:
* platform/gtk/css1/basic/id_as_selector-expected.txt:
* platform/gtk/css1/basic/inheritance-expected.txt:
* platform/gtk/css1/box_properties/acid_test-expected.txt:
* platform/gtk/css1/box_properties/border-expected.txt:
* platform/gtk/css1/box_properties/border_bottom-expected.txt:
* platform/gtk/css1/box_properties/border_bottom_inline-expected.txt:
* platform/gtk/css1/box_properties/border_bottom_width-expected.txt:
* platform/gtk/css1/box_properties/border_bottom_width_inline-expected.txt:
* platform/gtk/css1/box_properties/border_color-expected.txt:
* platform/gtk/css1/box_properties/border_color_inline-expected.txt:
* platform/gtk/css1/box_properties/border_inline-expected.txt:
* platform/gtk/css1/box_properties/border_left-expected.txt:
* platform/gtk/css1/box_properties/border_left_inline-expected.txt:
* platform/gtk/css1/box_properties/border_left_width-expected.txt:
* platform/gtk/css1/box_properties/border_left_width_inline-expected.txt:
* platform/gtk/css1/box_properties/border_right-expected.txt:
* platform/gtk/css1/box_properties/border_right_inline-expected.txt:
* platform/gtk/css1/box_properties/border_right_width-expected.txt:
* platform/gtk/css1/box_properties/border_right_width_inline-expected.txt:
* platform/gtk/css1/box_properties/border_style-expected.txt:
* platform/gtk/css1/box_properties/border_style_inline-expected.txt:
* platform/gtk/css1/box_properties/border_top-expected.txt:
* platform/gtk/css1/box_properties/border_top_inline-expected.txt:
* platform/gtk/css1/box_properties/border_top_width-expected.txt:
* platform/gtk/css1/box_properties/border_top_width_inline-expected.txt:
* platform/gtk/css1/box_properties/border_width-expected.txt:
* platform/gtk/css1/cascade/cascade_order-expected.txt:
* platform/gtk/css1/cascade/important-expected.txt:
* platform/gtk/css1/classification/display-expected.txt:
* platform/gtk/css1/classification/list_style-expected.txt:
* platform/gtk/css1/classification/list_style_image-expected.txt:
* platform/gtk/css1/classification/list_style_position-expected.txt:
* platform/gtk/css1/classification/list_style_type-expected.txt:
* platform/gtk/css1/classification/white_space-expected.txt:
* platform/gtk/css1/color_and_background/background-expected.txt:
* platform/gtk/css1/color_and_background/background_attachment-expected.txt:
* platform/gtk/css1/color_and_background/background_color-expected.txt:
* platform/gtk/css1/color_and_background/background_image-expected.txt:
* platform/gtk/css1/color_and_background/background_position-expected.txt:
* platform/gtk/css1/color_and_background/background_repeat-expected.txt:
* platform/gtk/css1/color_and_background/color-expected.txt:
* platform/gtk/css1/conformance/forward_compatible_parsing-expected.txt:
* platform/gtk/css1/font_properties/font-expected.txt:
* platform/gtk/css1/font_properties/font_family-expected.txt:
* platform/gtk/css1/font_properties/font_size-expected.txt:
* platform/gtk/css1/font_properties/font_style-expected.txt:
* platform/gtk/css1/font_properties/font_variant-expected.txt:
* platform/gtk/css1/font_properties/font_weight-expected.txt:
* platform/gtk/css1/formatting_model/canvas-expected.txt:
* platform/gtk/css1/formatting_model/floating_elements-expected.txt:
* platform/gtk/css1/formatting_model/height_of_lines-expected.txt:
* platform/gtk/css1/formatting_model/horizontal_formatting-expected.txt:
* platform/gtk/css1/formatting_model/inline_elements-expected.txt:
* platform/gtk/css1/formatting_model/replaced_elements-expected.txt:
* platform/gtk/css1/formatting_model/vertical_formatting-expected.txt:
* platform/gtk/css1/pseudo/anchor-expected.txt:
* platform/gtk/css1/pseudo/firstletter-expected.txt:
* platform/gtk/css1/pseudo/firstline-expected.txt:
* platform/gtk/css1/pseudo/multiple_pseudo_elements-expected.txt:
* platform/gtk/css1/pseudo/pseudo_elements_in_selectors-expected.txt:
* platform/gtk/css1/text_properties/letter_spacing-expected.txt:
* platform/gtk/css1/text_properties/line_height-expected.txt:
* platform/gtk/css1/text_properties/text_align-expected.txt:
* platform/gtk/css1/text_properties/text_decoration-expected.txt:
* platform/gtk/css1/text_properties/text_indent-expected.txt:
* platform/gtk/css1/text_properties/text_transform-expected.txt:
* platform/gtk/css1/text_properties/vertical_align-expected.txt:
* platform/gtk/css1/text_properties/word_spacing-expected.txt:
* platform/gtk/css1/units/color_units-expected.txt:
* platform/gtk/css1/units/length_units-expected.txt:
* platform/gtk/css1/units/percentage_units-expected.txt:
* platform/gtk/css1/units/urls-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRebasing editing results after r114799.
kov@webkit.org [Sat, 21 Apr 2012 00:33:06 +0000 (00:33 +0000)]
Rebasing editing results after r114799.

* platform/gtk/editing/deleting/4922367-expected.txt:
* platform/gtk/editing/deleting/5099303-expected.txt:
* platform/gtk/editing/deleting/5126166-expected.txt:
* platform/gtk/editing/deleting/5144139-2-expected.txt:
* platform/gtk/editing/deleting/5206311-1-expected.txt:
* platform/gtk/editing/deleting/5272440-expected.txt:
* platform/gtk/editing/deleting/5369009-expected.txt:
* platform/gtk/editing/deleting/5433862-2-expected.txt:
* platform/gtk/editing/deleting/5483370-expected.txt:
* platform/gtk/editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
* platform/gtk/editing/deleting/delete-3608445-fix-expected.txt:
* platform/gtk/editing/deleting/delete-3608462-fix-expected.txt:
* platform/gtk/editing/deleting/delete-3775172-fix-expected.txt:
* platform/gtk/editing/deleting/delete-3800834-fix-expected.txt:
* platform/gtk/editing/deleting/delete-3857753-fix-expected.txt:
* platform/gtk/editing/deleting/delete-3865854-fix-expected.txt:
* platform/gtk/editing/deleting/delete-3928305-fix-expected.txt:
* platform/gtk/editing/deleting/delete-3959464-fix-expected.txt:
* platform/gtk/editing/deleting/delete-4083333-fix-expected.txt:
* platform/gtk/editing/deleting/delete-after-span-ws-001-expected.txt:
* platform/gtk/editing/deleting/delete-after-span-ws-002-expected.txt:
* platform/gtk/editing/deleting/delete-after-span-ws-003-expected.txt:
* platform/gtk/editing/deleting/delete-and-undo-expected.txt:
* platform/gtk/editing/deleting/delete-at-paragraph-boundaries-001-expected.txt:
* platform/gtk/editing/deleting/delete-at-paragraph-boundaries-002-expected.txt:
* platform/gtk/editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
* platform/gtk/editing/deleting/delete-at-paragraph-boundaries-004-expected.txt:
* platform/gtk/editing/deleting/delete-at-paragraph-boundaries-005-expected.txt:
* platform/gtk/editing/deleting/delete-at-paragraph-boundaries-006-expected.txt:
* platform/gtk/editing/deleting/delete-at-paragraph-boundaries-007-expected.txt:
* platform/gtk/editing/execCommand/4580583-1-expected.txt:
* platform/gtk/editing/execCommand/4580583-2-expected.txt:
* platform/gtk/editing/execCommand/4641880-1-expected.txt:
* platform/gtk/editing/execCommand/4641880-2-expected.txt:
* platform/gtk/editing/execCommand/4747450-expected.txt:
* platform/gtk/editing/execCommand/4916402-expected.txt:
* platform/gtk/editing/execCommand/4916541-expected.txt:
* platform/gtk/editing/execCommand/4924441-expected.txt:
* platform/gtk/editing/execCommand/5080333-1-expected.txt:
* platform/gtk/editing/execCommand/5080333-2-expected.txt:
* platform/gtk/editing/execCommand/5136770-expected.txt:
* platform/gtk/editing/execCommand/5138441-expected.txt:
* platform/gtk/editing/execCommand/5142012-1-expected.txt:
* platform/gtk/editing/execCommand/5142012-2-expected.txt:
* platform/gtk/editing/execCommand/5190926-expected.txt:
* platform/gtk/editing/execCommand/5481523-expected.txt:
* platform/gtk/editing/execCommand/5482023-expected.txt:
* platform/gtk/editing/execCommand/5569741-expected.txt:
* platform/gtk/editing/execCommand/create-list-with-hr-expected.txt:
* platform/gtk/editing/input/caret-at-the-edge-of-contenteditable-expected.txt:
* platform/gtk/editing/input/caret-at-the-edge-of-input-expected.txt:
* platform/gtk/editing/input/emacs-ctrl-o-expected.txt:
* platform/gtk/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt:
* platform/gtk/editing/input/reveal-caret-of-multiline-input-expected.txt:
* platform/gtk/editing/inserting/12882-expected.txt:
* platform/gtk/editing/inserting/4278698-expected.txt:
* platform/gtk/editing/inserting/4840662-expected.txt:
* platform/gtk/editing/inserting/4875189-1-expected.txt:
* platform/gtk/editing/inserting/4875189-2-expected.txt:
* platform/gtk/editing/inserting/4959067-expected.txt:
* platform/gtk/editing/inserting/4960120-1-expected.txt:
* platform/gtk/editing/inserting/4960120-2-expected.txt:
* platform/gtk/editing/inserting/5002441-expected.txt:
* platform/gtk/editing/inserting/5058163-1-expected.txt:
* platform/gtk/editing/inserting/5058163-2-expected.txt:
* platform/gtk/editing/inserting/5156401-2-expected.txt:
* platform/gtk/editing/inserting/5418891-expected.txt:
* platform/gtk/editing/inserting/5510537-expected.txt:
* platform/gtk/editing/inserting/5549929-2-expected.txt:
* platform/gtk/editing/inserting/5549929-3-expected.txt:
* platform/gtk/editing/inserting/6703873-expected.txt:
* platform/gtk/editing/inserting/before-after-input-element-expected.txt:
* platform/gtk/editing/inserting/break-blockquote-after-delete-expected.txt:
* platform/gtk/editing/inserting/editable-html-element-expected.txt:
* platform/gtk/editing/inserting/editable-inline-element-expected.txt:
* platform/gtk/editing/inserting/edited-whitespace-1-expected.txt:
* platform/gtk/editing/inserting/editing-empty-divs-expected.txt:
* platform/gtk/editing/inserting/insert-3654864-fix-expected.txt:
* platform/gtk/editing/inserting/insert-3775316-fix-expected.txt:
* platform/gtk/editing/inserting/insert-3778059-fix-expected.txt:
* platform/gtk/editing/inserting/insert-3800346-fix-expected.txt:
* platform/gtk/editing/inserting/insert-3851164-fix-expected.txt:
* platform/gtk/editing/inserting/insert-after-delete-001-expected.txt:
* platform/gtk/editing/inserting/insert-at-end-01-expected.txt:
* platform/gtk/editing/inserting/insert-at-end-02-expected.txt:
* platform/gtk/editing/pasteboard/3976872-expected.txt:
* platform/gtk/editing/pasteboard/4076267-2-expected.txt:
* platform/gtk/editing/pasteboard/4076267-3-expected.txt:
* platform/gtk/editing/pasteboard/4076267-expected.txt:
* platform/gtk/editing/pasteboard/4242293-expected.txt:
* platform/gtk/editing/pasteboard/4631972-expected.txt:
* platform/gtk/editing/pasteboard/4641033-expected.txt:
* platform/gtk/editing/pasteboard/4806874-expected.txt:
* platform/gtk/editing/pasteboard/4944770-1-expected.txt:
* platform/gtk/editing/pasteboard/4944770-2-expected.txt:
* platform/gtk/editing/pasteboard/4947130-expected.txt:
* platform/gtk/editing/pasteboard/7955-expected.txt:
* platform/gtk/editing/pasteboard/8145-1-expected.txt:
* platform/gtk/editing/pasteboard/8145-2-expected.txt:
* platform/gtk/editing/pasteboard/8145-3-expected.txt:
* platform/gtk/editing/selection/13804-expected.txt:
* platform/gtk/editing/selection/14971-expected.txt:
* platform/gtk/editing/selection/3690703-2-expected.txt:
* platform/gtk/editing/selection/3690703-expected.txt:
* platform/gtk/editing/selection/3690719-expected.txt:
* platform/gtk/editing/selection/4397952-expected.txt:
* platform/gtk/editing/selection/4402375-expected.txt:
* platform/gtk/editing/selection/4776665-expected.txt:
* platform/gtk/editing/selection/4818145-expected.txt:
* platform/gtk/editing/selection/4866671-expected.txt:
* platform/gtk/editing/selection/4889598-expected.txt:
* platform/gtk/editing/selection/6476-expected.txt:
* platform/gtk/editing/selection/7152-1-expected.txt:
* platform/gtk/editing/selection/7152-2-expected.txt:
* platform/gtk/editing/style/4916887-expected.txt:
* platform/gtk/editing/style/5017613-1-expected.txt:
* platform/gtk/editing/style/5017613-2-expected.txt:
* platform/gtk/editing/style/5046875-1-expected.txt:
* platform/gtk/editing/style/5046875-2-expected.txt:
* platform/gtk/editing/style/5065910-expected.txt:
* platform/gtk/editing/style/5084241-expected.txt:
* platform/gtk/editing/style/5228141-expected.txt:
* platform/gtk/editing/style/5279521-expected.txt:
* platform/gtk/editing/style/apple-style-editable-mix-expected.txt:
* platform/gtk/editing/style/block-style-001-expected.txt:
* platform/gtk/editing/style/block-style-002-expected.txt:
* platform/gtk/editing/style/block-style-003-expected.txt:
* platform/gtk/editing/style/block-styles-007-expected.txt:
* platform/gtk/editing/style/create-block-for-style-001-expected.txt:
* platform/gtk/editing/style/create-block-for-style-002-expected.txt:
* platform/gtk/editing/style/create-block-for-style-003-expected.txt:
* platform/gtk/editing/style/create-block-for-style-004-expected.txt:
* platform/gtk/editing/undo/4063751-expected.txt:
* platform/gtk/editing/undo/redo-typing-001-expected.txt:
* platform/gtk/editing/undo/undo-combined-delete-boundary-expected.txt:
* platform/gtk/editing/undo/undo-combined-delete-expected.txt:
* platform/gtk/editing/undo/undo-delete-boundary-expected.txt:
* platform/gtk/editing/undo/undo-delete-expected.txt:
* platform/gtk/editing/undo/undo-forward-delete-boundary-expected.txt:
* platform/gtk/editing/undo/undo-forward-delete-expected.txt:
* platform/gtk/editing/unsupported-content/list-delete-001-expected.txt:
* platform/gtk/editing/unsupported-content/list-delete-003-expected.txt:
* platform/gtk/editing/unsupported-content/list-type-after-expected.txt:
* platform/gtk/editing/unsupported-content/list-type-before-expected.txt:
* platform/gtk/editing/unsupported-content/table-delete-001-expected.txt:
* platform/gtk/editing/unsupported-content/table-delete-002-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDFG should optimize int8 and int16 arrays on ARMv7
fpizlo@apple.com [Sat, 21 Apr 2012 00:31:28 +0000 (00:31 +0000)]
DFG should optimize int8 and int16 arrays on ARMv7
https://bugs.webkit.org/show_bug.cgi?id=84503

Reviewed by Oliver Hunt.

* assembler/ARMv7Assembler.h:
(ARMv7Assembler):
(JSC::ARMv7Assembler::ldrsb):
(JSC::ARMv7Assembler::ldrsh):
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::load16Signed):
(JSC::MacroAssemblerARMv7::load8Signed):
* bytecode/PredictedType.h:
(JSC::isActionableIntMutableArrayPrediction):
* dfg/DFGNode.h:
(JSC::DFG::Node::shouldSpeculateInt8Array):
(JSC::DFG::Node::shouldSpeculateInt16Array):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Remove special case for recreating layers during sync
danakj@chromium.org [Sat, 21 Apr 2012 00:27:46 +0000 (00:27 +0000)]
[chromium] Remove special case for recreating layers during sync
https://bugs.webkit.org/show_bug.cgi?id=84458

Reviewed by James Robinson.

Source/WebCore:

We no longer delete layers on the impl side, unless it is due to
deleting the layer on webkit side. So we will no longer have a
situation where we need to push properties from an old
LayerChromium to a new CCLayerImpl.

* platform/graphics/chromium/TreeSynchronizer.cpp:
(WebCore::TreeSynchronizer::reuseOrCreateCCLayerImpl):

Source/WebKit/chromium:

* tests/TreeSynchronizerTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] WebFilterOperations API does not compile or dynamically link
danakj@chromium.org [Sat, 21 Apr 2012 00:22:56 +0000 (00:22 +0000)]
[chromium] WebFilterOperations API does not compile or dynamically link
https://bugs.webkit.org/show_bug.cgi?id=84506

Reviewed by James Robinson.

Non-inline functions need WEBKIT_EXPORT in their declarations,
and the type used in the WebPrivateOwnPtr needs to be forward-
declared even when WEBKIT_IMPLEMENTATION is not defined.

Source/Platform:

* chromium/public/WebFilterOperations.h:
(WebKit::WebFilterOperations::WebFilterOperations):
(WebFilterOperations):

Source/WebCore:

* platform/chromium/support/WebFilterOperations.cpp:
(WebKit::WebFilterOperations::initialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r114333.
commit-queue@webkit.org [Sat, 21 Apr 2012 00:18:20 +0000 (00:18 +0000)]
Unreviewed, rolling out r114333.
http://trac.webkit.org/changeset/114333
https://bugs.webkit.org/show_bug.cgi?id=84511

perf regression (Requested by morrita on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-20

* dom/Node.cpp:
* dom/Node.h:
(WebCore):
(Node):
(WebCore::Node::isElementNode):
(WebCore::Node::isContainerNode):
(WebCore::Node::isTextNode):
(WebCore::Node::isHTMLElement):
(WebCore::Node::isSVGElement):
(WebCore::Node::isStyledElement):
(WebCore::Node::isShadowRoot):
(WebCore::Node::parentNode):
(WebCore::Node::parentNodeGuaranteedHostFree):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIndexedDB: Support get/getKey(keyRange)
commit-queue@webkit.org [Sat, 21 Apr 2012 00:16:48 +0000 (00:16 +0000)]
IndexedDB: Support get/getKey(keyRange)
https://bugs.webkit.org/show_bug.cgi?id=83638

Patch by Alec Flett <alecflett@chromium.org> on 2012-04-20
Reviewed by Ojan Vafai.

Source/WebCore:

Support IDBKeyRange as a parameter to all the various get/getKey
combinations. Switches the existing get/getKey versions that use
IDBKey directly to start using IDBKeyRange.only().

Test: storage/indexeddb/get-keyrange.html

* Modules/indexeddb/IDBIndex.cpp:
(WebCore::IDBIndex::get):
(WebCore):
(WebCore::IDBIndex::getKey):
* Modules/indexeddb/IDBIndex.h:
(IDBIndex):
* Modules/indexeddb/IDBIndex.idl:
* Modules/indexeddb/IDBIndexBackendImpl.cpp:
(WebCore::IDBIndexBackendImpl::getInternal):
(WebCore):
(WebCore::IDBIndexBackendImpl::getByRangeInternal):
(WebCore::IDBIndexBackendImpl::getKeyInternal):
(WebCore::IDBIndexBackendImpl::getKeyByRangeInternal):
(WebCore::IDBIndexBackendImpl::get):
(WebCore::IDBIndexBackendImpl::getKey):
* Modules/indexeddb/IDBIndexBackendImpl.h:
(IDBIndexBackendImpl):
* Modules/indexeddb/IDBIndexBackendInterface.h:
(IDBIndexBackendInterface):
* Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::get):
(WebCore):
* Modules/indexeddb/IDBObjectStore.h:
(IDBObjectStore):
* Modules/indexeddb/IDBObjectStore.idl:
* Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(WebCore):
(WebCore::IDBObjectStoreBackendImpl::get):
(WebCore::IDBObjectStoreBackendImpl::getByRangeInternal):
(WebCore::IDBObjectStoreBackendImpl::getInternal):
* Modules/indexeddb/IDBObjectStoreBackendImpl.h:
(IDBObjectStoreBackendImpl):
* Modules/indexeddb/IDBObjectStoreBackendInterface.h:
(IDBObjectStoreBackendInterface):

Source/WebKit/chromium:

Hook up WebKit API to the new get/getKey implementations.

* src/IDBIndexBackendProxy.cpp:
(WebKit::IDBIndexBackendProxy::get):
(WebKit):
(WebKit::IDBIndexBackendProxy::getKey):
* src/IDBIndexBackendProxy.h:
(IDBIndexBackendProxy):
* src/WebIDBIndexImpl.cpp:
(WebKit::WebIDBIndexImpl::getObject):
(WebKit::WebIDBIndexImpl::getKey):
* src/WebIDBObjectStoreImpl.cpp:
(WebKit::WebIDBObjectStoreImpl::get):

LayoutTests:

Tests for all the get/getKey combinations when using a range.

* storage/indexeddb/get-keyrange-expected.txt: Added.
* storage/indexeddb/get-keyrange.html: Added.
* storage/indexeddb/index-get-key-argument-required-expected.txt:
* storage/indexeddb/objectStore-required-arguments-expected.txt:
* storage/indexeddb/resources/get-keyrange.js: Added.
(test):
(openDatabase):
(setVersion):
(deleteExisting):
(addData):
(getRangeOnlyTest.request.onsuccess):
(getRangeOnlyTest):
(getRangeLowerTest.request.onsuccess):
(getRangeLowerTest):
(getRangeLowerOpenTest.request.onsuccess):
(getRangeLowerOpenTest):
(getRangeUpperTest.request.onsuccess):
(getRangeUpperTest):
(getRangeLowerFractionTest.request.onsuccess):
(getRangeLowerFractionTest):
(getOutOfRangeTest.request.onsuccess):
(getOutOfRangeTest):
(getBadOnlyTest.request.onsuccess):
(getBadOnlyTest):
(getNullTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r114789.
jer.noble@apple.com [Sat, 21 Apr 2012 00:12:30 +0000 (00:12 +0000)]
Unreviewed, rolling out r114789.
http://trac.webkit.org/changeset/114789
https://bugs.webkit.org/show_bug.cgi?id=84515

Caused 5 tests to fail on mac/ (Requested by jernoble on

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-20

* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
* css/CSSValueKeywords.in:
* platform/ThemeTypes.h:
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd an ability to find the extent of a callframe
oliver@apple.com [Sat, 21 Apr 2012 00:12:04 +0000 (00:12 +0000)]
Add an ability to find the extent of a callframe
https://bugs.webkit.org/show_bug.cgi?id=84513

Reviewed by Filip Pizlo.

Add a function to get the extent of a callframe and
use that function for a new assertion to make sure the
RegisterFile makes sense using that information.

* interpreter/CallFrame.cpp:
(JSC::CallFrame::frameExtentInternal):
(JSC):
* interpreter/CallFrame.h:
(JSC::ExecState::frameExtent):
(ExecState):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::executeCall):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=84512 Repurpose ActiveDOMObject::WillShowDial...
beidson@apple.com [Sat, 21 Apr 2012 00:07:13 +0000 (00:07 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=84512 Repurpose ActiveDOMObject::WillShowDialog to WillDeferLoading

Reviewed by Eric Carlson.

Source/WebCore:

No new tests. (Refactor, no behavior change)

Rename WillShowDialog to WillDeferLoading:
* dom/ActiveDOMObject.h:
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::suspend):

Don't take a ReasonForSuspension argument anymore, just use WillDeferLoading:
* page/PageGroupLoadDeferrer.cpp:
(WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
* page/PageGroupLoadDeferrer.h:

Don't pass a Reason anymore as WillDeferLoading is used by default:
* page/Chrome.cpp:
(WebCore::Chrome::runModal):
(WebCore::Chrome::runBeforeUnloadConfirmPanel):
(WebCore::Chrome::runJavaScriptAlert):
(WebCore::Chrome::runJavaScriptConfirm):
(WebCore::Chrome::runJavaScriptPrompt):
(WebCore::Chrome::shouldInterruptJavaScript):

Source/WebKit/blackberry:

PageGroupLoadDeferrer's don't take a ReasonForSuspension argument anymore;
They just use WillDeferLoading by default.

* Api/WebPageGroupLoadDeferrer.cpp:
(BlackBerry::WebKit::WebPageGroupLoadDeferrer::WebPageGroupLoadDeferrer):

* WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::createWindow):
(WebCore::ChromeClientBlackBerry::runOpenPanel):

Source/WebKit/chromium:

PageGroupLoadDeferrer's don't take a ReasonForSuspension argument anymore;
They just use WillDeferLoading by default.

* src/WebViewImpl.cpp:
(WebKit::WebView::willEnterModalLoop):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, GTK css2.1 rebaseline after r114796 and r114799.
philn@webkit.org [Sat, 21 Apr 2012 00:01:09 +0000 (00:01 +0000)]
Unreviewed, GTK css2.1 rebaseline after r114796 and r114799.

* platform/gtk/css2.1: Massive Update.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Plumb a compositor surface ready notification through to the threaded...
commit-queue@webkit.org [Fri, 20 Apr 2012 23:49:41 +0000 (23:49 +0000)]
[chromium] Plumb a compositor surface ready notification through to the threaded compositor
https://bugs.webkit.org/show_bug.cgi?id=84305

Patch by James Robinson <jamesr@chromium.org> on 2012-04-20
Reviewed by Adrienne Walker.

Source/Platform:

Add a notification for when the compositor surface associated with a given view is ready to use.

* chromium/public/WebLayerTreeView.h:
(WebLayerTreeView):

Source/WebCore:

Plumb setSurfaceReady through to the scheduler.

* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::setSurfaceReady):
(WebCore):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(CCLayerTreeHost):
* platform/graphics/chromium/cc/CCProxy.h:
(CCProxy):
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::setSurfaceReady):
(WebCore):
* platform/graphics/chromium/cc/CCSingleThreadProxy.h:
(CCSingleThreadProxy):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::setSurfaceReady):
(WebCore):
(WebCore::CCThreadProxy::setSurfaceReadyOnImplThread):
(WebCore::CCThreadProxy::initializeImplOnImplThread):
* platform/graphics/chromium/cc/CCThreadProxy.h:
(CCThreadProxy):

Source/WebKit/chromium:

Adds a notification to WebWidget for when the compositor surface is ready to use. This exists to fix a race
condition when WebKit requires that we enter compositing mode but we haven't completed initialization of the
native window/etc backing the WebWidget, and we can't block for this initialization to complete without inducing
deadlocks. In this situation, we proceed as usual except that we can't attempt to use the compositor context or
it will fail.

* public/WebWidget.h:
(WebWidget):
* src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::setSurfaceReady):
(WebKit):
* src/WebPagePopupImpl.cpp:
(WebKit::WebPagePopupImpl::setCompositorSurfaceReady):
(WebKit):
* src/WebPagePopupImpl.h:
(WebPagePopupImpl):
* src/WebPopupMenuImpl.cpp:
(WebKit::WebPopupMenuImpl::setCompositorSurfaceReady):
(WebKit):
* src/WebPopupMenuImpl.h:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setCompositorSurfaceReady):
(WebKit):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
* src/WebViewImpl.h:
(WebViewImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Gtk][WK1] Use mock scrollbars when testing
mrobinson@webkit.org [Fri, 20 Apr 2012 23:47:03 +0000 (23:47 +0000)]
[Gtk][WK1] Use mock scrollbars when testing
https://bugs.webkit.org/show_bug.cgi?id=79577

Patch by Zan Dobersek <zandobersek@gmail.com> on 2012-04-20
Reviewed by Daniel Bates.

Enable mock scrollbars if running DumpRenderTree.

* webkit/webkitwebview.cpp:
(webkit_web_view_update_settings):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION (r114764-r114766): svg/css/getComputedStyle-basic.xhtml failing on Lion...
dino@apple.com [Fri, 20 Apr 2012 23:32:16 +0000 (23:32 +0000)]
REGRESSION (r114764-r114766): svg/css/getComputedStyle-basic.xhtml failing on Lion Debug (Tests)
https://bugs.webkit.org/show_bug.cgi?id=84483

Reviewed by Simon Fraser.

Add -webkit-filter results to the platforms on which it is enabled.
This required a new platform result for WebKit mac.

* platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt:
* platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
* platform/mac/svg/css/getComputedStyle-basic-expected.txt: Copied from LayoutTests/platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt.
* platform/mac/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Call memoryUsageMB directly
pilgrim@chromium.org [Fri, 20 Apr 2012 23:31:23 +0000 (23:31 +0000)]
[Chromium] Call memoryUsageMB directly
https://bugs.webkit.org/show_bug.cgi?id=84376

Reviewed by Kentaro Hara.

Source/WebCore:

Now that memoryUsageMB has been moved from PlatformSupport.h to
Platform.h, we need to be able to call it directly
from WebCore/bindings/v8/V8GCController.cpp.
That means we need a new MemoryUsageSupport class in
WebCore/platform/ and an implementation in
WebCore/platform/chromium/MemoryUsageSupportChromium.cpp.
Other ports are welcome to implement their memory usage
functions if they wish. This pattern was based on the
HistogramSupport/HistogramSupportChromium classes.

Part of a refactoring series. See tracking bug 82948.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/v8/V8GCController.cpp:
(WebCore):
* platform/MemoryUsageSupport.cpp: Added.
(WebCore):
(WebCore::MemoryUsageSupport::memoryUsageMB):
* platform/MemoryUsageSupport.h: Added.
(WebCore):
(MemoryUsageSupport):
* platform/chromium/MemoryUsageSupportChromium.cpp: Added.
(WebCore):
(WebCore::MemoryUsageSupport::memoryUsageMB):
* platform/chromium/PlatformSupport.h:
(PlatformSupport):

Source/WebKit/chromium:

Part of a refactoring series. See tracking bug 82948.

* src/PlatformSupport.cpp:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Revert changes that disabled Cairo fonts metrics hinting
mrobinson@webkit.org [Fri, 20 Apr 2012 23:18:16 +0000 (23:18 +0000)]
[GTK] Revert changes that disabled Cairo fonts metrics hinting
https://bugs.webkit.org/show_bug.cgi?id=84502

Reviewed by Daniel Bates.

Re-enable Cairo metrics hinting, which seems to ensure consistent results in
reference and pixel test results. This makes our font metrics a bit different
than the Mac port's, but it's a decent price to pay for consistent results.

* DumpRenderTree/gtk/DumpRenderTree.cpp:
(initializeGtkFontSettings):
* WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
(WTR::initializeGtkSettings):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION (r114784): svg/text/foreignObject-text-clipping-bug.xml failing on Mountai...
jer.noble@apple.com [Fri, 20 Apr 2012 23:04:39 +0000 (23:04 +0000)]
REGRESSION (r114784): svg/text/foreignObject-text-clipping-bug.xml failing on Mountain Lion Debug Tests
https://bugs.webkit.org/show_bug.cgi?id=84505

Unreviewed; add new crashing test result to test_expectations.txt.

* platform/mac/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] [DRT] Add baselines for the tests which are missing expected results
commit-queue@webkit.org [Fri, 20 Apr 2012 23:03:05 +0000 (23:03 +0000)]
[EFL] [DRT] Add baselines for the tests which are missing expected results
https://bugs.webkit.org/show_bug.cgi?id=84440

Unreviewed, added EFL baselines for passing tests and also skipped two tests
which are failing due to missing implementation.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-20

* platform/efl/Skipped:
* platform/efl/fast/block/float/avoiding-float-centered-expected.png: Added.
* platform/efl/fast/block/float/avoiding-float-centered-expected.txt: Added.
* platform/efl/fast/events/panScroll-click-hyperlink-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoInline the JSArray constructor
benjamin@webkit.org [Fri, 20 Apr 2012 22:52:53 +0000 (22:52 +0000)]
Inline the JSArray constructor
https://bugs.webkit.org/show_bug.cgi?id=84416

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-04-20
Reviewed by Geoffrey Garen.

The constructor is trivial, no reason to jump for it.

This makes the creation of array ~5% faster (on non-trivial cases, no empty arrays).

* runtime/JSArray.cpp:
(JSC):
* runtime/JSArray.h:
(JSC::JSArray::JSArray):
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRe-land. The non-fast scrollable region is now always updated after layout, and frame...
andersca@apple.com [Fri, 20 Apr 2012 22:38:49 +0000 (22:38 +0000)]
Re-land. The non-fast scrollable region is now always updated after layout, and frameViewScrollableAreasDidChange has been removed.

computeNonFastScrollableRegion needs to traverse the entire frame tree
https://bugs.webkit.org/show_bug.cgi?id=84409
<rdar://problem/11285741>

Reviewed by Dan Bernstein.

Now that scrollable areas won't be in the set of scrollable areas unless they are actually scrollable, we need to look for scrollable
areas in the entire frame tree since there can be a scrollable frame that's a subframe of a non-scrollable frame for example.

* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::computeNonFastScrollableRegion):
(WebCore::ScrollingCoordinator::frameViewLayoutUpdated):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114792 268f45cc-cd09-0410-ab3c-d52691b4dbfc