WebKit-https.git
10 years ago<rdar://problem/9768483> REGRESSION: Crash in RenderBlock::removeFloatingObjectsBelow()
mitz@apple.com [Wed, 21 Sep 2011 18:45:56 +0000 (18:45 +0000)]
<rdar://problem/9768483> REGRESSION: Crash in RenderBlock::removeFloatingObjectsBelow()
https://bugs.webkit.org/show_bug.cgi?id=68550

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/multicol/null-lastFloat-in-removeFloatingObjectsBelow.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::removeFloatingObjectsBelow): Break out of the while() loop when the
floating object set is empty, which can happen if there were no floats on previous lines
(in which case, lastFloat is 0).

LayoutTests:

* fast/multicol/null-lastFloat-in-removeFloatingObjectsBelow-expected.txt: Added.
* fast/multicol/null-lastFloat-in-removeFloatingObjectsBelow.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFixed bug number in test expectations.
dslomov@google.com [Wed, 21 Sep 2011 18:38:58 +0000 (18:38 +0000)]
Fixed bug number in test expectations.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMacroAssembler fixes.
barraclough@apple.com [Wed, 21 Sep 2011 18:33:43 +0000 (18:33 +0000)]
MacroAssembler fixes.
https://bugs.webkit.org/show_bug.cgi?id=68494

Reviewed by Sam Weinig.

Add X86-64's 3 operand or32 to other MacroAssembler, fix load32's [const] void* mismatch

* assembler/MacroAssembler.h:
(JSC::MacroAssembler::orPtr):
(JSC::MacroAssembler::loadPtr):
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::or32):
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::or32):
* assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::or32):
* assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::or32):
(JSC::MacroAssemblerSH4::load32):
* assembler/MacroAssemblerX86.h:
(JSC::MacroAssemblerX86::load32):
* assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::load32):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[GTK] Fix build break when enabling webgl on r95593
commit-queue@webkit.org [Wed, 21 Sep 2011 18:18:59 +0000 (18:18 +0000)]
[GTK] Fix build break when enabling webgl on r95593
https://bugs.webkit.org/show_bug.cgi?id=68502

Patch by ChangSeok Oh <shivamidow@gmail.com> on 2011-09-21
Reviewed by Martin Robinson.

Add PassOwnPtr.h to GC3DPrivate.h and remove useless one from GC3DGtk.cpp & GC3DPrivate.cpp

No tests required.

* platform/graphics/gtk/GraphicsContext3DGtk.cpp:
* platform/graphics/gtk/GraphicsContext3DPrivate.cpp:
* platform/graphics/gtk/GraphicsContext3DPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBranch builds don't launch on Windows when run against trunk WebKit
sfalken@apple.com [Wed, 21 Sep 2011 18:14:02 +0000 (18:14 +0000)]
Branch builds don't launch on Windows when run against trunk WebKit
https://bugs.webkit.org/show_bug.cgi?id=68546

Reviewed by Darin Adler.

* Interfaces/IWebPreferences.idl: Swap avFoundation and pictographicFontFamily
in IDL for binary compatibility between branch and trunk.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: clear resource agent resource cache upon resource agent's disable.
vsevik@chromium.org [Wed, 21 Sep 2011 18:01:32 +0000 (18:01 +0000)]
Web Inspector: clear resource agent resource cache upon resource agent's disable.
https://bugs.webkit.org/show_bug.cgi?id=67995

Reviewed by Pavel Feldman.

Source/WebCore:

Test: http/tests/inspector/network/network-disabling-check-no-memory-leak.html

* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::disable):

LayoutTests:

* http/tests/inspector/network/network-disabling-check-no-memory-leak-expected.txt: Added.
* http/tests/inspector/network/network-disabling-check-no-memory-leak.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=68543
hyatt@apple.com [Wed, 21 Sep 2011 17:58:22 +0000 (17:58 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=68543

Make sure that when regions change dimensions we recompute pagination slices.

Reviewed by Simon Fraser.

Source/WebCore:

Added new tests in fast/regions.

* rendering/LayoutState.cpp:
(WebCore::LayoutState::LayoutState):
* rendering/LayoutState.h:
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::renderRegionForLine):
(WebCore::RenderFlowThread::regionLogicalWidthForLine):
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::layout):
* rendering/RenderView.cpp:
(WebCore::RenderView::pushLayoutState):
* rendering/RenderView.h:
(WebCore::LayoutStateMaintainer::LayoutStateMaintainer):
(WebCore::LayoutStateMaintainer::push):

LayoutTests:

* fast/regions/text-region-split-after-resize-expected.txt: Added.
* fast/regions/text-region-split-after-resize.html: Added.
* fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoEnsure TestWebKitAPI works on mac, win, chromium-mac and chromium-linux
commit-queue@webkit.org [Wed, 21 Sep 2011 17:37:57 +0000 (17:37 +0000)]
Ensure TestWebKitAPI works on mac, win, chromium-mac and chromium-linux
https://bugs.webkit.org/show_bug.cgi?id=68206

Patch by Xianzhu Wang <wangxianzhu@chromium.org> on 2011-09-21
Reviewed by Tony Chang.

Source/WebCore:

Added two new wtf headers into ForwardingHeaders/wtf to make
#include <wtf/...h> cross-platform.
No new tests needed.

* ForwardingHeaders/wtf/MetaAllocator.h: Added.
* ForwardingHeaders/wtf/RedBlackTree.h: Added.

Source/WebKit/chromium:

* WebKit.gyp:

Tools:

* Scripts/webkitdirs.pm:
(determineBaseProductDir): add support for chromium-mac
* TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
* TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[WinCairo] IconDatabase::defaultIcon always fails for non-CAN_THEME_URL_ICON builds.
commit-queue@webkit.org [Wed, 21 Sep 2011 17:10:45 +0000 (17:10 +0000)]
[WinCairo] IconDatabase::defaultIcon always fails for non-CAN_THEME_URL_ICON builds.
https://bugs.webkit.org/show_bug.cgi?id=67469

Patch by David Delaune <david.delaune@googlemail.com> on 2011-09-21
Reviewed by Brent Fulgham.

No new functionality added in this change.

* loader/icon/IconDatabase.cpp: defining CAN_THEME_URL_ICON for the WIN_CAIRO

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSpan element gets produced using backspace/delete to merge header with paragraph
rniwa@webkit.org [Wed, 21 Sep 2011 17:06:53 +0000 (17:06 +0000)]
Span element gets produced using backspace/delete to merge header with paragraph
https://bugs.webkit.org/show_bug.cgi?id=68413

Reviewed by Darin Adler.

Source/WebCore:

Add p element to the list of elements to retain appearance. Also modified removeStyleFromNode
(and renamed to removeStyleFromRules) not to remove inline style declarations because
inline styles need to stay on copy.

Test: editing/deleting/merge-paragraph-from-p-with-style.html

* editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::saveTypingStyleState):
* editing/EditingStyle.cpp:
(WebCore::EditingStyle::removeStyleFromRules): Renamed from removeStyleFromNode.
* editing/EditingStyle.h:
* editing/markup.cpp:
(WebCore::isBlockNodeToRetainAppearance):
(WebCore::StyledMarkupAccumulator::serializeNodes):

LayoutTests:

Add a test to remove the line break before a p element. WebKit should not preserve
the font color from the style rule but should preserve the font style from inline style declaration.

Also fix merge-paragraph-from-h6* to actually h6 instead of h1.

* editing/deleting/merge-paragraph-from-h6-expected.txt:
* editing/deleting/merge-paragraph-from-h6-with-style-expected.txt:
* editing/deleting/merge-paragraph-from-h6-with-style.html:
* editing/deleting/merge-paragraph-from-h6.html:
* editing/deleting/merge-paragraph-from-p-with-style-expected.txt: Added.
* editing/deleting/merge-paragraph-from-p-with-style.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[flexbox] rename classnames and methods in the tests to not assume horizontal
ojan@chromium.org [Wed, 21 Sep 2011 17:00:43 +0000 (17:00 +0000)]
[flexbox] rename classnames and methods in the tests to not assume horizontal
https://bugs.webkit.org/show_bug.cgi?id=68498

Reviewed by Tony Chang.

* css3/flexbox/001.html:
* css3/flexbox/002.html:
* css3/flexbox/003.html:
* css3/flexbox/004.html:
* css3/flexbox/resources/flexbox.js:
(checkFlexBoxen):
* css3/flexbox/writing-modes.html:
* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoneed rebaseline for gradient speedup in skia
reed@google.com [Wed, 21 Sep 2011 16:51:20 +0000 (16:51 +0000)]
need rebaseline for gradient speedup in skia
https://bugs.webkit.org/show_bug.cgi?id=68531

Reviewed by Stephen White.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, move today's skipped flaky tests to test_expectations
philn@webkit.org [Wed, 21 Sep 2011 16:48:46 +0000 (16:48 +0000)]
Unreviewed, move today's skipped flaky tests to test_expectations
as suggested by mrobinson.

* platform/gtk/Skipped:
* platform/gtk/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoReport AXValueChanged when value changes in element with role=textbox.
commit-queue@webkit.org [Wed, 21 Sep 2011 16:45:12 +0000 (16:45 +0000)]
Report AXValueChanged when value changes in element with role=textbox.
https://bugs.webkit.org/show_bug.cgi?id=68201

Patch by Alice Boxhall <aboxhall@chromium.org> on 2011-09-21
Reviewed by Chris Fleizach.

Source/WebCore:

Test: platform/mac/accessibility/textbox-role-reports-notifications.html

* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::isARIATextControl):
* accessibility/AccessibilityObject.h:
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::contentChanged):
(WebCore::AccessibilityRenderObject::childrenChanged):

LayoutTests:

* platform/mac/accessibility/textbox-role-reports-notifications-expected.txt: Added.
* platform/mac/accessibility/textbox-role-reports-notifications.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium]ClearFocusedNode doesn't clear the cursor or selection in editable div...
commit-queue@webkit.org [Wed, 21 Sep 2011 16:39:50 +0000 (16:39 +0000)]
[chromium]ClearFocusedNode doesn't clear the cursor or selection in editable div element.
https://bugs.webkit.org/show_bug.cgi?id=68351

Patch by chandra shekar vallala <chandra.vallala@gmail.com> on 2011-09-21
Reviewed by Darin Fisher.

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::clearFocusedNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNew layout tests for the JS bindings related to <track>:
annacc@chromium.org [Wed, 21 Sep 2011 16:27:30 +0000 (16:27 +0000)]
New layout tests for the JS bindings related to <track>:
    e.g. TextTrack, TextTrackCue, TextTrackCueList, MutableTextTrack.
https://bugs.webkit.org/show_bug.cgi?id=68194

Reviewed by Eric Carlson.

* media/track/track-mutable-expected.txt: Added.
* media/track/track-mutable.html: Added.
* media/track/track-text-track-cue-list-expected.txt: Added.
* media/track/track-text-track-cue-list.html: Added.
* media/track/track-text-track-expected.txt: Added.
* media/track/track-text-track.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoActually skip the test (forgot in the previous commit). Sorry for the noise.
kbalazs@webkit.org [Wed, 21 Sep 2011 16:19:54 +0000 (16:19 +0000)]
Actually skip the test (forgot in the previous commit). Sorry for the noise.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt][WK2] plugins/mouse-click-iframe-to-plugin.html fails since enabled in r95626
kbalazs@webkit.org [Wed, 21 Sep 2011 16:15:30 +0000 (16:15 +0000)]
[Qt][WK2] plugins/mouse-click-iframe-to-plugin.html fails since enabled in r95626
https://bugs.webkit.org/show_bug.cgi?id=68539

Unreviewed gardening.

* platform/qt-wk2/Skipped: skip the test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: introduce Page.enable and Page.disable
pfeldman@chromium.org [Wed, 21 Sep 2011 16:13:48 +0000 (16:13 +0000)]
Web Inspector: introduce Page.enable and Page.disable
https://bugs.webkit.org/show_bug.cgi?id=68530

Otherwise protocol is violating the contract of not sending
notifications by default.

Reviewed by Yury Semikhatsky.

* inspector/Inspector.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed; new baselines (Skia on Mac)
caryclark@google.com [Wed, 21 Sep 2011 15:51:51 +0000 (15:51 +0000)]
Unreviewed; new baselines (Skia on Mac)

This separates test failures that are specific to CG Mac from failures
for Skia on Mac. Most of these changes are specific to Leopard, but a
handful add new fail flavors for all Mac variations.

* LayoutTests/platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: add minimal error handling to the DOM breakpoints.
pfeldman@chromium.org [Wed, 21 Sep 2011 15:39:53 +0000 (15:39 +0000)]
Web Inspector: add minimal error handling to the DOM breakpoints.
https://bugs.webkit.org/show_bug.cgi?id=68537

Reviewed by Yury Semikhatsky.

* inspector/InspectorDOMAgent.h:
* inspector/InspectorDOMDebuggerAgent.cpp:
(WebCore::domTypeForName):
(WebCore::InspectorDOMDebuggerAgent::setDOMBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::removeDOMBreakpoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, GTK baselines for
philn@webkit.org [Wed, 21 Sep 2011 15:36:47 +0000 (15:36 +0000)]
Unreviewed, GTK baselines for
cross-origin-xsl-redirect-BLOCKED.html which were removed by mistake.

* platform/gtk/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: make WebInspector a bit more timeline friendly.
loislo@chromium.org [Wed, 21 Sep 2011 15:19:16 +0000 (15:19 +0000)]
Web Inspector: make WebInspector a bit more timeline friendly.
https://bugs.webkit.org/show_bug.cgi?id=68534

I found that the maximum captured stack frame depth tracked by timeline is not
very convenient because the average depth of call stack considerably more than five.
Another useful trick is console.timeStamp for all backend calls.

Reviewed by Yury Semikhatsky.

* inspector/CodeGeneratorInspector.pm:
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._toggleTimelineButtonClicked):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt][WK2] Implement Download support in WebProcess
commit-queue@webkit.org [Wed, 21 Sep 2011 15:10:43 +0000 (15:10 +0000)]
[Qt][WK2] Implement Download support in WebProcess
https://bugs.webkit.org/show_bug.cgi?id=68153

Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2011-09-21
Reviewed by Andreas Kling.

Source/WebCore:

Refactored QNetworkReplyHandler::finish() in order to add
and use the static function QNetworkReplyHandler::errorForReply().
This will be used by our Download implementation in WebKit2 (WebProcess)
when handling ResourceError.

* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::finish):
(WebCore::QNetworkReplyHandler::errorForReply):
* platform/network/qt/QNetworkReplyHandler.h:
* platform/network/qt/ResourceRequest.h:

Source/WebKit2:

We implement the necessary functions of Download.h, and our QtFileDownloader
to handle all network communication and call the necessary functions of Download.

We use the download policy for any MIME type not supported by WebKit. This
behaves like Qt non-WebKit2 except that we don't force download when
we encounter Content-Disposition: attachment. We still use the "filename="
field for file name suggestion though.

Based on original patches by: Kimmo Kinnunen <kimmo.t.kinnunen@nokia.com>,
Jocelyn Turcotte <jocelyn.turcotte@nokia.com>, Simon Hausmann <simon.hausmann@nokia.com>
and Zalan Bujtas <zalan.bujtas@nokia.com>.

* UIProcess/API/qt/qweberror.cpp: Adding DownloadError
(QWebError::type):
* UIProcess/API/qt/qweberror.h: Adding DownloadError
* WebKit2.pro:
* WebProcess/Downloads/Download.cpp: Adding QtFileDownloader, Qt platform specific
(WebKit::Download::Download):
* WebProcess/Downloads/Download.h: Adding QtFileDownloader, Qt platform specific
* WebProcess/Downloads/qt/DownloadQt.cpp:
(WebKit::Download::start):
(WebKit::Download::startWithHandle):
(WebKit::Download::cancel):
(WebKit::Download::platformInvalidate):
(WebKit::Download::didDecideDestination):
* WebProcess/Downloads/qt/QtFileDownloader.cpp: Added.
(WebKit::QtFileDownloader::QtFileDownloader):
(WebKit::QtFileDownloader::~QtFileDownloader):
(WebKit::QtFileDownloader::determineFilename):
(WebKit::QtFileDownloader::decidedDestination):
(WebKit::QtFileDownloader::abortDownloadWritingAndEmitError):
(WebKit::QtFileDownloader::onReadyRead):
(WebKit::QtFileDownloader::onFinished):
(WebKit::QtFileDownloader::onError):
(WebKit::QtFileDownloader::cancel):
* WebProcess/Downloads/qt/QtFileDownloader.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, skip flaky media test on GTK.
philn@webkit.org [Wed, 21 Sep 2011 14:59:13 +0000 (14:59 +0000)]
Unreviewed, skip flaky media test on GTK.

* platform/gtk/Skipped: Skip media/media-blocked-by-beforeload.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agogarden-o-matic command should explain that it is starting a local server
abarth@webkit.org [Wed, 21 Sep 2011 14:58:15 +0000 (14:58 +0000)]
garden-o-matic command should explain that it is starting a local server
https://bugs.webkit.org/show_bug.cgi?id=68486

Reviewed by Dimitri Glazkov.

In the user study, both participants didn't understand why the
garden-o-matic command appeared to hang.  This patch adds an
explaination of what's going on.  It also adds a confirmation prompt
before launching the browser to give the user a chance to read the
text.  If that's too much of a speed bump, we can iterate.

* Scripts/webkitpy/tool/commands/gardenomatic.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSyntax error in media/audio-delete-while-step-button-clicked.html
philn@webkit.org [Wed, 21 Sep 2011 14:48:34 +0000 (14:48 +0000)]
Syntax error in media/audio-delete-while-step-button-clicked.html
https://bugs.webkit.org/show_bug.cgi?id=68507

Reviewed by Eric Carlson.

* media/audio-delete-while-step-button-clicked.html: Some curly
braces were missing in a try/catch statement.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[EFL] Fix alphabetical sorting problem
gyuyoung.kim@samsung.com [Wed, 21 Sep 2011 14:28:18 +0000 (14:28 +0000)]
[EFL] Fix alphabetical sorting problem
https://bugs.webkit.org/show_bug.cgi?id=68505

Reviewed by Philippe Normand.

* ewk/ewk_util.cpp: Fix wrong alphabetical sorting problem.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Implement KeyDown function for WebKit2 EventSender.
commit-queue@webkit.org [Wed, 21 Sep 2011 14:20:28 +0000 (14:20 +0000)]
[Qt] Implement KeyDown function for WebKit2 EventSender.
https://bugs.webkit.org/show_bug.cgi?id=56485

Tools:

Implement the KeyDown function on Qt platform.

Patch by Chang Shu <cshu@webkit.org> on 2011-09-21
Reviewed by Andreas Kling.

* WebKitTestRunner/PlatformWebView.h:
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::TestController):
(WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
* WebKitTestRunner/qt/EventSenderProxyQt.cpp: Added.
(WTR::getModifiers):
(WTR::EventSenderProxy::keyDown):
(buildModifierFlags):
(EventSenderProxy::keyDown):
* WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::PlatformWebView::sendEvent):
* WebKitTestRunner/qt/WebKitTestRunner.pro:

LayoutTests:

Unskip passed tests.

Patch by Chang Shu <cshu@webkit.org> on 2011-09-21
Reviewed by Andreas Kling.

* platform/qt-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: UI performance test for Resource panel first open experience.
loislo@chromium.org [Wed, 21 Sep 2011 14:06:45 +0000 (14:06 +0000)]
Web Inspector: UI performance test for Resource panel first open experience.
https://bugs.webkit.org/show_bug.cgi?id=68527

Reviewed by Pavel Feldman.

* inspector/performance/resources/first-open-resources.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: extend UI perf tests coverage. Elements panel opens first time.
loislo@chromium.org [Wed, 21 Sep 2011 14:04:24 +0000 (14:04 +0000)]
Web Inspector: extend UI perf tests coverage. Elements panel opens first time.
https://bugs.webkit.org/show_bug.cgi?id=68432

Reviewed by Pavel Feldman.

* inspector/performance/resources/first-open-elements.html: Added.
* inspector/performance/resources/performance-test.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, skip some more flaky SVG tests on GTK.
philn@webkit.org [Wed, 21 Sep 2011 13:53:16 +0000 (13:53 +0000)]
Unreviewed, skip some more flaky SVG tests on GTK.

* platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, fix baselines for cross-origin-xsl-redirect-BLOCKED
jochen@chromium.org [Wed, 21 Sep 2011 13:34:13 +0000 (13:34 +0000)]
Unreviewed, fix baselines for cross-origin-xsl-redirect-BLOCKED

* http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
* platform/chromium-cg-mac/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
* platform/chromium-mac/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
* platform/chromium-win/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
* platform/gtk/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt: Removed
* platform/mac-wk2/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
* platform/qt-wk2/Skipped:
* platform/qt-wk2/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
* platform/qt/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.png: Removed
* platform/qt/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt: Removed
* platform/win-wk2/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: paint box model colors in Metrics sidebar at all times, do not draw...
pfeldman@chromium.org [Wed, 21 Sep 2011 13:33:10 +0000 (13:33 +0000)]
Web Inspector: paint box model colors in Metrics sidebar at all times, do not draw box outlines.
https://bugs.webkit.org/show_bug.cgi?id=68240

Today we paint backgrounds in Metrics box model on hover only - should be painted at all
times for the reference. Outlining boxes is highlight is wrong since outlines are outside
the corresponding box regions. We've seen few reports on that + Firebug does not do borders
for that reason.

Reviewed by Yury Semikhatsky.

* inspector/DOMNodeHighlighter.cpp:
* inspector/DOMNodeHighlighter.h:
* inspector/Inspector.json:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::setHighlightDataFromConfig):
* inspector/front-end/Color.js:
* inspector/front-end/MetricsSidebarPane.js:
(WebInspector.MetricsSidebarPane.prototype._highlightDOMNode):
(WebInspector.MetricsSidebarPane.prototype._updateMetrics):
* inspector/front-end/inspector.css:
(.metrics .label):
* inspector/front-end/inspector.js:
(WebInspector.buildHighlightConfig):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] rebaseline caused by r95567
keishi@webkit.org [Wed, 21 Sep 2011 13:14:57 +0000 (13:14 +0000)]
[chromium] rebaseline caused by r95567

* platform/chromium-cg-mac-leopard/fast/clip/overflow-border-radius-fixed-position-expected.png: Added.
* platform/chromium-mac-leopard: Added.
* platform/chromium-mac-leopard/fast: Added.
* platform/chromium-mac-leopard/fast/clip: Added.
* platform/chromium-mac-leopard/fast/clip/overflow-border-radius-fixed-position-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoProtect against misuse of EventListenerIterator.
commit-queue@webkit.org [Wed, 21 Sep 2011 13:08:19 +0000 (13:08 +0000)]
Protect against misuse of EventListenerIterator.
https://bugs.webkit.org/show_bug.cgi?id=68364

Patch by Andreas Kling <kling@webkit.org> on 2011-09-21
Reviewed by Darin Adler.

In debug mode, keep track of the number of active EventListenerIterators
on an EventListenerMap, and assert that there are no iterators when the
map is being modified.

* dom/EventListenerMap.cpp:
(WebCore::EventListenerMap::EventListenerMap):
(WebCore::EventListenerMap::clear):
(WebCore::EventListenerMap::add):
(WebCore::EventListenerMap::remove):
(WebCore::EventListenerMap::find):
(WebCore::EventListenerMap::removeFirstEventListenerCreatedFromMarkup):
(WebCore::EventListenerMap::copyEventListenersNotCreatedFromMarkupToTarget):
(WebCore::EventListenerIterator::EventListenerIterator):
(WebCore::EventListenerIterator::~EventListenerIterator):
* dom/EventListenerMap.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] rebaseline caused by r95599
keishi@webkit.org [Wed, 21 Sep 2011 13:05:56 +0000 (13:05 +0000)]
[chromium] rebaseline caused by r95599

* fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt: Added.
* platform/chromium-mac-leopard: Removed.
* platform/chromium-mac/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.png: Added.
* platform/chromium-win/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.png: Added.
* platform/chromium-win/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt: Added.
* platform/chromium/test_expectations.txt:
* platform/gtk/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, skip 2 GTK flaky tests.
philn@webkit.org [Wed, 21 Sep 2011 12:52:16 +0000 (12:52 +0000)]
Unreviewed, skip 2 GTK flaky tests.

* platform/gtk/Skipped: Skip
http/tests/websocket/tests/hixie76/error-detect.html and
svg/zoom/page/zoom-svg-through-object-with-auto-size.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt][WK2] Unskip some cookies related layout tests.
alexis.menard@openbossa.org [Wed, 21 Sep 2011 12:13:03 +0000 (12:13 +0000)]
[Qt][WK2] Unskip some cookies related layout tests.
https://bugs.webkit.org/show_bug.cgi?id=68484

Reviewed by Csaba Osztrogon√°c.

Unskip some cookies related layout tests as they seems to work fine with
--iterations 1000.

* platform/qt-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt][Mac] Unreviewed gardening after r95601.
rgabor@webkit.org [Wed, 21 Sep 2011 11:57:23 +0000 (11:57 +0000)]
[Qt][Mac] Unreviewed gardening after r95601.

* platform/qt-mac/Skipped: Paint the Qt-Mac bot green.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: minor fixes in the DOM domain of the protocol.
pfeldman@chromium.org [Wed, 21 Sep 2011 11:50:05 +0000 (11:50 +0000)]
Web Inspector: minor fixes in the DOM domain of the protocol.
https://bugs.webkit.org/show_bug.cgi?id=68517

Reviewed by Yury Semikhatsky.

* inspector/Inspector.json:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::setAttributesAsText):
* inspector/InspectorDOMAgent.h:
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode.prototype.setAttribute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: limit the use of "Resource" term in the protocol.
pfeldman@chromium.org [Wed, 21 Sep 2011 11:45:32 +0000 (11:45 +0000)]
Web Inspector: limit the use of "Resource" term in the protocol.
https://bugs.webkit.org/show_bug.cgi?id=68250

Reviewed by Yury Semikhatsky.

* inspector/Inspector.json:
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::markResourceAsCached):
(WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache):
(WebCore::InspectorResourceAgent::setExtraHTTPHeaders):
(WebCore::InspectorResourceAgent::getResponseBody):
* inspector/InspectorResourceAgent.h:
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onAddRequestHeaders):
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkManager.prototype.requestContent):
(WebInspector.NetworkDispatcher.prototype.requestServedFromCache):
(WebInspector.NetworkDispatcher.prototype.requestServedFromMemoryCache):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r95608.
commit-queue@webkit.org [Wed, 21 Sep 2011 11:39:41 +0000 (11:39 +0000)]
Unreviewed, rolling out r95608.
http://trac.webkit.org/changeset/95608
https://bugs.webkit.org/show_bug.cgi?id=68521

breaks GTK and Windows builds. Please check EWS next time.
(Requested by philn-tp on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-21

Source/WebCore:

* html/HTMLBodyElement.cpp:
(WebCore::adjustForZoom):
(WebCore::HTMLBodyElement::setScrollLeft):
(WebCore::HTMLBodyElement::setScrollTop):
* loader/HistoryController.cpp:
(WebCore::HistoryController::saveScrollPositionAndViewStateToItem):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::scrollX):
(WebCore::DOMWindow::scrollY):
(WebCore::DOMWindow::scrollTo):
* page/Frame.cpp:
(WebCore::Frame::pageScaleFactor):
* page/Frame.h:
* page/FrameView.cpp:
(WebCore::FrameView::applyOverflowToViewport):
(WebCore::FrameView::scrollXForFixedPosition):
(WebCore::FrameView::scrollYForFixedPosition):

LayoutTests:

* fast/events/scale-and-scroll-body-expected.png: Removed.
* fast/events/scale-and-scroll-body-expected.txt: Removed.
* fast/events/scale-and-scroll-body.html: Removed.
* fast/events/scale-and-scroll-iframe-body-expected.png: Removed.
* fast/events/scale-and-scroll-iframe-body-expected.txt: Removed.
* fast/events/scale-and-scroll-iframe-body.html: Removed.
* fast/events/scale-and-scroll-iframe-window-expected.png: Removed.
* fast/events/scale-and-scroll-iframe-window-expected.txt: Removed.
* fast/events/scale-and-scroll-iframe-window.html: Removed.
* fast/events/scale-and-scroll-window-expected.png: Removed.
* fast/events/scale-and-scroll-window-expected.txt: Removed.
* fast/events/scale-and-scroll-window.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: console panel's scroller is not properly aligned.
pfeldman@chromium.org [Wed, 21 Sep 2011 11:37:06 +0000 (11:37 +0000)]
Web Inspector: console panel's scroller is not properly aligned.
https://bugs.webkit.org/show_bug.cgi?id=68448

Reviewed by Yury Semikhatsky.

* inspector/front-end/inspector.css:
(#console-view):
(#console-messages):
(#drawer #console-messages):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, GTK baseslines for 2 new tests and skip a flaky svg test.
philn@webkit.org [Wed, 21 Sep 2011 11:25:43 +0000 (11:25 +0000)]
Unreviewed, GTK baseslines for 2 new tests and skip a flaky svg test.

* platform/gtk/Skipped: Skip svg/W3C-SVG-1.1-SE/filters-image-05-f.svg
* platform/gtk/fast/clip/overflow-border-radius-fixed-position-expected.png: Added.
* platform/gtk/fast/clip/overflow-border-radius-fixed-position-expected.txt: Added.
* platform/gtk/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.png: Added.
* platform/gtk/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt][WK2] http/tests/security/cross-origin-xsl-redirect-BLOCKED.html fails
rgabor@webkit.org [Wed, 21 Sep 2011 11:16:05 +0000 (11:16 +0000)]
[Qt][WK2] http/tests/security/cross-origin-xsl-redirect-BLOCKED.html fails
https://bugs.webkit.org/show_bug.cgi?id=68515

* platform/qt-wk2/Skipped: Skip http/tests/security/cross-origin-xsl-redirect-BLOCKED.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSource/WebCore: https://bugs.webkit.org/show_bug.cgi?id=68081
hclam@chromium.org [Wed, 21 Sep 2011 11:01:43 +0000 (11:01 +0000)]
Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=68081
Fix scroll in page scaling mode.

Reviewed by Simon Fraser.

The following things are done in this patch:
1. Rename Frame::pageScaleFactor() to Frame::frameScaleFactor() to better
   reflect its purpose.
2. Frame::frameScaleFactor() returns the scale factor of this frame with
   respect to the container. So for the main frame it'll return the scale
   factor of the page, inner frames will return 1.0
3. scrollBy(), scrollX() and scrollY() to take into account of the frame
   scale factor, causing incorrect coordinates reported to Javascript.

Tests: fast/events/scale-and-scroll-body.html
       fast/events/scale-and-scroll-iframe-body.html
       fast/events/scale-and-scroll-iframe-window.html
       fast/events/scale-and-scroll-window.html

* html/HTMLBodyElement.cpp:
(WebCore::adjustForZoom):
(WebCore::HTMLBodyElement::setScrollLeft):
(WebCore::HTMLBodyElement::setScrollTop):
* loader/HistoryController.cpp:
(WebCore::HistoryController::saveScrollPositionAndViewStateToItem):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::scrollX):
(WebCore::DOMWindow::scrollY):
(WebCore::DOMWindow::scrollTo):
* page/Frame.cpp:
(WebCore::Frame::frameScaleFactor): Return page's scale factor if this is
                                    main frame, otherwise 1.0
* page/Frame.h:
* page/FrameView.cpp:
(WebCore::FrameView::applyOverflowToViewport):
(WebCore::FrameView::scrollXForFixedPosition):
(WebCore::FrameView::scrollYForFixedPosition):

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=68081
Add layout test for page scale and scrolling.

Reviewed by Simon Fraser.

Add tests to cover the following cases:
1. Scale and scroll window
2. Scale and scroll document.body
3. Scale and scroll iframe's contentWindow
4. Scale and scroll iframe's contentDocument.body

* fast/events/scale-and-scroll-body-expected.png: Added.
* fast/events/scale-and-scroll-body-expected.txt: Added.
* fast/events/scale-and-scroll-body.html: Added.
* fast/events/scale-and-scroll-iframe-body-expected.png: Added.
* fast/events/scale-and-scroll-iframe-body-expected.txt: Added.
* fast/events/scale-and-scroll-iframe-body.html: Added.
* fast/events/scale-and-scroll-iframe-window-expected.png: Added.
* fast/events/scale-and-scroll-iframe-window-expected.txt: Added.
* fast/events/scale-and-scroll-iframe-window.html: Added.
* fast/events/scale-and-scroll-window-expected.png: Added.
* fast/events/scale-and-scroll-window-expected.txt: Added.
* fast/events/scale-and-scroll-window.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/9890932> "Open PDF in Preview" on two PDFs of the same name does...
mrowe@apple.com [Wed, 21 Sep 2011 10:16:53 +0000 (10:16 +0000)]
<rdar://problem/9890932> "Open PDF in Preview" on two PDFs of the same name does nothing the second time

The logic in PDFViewController::pathToPDFOnDisk that deals with constructing a unique
file name if a file of the suggested name already exists was incorrect. It was appending
the template used by mkstemps to the directory name component of the path rather than
using it as a prefix on the filename portion of the path. This resulted in a template path
like WebKitPDFs-ABCDEFXXXXXX-/foo.pdf where WebKitPDFs-ABCDEF/XXXXXX-foo.pdf was expected.

Reviewed by Jon Honeycutt.

* UIProcess/API/mac/PDFViewController.mm:
(WebKit::PDFViewController::pathToPDFOnDisk): Append the template as a new path component,
then append the suggested file name to that component.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, GTK rebaseline, skip some flaky worker tests and 2
philn@webkit.org [Wed, 21 Sep 2011 09:49:41 +0000 (09:49 +0000)]
Unreviewed, GTK rebaseline, skip some flaky worker tests and 2
failing http tests.

* platform/gtk/Skipped:
* platform/gtk/editing/deleting/regional-indicators-expected.txt:
* platform/gtk/fast/text/justify-ideograph-complex-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, GTK rebaseline and skip and a11y failing test.
philn@webkit.org [Wed, 21 Sep 2011 09:19:09 +0000 (09:19 +0000)]
Unreviewed, GTK rebaseline and skip and a11y failing test.

* platform/gtk/Skipped: Skip accessibility/aria-hidden-updates-alldescendants.html
* platform/gtk/editing/deleting/merge-whitespace-pre-expected.txt:
Rebaseline after r95335.
* platform/gtk/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Remove Qt specific code from css/SelectorChecker.cpp
abecsi@webkit.org [Wed, 21 Sep 2011 08:59:13 +0000 (08:59 +0000)]
[Qt] Remove Qt specific code from css/SelectorChecker.cpp
https://bugs.webkit.org/show_bug.cgi?id=67702

Reviewed by Csaba Osztrogon√°c.

Source/WebCore:

No new tests needed.

* css/SelectorChecker.cpp: Move Qt-specific code to the Qt-specific WebPlatformStrategies.
(WebCore::SelectorChecker::determineLinkStateSlowCase):
* platform/VisitedLinkStrategy.h:

Source/WebKit/mac:

* WebCoreSupport/WebPlatformStrategies.h:
* WebCoreSupport/WebPlatformStrategies.mm:
(WebPlatformStrategies::isLinkVisited):

Source/WebKit/qt:

* WebCoreSupport/WebPlatformStrategies.cpp: Check the Qt global history here, instead of a platform independent file.
(WebPlatformStrategies::isLinkVisited):
* WebCoreSupport/WebPlatformStrategies.h:

Source/WebKit/win:

* WebCoreSupport/WebPlatformStrategies.cpp: Modify to match new prototype.
(WebPlatformStrategies::isLinkVisited):
* WebCoreSupport/WebPlatformStrategies.h: Ditto.

Source/WebKit/wince:

* WebCoreSupport/PlatformStrategiesWinCE.cpp:
(PlatformStrategiesWinCE::addVisitedLink):
* WebCoreSupport/PlatformStrategiesWinCE.h:

Source/WebKit2:

* WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: Modify to match new prototype.
(WebKit::WebPlatformStrategies::isLinkVisited):
(WebKit::WebPlatformStrategies::addVisitedLink):
* WebProcess/WebCoreSupport/WebPlatformStrategies.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, GTK rebaseline after r95566.
philn@webkit.org [Wed, 21 Sep 2011 08:41:57 +0000 (08:41 +0000)]
Unreviewed, GTK rebaseline after r95566.

* platform/gtk/mathml/xHeight-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed Skipped list update for meter-element-repaint-on-update-value.html,
morrita@google.com [Wed, 21 Sep 2011 07:09:46 +0000 (07:09 +0000)]
Unreviewed Skipped list update for meter-element-repaint-on-update-value.html,
which needs windows

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Unreviewed gardening.
ossy@webkit.org [Wed, 21 Sep 2011 07:01:09 +0000 (07:01 +0000)]
[Qt] Unreviewed gardening.

* platform/qt-mac/Skipped:
* platform/qt-wk2/Skipped:
* platform/qt/fast/clip/overflow-border-radius-fixed-position-expected.png: Added.
* platform/qt/fast/clip/overflow-border-radius-fixed-position-expected.txt: Added.
* platform/qt/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.png: Added.
* platform/qt/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt: Added.
* platform/qt/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.png: Added.
* platform/qt/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoStyle changes on forwarded shadow children should trigger shadow renderer reconstruction.
morrita@google.com [Wed, 21 Sep 2011 05:58:02 +0000 (05:58 +0000)]
Style changes on forwarded shadow children should trigger shadow renderer reconstruction.
https://bugs.webkit.org/show_bug.cgi?id=68228

Reviewed by Dimitri Glazkov.

Currently style changes on forwarded shadow child triggers
Node::reattach() only for the forwarded node. But it should
invalidate whole renderers on the shadow tree because
ShadowContentElement expects its inclusions to be attached and to
create renderers in the inclusion order. But single node
reattach() violates the expectation and possibly creates
inconsistent render tree.

This change makes NodeRenderingContext to go
AttachContentForwarded, where the ShadowContentElement::attach()
happens, only during ShadowRoot::attach(), not for style-change
triggered Node::attach() on the forwarded nodes.

Note that the altering phase AttachContentLight doesn't create
renderers for the forwarded nodes. Instead of that, it possibly
triggers shadow subtree reconstruction on
NodeRenderingContext::hostChildrenChanged().

No new tests. This is a defensive change. There is no visible
difference at this time.

* dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::NodeRenderingContext):
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::isInclusionSelectorActive):
* dom/ShadowRoot.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<meter> doesn't update rendering when its value is changed.
morrita@google.com [Wed, 21 Sep 2011 05:41:27 +0000 (05:41 +0000)]
<meter> doesn't update rendering when its value is changed.
https://bugs.webkit.org/show_bug.cgi?id=67614

Reviewed by Dimitri Glazkov.

Source/WebCore:

It lacks repaint() when the value is changed.

For non-native appearance it works because the indicator is
implemented in shadow DOM, for native appearance, repainting should be
handled explicitly.

Test: fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value.html

* html/HTMLMeterElement.cpp:
(WebCore::HTMLMeterElement::didElementStateChange):
* rendering/RenderMeter.cpp:
(WebCore::RenderMeter::updateFromElement):
* rendering/RenderMeter.h:
* rendering/RenderProgress.cpp:
(WebCore::RenderProgress::updateAnimationState):

LayoutTests:

* fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.png: Added.
* platform/chromium/test_expectations.txt:
* platform/mac/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt: Added.
* platform/mac/dom/HTMLMeterElement/meter-element-repaint-on-update-value.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMove RenderObject::markContainingBlocksForLayout() to RenderObject.cpp.
tkent@chromium.org [Wed, 21 Sep 2011 05:38:48 +0000 (05:38 +0000)]
Move RenderObject::markContainingBlocksForLayout() to RenderObject.cpp.
https://bugs.webkit.org/show_bug.cgi?id=67989

Reviewed by Ryosuke Niwa.

No new tests because of no behavior change.

* rendering/RenderObject.cpp:
(WebCore::objectIsRelayoutBoundary): Moved from RenderObject.h.
(WebCore::RenderObject::markContainingBlocksForLayout): Moved from RenderObject.h
* rendering/RenderObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] changed test expectations for zoom-svg-through-object-with-auto-size.html:wq
keishi@webkit.org [Wed, 21 Sep 2011 05:23:13 +0000 (05:23 +0000)]
[chromium] changed test expectations for zoom-svg-through-object-with-auto-size.html:wq

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSome Heap cleanup.
ggaren@apple.com [Wed, 21 Sep 2011 04:19:36 +0000 (04:19 +0000)]
Some Heap cleanup.

Reviewed by Beth Dakin.

* heap/MarkedBlock.cpp:
(JSC::MarkedBlock::blessNewBlock): Removed blessNewBlockForSlowPath()
because it was unused; renamed blessNewBlockForFastPath() to blessNewBlock()
since there is only one now.

* heap/MarkedBlock.h: Removed ownerSet-related stuff since it was unused.
Updated mark bit overhead calculation. Deployed atomsPerBlock in one
place where we were recalculating it.

* heap/MarkedSpace.cpp:
(JSC::MarkedSpace::addBlock): Updated for rename.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agogarden-o-matic unit test fail because Safari 5.1 doesn't enumerate dictionaries in...
abarth@webkit.org [Wed, 21 Sep 2011 03:37:05 +0000 (03:37 +0000)]
garden-o-matic unit test fail because Safari 5.1 doesn't enumerate dictionaries in the same order as V8
https://bugs.webkit.org/show_bug.cgi?id=68496

Reviewed by Dimitri Glazkov.

This patch adds a bunch of sorting to make sure things happen in a
predictable order in both JavaScriptCore and V8.  We've talked before
about whether these two JavaScript engines should enumerate
dictionaries in the same order, but the consensus has been that they
shouldn't.  Personally, I disagree with that consensus, but such is life.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDFG JIT always speculates integer on modulo
fpizlo@apple.com [Wed, 21 Sep 2011 02:22:52 +0000 (02:22 +0000)]
DFG JIT always speculates integer on modulo
https://bugs.webkit.org/show_bug.cgi?id=68485

Reviewed by Oliver Hunt.

Added support for double modulo, which is a call to fmod().
Also added support for recording the old JIT's statistics
on op_mod and propagating them along the graph. Finally,
fixed a goof in the ArithNodeFlags propagation logic that
was made obvious when I started testing ArithMod.

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::makeSafe):
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGNode.h:
(JSC::DFG::Node::hasArithNodeFlags):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateArithNodeFlags):
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::fixupNode):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSupport for multiple <link rel="icon"> favicon elements.
commit-queue@webkit.org [Wed, 21 Sep 2011 01:49:03 +0000 (01:49 +0000)]
Support for multiple <link rel="icon"> favicon elements.
https://bugs.webkit.org/show_bug.cgi?id=65564

Patch by Rachel Blum <groby@chromium.org> on 2011-09-20
Reviewed by Darin Fisher.

No tests - purely an API change. (And API is not exposed to LayoutTests)

* dom/Document.cpp:
(WebCore::Document::iconURLs):
(WebCore::Document::addIconURL):
* dom/Document.h:
* dom/IconURL.cpp:
(WebCore::toIconIndex):
* dom/IconURL.h:
(WebCore::IconURL::IconURL):
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::process):
* loader/LinkLoader.cpp:
(WebCore::LinkLoader::loadLink):
* loader/LinkLoader.h:
* loader/icon/IconController.cpp:
(WebCore::IconController::urlsForTypes):
(WebCore::IconController::appendToIconURLs):
(WebCore::IconController::defaultURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agogarden-o-matic doesn't work in Safari 5.1 because Safari 5.1 lacks Function.prototype...
abarth@webkit.org [Wed, 21 Sep 2011 01:48:50 +0000 (01:48 +0000)]
garden-o-matic doesn't work in Safari 5.1 because Safari 5.1 lacks Function.prototype.bind
https://bugs.webkit.org/show_bug.cgi?id=68495

Reviewed by Dimitri Glazkov.

This patch adds an implementation of Function.prototype.bind if the browser lacks one.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[css3-flexbox] cleanup padding width calculations
ojan@chromium.org [Wed, 21 Sep 2011 01:30:06 +0000 (01:30 +0000)]
[css3-flexbox] cleanup padding width calculations
https://bugs.webkit.org/show_bug.cgi?id=68490

Reviewed by Tony Chang.

No new tests. Existing tests cover the refactor.

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::logicalBorderAndPaddingWidthForChild):
(WebCore::RenderFlexibleBox::logicalScrollbarHeightForChild):
(WebCore::RenderFlexibleBox::preferredLogicalContentWidthForFlexItem):
(WebCore::RenderFlexibleBox::computePreferredLogicalWidth):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection):
* rendering/RenderFlexibleBox.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoThis CL makes it possible to create a blob from Chromium.
jcivelli@chromium.org [Wed, 21 Sep 2011 01:07:43 +0000 (01:07 +0000)]
This CL makes it possible to create a blob from Chromium.
https://bugs.webkit.org/show_bug.cgi?id=68286

Reviewed by Darin Fisher.

* WebKit.gyp:
* public/WebBlob.h: Added.
* src/WebBlob.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] rebaseline caused by r95567
keishi@webkit.org [Wed, 21 Sep 2011 01:04:43 +0000 (01:04 +0000)]
[chromium] rebaseline caused by r95567

* platform/chromium-cg-mac/fast/clip/overflow-border-radius-fixed-position-expected.png: Added.
* platform/chromium-linux-x86/fast/clip: Removed.
* platform/chromium-linux/fast/clip/overflow-border-radius-fixed-position-expected.png: Added.
* platform/chromium-mac/fast/clip/overflow-border-radius-fixed-position-expected.png: Added.
* platform/chromium-win/fast/clip/overflow-border-radius-fixed-position-expected.png: Added.
* platform/chromium-win/fast/clip/overflow-border-radius-fixed-position-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[NRWT] REGRESSION: Local loader tests are failing on machines that lost /tmp/LayoutTe...
eric@webkit.org [Wed, 21 Sep 2011 00:48:14 +0000 (00:48 +0000)]
[NRWT] REGRESSION: Local loader tests are failing on machines that lost /tmp/LayoutTests symlink
https://bugs.webkit.org/show_bug.cgi?id=65781

Reviewed by Ryosuke Niwa.

Instead of making NRWT create the symlink, I made DumpRenderTree smart enough
to resolve the passed in url relative to the absolute url for the test.
For http tests, since the test url is an http url, we can't resolve relative
to the test path, and thus use a new LOCAL_RESOURCE_ROOT environment variable
for resolving.

I believe this is a better approach than the on used in the Qt and Chromium DRT's
(which resolves the path relative to the built location of the DRT executable)
and we should move this new code into a shared location in a follow-up patch.

It turns out that there was a second use for pathToLocalResource, used by one
test (http/tests/plugins/post-url-file.html) used for getting a path to /tmp.
To support this test I made the new pathToLocalResource smart enough to map
/tmp to DUMPRENDERTREE_TEMP (which is already defined for all ports).

* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::pathToLocalResource):
* Scripts/webkitpy/layout_tests/port/webkit.py: Set LOCAL_RESOURCE_ROOT for use by DRT.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNeed to specify a django version, instead of using default
commit-queue@webkit.org [Wed, 21 Sep 2011 00:34:41 +0000 (00:34 +0000)]
Need to specify a django version, instead of using default
https://bugs.webkit.org/show_bug.cgi?id=68398

Patch by Tom Zakrajsek <tomz@codeaurora.org> on 2011-09-20
Reviewed by Eric Seidel.

* QueueStatusServer/__init__.py:
* QueueStatusServer/main.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix clang compile errors in Web Audio
jer.noble@apple.com [Wed, 21 Sep 2011 00:16:52 +0000 (00:16 +0000)]
Fix clang compile errors in Web Audio
https://bugs.webkit.org/show_bug.cgi?id=68384

Reviewed by David Levin.

No new tests; no net change in functionality.

* platform/graphics/MediaPlayer.h: Forward declare (instead of including directly)
    AudioSourceProvider.
* webaudio/AudioChannelMerger.cpp:
(WebCore::AudioChannelMerger::checkNumberOfChannelsForInput): Remove unused parameter name.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoGet rid of PluginView::setBoundsSize from WebKit2
andersca@apple.com [Wed, 21 Sep 2011 00:05:31 +0000 (00:05 +0000)]
Get rid of PluginView::setBoundsSize from WebKit2
https://bugs.webkit.org/show_bug.cgi?id=68489

Reviewed by Dan Bernstein.

Remove m_boundsSize and the setter since they aren't used anywhere.

* WebProcess/Plugins/PluginView.cpp:
* WebProcess/Plugins/PluginView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdate committers.py with a few more contributor contacts
commit-queue@webkit.org [Wed, 21 Sep 2011 00:04:30 +0000 (00:04 +0000)]
Update committers.py with a few more contributor contacts
https://bugs.webkit.org/show_bug.cgi?id=68487

Patch by Tom Zakrajsek <tomz@codeaurora.org> on 2011-09-20
Reviewed by Eric Seidel.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix webkitpy unit tests after 95547 and 95549
commit-queue@webkit.org [Tue, 20 Sep 2011 23:53:22 +0000 (23:53 +0000)]
Fix webkitpy unit tests after 95547 and 95549
https://bugs.webkit.org/show_bug.cgi?id=68483

Patch by Leandro Pereira <leandro@profusion.mobi> on 2011-09-20
Reviewed by Adam Barth.

Fix tests for ChangeLog.touched_files() and ChangeLog.parse_entries_from_file().

* Scripts/webkitpy/common/checkout/changelog_unittest.py: While testing
parse_entries_from_file(), use StringIO and entry.reviewer_text().
While testing parse_latest_entry_from_file(), expect the correct
touched_files() list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDirectory Upload: parent path can truncate first char of the correct path
johnnyg@google.com [Tue, 20 Sep 2011 23:49:19 +0000 (23:49 +0000)]
Directory Upload: parent path can truncate first char of the correct path
https://bugs.webkit.org/show_bug.cgi?id=66695

Source/WebCore:

In some cases, if the parent path we compute ends with a separator
character like '/' or 'C:\', by adding one in an attempt to grab the
subsequent separator we actually grab a character of the real path,
which is incorrect.

Reviewed by Darin Fisher.

* html/FileInputType.cpp:
(WebCore::FileInputType::setFileList):

LayoutTests:

Add a test case for when the parent path is '/'.

Reviewed by Darin Fisher.

* fast/forms/input-file-directory-upload.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agogarden-o-matic makes it hard to compare images when scroll bars appear
abarth@webkit.org [Tue, 20 Sep 2011 23:43:26 +0000 (23:43 +0000)]
garden-o-matic makes it hard to compare images when scroll bars appear
https://bugs.webkit.org/show_bug.cgi?id=68482

Reviewed by Eric Seidel.

Because we autoscale image width, the images rescale if we overflow
vertically and get a scrollbar.  That makes it hard to compare two sets
of images.  This patch reserves space for the scrollbar so we won't
have the layout change.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoInvoke CachedResourceLoader::canRequest for all URLs in a redirect chain
jochen@chromium.org [Tue, 20 Sep 2011 23:31:17 +0000 (23:31 +0000)]
Invoke CachedResourceLoader::canRequest for all URLs in a redirect chain
https://bugs.webkit.org/show_bug.cgi?id=68279

Reviewed by Adam Barth.

Source/WebCore:

* loader/cache/CachedResourceLoader.h:
* loader/cache/CachedResourceRequest.cpp:
(WebCore::CachedResourceRequest::willSendRequest):

LayoutTests:

* http/tests/security/resources/cross-origin-xsl-redirect.xml:
* http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
* http/tests/security/cross-origin-xsl-redirect-BLOCKED.html:
* platform/chromium/http/tests/permissionclient/image-permissions-expected.txt:
* platform/chromium/http/tests/permissionclient/image-permissions.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoGenerate WebKit team's page out of committers.py
rniwa@webkit.org [Tue, 20 Sep 2011 23:17:10 +0000 (23:17 +0000)]
Generate WebKit team's page out of committers.py
https://bugs.webkit.org/show_bug.cgi?id=68045

Fix per Daniel's review comment since I had misunderstood the code.

* team.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoGenerate WebKit team's page out of committers.py
rniwa@webkit.org [Tue, 20 Sep 2011 22:57:34 +0000 (22:57 +0000)]
Generate WebKit team's page out of committers.py
https://bugs.webkit.org/show_bug.cgi?id=68045

Reviewed by Daniel Bates.

Add the initial implementation of team.html. This page automatically pulls data from committers.py
There are no areas of expertise but that'll be added once the bug 68061 is fixed.

* team.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agochange RenderFlexibleBox to act on logical coordinates
ojan@chromium.org [Tue, 20 Sep 2011 22:46:19 +0000 (22:46 +0000)]
change RenderFlexibleBox to act on logical coordinates
https://bugs.webkit.org/show_bug.cgi?id=68129

Reviewed by David Hyatt.

Source/WebCore:

This makes RenderFlexibleBox respect direction and writing-mode.
We now properly support the default flex-flow value of "row".

Test: css3/flexbox/writing-modes.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::setLogicalLocationForChild):
* rendering/RenderBlock.h:
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::RenderFlexibleBox::logicalBorderWidthForChild):
(WebCore::RenderFlexibleBox::logicalPaddingWidthForChild):
(WebCore::RenderFlexibleBox::logicalScrollbarHeightForChild):
(WebCore::RenderFlexibleBox::marginStartStyleForChild):
(WebCore::RenderFlexibleBox::marginEndStyleForChild):
(WebCore::RenderFlexibleBox::preferredLogicalContentWidthForFlexItem):
(WebCore::RenderFlexibleBox::layoutInlineDirection):
(WebCore::RenderFlexibleBox::logicalPositiveFlexForChild):
(WebCore::RenderFlexibleBox::logicalNegativeFlexForChild):
(WebCore::RenderFlexibleBox::computePreferredLogicalWidth):
(WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithmInlineDirection):
(WebCore::RenderFlexibleBox::setLogicalOverrideSize):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection):
* rendering/RenderFlexibleBox.h:

LayoutTests:

* css3/flexbox/resources/flexbox.js:
* css3/flexbox/writing-modes-expected.txt: Added.
* css3/flexbox/writing-modes.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUse DEFINE_STATIC_LOCAL to intentionally leak the static RefCountedHFONT object retur...
commit-queue@webkit.org [Tue, 20 Sep 2011 22:39:38 +0000 (22:39 +0000)]
Use DEFINE_STATIC_LOCAL to intentionally leak the static RefCountedHFONT object returned from
FontPlatformData::hashTableDeletedFontValue() to avoid global destructor ordering problems.
https://bugs.webkit.org/show_bug.cgi?id=67906

Patch by Marshall Greenblatt <marshall@chromium.org> on 2011-09-20
Reviewed by Adam Barth.

* platform/graphics/chromium/FontPlatformDataChromiumWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] remove obsolete WebPermissionClient::allowImages method
jochen@chromium.org [Tue, 20 Sep 2011 22:37:58 +0000 (22:37 +0000)]
[chromium] remove obsolete WebPermissionClient::allowImages method
https://bugs.webkit.org/show_bug.cgi?id=68380

Reviewed by Darin Fisher.

* DEPS:
* public/WebPermissionClient.h:
(WebKit::WebPermissionClient::allowImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoHit testing on margins of body and head elements doesn't recur
rniwa@webkit.org [Tue, 20 Sep 2011 22:33:48 +0000 (22:33 +0000)]
Hit testing on margins of body and head elements doesn't recur
https://bugs.webkit.org/show_bug.cgi?id=40753

Reviewed by Darin Adler.

Source/WebCore:

The bug was caused by positionForPointRespectingEditingBoundaries's comparing the editability
of head/body and html elements when hit testing was done inside margins of head and body elements.

Fixed the bug by special-casing html element since margins of head and body elements are special.

Tests: editing/selection/click-on-body-margin.html
       editing/selection/click-on-head-margin.html

* rendering/RenderBlock.cpp:
(WebCore::positionForPointRespectingEditingBoundaries):

LayoutTests:

Add tests to click on margins of head and body elements. WebKit should not
(attempt to) place the caret after or before head and body elements.

* editing/selection/click-on-body-margin-expected.txt: Added.
* editing/selection/click-on-body-margin.html: Added.
* editing/selection/click-on-head-margin-expected.txt: Added.
* editing/selection/click-on-head-margin.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=68480
hyatt@apple.com [Tue, 20 Sep 2011 22:23:41 +0000 (22:23 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=68480

De-virtualize containingBlock() and make RenderView return 0 instead
of itself to make the construction of normal loops that terminate via
a null-check possible.

Fix the only two places in the tree that needed null checks.

Eliminating RenderTableCell::containingBlock() is fine since the base class
does the same thing anyway.

Reviewed by Simon Fraser.

* editing/VisiblePosition.cpp:
(WebCore::VisiblePosition::lineDirectionPointForBlockDirectionNavigation):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::containingBlock):
* rendering/RenderObject.h:
* rendering/RenderTableCell.cpp:
* rendering/RenderTableCell.h:
* rendering/RenderTreeAsText.cpp:
(WebCore::RenderTreeAsText::writeRenderObject):
* rendering/RenderView.cpp:
* rendering/RenderView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] QTouchWebView missing signal tests for loadProgress
commit-queue@webkit.org [Tue, 20 Sep 2011 22:16:36 +0000 (22:16 +0000)]
[Qt] QTouchWebView missing signal tests for loadProgress
https://bugs.webkit.org/show_bug.cgi?id=68442

Patch by Gopal Raghavan <gopal.1.raghavan@nokia.com> on 2011-09-20
Reviewed by Chang Shu.

Added test case to check load progress signal for QTouchWebView

* UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadProgressSignal.qml: Added.
* UIProcess/API/qt/tests/qmltests/qmltests.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[CSSRegions] Need test case for 66198 (sliced line box rendering)
commit-queue@webkit.org [Tue, 20 Sep 2011 21:59:44 +0000 (21:59 +0000)]
[CSSRegions] Need test case for 66198 (sliced line box rendering)
https://bugs.webkit.org/show_bug.cgi?id=68257

Patch by Alan Stearns <stearns@adobe.com> on 2011-09-20
Reviewed by David Hyatt.

* fast/regions/resources/helper.js:
(assertTopLeftMatch):
(sameTopLeft):
* fast/regions/no-split-line-box-expected.txt: Added.
* fast/regions/no-split-line-box.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove ScrollView::platformContentsSize
andersca@apple.com [Tue, 20 Sep 2011 21:47:07 +0000 (21:47 +0000)]
Remove ScrollView::platformContentsSize
https://bugs.webkit.org/show_bug.cgi?id=68188

Reviewed by Darin Adler.

../WebCore:

Since ScrollView keeps track of the contents size in ScrollView::m_contentsSize, we never
have to ask the underlying platform scroll view for contents size since it should always just
be equal to m_contentsSize.

* platform/ScrollView.cpp:
(WebCore::ScrollView::contentsSize):
(WebCore::ScrollView::wheelEvent):
* platform/ScrollView.h:
* platform/mac/ScrollViewMac.mm:
* platform/wx/ScrollViewWx.cpp:

../WebKit/mac:

When creating the document view, make sure it's zero sized which matches the initial size
of the ScrollView. This is fine to do early since DocumentWriter::begin sets the contents
size to a zero size anyway.

* WebView/WebFrameView.mm:
(-[WebFrameView _makeDocumentViewForDataSource:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r95565.
commit-queue@webkit.org [Tue, 20 Sep 2011 21:14:33 +0000 (21:14 +0000)]
Unreviewed, rolling out r95565.
http://trac.webkit.org/changeset/95565
https://bugs.webkit.org/show_bug.cgi?id=68470

Broke builds (Requested by andersca on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-20

Source/WebKit2:

* GNUmakefile.am:
* Shared/API/c/WKHitTestResult.cpp: Removed.
* Shared/API/c/WKHitTestResult.h: Removed.
* UIProcess/API/C/WebKit2.h:

Tools:

* MiniBrowser/gtk/BrowserWindow.c:
(mouseDidMoveOverElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] [WK2] Implement a persistent cookie storage.
alexis.menard@openbossa.org [Tue, 20 Sep 2011 21:01:12 +0000 (21:01 +0000)]
[Qt] [WK2] Implement a persistent cookie storage.
https://bugs.webkit.org/show_bug.cgi?id=65309

Reviewed by Chang Shu.

Source/WebCore:

Implement a cookie storage for the Qt port on WebKit2.
The implementation is using a SQLite database to store the cookies
and restore them. It uses a static object as CookieJar is not an
object but a set of global functions. The actual saving/restoring is on
the WebProcess side where our network stack lives.

Existing tests cover the new implementation. Unfortunately there is one
case that we can't easily simulate : login in a website, make sure that the webprocess
is not running and then going back to this website and see that we are logged.

* WebCore.pri:
* WebCore.pro:
* platform/qt/CookieJarQt.cpp:
(WebCore::getHostnamesWithCookies):
(WebCore::deleteCookiesForHostname):
(WebCore::deleteAllCookies):
(WebCore::SharedCookieJarQt::shared):
(WebCore::SharedCookieJarQt::create):
(WebCore::SharedCookieJarQt::destroy):
(WebCore::SharedCookieJarQt::getHostnamesWithCookies):
(WebCore::SharedCookieJarQt::deleteCookiesForHostname):
(WebCore::SharedCookieJarQt::deleteAllCookies):
(WebCore::SharedCookieJarQt::SharedCookieJarQt):
(WebCore::SharedCookieJarQt::~SharedCookieJarQt):
(WebCore::SharedCookieJarQt::setCookiesFromUrl):
(WebCore::SharedCookieJarQt::ensureDatabaseTable):
(WebCore::SharedCookieJarQt::loadCookies):
* platform/qt/CookieJarQt.h: Added.

Source/WebKit2:

Add parameter to the WebProcess creation to specify where cookies should be saved.
It also use the new cookie storage implementation and set it to our network stack
so cookies are used when using it.

* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
* Shared/WebProcessCreationParameters.h:
* UIProcess/qt/WebContextQt.cpp:
(WebKit::WebContext::platformInitializeWebProcess):
* WebProcess/qt/WebProcessQt.cpp:
(WebKit::WebProcess::platformInitializeWebProcess):
(WebKit::WebProcess::platformTerminate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSource/WebCore: https://bugs.webkit.org/show_bug.cgi?id=68314
hyatt@apple.com [Tue, 20 Sep 2011 20:26:13 +0000 (20:26 +0000)]
Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=68314

Make sure that the containing block loop when clipping to border-radius
terminates by checking if you hit the RenderView. Null checking isn't sufficient
for stupid historical reasons that should be fixed (i.e., the RenderView returns itself
as its own containing block, even though this should just be changed).

Reviewed by Simon Fraser and Darin Adler.

Added new test in fast/clip.

* rendering/RenderLayer.cpp:
(WebCore::inContainingBlockChain):

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=68314

Added some more clipping tests for overflow to make sure the right things happen
when border-radius is specified.

Reviewed by Simon Fraser and Darin Adler.

* fast/clip/overflow-border-radius-fixed-position.html: Added.
* platform/mac/fast/clip/overflow-border-radius-fixed-position-expected.png: Added.
* platform/mac/fast/clip/overflow-border-radius-fixed-position-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMathML renderers do not override RenderObject::renderName()
mitz@apple.com [Tue, 20 Sep 2011 20:21:25 +0000 (20:21 +0000)]
MathML renderers do not override RenderObject::renderName()
https://bugs.webkit.org/show_bug.cgi?id=68461

Reviewed by Darin Adler.

Source/WebCore:

Added implementations of renderName() in MathML RenderObject subclasses.

* rendering/mathml/RenderMathMLBlock.h:
(WebCore::RenderMathMLBlock::renderName):
* rendering/mathml/RenderMathMLFenced.h:
(WebCore::RenderMathMLFenced::renderName):
* rendering/mathml/RenderMathMLFraction.h:
(WebCore::RenderMathMLFraction::renderName):
* rendering/mathml/RenderMathMLMath.h:
(WebCore::RenderMathMLMath::renderName):
* rendering/mathml/RenderMathMLOperator.h:
(WebCore::RenderMathMLOperator::renderName):
* rendering/mathml/RenderMathMLRoot.h:
(WebCore::RenderMathMLRoot::renderName):
* rendering/mathml/RenderMathMLRow.h:
(WebCore::RenderMathMLRow::renderName):
* rendering/mathml/RenderMathMLSquareRoot.h:
(WebCore::RenderMathMLSquareRoot::renderName):
* rendering/mathml/RenderMathMLSubSup.h:
(WebCore::RenderMathMLSubSup::renderName):
* rendering/mathml/RenderMathMLUnderOver.h:
(WebCore::RenderMathMLUnderOver::renderName):

LayoutTests:

* platform/mac/mathml/presentation/attributes-expected.txt:
* platform/mac/mathml/presentation/fenced-expected.txt:
* platform/mac/mathml/presentation/fenced-mi-expected.txt:
* platform/mac/mathml/presentation/fractions-expected.txt:
* platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt:
* platform/mac/mathml/presentation/mo-expected.txt:
* platform/mac/mathml/presentation/msub-base-changed-expected.txt:
* platform/mac/mathml/presentation/msub-sub-changed-expected.txt:
* platform/mac/mathml/presentation/msubsup-base-changed-expected.txt:
* platform/mac/mathml/presentation/msubsup-sub-changed-expected.txt:
* platform/mac/mathml/presentation/msubsup-sup-changed-expected.txt:
* platform/mac/mathml/presentation/msup-base-changed-expected.txt:
* platform/mac/mathml/presentation/msup-sup-changed-expected.txt:
* platform/mac/mathml/presentation/over-expected.txt:
* platform/mac/mathml/presentation/roots-expected.txt:
* platform/mac/mathml/presentation/row-alignment-expected.txt:
* platform/mac/mathml/presentation/row-expected.txt:
* platform/mac/mathml/presentation/style-expected.txt:
* platform/mac/mathml/presentation/sub-expected.txt:
* platform/mac/mathml/presentation/subsup-expected.txt:
* platform/mac/mathml/presentation/sup-expected.txt:
* platform/mac/mathml/presentation/tables-expected.txt:
* platform/mac/mathml/presentation/tokenElements-expected.txt:
* platform/mac/mathml/presentation/under-expected.txt:
* platform/mac/mathml/presentation/underover-expected.txt:
* platform/mac/mathml/xHeight-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSource/WebKit2: Added WKHitTestResult API's.
commit-queue@webkit.org [Tue, 20 Sep 2011 20:16:58 +0000 (20:16 +0000)]
Source/WebKit2: Added WKHitTestResult API's.

WKHitTestResult API's are added. These API's can be used to
get the hover'ed link/image/media URL as well as link lable and
title.
https://bugs.webkit.org/show_bug.cgi?id=68426

Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-09-20
Reviewed by Anders Carlsson.

* GNUmakefile.am:
* Shared/API/c/WKHitTestResult.cpp: Copied from Source/WebKit2/UIProcess/API/C/WebKit2.h.
(WKHitTestResultGetTypeID):
(WKHitTestResultCopyAbsoluteImageURL):
(WKHitTestResultCopyAbsoluteLinkURL):
(WKHitTestResultCopyAbsoluteMediaURL):
(WKHitTestResultCopyLinkLabel):
(WKHitTestResultCopyLinkTitle):
* Shared/API/c/WKHitTestResult.h: Copied from Source/WebKit2/UIProcess/API/C/WebKit2.h.
* UIProcess/API/C/WebKit2.h:

Tools: Get hover'ed element URL from HitTest.

mouseDidMoveOverElement now gets the hover'ed element link using
WKHitTestResult API's.
https://bugs.webkit.org/show_bug.cgi?id=68426

Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-09-20
Reviewed by Anders Carlsson.

* MiniBrowser/gtk/BrowserWindow.c:
(mouseDidMoveOverElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[GTK] requestAnimationFrame support for gtk port
commit-queue@webkit.org [Tue, 20 Sep 2011 20:13:15 +0000 (20:13 +0000)]
[GTK] requestAnimationFrame support for gtk port
https://bugs.webkit.org/show_bug.cgi?id=66280

Patch by ChangSeok Oh <shivamidow@gmail.com> on 2011-09-20
Reviewed by Martin Robinson.

.:

* configure.ac: Add an option to enable requestAnimationFrame for gtk port.

Source/JavaScriptCore:

Let GTK port use REQUEST_ANIMATION_FRAME_TIMER.

* wtf/Platform.h:

Source/WebCore:

Add some files to build-target & activate ENABLE_REQUEST_ANIMATION_FRAME flag
when enabling requestAnimationFrame option.

fast/animation/request-animation-frame-cancel.html
fast/animation/request-animation-frame-cancel2.html
fast/animation/request-animation-frame-display.html
fast/animation/request-animation-frame-during-modal.html
fast/animation/request-animation-frame-timestamps.html
fast/animation/request-animation-frame-within-callback.html
fast/animation/request-animation-frame.html

* GNUmakefile.am:
* GNUmakefile.list.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDFG JIT performs too many negative zero checks, and too many
fpizlo@apple.com [Tue, 20 Sep 2011 20:10:56 +0000 (20:10 +0000)]
DFG JIT performs too many negative zero checks, and too many
overflow checks
https://bugs.webkit.org/show_bug.cgi?id=68430

Reviewed by Oliver Hunt.

This adds comprehensive support for deciding how to perform an
arithmetic operations based on a combination of overflow profiling,
negative zero profiling, value profiling, and a static analysis of
how the results of these operations get used.

This is a 72% speed-up on stanford-crypto-sha256-iterative, and a
2.5% speed-up on the Kraken average, a 1.4% speed-up on the V8
geomean, and neutral on SunSpider. It's also an 8.5% speed-up on
V8-crypto, because apparenty everything we do speeds up crypto.

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::toInt32):
(JSC::DFG::ByteCodeParser::toNumber):
(JSC::DFG::ByteCodeParser::isSmallInt32Constant):
(JSC::DFG::ByteCodeParser::valueOfInt32Constant):
(JSC::DFG::ByteCodeParser::weaklyPredictInt32):
(JSC::DFG::ByteCodeParser::makeSafe):
(JSC::DFG::ByteCodeParser::handleMinMax):
(JSC::DFG::ByteCodeParser::handleIntrinsic):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::processPhiStack):
(JSC::DFG::ByteCodeParser::parse):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::nonSpeculativeBasicArithOp):
* dfg/DFGNode.h:
(JSC::DFG::nodeUsedAsNumber):
(JSC::DFG::nodeCanTruncateInteger):
(JSC::DFG::nodeCanIgnoreNegativeZero):
(JSC::DFG::nodeCanSpeculateInteger):
(JSC::DFG::arithNodeFlagsAsString):
(JSC::DFG::Node::Node):
(JSC::DFG::Node::hasArithNodeFlags):
(JSC::DFG::Node::rawArithNodeFlags):
(JSC::DFG::Node::arithNodeFlags):
(JSC::DFG::Node::arithNodeFlagsForCompare):
(JSC::DFG::Node::setArithNodeFlag):
(JSC::DFG::Node::mergeArithNodeFlags):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::fixpoint):
(JSC::DFG::Propagator::isNotNegZero):
(JSC::DFG::Propagator::isNotZero):
(JSC::DFG::Propagator::propagateArithNodeFlags):
(JSC::DFG::Propagator::propagateArithNodeFlagsForward):
(JSC::DFG::Propagator::propagateArithNodeFlagsBackward):
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::propagatePredictionsForward):
(JSC::DFG::Propagator::propagatePredictionsBackward):
(JSC::DFG::Propagator::toDouble):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::fixup):
(JSC::DFG::Propagator::startIndexForChildren):
(JSC::DFG::Propagator::endIndexForPureCSE):
(JSC::DFG::Propagator::pureCSE):
(JSC::DFG::Propagator::clobbersWorld):
(JSC::DFG::Propagator::setReplacement):
(JSC::DFG::Propagator::performNodeCSE):
(JSC::DFG::Propagator::localCSE):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed; new baselines (Skia on Mac)
caryclark@google.com [Tue, 20 Sep 2011 20:05:23 +0000 (20:05 +0000)]
Unreviewed; new baselines (Skia on Mac)

This separates test failures that are specific to CG Mac from failures
for Skia on Mac. Most of these changes are specific to Leopard, but a
handful add new fail flavors for all Mac variations.

* LayoutTests/platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRework script context creation/release notifications
aa@chromium.org [Tue, 20 Sep 2011 18:58:04 +0000 (18:58 +0000)]
Rework script context creation/release notifications
https://bugs.webkit.org/show_bug.cgi?id=67828

Reviewed by Adam Barth.

Source/WebCore:

* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::disposeContextHandles):
(WebCore::V8DOMWindowShell::initContextIfNeeded):
* bindings/v8/V8IsolatedContext.cpp:
(WebCore::V8IsolatedContext::V8IsolatedContext):
(WebCore::V8IsolatedContext::destroy):
* bindings/v8/V8IsolatedContext.h:
* loader/EmptyClients.h:
(WebCore::EmptyFrameLoaderClient::didCreateScriptContext):
(WebCore::EmptyFrameLoaderClient::willReleaseScriptContext):
* loader/FrameLoaderClient.h:

Source/WebKit/chromium:

* public/WebFrameClient.h:
(WebKit::WebFrameClient::didCreateScriptContext):
(WebKit::WebFrameClient::didDestroyScriptContext):
(WebKit::WebFrameClient::willReleaseScriptContext):
* src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::didCreateScriptContext):
(WebKit::FrameLoaderClientImpl::willReleaseScriptContext):
* src/FrameLoaderClientImpl.h:
* tests/WebFrameTest.cpp:
(WebKit::TEST_F):
(WebKit::ContextLifetimeTestWebFrameClient::Notification::Notification):
(WebKit::ContextLifetimeTestWebFrameClient::Notification::~Notification):
(WebKit::ContextLifetimeTestWebFrameClient::Notification::Equals):
(WebKit::ContextLifetimeTestWebFrameClient::~ContextLifetimeTestWebFrameClient):
(WebKit::ContextLifetimeTestWebFrameClient::reset):
(WebKit::ContextLifetimeTestWebFrameClient::didCreateScriptContext):
(WebKit::ContextLifetimeTestWebFrameClient::willReleaseScriptContext):
* tests/data/context_notifications_test.html: Added.
* tests/data/context_notifications_test_frame.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRefactor Heap allocation logic into separate AllocationSpace class
oliver@apple.com [Tue, 20 Sep 2011 18:31:37 +0000 (18:31 +0000)]
Refactor Heap allocation logic into separate AllocationSpace class
https://bugs.webkit.org/show_bug.cgi?id=68409

Reviewed by Gavin Barraclough.

../../../../Volumes/Data/git/WebKit/OpenSource/Source/JavaScriptCore:

This patch hoists direct manipulation of the MarkedSpace and related
data out of Heap and into a separate class.  This will allow us to
have multiple allocation spaces in future, so easing the way towards
having GC'd backing stores for objects.

* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.exp:
* JavaScriptCore.gypi:
* JavaScriptCore.pro:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* debugger/Debugger.cpp:
(JSC::Debugger::recompileAllJSFunctions):
* heap/AllocationSpace.cpp: Added.
(JSC::AllocationSpace::tryAllocate):
(JSC::AllocationSpace::allocateSlowCase):
(JSC::AllocationSpace::allocateBlock):
(JSC::AllocationSpace::freeBlocks):
(JSC::TakeIfEmpty::TakeIfEmpty):
(JSC::TakeIfEmpty::operator()):
(JSC::TakeIfEmpty::returnValue):
(JSC::AllocationSpace::shrink):
* heap/AllocationSpace.h: Added.
(JSC::AllocationSpace::AllocationSpace):
(JSC::AllocationSpace::blocks):
(JSC::AllocationSpace::sizeClassFor):
(JSC::AllocationSpace::setHighWaterMark):
(JSC::AllocationSpace::highWaterMark):
(JSC::AllocationSpace::canonicalizeBlocks):
(JSC::AllocationSpace::resetAllocator):
(JSC::AllocationSpace::forEachCell):
(JSC::AllocationSpace::forEachBlock):
(JSC::AllocationSpace::allocate):
* heap/Heap.cpp:
(JSC::Heap::Heap):
(JSC::Heap::reportExtraMemoryCostSlowCase):
(JSC::Heap::getConservativeRegisterRoots):
(JSC::Heap::markRoots):
(JSC::Heap::clearMarks):
(JSC::Heap::sweep):
(JSC::Heap::objectCount):
(JSC::Heap::size):
(JSC::Heap::capacity):
(JSC::Heap::globalObjectCount):
(JSC::Heap::objectTypeCounts):
(JSC::Heap::collect):
(JSC::Heap::canonicalizeBlocks):
(JSC::Heap::resetAllocator):
(JSC::Heap::freeBlocks):
(JSC::Heap::shrink):
* heap/Heap.h:
(JSC::Heap::objectSpace):
(JSC::Heap::sizeClassForObject):
(JSC::Heap::allocate):
* jit/JITInlineMethods.h:
(JSC::JIT::emitAllocateBasicJSObject):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::recompileAllJSFunctions):
(JSC::JSGlobalData::releaseExecutableMemory):

../../../../Volumes/Data/git/WebKit/OpenSource/Source/WebCore:

Adding a forwarding header.

* ForwardingHeaders/heap/AllocationSpace.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix.
ggaren@apple.com [Tue, 20 Sep 2011 18:20:37 +0000 (18:20 +0000)]
Build fix.

* WebCorePrefix.h: Removed stray text from accidental paste.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-09-20 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Tue, 20 Sep 2011 18:17:18 +0000 (18:17 +0000)]
2011-09-20  Pavel Feldman  <pfeldman@google.com>

        Not reviewed: one line inspector's script-formatter.html fix.

        * inspector/debugger/script-formatter.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[EFL] Call FrameLoader::detachFromParent() when destroying a frame.
commit-queue@webkit.org [Tue, 20 Sep 2011 18:09:22 +0000 (18:09 +0000)]
[EFL] Call FrameLoader::detachFromParent() when destroying a frame.
https://bugs.webkit.org/show_bug.cgi?id=66855

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-09-20
Reviewed by Antonio Gomes.

Most other ports call this method somewhere when the frame is being
removed, as it performs some destruction calls which, in our case, at
least makes sure onunload events get delivered properly in
fast/frames/iframe-reparenting-adopt-node.html.

* ewk/ewk_frame.cpp:
(_ewk_frame_smart_del): Call FrameLoader::detachFromParent()

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemoved BREWMP* platform #ifdefs
ggaren@apple.com [Tue, 20 Sep 2011 18:02:33 +0000 (18:02 +0000)]
Removed BREWMP* platform #ifdefs
https://bugs.webkit.org/show_bug.cgi?id=68425

BREWMP* has no maintainer, and this is dead code.

Reviewed by Darin Adler.

../JavaScriptCore:

* heap/MarkStack.h:
(JSC::::shrinkAllocation):
* jit/ExecutableAllocator.h:
(JSC::ExecutableAllocator::cacheFlush):
* runtime/TimeoutChecker.cpp:
(JSC::getCPUTime):
* wtf/Assertions.cpp:
* wtf/Assertions.h:
* wtf/CurrentTime.cpp:
* wtf/DateMath.cpp:
(WTF::calculateUTCOffset):
* wtf/FastMalloc.cpp:
(WTF::fastMalloc):
(WTF::fastCalloc):
(WTF::fastMallocSize):
* wtf/FastMalloc.h:
* wtf/MainThread.cpp:
* wtf/MathExtras.h:
* wtf/OwnPtrCommon.h:
* wtf/Platform.h:
* wtf/RandomNumber.cpp:
(WTF::randomNumber):
* wtf/RandomNumberSeed.h:
(WTF::initializeRandomNumberGenerator):
* wtf/text/WTFString.h:
* wtf/unicode/Unicode.h:

../WebCore:

* WebCorePrefix.h:
* loader/cache/CachedFont.cpp:
* platform/DragData.h:
* platform/DragImage.h:
* platform/FileSystem.h:
* platform/PlatformKeyboardEvent.h:
* platform/PlatformMouseEvent.h:
* platform/PlatformTouchEvent.h:
* platform/PlatformTouchPoint.h:
(WebCore::PlatformTouchPoint::PlatformTouchPoint):
* platform/Widget.h:
* platform/graphics/IntPoint.h:
* platform/graphics/IntSize.h:
* platform/graphics/WOFFFileFormat.cpp:
* platform/graphics/skia/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::~FontCustomPlatformData):
(WebCore::FontCustomPlatformData::fontPlatformData):
(WebCore::createFontCustomPlatformData):
* platform/graphics/skia/FontCustomPlatformData.h:
* platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
* platform/text/TextBoundaries.cpp:
* platform/text/TextEncoding.cpp:
(WebCore::TextEncoding::encode):
* platform/text/TextEncodingRegistry.cpp:
* plugins/PluginViewNone.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: Copy Stack Trace lacks newlines on Windows
pfeldman@chromium.org [Tue, 20 Sep 2011 17:47:18 +0000 (17:47 +0000)]
Web Inspector: Copy Stack Trace lacks newlines on Windows
https://bugs.webkit.org/show_bug.cgi?id=68447

Reviewed by Joseph Pecoraro.

* inspector/front-end/CallStackSidebarPane.js:
(WebInspector.CallStackSidebarPane.prototype._copyStackTrace):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95554 268f45cc-cd09-0410-ab3c-d52691b4dbfc