WebKit-https.git
9 years ago[BlackBerry]Adjust fatfinger detection rect size
commit-queue@webkit.org [Mon, 4 Feb 2013 21:12:35 +0000 (21:12 +0000)]
[BlackBerry]Adjust fatfinger detection rect size
https://bugs.webkit.org/show_bug.cgi?id=108678

Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-02-04
Reviewed by Antonio Gomes.
RIM Bug 246976

We still need to clip the fatfinger detection rect to the viewport to
avoid wrong hitTest result.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::mouseEvent):
* WebKitSupport/FatFingers.cpp:
(BlackBerry::WebKit::FatFingers::getNodesFromRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUse a separate queue for the connection watchdog callback in the web process
andersca@apple.com [Mon, 4 Feb 2013 21:11:27 +0000 (21:11 +0000)]
Use a separate queue for the connection watchdog callback in the web process
https://bugs.webkit.org/show_bug.cgi?id=108844

Reviewed by Andreas Kling.

Don't pass the connection work queue to the didCloseOnConnectionWorkQueue callback.
Instead, create a new, temporary work queue where the exit call will be dispatched to.

* Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::connectionDidClose):
* Platform/CoreIPC/Connection.h:
(Connection):
* Shared/ChildProcess.cpp:
(WebKit::didCloseOnConnectionWorkQueue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImplemet :lang() pseudo class support for the WebVTT ::cue pseudo element
commit-queue@webkit.org [Mon, 4 Feb 2013 21:00:26 +0000 (21:00 +0000)]
Implemet :lang() pseudo class support for the WebVTT ::cue pseudo element
https://bugs.webkit.org/show_bug.cgi?id=105478

Patch by Dima Gorbik <dgorbik@apple.com> on 2013-02-04
Reviewed by Antti Koivisto.

Source/WebCore:

In WebVTT lang is preprocessed and stored in the lang attribute of the element,
so we access it instead of walking up the tree the way it is done in HTML.

Existing tests were modified to cover this case.

* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne):

LayoutTests:

* media/track/captions-webvtt/styling-lang.vtt:
* media/track/track-css-matching-lang-expected.txt:
* media/track/track-css-matching-lang.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDisable autoscrolling the main frame if main frame scrolling is disabled
timothy_horton@apple.com [Mon, 4 Feb 2013 20:30:24 +0000 (20:30 +0000)]
Disable autoscrolling the main frame if main frame scrolling is disabled
https://bugs.webkit.org/show_bug.cgi?id=108848
<rdar://problem/13004059>

Reviewed by Simon Fraser.

Ensure that the main frame can scroll at all before allowing an autoscroll.

* rendering/RenderBox.cpp:
(WebCore::RenderBox::canAutoscroll):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoXSS Auditor bypass via svg tags and xlink:href
commit-queue@webkit.org [Mon, 4 Feb 2013 19:48:42 +0000 (19:48 +0000)]
XSS Auditor bypass via svg tags and xlink:href
https://bugs.webkit.org/show_bug.cgi?id=84158

Source/WebCore:

This patch adds a test for the xlink:href attribute inside of
script tokens. The test is complicated by the namespacing; the
xlink hrefAttr qualified name does not contain a literal "xlink"
prefix but only the URI of the namespace.

Patch by Tom Sepez <tsepez@chromiium.org> on 2013-02-04
Reviewed by Adam Barth.

Test: http/tests/security/xssAuditor/svg-script-tag.html

* html/parser/XSSAuditor.cpp:
(WebCore::findAttributeWithName):
(WebCore::XSSAuditor::filterScriptToken):

LayoutTests:

Patch by Tom Sepez <tsepez@chromiium.org> on 2013-02-04
Reviewed by Adam Barth.

* http/tests/security/xssAuditor/svg-script-tag-expected.txt: Added.
* http/tests/security/xssAuditor/svg-script-tag.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate CaptionUserPreferences
eric.carlson@apple.com [Mon, 4 Feb 2013 19:39:31 +0000 (19:39 +0000)]
Update CaptionUserPreferences
https://bugs.webkit.org/show_bug.cgi?id=108783

Reviewed by Dean Jackson.

* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTextTrackContainerElement::updateSizes): Mark font size as important
    when necessary.
* page/CaptionUserPreferences.h:
(WebCore::CaptionUserPreferences::setUserPrefersCaptions): New, allow a port to remember that
    the user has chosen to see captions.
(WebCore::CaptionUserPreferences::setPreferredLanguage): New, allow a port to remember the
    user's preferred caption language.
(WebCore::CaptionUserPreferences::preferredLanguages): New, return a Vector of the user's
    preferred caption languages.
* page/CaptionUserPreferencesMac.h:
* page/CaptionUserPreferencesMac.mm:
* page/PageGroup.cpp:
(WebCore::PageGroup::captionPreferences):
(WebCore::PageGroup::captionFontSizeScale):
* page/PageGroup.h:
* platform/Language.cpp:
(WebCore::userPreferredLanguagesOverride): New, return the user preferred languages override
    used during testing.
* platform/Language.h:
* platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.mm:
(WebCore::InbandTextTrackPrivateAVFObjC::kind):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAllow TiledCoreAnimationDrawingArea overlay layers to become tiled
timothy_horton@apple.com [Mon, 4 Feb 2013 19:26:18 +0000 (19:26 +0000)]
Allow TiledCoreAnimationDrawingArea overlay layers to become tiled
https://bugs.webkit.org/show_bug.cgi?id=108729
<rdar://problem/13047546>

Reviewed by Anders Carlsson.

* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
(TiledCoreAnimationDrawingArea): Add didCommitChangesForLayer and storage for the
current PlatformLayer corresponding to m_pageOverlayLayer.
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::flushLayers): Update the TileCache's visible rect.
(WebKit::TiledCoreAnimationDrawingArea::setExposedRect): Forward exposed rect changes to the page overlay layer, if it's tiled.
(WebKit::TiledCoreAnimationDrawingArea::mainFrameScrollabilityChanged): Forward scrollability changes to the page overlay layer, if it's tiled.
(WebKit::TiledCoreAnimationDrawingArea::createPageOverlayLayer): Allow the page overlay layer to become tiled. Update its exposed rect and whether or not it respects the exposed rect if it's tiled upon creation.
(WebKit::TiledCoreAnimationDrawingArea::didCommitChangesForLayer): If a GraphicsLayer's platform layer changes (because it switched to or from a tiled layer), reparent it. If it's switching to a tiled layer, update the exposed rect and whether or not it should respect the exposed rect.

* WebCore.exp.in:
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::flushCompositingStateForThisLayerOnly): The "for this layer only" variant
of flushCompositingState wasn't informing its client that it committed changes for the layer.
(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer): We now explicitly want to be able to have a
GraphicsLayerCA switch into or out of tiling while being unparented (we'll get a client callback and
swap out its parent ourselves).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFor ARMv7s use integer divide instruction for divide and modulo when possible
msaboff@apple.com [Mon, 4 Feb 2013 19:18:27 +0000 (19:18 +0000)]
For ARMv7s use integer divide instruction for divide and modulo when possible
https://bugs.webkit.org/show_bug.cgi?id=108840

Reviewed in person by Filip Pizlo.

Added ARMv7s integer divide path for ArithDiv and ArithMod where operands and results are integer.
This is patterned after the similar code for X86.  Also added modulo power of 2 optimization
that uses logical and.  Added sdiv and udiv to the ARMv7 disassembler.  Put all the changes
behind #if CPU(APPLE_ARMV7S).

* assembler/ARMv7Assembler.h:
(ARMv7Assembler):
(JSC::ARMv7Assembler::sdiv):
(JSC::ARMv7Assembler::udiv):
* dfg/DFGCommon.h:
(JSC::DFG::isARMv7s):
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileSoftModulo):
(JSC::DFG::SpeculativeJIT::compileIntegerArithDivForARMv7s):
* dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[CSS Grid Layout] Add parsing for grid-auto-flow
jchaffraix@webkit.org [Mon, 4 Feb 2013 19:14:19 +0000 (19:14 +0000)]
[CSS Grid Layout] Add parsing for grid-auto-flow
https://bugs.webkit.org/show_bug.cgi?id=108397

Reviewed by Ojan Vafai.

Source/WebCore:

Test: fast/css-grid-layout/grid-auto-flow-get-set.html

This change adds the parsing, application and conversion back through getComputedStyle
for the new property -webkit-grid-auto-flow, which accpets the following:

-webkit-grid-auto-flow: none | rows | columns

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
Added code to convert the RenderStyle information back into a CSS value.

* css/CSSParser.cpp:
(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
Implemented parsing for -webkit-grid-auto-flow.

* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::operator GridAutoFlow):
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
Added the conversion operators, used for parsing and getComputedStyle.

* css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
Added -webkit-grid-auto-flow to the list of the not inherited properties.

* css/CSSPropertyNames.in:
Added the new value and keywords.

* css/StyleBuilder.cpp:
(WebCore::StyleBuilder::StyleBuilder):
Added a handler for the new CSS property.

* rendering/style/RenderStyle.h:
Added the usual getter / setter / initial function.

* rendering/style/RenderStyleConstants.h:
Added a new enum GridAutoFlow to hold the parsed value.

* rendering/style/StyleGridData.cpp:
(WebCore::StyleGridData::StyleGridData):
* rendering/style/StyleGridData.h:
(WebCore::StyleGridData::operator==):
Updated after adding a new field for the GridAutoFlow value.

LayoutTests:

* fast/css-grid-layout/grid-auto-flow-get-set-expected.txt: Added.
* fast/css-grid-layout/grid-auto-flow-get-set.html: Added.
* fast/css-grid-layout/resources/grid.css:
(.gridAutoFlowNone):
(.gridAutoFlowColumn):
(.gridAutoFlowRow):
Added these new classes to our common style.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCheck PrivateHeaders/JSBasePrivate.h for inappropriate macros
ddkilzer@apple.com [Mon, 4 Feb 2013 19:01:45 +0000 (19:01 +0000)]
Check PrivateHeaders/JSBasePrivate.h for inappropriate macros
<http://webkit.org/b/108749>

Reviewed by Joseph Pecoraro.

* JavaScriptCore.xcodeproj/project.pbxproj: Add
PrivateHeaders/JSBasePrivate.h to list of headers to check in
"Check for Inappropriate Macros in External Headers" build phase
script.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] remove WebTestPlugin from the public TestRunner API
jochen@chromium.org [Mon, 4 Feb 2013 18:59:01 +0000 (18:59 +0000)]
[chromium] remove WebTestPlugin from the public TestRunner API
https://bugs.webkit.org/show_bug.cgi?id=108467

Reviewed by Adam Barth.

* DumpRenderTree/DumpRenderTree.gypi:
* DumpRenderTree/chromium/TestRunner/public/WebTestPlugin.h: Removed.
* DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
(WebKit):
(WebTestProxyBase):
(WebTestRunner::WebTestProxy::createPlugin):
* DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp.
(WebTestRunner::TestPlugin::TestPlugin):
(WebTestRunner):
(WebTestRunner::TestPlugin::~TestPlugin):
(WebTestRunner::TestPlugin::initialize):
(WebTestRunner::TestPlugin::destroy):
(WebTestRunner::TestPlugin::updateGeometry):
(WebTestRunner::TestPlugin::parsePrimitive):
(WebTestRunner::TestPlugin::parseColor):
(WebTestRunner::TestPlugin::parseOpacity):
(WebTestRunner::TestPlugin::parseBoolean):
(WebTestRunner::TestPlugin::initScene):
(WebTestRunner::TestPlugin::drawScene):
(WebTestRunner::TestPlugin::destroyScene):
(WebTestRunner::TestPlugin::initProgram):
(WebTestRunner::TestPlugin::initPrimitive):
(WebTestRunner::TestPlugin::drawPrimitive):
(WebTestRunner::TestPlugin::loadShader):
(WebTestRunner::TestPlugin::loadProgram):
(WebTestRunner::TestPlugin::handleInputEvent):
(WebTestRunner::TestPlugin::handleDragStatusUpdate):
(WebTestRunner::TestPlugin::create):
(WebTestRunner::TestPlugin::mimeType):
* DumpRenderTree/chromium/TestRunner/src/TestPlugin.h: Added.
(WebTestRunner):
(TestPlugin):
(WebTestRunner::TestPlugin::scriptableObject):
(WebTestRunner::TestPlugin::canProcessDrag):
(WebTestRunner::TestPlugin::paint):
(WebTestRunner::TestPlugin::updateFocus):
(WebTestRunner::TestPlugin::updateVisibility):
(WebTestRunner::TestPlugin::acceptsInputEvents):
(WebTestRunner::TestPlugin::didReceiveResponse):
(WebTestRunner::TestPlugin::didReceiveData):
(WebTestRunner::TestPlugin::didFinishLoading):
(WebTestRunner::TestPlugin::didFailLoading):
(WebTestRunner::TestPlugin::didFinishLoadingFrameRequest):
(WebTestRunner::TestPlugin::didFailLoadingFrameRequest):
(WebTestRunner::TestPlugin::isPlaceholder):
(WebTestRunner::TestPlugin::prepareTexture):
(WebTestRunner::TestPlugin::context):
(Scene):
(WebTestRunner::TestPlugin::Scene::Scene):
* DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
(WebTestRunner::WebTestProxyBase::createPlugin):
(WebTestRunner):
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::createPlugin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Move IDBFactoryBackendInterface to WebCore
pilgrim@chromium.org [Mon, 4 Feb 2013 18:52:03 +0000 (18:52 +0000)]
[Chromium] Move IDBFactoryBackendInterface to WebCore
https://bugs.webkit.org/show_bug.cgi?id=108638

Reviewed by Adam Barth.

Part of a larger refactoring series; see tracking bug 106829.

Source/WebCore:

* Modules/indexeddb/chromium: Added.
* Modules/indexeddb/chromium/IDBFactoryBackendInterfaceChromium.cpp: Added.
(WebCore):
(WebCore::setIDBFactoryBackendInterfaceCreateFunction):
(WebCore::IDBFactoryBackendInterface::create):
* Modules/indexeddb/chromium/IDBFactoryBackendInterfaceChromium.h: Added.
(WebCore):
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:

Source/WebKit/chromium:

* WebKit.gyp:
* src/AssertMatchingEnums.cpp:
* src/IDBFactoryBackendInterface.cpp: Removed.
* src/IDBFactoryBackendProxy.h:
* src/WebKit.cpp:
(WebKit::initializeWithoutV8):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd ASSERT_WITH_SECURITY_IMPLICATION to detect bad cast in DOM, CSS, etc.
inferno@chromium.org [Mon, 4 Feb 2013 18:43:03 +0000 (18:43 +0000)]
Add ASSERT_WITH_SECURITY_IMPLICATION to detect bad cast in DOM, CSS, etc.
https://bugs.webkit.org/show_bug.cgi?id=108688

Reviewed by Eric Seidel.

Source/WebCore:

* Modules/notifications/Notification.cpp:
(WebCore::Notification::Notification):
(WebCore::Notification::permission):
(WebCore::Notification::requestPermission):
* Modules/speech/SpeechGrammar.cpp:
(WebCore::SpeechGrammar::setSrc):
* Modules/speech/SpeechGrammarList.cpp:
(WebCore::SpeechGrammarList::addFromUri):
* Modules/websockets/ThreadableWebSocketChannel.cpp:
(WebCore::ThreadableWebSocketChannel::create):
* accessibility/AccessibilityMenuListPopup.cpp:
(WebCore::AccessibilityMenuListPopup::menuListOptionAccessibilityObject):
* accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::cellForColumnAndRow):
* css/CSSFontFaceRule.cpp:
(WebCore::CSSFontFaceRule::reattach):
* css/CSSImageSetValue.cpp:
(WebCore::CSSImageSetValue::fillImageSet):
* css/CSSPageRule.cpp:
(WebCore::CSSPageRule::reattach):
* css/CSSStyleRule.cpp:
(WebCore::CSSStyleRule::reattach):
* css/StyleBuilder.cpp:
(WebCore::ApplyPropertyFontVariantLigatures::applyValue):
(WebCore::ApplyPropertyTextDecoration::applyValue):
(WebCore::ApplyPropertyZoom::applyValue):
* css/StyleResolver.cpp:
(WebCore::createGridPosition):
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::createCustomFilterOperationWithInlineSyntax):
* css/WebKitCSSFilterRule.cpp:
(WebCore::WebKitCSSFilterRule::reattach):
* css/WebKitCSSKeyframesRule.cpp:
(WebCore::WebKitCSSKeyframesRule::reattach):
* css/WebKitCSSViewportRule.cpp:
(WebCore::WebKitCSSViewportRule::reattach):
* editing/EditCommand.h:
(WebCore::toSimpleEditCommand):
* editing/visible_units.cpp:
(WebCore::startOfParagraph):
(WebCore::endOfParagraph):
* html/HTMLCollection.cpp:
(WebCore::LiveNodeListBase::setItemCache):
* loader/ThreadableLoader.cpp:
(WebCore::ThreadableLoader::create):
(WebCore::ThreadableLoader::loadResourceSynchronously):
* loader/WorkerThreadableLoader.cpp:
(WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCreateLoader):
* page/Frame.cpp:
(WebCore::Frame::frameForWidget):
* platform/RefCountedSupplement.h:
(WebCore::RefCountedSupplement::from):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::splitBlocks):
(WebCore::RenderBlock::firstLineBlock):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::createLineBoxes):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeReplacedLogicalHeightUsing):
* rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::positionForPoint):
* rendering/svg/SVGRootInlineBox.cpp:
(WebCore::SVGRootInlineBox::layoutCharactersInTextBoxes):
(WebCore::SVGRootInlineBox::layoutChildBoxes):
* testing/js/WebCoreTestSupport.cpp:
(WebCoreTestSupport::resetInternalsObject):
* testing/v8/WebCoreTestSupport.cpp:
(WebCoreTestSupport::resetInternalsObject):
* workers/DefaultSharedWorkerRepository.cpp:
(WebCore::SharedWorkerProxy::addToWorkerDocuments):
(WebCore::SharedWorkerConnectTask::performTask):
* workers/SharedWorker.cpp:
(WebCore::SharedWorker::create):
* workers/WorkerContext.cpp:
(WebCore::CloseWorkerContextTask::performTask):
* workers/WorkerMessagingProxy.cpp:
(WebCore::MessageWorkerContextTask::performTask):
(WebCore::connectToWorkerContextInspectorTask):
(WebCore::disconnectFromWorkerContextInspectorTask):
(WebCore::dispatchOnInspectorBackendTask):
* workers/WorkerScriptLoader.cpp:
(WebCore::WorkerScriptLoader::loadSynchronously):
* workers/WorkerThread.cpp:
(WebCore::WorkerThreadShutdownFinishTask::performTask):
(WebCore::WorkerThreadShutdownStartTask::performTask):

Source/WebKit/blackberry:

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
* WebKitSupport/FatFingers.cpp:
(BlackBerry::WebKit::FatFingers::setSuccessfulFatFingersResult):

Source/WebKit/chromium:

* src/IDBFactoryBackendProxy.cpp:
(WebKit::IDBFactoryBackendProxy::allowIndexedDB):
(WebKit::getWebFrame):
* src/LocalFileSystemChromium.cpp:
(WebCore::LocalFileSystem::deleteFileSystem):
* src/WebSharedWorkerImpl.cpp:
(WebKit::WebSharedWorkerImpl::connectTask):
(WebKit::resumeWorkerContextTask):
(WebKit::connectToWorkerContextInspectorTask):
(WebKit::reconnectToWorkerContextInspectorTask):
(WebKit::disconnectFromWorkerContextInspectorTask):
(WebKit::dispatchOnInspectorBackendTask):

Source/WebKit/qt:

* WebCoreSupport/FrameLoaderClientQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMade the documentation on the confirmed argument for the
kov@webkit.org [Mon, 4 Feb 2013 18:35:12 +0000 (18:35 +0000)]
Made the documentation on the confirmed argument for the
WebView::script-confirm signal clearer about its type.

Reviewed by Martin Robinson.

* webkit/webkitwebview.cpp:
(webkit_web_view_class_init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUse UNUSED_PARAM instead of C style comments.
andersca@apple.com [Mon, 4 Feb 2013 18:34:45 +0000 (18:34 +0000)]
Use UNUSED_PARAM instead of C style comments.

* UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::createStorageArea):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL][WK2] Stop using libsoup in ewk_url_scheme_request
commit-queue@webkit.org [Mon, 4 Feb 2013 18:32:05 +0000 (18:32 +0000)]
[EFL][WK2] Stop using libsoup in ewk_url_scheme_request
https://bugs.webkit.org/show_bug.cgi?id=108816

Patch by Christophe Dumez <dchris@gmail.com> on 2013-02-04
Reviewed by Anders Carlsson.

As we are trying to minimize use of external dependencies in our WK2 EFL
API implementation, we should stop using libsoup in
ewk_url_scheme_request and use the WK2 C API instead.

* UIProcess/API/efl/ewk_url_scheme_request.cpp:
(EwkUrlSchemeRequest::EwkUrlSchemeRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd a new method for obtaining a build-type-dependent path,
kov@webkit.org [Mon, 4 Feb 2013 18:29:28 +0000 (18:29 +0000)]
Add a new method for obtaining a build-type-dependent path,
instead of modifying all call sites to pass it in.

Reviewed by Martin Robinson.

* Scripts/run-gtk-tests:
(TestRunner.__init__): use the new method, which takes a tuple.
(TestRunner._setup_testing_environment): ditto.
* gtk/common.py:
(get_build_path): accept a tuple that may include Release and
Debug as build types, for searching.
(build_path_for_build_types): new method that finds the path when
it is dependent on the build type.
(build_path): restore its original behaviour.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Skia] Argument to HarfBuzzShaper::offsetForPosition unnecessarily truncated
dominik.rottsches@intel.com [Mon, 4 Feb 2013 18:21:25 +0000 (18:21 +0000)]
[Skia] Argument to HarfBuzzShaper::offsetForPosition unnecessarily truncated
https://bugs.webkit.org/show_bug.cgi?id=108479

Reviewed by Emil A Eklund.

Remove a FIXME that intended to solve the value truncation.
Should positively affect SVG text positioning.

No new tests, partially covered by manual test
ManualTests/harfbuzz-mouse-selection-crash.html.

* platform/graphics/harfbuzz/FontHarfBuzz.cpp:
(WebCore::Font::offsetForPositionForComplexText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Create a container class for SidebarPane instances
commit-queue@webkit.org [Mon, 4 Feb 2013 18:19:31 +0000 (18:19 +0000)]
Web Inspector: Create a container class for SidebarPane instances
https://bugs.webkit.org/show_bug.cgi?id=108183

Source/WebCore:

Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-02-04
Reviewed by Pavel Feldman.

SidebarPaneStack is responsible for pane title bar and expand/collapse behavior (previously handled by SidebarPane).
SidebarPanes are inserted into DOM lazily and can belong to more than one container.
SidebarPane is ready to be displayed in other types of containers (such as tabbed pane as requested in https://bugs.webkit.org/show_bug.cgi?id=107552).
There should be no visible changes except for one: DOM breakpoint pane expand/collapse state is no longer
shared between Elements and Sources sidebars.

* inspector/front-end/AuditResultView.js:
(WebInspector.AuditResultView):
* inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._addBreakpoint):
(WebInspector.XHRBreakpointsSidebarPane.prototype.highlightBreakpoint):
(WebInspector.EventListenerBreakpointsSidebarPane.prototype.highlightBreakpoint):
* inspector/front-end/DOMBreakpointsSidebarPane.js:
(WebInspector.DOMBreakpointsSidebarPane.prototype.highlightBreakpoint):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype.wasShown):
(WebInspector.ElementsPanel.prototype.updateStyles):
(WebInspector.ElementsPanel.prototype.updateMetrics):
(WebInspector.ElementsPanel.prototype.updateProperties):
(WebInspector.ElementsPanel.prototype.updateEventListeners):
* inspector/front-end/ExtensionPanel.js:
(WebInspector.ExtensionSidebarPane):
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onCreateSidebarPane):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.wasShown):
* inspector/front-end/SidebarPane.js:
(WebInspector.SidebarPane):
(WebInspector.SidebarPane.prototype.title):
(WebInspector.SidebarPane.prototype.prepareContent):
(WebInspector.SidebarPane.prototype.expand):
(WebInspector.SidebarPane.prototype.onContentReady):
(WebInspector.SidebarPane.prototype.setExpandCallback):
(WebInspector.SidebarPane.prototype.setShowCallback):
(WebInspector.SidebarPane.prototype.wasShown):
(WebInspector.SidebarPaneStack):
(WebInspector.SidebarPaneStack.prototype.wasShown):
(WebInspector.SidebarPaneStack.prototype.addPane):
(WebInspector.SidebarPaneStack.prototype._addTitle):
(WebInspector.SidebarPaneStack.prototype._attachToPane):
(WebInspector.SidebarPaneStack.prototype._isExpanded):
(WebInspector.SidebarPaneStack.prototype._setExpanded):
(WebInspector.SidebarPaneStack.prototype._onPaneExpanded):
(WebInspector.SidebarPaneStack.prototype._collapsePane):
(WebInspector.SidebarPaneStack.prototype._togglePane):
(WebInspector.SidebarPaneStack.prototype._onTitleKeyDown):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype._refreshUpdate):
(WebInspector.StylesSidebarPane.prototype._rebuildUpdate):
(WebInspector.StylesSidebarPane.prototype.set _createNewRule):
(WebInspector.ComputedStyleSidebarPane.prototype.prepareContent):
* inspector/front-end/WatchExpressionsSidebarPane.js:
(WebInspector.WatchExpressionsSidebarPane):
(WebInspector.WatchExpressionsSidebarPane.prototype.wasShown):
(WebInspector.WatchExpressionsSidebarPane.prototype.addExpression):
(WebInspector.WatchExpressionsSidebarPane.prototype._addButtonClicked):
* inspector/front-end/inspector.css:
(.pane-title + .pane-title, .pane:not(.visible) + .pane-title, .pane-title:first-of-type):
(.pane-title):
(.pane-title:active):
(.pane-title::before):
(.pane-title.expanded::before):
(.pane-title > select):
(.pane-title > select:hover):
(.pane-title > select:active):
(.pane-title > select.select-settings):
(.pane-title > select.select-filter):
(.pane-title > select > option, .pane-title > select > hr):
(.pane-title > .pane-title-button):
(.pane-title > .pane-title-button:hover):
(.pane-title > .pane-title-button:active, .pane-title > .pane-title-button.toggled):
(.pane-title > .pane-title-button.add):
(.pane-title > .pane-title-button.element-state):
(.pane-title > .pane-title-button.refresh):
(.pane.visible > .body):
(.pane.visible:nth-last-of-type(1)):
(.panel-enabler-view button:not(.status-bar-item), .pane-title-button, button.show-all-nodes):
(.panel-enabler-view button:active:not(.status-bar-item), .pane-title-button:active, button.show-all-nodes:active):
(body.inactive .panel-enabler-view button:not(.status-bar-item), .panel-enabler-view button:disabled:not(.status-bar-item), body.inactive .pane-title-button, .pane-title-button:disabled, body.inactive button.show-all-nodes):

LayoutTests:

Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-02-04
Reviewed by Pavel Feldman.

* http/tests/inspector/elements-test.js:
(initialize_ElementTest.stylesCallback):
(initialize_ElementTest.InspectorTest.selectNodeAndWaitForStylesWithComputed):
* inspector/audits/audits-panel-functional-expected.txt:
* inspector/audits/audits-panel-noimages-functional-expected.txt:
* inspector/debugger/error-in-watch-expressions.html:
* inspector/debugger/properties-special.html:
* inspector/debugger/watch-expressions-panel-switch.html:
* inspector/debugger/watch-expressions-preserve-expansion.html:
* inspector/extensions/extensions-audits-api-expected.txt:
* inspector/extensions/extensions-audits-content-script-expected.txt:
* inspector/extensions/extensions-audits-expected.txt:
* inspector/extensions/extensions-events.html:
* inspector/extensions/extensions-sidebar.html:
* inspector/styles/lazy-computed-style.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][Wk2] Unreviewed gardnening. Skip failing tests.
kadam@inf.u-szeged.hu [Mon, 4 Feb 2013 18:14:31 +0000 (18:14 +0000)]
[Qt][Wk2] Unreviewed gardnening. Skip failing tests.

* platform/qt-5.0-wk2/TestExpectations:
* platform/qt-5.0-wk2/fast/multicol/shrink-to-column-height-for-pagination-expected.png: Update after r141459.
* platform/qt-5.0-wk2/fast/multicol/shrink-to-column-height-for-pagination-expected.txt: Update after r141459.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove duplicate code in RenderBoxModelObject::computedCSSPadding*
eae@chromium.org [Mon, 4 Feb 2013 17:45:19 +0000 (17:45 +0000)]
Remove duplicate code in RenderBoxModelObject::computedCSSPadding*
https://bugs.webkit.org/show_bug.cgi?id=108707

Reviewed by Eric Seidel.

The computedCSSPaddingTop/Bottom/... methods in
RenderBoxModelObject all do pretty much exactly the same thing
yet share no code.

Break out shared code into computedCSSPadding method and have
the top/bottom/left/right/... ones call it with the appropriate
length value.

No new tests, no change in functionality.

* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::computedCSSPadding):
* rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::computedCSSPaddingTop):
(WebCore::RenderBoxModelObject::computedCSSPaddingBottom):
(WebCore::RenderBoxModelObject::computedCSSPaddingLeft):
(WebCore::RenderBoxModelObject::computedCSSPaddingRight):
(WebCore::RenderBoxModelObject::computedCSSPaddingBefore):
(WebCore::RenderBoxModelObject::computedCSSPaddingAfter):
(WebCore::RenderBoxModelObject::computedCSSPaddingStart):
(WebCore::RenderBoxModelObject::computedCSSPaddingEnd):
(RenderBoxModelObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: add round braces to javascript tokenizer
commit-queue@webkit.org [Mon, 4 Feb 2013 17:42:19 +0000 (17:42 +0000)]
Web Inspector: add round braces to javascript tokenizer
https://bugs.webkit.org/show_bug.cgi?id=108692

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-04
Reviewed by Pavel Feldman.

Source/WebCore:

Change SourceJavascriptTokenizer.re2js file to produce "brace-start"
and "brace-end" tokens for round braces.
Regenerate SourceJavascriptTokenizer.js according to new re2js file.

No new tests: no change in behaviour.

* inspector/front-end/SourceJavaScriptTokenizer.js:
(WebInspector.SourceJavaScriptTokenizer.prototype.nextToken):
* inspector/front-end/SourceJavaScriptTokenizer.re2js:

LayoutTests:

Updated test expectations to correspond to new tokens "brace-start"
and "brace-end" in javascript tokenizer.

* inspector/editor/highlighter-basics-expected.txt:
* inspector/editor/text-editor-long-line-expected.txt:
* inspector/syntax-highlight-html-expected.txt:
* inspector/syntax-highlight-javascript-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Needs one-shot drawing synchronization flag should be set before renderi...
commit-queue@webkit.org [Mon, 4 Feb 2013 17:38:58 +0000 (17:38 +0000)]
[BlackBerry] Needs one-shot drawing synchronization flag should be set before rendering when resuming the backing store
https://bugs.webkit.org/show_bug.cgi?id=108760

Patch by Andrew Lo <anlo@rim.com> on 2013-02-04
Reviewed by Yong Li.
Internally reviewed by Arvid Nilsson.

Internal PR 286218.
When acquiring the backing store ownership in WebPagePrivate::resumeBackingStore
we need to set the needs one-shot drawing synchronization flag
before rendering, so that when the render is completed we
commit the root layer.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::resumeBackingStore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: take page scale factor into account when updating overlay.
pfeldman@chromium.org [Mon, 4 Feb 2013 16:42:23 +0000 (16:42 +0000)]
Web Inspector: take page scale factor into account when updating overlay.
https://bugs.webkit.org/show_bug.cgi?id=108831

Reviewed by Vsevolod Vlasov.

Otherwise, the ports that use page scale factor have broken overlay.

* inspector/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::update):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[v8] explicit isolate parameter for MakeWeak calls
commit-queue@webkit.org [Mon, 4 Feb 2013 15:56:52 +0000 (15:56 +0000)]
[v8] explicit isolate parameter for MakeWeak calls
https://bugs.webkit.org/show_bug.cgi?id=108818

Patch by Dan Carney <dcarney@google.com> on 2013-02-04
Reviewed by Kentaro Hara.

No new tests. No change in functionality.

* bindings/v8/DOMDataStore.cpp:
(WebCore::DOMDataStore::DOMDataStore):
(WebCore::DOMDataStore::weakCallback):
* bindings/v8/DOMDataStore.h:
(WebCore::DOMDataStore::setWrapper):
(WebCore::DOMDataStore::set):
(WebCore::DOMDataStore::setWrapperInObject):
(DOMDataStore):
* bindings/v8/DOMWrapperMap.h:
(WebCore::DOMWrapperMap::DOMWrapperMap):
(WebCore::DOMWrapperMap::set):
(WebCore::DOMWrapperMap::defaultWeakCallback):
(DOMWrapperMap):
* bindings/v8/DOMWrapperWorld.cpp:
(WebCore::isolatedWorldWeakCallback):
(WebCore::DOMWrapperWorld::makeContextWeak):
* bindings/v8/ScriptState.cpp:
(WebCore::ScriptState::ScriptState):
(WebCore::ScriptState::weakReferenceCallback):
* bindings/v8/ScriptState.h:
(ScriptState):
* bindings/v8/V8AbstractEventListener.cpp:
(WebCore::V8AbstractEventListener::weakEventListenerCallback):
(WebCore::V8AbstractEventListener::V8AbstractEventListener):
(WebCore::V8AbstractEventListener::setListenerObject):
* bindings/v8/V8AbstractEventListener.h:
(V8AbstractEventListener):
* bindings/v8/V8EventListener.cpp:
(WebCore::V8EventListener::V8EventListener):
* bindings/v8/V8LazyEventListener.cpp:
(WebCore::V8LazyEventListener::V8LazyEventListener):
* bindings/v8/V8MutationCallback.cpp:
(WebCore::V8MutationCallback::V8MutationCallback):
* bindings/v8/V8MutationCallback.h:
(WebCore::V8MutationCallback::create):
(WebCore::V8MutationCallback::weakCallback):
* bindings/v8/V8NPObject.cpp:
(WebCore::V8NPTemplateMap::set):
(WebCore::V8NPTemplateMap::sharedInstance):
(WebCore::V8NPTemplateMap::V8NPTemplateMap):
(V8NPTemplateMap):
(WebCore::V8NPTemplateMap::weakCallback):
(WebCore::npObjectGetProperty):
(WebCore):
(WebCore::staticNPObjectMap):
(WebCore::weakNPObjectCallback):
* bindings/v8/V8ValueCache.cpp:
(WebCore::cachedStringCallback):
(WebCore::StringCache::v8ExternalStringSlow):
* bindings/v8/custom/V8InjectedScriptManager.cpp:
(WebCore::WeakReferenceCallback):
(WebCore::createInjectedScriptHostV8Wrapper):
* bindings/v8/custom/V8MutationObserverCustom.cpp:
(WebCore::V8MutationObserver::constructorCallbackCustom):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WK2][EFL] Weird stripe at the end of the page
mikhail.pozdnyakov@intel.com [Mon, 4 Feb 2013 15:00:11 +0000 (15:00 +0000)]
[WK2][EFL] Weird stripe at the end of the page
https://bugs.webkit.org/show_bug.cgi?id=108820

Reviewed by Noam Rosenthal.

The page scroll bound was artificially enlarged by one causing the artifact appearance.

* UIProcess/PageViewportController.cpp:
(WebKit::PageViewportController::boundContentsPositionAtScale):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDisable -webkit-overflow-scrolling CSS attribute on Chromium
commit-queue@webkit.org [Mon, 4 Feb 2013 14:45:41 +0000 (14:45 +0000)]
Disable -webkit-overflow-scrolling CSS attribute on Chromium
https://bugs.webkit.org/show_bug.cgi?id=108020

Patch by Sami Kyostila <skyostil@chromium.org> on 2013-02-04
Reviewed by James Robinson.

Now that we can automatically promote overflow elements to accelerated
scrolling layers there is no use for the -webkit-overflow-scrolling CSS
attribute any longer on Chromium.

Source/WebKit/chromium:

This patch enables composited overflow scrolling in
ScrollingCoordinatorChromiumTest. Because this also causes the overflow div
in non-fast-scrollable.html to become composited, we also need to modify that
test to opt it out of composited scrolling.

* features.gypi:
* tests/ScrollingCoordinatorChromiumTest.cpp:
(WebKit::ScrollingCoordinatorChromiumTest::ScrollingCoordinatorChromiumTest):
(WebKit::TEST_F):
* tests/data/non-fast-scrollable.html:
* tests/data/overflow-scrolling.html: Renamed from Source/WebKit/chromium/tests/data/touch-overflow-scrolling.html.

LayoutTests:

The following tests using -webkit-overflow-scroll are modified to also call
setAcceleratedCompositingForOverflowScrollEnabled(). This makes them test
meaningful things on also on platforms that do not support that CSS attribute.

* compositing/overflow/clipping-ancestor-with-accelerated-scrolling-ancestor.html:
* compositing/overflow/iframe-inside-overflow-clipping.html:
* compositing/overflow/nested-scrolling.html:
* compositing/overflow/overflow-clip-with-accelerated-scrolling-ancestor.html:
* compositing/overflow/scrolling-content-clip-to-viewport.html:
* compositing/overflow/scrolling-without-painting.html:
* compositing/overflow/textarea-scroll-touch.html:
* compositing/overflow/updating-scrolling-content.html:
* platform/chromium-android/compositing/layer-creation/overflow-scrolling-touch-expected.txt: Removed.
* platform/chromium-android/compositing/layer-creation/overflow-scrolling-touch.html: Removed.
* platform/chromium-linux/compositing/overflow/nested-scrolling-expected.png:
* platform/chromium/TestExpectations:
* platform/chromium/compositing/overflow/overflow-auto-with-touch-toggle-expected.txt: Removed.
* platform/chromium/compositing/overflow/overflow-scrolling-touch-stacking-context-expected.png: Removed.
* platform/chromium/compositing/overflow/overflow-scrolling-touch-stacking-context-expected.txt: Removed.
* platform/chromium/compositing/overflow/overflow-scrolling-touch-stacking-context.html: Removed.
* platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/overflow-auto-with-touch-toggle-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Allow user to change dock side by dragging toolbar
commit-queue@webkit.org [Mon, 4 Feb 2013 14:43:25 +0000 (14:43 +0000)]
Web Inspector: Allow user to change dock side by dragging toolbar
https://bugs.webkit.org/show_bug.cgi?id=108073

Dragging toolbar to the right/bottom will change the dock side accordingly
instead of changing the inspector window height (if dock to right is available).

Patch by Dmitry Gozman <dgozman@chromium.org> on 2013-02-04
Reviewed by Pavel Feldman.

No new tests, because of pure inspector UI change.

* inspector/front-end/DockController.js:
(WebInspector.DockController.prototype.dockSide):
* inspector/front-end/Toolbar.js:
(WebInspector.Toolbar):
(WebInspector.Toolbar.prototype._isDockedToBottom):
(WebInspector.Toolbar.prototype._isUndocked):
(WebInspector.Toolbar.prototype._toolbarDragStart):
(WebInspector.Toolbar.prototype._toolbarDragEnd):
(WebInspector.Toolbar.prototype._toolbarDrag):
(WebInspector.Toolbar.prototype._toolbarDragMoveWindow):
(WebInspector.Toolbar.prototype._toolbarDragChangeDocking):
(WebInspector.Toolbar.prototype._toolbarDragChangeHeight):
* inspector/front-end/UIUtils.js:
(WebInspector._elementDragStart):
(WebInspector._elementDragMove):
(WebInspector._cancelDragEvents):
(WebInspector._elementDragEnd):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening. Skipping failing tests.
kadam@inf.u-szeged.hu [Mon, 4 Feb 2013 14:35:54 +0000 (14:35 +0000)]
[Qt] Unreviewed gardening. Skipping failing tests.

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2013-02-04

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: sync list of console API methods to that used by auto-complete
caseq@chromium.org [Mon, 4 Feb 2013 14:23:47 +0000 (14:23 +0000)]
Web Inspector: sync list of console API methods to that used by auto-complete
https://bugs.webkit.org/show_bug.cgi?id=108804

Reviewed by Pavel Feldman.

- push new method names from InjectedScriptSource to RuntimeModel;
- add a comment to InjectedScriptSource noting the necessity of keeping lists in sync.

* inspector/InjectedScriptSource.js:
* inspector/front-end/RuntimeModel.js:
(WebInspector.RuntimeModel.prototype.receivedPropertyNames):
(WebInspector.RuntimeModel.prototype._completionsForExpression):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: [Network] Minor refactorings.
caseq@chromium.org [Mon, 4 Feb 2013 14:08:50 +0000 (14:08 +0000)]
Web Inspector: [Network] Minor refactorings.
https://bugs.webkit.org/show_bug.cgi?id=108162

Patch by Eugene Klyuchnikov <eustas@chromium.org> on 2013-02-04
Reviewed by Vsevolod Vlasov.

Apply minor refactorings to NetworkPanel.js
Add hint to statusbar selector buttons.

* English.lproj/localizedStrings.js: Added hint string.
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._createStatusBarItems): Ditto.
(WebInspector.NetworkLogView.prototype._makeHeaderFragment):
Applied minor refactoring.
(WebInspector.NetworkLogView.prototype._createStatusBarItems.createFilterElement):
Ditto.
(WebInspector.NetworkLogView.prototype._updateOffscreenRows): Ditto.
(WebInspector.NetworkPanel.prototype._onRowSizeChanged): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: [CPU Profile] Apply minor refactorings and add JSDocs.
caseq@chromium.org [Mon, 4 Feb 2013 13:55:56 +0000 (13:55 +0000)]
Web Inspector: [CPU Profile] Apply minor refactorings and add JSDocs.
https://bugs.webkit.org/show_bug.cgi?id=108437

Patch by Eugene Klyuchnikov <eustas@chromium.org> on 2013-02-04
Reviewed by Pavel Feldman.

CPU Profile code has obsolete inline-comments to clarify types.
Currently we use JSDocs to specify types.

Also applied some minor refactorings.

* inspector/front-end/BottomUpProfileDataGridTree.js:
(WebInspector.BottomUpProfileDataGridNode):
Added JSDocs. Removed profileView parameter.
(WebInspector.BottomUpProfileDataGridNode.prototype._takePropertiesFromProfileDataGridNode):
Added JSDocs.
(WebInspector.BottomUpProfileDataGridNode.prototype._keepOnlyChild):
Ditto.
(WebInspector.BottomUpProfileDataGridNode.prototype._merge):
Ditto.
(WebInspector.BottomUpProfileDataGridNode.prototype._sharedPopulate):
Do not pass profileView to constructor.
(WebInspector.BottomUpProfileDataGridTree):
Added JSDocs. Renamed parameters.
(WebInspector.BottomUpProfileDataGridTree.prototype.focus):
Added JSDocs.
(WebInspector.BottomUpProfileDataGridTree.prototype.exclude):
Ditto.
* inspector/front-end/CPUProfileView.js: Removed unused getter/setter.
(WebInspector.CPUProfileView.prototype._getCPUProfileCallback):
Un-nested. Added JSDocs.
(WebInspector.CPUProfileView.prototype._getBottomUpProfileDataGridTree):
Added JSDocs. Turned to method from getter. Simplified.
(WebInspector.CPUProfileView.prototype._getTopDownProfileDataGridTree):
Added JSDocs. Turned to method from getter.
(WebInspector.CPUProfileView.prototype._assignParentsInProfile):
Optimized.
* inspector/front-end/DataGrid.js: Added JSDocs.
* inspector/front-end/ProfileDataGridTree.js:
(WebInspector.ProfileDataGridNode):
Added JSDocs. Removed profileView parameter.
(WebInspector.ProfileDataGridNode.prototype.createCell): Added JSDocs.
(WebInspector.ProfileDataGridNode.prototype.sort): Ditto.
(WebInspector.ProfileDataGridNode.prototype.insertChild): Ditto.
(WebInspector.ProfileDataGridNode.prototype.removeChild): Ditto.
(WebInspector.ProfileDataGridNode.prototype.removeChildren):
Added JSDocs. Removed parameter.
(WebInspector.ProfileDataGridNode.prototype.findChild): Added JSDocs.
(WebInspector.ProfileDataGridTree): Added JSDocs. Renamed parameter.
* inspector/front-end/TopDownProfileDataGridTree.js:
(WebInspector.TopDownProfileDataGridNode):
Added JSDocs. Removed profileView parameter.
(WebInspector.TopDownProfileDataGridNode.prototype._sharedPopulate):
Do not pass profileView to constructor.
(WebInspector.TopDownProfileDataGridTree):
Added JSDocs. Renamed parameter.
(WebInspector.TopDownProfileDataGridTree.prototype.focus):
Added JSDocs.
(WebInspector.TopDownProfileDataGridTree.prototype.exclude):
Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[v8] use toV8Fast in hand coded callbacks
commit-queue@webkit.org [Mon, 4 Feb 2013 13:48:31 +0000 (13:48 +0000)]
[v8] use toV8Fast in hand coded callbacks
https://bugs.webkit.org/show_bug.cgi?id=108817

Patch by Dan Carney <dcarney@google.com> on 2013-02-04
Reviewed by Kentaro Hara.

No new tests. No change in functionality.

* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::openCallback):
(WebCore::V8DOMWindow::indexedPropertyGetter):
(WebCore::V8DOMWindow::namedPropertyGetter):
* bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::V8Document::evaluateCallback):
* bindings/v8/custom/V8DocumentLocationCustom.cpp:
(WebCore::V8Document::locationAccessorGetter):
* bindings/v8/custom/V8EventCustom.cpp:
(WebCore::V8Event::dataTransferAccessorGetter):
(WebCore::V8Event::clipboardDataAccessorGetter):
* bindings/v8/custom/V8FileReaderCustom.cpp:
(WebCore::V8FileReader::resultAccessorGetter):
* bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:
(WebCore):
(WebCore::getNamedItems):
(WebCore::getItem):
(WebCore::V8HTMLAllCollection::namedPropertyGetter):
(WebCore::V8HTMLAllCollection::itemCallback):
(WebCore::V8HTMLAllCollection::namedItemCallback):
(WebCore::V8HTMLAllCollection::callAsFunctionCallback):
* bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
(WebCore::V8HTMLCanvasElement::getContextCallback):
* bindings/v8/custom/V8HTMLCollectionCustom.cpp:
(WebCore::V8HTMLCollection::namedPropertyGetter):
* bindings/v8/custom/V8HTMLElementCustom.cpp:
(WebCore::V8HTMLElement::itemValueAccessorGetter):
* bindings/v8/custom/V8HTMLFormControlsCollectionCustom.cpp:
(WebCore):
(WebCore::getNamedItems):
(WebCore::V8HTMLFormControlsCollection::namedPropertyGetter):
(WebCore::V8HTMLFormControlsCollection::namedItemCallback):
* bindings/v8/custom/V8HTMLFormElementCustom.cpp:
(WebCore::V8HTMLFormElement::indexedPropertyGetter):
(WebCore::V8HTMLFormElement::namedPropertyGetter):
* bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp:
(WebCore::V8HTMLFrameSetElement::namedPropertyGetter):
* bindings/v8/custom/V8HTMLLinkElementCustom.cpp:
(WebCore::V8HTMLLinkElement::sizesAccessorGetter):
* bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
(WebCore):
(WebCore::getNamedItems):
(WebCore::V8HTMLOptionsCollection::namedPropertyGetter):
(WebCore::V8HTMLOptionsCollection::namedItemCallback):
(WebCore::V8HTMLOptionsCollection::indexedPropertyGetter):
* bindings/v8/custom/V8HTMLSelectElementCustom.cpp:
(WebCore::V8HTMLSelectElement::indexedPropertyGetter):
* bindings/v8/custom/V8MessageEventCustom.cpp:
(WebCore::V8MessageEvent::dataAccessorGetter):
(WebCore::V8MessageEvent::portsAccessorGetter):
* bindings/v8/custom/V8NamedNodeMapCustom.cpp:
(WebCore::V8NamedNodeMap::indexedPropertyGetter):
(WebCore::V8NamedNodeMap::namedPropertyGetter):
* bindings/v8/custom/V8NodeListCustom.cpp:
(WebCore::V8NodeList::namedPropertyGetter):
* bindings/v8/custom/V8PopStateEventCustom.cpp:
(WebCore::V8PopStateEvent::stateAccessorGetter):
* bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:
(WebCore::V8SQLTransactionSync::executeSqlCallback):
* bindings/v8/custom/V8StyleSheetListCustom.cpp:
(WebCore::V8StyleSheetList::namedPropertyGetter):
* bindings/v8/custom/V8TrackEventCustom.cpp:
(WebCore::V8TrackEvent::trackAccessorGetter):
* bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
(WebCore::V8XMLHttpRequest::responseAccessorGetter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove duplicate entry from DumpRenderTree Xcode project
ddkilzer@apple.com [Mon, 4 Feb 2013 12:44:19 +0000 (12:44 +0000)]
Remove duplicate entry from DumpRenderTree Xcode project

    $ uniq Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj | diff -u - Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj | patch -p0 -R
    patching file Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj

* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
Remove duplicate.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSort TestWebKitAPI Xcode project file
ddkilzer@apple.com [Mon, 4 Feb 2013 12:41:25 +0000 (12:41 +0000)]
Sort TestWebKitAPI Xcode project file

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSort WebKit2 Xcode project file
ddkilzer@apple.com [Mon, 4 Feb 2013 12:36:31 +0000 (12:36 +0000)]
Sort WebKit2 Xcode project file

* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove duplicate entry from WebCore Xcode project
ddkilzer@apple.com [Mon, 4 Feb 2013 12:32:57 +0000 (12:32 +0000)]
Remove duplicate entry from WebCore Xcode project

    $ uniq Source/WebCore/WebCore.xcodeproj/project.pbxproj | diff -u - Source/WebCore/WebCore.xcodeproj/project.pbxproj | patch -p0 -R
    patching file Source/WebCore/WebCore.xcodeproj/project.pbxproj

* WebCore.xcodeproj/project.pbxproj: Remove duplicate.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSort WebCore Xcode project file
ddkilzer@apple.com [Mon, 4 Feb 2013 12:30:05 +0000 (12:30 +0000)]
Sort WebCore Xcode project file

* WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove duplicate entries from JavaScriptCore Xcode project
ddkilzer@apple.com [Mon, 4 Feb 2013 12:26:41 +0000 (12:26 +0000)]
Remove duplicate entries from JavaScriptCore Xcode project

    $ uniq Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj | diff -u - Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj | patch -p0 -R
    patching file Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj

* JavaScriptCore.xcodeproj/project.pbxproj: Remove duplicates.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WK2][Qt] Replace WebPageGroup usage for user scripts with WKPageGroupRef
hausmann@webkit.org [Mon, 4 Feb 2013 12:21:32 +0000 (12:21 +0000)]
[WK2][Qt] Replace WebPageGroup usage for user scripts with WKPageGroupRef
https://bugs.webkit.org/show_bug.cgi?id=108651

Reviewed by Sam Weinig.

It's straight-forward port towards the C API.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::initialize):
(readUserScript):
(QQuickWebViewPrivate::updateUserScripts):
* UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSort JavaScriptCore Xcode project file
ddkilzer@apple.com [Mon, 4 Feb 2013 12:21:32 +0000 (12:21 +0000)]
Sort JavaScriptCore Xcode project file

* JavaScriptCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSort WTF Xcode project file
ddkilzer@apple.com [Mon, 4 Feb 2013 12:14:35 +0000 (12:14 +0000)]
Sort WTF Xcode project file

* WTF.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSort ANGLE Xcode project file.
ddkilzer@apple.com [Mon, 4 Feb 2013 12:13:17 +0000 (12:13 +0000)]
Sort ANGLE Xcode project file.

* ANGLE.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[v8] disable ascii check once latin-1 is enabled in v8
commit-queue@webkit.org [Mon, 4 Feb 2013 11:34:31 +0000 (11:34 +0000)]
[v8] disable ascii check once latin-1 is enabled in v8
https://bugs.webkit.org/show_bug.cgi?id=108805

Patch by Dan Carney <dcarney@google.com> on 2013-02-04
Reviewed by Kentaro Hara.

No new tests. No change in functionality.

* bindings/v8/V8ValueCache.cpp:
(WebCore::makeExternalString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: make tabbed pane header a relayout boundary.
pfeldman@chromium.org [Mon, 4 Feb 2013 10:46:48 +0000 (10:46 +0000)]
Web Inspector: make tabbed pane header a relayout boundary.
https://bugs.webkit.org/show_bug.cgi?id=108650

Reviewed by Alexander Pavlov.

Otherwise, its measure width routine causes total reflow.

* inspector/front-end/tabbedPane.css:
(.tabbed-pane-header):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSplit InspectorCSSOMWrappers out from StyleResolver.h into its own file.
hayato@chromium.org [Mon, 4 Feb 2013 10:27:27 +0000 (10:27 +0000)]
Split InspectorCSSOMWrappers out from StyleResolver.h into its own file.
https://bugs.webkit.org/show_bug.cgi?id=108797

Reviewed by Hajime Morita.

This is a following patch after r141373. Now we can have
InspectorCSSOMWrappers in its own file since CSSDefaultStyleSheets
was factored out from StyleResolver.cpp in r141733.

WebCore/inspector/ directory is used for basic inspector
functionalities. Therefore, I've put
InspectorCSSOMWrappers.{h,cpp} in WebCore/css/ rather than
WebCore/inspector/.

No new tests, refactoring only.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSAllInOne.cpp:
* css/InspectorCSSOMWrappers.cpp: Added.
(WebCore):
(WebCore::InspectorCSSOMWrappers::collectFromStyleSheetIfNeeded):
(WebCore::InspectorCSSOMWrappers::collect):
(WebCore::InspectorCSSOMWrappers::collectFromStyleSheetContents):
(WebCore::InspectorCSSOMWrappers::collectFromStyleSheets):
(WebCore::InspectorCSSOMWrappers::collectFromDocumentStyleSheetCollection):
(WebCore::InspectorCSSOMWrappers::getWrapperForRuleInSheets):
(WebCore::InspectorCSSOMWrappers::reportMemoryUsage):
* css/InspectorCSSOMWrappers.h: Added.
(WebCore):
(InspectorCSSOMWrappers):
* css/StyleResolver.cpp:
* css/StyleResolver.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Soup] Wrap SoupSession by NetworkStorageSession
kbalazs@webkit.org [Mon, 4 Feb 2013 09:33:30 +0000 (09:33 +0000)]
[Soup] Wrap SoupSession by NetworkStorageSession
https://bugs.webkit.org/show_bug.cgi?id=108615

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Implement NetworkStorageSession for ports using soup. It has been
separated from NetworkingContext, so now we have a default storage
session, which is the same as before but now wrapped with NetworkStorageSession,
and it can be overridden by the networking context.

No change in behavior so no new tests.

* CMakeLists.txt:
* GNUmakefile.list.am:
* PlatformBlackBerry.cmake:
* PlatformEfl.cmake:
* loader/CookieJar.cpp:
(WebCore):
Now we also get the storage session from the networking context
and not the other way.

* platform/network/NetworkStorageSession.h:
(NetworkStorageSession):
(WebCore::NetworkStorageSession::setSoupSession):
(WebCore::NetworkStorageSession::soupSession):
Hold a SoupSession pointer for ports using soup. Added a setter because it is
necessary for API's that allow it to be specified per page, like EFL WK1.

* platform/network/NetworkingContext.h:
(NetworkingContext):
* platform/network/soup/CookieJarSoup.cpp:
(WebCore::cookieJarForSession):
* platform/network/soup/NetworkStorageSessionSoup.cpp: Copied from Source/WebKit2/WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.cpp.
(WebCore::NetworkStorageSession::NetworkStorageSession):
(WebCore::NetworkStorageSession::defaultStorageSession):
(WebCore::NetworkStorageSession::createDefaultSession):
(WebCore::NetworkStorageSession::createPrivateBrowsingSession):
(WebCore::NetworkStorageSession::switchToNewTestingSession):
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::sessionFromContext):

* CMakeLists.txt:
* GNUmakefile.list.am:
* PlatformBlackBerry.cmake:
* PlatformEfl.cmake:
* loader/CookieJar.cpp:
(WebCore):
* platform/network/NetworkStorageSession.h:
(NetworkStorageSession):
(WebCore::NetworkStorageSession::setSoupSession):
(WebCore::NetworkStorageSession::soupSession):
* platform/network/NetworkingContext.h:
(NetworkingContext):
* platform/network/soup/CookieJarSoup.cpp:
(WebCore::cookieJarForSession):
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::sessionFromContext):

Source/WebKit/efl:

Changed to hold the SoupSession pointer in a NetworkStorageSession
so we can pass it to WebCore. _Ewk_View_Private_Data has to be
changed for that reason.

* WebCoreSupport/FrameNetworkingContextEfl.cpp:
(WebCore::FrameNetworkingContextEfl::storageSession):
* WebCoreSupport/FrameNetworkingContextEfl.h:
(FrameNetworkingContextEfl):
* ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_ewk_view_priv_new):
(ewk_view_soup_session_get):
(ewk_view_soup_session_set):
(EWKPrivate::storageSession):
(EWKPrivate):
* ewk/ewk_view_private.h:
(EWKPrivate):

Source/WebKit/gtk:

* WebCoreSupport/FrameNetworkingContextGtk.cpp:
(WebKit::FrameNetworkingContextGtk::storageSession):
* WebCoreSupport/FrameNetworkingContextGtk.h:
(FrameNetworkingContextGtk):

Source/WebKit2:

* WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.cpp:
(WebKit::WebFrameNetworkingContext::storageSession):
* WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.h:
(WebFrameNetworkingContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Rebaseline for r141741
tkent@chromium.org [Mon, 4 Feb 2013 09:08:04 +0000 (09:08 +0000)]
[Chromium] Rebaseline for r141741
https://bugs.webkit.org/show_bug.cgi?id=108791

* platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
* platform/chromium-win-xp/fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events-expected.txt: Removed.
* platform/chromium-win-xp/fast/forms/date/date-appearance-l10n-expected.png:
* platform/chromium-win-xp/fast/forms/datetime/datetime-appearance-l10n-expected.png:
* platform/chromium-win-xp/fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-keyboard-events-expected.txt: Removed.
* platform/chromium-win-xp/fast/forms/datetimelocal/datetimelocal-appearance-l10n-expected.png:
* platform/chromium-win-xp/fast/forms/month/month-appearance-l10n-expected.png:
* platform/chromium-win-xp/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt: Removed.
* platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
* platform/chromium-win-xp/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-locale-hebrew-expected.png:
* platform/chromium-win-xp/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew-expected.png:
* platform/chromium-win-xp/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: source location in statusbar has few bugs in it
commit-queue@webkit.org [Mon, 4 Feb 2013 09:01:20 +0000 (09:01 +0000)]
Web Inspector: source location in statusbar has few bugs in it
https://bugs.webkit.org/show_bug.cgi?id=108748

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-04
Reviewed by Vsevolod Vlasov.

Call super method statusBarItems in SnippetJavaScriptSourceFrame class
and merge its results. Fix css styles for source location in statusbar
and rename its css class into a less confusing name.

No new test: no change in behaviour.

* inspector/front-end/SnippetJavaScriptSourceFrame.js:
(WebInspector.SnippetJavaScriptSourceFrame.prototype.statusBarItems):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame):
* inspector/front-end/inspector.css:
(.source-frame-cursor-position):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCleanup: Normalize usage of ExceptionCode in ContainerNode::checkXxxChild()
mkwst@chromium.org [Mon, 4 Feb 2013 08:26:53 +0000 (08:26 +0000)]
Cleanup: Normalize usage of ExceptionCode in ContainerNode::checkXxxChild()
https://bugs.webkit.org/show_bug.cgi?id=108766

Reviewed by Kentaro Hara.

This patch refactors checkAddChild and checkReplaceChild to remove the
creation of an extra ExceptionCode that's not necessary for the
desired behavior, and to bring the ExceptionCode usage into line with
the rest of WebKit (this was the only case where ExceptionCode was
assigned inside an 'if' statement's condition).

After this patch, 'ec' will always be assigned a value, even if the
result of 'checkAcceptChild' is 0. This would only change behavior if
'ec' was non-zero coming into the function, and 'checkAcceptChild'
returned 0. Since every callsite is either directly after an explicit
zeroing of 'ec', or after an 'if (ec)' clause, that case should never
appear. This patch, therefore, shouldn't visibly change WebKit's
behavior.

* dom/ContainerNode.cpp:
(WebCore::checkAddChild):
(WebCore::checkReplaceChild):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL][WK2] Mark fast/dom/DOMImplementation/createDocument-with-used-doctype.html...
commit-queue@webkit.org [Mon, 4 Feb 2013 07:44:10 +0000 (07:44 +0000)]
[EFL][WK2] Mark fast/dom/DOMImplementation/createDocument-with-used-doctype.html as flaky
https://bugs.webkit.org/show_bug.cgi?id=108793

Unreviewed EFL gardening.

Mark fast/dom/DOMImplementation/createDocument-with-used-doctype.html as
flaky due to Bug 108058. It sometimes crashes on the bots.

Patch by Christophe Dumez <dchris@gmail.com> on 2013-02-03

* platform/efl-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpstream ENABLE_PDFKIT_PLUGIN settting
ddkilzer@apple.com [Mon, 4 Feb 2013 07:16:37 +0000 (07:16 +0000)]
Upstream ENABLE_PDFKIT_PLUGIN settting
<http://webkit.org/b/108792>

Reviewed by Tim Horton.

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig: Disable PDFKIT_PLUGIN
on iOS since PDFKit is a Mac-only framework.

Source/WebCore:

* Configurations/FeatureDefines.xcconfig: Disable PDFKIT_PLUGIN
on iOS since PDFKit is a Mac-only framework.

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig: Disable PDFKIT_PLUGIN
on iOS since PDFKit is a Mac-only framework.

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig: Disable PDFKIT_PLUGIN
on iOS since PDFKit is a Mac-only framework.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Silently block one more directory needed for NSApplication initialization.
ap@apple.com [Mon, 4 Feb 2013 07:14:15 +0000 (07:14 +0000)]
    Silently block one more directory needed for NSApplication initialization.

        Reviewed by Sam Weinig.

        * WebProcess/com.apple.WebProcess.sb.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSplit per-resolve logic out from StyleResolver.
tasak@google.com [Mon, 4 Feb 2013 07:02:55 +0000 (07:02 +0000)]
Split per-resolve logic out from StyleResolver.
https://bugs.webkit.org/show_bug.cgi?id=96421

Reviewed by Eric Seidel.

Implemented class StyleResolver::State and added m_state to
StyleResolver. All member variables used for per-resolve logic are
moved into the state class.

No new tests, because just refactoring.

* css/SVGCSSStyleSelector.cpp:
(WebCore::StyleResolver::applySVGProperty):
* css/StyleResolver.cpp:
(WebCore):
(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::collectMatchingRules):
(WebCore::StyleResolver::collectMatchingRulesForRegion):
(WebCore::StyleResolver::sortAndTransferMatchedRules):
(WebCore::StyleResolver::matchScopedAuthorRules):
(WebCore::StyleResolver::styleSharingCandidateMatchesHostRules):
(WebCore::StyleResolver::matchHostRules):
(WebCore::StyleResolver::matchAuthorRules):
(WebCore::StyleResolver::matchUserRules):
(WebCore::StyleResolver::matchUARules):
(WebCore::StyleResolver::collectMatchingRulesForList):
(WebCore::StyleResolver::sortMatchedRules):
(WebCore::StyleResolver::matchAllRules):
(WebCore::StyleResolver::initElement):
(WebCore::StyleResolver::initForStyleResolve):
(WebCore::StyleResolver::styleSharingCandidateMatchesRuleSet):
(WebCore::StyleResolver::canShareStyleWithControl):
(WebCore::StyleResolver::sharingCandidateHasIdenticalStyleAffectingAttributes):
(WebCore::StyleResolver::canShareStyleWithElement):
(WebCore::StyleResolver::locateSharedStyle):
(WebCore::StyleResolver::styleForElement):
(WebCore::StyleResolver::styleForKeyframe):
(WebCore::StyleResolver::pseudoStyleForElement):
(WebCore::StyleResolver::styleForPage):
(WebCore::StyleResolver::defaultStyleForElement):
(WebCore::StyleResolver::adjustRenderStyle):
(WebCore::StyleResolver::updateFont):
(WebCore::StyleResolver::cacheBorderAndBackground):
(WebCore::StyleResolver::pseudoStyleRulesForElement):
(WebCore::StyleResolver::ruleMatches):
(WebCore::StyleResolver::checkRegionSelector):
(WebCore::StyleResolver::applyProperties):
(WebCore::StyleResolver::applyMatchedProperties):
(WebCore::StyleResolver::isLeftPage):
(WebCore::StyleResolver::applyPropertyToStyle):
(WebCore::StyleResolver::useSVGZoomRules):
(WebCore::createGridTrackBreadth):
(WebCore::createGridTrackMinMax):
(WebCore::createGridTrackGroup):
(WebCore::createGridTrackList):
(WebCore::StyleResolver::resolveVariables):
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::cachedOrPendingFromValue):
(WebCore::StyleResolver::generatedOrPendingFromValue):
(WebCore::StyleResolver::setOrPendingFromValue):
(WebCore::StyleResolver::cursorOrPendingFromValue):
(WebCore::StyleResolver::checkForTextSizeAdjust):
(WebCore::StyleResolver::initializeFontStyle):
(WebCore::StyleResolver::setFontSize):
(WebCore::StyleResolver::colorFromPrimitiveValue):
(WebCore::StyleResolver::loadPendingSVGDocuments):
(WebCore::StyleResolver::cachedOrPendingStyleShaderFromValue):
(WebCore::StyleResolver::loadPendingShaders):
(WebCore::StyleResolver::parseCustomFilterTransformParameter):
(WebCore::StyleResolver::createFilterOperations):
(WebCore::StyleResolver::loadPendingImage):
(WebCore::StyleResolver::loadPendingImages):
(WebCore::StyleResolver::reportMemoryUsage):
* css/StyleResolver.h:
(WebCore::StyleResolver::style):
(WebCore::StyleResolver::parentStyle):
(WebCore::StyleResolver::rootElementStyle):
(WebCore::StyleResolver::element):
(WebCore::StyleResolver::setFontDescription):
(WebCore::StyleResolver::setZoom):
(WebCore::StyleResolver::setEffectiveZoom):
(WebCore::StyleResolver::setTextSizeAdjust):
(WebCore::StyleResolver::setWritingMode):
(WebCore::StyleResolver::setTextOrientation):
(WebCore::StyleResolver::hasParentNode):
(WebCore::StyleResolver::addMatchedRule):
(StyleResolver):
(State):
(WebCore::StyleResolver::State::State):
(WebCore::StyleResolver::applyPropertyToRegularStyle):
(WebCore::StyleResolver::applyPropertyToVisitedLinkStyle):
Added "m_state." to access member variables used for per-resolve logic.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSupport setLangAttributeAwareFormControlUIEnabled on Chromium Windows XP
tkent@chromium.org [Mon, 4 Feb 2013 06:58:05 +0000 (06:58 +0000)]
Support setLangAttributeAwareFormControlUIEnabled on Chromium Windows XP
https://bugs.webkit.org/show_bug.cgi?id=108791

Reviewed by Kentaro Hara.

Source/WebCore:

We didn't support setLangAttributeAwareFormControlUIEnabled(true) on
Chromium Windows XP because of lack of LocaleNameToLCID API. This change
add manual mapping from locale names to LCIDs for Windows XP.

No new tests. This doesn't make any behavior changes in products, and
this improves some test results.

* platform/text/win/LocaleWin.cpp:
(WebCore): Define NameToLCIDMap.
(WebCore::removeLastComponent):
Remove the last component separated with '-'.
(WebCore::ensureNameToLCIDMap):
Add locale names used in layout tests.
(WebCore::convertLocaleNameToLCID):
Find an appropriate LCID longest matching with the specified locale name.
(WebCore::LCIDFromLocale):
Use convertLocaleNameToLCID if LocaleNameToLCID is not available.

LayoutTests:

* platform/chromium/TestExpectations:
Mark affected tests failure.
Actually we should be able to remove XP-specific test results for
them. We just mark them in this patch just in case, and do rebaseline
later.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Unreviewed, marking some as timing out.
morrita@google.com [Mon, 4 Feb 2013 06:17:14 +0000 (06:17 +0000)]
[Chromium] Unreviewed, marking some as timing out.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPatchLogs are not getting created on QueueStatusServer
commit-queue@webkit.org [Mon, 4 Feb 2013 06:16:10 +0000 (06:16 +0000)]
PatchLogs are not getting created on QueueStatusServer
https://bugs.webkit.org/show_bug.cgi?id=108593

Patch by Alan Cutter <alancutter@chromium.org> on 2013-02-03
Reviewed by Eric Seidel.

Added missing "added" patch event to submit-to-ews handler.

* QueueStatusServer/app.yaml:
* QueueStatusServer/handlers/submittoews.py:
(SubmitToEWS._add_attachment_to_ews_queues):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd FocusDirection argument to HTMLTextFormControlElement::handleFocusEvent
tkent@chromium.org [Mon, 4 Feb 2013 06:11:17 +0000 (06:11 +0000)]
Add FocusDirection argument to HTMLTextFormControlElement::handleFocusEvent
https://bugs.webkit.org/show_bug.cgi?id=108775

Reviewed by Hajime Morita.

We'd like to add a FocusDirection argument to
HTMLTextFormControlElement::handleFocusEvent in order to fix Bug
108447. This is a preparation for it.

We need to add FocusDirection arguments to some focus-related functions
to pass it correctly when TAB or Shift+TAB is pressed.

No new tests. This doesn't make any behavior changes.

* html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::dispatchFocusEvent):
To pass the FocusDirection argument to handleFocusEvent, we need to add
it to dispatchFocusEvent too.
* html/HTMLTextFormControlElement.h:
(HTMLTextFormControlElement):
Add FocusDirection arugment to dispatchFocusEvent.
(WebCore::HTMLTextFormControlElement::handleFocusEvent):
Add FocusDirection argument.

* dom/Node.cpp:
(WebCore::Node::dispatchFocusEvent): Add FocusDirection argument.
* dom/Node.h:
(Node): Ditto.

* dom/Document.cpp:
(WebCore::Document::setFocusedNode): Add FocusDirection argument in
order to pass it to Node::dispatchFocusEvent.
* dom/Document.h:
(Document): Ditto.

* page/FocusController.cpp:
(WebCore::dispatchEventsOnWindowAndFocusedNode):
Adjust Node::dispatchFocusEvent argument.
(WebCore::FocusController::advanceFocusInDocumentOrder):
Pass FocusDirectio to Element::focus.
(WebCore::FocusController::setFocusedNode):
Add FocusDirection argument in order to pass it to Document::setFocusedNode.
(WebCore::FocusController::advanceFocusDirectionallyInContainer):
Pass FocusDirectio to Element::focus.
* page/FocusController.h:
(FocusController): Add FocusDirection argument to setFocusedNode.

* dom/Element.cpp:
(WebCore::Element::focus):
Add FocusDirection argument to pass it to FocusController::setFocusedNode.
* dom/Element.h:
(Element): Ditto.

* WebCore.exp.in:
Update FocusController::setFocusedNode and Document::setFocusedNode.

* html/HTMLLabelElement.cpp:
(WebCore::HTMLLabelElement::focus): Adjust FocusDirection argument.
* html/HTMLLabelElement.h:
(HTMLLabelElement): Ditto.
* html/HTMLLegendElement.cpp:
(WebCore::HTMLLegendElement::focus): Ditto.
* html/HTMLLegendElement.h:
(HTMLLegendElement): Ditto.
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::dispatchFocusEvent): Ditto.
* html/HTMLSelectElement.h:
(HTMLSelectElement): Ditto.

* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::defaultFocus):
Add FocusDirection argument in order to pass it from
HTMLInputElement::focus() to HTMLTextFormControlElement::focus().
(WebCore::HTMLInputElement::focus):
Pass the FocusDirection argument to InputType::focus. See above.
(WebCore::HTMLInputElement::handleFocusEvent):
Adjust FocusDirection argument.
* html/HTMLInputElement.h:
(HTMLInputElement):
* html/InputType.cpp:
(WebCore::InputType::focus): Add FocusDirection argument.
* html/InputType.h:
(InputType): Ditto.

* html/BaseMultipleFieldsDateAndTimeInputType.cpp:
(WebCore::BaseMultipleFieldsDateAndTimeInputType::focus):
Add FocusDirection argument to follow InputType.
* html/BaseMultipleFieldsDateAndTimeInputType.h:
(BaseMultipleFieldsDateAndTimeInputType): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Unreviewed, marking terminate-during-sync-operation.html as timing out.
morrita@google.com [Mon, 4 Feb 2013 06:02:17 +0000 (06:02 +0000)]
[Chromium] Unreviewed, marking terminate-during-sync-operation.html as timing out.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix build warning after r141473
commit-queue@webkit.org [Mon, 4 Feb 2013 05:59:19 +0000 (05:59 +0000)]
Fix build warning after r141473
https://bugs.webkit.org/show_bug.cgi?id=108782

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2013-02-03
Reviewed by Kentaro Hara.

Fix -Wunused-parameter build warning.

Source/WebKit/blackberry:

* WebCoreSupport/EditorClientBlackBerry.cpp:
(WebCore::EditorClientBlackBerry::getClientPasteboardDataForRange):

Source/WebKit/chromium:

* src/EditorClientImpl.cpp:
(WebKit::EditorClientImpl::getClientPasteboardDataForRange):

Source/WebKit/efl:

* WebCoreSupport/EditorClientEfl.cpp:
(WebCore::EditorClientEfl::getClientPasteboardDataForRange):

Source/WebKit/gtk:

* WebCoreSupport/EditorClientGtk.cpp:
(WebKit::EditorClient::getClientPasteboardDataForRange):

Source/WebKit/qt:

* WebCoreSupport/EditorClientQt.cpp:
(WebCore::EditorClientQt::getClientPasteboardDataForRange):

Source/WebKit/win:

* WebCoreSupport/WebEditorClient.cpp:
(WebEditorClient::getClientPasteboardDataForRange):

Source/WebKit/wince:

* WebCoreSupport/EditorClientWinCE.cpp:
(WebKit::EditorClientWinCE::getClientPasteboardDataForRange):

Source/WebKit/wx:

* WebKitSupport/EditorClientWx.cpp:
(WebCore::EditorClientWx::getClientPasteboardDataForRange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdds usage instrumentation for indexedDB
commit-queue@webkit.org [Mon, 4 Feb 2013 05:11:35 +0000 (05:11 +0000)]
Adds usage instrumentation for indexedDB
Includes new header file in project files

https://bugs.webkit.org/show_bug.cgi?id=107772

Patch by Kassy Coan <kassycoan@chromium.org> on 2013-02-03
Reviewed by Tony Chang.

Currently untestable. Has zero effect apart from histogramming.

* GNUmakefile.list.am:
* Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::createObjectStore):
(WebCore::IDBDatabase::deleteObjectStore):
(WebCore::IDBDatabase::transaction):
* Modules/indexeddb/IDBFactory.cpp:
(WebCore::IDBFactory::openInternal):
(WebCore::IDBFactory::deleteDatabase):
* Modules/indexeddb/IDBHistograms.h: Added.
(WebCore):
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Add dstockwell as a contributor in comitters.py and to the watchlist...
commit-queue@webkit.org [Mon, 4 Feb 2013 04:54:53 +0000 (04:54 +0000)]
Unreviewed. Add dstockwell as a contributor in comitters.py and to the watchlist for animation
https://bugs.webkit.org/show_bug.cgi?id=108777

Patch by Douglas Stockwell <dstockwell@chromium.org> on 2013-02-03

* Scripts/webkitpy/common/config/committers.py:
* Scripts/webkitpy/common/config/watchlist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSplit default style-sheet statics out from StyleResolver into its own class
hayato@chromium.org [Mon, 4 Feb 2013 04:53:39 +0000 (04:53 +0000)]
Split default style-sheet statics out from StyleResolver into its own class
https://bugs.webkit.org/show_bug.cgi?id=107780

Reviewed by Dimitri Glazkov.

Factored static variables and logic about default style sheets out from StyleResolver into its own class
CSSDefaultStyleSheets. This is a following patch after r141373.

No new tests, refactoring only.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSAllInOne.cpp:
* css/CSSDefaultStyleSheets.cpp: Added.
(WebCore):
(WebCore::elementCanUseSimpleDefaultStyle):
(WebCore::screenEval):
(WebCore::printEval):
(WebCore::parseUASheet):
(WebCore::CSSDefaultStyleSheets::initDefaultStyle):
(WebCore::CSSDefaultStyleSheets::loadFullDefaultStyle):
(WebCore::CSSDefaultStyleSheets::loadSimpleDefaultStyle):
(WebCore::CSSDefaultStyleSheets::viewSourceStyle):
(WebCore::CSSDefaultStyleSheets::ensureDefaultStyleSheetsForElement):
* css/CSSDefaultStyleSheets.h: Added.
(WebCore):
(CSSDefaultStyleSheets):
* css/StyleResolver.cpp:
(WebCore):
(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::matchUARules):
(WebCore::StyleResolver::styleForElement):
(WebCore::StyleResolver::styleForPage):
(WebCore::InspectorCSSOMWrappers::getWrapperForRuleInSheets):
(WebCore::StyleResolver::collectFeatures):
(WebCore::StyleResolver::reportMemoryUsage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix build warning after r141648
commit-queue@webkit.org [Mon, 4 Feb 2013 04:25:45 +0000 (04:25 +0000)]
Fix build warning after r141648
https://bugs.webkit.org/show_bug.cgi?id=108784

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2013-02-03
Reviewed by Kentaro Hara.

Fix -Wunused-parameter build warning.

* UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::createStorageArea):
(WebKit::StorageManager::destroyStorageArea):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Do not call m_widgetClient->show() for WebHelperPlugin.
commit-queue@webkit.org [Mon, 4 Feb 2013 04:04:12 +0000 (04:04 +0000)]
[chromium] Do not call m_widgetClient->show() for WebHelperPlugin.
https://bugs.webkit.org/show_bug.cgi?id=108740

Patch by David Dorwin <ddorwin@chromium.org> on 2013-02-03
Reviewed by Kent Tamura.

The calls to m_widgetClient->show() and setFocus() do not appear to be
necessary, and the former causes problems on at least on platform.

* src/WebHelperPluginImpl.cpp:
(WebKit::WebHelperPluginImpl::initialize): Removed calls to m_widgetClient->show() and setFocus().
(WebKit::WebHelperPluginImpl::setFocus): Should never be called.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[V8] Simplify CodeGeneratorV8.pm by using InheritsExtendedAttribute("EventTarget")
haraken@chromium.org [Mon, 4 Feb 2013 03:22:44 +0000 (03:22 +0000)]
[V8] Simplify CodeGeneratorV8.pm by using InheritsExtendedAttribute("EventTarget")
https://bugs.webkit.org/show_bug.cgi?id=108441

Reviewed by Adam Barth.

A complicated condition in GetInternalFields() can be simplified
by using InheritsExtendedAttribute("EventTarget").

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm:
(GetInternalFields):
* dom/EventTarget.idl: Added [EventTarget] which should have been added.
* svg/SVGElementInstance.idl: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix failing test.
weinig@apple.com [Mon, 4 Feb 2013 03:09:17 +0000 (03:09 +0000)]
Fix failing test.

* TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp:
(TestWebKitAPI::didFinishLoadForFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Unreviewed rebaselining.
morrita@google.com [Mon, 4 Feb 2013 02:55:10 +0000 (02:55 +0000)]
[Chromium] Unreviewed rebaselining.

* platform/chromium-mac-lion/fast/css/resize-corner-tracking-transformed-iframe-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Soup] Do not use local variables for the client
kov@webkit.org [Mon, 4 Feb 2013 02:16:45 +0000 (02:16 +0000)]
[Soup] Do not use local variables for the client
https://bugs.webkit.org/show_bug.cgi?id=108714

Reviewed by Martin Robinson.

Covered by existing tests, refactoring code only.

We have had problems in the past with the client being destroyed or
changed inside a method or function, and we ended up with a stale
pointer, leading to crashes. This refactoring is an effort to minimize
the possibility of hitting that same issue in the future.

* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::redirectSkipCallback): no longer use a local variable to hold
the client.
(WebCore::wroteBodyDataCallback): ditto.
(WebCore::nextMultipartResponsePartCallback): ditto.
(WebCore::sendRequestCallback): ditto.
(WebCore::closeCallback): ditto.
(WebCore::readCallback): ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Unreviewed, marking grid-preferred-logical-widths.html as a fail.
morrita@google.com [Mon, 4 Feb 2013 02:15:07 +0000 (02:15 +0000)]
[Chromium] Unreviewed, marking grid-preferred-logical-widths.html as a fail.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Unreviewed, marking block-test.html as a fail.
morrita@google.com [Mon, 4 Feb 2013 01:54:56 +0000 (01:54 +0000)]
[Chromium] Unreviewed, marking block-test.html as a fail.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Skip editing/inserting/smart-link-when-caret-is-moved-before-URL.html
noel.gordon@gmail.com [Mon, 4 Feb 2013 01:37:58 +0000 (01:37 +0000)]
[chromium] Skip editing/inserting/smart-link-when-caret-is-moved-before-URL.html
https://bugs.webkit.org/show_bug.cgi?id=85463

Test added in http://trac.webkit.org/changeset/141618 - requires that DRT or WKTR
implement setAutomaticLinkDetectionEnabled().

Unreviewed gardening.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake ChangeLogEntry detect annotations by prepare-ChangeLog (Added/Removed/Copied...
commit-queue@webkit.org [Mon, 4 Feb 2013 01:03:44 +0000 (01:03 +0000)]
Make ChangeLogEntry detect annotations by prepare-ChangeLog (Added/Removed/Copied from/Renamed from) as clean.
https://bugs.webkit.org/show_bug.cgi?id=108433

Patch by Timothy Loh <timloh@chromium.com> on 2013-02-03
Reviewed by Eric Seidel.

PrepareChangeLog is supposed to update the file/function list if we
haven't touched it, but the existing regex doesn't handle the
annotations prepare-ChangeLog adds (e.g. "Added.")

* Scripts/webkitpy/common/checkout/changelog.py:
(ChangeLogEntry.is_touched_files_text_clean):
* Scripts/webkitpy/common/checkout/changelog_unittest.py:
(test_is_touched_files_text_clean):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agocalendar-picker-key-operations.html is failing
tkent@chromium.org [Mon, 4 Feb 2013 00:47:07 +0000 (00:47 +0000)]
calendar-picker-key-operations.html is failing
https://bugs.webkit.org/show_bug.cgi?id=108566

Reviewed by Kentaro Hara.

* platform/chromium/TestExpectations:
* platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations.html:
Month.createFromDate supports only UTC Date. Use the Month constructor
with local year and local month.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[V8] Pass an Isolate to HasInstance() (part 1)
haraken@chromium.org [Mon, 4 Feb 2013 00:43:25 +0000 (00:43 +0000)]
[V8] Pass an Isolate to HasInstance() (part 1)
https://bugs.webkit.org/show_bug.cgi?id=108617

Reviewed by Adam Barth.

This is one of efforts to pass an Isolate to GetTemplate().

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm:
(JSValueToNative):
* bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::Float64ArrayV8Internal::fooCallback):
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::TestActiveDOMObjectV8Internal::excitingFunctionCallback):
* bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::TestEventTargetV8Internal::dispatchEventCallback):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::TestInterfaceV8Internal::supplementalNodeAttrSetter):
(WebCore::TestInterfaceV8Internal::supplementalMethod2Callback):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::testObjAttrAttrSetter):
(WebCore::TestObjV8Internal::XMLObjAttrAttrSetter):
(WebCore::TestObjV8Internal::typedArrayAttrAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrSetter):
(WebCore::TestObjV8Internal::mutablePointAttrSetter):
(WebCore::TestObjV8Internal::immutablePointAttrSetter):
(WebCore::TestObjV8Internal::voidMethodWithArgsCallback):
(WebCore::TestObjV8Internal::longMethodWithArgsCallback):
(WebCore::TestObjV8Internal::objMethodWithArgsCallback):
(WebCore::TestObjV8Internal::methodThatRequiresAllArgsAndThrowsCallback):
(WebCore::TestObjV8Internal::overloadedMethod1Callback):
(WebCore::TestObjV8Internal::overloadedMethod2Callback):
(WebCore::TestObjV8Internal::overloadedMethod8Callback):
(WebCore::TestObjV8Internal::convert1Callback):
(WebCore::TestObjV8Internal::convert2Callback):
(WebCore::TestObjV8Internal::convert4Callback):
(WebCore::TestObjV8Internal::convert5Callback):
(WebCore::TestObjV8Internal::variadicNodeMethodCallback):
* bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:
(WebCore::V8TestOverloadedConstructors::constructor1Callback):
(WebCore::V8TestOverloadedConstructors::constructor2Callback):
(WebCore::V8TestOverloadedConstructors::constructor3Callback):
* bindings/v8/Dictionary.cpp:
(WebCore::Dictionary::get):
* bindings/v8/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::visitNodeWrappers):
* bindings/v8/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::SerializedScriptValue):
(WebCore::SerializedScriptValue::deserialize):
* bindings/v8/V8Binding.cpp:
(WebCore::toDOMStringList):
(WebCore::toXPathNSResolver):
* bindings/v8/V8Binding.h:
(WebCore):
* bindings/v8/V8Collection.cpp:
(WebCore::toOptionsCollectionSetter):
* bindings/v8/V8GCController.cpp:
(WebCore::WrapperVisitor::WrapperVisitor):
(WrapperVisitor):
(WebCore::V8GCController::majorGCPrologue):
* bindings/v8/V8NPObject.cpp:
(WebCore::npObjectInvokeImpl):
* bindings/v8/V8Utilities.cpp:
(WebCore::extractTransferables):
* bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::V8Document::evaluateCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Make distcheck fails
commit-queue@webkit.org [Mon, 4 Feb 2013 00:01:14 +0000 (00:01 +0000)]
[GTK] Make distcheck fails
https://bugs.webkit.org/show_bug.cgi?id=108756

Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2013-02-03
Reviewed by Kentaro Hara.

Source/WebCore:

* GNUmakefile.list.am: Remove header files which no longer exist;
correct one which got added incorrectly.

Source/WebKit2:

* GNUmakefile.list.am: Remove header files which no longer exist

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[V8] Pass an Isolate to HasInstance() (part 3)
haraken@chromium.org [Sun, 3 Feb 2013 23:53:55 +0000 (23:53 +0000)]
[V8] Pass an Isolate to HasInstance() (part 3)
https://bugs.webkit.org/show_bug.cgi?id=108622

Reviewed by Adam Barth.

This is one of efforts to pass an Isolate to GetTemplate().

No tests. No change in behavior.

* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::isHTMLAllCollectionCallback):
(WebCore::V8InjectedScriptHost::typeCallback):
(WebCore::V8InjectedScriptHost::getEventListenersCallback):
* bindings/v8/custom/V8NodeCustom.cpp:
(WebCore::V8Node::insertBeforeCallback):
(WebCore::V8Node::replaceChildCallback):
(WebCore::V8Node::removeChildCallback):
(WebCore::V8Node::appendChildCallback):
* bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::toWebGLUniformLocation):
(WebCore::V8WebGLRenderingContext::getAttachedShadersCallback):
(WebCore::V8WebGLRenderingContext::getProgramParameterCallback):
(WebCore::V8WebGLRenderingContext::getShaderParameterCallback):
(WebCore::V8WebGLRenderingContext::getUniformCallback):
(WebCore::vertexAttribAndUniformHelperf):
(WebCore::uniformHelperi):
(WebCore::uniformMatrixHelper):
* bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
(WebCore::isDocumentType):
(WebCore::V8XMLHttpRequest::sendCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[V8] Pass an Isolate to HasInstance() (part 2)
haraken@chromium.org [Sun, 3 Feb 2013 23:26:25 +0000 (23:26 +0000)]
[V8] Pass an Isolate to HasInstance() (part 2)
https://bugs.webkit.org/show_bug.cgi?id=108620

Reviewed by Adam Barth.

This is one of efforts to pass an Isolate to GetTemplate().

No tests. No change in behavior.

* bindings/v8/custom/V8ArrayBufferViewCustom.h:
(WebCore::constructWebGLArray):
(WebCore::setWebGLArrayHelper):
* bindings/v8/custom/V8AudioBufferSourceNodeCustom.cpp:
(WebCore::V8AudioBufferSourceNode::bufferAccessorSetter):
* bindings/v8/custom/V8BlobCustom.cpp:
(WebCore::V8Blob::constructorCallbackCustom):
* bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
(WebCore::toCanvasStyle):
(WebCore::V8CanvasRenderingContext2D::strokeStyleAccessorSetter):
* bindings/v8/custom/V8ClipboardCustom.cpp:
(WebCore::V8Clipboard::setDragImageCallback):
* bindings/v8/custom/V8CryptoCustom.cpp:
(WebCore::V8Crypto::getRandomValuesCallback):
* bindings/v8/custom/V8DOMFormDataCustom.cpp:
(WebCore::V8DOMFormData::constructorCallbackCustom):
(WebCore::V8DOMFormData::appendCallback):
* bindings/v8/custom/V8DataViewCustom.cpp:
(WebCore::V8DataView::constructorCallbackCustom):
* bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::V8Document::evaluateCallback):
* bindings/v8/custom/V8HTMLMediaElementCustom.cpp:
(WebCore::V8HTMLMediaElement::controllerAccessorSetter):
* bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
(WebCore::V8HTMLOptionsCollection::addCallback):
* bindings/v8/custom/V8HTMLSelectElementCustom.cpp:
(WebCore::removeElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCleanup: 'ExceptionCode& ec', not 'ExceptionCode &ec'.
mkwst@chromium.org [Sun, 3 Feb 2013 18:35:51 +0000 (18:35 +0000)]
Cleanup: 'ExceptionCode& ec', not 'ExceptionCode &ec'.
https://bugs.webkit.org/show_bug.cgi?id=108769

Reviewed by Eric Seidel.

Does what it says on the tin: reference parameters should read
'type& name', and this patch fixes the two occurances of 'type &name'
that cropped up for ExceptionCode.

Pure style change; no effect on behavior.

* html/HTMLOptionsCollection.cpp:
(WebCore::HTMLOptionsCollection::add):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoVector should consult allocator about ideal size when choosing capacity.
akling@apple.com [Sun, 3 Feb 2013 13:37:41 +0000 (13:37 +0000)]
Vector should consult allocator about ideal size when choosing capacity.
<http://webkit.org/b/108410>
<rdar://problem/13124002>

Reviewed by Benjamin Poulain.

Source/JavaScriptCore:

Remove assertion about Vector capacity that won't hold anymore since capacity()
may not be what you passed to reserveCapacity().
Also export WTF::fastMallocGoodSize() for Windows builds.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):

Source/WTF:

Added WTF::fastMallocGoodSize(), a workalike/wrapper for OS X's malloc_good_size().
It returns the actual size of the block that will get allocated for a given byte size.

Vector's internal buffer now checks with the allocator if the resulting allocation
could actually house more objects and updates its capacity to make use of the space.

* wtf/Deque.h:
(WTF::::expandCapacity):
* wtf/FastMalloc.cpp:
(WTF::fastMallocGoodSize):
* wtf/FastMalloc.h:
* wtf/Vector.h:
(WTF::VectorBufferBase::allocateBuffer):
(WTF::VectorBufferBase::tryAllocateBuffer):
(WTF::VectorBufferBase::reallocateBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Mark inspector/debugger/source-frame-count.html as flaky
commit-queue@webkit.org [Sun, 3 Feb 2013 12:17:33 +0000 (12:17 +0000)]
[EFL] Mark inspector/debugger/source-frame-count.html as flaky
https://bugs.webkit.org/show_bug.cgi?id=108768

Unreviewed EFL gardening.

Mark inspector/debugger/source-frame-count.html as flaky as it sometimes
crashes due to Bug 81574.

Patch by Christophe Dumez <dchris@gmail.com> on 2013-02-03

* platform/efl-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Mark a few more media tests as flaky due to gstreamer 1.0
commit-queue@webkit.org [Sun, 3 Feb 2013 10:48:22 +0000 (10:48 +0000)]
[EFL] Mark a few more media tests as flaky due to gstreamer 1.0
https://bugs.webkit.org/show_bug.cgi?id=108765

Unreviewed EFL gardening.

Mark 2 more media tests as flaky since the update to gstreamer 1.0.
They sometimes crash in MediaPlayerPrivateGStreamer dtor.

Patch by Christophe Dumez <dchris@gmail.com> on 2013-02-03

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] svg/custom/text-ctm.svg needs a baseline
commit-queue@webkit.org [Sun, 3 Feb 2013 10:42:00 +0000 (10:42 +0000)]
[EFL] svg/custom/text-ctm.svg needs a baseline
https://bugs.webkit.org/show_bug.cgi?id=108764

Unreviewed EFL gardening.

Add baseline for svg/custom/text-ctm.svg that was added in r17879.

Patch by Christophe Dumez <dchris@gmail.com> on 2013-02-03

* platform/efl/svg/custom/text-ctm-expected.png: Added.
* platform/efl/svg/custom/text-ctm-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] FileSystem mods: Changes to snapshot file creation to reduce dependencies...
michaeln@google.com [Sun, 3 Feb 2013 06:12:51 +0000 (06:12 +0000)]
[chromium] FileSystem mods: Changes to snapshot file creation to reduce dependencies on blobs.
This patch just alters the WebKitAPI in advance of coding to the new API in chromium and webkit
sources, defining two new virtual methods (unimplemented and uncalled). The existing API remains
in place and in use.
https://bugs.webkit.org/show_bug.cgi?id=108736

Reviewed by Darin Fisher.

Source/Platform:

* chromium/public/WebFileSystem.h:
(WebFileSystem):
(WebKit::WebFileSystem::createSnapshotFileAndReadMetadata):

Source/WebKit/chromium:

* public/WebFileSystemCallbacks.h:
(WebFileSystemCallbacks):
(WebKit::WebFileSystemCallbacks::didCreateSnapshotFile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove more LegacyReceivers
weinig@apple.com [Sun, 3 Feb 2013 01:14:56 +0000 (01:14 +0000)]
Remove more LegacyReceivers
https://bugs.webkit.org/show_bug.cgi?id=108758

Reviewed by Anders Carlsson.

* UIProcess/Downloads/DownloadProxy.cpp:
* UIProcess/Downloads/DownloadProxy.messages.in:
* UIProcess/WebApplicationCacheManagerProxy.cpp:
* UIProcess/WebApplicationCacheManagerProxy.h:
(WebApplicationCacheManagerProxy):
* UIProcess/WebApplicationCacheManagerProxy.messages.in:
* UIProcess/WebCookieManagerProxy.cpp:
* UIProcess/WebCookieManagerProxy.h:
(WebCookieManagerProxy):
* UIProcess/WebCookieManagerProxy.messages.in:
* UIProcess/WebDatabaseManagerProxy.cpp:
* UIProcess/WebDatabaseManagerProxy.h:
(WebDatabaseManagerProxy):
* UIProcess/WebDatabaseManagerProxy.messages.in:
* UIProcess/mac/RemoteLayerTreeHost.h:
(RemoteLayerTreeHost):
* UIProcess/mac/RemoteLayerTreeHost.messages.in:
* UIProcess/mac/RemoteLayerTreeHost.mm:
* WebProcess/ApplicationCache/WebApplicationCacheManager.cpp:
* WebProcess/ApplicationCache/WebApplicationCacheManager.h:
(WebApplicationCacheManager):
* WebProcess/ApplicationCache/WebApplicationCacheManager.messages.in:
* WebProcess/Cookies/WebCookieManager.cpp:
* WebProcess/Cookies/WebCookieManager.h:
(WebCookieManager):
* WebProcess/Cookies/WebCookieManager.messages.in:
* WebProcess/WebCoreSupport/WebDatabaseManager.cpp:
* WebProcess/WebCoreSupport/WebDatabaseManager.h:
(WebDatabaseManager):
* WebProcess/WebCoreSupport/WebDatabaseManager.messages.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoConvert CustomProtocolManagerProxy, CustomProtocolManager and AuthenticationManager...
weinig@apple.com [Sun, 3 Feb 2013 01:11:02 +0000 (01:11 +0000)]
Convert CustomProtocolManagerProxy, CustomProtocolManager and AuthenticationManager to be non-LegacyReceivers
https://bugs.webkit.org/show_bug.cgi?id=108757

Reviewed by Anders Carlsson.

* Shared/Authentication/AuthenticationManager.cpp:
* Shared/Authentication/AuthenticationManager.h:
(AuthenticationManager):
* Shared/Authentication/AuthenticationManager.messages.in:
* Shared/Network/CustomProtocols/CustomProtocolManager.h:
(CustomProtocolManager):
* Shared/Network/CustomProtocols/CustomProtocolManager.messages.in:
* Shared/Network/CustomProtocols/mac/CustomProtocolManagerMac.mm:
* UIProcess/Network/CustomProtocols/CustomProtocolManagerProxy.h:
(CustomProtocolManagerProxy):
* UIProcess/Network/CustomProtocols/CustomProtocolManagerProxy.messages.in:
* UIProcess/Network/CustomProtocols/mac/CustomProtocolManagerProxyMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL][WK2] Use C API inside ewk_file_chooser_request
christophe.dumez@intel.com [Sun, 3 Feb 2013 00:14:41 +0000 (00:14 +0000)]
[EFL][WK2] Use C API inside ewk_file_chooser_request
https://bugs.webkit.org/show_bug.cgi?id=107811

Reviewed by Sam Weinig.

Use C API inside ewk_file_chooser_request instead of
accessing the internal C++ classes directly, to
avoid violating API layering.

* UIProcess/API/efl/ewk_file_chooser_request.cpp:
(EwkFileChooserRequest::EwkFileChooserRequest):
(EwkFileChooserRequest::~EwkFileChooserRequest):
(EwkFileChooserRequest::allowMultipleFiles):
(EwkFileChooserRequest::acceptedMIMETypes):
(EwkFileChooserRequest::cancel):
(EwkFileChooserRequest::chooseFiles):
(ewk_file_chooser_request_accepted_mimetypes_get):
(ewk_file_chooser_request_files_choose):
(ewk_file_chooser_request_file_choose):
* UIProcess/API/efl/ewk_file_chooser_request_private.h:
(EwkFileChooserRequest::create):
(EwkFileChooserRequest):
* UIProcess/efl/PageUIClientEfl.cpp:
(WebKit::PageUIClientEfl::runOpenPanel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoStop keeping a frame tree in the UIProcess
weinig@apple.com [Sat, 2 Feb 2013 23:50:18 +0000 (23:50 +0000)]
Stop keeping a frame tree in the UIProcess
https://bugs.webkit.org/show_bug.cgi?id=81728

Reviewed by Oliver Hunt.

This patch removes the parent/child relationships of WebFrameProxys
in the UIProcess

* UIProcess/API/C/WKFrame.cpp:
(WKFrameCopyChildFrames):
(WKFrameGetParentFrame):
* UIProcess/API/C/WKFrame.h:
Null out the implementations of WKFrameCopyChildFrames and WKFrameGetParentFrame,
but keep them around as their symbols are still needed for nightlies.

* UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::WebFrameProxy):
(WebKit::WebFrameProxy::disconnect):
* UIProcess/WebFrameProxy.h:
Remove parent/child connections.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didCreateSubframe):
(WebKit::WebPageProxy::didRemoveFrameFromHierarchy):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::didSaveToPageCache):
(WebKit::WebFrameLoaderClient::didRestoreFromPageCache):
* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::createSubframe):
Remove/Update messages that only served to update the parent/child connection.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd Antoine Quint to the list of committers
dino@apple.com [Sat, 2 Feb 2013 23:01:41 +0000 (23:01 +0000)]
Add Antoine Quint to the list of committers
https://bugs.webkit.org/show_bug.cgi?id=108750

No review necessary.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoOptimize some operations for float type in texture format conversions of WebGL
commit-queue@webkit.org [Sat, 2 Feb 2013 22:32:34 +0000 (22:32 +0000)]
Optimize some operations for float type in texture format conversions of WebGL
https://bugs.webkit.org/show_bug.cgi?id=107526

Patch by Jun Jiang <jun.a.jiang@intel.com> on 2013-02-02
Reviewed by Darin Adler.

Some small changes are made to optimize the operations for float type in the texture format conversion of WebGL to improve performance.

Already covered by current tests.

* platform/graphics/GraphicsContext3D.cpp:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake it possible to modify the connection from ChildProcessProxy subclasses.
weinig@apple.com [Sat, 2 Feb 2013 22:26:41 +0000 (22:26 +0000)]
Make it possible to modify the connection from ChildProcessProxy subclasses.

Reviewed by Anders Carlsson.

* Shared/ChildProcessProxy.cpp:
(WebKit::ChildProcessProxy::ChildProcessProxy):
(WebKit::ChildProcessProxy::didFinishLaunching):
(WebKit::ChildProcessProxy::clearConnection):
(WebKit::ChildProcessProxy::connectionWillOpen):
(WebKit::ChildProcessProxy::connectionWillClose):
* Shared/ChildProcessProxy.h:
(ChildProcessProxy):
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::WebProcessProxy):
(WebKit::WebProcessProxy::connectionWillOpen):
(WebKit::WebProcessProxy::connectionWillClose):
* UIProcess/WebProcessProxy.h:
(WebProcessProxy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoClean up the storage of dirty bits on nodes in the scrolling state tree
simon.fraser@apple.com [Sat, 2 Feb 2013 21:04:52 +0000 (21:04 +0000)]
Clean up the storage of dirty bits on nodes in the scrolling state tree
https://bugs.webkit.org/show_bug.cgi?id=108744

Reviewed by Sam Weinig.

ScrollingStateNode and its subclasses used different techniques for
tracking which properties changed. ScrollingStateNode tracked its layers
via a bool member and some layer-specific methods, but also had virtual
methods to allow subclasses to track properties via a bit mask.

Clean this up by having the base class store the bit mask, and use
enums to specify bits for the various properties. All properties are thus
tracked in the same way. Bits are read and written through non-virtual member
functions on ScrollingStateNode. All bit checking is done via hasChangedProperty().

* page/scrolling/ScrollingStateFixedNode.cpp:
(WebCore::ScrollingStateFixedNode::ScrollingStateFixedNode): m_changedProperties is now on the base class.
(WebCore::ScrollingStateFixedNode::updateConstraints): Use setPropertyChanged()
* page/scrolling/ScrollingStateFixedNode.h: Remove overrides that are no longer needed.
* page/scrolling/ScrollingStateNode.cpp:
(WebCore::ScrollingStateNode::ScrollingStateNode): Initialize m_changedProperties,
m_scrollLayerDidChange no longer tracked separately.
(WebCore::ScrollingStateNode::cloneAndReset):
* page/scrolling/ScrollingStateNode.h:
(WebCore::ScrollingStateNode::hasChangedProperties):
(WebCore::ScrollingStateNode::hasChangedProperty): Tests the bit.
(WebCore::ScrollingStateNode::resetChangedProperties): Set all bits to 0.
(WebCore::ScrollingStateNode::setPropertyChanged): Set the bit.
(WebCore::ScrollingStateNode::changedProperties): Private to discourage incorrect usage
(changeProperties() & foo).
* page/scrolling/ScrollingStateScrollingNode.cpp:
(WebCore::ScrollingStateScrollingNode::ScrollingStateScrollingNode): Base class does the copying now.
(WebCore::ScrollingStateScrollingNode::setViewportRect): Use setPropertyChanged().
(WebCore::ScrollingStateScrollingNode::setContentsSize): Ditto.
(WebCore::ScrollingStateScrollingNode::setFrameScaleFactor): Etc.
(WebCore::ScrollingStateScrollingNode::setNonFastScrollableRegion):
(WebCore::ScrollingStateScrollingNode::setWheelEventHandlerCount):
(WebCore::ScrollingStateScrollingNode::setShouldUpdateScrollLayerPositionOnMainThread):
(WebCore::ScrollingStateScrollingNode::setHorizontalScrollElasticity):
(WebCore::ScrollingStateScrollingNode::setVerticalScrollElasticity):
(WebCore::ScrollingStateScrollingNode::setHasEnabledHorizontalScrollbar):
(WebCore::ScrollingStateScrollingNode::setHasEnabledVerticalScrollbar):
(WebCore::ScrollingStateScrollingNode::setHorizontalScrollbarMode):
(WebCore::ScrollingStateScrollingNode::setVerticalScrollbarMode):
(WebCore::ScrollingStateScrollingNode::setRequestedScrollPosition):
(WebCore::ScrollingStateScrollingNode::setScrollOrigin):
* page/scrolling/ScrollingStateScrollingNode.h:
(ScrollingStateScrollingNode):
* page/scrolling/ScrollingStateStickyNode.cpp:
(WebCore::ScrollingStateStickyNode::ScrollingStateStickyNode):
(WebCore::ScrollingStateStickyNode::updateConstraints):
* page/scrolling/ScrollingStateStickyNode.h:
* page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::commitNewTreeState):
* page/scrolling/ScrollingTreeScrollingNode.cpp:
(WebCore::ScrollingTreeScrollingNode::update):
* page/scrolling/mac/ScrollingStateNodeMac.mm:
(WebCore::ScrollingStateNode::setScrollLayer):
* page/scrolling/mac/ScrollingStateScrollingNodeMac.mm:
(WebCore::ScrollingStateScrollingNode::setCounterScrollingLayer):
* page/scrolling/mac/ScrollingTreeFixedNode.mm:
(WebCore::ScrollingTreeFixedNode::update):
* page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
(WebCore::ScrollingTreeScrollingNodeMac::update):
* page/scrolling/mac/ScrollingTreeStickyNode.mm:
(WebCore::ScrollingTreeStickyNode::update):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFixed and sticky nodes have no nodeID set
simon.fraser@apple.com [Sat, 2 Feb 2013 21:03:16 +0000 (21:03 +0000)]
Fixed and sticky nodes have no nodeID set
https://bugs.webkit.org/show_bug.cgi?id=108734

Reviewed by Sam Weinig.

Push ScrollingNodeIDs onto scrolling nodes at construction time, and thereafter
treat them as readonly. Previously, only the root scrolling node would have a node ID.

Node IDs aren't actually used by the scrolling tree yet, but are useful for debugging.

Not testable since we only dump the scrolling state tree, not the scrolling
node tree in tests.

* page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::ScrollingTree): No longer create the root node here;
we can only create it when we know what its ID will be.
(WebCore::ScrollingTree::updateTreeFromStateNode): Create the root node if
necessary. Pass node IDs into create methods.
* page/scrolling/ScrollingTreeNode.cpp:
(WebCore::ScrollingTreeNode::ScrollingTreeNode):
* page/scrolling/ScrollingTreeNode.h:
* page/scrolling/ScrollingTreeScrollingNode.cpp:
(WebCore::ScrollingTreeScrollingNode::ScrollingTreeScrollingNode):
* page/scrolling/ScrollingTreeScrollingNode.h:
* page/scrolling/mac/ScrollingTreeFixedNode.h:
* page/scrolling/mac/ScrollingTreeFixedNode.mm:
(WebCore::ScrollingTreeFixedNode::create):
(WebCore::ScrollingTreeFixedNode::ScrollingTreeFixedNode):
* page/scrolling/mac/ScrollingTreeScrollingNodeMac.h:
* page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
(WebCore::ScrollingTreeScrollingNode::create):
(WebCore::ScrollingTreeScrollingNodeMac::ScrollingTreeScrollingNodeMac):
* page/scrolling/mac/ScrollingTreeStickyNode.h:
* page/scrolling/mac/ScrollingTreeStickyNode.mm:
(WebCore::ScrollingTreeStickyNode::create):
(WebCore::ScrollingTreeStickyNode::ScrollingTreeStickyNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[CMake] Adopt the WinCE port to new CMake
paroga@webkit.org [Sat, 2 Feb 2013 20:59:25 +0000 (20:59 +0000)]
[CMake] Adopt the WinCE port to new CMake
https://bugs.webkit.org/show_bug.cgi?id=108754

Reviewed by Laszlo Gombos.

.:

Remove the entry point hack which isn't required in the new
CMake version with offical WindowsCE support.

* Source/cmake/OptionsWindows.cmake:

Source/JavaScriptCore:

* os-win32/WinMain.cpp: Removed.
* shell/PlatformWinCE.cmake: Removed.

Tools:

* WinCELauncher/CMakeLists.txt: Mark WinCELauncher
as WIN32 target to use the correct entry point.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMaking -webkit-image-set() the first value of background property causes crash.
tasak@google.com [Sat, 2 Feb 2013 20:55:48 +0000 (20:55 +0000)]
Making -webkit-image-set() the first value of background property causes crash.
https://bugs.webkit.org/show_bug.cgi?id=108409

Reviewed by Beth Dakin.

Source/WebCore:

CSSParser::addFillValue should use lval->isBaseValueList() instead
of lval->isValueList(). If lval is -webkit-image-set, rval is appended
to -webkit-image-set.

Test: fast/css/image-set-value-crash-in-fillImageSet.html

* css/CSSParser.cpp:
(WebCore::CSSParser::addFillValue):
If lval is not a value list, lval is initialized by using
CSSValueList::createCommaSeparated(). So we have to check whether
lval is created by CSSValueList::createCommaSeparated() or not.

LayoutTests:

* fast/css/image-set-value-crash-in-fillImageSet-expected.txt: Added.
* fast/css/image-set-value-crash-in-fillImageSet.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<http://webkit.org/b/108745> WTF shouldn't use a script build phase to detect the...
mrowe@apple.com [Sat, 2 Feb 2013 20:25:53 +0000 (20:25 +0000)]
<webkit.org/b/108745> WTF shouldn't use a script build phase to detect the presence of headers when the compiler can do it for us

Reviewed by Sam Weinig.

Source/JavaScriptCore:

* DerivedSources.make: Remove an obsolete Makefile rule. This should have been removed when the use
of the generated file moved to WTF.

Source/WTF:

* WTF.xcodeproj/project.pbxproj: Remove the script phase that used to generate a header file
containing information about whether certain header files exist on the system.
* wtf/FastMalloc.cpp: Use Clang's __has_include to detect whether the header exists before including it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpstream iOS FeatureDefines
ddkilzer@apple.com [Sat, 2 Feb 2013 19:02:36 +0000 (19:02 +0000)]
Upstream iOS FeatureDefines
<http://webkit.org/b/108753>

Reviewed by Anders Carlsson.

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:
- ENABLE_DEVICE_ORIENTATION: Add iOS configurations.
- ENABLE_PLUGIN_PROXY_FOR_VIDEO: Ditto.
- FEATURE_DEFINES: Add ENABLE_PLUGIN_PROXY_FOR_VIDEO.  Add
  PLATFORM_NAME variant to reduce future merge conflicts.

Source/WebCore:

* Configurations/FeatureDefines.xcconfig:
- ENABLE_DEVICE_ORIENTATION: Add iOS configurations.
- ENABLE_PLUGIN_PROXY_FOR_VIDEO: Ditto.
- FEATURE_DEFINES: Add ENABLE_PLUGIN_PROXY_FOR_VIDEO.  Add
  PLATFORM_NAME variant to reduce future merge conflicts.

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:
- ENABLE_DEVICE_ORIENTATION: Add iOS configurations.
- ENABLE_PLUGIN_PROXY_FOR_VIDEO: Ditto.
- FEATURE_DEFINES: Add ENABLE_PLUGIN_PROXY_FOR_VIDEO.  Add
  PLATFORM_NAME variant to reduce future merge conflicts.

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:
- ENABLE_DEVICE_ORIENTATION: Add iOS configurations.
- ENABLE_PLUGIN_PROXY_FOR_VIDEO: Ditto.
- FEATURE_DEFINES: Add ENABLE_PLUGIN_PROXY_FOR_VIDEO.  Add
  PLATFORM_NAME variant to reduce future merge conflicts.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago One is not allowed to use commit-queue to make oneself a committer.
ap@apple.com [Sat, 2 Feb 2013 17:31:47 +0000 (17:31 +0000)]
    One is not allowed to use commit-queue to make oneself a committer.

        * Scripts/webkitpy/common/config/committers.py: Rolled out r141693.
        Also, changed e-mail order for Yongjun Zhang, so that Bugzilla autocomplete works.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GStreamer] Media tests fix after r141695.
philn@webkit.org [Sat, 2 Feb 2013 16:41:07 +0000 (16:41 +0000)]
[GStreamer] Media tests fix after r141695.

Rubber-stamped by Martin Robinson.

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::setPlaybinURL): Remove
both fragment and query string for file:// uris before loading.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix for WinCE after r141637.
paroga@webkit.org [Sat, 2 Feb 2013 16:12:15 +0000 (16:12 +0000)]
Build fix for WinCE after r141637.

* platform/graphics/wince/ImageBufferWinCE.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141696 268f45cc-cd09-0410-ab3c-d52691b4dbfc