staikos [Thu, 14 Jun 2007 02:24:08 +0000 (02:24 +0000)]
Compile without trying to link ourself.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23516
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lars [Thu, 14 Jun 2007 02:23:29 +0000 (02:23 +0000)]
Disable FastMalloc for the Qt build and make sure we
don't reimplement the global new/delete operators
when using the system malloc.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23515
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Thu, 14 Jun 2007 01:11:30 +0000 (01:11 +0000)]
Reviewed by Kevin Decker.
- fix <rdar://problem/
5264923> Safari frequently "stalls" beneath
+[NSFont fontWithName:size:] while loading a web page (searching on disk for the font)
* platform/mac/WebFontCache.mm:
(+[WebFontCache internalFontWithFamily:traits:size:]): Renamed from fontWithFamily.
Took out the auto-activation code.
(+[WebFontCache fontWithFamily:traits:size:]): Added. Calls internalFontWithFamily,
then calls NSFont to trigger activation if that returned nil, then calls
internalFontWithFamily again.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23514
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Thu, 14 Jun 2007 00:10:38 +0000 (00:10 +0000)]
JavaScriptCore:
Reviewed by Geoff.
Make sure that bindings instances get correct root objects.
* JavaScriptCore.exp:
* bindings/NP_jsobject.cpp:
(listFromVariantArgs):
(_NPN_InvokeDefault):
(_NPN_Invoke):
(_NPN_SetProperty):
* bindings/c/c_instance.cpp:
(KJS::Bindings::CInstance::invokeMethod):
(KJS::Bindings::CInstance::invokeDefaultMethod):
* bindings/c/c_runtime.cpp:
(KJS::Bindings::CField::valueFromInstance):
* bindings/c/c_utility.cpp:
(KJS::Bindings::convertNPVariantToValue):
* bindings/c/c_utility.h:
* bindings/objc/objc_instance.mm:
(ObjcInstance::invokeMethod):
(ObjcInstance::invokeDefaultMethod):
(ObjcInstance::getValueOfUndefinedField):
* bindings/objc/objc_runtime.mm:
(ObjcField::valueFromInstance):
(ObjcArray::valueAt):
* bindings/objc/objc_utility.h:
* bindings/objc/objc_utility.mm:
(KJS::Bindings::convertObjcValueToValue):
* bindings/runtime.h:
WebCore:
Reviewed by Geoff.
Pass the root object to methods that end up creating new ObjcInstance objects.
* bindings/objc/WebScriptObject.mm:
(listFromNSArray):
(-[WebScriptObject callWebScriptMethod:withArguments:]):
(-[WebScriptObject evaluateWebScript:]):
(-[WebScriptObject setValue:forKey:]):
(-[WebScriptObject valueForKey:]):
(-[WebScriptObject removeWebScriptKey:]):
(-[WebScriptObject setWebScriptValueAtIndex:value:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23512
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Wed, 13 Jun 2007 23:31:36 +0000 (23:31 +0000)]
Reviewed by Darin.
<rdar://problem/
5267992>
Make sure an alert doesn't allow loading to continue inside a script.
Make sure to defer all loads where it's possible for a second main loop to be running.
* page/Chrome.cpp:
(WebCore::Chrome::runModal):
(WebCore::Chrome::runBeforeUnloadConfirmPanel):
(WebCore::Chrome::runJavaScriptAlert):
(WebCore::Chrome::runJavaScriptConfirm):
(WebCore::Chrome::runJavaScriptPrompt):
(WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
(WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::ResourceHandle::setDefersLoading):
Implement this.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23510
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan [Wed, 13 Jun 2007 22:26:03 +0000 (22:26 +0000)]
Reviewed by Adele Peterson
- fixed <rdar://problem/
5267607> Clicking the "Save to Downloads" button in
PDF overlay too soon results in corrupt file
* WebView/WebPDFView.mm:
(-[WebPDFView PDFViewSavePDFToDownloadFolder:]):
Just beep if the document isn't available yet, since trying to save it as a file
really isn't a good idea.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23508
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Wed, 13 Jun 2007 20:39:42 +0000 (20:39 +0000)]
2007-06-13 Alp Toker <alp.toker@collabora.co.uk>
Reviewed by Rob.
http://bugs.webkit.org/show_bug.cgi?id=14060
Cairo SVG support
* WebCore.pro: Add new files to the build.
* platform/graphics/svg/SVGPaintServerPattern.h:
* platform/graphics/svg/SVGPaintServerSolid.h:
* platform/graphics/svg/cairo: Added.
* platform/graphics/svg/cairo/RenderPathCairo.cpp: Added.
(WebCore::RenderPath::strokeContains):
(WebCore::RenderPath::strokeBBox):
* platform/graphics/svg/cairo/SVGPaintServerCairo.cpp: Added.
(WebCore::SVGPaintServer::draw):
(WebCore::SVGPaintServer::teardown):
(WebCore::SVGPaintServer::renderPath):
* platform/graphics/svg/cairo/SVGPaintServerGradientCairo.cpp: Added.
(WebCore::SVGPaintServerGradient::setup):
* platform/graphics/svg/cairo/SVGPaintServerPatternCairo.cpp: Added.
(WebCore::SVGPaintServerPattern::setup):
* platform/graphics/svg/cairo/SVGPaintServerSolidCairo.cpp: Added.
(WebCore::SVGPaintServerSolid::setup):
* platform/graphics/svg/cairo/SVGResourceClipperCairo.cpp: Added.
(WebCore::SVGResourceClipper::applyClip):
* platform/graphics/svg/cairo/SVGResourceMaskerCairo.cpp: Added.
(WebCore::SVGResourceMasker::applyMask):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23507
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann [Wed, 13 Jun 2007 15:01:28 +0000 (15:01 +0000)]
Fix the build: WebKitQt is now called QtWebKit
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23504
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann [Wed, 13 Jun 2007 14:38:36 +0000 (14:38 +0000)]
Added a make install target that installs the Qt port and renamed
WebKitQt to QtWebKit
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23503
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann [Wed, 13 Jun 2007 13:05:27 +0000 (13:05 +0000)]
Added httpHeaderField setter/getter to QWebNetworkRequest for convenience.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23500
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann [Wed, 13 Jun 2007 13:05:16 +0000 (13:05 +0000)]
Changed QWebObjectPluginConnector::requestUrl to take a QWebNetworkRequest as argument.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23499
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann [Wed, 13 Jun 2007 13:05:01 +0000 (13:05 +0000)]
Added a QWebNetworkRequest convenience constructor.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23498
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann [Wed, 13 Jun 2007 13:04:50 +0000 (13:04 +0000)]
Changed the QWebPage::open(const QUrl &url, const QHttpRequestHeader &httpHeader, const QByteArray &postData)
overload to take a QWebNetworkRequest instead.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23497
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann [Wed, 13 Jun 2007 13:04:40 +0000 (13:04 +0000)]
In QWebPage::open(const QUrl &, const QHttpRequestHeader &, ...) don't make the population
of the WebCore::ResourceRequest depend on the validity of the QHttpRequestHeader but just
pick the individual fields if we can use them.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23496
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann [Wed, 13 Jun 2007 13:04:29 +0000 (13:04 +0000)]
Minor QWebNetworkRequet API fixlet
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23495
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann [Wed, 13 Jun 2007 13:04:19 +0000 (13:04 +0000)]
Use QWebNetworkRequest for QWebPage::navigationRequested.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23494
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann [Wed, 13 Jun 2007 13:04:08 +0000 (13:04 +0000)]
Some docs for QWebNetworkRequest
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23493
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann [Wed, 13 Jun 2007 13:03:57 +0000 (13:03 +0000)]
Moved QWebNetworkJob::Method enum into QWebNetworkRequest.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23492
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann [Wed, 13 Jun 2007 13:03:45 +0000 (13:03 +0000)]
Rename QWebNetworkJob::request() into QWebNetworkJob::httpHeader() and added
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23491
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann [Wed, 13 Jun 2007 13:03:34 +0000 (13:03 +0000)]
Introduce QWebNetworkRequest in the public API.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23490
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann [Wed, 13 Jun 2007 13:03:23 +0000 (13:03 +0000)]
Changed QWebNetworkJobPrivate to aggregate a QWebNetworkRequest instead of inheriting from it.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23489
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann [Wed, 13 Jun 2007 13:03:11 +0000 (13:03 +0000)]
Rename QWebNetworkRequest::request into QWebNetworkRequest::httpHeader.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23488
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Wed, 13 Jun 2007 07:25:28 +0000 (07:25 +0000)]
Fix one more BITMAPINFO/BITMAPINFOHEADER typo.
Rubberstamped by Oliver.
* platform/win/DragImageWin.cpp:
(WebCore::allocImage):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23487
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver [Wed, 13 Jun 2007 06:56:26 +0000 (06:56 +0000)]
WebCore:
Reviewed by Darin.
Use correct size for BITMAPINFOHEADER -- whoops.
* platform/win/CursorWin.cpp:
(WebCore::Cursor::Cursor):
* platform/win/PasteboardWin.cpp:
(WebCore::Pasteboard::writeImage):
WebKit:
Reviewed by Darin.
Use correct size for BITMAPINFOHEADER -- whoops.
* win/WebIconDatabase.cpp:
(createDIB):
(WebIconDatabase::getOrCreateDefaultIconBitmap):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23486
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Wed, 13 Jun 2007 04:57:29 +0000 (04:57 +0000)]
Another build fix.
* bindings/qt/qt_instance.cpp:
(KJS::Bindings::QtInstance::invokeMethod):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23483
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Wed, 13 Jun 2007 04:52:00 +0000 (04:52 +0000)]
Reviewed by Geoff.
Move the notion of field type to the JNI runtime since that's the only
one that was actually using it.
* bindings/c/c_runtime.h:
(KJS::Bindings::CField::CField):
* bindings/jni/jni_runtime.h:
* bindings/objc/objc_runtime.h:
* bindings/objc/objc_runtime.mm:
* bindings/qt/qt_runtime.h:
* bindings/runtime.h:
* bindings/runtime_method.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23482
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Wed, 13 Jun 2007 04:43:19 +0000 (04:43 +0000)]
Build fix.
* bindings/qt/qt_class.cpp:
(KJS::Bindings::QtClass::methodsNamed):
* bindings/qt/qt_instance.cpp:
(KJS::Bindings::QtInstance::invokeMethod):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23481
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Wed, 13 Jun 2007 04:42:32 +0000 (04:42 +0000)]
Fix from Lars to remove duplicate symbols.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23480
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Wed, 13 Jun 2007 04:25:28 +0000 (04:25 +0000)]
Reviewed by Oliver.
Get rid of the MethodList class and use a good ol' Vector instead.
* bindings/c/c_class.cpp:
(KJS::Bindings::CClass::methodsNamed):
* bindings/c/c_instance.cpp:
(KJS::Bindings::CInstance::invokeMethod):
* bindings/jni/jni_class.cpp:
(JavaClass::JavaClass):
(JavaClass::~JavaClass):
* bindings/jni/jni_instance.cpp:
(JavaInstance::invokeMethod):
* bindings/objc/objc_class.mm:
(KJS::Bindings::ObjcClass::methodsNamed):
* bindings/objc/objc_instance.mm:
(ObjcInstance::invokeMethod):
* bindings/objc/objc_runtime.mm:
(ObjcFallbackObjectImp::callAsFunction):
* bindings/runtime.cpp:
* bindings/runtime.h:
* bindings/runtime_method.cpp:
(RuntimeMethod::lengthGetter):
(RuntimeMethod::callAsFunction):
* bindings/runtime_object.cpp:
(RuntimeObjectImp::getOwnPropertySlot):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23479
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Wed, 13 Jun 2007 04:06:59 +0000 (04:06 +0000)]
Reviewed by Geoff.
Make RuntimeMethod's method list a pointer so that the object size doesn't
grow beyond 32 bytes when we later will replace MethodList with a Vector.
* bindings/runtime_method.cpp:
(RuntimeMethod::RuntimeMethod):
(RuntimeMethod::lengthGetter):
(RuntimeMethod::callAsFunction):
* bindings/runtime_method.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23478
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Wed, 13 Jun 2007 03:57:56 +0000 (03:57 +0000)]
Reviewed by Geoff.
Get rid of the Parameter class.
* bindings/jni/jni_instance.cpp:
(JavaInstance::invokeMethod):
* bindings/jni/jni_runtime.cpp:
(JavaMethod::signature):
* bindings/jni/jni_runtime.h:
(KJS::Bindings::JavaParameter::JavaParameter):
(KJS::Bindings::JavaParameter::~JavaParameter):
(KJS::Bindings::JavaParameter::type):
(KJS::Bindings::JavaMethod::parameterAt):
(KJS::Bindings::JavaMethod::numParameters):
* bindings/runtime.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23477
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Wed, 13 Jun 2007 03:54:56 +0000 (03:54 +0000)]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23476
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Wed, 13 Jun 2007 03:54:25 +0000 (03:54 +0000)]
Build fix.
* bindings/qt/qt_class.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23475
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Wed, 13 Jun 2007 03:49:48 +0000 (03:49 +0000)]
2007-06-12 Mark Rowe <mrowe@apple.com>
Build fix.
* bindings/objc/objc_runtime.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23474
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Wed, 13 Jun 2007 03:43:59 +0000 (03:43 +0000)]
Reviewed by Geoff.
Get rid of Constructor and its only subclass JavaConstructor.
* bindings/c/c_class.h:
* bindings/jni/jni_class.cpp:
(JavaClass::JavaClass):
(JavaClass::~JavaClass):
* bindings/jni/jni_class.h:
* bindings/jni/jni_runtime.cpp:
* bindings/jni/jni_runtime.h:
* bindings/objc/objc_class.h:
* bindings/runtime.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23473
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Wed, 13 Jun 2007 03:24:48 +0000 (03:24 +0000)]
Reviewed by Geoff.
Use RetainPtr throughout the bindings code.
* bindings/objc/objc_class.h:
* bindings/objc/objc_class.mm:
(KJS::Bindings::ObjcClass::ObjcClass):
(KJS::Bindings::ObjcClass::methodsNamed):
(KJS::Bindings::ObjcClass::fieldNamed):
* bindings/objc/objc_instance.h:
(KJS::Bindings::ObjcInstance::getObject):
* bindings/objc/objc_instance.mm:
(ObjcInstance::ObjcInstance):
(ObjcInstance::~ObjcInstance):
(ObjcInstance::implementsCall):
(ObjcInstance::invokeMethod):
(ObjcInstance::invokeDefaultMethod):
(ObjcInstance::defaultValue):
* bindings/objc/objc_runtime.h:
(KJS::Bindings::ObjcMethod::setJavaScriptName):
(KJS::Bindings::ObjcMethod::javaScriptName):
(KJS::Bindings::ObjcArray::getObjcArray):
* bindings/objc/objc_runtime.mm:
(ObjcField::name):
(ObjcArray::ObjcArray):
(ObjcArray::setValueAt):
(ObjcArray::valueAt):
(ObjcArray::getLength):
* wtf/RetainPtr.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23472
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Wed, 13 Jun 2007 02:40:00 +0000 (02:40 +0000)]
Reviewed by Oliver.
Patch for http://bugs.webkit.org/show_bug.cgi?id=14109
Cleanup JSEvent and JSClipboard in preperation for autogeneration
* bindings/js/kjs_events.cpp:
(KJS::DOMEvent::DOMEvent):
(KJS::DOMEvent::getValueProperty):
(KJS::DOMEvent::put):
(KJS::DOMEvent::putValueProperty):
(KJS::DOMEventPrototypeFunction::callAsFunction):
(KJS::toJS):
(KJS::toEvent):
(KJS::):
(KJS::JSClipboard::JSClipboard):
(KJS::JSClipboard::~JSClipboard):
(KJS::JSClipboard::getOwnPropertySlot):
(KJS::JSClipboard::getValueProperty):
(KJS::JSClipboard::put):
(KJS::JSClipboard::putValueProperty):
(KJS::JSClipboardPrototypeFunction::callAsFunction):
(KJS::toClipboard):
* bindings/js/kjs_events.h:
(KJS::DOMEvent::):
(KJS::DOMEvent::impl):
(KJS::JSClipboard::impl):
* dom/ClipboardEvent.h:
* dom/Event.h:
(WebCore::Event::srcElement):
(WebCore::Event::returnValue):
(WebCore::Event::clipboardData):
(WebCore::Event::dataTransfer):
(WebCore::Event::clipboard):
* dom/MouseEvent.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23471
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Wed, 13 Jun 2007 01:48:11 +0000 (01:48 +0000)]
Reviewed by Maciej.
Have JSCell inherit from Noncopyable.
* bindings/objc/objc_runtime.h:
* bindings/runtime_object.h:
* kjs/value.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23470
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lars [Wed, 13 Jun 2007 01:22:24 +0000 (01:22 +0000)]
Fix compilation, and remove dependency on Qt
private header.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23469
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lars [Wed, 13 Jun 2007 00:39:08 +0000 (00:39 +0000)]
Parts of the patch done by Zack.
Fix up some parts in the implementation of QWebNetworkInterface
so it can be used by plugins.
Change the plugin API so we can actually get all the information
required by the JS bridge from them as well.
Implement the parts required for the JS bridge
to know about the plugins.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23468
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Wed, 13 Jun 2007 00:22:19 +0000 (00:22 +0000)]
Reviewed by Darin and Maciej.
More cleanup. Use our Noncopyable WTF class, add a root object member
to the Array class.
* bindings/c/c_class.h:
* bindings/jni/jni_class.h:
* bindings/jni/jni_instance.h:
* bindings/jni/jni_runtime.cpp:
(JavaArray::JavaArray):
* bindings/jni/jni_runtime.h:
* bindings/objc/objc_class.h:
* bindings/objc/objc_runtime.h:
* bindings/objc/objc_runtime.mm:
(ObjcArray::ObjcArray):
* bindings/objc/objc_utility.mm:
(KJS::Bindings::convertObjcValueToValue):
* bindings/runtime.cpp:
(KJS::Bindings::Array::Array):
(KJS::Bindings::Array::~Array):
* bindings/runtime.h:
* bindings/runtime_object.h:
* bindings/runtime_root.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23467
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Tue, 12 Jun 2007 23:58:50 +0000 (23:58 +0000)]
WebKitTools:
Land CygwinDownloader.
Rubberstamped by Hyatt.
* CygwinDownloader/cygwin-downloader.py: Added.
* CygwinDownloader/cygwin-downloader.zip: Added.
* CygwinDownloader/make-zip.sh: Added.
* CygwinDownloader/setup.py: Added.
WebKitSite:
Update the location of cygwin-downloader.zip.
Rubberstamped by Hyatt.
* building/tools.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23466
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Tue, 12 Jun 2007 22:40:23 +0000 (22:40 +0000)]
Fix build bustage.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23465
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Tue, 12 Jun 2007 21:53:37 +0000 (21:53 +0000)]
Add Windows checkout/build instructions to website.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23464
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Tue, 12 Jun 2007 21:51:33 +0000 (21:51 +0000)]
Update scripts and project paths to make the Windows build work.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23463
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Tue, 12 Jun 2007 21:50:34 +0000 (21:50 +0000)]
Merge WindowsMerge to trunk
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23462
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann [Mon, 11 Jun 2007 13:49:56 +0000 (13:49 +0000)]
Added a QWebPage::open overload to allow specifying the http header and post data.
(it's an overload instead of a merged openUrl to avoid including qhttp.h in qwebpage.h,
which would imply that one has to have QT += network in the .pro file for using WebKitQt)
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22096
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann [Mon, 11 Jun 2007 13:49:46 +0000 (13:49 +0000)]
Added the possibility to intercept url requests through QWebPage::navigationRequested.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22095
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann [Mon, 11 Jun 2007 13:49:34 +0000 (13:49 +0000)]
Added a QWebNetworkRequest::init overload that takes a WebCore::ResourceRequest,
to be called from FrameLoaderClientQt in the near future.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22094
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann [Mon, 11 Jun 2007 13:49:24 +0000 (13:49 +0000)]
Moved the postData setup into QWebNetworkRequest::init.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22093
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann [Mon, 11 Jun 2007 13:49:13 +0000 (13:49 +0000)]
Moved HTTP header field propagation to QWebNetworkRequest::init.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22092
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann [Mon, 11 Jun 2007 13:48:58 +0000 (13:48 +0000)]
Started moving the code to separate a WebCore::ResourceRequest into a QUrl, postData
and QHttpRequestHeader into a separate little QWebNetworkRequest struct.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22091
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zack [Mon, 11 Jun 2007 07:30:43 +0000 (07:30 +0000)]
Forgot to export the plugin exporter. Fixing it.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22090
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Mon, 11 Jun 2007 01:02:52 +0000 (01:02 +0000)]
Reviewed by Beth Dakin.
Made confusing work-around to ObjC bindings bug <rdar://problem/
5262101>
less confusing.
Fixed test to actually call queueReload.
* fast/frames/resources/iframe-focus.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22089
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Sun, 10 Jun 2007 22:58:33 +0000 (22:58 +0000)]
2007-06-10 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Maciej.
Disable whole-view editing for the Gdk port in order to improve the browsing experience.
* platform/gdk/EditorClientGdk.cpp:
(WebCore::EditorClientGdk::isEditable): Return false to disable whole-view editing
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22088
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin [Sun, 10 Jun 2007 22:18:31 +0000 (22:18 +0000)]
Reviewed by Adele.
Fix for http://bugs.webkit.org/show_bug.cgi?id=13933 REGRESSION:
fast/history/clicked-link-is-visited is failing
* fast/frames/resources/iframe-focus.html: Cause the page to reload
with layoutTestController.queueReload instead of using JavaScript
to reload. Using JS seems to get DRT's history all messed up (off
by one?!).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22087
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Sun, 10 Jun 2007 19:41:08 +0000 (19:41 +0000)]
Reviewed by Beth Dakin.
Cleaned up formatting on the check out page.
* building/checkout.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22085
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Sun, 10 Jun 2007 07:14:52 +0000 (07:14 +0000)]
Fix for bug 14037, make sure respondsToSelector does the write thing
when invoked on a WebKit plugin's container view.
Reviewed by Mark Rowe
* Plugins/WebKitPluginContainerView.mm:
(-[WebKitPluginContainerView respondsToSelector:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22084
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Sat, 9 Jun 2007 06:00:26 +0000 (06:00 +0000)]
LayoutTests:
Reviewed by Oliver.
Update test for http://bugs.webkit.org/show_bug.cgi?id=14044
Autogenerate the JS bindings for HTMLCollection.
* tables/mozilla/bugs/bug53690-1-expected.txt: Now throws Undefined Error instead of Null Error
WebCore:
Reviewed by Oliver.
Patch for http://bugs.webkit.org/show_bug.cgi?id=14044
Autogenerate the JS bindings for HTMLCollection
- also moves JSHTMLAllCollection into it's own file.
* DerivedSources.make:
* WebCore.pro:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSHTMLAllCollection.h: Added.
(WebCore::JSHTMLAllCollection::JSHTMLAllCollection):
(WebCore::JSHTMLAllCollection::toBoolean):
(WebCore::JSHTMLAllCollection::masqueradeAsUndefined):
* bindings/js/JSHTMLCollectionCustom.cpp: Added.
(WebCore::getNamedItems):
(WebCore::JSHTMLCollection::callAsFunction):
(WebCore::JSHTMLCollection::implementsCall):
(WebCore::JSHTMLCollection::canGetItemsForName):
(WebCore::JSHTMLCollection::nameGetter):
(WebCore::JSHTMLCollection::item):
(WebCore::JSHTMLCollection::namedItem):
(WebCore::toJS):
* bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::nameGetter):
(WebCore::JSHTMLDocument::all):
* bindings/js/JSXMLHttpRequest.cpp:
* bindings/js/kjs_html.cpp:
(WebCore::ImageConstructorImp::ImageConstructorImp):
(WebCore::ImageConstructorImp::construct):
* bindings/js/kjs_html.h:
(WebCore::ImageConstructorImp::implementsConstruct):
* bindings/js/kjs_window.cpp:
(KJS::Window::namedItemGetter):
* bindings/objc/DOMUtility.mm:
(KJS::createDOMWrapper):
* bindings/scripts/CodeGeneratorJS.pm:
* html/HTMLCollection.cpp:
(WebCore::HTMLCollection::tags):
* html/HTMLCollection.h:
(WebCore::HTMLCollection::collectionType):
* html/HTMLCollection.idl:
* html/HTMLOptionsCollection.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22080
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin [Fri, 8 Jun 2007 20:03:37 +0000 (20:03 +0000)]
Reviewed by Brady.
Fix for http://trac.webkit.org/projects/webkit/changeset/21738
This test started failing after Adele's r21738. After investigating
this, it turns out that it just needs updated results. This test
happened to tickle the very bug that Adele fixed.
* http/tests/navigation/relativeanchor-goback-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22076
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Fri, 8 Jun 2007 18:10:26 +0000 (18:10 +0000)]
LayoutTests:
Reviewed by John.
<rdar://problem/
5232159> REGRESSION: Cannot select text in RSS view
* editing/selection/
5232159-expected.checksum: Added.
* editing/selection/
5232159-expected.png: Added.
* editing/selection/
5232159-expected.txt: Added.
* editing/selection/
5232159.html: Added.
WebCore:
Reviewed by John.
<rdar://problem/
5232159> REGRESSION: Cannot select text in RSS view
The selection is updated both on mouse movement and
when the autoscroll timer fires. The autoscroll
code wasn't converting mouse coordinates to layer
coordinates correctly, and was then using those
coordinates to create a bad selection.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::autoscroll): Use convertToLayerCoordinates.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22075
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan [Fri, 8 Jun 2007 16:38:11 +0000 (16:38 +0000)]
* WebView/WebViewPrivate.h:
Added a FIXME
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22074
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Fri, 8 Jun 2007 15:17:27 +0000 (15:17 +0000)]
Reviewed by Geoff.
Store the root object in a hash set, keyed by the plugin view. This is in preparation for
letting plugins invalidate the root object upon destruction
* page/Frame.cpp:
(WebCore::Frame::createRootObject):
(WebCore::Frame::cleanupScriptObjects):
* page/FramePrivate.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22071
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lars [Fri, 8 Jun 2007 13:01:38 +0000 (13:01 +0000)]
Forgot to checkin this part in my last submit.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22070
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lars [Fri, 8 Jun 2007 12:44:53 +0000 (12:44 +0000)]
Reviewed by Zack.
Add a QWebObjectPluginConnector class. The class will
facility communication between the plugin and WebKit.
Currently it's used to make the plugin network capable.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22069
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zack [Fri, 8 Jun 2007 10:08:11 +0000 (10:08 +0000)]
Fix the Qt build
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22067
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Fri, 8 Jun 2007 07:17:49 +0000 (07:17 +0000)]
WebCore:
Reviewed by Tristan.
<rdar://problem/
5250997> A crash occurs when selecting Undo Typing for a page that has been closed in tab
* WebCore.exp: Added clearUndoRedoOperations.
* page/Page.cpp:
(WebCore::Page::clearUndoRedoOperations): Added.
* page/Page.h:
WebKit:
Reviewed by Tristan.
<rdar://problem/
5250997> A crash occurs when selecting Undo Typing for a page that has been closed in tab
* WebView/WebView.mm:
(-[WebView _clearUndoRedoOperations]): Added.
* WebView/WebViewPrivate.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22065
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Fri, 8 Jun 2007 06:50:59 +0000 (06:50 +0000)]
2007-06-08 Mark Rowe <mrowe@apple.com>
Rubber-stamped by Hyatt.
Switch to using Internet Explorer's conditional comments to target IE-specific styles rather
than doing server-side user agent checks. This resolves an issue some people were seeing where
caching would lead to a page generated for an Internet Explorer user being served to a Safari
user. The visible symptom of this was many of the graphics were missing.
* blog/wp-content/themes/webkit/header.php:
* header.inc:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22064
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver [Fri, 8 Jun 2007 06:38:16 +0000 (06:38 +0000)]
Reviewed by Sam "The Intern" Weinig.
Don't be overzealous with the input checks, firstRectForCharacterRange
can be determined even when there is not an active editable region.
This unbreaks editing/input/range-for-empty-document which was broken
by aforementioned overzealousness.
* WebView/WebHTMLView.mm:
(-[WebHTMLView firstRectForCharacterRange:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22063
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Fri, 8 Jun 2007 05:25:17 +0000 (05:25 +0000)]
Fix crash. Null check layer. Bug 13984.
Reviewed by andersca
* WebCore.xcodeproj/project.pbxproj:
* page/FrameView.cpp:
(WebCore::FrameView::windowClipRectForLayer):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22062
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver [Fri, 8 Jun 2007 03:07:04 +0000 (03:07 +0000)]
WebCore:
Reviewed by Justin.
Remove incorrect assertions.
These assertions were made on the assumption that
TSM would always call with a range that was contained
by an editable region.
TSM may call -[WebHTMLView characterIndexForPoint:] on a mouse
event that is otherwise unrelated to editing, which may
be outside the current editing region, triggering these
assertions.
* page/mac/WebCoreFrameBridge.mm:
(-[WebCoreFrameBridge convertToNSRange:]):
WebKit:
Reviewed by Justin.
Add checks to make sure we don't try to create, use
or return invalid ranges to TSM when it calls us despite
not currently being in an editable region.
* WebView/WebHTMLView.mm:
(isTextInput):
(-[WebHTMLView textStorage]):
(-[WebHTMLView firstRectForCharacterRange:]):
(-[WebHTMLView selectedRange]):
(-[WebHTMLView attributedSubstringFromRange:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22058
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Fri, 8 Jun 2007 00:02:06 +0000 (00:02 +0000)]
LayoutTests:
Reviewed by John.
<rdar://problem/
5237074> REGRESSION: editing/unsupported-content/table-delete-003 is failing (13931)
Corrected the description and added a FIXME:
* editing/unsupported-content/table-delete-003-expected.checksum:
* editing/unsupported-content/table-delete-003-expected.png:
* editing/unsupported-content/table-delete-003-expected.txt:
* editing/unsupported-content/table-delete-003.html:
WebCore:
Reviewed by John.
<rdar://problem/
5237074> REGRESSION: editing/unsupported-content/table-delete-003 is failing (13931)
* editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::initializeStartEnd):
We wouldn't expand the selection to include a special element
at the start of the selection unless the end of the selection
was at the end of a special element. Avoid a special
element at the start as long as it's fully selected. Ditto for
the end.
* editing/htmlediting.cpp:
(WebCore::positionBeforeContainingSpecialElement):
(WebCore::positionAfterContainingSpecialElement):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22057
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Thu, 7 Jun 2007 23:16:37 +0000 (23:16 +0000)]
Reviewed by Geoff.
Get rid of Instance::setRootObject and pass the root object to the instance constructor instead.
* bindings/c/c_instance.cpp:
(KJS::Bindings::CInstance::CInstance):
* bindings/c/c_instance.h:
* bindings/jni/jni_instance.cpp:
(JavaInstance::JavaInstance):
* bindings/jni/jni_instance.h:
* bindings/jni/jni_jsobject.cpp:
(JavaJSObject::convertJObjectToValue):
* bindings/objc/objc_instance.h:
* bindings/objc/objc_instance.mm:
(ObjcInstance::ObjcInstance):
* bindings/runtime.cpp:
(KJS::Bindings::Instance::Instance):
(KJS::Bindings::Instance::createBindingForLanguageInstance):
* bindings/runtime.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22056
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Thu, 7 Jun 2007 22:31:46 +0000 (22:31 +0000)]
Reviewed by Adam.
Don't use a JavaInstance to store the field when all we want to do is to keep the field
from being garbage collected. Instead, use a JObjectWrapper.
* bindings/jni/jni_instance.h:
* bindings/jni/jni_runtime.cpp:
(JavaField::JavaField):
(JavaField::dispatchValueFromInstance):
(JavaField::dispatchSetValueToInstance):
* bindings/jni/jni_runtime.h:
(KJS::Bindings::JavaField::JavaField):
(KJS::Bindings::JavaField::operator=):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22055
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Thu, 7 Jun 2007 20:58:15 +0000 (20:58 +0000)]
LayoutTests:
Reviewed by Anders.
Update test for http://bugs.webkit.org/show_bug.cgi?id=14028
Finish autogenerating the JS bindings for Node
* fast/dom/prototype-chain-expected.txt: DOMNodePrototype is no longer in the prototype chain.
WebCore:
Reviewed by Anders.
Patch for http://bugs.webkit.org/show_bug.cgi?id=14028
Finish autogenerating the JS bindings for Node
* DerivedSources.make:
* WebCore.pro:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSHTMLElementWrapperFactory.cpp:
(WebCore::createJSHTMLWrapper):
* bindings/js/JSHTMLElementWrapperFactory.h:
* bindings/js/JSHTMLOptionElementConstructor.cpp:
* bindings/js/JSNamedNodeMapCustom.cpp:
* bindings/js/JSNodeCustom.cpp:
(WebCore::JSNode::insertBefore):
(WebCore::JSNode::replaceChild):
(WebCore::JSNode::removeChild):
(WebCore::JSNode::appendChild):
(WebCore::JSNode::mark):
(WebCore::toJS):
* bindings/js/JSSVGElementWrapperFactory.cpp:
(WebCore::createJSSVGWrapper):
* bindings/js/JSSVGElementWrapperFactory.h:
* bindings/js/JSXSLTProcessor.cpp:
(KJS::XSLTProcessorPrototypeFunction::callAsFunction):
* bindings/js/kjs_binding.cpp:
(KJS::ScriptInterpreter::getDOMNodeForDocument):
(KJS::ScriptInterpreter::putDOMNodeForDocument):
(KJS::ScriptInterpreter::markDOMNodesForDocument):
(KJS::ScriptInterpreter::updateDOMNodeDocument):
* bindings/js/kjs_binding.h:
* bindings/js/kjs_dom.cpp:
(WebCore::toAttr):
* bindings/js/kjs_dom.h:
* bindings/js/kjs_domnode.h: Removed.
* bindings/objc/DOMUtility.mm:
(KJS::createDOMWrapper):
* bindings/scripts/CodeGeneratorJS.pm:
* dom/Node.h:
(WebCore::Node::parentElement):
* dom/Node.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22048
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Thu, 7 Jun 2007 18:34:04 +0000 (18:34 +0000)]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22044
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Thu, 7 Jun 2007 08:07:43 +0000 (08:07 +0000)]
Another Gdk and Qt build fix.
* WebCore.pro:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22043
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Thu, 7 Jun 2007 07:48:30 +0000 (07:48 +0000)]
Gdk and Qt build fix.
* WebCore.pro:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22042
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Thu, 7 Jun 2007 04:28:36 +0000 (04:28 +0000)]
LayoutTests:
Reviewed by Hyatt.
Update tests for http://bugs.webkit.org/show_bug.cgi?id=13973
Autogenerate most of the rest of kjs_dom.h/cpp
* fast/dom/Window/window-properties-expected.txt:
* fast/dom/prototype-chain-expected.txt:
WebCore:
Reviewed by Hyatt.
Patch for http://bugs.webkit.org/show_bug.cgi?id=13973
Autogenerate most of the rest of kjs_dom.h/cpp
- Autogenerate JSNodeList and JSNamedNodeMap.
- Move JSEventTargetNode, JSNamedNodesCollection, and JSDOMExceptionConstructor
into their own files.
- Rename KJS::DOMEventTargeNode to WebCore::JSEventTargetNode to adhere
to convention and allow easier code generation.
- Add JS constructors for JSNodeList and JSNamedNodeMap.
- Moved more toJS methods into the correct (corresponding) header files.
- Cleaned up code in order for changes to work.
* DerivedSources.make:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSDOMExceptionConstructor.cpp: Added.
(WebCore::):
(WebCore::JSDOMExceptionConstructor::JSDOMExceptionConstructor):
(WebCore::JSDOMExceptionConstructor::getOwnPropertySlot):
(WebCore::JSDOMExceptionConstructor::getValueProperty):
(WebCore::getDOMExceptionConstructor):
* bindings/js/JSDOMExceptionConstructor.h: Added.
(WebCore::JSDOMExceptionConstructor::classInfo):
* bindings/js/JSDOMWindowCustom.cpp: Added.
(WebCore::JSDOMWindow::customGetOwnPropertySlot):
* bindings/js/JSDocumentCustom.cpp:
(WebCore::JSDocument::mark):
(WebCore::toJS):
* bindings/js/JSEventTargetNode.cpp: Added.
(WebCore::JSEventTargetNode::JSEventTargetNode):
(WebCore::JSEventTargetNode::getOwnPropertySlot):
(WebCore::JSEventTargetNode::getValueProperty):
(WebCore::JSEventTargetNode::put):
(WebCore::JSEventTargetNode::putValueProperty):
(WebCore::JSEventTargetNode::setListener):
(WebCore::JSEventTargetNode::getListener):
(WebCore::JSEventTargetNode::pushEventHandlerScope):
(WebCore::JSEventTargetNodePrototypeFunction::callAsFunction):
(WebCore::toEventTargetNode):
* bindings/js/JSEventTargetNode.h: Added.
(WebCore::JSEventTargetNode::):
* bindings/js/JSHTMLElementCustom.cpp:
* bindings/js/JSHTMLFormElementCustom.cpp:
(WebCore::JSHTMLFormElement::nameGetter):
* bindings/js/JSHTMLOptionElementConstructor.cpp:
* bindings/js/JSNamedNodeMapCustom.cpp: Added.
(WebCore::JSNamedNodeMap::canGetItemsForName):
(WebCore::JSNamedNodeMap::nameGetter):
* bindings/js/JSNamedNodesCollection.cpp: Added.
(WebCore::):
(WebCore::JSNamedNodesCollection::JSNamedNodesCollection):
(WebCore::JSNamedNodesCollection::lengthGetter):
(WebCore::JSNamedNodesCollection::indexGetter):
(WebCore::JSNamedNodesCollection::getOwnPropertySlot):
* bindings/js/JSNamedNodesCollection.h: Added.
(WebCore::JSNamedNodesCollection::classInfo):
* bindings/js/JSNodeCustom.cpp: Added.
(WebCore::toJS):
* bindings/js/JSNodeListCustom.cpp: Added.
(WebCore::JSNodeList::callAsFunction):
(WebCore::JSNodeList::implementsCall):
(WebCore::JSNodeList::canGetItemsForName):
(WebCore::JSNodeList::nameGetter):
* bindings/js/kjs_dom.cpp:
* bindings/js/kjs_dom.h:
* bindings/js/kjs_domnode.h:
* bindings/js/kjs_events.cpp:
(KJS::JSLazyEventListener::parseCode):
* bindings/js/kjs_html.cpp:
(KJS::JSHTMLCollection::getNamedItems):
* bindings/js/kjs_html.h:
* bindings/js/kjs_window.cpp:
(WebCore::toJS):
* bindings/js/kjs_window.h:
* bindings/objc/DOMInternal.mm:
(-[WebScriptObject _initializeScriptDOMNodeImp]):
* bindings/objc/DOMUtility.mm:
(KJS::createDOMWrapper):
* bindings/scripts/CodeGeneratorJS.pm:
* bridge/mac/WebCoreAXObject.mm:
* dom/Attr.idl:
* dom/CharacterData.idl:
* dom/Document.idl:
* dom/DocumentFragment.idl:
* dom/DocumentType.idl:
* dom/Element.idl:
* dom/NamedNodeMap.idl:
* dom/Node.idl:
* dom/NodeList.idl:
* page/DOMWindow.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22039
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Thu, 7 Jun 2007 03:42:45 +0000 (03:42 +0000)]
LayoutTests:
Reviewed by Oliver.
* editing/pasteboard/
5245519-expected.checksum: Added.
* editing/pasteboard/
5245519-expected.png: Added.
* editing/pasteboard/
5245519-expected.txt: Added.
* editing/pasteboard/
5245519.html: Added.
WebCore:
Reviewed by Oliver.
<rdar://problem/
5245519> CrashTracer: [USER] 457 crashes in Mail at WebCore::CSSComputedStyleDeclaration::copyInheritableProperties()
If the user pastes something into a region that ends up being
invisible, or if the pasted content contains style spans
that are render-less, we'll crash when we try to remove
redundant styles from style spans.
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::copyInheritableProperties):
Add null checks.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22038
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Thu, 7 Jun 2007 03:11:34 +0000 (03:11 +0000)]
LayoutTests:
Reviewed by Harrison.
<rdar://problem/
4889598> Problems with moveDown: and moveUp: in Notes with ToDos
* editing/selection/
4889598-expected.checksum: Added.
* editing/selection/
4889598-expected.png: Added.
* editing/selection/
4889598-expected.txt: Added.
* editing/selection/
4889598.html: Added.
WebCore:
Reviewed by Harrison.
<rdar://problem/
4889598> Problems with moveDown: and moveUp: in Notes with ToDos
The caret would disappear when moving from content above or below
a ToDo if that ToDo doesn't have any content in it with the same
x position as the caret. That's because closestLeafChildForXPos
would return non-editable leaves, and which turn into non-editable
VisiblePositions, which are invisible.
* editing/visible_units.cpp:
(WebCore::previousLinePosition): Ask closestLeafForXPos to only
return editable leaves.
(WebCore::nextLinePosition): Ditto.
* rendering/RootInlineBox.cpp:
(WebCore::isEditableLeaf): Added.
(WebCore::RootInlineBox::closestLeafChildForXPos): If requested,
return the closest editable leaf. Removed an early return if the
position is before the first leaf, it's not really much of an
optimization.
* rendering/RootInlineBox.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22037
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Thu, 7 Jun 2007 02:36:49 +0000 (02:36 +0000)]
Reviewed by Anders.
Fix release build.
* bindings/objc/DOM.mm:
(-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]): Add missing null initialization.
(-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]): Add missing null initialization.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22036
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Thu, 7 Jun 2007 00:54:18 +0000 (00:54 +0000)]
LayoutTests:
Reviewed by Hyatt.
Update results for http://bugs.webkit.org/show_bug.cgi?id=13947
Finish autogenerating the JS DOM traversal code
* fast/dom/Window/window-properties-expected.txt:
WebCore:
Reviewed by Hyatt.
Patch for http://bugs.webkit.org/show_bug.cgi?id=13947
Finish autogenerating the JS DOM traversal code
- Completely generate JSNodeFilter.
- Move JSNodeFilterCondition into its own file
* DerivedSources.make:
* WebCore.pro:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSNodeFilterCondition.cpp: Copied from WebCore/bindings/js/kjs_traversal.cpp.
(WebCore::JSNodeFilterCondition::JSNodeFilterCondition):
(WebCore::JSNodeFilterCondition::mark):
(WebCore::JSNodeFilterCondition::acceptNode):
* bindings/js/JSNodeFilterCondition.h: Copied from WebCore/bindings/js/kjs_traversal.h.
* bindings/js/JSNodeFilterCustom.cpp: Added.
(WebCore::JSNodeFilter::mark):
(WebCore::toNodeFilter):
* bindings/js/kjs_dom.cpp:
* bindings/js/kjs_traversal.cpp: Removed.
* bindings/js/kjs_traversal.h: Removed.
* bindings/js/kjs_window.cpp:
* bindings/objc/DOM.mm:
(-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]):
(-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
* bindings/scripts/CodeGeneratorJS.pm:
* dom/Document.cpp:
(WebCore::Document::createNodeIterator):
(WebCore::Document::createTreeWalker):
* dom/Document.h:
* dom/NodeFilter.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22035
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Wed, 6 Jun 2007 22:37:09 +0000 (22:37 +0000)]
Make sure to hand back a script object for webkit plugins (the container
view forwards to its plugin child).
Reviewed by sullivan
* Plugins/WebKitPluginContainerView.h:
* Plugins/WebKitPluginContainerView.mm:
(-[WebKitPluginContainerView objectForWebScript]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22033
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Wed, 6 Jun 2007 18:42:44 +0000 (18:42 +0000)]
Reviewed by Mark Rowe.
Fixes Bug 13996: http://bugs.webkit.org/show_bug.cgi?id=13996
[Drosera] Items in the file list don't get un-highlighted when
files are selected from the file drop-down
* Drosera/debugger.js: currentFile was getting modified before file in the file
browser got un-highlighted. Changed the order in which the functions execute.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22031
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Wed, 6 Jun 2007 18:14:27 +0000 (18:14 +0000)]
Reviewed by Eric Seidel.
http://bugs.webkit.org/show_bug.cgi?id=14017
Cairo: Unwanted gradient effect for small stretched images
* platform/graphics/cairo/ImageCairo.cpp: Use CAIRO_FILTER_NEAREST to
work around the issue.
(WebCore::BitmapImage::draw):
(WebCore::Image::drawPattern):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22030
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lars [Wed, 6 Jun 2007 14:47:42 +0000 (14:47 +0000)]
Reviewed by Zack
Add an API to create and load plugins.
Don't include moc files by hand anymore, rather let
qmake handle them.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22027
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Wed, 6 Jun 2007 10:55:43 +0000 (10:55 +0000)]
2007-06-06 Mark Rowe <mrowe@apple.com>
Reviewed by Maciej.
http://bugs.webkit.org/show_bug.cgi?id=13988
Bug 13988: Colon in file path crashes WebKit Nightly
The WebKit launcher makes use of two `dyld' variables to coerce Safari into running with
the bundled WebKit framework. Both of these variables are interpreted as containing a
colon-delimited list of paths. There is no escaping mechanism defined, so if we detect
a path with a colon in it we need to bail out to prevent `dyld' from throwing an error
when we execute Safari.
* WebKitLauncher/main.m:
(main):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22026
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Wed, 6 Jun 2007 09:45:49 +0000 (09:45 +0000)]
2007-06-06 Mark Rowe <mrowe@apple.com>
Qt build fix.
* rendering/RenderTextControl.cpp: Fix case of #include filename.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22024
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lars [Wed, 6 Jun 2007 09:01:39 +0000 (09:01 +0000)]
Reviewed by Maciej.
Define WTF_USE_NPOBJECT for Qt. Fix includes
in HTMLPluginElement and add proper forwarding headers
from JavaScriptCore.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22023
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Wed, 6 Jun 2007 08:46:08 +0000 (08:46 +0000)]
Remove bogus assert that is hit depressingly often.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22022
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Wed, 6 Jun 2007 07:05:57 +0000 (07:05 +0000)]
Bulletproof windowClipRect, since it can be called at crazy times.
Part of fix for 13972.
Reviewed by olliej
* bindings/objc/DOM.mm:
(-[DOMElement _windowClipRect]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22020
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Wed, 6 Jun 2007 07:04:17 +0000 (07:04 +0000)]
Fix for bug 13972, quicktime doesn't respect CSS clip and overflow properties.
Make sure that calls to [NSView visibleRect] will do the right thing for both
Netscape plugins and WebKit plugins.
Reviewed by olliej
* Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView visibleRect]):
(-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
(-[WebBaseNetscapePluginView isOpaque]):
* Plugins/WebKitPluginContainerView.h: Added.
* Plugins/WebKitPluginContainerView.mm: Added.
(-[WebKitPluginContainerView initWithFrame:DOMElement:]):
(-[WebKitPluginContainerView dealloc]):
(-[WebKitPluginContainerView visibleRect]):
* Plugins/WebPluginController.mm:
(-[WebPluginController destroyAllPlugins]):
* WebCoreSupport/WebFrameBridge.mm:
(-[WebFrameBridge pluginViewWithPackage:attributeNames:attributeValues:baseURL:DOMElement:loadManually:]):
* WebKit.xcodeproj/project.pbxproj:
* WebView/WebHTMLView.mm:
(-[WebHTMLView addSubview:]):
(-[WebHTMLView willRemoveSubview:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22019
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Wed, 6 Jun 2007 04:17:41 +0000 (04:17 +0000)]
2007-06-05 MorganL <morganl.webkit@yahoo.com>
Reviewed by Dave Hyatt.
Fixes http://bugs.webkit.org/show_bug.cgi?id=14008
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::calcHeight):
(WebCore::RenderTextControl::calcPrefWidths):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22017
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kmccullo [Wed, 6 Jun 2007 02:36:00 +0000 (02:36 +0000)]
Reviewed by.
- Respelling Oliver's name right.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22014
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kmccullo [Wed, 6 Jun 2007 02:32:15 +0000 (02:32 +0000)]
Reviewed by Mark and Olliver.
- http://bugs.webkit.org/show_bug.cgi?id=13352 REGRESSION: Gmail hangs on send message.
- Now we don't hang, but we do so by avoiding certain legitimate characters, the evangelism bug for this is: <rdar://problem/
5252577> gmail does not accept legal characters in the form boundary
* html/HTMLFormElement.cpp:
(WebCore::getUniqueBoundaryString):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22013
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Tue, 5 Jun 2007 21:01:59 +0000 (21:01 +0000)]
Build fix.
* xml/xmlhttprequest.cpp:
(WebCore::isValidToken):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21982
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Tue, 5 Jun 2007 20:47:19 +0000 (20:47 +0000)]
LayoutTests:
Reviewed by Geoff.
<rdar://problem/
5245555> REGRESSION: HTTP header injection in XMLHttpRequest.setRequestHeader
<rdar://problem/
5246208> HTTP injection in XMLHttpRequest.open method parameter
<rdar://problem/
5246242> HTTP header injection in HXMLHttpRequest.setRequestHeader header parameter
* fast/dom/xmlhttprequest-invalid-values-expected.txt: Added.
* fast/dom/xmlhttprequest-invalid-values.html: Added.
WebCore:
Reviewed by Geoff.
<rdar://problem/
5245555> REGRESSION: HTTP header injection in XMLHttpRequest.setRequestHeader
<rdar://problem/
5246208> HTTP injection in XMLHttpRequest.open method parameter
<rdar://problem/
5246242> HTTP header injection in HXMLHttpRequest.setRequestHeader header parameter
Check method names, header names and header values and throw exceptions if any of them are
invalid. This is what the new XMLHttpRequest spec states that we should do.
* xml/xmlhttprequest.cpp:
(WebCore::isValidToken):
(WebCore::isValidHeaderValue):
(WebCore::XMLHttpRequest::open):
(WebCore::XMLHttpRequest::setRequestHeader):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21981
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Tue, 5 Jun 2007 20:33:54 +0000 (20:33 +0000)]
Reviewed by Geoff.
Optimize JSCSSStyleDeclaration after performance regression in r21854.
- Check static table before name getter in JSCSSStyleDeclaration::getOwnPropertySlot()
- Get rid of a string allocation by keeping string as KJS::Identifier for canGetItemsForName()
functions.
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::JSCSSStyleDeclaration::canGetItemsForName):
* bindings/js/JSHTMLAppletElementCustom.cpp:
(WebCore::JSHTMLAppletElement::canGetItemsForName):
* bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::canGetItemsForName):
* bindings/js/JSHTMLEmbedElementCustom.cpp:
(WebCore::JSHTMLEmbedElement::canGetItemsForName):
* bindings/js/JSHTMLFormElementCustom.cpp:
(WebCore::JSHTMLFormElement::canGetItemsForName):
* bindings/js/JSHTMLFrameSetElementCustom.cpp:
(WebCore::JSHTMLFrameSetElement::canGetItemsForName):
* bindings/js/JSHTMLObjectElementCustom.cpp:
(WebCore::JSHTMLObjectElement::canGetItemsForName):
* bindings/scripts/CodeGeneratorJS.pm:
* css/CSSStyleDeclaration.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21979
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver [Tue, 5 Jun 2007 00:15:31 +0000 (00:15 +0000)]
Reviewed by Geoff and Justin.
Fix for <rdar://problem/
5246941> Clicking URL field on
Safari causes halt for a minute when using input methods.
and <rdar://problem/
5245964> Safari hangs for several
seconds when trying to select text using mouse
This is a by product of the textStorage hack used to fix
rdar://problem/
5000470 -- TSM calls textStorage repeatedly
when changing focus, on certain mouse events, etc. If there
is no selection/editable region we repeatedly create an
NSAttributedString from the full document. If the document is
sufficiently long this starts consuming an inordinate amount of
time.
This check should really have been present in the original
patch.
* WebKit.xcodeproj/project.pbxproj:
* WebView/WebHTMLView.mm:
(-[WebHTMLView textStorage]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21976
268f45cc-cd09-0410-ab3c-
d52691b4dbfc