WebKit-https.git
11 years ago2010-08-24 Lucas De Marchi <lucas.demarchi@profusion.mobi>
demarchi@webkit.org [Tue, 24 Aug 2010 16:40:36 +0000 (16:40 +0000)]
2010-08-24  Lucas De Marchi  <lucas.demarchi@profusion.mobi>

        [EFL] Unreviewed build fix after r65891.

        r65891 renamed RemoteInspectorFrontend to InspectorFrontend. Rename
        accordingly in CMake build system.

        * cmake/WebKitGenerators.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-24 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 24 Aug 2010 16:15:46 +0000 (16:15 +0000)]
2010-08-24  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Trace to the style that contributes to
        the computed styles panel.
        https://bugs.webkit.org/show_bug.cgi?id=44448

        Test: inspector/styles-computed-trace.html

        * English.lproj/localizedStrings.js:
        * inspector/front-end/Section.js:
        (WebInspector.Section.prototype.set subtitle):
        (WebInspector.Section.prototype.get subtitleAsTextForTest):
        * inspector/front-end/StylesSidebarPane.js:
        (WebInspector.StylesSidebarPane.prototype._refreshUpdate):
        (WebInspector.StylesSidebarPane.prototype._rebuildUpdate):
        (WebInspector.StylesSidebarPane.prototype._rebuildStyleRules):
        (WebInspector.StylesSidebarPane.prototype._refreshSectionsForStyleRules):
        (WebInspector.StylesSidebarPane.prototype._rebuildSectionsForStyleRules):
        (WebInspector.StylePropertiesSection.linkifyUncopyable):
        (WebInspector.StylePropertiesSection):
        (WebInspector.StylePropertiesSection.prototype.isPropertyInherited):
        (WebInspector.StylePropertiesSection.prototype.isPropertyOverloaded):
        (WebInspector.StylePropertiesSection.prototype.isPropertyDisabled):
        (WebInspector.StylePropertiesSection.prototype.update):
        (WebInspector.StylePropertiesSection.prototype.onpopulate):
        (WebInspector.ComputedStylePropertiesSection):
        (WebInspector.ComputedStylePropertiesSection.prototype.collapse):
        (WebInspector.ComputedStylePropertiesSection.prototype._isPropertyInherited):
        (WebInspector.ComputedStylePropertiesSection.prototype.update):
        (WebInspector.ComputedStylePropertiesSection.prototype.onpopulate):
        (WebInspector.ComputedStylePropertiesSection.prototype.rebuildComputedTrace):
        (WebInspector.BlankStylePropertiesSection):
        * inspector/front-end/inspector.css:
        (.styles-section a::before):
        * inspector/front-end/inspector.js:
        (WebInspector.documentClick.followLink):
        (WebInspector.documentClick):
        (WebInspector.linkifyResourceAsNode):
2010-08-24  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Trace to the style that contributes to
        the computed styles panel.
        https://bugs.webkit.org/show_bug.cgi?id=44448

        * inspector/elements-panel-styles-expected.txt:
        * inspector/elements-tests.js:
        (frontend_getSelectedElementStyles):
        (frontend_dumpStyleTreeItem):
        * inspector/styles-computed-trace-expected.txt: Added.
        * inspector/styles-computed-trace.html: Added.
        * inspector/styles-disable-inherited-expected.txt:
        * inspector/styles-disable-inherited.html:
        * inspector/styles-disable-then-delete-expected.txt:
        * inspector/styles-source-lines-inline-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-24 Daniel Cheng <dcheng@chromium.org>
commit-queue@webkit.org [Tue, 24 Aug 2010 16:06:36 +0000 (16:06 +0000)]
2010-08-24  Daniel Cheng  <dcheng@chromium.org>

        Reviewed by Eric Seidel.

        [chromium] Generate drag images for HTML elements and selections.
        https://bugs.webkit.org/show_bug.cgi?id=43449

        We weren't properly generating drag images if an HTML element was set
        as the drag feedback image. I also implemented dragImageForSelection
        while I was working on this part of the code.

        No new tests.

        * WebCore.exp.in:
        * bindings/objc/DOM.mm:
        (-[DOMNode renderedImage]):
        * page/Frame.h:
        * page/brew/FrameBrew.cpp:
        (WebCore::Frame::nodeImage):
        * page/chromium/FrameChromium.cpp:
        (WebCore::):
        (WebCore::Frame::nodeImage):
        (WebCore::Frame::dragImageForSelection):
        * page/efl/FrameEfl.cpp:
        (WebCore::Frame::nodeImage):
        * page/gtk/FrameGtk.cpp:
        (WebCore::Frame::nodeImage):
        * page/haiku/FrameHaiku.cpp:
        (WebCore::Frame::nodeImage):
        * page/mac/FrameMac.mm:
        (WebCore::Frame::nodeImage):
        (WebCore::Frame::dragImageForSelection):
        * page/qt/FrameQt.cpp:
        (WebCore::Frame::nodeImage):
        (WebCore::Frame::dragImageForSelection):
        * page/win/FrameCGWin.cpp:
        (WebCore::Frame::nodeImage):
        * page/win/FrameCairoWin.cpp:
        (WebCore::Frame::nodeImage):
        * page/wince/FrameWince.cpp:
        (WebCore::Frame::nodeImage):
        * page/wx/FrameWx.cpp:
        (WebCore::Frame::nodeImage):
        * platform/chromium/ClipboardChromium.cpp:
        (WebCore::ClipboardChromium::createDragImage):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::selectionForegroundColor):
2010-08-24  Daniel Cheng  <dcheng@chromium.org>

        Reviewed by Eric Seidel.

        [chromium] Generate drag images for HTML elements and selections.
        https://bugs.webkit.org/show_bug.cgi?id=43449

        Fix up calls to Frame::nodeImage, which has a new signature.

        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView halt]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed trivial fix.
ossy@webkit.org [Tue, 24 Aug 2010 15:53:42 +0000 (15:53 +0000)]
Unreviewed trivial fix.

After r65845 we don't need Qt specific expected result.

* platform/qt/editing/execCommand/insert-list-xml-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-24 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Tue, 24 Aug 2010 15:44:07 +0000 (15:44 +0000)]
2010-08-24  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Steve Block.

        IndexedDB needs to manually delete all objectStore data and indexes
        https://bugs.webkit.org/show_bug.cgi?id=44522

        * storage/indexeddb/objectstore-removeobjectstore-expected.txt: Added.
        * storage/indexeddb/objectstore-removeobjectstore.html: Added.
        * storage/indexeddb/resources/shared.js:
        (unexpectedSuccessCallback):
2010-08-24  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Steve Block.

        IndexedDB needs to manually delete all objectStore data and indexes
        https://bugs.webkit.org/show_bug.cgi?id=44522

        Apparently it's only newer versions of SQLite that handle cascade
        delete.  The rest silently fail.  So do it manually.

        Test: storage/indexeddb/objectstore-removeobjectstore.html

        * storage/IDBDatabaseBackendImpl.cpp:
        (WebCore::IDBDatabaseBackendImpl::createObjectStore):
        (WebCore::doDelete):
        (WebCore::IDBDatabaseBackendImpl::removeObjectStore):
        * storage/IDBDatabaseBackendImpl.h:
        * storage/IDBFactoryBackendImpl.cpp:
        (WebCore::createTables):
        * storage/IDBObjectStoreBackendImpl.cpp:
        (WebCore::IDBObjectStoreBackendImpl::removeIndex):
        * storage/IDBObjectStoreBackendImpl.h:
        (WebCore::IDBObjectStoreBackendImpl::create):
        (WebCore::IDBObjectStoreBackendImpl::id):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUpdate skipped list for WebKit2.
weinig@apple.com [Tue, 24 Aug 2010 15:03:26 +0000 (15:03 +0000)]
Update skipped list for WebKit2.

* platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix for <rdar://problem/8153271> and <rdar://problem/8153288>
weinig@apple.com [Tue, 24 Aug 2010 14:59:26 +0000 (14:59 +0000)]
Fix for <rdar://problem/8153271> and <rdar://problem/8153288>
Change behavior of javascript: urls in <embed> and <object> back to
how they behaved before r50698.

Reviewed by Adam Barth.

WebCore:

Tests: fast/loader/javascript-url-in-embed.html
       fast/loader/javascript-url-in-object.html

* loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::requestFrame):
(WebCore::SubframeLoader::requestObject):
(WebCore::SubframeLoader::loadOrRedirectSubframe):
* loader/SubframeLoader.h:

LayoutTests:

* fast/loader/javascript-url-in-embed-expected.txt: Added.
* fast/loader/javascript-url-in-embed.html: Added.
* fast/loader/javascript-url-in-object-expected.txt: Added.
* fast/loader/javascript-url-in-object.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-24 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Tue, 24 Aug 2010 14:58:45 +0000 (14:58 +0000)]
2010-08-24  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Rubber-stamped by Xan Lopez.

        Do not initialize the GSettings object in webkit_init - the other
        call sites are always called in the main thread so this is
        unnecessary.

        * webkit/webkitprivate.cpp:
        (webkit_init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-24 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Tue, 24 Aug 2010 14:14:55 +0000 (14:14 +0000)]
2010-08-24  Kent Tamura  <tkent@chromium.org>

        Unreviewed, test expectation update.

        * platform/chromium/drt_expectations.txt: Remove a duplicated entry.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-24 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 24 Aug 2010 14:13:43 +0000 (14:13 +0000)]
2010-08-24  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        Update code to compile with latest GTK+ 3.x.

        * platform/gtk/gtk2drawing.c:
        (TSOffsetStyleGCs):
        (moz_gtk_entry_paint):
        * plugins/gtk/gtk2xtbin.c:
        (gtk_xtbin_new):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-24 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Tue, 24 Aug 2010 14:04:02 +0000 (14:04 +0000)]
2010-08-24  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Landed wrong results in my last commit.

        * platform/mac/svg/css/shadow-changes-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-24 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Tue, 24 Aug 2010 14:00:41 +0000 (14:00 +0000)]
2010-08-24  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        -webkit-svg-shadow doesn't repaint on changes
        https://bugs.webkit.org/show_bug.cgi?id=44521

        Trivial fix, to make -webkit-svg-shadow react on changes.

        Test: svg/css/shadow-changes.svg

        * rendering/style/SVGRenderStyle.cpp:
        (WebCore::SVGRenderStyle::diff): If 'svgShadow' is not equal, cause a repaint.

2010-08-24  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        -webkit-svg-shadow doesn't repaint on changes
        https://bugs.webkit.org/show_bug.cgi?id=44521

        * platform/mac/svg/css/shadow-changes-expected.checksum: Added.
        * platform/mac/svg/css/shadow-changes-expected.png: Added.
        * platform/mac/svg/css/shadow-changes-expected.txt: Added.
        * svg/css/shadow-changes.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-24 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Tue, 24 Aug 2010 13:40:49 +0000 (13:40 +0000)]
2010-08-24  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        Cg logs "<Error>: CGPathCloseSubpath: no current point. " in lots of tests
        https://bugs.webkit.org/show_bug.cgi?id=43026

        Check if the path is empty before closing it.

        * svg/SVGPathBuilder.cpp:
        (WebCore::SVGPathBuilder::moveTo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-24 Marcus Bulach <bulach@chromium.org>
bulach@chromium.org [Tue, 24 Aug 2010 13:25:39 +0000 (13:25 +0000)]
2010-08-24  Marcus Bulach  <bulach@chromium.org>

        Reviewed by Jeremy Orlow.

        Hooks IDBKeyPath with IDBObjectStorage::put.
        https://bugs.webkit.org/show_bug.cgi?id=44275

        Adds a mechanism to extract an IDBKey from SerializedScriptValue using IDBKeyPath
        during IDBObjectStorage::put.

        * WebCore.gyp/WebCore.gyp:
        * WebCore.gypi:
        * platform/chromium/ChromiumBridge.h:
        * storage/IDBKeyPathBackendImpl.cpp: Added.
        (IDBKeyPathBackendImpl::createIDBKeysFromSerializedValuesAndKeyPath):
        * storage/IDBKeyPathBackendImpl.h: Added.
        * storage/IDBObjectStoreBackendImpl.cpp:
        (WebCore::IDBObjectStoreBackendImpl::put):
        * storage/chromium/IDBKeyPathBackendImpl.cpp: Added.
        (WebCore::IDBKeyPathBackendImpl::createIDBKeysFromSerializedValuesAndKeyPath):
2010-08-24  Marcus Bulach  <bulach@chromium.org>

        Reviewed by Jeremy Orlow.

        Hooks IDBKeyPath with IDBObjectStorage::put.
        https://bugs.webkit.org/show_bug.cgi?id=44275

        Adds a mechanism to extract an IDBKey from SerializedScriptValue using IDBKeyPath
        during IDBObjectStorage::put.

        * public/WebIDBKey.h:
        (WebKit::WebIDBKey::WebIDBKey):
        * public/WebKitClient.h:
        (WebKit::WebKitClient::createIDBKeysFromSerializedValuesAndKeyPath):
        * src/ChromiumBridge.cpp:
        (WebCore::ChromiumBridge::createIDBKeysFromSerializedValuesAndKeyPath):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-24 Andras Becsi <abecsi@inf.u-szeged.hu>
abecsi@webkit.org [Tue, 24 Aug 2010 13:04:40 +0000 (13:04 +0000)]
2010-08-24  Andras Becsi  <abecsi@inf.u-szeged.hu>

        Reviewed by Simon Hausmann.

        [Qt] Fix predeclared variables for Symbian to be able to build QtWebKit for Symbian on Linux.

        * Api/DerivedSources.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-24 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Tue, 24 Aug 2010 12:26:55 +0000 (12:26 +0000)]
2010-08-24  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Pavel Feldman.

        WebInspector: RemoteInspectorFrontend can be renamed to InspectorFrontend.
        The old version of InspectorFrontend was removed some time ago and now
        it is possible to rename the new version of inspector frontend class to its
        original name.
        https://bugs.webkit.org/show_bug.cgi?id=44499

        * GNUmakefile.am:
        * WebCore.gyp/WebCore.gyp:
        * WebCore.pri:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * inspector/CodeGeneratorInspector.pm:
        * inspector/ConsoleMessage.cpp:
        * inspector/ConsoleMessage.h:
        * inspector/InjectedScriptHost.cpp:
        * inspector/InjectedScriptHost.h:
        * inspector/InspectorApplicationCacheAgent.cpp:
        * inspector/InspectorApplicationCacheAgent.h:
        * inspector/InspectorBackend.cpp:
        * inspector/InspectorBackend.h:
        * inspector/InspectorCSSStore.cpp:
        * inspector/InspectorCSSStore.h:
        * inspector/InspectorController.cpp:
        * inspector/InspectorController.h:
        * inspector/InspectorDOMAgent.cpp:
        * inspector/InspectorDOMAgent.h:
        * inspector/InspectorDOMStorageResource.cpp:
        * inspector/InspectorDOMStorageResource.h:
        * inspector/InspectorDatabaseResource.cpp:
        * inspector/InspectorDatabaseResource.h:
        * inspector/InspectorDebuggerAgent.cpp:
        * inspector/InspectorDebuggerAgent.h:
        * inspector/InspectorProfilerAgent.cpp:
        * inspector/InspectorProfilerAgent.h:
        * inspector/InspectorResource.cpp:
        * inspector/InspectorResource.h:
        * inspector/InspectorStorageAgent.cpp:
        * inspector/InspectorStorageAgent.h:
        * inspector/InspectorTimelineAgent.cpp:
        * inspector/InspectorTimelineAgent.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed trivial fix.
ossy@webkit.org [Tue, 24 Aug 2010 12:11:15 +0000 (12:11 +0000)]
Unreviewed trivial fix.

Remove wrong code from Qt that's dumping extra markup into the clipboard
https://bugs.webkit.org/show_bug.cgi?id=44506

After r65888 we don't need Qt specific expected result.

* platform/qt/editing/pasteboard/onpaste-text-html-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-24 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Tue, 24 Aug 2010 11:22:12 +0000 (11:22 +0000)]
2010-08-24  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        Markers don't render, when applied to a target using vector-effect="non-scaling-stroke"
        https://bugs.webkit.org/show_bug.cgi?id=44511

        Make fillAndStrokePath a member function of RenderPath, to avoid having to pass the const Path& and this paramters.
        Don't leave the GraphicsContext mutated after applying non-scaling-stroke transformation, otherwhise markers will be renderer
        in the wrong coordinate space, and thus don't show up anymore.

        Test: svg/custom/non-scaling-stroke-markers.svg

        * rendering/RenderPath.cpp:
        (WebCore::RenderPath::fillAndStrokePath):
        (WebCore::RenderPath::paint):
        * rendering/RenderPath.h:

2010-08-24  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        Markers don't render, when applied to a target using vector-effect="non-scaling-stroke"
        https://bugs.webkit.org/show_bug.cgi?id=44511

        Add new test verifying that markers can be appplied to objects using vector-effect="non-scaling-stroke".

        * platform/mac/svg/custom/non-scaling-stroke-markers-expected.checksum: Added.
        * platform/mac/svg/custom/non-scaling-stroke-markers-expected.png: Added.
        * platform/mac/svg/custom/non-scaling-stroke-markers-expected.txt: Added.
        * svg/custom/non-scaling-stroke-markers.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRemove wrong code from Qt that's dumping extra markup into the clipboard
ossy@webkit.org [Tue, 24 Aug 2010 11:16:43 +0000 (11:16 +0000)]
Remove wrong code from Qt that's dumping extra markup into the clipboard
https://bugs.webkit.org/show_bug.cgi?id=44506

Patch by Adam Barth <abarth@webkit.org> on 2010-08-24
Reviewed by Kenneth Rohde Christiansen.

I have no way of testing this patch, but hopefully it should fix a
bunch of newly failing tests.  This code seems very confused.

* platform/qt/PasteboardQt.cpp:
(WebCore::Pasteboard::writeSelection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWeb Inspector: fix gcc warnings introduced in 65731
ossy@webkit.org [Tue, 24 Aug 2010 11:00:15 +0000 (11:00 +0000)]
Web Inspector: fix gcc warnings introduced in 65731
https://bugs.webkit.org/show_bug.cgi?id=44468

Patch by Pavel Podivilov <podivilov@chromium.org> on 2010-08-24
Reviewed by Yury Semikhatsky.

* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::didInsertDOMNode):
(WebCore::InspectorDOMAgent::pauseOnBreakpoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Symbian] Fix commit/decommit of system memory using RChunk
hausmann@webkit.org [Tue, 24 Aug 2010 10:38:35 +0000 (10:38 +0000)]
[Symbian] Fix commit/decommit of system memory using RChunk

Patch by Yael Aharon <yael.aharon@nokia.com> on 2010-08-24
Reviewed by Simon Hausmann.

Swap accidentially reversed start and m_base values for determining the
offset within the RChunk.

* wtf/PageReservation.h:
(WTF::PageReservation::systemCommit):
(WTF::PageReservation::systemDecommit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-24 Andreas Kling <andreas.kling@nokia.com>
andreas.kling@nokia.com [Tue, 24 Aug 2010 10:11:05 +0000 (10:11 +0000)]
2010-08-24  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Tor Arne Vestbø.

        r65878 broke fast/dom/document-attribute-js-null.html

        * fast/dom/document-attribute-js-null-expected.txt:
        * fast/dom/document-attribute-js-null.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-24 Roland Steiner <rolandsteiner@chromium.org>
rolandsteiner@chromium.org [Tue, 24 Aug 2010 10:05:02 +0000 (10:05 +0000)]
2010-08-24  Roland Steiner  <rolandsteiner@chromium.org>

        Unreviewed: trim duplicated entry from Chromium test_expectations.txt

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-24 Andras Becsi <abecsi@webkit.org>
abecsi@webkit.org [Tue, 24 Aug 2010 10:03:52 +0000 (10:03 +0000)]
2010-08-24  Andras Becsi  <abecsi@webkit.org>

        [Qt] WebKit2 build fix.

        * Scripts/enumerate-included-framework-headers:
        Remove stray global option form sed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Blur shadow for rectangle fill
ariya@webkit.org [Tue, 24 Aug 2010 09:58:01 +0000 (09:58 +0000)]
[Qt] Blur shadow for rectangle fill
https://bugs.webkit.org/show_bug.cgi?id=44488

Patch by Ariya Hidayat <ariya@sencha.com> on 2010-08-24
Reviewed by Simon Hausmann.

Refactor fillRect() function to support blur radius in the shadow.

* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::fillRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-24 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Tue, 24 Aug 2010 09:27:22 +0000 (09:27 +0000)]
2010-08-24  Kent Tamura  <tkent@chromium.org>

        Reviewed by Jeremy Orlow.

        [DRT/Chromium] Support for IndexedDB tests
        https://bugs.webkit.org/show_bug.cgi?id=44490

        * platform/chromium/drt_expectations.txt:
2010-08-24  Kent Tamura  <tkent@chromium.org>

        Reviewed by Jeremy Orlow.

        [DRT/Chromium] Support for IndexedDB tests
        https://bugs.webkit.org/show_bug.cgi?id=44490

        * DEPS: Roll Chromium to r57145 to have a webkit_support change.
2010-08-24  Kent Tamura  <tkent@chromium.org>

        Reviewed by Jeremy Orlow.

        [DRT/Chromium] Support for IndexedDB tests
        https://bugs.webkit.org/show_bug.cgi?id=44490

        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::TestShell): Enable IndexedDB.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-24 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Tue, 24 Aug 2010 09:25:11 +0000 (09:25 +0000)]
2010-08-24  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze

        clip-path does not work inside mask element
        https://bugs.webkit.org/show_bug.cgi?id=41428

        Add new tests covering nesting of clippers and maskers, with different unitTypes for the content coordinate system.
        Scale all ImageBuffer content to take into account that ImageBuffers use integer based sizes, where the content
        is floating-point sized. This compensates rounded errors, when scaling the document.

        Tests: svg/clip-path/clip-in-mask-objectBoundingBox.svg
               svg/clip-path/clip-in-mask-userSpaceOnUse.svg
               svg/clip-path/clip-in-mask.svg
               svg/clip-path/deep-nested-clip-in-mask-different-unitTypes.svg
               svg/clip-path/deep-nested-clip-in-mask-panning.svg
               svg/clip-path/deep-nested-clip-in-mask.svg
               svg/clip-path/nested-clip-in-mask-image-based-clipping.svg
               svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping.svg
               svg/clip-path/nested-clip-in-mask-path-based-clipping.svg

        * rendering/RenderSVGResourceClipper.cpp:
        (WebCore::RenderSVGResourceClipper::applyResource): Return the value of applyClippingToContext, instead of always true.
        (WebCore::RenderSVGResourceClipper::applyClippingToContext): Moved some code from createClipData, to avoid having to pass 5 arguments to createClipData.
        (WebCore::RenderSVGResourceClipper::drawContentIntoMaskImage): Renamed from createClipData.
        * rendering/RenderSVGResourceClipper.h:
        * rendering/RenderSVGResourceGradient.cpp:
        (WebCore::createMaskAndSwapContextForTextGradient): Pass absoluteTargetRect to createImageBuffer.
        (WebCore::clipToTextMask): Ditto.
        * rendering/RenderSVGResourceMasker.cpp:
        (WebCore::RenderSVGResourceMasker::applyResource): Ditto.
        (WebCore::RenderSVGResourceMasker::drawContentIntoMaskImage): Pass content transformation to renderSubtreeToImageBuffer, to support nesting objectBoundingBox resources.
        * rendering/RenderSVGResourcePattern.cpp:
        (WebCore::RenderSVGResourcePattern::applyResource): Adapt to calculateTransformationToOutermostSVGCoordinateSystem changes. AffineTransform is now passed as reference.
        (WebCore::RenderSVGResourcePattern::createTileImage): ImageBuffer content scaling is now handled by createImageBuffer.
        * rendering/SVGImageBufferTools.cpp:
        (WebCore::SVGImageBufferTools::calculateTransformationToOutermostSVGCoordinateSystem): Renamed. Don't return an AffineTransform copy, but instead pass it as reference.
        (WebCore::SVGImageBufferTools::createImageBuffer): Always scale the ImageBuffer content, to compensate rounding effects (code was only present in patterns so far).
                                                           Now also needs the 'absoluteTargetRect' parameter, not only 'clampedAbsoluteTargetRect'.
        (WebCore::SVGImageBufferTools::renderSubtreeToImageBuffer): Moved from SVGRenderSupport.
        (WebCore::SVGImageBufferTools::clipToImageBuffer): Pass ImageBuffer as OwnPtr reference, to allow to clear it under certain circumstances (see comment).
        (WebCore::SVGImageBufferTools::clampedAbsoluteTargetRectForRenderer): Remove AffineTransform parameter, absoluteTargetRect is calculated before passing into this function.
        * rendering/SVGImageBufferTools.h:
        * rendering/SVGRenderSupport.cpp:
        (WebCore::SVGRenderSupport::prepareToRenderSVGContent): Important change, respect the RenderSVGResourceClipper::applyResource() return value!
        * rendering/SVGRenderSupport.h:
        * svg/SVGFEImageElement.cpp:
        (WebCore::SVGFEImageElement::build): renderSubtreeToImage now lives in SVGImageBufferTools, adapt code.

2010-08-24  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        clip-path does not work inside mask element
        https://bugs.webkit.org/show_bug.cgi?id=41428

        Update results of all tests containing <mask> / <pattern> and/or gradient on text (using CG).
        The ImageBuffer content is now scaled to account for rounding differences, when zooming.

        * platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.checksum:
        * platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
        * platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.checksum:
        * platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png:
        * platform/mac/svg/clip-path/clip-in-mask-expected.checksum: Added.
        * platform/mac/svg/clip-path/clip-in-mask-expected.png: Added.
        * platform/mac/svg/clip-path/clip-in-mask-expected.txt: Added.
        * platform/mac/svg/clip-path/clip-in-mask-objectBoundingBox-expected.checksum: Added.
        * platform/mac/svg/clip-path/clip-in-mask-objectBoundingBox-expected.png: Added.
        * platform/mac/svg/clip-path/clip-in-mask-objectBoundingBox-expected.txt: Added.
        * platform/mac/svg/clip-path/clip-in-mask-userSpaceOnUse-expected.checksum: Added.
        * platform/mac/svg/clip-path/clip-in-mask-userSpaceOnUse-expected.png: Added.
        * platform/mac/svg/clip-path/clip-in-mask-userSpaceOnUse-expected.txt: Added.
        * platform/mac/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.checksum: Added.
        * platform/mac/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.png: Added.
        * platform/mac/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.txt: Added.
        * platform/mac/svg/clip-path/deep-nested-clip-in-mask-expected.checksum: Added.
        * platform/mac/svg/clip-path/deep-nested-clip-in-mask-expected.png: Added.
        * platform/mac/svg/clip-path/deep-nested-clip-in-mask-expected.txt: Added.
        * platform/mac/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.checksum: Added.
        * platform/mac/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.png: Added.
        * platform/mac/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.txt: Added.
        * platform/mac/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.checksum: Added.
        * platform/mac/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.png: Added.
        * platform/mac/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.txt: Added.
        * platform/mac/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.checksum: Added.
        * platform/mac/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.png: Added.
        * platform/mac/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.txt: Added.
        * platform/mac/svg/custom/absolute-sized-content-with-resources-expected.checksum:
        * platform/mac/svg/custom/absolute-sized-content-with-resources-expected.png:
        * platform/mac/svg/custom/grayscale-gradient-mask-expected.checksum:
        * platform/mac/svg/custom/grayscale-gradient-mask-expected.png:
        * platform/mac/svg/custom/js-late-gradient-and-object-creation-expected.checksum:
        * platform/mac/svg/custom/js-late-gradient-and-object-creation-expected.png:
        * platform/mac/svg/custom/text-rotated-gradient-expected.checksum:
        * platform/mac/svg/custom/text-rotated-gradient-expected.png:
        * platform/mac/svg/text/selection-background-color-expected.checksum:
        * platform/mac/svg/text/selection-background-color-expected.png:
        * platform/mac/svg/transforms/text-with-mask-with-svg-transform-expected.checksum:
        * platform/mac/svg/transforms/text-with-mask-with-svg-transform-expected.png:
        * platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.checksum:
        * platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.png:
        * svg/clip-path/clip-in-mask-objectBoundingBox.svg: Added.
        * svg/clip-path/clip-in-mask-userSpaceOnUse.svg: Added.
        * svg/clip-path/clip-in-mask.svg: Added.
        * svg/clip-path/deep-nested-clip-in-mask-different-unitTypes.svg: Added.
        * svg/clip-path/deep-nested-clip-in-mask.svg: Added.
        * svg/clip-path/nested-clip-in-mask-image-based-clipping.svg: Added.
        * svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping.svg: Added.
        * svg/clip-path/nested-clip-in-mask-path-based-clipping.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-24 Andrei Popescu <andreip@dhcp-172-16-14-12.lon.corp.google.com>
andreip@google.com [Tue, 24 Aug 2010 09:05:38 +0000 (09:05 +0000)]
2010-08-24  Andrei Popescu  <andreip@dhcp-172-16-14-12.lon.corp.google.com>

        Reviewed by Jeremy Orlow.

        Implement IDBTransaction::objectStore

        [IndexedDB] IDBTransaction is missing the implementation for objectStore method
        https://bugs.webkit.org/show_bug.cgi?id=44446

        * storage/indexeddb/script-tests/transaction-basics.js:
        (test):
        (openSuccess):
        (createSuccess):
        (abortCallback):
        * storage/indexeddb/transaction-basics-expected.txt:
2010-08-24  Andrei Popescu  <andreip@dhcp-172-16-14-12.lon.corp.google.com>

        Reviewed by Jeremy Orlow.

        [IndexedDB] IDBTransaction is missing the implementation for objectStore method
        https://bugs.webkit.org/show_bug.cgi?id=44446

        * storage/IDBDatabaseBackendImpl.cpp:
        (WebCore::IDBDatabaseBackendImpl::transaction):
        * storage/IDBTransactionBackendImpl.cpp:
        (WebCore::IDBTransactionBackendImpl::create):
        (WebCore::IDBTransactionBackendImpl::IDBTransactionBackendImpl):
        (WebCore::IDBTransactionBackendImpl::objectStore):
        * storage/IDBTransactionBackendImpl.h:
        * storage/IDBTransactionCoordinator.cpp:
        (WebCore::IDBTransactionCoordinator::createTransaction):
        * storage/IDBTransactionCoordinator.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-24 Andreas Kling <andreas.kling@nokia.com>
andreas.kling@nokia.com [Tue, 24 Aug 2010 08:55:29 +0000 (08:55 +0000)]
2010-08-24  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Tor Arne Vestbø.

        Disallow setting Document.xmlVersion to unsupported versions
        https://bugs.webkit.org/show_bug.cgi?id=44494

        Added XMLDocumentParser::supportsXMLVersion() - only returns true for "1.0"
        in both implementations.

        * dom/Document.cpp:
        (WebCore::Document::setXMLVersion): Throw NOT_SUPPORTED_ERR
        if XMLDocumentParser::supportsXMLVersion() returns false for the version.
        * dom/XMLDocumentParser.h:
        * dom/XMLDocumentParserLibxml2.cpp:
        (WebCore::XMLDocumentParser::supportsXMLVersion):
        * dom/XMLDocumentParserQt.cpp:
        (WebCore::XMLDocumentParser::supportsXMLVersion):
2010-08-24  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Tor Arne Vestbø.

        Disallow setting Document.xmlVersion to unsupported versions
        https://bugs.webkit.org/show_bug.cgi?id=44494

        Rebaselined tests (to expect success in 9/10 cases)
        documentsetxmlversion03.xhtml fails now (but legitimately.)

        * dom/xhtml/level3/core/canonicalform06-expected.txt:
        * dom/xhtml/level3/core/documentsetxmlversion01-expected.txt:
        * dom/xhtml/level3/core/documentsetxmlversion03-expected.txt:
        * dom/xhtml/level3/core/documentsetxmlversion05-expected.txt:
        * dom/xhtml/level3/core/infoset06-expected.txt:
        * dom/xhtml/level3/core/infoset07-expected.txt:
        * dom/xhtml/level3/core/wellformed01-expected.txt:
        * dom/xhtml/level3/core/wellformed02-expected.txt:
        * dom/xhtml/level3/core/wellformed03-expected.txt:
        * dom/xhtml/level3/core/wellformed04-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt][Symbian] Make sure WebKit headers are included before platform headers on Symbian
hausmann@webkit.org [Tue, 24 Aug 2010 08:51:39 +0000 (08:51 +0000)]
[Qt][Symbian] Make sure WebKit headers are included before platform headers on Symbian
https://bugs.webkit.org/show_bug.cgi?id=31273

Patch by Laszlo Gombos <laszlo.1.gombos@nokia.com> on 2010-08-24
Reviewed by Simon Hausmann.

On Symbian PREPEND_INCLUDEPATH is the best way to make sure that
WebKit headers are included before platform headers. On all other
platforms continue to use INCLUDEPATH (as before).

This patch also removed the workarounds that are put in place
now that we have a better solution.

No new tests as there is no new functionality.

* WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Support text-shadow blur
ariya@webkit.org [Tue, 24 Aug 2010 08:38:35 +0000 (08:38 +0000)]
[Qt] Support text-shadow blur
https://bugs.webkit.org/show_bug.cgi?id=19728

Patch by Ariya Hidayat <ariya@sencha.com> on 2010-08-24
Reviewed by Kenneth Rohde Christiansen.

Implement blur for text shadow using the shadow layer in r65782.

* platform/graphics/qt/ContextShadow.cpp:
(WebCore::ContextShadow::beginShadowLayer):
* platform/graphics/qt/FontQt.cpp:
(WebCore::drawTextCommon):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-24 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 24 Aug 2010 08:16:44 +0000 (08:16 +0000)]
2010-08-24  Adam Barth  <abarth@webkit.org>

        Update baselines for Tiger bot.  I'm not sure why these didn't turn up
        when running the tests locally.  The limits are slightly different in
        the new parser, so we'll need to adjust these tests.

        * fast/parser/block-nesting-cap-expected.txt:
        * fast/parser/block-nesting-cap-table-expected.txt:
        * fast/parser/element-nesting-cap-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-23 Andreas Kling <andreas.kling@nokia.com>
andreas.kling@nokia.com [Tue, 24 Aug 2010 08:15:16 +0000 (08:15 +0000)]
2010-08-23  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Tor Arne Vestbø.

        setAttributeNS() should throw NAMESPACE_ERR for prefixed qualifiedName with null namespace
        https://bugs.webkit.org/show_bug.cgi?id=44432

        Test: fast/dom/setAttributeNS-prefix-and-null-namespace.html

        * dom/Element.cpp:
        (WebCore::Element::setAttributeNS): Throw NAMESPACE_ERR if namespace is null
        and the qualifiedName has a prefix.
2010-08-24  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Tor Arne Vestbø and Nikolas Zimmermann.

        setAttributeNS() should throw NAMESPACE_ERR for prefixed qualifiedName with null namespace
        https://bugs.webkit.org/show_bug.cgi?id=44432

        - Added a test for the new behavior.
        - Rebaselined svg/custom/missing-xlink.svg

        * fast/dom/script-tests/setAttributeNS-prefix-and-null-namespace.js: Added.
        * fast/dom/setAttributeNS-prefix-and-null-namespace-expected.txt: Added.
        * fast/dom/setAttributeNS-prefix-and-null-namespace.html: Added.
        * platform/chromium-mac/svg/custom/missing-xlink-expected.txt:
        * platform/chromium-win/svg/custom/missing-xlink-expected.txt:
        * platform/mac-leopard/svg/custom/missing-xlink-expected.txt:
        * platform/mac/svg/custom/missing-xlink-expected.txt:
        * platform/win/svg/custom/missing-xlink-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-24 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 24 Aug 2010 07:58:07 +0000 (07:58 +0000)]
2010-08-24  Adam Barth  <abarth@webkit.org>

        Build fix.  leakPtr doesn't exist, contrary to my dreams.

        * storage/IDBKeyTree.h:
        (WebCore::::put):
        * storage/IDBPendingTransactionMonitor.cpp:
        (WebCore::IDBPendingTransactionMonitor::addPendingTransaction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-24 Roland Steiner <rolandsteiner@chromium.org>
rolandsteiner@chromium.org [Tue, 24 Aug 2010 07:46:13 +0000 (07:46 +0000)]
2010-08-24  Roland Steiner  <rolandsteiner@chromium.org>

        Unreviewed: upstreaming chromium test suppressions.

        Moving entries to LayoutTests/platform/chromium/test_expectations.txt

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-24 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 24 Aug 2010 07:34:52 +0000 (07:34 +0000)]
2010-08-24  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Deploy adoptPtr in WebCore/storage
        https://bugs.webkit.org/show_bug.cgi?id=44491

        There are still some naked news for a future patch.  The next step is
        to make create methods.

        * storage/Database.cpp:
        (WebCore::DatabaseCreationCallbackTask::create):
        (WebCore::DerefContextTask::create):
        (WebCore::DeliverPendingCallbackTask::create):
        * storage/DatabaseSync.cpp:
        (WebCore::CloseSyncDatabaseOnContextThreadTask::create):
        * storage/DatabaseTask.h:
        (WebCore::Database::DatabaseOpenTask::create):
        (WebCore::Database::DatabaseCloseTask::create):
        (WebCore::Database::DatabaseTransactionTask::create):
        (WebCore::Database::DatabaseTableNamesTask::create):
        * storage/DatabaseThread.cpp:
        (WebCore::DatabaseThread::DatabaseThread):
        * storage/DatabaseTracker.cpp:
        (WebCore::DatabaseTracker::populateOrigins):
        (WebCore::DatabaseTracker::addOpenDatabase):
        * storage/IDBKeyTree.h:
        (WebCore::::put):
        * storage/IDBPendingTransactionMonitor.cpp:
        (WebCore::IDBPendingTransactionMonitor::addPendingTransaction):
        * storage/LocalStorageTask.h:
        (WebCore::LocalStorageTask::createImport):
        (WebCore::LocalStorageTask::createSync):
        (WebCore::LocalStorageTask::createDeleteEmptyDatabase):
        (WebCore::LocalStorageTask::createTerminate):
        * storage/LocalStorageThread.cpp:
        (WebCore::LocalStorageThread::create):
        * storage/SQLTransaction.cpp:
        (WebCore::SQLTransaction::openTransactionAndPreflight):
        * storage/SQLTransactionSync.cpp:
        (WebCore::SQLTransactionSync::SQLTransactionSync):
        (WebCore::SQLTransactionSync::begin):
        * storage/StorageNamespaceImpl.cpp:
        (WebCore::StorageNamespaceImpl::copy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-24 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Tue, 24 Aug 2010 07:32:22 +0000 (07:32 +0000)]
2010-08-24  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        WebInspector: setAttachedWindow was modified at r65809 but it should be implemented another way.
        https://bugs.webkit.org/show_bug.cgi?id=44493

        * inspector/Inspector.idl:
        * inspector/InspectorController.cpp:
        * inspector/InspectorController.h:
        * inspector/InspectorFrontendClientLocal.cpp:
        (WebCore::InspectorFrontendClientLocal::setAttachedWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-24 Roland Steiner <rolandsteiner@chromium.org>
rolandsteiner@chromium.org [Tue, 24 Aug 2010 07:19:49 +0000 (07:19 +0000)]
2010-08-24  Roland Steiner  <rolandsteiner@chromium.org>

        Unreviewed build fix.

        put the "DISABLED_" in front of the right identifier.

        * tests/WebFrameTest.cpp:
        (WebKit::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-23 Eric Seidel <eric@webkit.org>
abarth@webkit.org [Tue, 24 Aug 2010 07:12:50 +0000 (07:12 +0000)]
2010-08-23  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Use new HTML5 TreeBuilder for fragment parsing
        https://bugs.webkit.org/show_bug.cgi?id=44475

        The HTML5 TreeBuilder is ready to be used for all parsing
        including fragments!  This is the last change to move trunk
        off of the LegacyHTMLTreeBuilder.  We'll go through and
        delete the thousands of lines of code supporting the old
        parser in a separate patch.

        This is covered by many layout tests.

        * html/HTMLTreeBuilder.cpp:
2010-08-23  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Use new HTML5 TreeBuilder for fragment parsing
        https://bugs.webkit.org/show_bug.cgi?id=44475

        The HTML5 TreeBuilder is ready to be used for all parsing
        including fragments!  This is the last change to move trunk
        off of the LegacyHTMLTreeBuilder.  We'll go through and
        delete the thousands of lines of code supporting the old
        parser in a separate patch.

        As far as we can tell, all of these are test progressions, see below.

        * editing/pasteboard/paste-noscript-svg-expected.txt: progression.
        * fast/forms/state-restore-to-non-edited-controls-expected.txt: matches minefield.
        * fast/innerHTML/innerHTML-changing-document-properties-expected.txt: new HTML5 exception code, progression.
        * fast/parser/fragment-parser-expected.txt: matches minefield.
        * fast/parser/p-in-scope-expected.txt: matches minefield.
        * fast/parser/p-in-scope-strict-expected.txt: matches minefield.
        * fast/parser/residual-style-close-across-n-blocks-expected.txt: matches minefield.
        * fast/table/incomplete-table-in-fragment-2-expected.txt: matches minefield.
        * fast/table/incomplete-table-in-fragment-hang-expected.txt: matches minefield.
        * html5lib/runner-expected.txt: progression!
        * http/tests/security/xssAuditor/dom-write-innerHTML-expected.txt: Adam will fix this separately.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-23 Roland Steiner <rolandsteiner@chromium.org>
rolandsteiner@chromium.org [Tue, 24 Aug 2010 07:06:18 +0000 (07:06 +0000)]
2010-08-23  Roland Steiner  <rolandsteiner@chromium.org>

        Reviewed by Tamura Kent.

        Disable failing test
        https://bugs.webkit.org/show_bug.cgi?id=44492

        * tests/WebFrameTest.cpp:
        (WebKit::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[WINCE] Buildfix for GeneratedJITStubs after r64818
loki@webkit.org [Tue, 24 Aug 2010 06:54:40 +0000 (06:54 +0000)]
[WINCE] Buildfix for GeneratedJITStubs after r64818
https://bugs.webkit.org/show_bug.cgi?id=44469

Patch by Patrick Gansterer <paroga@paroga.com> on 2010-08-23
Rubber-stamped by Gabor Loki.

Use " THUNK_RETURN_ADDRESS_OFFSET" instead of "#offset#".

* jit/JITStubs.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-23 Hironori Bono <hbono@chromium.org>
commit-queue@webkit.org [Tue, 24 Aug 2010 05:14:50 +0000 (05:14 +0000)]
2010-08-23  Hironori Bono  <hbono@chromium.org>

        Reviewed by Kent Tamura.

        Removes the rebaselined results for special-key-events-in-input-text.html
        because my test_shell change fixes it and produces the expected output.
        https://bugs.webkit.org/show_bug.cgi?id=44156

        * platform/chromium-mac/fast/events/special-key-events-in-input-text-expected.txt: Removed.
        * platform/chromium-win/fast/events/special-key-events-in-input-text-expected.txt: Removed.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-23 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 24 Aug 2010 04:20:29 +0000 (04:20 +0000)]
2010-08-23  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        HTMLScriptRunner::create
        https://bugs.webkit.org/show_bug.cgi?id=44474

        * html/HTMLDocumentParser.cpp:
        (WebCore::HTMLDocumentParser::HTMLDocumentParser):
        * html/HTMLScriptRunner.h:
        (WebCore::HTMLScriptRunner::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-23 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 24 Aug 2010 04:01:42 +0000 (04:01 +0000)]
2010-08-23  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        HTMLTreeBuilder should use adoptPtr
        https://bugs.webkit.org/show_bug.cgi?id=44473

        We should really use this pattern everywhere.

        * html/HTMLDocumentParser.cpp:
        (WebCore::HTMLDocumentParser::HTMLDocumentParser):
        * html/HTMLTreeBuilder.h:
        (WebCore::HTMLTreeBuilder::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-23 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Tue, 24 Aug 2010 03:51:26 +0000 (03:51 +0000)]
2010-08-23  Martin Robinson  <mrobinson@igalia.com>

        Skip another test which shows one pixel differences between the 32-bit and 64-bit bot.

        * platform/gtk/Skipped: Skip newly failing test.
        * platform/gtk/svg/custom/recursive-filter-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd tests to the Skipped list.
jhoneycutt@apple.com [Tue, 24 Aug 2010 03:49:51 +0000 (03:49 +0000)]
Add tests to the Skipped list.

Rubber-stamped by Brady Eidson.

* platform/mac-wk2/Skipped:
* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-23 Jay Civelli <jcivelli@chromium.org>
jcivelli@chromium.org [Tue, 24 Aug 2010 03:43:08 +0000 (03:43 +0000)]
2010-08-23  Jay Civelli  <jcivelli@chromium.org>

        Reviewed by Darin Fisher.

        Made WebFrame not report the text from hidden frames.
        (some pages contain hidden frames with garbage text that
        should not be indexed or used to detect the page's language).
        https://bugs.webkit.org/show_bug.cgi?id=39456

        * WebKit.gyp:
        * public/WebCString.h:
        (WebKit::operator<):
        * public/WebURL.h:
        (WebKit::operator<):
        * src/WebCString.cpp:
        (WebKit::WebCString::compare):
        * src/WebFrameImpl.cpp:
        (WebKit::frameContentAsPlainText):
        * tests/RunAllTests.cpp:
        (main):
        * tests/WebFrameTest.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-23 Patrick Gansterer <paroga@paroga.com>
commit-queue@webkit.org [Tue, 24 Aug 2010 03:25:48 +0000 (03:25 +0000)]
2010-08-23  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Adam Roben.

        Set the ResourceResponse HTTP headers in RessourceHandleWin
        https://bugs.webkit.org/show_bug.cgi?id=44444

        * platform/network/win/ResourceHandleWin.cpp:
        (WebCore::queryHTTPHeader):
        (WebCore::ResourceHandle::onRequestComplete):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed, removing a Chromium-specific expectation.
dumi@chromium.org [Tue, 24 Aug 2010 03:24:33 +0000 (03:24 +0000)]
Unreviewed, removing a Chromium-specific expectation.

* platform/chromium-win/editing/execCommand/insert-list-xml-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-23 Patrick Gansterer <paroga@paroga.com>
commit-queue@webkit.org [Tue, 24 Aug 2010 03:04:18 +0000 (03:04 +0000)]
2010-08-23  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Adam Roben.

        Support all available biBitCount values in BitmapInfo
        https://bugs.webkit.org/show_bug.cgi?id=43724

        Add an enum with all possible values for biBitCount.
        Also remove explicit initialization of bmiHeader members,
        because that is already done in the constructor.

        * platform/win/BitmapInfo.cpp: Added property svn:eol-style.
        (WebCore::bitmapInfoForSize):
        (WebCore::BitmapInfo::create):
        (WebCore::BitmapInfo::createBottomUp):
        * platform/win/BitmapInfo.h: Added property svn:eol-style.
        (WebCore::BitmapInfo::):
        (WebCore::BitmapInfo::bytesPerLine):
        (WebCore::BitmapInfo::paddedBytesPerLine):
        (WebCore::BitmapInfo::paddedWidth):
        * platform/win/PopupMenuWin.cpp:
        (WebCore::PopupMenuWin::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-23 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Tue, 24 Aug 2010 02:30:50 +0000 (02:30 +0000)]
2010-08-23  Kent Tamura  <tkent@chromium.org>

        Unreviewed, build fix for r65852.

        * rendering/RenderTextControlSingleLine.cpp:
        (WebCore::RenderTextControlSingleLine::createSubtreeIfNeeded):
        * rendering/TextControlInnerElements.cpp:
        (WebCore::InputFieldSpeechButtonElement::InputFieldSpeechButtonElement):
        (WebCore::InputFieldSpeechButtonElement::create):
        * rendering/TextControlInnerElements.h:
2010-08-23  Kent Tamura  <tkent@chromium.org>

        Unreviewed, build fix for r65852.

        * src/WebNode.cpp:
        (WebKit::WebNode::parentNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-23 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Tue, 24 Aug 2010 02:26:35 +0000 (02:26 +0000)]
2010-08-23  Martin Robinson  <mrobinson@igalia.com>

        Rebaseline new tests and skip tests which produce incorrect output.

        * platform/gtk/Skipped:
        * platform/gtk/fast/canvas/setWidthResetAfterForcedRender-expected.txt: Added.
        * platform/gtk/fast/repaint/multicol-repaint-expected.txt: Added.
        * platform/gtk/fast/repaint/view-background-from-body-1-expected.txt: Copied from LayoutTests/platform/mac/fast/repaint/view-background-from-body-1-expected.txt.
        * platform/gtk/fast/repaint/view-background-from-body-2-expected.txt: Copied from LayoutTests/platform/mac/fast/repaint/view-background-from-body-2-expected.txt.
        * platform/gtk/http/tests/misc/slow-loading-image-in-pattern-expected.txt: Added.
        * platform/gtk/mathml/presentation/attributes-expected.txt: Added.
        * platform/gtk/mathml/presentation/fenced-expected.txt: Added.
        * platform/gtk/mathml/presentation/fractions-expected.txt: Added.
        * platform/gtk/mathml/presentation/fractions-vertical-alignment-expected.txt: Added.
        * platform/gtk/mathml/presentation/mo-expected.txt: Added.
        * platform/gtk/mathml/presentation/over-expected.txt: Added.
        * platform/gtk/mathml/presentation/roots-expected.txt: Added.
        * platform/gtk/mathml/presentation/row-alignment-expected.txt: Added.
        * platform/gtk/mathml/presentation/row-expected.txt: Added.
        * platform/gtk/mathml/presentation/style-expected.txt: Added.
        * platform/gtk/mathml/presentation/subsup-expected.txt: Added.
        * platform/gtk/mathml/presentation/tokenElements-expected.txt: Added.
        * platform/gtk/mathml/presentation/under-expected.txt: Added.
        * platform/gtk/mathml/presentation/underover-expected.txt: Added.
        * platform/gtk/svg/batik/paints/patternRegions-positioned-objects-expected.txt: Added.
        * platform/gtk/svg/custom/convolution-crash-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/convolution-crash-expected.txt.
        * platform/gtk/svg/custom/marker-empty-path-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/marker-empty-path-expected.txt.
        * platform/gtk/svg/custom/path-zero-strokewidth-expected.txt: Added.
        * platform/gtk/svg/custom/pattern-incorrect-tiling-expected.txt: Added.
        * platform/gtk/svg/custom/pattern-no-pixelation-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/pattern-no-pixelation-expected.txt.
        * platform/gtk/svg/custom/recursive-filter-expected.txt: Added.
        * platform/gtk/svg/custom/recursive-gradient-expected.txt: Added.
        * platform/gtk/svg/custom/recursive-mask-expected.txt: Added.
        * platform/gtk/svg/custom/recursive-pattern-expected.txt: Added.
        * platform/gtk/svg/custom/relative-sized-content-with-resources-expected.txt: Added.
        * platform/gtk/svg/custom/svg-fonts-without-missing-glyph-expected.txt: Added.
        * platform/gtk/svg/filters/filter-empty-g-expected.txt: Copied from LayoutTests/platform/mac/svg/filters/filter-empty-g-expected.txt.
        * platform/gtk/svg/in-html/circle-expected.txt: Added.
        * platform/gtk/svg/zoom/page/zoom-mask-with-percentages-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-23 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Tue, 24 Aug 2010 02:14:02 +0000 (02:14 +0000)]
2010-08-23  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        MarkupAccumulator::appendStartMarkup should be broken down into pieces
        https://bugs.webkit.org/show_bug.cgi?id=44288

        Extracted appendText, appendComment, appendProcessingInstruction, appendElement and appendCDATASection.
        Also simplified the conditionals in appendText.

        No new tests are added since this is a cleanup.

        * editing/markup.cpp:
        (WebCore::MarkupAccumulator::appendText):
        (WebCore::MarkupAccumulator::appendComment):
        (WebCore::MarkupAccumulator::appendProcessingInstruction):
        (WebCore::MarkupAccumulator::appendElement):
        (WebCore::MarkupAccumulator::appendCDATASection):
        (WebCore::MarkupAccumulator::appendStartMarkup):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-23 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 24 Aug 2010 01:49:04 +0000 (01:49 +0000)]
2010-08-23  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Alexey Proskuryakov.

        TreeWalker is not calling acceptNode function in filter object
        https://bugs.webkit.org/show_bug.cgi?id=35296

        Fix incorrect shadowing of the 'function' variable, which could result
        in badness when asking for arguments.callee.

        * bindings/js/JSNodeFilterCondition.cpp:
        (WebCore::JSNodeFilterCondition::acceptNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore: Changed type of Node::parentNode to ContainerNode so we don't have to cast,
darin@apple.com [Tue, 24 Aug 2010 01:39:08 +0000 (01:39 +0000)]
WebCore: Changed type of Node::parentNode to ContainerNode so we don't have to cast,
since parent are all containers.

Reviewed by Geoff Garen.

* css/CSSStyleSelector.h: Changed m_parentNode to ContainerNode*.

* dom/Document.h: Fixed the type of TreeShared in the Node constructor.
Yes, it's here.

* dom/Node.cpp:
(WebCore::Node::eventParentNode): Removed now-unneeded typecast dance.
(WebCore::eventTargetAsSVGElementInstance):Changed type to ContainerNode*.

* dom/Node.h: Made Node inherit from TreeShared<ContainerNode> instead of
from TreeShared<Node>. Removed bogus comment. Changed return type of parentNode
and shadowParentNode functions to ContainerNode*. Fixed using to use
TreeShared<ContainerNode>.

* dom/Position.h: Include ContainerNode.h instead of Node.h.

* html/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::findFosterSite): Removed now-unneeded typecast.

* rendering/MediaControlElements.h:
* rendering/SVGShadowTreeElements.h:
* rendering/TextControlInnerElements.h:
Changed return type of shadowParentNode functions to ContainerNode.

* rendering/RenderMeter.cpp:
(WebCore::RenderMeter::updatePartsState): Cast the node to HTMLElement* before
passing it to the function that creates the shadow element. We know the node is
a HTMLMeterElement, but the node function doesn't know that.
* rendering/RenderProgress.cpp:
(WebCore::RenderProgress::updatePartsState): Ditto.
* rendering/RenderSlider.cpp:
(WebCore::SliderThumbElement::SliderThumbElement): More of the same.
(WebCore::SliderThumbElement::create): Ditto.
(WebCore::RenderSlider::updateFromElement): Ditto.
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::createSubtreeIfNeeded): Ditto.
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::createSubtreeIfNeeded): Ditto.
* rendering/SVGShadowTreeElements.cpp:
(WebCore::SVGShadowTreeRootElement::SVGShadowTreeRootElement): Ditto.
(WebCore::SVGShadowTreeRootElement::shadowParentNode): Ditto.
* rendering/ShadowElement.cpp:
(WebCore::ShadowBlockElement::create): Ditto.
(WebCore::ShadowBlockElement::ShadowBlockElement): Ditto.
(WebCore::ShadowBlockElement::createForPart): Ditto.
(WebCore::ShadowInputElement::create): Ditto.
(WebCore::ShadowInputElement::ShadowInputElement): Ditto.
* rendering/ShadowElement.h:
(WebCore::ShadowElement::ShadowElement): Ditto.
(WebCore::ShadowElement::shadowParent): Ditto.
(WebCore::ShadowElement::shadowParentNode): Ditto.
* rendering/TextControlInnerElements.cpp:
(WebCore::TextControlInnerElement::TextControlInnerElement): Ditto.
(WebCore::TextControlInnerElement::create): Ditto.
(WebCore::TextControlInnerTextElement::TextControlInnerTextElement): Ditto.
(WebCore::TextControlInnerTextElement::create): Ditto.
(WebCore::SpinButtonElement::SpinButtonElement): Ditto.
(WebCore::SpinButtonElement::create): Ditto.

* svg/SVGElement.cpp:
(WebCore::SVGElement::eventParentNode): Removed now-unneeded typecast.

* svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::title): Changed type to ContainerNode*.

WebKit2: * WebProcess/InjectedBundle/API/c/WKBundleNode.cpp:
(WKBundleNodeGetParent): Update since parent now returns a
ContainerNode*. The toRef function is a bit too picky to convert
it without a bit of help.

Reviewed by Geoff Garen.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-23 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Tue, 24 Aug 2010 01:25:37 +0000 (01:25 +0000)]
2010-08-23  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] The Mozilla theme drawing code incorrectly renders scrollbar backgrounds
        https://bugs.webkit.org/show_bug.cgi?id=44388

        No new tests as this functionality is currently unused. When the
        the new scrollbar theme code lands for GTK+, this will be tested
        by scrollbar pixel tests.

        * platform/gtk/gtk2drawing.c: Expose a method to paint scrolled window
        backgrounds and disable incorrect rendering of scrollbar trough backgrounds.
        (moz_gtk_scrolled_window_paint): Added.
        (moz_gtk_scrollbar_trough_paint): Disable incorrect background render.
        * platform/gtk/gtkdrawing.h: Add scrolled window widget type in the enum.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-23 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Tue, 24 Aug 2010 01:23:51 +0000 (01:23 +0000)]
2010-08-23  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] The Mozilla theme drawing API should expose extra information about scrollbar geometry
        https://bugs.webkit.org/show_bug.cgi?id=44385

        Expose the trough_under_steppers property in MozGtkScrollbarMetrics.

        No new tests as this does not change functionality.

        * platform/gtk/gtk2drawing.c: Set the trough_under_steppers member when accessing theme data.
        * platform/gtk/gtkdrawing.h: Add the trough_under_steppers member.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoParser DOM tree manipulation functions do not need to be virtual.
darin@apple.com [Tue, 24 Aug 2010 00:44:03 +0000 (00:44 +0000)]
Parser DOM tree manipulation functions do not need to be virtual.

Reviewed by Geoff Garen.

* dom/ContainerNode.h: Made parserAddChild, parserRemoveChild, and
parserInsertBefore non-virtual.

* dom/Node.cpp: Removed the parserAddChild, parserRemoveChild, and
parserInsertBefore functions, which should never have been in the Node class.
* dom/Node.h: Ditto.

* html/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::attach): Changed argument type to ContainerNode*
because we never need to attach a child to a non-container node.
(WebCore::HTMLConstructionSite::findFosterSite): Cast the result of the parent
function to ContainerNode*. A parent is always guaranteed to be a container, but
the parent function returns a Node* so that callers can use it without including
ContainerNode's header. That seems like something we can easily fix later.

* html/HTMLConstructionSite.h: Changed AttachmentSite::parent and the
attach function to ContainerNode* instead of Node*.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-23 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 24 Aug 2010 00:29:39 +0000 (00:29 +0000)]
2010-08-23  Adam Barth  <abarth@webkit.org>

        Update the expected results for this test.  I think the new expected
        results are better than the old ones, but we'll check with some editing
        folks to be sure.

        * editing/execCommand/insert-list-xml-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-23 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Tue, 24 Aug 2010 00:04:01 +0000 (00:04 +0000)]
2010-08-23  Oliver Hunt  <oliver@apple.com>

        Reviewed by Darin Adler.

        [REGRESSION] Interpreter incorrectly excludes prototype chain when validating put_by_id_transition
        https://bugs.webkit.org/show_bug.cgi?id=44240
        <rdar://problem/8328995>

        Fix an error I introduced when cleaning up the interpreter side of the logic
        to prevent setters being called in object initialisers.

        * interpreter/Interpreter.cpp:
        (JSC::Interpreter::privateExecute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed, updating Chromium expectations.
dumi@chromium.org [Mon, 23 Aug 2010 23:55:13 +0000 (23:55 +0000)]
Unreviewed, updating Chromium expectations.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-23 Adam Barth <abarth@webkit.org>
eric@webkit.org [Mon, 23 Aug 2010 23:52:34 +0000 (23:52 +0000)]
2010-08-23  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        editing/pasteboard/bad-placeholder.html fails with --html5-treebuilder
        https://bugs.webkit.org/show_bug.cgi?id=44463

        The problem here is that using the documentElement as the context puts
        the tree builder into the BeforeHead insertion mode, which strips
        leading spaces.  This code is confused about what it wants, but it
        certainly doesn't want to be in that insertion mode.  Looking through
        the callers, they'd much rather be in the InBody insertion mode.  We
        can get them there by creating a fake body element as the context
        element.

        In the long term, all this code needs to be changed to move away from
        deprecatedCreateContextualFragment, which does a bunch of nasty stuff
        like removing certain kinds of elements.  However, that's a battle for
        another day.

        * editing/markup.cpp:
        (WebCore::createFragmentFromMarkup):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-23 Adam Barth <abarth@webkit.org>
eric@webkit.org [Mon, 23 Aug 2010 23:49:09 +0000 (23:49 +0000)]
2010-08-23  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        fast/xsl/default-html.html fails with HTML5 fragment parsing
        https://bugs.webkit.org/show_bug.cgi?id=44450

        This patch is a step down a trail of tears.  As far as I can tell,
        there's no spec for XSLTProcessor.transformToFragment.  This patch
        attempts to infer the proper behavior from test cases and the Mozilla
        wiki.

        * xml/XSLTProcessor.cpp:
        (WebCore::createFragmentFromSource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-23 Adam Barth <abarth@webkit.org>
eric@webkit.org [Mon, 23 Aug 2010 23:48:38 +0000 (23:48 +0000)]
2010-08-23  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        editing/pasteboard/paste-visible-script.html is broken with --html5-treebuilder
        https://bugs.webkit.org/show_bug.cgi?id=44457

        Turns out there are two more checks we need for fragment scripting
        permission.  Not the most beautiful design, but it seems work.

        * html/HTMLConstructionSite.cpp:
        (WebCore::HTMLConstructionSite::insertScriptElement):
        * html/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::processEndTag):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-23 Eric Seidel <eric@webkit.org>
eric@webkit.org [Mon, 23 Aug 2010 23:44:10 +0000 (23:44 +0000)]
2010-08-23  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        fast/dom/script-innerHTML-x.xhtml fails when run with the HTML5 TreeBuilder in fragment mode
        https://bugs.webkit.org/show_bug.cgi?id=44447

        This special handling for script/style used to exist in
        setInnerHTML.  HTML5 moves this logic into the HTML and XML
        parsers instead of in setInnerHTML.

        In order to share this logic between WebKit's two XML parsers
        I had to clean up a bit of the libxml2 parser and add a
        new appendFragmentSource method.

        Covered by fast/dom/script-innerHTML-x.xhtml.

        * dom/XMLDocumentParser.cpp:
        (WebCore::XMLDocumentParser::end):
         - Now that libxml2 is calling finish() for fragments (Qt already was)
           I went through and removed this unneeded style update after fragment parsing.
        (WebCore::XMLDocumentParser::parseDocumentFragment):
         - Yay for shared code!
         - This is where I added the style/script hack moved from setInnerHTML.
        * dom/XMLDocumentParser.h:
         - Fix indent.
        * dom/XMLDocumentParserLibxml2.cpp:
         - Removed parseDocumentFragment and moved necessary libxml-specific
           logic into appendFragmentSource.
        (WebCore::XMLDocumentParser::appendFragmentSource):
        * dom/XMLDocumentParserQt.cpp:
        (WebCore::XMLDocumentParser::appendFragmentSource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-23 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Mon, 23 Aug 2010 23:32:09 +0000 (23:32 +0000)]
2010-08-23  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] The 64-bit Release bot is showing crashes on tests that use mouse buttons
        https://bugs.webkit.org/show_bug.cgi?id=44465

        Initialize the axes field of mouse button and motion events to null.
        This is the value that should be used for events originating from the
        mouse device.

        * DumpRenderTree/gtk/EventSender.cpp:
        (prepareMouseButtonEvent): Initalize button event axes field to null.
        (mouseMoveToCallback): Initialize motion event axes field to null.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-23 Michael Saboff <msaboff@apple.com>
commit-queue@webkit.org [Mon, 23 Aug 2010 23:12:46 +0000 (23:12 +0000)]
2010-08-23  Michael Saboff  <msaboff@apple.com>

        Reviewed by Oliver Hunt.

        Fixed case where a single character search string in a string.replace()
        did not properly handle back reference replacement.  The fix is to
        check for a '$' as part of the check to see if we can execute the
        single character replace optimization.
        https://bugs.webkit.org/show_bug.cgi?id=44067

        * runtime/StringPrototype.cpp:
        (JSC::stringProtoFuncReplace):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-23 Kenneth Russell <kbr@google.com>
kbr@google.com [Mon, 23 Aug 2010 23:07:16 +0000 (23:07 +0000)]
2010-08-23  Kenneth Russell  <kbr@google.com>

        Reviewed by Dimitri Glazkov.

        Remove references to ArrayBuffer and ArrayBufferView from GraphicsContext3D
        https://bugs.webkit.org/show_bug.cgi?id=44455

        Updated Safari, Qt and Chromium WebGL ports to avoid referencing
        ArrayBuffer and ArrayBufferView types from GraphicsContext3D.

        Ran all WebGL layout tests; no new regressions. Built and tested
        WebKit on Mac OS X; built Chromium on Mac OS X and Linux.

        * src/GraphicsContext3D.cpp:
        (WebCore::GraphicsContext3DInternal::bufferData):
        (WebCore::GraphicsContext3DInternal::bufferSubData):
2010-08-23  Kenneth Russell  <kbr@google.com>

        Reviewed by Dimitri Glazkov.

        Remove references to ArrayBuffer and ArrayBufferView from GraphicsContext3D
        https://bugs.webkit.org/show_bug.cgi?id=44455

        Updated Safari, Qt and Chromium WebGL ports to avoid referencing
        ArrayBuffer and ArrayBufferView types from GraphicsContext3D.

        Ran all WebGL layout tests; no new regressions. Built and tested
        WebKit on Mac OS X; built Chromium on Mac OS X and Linux.

        * html/canvas/WebGLBuffer.cpp:
        * html/canvas/WebGLBuffer.h:
        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::bufferData):
        (WebCore::WebGLRenderingContext::bufferSubData):
        (WebCore::WebGLRenderingContext::texImage2D):
        (WebCore::WebGLRenderingContext::texSubImage2D):
        (WebCore::WebGLRenderingContext::simulateVertexAttrib0):
        * platform/graphics/GraphicsContext3D.cpp:
        (WebCore::GraphicsContext3D::extractTextureData):
        * platform/graphics/GraphicsContext3D.h:
        * platform/graphics/chromium/GLES2Canvas.cpp:
        (WebCore::GLES2Canvas::getQuadVertices):
        * platform/graphics/mac/GraphicsContext3DMac.mm:
        (WebCore::GraphicsContext3D::bufferData):
        (WebCore::GraphicsContext3D::bufferSubData):
        * platform/graphics/qt/GraphicsContext3DQt.cpp:
        (WebCore::GraphicsContext3D::bufferData):
        (WebCore::GraphicsContext3D::bufferSubData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-23 Sheriff Bot <webkit.review.bot@gmail.com>
eric@webkit.org [Mon, 23 Aug 2010 22:59:51 +0000 (22:59 +0000)]
2010-08-23  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r65703.
        http://trac.webkit.org/changeset/65703
        https://bugs.webkit.org/show_bug.cgi?id=44460

        "Causing lots of crashes on Snow Leopard when running the
        layout tests" (Requested by eseidel2 on #webkit).

        * WebProcess/Plugins/Netscape/NetscapePluginModule.cpp:
        (WebKit::NetscapePluginModule::tryLoad):
2010-08-23  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r65703.
        http://trac.webkit.org/changeset/65703
        https://bugs.webkit.org/show_bug.cgi?id=44460

        "Causing lots of crashes on Snow Leopard when running the
        layout tests" (Requested by eseidel2 on #webkit).

        * DumpRenderTree/TestNetscapePlugIn/main.cpp:
        (NP_Initialize):
        (NP_GetEntryPoints):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed, updating some Chromium expectations.
dumi@chromium.org [Mon, 23 Aug 2010 22:30:16 +0000 (22:30 +0000)]
Unreviewed, updating some Chromium expectations.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-20 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Mon, 23 Aug 2010 22:23:42 +0000 (22:23 +0000)]
2010-08-20  Stephen White  <senorblanco@chromium.org>

        Reviewed by Kenneth Russell.

        [CHROMIUM] Fix some failing layout tests w/ACCELERATED_2D_CANVAS
        https://bugs.webkit.org/show_bug.cgi?id=44346

        LayoutTests/fast/canvas/canvas-incremental-repaint.html (top middle
        pane).
        Failing because we were not applying the CTM in clearRect().  Now using
        the fast path when the CTM is identity, and a fillRect() for the rest.
        LayoutTests/fast/canvas/canvas-strokeRect.html
        LayoutTests/fast/canvas/shadow-offset-[1-7].html
        Failing because we weren't switching to the software path when a
        shadow is present.
        Also refactor the two versions of fillRect(), and use TRIANGLE_STRIP
        strip instead of TRIANGLES, which lets us get rid of the element array
        and use drawArrays() instead of drawElements().

        Covered by the above layout tests.

        * platform/graphics/chromium/GLES2Canvas.cpp:
        (WebCore::GLES2Canvas::GLES2Canvas):
        (WebCore::GLES2Canvas::~GLES2Canvas):
        Remove m_quadIndices (now unused).
        (WebCore::GLES2Canvas::clearRect):
        Use a glClear() fast path for the identity-CTM clear, and fillRect()
        for the rest.
        (WebCore::GLES2Canvas::fillRect):
        Refactor the two versions of fillRect().
        (WebCore::GLES2Canvas::drawTexturedRect):
        (WebCore::GLES2Canvas::drawTexturedRectTile):
        Get rid of the ELEMENT_ARRAY_BUFFER bind.  Use drawArrays() instead of
        drawElements().
        (WebCore::GLES2Canvas::getQuadVertices):
        Re-order the vertices so they form a triangle strip.
        * platform/graphics/chromium/GLES2Canvas.h:
        Remove m_quadIndices (now unused).
        * platform/graphics/skia/GraphicsContextSkia.cpp:
        (WebCore::GraphicsContext::fillRect):
        Check for a draw looper (shadow), and drop to the software path.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-23 Patrick Gansterer <paroga@paroga.com>
commit-queue@webkit.org [Mon, 23 Aug 2010 22:12:03 +0000 (22:12 +0000)]
2010-08-23  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Adam Roben.

        Move filehandling into fileLoadTimer callback
        https://bugs.webkit.org/show_bug.cgi?id=43714

        Also add mimetype detection for local files.

        * platform/network/ResourceHandleInternal.h:
        (WebCore::ResourceHandleInternal::ResourceHandleInternal):
        * platform/network/win/ResourceHandleWin.cpp:
        (WebCore::ResourceHandle::start):
        (WebCore::ResourceHandle::fileLoadTimer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-23 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Mon, 23 Aug 2010 21:59:00 +0000 (21:59 +0000)]
2010-08-23  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        JSON.stringify is much slower than Firefox on particular pathological input
        https://bugs.webkit.org/show_bug.cgi?id=44456

        Make StringBuilder::reserveCapacity reserve additional space so we don't end up
        repeatedly copying the entire result string.

        * runtime/StringBuilder.h:
        (JSC::StringBuilder::append):
        (JSC::StringBuilder::reserveCapacity):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-23 Iain Merrick <husky@google.com>
commit-queue@webkit.org [Mon, 23 Aug 2010 21:52:03 +0000 (21:52 +0000)]
2010-08-23  Iain Merrick  <husky@google.com>

        Reviewed by Steve Block.

        Update JNI bridge for V8 after renaming of JavaString::utf8().
        https://bugs.webkit.org/show_bug.cgi?id=44419

        This fixes the build on Android. No new functionality, so no new tests.

        * bridge/jni/v8/JNIBridgeV8.cpp:
        (JavaField::JavaField):
        * bridge/jni/v8/JNIBridgeV8.h:
        (JSC::Bindings::JavaField::type):
        * bridge/jni/v8/JavaClassV8.cpp:
        (JavaClass::JavaClass):
        * bridge/jni/v8/JavaNPObjectV8.cpp:
        (JSC::Bindings::JavaNPObjectGetProperty):
        * bridge/jni/v8/JavaStringV8.h:
        (JSC::Bindings::JavaStringImpl::utf8):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-23 Mihai Parparita <mihaip@chromium.org>
commit-queue@webkit.org [Mon, 23 Aug 2010 21:31:11 +0000 (21:31 +0000)]
2010-08-23  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by David Hyatt.

        Assertion failure in FrameView::layout when modifying the DOM during
        pagehide with PageCache enabled
        https://bugs.webkit.org/show_bug.cgi?id=43152

        Always unschedule any pending relayouts when changing the view, not just
        when we're not using the page cache. Otherwise touching the DOM during
        the pagehide handler can lead to layouts that will be done by the time
        the view has changed, which triggers an assert.

        * fast/loader/resources/unschedule-relayout-after-unload-target.html: Added.
        * fast/loader/unschedule-relayout-after-unload-expected.txt: Added.
        * fast/loader/unschedule-relayout-after-unload.html: Added.
2010-08-23  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by David Hyatt.

        Assertion failure in FrameView::layout when modifying the DOM during
        pagehide with PageCache enabled
        https://bugs.webkit.org/show_bug.cgi?id=43152

        Always unschedule any pending relayouts when changing the view, not just
        when we're not using the page cache. Otherwise touching the DOM during
        the pagehide handler can lead to layouts that will be done by the time
        the view has changed, which triggers an assert.

        Test: fast/loader/unschedule-relayout-after-unload.html

        * page/Frame.cpp:
        (WebCore::Frame::setView): move unscheduleRelayout outside page cache
        check.
        * page/FrameView.cpp:
        (WebCore::FrameView::layout): remove early return now that assert
        should be correct (and the referenced rdar:// got fixed).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoLayout tests do not run when using WebKitTestRunner in a Debug build.
jhoneycutt@apple.com [Mon, 23 Aug 2010 21:29:42 +0000 (21:29 +0000)]
Layout tests do not run when using WebKitTestRunner in a Debug build.
https://bugs.webkit.org/show_bug.cgi?id=44409

Reviewed by Dan Bernstein.

WebKit2:

* UIProcess/Launcher/win/ProcessLauncherWin.cpp:
(WebKit::ProcessLauncher::launchProcess):
Use WebKit2WebProcess_debug.exe when building Debug.

WebKitTools:

* WebKitTestRunner/win/TestControllerWin.cpp:
(WTR::TestController::initializeInjectedBundlePath):
Use InjectedBundle_debug.dll when building Debug.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd more tests to the WebKit2 skipped lists.
jhoneycutt@apple.com [Mon, 23 Aug 2010 21:27:11 +0000 (21:27 +0000)]
Add more tests to the WebKit2 skipped lists.

Rubber-stamped by Mark Rowe.

* platform/mac-wk2/Skipped:
* platform/win-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-23 Sheriff Bot <webkit.review.bot@gmail.com>
jamesr@google.com [Mon, 23 Aug 2010 20:43:40 +0000 (20:43 +0000)]
2010-08-23  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r65812.
        http://trac.webkit.org/changeset/65812
        https://bugs.webkit.org/show_bug.cgi?id=44451

        Broke fast/events/special-key-events-in-input-text.html for
        chromium (Requested by jamesr on #webkit).

        * platform/chromium-mac/fast/events/special-key-events-in-input-text-expected.txt: Added.
        * platform/chromium-win/fast/events/special-key-events-in-input-text-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-19 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Mon, 23 Aug 2010 20:20:23 +0000 (20:20 +0000)]
2010-08-19  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Tony Chang.

        There is no test for unicode-bidi / direction support in ApplyStyleCommand::applyInlineStyle
        https://bugs.webkit.org/show_bug.cgi?id=43989

        Added a test for MakeTextWritingDirectionNatural, MakeTextWritingDirectionLeftToRight,
        and MakeTextWritingDirectionRightToLeft commands.

        * editing/style/make-text-writing-direction-inline.html: Added.
        * editing/style/script-tests/make-text-writing-direction-inline.js: Added.
        (modifyWritingDirection):
        (selectFirstWord):
        (selectSecondAndThirdWords):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoHandle blob resource.
jianli@chromium.org [Mon, 23 Aug 2010 20:09:56 +0000 (20:09 +0000)]
Handle blob resource.
https://bugs.webkit.org/show_bug.cgi?id=43941

Reviewed by Darin Fisher.

JavaScriptCore:

* JavaScriptCore.exp: Add an export that is neede by BlobResourceHandle.

WebCore:

To provide lower level blob reosurce handling for all possible ports,
BlobResourceHandle derived from ResourceHandle is implemented. It provides
both synchronous and asynchronous resource loading for blob URL.

BlobResourceHandle needs to create a FileStreamProxy instance in order to
asynchronous file stream operation. To achive this, a hook createAsyncFileStream
is added to ResourceHandleClient interface. When ResourceLoader implements
ths hook, it creates and returns FileStreamProxy.

BlobResourceHandle.* is not added to chromium port since it will implement
its own blob resource handling.

* Android.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::createAsyncFileStream): Create and return FileStreamProxy.
* loader/ResourceLoader.h:
* page/SecurityOrigin.cpp: Add the support to get and validate the origin of blob URL.
(WebCore::SecurityOrigin::create):
(WebCore::SecurityOrigin::canLoad):
* platform/network/BlobRegistryImpl.cpp:
(WebCore::BlobRegistryImpl::appendStorageItems): Fix a bug that the length is not subtracted.
* platform/network/BlobResourceHandle.cpp: Added.
* platform/network/BlobResourceHandle.h: Added.
* platform/network/HTTPParsers.cpp:
(WebCore::parseRange):
* platform/network/HTTPParsers.h:
* platform/network/ResourceHandle.cpp: Hook up with asynchronous blob resource handling.
(WebCore::ResourceHandle::create):
* platform/network/ResourceHandle.h:
* platform/network/ResourceHandleClient.h:
(WebCore::ResourceHandleClient::createAsyncFileStream): Add a hook.
* platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::loadResourceSynchronously): Hook up with synchronous blob resource handling.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-23 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Mon, 23 Aug 2010 20:03:36 +0000 (20:03 +0000)]
2010-08-23  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Dimitri Glazkov.

        Fix security origin calculation in createPattern. Need to use
        cachedImage->response().url() instead of cachedImage->url().
        https://bugs.webkit.org/show_bug.cgi?id=44399.

        Test: http/tests/security/canvas-remote-read-remote-image-redirect.html

        * html/canvas/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::createPattern):
2010-08-23  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Dimitri Glazkov.

        Tests that calling getImageData(), toDataURL() on a canvas tainted by
        a createPattern of a different origin image using redirects from same origin
        is not allowed.
        https://bugs.webkit.org/show_bug.cgi?id=44399

        * http/tests/security/canvas-remote-read-remote-image-redirect-expected.txt: Added.
        * http/tests/security/canvas-remote-read-remote-image-redirect.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-23 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Mon, 23 Aug 2010 19:27:38 +0000 (19:27 +0000)]
2010-08-23  Simon Fraser  <simon.fraser@apple.com>

        Add missing test result.

        * platform/mac/fast/table/simple_paint-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/table/simple_paint-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-23 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Mon, 23 Aug 2010 19:22:48 +0000 (19:22 +0000)]
2010-08-23  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Alexey Proskuryakov.

        TreeWalker is not calling acceptNode function in filter object
        https://bugs.webkit.org/show_bug.cgi?id=35296

        We only accepted raw functions as the NodeFilter on TreeWalker. Fix this to
        look for an 'acceptNode' function on the filter object, and use that if present.
        Also throw an exception if the filter object does not have an acceptNode function.

        Test: fast/dom/TreeWalker/acceptNode-filter.html

        * bindings/js/JSNodeFilterCondition.cpp:
        (WebCore::JSNodeFilterCondition::acceptNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-23 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Mon, 23 Aug 2010 19:18:01 +0000 (19:18 +0000)]
2010-08-23  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r65814.
        http://trac.webkit.org/changeset/65814
        https://bugs.webkit.org/show_bug.cgi?id=44443

        broke svg/custom/missing-xlink.svg (Requested by kling on
        #webkit).

        * fast/dom/script-tests/setAttributeNS-prefix-and-null-namespace.js: Removed.
        * fast/dom/setAttributeNS-prefix-and-null-namespace-expected.txt: Removed.
        * fast/dom/setAttributeNS-prefix-and-null-namespace.html: Removed.
2010-08-23  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r65814.
        http://trac.webkit.org/changeset/65814
        https://bugs.webkit.org/show_bug.cgi?id=44443

        broke svg/custom/missing-xlink.svg (Requested by kling on
        #webkit).

        * dom/Element.cpp:
        (WebCore::Element::setAttributeNS):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoClean up some HTML typos in crashlogs.html
ddkilzer@apple.com [Mon, 23 Aug 2010 19:10:26 +0000 (19:10 +0000)]
Clean up some HTML typos in crashlogs.html

Rubber-stamped by Maciej Stachowiak.

* quality/crashlogs.html: Fixed "</code>>" typos added in
r56300.  Changed "<tt>" tag with style attribute to "<code>"
that was missed in r56300.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRemove unneeded BlobRegistryImpl.* and WebBlobRegistryImpl.* from
jianli@chromium.org [Mon, 23 Aug 2010 18:59:35 +0000 (18:59 +0000)]
Remove unneeded BlobRegistryImpl.* and WebBlobRegistryImpl.* from
chromium project files.
https://bugs.webkit.org/show_bug.cgi?id=44442

Reviewed by David Levin.

WebCore:

* WebCore.gypi:

WebKit/chromium:

* WebKit.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebPDFView should remove itself as the delegate of its PDFView before being dealloced
mthole@apple.com [Mon, 23 Aug 2010 18:28:45 +0000 (18:28 +0000)]
WebPDFView should remove itself as the delegate of its PDFView before being dealloced
https://bugs.webkit.org/show_bug.cgi?id=44441

Reviewed by Dan Bernstein.

* WebView/WebPDFView.mm:
(-[WebPDFView dealloc]): Set the PDFView's delegate to nil.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-23 Adam Barth <abarth@webkit.org>
eric@webkit.org [Mon, 23 Aug 2010 18:12:15 +0000 (18:12 +0000)]
2010-08-23  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Many LayoutTests crash when run with --html5-treebuilder
        https://bugs.webkit.org/show_bug.cgi?id=44440

        Our list of special tags is out of sync with the HTML5 spec.  This
        patch adds HTML to the list, which fixs a ton of crashers when parsing
        fragments.  We neet to sync up the list at some point, but we want to
        make sure we have test coverage for all those changes, so I've left
        that for a future patch.

        * html/HTMLTreeBuilder.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-23 Leandro Pereira <leandro@profusion.mobi>
leandro@webkit.org [Mon, 23 Aug 2010 17:58:06 +0000 (17:58 +0000)]
2010-08-23  Leandro Pereira  <leandro@profusion.mobi>

        [EFL] Build fix for platforms that do not require linking with "dl".
        CMake includes the variable CMAKE_DL_LIBS that evaluates to the
        platform-specific libraries.

        * CMakeListsEfl.txt: Use ${CMAKE_DL_LIBS} instead of dl.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-23 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Mon, 23 Aug 2010 16:56:36 +0000 (16:56 +0000)]
2010-08-23  Daniel Bates  <dbates@rim.com>

        Rubber-stamped by Adam Roben.

        Substitute "sizeof("javascript:") - 1" for the hardcoded constant 11 when
        extracting the JavaScript code portion of a JavaScript URL so as to make
        it clearer that the 11 represents the length of the scheme portion of
        a JavaScript URL.

        * WebProcess/Plugins/PluginView.cpp:
        (WebKit::PluginView::performJavaScriptURLRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-23 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Mon, 23 Aug 2010 16:54:14 +0000 (16:54 +0000)]
2010-08-23  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Pavel Feldman.

        WebInspector: Context menu in Scripts panel was broken.
        https://bugs.webkit.org/show_bug.cgi?id=44431

        * inspector/InspectorFrontendHost.cpp:
        (WebCore::FrontendMenuProvider::contextMenuItemSelected):
        (WebCore::FrontendMenuProvider::contextMenuCleared):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-23 Satish Sampath <satish@chromium.org>
commit-queue@webkit.org [Mon, 23 Aug 2010 16:37:01 +0000 (16:37 +0000)]
2010-08-23  Satish Sampath  <satish@chromium.org>

        Reviewed by Jeremy Orlow.

        Remove obsolete public/API methods in chromium port
        https://bugs.webkit.org/show_bug.cgi?id=44421

        * public/WebSpeechInputController.h:
        (WebKit::WebSpeechInputController::startRecognition):
        (WebKit::WebSpeechInputController::cancelRecognition):
        (WebKit::WebSpeechInputController::stopRecording):
        * public/WebSpeechInputListener.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-23 Andreas Kling <andreas.kling@nokia.com>
andreas.kling@nokia.com [Mon, 23 Aug 2010 16:34:54 +0000 (16:34 +0000)]
2010-08-23  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Tor Arne Vestbø.

        setAttributeNS() should throw NAMESPACE_ERR for prefixed qualifiedName with null namespace
        https://bugs.webkit.org/show_bug.cgi?id=44432

        Test: fast/dom/setAttributeNS-prefix-and-null-namespace.html

        * dom/Element.cpp:
        (WebCore::Element::setAttributeNS): Throw NAMESPACE_ERR if namespace is null
        and the qualifiedName has a prefix.
2010-08-23  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Tor Arne Vestbø.

        setAttributeNS() should throw NAMESPACE_ERR for prefixed qualifiedName with null namespace
        https://bugs.webkit.org/show_bug.cgi?id=44432

        * fast/dom/script-tests/setAttributeNS-prefix-and-null-namespace.js: Added.
        * fast/dom/setAttributeNS-prefix-and-null-namespace-expected.txt: Added.
        * fast/dom/setAttributeNS-prefix-and-null-namespace.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-23 Ryuan Choi <ryuan.choi@samsung.com>
commit-queue@webkit.org [Mon, 23 Aug 2010 16:18:44 +0000 (16:18 +0000)]
2010-08-23  Ryuan Choi  <ryuan.choi@samsung.com>

        Reviewed by Antonio Gomes.

        [EFL] rendering was broken when missing plugin.
        https://bugs.webkit.org/show_bug.cgi?id=43395

        Implement RenderThemeEfl::systemFont to render "Missing plugin" when we
        don't have proper plugin.
        In this case, RenderEmbeddedObject::paintReplaced call systemFont and
        pass returned font to GraphicsContext.

        * platform/efl/RenderThemeEfl.cpp:
        (WebCore::RenderThemeEfl::setDefaultFontSize):
        (WebCore::RenderThemeEfl::systemFont):
        * platform/efl/RenderThemeEfl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-23 Hironori Bono <hbono@chromium.org>
commit-queue@webkit.org [Mon, 23 Aug 2010 15:30:34 +0000 (15:30 +0000)]
2010-08-23  Hironori Bono  <hbono@chromium.org>

        Reviewed by Kent Tamura.

        Removes the rebaselined results for special-key-events-in-input-text.html
        because my test_shell change fixes it and produces the expected output.
        https://bugs.webkit.org/show_bug.cgi?id=44156

        * platform/chromium-mac/fast/events/special-key-events-in-input-text-expected.txt: Removed.
        * platform/chromium-win/fast/events/special-key-events-in-input-text-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-23 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Mon, 23 Aug 2010 15:20:36 +0000 (15:20 +0000)]
2010-08-23  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] run-launcher fails if WebKitGTK+ compiled with GTK+-3.0 support
        https://bugs.webkit.org/show_bug.cgi?id=42026

        If a GTK+ 3.x build is present return that as the library to use,
        otherwise fallback to the GTK+ 2.x build.

        * Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-23 Pavel Podivilov <podivilov@chromium.org>
commit-queue@webkit.org [Mon, 23 Aug 2010 14:40:57 +0000 (14:40 +0000)]
2010-08-23  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: remove javascript breakpoint specific code from BreakpointSidebarPane
        https://bugs.webkit.org/show_bug.cgi?id=44327

        * inspector/front-end/BreakpointManager.js:
        (WebInspector.BreakpointManager.prototype.setBreakpoint):
        (WebInspector.BreakpointManager.prototype.restoredBreakpoint):
        (WebInspector.BreakpointManager.prototype._setBreakpoint):
        (WebInspector.BreakpointManager.prototype._removeBreakpoint):
        (WebInspector.BreakpointManager.prototype._setBreakpointOnBackend):
        (WebInspector.Breakpoint):
        * inspector/front-end/BreakpointsSidebarPane.js:
        (WebInspector.BreakpointsSidebarPane):
        (WebInspector.BreakpointsSidebarPane.prototype.addBreakpoint):
        (WebInspector.BreakpointsSidebarPane.prototype._breakpointRemoved):
        (WebInspector.JSBreakpointItem):
        (WebInspector.JSBreakpointItem.prototype.compareTo):
        (WebInspector.JSBreakpointItem.prototype.element):
        (WebInspector.JSBreakpointItem.prototype._breakpointClicked):
        (WebInspector.JSBreakpointItem.prototype._checkboxClicked):
        (WebInspector.JSBreakpointItem.prototype._enableChanged):
        (WebInspector.JSBreakpointItem.prototype._textChanged):
        (WebInspector.JSBreakpointItem.prototype._removed):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel):
        (WebInspector.ScriptsPanel.prototype._breakpointAdded):
        (WebInspector.ScriptsPanel.prototype._breakpointRemoved):
        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype.addBreakpoint):
        (WebInspector.SourceFrame.prototype._addBreakpointToSource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-23 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Mon, 23 Aug 2010 14:07:09 +0000 (14:07 +0000)]
2010-08-23  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        WebInspector: inspector protocol should be switched from array based
        message format to object based message format.
        Almost all the protocol related things is generated by CodeGeneratorInspector.pm
        It was changed a bit. As result InspectorBackendStub.js wraps the
        calls into Request objects. InspectorBackendDispatcher.cpp unwraps
        these objects and calls corresponding agents. These two files and
        RemoteInspectorFrontend are generated by CodeGeneratorInspector.pm
        Dispatching part of WebInspector also was adjusted for handling Event
        objects produced by RemoteInspectorFrontend.cpp and Response objects
        produced by InspectorBackendDispatcher.cpp
        https://bugs.webkit.org/show_bug.cgi?id=44338

        * inspector/CodeGeneratorInspector.pm:
        * inspector/Inspector.idl:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::setAttachedWindow):
        * inspector/InspectorController.h:
        * inspector/InspectorFrontendClientLocal.cpp:
        (WebCore::InspectorFrontendClientLocal::setAttachedWindow):
        * inspector/InspectorValues.h:
        (WebCore::InspectorObject::find):
        * inspector/front-end/Callback.js:
        (WebInspector.Callback.prototype.processResponse):
        * inspector/front-end/inspector.js:
        (WebInspector.dispatch):
        (WebInspector_syncDispatch):
        (WebInspector.dispatchMessageFromBackend):
        (WebInspector.reportProtocolError):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-23 Balazs Kelemen <kb@inf.u-szeged.hu>
abecsi@webkit.org [Mon, 23 Aug 2010 13:58:51 +0000 (13:58 +0000)]
2010-08-23  Balazs Kelemen  <kb@inf.u-szeged.hu>

        Reviewed by Ariya Hidayat.

        [Qt] Find needed forwarding headers for WebKit2 automatically
        https://bugs.webkit.org/show_bug.cgi?id=44336

        * MiniBrowser/qt/BrowserWindow.cpp: Use normal (not framework style) includes here.
        The new script does not satisfy the needs of this file however using normal includes
        is generally better here.
        * MiniBrowser/qt/MiniBrowser.pro: Added include paths.
        * Scripts/enumerate-included-framework-headers: Enumerates headers included from the
        given frameworks by files in the current directory (and subdirectories).
        In the future this needs to be rewritten in perl for being able to use on Windows.
2010-08-23  Balazs Kelemen  <kb@inf.u-szeged.hu>

        Reviewed by Ariya Hidayat.

        [Qt] Find needed forwarding headers for WebKit2 automatically
        https://bugs.webkit.org/show_bug.cgi?id=44336

        * DerivedSources.pro: Use the new enumerate-included-framework-headers script for generating
        the list of forwarding headers we want to create.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-19 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Mon, 23 Aug 2010 13:23:05 +0000 (13:23 +0000)]
2010-08-19  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Steve Block.

        Remove IDBDatabase.description per spec changes
        https://bugs.webkit.org/show_bug.cgi?id=44264

        Update layout tests to match changes.  One layout test is now
        obsolete.

        * storage/indexeddb/database-basics-expected.txt:
        * storage/indexeddb/database-description-expected.txt: Removed.
        * storage/indexeddb/database-description.html: Removed.
        * storage/indexeddb/script-tests/database-basics.js:
        (openSuccess):
        * storage/indexeddb/script-tests/database-description.js: Removed.
2010-08-19  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Steve Block.

        Remove IDBDatabase.description per spec changes
        https://bugs.webkit.org/show_bug.cgi?id=44264

        There's now no longer any way to access the description from JS.
        The main premise of the manual test is now obsolete. Over time we'll
        be able to add to it again. While I'm at it, I cleaned up the format
        of the manual test to be easier to follow (code and usage wise).

        * manual-tests/indexed-database.html:
        * storage/IDBDatabase.cpp:
        (WebCore::IDBDatabase::IDBDatabase):
        * storage/IDBDatabase.h:
        * storage/IDBDatabase.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65807 268f45cc-cd09-0410-ab3c-d52691b4dbfc