13 years ago2008-08-25 Dean Jackson <dino@apple.com>
dino@apple.com [Mon, 25 Aug 2008 21:06:21 +0000 (21:06 +0000)]
2008-08-25  Dean Jackson  <dino@apple.com>

        Reviewed by Dave Hyatt

        Make sure 'inherit' is handled by transition property.

        Test: transitions/inherit.html
        Test: transitions/inherit-other-props.html

        * css/CSSStyleSelector.cpp:
          fix macro to check existence of list before getting size

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-08-25 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 25 Aug 2008 20:56:21 +0000 (20:56 +0000)]
2008-08-25  Anders Carlsson  <andersca@apple.com>

        Reviewed by Mark.

        <rdar://problem/6149787> crash @ com.apple.JavaScriptCore: WTF::callOnMainThread + 37.

        Initialize threading in the call to WebCoreObjCFinalizeOnMainThread. We currently assume
        (safely) that any class that needs finalization on the main thread will also need to be deallocated
        on the main thread, and calling initializeThreading from WebCoreObjCFinalizeOnMainThread instead of
        calling it from WebCoreObjCScheduleDeallocateOnMainThread seems safer.

        * platform/mac/WebCoreObjCExtras.c:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-08-25 Antti Koivisto <antti@apple.com>
antti@apple.com [Mon, 25 Aug 2008 20:41:11 +0000 (20:41 +0000)]
2008-08-25  Antti Koivisto  <antti@apple.com>

        Reviewed by Dan Bernstein.

        Rename CachedResource::referenced() to CachedResource::hasClients() to
        match previous ref() -> addClient() rename.

        * loader/Cache.cpp:
        * loader/CachedResource.cpp:
        * loader/CachedResource.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix an assertion when showing the Web Inspector
aroben@apple.com [Mon, 25 Aug 2008 19:53:57 +0000 (19:53 +0000)]
    Fix an assertion when showing the Web Inspector

        Reviewed by Kevin McCullough.

        * WebCoreSupport/WebInspectorClient.cpp:
        Recent code changes have caused these functions to get called even
        when the window is already attached/detached, respectively. Handle
        this case gracefully instead of asserting something that is no longer

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Add a missing Inspector localized string for "other".
timothy@apple.com [Mon, 25 Aug 2008 18:33:05 +0000 (18:33 +0000)]
    Add a missing Inspector localized string for "other".


        Reviewed by Tim Hatcher.

        * English.lproj/localizedStrings.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
kmccullough@apple.com [Mon, 25 Aug 2008 18:18:01 +0000 (18:18 +0000)]

2008-08-25  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Geoff, Tim and Mark.

        <rdar://problem/6150623> JSProfiler: It would be nice if the profiles
        in the console said what file and line number they came from
        - Lay the foundation for getting line numbers and other data from the
        JavaScript engine.  With the cleanup in kjs/ExecState this is actually
        a slight performance improvement.

        * JavaScriptCore.exp: Export retrieveLastCaller() for WebCore.
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * VM/Machine.cpp: Now Host and JS functions set a call frame on the
        exec state, so this and the profiler code were pulled out of the
        (KJS::Machine::retrieveLastCaller): This get's the lineNumber, sourceID
        and sourceURL for the previously called function.
        * VM/Machine.h:
        * kjs/ExecState.cpp: Remove references to JSFunction since it's not used
        * kjs/ExecState.h:


2008-08-22  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Geoff, Mark and Tim.

        <rdar://problem/6150623> JSProfiler: It would be nice if the profiles
        in the console said what file and line number they came from
        - Lay the foundation for getting line numbers and other data from the
        JavaScript engine.

        * ForwardingHeaders/VM: Added.
        * ForwardingHeaders/VM/Machine.h: Added.
        * page/Console.cpp: Gather the line number and file information when
        profileEnd has been called, but don't use it until didFinishProfiling is
        called.  We won't need to wait once we remove the profiler "zombie" mode
        which this patch helps pave the foundation for.
        * page/Console.h:
        * page/InspectorController.cpp: Modify calls to
        addProfileMessageToConsole to satisfy the new arguments it takes.
        * page/InspectorController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
ap@webkit.org [Mon, 25 Aug 2008 12:40:20 +0000 (12:40 +0000)]
    Reviewed by Darin.

        Ensure that JSGlobalContextRelease() performs garbage collection, even if there are other
        contexts in the current context's group.

        This is only really necessary when the last reference is released, but there is no way to
        determine that, and no harm in collecting slightly more often.

        * API/JSContextRef.cpp: (JSGlobalContextRelease): Explicitly collect the heap if it is not
        being destroyed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-08-25 Holger Hans Peter Freyther <zecke@selfish.org>
hausmann@webkit.org [Mon, 25 Aug 2008 10:08:41 +0000 (10:08 +0000)]
2008-08-25  Holger Hans Peter Freyther  <zecke@selfish.org>

        Reviewed by Simon.

        [run-webkit-tests] Use QtLauncher to show the results of the tests
        konqueror might not be installed, xdg-open might not be installed but the
        QtLauncher should be present.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-08-25 Holger Hans Peter Freyther <zecke@selfish.org>
hausmann@webkit.org [Mon, 25 Aug 2008 10:06:53 +0000 (10:06 +0000)]
2008-08-25  Holger Hans Peter Freyther  <zecke@selfish.org>

        Reviewed by Simon.

        [inspector] Update the WebKit.qrc Qt resources file
        Catchup with the changes in the directory.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago[inspector] Emit signals from attachWindow and detachWindow in the Qt platform
hausmann@webkit.org [Mon, 25 Aug 2008 10:06:39 +0000 (10:06 +0000)]
[inspector] Emit signals from attachWindow and detachWindow in the Qt platform
    Allow the user of the API to honor the attachWindow and detachWindow
    requests and attach the QWebPage/QWebView wherever it is wanted. This needs
    some more API in QWebPage to be properly exposed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago008-08-25 Dirk Schulze <vbs85@gmx.de>
hausmann@webkit.org [Mon, 25 Aug 2008 07:10:22 +0000 (07:10 +0000)]
008-08-25  Dirk Schulze  <vbs85@gmx.de>

        Reviewed by Simon.

        Transformed the radian to degree, to get rotate()
        in canvas work as expected.

        [Qt] Canvas.rotate() doesn't work

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-08-24 Steve Falkenburg <sfalken@apple.com>
sfalken@apple.com [Mon, 25 Aug 2008 05:43:33 +0000 (05:43 +0000)]
2008-08-24  Steve Falkenburg  <sfalken@apple.com>

        Add a "last chance" WM_TIMER to the Windows shared timer.

        The last chance timer fires every 5 seconds to run any lost WM_TIMER based timers.
        Failure to fire a timer is fatal to the cross-platform Timer code, since it won't re-schedule
        timers if a timer with an earlier expiration is already pending. This results in no timers
        firing from that point on.

        We lose WM_TIMER messages occasionally (in the neighborhood of 1 per hour) probably due to a
        buggy window message hook.

        This timer will start when the first WM_TIMER is scheduled, and will
        fire every 5 seconds thereafter, causing any lost timers to be fired.

        Found this via one of its symptoms: leaking WebFrames. The fix prevents timers from stalling
        and prevents the WebFrame leak.

        Reviewed by Darin Adler, Geoff Garen.

        * platform/win/SharedTimerWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-08-24 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Mon, 25 Aug 2008 04:08:01 +0000 (04:08 +0000)]
2008-08-24  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Oliver Hunt.

        Bug 20093: JSC shell does not clear exceptions after it executes toString on an expression

        Clear exceptions after evaluating any code in the JSC shell. We do not
        report exceptions that are caused by calling toString on the final
        valued, but at least we avoid incorrect behaviour.

        Also, print any exceptions that occurred while evaluating code at the
        interactive prompt, not just while evaluating code from a file.

        * kjs/Shell.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
mitz@apple.com [Mon, 25 Aug 2008 03:22:44 +0000 (03:22 +0000)]

        Reviewed by Darin Adler.

        - fix <rdar://problem/6065547> REGRESSION (r34879): "Subject" in unread emails in Yahoo mail is not shown in bold

        Test: fast/css/font-property-priority.html

        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue): Changed to pass the 'important' flag
        to the font-property-parsing functions.
        (WebCore::CSSParser::parseFontStyle): Added an 'important' argument and
        changed to use it rather than the m_important member.
        (WebCore::CSSParser::parseFontVariant): Ditto.
        (WebCore::CSSParser::parseFontWeight): Ditto.
        * css/CSSParser.h:


        Reviewed by Darin Adler.

        - test for <rdar://problem/6065547> REGRESSION (r34879): "Subject" in unread emails in Yahoo mail is not shown in bold

        * fast/css/font-property-priority-expected.txt: Added.
        * fast/css/font-property-priority.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-08-24 Beth Dakin <bdakin@apple.com>
bdakin@apple.com [Mon, 25 Aug 2008 01:27:53 +0000 (01:27 +0000)]
2008-08-24  Beth Dakin  <bdakin@apple.com>

        Reviewed by John Sullivan.

        Provide the excludeFromTextSearch SPI on Windows as well.

        * Interfaces/IWebFrame.idl:
        * WebFrame.cpp:
        * WebFrame.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fixes a bug where the Inspector's UI would not animate or
timothy@apple.com [Sun, 24 Aug 2008 22:28:44 +0000 (22:28 +0000)]
    Fixes a bug where the Inspector's UI would not animate or
        fully function because JavaScript timeouts, intervals and
        CSS animation timers where not firing while paused at a
        a breakpoint in the inspected page.


        Reviewed by Darin Adler.

        Test: manual-tests/inspector/forzen-ui-while-paused.html

        * page/JavaScriptDebugServer.cpp:
        Add a call to TimerBase::fireTimersInNestedEventLoop before
        spinning the EventLoop.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-08-24 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Sun, 24 Aug 2008 21:30:40 +0000 (21:30 +0000)]
2008-08-24  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Oliver.

        Remove an unnecessary RefPtr to a RegisterID.

        * kjs/nodes.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Sam Weinig.
rwlbuis@webkit.org [Sun, 24 Aug 2008 18:07:32 +0000 (18:07 +0000)]
    Reviewed by Sam Weinig.

        A change in SVG Glyph wont show up

        Invalidate the glyph cache when the d attribute is set.

        Test: svg/custom/glyph-setting-d-attribute.svg

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-08-24 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Sun, 24 Aug 2008 12:59:03 +0000 (12:59 +0000)]
2008-08-24  Jon Honeycutt  <jhoneycutt@apple.com>

        Cannot get the focused accessible object from the root object.

        AccessibleBase::get_AccFocus() checks whether the focused object is a
        child of the current object, but
        http://msdn.microsoft.com/en-us/library/ms696150(VS.85).aspx states that
        the result is the object itself, if it has focus, or a child object of
        the active window, not a child of the object.

        Reviewed by Sam Weinig.

        * AccessibleBase.cpp:
        (AccessibleBase::get_accFocus): Don't check whether the focused object
        is our child.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-08-24 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Sun, 24 Aug 2008 12:56:21 +0000 (12:56 +0000)]
2008-08-24  Jon Honeycutt  <jhoneycutt@apple.com>

        Initial support for accessibility layout tests on Windows.

        Reviewed by Sam Weinig.

        * DumpRenderTree/AccessibilityController.h: Fix typos.
        * DumpRenderTree/AccessibilityUIElement.cpp: Change #import to #include.
        * DumpRenderTree/AccessibilityUIElement.h: Define _WINSOCKAPI_ to
        prevent oleacc.h, which includes windows.h, from including winsock.h.
        Fixed typos.
        * DumpRenderTree/win/AccessibilityControllerWin.cpp: Added.
        (AccessibilityController::focusedElement): Get the root element, and
        request its focused object.
        (AccessibilityController::rootElement): Query Windows for the
        accessible client object for the WebView's window.
        * DumpRenderTree/win/AccessibilityUIElementWin.cpp: Added.
        (AccessibilityUIElement::getLinkedUIElements): Not implemented.
        (AccessibilityUIElement::getChildren): Get the child count, and append
        each child.
        (AccessibilityUIElement::getChildAtIndex): Get the child at the given
        index offset by 1. In MSAA, child 0 is the object itself.
        (AccessibilityUIElement::allAttributes): Not implemented.
        (AccessibilityUIElement::attributesOfLinkedUIElements): Same.
        (AccessibilityUIElement::attributesOfChildren): Same.
        (AccessibilityUIElement::parameterizedAttributeNames): Same.
        (self): Return a VARIANT representing the "self" object. This is used
        when calling methods that require a child variant.
        (AccessibilityUIElement::role): Get the MSAA role, a long value, and
        convert it into a string with GetRoleText().
        (AccessibilityUIElement::title): Get the element's title, and convert
        it to a JS String.
        (AccessibilityUIElement::description): Same, for description.
        (AccessibilityUIElement::intValue): Get the object's value as a string,
        and convert the string to a double.
        (AccessibilityUIElement::minValue): Not implemented.
        (AccessibilityUIElement::maxValue): Same.
        (AccessibilityUIElement::insertionPointLineNumber): Same.
        (AccessibilityUIElement::attributesOfColumnHeaders): Same.
        (AccessibilityUIElement::attributesOfRowHeaders): Same.
        (AccessibilityUIElement::attributesOfColumns): Same.
        (AccessibilityUIElement::attributesOfRows): Same.
        (AccessibilityUIElement::attributesOfVisibleCells): Same.
        (AccessibilityUIElement::attributesOfHeader): Same.
        (AccessibilityUIElement::indexInTable): Same.
        (AccessibilityUIElement::rowIndexRange): Same.
        (AccessibilityUIElement::columnIndexRange): Same.
        (AccessibilityUIElement::lineForIndex): Same.
        (AccessibilityUIElement::boundsForRange): Same.
        (AccessibilityUIElement::cellForColumnAndRow): Same.
        * DumpRenderTree/win/DumpRenderTree.vcproj: Add accessibility files to
        project.  Link to oleacc.lib, the MSAA library.
        * DumpRenderTree/win/FrameLoadDelegate.cpp:
        (FrameLoadDelegate::FrameLoadDelegate): Initialize the accessibility
        (FrameLoadDelegate::didClearWindowObject): Create a new window object
        for the accessibility controller.
        * DumpRenderTree/win/FrameLoadDelegate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Sam Weinig.
mitz@apple.com [Sun, 24 Aug 2008 09:18:39 +0000 (09:18 +0000)]
    Reviewed by Sam Weinig.

        - fix https://bugs.webkit.org/show_bug.cgi?id=13864
          <rdar://problem/5451470> REGRESSION: Uninitialized value in RenderBlock::calcInlinePrefWidths()

        * rendering/RenderText.cpp:
        (WebCore::RenderText::trimmedPrefWidths): Moved the assignment to
        beginWS and endWS before the early return to ensure that they are
        initialized in that case.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUse the correct version number for when JSGlobalContextCreate was introduced.
mrowe@apple.com [Sun, 24 Aug 2008 08:35:21 +0000 (08:35 +0000)]
Use the correct version number for when JSGlobalContextCreate was introduced.

Reviewed by Oliver Hunt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-08-23 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Sat, 23 Aug 2008 08:16:54 +0000 (08:16 +0000)]
2008-08-23  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Rubber-stamped by Mark Rowe.

        Remove modelines.


        * API/APICast.h:
        * API/JSBase.cpp:
        * API/JSCallbackConstructor.cpp:
        * API/JSCallbackConstructor.h:
        * API/JSCallbackFunction.cpp:
        * API/JSCallbackFunction.h:
        * API/JSCallbackObject.cpp:
        * API/JSCallbackObject.h:
        * API/JSCallbackObjectFunctions.h:
        * API/JSClassRef.cpp:
        * API/JSContextRef.cpp:
        * API/JSObjectRef.cpp:
        * API/JSProfilerPrivate.cpp:
        * API/JSStringRef.cpp:
        * API/JSStringRefBSTR.cpp:
        * API/JSStringRefCF.cpp:
        * API/JSValueRef.cpp:
        * API/tests/JSNode.c:
        * API/tests/JSNode.h:
        * API/tests/JSNodeList.c:
        * API/tests/JSNodeList.h:
        * API/tests/Node.c:
        * API/tests/Node.h:
        * API/tests/NodeList.c:
        * API/tests/NodeList.h:
        * API/tests/minidom.c:
        * API/tests/minidom.js:
        * API/tests/testapi.c:
        * API/tests/testapi.js:
        * JavaScriptCore.pro:
        * kjs/FunctionConstructor.h:
        * kjs/FunctionPrototype.h:
        * kjs/JSArray.h:
        * kjs/JSString.h:
        * kjs/JSWrapperObject.cpp:
        * kjs/NumberConstructor.h:
        * kjs/NumberObject.h:
        * kjs/NumberPrototype.h:
        * kjs/lexer.h:
        * kjs/lookup.h:
        * wtf/Assertions.cpp:
        * wtf/Assertions.h:
        * wtf/HashCountedSet.h:
        * wtf/HashFunctions.h:
        * wtf/HashIterators.h:
        * wtf/HashMap.h:
        * wtf/HashSet.h:
        * wtf/HashTable.h:
        * wtf/HashTraits.h:
        * wtf/ListHashSet.h:
        * wtf/ListRefPtr.h:
        * wtf/Noncopyable.h:
        * wtf/OwnArrayPtr.h:
        * wtf/OwnPtr.h:
        * wtf/PassRefPtr.h:
        * wtf/Platform.h:
        * wtf/RefPtr.h:
        * wtf/RefPtrHashMap.h:
        * wtf/RetainPtr.h:
        * wtf/UnusedParam.h:
        * wtf/Vector.h:
        * wtf/VectorTraits.h:
        * wtf/unicode/Unicode.h:
        * wtf/unicode/icu/UnicodeIcu.h:


        * WebCore.pro:
        * bridge/testbindings.cpp:
        * dom/DocPtr.h:
        * loader/SubstituteData.h:
        * page/Chrome.cpp:
        * page/Chrome.h:
        * page/ChromeClient.h:
        * page/Frame.h:
        * page/FrameLoadRequest.h:
        * page/FrameTree.cpp:
        * page/FrameTree.h:
        * page/Page.h:
        * page/mac/ChromeMac.mm:
        * platform/network/HTTPHeaderMap.h:
        * platform/network/ResourceErrorBase.cpp:
        * platform/network/ResourceErrorBase.h:
        * platform/network/ResourceHandleInternal.h:
        * platform/network/ResourceRequestBase.cpp:
        * platform/network/ResourceRequestBase.h:
        * platform/network/ResourceResponseBase.cpp:
        * platform/network/ResourceResponseBase.h:
        * platform/network/cf/ResourceError.h:
        * platform/network/cf/ResourceRequest.h:
        * platform/network/cf/ResourceRequestCFNet.h:
        * platform/network/cf/ResourceResponse.h:
        * platform/network/cf/ResourceResponseCFNet.h:
        * platform/network/curl/ResourceError.h:
        * platform/network/curl/ResourceRequest.h:
        * platform/network/curl/ResourceResponse.h:
        * platform/network/mac/ResourceError.h:
        * platform/network/mac/ResourceErrorMac.mm:
        * platform/network/mac/ResourceRequest.h:
        * platform/network/mac/ResourceRequestMac.mm:
        * platform/network/mac/ResourceResponse.h:
        * platform/network/mac/ResourceResponseMac.mm:
        * platform/network/qt/ResourceError.h:
        * platform/network/qt/ResourceRequest.h:
        * platform/network/qt/ResourceResponse.h:
        * platform/network/soup/CookieJarSoup.cpp:
        * platform/network/soup/ResourceError.h:
        * platform/network/soup/ResourceRequest.h:
        * platform/network/soup/ResourceResponse.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
mitz@apple.com [Sat, 23 Aug 2008 07:16:41 +0000 (07:16 +0000)]

        Reviewed by Dave Hyatt.

        - fix <rdar://problem/6065143> Reflowed image in first line of table doesn't affect baseline

        Test: fast/table/vertical-align-baseline.html

        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::getBaselineOfFirstLineBox): Added. Returns the
        baseline of the first table row, if there is one, -1 otherwise.
        * rendering/RenderTable.h:
        * rendering/RenderTableCell.cpp:
        (WebCore::RenderTableCell::baselinePosition): Changed to follow the
        CSS2.1 definition of the baseline of a table cell.
        * rendering/RenderTableSection.cpp:
        (WebCore::RenderTableSection::getBaselineOfFirstLineBox): Added. Returns
        the baseline of the first row in the section.
        * rendering/RenderTableSection.h:


        Reviewed by Dave Hyatt.

        - test and updated results for <rdar://problem/6065143> Reflowed image in first line of table doesn't affect baseline

        * fast/table/vertical-align-baseline.html: Added.
        * platform/mac/fast/table/form-with-table-style-expected.checksum:
        * platform/mac/fast/table/form-with-table-style-expected.png:
        * platform/mac/fast/table/form-with-table-style-expected.txt:
        * platform/mac/fast/table/vertical-align-baseline-expected.checksum: Added.
        * platform/mac/fast/table/vertical-align-baseline-expected.png: Added.
        * platform/mac/fast/table/vertical-align-baseline-expected.txt: Added.
        * platform/mac/tables/mozilla/bugs/bug3037-1-expected.txt:
        * platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.checksum:
        * platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:
        * platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-08-22 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Sat, 23 Aug 2008 03:17:17 +0000 (03:17 +0000)]
2008-08-22  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Oliver.

        Some cleanup to match our coding style.

        * VM/CodeGenerator.h:
        * VM/Machine.cpp:
        * kjs/ExecState.cpp:
        * kjs/ExecState.h:
        * kjs/completion.h:
        * kjs/identifier.cpp:
        * kjs/operations.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-08-18 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Fri, 22 Aug 2008 23:44:32 +0000 (23:44 +0000)]
2008-08-18  Jon Honeycutt  <jhoneycutt@apple.com>

        Add SPI to make a Windows WebView transparent.

        Reviewed by Dan Bernstein.

        * Interfaces/IWebViewPrivate.idl:
        * WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebFrameLoaderClient::transitionToCommittedForNewPage): Call
        updateBackground() when a new frame is attached, matching the Mac.
        * WebFrame.cpp:
        (WebFrame::updateBackground): Propagate WebView transparency to ourself
        and our child frames.
        * WebFrame.h:
        * WebView.cpp:
        (WebView::paintIntoBackingStore): Pass m_transparent when creating a
        GraphicsContext, so the context will be created with an alpha channel.
        * WebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-08-12 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Fri, 22 Aug 2008 23:44:14 +0000 (23:44 +0000)]
2008-08-12  Jon Honeycutt  <jhoneycutt@apple.com>

        Add SPI to get a handle to the WebView's backing store bitmap.

        Reviewed by Dan Bernstein.

        * Interfaces/IWebViewPrivate.idl:
        * WebView.cpp:
        * WebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Rolls out r35834 because it caused a regression in the Inspector's
timothy@apple.com [Fri, 22 Aug 2008 20:35:20 +0000 (20:35 +0000)]
    Rolls out r35834 because it caused a regression in the Inspector's
        Console where some expressions always threw a syntax error.


        * page/inspector/Console.js:
        (Console.prototype._evalInInspectedWindow): Removes parenthesis
        around the expression.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-08-22 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 22 Aug 2008 19:39:36 +0000 (19:39 +0000)]
2008-08-22  Anders Carlsson  <andersca@apple.com>

        Fix build for real this time.

        * UserObjectImp.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-08-22 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 22 Aug 2008 19:14:11 +0000 (19:14 +0000)]
2008-08-22  Anders Carlsson  <andersca@apple.com>

        Fix build.

        * UserObjectImp.cpp:
        * UserObjectImp.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoMakes getStyleProperty return a value for the overflow property when overflow-x and...
timothy@apple.com [Fri, 22 Aug 2008 18:39:52 +0000 (18:39 +0000)]
Makes getStyleProperty return a value for the overflow property when overflow-x and overflow-y are equal.


2008-08-22  Timothy Hatcher  <timothy@apple.com>

        Makes getStyleProperty return a value for the overflow property
        when overflow-x and overflow-y are equal.


        Reviewed by Dan Bernstein.

        Test: fast/css/overflow-property.html

        * css/CSSMutableStyleDeclaration.cpp:


2008-08-22  Timothy Hatcher  <timothy@apple.com>

        Test for the tests the parsing and retrieval of the overflow,
        overflow-x and overflow-y properties


        Reviewed by Dan Bernstein.

        * fast/css/overflow-property-expected.txt: Added.
        * fast/css/overflow-property.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fixes a bug where while editing in the Inspector the
timothy@apple.com [Fri, 22 Aug 2008 18:39:42 +0000 (18:39 +0000)]
    Fixes a bug where while editing in the Inspector the
        sidebar scroll position would jump to the top.


        Reviewed by Darin Adler.

        * page/inspector/treeoutline.js:
        (TreeOutline._removeChildren): Remove the offsetTop call that
        was forcing a layout, since layout causes scroll positions
        to be clamped to the new scrollHeight/Width. Layout will happen
        normally when needed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin Adler
simon.fraser@apple.com [Fri, 22 Aug 2008 17:38:53 +0000 (17:38 +0000)]
    Reviewed by Darin Adler

        css3/transform-computed-style-001.html is better tested
        by fast/css/getComputedStyle-transform.html, so removed.

        * css3/transform-computed-style-001-expected.txt: Removed.
        * css3/transform-computed-style-001.fhtml: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agowx build fix. Add AccessibilityTable sources.
kevino@webkit.org [Fri, 22 Aug 2008 16:25:52 +0000 (16:25 +0000)]
wx build fix. Add AccessibilityTable sources.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
mitz@apple.com [Fri, 22 Aug 2008 06:29:33 +0000 (06:29 +0000)]

        Reviewed by Jon Honeycutt and Alexey Proskuryakov.

        - fix <rdar://problem/6162701> WebKit should correct Geeza Pro's font metrics

        Test: platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html

        * platform/graphics/mac/SimpleFontDataMac.mm:
        (WebCore::SimpleFontData::platformInit): Add 8% to Geeza Pro's reported
        ascent and 100% to its reported descent.


        Reviewed by Jon Honeycutt and Alexey Proskuryakov.

        - test for <rdar://problem/6162701> WebKit should correct Geeza Pro's font metrics

        * platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.checksum: Added.
        * platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png: Added.
        * platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt: Added.
        * platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-08-21 Jonas Klink <klinktech@gmail.com>
mrowe@apple.com [Fri, 22 Aug 2008 02:20:13 +0000 (02:20 +0000)]
2008-08-21 Jonas Klink <klinktech@gmail.com>

        Reviewed by Jon Honeycutt.

        Fix https://bugs.webkit.org/show_bug.cgi?id=20231
        Bug 20231: accNavigate: no screen element found in the specified direction should return S_FALSE

        Per <http://msdn.microsoft.com/en-us/library/ms696145(VS.85).aspx>, we should return S_FALSE
        from accNavigate if no screen element is found in the specified direction.

        * AccessibleBase.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-08-21 Jonas Klink <klinktech@gmail.com>
mrowe@apple.com [Fri, 22 Aug 2008 02:20:08 +0000 (02:20 +0000)]
2008-08-21 Jonas Klink <klinktech@gmail.com>

        Reviewed by Jon Honeycutt.

        Fix http://bugs.webkit.org/show_bug.cgi?id=20230
        Bug 20230: get_accState should be testing state on childObj

        Also initializes output parameter action to 0 in get_accDefaultAction.

        * AccessibleBase.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix bug number in ChangeLog.
mrowe@apple.com [Fri, 22 Aug 2008 02:10:15 +0000 (02:10 +0000)]
Fix bug number in ChangeLog.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-08-21 Kalle Vahlman <kalle.vahlman@movial.com>
mrowe@apple.com [Fri, 22 Aug 2008 02:07:54 +0000 (02:07 +0000)]
2008-08-21  Kalle Vahlman  <kalle.vahlman@movial.com>

        Reviewed by Darin Adler.

        [GTK] Crash on some pages due to a plugin

        Fix handling of badly formatted and empty plugin mime descriptions

        * plugins/gtk/PluginPackageGtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-08-21 Kevin Watters <kevinwatters@gmail.com>
mrowe@apple.com [Fri, 22 Aug 2008 02:07:48 +0000 (02:07 +0000)]
2008-08-21  Kevin Watters  <kevinwatters@gmail.com>

        Reviewed by Darin Adler.

        Follow other ports (and IE) in ImageSourceWx.cpp never to return an
        animated GIF frame duration of less than 50ms.

        * platform/graphics/wx/ImageSourceWx.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-08-21 Maxime Britto <britto@apple.com>
britto@apple.com [Fri, 22 Aug 2008 00:39:39 +0000 (00:39 +0000)]
2008-08-21  Maxime Britto  <britto@apple.com>

        Reviewed by Kevin McCullough.

        Test: fast/events/autoscroll-nonscrollable-iframe-in-scrollable-div.html

        rdar://problem/6166435 Inspector doesn't auto scroll when selecting text (20451)
        When we climb up the rendering tree looking for a scrollable renderer, we need to be able to jump outside of an iframe.
        This way we can see if what is embedding the iframe can be scrolled even if the iframe content can't.

        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleMouseDraggedEvent): when we reach the document node and it can't be scrolled we set the next parent as the document's owner element if it exists.

        (WebCore::EventHandler::handleMousePressEvent): ditto

2008-08-21  Maxime Britto  <britto@apple.com>

        Reviewed by Kevin McCullough.

        rdar://problem/6166435 Inspector doesn't auto scroll when selecting text (20451)

        This test can be run automatically or manually as well.

        * fast/events/autoscroll-nonscrollable-iframe-in-scrollable-div-expected.txt: Added.
        * fast/events/autoscroll-nonscrollable-iframe-in-scrollable-div.html: Added.
        * fast/events/resources/big-page-with-overflow-hidden.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Small optimization for when the dividers in the Inspector's
timothy@apple.com [Thu, 21 Aug 2008 23:54:01 +0000 (23:54 +0000)]
    Small optimization for when the dividers in the Inspector's
        Resources panel are updated.

        Reviewed by Tim Hatcher.

        * page/inspector/ResourcesPanel.js:
        Combind a for loop and clone the divider element.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoReviewed by Mark Rowe
simon.fraser@apple.com [Thu, 21 Aug 2008 23:44:56 +0000 (23:44 +0000)]
Reviewed by Mark Rowe

Make build-launcher-app work when run from a git repository.

* BuildSlaveSupport/build-launcher-app:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-08-21 Chris Marrin <cmarrin@apple.com>
dino@apple.com [Thu, 21 Aug 2008 23:35:23 +0000 (23:35 +0000)]
2008-08-21  Chris Marrin  <cmarrin@apple.com>

        Allow 0 (without units) for Time eg. duration
        Fix for https://bugs.webkit.org/show_bug.cgi?id=20467

        Reviewed by Dave Hyatt.

        Test: css1/units/zero-duration-without-units.html

        * css/CSSParser.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Make deleting all text while editing a DOM attribute in
timothy@apple.com [Thu, 21 Aug 2008 20:13:12 +0000 (20:13 +0000)]
    Make deleting all text while editing a DOM attribute in
        the Inspector delete the attribute. This also fixes
        an exception that would happen before.


        Reviewed by Kevin McCullough.

        * page/inspector/ElementsPanel.js:
        Don't check for hasAttributes on the parseElement, continuing
        through the function will correctly remove the attribute.
        If the parseElement is null, call _editingCancelled not
        editingCancelled, this fixes an exception.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Update the Inspector's Metrics pane when editing in
timothy@apple.com [Thu, 21 Aug 2008 20:12:59 +0000 (20:12 +0000)]
    Update the Inspector's Metrics pane when editing in
        the Styles pane. This makes sure the metrics shown
        always match what the Styles pane shows.


        Reviewed by Kevin McCullough.

        * page/inspector/ElementsPanel.js:
        (WebInspector.ElementsPanel): Add event listeners for
        the "style edited" and "style property toggled" events,
        so the Metrics pane is updated.
        Update the Metrics pane.
        * page/inspector/StylesSidebarPane.js:
        Dispatch the "style property toggled" event.
        Dispatch the "style edited" event when the CSS text is restored.
        Dispatch the "style edited" event.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Make the Inspector's Metrics sidebar pane editable.
timothy@apple.com [Thu, 21 Aug 2008 20:12:47 +0000 (20:12 +0000)]
    Make the Inspector's Metrics sidebar pane editable.


        Reviewed by Kevin McCullough.

        * page/inspector/ElementsPanel.js:
        (WebInspector.ElementsPanel): Add an event listener for
        the "metrics edited" event, so the Styles pane is updated.
        * page/inspector/MetricsSidebarPane.js:
        (WebInspector.MetricsSidebarPane.prototype.update): Remember the node
        so future updates work. Add a double click event listener for the
        metric values to start editing.
        Call WebInspector.startEditing with some context.
        Set the user input on the elements inline style. Fire the
        "metrics edited" event.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix a race condition in Windows timer code.
sfalken@apple.com [Thu, 21 Aug 2008 18:42:44 +0000 (18:42 +0000)]
    Fix a race condition in Windows timer code.
        Timer function could end up being called with a 0 timer, leading to a Windows exception.

        Don't post a timer message if one is already pending.

        Reviewed by Ada Chan.

        * platform/win/SharedTimerWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago After trying to add the expression, try again with quotes for
timothy@apple.com [Thu, 21 Aug 2008 16:36:06 +0000 (16:36 +0000)]
    After trying to add the expression, try again with quotes for
        easier edition.


        Reviewed by Tim Hatcher.

        * page/inspector/ObjectPropertiesSection.js: Added an
        evaluateExpression function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Perform Inspector searches on search event to clear results when
timothy@apple.com [Thu, 21 Aug 2008 16:33:17 +0000 (16:33 +0000)]
    Perform Inspector searches on search event to clear results when
        clicking the cross to empty it. Delete the lastQuery when the field
        is emptied in order to perform the search if exactly the same query
        is entered next.


        Reviewed by Tim Hatcher.

        * page/inspector/inspector.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-08-21 Marco Barisione <marco.barisione@collabora.co.uk>
jmalonzo@webkit.org [Thu, 21 Aug 2008 11:22:51 +0000 (11:22 +0000)]
2008-08-21  Marco Barisione  <marco.barisione@collabora.co.uk>

        Reviewed by Mark Rowe.

        [SOUP] The gio code should call didFail() instead of
        didFinishLoading() in case of error

        In case of error call didFail() instead of didReceiveResponse() and

        * platform/network/soup/ResourceHandleSoup.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix build failure.
mrowe@apple.com [Thu, 21 Aug 2008 06:52:42 +0000 (06:52 +0000)]
Fix build failure.

Reviewed by Jon Honeycutt.

* bridge/c/c_instance.cpp:
(KJS::Bindings::CInstance::getPropertyNames): Declare count as uint32_t rather than unsigned
as that is what NPEnumerationFunctionPtr is declared as accepting.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd Anthony Ricaud's blog.
timothy@apple.com [Thu, 21 Aug 2008 05:03:21 +0000 (05:03 +0000)]
Add Anthony Ricaud's blog.

        Reviewed by Tim Hatcher.

        * config.ini: Add Anthony Ricaud's blog.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBuild fix.
mrowe@apple.com [Thu, 21 Aug 2008 04:01:51 +0000 (04:01 +0000)]
Build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
mitz@apple.com [Thu, 21 Aug 2008 00:33:29 +0000 (00:33 +0000)]

        Rubber-stamped by John Sullivan.

        - rename shouldUpdateWhileHidden to shouldUpdateWhileOffscreen and
          rename related methods and variables accordingly.

        * WebCore.base.exp:
        * page/FrameView.cpp:
        * page/FrameView.h:
        * platform/ScrollView.h:
        * platform/mac/ScrollViewMac.mm:


        Rubber-stamped by John Sullivan.

        - rename shouldUpdateWhileHidden to shouldUpdateWhileOffscreen,
          rename related methods and variables accordingly, and make
          -setShouldUpdateWhileOffscreen: and -shouldUpdateWhileOffscreen
          WebView API.

        * WebCoreSupport/WebFrameLoaderClient.mm:
        * WebView/WebFrame.mm:
        (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
        * WebView/WebFrameInternal.h:
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView windowWillOrderOnScreen:]):
        * WebView/WebView.h:
        * WebView/WebView.mm:
        (-[WebViewPrivate init]):
        (-[WebView setBackgroundColor:]):
        (-[WebView setDrawsBackground:]):
        (-[WebView setShouldUpdateWhileOffscreen:]):
        (-[WebView shouldUpdateWhileOffscreen]):
        * WebView/WebViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-08-20 Brady Eidson <beidson@apple.com>
beidson@apple.com [Thu, 21 Aug 2008 00:13:12 +0000 (00:13 +0000)]
2008-08-20  Brady Eidson  <beidson@apple.com>

        Reviewed by Mitzpettel

        <rdar://problem/6163636> - Many images broken in Mail

        This can be traced back to the preload scanner.  With that change, CachedResources are created a lot
        sooner than before and confuse the WebArchive machinery.

        When referencing WebArchive subresources directly through the WebKit API it is appropriate to ignore
        such CachedResources since they are placeholders and have not been submitted to the ResourceLoadDelegate
        machinery and nothing is known about where the data will eventually come from.

        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::subresource):  Ignore a CachedResource if its preloadResult is

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoSwitch to non-deprecated NSFileManager APIs.
mrowe@apple.com [Wed, 20 Aug 2008 23:20:55 +0000 (23:20 +0000)]
Switch to non-deprecated NSFileManager APIs.

In order to minimize #if's the new NSFileManager APIs have been implemented for
Tiger and call sites updated to use the new methods.

Reviewed by Darin Adler.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Dave Hyatt
simon.fraser@apple.com [Wed, 20 Aug 2008 23:04:43 +0000 (23:04 +0000)]
    Reviewed by Dave Hyatt

        getComputedStyle() for webkitTransform should return a transform
        that does not have the transform origin baked into it.

        * fast/css/getComputedStyle-transform-expected.txt: Added.
        * fast/css/getComputedStyle-transform.html: Added.

        (Missed these test files on last commit)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-08-20 Holger Hans Peter Freyther <zecke@selfish.org>
zecke@webkit.org [Wed, 20 Aug 2008 22:50:39 +0000 (22:50 +0000)]
2008-08-20  Holger Hans Peter Freyther  <zecke@selfish.org>

        Unreviewed compile fix

        Catch up with the JSValue::type elimination.

        * bridge/qt/qt_instance.cpp:
        * bridge/qt/qt_runtime.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-08-20 Chris Teague <chris.teague@gmail.com>
mrowe@apple.com [Wed, 20 Aug 2008 22:15:53 +0000 (22:15 +0000)]
2008-08-20  Chris Teague  <chris.teague@gmail.com>

        Reviewed by Mark Rowe.

        Fix https://bugs.webkit.org/show_bug.cgi?id=20449
        Bug 20449: Build fails if LOW_BANDWIDTH_DISPLAY is defined

        * ChangeLog:
        * loader/FrameLoader.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Dave Hyatt
simon.fraser@apple.com [Wed, 20 Aug 2008 21:57:22 +0000 (21:57 +0000)]
    Reviewed by Dave Hyatt

        getComputedStyle() for webkitTransform should return a transform
        that does not have the transform origin baked into it.

        Test: fast/css/getComputedStyle-transform.html

        * css/CSSComputedStyleDeclaration.cpp:
        * rendering/style/RenderStyle.cpp:
        * rendering/style/RenderStyle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
andersca@apple.com [Wed, 20 Aug 2008 21:04:12 +0000 (21:04 +0000)]

2008-08-20  Josh Aas  <joshmoz@gmail.com>

        Reviewed and landed by Anders.

        rename NPCocoaEvent's "event" struct to "data" (20446)

        * bridge/npapi.h:


2008-08-20  Josh Aas  <joshmoz@gmail.com>

        Reviewed and landed by Anders.

        rename NPCocoaEvent's "event" struct to "data" (20446)

        * Plugins/WebNetscapePluginEventHandlerCocoa.mm:


2008-08-20  Josh Aas  <joshmoz@gmail.com>

        Reviewed and landed by Anders.

        rename NPCocoaEvent's "event" struct to "data" (20446)

        * NetscapeCocoaPlugin/main.m:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
bdakin@apple.com [Wed, 20 Aug 2008 20:46:28 +0000 (20:46 +0000)]

2008-08-20  Beth Dakin  <bdakin@apple.com>

        Reviewed by Darin.

        Fix for <rdar://problem/6145626>
        This patch fixes a number of remaining problems getting
        disconnected frames to work correctly with markAllMatchesForText()
        and findString(). Details inline.

        This was a static helper function in Frame, but this patch requires
        the same functionality in Editor, so I just added it as a function
        on Node.
        * dom/Node.cpp:
        * dom/Node.h:

        * editing/Editor.cpp:
        (WebCore::Editor::insideVisibleArea): Returns false if
        excludeFromTextSearch() is true.

        In a normal (non-disconnected) frame, findString returns a range of
        the document node if the text is not found in the frame. I changed
        firstVisibleRange and lastVisibleRange to match that behavior when
        the text is not found

        Here are the bulk of the changes in the patch. A lot of text was
        not being found in disconnected frames because I failed to account
        for all of the possible problems associated with shadow trees. That
        is fixed here.
        * editing/Editor.h:

        excludeFromTextSearch() is new. It allows a WebKit client to mark a
        frame as not-text-searchable through SPI.
        * WebCore.base.exp:
        * page/Frame.cpp:
        * page/Frame.h:
        * page/FramePrivate.h:

        (WebCore::Frame::markAllMatchesForText):  I kept running into an
        assertion failure in paining code because of the forced paint on
        empty visible rects.


2008-08-20  Beth Dakin  <bdakin@apple.com>

        Reviewed by Darin.

        Fix for <rdar://problem/6145626>
        Allows a WebKit client to mark a frame as not-text-searchable
        through SPI.

        * WebView/WebFrame.mm:
        (-[WebFrame _setExcludeFromTextSearch:]):
        * WebView/WebFramePrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Adds a positon box to the Inspector's Metrics sidebar
timothy@apple.com [Wed, 20 Aug 2008 19:10:54 +0000 (19:10 +0000)]
    Adds a positon box to the Inspector's Metrics sidebar
        pane. When an element is not statically positioned, there
        is now a position box that show top, right, bottom and
        left computed values.

        Reviewed by Kevin McCullough.

        * English.lproj/localizedStrings.js: Updated the strings.
        * page/inspector/MetricsSidebarPane.js:
        Renamed the boxPartValue function to createBoxPartElement
        and made it create the entire element. Made it understand
        how to get position style properties. Don't use the figure dash
        when 0px is used for positions, since the 0 is meaningful there.
        Instead use the figure dash when a position is auto.
        * page/inspector/inspector.css: Added a new rule for position.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-08-20 Maxime Britto <britto@apple.com>
britto@apple.com [Wed, 20 Aug 2008 19:01:24 +0000 (19:01 +0000)]
2008-08-20  Maxime Britto  <britto@apple.com>

        Reviewed by Ada Chan.

        Mouse events are sent to page while resizing window (affects Gmail)
        In the WebView, if the MouseEvent is located in the resize corner, we send it back to the UIDelegate and early return.

        * Interfaces/IWebUIDelegatePrivate.idl: Add a new method to the UIDelegate to send the resize message
        * WebView.cpp:
        (WebView::handleMouseEvent): If the mouse event is in the resize corner and our UIDelegate supports the message it sends the new message and early returns

2008-08-20  Maxime Britto  <britto@apple.com>

        Reviewed by Ada Chan.

        Mouse events are sent to page while resizing window (affects Gmail)

        * DumpRenderTree/win/UIDelegate.h:
        (UIDelegate::webViewSendResizeMessage): Add the new interface method, not implemented.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoQt build fix
cfleizach@apple.com [Wed, 20 Aug 2008 18:34:56 +0000 (18:34 +0000)]
Qt build fix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Anders Carlsson.
mitz@apple.com [Wed, 20 Aug 2008 18:28:07 +0000 (18:28 +0000)]
    Reviewed by Anders Carlsson.

        - avoid using a deprecated NSScroller method on Leopard

        * platform/mac/PlatformScrollBarMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-08-20 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Wed, 20 Aug 2008 11:40:31 +0000 (11:40 +0000)]
2008-08-20  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Oliver Hunt.

        Gtk build fix

        * GNUmakefile.am:
        * page/AccessibilityTable.cpp: Change nil to 0

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Windows build fix.
ap@webkit.org [Wed, 20 Aug 2008 10:40:16 +0000 (10:40 +0000)]
    Windows build fix.

        * API/WebKitAvailability.h: Define DEPRECATED_ATTRIBUTE.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Geoff Garen.
ap@webkit.org [Wed, 20 Aug 2008 07:23:06 +0000 (07:23 +0000)]
    Reviewed by Geoff Garen.

        Bring back shared JSGlobalData and implicit locking, because too many clients rely on it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Geoff Garen.
eric@webkit.org [Tue, 19 Aug 2008 23:33:07 +0000 (23:33 +0000)]
    Reviewed by Geoff Garen.

        Add the beginnings of Skia graphics support to WebCore
        as I try to begin the long process of un-forking the changes
        needed to WebCore to make Andriod's WebCore build.

        I'll follow this up with actual *Skia.cpp files in a separate patch.

        * platform/graphics/AffineTransform.h:
        * platform/graphics/FloatPoint.h:
        * platform/graphics/FloatRect.h:
        * platform/graphics/Gradient.h:
        * platform/graphics/GraphicsContext.h:
        * platform/graphics/Image.h:
        * platform/graphics/ImageBuffer.h:
        * platform/graphics/ImageSource.h:
        * platform/graphics/IntPoint.h:
        * platform/graphics/IntRect.h:
        * platform/graphics/Path.h:
        * platform/graphics/Pattern.h:
        * svg/graphics/SVGPaintServerPattern.h:
        * svg/graphics/SVGPaintServerSolid.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix Windows build more.
sfalken@apple.com [Tue, 19 Aug 2008 22:46:31 +0000 (22:46 +0000)]
    Fix Windows build more.

        * WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fixes the Web Inspector flashing white while resizing after
timothy@apple.com [Tue, 19 Aug 2008 22:36:30 +0000 (22:36 +0000)]
    Fixes the Web Inspector flashing white while resizing after
        highlighting a page element. Calling disableScreenUpdatesUntilFlush
        when attaching and detaching the Inspector page highlight is bad,
        since the browser window might not flush again for a while. So screen
        updates could be disabled for long periods of time, causing backing store
        flashing while resizing. There is no need to call disableScreenUpdatesUntilFlush
        when attaching or detaching the child window.

        Reviewed by John Sullivan and Kevin McCullough.

        * WebInspector/WebNodeHighlight.m:
        (-[WebNodeHighlight attach]): Remove the call to disableScreenUpdatesUntilFlush.
        (-[WebNodeHighlight detach]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix Windows build.
sfalken@apple.com [Tue, 19 Aug 2008 22:34:37 +0000 (22:34 +0000)]
    Fix Windows build.

        * page/AccessibilityRenderObject.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix build.
sfalken@apple.com [Tue, 19 Aug 2008 22:29:18 +0000 (22:29 +0000)]
    Fix build.

        * WebScriptCallFrame.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-08-19 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Tue, 19 Aug 2008 22:22:02 +0000 (22:22 +0000)]
2008-08-19  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Tim and Mark.

        Implement DTrace hooks for dashcode and instruments.

        * API/JSProfilerPrivate.cpp: Added. Expose SPI so that profiling can be
        turned on from a client.  The DTrace probes were added within the
        profiler mechanism for performance reasons so the profiler must be
        started to enable tracing.
        * API/JSProfilerPrivate.h: Added. Ditto.
        * JavaScriptCore.exp: Exposing the start/stop methods to clients.
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * kjs/Tracing.d: Define the DTrace probes.
        * kjs/Tracing.h: Ditto.
        * profiler/ProfileGenerator.cpp: Implement the DTrace probes in the

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago<rdar://problem/4003764> Expose tables as AXTables
cfleizach@apple.com [Tue, 19 Aug 2008 22:05:37 +0000 (22:05 +0000)]
<rdar://problem/4003764> Expose tables as AXTables

Exposes "data" tables in HTML as AXTables through accessibility

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Build fix.
sfalken@apple.com [Tue, 19 Aug 2008 21:35:49 +0000 (21:35 +0000)]
    Build fix.

        * kjs/operations.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
ap@webkit.org [Tue, 19 Aug 2008 20:18:54 +0000 (20:18 +0000)]
    Reviewed by Darin.

        Fix run-webkit-tests misreporting crashed tests as timed out ones because DumpRenderTree
        is waiting for crash reporter to let it exit.

        The fix does not work on Tiger, because the state of the process is indistinguishable from
        other waiting processes, at least not with this technique.

        * Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Build fix.
sfalken@apple.com [Tue, 19 Aug 2008 18:39:44 +0000 (18:39 +0000)]
    Build fix.
        Add buildfailed support to stop builds early (preventing inaccurate error messages).
        Add missing post-build rule to Release.

        * WebCore.vcproj/QTMovieWin.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Added support for console.count in the inspector.
timothy@apple.com [Tue, 19 Aug 2008 18:33:27 +0000 (18:33 +0000)]
    Added support for console.count in the inspector.

        Reviewed by Geoff Garen.

        * page/Console.cpp:
        * page/Console.h:
        * page/Console.idl: Added console.count.
        * page/InspectorController.cpp:
        (WebCore::InspectorController::didCommitLoad): Clears m_counts.
        (WebCore::InspectorController::count): Updates the count number
        sing "title@source:line" as the identifier, and adds a
        message to the console.
        * page/InspectorController.h: Added m_counts.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Clear console.time timers when changing page.
timothy@apple.com [Tue, 19 Aug 2008 18:33:02 +0000 (18:33 +0000)]
    Clear console.time timers when changing page.

        Reviewed by Geoff Garen.

        * page/InspectorController.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-08-19 Eric Carlson <eric.carlson@apple.com>
adele@apple.com [Tue, 19 Aug 2008 17:55:58 +0000 (17:55 +0000)]
2008-08-19  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Adele.

        Fix for <rdar://problem/6154695> Full-page movies flicker while playing

        Ignore setVisible() when visibility doesn't change.

        * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Correctly remembers the attached state of the Web Inspector so
timothy@apple.com [Tue, 19 Aug 2008 17:01:23 +0000 (17:01 +0000)]
    Correctly remembers the attached state of the Web Inspector so
        it opens in that state for the next window, or next launch.

        Reviewed by Kevin McCullough.

        * WebCoreSupport/WebInspectorClient.mm:
        (-[WebInspectorWindowController attach]): Set WebKitInspectorAttachedKey
        to YES in the user defaults.
        (-[WebInspectorWindowController detach]): Set WebKitInspectorAttachedKey
        to NO in the user defaults.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fixes a bug in the Profile view where switching sort order, then
timothy@apple.com [Tue, 19 Aug 2008 17:01:12 +0000 (17:01 +0000)]
    Fixes a bug in the Profile view where switching sort order, then
        switching from heavy to tree mode would show the tree in the
        previous sort order.


        Reviewed by Kevin McCullough.

        * page/inspector/ProfileView.js:
        (WebInspector.ProfileView.prototype._changeView): Call _sortProfile
        on the next profile before assigning it to this.profile.
        (WebInspector.ProfileView.prototype._sortData): Call _sortProfile.
        (WebInspector.ProfileView.prototype._sortProfile): Moves from
        _sortData and takes a profile argument. If the profile passed in
        matches the this.profile, then call refresh.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Changed the default sort order now that heavy view is the default.
timothy@apple.com [Tue, 19 Aug 2008 17:01:00 +0000 (17:01 +0000)]
    Changed the default sort order now that heavy view is the default.
        Also fixes a bug where the heavy profile was not sorted at first.


        Reviewed by Kevin McCullough.

        * page/inspector/ProfileView.js:
        (WebInspector.ProfileView): Changed the default sort column. Also assign
        heavyProfile to profile, so the sortSelfTimeDescending call happens
        on the heavy profile before assigning to this.profile.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix an assertion when generating a heavy profile because the
timothy@apple.com [Tue, 19 Aug 2008 17:00:48 +0000 (17:00 +0000)]
    Fix an assertion when generating a heavy profile because the
        empty value and deleted value of CallIdentifier where equal.


        Reviewed by Dan Bernstein.

        * profiler/CallIdentifier.h: Make the emptyValue for CallIdentifier
        use empty strings for URL and function name.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Add support for editing DOM properties and scope variables by double
timothy@apple.com [Tue, 19 Aug 2008 17:00:36 +0000 (17:00 +0000)]
    Add support for editing DOM properties and scope variables by double
        clicking a property to enter edit mode.


        Reviewed by Kevin McCullough.

        * page/inspector/ObjectPropertiesSection.js:
        (WebInspector.ObjectPropertiesSection): Set editable to true by default.
        Factored out code into update, and calls update.
        (WebInspector.ObjectPropertiesSection.prototype.update): Moved from onpopulate.
        Call removeChildren since this method can be called multiple times now.
        (WebInspector.ObjectPropertyTreeElement): Pass an empty title, the title
        gets made later in onattach.
        (WebInspector.ObjectPropertyTreeElement.prototype.onpopulate): Don't return early
        if shouldRefreshChildren is true. Call removeChildren since this method can be
        called multiple times now.
        (WebInspector.ObjectPropertyTreeElement.prototype.ondblclick): Call startEditing.
        (WebInspector.ObjectPropertyTreeElement.prototype.onattach): Call update.
        (WebInspector.ObjectPropertyTreeElement.prototype.update): Update the title for
        this element (code moved from the constructor.)
        (WebInspector.ObjectPropertyTreeElement.prototype.updateSiblings): Recreate all
        sibling property elements.
        (WebInspector.ObjectPropertyTreeElement.prototype.startEditing): Call
        WebInspector.startEditing after rememebring some context.
        (WebInspector.ObjectPropertyTreeElement.prototype.editingEnded): Reset the scrollLeft
        for the list element, since it might have scrolled during editing.
        (WebInspector.ObjectPropertyTreeElement.prototype.editingCancelled): Call editingEnded
        then restore the state from the context. Then call update to restore the title.
        (WebInspector.ObjectPropertyTreeElement.prototype.editingCommitted): Call editingCancelled
        if the user input and the previous input are the same. Call editingEnded, then call applyExpression
        to commit the user input.
        (WebInspector.ObjectPropertyTreeElement.prototype.applyExpression): Evaluates the input expression
        and stores the result on the object for the property name of this element. If the expression is
        empty, delete the property and remove the tree element.
        * page/inspector/ScopeChainSidebarPane.js:
        (WebInspector.ScopeChainSidebarPane.prototype.update): Set the editInSelectedCallFrameWhenPaused
        property on each ObjectPropertiesSection.
        (WebInspector.ScopeVariableTreeElement.prototype.onattach): Call ObjectPropertyTreeElement's onattach
        since it is now implemented.
        * page/inspector/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame): Added an updateInterface argument
        that defaults to true if omitted. It specifies whether to call update on the scope chain.
        * page/inspector/inspector.css: New styles.
        * page/inspector/treeoutline.js:
        (TreeElement.prototype._attach): Fixed an exception that fired when handling the shouldRefreshChildren
        change. The nextSibling would exist but have a _listItemNode that didn't match the new parent.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Surround the expression to be evaluated in parenthesis so the
timothy@apple.com [Tue, 19 Aug 2008 17:00:26 +0000 (17:00 +0000)]
    Surround the expression to be evaluated in parenthesis so the
        result of the eval is the result of the whole expression not
        the last potential sub-expression. So evaluating {x: 123}
        will show the Object not 123.


        Reviewed by Kevin McCullough.

        * page/inspector/Console.js:
        (Console.prototype._evalInInspectedWindow): Add parenthesis
        around the expression. And add couple comments.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-08-19 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Tue, 19 Aug 2008 16:38:06 +0000 (16:38 +0000)]
2008-08-19 Kevin McCullough <kmccullough@apple.com>

        Reviewed by Geoff.

        -Implement a page() function to extract a common code pattern.

        * WebCore.xcodeproj/project.pbxproj:
        * page/Console.cpp:
        * page/Console.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago https://bugs.webkit.org/show_bug.cgi?id=19762
ap@webkit.org [Tue, 19 Aug 2008 14:35:48 +0000 (14:35 +0000)]
        Crash in svg/webarchive/svg-cursor-subresources.svg

        Disabling the test while the crash is being investigated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Dan Bernstein.
ap@webkit.org [Tue, 19 Aug 2008 07:27:12 +0000 (07:27 +0000)]
    Reviewed by Dan Bernstein.

        <rdar://problem/5977562> Input methods do not work after switching to a password field
        and back.

        Fix <rdar://problem/5522011> (The content of the password field of Safari is displayed by
        reconversion) in a different way which doesn't conflict with context caching performed
        by AppKit.

        This original bug does not really occur in ToT or shipping Safari under Mac OS X 10.5.4,
        because input methods are disabled in password fields. Attempting to reconvert text typed
        with Romaji only yields a string of bullets. Still, it is probably better to match Cocoa
        password field behavior and disable reconversion completely.

        * WebView/WebHTMLView.mm:
        (isInPasswordField): Factored out code to determine that the current selection is in
        a password field.
        (inputContext): Removed a hack that was breaking TSMGetActiveDocument().
        (-[WebHTMLView attributedSubstringFromRange:]): Check for password fields.
        (-[WebHTMLView textStorage]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
darin@apple.com [Tue, 19 Aug 2008 04:39:04 +0000 (04:39 +0000)]

2008-08-12  Darin Adler  <darin@apple.com>

        Reviewed by Geoff.

        - eliminate JSValue::type()

        This will make it slightly easier to change the JSImmediate design without
        having to touch so many call sites.

        SunSpider says this change is a wash (looked like a slight speedup, but not
        statistically significant).

        * API/JSStringRef.cpp: Removed include of JSType.h.
        * API/JSValueRef.cpp: Removed include of JSType.h.
        (JSValueGetType): Replaced use of JSValue::type() with
        JSValue::is functions.

        * JavaScriptCore.exp: Updated.

        * VM/JSPropertyNameIterator.cpp: Removed type() implementation.
        (KJS::JSPropertyNameIterator::toPrimitive): Changed to take
        PreferredPrimitiveType argument instead of JSType.
        * VM/JSPropertyNameIterator.h: Ditto.

        * VM/Machine.cpp:
        (KJS::fastIsNumber): Updated for name change.
        (KJS::fastToInt32): Ditto.
        (KJS::fastToUInt32): Ditto.
        (KJS::jsAddSlowCase): Updated toPrimitive caller for change from
        JSType to PreferredPrimitiveType.
        (KJS::jsAdd): Replaced calls to JSValue::type() with calls to
        (KJS::jsTypeStringForValue): Replaced calls to JSValue::type()
        with multiple calls to JSValue::is -- we could make this a
        virtual function instead if we want to have faster performance.
        (KJS::Machine::privateExecute): Renamed JSImmediate::toTruncatedUInt32
        to JSImmediate::getTruncatedUInt32 for consistency with other functions.
        Changed two calls of JSValue::type() to JSValue::isString().

        * kjs/GetterSetter.cpp:
        (KJS::GetterSetter::toPrimitive): Changed to take
        PreferredPrimitiveType argument instead of JSType.
        (KJS::GetterSetter::isGetterSetter): Added.
        * kjs/GetterSetter.h:

        * kjs/JSCell.cpp:
        (KJS::JSCell::isString): Added.
        (KJS::JSCell::isGetterSetter): Added.
        (KJS::JSCell::isObject): Added.

        * kjs/JSCell.h: Eliminated type function. Added isGetterSetter.
        Made isString and isObject virtual. Changed toPrimitive to take
        PreferredPrimitiveType argument instead of JSType.
        (KJS::JSCell::isNumber): Use Heap::isNumber for faster performance.
        (KJS::JSValue::isGetterSetter): Added.
        (KJS::JSValue::toPrimitive): Changed to take
        PreferredPrimitiveType argument instead of JSType.

        * kjs/JSImmediate.h: Removed JSValue::type() and replaced
        JSValue::toTruncatedUInt32 with JSValue::getTruncatedUInt32.
        (KJS::JSImmediate::isEitherImmediate): Added.

        * kjs/JSNotAnObject.cpp:
        (KJS::JSNotAnObject::toPrimitive): Changed to take
        PreferredPrimitiveType argument instead of JSType.
        * kjs/JSNotAnObject.h: Ditto.
        * kjs/JSNumberCell.cpp:
        (KJS::JSNumberCell::toPrimitive): Ditto.
        * kjs/JSNumberCell.h:
        (KJS::JSNumberCell::toInt32): Renamed from fastToInt32. There's no
        other "slow" version of this once you have a JSNumberCell, so there's
        no need for "fast" in the name. It's a feature that this hides the
        base class toInt32, which does the same job less efficiently (and has
        an additional ExecState argument).
        (KJS::JSNumberCell::toUInt32): Ditto.

        * kjs/JSObject.cpp:
        (KJS::callDefaultValueFunction): Use isGetterSetter instead of type.
        (KJS::JSObject::getPrimitiveNumber): Use PreferredPrimitiveType.
        (KJS::JSObject::defaultValue): Ditto.
        (KJS::JSObject::defineGetter): Use isGetterSetter.
        (KJS::JSObject::defineSetter): Ditto.
        (KJS::JSObject::lookupGetter): Ditto.
        (KJS::JSObject::lookupSetter): Ditto.
        (KJS::JSObject::toNumber): Use PreferredPrimitiveType.
        (KJS::JSObject::toString): Ditto.
        (KJS::JSObject::isObject): Added.

        * kjs/JSObject.h:
        (KJS::JSObject::inherits): Call the isObject from JSCell; it's now
        hidden by our override of isObject.
        (KJS::JSObject::getOwnPropertySlotForWrite): Use isGetterSetter
        instead of type.
        (KJS::JSObject::getOwnPropertySlot): Ditto.
        (KJS::JSObject::toPrimitive): Use PreferredPrimitiveType.

        * kjs/JSString.cpp:
        (KJS::JSString::toPrimitive): Use PreferredPrimitiveType.
        (KJS::JSString::isString): Added.
        * kjs/JSString.h: Ditto.

        * kjs/JSValue.h: Removed type(), added isGetterSetter(). Added
        PreferredPrimitiveType enum and used it as the argument for the
        toPrimitive function.
        (KJS::JSValue::getBoolean): Simplified a bit an removed a branch.

        * kjs/collector.cpp:
        (KJS::typeName): Changed to use JSCell::is functions instead of
        calling JSCell::type.

        * kjs/collector.h:
        (KJS::Heap::isNumber): Renamed from fastIsNumber.

        * kjs/nodes.h: Added now-needed include of JSType, since the type
        is used here to record types of values in the tree.

        * kjs/operations.cpp:
        (KJS::equal): Rewrote to no longer depend on type().
        (KJS::strictEqual): Ditto.


2008-08-12  Darin Adler  <darin@apple.com>

        Reviewed by Geoff.

        - eliminate JSValue::type()

        * JSUtils.cpp:
        (KJSValueToCFTypeInternal): Replaced uses of JSValue::type() with
        JSValue::is functions.
        * UserObjectImp.cpp:
        (UserObjectImp::getOwnPropertySlot): Ditto.
        (UserObjectImp::toPrimitive): Take PreferredPrimitiveType argument
        instead of JSType argument.
        * UserObjectImp.h: Ditto.


2008-08-12  Darin Adler  <darin@apple.com>

        Reviewed by Geoff.

        - eliminate JSValue::type()

        * bridge/c/c_instance.cpp:
        (KJS::Bindings::CInstance::defaultValue): Take PreferredPrimitiveType
        argument instead of JSType argument. Removed unneeded code to handle
        boolean, since that's never passed.
        * bridge/c/c_instance.h: Ditto.

        * bridge/c/c_utility.cpp:
        (KJS::Bindings::convertValueToNPVariant): Use JSValue::is functions
        instead of JSValue::type(). Removed unneeded code to handle

        * bridge/jni/jni_instance.cpp:
        (JavaInstance::defaultValue): Take PreferredPrimitiveType argument
        instead of JSType argument. Removed unneeded code to handle boolean.
        * bridge/jni/jni_instance.h: Ditto.

        * bridge/jni/jni_jsobject.mm:
        (JavaJSObject::convertValueToJObject): Use JSValue::is functions
        instead of JSValue::type().

        * bridge/objc/objc_instance.h: Take PreferredPrimitiveType argument
        instead of JSType argument. Removed unused argument.
        * bridge/objc/objc_instance.mm:
        (ObjcInstance::getValueOfUndefinedField): Removed unused argument.
        (ObjcInstance::defaultValue): Take PreferredPrimitiveType argument
        instead of JSType argument. Removed unneeded code to handle boolean
        and another dead code path for unknown types.

        * bridge/objc/objc_runtime.h: Take PreferredPrimitiveType argument
        instead of JSType argument. Removed override of type() that caused
        the fallback object to return "UndefinedType" when there is no
        invokeUndefinedMethodFromWebScript:withArguments: method defined.
        That didn't accomplish much, since most checks for undefined don't
        ever call type().
        * bridge/objc/objc_runtime.mm:
        (ObjcFallbackObjectImp::defaultValue): Ditto.

        * bridge/qt/qt_instance.cpp:
        (KJS::Bindings::QtInstance::defaultValue): Take PreferredPrimitiveType
        argument instead of JSType argument. Removed unneeded code to handle
        * bridge/qt/qt_instance.h: Ditto.

        * bridge/runtime.h:
        (KJS::Bindings::Instance::getValueOfUndefinedField): Removed
        unsed argument.
        * bridge/runtime_object.cpp:
        (RuntimeObjectImp::defaultValue): Take PreferredPrimitiveType
        argument instead of JSType argument.
        * bridge/runtime_object.h: Ditto.


2008-08-12  Darin Adler  <darin@apple.com>

        Reviewed by Geoff.

        - eliminate JSValue::type()

        * WebView/WebView.mm:
        (aeDescFromJSValue): Rewrite to use the JSValue::is functions instead
        of a switch on JSValue::type().


2008-08-12  Darin Adler  <darin@apple.com>

        Reviewed by Geoff.

        - added a test since I had to rewrite the == and === operators

        * fast/js/equality-expected.txt: Added.
        * fast/js/equality.html: Added.
        * fast/js/resources/equality.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-08-18 Maxime Britto <britto@apple.com>
britto@apple.com [Tue, 19 Aug 2008 00:42:13 +0000 (00:42 +0000)]
2008-08-18  Maxime Britto  <britto@apple.com>

        Reviewed by Adele.

        <rdar://6157207> Mouse pointer does not change when new window is opened after pan-scrolling original window
        Related to the discussion from rdar://6102511 , we should disable every key event (except for the esc key which stops the panning).
        We shouldn't be able to create another window while we are in pan scrolling.
        Other browsers behaviors :
          FF3 : Most of the keys are disabled, there is no way to create another window while in panscroll mode
          IE7 : Keys are not disabled but stops immediately the panning.
        This patch matches FF3 behavior by disabling every key but the esc key.

        * page/EventHandler.cpp:
        (WebCore::EventHandler::stopAutoscrollTimer): Change the cursor back to the regular arrow cursor when the pannning is stopped.
        (WebCore::EventHandler::keyEvent): When a key event is received while in panning or autoscroll we swallow the event early.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
mitz@apple.com [Tue, 19 Aug 2008 00:20:38 +0000 (00:20 +0000)]

        Reviewed by Dave Hyatt.

        - fix <rdar://problem/5862634> REGRESSION (3.1.1): In iChat, inline image not resizable past current size after another IM is received

        Test: fast/replaced/max-width-percent.html

        Added an includeMaxWidth boolean to RenderBox::calcReplaedWidth().
        When false, max-width is not factored into the
        Changed RenderReplaced and subclasses' calcPrefWidths() to call
        calcReplacedWidth(false) and then apply max-width only if it has a
        fixed, positive value.

        * rendering/RenderBox.cpp:
        * rendering/RenderBox.h:
        * rendering/RenderImage.cpp:
        * rendering/RenderImage.h:
        * rendering/RenderReplaced.cpp:
        * rendering/RenderSVGRoot.cpp:
        * rendering/RenderVideo.cpp:
        * rendering/RenderVideo.h:


        Reviewed by Dave Hyatt.

        - test for <rdar://problem/5862634> REGRESSION (3.1.1): In iChat, inline image not resizable past current size after another IM is received

        * fast/replaced/max-width-percent.html: Added.
        * platform/mac/fast/replaced/max-width-percent-expected.checksum: Added.
        * platform/mac/fast/replaced/max-width-percent-expected.png: Added.
        * platform/mac/fast/replaced/max-width-percent-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Make transition_shorthand_parsing.html a text-only test.
simon.fraser@apple.com [Mon, 18 Aug 2008 23:08:22 +0000 (23:08 +0000)]
    Make transition_shorthand_parsing.html a text-only test.

        * fast/css/transition_shorthand_parsing-expected.txt: Added.
        * fast/css/transition_shorthand_parsing.html:
        * platform/mac/fast/css/transition_shorthand_parsing-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-08-18 Daniel Macks <dmacks@netspace.org>
mrowe@apple.com [Mon, 18 Aug 2008 22:47:28 +0000 (22:47 +0000)]
2008-08-18  Daniel Macks  <dmacks@netspace.org>

        Reviewed by Mark Rowe.

        More portable/self-documenting replacement for SIZE_MAX.

        * platform/network/curl/FormDataStreamCurl.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Dave Hyatt
simon.fraser@apple.com [Mon, 18 Aug 2008 22:11:10 +0000 (22:11 +0000)]
    Reviewed by Dave Hyatt

        Need to make sure we have an Animation in the AnimationList
        before setting the initial value.

        Test: fast/css/transition_shorthand_parsing.html

        * css/CSSStyleSelector.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBuild fix for Win. Don't include the libxml/libxslt directories in the
kevino@webkit.org [Mon, 18 Aug 2008 21:55:04 +0000 (21:55 +0000)]
Build fix for Win. Don't include the libxml/libxslt directories in the
include path, it picks up the wrong Pattern.h in that case.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-08-18 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Mon, 18 Aug 2008 20:53:59 +0000 (20:53 +0000)]
2008-08-18  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Tim.

        If there are no nodes in a profile all the time should be attributed to

        * profiler/Profile.cpp: If ther are no nodes make sure we still process
        the head.
        * profiler/ProfileGenerator.cpp: Remove some useless code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35823 268f45cc-cd09-0410-ab3c-d52691b4dbfc