weinig [Sat, 3 Feb 2007 15:00:42 +0000 (15:00 +0000)]
Reviewed by Mark.
Patch for http://bugs.webkit.org/show_bug.cgi?id=12555
Drosera doesn't handle CR ( carriage returns ) well
- Normalize all the line endings.
* Drosera/debugger.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19386
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer [Sat, 3 Feb 2007 12:16:36 +0000 (12:16 +0000)]
WebCore:
Reviewed by NOBODY (no-svg build fix).
* page/EventHandler.cpp: Include FloatPoint.h.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19385
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Sat, 3 Feb 2007 10:53:11 +0000 (10:53 +0000)]
Reviewed by Mitz.
http://bugs.webkit.org/show_bug.cgi?id=12549
Wrong character encoding at www.ravmilim.co.il
Test: fast/encoding/meta-charset.html
* loader/TextResourceDecoder.cpp:
(WebCore::TextResourceDecoder::checkForHeadCharset): Fix an off by one error.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19384
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Sat, 3 Feb 2007 05:54:46 +0000 (05:54 +0000)]
LayoutTests:
Reviewed by Hyatt & Adele.
- test case for <rdar://problem/
4896972> TV guide listings page doesn't finish loading (11674)
* fast/forms/disabled-select-change-index.html: Added.
WebCore:
Reviewed by Hyatt & Adele.
- <rdar://problem/
4896972> TV guide listings page doesn't finish loading (11674)
Test case: fast/forms/disabled-select-change-index.html
* html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::setSelected): Allow changing selected state of a disabled
option.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19383
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann [Sat, 3 Feb 2007 01:36:05 +0000 (01:36 +0000)]
Build fix, not reviewed.
Blind attempt to fix Qt build.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19379
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann [Sat, 3 Feb 2007 01:33:38 +0000 (01:33 +0000)]
Reviewed by Eric & Maciej.
Fix serveral <use> issues:
- When events are dispatch to a referenced element, the actual event.target
has to be set to the corresponding SVGElementInstance object
- Node::shadowAncestorNode() should _not_ return the shadowParentNode for SVG elements
This is only needed for the HTML forms concept and breaks event dispatching for SVG shadow tree elements.
- Add SVGElementInstance as possible EventTarget in bindings/js/kjs_dom.cpp
(Now event.target returns the actual SVGElementInstance object for a shadow tree element)
Fixes: http://bugs.webkit.org/show_bug.cgi?id=12502 (Reproducible crash when browsing SVG map.)
Fixes: http://bugs.webkit.org/show_bug.cgi?id=12511 (<use> has event dispatching issues)
Added test: svg/custom/use-event-handler-on-use-element.svg
Added test: svg/custom/use-event-handler-on-referenced-element.svg
Added test: svg/custom/use-elementInstance-event-target.svg
Added test: svg/custom/use-elementInstance-methods.svg
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19378
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Sat, 3 Feb 2007 01:06:51 +0000 (01:06 +0000)]
Reviewed by Darin Adler.
Added some more known leaks to the leaks ignore list.
* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Why does XCode
hate itself so much?
* Scripts/run-webkit-tests:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19377
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver [Sat, 3 Feb 2007 00:25:19 +0000 (00:25 +0000)]
2007-02-02 Oliver Hunt <oliver@apple.com>
Reviewed by Geoff.
Add guard around accessing [NSEvent eventNumber] to ensure
we don't attempt to access it on on non-mouse related NSEvent.
* platform/mac/PlatformMouseEventMac.mm:
(WebCore::eventNumberForEvent):
(WebCore::PlatformMouseEvent::PlatformMouseEvent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19376
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Fri, 2 Feb 2007 23:53:11 +0000 (23:53 +0000)]
Reviewed by Anders.
Try to be a little less selfish about DocumentLoader.
Spotted while working on <rdar://problem/
4957747>.
* page/ContextMenuController.cpp:
(WebCore::ContextMenuController::contextMenuItemSelected):
Everyone can open frames in new windows.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19375
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann [Fri, 2 Feb 2007 23:45:48 +0000 (23:45 +0000)]
Reviewed by Eric.
Move xml:space/xml:lang from svgattrs.in to xmlattrs.in where they actually belong.
Now they are actually recognized by SVGLangSpace::parseMappedAttribute.
Patch implementing xml:space="preserve" coming soon, which acts as test for this stuff.
Always build XMLNames.cpp (not only for SVG) and replace all occourences of
"http://www.w3.org/XML/1998/namespace" by "XMLNames::xmlNamespaceURI".
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19374
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin [Fri, 2 Feb 2007 23:03:31 +0000 (23:03 +0000)]
Reviewed by Maciej.
Working on a layout test.
Fix for <rdar://problem/
4966100> REGRESSION: Reproducible ASSERT
hit at Walgreens.com
* page/Frame.cpp:
(WebCore::Frame::setView): If we are setting the view to 0 and
detaching the document, call unscheduleRealyout() on the old view
before setting it to 0.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19373
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Fri, 2 Feb 2007 19:57:28 +0000 (19:57 +0000)]
add const back, too
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19371
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Fri, 2 Feb 2007 19:56:16 +0000 (19:56 +0000)]
Even better build fix than the last.
* ChangeLog:
* DumpRenderTree/DumpRenderTree.m:
(shouldIgnoreWebCoreNodeLeaks):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19370
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Fri, 2 Feb 2007 18:57:55 +0000 (18:57 +0000)]
Fixed build. Added work-around for GCC bug.
* DumpRenderTree/DumpRenderTree.m:
(shouldIgnoreWebCoreNodeLeaks):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19367
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Fri, 2 Feb 2007 18:36:27 +0000 (18:36 +0000)]
build fix? i don't think so, but let's see...
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19366
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Fri, 2 Feb 2007 17:57:28 +0000 (17:57 +0000)]
Reviewed by Anders.
- fix copying and assigning a ListHashSet
No test because the code path with bugs I am fixing is not used yet.
* wtf/ListHashSet.h: Tweaked ListHashSetNodeAllocator a little bit for clarity.
Changed m_allocator to be an OwnPtr instead of doing an explicit delete.
Fixed bug in copy constructor where we'd have an uninitialized m_allocator.
Fixed bug in assignment operator where it would swap only the hash table, and
not the head, tail, and allocator pointers.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19365
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Fri, 2 Feb 2007 17:55:33 +0000 (17:55 +0000)]
JavaScriptCore:
Reviewed by Maciej Stachowiak.
Use WTFLog instead of fprintf for logging KJS::Node leaks.
* kjs/nodes.cpp:
(NodeCounter::~NodeCounter): Changed count to unsigned, updated
to match style guidelines.
WebCore:
Reviewed by Maciej Stachowiak.
Added support for selectively ignoring WebCore::Node leaks during layout
tests, so that we can ignore known leaks in other components.
* WebCore.exp:
* dom/Node.cpp:
(WebCore::Node::isSupported): Moved isSupported up with the rest of the static functions.
(WebCore::): Added an ignoreSet, which collects WebCore::Nodes whose lifetime
we want to ignore. We need to track which nodes to ignore rather than, say,
just suspending the count, because node destruction depends on lots of
different variables, so it would be nearly impossible to know when exactly
to suspend the count and when exactly to resume it.
(WebCore::NodeCounter::~NodeCounter): Changed to use WTFLog instead of fprintf.
(WebCore::Node::startIgnoringLeaks): Do the ignoring.
(WebCore::Node::stopIgnoringLeaks): ditto
(WebCore::Node::Node): ditto
(WebCore::Node::~Node): ditto
* dom/Node.h: Moved isSupported up with the rest of the static functions.
* platform/mac/LoggingMac.mm:
(WebCore::initializeWithUserDefault): Renamed from "initializeLoggingChannel"
because the real goal here is to honor a user default -- WTFLoggingChannels
need no run-time initialization. Also replaced "off by default, on if a
user default says so" behavior with "only override existing setting if a
user default says so" behavior. It seemed like a bug that you would specify
a channel's on/off state in its definition, but this function would unconditionally
blow that state away.
(WebCore::InitializeLoggingChannelsIfNecessary):
WebKit:
Reviewed by Maciej Stachowiak.
Added support for selectively ignoring WebCore::Node leaks during layout
tests, so that we can ignore known leaks in other components.
* Misc/WebCoreStatistics.h:
* Misc/WebCoreStatistics.mm:
(+[WebCoreStatistics startIgnoringWebCoreNodeLeaks]):
(+[WebCoreStatistics stopIgnoringWebCoreNodeLeaks]):
WebKitTools:
Reviewed by Maciej Stachowiak.
Added support for selectively ignoring WebCore::Node leaks during layout
tests, so that we can ignore known leaks in other components.
* DumpRenderTree/DumpRenderTree.m:
(shouldIgnoreWebCoreNodeLeaks): Implements a black list of tests whose
WebCore::Node leaks we have to ignore. Does this CFString gobbledy-gook
confuse anyone else?
(runTest):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19364
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Fri, 2 Feb 2007 16:28:09 +0000 (16:28 +0000)]
2007-02-02 Eric Seidel <eric@webkit.org>
Reviewed by mitz.
Fix gradient stop style resolution to be less of a hack, fixing style invalidation:
http://bugs.webkit.org/show_bug.cgi?id=12193
and fix stop-color and stop-opacity not to inherit:
http://bugs.webkit.org/show_bug.cgi?id=12193
Tests:
* svg/custom/gradient-stops-style-change.svg: added
* svg/W3C-SVG-1.1/pservers-grad-18-b.svg: updated
* WebCore.xcodeproj/project.pbxproj:
* ksvg2/css/SVGCSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applySVGProperty):
* ksvg2/css/SVGRenderStyle.cpp:
(WebCore::SVGRenderStyle::inheritedNotEqual):
(WebCore::SVGRenderStyle::inheritFrom):
* ksvg2/css/SVGRenderStyle.h:
* ksvg2/svg/SVGDefsElement.cpp:
(WebCore::SVGDefsElement::createRenderer):
* ksvg2/svg/SVGGradientElement.cpp:
(WebCore::SVGGradientElement::createRenderer):
(WebCore::SVGGradientElement::buildStops):
* ksvg2/svg/SVGGradientElement.h:
(WebCore::SVGGradientElement::rendererIsNeeded):
* ksvg2/svg/SVGStopElement.cpp:
(WebCore::SVGStopElement::createRenderer):
* ksvg2/svg/SVGStopElement.h:
(WebCore::SVGStopElement::rendererIsNeeded):
* rendering/RenderSVGGradientStop.cpp: Added.
* rendering/RenderSVGGradientStop.h: Added.
* rendering/RenderSVGHiddenContainer.cpp: Added.
* rendering/RenderSVGHiddenContainer.h: Added.
* rendering/RenderSVGContainer.cpp:
* rendering/RenderSVGContainer.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19362
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zack [Fri, 2 Feb 2007 14:41:23 +0000 (14:41 +0000)]
Fix scrolling-on-selection bug by correctly
scrolling to the offset instead of trying to
ensure visibility with margins
r=Lars
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19361
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zack [Fri, 2 Feb 2007 10:26:06 +0000 (10:26 +0000)]
actually set the pen on color setting
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19357
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zack [Fri, 2 Feb 2007 10:24:46 +0000 (10:24 +0000)]
Fix drawing of dashed and colored lines. Pen
has to be inherited for stroke to stay consistent.
r=Lars
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19356
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zack [Fri, 2 Feb 2007 09:49:48 +0000 (09:49 +0000)]
Compilation fix: forward declare d-ptr.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19355
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Fri, 2 Feb 2007 09:35:54 +0000 (09:35 +0000)]
- not reviewed, build fix
* wtf/ListHashSet.h:
(WTF::ListHashSetNodeAllocator::ListHashSetNodeAllocator): ummm, use union correctly
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19354
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Fri, 2 Feb 2007 09:14:15 +0000 (09:14 +0000)]
Reviewed by Darin.
- use a custom allocator for ListHashSet, to fix ~1% perf regression using it for form control
* wtf/ListHashSet.h:
(WTF::ListHashSetNodeAllocator::ListHashSetNodeAllocator):
(WTF::ListHashSetNodeAllocator::allocate):
(WTF::ListHashSetNodeAllocator::deallocate):
(WTF::ListHashSetNode::operator new):
(WTF::ListHashSetNode::operator delete):
(WTF::ListHashSetNode::destroy):
(WTF::ListHashSetTranslator::translate):
(WTF::::ListHashSet):
(WTF::::~ListHashSet):
(WTF::::add):
(WTF::::unlinkAndDelete):
(WTF::::deleteAllNodes):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19353
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Fri, 2 Feb 2007 09:09:59 +0000 (09:09 +0000)]
Reviewed by Darin.
- use a custom allocator for ListHashSet, to fix ~1% per regression using it for form control
* wtf/ListHashSet.h:
(WTF::ListHashSetNodeAllocator::ListHashSetNodeAllocator):
(WTF::ListHashSetNodeAllocator::allocate):
(WTF::ListHashSetNodeAllocator::deallocate):
(WTF::ListHashSetNode::operator new):
(WTF::ListHashSetNode::operator delete):
(WTF::ListHashSetNode::destroy):
(WTF::ListHashSetTranslator::translate):
(WTF::::ListHashSet):
(WTF::::~ListHashSet):
(WTF::::add):
(WTF::::unlinkAndDelete):
(WTF::::deleteAllNodes):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19352
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zack [Fri, 2 Feb 2007 08:41:12 +0000 (08:41 +0000)]
Make the frames white by default and get the
files that WebCore can handle render inside
the frames.
r=Lars
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19351
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Fri, 2 Feb 2007 07:43:25 +0000 (07:43 +0000)]
2007-02-01 Nicholas Shanks <webkit@nickshanks.com>
Reviewed by Mark.
Add support for CSS2 font-stretch property.
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/cssparser.cpp:
(WebCore::CSSParser::parseValue):
* css/cssstyleselector.cpp:
(WebCore::CSSStyleSelector::applyDeclarations):
(WebCore::CSSStyleSelector::applyProperty):
* platform/FontCache.cpp:
(WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey):
(WebCore::FontPlatformDataCacheKey::operator==):
(WebCore::computeHash):
(WebCore::FontPlatformDataCacheKeyTraits::deletedValue):
(WebCore::FontPlatformDataCacheKeyTraits::emptyValue):
(WebCore::FontCache::getCachedFontPlatformData):
* platform/FontDescription.h:
(WebCore::):
(WebCore::FontDescription::FontDescription):
(WebCore::FontDescription::stretch):
(WebCore::FontDescription::narrowerStretch):
(WebCore::FontDescription::widerStretch):
(WebCore::FontDescription::setStretch):
(WebCore::FontDescription::operator==):
* platform/mac/FontCacheMac.mm:
(WebCore::FontCache::createFontPlatformData):
* platform/mac/WebFontCache.mm:
(acceptableChoice):
(betterChoice):
(+[WebFontCache fontWithFamily:traits:size:]):
2007-02-01 Nicholas Shanks <webkit@nickshanks.com>
Reviewed by Mark.
CSS2 font-stretch property; uses American Typewriter and Helvetica Neue fonts,
requiring Regular, Condensed, Bold and Bold Condensed faces.
* fast/css/computed-style-expected.txt: Updated.
* fast/css/font-stretch-expected.checksum: Added.
* fast/css/font-stretch-expected.png: Added.
* fast/css/font-stretch-expected.txt: Added.
* fast/css/font-stretch.html: Added.
2007-02-01 Nicholas Shanks <webkit@nickshanks.com>
Reviewed by Mark.
Add support for CSS2 font-stretch property.
* WebInspector/webInspector/inspector.js:
* WebView/WebHTMLView.mm:
(-[WebHTMLView _addToStyle:fontA:fontB:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19350
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Fri, 2 Feb 2007 06:57:38 +0000 (06:57 +0000)]
Reviewed by Mark Rowe.
<rdar://problem/
4969201> REGRESSION: Safari applies the wrong font to BODY element at http://www.apple.com/downloads/dashboard/
* platform/mac/WebFontCache.mm:
(+[WebFontCache fontWithFamily:traits:size:]): Don't call [NSFont fontWithName:] with the desiredFamily on Tiger.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19349
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Fri, 2 Feb 2007 05:52:37 +0000 (05:52 +0000)]
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=12506
REGRESSION: Safari doesn't display hebrew text on a web page,
displayed correctly on Tiger
WebCore:
* loader/TextResourceDecoder.cpp:
(WebCore::TextResourceDecoder::checkForHeadCharset): Advance the pointer when necessary.
LayoutTests:
* fast/encoding/pseudo-tags-in-attributes-expected.txt: Changing back to success.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19348
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Fri, 2 Feb 2007 05:44:31 +0000 (05:44 +0000)]
Add a cookie interface for the Qt build.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19347
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin [Fri, 2 Feb 2007 03:11:49 +0000 (03:11 +0000)]
un-doing accidental change that made all of the files in tables/mozilla/bugs allow tabs. whoopsie!
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19346
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Fri, 2 Feb 2007 02:40:03 +0000 (02:40 +0000)]
Reviewed by Adele.
- fixed <rdar://problem/
4922764> ASSERTION: (!m_contentFunction) in PolicyCheck::call trying to visit feed URL (CNN, Apple, etc.)
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::stopPolicyCheck): Call new cancel method instead of call(false) on old check.
(WebCore::PolicyCheck::cancel): call any callback function that is set with false or PolicyIgnore as
appropriate.
* loader/FrameLoader.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19345
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Fri, 2 Feb 2007 01:34:40 +0000 (01:34 +0000)]
LayoutTests:
Reviewed by Darin.
Update test results that have console messages.
* dom/html/level2/html/HTMLFrameElement09-expected.txt:
* dom/html/level2/html/HTMLIFrameElement11-expected.txt:
* dom/xhtml/level2/html/HTMLBaseElement01-expected.txt:
* dom/xhtml/level2/html/HTMLBaseElement02-expected.txt:
* dom/xhtml/level2/html/frame-expected.txt:
* dom/xhtml/level2/html/iframe-expected.txt:
* editing/execCommand/
4920488-expected.txt:
* editing/selection/contenteditable-click-inside-expected.txt:
* editing/selection/contenteditable-click-outside-expected.txt:
* fast/AppleScript/001-expected.txt:
* fast/dynamic/015-expected.txt:
* fast/events/iframe-object-onload-expected.txt:
* fast/events/updateLayoutForHitTest-expected.txt:
* fast/forms/display-none-in-onchange-keyboard-expected.txt:
* fast/forms/input-text-click-inside-expected.txt:
* fast/forms/input-text-click-outside-expected.txt:
* fast/forms/selected-index-assert-expected.txt:
* fast/js/array-foreach-expected.txt:
* fast/js/array-some-expected.txt:
* fast/js/kde/exception_propagation-expected.txt:
* fast/js/kde/garbage-n-expected.txt:
* fast/js/kde/string-1-n-expected.txt:
* fast/js/kde/string-2-n-expected.txt:
* fast/parser/script-tag-with-trailing-slash-expected.txt:
* fast/table/click-near-anonymous-table-expected.txt:
* fast/tokenizer/002-expected.txt:
* fast/tokenizer/external-script-document-write_2-expected.txt:
* fast/tokenizer/script_extra_close-expected.txt:
* fast/xsl/transform-xhr-doc-expected.txt:
* http/tests/navigation/error404-goback-expected.txt:
* http/tests/xmlhttprequest/set-dangerous-headers-expected.txt:
* svg/W3C-SVG-1.1/animate-elem-30-t-expected.txt:
* svg/W3C-SVG-1.1/animate-elem-33-t-expected.txt:
* svg/W3C-SVG-1.1/animate-elem-34-t-expected.txt:
* svg/W3C-SVG-1.1/animate-elem-37-t-expected.txt:
* svg/W3C-SVG-1.1/animate-elem-41-t-expected.txt:
* svg/W3C-SVG-1.1/animate-elem-78-t-expected.txt:
* svg/W3C-SVG-1.1/color-prop-03-t-expected.txt:
* svg/W3C-SVG-1.1/interact-cursor-01-f-expected.txt:
* svg/W3C-SVG-1.1/linking-uri-01-b-expected.txt:
* svg/W3C-SVG-1.1/linking-uri-02-b-expected.txt:
* svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
* svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt:
* svg/W3C-SVG-1.1/shapes-polygon-01-t-expected.txt:
* svg/W3C-SVG-1.1/shapes-polyline-01-t-expected.txt:
* svg/W3C-SVG-1.1/struct-group-03-t-expected.txt:
* svg/W3C-SVG-1.1/struct-use-01-t-expected.txt:
* svg/W3C-SVG-1.1/styling-css-01-b-expected.txt:
* svg/W3C-SVG-1.1/styling-css-02-b-expected.txt:
* svg/W3C-SVG-1.1/styling-css-03-b-expected.txt:
* svg/custom/dynamic-empty-path-expected.txt:
* svg/custom/js-update-container-expected.txt:
* svg/custom/js-update-gradient-expected.txt:
* svg/custom/js-update-polygon-changes-expected.txt:
* svg/custom/js-update-polygon-removal-expected.txt:
* svg/custom/path-bad-data-expected.txt:
* svg/custom/polyline-hittest-expected.txt:
* svg/custom/polyline-invalid-points-expected.txt:
* svg/custom/polyline-setattribute-points-null-expected.txt:
* svg/custom/svgpolyparser-extra-space-expected.txt:
* svg/custom/use-modify-target-symbol-expected.txt:
* svg/custom/viewbox-syntax-expected.txt:
* tables/mozilla/bugs/bug53690-1-expected.txt:
* tables/mozilla/bugs/bug9024-expected.txt:
* tables/mozilla_expected_failures/bugs/bug3517-expected.txt:
* tables/mozilla_expected_failures/bugs/bug92868_1-expected.txt:
* tables/mozilla_expected_failures/core/captions1-expected.txt:
* tables/mozilla_expected_failures/dom/appendCells1-expected.txt:
* tables/mozilla_expected_failures/dom/appendCellsRebuild1-expected.txt:
* tables/mozilla_expected_failures/dom/insertTbodyExpand1-expected.txt:
* tables/mozilla_expected_failures/dom/insertTbodyRebuild1-expected.txt:
WebKitTools:
Reviewed by Darin.
* DumpRenderTree/UIDelegate.m:
(-[UIDelegate webView:addMessageToConsole:]):
Dump console messages.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19343
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin [Fri, 2 Feb 2007 00:52:29 +0000 (00:52 +0000)]
WebCore:
Reviewed by Hyatt.
Fix for http://bugs.webkit.org/show_bug.cgi?id=10517 REGRESSION
(r12065-r12082): Navigation graphic wraps to the next line on
duart.com and <rdar://problem/
4960505> REGRESSION: The Awesome
Windows Vista page has a layout error in the header table (10517)
The problem is that we never supported a quirk that other browsers
support where, under very specific circumstances, a table cell will
grow to fit an image inside of it. This is only a regression
because a bug was fixed were we were 1 pixel off in the calculation
of overflow in some cases.
* rendering/RenderBlock.cpp:
(WebCore::shouldGrowTableCellForImage):
(WebCore::RenderBlock::calcInlineMinMaxWidth):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19342
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lars [Thu, 1 Feb 2007 19:57:05 +0000 (19:57 +0000)]
Reviewed by Adam.
Fix form loading for the Qt build.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19341
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Thu, 1 Feb 2007 17:34:05 +0000 (17:34 +0000)]
* fast/encoding/pseudo-tags-in-attributes-expected.txt: Change test result to reflect failure
because bug 12506 isn't fixed yet; we'll change it back once the bug is re-fixed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19339
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zack [Thu, 1 Feb 2007 12:27:56 +0000 (12:27 +0000)]
Implement native look for comboboxes
and fix/implement popup menus. Also add the m_timestamp
and m_eventType setting to PlatformMouseEvent
r=Lars
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19338
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Thu, 1 Feb 2007 08:56:18 +0000 (08:56 +0000)]
Reviewed by Adam.
<rdar://problem/
4730469> REGRESSION: Assertion failure in -[WebDataSource(WebInternal) _bridge] when forwarding message
* WebView/WebDataSource.mm:
(-[WebDataSource subresources]): Check for being uncommitted and return emtpy result.
(-[WebDataSource subresourceForURL:]): ditto
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19337
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Thu, 1 Feb 2007 08:36:53 +0000 (08:36 +0000)]
LayoutTests:
Reviewed by Maciej.
- test for <rdar://problem/
4887428> REGRESSION: Implement slight delay for firing incremental onSearch event
* fast/forms/search-event-delay-expected.txt: Added.
* fast/forms/search-event-delay.html: Added.
WebCore:
Reviewed by Maciej.
- fix <rdar://problem/
4887428> REGRESSION: Implement slight delay for firing incremental onSearch event
* rendering/RenderTextControl.h:
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::RenderTextControl): Set up timer.
(WebCore::RenderTextControl::subtreeHasChanged): Start timer here instead of immediately sending event.
(WebCore::RenderTextControl::searchEventTimerFired): Added. Sends search event.
(WebCore::RenderTextControl::stopSearchEventTimer): Added.
(WebCore::RenderTextControl::startSearchEventTimer): Added. Sends search event right away if there is
no text. If there is some text, sets the timer using the same delay rule as NSSearchField. If you keep
typing, then the timer keeps getting reset 0.2 seconds into the future until you pause.
* html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::onSearch): Tell the renderer to
stop the timer, since we're sending a search event. This helps when a caller other than
the timer decides to send an explicit search event.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19336
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Thu, 1 Feb 2007 08:23:31 +0000 (08:23 +0000)]
Fix by Darin, reviewed by Maciej.
- fix ~10% performance regression from encoding fix
* loader/TextResourceDecoder.cpp:
(WebCore::TextResourceDecoder::checkForHeadCharset): Fix a logic
error which made huge strings accidentally.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19335
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lars [Thu, 1 Feb 2007 07:53:52 +0000 (07:53 +0000)]
fix the Qt build
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19334
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Thu, 1 Feb 2007 06:55:43 +0000 (06:55 +0000)]
LayoutTests:
Reviewed by Adam and Geoff.
- test for <rdar://problem/
4786767> REGRESSION: <select> controls are not resized when zooming text
* fast/forms/select-width-font-change-expected.txt: Added.
* fast/forms/select-width-font-change.html: Added.
WebCore:
Reviewed by Adam and Geoff.
- fix <rdar://problem/
4786767> REGRESSION: <select> controls are not resized when zooming text
Test: fast/forms/select-width-font-change.html
* rendering/RenderMenuList.h: Cleaned up formatting a bit. Removed unneeded include of PopupMenu.h.
Made a lot more things private, including the PopupMenuClient base class, all of the virtual
functions from PopupMenuClient, and the setTextFromOption function. Added updateOptionsWidth.
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::setStyle): Added code to call updateOptionsWidth when the font changes.
(WebCore::RenderMenuList::updateOptionsWidth): Added. Factored code out of updateFromElement.
Changed to do nothing when m_optionsWidth is already correct.
(WebCore::RenderMenuList::updateFromElement): Moved code to recomputed options width to the new
updateOptionsWidth function.
(WebCore::RenderMenuList::text): Made const.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19331
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver [Thu, 1 Feb 2007 06:02:09 +0000 (06:02 +0000)]
liver Hunt <oliver@apple.com>
Reviewed by Adam.
WebCore:
Migrate more drag and drop logic to WebCore, start preparing
to move EventHandler::handleDrag from EventHandlerMac to EventHandler
* WebCore.exp:
updating methods
* dom/Clipboard.cpp:
* dom/Clipboard.h:
(WebCore::Clipboard::Clipboard):
(WebCore::Clipboard::setDragHasStarted):
(WebCore::Clipboard::dragStarted):
Moving from ClipboardMac to Clipboard
* dom/EventTargetNode.cpp:
(WebCore::EventTargetNode::dispatchMouseEvent):
PlatformMouseEvent no longer lies about button state, however
DOM Events don't allow NoButton, so we need to convert NoButton
to LeftButton when we create a DOM Event from PlatformMouseEvent
* page/DragClient.h:
Tidying comment
* page/DragController.cpp:
(WebCore::createMouseEvent):
Updated for new PlatformMouseEvent constructors
(WebCore::DragController::mayStartDragAtEventLocation):
Migrated from WebKit
* page/DragController.h:
Added above function declarations
* page/EventHandler.cpp:
(WebCore::EventHandler::dragState):
(WebCore::EventHandler::dragHysteresisExceeded):
(WebCore::EventHandler::freeClipboard):
(WebCore::EventHandler::shouldDragAutoNode):
Moved from EventHandlerMac
(WebCore::EventHandler::handleMouseMoveEvent):
(WebCore::EventHandler::eventMayStartDrag):
(WebCore::EventHandler::handleMousePressEvent):
Use DragController
* page/EventHandler.h:
Added DragState struct definition to EventHandler
* page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::eventActivatedView):
(WebCore::EventHandler::handleDrag):
(WebCore::EventHandler::handleMouseUp):
(WebCore::EventHandler::mouseDown):
Update to use DragController and PlatformMouseEvent
* page/mac/WebCoreFrameBridge.h:
* page/mac/WebCoreFrameBridge.mm:
(-[WebCoreFrameBridge dragSourceMovedTo:]):
(-[WebCoreFrameBridge dragSourceEndedAt:operation:]):
Use DragController for state
WebKit:
Migrating methods to WebCore
* WebCoreSupport/WebFrameBridge.mm:
* WebView/WebHTMLView.mm:
* WebView/WebHTMLViewPrivate.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19327
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Thu, 1 Feb 2007 04:26:51 +0000 (04:26 +0000)]
LayoutTests:
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=12506
REGRESSION: Safari doesn't display hebrew text on a web page,
displayed correctly on Tiger
* fast/encoding/pseudo-tags-in-attributes-expected.txt: Added.
* fast/encoding/pseudo-tags-in-attributes.html: Added.
WebCore:
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=12506
REGRESSION: Safari doesn't display hebrew text on a web page,
displayed correctly on Tiger
* loader/TextResourceDecoder.cpp:
(WebCore::TextResourceDecoder::checkForHeadCharset): Skip over
quoted attributes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19324
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Thu, 1 Feb 2007 04:20:02 +0000 (04:20 +0000)]
Reviewed by Darin.
- fix http://bugs.webkit.org/show_bug.cgi?id=12510
Initialize the variable m_totalLoops
Is tested by LayoutTests/fast/css/MarqueeLayoutTest.html
* rendering/RenderLayer.cpp:
(WebCore::Marquee::Marquee):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19323
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Thu, 1 Feb 2007 03:51:00 +0000 (03:51 +0000)]
LayoutTests:
Reviewed by Maciej.
<rdar://problem/
4886776>
REGRESSION: After opening a web archive, location shows the actual URL, not the webarchive file
* webarchive/loading/resources/helloworld.webarchive: Added.
* webarchive/loading/test-loading-archive-expected.txt: Added.
* webarchive/loading/test-loading-archive.html: Added.
WebCore:
Reviewed by Maciej.
<rdar://problem/
4886776>
REGRESSION: After opening a web archive, location shows the actual URL, not the webarchive file
* WebCore.exp:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::continueLoadWithData):
* loader/FrameLoader.h:
New function which continues a load but using a given buffer instead.
WebKit:
Reviewed by Maciej.
<rdar://problem/
4886776>
REGRESSION: After opening a web archive, location shows the actual URL, not the webarchive file
"Revert" the change done in 13734.
* WebView/WebHTMLRepresentation.mm:
(-[WebHTMLRepresentation loadArchive]):
Don't do a new load here, as this would cancel the current load and call the resource load
delegate's didFailLoadingWithError: method. Instead, call continueLoadWithData.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19322
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Thu, 1 Feb 2007 03:30:39 +0000 (03:30 +0000)]
* DumpRenderTree/ResourceLoadDelegate.m:
(-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
Use an NSString here so we can guarantee that -description always returns the same value.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19321
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Thu, 1 Feb 2007 02:14:09 +0000 (02:14 +0000)]
Reviewed by Adam.
- fix sporadic crash
* wtf/ListHashSet.h:
(WTF::::remove): remove before deleting
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19320
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Thu, 1 Feb 2007 01:55:30 +0000 (01:55 +0000)]
Reviewed by Adam.
Fix for http://bugs.webkit.org/show_bug.cgi?id=12516
REGRESSION (r19313): All keyboard navigation has stopped working
For non-editable selections, handleKeyPress doesn't need to call _interceptEditingKeyEvent.
* editing/Editor.cpp:
(WebCore::selectionForEvent): Moved this to the top of the file.
(WebCore::Editor::handleKeyPress): Do the equivalent of the _canEdit check that used to be in WebKit WebEditorClient::handleKeyPress.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19319
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Thu, 1 Feb 2007 01:33:23 +0000 (01:33 +0000)]
Reviewed by Maciej.
Fix run-pageloadtest to actually work again.
* Misc/WebNSWindowExtras.m:
(+[NSWindow _webkit_displayThrottledWindows]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19318
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Thu, 1 Feb 2007 01:03:22 +0000 (01:03 +0000)]
WebCore:
Reviewed by Darin Adler.
Added a Range counter to detect leaks. Tweaked the Node counter.
Also fixed a TextIterator destructive modification bug that I noticed along the
way. No test case for this bug because no clients have been bitten by it
yet.
* dom/Node.cpp: Renamed NodeImplCounter to NodeCounter, changed counter
to unsigned, fixed formatting to match style guidelines.
(WebCore::NodeCounter::~NodeCounter):
(WebCore::Node::Node):
(WebCore::Node::~Node):
* dom/Range.cpp:
(WebCore::RangeCounter::~RangeCounter): Added.
(WebCore::Range::Range):
(WebCore::Range::~Range):
(WebCore::Range::ownerDocument): New accessor, used by TextIterator to avoid
annoying NULL checks.
* dom/Range.h:
* editing/TextIterator.cpp:
(WebCore::TextIterator::subrange):
(1) Don't initialize result with entireRange -- doing so would create a
PassRefPtr that pointed to entireRange, so this function would destructively
modify the Range you passed it. Initialize it with a new Range instead.
(2) Don't use a PassRefPtr as a local variable, because they have sneaky
semantics. Use a RefPtr instead.
(3) Don't call CharacterIterator::range() willy-nilly, since it does
non-trivial work. Use a local variable instead.
WebKitTools:
Reviewed by Darin Adler.
Added Selection::toRange to the leaks -exclude list, since it comes up
as a false positive (Radar
4967949).
Also added RangeCounter to the global initializer exclude list. I added
a RangeCounter since leaks won't detect all Range leaks anymore.
* Scripts/check-for-global-initializers:
* Scripts/run-webkit-tests:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19317
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Thu, 1 Feb 2007 00:31:52 +0000 (00:31 +0000)]
* DumpRenderTree/ResourceLoadDelegate.m:
(-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
Don't try to create an identifier if resource loads shouldn't be dumped.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19316
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Wed, 31 Jan 2007 23:00:19 +0000 (23:00 +0000)]
Reviewed by Geoff.
Add dumping of resource loads. This isn't completely tweaked yet since the test results would
rely on resources being delivered in the same order which might not always be true. However, it works good
enough for the simple webarchive tests I want to do right now.
* DumpRenderTree/DumpRenderTree.h:
* DumpRenderTree/DumpRenderTree.m:
(dumpRenderTree):
(+[LayoutTestController isSelectorExcludedFromWebScript:]):
(-[LayoutTestController dumpResourceLoadCallbacks]):
(runTest):
* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
* DumpRenderTree/ResourceLoadDelegate.h: Added.
* DumpRenderTree/ResourceLoadDelegate.m: Added.
Add new resource load delegate.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19315
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann [Wed, 31 Jan 2007 22:59:23 +0000 (22:59 +0000)]
Reviewed by Maciej.
Fix run-pageloadtest to actually work again.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19314
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Wed, 31 Jan 2007 22:55:56 +0000 (22:55 +0000)]
LayoutTests:
Reviewed by Darin.
Test for <rdar://problem/
4521461> REGRESSION: when keyPress event changes form focus, inserted key goes to wrong control
* fast/events/keypress-focus-change-expected.txt: Added.
* fast/events/keypress-focus-change.html: Added.
* fast/events/resources/keypress-frame.html: Added.
WebCore:
Reviewed by Darin.
WebCore part of fix for <rdar://problem/
4521461> REGRESSION: when keyPress event changes form focus, inserted key goes to wrong control
Test: fast/events/keypress-focus-change.html
* editing/Editor.cpp:
(WebCore::selectionForEvent): Added. This computes a selection that considers the case where an event handler
has moved the selection outside of a text control. In that case, we use the target control's selection.
(WebCore::Editor::insertText): This gets the selectionForEvent, checks that the selection is editable,
and calls TypingCommand::insertText with the correct selection.
* editing/TypingCommand.h: Added a version of insertText that takes a selection. The old version of insertText will call this, and pass
in the frame's selection.
* editing/TypingCommand.cpp: (WebCore::TypingCommand::insertText): Added. Uses the passed in selection to
set the starting and ending selections correctly so that the editing machinery will insert the text in the correct place.
* page/Page.h: Added convenience method to get selection from focused or main frame.
* page/Page.cpp: (WebCore::Page::selection):
* html/HTMLInputElement.h: Added selection methods to get selection for text controls.
* html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::selection):
* html/HTMLTextAreaElement.h:
* html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::selection):
* rendering/RenderTextControl.h:
* rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::selection):
WebKit:
Reviewed by Darin.
WebKit part of fix for <rdar://problem/
4521461> REGRESSION: when keyPress event changes form focus, inserted key goes to wrong control
* WebCoreSupport/WebEditorClient.mm: (WebEditorClient::handleKeyPress): Instead of using the selected frame, use the
frame for the target of the keyboard event. Also, don't do the canEdit check here, since the target's frame might not
have a selection at this point. Do the canEdit check within Editor::insertText, where we determine which selection to use
for inserting text.
* WebView/WebEditingDelegatePrivate.h: Added forward declaration of DOMHTMLElement. This is needed after reordering includes in WebEditorClient.mm.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19313
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Wed, 31 Jan 2007 22:01:34 +0000 (22:01 +0000)]
Backing out the CFRunLoopRunSpecific exclude command because it was overly
broad. We'll either need to work around this leak in DRT, or do some
custom grep-based leak ignoring.
* Scripts/run-webkit-tests:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19312
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aliceli1 [Wed, 31 Jan 2007 21:15:57 +0000 (21:15 +0000)]
Reviewed by Tim Hatcher.
Turning an accidental API change to an SPI change
* WebView/WebEditingDelegate.h:
* WebView/WebEditingDelegatePrivate.h:
move some declarations into private header.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19308
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 31 Jan 2007 15:08:49 +0000 (15:08 +0000)]
WebCore:
- fix build
* ForwardingHeaders/wtf/ListHashSet.h: Added.
WebKit:
- fix build
* ForwardingHeaders/wtf/ListHashSet.h: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19305
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zack [Wed, 31 Jan 2007 14:08:05 +0000 (14:08 +0000)]
Implement native colors for selections.
r=Lars
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19304
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zack [Wed, 31 Jan 2007 13:44:45 +0000 (13:44 +0000)]
Expose the fact that the form has been edited
in the public Qt api.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19303
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Wed, 31 Jan 2007 13:43:13 +0000 (13:43 +0000)]
JavaScriptCore:
Reviewed by Mark with help from Lars.
- added new ListHashSet class, which combines a hashtable and a linked list to provide a set
that keeps elements in inserted order
This is to assist in fixing the following:
<rdar://problem/
4751164> REGRESSION: Safari places text on incorrect button when returning to a page via back [10541]
http://bugs.webkit.org/show_bug.cgi?id=10541
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* wtf/HashTable.h:
(WTF::HashTable::find):
(WTF::HashTable::contains):
(WTF::::find):
(WTF::::contains):
* wtf/ListHashSet.h: Added.
(WTF::ListHashSetNode::ListHashSetNode):
(WTF::ListHashSetNodeHashFunctions::hash):
(WTF::ListHashSetNodeHashFunctions::equal):
(WTF::ListHashSetIterator::ListHashSetIterator):
(WTF::ListHashSetIterator::get):
(WTF::ListHashSetIterator::operator*):
(WTF::ListHashSetIterator::operator->):
(WTF::ListHashSetIterator::operator++):
(WTF::ListHashSetIterator::operator--):
(WTF::ListHashSetIterator::operator==):
(WTF::ListHashSetIterator::operator!=):
(WTF::ListHashSetIterator::operator const_iterator):
(WTF::ListHashSetIterator::node):
(WTF::ListHashSetConstIterator::ListHashSetConstIterator):
(WTF::ListHashSetConstIterator::get):
(WTF::ListHashSetConstIterator::operator*):
(WTF::ListHashSetConstIterator::operator->):
(WTF::ListHashSetConstIterator::operator++):
(WTF::ListHashSetConstIterator::operator--):
(WTF::ListHashSetConstIterator::operator==):
(WTF::ListHashSetConstIterator::operator!=):
(WTF::ListHashSetConstIterator::node):
(WTF::ListHashSetTranslator::hash):
(WTF::ListHashSetTranslator::equal):
(WTF::ListHashSetTranslator::translate):
(WTF::::ListHashSet):
(WTF::::operator):
(WTF::::~ListHashSet):
(WTF::::size):
(WTF::::capacity):
(WTF::::isEmpty):
(WTF::::begin):
(WTF::::end):
(WTF::::find):
(WTF::::contains):
(WTF::::add):
(WTF::::remove):
(WTF::::clear):
(WTF::::unlinkAndDelete):
(WTF::::appendNode):
(WTF::::deleteAllNodes):
(WTF::::makeIterator):
(WTF::::makeConstIterator):
(WTF::deleteAllValues):
WebCore:
Reviewed by Mark.
- fixed <rdar://problem/
4751164> REGRESSION: Safari places text on incorrect button when returning to a page via back [10541]
http://bugs.webkit.org/show_bug.cgi?id=10541
* dom/Document.cpp:
(WebCore::Document::formElementsState):
* dom/Document.h:
I couldn't figure out the back/forward support in the tests enough
to make an automated test, but this maual test reproduces the
problem 100% without this patch:
* manual-tests/back.html: Added.
* manual-tests/form-control-madness.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19302
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer [Wed, 31 Jan 2007 12:59:41 +0000 (12:59 +0000)]
Added Bugzilla bug number. Thanks Mitz!
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19301
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer [Wed, 31 Jan 2007 12:51:30 +0000 (12:51 +0000)]
WebCore:
Reviewed by Mitz.
No test cases since there is no change in functionality.
* rendering/bidi.cpp:
(WebCore::RenderBlock::findNextLineBreak): Simplify canFitOnLine expression.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19300
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zack [Wed, 31 Jan 2007 12:36:24 +0000 (12:36 +0000)]
Adding comments explaining how the focus ring implementation
works on the Qt platform and just move focus ring rendering
related code to the same spot.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19299
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Wed, 31 Jan 2007 12:20:57 +0000 (12:20 +0000)]
Reviewed by Eric.
- add back no-op version of silly method so that shipping Safari can still run the PLT
* Misc/WebNSWindowExtras.m:
(-[NSWindow _webkit_displayThrottledWindows]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19298
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zack [Wed, 31 Jan 2007 12:00:23 +0000 (12:00 +0000)]
Clean up key event handling on Qt.
r=Lars
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19297
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Wed, 31 Jan 2007 08:57:13 +0000 (08:57 +0000)]
Fix a double delete on cancel as well as a crash with proxy
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19296
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Wed, 31 Jan 2007 08:33:31 +0000 (08:33 +0000)]
2007-01-31 Mark Rowe <mrowe@apple.com>
More build fixing.
* Misc/WebKitLogging.h: Use !defined() rather than !.
* Plugins/WebNetscapePluginStream.h: Remove #if __cplusplus as this file is only included from Obj-C++ files.
* WebView/WebHTMLView.mm:
(-[WebHTMLView _lookUpInDictionaryFromMenu:]): Use #ifdef rather than #if.
* WebView/WebView.mm:
(-[WebView isGrammarCheckingEnabled]): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19295
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Wed, 31 Jan 2007 08:11:28 +0000 (08:11 +0000)]
2007-01-31 Mark Rowe <mrowe@apple.com>
Build fix.
* WebView/WebView.mm:
(-[WebView initWithFrame:frameName:groupName:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19294
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Wed, 31 Jan 2007 08:10:22 +0000 (08:10 +0000)]
fix a crash on exit
remove focusFrame
add childFrames
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19293
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Wed, 31 Jan 2007 07:26:13 +0000 (07:26 +0000)]
2007-01-31 Mark Rowe <mrowe@apple.com>
Reviewed by Oliver.
Enable -Wundef in WebKit, and change misuses of #if to #ifdef or #ifndef as appropriate.
* Misc/WebKitLogging.h:
* WebKit.xcodeproj/project.pbxproj:
* WebView/WebFrame.mm:
* WebView/WebFrameInternal.h:
* WebView/WebHTMLView.mm:
(-[WebHTMLView validateUserInterfaceItem:]):
(-[WebHTMLView delete:]):
(-[WebHTMLView showGuessPanel:]):
(-[WebHTMLView copy:]):
(-[WebHTMLView cut:]):
(-[WebHTMLView paste:]):
* WebView/WebHTMLViewInternal.h:
* WebView/WebView.mm:
(-[WebViewPrivate init]):
(-[WebView validateUserInterfaceItem:]):
* WebView/WebViewPrivate.h:
2007-01-31 Mark Rowe <mrowe@apple.com>
Reviewed by Oliver.
* dom/Document.h: Change #if XSLT_SUPPORT to #ifdef XSLT_SUPPORT.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19292
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lars [Wed, 31 Jan 2007 07:20:24 +0000 (07:20 +0000)]
Fix the Qt build.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19291
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zack [Wed, 31 Jan 2007 06:43:50 +0000 (06:43 +0000)]
Implement SVGImage on the Qt platform.
r=Eric
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19290
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Wed, 31 Jan 2007 05:45:47 +0000 (05:45 +0000)]
Reviewed by Brady.
- fixed <rdar://problem/
4939366> REGRESSION: Assertion failure and crash when going back in history (12314)
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::createWindow): special case a frame name of "_blank"
(WebCore::FrameLoader::continueLoadAfterNewWindowPolicy): ditto
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19289
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Wed, 31 Jan 2007 05:24:05 +0000 (05:24 +0000)]
Reviewed by Beth Dakin.
Filed some more Radars in other components, added some more leaks to the
exclusion list.
* Scripts/run-webkit-tests: Ignore leaks in CFNotificationCenterAddObserver,
CFRunLoopRunSpecific, and NSSpellChecker.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19288
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer [Wed, 31 Jan 2007 03:31:04 +0000 (03:31 +0000)]
LayoutTests:
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=11882
Need a way to regression test .webarchive output files
Created webarchive tests that exercise various features of the WebArchive format.
* webarchive/resources/apple.gif: Copied from fast/canvas/resources/apple.gif.
* webarchive/resources/dump-webarchive.js: Added.
* webarchive/resources/test-frame.html: Added.
* webarchive/resources/test-style.css: Added.
* webarchive/test-body-background-expected.txt: Added.
* webarchive/test-body-background.html: Added.
* webarchive/test-duplicate-resources-expected.txt: Added.
* webarchive/test-duplicate-resources.html: Added.
* webarchive/test-frameset-expected.txt: Added.
* webarchive/test-frameset.html: Added.
* webarchive/test-img-src-expected.txt: Added.
* webarchive/test-img-src.html: Added.
* webarchive/test-input-src-expected.txt: Added.
* webarchive/test-input-src.html: Added.
* webarchive/test-link-href-expected.txt: Added.
* webarchive/test-link-href.html: Added.
* webarchive/test-object-data-expected.txt: Added.
* webarchive/test-object-data.html: Added.
* webarchive/test-script-src-expected.txt: Added.
* webarchive/test-script-src.html: Added.
* webarchive/test-table-background-expected.txt: Added.
* webarchive/test-table-background.html: Added.
* webarchive/test-td-background-expected.txt: Added.
* webarchive/test-td-background.html: Added.
WebKitTools:
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=11882
Need a way to regression test .webarchive output files
Implement layoutTestController.dumpAsWebArchive() to test WebArchive format.
Alters WebResourceResponse and WebResourceURL properties within WebArchive format
to normalize URLs to remove path where WebKit was checked out. Also converts
WebDataResource properties from data to string if the corresponding
WebResourceMIMEType property starts with "text/" or equals
"application/x-javascript".
* DumpRenderTree/DumpRenderTree.m:
(convertWebResourceDataToString): Added.
(normalizeWebResourceURL): Added.
(normalizeWebResourceResponse): Added.
(serializeWebArchiveToXML): Added.
(dump):
(+[LayoutTestController isSelectorExcludedFromWebScript:]):
(-[LayoutTestController dumpAsWebArchive]): Added.
(runTest):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19284
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Wed, 31 Jan 2007 02:40:54 +0000 (02:40 +0000)]
Reviewed by Anders.
- fixed <rdar://problem/
4963871> REGRESSION: Crash occurs at WebCore::Frame::loader() when attempting to open a saved archive file
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::request): Removed obsolete FIXME.
(WebCore::DocumentLoader::initialRequest): Ditto.
* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::MainResourceLoader): Handle data loads from a timer, otherwise bad things happen.
(WebCore::MainResourceLoader::handleDataLoadNow):
(WebCore::MainResourceLoader::handleDataLoadSoon):
(WebCore::MainResourceLoader::loadNow):
(WebCore::MainResourceLoader::didCancel): cancel data load timer
* loader/MainResourceLoader.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19281
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Wed, 31 Jan 2007 02:31:34 +0000 (02:31 +0000)]
Reviewed by Oliver
This is a corollary to <rdar://problem/
4944887> where certain things happened on an alternate thread.
To help catch such behavior in the future, add ASSERT_MAIN_THREAD() to key WebKit API points
* History/WebHistoryItem.mm: Added ASSERT_MAIN_THREAD() to suspected API entry points
(-[WebHistoryItem dealloc]):
(-[WebHistoryItem finalize]):
(-[WebHistoryItem copyWithZone:]):
(-[WebHistoryItem URLString]):
(-[WebHistoryItem originalURLString]):
(-[WebHistoryItem title]):
(-[WebHistoryItem lastVisitedTimeInterval]):
(-[WebHistoryItem isEqual:]):
(-[WebHistoryItem description]):
(-[WebHistoryItem initWithWebCoreHistoryItem:]):
(-[WebHistoryItem initFromDictionaryRepresentation:]):
(-[WebHistoryItem scrollPoint]):
(-[WebHistoryItem dictionaryRepresentation]):
(-[WebHistoryItem target]):
(-[WebHistoryItem visitCount]):
(-[WebHistoryItem children]):
(-[WebHistoryItem URL]):
(-[WebHistoryItem _lastVisitedDate]):
(-[WebHistoryItem targetItem]):
* Misc/WebIconDatabase.mm: Added ASSERT_MAIN_THREAD() to suspected API entry points
(-[WebIconDatabase iconForURL:withSize:cache:]):
(-[WebIconDatabase iconURLForURL:]):
(-[WebIconDatabase defaultIconWithSize:]):
(-[WebIconDatabase retainIconForURL:]):
(-[WebIconDatabase releaseIconForURL:]):
(-[WebIconDatabase removeAllIcons]):
(-[WebIconDatabase _iconForFileURL:withSize:]):
(webGetNSImage):
* Misc/WebKitLogging.h: Added ASSERT_MAIN_THREAD()
* Misc/WebKitLogging.m:
(WebKitRunningOnMainThread): Added
* WebKit.xcodeproj/project.pbxproj: Define DISABLE_THREAD_CHECK until it is
safe to run with ASSERT_MAIN_THREAD() active
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19280
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Tue, 30 Jan 2007 23:57:56 +0000 (23:57 +0000)]
Add layout test for invalid pseudo-classes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19279
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Tue, 30 Jan 2007 23:56:54 +0000 (23:56 +0000)]
Reviewed by Darin.
<rdar://problem/
4961953> Stop using NSString deprecated methods like initWithCString:
* Misc/WebNSImageExtras.m:
(-[NSImage _web_saveAndOpen]):
* WebKit.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19278
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Tue, 30 Jan 2007 23:55:43 +0000 (23:55 +0000)]
Reviewed by Darin.
<rdar://problem/
4961953> Stop using NSString deprecated methods like initWithCString:
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/svg/filters/cg/WKArithmeticFilter.m:
(-[WKArithmeticFilter init]):
* platform/graphics/svg/filters/cg/WKComponentMergeFilter.m:
(-[WKComponentMergeFilter init]):
* platform/graphics/svg/filters/cg/WKDiffuseLightingFilter.m:
(-[WKDiffuseLightingFilter init]):
* platform/graphics/svg/filters/cg/WKDiscreteTransferFilter.m:
(-[WKDiscreteTransferFilter init]):
* platform/graphics/svg/filters/cg/WKDisplacementMapFilter.m:
(-[WKDisplacementMapFilter init]):
* platform/graphics/svg/filters/cg/WKDistantLightFilter.m:
(-[WKDistantLightFilter init]):
* platform/graphics/svg/filters/cg/WKGammaTransferFilter.m:
(-[WKGammaTransferFilter init]):
* platform/graphics/svg/filters/cg/WKLinearTransferFilter.m:
(-[WKLinearTransferFilter init]):
* platform/graphics/svg/filters/cg/WKNormalMapFilter.m:
(-[WKNormalMapFilter init]):
* platform/graphics/svg/filters/cg/WKPointLightFilter.m:
(-[WKPointLightFilter init]):
* platform/graphics/svg/filters/cg/WKSpecularLightingFilter.m:
(-[WKSpecularLightingFilter init]):
* platform/graphics/svg/filters/cg/WKSpotLightFilter.m:
(-[WKSpotLightFilter init]):
* platform/graphics/svg/filters/cg/WKTableTransferFilter.m:
(-[WKTableTransferFilter init]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19277
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Tue, 30 Jan 2007 23:54:57 +0000 (23:54 +0000)]
Fix for Radar bug #
4679426, golden gate bridge Web site layout broken.
This is a regression caused by the addition of :lang support. This
feature caused us to accept any pseudo-class/element with function
arguments, even ones we couldn't handle. The site used such a construct
in conjunction with :not, which turned :not(something-crazy) into not(false).
This ended up being "true", and so we started matching a rule we used to
reject.
The fix is to now aggressively parse pseudo-elements and classes and to
cause the rejection of an entire rule if any pseudoclass or element within
any simple selector of that rule is unrecognized.
Reviewed by darin
fast/css/invalid-pseudo-classes.html
* css/CSSGrammar.y:
* css/CSSSelector.cpp:
(WebCore::CSSSelector::extractPseudoType):
* css/CSSSelector.h:
(WebCore::CSSSelector::):
* css/cssstyleselector.cpp:
(WebCore::CSSStyleSelector::checkOneSelector):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19276
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Tue, 30 Jan 2007 23:24:24 +0000 (23:24 +0000)]
LayoutTests:
Reviewed by Geoff.
- test for http://bugs.webkit.org/show_bug.cgi?id=12050
REGRESSION: Assertion failure in -[WebBaseNetscapePluginView willCallPlugInFunction] (plugin)
* plugins/createScriptableObject-before-start-expected.txt: Added.
* plugins/createScriptableObject-before-start.html: Added.
WebKit:
Reviewed by Geoff.
- fix http://bugs.webkit.org/show_bug.cgi?id=12050
REGRESSION: Assertion failure in -[WebBaseNetscapePluginView willCallPlugInFunction] (plugin)
Test: plugins/createScriptableObject-before-start.html
* Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView createPluginScriptableObject]): Return NULL if
the plugin is not started.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19275
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Tue, 30 Jan 2007 23:14:17 +0000 (23:14 +0000)]
Reviewed by Anders.
<rdar://problem/
4964407> REGRESSION: Mail hangs when replying, forwarding , or creating a new message
* WebView/WebFrame.mm:
(-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): Set WebDataRequest property on data
load requests since Mail specifically checks for this.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19274
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Tue, 30 Jan 2007 23:02:00 +0000 (23:02 +0000)]
LayoutTests:
Reviewed by Darin.
- test for http://bugs.webkit.org/show_bug.cgi?id=12487
REGRESSION: Repro crash when a second background image is animated
* fast/images/animated-background-image-crash-expected.txt: Added.
* fast/images/animated-background-image-crash.html: Added.
* fast/images/resources/animated.gif: Added.
* fast/images/resources/animated2.gif: Added.
WebCore:
Reviewed by Darin.
- fix http://bugs.webkit.org/show_bug.cgi?id=12487
REGRESSION: Repro crash when a second background image is animated
Test: fast/images/animated-background-image-crash.html
* rendering/RenderObject.cpp:
(WebCore::RenderObject::arenaDelete): Deref() all background images and the
border image.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19273
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Tue, 30 Jan 2007 22:57:01 +0000 (22:57 +0000)]
2007-01-31 Mark Rowe <mrowe@apple.com>
Reviewed by Mitz.
Re-enable editing/pasteboard/paste-{RTFD,TIFF}.html now that a fix has been landed for:
http://bugs.webkit.org/show_bug.cgi?id=12474
REGRESSION(r19244): Assertion failure in layout tests: ASSERTION FAILED: loader->handle()
* editing/pasteboard/paste-RTFD.html: Added.
* editing/pasteboard/paste-RTFD.html-disabled: Removed.
* editing/pasteboard/paste-TIFF.html: Added.
* editing/pasteboard/paste-TIFF.html-disabled: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19272
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Tue, 30 Jan 2007 22:53:53 +0000 (22:53 +0000)]
Reviewed by Maciej.
* dom/EventTarget.h:
* dom/EventTarget.cpp: (WebCore::EventTarget::toNode):
Use EventTargetNode instead of Node. Removed unneeded includes.
Make EventTarget's destructor protected to make it clear that you
should never delete one.
* dom/EventTargetNode.h:
(WebCore::EventTargetNode::toNode):
Tweaked formatting. Updated for change to return value.
* platform/graphics/BitmapImage.h: Updated comment for clarity.
Marked FrameData Noncopyable.
* platform/graphics/Image.h: Tweaked formatting.
* platform/graphics/ImageAnimationObserver.h:
Make ImageAnimationObserver's destructor protected to make it clear that you
should never delete one.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19271
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Tue, 30 Jan 2007 22:36:05 +0000 (22:36 +0000)]
LayoutTests:
Reviewed by Darin (by way of Hyatt).
- test for http://bugs.webkit.org/show_bug.cgi?id=12373
ASSERTION FAILURE: !child->needsLayout() on paypal.com
* fast/table/inline-form-assert-expected.checksum: Added.
* fast/table/inline-form-assert-expected.png: Added.
* fast/table/inline-form-assert-expected.txt: Added.
* fast/table/inline-form-assert.html: Added.
WebCore:
Reviewed by Darin (by way of Hyatt).
- fix http://bugs.webkit.org/show_bug.cgi?id=12373
ASSERTION FAILURE: !child->needsLayout() on paypal.com
Test: fast/table/inline-form-assert.html
* rendering/RenderContainer.cpp:
(WebCore::RenderContainer::layout): Changed the assertion to ignore inlines.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19270
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Tue, 30 Jan 2007 22:25:24 +0000 (22:25 +0000)]
LayoutTests:
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=12486
XPathNSResolver.lookupNamespaceURI should return null if no URI is found
* dom/svg/level3/xpath/XPathNSResolver_lookupNamespaceURI_nist_dmstc-expected.txt:
* dom/svg/level3/xpath/XPathNSResolver_lookupNamespaceURI_null-expected.txt:
These tests now pass.
WebCore:
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=12486
XPathNSResolver.lookupNamespaceURI should return null if no URI is found
* xml/XPathNSResolver.idl: added [ConvertNullStringTo=Null].
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19269
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Tue, 30 Jan 2007 22:07:21 +0000 (22:07 +0000)]
* kjs/DateMath.cpp: Fix license header to reflect LGPL as the first license
mentioned. We still mention the option of using under MPL or GPL since some
of this code came from the Mozilla project with those license terms.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19268
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Tue, 30 Jan 2007 22:04:28 +0000 (22:04 +0000)]
Reviewed by Maciej.
Revert the parts of 19244 that removed deferring NSURLConnections, that was not a correct change.
Remove ASSERTS from loader.cpp that aren't true anymore since the callbacks are invoked without a handle
when loading a subresource from an archive.
* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::loadNow):
* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::releaseResources):
(WebCore::ResourceLoader::load):
(WebCore::ResourceLoader::setDefersLoading):
* loader/loader.cpp:
(WebCore::Loader::didFail):
(WebCore::Loader::didReceiveResponse):
(WebCore::Loader::didReceiveData):
* platform/network/ResourceHandle.cpp:
(WebCore::ResourceHandle::ResourceHandle):
(WebCore::ResourceHandle::create):
* platform/network/ResourceHandle.h:
* platform/network/ResourceHandleInternal.h:
(WebCore::ResourceHandleInternal::ResourceHandleInternal):
* platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::setDefersLoading):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19267
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Tue, 30 Jan 2007 21:57:43 +0000 (21:57 +0000)]
Reviewed by John.
- fix for <rdar://problem/
4911504> REGRESSION: With a image selected, ctrl-clicking
on page displays the wrong contextual menu items "Search in Google", "Search in Spotlight"
and "Look up in Dictionary"
* platform/ContextMenu.cpp:
(WebCore::selectionContainsPossibleWord): Added. Returns true if there are some
non-whitespace characters in the selection.
(WebCore::ContextMenu::populate): Don't add SearchSpotlightItem, SearchWebItem,
or LookInDictionaryItem if selectionContainsPossibleWord returns false.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19266
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann [Tue, 30 Jan 2007 20:59:25 +0000 (20:59 +0000)]
Reviewed by Oliver.
Respect stroke-width in absolute repaint rect calculations for SVG text.
Added test: svg/custom/text-repaint-including-stroke.svg
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19265
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken [Tue, 30 Jan 2007 20:46:11 +0000 (20:46 +0000)]
2007-01-30 Steve Falkenburg <sfalken@apple.com>
Reviewed by Oliver.
Add missing includes.
* ksvg2/svg/SVGElementInstance.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19264
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Tue, 30 Jan 2007 19:01:59 +0000 (19:01 +0000)]
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=12452
XPath id() function is not supported
WebCore:
* xml/XPathFunctions.cpp:
(WebCore::XPath::isWhitespace): A helper to detect XML whitespace.
(WebCore::XPath::FunId::isConstant):
(WebCore::XPath::FunId::doEvaluate):
(WebCore::XPath::FunctionMapping::):
Implemented id().
LayoutTests:
* dom/svg/level3/xpath/Conformance_ID-expected.txt:
This test now passes.
* fast/xpath/complex-id-expected.txt: Added.
* fast/xpath/complex-id.html: Added.
A test for more advanced id() capabilities.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19263
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zack [Tue, 30 Jan 2007 15:47:55 +0000 (15:47 +0000)]
Make the gradients work on the Qt platform.
r=Sam
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19261
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer [Tue, 30 Jan 2007 14:22:38 +0000 (14:22 +0000)]
WebKitTools:
Reviewed by Mark Rowe.
http://bugs.webkit.org/show_bug.cgi?id=12470
svn-create-patch creates duplicate patches for files within an added/modified directory
* Scripts/svn-create-patch:
(sub generateFileList($\%\%)): Ignore directories when generating the file list.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19256
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Tue, 30 Jan 2007 14:04:10 +0000 (14:04 +0000)]
2007-01-31 Mark Rowe <mrowe@apple.com>
Disable editing/pasteboard/paste-{RTFD,TIFF}.html so tests run to completion until a fix is landed for:
http://bugs.webkit.org/show_bug.cgi?id=12474
REGRESSION(r19244): Assertion failure in layout tests: ASSERTION FAILED: loader->handle()
* editing/pasteboard/paste-RTFD.html: Removed.
* editing/pasteboard/paste-RTFD.html-disabled: Added.
* editing/pasteboard/paste-TIFF.html: Removed.
* editing/pasteboard/paste-TIFF.html-disabled: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19255
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann [Tue, 30 Jan 2007 12:44:03 +0000 (12:44 +0000)]
Reviewed by Eric & Oliver. Leak related fixes reviewed by Mark.
Finally make the SVG <use> implementation use the proper "shadow tree" concept,
which is also used by the HTML forms implementation. It's the first time in ksvg
history that <use> is not implement as a crude hack, but proper & sane.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19254
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zack [Tue, 30 Jan 2007 12:09:49 +0000 (12:09 +0000)]
Improve QtLauncher to make it more useful as a testing tool.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19253
268f45cc-cd09-0410-ab3c-
d52691b4dbfc