WebKit-https.git
8 years ago[EFL] Move ImageDiff to the Tools directory root
thiago.santos@intel.com [Wed, 19 Dec 2012 15:05:46 +0000 (15:05 +0000)]
[EFL] Move ImageDiff to the Tools directory root
https://bugs.webkit.org/show_bug.cgi?id=105305

Reviewed by Laszlo Gombos.

We previously moved this directory from the DRT directory to
efl/ImageDiff. The major reason for doing so was because ImageDiff does
not depend on DumpRenderTree but for legacy reasons was living inside the
DRT folder, even though it is needed when running pixel tests for WK2.

Now we are moving to Tool directory root as other ports agreed to do the same.

* CMakeLists.txt:
* ImageDiff/CMakeLists.txt: Added.
* ImageDiff/PlatformEfl.cmake: Added.
* ImageDiff/efl/ImageDiff.cpp: Renamed from Tools/efl/ImageDiff/ImageDiff.cpp.
* efl/ImageDiff/CMakeLists.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Texmap] Instead of having multiple shaders sources with lots of duplication, we...
commit-queue@webkit.org [Wed, 19 Dec 2012 14:52:12 +0000 (14:52 +0000)]
[Texmap] Instead of having multiple shaders sources with lots of duplication, we should have one shader source with MACRO variants
https://bugs.webkit.org/show_bug.cgi?id=104815

Patch by No'am Rosenthal <noam@webkit.org> on 2012-12-19
Reviewed by Kenneth Rohde Christiansen.

Created templates for the vertex and fragment shaders, and added some MACROs in
TextureMapperShaderManager to allow GLSL precompiler-based configuration.

The template follows a pattern where the main function in the shader calls
applyFooBarIfNeeded(), while applyFooBar() is implemented. The Macros prepended to the template define whether applyIfNeeded resolves to the real function or to a noop.

In addition, made some small changes to the filter shaders so that they can use the same code as the normal shaders.

Covered by existing pixel/ref tests when run on Qt/EFL/GTK.

* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::drawTexture):
(WebCore::TextureMapperGL::drawSolidColor):
(WebCore::TextureMapperGL::drawTextureWithAntialiasing):
(WebCore::optionsForFilterType):
(WebCore):
(WebCore::getPassesRequiredForFilter):
(WebCore::prepareFilterProgram):
(WebCore::TextureMapperGL::drawFiltered):
(WebCore::BitmapTextureGL::applyFilters):
    Always draw using the drawQuad function, and use the new TextureMapperShaderManager::Options mask instead of the old ShaderKey.

* platform/graphics/texmap/TextureMapperShaderManager.cpp:
(WebCore):
(WebCore::getShaderSpec):
(WebCore::TextureMapperShaderManager::getShaderProgram):
* platform/graphics/texmap/TextureMapperShaderManager.h:
(TextureMapperShaderProgram):
(TextureMapperShaderManager):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening, update pixel results.
ossy@webkit.org [Wed, 19 Dec 2012 14:48:55 +0000 (14:48 +0000)]
[Qt] Unreviewed gardening, update pixel results.

* platform/qt-5.0-wk2/fast/backgrounds/transformed-body-background-expected.png: Removed.
* platform/qt-5.0-wk2/fast/backgrounds/transformed-body-html-background-expected.png: Removed.
* platform/qt-5.0-wk2/fast/backgrounds/transformed-html-body-background-expected.png: Removed.
* platform/qt-5.0-wk2/fast/forms/datalist/input-appearance-range-with-transform-expected.png: Removed.
* platform/qt-5.0-wk2/fast/layers/scroll-with-transform-composited-layer-expected.png: Removed.
* platform/qt-5.0-wk2/svg/dom/SVGLengthList-getItem-expected.png: Removed.
* platform/qt-5.0-wk2/svg/dom/SVGLengthList-initialize-expected.png: Removed.
* platform/qt-5.0-wk2/svg/dom/SVGLengthList-replaceItem-expected.png: Removed.
* platform/qt/compositing/masks/masked-ancestor-expected.png:
* platform/qt/compositing/reflections/reflection-in-composited-expected.png:
* platform/qt/compositing/shadows/shadow-drawing-expected.png:
* platform/qt/css1/box_properties/border_style-expected.png:
* platform/qt/css2.1/t0805-c5517-brdr-s-00-c-expected.png:
* platform/qt/css2.1/t0805-c5519-brdr-r-01-e-expected.png:
* platform/qt/css2.1/t170602-bdr-conflct-w-04-d-expected.png:
* platform/qt/css2.1/t170602-bdr-conflct-w-14-d-expected.png:
* platform/qt/css2.1/t170602-bdr-conflct-w-24-d-expected.png:
* platform/qt/css2.1/t170602-bdr-conflct-w-34-d-expected.png:
* platform/qt/css2.1/t170602-bdr-conflct-w-44-d-expected.png:
* platform/qt/css2.1/t170602-bdr-conflct-w-54-d-expected.png:
* platform/qt/css2.1/t170602-bdr-conflct-w-64-d-expected.png:
* platform/qt/css2.1/t170602-bdr-conflct-w-74-d-expected.png:
* platform/qt/css2.1/t170602-bdr-conflct-w-84-d-expected.png:
* platform/qt/css2.1/t170602-bdr-conflct-w-94-d-expected.png:
* platform/qt/editing/deleting/delete-at-paragraph-boundaries-007-expected.png:
* platform/qt/editing/deleting/delete-at-paragraph-boundaries-009-expected.png:
* platform/qt/editing/selection/extend-by-character-002-expected.png:
* platform/qt/editing/selection/extend-by-character-004-expected.png:
* platform/qt/editing/selection/move-by-character-002-expected.png:
* platform/qt/editing/selection/move-by-character-004-expected.png:
* platform/qt/fast/backgrounds/animated-svg-as-mask-expected.png:
* platform/qt/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
* platform/qt/fast/backgrounds/transformed-body-background-expected.png: Added.
* platform/qt/fast/backgrounds/transformed-body-html-background-expected.png: Added.
* platform/qt/fast/backgrounds/transformed-html-body-background-expected.png: Added.
* platform/qt/fast/css/outline-auto-empty-rects-expected.png:
* platform/qt/fast/css/outline-auto-location-expected.png:
* platform/qt/fast/css/resize-corner-tracking-transformed-expected.png:
* platform/qt/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.png:
* platform/qt/fast/forms/datalist/input-appearance-range-with-datalist-expected.png: Renamed from LayoutTests/platform/qt-5.0-wk2/fast/forms/datalist/input-appearance-range-with-datalist-expected.png.
* platform/qt/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png: Renamed from LayoutTests/platform/qt-5.0-wk2/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png.
* platform/qt/fast/forms/datalist/input-appearance-range-with-padding-with-datalist-expected.png: Renamed from LayoutTests/platform/qt-5.0-wk2/fast/forms/datalist/input-appearance-range-with-padding-with-datalist-expected.png.
* platform/qt/fast/forms/datalist/input-appearance-range-with-transform-expected.png: Added.
* platform/qt/fast/forms/number/number-appearance-rtl-expected.png:
* platform/qt/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png:
* platform/qt/fast/forms/select-baseline-expected.png:
* platform/qt/fast/inline/continuation-outlines-expected.png:
* platform/qt/fast/layers/scroll-with-transform-composited-layer-expected.png: Added.
* platform/qt/fast/layers/scroll-with-transform-layer-expected.png: Renamed from LayoutTests/platform/qt-5.0-wk2/fast/layers/scroll-with-transform-layer-expected.png.
* platform/qt/fast/multicol/vertical-lr/float-avoidance-expected.png:
* platform/qt/fast/multicol/vertical-rl/float-avoidance-expected.png:
* platform/qt/fast/overflow/overflow-with-local-background-attachment-expected.png:
* platform/qt/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.png:
* platform/qt/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.png:
* platform/qt/fast/repaint/line-flow-with-floats-in-regions-expected.png:
* platform/qt/fast/repaint/reflection-repaint-test-expected.png:
* platform/qt/fast/repaint/region-painting-invalidation-expected.png:
* platform/qt/fast/repaint/region-painting-via-layout-expected.png:
* platform/qt/fast/repaint/transform-repaint-descendants-expected.png:
* platform/qt/fast/replaced/selection-rect-transform-expected.png:
* platform/qt/fast/table/035-vertical-expected.png:
* platform/qt/fast/table/border-collapsing/001-expected.png:
* platform/qt/fast/table/border-collapsing/001-vertical-expected.png:
* platform/qt/fast/table/border-collapsing/004-vertical-expected.png:
* platform/qt/fast/transforms/transform-table-row-expected.png:
* platform/qt/fast/transforms/transformed-caret-expected.png:
* platform/qt/fast/writing-mode/box-shadow-vertical-lr-expected.png:
* platform/qt/fast/writing-mode/box-shadow-vertical-rl-expected.png:
* platform/qt/svg/W3C-SVG-1.1/animate-elem-11-t-expected.png:
* platform/qt/svg/W3C-SVG-1.1/animate-elem-22-b-expected.png:
* platform/qt/svg/W3C-SVG-1.1/animate-elem-33-t-expected.png:
* platform/qt/svg/W3C-SVG-1.1/animate-elem-84-t-expected.png:
* platform/qt/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
* platform/qt/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
* platform/qt/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.png:
* platform/qt/svg/W3C-SVG-1.1/masking-path-03-b-expected.png:
* platform/qt/svg/W3C-SVG-1.1/paths-data-04-t-expected.png:
* platform/qt/svg/W3C-SVG-1.1/paths-data-06-t-expected.png:
* platform/qt/svg/W3C-SVG-1.1/paths-data-08-t-expected.png:
* platform/qt/svg/W3C-SVG-1.1/pservers-grad-07-b-expected.png:
* platform/qt/svg/W3C-SVG-1.1/text-align-02-b-expected.png:
* platform/qt/svg/W3C-SVG-1.1/text-path-01-b-expected.png:
* platform/qt/svg/W3C-SVG-1.1/text-tspan-01-b-expected.png:
* platform/qt/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.png:
* platform/qt/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.png:
* platform/qt/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.png:
* platform/qt/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png:
* platform/qt/svg/as-background-image/svg-as-background-5-expected.png:
* platform/qt/svg/batik/paints/patternPreserveAspectRatioA-expected.png:
* platform/qt/svg/batik/text/smallFonts-expected.png:
* platform/qt/svg/batik/text/textAnchor-expected.png:
* platform/qt/svg/batik/text/textGlyphOrientationHorizontal-expected.png:
* platform/qt/svg/batik/text/textOnPath-expected.png:
* platform/qt/svg/batik/text/textOnPath2-expected.png:
* platform/qt/svg/batik/text/textOnPathSpaces-expected.png:
* platform/qt/svg/batik/text/verticalText-expected.png:
* platform/qt/svg/batik/text/verticalTextOnPath-expected.png:
* platform/qt/svg/batik/text/xmlSpace-expected.png:
* platform/qt/svg/carto.net/button-expected.png:
* platform/qt/svg/carto.net/colourpicker-expected.png:
* platform/qt/svg/carto.net/slider-expected.png:
* platform/qt/svg/carto.net/textbox-expected.png:
* platform/qt/svg/carto.net/window-expected.png:
* platform/qt/svg/css/text-shadow-multiple-expected.png:
* platform/qt/svg/custom/feComponentTransfer-Discrete-expected.png:
* platform/qt/svg/custom/feComponentTransfer-Gamma-expected.png:
* platform/qt/svg/custom/feComponentTransfer-Linear-expected.png:
* platform/qt/svg/custom/feComponentTransfer-Table-expected.png:
* platform/qt/svg/custom/focus-ring-expected.png:
* platform/qt/svg/custom/font-face-simple-expected.png:
* platform/qt/svg/custom/foreign-object-skew-expected.png:
* platform/qt/svg/custom/invalid-css-expected.png:
* platform/qt/svg/custom/marker-default-width-height-expected.png:
* platform/qt/svg/custom/no-inherited-dashed-stroke-expected.png:
* platform/qt/svg/custom/preserve-aspect-ratio-syntax-expected.png:
* platform/qt/svg/custom/shapes-supporting-markers-expected.png:
* platform/qt/svg/custom/stroked-pattern-expected.png:
* platform/qt/svg/custom/text-rotated-gradient-expected.png:
* platform/qt/svg/custom/text-tref-03-b-change-href-dom-expected.png:
* platform/qt/svg/custom/text-tref-03-b-change-href-expected.png:
* platform/qt/svg/custom/text-tref-03-b-referenced-element-removal-expected.png:
* platform/qt/svg/custom/text-tref-03-b-tref-removal-expected.png:
* platform/qt/svg/custom/tref-own-content-removal-expected.png:
* platform/qt/svg/custom/use-detach-expected.png:
* platform/qt/svg/custom/viewbox-syntax-expected.png:
* platform/qt/svg/dom/SVGLengthList-appendItem-expected.png: Renamed from LayoutTests/platform/qt-5.0-wk2/svg/dom/SVGLengthList-appendItem-expected.png.
* platform/qt/svg/dom/SVGLengthList-basics-expected.png: Renamed from LayoutTests/platform/qt-5.0-wk2/svg/dom/SVGLengthList-basics-expected.png.
* platform/qt/svg/dom/SVGLengthList-getItem-expected.png: Added.
* platform/qt/svg/dom/SVGLengthList-initialize-expected.png: Added.
* platform/qt/svg/dom/SVGLengthList-insertItemBefore-expected.png: Renamed from LayoutTests/platform/qt-5.0-wk2/svg/dom/SVGLengthList-insertItemBefore-expected.png.
* platform/qt/svg/dom/SVGLengthList-removeItem-expected.png: Renamed from LayoutTests/platform/qt-5.0-wk2/svg/dom/SVGLengthList-removeItem-expected.png.
* platform/qt/svg/dom/SVGLengthList-replaceItem-expected.png: Added.
* platform/qt/svg/dom/SVGLengthList-xml-dom-modifications-expected.png: Renamed from LayoutTests/platform/qt-5.0-wk2/svg/dom/SVGLengthList-xml-dom-modifications-expected.png.
* platform/qt/svg/dom/SVGLocatable-getCTM-svg-root-expected.png: Renamed from LayoutTests/platform/qt-5.0-wk2/svg/dom/SVGLocatable-getCTM-svg-root-expected.png.
* platform/qt/svg/dom/SVGNumberList-basics-expected.png: Renamed from LayoutTests/platform/qt-5.0-wk2/svg/dom/SVGNumberList-basics-expected.png.
* platform/qt/svg/dom/SVGPathSegList-appendItem-expected.png: Renamed from LayoutTests/platform/qt-5.0-wk2/svg/dom/SVGPathSegList-appendItem-expected.png.
* platform/qt/svg/dom/SVGPathSegList-clear-and-initialize-expected.png: Renamed from LayoutTests/platform/qt-5.0-wk2/svg/dom/SVGPathSegList-clear-and-initialize-expected.png.
* platform/qt/svg/dom/SVGPathSegList-insertItemBefore-expected.png: Renamed from LayoutTests/platform/qt-5.0-wk2/svg/dom/SVGPathSegList-insertItemBefore-expected.png.
* platform/qt/svg/dom/SVGPathSegList-removeItem-expected.png: Renamed from LayoutTests/platform/qt-5.0-wk2/svg/dom/SVGPathSegList-removeItem-expected.png.
* platform/qt/svg/dom/SVGPathSegList-replaceItem-expected.png: Renamed from LayoutTests/platform/qt-5.0-wk2/svg/dom/SVGPathSegList-replaceItem-expected.png.
* platform/qt/svg/dom/SVGPathSegList-xml-dom-synchronization-expected.png: Renamed from LayoutTests/platform/qt-5.0-wk2/svg/dom/SVGPathSegList-xml-dom-synchronization-expected.png.
* platform/qt/svg/dom/SVGPointList-basics-expected.png: Renamed from LayoutTests/platform/qt-5.0-wk2/svg/dom/SVGPointList-basics-expected.png.
* platform/qt/svg/dom/SVGStringList-basics-expected.png: Renamed from LayoutTests/platform/qt-5.0-wk2/svg/dom/SVGStringList-basics-expected.png.
* platform/qt/svg/dom/SVGTransformList-basics-expected.png: Renamed from LayoutTests/platform/qt-5.0-wk2/svg/dom/SVGTransformList-basics-expected.png.
* platform/qt/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png:
* platform/qt/svg/hixie/perf/003-expected.png:
* platform/qt/svg/text/select-textLength-spacing-squeeze-3-expected.png:
* platform/qt/svg/text/select-textLength-spacing-stretch-1-expected.png:
* platform/qt/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.png:
* platform/qt/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.png:
* platform/qt/svg/text/select-x-list-1-expected.png:
* platform/qt/svg/text/select-x-list-with-tspans-1-expected.png:
* platform/qt/svg/text/small-fonts-2-expected.png:
* platform/qt/svg/text/small-fonts-3-expected.png:
* platform/qt/svg/text/text-align-01-b-expected.png:
* platform/qt/svg/text/text-align-02-b-expected.png:
* platform/qt/svg/text/text-align-03-b-expected.png:
* platform/qt/svg/text/text-align-06-b-expected.png:
* platform/qt/svg/text/text-fonts-02-t-expected.png:
* platform/qt/svg/text/text-path-01-b-expected.png:
* platform/qt/svg/text/text-text-03-b-expected.png:
* platform/qt/svg/text/text-text-05-t-expected.png:
* platform/qt/svg/text/text-tref-01-b-expected.png:
* platform/qt/svg/text/text-tselect-01-b-expected.png:
* platform/qt/svg/text/text-tspan-01-b-expected.png:
* platform/qt/svg/transforms/animated-path-inside-transformed-html-expected.png:
* platform/qt/svg/transforms/svg-css-transforms-expected.png:
* platform/qt/svg/transforms/text-with-mask-with-svg-transform-expected.png:
* platform/qt/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
* platform/qt/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
* platform/qt/svg/zoom/page/zoom-mask-with-percentages-expected.png:
* platform/qt/svg/zoom/text/zoom-coords-viewattr-01-b-expected.png:
* platform/qt/svg/zoom/text/zoom-foreignObject-expected.png:
* platform/qt/tables/mozilla/bugs/bug6674-expected.png:
* platform/qt/tables/mozilla/marvin/backgr_position-table-expected.png:
* platform/qt/tables/mozilla/marvin/backgr_simple-table-cell-expected.png:
* platform/qt/tables/mozilla/marvin/backgr_simple-table-expected.png:
* platform/qt/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png:
* platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.png:
* platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png:
* platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png:
* platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.png:
* platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.png:
* platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png:
* platform/qt/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png:
* platform/qt/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png:
* platform/qt/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png:
* platform/qt/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.png:
* platform/qt/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png:
* platform/qt/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.png:
* platform/qt/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png:
* platform/qt/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png:
* platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.png:
* platform/qt/transforms/svg-vs-css-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][WK2][AC] Avoid creating an empty surface.
commit-queue@webkit.org [Wed, 19 Dec 2012 14:39:30 +0000 (14:39 +0000)]
[EFL][WK2][AC] Avoid creating an empty surface.
https://bugs.webkit.org/show_bug.cgi?id=105410

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2012-12-19
Reviewed by Kenneth Rohde Christiansen.

Ensure that the view has valid size before creating the surface.

* UIProcess/API/efl/EvasGLSurface.h:
(WebKit::EvasGLSurface::create):
* UIProcess/API/efl/EwkViewImpl.cpp:
(EwkViewImpl::displayTimerFired):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Support removing several tabs from TabbedEditorContainer/TabbedPane...
vsevik@chromium.org [Wed, 19 Dec 2012 14:14:01 +0000 (14:14 +0000)]
Web Inspector: Support removing several tabs from TabbedEditorContainer/TabbedPane at once.
https://bugs.webkit.org/show_bug.cgi?id=104881

Reviewed by Alexander Pavlov.

* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._uiSourceCodeRemoved):
* inspector/front-end/TabbedEditorContainer.js:
(WebInspector.TabbedEditorContainer.prototype.removeUISourceCode):
* inspector/front-end/TabbedPane.js:
(WebInspector.TabbedPane.prototype.closeTab):
(WebInspector.TabbedPane.prototype.closeTabs):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: scripts to evaluate on load are not removed from inspector state when...
caseq@chromium.org [Wed, 19 Dec 2012 13:56:38 +0000 (13:56 +0000)]
Web Inspector: scripts to evaluate on load are not removed from inspector state when Page agent is disabled
https://bugs.webkit.org/show_bug.cgi?id=105422

Reviewed by Alexander Pavlov.

- reset scripts to evaluate on load when InspectorPageAgent is disabled.
- added InspectorState::remove();

* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::disable):
* inspector/InspectorState.cpp:
(WebCore::InspectorState::remove):
(WebCore):
* inspector/InspectorState.h:
(InspectorState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138150 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][Qt][WK2] Going back to 47-amazing-css3-animation-demos shows nothing or wrong...
kenneth@webkit.org [Wed, 19 Dec 2012 13:45:15 +0000 (13:45 +0000)]
[EFL][Qt][WK2] Going back to 47-amazing-css3-animation-demos shows nothing or wrong position
https://bugs.webkit.org/show_bug.cgi?id=104414

Reviewed by Simon Hausmann.

When contents size changes, make sure to apply any pending position
change if possible.

* UIProcess/PageViewportController.cpp:
(WebKit::PageViewportController::didChangeContentsSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoINPUT_MULTIPLE_FIELDS_UI: Make year field readonly if min and max have the same year
commit-queue@webkit.org [Wed, 19 Dec 2012 13:38:31 +0000 (13:38 +0000)]
INPUT_MULTIPLE_FIELDS_UI: Make year field readonly if min and max have the same year
https://bugs.webkit.org/show_bug.cgi?id=105383

Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2012-12-19
Reviewed by Kent Tamura.

Source/WebCore:

Make year field readonly if min and max have the same year, and it does not have
value with different year.

Test: fast/forms/date-multiple-fields/date-multiple-fields-readonly-subfield.html

* css/html.css: Add CSS rule for the year field.
* html/shadow/DateTimeEditElement.cpp:
(DateTimeEditBuilder):
(WebCore::DateTimeEditBuilder::visitField): Make year-field readonly when appropriate.
(WebCore::DateTimeEditBuilder::shouldYearFieldReadOnly): Added.

LayoutTests:

* fast/forms/date-multiple-fields/date-multiple-fields-readonly-subfield-expected.txt: Added.
* fast/forms/date-multiple-fields/date-multiple-fields-readonly-subfield.html: Added.
* fast/forms/date-multiple-fields/resources/preserve-value-after-history-back-frame.html: Tweak so year field is focusable.
* fast/forms/datetimelocal-multiple-fields/resources/preserve-value-after-history-back-frame.html: Ditto.
* fast/forms/month-multiple-fields/resources/preserve-value-after-history-back-frame.html: Ditto.
* fast/forms/week-multiple-fields/resources/preserve-value-after-history-back-frame.html: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] [WK2] Trailing semicolon in an #include line
commit-queue@webkit.org [Wed, 19 Dec 2012 13:32:45 +0000 (13:32 +0000)]
[GTK] [WK2] Trailing semicolon in an #include line
https://bugs.webkit.org/show_bug.cgi?id=105418

Patch by Alberto Garcia <agarcia@igalia.com> on 2012-12-19
Reviewed by Xan Lopez.

* UIProcess/gtk/WebContextGtk.cpp:
Remove trailing semicolon in #include line.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][WK2] Move deviceScaleFactor to our view as it's view related
kenneth@webkit.org [Wed, 19 Dec 2012 13:22:31 +0000 (13:22 +0000)]
[EFL][WK2] Move deviceScaleFactor to our view as it's view related
https://bugs.webkit.org/show_bug.cgi?id=105412

Reviewed by Laszlo Gombos.

* UIProcess/API/efl/EwkViewImpl.cpp:
(EwkViewImpl::setDeviceScaleFactor):
(EwkViewImpl::transformFromScene):
* UIProcess/API/efl/EwkViewImpl.h:
(EwkViewImpl):
* UIProcess/API/efl/ewk_view.cpp:
(ewk_view_device_pixel_ratio_set):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Fix undesired re-entrant calls during media error dialog
commit-queue@webkit.org [Wed, 19 Dec 2012 13:13:41 +0000 (13:13 +0000)]
[BlackBerry] Fix undesired re-entrant calls during media error dialog
https://bugs.webkit.org/show_bug.cgi?id=105398

Patch by Max Feil <mfeil@rim.com> on 2012-12-19
Reviewed by Rob Buis.

A recent change in libwebview (PR194379) to the dialog
handling means that dialogs are not truly blocking anymore.
While the dialog is up, a sub-event loop is called. Therefore
the HTML5 media code will continue processing pps messages from
mm-renderer, responding to periodic timers, etc., all while a
media error dialog call higher up in the stack is waiting for
the user to respond. Unfortunately certain places in our code
do not anticipate being called in this re-entrant way.

This patch restores previous behaviour, covered by existing tests.

* platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::MediaPlayerPrivate::waitMetadataTimerFired):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: [REGRESSION] The last remembered tab is not restored when the Settings...
apavlov@chromium.org [Wed, 19 Dec 2012 13:02:17 +0000 (13:02 +0000)]
Web Inspector: [REGRESSION] The last remembered tab is not restored when the Settings dialog is opened
https://bugs.webkit.org/show_bug.cgi?id=105414

Reviewed by Vsevolod Vlasov.

Do not force the "General" tab when opening settings upon the Cog button click.

* inspector/front-end/SettingsScreen.js:
(WebInspector.SettingsController.prototype._mouseUp):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening, skip flakey tests.
ossy@webkit.org [Wed, 19 Dec 2012 13:00:54 +0000 (13:00 +0000)]
Unreviewed gardening, skip flakey tests.

* platform/qt-5.0-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Missing vtable for LoadStartedCatcher.
zeno.albisser@digia.com [Wed, 19 Dec 2012 12:49:16 +0000 (12:49 +0000)]
[Qt] Missing vtable for LoadStartedCatcher.
https://bugs.webkit.org/show_bug.cgi?id=105313

Properly splitting class declarations and function
definitions into headers/cpp-files.
This makes including util.moc redundant
and avoids the well known vtable issues with QObject classes.

Reviewed by Simon Hausmann.

* UIProcess/API/qt/tests/util.cpp:
(LoadSpy::LoadSpy):
(LoadSpy::onLoadingChanged):
* UIProcess/API/qt/tests/util.h:
(LoadSpy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCSSParser crases, when no context is available, and the value is a valid keyword
reni@webkit.org [Wed, 19 Dec 2012 11:56:08 +0000 (11:56 +0000)]
CSSParser crases, when no context is available, and the value is a valid keyword
https://bugs.webkit.org/show_bug.cgi?id=105275

Reviewed by Tony Chang.

ParserContext could be null even if the keyword is valid. We have to check it.

Source/WebCore:

Test: fast/css/invalid-parsercontext-valid-keyword-crash.svg

* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):

LayoutTests:

* fast/css/invalid-parsercontext-valid-keyword-crash-expected.txt: Added.
* fast/css/invalid-parsercontext-valid-keyword-crash.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138141 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][WebGL] Refactor GLXSurface.
commit-queue@webkit.org [Wed, 19 Dec 2012 11:35:05 +0000 (11:35 +0000)]
[EFL][WebGL] Refactor GLXSurface.
https://bugs.webkit.org/show_bug.cgi?id=105357

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2012-12-19
Reviewed by Kenneth Rohde Christiansen.

This is in preparation for adding EGL support.
There is lot of X related code which could be shared between our current GLX implementation
and EGL. This patch makes it possible to share the common code but doesn't change any functionality.

* PlatformEfl.cmake:
* platform/graphics/surfaces/glx/GLXSurface.cpp:
(WebCore):
(WebCore::GLXTransportSurface::GLXTransportSurface):
(WebCore::GLXTransportSurface::configuration):
(WebCore::GLXTransportSurface::destroy):
(WebCore::GLXTransportSurface::freeResources):
(WebCore::GLXPBuffer::GLXPBuffer):
(WebCore::GLXPBuffer::initialize):
(WebCore::GLXPBuffer::configuration):
(WebCore::GLXPBuffer::setGeometry):
* platform/graphics/surfaces/glx/GLXSurface.h:
(GLXTransportSurface):
(GLXPBuffer):

GLX related implementation.
* platform/graphics/surfaces/glx/GLXWindowResources.h: Added.
(WebCore):
(SharedGLXResources):
(WebCore::SharedGLXResources::create):
(WebCore::SharedGLXResources::nativeDisplay):
(WebCore::SharedGLXResources::pBufferContextConfig):
(WebCore::SharedGLXResources::surfaceContextConfig):
(WebCore::SharedGLXResources::SharedGLXResources):
(WebCore::SharedGLXResources::createConfig):

Moving X related code to a seperate class.
* platform/graphics/surfaces/glx/X11WindowResources.cpp: Added.
(WebCore):
(WebCore::X11OffScreenWindow::X11OffScreenWindow):
(WebCore::X11OffScreenWindow::~X11OffScreenWindow):
(WebCore::X11OffScreenWindow::setGeometry):
(WebCore::X11OffScreenWindow::createOffscreenWindow):
* platform/graphics/surfaces/glx/X11WindowResources.h: Added.
(WebCore):
(SharedX11Resources):
(WebCore::SharedX11Resources::deref):
(WebCore::SharedX11Resources::x11Display):
(WebCore::SharedX11Resources::getXWindow):
(WebCore::SharedX11Resources::visualInfo):
(WebCore::SharedX11Resources::isXRenderExtensionSupported):
(WebCore::SharedX11Resources::SharedX11Resources):
(WebCore::SharedX11Resources::~SharedX11Resources):
(X11OffScreenWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Unreviewed gardening.
dominik.rottsches@intel.com [Wed, 19 Dec 2012 10:56:01 +0000 (10:56 +0000)]
[EFL] Unreviewed gardening.

Adding failing touch events case, details in bug 105406.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[JSC] Add support for overloaded constructors
commit-queue@webkit.org [Wed, 19 Dec 2012 10:50:36 +0000 (10:50 +0000)]
[JSC] Add support for overloaded constructors
https://bugs.webkit.org/show_bug.cgi?id=103226

Patch by Tommy Widenflycht <tommyw@chromium.org> on 2012-12-19
Reviewed by Kentaro Hara.

Source/WebCore:

This patch adds the same support for overloaded constructors to JSC as V8.
As proof of implementation soundness WebSockets custom constructor is removed.

Existing tests cover patch. As they should.

* GNUmakefile.list.am:
* Modules/websockets/WebSocket.idl:
* Target.pri:
* UseJSC.cmake:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSBindingsAllInOne.cpp:
* bindings/js/JSWebSocketCustom.cpp: Removed.
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateConstructorDeclaration):
(GenerateConstructorDefinitions):
(GenerateOverloadedConstructorDefinition):
(GenerateConstructorDefinition):
(GenerateConstructorHelperMethods):
* bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
(WebCore::JSTestOverloadedConstructorsConstructor::constructJSTestOverloadedConstructors1):
(WebCore):
(WebCore::JSTestOverloadedConstructorsConstructor::constructJSTestOverloadedConstructors2):
(WebCore::JSTestOverloadedConstructorsConstructor::constructJSTestOverloadedConstructors3):
(WebCore::JSTestOverloadedConstructorsConstructor::constructJSTestOverloadedConstructors4):
(WebCore::JSTestOverloadedConstructorsConstructor::constructJSTestOverloadedConstructors):
* bindings/scripts/test/JS/JSTestOverloadedConstructors.h:
(JSTestOverloadedConstructorsConstructor):

LayoutTests:

* http/tests/websocket/tests/hybi/url-parsing-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Mark XHR tests flaky (unreliable console logging)
commit-queue@webkit.org [Wed, 19 Dec 2012 10:48:06 +0000 (10:48 +0000)]
[EFL] Mark XHR tests flaky (unreliable console logging)
https://bugs.webkit.org/show_bug.cgi?id=105403

Unreviewed gardening: mark a bunch of xmlhttprequest tests flaky.

Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2012-12-19

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][Mac] run-launcher cannot find Qt5WebKitWidgets.
zeno.albisser@digia.com [Wed, 19 Dec 2012 10:46:03 +0000 (10:46 +0000)]
[Qt][Mac] run-launcher cannot find Qt5WebKitWidgets.
https://bugs.webkit.org/show_bug.cgi?id=105309

The version number is only used as a part
of the library name on Linux.

Reviewed by Kenneth Rohde Christiansen.

* Scripts/webkitdirs.pm:
(builtDylibPathForName):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPass debuggerTaskMode as a parameter in WorkerScriptDebugServer constructor
commit-queue@webkit.org [Wed, 19 Dec 2012 10:39:17 +0000 (10:39 +0000)]
Pass debuggerTaskMode as a parameter in WorkerScriptDebugServer constructor
https://bugs.webkit.org/show_bug.cgi?id=105085

Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2012-12-19
Reviewed by Yury Semikhatsky.

Leave WorkerDebuggerAgent::debuggerTaskMode
and remove WorkerScriptDebugServer::debuggerTaskMode.

No new tests, no behavior change.

* bindings/js/WorkerScriptDebugServer.cpp:
(WebCore::WorkerScriptDebugServer::WorkerScriptDebugServer):
(WebCore::WorkerScriptDebugServer::runEventLoopWhilePaused):
* bindings/js/WorkerScriptDebugServer.h:
(WorkerScriptDebugServer):
* bindings/v8/WorkerScriptDebugServer.cpp:
(WebCore::WorkerScriptDebugServer::WorkerScriptDebugServer):
(WebCore::WorkerScriptDebugServer::runMessageLoopOnPause):
* bindings/v8/WorkerScriptDebugServer.h:
(WorkerScriptDebugServer):
* inspector/WorkerDebuggerAgent.cpp:
(WebCore::WorkerDebuggerAgent::WorkerDebuggerAgent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Gardening after r138095, skip a newly added, but failing test.
jbadics@inf.u-szeged.hu [Wed, 19 Dec 2012 10:29:41 +0000 (10:29 +0000)]
[Qt] Gardening after r138095, skip a newly added, but failing test.
https://bugs.webkit.org/show_bug.cgi?id=105406

Reviewed by Csaba Osztrogon√°c.

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Tests that time out are not considered as failures.
carlosgc@webkit.org [Wed, 19 Dec 2012 10:18:15 +0000 (10:18 +0000)]
[GTK] Tests that time out are not considered as failures.
https://bugs.webkit.org/show_bug.cgi?id=105318

Patch by Alberto Garcia <agarcia@igalia.com> on 2012-12-19
Reviewed by Martin Robinson.

Fix parsing of the GTK API tests log files.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(RunGtkAPITests.commandComplete):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening. Move chromium-mac image to chromium where it will also be used...
loislo@chromium.org [Wed, 19 Dec 2012 10:10:14 +0000 (10:10 +0000)]
Unreviewed gardening. Move chromium-mac image to chromium where it will also be used for win and linux.

* platform/chromium/fast/text/line-initial-and-final-swashes-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/text/line-initial-and-final-swashes-expected.png.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r138129.
loislo@chromium.org [Wed, 19 Dec 2012 09:56:33 +0000 (09:56 +0000)]
Unreviewed, rolling out r138129.
http://trac.webkit.org/changeset/138129
https://bugs.webkit.org/show_bug.cgi?id=105399

reapply patch r138123. The problem was on chromium side at r173875.

Source/WebCore:

* dom/Element.cpp:
(WebCore::Element::insertedInto):
(WebCore::Element::removedFrom):
* dom/Element.h:
(WebCore::Node::insertedInto):
(WebCore):
(WebCore::Node::removedFrom):
* dom/Node.cpp:

LayoutTests:

* fast/dom/shadow/getelementbyid-shadow-expected.txt: Added.
* fast/dom/shadow/getelementbyid-shadow.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Shadow] TITLE elements in Shadow DOM should not affect document.title attribute
tasak@google.com [Wed, 19 Dec 2012 08:54:10 +0000 (08:54 +0000)]
[Shadow] TITLE elements in Shadow DOM should not affect document.title attribute
https://bugs.webkit.org/show_bug.cgi?id=85864

Reviewed by Ryosuke Niwa.

Source/WebCore:

Modified HTMLTitleElement to check whether a title element is in a
shadow tree or not when it is inserted or removed. Now if a title
element has been just removed from or inserted into a shadow tree,
document.title is not updated independent of inDocument().  If the
title element is not in a shadow tree and in document,
document.title is updated.

Test: fast/dom/shadow/title-element-in-shadow.html

* html/HTMLTitleElement.cpp:
(WebCore::HTMLTitleElement::insertedInto):
Added a condition: isInShadowTree() to the code which checks
inDocument or not.
(WebCore::HTMLTitleElement::removedFrom):
Added a condition: insertionPoint.isInShadowTree() to the code which
checks an insertion point is in a document or not.
(WebCore::HTMLTitleElement::childrenChanged):
Added a condition: isInShadowTree() before setTitle.
If not isInShadowTree, modified to removeTitle from document.

LayoutTests:

* fast/dom/shadow/title-element-in-shadow-expected.txt: Added.
* fast/dom/shadow/title-element-in-shadow.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r138123.
loislo@chromium.org [Wed, 19 Dec 2012 08:46:12 +0000 (08:46 +0000)]
Unreviewed, rolling out r138123.
http://trac.webkit.org/changeset/138123
https://bugs.webkit.org/show_bug.cgi?id=105399

It broke compositing/visibility/visibility-simple-video-
layer.html (Requested by loislo on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-12-19

Source/WebCore:

* dom/Element.cpp:
(WebCore::Element::insertedInto):
(WebCore::Element::removedFrom):
* dom/Element.h:
* dom/Node.cpp:
(WebCore::Node::insertedInto):
(WebCore):
(WebCore::Node::removedFrom):

LayoutTests:

* fast/dom/shadow/getelementbyid-shadow-expected.txt: Removed.
* fast/dom/shadow/getelementbyid-shadow.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agotransitions/interrupted-accelerated-transition.html should use pauseAPI
commit-queue@webkit.org [Wed, 19 Dec 2012 08:41:02 +0000 (08:41 +0000)]
transitions/interrupted-accelerated-transition.html should use pauseAPI
https://bugs.webkit.org/show_bug.cgi?id=103524

Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2012-12-19
Reviewed by Simon Fraser.

In certain situations interrupted-accelerated-transition.html exceeds the
test tolerance, making the test flaky. Use the pauseAPI so we don't
depend on javascript timing.

* transitions/resources/interrupted-accelerated-transition-final.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening. Restore expectations for mac.
loislo@chromium.org [Wed, 19 Dec 2012 08:23:27 +0000 (08:23 +0000)]
Unreviewed gardening. Restore expectations for mac.

The tests still have problem with scroller image.

* platform/chromium/TestExpectations:
added: webkit.org/b/102294 [ Mac ] platform/chromium/virtual/deferred/fast/images/exif-orientation.html [ ImageOnlyFailure ]
added: webkit.org/b/102294 [ Mac ] platform/chromium/virtual/deferred/fast/images/exif-orientation-css.html [ ImageOnlyFailure ]
added: webkit.org/b/102294 [ Mac ] platform/chromium/virtual/deferred/fast/images/gray-scale-jpeg-with-color-profile.html [ ImageOnlyFailure ]

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnused parameters on WebContext.cpp
commit-queue@webkit.org [Wed, 19 Dec 2012 08:21:19 +0000 (08:21 +0000)]
Unused parameters on WebContext.cpp
https://bugs.webkit.org/show_bug.cgi?id=105395

Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-12-19
Reviewed by Kentaro Hara.

Because the parameters 'certficate', 'host' are not used if !ENABLE(NETWORK_PROCESS),
use UNUSED_PARAM macro to fix build warning -Wunused-parameter.

* UIProcess/WebContext.cpp:
(WebKit::WebContext::allowSpecificHTTPSCertificateForHost):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening. Update expectation for mac and remove wrong expectation for...
loislo@chromium.org [Wed, 19 Dec 2012 08:15:51 +0000 (08:15 +0000)]
Unreviewed gardening. Update expectation for mac and remove wrong expectation for win.

* platform/chromium-mac-snowleopard/fast/text/line-initial-and-final-swashes-expected.png: Added.
* platform/chromium-win/fast/text/line-initial-and-final-swashes-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAX: radio-button-checkbox-size is Mac-specific and should be moved.
dmazzoni@google.com [Wed, 19 Dec 2012 07:57:33 +0000 (07:57 +0000)]
AX: radio-button-checkbox-size is Mac-specific and should be moved.
https://bugs.webkit.org/show_bug.cgi?id=105382

Reviewed by Chris Fleizach.

Move radio-button-checkbox-size to platform/mac because the
behavior it tests for is Mac-specific. Take it out of the
Chromium TestExpectations file.

* platform/chromium/TestExpectations:
* platform/mac/accessibility/radio-button-checkbox-size-expected.txt: Renamed from LayoutTests/accessibility/radio-button-checkbox-size-expected.txt.
* platform/mac/accessibility/radio-button-checkbox-size.html: Renamed from LayoutTests/accessibility/radio-button-checkbox-size.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoShadowRoot.getElementById() returns a deleted element
shinyak@chromium.org [Wed, 19 Dec 2012 07:54:57 +0000 (07:54 +0000)]
ShadowRoot.getElementById() returns a deleted element
https://bugs.webkit.org/show_bug.cgi?id=105243

Reviewed by Dimitri Glazkov.

Source/WebCore:

Only when the treeScope of an element and the treeScope of insertionPoint is the same in insertedInto or removedFrom,
we can call updatedId() etc. However, we didn't check it's same.

For removedFrom, since an element has been removed, treeScope() doesn't return the original treeScope but document()
every time.

This patch might hurt html5-full-render a bit: the result is here. The first 2 results are without this patch,
the last 2 results are with this patch.

Dromaeo/dom-modify [runs/s]
     35.97,   36.09 -->   36.05,   35.69
Parser/html5-full-render [ms]
   4156.58, 4166.09 --> 4155.22, 4216.38

Test: fast/dom/shadow/getelementbyid-shadow.html

* dom/Element.cpp:
(WebCore::Element::insertedInto):
(WebCore::Element::removedFrom):
* dom/Element.h:
(WebCore::Node::insertedInto): Moved from Node.cpp to make this inline.
(WebCore):
(WebCore::Node::removedFrom): ditto.
* dom/Node.cpp:

LayoutTests:

* fast/dom/shadow/getelementbyid-shadow-expected.txt: Added.
* fast/dom/shadow/getelementbyid-shadow.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: AuditLauncherView UI components should be disabled until ongoing audit...
vivek.vg@samsung.com [Wed, 19 Dec 2012 07:37:53 +0000 (07:37 +0000)]
Web Inspector: AuditLauncherView UI components should be disabled until ongoing audit finishes
https://bugs.webkit.org/show_bug.cgi?id=105389

Reviewed by Alexander Pavlov.

While the Audit request is on-going, UI components on the AuditLauncherView are disabled
until the request is completed or explicitly stopped. Also changed the _categoriesElement
from div to fieldset and modified the associated CSS file accordingly.

No new tests as this is a UI change.

* inspector/front-end/AuditLauncherView.js:
(WebInspector.AuditLauncherView.prototype._setAuditRunning):
(WebInspector.AuditLauncherView.prototype._toggleUIComponents):
* inspector/front-end/auditsPanel.css:
(.audit-launcher-view fieldset.audit-categories-container):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r138061.
loislo@chromium.org [Wed, 19 Dec 2012 07:36:39 +0000 (07:36 +0000)]
Unreviewed, rolling out r138061.
https://bugs.webkit.org/show_bug.cgi?id=105396

Original patch:
http://trac.webkit.org/changeset/138061
https://bugs.webkit.org/show_bug.cgi?id=97359

It is crashing on Debug bots

Source/WebKit/chromium:

* public/WebAccessibilityObject.h:
(WebAccessibilityObject):
* src/WebAccessibilityObject.cpp:

Tools:

* DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
(WebTestRunner::AccessibilityUIElement::AccessibilityUIElement):
(WebTestRunner::AccessibilityUIElement::elementAtPointCallback):
* DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h:
(AccessibilityUIElement):

LayoutTests:

* accessibility/svg-bounds.html:
* accessibility/svg-remote-element-expected.txt:
* accessibility/svg-remote-element.html:
* platform/chromium/TestExpectations:
* platform/chromium/accessibility/svg-bounds-expected.txt: Copied from LayoutTests/accessibility/svg-bounds-expected.txt.
* platform/mac/accessibility/svg-bounds-expected.txt: Renamed from LayoutTests/accessibility/svg-bounds-expected.txt.
* platform/mac/accessibility/svg-remote-element-expected.txt: Copied from LayoutTests/accessibility/svg-remote-element-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] regression(r138071) Add mission functions for build fix
commit-queue@webkit.org [Wed, 19 Dec 2012 07:33:00 +0000 (07:33 +0000)]
[EFL] regression(r138071) Add mission functions for build fix
https://bugs.webkit.org/show_bug.cgi?id=105392

Unreviewed build fix.

r138071 add new functions to LocalizedStrings.cpp, but EFL port doesn't use them.
So, add those functions to LocalizedStringsEfl.cpp

Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-12-18

* platform/efl/LocalizedStringsEfl.cpp:
(WebCore):
(WebCore::textTrackClosedCaptionsText):
(WebCore::textTrackSubtitlesText):
(WebCore::textTrackOffText):
(WebCore::textTrackNoLabelText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening, skip a new failing test.
ossy@webkit.org [Wed, 19 Dec 2012 06:58:14 +0000 (06:58 +0000)]
Unreviewed gardening, skip a new failing test.

* platform/qt-5.0-wk1/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: [Chromium] profiler - differentiate between native code (program)...
commit-queue@webkit.org [Wed, 19 Dec 2012 06:42:06 +0000 (06:42 +0000)]
Web Inspector: [Chromium] profiler - differentiate between native code (program) and idle time
https://bugs.webkit.org/show_bug.cgi?id=88446

Patch by Eugene Klyuchnikov <eustas@chromium.org> on 2012-12-18
Reviewed by Pavel Feldman.

Now idleTime is supplied in profile object. In this patch, idleTime,
if any, is subtracted from "(program)" node, and new node "(idle)" is
injected as a top level node to profile.

* inspector/front-end/CPUProfileView.js:
(WebInspector.CPUProfileView.profileCallback): Call _injectIdleTimeNode
if non-zero idleTime is specified.
(WebInspector.CPUProfileView.prototype._injectIdleTimeNode): Lookup for
"(program)" node, modify it, add "(idle)" node.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed rebaseline after r138075. Remove entries for passing tests and one bad...
loislo@chromium.org [Wed, 19 Dec 2012 06:34:08 +0000 (06:34 +0000)]
Unreviewed rebaseline after r138075. Remove entries for passing tests and one bad expectation for a reftest by dpranke@chromium.org

* platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/scrollbars/scrollbars-on-positioned-content-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed rebaseline.
loislo@chromium.org [Wed, 19 Dec 2012 06:26:11 +0000 (06:26 +0000)]
Unreviewed rebaseline.

* platform/chromium-linux-x86/fast/inline/justify-emphasis-inline-box-expected.txt: Added.
* platform/chromium-linux/fast/inline/justify-emphasis-inline-box-expected.png: Added.
* platform/chromium-linux/fast/inline/justify-emphasis-inline-box-expected.txt: Added.
* platform/chromium-win/fast/inline/justify-emphasis-inline-box-expected.png: Added.
* platform/chromium-win/fast/inline/justify-emphasis-inline-box-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening. Layout Test fast/events/touch/touch-input-element-change-docume...
loislo@chromium.org [Wed, 19 Dec 2012 06:14:18 +0000 (06:14 +0000)]
Unreviewed gardening. Layout Test fast/events/touch/touch-input-element-change-documents.html is failing
https://bugs.webkit.org/show_bug.cgi?id=105388

wrong path to the js-test-pre.js

* fast/events/touch/touch-input-element-change-documents.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r138097.
loislo@chromium.org [Wed, 19 Dec 2012 05:41:10 +0000 (05:41 +0000)]
Unreviewed, rolling out r138097.
http://trac.webkit.org/changeset/138097
https://bugs.webkit.org/show_bug.cgi?id=105386

multiple crashes on media tests (Requested by loislo on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-12-18

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::canPlayType):
(WebCore::createFileURLForApplicationCacheResource):
(WebCore::stringForNetworkState):
(WebCore::HTMLMediaElement::preload):
(WebCore::HTMLMediaElement::setLoop):
(WebCore::HTMLMediaElement::getPluginProxyParams):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFree one bit in RenderObject
jchaffraix@webkit.org [Wed, 19 Dec 2012 05:19:53 +0000 (05:19 +0000)]
Free one bit in RenderObject
https://bugs.webkit.org/show_bug.cgi?id=105065

Reviewed by Simon Fraser.

This change uses the mutual exclusivity between the different position bits to pack
the information more efficiently. Because you can be only in one position at any point
in time, you only need to store 4 states in RenderObject (ie 2 bits of information) but
we were using 3 bits to store this information, thus losing one bit that I am reclaiming.

The change covers the 3 bits into a single PositionState. In order to avoid any extra branch
on the common code path, the logic was modified to be able to convert a EPosition to a PositionState
using only a bit mask. This also means that we now sets up and clears all the bits at once instead
of several calls, which matches more closely what happens at style change.

Change covered by existing tests.

* rendering/RenderBox.cpp:
(WebCore::RenderBox::updateFromStyle):
Removed a call, superseed by the one in RenderBoxModelObject::updateFromStyle.

* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::updateFromStyle):
Changed to set the positioned bits in only one call to setPositionedState.

* rendering/RenderObject.cpp:
(WebCore::RenderObject::styleWillChange):
Changed to clear all positioned bits at once.

* rendering/RenderScrollbarPart.cpp:
(WebCore::RenderScrollbarPart::styleDidChange):
Ditto, which was probably the intent anyway.

* rendering/RenderView.cpp:
(WebCore::RenderView::RenderView):
Changed to explicitly be AbsolutelyPositioned, not that it really matters as we only store
the out-of-flow information.

* rendering/RenderObject.h:
(WebCore::RenderObject::isOutOfFlowPositioned):
(WebCore::RenderObject::isInFlowPositioned):
(WebCore::RenderObject::isRelPositioned):
(WebCore::RenderObject::isStickyPositioned):
(WebCore::RenderObject::isPositioned):
(WebCore::RenderObject::clearPositionedState):
Updated after the renaming below.

(WebCore::RenderObject::setPositionState):
Ditto, but added an ASSERT to ensure that the out-of-flow bit is only set on boxes, to match
existing code.

* rendering/style/RenderStyleConstants.h:
Changed the values so that the conversion to PositionState is a simple bit mask, e.g
FixedPosition & 0x3 == AbsolutePosition as we only store the out-of-flow position information.

(WebCore::RenderObject::RenderObjectBitfields::RenderObjectBitfields):
Introduced PositionState to hold the different bits.

(WebCore::RenderObject::RenderObjectBitfields::setPositionedState):
(WebCore::RenderObject::RenderObjectBitfields::clearPositionedState):
(WebCore::RenderObject::RenderObjectBitfields::isOutOfFlowPositioned):
(WebCore::RenderObject::RenderObjectBitfields::isRelPositioned):
(WebCore::RenderObject::RenderObjectBitfields::isStickyPositioned):
(WebCore::RenderObject::RenderObjectBitfields::isPositioned):
Re-implemented these getters / setters and renamed them to match our style while at it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAX: aria-controls-with-tabs should run on Chromium
dmazzoni@google.com [Wed, 19 Dec 2012 05:13:59 +0000 (05:13 +0000)]
AX: aria-controls-with-tabs should run on Chromium
https://bugs.webkit.org/show_bug.cgi?id=105381

Reviewed by Chris Fleizach.

Use accessibleElementById so the test works on all platforms,
and specifically unskip it in the Chromium expectations.

* accessibility/aria-controls-with-tabs.html:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoText Autosizing: containers wider than their enclosing clusters should be autosized...
commit-queue@webkit.org [Wed, 19 Dec 2012 04:33:14 +0000 (04:33 +0000)]
Text Autosizing: containers wider than their enclosing clusters should be autosized as separate clusters
https://bugs.webkit.org/show_bug.cgi?id=103627

Patch by Anton Vayvod <avayvod@chromium.org> on 2012-12-18
Reviewed by Julien Chaffraix.

Source/WebCore:

Some blocks of texts might be wider than their parent clusters and need to be autosized separately.

isAutosizingCluster() now checks for the width of the container being greater than the width of the lowest
common ancestor of the text nodes of the enclosing cluster. This block containing all text is passed to all
tree traversal methods.
An overloaded version is added for cases when we don't have the lowest common ancestor yet.

The change fixes several cases covered by existing tests.

* rendering/TextAutosizer.cpp:
(WebCore::TextAutosizer::processSubtree):

    Calls processCluster with a new number of arguments.

(WebCore::TextAutosizer::processCluster):

    Passes block containing all text nodes into processContainer. Assertion removed since it can no longer be
    checked without passing an additional parameter (the parent block containing all text) to the function
    for the sake of this assertion only.

(WebCore::TextAutosizer::processContainer):

    |parentBlockContainingAllText| parameter passed into isAutosizingCluster.

(WebCore::TextAutosizer::isAutosizingCluster(const RenderBlock*, const RenderBlock*)):

    The overloaded method that is used when the render block checked is already known to be an autosizing
    container and there's full information necessary to determine if it's a cluster like the parent block
    containing all text within the enclosing cluster.
    Considers a block a cluster if it is wider than its parent block containing all text within enclosing
    cluster.

(WebCore::TextAutosizer::isAutosizingCluster(const RenderObject*)):

    The overloaded method that checks for the given object to be an autosizing container first (for
    convenience of the caller) and doesn't require information about the parent cluster. Used when such
    information is not available, for example, in the process of retrieving the information for the parent
    cluster or when looking for the root cluster in the tree.

(WebCore::TextAutosizer::clusterShouldBeAutosized):

    Passes new parameter to measureDescendantTextWidth.

(WebCore::TextAutosizer::measureDescendantTextWidth):

    Uses blockContainingAllText parameter to pass to isAutosizingCluster.

(WebCore::TextAutosizer::findDeepestBlockContainingAllText):

    Assertion removed since it can no longer be checked without passing an additional parameter (the
    parent block containing all text) to the function for the sake of this assertion only.

(WebCore::TextAutosizer::findFirstTextLeafNotInCluster):
    Uses shorter isAutosizingCluster call.

LayoutTests:

Modified existing tests to reflect the new autosizing approach to handling of the elements that are
wider than the lowest common ancestor of the text nodes of the enclosing autosizing cluster.

* fast/text-autosizing/cluster-wide-in-narrow-expected.html:
* fast/text-autosizing/cluster-wide-in-narrow.html:
* fast/text-autosizing/wide-child-expected.html:
* fast/text-autosizing/wide-child.html:
* fast/text-autosizing/wide-in-narrow-overflow-scroll-expected.html:
* fast/text-autosizing/wide-in-narrow-overflow-scroll.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCorrecting reviewer in ChangeLogs.
ap@apple.com [Wed, 19 Dec 2012 04:23:31 +0000 (04:23 +0000)]
Correcting reviewer in ChangeLogs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago Remove unnecessary functions from CookiesStrategy
ap@apple.com [Wed, 19 Dec 2012 04:21:48 +0000 (04:21 +0000)]
    Remove unnecessary functions from CookiesStrategy
        https://bugs.webkit.org/show_bug.cgi?id=105369

        Reviewed by Sam Weinig.

        Remove CookieJar functions that are only ever called from WebKit.

        * WebCore.exp.in:
        * loader/CookieJar.cpp:
        * loader/CookieJar.h:
        * platform/CookiesStrategy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUse element.webkitCreateShadowRoot instead of WebKitShadowRoot in PerformanceTests.
hayato@chromium.org [Wed, 19 Dec 2012 04:18:43 +0000 (04:18 +0000)]
Use element.webkitCreateShadowRoot instead of WebKitShadowRoot in PerformanceTests.
https://bugs.webkit.org/show_bug.cgi?id=105256

Reviewed by Dimitri Glazkov.

WebKitShadowRoot constructor was deleted in favor of element.webkitCreateShadowRoot().

* ShadowDOM/ChangingClassNameShadowDOM.html:
* ShadowDOM/ChangingSelect.html:
* ShadowDOM/ContentReprojection.html:
* ShadowDOM/DistributionWithMultipleShadowRoots.html:
* ShadowDOM/LargeDistributionWithLayout.html:
* ShadowDOM/MultipleInsertionPoints.html:
* ShadowDOM/ShadowReprojection.html:
* ShadowDOM/SmallDistributionWithLayout.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoProxies should set InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero
fpizlo@apple.com [Wed, 19 Dec 2012 03:29:41 +0000 (03:29 +0000)]
Proxies should set InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero
https://bugs.webkit.org/show_bug.cgi?id=105379

Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

Forgetting to set this flag led to the DFG trying to ensure array storage on a proxy. I've
now hardened the code with a release assertion as well as fixing the bug. A release assertion
is appropriate here since this is slow-path code.

* runtime/JSObject.cpp:
(JSC::JSObject::enterDictionaryIndexingMode):
(JSC::JSObject::ensureInt32Slow):
(JSC::JSObject::ensureDoubleSlow):
(JSC::JSObject::ensureContiguousSlow):
(JSC::JSObject::ensureArrayStorageSlowNoCheck):
(JSC::JSObject::ensureArrayStorageSlow):
(JSC):
(JSC::JSObject::putByIndexBeyondVectorLengthWithoutAttributes):
* runtime/JSObject.h:
(JSObject):
* runtime/JSProxy.h:
(JSProxy):

LayoutTests:

* fast/js/dfg-ensure-non-array-array-storage-on-window-expected.txt: Added.
* fast/js/dfg-ensure-non-array-array-storage-on-window.html: Added.
* fast/js/script-tests/dfg-ensure-non-array-array-storage-on-window.js: Added.
(foo):
(bar):
(.shouldBe):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, fix expected file to have the right test description.
fpizlo@apple.com [Wed, 19 Dec 2012 03:28:53 +0000 (03:28 +0000)]
Unreviewed, fix expected file to have the right test description.

* fast/js/dfg-ensure-array-storage-on-window-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebKit/mac: Add SPI to WebKit1 WebFrame for hit testing
alice.liu@apple.com [Wed, 19 Dec 2012 03:00:02 +0000 (03:00 +0000)]
Source/WebKit/mac: Add SPI to WebKit1 WebFrame for hit testing
https://bugs.webkit.org/show_bug.cgi?id=105106

Reviewed by Dan Bernstein.

* WebView/WebFrame.mm:
(-[WebFrame elementAtPoint:]): Added. Takes an NSPoint to feed to the WebCore::Frame for hit-testing.
Creates a WebElementDictionary from that WebCore::HitTestResult, and returns the element dictionary.
* WebView/WebFramePrivate.h:

Tools: Test for https://bugs.webkit.org/show_bug.cgi?id=105106
Add SPI to WebKit1 WebFrame for hit testing

Reviewed by Dan Bernstein.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added file Tests/mac/ElementAtPointInWebFrame.mm
* TestWebKitAPI/Tests/mac/ElementAtPointInWebFrame.mm: Added.
(TestWebKitAPI::TEST): Loads html with two divs positioned in the 2nd and 4th quadrants of the webview.
Then hit-tests at three points, expecting to hit the two divs and body element.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK][AC] Assertion failed while destroying GraphicsLayer
commit-queue@webkit.org [Wed, 19 Dec 2012 02:45:02 +0000 (02:45 +0000)]
[GTK][AC] Assertion failed while destroying GraphicsLayer
https://bugs.webkit.org/show_bug.cgi?id=105312

Patch by ChangSeok Oh <shivamidow@gmail.com> on 2012-12-18
Reviewed by Gustavo Noronha Silva.

According to the comment in GraphicsLayer::~GraphicsLayer(), we should call
willBeDestroyed() before destructor of GraphicsLayer.

No new tests since this patch can be covered by already existing gtk ac tests.

* platform/graphics/clutter/GraphicsLayerClutter.cpp:
(WebCore::GraphicsLayerClutter::~GraphicsLayerClutter): call willBeDestroyed()

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agofast/css/image-set-value-not-removed-crash.html should not InsertText with an apostrophe
timothy_horton@apple.com [Wed, 19 Dec 2012 02:35:34 +0000 (02:35 +0000)]
fast/css/image-set-value-not-removed-crash.html should not InsertText with an apostrophe
https://bugs.webkit.org/show_bug.cgi?id=105375

Reviewed by Beth Dakin.

Don't InsertText text content with an apostrophe in it, as this can break
on platforms where apostrophes turn into curly quotes.

* fast/css/image-set-value-not-removed-crash-expected.txt:
* fast/css/image-set-value-not-removed-crash.html:
* platform/win/fast/css/image-set-value-not-removed-crash-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebKit/mac: Add SPI to WebKit1 WebFrame for node conversion to JSValueRef
alice.liu@apple.com [Wed, 19 Dec 2012 02:33:57 +0000 (02:33 +0000)]
Source/WebKit/mac: Add SPI to WebKit1 WebFrame for node conversion to JSValueRef
https://bugs.webkit.org/show_bug.cgi?id=105262

Reviewed by Anders Carlsson.

* WebView/WebFrame.mm:
(-[WebFrame jsWrapper:forWorld:]): Added. Takes a DOMNode and WebScriptWorld and provides a JSValueRef
for the WebCore::Node in that particular WebScriptWorld.
* WebView/WebFramePrivate.h:

Tools: Test for https://bugs.webkit.org/show_bug.cgi?id=105262
Add SPI to WebKit1 WebFrame for node conversion to JSValueRef

Reviewed by Anders Carlsson.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added file Tests/mac/JSWrapperForNodeInWebFrame.mm.mm
* TestWebKitAPI/Tests/mac/JSWrapperForNodeInWebFrame.mm.mm: Added.
(TestWebKitAPI::TEST): Tests for the correct JS wrapper for a DOMNode, provided a WebScriptWorld.
Loads html with a single div element. In an isolated world, creates a property on that node.
Also, in the standard world, creates a different property on that node.  Then tests for 4 things:
    - Existence of the isolated property in the isolated world.
    - Existence of the standard property in the standard world.
    - Non-existence of the isolated property in the standard world.
    - Non-existence of the standard property in the isolated world.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK][AC] Fix assertion failures for AC with clutter
commit-queue@webkit.org [Wed, 19 Dec 2012 02:32:32 +0000 (02:32 +0000)]
[GTK][AC] Fix assertion failures for AC with clutter
https://bugs.webkit.org/show_bug.cgi?id=105039

Patch by ChangSeok Oh <shivamidow@gmail.com> on 2012-12-18
Reviewed by Gustavo Noronha Silva.

AcceleratedCompositingContext could be a client of GraphicsLayerClutter
not only RenderLayerBacking. So inserting ASSERT_NOT_REACH in notifyFlushRequired()
causes a crash by calling GraphicsLayerClutter::noteLayerPropertyChanged in debug build.
And also I added flushCompositingStateIncludingSubframes taken from
AcceleratedCompositingContextGL to flushAndRenderLayers(). If not so,
ASSERT(!needsLayout()) failed in FrameView::paintContents() too in debug build.

* WebCoreSupport/AcceleratedCompositingContextClutter.cpp:
(WebKit::AcceleratedCompositingContext::flushAndRenderLayers): Add updateLayoutAndStyleIfNeededRecursive()
(WebKit::AcceleratedCompositingContext::notifyAnimationStarted): Removed ASSERT_NOT_REACHED()
(WebKit::AcceleratedCompositingContext::notifyFlushRequired): Removed ASSERT_NOT_REACHED()

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Remove extra call to doFatFingers.
commit-queue@webkit.org [Wed, 19 Dec 2012 02:21:36 +0000 (02:21 +0000)]
[BlackBerry] Remove extra call to doFatFingers.
https://bugs.webkit.org/show_bug.cgi?id=105347

Patch by Genevieve Mak <gmak@rim.com> on 2012-12-18
Reviewed by Rob Buis.

Reviewed Internally by Mike Fenton.
Now that we do fat fingers on touch start, we don't need this anymore.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::touchEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd a JSScriptRef API to JSC so that we can allow API users to avoid the full cost...
oliver@apple.com [Wed, 19 Dec 2012 02:19:37 +0000 (02:19 +0000)]
Add a JSScriptRef API to JSC so that we can allow API users to avoid the full cost of reparsing everytime the execute a script.
https://bugs.webkit.org/show_bug.cgi?id=105340

Reviewed by Gavin Barraclough.

This patch adds a (currently private) API to allow users of the JSC API to create a JSScript object
that references a reusable version of the script that they wish to evaluate.  This can help us avoid
numeorus copies that are otherwise induced by our existing API and gives us an opaque object that we
can hang various caches off.  Currently this is simply a simple SourceProvider, but in future we may
be able to add more caching without requiring new/replacement APIs.

* API/JSScriptRef.cpp: Added.
* API/JSScriptRefPrivate.h: Added.
* API/tests/testapi.c:
  Add tests for new APIs.
* JavaScriptCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMinor improvements to HTMLMediaElement
commit-queue@webkit.org [Wed, 19 Dec 2012 02:14:03 +0000 (02:14 +0000)]
Minor improvements to HTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=105353

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2012-12-18
Reviewed by Eric Carlson.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::canPlayType):
(WebCore::createFileURLForApplicationCacheResource):
(WebCore::stringForNetworkState):
(WebCore::HTMLMediaElement::preload):
(WebCore::HTMLMediaElement::getPluginProxyParams):
Use ASCIILiteral for literal strings becoming WTFStrings.

(WebCore::HTMLMediaElement::setLoop):
By going through setAttribute, parseAttribute would already take care of
updating the disable sleep, so the call here is not needed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WK2] Create a context client
jonlee@apple.com [Wed, 19 Dec 2012 02:11:13 +0000 (02:11 +0000)]
[WK2] Create a context client
https://bugs.webkit.org/show_bug.cgi?id=105316
<rdar://problem/12901762>

Reviewed by Brady Eidson.

Web contexts already have clients related to downloads or history.
Miscellaneous callbacks can be grouped into a generic client for the
web context.

* UIProcess/API/C/WKContext.cpp:
(WKContextSetClient): Set the client for the context.
* UIProcess/API/C/WKContext.h: Define a new, empty WKContextClient.

* UIProcess/WebContext.cpp:
(WebKit::WebContext::initializeClient):
* UIProcess/WebContext.h: Add a variable for the new client. Move the
download client so that all the clients are grouped together.
(WebKit::WebContext::client): Returns the context client.
* UIProcess/WebContextClient.cpp: Added. Currently empty, but will be
filled out in a pending patch.
* UIProcess/WebContextClient.h: Added.

Add WebContextClient.{h,cpp}.
* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebKit2.xcodeproj/project.pbxproj:
* win/WebKit2.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoInput elements with default touch handlers don't update handler counts when changing...
leviw@chromium.org [Wed, 19 Dec 2012 02:04:12 +0000 (02:04 +0000)]
Input elements with default touch handlers don't update handler counts when changing documents
https://bugs.webkit.org/show_bug.cgi?id=105334

Reviewed by James Robinson.

Source/WebCore:

When an Input element with default touch event handlers changes documents, it failed to
update the touch event handler sets in both the old and new document. This patch fixes this
case.

Test: fast/events/touch/touch-input-element-change-documents.html

* dom/Document.h:
(WebCore::Document::didRemoveTouchEventTargetNode) This function makes sense when touch
handling is enabled, regardless of whether we're tracking the rects.
* dom/Document.cpp:
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::~HTMLInputElement): Switch from didRemoveTouchEventHandler to
didRemoveTouchEventTargetNode, since we don't care about counts in the destructor.
(WebCore::HTMLInputElement::updateType): Fixing incorrect indentation.
(WebCore::HTMLInputElement::didMoveToNewDocument): Adding the node to the new document and
removing it from the old.

LayoutTests:

* fast/events/touch/touch-input-element-change-documents-expected.txt: Added.
* fast/events/touch/touch-input-element-change-documents.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSkip two asserting tests in Debug.
simon.fraser@apple.com [Wed, 19 Dec 2012 02:02:54 +0000 (02:02 +0000)]
Skip two asserting tests in Debug.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Remove temporary backwards compatible interface code (from r137724).
commit-queue@webkit.org [Wed, 19 Dec 2012 01:52:55 +0000 (01:52 +0000)]
[Chromium] Remove temporary backwards compatible interface code (from r137724).
https://bugs.webkit.org/show_bug.cgi?id=105205

Patch by David Dorwin <ddorwin@chromium.org> on 2012-12-18
Reviewed by James Robinson.

* public/WebMediaPlayerClient.h:
* src/WebMediaPlayerClientImpl.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoNew baseline for Acid3 test.
simon.fraser@apple.com [Wed, 19 Dec 2012 01:45:45 +0000 (01:45 +0000)]
New baseline for Acid3 test.

* platform/mac/http/tests/misc/acid3-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRebaseline some tests on Lion.
simon.fraser@apple.com [Wed, 19 Dec 2012 01:41:49 +0000 (01:41 +0000)]
Rebaseline some tests on Lion.

* platform/mac-lion/fast/text/decorations-with-text-combine-expected.txt: Added.
* platform/mac-lion/fast/text/orientation-sideways-expected.txt: Added.
* platform/mac-lion/fast/writing-mode/broken-ideographic-font-expected.txt:
* platform/mac-lion/fast/writing-mode/vertical-baseline-alignment-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDisable the SimplifyMarkup API test, wich asserts in debug builds.
simon.fraser@apple.com [Wed, 19 Dec 2012 01:15:25 +0000 (01:15 +0000)]
Disable the SimplifyMarkup API test, wich asserts in debug builds.
Tracked by https://bugs.webkit.org/show_bug.cgi?id=105370.

* TestWebKitAPI/Tests/mac/SimplifyMarkup.mm:
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFixed bad merge in "Initial refactoring of database functionality into the manager...
mark.lam@apple.com [Wed, 19 Dec 2012 00:49:35 +0000 (00:49 +0000)]
Fixed bad merge in "Initial refactoring of database functionality into the manager and server".
https://bugs.webkit.org/show_bug.cgi?id=104748.

Not reviewed.

No new tests.

* Modules/webdatabase/DBBackendServer.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix the test description.
fpizlo@apple.com [Wed, 19 Dec 2012 00:35:44 +0000 (00:35 +0000)]
Fix the test description.

Rubber stamped by Mark Hahnenberg.

* fast/js/script-tests/dfg-ensure-array-storage-on-window.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDFG::SpeculativeJIT::jumpSlowForUnwantedArrayMode incorrectly checks for non-array...
fpizlo@apple.com [Wed, 19 Dec 2012 00:33:19 +0000 (00:33 +0000)]
DFG::SpeculativeJIT::jumpSlowForUnwantedArrayMode incorrectly checks for non-array array storage when it should be checking for array array storage
https://bugs.webkit.org/show_bug.cgi?id=105365

Reviewed by Mark Hahnenberg.

Source/JavaScriptCore:

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::jumpSlowForUnwantedArrayMode):

LayoutTests:

* fast/js/dfg-ensure-array-storage-on-window-expected.txt: Added.
* fast/js/dfg-ensure-array-storage-on-window.html: Added.
* fast/js/indexed-setter-on-global-object-expected.txt: Added.
* fast/js/indexed-setter-on-global-object.html: Added.
* fast/js/script-tests/dfg-ensure-array-storage-on-window.js: Added.
(foo):
* fast/js/script-tests/indexed-setter-on-global-object.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoInitial refactoring of database functionality into the manager and server.
mark.lam@apple.com [Wed, 19 Dec 2012 00:27:34 +0000 (00:27 +0000)]
Initial refactoring of database functionality into the manager and server.
https://bugs.webkit.org/show_bug.cgi?id=104748.

Reviewed by Brady Eidson.

This is not a complete refactor, but a stepping stone on the way to isolating
script side database activity from the SQL backend.

No new tests.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Modules/webdatabase/AbstractDatabase.cpp:
(WebCore):
(WebCore::updateGuidVersionMap):
(WebCore::guidForOriginAndName):
(WebCore::AbstractDatabase::AbstractDatabase):
(WebCore::AbstractDatabase::maximumSize):
* Modules/webdatabase/AbstractDatabase.h:
(AbstractDatabase):
- Moved isAvailable() and setIsAvailable() to the DatabaseManager.
* Modules/webdatabase/AbstractDatabaseServer.h:
(AbstractDatabaseServer):
* Modules/webdatabase/DBBackendServer.cpp: Added.
(WebCore::DBBackend::Server::initialize):
(WebCore::DBBackend::Server::setClient):
(WebCore::DBBackend::Server::databaseDirectoryPath):
(WebCore::DBBackend::Server::setDatabaseDirectoryPath):
(WebCore::DBBackend::Server::fullPathForDatabase):
(WebCore::DBBackend::Server::hasEntryForOrigin):
(WebCore::DBBackend::Server::origins):
(WebCore::DBBackend::Server::databaseNamesForOrigin):
(WebCore::DBBackend::Server::detailsForNameAndOrigin):
(WebCore::DBBackend::Server::usageForOrigin):
(WebCore::DBBackend::Server::quotaForOrigin):
(WebCore::DBBackend::Server::setQuota):
(WebCore::DBBackend::Server::deleteAllDatabases):
(WebCore::DBBackend::Server::deleteOrigin):
(WebCore::DBBackend::Server::deleteDatabase):
(WebCore::DBBackend::Server::scheduleNotifyDatabaseChanged):
(WebCore::DBBackend::Server::databaseChanged):
(WebCore::DBBackend::Server::closeDatabasesImmediately):
(WebCore::DBBackend::Server::interruptAllDatabasesForContext):
(WebCore::DBBackend::Server::canEstablishDatabase):
(WebCore::DBBackend::Server::addOpenDatabase):
(WebCore::DBBackend::Server::removeOpenDatabase):
(WebCore::DBBackend::Server::setDatabaseDetails):
(WebCore::DBBackend::Server::getMaxSizeForDatabase):
- Refactored all calls to the DatabaseTracker to go thru the DBBackend::Server.
* Modules/webdatabase/DBBackendServer.h:
* Modules/webdatabase/DOMWindowWebDatabase.cpp:
(WebCore::DOMWindowWebDatabase::openDatabase):
* Modules/webdatabase/Database.cpp:
(WebCore::Database::close):
(WebCore::Database::maximumSize):
* Modules/webdatabase/Database.h:
(Database):
- Moved the openDatabase() factory method to the DatabaseManager.
- Removed the unused deliverPendingCallback() prototype.
* Modules/webdatabase/DatabaseBasicTypes.h: Added.
- A place to define some common basic types used by the database module.
* Modules/webdatabase/DatabaseContext.cpp:
(WebCore::DatabaseContext::databaseExceededQuota):
* Modules/webdatabase/DatabaseManager.cpp:
(WebCore::DatabaseManager::DatabaseManager):
(WebCore::DatabaseManager::initialize):
(WebCore::DatabaseManager::setClient):
(WebCore::DatabaseManager::databaseDirectoryPath):
(WebCore::DatabaseManager::setDatabaseDirectoryPath):
(WebCore::DatabaseManager::isAvailable):
(WebCore::DatabaseManager::setIsAvailable):
(DatabaseCreationCallbackTask):
(WebCore::DatabaseCreationCallbackTask::create):
(WebCore::DatabaseCreationCallbackTask::performTask):
(WebCore::DatabaseCreationCallbackTask::DatabaseCreationCallbackTask):
(WebCore::DatabaseManager::openDatabase):
(WebCore::DatabaseManager::openDatabaseSync):
(WebCore::DatabaseManager::setHasOpenDatabases):
(WebCore::DatabaseManager::fullPathForDatabase):
(WebCore::DatabaseManager::hasEntryForOrigin):
(WebCore::DatabaseManager::origins):
(WebCore::DatabaseManager::databaseNamesForOrigin):
(WebCore::DatabaseManager::detailsForNameAndOrigin):
(WebCore::DatabaseManager::usageForOrigin):
(WebCore::DatabaseManager::quotaForOrigin):
(WebCore::DatabaseManager::setQuota):
(WebCore::DatabaseManager::deleteAllDatabases):
(WebCore::DatabaseManager::deleteOrigin):
(WebCore::DatabaseManager::deleteDatabase):
(WebCore::DatabaseManager::scheduleNotifyDatabaseChanged):
(WebCore::DatabaseManager::databaseChanged):
(WebCore::DatabaseManager::closeDatabasesImmediately):
(WebCore::DatabaseManager::interruptAllDatabasesForContext):
(WebCore::DatabaseManager::canEstablishDatabase):
(WebCore::DatabaseManager::addOpenDatabase):
(WebCore::DatabaseManager::removeOpenDatabase):
(WebCore::DatabaseManager::setDatabaseDetails):
(WebCore::DatabaseManager::getMaxSizeForDatabase):
* Modules/webdatabase/DatabaseManager.h:
(DatabaseManager):
* Modules/webdatabase/DatabaseSync.cpp:
(WebCore::DatabaseSync::~DatabaseSync):
(WebCore::DatabaseSync::closeImmediately):
* Modules/webdatabase/DatabaseSync.h:
(DatabaseSync):
- Moved the openDatabaseSync() factory method to the DatabaseManager.
* Modules/webdatabase/DatabaseTask.h:
* Modules/webdatabase/SQLResultSet.h:
* Modules/webdatabase/SQLStatementSync.h:
* Modules/webdatabase/SQLTransaction.h:
* Modules/webdatabase/SQLTransactionClient.cpp:
(WebCore::SQLTransactionClient::didCommitWriteTransaction):
(WebCore::SQLTransactionClient::didExecuteStatement):
(WebCore::SQLTransactionClient::didExceedQuota):
* Modules/webdatabase/SQLTransactionSync.h:
* Modules/webdatabase/WorkerContextWebDatabase.cpp:
(WebCore::WorkerContextWebDatabase::openDatabase):
(WebCore::WorkerContextWebDatabase::openDatabaseSync):
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBug 105344 - [BlackBerry] Make single line text edits touch scrollable.
commit-queue@webkit.org [Wed, 19 Dec 2012 00:26:57 +0000 (00:26 +0000)]
Bug 105344 - [BlackBerry] Make single line text edits touch scrollable.
https://bugs.webkit.org/show_bug.cgi?id=105344

Patch by Genevieve Mak <gmak@rim.com> on 2012-12-18
Reviewed by Antonio Gomes.

Reviewed Internally by Mike Fenton.
We don't need to check the overflow for editable layers because there's
no need for overflow to be set by the content.
PR #231776

* WebKitSupport/InRegionScrollableArea.cpp:
(BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoEventSource should support CORS
commit-queue@webkit.org [Wed, 19 Dec 2012 00:19:42 +0000 (00:19 +0000)]
EventSource should support CORS
https://bugs.webkit.org/show_bug.cgi?id=61862

Patch by Per-Erik Brodin <per-erik.brodin@ericsson.com> on 2012-12-18
Reviewed by Alexey Proskuryakov.

Source/WebCore:

Enabled CORS in EventSource with optional constructor argument to
indicate whether credentials should be included or not, as per the spec.
Added didFailAccessControlCheck to ThreadableLoaderClient to be able to
properly distinguish CORS failures from other errors.

Tests: http/tests/eventsource/eventsource-cors-basic.html
       http/tests/eventsource/eventsource-cors-no-server.html
       http/tests/eventsource/eventsource-cors-with-credentials.html

* loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest):
(WebCore::DocumentThreadableLoader::didReceiveResponse):
(WebCore::DocumentThreadableLoader::preflightFailure):
* loader/ThreadableLoaderClient.h:
(WebCore::ThreadableLoaderClient::didFailAccessControlCheck):
* loader/ThreadableLoaderClientWrapper.h:
(WebCore::ThreadableLoaderClientWrapper::didFailAccessControlCheck):
(ThreadableLoaderClientWrapper):
* loader/WorkerThreadableLoader.cpp:
(WebCore::workerContextDidFailAccessControlCheck):
(WebCore):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didFailAccessControlCheck):
* loader/WorkerThreadableLoader.h:
(MainThreadBridge):
* page/EventSource.cpp:
(WebCore::EventSource::EventSource):
(WebCore::EventSource::create):
(WebCore::EventSource::connect):
(WebCore::EventSource::withCredentials):
(WebCore):
(WebCore::EventSource::didReceiveResponse):
(WebCore::EventSource::didFailAccessControlCheck):
(WebCore::EventSource::didFailRedirectCheck):
(WebCore::EventSource::abortConnectionAttempt):
(WebCore::EventSource::parseEventStreamLine):
(WebCore::EventSource::createMessageEvent):
* page/EventSource.h:
(WebCore):
(EventSource):
(WebCore::EventSource::refEventTarget):
(WebCore::EventSource::derefEventTarget):
* page/EventSource.idl:

LayoutTests:

Added new CORS tests for EventSource. Modified existing test to verify
that the new constructor argument can be passed to the constructor.

* fast/eventsource/eventsource-constructor-expected.txt:
* fast/eventsource/eventsource-constructor.html:
* fast/js/constructor-length.html:
* http/tests/eventsource/eventsource-cors-basic-expected.txt: Added.
* http/tests/eventsource/eventsource-cors-basic.html: Added.
* http/tests/eventsource/eventsource-cors-no-server-expected.txt: Added.
* http/tests/eventsource/eventsource-cors-no-server.html: Added.
* http/tests/eventsource/eventsource-cors-with-credentials-expected.txt: Added.
* http/tests/eventsource/eventsource-cors-with-credentials.html: Added.
* http/tests/eventsource/resources/es-cors-basic.php: Added.
* http/tests/eventsource/resources/es-cors-credentials.php: Added.
* platform/blackberry/fast/js/constructor-length-expected.txt:
* platform/chromium/fast/js/constructor-length-expected.txt:
* platform/gtk/fast/js/constructor-length-expected.txt:
* platform/mac/fast/js/constructor-length-expected.txt:
* platform/qt/fast/js/constructor-length-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] pull in the CDM module recently added to media
dpranke@chromium.org [Wed, 19 Dec 2012 00:16:00 +0000 (00:16 +0000)]
[chromium] pull in the CDM module recently added to media
https://bugs.webkit.org/show_bug.cgi?id=105360

Unreiviewed build fix, but sanity checked by ddorwin.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIndexedDB: Implement custom bindings for parsing options
commit-queue@webkit.org [Wed, 19 Dec 2012 00:10:20 +0000 (00:10 +0000)]
IndexedDB: Implement custom bindings for parsing options
https://bugs.webkit.org/show_bug.cgi?id=96614

Patch by Michael Pruett <michael@68k.org> on 2012-12-18
Reviewed by Darin Adler.

Parsing the options dictionary in IDBDatabase.createObjectStore()
and IDBObjectStore.createIndex() requires custom bindings in JSC.

Tests: storage/indexeddb/*

* GNUmakefile.list.am:
* Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::createObjectStore):
(WebCore):
* Modules/indexeddb/IDBDatabase.h:
(IDBDatabase):
* Modules/indexeddb/IDBDatabase.idl:
* Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::createIndex):
(WebCore):
* Modules/indexeddb/IDBObjectStore.h:
(IDBObjectStore):
* Modules/indexeddb/IDBObjectStore.idl:
* UseJSC.cmake:
* bindings/js/IDBBindingUtilities.cpp:
(WebCore::idbKeyPathFromValue): Added utility function for converting a JSValue to an IDBKeyPath.
(WebCore):
* bindings/js/IDBBindingUtilities.h:
(WebCore):
* bindings/js/JSIDBDatabaseCustom.cpp: Added.
(WebCore):
(WebCore::JSIDBDatabase::createObjectStore):
* bindings/js/JSIDBObjectStoreCustom.cpp: Added.
(WebCore):
(WebCore::JSIDBObjectStore::createIndex):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCannot click an element at 2nd line or more inside inline-block in vertical writing...
commit-queue@webkit.org [Wed, 19 Dec 2012 00:02:18 +0000 (00:02 +0000)]
Cannot click an element at 2nd line or more inside inline-block in vertical writing mode.
https://bugs.webkit.org/show_bug.cgi?id=104775

Patch by Yuki Sekiguchi <yuki.sekiguchi@access-company.com> on 2012-12-18
Reviewed by Dean Jackson.

Source/WebCore:

If the parent of an inline box changes writing mode, then the inline box must flip incoming hit point coordinates.
Otherwise, the coordinate will be misunderstood because the box has a different origin from its parent.
If the InlineBox doesn't flip its offset, its children will use the wrong offset
because they don't know their grandparent changed writing modes.
InlineBox::nodeAtPoint should flip accumulatedOffset like InlineBox::paint().

Test: fast/writing-mode/vertical-inline-block-hittest.html

* rendering/InlineBox.cpp:
(WebCore::InlineBox::nodeAtPoint):

LayoutTests:

Test that we can click 2nd line inside inline-block in vertical writing mode.

* fast/writing-mode/vertical-inline-block-hittest-expected.txt: Added.
* fast/writing-mode/vertical-inline-block-hittest.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed attempted build fix for Chromium.
dino@apple.com [Wed, 19 Dec 2012 00:01:57 +0000 (00:01 +0000)]
Unreviewed attempted build fix for Chromium.

Insert stub methods for localized text track menu labels.

* src/LocalizedStrings.cpp:
(WebCore):
(WebCore::textTrackClosedCaptionsText):
(WebCore::textTrackSubtitlesText):
(WebCore::textTrackOffText):
(WebCore::textTrackNoLabelText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<rdar://problem/12720539> per-pid private temporary directories for sandboxed webkit2...
ike@apple.com [Tue, 18 Dec 2012 23:48:14 +0000 (23:48 +0000)]
<rdar://problem/12720539> per-pid private temporary directories for sandboxed webkit2 plugins

Reviewed by Sam Weinig, Alexey Proskuryakov, Anders Carlsson.

Previously we assigned each PluginProcess a private temporary and
cache directory based on the bundle name of the plugin that was
running. This sometimes led to overly-long pathnames (sockets on OS X
can only be 103 characters long), and didn't provide isolation between
multiple running instances of the same plugin on behalf of different
processes. We now assign each PluginProcess its own private
temporary and cache directory regardless of which plugin it's running,
and make an attempt to clean these up when the process terminates.

We also pass the temporary directory into the sandbox
profile as a parameter, in case the plugin profile needs to apply
additional rules beyond the default read/write policy.

* PluginProcess/mac/PluginProcessMainMac.mm:
(WebKit::PluginProcessMain):
* WebProcess/Plugins/Netscape/mac/NetscapeSandboxFunctions.mm:
(enterSandbox):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPull in the opus codec sources.
dpranke@chromium.org [Tue, 18 Dec 2012 23:35:55 +0000 (23:35 +0000)]
Pull in the opus codec sources.

Unreviewed, build fix.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAllow position:sticky elements to be moved by the scrolling thread
simon.fraser@apple.com [Tue, 18 Dec 2012 23:31:29 +0000 (23:31 +0000)]
Allow position:sticky elements to be moved by the scrolling thread
https://bugs.webkit.org/show_bug.cgi?id=105245

Reviewed by Beth Dakin.

Source/WebCore:

Allow sticky position elements to be repositioned on the scrolling thread.

RenderLayerCompositor::requiresCompositingForPosition() is changed to make
all position:-webkit-sticky elements composited.

Sticky position constraints are already communicated to the ScrollingCoordinator,
but now we created ScrollingStateStickyNodes for them, and send the constraints
over to the scrolling thread for new ScrollingTreeStickyNodes. That allows
their layers to be repositioned on the scrolling thread.

Tests: platform/mac/tiled-drawing/sticky/sticky-horizontal.html
       platform/mac/tiled-drawing/sticky/sticky-vertical.html

* WebCore.xcodeproj/project.pbxproj: Add new files.
* page/scrolling/ScrollingConstraints.h:
(WebCore::StickyPositionViewportConstraints::absoluteContainingBlockRect): New accessors.
(WebCore::StickyPositionViewportConstraints::absoluteStickyBoxRect):
(WebCore::StickyPositionViewportConstraints::operator==):
(WebCore::StickyPositionViewportConstraints::operator!=):
* page/scrolling/ScrollingCoordinator.h: Added StickyNode type.
* page/scrolling/ScrollingStateFixedNode.cpp:
(WebCore::ScrollingStateFixedNode::syncLayerPositionForViewportRect):
New virtual method that allows different kinds of nodes to sync layer positions.
* page/scrolling/ScrollingStateFixedNode.h:
* page/scrolling/ScrollingStateNode.h:
(WebCore::ScrollingStateNode::isStickyNode):
(WebCore::ScrollingStateNode::syncLayerPositionForViewportRect):
* page/scrolling/ScrollingStateStickyNode.cpp: Added.
(WebCore::ScrollingStateStickyNode::create):
(WebCore::ScrollingStateStickyNode::ScrollingStateStickyNode):
(WebCore::ScrollingStateStickyNode::~ScrollingStateStickyNode):
(WebCore::ScrollingStateStickyNode::clone):
(WebCore::ScrollingStateStickyNode::updateConstraints):
(WebCore::ScrollingStateStickyNode::syncLayerPositionForViewportRect):
(WebCore::ScrollingStateStickyNode::dumpProperties):
* page/scrolling/ScrollingStateStickyNode.h: Copied from Source/WebCore/page/scrolling/ScrollingStateFixedNode.h.
(ScrollingStateStickyNode):
(WebCore::ScrollingStateStickyNode::viewportConstraints):
(WebCore::toScrollingStateStickyNode):
* page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::updateTreeFromStateNode):
* page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinatorMac::attachToStateTree): Handle sticky nodes.
(WebCore::ScrollingCoordinatorMac::syncChildPositions): Generalize to different kinds of nodes by
calling a virtual method on the node.
(WebCore::ScrollingCoordinatorMac::updateViewportConstrainedNode):
* page/scrolling/mac/ScrollingTreeFixedNode.mm:
(WebCore::ScrollingTreeFixedNode::ScrollingTreeFixedNode):
* page/scrolling/mac/ScrollingTreeStickyNode.h: Added.
(ScrollingTreeStickyNode):
* page/scrolling/mac/ScrollingTreeStickyNode.mm: Copied from Source/WebCore/page/scrolling/mac/ScrollingTreeFixedNode.mm.
(WebCore::ScrollingTreeStickyNode::create):
(WebCore::ScrollingTreeStickyNode::ScrollingTreeStickyNode):
(WebCore::ScrollingTreeStickyNode::~ScrollingTreeStickyNode):
(WebCore::ScrollingTreeStickyNode::update):
(WebCore::operator*):
(WebCore::ScrollingTreeStickyNode::parentScrollPositionDidChange):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::attachToScrollingCoordinator):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingForPosition):
(WebCore::RenderLayerCompositor::computeFixedViewportConstraints):
(WebCore::RenderLayerCompositor::computeStickyViewportConstraints):
(WebCore::RenderLayerCompositor::registerOrUpdateViewportConstrainedLayer):
* rendering/RenderLayerCompositor.h:
(RenderLayerCompositor):

LayoutTests:

Sticky position tests that dump the scrolling tree.

* platform/mac/tiled-drawing/sticky/sticky-horizontal-expected.txt: Added.
* platform/mac/tiled-drawing/sticky/sticky-horizontal.html: Added.
* platform/mac/tiled-drawing/sticky/sticky-vertical-expected.txt: Added.
* platform/mac/tiled-drawing/sticky/sticky-vertical.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove entries for passing tests and one bad expectation for a reftest.
dpranke@chromium.org [Tue, 18 Dec 2012 23:04:22 +0000 (23:04 +0000)]
Remove entries for passing tests and one bad expectation for a reftest.

Unreviewed.

* platform/chromium-mac/compositing/background-color/background-color-change-to-text-expected.png: Removed.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSunSpider/date-format-tofte shouldn't compile each of the tiny worthless eval's only...
fpizlo@apple.com [Tue, 18 Dec 2012 22:49:40 +0000 (22:49 +0000)]
SunSpider/date-format-tofte shouldn't compile each of the tiny worthless eval's only to OSR exit in the prologue every time
https://bugs.webkit.org/show_bug.cgi?id=105335

Reviewed by Geoffrey Garen.

The first thing I did was restructure the logic of canInlineResolveOperations(),
because I didn't understand it. This was relevant because the OSR exits are
caused by a resolve that the DFG cannot handle.

I was then going to make it so that we didn't compile the resolve at all, but
realized that this would not be the best fix: it didn't seem sensible to me to
be optimizing these evals after only 60 invocations. Evals should have a higher
threshold, since they often contain code for which the baseline JIT does a
pretty good job already (if all you've got is a single heap access or a single
hard-to-inline call, then the baseline JIT has got you covered), and typically
if we see one eval code block we expect to see more (from the same eval site):
so our typical low threshold could lead to a *lot* of compilation. As such, the
main effect of this patch is to introduce an evalThresholdMultiplier, which is
now set to 10.

This is a ~5% speed-up on data-format-tofte. No regressions anywhere as far as
I can see.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::codeTypeThresholdMultiplier):
(JSC):
(JSC::CodeBlock::optimizationThresholdScalingFactor):
(JSC::CodeBlock::exitCountThresholdForReoptimization):
(JSC::CodeBlock::exitCountThresholdForReoptimizationFromLoop):
* bytecode/CodeBlock.h:
(CodeBlock):
* dfg/DFGCapabilities.h:
(JSC::DFG::canInlineResolveOperations):
* dfg/DFGOSRExitCompiler.cpp:
* runtime/Options.h:
(JSC):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoConvert indexingTypeToString to IndexingTypeDump
fpizlo@apple.com [Tue, 18 Dec 2012 22:32:52 +0000 (22:32 +0000)]
Convert indexingTypeToString to IndexingTypeDump
https://bugs.webkit.org/show_bug.cgi?id=105351

Reviewed by Mark Hahnenberg.

This gets rid of another case of static char buffer[thingy].

* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
* runtime/IndexingType.cpp:
(JSC::dumpIndexingType):
* runtime/IndexingType.h:
(JSC):
* runtime/JSValue.cpp:
(JSC::JSValue::dump):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIndexedDB: Split BackingStore histogram
dgrogan@chromium.org [Tue, 18 Dec 2012 22:32:23 +0000 (22:32 +0000)]
IndexedDB: Split BackingStore histogram
https://bugs.webkit.org/show_bug.cgi?id=105222

Reviewed by Tony Chang.

Add separate histograms for Consistency, Write, and Read errors.
Recategorize some read errors as consistency errors.

Tested the preprocessor logic by manually making some functions fail
and printing the histogram string from chromium code.

Next up is logging successes to get an idea of which functions have
the highest failure _rate_.

* Modules/indexeddb/IDBBackingStore.cpp:
(WebCore::recordInternalError):
(WebCore):
(WebCore::setUpMetadata):
(WebCore::IDBBackingStore::getIDBDatabaseMetaData):
(WebCore::getNewDatabaseId):
(WebCore::IDBBackingStore::createIDBDatabaseMetaData):
(WebCore::IDBBackingStore::getObjectStores):
(WebCore::setMaxObjectStoreId):
(WebCore::IDBBackingStore::deleteObjectStore):
(WebCore::IDBBackingStore::getRecord):
(WebCore::getNewVersionNumber):
(WebCore::IDBBackingStore::getKeyGeneratorCurrentNumber):
(WebCore::IDBBackingStore::keyExistsInObjectStore):
(WebCore::IDBBackingStore::getIndexes):
(WebCore::setMaxIndexId):
(WebCore::versionExists):
(WebCore::IDBBackingStore::findKeyInIndex):
(WebCore::IDBBackingStore::getPrimaryKeyViaIndex):
(WebCore::IDBBackingStore::keyExistsInIndex):
(WebCore::ObjectStoreKeyCursorImpl::loadCurrentRow):
(WebCore::ObjectStoreCursorImpl::loadCurrentRow):
(WebCore::IndexKeyCursorImpl::loadCurrentRow):
(WebCore::IndexCursorImpl::loadCurrentRow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTrack menu needs localization
dino@apple.com [Tue, 18 Dec 2012 22:30:34 +0000 (22:30 +0000)]
Track menu needs localization
https://bugs.webkit.org/show_bug.cgi?id=105233

Reviewed by Eric Carlson.

Source/WebCore:

Allow the UI strings in the closed captions menu to be localized, and
profile strings for the English locale.

Test: media/video-controls-captions-trackmenu-localized.html

* English.lproj/Localizable.strings: Adds the four new captions strings.
* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlClosedCaptionsTrackListElement::rebuildTrackListMenu): Use localized getters.
* platform/LocalizedStrings.cpp:
(WebCore::textTrackClosedCaptionsText): New localized string getter.
(WebCore::textTrackSubtitlesText): Ditto.
(WebCore::textTrackOffText): Ditto.
(WebCore::textTrackNoLabelText): Ditto.
* platform/LocalizedStrings.h:

LayoutTests:

Test to exercise the localization of strings in the captions menu.
While I was here I merged some common code into a helper file.

* media/trackmenu-test.js: Added. New helper file to run common test operations.
* media/video-controls-captions-trackmenu-localized-expected.txt: Added.
* media/video-controls-captions-trackmenu-localized.html: Added.
* media/video-controls-captions-trackmenu-sorted.html: Updated to use helper functions.
* platform/chromium/TestExpectations: Skip unimplemented test.
* platform/efl/TestExpectations: Ditto.
* platform/gtk/TestExpectations: Ditto.
* platform/qt/TestExpectations: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, roll chromium deps to r173769
dpranke@chromium.org [Tue, 18 Dec 2012 22:26:47 +0000 (22:26 +0000)]
Unreviewed, roll chromium deps to r173769

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=102579
bdakin@apple.com [Tue, 18 Dec 2012 22:25:11 +0000 (22:25 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=102579
[mac] Enable scaled cursors

Reviewed by Dean Jackson.

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Not much is required to get this turned on. We just need the feature to be
defined, and we need to initialize m_imageScaleFactor in the Cursor constructors.

* Configurations/FeatureDefines.xcconfig:
* platform/mac/CursorMac.mm:
(WebCore::Cursor::Cursor):
(WebCore::Cursor::operator=):

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:

LayoutTests:

Un-skip these tests now that the feature is enabled.
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix broken loop in style guide
thakis@chromium.org [Tue, 18 Dec 2012 22:16:07 +0000 (22:16 +0000)]
Fix broken loop in style guide
https://bugs.webkit.org/show_bug.cgi?id=105346

Reviewed by Ryosuke Niwa.

Found by Sean Silva <silvas@purdue.edu>

* coding/coding-style.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRestrictions on oversize CopiedBlock allocations should be relaxed
mhahnenberg@apple.com [Tue, 18 Dec 2012 22:01:31 +0000 (22:01 +0000)]
Restrictions on oversize CopiedBlock allocations should be relaxed
https://bugs.webkit.org/show_bug.cgi?id=105339

Reviewed by Filip Pizlo.

Currently the DFG has a single branch in the inline allocation path for property/array storage where
it checks to see if the number of bytes requested will fit in the current block. This does not match
what the C++ allocation path does; it checks if the requested number of bytes is oversize, and then
if it's not, it tries to fit it in the current block. The garbage collector assumes that ALL allocations
that are greater than 16KB are in oversize blocks. Therefore, this mismatch can lead to crashes when
the collector tries to perform some operation on a CopiedBlock.

To avoid adding an extra branch to the inline allocation path in the JIT, we should make it so that
oversize blocks are allocated on the same alignment boundaries so that there is a single mask to find
the block header of any CopiedBlock (rather than two, one for normal and one for oversize blocks), and
we should figure out if a block is oversize by some other method than just whatever the JSObject says
it is. One way we could record this info Region of the block, since we allocate a one-off Region for
oversize blocks.

* heap/BlockAllocator.h:
(JSC::Region::isCustomSize):
(Region):
(JSC::Region::createCustomSize):
(JSC::Region::Region):
(JSC::BlockAllocator::deallocateCustomSize):
* heap/CopiedBlock.h:
(CopiedBlock):
(JSC::CopiedBlock::isOversize):
(JSC):
* heap/CopiedSpace.cpp:
(JSC::CopiedSpace::tryAllocateOversize):
(JSC::CopiedSpace::tryReallocate):
(JSC::CopiedSpace::tryReallocateOversize):
* heap/CopiedSpace.h:
(CopiedSpace):
* heap/CopiedSpaceInlines.h:
(JSC::CopiedSpace::contains):
(JSC::CopiedSpace::tryAllocate):
(JSC):
* heap/CopyVisitor.h:
(CopyVisitor):
* heap/CopyVisitorInlines.h:
(JSC::CopyVisitor::checkIfShouldCopy):
(JSC::CopyVisitor::didCopy):
* heap/SlotVisitorInlines.h:
(JSC::SlotVisitor::copyLater):
* runtime/JSObject.cpp:
(JSC::JSObject::copyButterfly):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Build fix for r138024.
jpetsovits@rim.com [Tue, 18 Dec 2012 21:44:09 +0000 (21:44 +0000)]
[BlackBerry] Build fix for r138024.
https://bugs.webkit.org/show_bug.cgi?id=105199
RIM PR 260232

Reviewed by Yong Li.

The clearVisibleTiles() function doesn't exist anymore
and apparently I fail at merge conflict resolution.

* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchDidLayout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Mac] Add Build Phase to Check Headers for Inappropriate Macros (Platform.h macros)
joepeck@webkit.org [Tue, 18 Dec 2012 21:36:40 +0000 (21:36 +0000)]
[Mac] Add Build Phase to Check Headers for Inappropriate Macros (Platform.h macros)
https://bugs.webkit.org/show_bug.cgi?id=104279

Reviewed by David Kilzer.

Source/JavaScriptCore:

Add a build phase to check the public JavaScriptCore headers for
inappropriate macros.

* JavaScriptCore.xcodeproj/project.pbxproj:

Source/WebCore:

Set the executable as an input path on the check-* build phases.

* WebCore.xcodeproj/project.pbxproj:

Source/WebKit:

Add a build phase to check the public WebKit headers for
inappropriate macros. Also set the executable as an input
path on the other check-* build phases.

* WebKit.xcodeproj/project.pbxproj:

Source/WebKit2:

Add a build phase to check the public WebKit2 headers for
inappropriate macros. Also set the executable as an input
path on the other check-* build phases.

* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Mac] Add Build Phase to Check Headers for Inappropriate Macros (Platform.h macros)
joepeck@webkit.org [Tue, 18 Dec 2012 21:36:37 +0000 (21:36 +0000)]
[Mac] Add Build Phase to Check Headers for Inappropriate Macros (Platform.h macros)
https://bugs.webkit.org/show_bug.cgi?id=104279

Reviewed by David Kilzer.

Add a build phase script that checks a framework's header files for
Platform.h and Compiler.h macros. Also add some tests for the script.

* Scripts/check-for-inappropriate-macros-in-external-headers: Added.
Script to be used in build phases to check for inappropriate macros in headers.

* Scripts/test-webkitruby: Added.
Script that can be used to run all webkitruby tests.

* Scripts/test-webkit-scripts:
Also run the ruby tests.

* Scripts/webkitruby/check-for-inappropriate-macros-in-external-headers-tests/fake-data-failing-expected.txt: Added.
* Scripts/webkitruby/check-for-inappropriate-macros-in-external-headers-tests/pass-expected.txt: Added.
* Scripts/webkitruby/check-for-inappropriate-macros-in-external-headers-tests/passing-expected.txt: Added.
* Scripts/webkitruby/check-for-inappropriate-macros-in-external-headers-tests/resources/Fake.framework/Headers/Fail.h: Added.
* Scripts/webkitruby/check-for-inappropriate-macros-in-external-headers-tests/resources/Fake.framework/Headers/Pass.h: Added.
* Scripts/webkitruby/check-for-inappropriate-macros-in-external-headers-tests/run-test.rb: Added.
Tests for the new script.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Unreviewed gardening.
dmazzoni@google.com [Tue, 18 Dec 2012 21:34:52 +0000 (21:34 +0000)]
[chromium] Unreviewed gardening.

Updating the expectation and unskipping a test whose output was correct.

* platform/chromium/TestExpectations:
* platform/chromium/accessibility/legend-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION: Using the Exit Full Screen button in the menu bar to exit HTML5 / media...
jer.noble@apple.com [Tue, 18 Dec 2012 21:28:17 +0000 (21:28 +0000)]
REGRESSION: Using the Exit Full Screen button in the menu bar to exit HTML5 / media full screen breaks Safari windows
https://bugs.webkit.org/show_bug.cgi?id=104610

Reviewed by Anders Carlsson.

When a user clicks on the menu-bar exit fullscreen button, that skips notifying the document that
the window is exiting fullscreen and tearing down the placeholder. Manually call that part of the code
when we detect that it has been skipped.

* UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController _startExitFullScreenAnimationWithDuration:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAX: support clickPoint in DRT for chromium
dmazzoni@google.com [Tue, 18 Dec 2012 21:28:06 +0000 (21:28 +0000)]
AX: support clickPoint in DRT for chromium
https://bugs.webkit.org/show_bug.cgi?id=97359

Reviewed by Chris Fleizach.

Source/WebKit/chromium:

Exposes the clickPoint accessibility method in WebAccessibilityObject.

* public/WebAccessibilityObject.h:
(WebAccessibilityObject):
* src/WebAccessibilityObject.cpp:
(WebKit::WebAccessibilityObject::clickPoint):
(WebKit):

Tools:

Implement clickPointX, clickPointY, and elementAtPoint for Chromium, so that
several more tests can pass.

* DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
(WebTestRunner::AccessibilityUIElement::AccessibilityUIElement):
(WebTestRunner::AccessibilityUIElement::clickPointXGetterCallback):
(WebTestRunner):
(WebTestRunner::AccessibilityUIElement::clickPointYGetterCallback):
(WebTestRunner::AccessibilityUIElement::elementAtPointCallback):
* DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h:
(AccessibilityUIElement):

LayoutTests:

Enable four more tests now that clickPointX, clickPointY,
and elementAtPoint are implemented for Chromium.

Minor fixes to two tests to make them more robust
across platfoms and when run in parallel.

* accessibility/svg-bounds.html: Updated
* accessibility/svg-bounds-expected.txt: Added (made cross-platform
* accessibility/svg-remote-element.html: Updated
* accessibility/svg-remote-element-expected.txt: Added (made cross-platform)
* platform/mac/accessibility/svg-bounds-expected.txt: Deleted
* platform/mac/accessibility/svg-remote-element-expected.txt: Deleted
* platform/chromium/TestExpectations: Updated

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWebProcesses often crash if they access the network after a NetworkProcess crash.
beidson@apple.com [Tue, 18 Dec 2012 21:09:02 +0000 (21:09 +0000)]
WebProcesses often crash if they access the network after a NetworkProcess crash.
<rdar://problem/12865789> and https://bugs.webkit.org/show_bug.cgi?id=105338

Reviewed by Alexey Proskuryakov.

After a NetworkProcess crash we should try to re-establish a connection to a new NetworkProcess
when it is needed.

If that attempt fails, then the WebProcess should "cleanly" crash.

* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::networkConnection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[HTMLTemplateElement] Prevent first-level recursive <template> from resetting the...
adamk@chromium.org [Tue, 18 Dec 2012 21:06:33 +0000 (21:06 +0000)]
[HTMLTemplateElement] Prevent first-level recursive <template> from resetting the implied context
https://bugs.webkit.org/show_bug.cgi?id=104142

Reviewed by Eric Seidel.

Source/WebCore:

This patch adds a stack of InsertionModes retains the chosen
"implied context" for each template element.

Based on a patch by Rafael Weinstein.

Tests added to html5lib/run-template.html

* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::HTMLTreeBuilder): Initialize the stack appropriately for HTMLTemplateElement.innerHTML.
(WebCore::HTMLTreeBuilder::processTemplateStartTag):
(WebCore::HTMLTreeBuilder::processTemplateEndTag):
(WebCore::HTMLTreeBuilder::processStartTag): Once we've figured out the insertion mode for a given <template> store it in the stack.
(WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::processEndOfFile): Clear the stack if we hit end of file to allow the assertion in finish().
(WebCore::HTMLTreeBuilder::finished):
* html/parser/HTMLTreeBuilder.h:
(HTMLTreeBuilder):

LayoutTests:

Added test that the original template context is retained after inner template.

* html5lib/resources/template.dat:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBuild fix after r138045.
rniwa@webkit.org [Tue, 18 Dec 2012 21:02:45 +0000 (21:02 +0000)]
Build fix after r138045.

* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._collect_tests): Use relative_path. We skip only when this path
is not explicitly specified. The condition was backwards but never matched so we
always ran the test regardless of whether it's listed in the skipped list or not.
* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(test_collect_tests_with_ignored_skipped_list): Renamed so that it actually runs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Clean up "frontState" vs. "geometry" naming confusion.
jpetsovits@rim.com [Tue, 18 Dec 2012 20:58:13 +0000 (20:58 +0000)]
[BlackBerry] Clean up "frontState" vs. "geometry" naming confusion.
https://bugs.webkit.org/show_bug.cgi?id=105331
RIM PR 260232

Reviewed by Adam Treat.

The concept of the "front state" is going away or will be
marginalized/renamed, but I don't want to clutter upcoming
patches with renames. So do the variable renames in here,
once, and have future patches focus on actual behavior changes.

* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::shouldDirectRenderingToWindow):
(BlackBerry::WebKit::BackingStorePrivate::setBackingStoreRect):
(BlackBerry::WebKit::BackingStorePrivate::updateTilesAfterBackingStoreRectChange):
(BlackBerry::WebKit::BackingStorePrivate::render):
(BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
(BlackBerry::WebKit::BackingStorePrivate::compositeContents):
(BlackBerry::WebKit::BackingStorePrivate::resetTiles):
(BlackBerry::WebKit::BackingStorePrivate::updateTiles):
(BlackBerry::WebKit::BackingStorePrivate::updateTilesForScrollOrNotRenderedRegion):
(BlackBerry::WebKit::BackingStorePrivate::createSurfaces):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Use midpoint for fixed position heuristic
commit-queue@webkit.org [Tue, 18 Dec 2012 20:51:05 +0000 (20:51 +0000)]
[BlackBerry] Use midpoint for fixed position heuristic
https://bugs.webkit.org/show_bug.cgi?id=105329

Patch by Andrew Lo <anlo@rim.com> on 2012-12-18
Reviewed by Rob Buis.
Internally reviewed by Joe Mason.

Use the midpoint of the layer when determining whether the
fixed-position layer is on the top or bottom half of the screen
rather than the top of the layer.
Internal PR 237073.

No new tests are needed.

* platform/graphics/blackberry/LayerRenderer.cpp:
(WebCore::LayerRenderer::updateLayersRecursive):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Fixed position elements should be fixed position on x axis
commit-queue@webkit.org [Tue, 18 Dec 2012 20:49:02 +0000 (20:49 +0000)]
[BlackBerry] Fixed position elements should be fixed position on x axis
https://bugs.webkit.org/show_bug.cgi?id=105333

Patch by Andrew Lo <anlo@rim.com> on 2012-12-18
Reviewed by Rob Buis.
Internally reviewed by Joe Mason.

Have fixed position elements be fixed on the X axis as well as Y.
This better aligns with what other ports are doing.
Internal PR237073.

No new tests are needed.

* platform/graphics/blackberry/LayerRenderer.cpp:
(WebCore::LayerRenderer::updateLayersRecursive):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Reduce calls to IMF on return
nghanavatian@rim.com [Tue, 18 Dec 2012 20:34:35 +0000 (20:34 +0000)]
[BlackBerry] Reduce calls to IMF on return
https://bugs.webkit.org/show_bug.cgi?id=105308

Reviewed by Yong Li.

PR207743
The extra calls of selection change and most importantly, end composition
are sent incorrectly on return. This is causing our state to be reset
every time we hit enter.

Internally reviewed by Mike Fenton and Gen Mak.

* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::InputHandler):
(BlackBerry::WebKit::InputHandler::nodeTextChanged):
(BlackBerry::WebKit::InputHandler::selectionChanged):
(BlackBerry::WebKit::InputHandler::handleKeyboardInput):
(BlackBerry::WebKit::InputHandler::shouldNotifyWebView):
(WebKit):
* WebKitSupport/InputHandler.h:
(InputHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138054 268f45cc-cd09-0410-ab3c-d52691b4dbfc