WebKit-https.git
16 years agoSomehow this file was missed in the last commit. Since it's just a delete, do it...
darin [Sun, 29 Jan 2006 09:09:08 +0000 (09:09 +0000)]
Somehow this file was missed in the last commit. Since it's just a delete, do it without a new ChangeLog entry.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago - updated tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=6895
darin [Sun, 29 Jan 2006 08:57:00 +0000 (08:57 +0000)]
    - updated tests for bugzilla.opendarwin.org/show_bug.cgi?id=6895
          include exception names in JavaScript form of DOM exception

        * dom/xhtml/level1/core/hc_nodevalue03-expected.txt:
        * dom/xhtml/level3/core/canonicalform06-expected.txt:
        * dom/xhtml/level3/core/documentgetdoctype01-expected.txt:
        * dom/xhtml/level3/core/infoset06-expected.txt:
        * dom/xhtml/level3/core/infoset07-expected.txt:
        * dom/xhtml/level3/core/nodecomparedocumentposition02-expected.txt:
        * dom/xhtml/level3/core/nodeinsertbefore02-expected.txt:
        * dom/xhtml/level3/core/nodeinsertbefore05-expected.txt:
        * dom/xhtml/level3/core/nodeisequalnode17-expected.txt:
        * dom/xhtml/level3/core/noderemovechild04-expected.txt:
        * dom/xhtml/level3/core/noderemovechild05-expected.txt:
        * dom/xhtml/level3/core/nodereplacechild13-expected.txt:
        * dom/xhtml/level3/core/wellformed01-expected.txt:
        * dom/xhtml/level3/core/wellformed02-expected.txt:
        * dom/xhtml/level3/core/wellformed03-expected.txt:
        * dom/xhtml/level3/core/wellformed04-expected.txt:

        - for these, also changed the tests to be dumpAsText at the same time

        * fast/dom/outerText-no-element.html:
        * fast/dom/outerText-no-element-expected.txt:
        * fast/dynamic/outerHTML-no-element.html:
        * fast/dynamic/outerHTML-no-element-expected.txt:

        * fast/dom/outerText-no-element-expected.checksum: Removed.
        * fast/dom/outerText-no-element-expected.png: Removed.
        * fast/dynamic/outerHTML-no-element-expected.checksum: Removed.
        * fast/dynamic/outerHTML-no-element-expected.png: Removed.

        - removed test results for tests that are either disabled or not checked in

        * dom/xhtml/level2/html/HTMLIFrameElement11-expected.txt: Removed.
        * dom/xhtml/level3/core/documentadoptnode22-expected.txt: Removed.
        * editing/execCommand/boldCharacter-expected.txt: Removed.
        * fast/parser/remove-block-in-residual-style-expected.checksum: Removed.
        * fast/parser/remove-block-in-residual-style-expected.png: Removed.
        * fast/parser/remove-block-in-residual-style-expected.txt: Removed.
        * fast/plugins: Removed.
        * fast/plugins/netscape-back-forward-expected.txt: Removed.
        * fast/plugins/resources: Removed.
        * fast/plugins/resources/go-back.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-01-29 Eric Seidel <eseidel@apple.com>
eseidel [Sun, 29 Jan 2006 08:26:04 +0000 (08:26 +0000)]
2006-01-29  Eric Seidel  <eseidel@apple.com>

        Reviewed by mjs.

        Fix SVG layout tests crash due to Vector change.

        * kcanvas/device/KRenderingDevice.cpp:
        (KRenderingDevice::currentContext): check isEmpty, return 0

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-01-28 Eric Seidel <eseidel@apple.com>
eseidel [Sun, 29 Jan 2006 08:04:11 +0000 (08:04 +0000)]
2006-01-28  Eric Seidel  <eseidel@apple.com>

        Reviewed by mjs.

        Remove bogus IntRect operator.

        * platform/FloatRect.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoWebCore:
hyatt [Sun, 29 Jan 2006 07:45:00 +0000 (07:45 +0000)]
WebCore:

        Cleanup of RenderImage.  Eliminate unneeded members and methods.

        Reviewed by darin

        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge elementAtPoint:]):
        * khtml/ecma/kjs_html.cpp:
        (KJS::KJS::Context2DFunction::callAsFunction):
        (KJS::drawPattern):
        * khtml/html/HTMLInputElementImpl.cpp:
        (WebCore::HTMLInputElementImpl::attach):
        * khtml/html/html_imageimpl.cpp:
        (WebCore::HTMLImageLoader::notifyFinished):
        (WebCore::HTMLImageElementImpl::attach):
        * khtml/html/html_imageimpl.h:
        (WebCore::HTMLImageElementImpl::compositeOperator):
        * khtml/html/html_objectimpl.cpp:
        (WebCore::HTMLObjectElementImpl::attach):
        * ksvg2/svg/SVGImageElementImpl.cpp:
        (SVGImageElementImpl::attach):
        * kwq/KWQPainter.h:
        * kwq/KWQPainter.mm:
        (WebCore::QPainter::drawImageAtPoint):
        (WebCore::QPainter::drawImageInRect):
        (WebCore::QPainter::drawImage):
        (WebCore::QPainter::drawFloatImage):
        (WebCore::QPainter::drawTiledImage):
        (WebCore::QPainter::drawScaledAndTiledImage):
        * kwq/WebCoreImageRenderer.h:
        * loader/CachedImage.cpp:
        (WebCore::CachedImage::ref):
        (WebCore::CachedImage::notifyObservers):
        (WebCore::CachedImage::data):
        (WebCore::CachedImage::error):
        * loader/CachedImage.h:
        * loader/CachedObjectClient.h:
        (WebCore::CachedObjectClient::imageChanged):
        * platform/Image.h:
        (WebCore::Image::):
        * platform/mac/Image.mm:
        (WebCore::Image::Image):
        (WebCore::Image::resetAnimation):
        (WebCore::Image::operator=):
        (WebCore::Image::stopAnimations):
        (WebCore::):
        (WebCore::Image::compositeOperatorFromString):
        * rendering/render_box.cpp:
        (WebCore::RenderBox::paintBackgroundExtended):
        * rendering/render_canvasimage.cpp:
        (WebCore::RenderCanvasImage::paint):
        * rendering/render_image.cpp:
        (WebCore::RenderImage::RenderImage):
        (WebCore::RenderImage::~RenderImage):
        (WebCore::RenderImage::setContentObject):
        (WebCore::RenderImage::setCachedImage):
        (WebCore::RenderImage::imageChanged):
        (WebCore::RenderImage::resetAnimation):
        (WebCore::RenderImage::paint):
        (WebCore::RenderImage::layout):
        (WebCore::RenderImage::updateAltText):
        (WebCore::RenderImage::calcReplacedWidth):
        (WebCore::RenderImage::calcReplacedHeight):
        * rendering/render_image.h:
        (WebCore::RenderImage::cachedImage):
        (WebCore::RenderImage::image):
        (WebCore::RenderImage::errorOccurred):
        * rendering/render_list.cpp:
        (RenderListMarker::paint):
        (RenderListMarker::imageChanged):
        * rendering/render_list.h:
        * rendering/render_object.cpp:
        (WebCore::RenderObject::paintBorderImage):
        (WebCore::RenderObject::setImage):
        * rendering/render_object.h:

WebKit:

        Clean up RenderImage, eliminating unneeded members and methods.

        Reviewed by darin

        * WebCoreSupport.subproj/WebImageRenderer.h:
        * WebCoreSupport.subproj/WebImageRenderer.m:
        (-[WebImageRenderer copyWithZone:]):
        (-[WebImageRenderer size]):
        (-[WebImageRenderer drawImageInRect:fromRect:compositeOperator:context:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by John Sullivan.
darin [Sun, 29 Jan 2006 07:42:57 +0000 (07:42 +0000)]
    Reviewed by John Sullivan.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=6870
          REGRESSION: JavaScript Date constructor won't accept another Date object

        * fast/js/date-constructor.html: Added.
        * fast/js/date-constructor-expected.txt: Added.
        * fast/js/resources/date-constructor.js: Added.

        * fast/js/resources/date-big-constructor.js: Formatting tweak.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by John Sullivan.
darin [Sun, 29 Jan 2006 07:42:32 +0000 (07:42 +0000)]
    Reviewed by John Sullivan.

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=6895
          include exception names in JavaScript form of DOM exception

        * khtml/ecma/kjs_binding.cpp: (KJS::setDOMException): Include the name of the
        exception in the error message.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
darin [Sun, 29 Jan 2006 07:38:33 +0000 (07:38 +0000)]
LayoutTests:

        Reviewed by Eric.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=6711
          crash if an event is dispatched to a listener that uses handleEvent

        * fast/events/dispatch-to-handle-event.html: Added.
        * fast/events/dispatch-to-handle-event-expected.txt: Added.

WebCore:

        Reviewed by Eric.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6711
          crash if an event is dispatched to a listener that uses handleEvent

        Test: fast/events/dispatch-to-handle-event.html

        * khtml/ecma/kjs_events.cpp: (KJS::JSAbstractEventListener::handleEvent):
        Remove boolean that is always false, and correct the one place that was
        checking it to check the correct pointer instead.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin.
mjs [Sun, 29 Jan 2006 06:52:29 +0000 (06:52 +0000)]
    Reviewed by Darin.

        - remove QPtrStack, replace with Vector or traverseNextNode as appropriate

        * WebCore.xcodeproj/project.pbxproj:
        * kcanvas/device/KRenderingDevice.cpp:
        (KRenderingDevice::currentContext):
        (KRenderingDevice::popContext):
        (KRenderingDevice::pushContext):
        * kcanvas/device/KRenderingDevice.h:
        * khtml/html/html_documentimpl.cpp:
        * khtml/xml/DocumentImpl.cpp:
        * khtml/xml/xml_tokenizer.cpp:
        (WebCore::XMLTokenizer::XMLTokenizer):
        * kwq/KWQAccObject.mm:
        (-[KWQAccObject addChildrenToArray:]):
        * kwq/KWQPainter.mm:
        (WebCore::QPainter::save):
        (WebCore::QPainter::restore):
        * kwq/KWQPtrStack.h: Removed.
        * ForwardingHeaders/qptrstack.h: Removed.
        * ForwardingHeaders/q3ptrstack.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin.
mjs [Sun, 29 Jan 2006 06:47:45 +0000 (06:47 +0000)]
    Reviewed by Darin.

        - miscellaneous Vector improvements

        * kxmlcore/Vector.h:
        (KXMLCore::Vector::at): Add range-checking asserts.
        (KXMLCore::Vector::first): Added as a convenience.
        (KXMLCore::Vector::last): Convenience for stack-style use.
        (KXMLCore::Vector::removeLast): ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago - added missing forwarding header to fix build.
mjs [Sun, 29 Jan 2006 06:25:53 +0000 (06:25 +0000)]
    - added missing forwarding header to fix build.

        * ForwardingHeaders/kxmlcore/Vector.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago * khtml/ecma/kjs_binding.cpp: (KJS::setDOMException): Removed extra parameter
darin [Sun, 29 Jan 2006 05:26:02 +0000 (05:26 +0000)]
    * khtml/ecma/kjs_binding.cpp: (KJS::setDOMException): Removed extra parameter
        to fix the build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin.
mjs [Sun, 29 Jan 2006 05:23:16 +0000 (05:23 +0000)]
    Reviewed by Darin.

        - converted KWQKURL to use Vector
        ://bugzilla.opendarwin.org/show_bug.cgi?id=6900

        Use Vector in place of Array, and in place of the custom stack
        buffers with overflow.

        * kwq/KWQKURL.mm:
        (KURL::KURL):
        (KURL::decode_string):
        (KURL::parse):
        (KURL::encode_string):
        (findHostnamesInMailToURL):
        (encodeHostnames):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Maciej.
darin [Sun, 29 Jan 2006 04:30:31 +0000 (04:30 +0000)]
    Reviewed by Maciej.

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=6895
          include exception names in JavaScript form of DOM exception

        * khtml/ecma/kjs_binding.cpp: (KJS::setDOMException): Include the name of the
        exception in the error message.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago * kjs/create_hash_table: Added missing license.
darin [Sun, 29 Jan 2006 04:18:56 +0000 (04:18 +0000)]
    * kjs/create_hash_table: Added missing license.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago * DumpRenderTree/DumpRenderTree.m: (dump): Dump the image if it's not
darin [Sun, 29 Jan 2006 04:17:20 +0000 (04:17 +0000)]
    * DumpRenderTree/DumpRenderTree.m: (dump): Dump the image if it's not
        already there, even if the checksum is correct.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Dave Hyatt.
mjs [Sun, 29 Jan 2006 04:12:59 +0000 (04:12 +0000)]
    Reviewed by Dave Hyatt.

        - added a Vector class
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6894

        * JavaScriptCore.xcodeproj/project.pbxproj:
        * kjs/internal.cpp:
        (KJS::Parser::saveNewNode): Apply Vector.
        (KJS::clearNewNodes): ditto
        * kjs/number_object.cpp:
        (integer_part_noexp): ditto
        (char_sequence): ditto
        * kjs/ustring.cpp:
        (KJS::UString::UTF8String): ditto
        * kxmlcore/HashMap.h:
        (KXMLCore::deleteAllValues): Tweaked this to only apply to HashMap,
        other versions are useful for other containers.
        * kxmlcore/Vector.h: Added. Implemented a Vector class, which should
        be usable for all Array/QVector style purposes, and also as a stack buffer
        with oversize handling. Also some helper classes to make vector operations
        as efficient as possible for POD types and for simple non-PODs like RefPtr.
        (KXMLCore::):
        (KXMLCore::VectorTypeOperations::destruct):
        (KXMLCore::VectorTypeOperations::initialize):
        (KXMLCore::VectorTypeOperations::move):
        (KXMLCore::VectorTypeOperations::uninitializedCopy):
        (KXMLCore::VectorTypeOperations::uninitializedFill):
        (KXMLCore::VectorBuffer::VectorBuffer):
        (KXMLCore::VectorBuffer::~VectorBuffer):
        (KXMLCore::VectorBuffer::deallocateBuffer):
        (KXMLCore::VectorBuffer::inlineBuffer):
        (KXMLCore::Vector::Vector):
        (KXMLCore::Vector::~Vector):
        (KXMLCore::Vector::size):
        (KXMLCore::Vector::capacity):
        (KXMLCore::Vector::isEmpty):
        (KXMLCore::Vector::at):
        (KXMLCore::Vector::operator[]):
        (KXMLCore::Vector::data):
        (KXMLCore::Vector::operator T*):
        (KXMLCore::Vector::operator const T*):
        (KXMLCore::Vector::begin):
        (KXMLCore::Vector::end):
        (KXMLCore::Vector::clear):
        (KXMLCore::Vector::fill):
        (KXMLCore::Vector::operator=):
        (KXMLCore::::Vector):
        (KXMLCore::::operator):
        (KXMLCore::::fill):
        (KXMLCore::::expandCapacity):
        (KXMLCore::::resize):
        (KXMLCore::::reserveCapacity):
        (KXMLCore::::append):
        (KXMLCore::deleteAllValues):
        * kxmlcore/VectorTraits.h: Added.
        (KXMLCore::VectorTraits): Traits to enable making Vector efficient for
        simple types.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoEliminate three unused methods on Image: increase/DecreaseUseCount and flushRasterCache.
hyatt [Sun, 29 Jan 2006 01:50:50 +0000 (01:50 +0000)]
Eliminate three unused methods on Image: increase/DecreaseUseCount and flushRasterCache.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoEliminate three unused methods on Image: increase/DecreaseUseCount and flushRasterCache.
hyatt [Sun, 29 Jan 2006 01:50:32 +0000 (01:50 +0000)]
Eliminate three unused methods on Image: increase/DecreaseUseCount and flushRasterCache.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin.
darin [Sun, 29 Jan 2006 01:32:28 +0000 (01:32 +0000)]
    Reviewed by Darin.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=5868
          Crash on HP.com with ToT and Safari 2.0.2 in khtml::RenderContainer::detach()

        * fast/table/add-before-anonymous-child.html: Added.
        * fast/table/add-before-anonymous-child-expected.txt: Added.
        * fast/table/add-before-anonymous-child-expected.png: Added.
        * fast/table/add-before-anonymous-child-expected.checksum: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Test: fast/table/add-before-anonymous-child.html
darin [Sun, 29 Jan 2006 01:29:33 +0000 (01:29 +0000)]
    Test: fast/table/add-before-anonymous-child.html

        Reviewed by Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5868
          Crash on HP.com with ToT and Safari 2.0.2 in khtml::RenderContainer::detach()

        * rendering/RenderTableRow.cpp:
        (WebCore::RenderTableRow::addChild): If beforeChild is inside an anonymous
        cell, insert into the cell.
        * rendering/RenderTableSection.cpp:
        (WebCore::RenderTableSection::addChild): Changed comment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Eliminate the mask() method on Image. It's unused.
hyatt [Sun, 29 Jan 2006 00:58:46 +0000 (00:58 +0000)]
    Eliminate the mask() method on Image.  It's unused.

        * platform/Image.h:
        * platform/mac/Image.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoFix Changelog typo.
hyatt [Sun, 29 Jan 2006 00:16:23 +0000 (00:16 +0000)]
Fix Changelog typo.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Clean up the Image class. Eliminate the MIME type memebr variable.
hyatt [Sun, 29 Jan 2006 00:15:37 +0000 (00:15 +0000)]
    Clean up the Image class.  Eliminate the MIME type memebr variable.
        Eliminate an unused constructor.  Fix the constructor to take
        a QString rather than an NSString so that it's portable.  Rename
        the receivedData method to decode.  Move canRenderImageType into
        the Image class as a static method.

        Reviewed by mjs

        * khtml/html/html_objectimpl.cpp:
        (WebCore::HTMLObjectElementImpl::isImageType):
        * kwq/KWQLoader.h:
        * kwq/KWQLoader.mm:
        (KWQResponseMIMEType):
        * loader/CachedImage.cpp:
        (WebCore::CachedImage::data):
        * platform/Image.h:
        * platform/mac/Image.mm:
        (WebCore::Image::supportsType):
        (WebCore::Image::Image):
        (WebCore::Image::~Image):
        (WebCore::Image::decode):
        (WebCore::Image::operator=):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-01-28 Alexander Kellett <lypanov@kde.org>
eseidel [Sat, 28 Jan 2006 10:18:23 +0000 (10:18 +0000)]
2006-01-28  Alexander Kellett  <lypanov@kde.org>

        Reviewed by eseidel.

        SourceAlpha does not display until window is redrawn (resized)
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6375

        Test: svg/custom/filter-source-alpha.svg

        * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
        (KCanvasFilterQuartz::inputImage):`

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin.
ap [Sat, 28 Jan 2006 08:53:52 +0000 (08:53 +0000)]
    Reviewed by Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5163
        RealPlayer.GetTitle() Crashes Safari/Dashboard

        * bindings/c/c_utility.cpp: (KJS::Bindings::convertUTF8ToUTF16):
        Fallback to kCFStringEncodingWindowsLatin1 if the passed buffer is not valid UTF-8, preventing crashes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Fix CachedImage.h/.cpp up. Lots of cleanup. Eliminated
hyatt [Sat, 28 Jan 2006 08:52:23 +0000 (08:52 +0000)]
    Fix CachedImage.h/.cpp up.  Lots of cleanup.  Eliminated
        unused code and cleaned up method and member names.

        Reviewed by darin

        * WebCore.xcodeproj/project.pbxproj:
        * khtml/html/html_imageimpl.cpp:
        (WebCore::HTMLImageElementImpl::width):
        (WebCore::HTMLImageElementImpl::height):
        * loader/CachedImage.cpp:
        (WebCore::CachedImage::CachedImage):
        (WebCore::CachedImage::ref):
        (WebCore::CachedImage::deref):
        (WebCore::CachedImage::image):
        (WebCore::CachedImage::imageSize):
        (WebCore::CachedImage::decodedRect):
        (WebCore::CachedImage::notifyObservers):
        (WebCore::CachedImage::clear):
        (WebCore::CachedImage::data):
        (WebCore::CachedImage::error):
        (WebCore::CachedImage::checkNotify):
        * loader/CachedImage.h:
        (WebCore::CachedImage::isDecoded):
        (WebCore::CachedImage::isErrorImage):
        (WebCore::CachedImage::schedule):
        (WebCore::CachedImage::isImage):
        * loader/CachedImageCallback.cpp: Removed.
        * loader/CachedImageCallback.h: Removed.
        * loader/loader.cpp:
        (WebCore::Loader::servePendingRequests):
        (WebCore::Loader::slotFinished):
        * platform/Image.h:
        * platform/mac/Image.mm:
        (WebCore::Image::receivedData):
        * rendering/render_box.cpp:
        (WebCore::RenderBox::paintBackgroundExtended):
        * rendering/render_image.cpp:
        (WebCore::RenderImage::setImage):
        (WebCore::RenderImage::paint):
        * rendering/render_line.cpp:
        (WebCore::InlineFlowBox::paintBackground):
        (WebCore::InlineFlowBox::paintBackgroundAndBorder):
        * rendering/render_list.cpp:
        (RenderListMarker::setImage):
        * rendering/render_object.cpp:
        (WebCore::RenderObject::mustRepaintBackgroundOrBorder):
        (WebCore::RenderObject::paintBorder):
        (WebCore::RenderObject::setImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Geoff.
mjs [Sat, 28 Jan 2006 03:26:25 +0000 (03:26 +0000)]
    Reviewed by Geoff.

        - GC after destroying the very last frame to avoid node leak false positives
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6884

        * ForwardingHeaders/JSLock.h: added
        * page/Page.cpp:
        (Page::~Page): In debug mode, when destroying the last page,
        0 out m_mainFrame to destroy the very last frame and then garbage collect,
        so a GC happens at a time when the stack won't have references into the JS
        heap for the conservative GC to catch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Eric.
mjs [Sat, 28 Jan 2006 03:07:25 +0000 (03:07 +0000)]
    Reviewed by Eric.

        - remove nearly all the substance of ObjectContents and put it on Frame
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6885

        * ForwardingHeaders/kjs/JSLock.h: Added.
        * bridge/mac/MacFrame.mm:
        (Plugin::Plugin): renamed from KWQPluginPart, make it able to store a view.
        (Plugin::view): And return the QWidget* view.
        (MacFrame::createPart): Use Plugin instead of KWQPluginPart, avoid setWidget.
        (MacFrame::setView): Don't use m_url directly so much, and use through d-> if
        needed.
        (MacFrame::userAgent): ditto
        (MacFrame::openURLFromPageCache): ditto
        * kwq/KWQObject.cpp:
        (QObject::inherits): Removed case for ObjectContents, which is not long for this
        world.
        * kwq/KWQObject.h:
        * page/Frame.cpp:
        (Frame::init): Don't pass parent() to FramePrivate, we can't possibly have one
        yet.
        (Frame::restoreURL): d->m_url, not m_url
        (Frame::didOpenURL): ditto
        (Frame::executeScript): ditto
        (Frame::receivedFirstData): ditto
        (Frame::begin): ditto
        (Frame::gotoAnchor): ditto
        (Frame::requestObject): ditto, plus only use Frame methods when we really have a Frame.
        (Frame::processObjectRequest): ditto, also get view() not widget().
        (Frame::childFrame): remove excess spaces and pointless assert.
        (Frame::parentFrame): just call parent() (could probably remove this).
        (Frame::reparseConfiguration): d->m_url not m_url
        (Frame::canCachePage): ditto
        (Frame::updatePolicyBaseURL): ditto
        (Frame::scrollToAnchor): ditto
        (Frame::setName): set in FramePrivate
        (Frame::name): get from FramePrivate
        (Frame::setParent): similarly
        (Frame::parent): similarly
        (Frame::url): similarly
        * page/Frame.h:
        * page/FramePrivate.h:
        (FramePrivate::FramePrivate): Added m_parent, m_name and m_url.
        * page/FrameView.cpp:
        (FrameView::viewportMousePressEvent): Call frame directly instead of
        sending through QApplication.
        (FrameView::viewportMouseDoubleClickEvent): ditto
        (FrameView::viewportMouseMoveEvent): ditto
        (FrameView::viewportMouseReleaseEvent): ditto
        * page/ObjectContents.h:
        (ObjectContents::ObjectContents): Removed url, setParent, parent, name,
        setName, openURL, closeURL, widget, setWidget, event and customEvent methods,
        and corresponding fields. Add pure virtual view() method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Adele.
darin [Sat, 28 Jan 2006 01:19:10 +0000 (01:19 +0000)]
    Reviewed by Adele.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=6075
          REGRESSION: event.relatedTarget not working, breaks menus at www.ati.com

        * fast/events/related-target-expected.txt: Added.
        * fast/events/related-target.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Adele.
darin [Sat, 28 Jan 2006 01:18:54 +0000 (01:18 +0000)]
    Reviewed by Adele.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6075
          REGRESSION: event.relatedTarget not working, breaks menus at www.ati.com

        Test: fast/events/related-target.html

        * khtml/xml/NodeImpl.h:
        * khtml/xml/NodeImpl.cpp: (WebCore::NodeImpl::dispatchMouseEvent): Added a
        relatedTarget parameter to a couple overloads.

        * page/FrameView.cpp:
        (FrameView::viewportMouseMoveEvent): Moved code to set prevMouseX/Y out of here
        and into dispatchMouseEvent, because it now handles mouseout and mouseover events,
        and that's what these globals are used for. This fixes DumpRenderTree to work
        properly with mouseout and mouseover (because it delivers only mouse down and up,
        no mouse move events).
        (FrameView::dispatchMouseEvent): Passed in the "other" node as the related target
        for mouseout and mouseover events. Also set prevMouseX/Y.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-01-27 Eric Seidel <eseidel@apple.com>
eseidel [Sat, 28 Jan 2006 01:05:21 +0000 (01:05 +0000)]
2006-01-27  Eric Seidel  <eseidel@apple.com>

        Reviewed by adele.

        * Scripts/run-webkit-tests: make new tests use absolute urls

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
adele [Fri, 27 Jan 2006 23:41:08 +0000 (23:41 +0000)]
LayoutTests:

        Adding test for
        <rdar://problem/4422624> REGRESSION: crash loading webmail.mac.com

        * fast/forms/input-no-renderer-expected.checksum: Added.
        * fast/forms/input-no-renderer-expected.png: Added.
        * fast/forms/input-no-renderer-expected.txt: Added.
        * fast/forms/input-no-renderer.html: Added.

WebCore:

        Adding comment for added layout test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoUpdated ChangeLog to mention layout tests landed with previous commits.
eseidel [Fri, 27 Jan 2006 23:06:59 +0000 (23:06 +0000)]
Updated ChangeLog to mention layout tests landed with previous commits.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoUpdating ChangeLog with explanation of missing test case.
adele [Fri, 27 Jan 2006 22:39:42 +0000 (22:39 +0000)]
Updating ChangeLog with explanation of missing test case.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoUpdated ChangeLog to explain why my last commit did not include a test case.
tomernic [Fri, 27 Jan 2006 21:18:58 +0000 (21:18 +0000)]
Updated ChangeLog to explain why my last commit did not include a test case.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-01-27 Eric Seidel <eseidel@apple.com>
eseidel [Fri, 27 Jan 2006 10:52:53 +0000 (10:52 +0000)]
2006-01-27  Eric Seidel  <eseidel@apple.com>

        Reviewed by mjs.

        make run-webkit-tests output total leaks count

        * Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Fix for 6867. Rename QPixmap to Image and move it to platform/.
hyatt [Fri, 27 Jan 2006 10:22:26 +0000 (10:22 +0000)]
    Fix for 6867.  Rename QPixmap to Image and move it to platform/.
        Eliminate QPaintDevice and QPaintDeviceMetrics completely, since
        they aren't necessary.

        Reviewed by anders

        * ForwardingHeaders/q3paintdevicemetrics.h: Removed.
        * ForwardingHeaders/qpaintdevice.h: Removed.
        * ForwardingHeaders/qpaintdevicemetrics.h: Removed.
        * ForwardingHeaders/qpixmap.h: Removed.
        * WebCore.xcodeproj/project.pbxproj:
        * bridge/mac/MacFrame.mm:
        (MacFrame::fileWrapperForElement):
        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge reapplyStylesForDeviceType:]):
        (nowPrinting):
        (-[WebCoreFrameBridge elementAtPoint:]):
        * css/css_valueimpl.cpp:
        (WebCore::CSSPrimitiveValueImpl::computeLength):
        (WebCore::CSSPrimitiveValueImpl::computeLengthFloat):
        * css/css_valueimpl.h:
        * css/csshelper.cpp:
        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::CSSStyleSelector):
        (WebCore::CSSStyleSelector::init):
        (WebCore::CSSStyleSelector::initForStyleResolve):
        (WebCore::CSSStyleSelector::styleForElement):
        (WebCore::CSSStyleSelector::pseudoStyleForElement):
        (WebCore::convertToLength):
        (WebCore::CSSStyleSelector::applyProperty):
        (WebCore::CSSStyleSelector::mapBackgroundXPosition):
        (WebCore::CSSStyleSelector::mapBackgroundYPosition):
        * css/cssstyleselector.h:
        * kcanvas/KCanvasFilters.h:
        (KCanvasFEImage::image):
        (KCanvasFEImage::setImage):
        * kcanvas/KCanvasImage.h:
        * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
        (KCanvasFEImageQuartz::getCIFilter):
        * kcanvas/device/quartz/KCanvasResourcesQuartz.h:
        (KCanvasImageQuartz::init):
        * khtml/ecma/kjs_events.cpp:
        (KJS::ClipboardProtoFunc::callAsFunction):
        * khtml/ecma/kjs_html.cpp:
        (KJS::KJS::Context2DFunction::callAsFunction):
        (KJS::drawPattern):
        (KJS::_rh):
        (KJS::ImagePattern::createPattern):
        * khtml/ecma/kjs_html.h:
        (KJS::ImagePattern::image):
        * khtml/ecma/kjs_window.cpp:
        (KJS::Screen::getValueProperty):
        * khtml/editing/SelectionController.h:
        * khtml/html/html_imageimpl.h:
        (WebCore::HTMLImageElementImpl::image):
        * khtml/misc/helper.h:
        * khtml/xml/DocumentImpl.cpp:
        (WebCore::DocumentImpl::DocumentImpl):
        (WebCore::DocumentImpl::~DocumentImpl):
        (WebCore::DocumentImpl::recalcStyle):
        (WebCore::DocumentImpl::attach):
        (WebCore::DocumentImpl::detach):
        * khtml/xml/DocumentImpl.h:
        (WebCore::DocumentImpl::printing):
        (WebCore::DocumentImpl::setPrinting):
        * khtml/xml/dom2_eventsimpl.h:
        * ksvg2/css/SVGCSSStyleSelector.cpp:
        * ksvg2/misc/KCanvasRenderingStyle.cpp:
        (WebCore::KSVGPainterFactory::cssPrimitiveToLength):
        (WebCore::KSVGPainterFactory::strokePainter):
        * ksvg2/svg/SVGCursorElementImpl.cpp:
        (SVGCursorElementImpl::notifyFinished):
        * ksvg2/svg/SVGCursorElementImpl.h:
        (KSVG::SVGCursorElementImpl::image):
        * ksvg2/svg/SVGDocumentImpl.cpp:
        (SVGDocumentImpl::SVGDocumentImpl):
        * ksvg2/svg/SVGFEImageElementImpl.cpp:
        (SVGFEImageElementImpl::notifyFinished):
        * ksvg2/svg/SVGMaskElementImpl.cpp:
        (KSVG::SVGMaskElementImpl::drawMaskerContent):
        * ksvg2/svg/SVGSVGElementImpl.cpp:
        * kwq/KWQApplication.h:
        * kwq/KWQApplication.mm:
        (QDesktopWidget::screenDepth):
        * kwq/KWQClipboard.h:
        * kwq/KWQClipboard.mm:
        (WebCore::KWQClipboard::dragImage):
        (WebCore::KWQClipboard::setDragImage):
        (WebCore::KWQClipboard::setDragImageElement):
        * kwq/KWQComboBox.mm:
        * kwq/KWQCursor.h:
        * kwq/KWQCursor.mm:
        (WebCore::createCustomCursor):
        (WebCore::QCursor::QCursor):
        * kwq/KWQKPartsEvent.h:
        * kwq/KWQObject.h:
        * kwq/KWQPaintDevice.h: Removed.
        * kwq/KWQPaintDeviceMetrics.h: Removed.
        * kwq/KWQPaintDeviceMetrics.mm: Removed.
        * kwq/KWQPainter.h:
        (WebCore::QPainter::printing):
        * kwq/KWQPainter.mm:
        (WebCore::QPainter::drawImage):
        (WebCore::QPainter::drawFloatImage):
        (WebCore::QPainter::drawTiledImage):
        (WebCore::QPainter::drawScaledAndTiledImage):
        * kwq/KWQPixmap.h: Removed.
        * kwq/KWQPixmap.mm: Removed.
        * kwq/KWQPrinter.h:
        (QPrinter::QPrinter):
        * kwq/KWQWidget.h:
        * loader/Cache.cpp:
        (khtml::Cache::init):
        (khtml::Cache::clear):
        (khtml::Cache::requestImage):
        (khtml::Cache::getStatistics):
        * loader/Cache.h:
        * loader/CachedImage.cpp:
        (WebCore::CachedImage::CachedImage):
        (WebCore::CachedImage::ref):
        (WebCore::CachedImage::tiled_image):
        (WebCore::CachedImage::image):
        (WebCore::CachedImage::image_size):
        (WebCore::CachedImage::do_notify):
        (WebCore::CachedImage::data):
        (WebCore::CachedImage::error):
        * loader/CachedImage.h:
        * loader/CachedImageCallback.cpp:
        (WebCore::CachedImageCallback::notifyUpdate):
        (WebCore::CachedImageCallback::notifyFinished):
        (WebCore::CachedImageCallback::handleError):
        * loader/CachedObject.h:
        (WebCore::CachedObject::):
        * loader/CachedObjectClient.h:
        (WebCore::CachedObjectClient::setImage):
        * loader/DocLoader.cpp:
        (khtml::DocLoader::setAutoloadImages):
        (khtml::DocLoader::setShowAnimations):
        * loader/loader.cpp:
        (WebCore::Loader::servePendingRequests):
        (WebCore::Loader::slotFinished):
        * page/Frame.cpp:
        (Frame::paint):
        * page/Frame.h:
        * page/FrameView.cpp:
        (selectCursor):
        * page/FrameView.h:
        * platform/Image.h: Added.
        * platform/mac/Image.mm: Added.
        (WebCore::Image::loadResource):
        (WebCore::Image::Image):
        (WebCore::Image::~Image):
        (WebCore::Image::imageRef):
        (WebCore::Image::resetAnimation):
        (WebCore::Image::setAnimationRect):
        (-[WebImageCallback initWithCallback:WebCore::]):
        (WebCore::Image::shouldUseThreadedDecoding):
        (WebCore::Image::receivedData):
        (WebCore::Image::mask):
        (WebCore::Image::isNull):
        (WebCore::Image::size):
        (WebCore::Image::rect):
        (WebCore::Image::width):
        (WebCore::Image::height):
        (WebCore::Image::resize):
        (WebCore::Image::operator=):
        (WebCore::Image::increaseUseCount):
        (WebCore::Image::decreaseUseCount):
        (WebCore::Image::stopAnimations):
        (WebCore::Image::flushRasterCache):
        * rendering/InlineTextBox.cpp:
        (khtml::InlineTextBox::paint):
        * rendering/InlineTextBox.h:
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::paintChildren):
        (WebCore::RenderBlock::paintObject):
        * rendering/RenderText.h:
        * rendering/font.cpp:
        (khtml::Font::update):
        * rendering/font.h:
        * rendering/render_box.cpp:
        (WebCore::RenderBox::paintBackgroundExtended):
        * rendering/render_canvasimage.cpp:
        (WebCore::RenderCanvasImage::paint):
        * rendering/render_flow.cpp:
        (RenderFlow::paintLines):
        * rendering/render_image.cpp:
        (WebCore::RenderImage::RenderImage):
        (WebCore::RenderImage::~RenderImage):
        (WebCore::RenderImage::setContentObject):
        (WebCore::RenderImage::setImage):
        (WebCore::RenderImage::paint):
        (WebCore::RenderImage::layout):
        (WebCore::RenderImage::calcReplacedWidth):
        (WebCore::RenderImage::calcReplacedHeight):
        * rendering/render_image.h:
        (WebCore::RenderImage::image):
        (WebCore::RenderImage::getImage):
        * rendering/render_line.cpp:
        (WebCore::InlineFlowBox::paintBackground):
        (WebCore::InlineFlowBox::paintBackgroundAndBorder):
        * rendering/render_list.cpp:
        (RenderListItem::getAbsoluteRepaintRect):
        (RenderListMarker::paint):
        (RenderListMarker::setImage):
        (RenderListMarker::calcMinMaxWidth):
        * rendering/render_list.h:
        * rendering/render_object.cpp:
        (WebCore::RenderObject::mustRepaintBackgroundOrBorder):
        (WebCore::RenderObject::paintBorderImage):
        (WebCore::RenderObject::paintBorder):
        (WebCore::RenderObject::setImage):
        * rendering/render_object.h:
        * rendering/render_replaced.cpp:
        (WebCore::RenderWidget::paint):
        * rendering/render_replaced.h:
        * rendering/render_theme_mac.mm:
        (khtml::RenderThemeMac::setFontFromControlSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-01-27 Eric Seidel <eseidel@apple.com>
eseidel [Fri, 27 Jan 2006 10:20:48 +0000 (10:20 +0000)]
2006-01-27  Eric Seidel  <eseidel@apple.com>

        Reviewed by mjs.

        run-webkit-test --leaks crashes (malloc logging runs out of memory)
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6869

        * Scripts/run-webkit-tests: fix --leaks to not crash

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoSomehow these ChangeLog entries weren't committed
andersca [Fri, 27 Jan 2006 09:39:21 +0000 (09:39 +0000)]
Somehow these ChangeLog entries weren't committed

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago - revised test for http://bugzilla.opendarwin.org/show_bug.cgi?id=6731
darin [Fri, 27 Jan 2006 09:35:01 +0000 (09:35 +0000)]
   - revised test for bugzilla.opendarwin.org/show_bug.cgi?id=6731
         REGRESSION: change event fires at load time for checked items

        * fast/forms/radio-button-no-change-event.html: Updated to add a second radio button.
        * fast/forms/radio-button-no-change-event-expected.txt: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Maciej.
darin [Fri, 27 Jan 2006 09:29:26 +0000 (09:29 +0000)]
    Reviewed by Maciej.

        - fix another part of http://bugzilla.opendarwin.org/show_bug.cgi?id=6731
          REGRESSION: change event fires at load time for checked items

        Revised test: fast/forms/radio-button-no-change-event.html

        * khtml/html/HTMLInputElementImpl.cpp: (WebCore::HTMLInputElementImpl::setChecked):
        Don't send a change event for a radio button getting unchecked (matches Gecko at least).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-01-26 Eric Seidel <eseidel@apple.com>
eseidel [Fri, 27 Jan 2006 08:10:43 +0000 (08:10 +0000)]
2006-01-26  Eric Seidel  <eseidel@apple.com>

        Reviewed by darin.

        run-webkit-tests should produce a self-contained results directory
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6864

        * Scripts/run-webkit-tests: copy failing items to results dir.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-01-26 Eric Seidel <eseidel@apple.com>
eseidel [Fri, 27 Jan 2006 06:55:16 +0000 (06:55 +0000)]
2006-01-26  Eric Seidel  <eseidel@apple.com>

        Reviewed by mjs.

        Leak fixes in SVG code.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6588

        * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
        (teardownShadingWithStyle): delete image and context when through.
        (KRenderingPaintServerGradientQuartz::KRenderingPaintServerGradientQuartz): zero out cached mask
        (KRenderingPaintServerGradientQuartz::~KRenderingPaintServerGradientQuartz): destroy cached mask image.
        (KRenderingPaintServerLinearGradientQuartz::setup): delete mask before making new
        (KRenderingPaintServerRadialGradientQuartz::setup): delete mask before making new
        * ksvg2/misc/KCanvasRenderingStyle.cpp:
        (WebCore::sharedSolidPaintServer): forgot "static" keyword
        * ksvg2/svg/SVGPolyElementImpl.cpp:
        (SVGPolyElementImpl::notifyAttributeChange): use RefPtr

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Eric.
mjs [Fri, 27 Jan 2006 06:05:17 +0000 (06:05 +0000)]
    Reviewed by Eric.

        - various leaks on "fast" LayoutTests

        http://bugzilla.opendarwin.org/show_bug.cgi?id=6819
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6823
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6824

        It turns out these all had the same cause.

        * page/Frame.cpp:
        (Frame::clear): If we have a document, make sure to cancel parsing,
        in case it has a tokenizer and parser that are keeping it alive. Use
        cancelParsing to avoid possibly accidentally firing the onload handler.
        * khtml/xml/DocumentImpl.cpp:
        (WebCore::DocumentImpl::cancelParsing): Factored out of implicitOpen.
        (WebCore::DocumentImpl::implicitOpen): Call cancelParsing now.
        * khtml/xml/DocumentImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Tim Omernick.
mjs [Fri, 27 Jan 2006 05:42:21 +0000 (05:42 +0000)]
    Reviewed by Tim Omernick.

        - test case for REGRESSION: crash when setting a list with list-style: none to display: none
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6860

        (This bug was fixed independently by Dave Harrison but I'm landing the test
        case anyway.)

        * fast/lists/list-style-none-crash-expected.checksum: Added.
        * fast/lists/list-style-none-crash-expected.png: Added.
        * fast/lists/list-style-none-crash-expected.txt: Added.
        * fast/lists/list-style-none-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoTest case for <rdar://problem/4256504>
bdakin [Fri, 27 Jan 2006 01:35:46 +0000 (01:35 +0000)]
Test case for <rdar://problem/4256504>
khtml::RenderBlock::skipWhitespace crashes upon interaction with
radio buttons

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoReviewed by Hyatt.
bdakin [Fri, 27 Jan 2006 01:12:15 +0000 (01:12 +0000)]
Reviewed by Hyatt.

        Fix for <rdar://problem/4256504> khtml::RenderBlock::skipWhitespace
        crashes upon interaction with radio buttons.

        The old code held an assumption that positioned elements would
        always have line boxes. This is not necessarily the case, so this
        patch makes sure that the lines are dirtied appropriately.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-01-26 Mitz Pettel <opendarwin.org@mitzpettel.com>
andersca [Thu, 26 Jan 2006 23:56:02 +0000 (23:56 +0000)]
2006-01-26  Mitz Pettel  <opendarwin.org@mitzpettel.com>

        Test: fast/dom/HTMLImageElement/image-without-renderer-width.html

        Reviewed and landed by Anders.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6841
          REGRESSION: WebKit (Thursday, January 26, 2006) crash in HTMLImageElementImpl::width()

        * khtml/html/html_imageimpl.cpp:
        (WebCore::HTMLImageElementImpl::width): Return the image's dimensions only if it isn't
        null, but even if it hasn't finished loading.
        (WebCore::HTMLImageElementImpl::height): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by John Sullivan.
tomernic [Thu, 26 Jan 2006 23:32:35 +0000 (23:32 +0000)]
    Reviewed by John Sullivan.

<rdar://problem/4422365>

        * WebView.subproj/WebHTMLView.m:
        (-[NSArray addSuperviewObservers]):
        In addition to registering for frame/bounds change notifications, call -_frameOrBoundsChanged.
        It will check the current size/scroll against the previous layout's size/scroll.  We need to
        do this here to catch the case where the WebView is laid out at one size, removed from its
        window, resized, and inserted into another window.  Our frame/bounds changed notifications
        will not be sent in that situation, since we only watch for changes while in the view hierarchy.

I have verified that this does not cause unnecessary layouts while running the PLT.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Hyatt and Vicki.
adele [Thu, 26 Jan 2006 22:45:51 +0000 (22:45 +0000)]
    Reviewed by Hyatt and Vicki.

        Fix for broken layout tests.

        * khtml/html/HTMLInputElementImpl.cpp: (WebCore::HTMLInputElementImpl::focus):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-01-26 Anders Carlsson <andersca@mac.com>
andersca [Thu, 26 Jan 2006 22:00:35 +0000 (22:00 +0000)]
2006-01-26  Anders Carlsson  <andersca@mac.com>

        Reviewed by Eric.

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=6845
        Autogenerate more classes

        This makes DocumentType and DOMImplementation autogenerated.

        * JSCore.cpp: Added.

        * WebCore.xcodeproj/project.pbxproj:
        Add JSCore.cpp

        * bindings/scripts/CodeGeneratorJS.pm:
        Add attributes for controlling how null values should be converted
        to and from DOMString objects.

        * bindings/scripts/IDLParser.pm:
        * bindings/scripts/IDLStructure.pm:
        Remove the extended attributes hash on attribute objects and
        use the one on the signature.

        * khtml/ecma/kjs_dom.cpp:
        (KJS::DOMNodeProtoFunc::callAsFunction):
        For isSupported, just convert the version argument to an empty string if
        null is passed in. The reason for this change is that the autogenerated
        binding for DOMImplementation::hasFeature does the same thing. This also makes
        us behave like Mozilla and Opera.

        (KJS::toDocumentType):
        (KJS::getDOMNode):
        Use JSDocumentType.

        (KJS::getDOMDOMImplementation):
        Use JSDOMImplementation.

        * khtml/ecma/kjs_dom.h:
        Remove DOMDOMImplementation and DOMDocumentType

        * khtml/xml/DOMImplementation.idl: Added.
        * khtml/xml/DocumentType.idl: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-01-26 Alexander Kellett <lypanov@kde.org>
eseidel [Thu, 26 Jan 2006 21:40:39 +0000 (21:40 +0000)]
2006-01-26  Alexander Kellett  <lypanov@kde.org>

        Reviewed by eseidel.

        <text> elements with a scale on a parent <g> breaks nodeAtPoint
        Fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6843

        * kcanvas/RenderSVGText.cpp:
        (RenderSVGText::nodeAtPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Geoff.
mjs [Thu, 26 Jan 2006 20:32:30 +0000 (20:32 +0000)]
    Reviewed by Geoff.

        - fixed a couple hundred node leaks on the traversal layout tests
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6828

        There were three basic problems here, any one of which was enough
        to cause the leak.

        1) If the filter function for a NodeFilter, NodeIterator or TreeWalker
        had that object in scope, it would cause a GC reference cycle. I fixed
        this by making these JS functions get marked by the corresponding JS object,
        as for XMLHttpRequest.

        2) The TraversalImpl class that's a base class for NodeIteratorImpl and
        TreeWalkerImpl did not have a virtual destructor, leading the Shared
        template to call the base class destructor on deref.

        3) ref/deref on the document were mismatched, I fixed all that sort of nonsense
        by using RefPtr instead of manual ref/deref.

        * khtml/dom/dom2_traversal.h:
        (DOM::NodeFilterCondition::mark): Add no-op virtual mark method, JS subclass
        will do something useful here.
        * khtml/ecma/kjs_traversal.cpp:
        (KJS::DOMNodeIterator::mark): Mark the DOM-level filter.
        (KJS::DOMNodeFilter::mark): ditto
        (KJS::DOMTreeWalker::mark): ditto
        (KJS::JSNodeFilterCondition::JSNodeFilterCondition): reformatted.
        (KJS::JSNodeFilterCondition::mark): Mark the filter function.
        * khtml/ecma/kjs_traversal.h:
        * khtml/xml/dom2_traversalimpl.cpp:
        (DOM::NodeFilterImpl::NodeFilterImpl): diligently applied RefPtr
        (DOM::TraversalImpl::TraversalImpl): ditto
        (DOM::TraversalImpl::~TraversalImpl): ditto
        (DOM::NodeIteratorImpl::NodeIteratorImpl): ditto
        (DOM::NodeIteratorImpl::~NodeIteratorImpl): ditto
        (DOM::NodeIteratorImpl::setReferenceNode): ditto
        (DOM::TreeWalkerImpl::TreeWalkerImpl): ditto
        (DOM::TreeWalkerImpl::setCurrentNode): ditto
        * khtml/xml/dom2_traversalimpl.h:
        (DOM::NodeFilterImpl::mark): call mark() on the codition
        (DOM::TraversalImpl::root): Use .get()
        (DOM::TraversalImpl::filter): ditto
        (DOM::NodeIteratorImpl::referenceNode): ditto
        (DOM::NodeIteratorImpl::document): ditto
        (DOM::TreeWalkerImpl::currentNode): ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Geoff.
mjs [Thu, 26 Jan 2006 20:18:55 +0000 (20:18 +0000)]
    Reviewed by Geoff.

        - fixed ~40 DOM nodes leaked when running any two of the outerHTML DOM tests (actually just a false positive)
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6822

        * kwq/KWQPageState.mm:
        (-[KWQPageState clear]): Garbage collect after deleting a bunch of
        stuff that holds onto JS objects. This should avoid false positive leaks
        and is good in any case since page state deallocation is already deferred.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Vicki.
adele [Thu, 26 Jan 2006 18:46:41 +0000 (18:46 +0000)]
    Reviewed by Vicki.

        - fix for <rdar://problem/4422624> REGRESSION: crash loading webmail.mac.com

        * khtml/html/HTMLInputElementImpl.cpp:
        (WebCore::HTMLInputElementImpl::focus): Nil check for renderer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Adding test case for:
harrison [Thu, 26 Jan 2006 16:59:11 +0000 (16:59 +0000)]
    Adding test case for:
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6835

        * editing/deleting/delete-listitem-001-expected.checksum: Added.
        * editing/deleting/delete-listitem-001-expected.png: Added.
        * editing/deleting/delete-listitem-001-expected.txt: Added.
        * editing/deleting/delete-listitem-001.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Timothy.
harrison [Thu, 26 Jan 2006 16:58:11 +0000 (16:58 +0000)]
    Reviewed by Timothy.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6835
          REGRESSION: WebKit crashes when loading a script on Wikipedia

        Test added:
        editing/deleting/delete-listitem-001.html

        * rendering/render_list.cpp:
        (RenderListItem::setStyle):
        (RenderListItem::resetMarkerValue):
        (RenderListItem::getAbsoluteRepaintRect):
        (RenderListMarker::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Fix by Mitz Pettel, reviewed by Darin, landed by ap.
ap [Thu, 26 Jan 2006 12:06:08 +0000 (12:06 +0000)]
    Fix by Mitz Pettel, reviewed by Darin, landed by ap.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6388
          REGRESSION: Incomplete repaint when dragging the map on Google maps

        * manual-tests/bugzilla-6388.html: Added.
        * rendering/render_layer.cpp:
        (WebCore::RenderLayer::computeRepaintRects): Cache the object's absolute position
        before update.
        (WebCore::RenderLayer::updateLayerPositions): Use the cached position to determine if
        the object moved. If it did, do a full repaint.
        * rendering/render_layer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-01-26 Eric Seidel <eseidel@apple.com>
eseidel [Thu, 26 Jan 2006 11:32:42 +0000 (11:32 +0000)]
2006-01-26  Eric Seidel  <eseidel@apple.com>

        Adding additional test case from:
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6801

        * svg/custom/percentage-rect2-expected.checksum: Added.
        * svg/custom/percentage-rect2-expected.png: Added.
        * svg/custom/percentage-rect2-expected.txt: Added.
        * svg/custom/percentage-rect2.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-01-26 Eric Seidel <eseidel@apple.com>
eseidel [Thu, 26 Jan 2006 11:11:25 +0000 (11:11 +0000)]
2006-01-26  Eric Seidel  <eseidel@apple.com>

        Adding additional test case from:
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6801

        * svg/custom/percentage-rect2-expected.checksum: Added.
        * svg/custom/percentage-rect2-expected.png: Added.
        * svg/custom/percentage-rect2-expected.txt: Added.
        * svg/custom/percentage-rect2.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Fix by Mitz Pettel, reviewed by Darin, committed by ap.
ap [Thu, 26 Jan 2006 10:57:58 +0000 (10:57 +0000)]
    Fix by Mitz Pettel, reviewed by Darin, committed by ap.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6278
          REGRESSION: Incomplete repaint when table cell width changes during layout

        * manual-tests/bugzilla-6278.html: Added.
        * rendering/RenderTableSection.cpp:
        (WebCore::RenderTableSection::setCellWidths): If during layout a cell changes from
        not needing layout to needing layout, call repaintObjectsBeforeLayout on it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-01-26 Eric Seidel <eseidel@apple.com>
eseidel [Thu, 26 Jan 2006 10:53:01 +0000 (10:53 +0000)]
2006-01-26  Eric Seidel  <eseidel@apple.com>

        Reviewed by mjs.

        SVG shows up blank in WebKit+SVG
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6620

        * css/svg.css: default to width/height 100% for <svg>

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoForce this to be re-generated
andersca [Thu, 26 Jan 2006 09:53:41 +0000 (09:53 +0000)]
Force this to be re-generated

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-01-26 Anders Carlsson <andersca@mac.com>
andersca [Thu, 26 Jan 2006 09:43:42 +0000 (09:43 +0000)]
2006-01-26  Anders Carlsson  <andersca@mac.com>

        Reviewed by Darin.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=6805
        Support constants in IDL files

        * bindings/scripts/CodeGeneratorJS.pm:
        If an interface has constants, generate a constructor
        object and add the constants as properties. Also add a
        getConstructor method to the interface object.

        * bindings/scripts/CodeGenerator.pm:
        * bindings/scripts/generate-bindings.pl:
        Add a --force-generation flag to force regeneration of files
        even though nothing has changed.

        * khtml/ecma/kjs_events.cpp:
        * khtml/ecma/kjs_events.h:
        Remove MutationEventConstructor and DOMMutationEvent,
        those are autogenerated now.

        * bindings/js/JSEvents.cpp:
        Include JSMutationEvent.cpp

        * khtml/ecma/kjs_window.cpp:
        (KJS::Window::getValueProperty):
        * khtml/ecma/kjs_window.h:
        (KJS::Window::):
        Add MutationEvent property.

        * khtml/xml/MutationEvent.idl: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-01-25 Alexander Kellett <lypanov@kde.org>
eseidel [Thu, 26 Jan 2006 09:32:56 +0000 (09:32 +0000)]
2006-01-25  Alexander Kellett  <lypanov@kde.org>

        Reviewed by eseidel.

        Percentage values for width, height are not rendered correctly.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=5331

        Create items for even empty paths to prevent an empty render tree.
        Calculate the viewport element on the fly rather than caching it,
        unless there is no context from which to calculate it. Call
        notifyAttributeChange() on layout to fix usage of viewport
        percentages for lengths. Remove portion of code which appears to
        do nothing but worsen the situation.

        * kcanvas/device/quartz/KCanvasItemQuartz.h:
        * kcanvas/device/quartz/KCanvasItemQuartz.mm:
        (KCanvasItemQuartz::layout):
        * ksvg2/svg/SVGLengthImpl.cpp:
        (SVGLengthImpl::value):
        * ksvg2/svg/SVGStyledElementImpl.cpp:
        (SVGStyledElementImpl::createRenderer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-01-26 Eric Seidel <eseidel@apple.com>
eseidel [Thu, 26 Jan 2006 09:23:28 +0000 (09:23 +0000)]
2006-01-26  Eric Seidel  <eseidel@apple.com>

        Reviewed by hyatt.

        Disable <animateTransform> to stop layout test crashes.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6780

        * ksvg2/misc/KSVGTimeScheduler.cpp: hack out animateTransform.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-01-26 Eric Seidel <eseidel@apple.com>
eseidel [Thu, 26 Jan 2006 08:37:56 +0000 (08:37 +0000)]
2006-01-26  Eric Seidel  <eseidel@apple.com>

        Reviewed by mjs.

        Deploy RefPtr throughout more of WebCore
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6754

        * bridge/mac/MacFrame.mm:
        (MacFrame::shouldClose): no need to call .get()
        * khtml/html/HTMLElementImpl.cpp:
        (WebCore::HTMLElementImpl::createContextualFragment):
        * khtml/html/HTMLSelectElementImpl.cpp:
        (WebCore::HTMLSelectElementImpl::remove):
        * khtml/html/HTMLTextAreaElementImpl.cpp:
        (WebCore::HTMLTextAreaElementImpl::setDefaultValue):
        * khtml/html/html_baseimpl.cpp:
        (WebCore::HTMLBodyElementImpl::HTMLBodyElementImpl):
        (WebCore::HTMLBodyElementImpl::~HTMLBodyElementImpl):
        (WebCore::HTMLBodyElementImpl::createLinkDecl):
        (WebCore::HTMLBodyElementImpl::parseMappedAttribute):
        * khtml/html/html_baseimpl.h:
        * khtml/html/html_headimpl.cpp:
        (WebCore::HTMLLinkElementImpl::HTMLLinkElementImpl):
        (WebCore::HTMLLinkElementImpl::~HTMLLinkElementImpl):
        (WebCore::HTMLLinkElementImpl::process):
        (WebCore::HTMLLinkElementImpl::setStyleSheet):
        (WebCore::HTMLLinkElementImpl::isLoading):
        (WebCore::HTMLStyleElementImpl::HTMLStyleElementImpl):
        (WebCore::HTMLStyleElementImpl::childrenChanged):
        (WebCore::HTMLStyleElementImpl::isLoading):
        * khtml/html/html_headimpl.h:
        (DOM::HTMLLinkElementImpl::sheet):
        (DOM::HTMLStyleElementImpl::sheet):
        * khtml/html/html_tableimpl.cpp:
        (WebCore::HTMLTableElementImpl::parseMappedAttribute):
        (WebCore::HTMLTableSectionElementImpl::insertRow):
        (WebCore::HTMLTableSectionElementImpl::deleteRow):
        (WebCore::HTMLTableRowElementImpl::deleteCell):
        * khtml/xml/NodeImpl.cpp:
        (WebCore::NodeImpl::dispatchEvent):
        (WebCore::NodeImpl::dispatchGenericEvent):
        (WebCore::NodeImpl::dispatchWindowEvent):
        (WebCore::NodeImpl::dispatchMouseEvent):
        (WebCore::NodeImpl::dispatchKeyEvent):
        (WebCore::NodeImpl::createRendererIfNeeded):
        * khtml/xml/NodeImpl.h:
        * khtml/xml/dom_elementimpl.cpp:
        (WebCore::MappedAttributeImpl::clone):
        (WebCore::StyledElementImpl::StyledElementImpl):
        (WebCore::StyledElementImpl::createInlineStyleDecl):
        (WebCore::StyledElementImpl::destroyInlineStyleDecl):
        (WebCore::StyledElementImpl::getInlineStyleDecl):
        * khtml/xml/dom_elementimpl.h:
        (DOM::MappedAttributeImpl::MappedAttributeImpl):
        (DOM::MappedAttributeImpl::style):
        (DOM::MappedAttributeImpl::decl):
        (DOM::MappedAttributeImpl::setDecl):
        (DOM::StyledElementImpl::inlineStyleDecl):
        * khtml/xml/dom_position.cpp:
        (DOM::Position::Position):
        (DOM::Position::clear):
        * khtml/xml/dom_position.h:
        (DOM::Position::node):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Dave Hyatt.
mjs [Thu, 26 Jan 2006 07:10:17 +0000 (07:10 +0000)]
    Reviewed by Dave Hyatt.

        - garbage collect a bit later when destroying Frame (fixes node leak false positives)
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6818

        * khtml/ecma/kjs_proxy.cpp:
        (WebCore::KJSProxyImpl::~KJSProxyImpl): Garbage collect after destroying
        the script interpreter.
        * page/Frame.cpp:
        (Frame::clear): Add a boolean parameter to indicate whether properties
        of the window object should also be cleared (defaults to true).
        (Frame::~Frame): Call clear(false) instead of clear()
        * page/Frame.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin.
mjs [Thu, 26 Jan 2006 04:44:37 +0000 (04:44 +0000)]
    Reviewed by Darin.

        - Turn on NodeImpl leak counter for debug builds
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6808

        * khtml/xml/NodeImpl.cpp:
        (WebCore::NodeImplCounter::~NodeImplCounter): Uncomment node
        counter now tit won't give a lot of false positives.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Dave Hyatt.
mjs [Thu, 26 Jan 2006 04:40:01 +0000 (04:40 +0000)]
    Reviewed by Dave Hyatt.

        - fixed "Whole DOM tree can leak if Document is hover/active/focus node on quit"
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6809

        This fixes 175 reproducible node leaks in the editing layout tests.

        * khtml/xml/DocumentImpl.cpp:
        (WebCore::DocumentImpl::detach): Clear hover, focus and active nodes. It doesn't
        make sense to have these without a view anyway, and if any of them is the document
        it can cause a leak of the whole DOM.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Maciej.
adele [Thu, 26 Jan 2006 04:36:15 +0000 (04:36 +0000)]
    Reviewed by Maciej.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=6816
        Crash in dispatchMouseEvent - Missing nil check

        * page/FrameView.cpp: (FrameView::dispatchMouseEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by harrison
justing [Thu, 26 Jan 2006 02:39:22 +0000 (02:39 +0000)]
    Reviewed by harrison

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=6644>
        TinyMCE: Undo operation crashes Safari
        <rdar://problem/4343068>
        Some shouldChangeSelection calls are nonsensical

        Selections are blown away if their endpoints are removed from the document.
        This changed the selections that editing delegates see during deletion/replacement.

        * editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
        * editing/deleting/delete-3608430-fix-expected.txt:
        * editing/deleting/delete-3608462-fix-expected.txt:
        * editing/deleting/delete-3775172-fix-expected.txt:
        * editing/deleting/delete-3800834-fix-expected.txt:
        * editing/deleting/delete-3857753-fix-expected.txt:
        * editing/deleting/delete-3865854-fix-expected.txt:
        * editing/deleting/delete-3928305-fix-expected.txt:
        * editing/deleting/delete-3959464-fix-expected.txt:
        * editing/deleting/delete-4038408-fix-expected.txt:
        * editing/deleting/delete-at-paragraph-boundaries-001-expected.txt:
        * editing/deleting/delete-at-paragraph-boundaries-002-expected.txt:
        * editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
        * editing/deleting/delete-at-paragraph-boundaries-004-expected.txt:
        * editing/deleting/delete-at-paragraph-boundaries-005-expected.txt:
        * editing/deleting/delete-at-paragraph-boundaries-006-expected.txt:
        * editing/deleting/delete-at-paragraph-boundaries-007-expected.txt:
        * editing/deleting/delete-at-paragraph-boundaries-009-expected.txt:
        * editing/deleting/delete-at-paragraph-boundaries-010-expected.txt:
        * editing/deleting/delete-at-paragraph-boundaries-011-expected.txt:
        * editing/deleting/delete-block-contents-001-expected.txt:
        * editing/deleting/delete-block-contents-002-expected.txt:
        * editing/deleting/delete-block-contents-003-expected.txt:
        * editing/deleting/delete-block-merge-contents-001-expected.txt:
        * editing/deleting/delete-block-merge-contents-002-expected.txt:
        * editing/deleting/delete-block-merge-contents-003-expected.txt:
        * editing/deleting/delete-block-merge-contents-004-expected.txt:
        * editing/deleting/delete-block-merge-contents-005-expected.txt:
        * editing/deleting/delete-block-merge-contents-006-expected.txt:
        * editing/deleting/delete-block-merge-contents-007-expected.txt:
        * editing/deleting/delete-block-merge-contents-008-expected.txt:
        * editing/deleting/delete-block-merge-contents-009-expected.txt:
        * editing/deleting/delete-block-merge-contents-010-expected.txt:
        * editing/deleting/delete-block-merge-contents-012-expected.txt:
        * editing/deleting/delete-block-merge-contents-013-expected.txt:
        * editing/deleting/delete-block-merge-contents-014-expected.txt:
        * editing/deleting/delete-block-merge-contents-015-expected.txt:
        * editing/deleting/delete-block-merge-contents-016-expected.txt:
        * editing/deleting/delete-block-merge-contents-017-expected.txt:
        * editing/deleting/delete-block-merge-contents-018-expected.txt:
        * editing/deleting/delete-block-merge-contents-019-expected.txt:
        * editing/deleting/delete-block-merge-contents-020-expected.txt:
        * editing/deleting/delete-block-merge-contents-021-expected.txt:
        * editing/deleting/delete-br-008-expected.txt:
        * editing/deleting/delete-br-010-expected.txt:
        * editing/deleting/delete-image-001-expected.txt:
        * editing/deleting/delete-image-002-expected.txt:
        * editing/deleting/delete-image-003-expected.txt:
        * editing/deleting/delete-image-004-expected.txt:
        * editing/deleting/delete-line-001-expected.txt:
        * editing/deleting/delete-line-002-expected.txt:
        * editing/deleting/delete-line-003-expected.txt:
        * editing/deleting/delete-line-004-expected.txt:
        * editing/deleting/delete-line-005-expected.txt:
        * editing/deleting/delete-line-006-expected.txt:
        * editing/deleting/delete-line-007-expected.txt:
        * editing/deleting/delete-line-008-expected.txt:
        * editing/deleting/delete-line-009-expected.txt:
        * editing/deleting/delete-line-010-expected.txt:
        * editing/deleting/delete-line-011-expected.txt:
        * editing/deleting/delete-line-012-expected.txt:
        * editing/deleting/delete-line-013-expected.txt:
        * editing/deleting/delete-line-014-expected.txt:
        * editing/deleting/delete-line-015-expected.txt:
        * editing/deleting/delete-line-016-expected.txt:
        * editing/deleting/delete-line-017-expected.txt:
        * editing/deleting/delete-select-all-001-expected.txt:
        * editing/deleting/delete-select-all-002-expected.txt:
        * editing/deleting/delete-select-all-003-expected.txt:
        * editing/execCommand/boldSelection-expected.txt:
        * editing/execCommand/strikethroughSelection-expected.txt:
        * editing/input/attributed-substring-from-range-lines-expected.txt:
        * editing/input/text-input-controller-expected.txt:
        * editing/inserting/insert-3654864-fix-expected.txt:
        * editing/inserting/insert-3659587-fix-expected.txt:
        * editing/inserting/insert-3775316-fix-expected.txt:
        * editing/inserting/insert-3851164-fix-expected.txt:
        * editing/inserting/insert-3907422-fix-expected.txt:
        * editing/inserting/insert-after-delete-001-expected.txt:
        * editing/inserting/insert-div-001-expected.txt:
        * editing/inserting/insert-div-002-expected.txt:
        * editing/inserting/insert-div-003-expected.txt:
        * editing/inserting/insert-div-005-expected.txt:
        * editing/inserting/insert-div-007-expected.txt:
        * editing/inserting/insert-div-009-expected.txt:
        * editing/inserting/insert-div-010-expected.txt:
        * editing/inserting/insert-div-020-expected.txt:
        * editing/inserting/insert-div-023-expected.txt:
        * editing/inserting/insert-div-024-expected.txt:
        * editing/inserting/insert-div-025-expected.txt:
        * editing/inserting/insert-div-026-expected.txt:
        * editing/inserting/return-key-with-selection-001-expected.txt:
        * editing/inserting/return-key-with-selection-002-expected.txt:
        * editing/inserting/return-key-with-selection-003-expected.txt:
        * editing/pasteboard/3976872-expected.txt:
        * editing/pasteboard/4076267-3-expected.txt:
        * editing/pasteboard/4076267-expected.txt:
        * editing/pasteboard/block-wrappers-necessary-expected.txt:
        * editing/pasteboard/paste-4035648-fix-expected.txt:
        * editing/pasteboard/paste-4039777-fix-expected.txt:
        * editing/pasteboard/paste-line-endings-001-expected.txt:
        * editing/pasteboard/paste-line-endings-006-expected.txt:
        * editing/pasteboard/paste-line-endings-007-expected.txt:
        * editing/pasteboard/paste-line-endings-008-expected.txt:
        * editing/pasteboard/paste-line-endings-009-expected.txt:
        * editing/pasteboard/paste-line-endings-010-expected.txt:
        * editing/pasteboard/paste-match-style-001-expected.txt:
        * editing/pasteboard/paste-match-style-002-expected.txt:
        * editing/pasteboard/paste-pre-001-expected.txt:
        * editing/pasteboard/paste-pre-002-expected.txt:
        * editing/pasteboard/paste-text-002-expected.txt:
        * editing/pasteboard/paste-text-003-expected.txt:
        * editing/pasteboard/paste-text-006-expected.txt:
        * editing/pasteboard/paste-text-007-expected.txt:
        * editing/pasteboard/paste-text-008-expected.txt:
        * editing/pasteboard/paste-text-009-expected.txt:
        * editing/pasteboard/paste-text-011-expected.txt:
        * editing/pasteboard/paste-text-015-expected.txt:
        * editing/pasteboard/paste-text-016-expected.txt:
        * editing/pasteboard/paste-text-017-expected.txt:
        * editing/pasteboard/paste-text-018-expected.txt:
        * editing/pasteboard/smart-paste-006-expected.txt:
        * editing/pasteboard/smart-paste-007-expected.txt:
        * editing/selection/node-removal-1-expected.checksum: Added.
        * editing/selection/node-removal-1-expected.png: Added.
        * editing/selection/node-removal-1-expected.txt: Added.
        * editing/selection/node-removal-1.html: Added.
        * editing/selection/node-removal-2-expected.checksum: Added.
        * editing/selection/node-removal-2-expected.png: Added.
        * editing/selection/node-removal-2-expected.txt: Added.
        * editing/selection/node-removal-2.html: Added.
        * editing/style/block-style-004-expected.txt:
        * editing/style/block-style-005-expected.txt:
        * editing/style/block-style-006-expected.txt:
        * editing/style/create-block-for-style-001-expected.txt:
        * editing/style/create-block-for-style-002-expected.txt:
        * editing/style/create-block-for-style-003-expected.txt:
        * editing/style/create-block-for-style-004-expected.txt:
        * editing/style/create-block-for-style-007-expected.txt:
        * editing/style/create-block-for-style-009-expected.txt:
        * editing/style/create-block-for-style-010-expected.txt:
        * editing/style/create-block-for-style-011-expected.txt:
        * editing/style/create-block-for-style-012-expected.txt:
        * editing/style/create-block-for-style-013-expected.txt:
        * editing/style/relative-font-size-change-001-expected.txt:
        * editing/style/relative-font-size-change-002-expected.txt:
        * editing/style/remove-underline-across-paragraph-expected.txt:
        * editing/style/remove-underline-across-paragraph-in-bold-expected.txt:
        * editing/style/remove-underline-after-paragraph-expected.txt:
        * editing/style/remove-underline-after-paragraph-in-bold-expected.txt:
        * editing/style/remove-underline-from-stylesheet-expected.txt:
        * editing/style/smoosh-styles-001-expected.txt:
        * editing/style/smoosh-styles-002-expected.txt:
        * editing/style/smoosh-styles-003-expected.txt:
        * editing/style/style-3681552-fix-001-expected.txt:
        * editing/style/style-3681552-fix-002-expected.txt:
        * editing/style/style-3690704-fix-expected.txt:
        * editing/style/style-3998892-fix-expected.txt:
        * editing/style/style-boundary-001-expected.txt:
        * editing/style/style-boundary-003-expected.txt:
        * editing/style/style-boundary-004-expected.txt:
        * editing/style/typing-style-001-expected.txt:
        * editing/style/typing-style-003-expected.txt:
        * editing/unsupported-content/list-delete-001-expected.txt:
        * editing/unsupported-content/list-delete-002-expected.txt:
        * editing/unsupported-content/list-delete-003-expected.txt:
        * editing/unsupported-content/table-delete-001-expected.txt:
        * editing/unsupported-content/table-delete-002-expected.txt:
        * editing/unsupported-content/table-delete-003-expected.txt:
        * fast/events/updateLayoutForHitTest-expected.txt:
        * fast/forms/attributed-strings-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by mjs
justing [Thu, 26 Jan 2006 02:36:47 +0000 (02:36 +0000)]
    Reviewed by mjs

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=6644>
        TinyMCE: Undo operation crashes Safari
        <rdar://problem/4343068>
        Some shouldChangeSelection calls are nonsensical

        Notify the SelectionController of node removals,
        and blow away the selection when end points are removed.

        Tests added:
        * editing/selection/remove-node-1.html
        * editing/selection/remove-node-2.html

        * khtml/editing/SelectionController.cpp:
        (WebCore::MutationListener::handleEvent):
        (WebCore::SelectionController::SelectionController):
        (WebCore::SelectionController::~SelectionController):
        (WebCore::SelectionController::operator=):
        (WebCore::SelectionController::moveTo):
        (WebCore::SelectionController::setSelection):
        (WebCore::SelectionController::nodeWillBeRemoved):
        (WebCore::SelectionController::clear):
        (WebCore::SelectionController::setBase):
        (WebCore::SelectionController::setExtent):
        * khtml/editing/SelectionController.h:
        (WebCore::MutationListener::MutationListener):
        (WebCore::MutationListener::selectionController):
        (WebCore::MutationListener::setSelectionController):
        * rendering/RenderContainer.cpp:
        (WebCore::RenderContainer::removeChildNode):
        * rendering/render_flow.cpp:
        (RenderFlow::destroy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoBuild fix for i386.
thatcher [Thu, 26 Jan 2006 02:30:26 +0000 (02:30 +0000)]
Build fix for i386.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
adele [Thu, 26 Jan 2006 02:09:56 +0000 (02:09 +0000)]
LayoutTests:

        Updating test results for aqua text fields.

        * fast/forms/input-appearance-focus-expected.checksum:
        * fast/forms/input-appearance-focus-expected.png:
        * fast/forms/input-appearance-focus-expected.txt:

WebCore:

        Reviewed by Hyatt.

        This change lets us display an aqua appearance for the new text fields.

        Updated results for:
        * fast/forms/input-appearance-focus.html

        * rendering/RenderTextField.cpp: (WebCore::RenderTextField::createDivStyle):
          remove styling of the div, since RenderTheme handles that now.
        * rendering/render_theme.cpp:
        (khtml::RenderTheme::adjustStyle): call adjustTextFieldStyle.
        (khtml::RenderTheme::paint): call paintTextField.
        (khtml::RenderTheme::adjustTextFieldStyle): added FIXME to turn off appearance later.
        * rendering/render_theme.h: added adjustTextFieldStyle, paintTextField
        * rendering/render_theme_mac.h: added paintTextField, setTextFieldState, and NSTextFieldCell.
        * rendering/render_theme_mac.mm:
        (khtml::): Added static textFieldMargins.
        (khtml::RenderThemeMac::adjustRepaintRect): update text field state and size.
        (khtml::RenderThemeMac::paintTextField): Added. Paints the NSTextFieldCell
        (khtml::RenderThemeMac::setTextFieldCellState): Initialize NSTextFieldCell, and update enabled state.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLand project change so Brush is in the Win32 project.
hyatt [Thu, 26 Jan 2006 01:56:49 +0000 (01:56 +0000)]
Land project change so Brush is in the Win32 project.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Rename QBrush to Brush and move it to platform/. Remove unused QPoint/Size...
hyatt [Thu, 26 Jan 2006 01:52:44 +0000 (01:52 +0000)]
    Rename QBrush to Brush and move it to platform/.  Remove unused QPoint/Size/RectF forwarding
        headers.

        * ForwardingHeaders/QPointF: Removed.
        * ForwardingHeaders/QRectF: Removed.
        * ForwardingHeaders/QSizeF: Removed.
        * WebCore.xcodeproj/project.pbxproj:
        * khtml/editing/SelectionController.cpp:
        (WebCore::SelectionController::paintCaret):
        * kwq/KWQBrush.h: Removed.
        * kwq/KWQNamespace.h:
        * kwq/KWQObject.h:
        * kwq/KWQPainter.h:
        * kwq/KWQPainter.mm:
        (QPainter::setBrush):
        (QPainter::brush):
        (QPainter::drawRect):
        (QPainter::drawEllipse):
        (QPainter::drawConvexPolygon):
        (QPainter::fillRect):
        * kwq/KWQPalette.h:
        (QColorGroup::brush):
        * platform/Brush.h: Added.
        (WebCore::Brush::):
        (WebCore::Brush::Brush::Brush):
        (WebCore::Brush::operator==):
        (WebCore::Brush::operator!=):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::fillHorizontalSelectionGap):
        (WebCore::RenderBlock::fillVerticalSelectionGap):
        (WebCore::RenderBlock::fillLeftSelectionGap):
        (WebCore::RenderBlock::fillRightSelectionGap):
        * rendering/render_box.cpp:
        (WebCore::RenderBox::outlineBox):
        * rendering/render_canvasimage.cpp:
        (WebCore::RenderCanvasImage::paint):
        * rendering/render_image.cpp:
        (WebCore::RenderImage::paint):
        * rendering/render_list.cpp:
        (RenderListMarker::paint):
        * rendering/render_replaced.cpp:
        (WebCore::RenderWidget::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Justin.
harrison [Thu, 26 Jan 2006 01:14:31 +0000 (01:14 +0000)]
    Reviewed by Justin.

        Updated pixel tests for my recent checkin.

        * editing/pasteboard/paste-list-001-expected.png:
        * editing/selection/3690703-2-expected.png:
        * editing/selection/3690703-expected.png:
        * editing/selection/3690719-expected.png:
        * editing/unsupported-content/list-type-after-expected.png:
        * editing/unsupported-content/list-type-before-expected.png:
        * editing/unsupported-content/table-type-after-expected.png:
        * editing/unsupported-content/table-type-before-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Beth Dakin.
vicki [Thu, 26 Jan 2006 01:13:15 +0000 (01:13 +0000)]
    Reviewed by Beth Dakin.

- fix <rdar://problem/4351664> REGRESSION (420+): extra URL in b/f list - navigating back to
previous page fails at apple.com/retail/)

        * WebView.subproj/WebFrame.m:
        (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): grab the
redirect flag of the current load before calling _loadURL, which clears this flag,
        (-[WebFrame _transitionToCommitted:]): remove misleading comment
        * History.subproj/WebHistoryItem.m:
        (-[WebHistoryItem setURL:]): release resources in the page cache when setting
        the URL on a WebHistoryItem

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-01-25 Anders Carlsson <andersca@mac.com>
andersca [Thu, 26 Jan 2006 00:54:21 +0000 (00:54 +0000)]
2006-01-25  Anders Carlsson  <andersca@mac.com>

        Reviewed by Timothy Hatcher.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=6807
        generate-bindings.pl should not use find command

        * bindings/scripts/generate-bindings.pl:
        Use opendir and readdir instead of find.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoFix Win32 build bustage. Make the autogeneration from idl work on windows.
hyatt [Thu, 26 Jan 2006 00:21:45 +0000 (00:21 +0000)]
Fix Win32 build bustage. Make the autogeneration from idl work on windows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Rename QPen to Pen and move it to the platform/ directory.
hyatt [Wed, 25 Jan 2006 23:44:12 +0000 (23:44 +0000)]
    Rename QPen to Pen and move it to the platform/ directory.

        * ForwardingHeaders/qpen.h: Removed.
        * WebCore.xcodeproj/project.pbxproj:
        * kwq/KWQNamespace.h:
        (Qt::):
        * kwq/KWQPainter.h:
        * kwq/KWQPainter.mm:
        (QPainter::pen):
        (QPainter::setPen):
        (QPainter::drawRect):
        (QPainter::drawLine):
        (QPainter::drawEllipse):
        (QPainter::drawArc):
        (QPainter::drawConvexPolygon):
        * kwq/KWQPen.cpp: Removed.
        * kwq/KWQPen.h: Removed.
        * platform/Pen.cpp: Added.
        (WebCore::Pen::Pen):
        (WebCore::Pen::color):
        (WebCore::Pen::width):
        (WebCore::Pen::style):
        (WebCore::Pen::setColor):
        (WebCore::Pen::setWidth):
        (WebCore::Pen::setStyle):
        (WebCore::Pen::operator==):
        (WebCore::Pen::operator!=):
        * platform/Pen.h: Added.
        (WebCore::Pen::):
        * rendering/InlineTextBox.cpp:
        (khtml::InlineTextBox::paintMarkedTextUnderline):
        * rendering/RenderTableCell.cpp:
        (WebCore::outlineBox):
        * rendering/RenderText.cpp:
        * rendering/render_box.cpp:
        (WebCore::RenderBox::outlineBox):
        * rendering/render_frames.cpp:
        (WebCore::RenderFrameSet::userResize):
        * rendering/render_image.cpp:
        * rendering/render_line.cpp:
        * rendering/render_list.cpp:
        * rendering/render_object.cpp:
        (WebCore::RenderObject::drawBorder):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoReviewed by Darin.
staikos [Wed, 25 Jan 2006 23:04:35 +0000 (23:04 +0000)]
Reviewed by Darin.

  Merge fix cast fix from KDE (reinterpret_cast can't change size)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoWebCore:
thatcher [Wed, 25 Jan 2006 22:16:25 +0000 (22:16 +0000)]
WebCore:

        Move off of -[NSFont widthOfString:] since it is now deprecated.
        Use the NSStringDrawing -[NSString sizeWithAttributes:] API.

        * bridge/mac/MacFrame.mm:
        (MacFrame::attributedString):
        * kwq/KWQTextArea.mm:
        (-[KWQTextAreaTextView sizeWithColumns:rows:]):

WebKit:

        Move off of -[NSFont widthOfString:] since it is now deprecated.
        Use the NSStringDrawing -[NSString sizeWithAttributes:] API.

        * WebCoreSupport.subproj/WebFileButton.m:
        (-[WebFileChooserButton bestVisualFrameSizeForCharacterCount:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Dave Harrison.
tomernic [Wed, 25 Jan 2006 22:05:33 +0000 (22:05 +0000)]
    Reviewed by Dave Harrison.

        <rdar://problem/4339024>
        <http://bugzilla.opendarwin.org/show_bug.cgi?id=6785> "Fix for possible leak of applet, object, or embed
        (and plugin view)"

        * khtml/html/html_objectimpl.cpp:
        (WebCore::HTMLAppletElementImpl::~HTMLAppletElementImpl):
        Assert that appletInstance has been deleted by detach().
        (WebCore::HTMLAppletElementImpl::detach):
        Delete appletInstance, because it references the widget owned by the renderer we're about to destroy.
        It is assumed elsewhere (getRuntimeObject(), kjs_dom.cpp) that the instance is owned by the applet
        element.  Therefore, it is required that the element destroy the instance in its tear-down phase.
        (WebCore::HTMLEmbedElementImpl::~HTMLEmbedElementImpl):
        Assert that embedInstance has been deleted by detach().
        (WebCore::HTMLEmbedElementImpl::detach):
        Delete embedInstance, same reason.  This is the one that fixes <rdar://problem/4339024>.
        (WebCore::HTMLObjectElementImpl::~HTMLObjectElementImpl):
        Assert that objectInstance has been deleted by detach().
        (WebCore::HTMLObjectElementImpl::detach):
        Delete embedInstance, same reason.
        * khtml/html/html_objectimpl.h:
        Declared HTMLAppletElementImpl::detach() and HTMLEmbedElementImpl::detach().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoForgot to add this
andersca [Wed, 25 Jan 2006 22:04:29 +0000 (22:04 +0000)]
Forgot to add this

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-01-24 Anders Carlsson <andersca@mac.com>
andersca [Wed, 25 Jan 2006 21:57:47 +0000 (21:57 +0000)]
2006-01-24  Anders Carlsson  <andersca@mac.com>

        Reviewed by Darin.

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=5975
        WebCore needs to use KDOM-like DOM binding autogeneration

        This is a first cut at an autogeneration framework based on
        what KDOM uses, but with some changes to be able to move
        gradually to using autogenerated files. Currently only Javascript
        is supported, but ObjC support could be added by writing a new code
        generator package.

        * WebCore.xcodeproj/project.pbxproj:
        Call generate-bindings.pl

        * bindings/js/JSEvents.cpp: Added.
        New file which #includes all generated files in the event module
        (Just JSWheelEvent.cpp for now)

        * khtml/xml/WheelEvent.idl: Added.

        * bindings/scripts: Added.
        * bindings/scripts/CodeGenerator.pm: Added.
        * bindings/scripts/CodeGeneratorJS.pm: Added.
        * bindings/scripts/IDLParser.pm: Added.
        * bindings/scripts/IDLStructure.pm: Added.
        * bindings/scripts/generate-bindings.pl: Added.

        * khtml/ecma/kjs_events.cpp:
        Remove DOMWheelEvent class.

        (KJS::getDOMEvent):
        Use JSWheelEvent here.

        * khtml/ecma/kjs_events.h:
        Remove DOMWheelEvent class.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Updated for fixes of:
harrison [Wed, 25 Jan 2006 21:11:04 +0000 (21:11 +0000)]
    Updated for fixes of:

        <rdar://problem/3907635> copy/paste of list item text moves list item up one <LI>
        <rdar://problem/3907647> Enhance list editing: return inserts <li></li>
        <rdar://problem/4060158> deleting selection within table deletes more than intended
        <rdar://problem/4061232> Deleting a list can delete unselected content
        <rdar://problem/4062212> after pasting in contents of web.apple.com, typing before start adds to table instead of before table
        <rdar://problem/4064437> After copy/paste from bugweb cannot go back to entering text at left side of page
        <rdar://problem/4259845> Table editing in design mode is broken
        <rdar://problem/4287667> Insertion point goes before table instead of inside first cell
        <rdar://problem/4345749> Editing HTML - Enter at end of <LI> inserts uneditable blank <LI>
        <rdar://problem/4345794> HTML editing: Enter at end of last <LI> does not add new <LI>
        <rdar://problem/4345825> HTML Editing: editing first <LI> element removes first <LI> and more
        <rdar://problem/4345835> HTML editing: editing last <LI> removes everything within <BODY>
        <rdar://problem/4345879> HTML editing: editing first <TD> moves data out of table

        * editing/deleting/delete-4083333-fix-expected.txt:
        * editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
        * editing/deleting/delete-at-paragraph-boundaries-006-expected.txt:
        * editing/deleting/delete-at-paragraph-boundaries-011-expected.txt:
        * editing/deleting/delete-image-004-expected.txt:
        * editing/deleting/delete-line-015-expected.txt:
        * editing/deleting/delete-select-all-001-expected.txt:
        * editing/pasteboard/paste-list-001-expected.txt:
        * editing/pasteboard/paste-table-001-expected.txt:
        * editing/pasteboard/paste-table-001.html:
        * editing/selection/3690703-2-expected.txt:
        * editing/selection/3690703-2.html:
        * editing/selection/3690703-expected.txt:
        * editing/selection/3690719-expected.txt:
        * editing/selection/move-by-line-001-expected.txt:
        * editing/selection/move-by-line-001.html:
        * editing/selection/replaced-boundaries-3-expected.txt:
        * editing/unsupported-content/list-type-after-expected.txt:
        * editing/unsupported-content/list-type-after.html:
        * editing/unsupported-content/list-type-before-expected.txt:
        * editing/unsupported-content/list-type-before.html:
        * editing/unsupported-content/table-delete-001-expected.txt:
        * editing/unsupported-content/table-delete-001.html:
        * editing/unsupported-content/table-delete-002-expected.txt:
        * editing/unsupported-content/table-delete-002.html:
        * editing/unsupported-content/table-type-after-expected.txt:
        * editing/unsupported-content/table-type-after.html:
        * editing/unsupported-content/table-type-before-expected.txt:
        * editing/unsupported-content/table-type-before.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Justin.
harrison [Wed, 25 Jan 2006 21:05:02 +0000 (21:05 +0000)]
    Reviewed by Justin.

        <rdar://problem/3907635> copy/paste of list item text moves list item up one <LI>
        <rdar://problem/3907647> Enhance list editing: return inserts <li></li>
        <rdar://problem/4060158> deleting selection within table deletes more than intended
        <rdar://problem/4061232> Deleting a list can delete unselected content
        <rdar://problem/4062212> after pasting in contents of web.apple.com, typing before start adds to table instead of before table
        <rdar://problem/4064437> After copy/paste from bugweb cannot go back to entering text at left side of page
        <rdar://problem/4259845> Table editing in design mode is broken
        <rdar://problem/4287667> Insertion point goes before table instead of inside first cell
        <rdar://problem/4345749> Editing HTML - Enter at end of <LI> inserts uneditable blank <LI>
        <rdar://problem/4345794> HTML editing: Enter at end of last <LI> does not add new <LI>
        <rdar://problem/4345825> HTML Editing: editing first <LI> element removes first <LI> and more
        <rdar://problem/4345835> HTML editing: editing last <LI> removes everything within <BODY>
        <rdar://problem/4345879> HTML editing: editing first <TD> moves data out of table

        ...also added showTree() static functions because switch to gcc 4.0 makes calling instance methods unreliable

        - numerous small changes to handle empty list items
        - fix numeric list marker updating when adding/deleting list items
        - start to decompose "special element" handling, replacing it with appropriate handling of the different
          kinds of special elements in various situations, rather than giving a blanket treatment.  I will do more
          of this in subsequent checkins.
        - numerous small editing/selection changes to handle VisiblePosition at table offset childNodeCount()
        - simplify and fix equivalentRangeCompliantPosition, rename it to rangeCompliantEquivalent and make it static
        - some minor reformatting to current standards
        - the comments in the list below are for changes not covered by the above comments

        * khtml/editing/Selection.cpp:
        (WebCore::Selection::toRange):
        (WebCore::Selection::validate):
        * khtml/editing/SelectionController.cpp:
        (WebCore::SelectionController::modifyExtendingLeftBackward):
        - character selection backward from after table selects the table
        (WebCore::showTree):
        * khtml/editing/composite_edit_command.cpp:
        (WebCore::CompositeEditCommand::removeFullySelectedNode):
        - make sure empty cell has some height
        (WebCore::CompositeEditCommand::positionOutsideTabSpan):
        - check for !isTabSpanTextNode() to make calling this function easier
        (WebCore::CompositeEditCommand::addBlockPlaceholderIfNeeded):
        * khtml/editing/delete_selection_command.cpp:
        (WebCore::positionBeforePossibleContainingSpecialElement):
        (WebCore::positionAfterPossibleContainingSpecialElement):
        (WebCore::DeleteSelectionCommand::initializeStartEnd):
        - new.  more consistent handling of special element boundaries.
        (WebCore::DeleteSelectionCommand::initializePositionData):
        (WebCore::DeleteSelectionCommand::handleGeneralDelete):
        - handle childless block (e.g. empty table cell)
        - allow merging across list items
        (WebCore::DeleteSelectionCommand::moveNodesAfterNode):
        - use new isEmpty() method for renderers, to handle empty list items
        * khtml/editing/delete_selection_command.h:
        * khtml/editing/htmlediting.cpp:
        (WebCore::isAtomicNode):
        (WebCore::editingIgnoresContent):
        - new.  smarter check than isReplaced()
        (WebCore::rangeCompliantEquivalent):
        (WebCore::maxDeepOffset):
        (WebCore::isFirstVisiblePositionInSpecialElement):
        (WebCore::positionBeforeContainingSpecialElement):
        (WebCore::isLastVisiblePositionInSpecialElement):
        (WebCore::positionAfterContainingSpecialElement):
        (WebCore::positionOutsideContainingSpecialElement):
        (WebCore::positionBeforeNode):
        (WebCore::positionAfterNode):
        (WebCore::isListElement):
        (WebCore::isTableElement):
        (WebCore::isFirstVisiblePositionAfterTableElement):
        (WebCore::positionBeforePrecedingTableElement):
        (WebCore::positionAvoidingSpecialElementBoundary):
        * khtml/editing/htmlediting.h:
        * khtml/editing/insert_line_break_command.cpp:
        (khtml::InsertLineBreakCommand::doApply):
        * khtml/editing/insert_paragraph_separator_command.cpp:
        (khtml::InsertParagraphSeparatorCommand::doApply):
        * khtml/editing/insert_text_command.cpp:
        (khtml::InsertTextCommand::prepareForTextInsertion):
        (khtml::InsertTextCommand::input):
        * khtml/editing/replace_selection_command.cpp:
        (WebCore::isMailPasteAsQuotationNode):
        (WebCore::ReplacementFragment::countRenderedBlocks):
        (WebCore::ReplaceSelectionCommand::doApply):
        - allow for fact that fragments have no VisiblePositions
        * khtml/editing/visible_position.cpp:
        (khtml::VisiblePosition::isCandidate):
        (khtml::showTree):
        (khtml::makeRange):
        (khtml::setStart):
        (khtml::setEnd):
        * khtml/editing/visible_position.h:
        * khtml/editing/visible_units.cpp:
        (khtml::previousBoundary):
        (khtml::nextBoundary):
        (khtml::startOfLine):
        - allow for fact that renderers for list markers and other generated content
          have no corresponding NodeImpl.
        (khtml::endOfLine):
        - ditto
        (khtml::nextLinePosition):
        (khtml::startOfParagraph):
        (khtml::endOfParagraph):
        * khtml/xml/ContainerNodeImpl.cpp:
        (WebCore::ContainerNodeImpl::getUpperLeftCorner):
        (WebCore::ContainerNodeImpl::childNode):
        * khtml/xml/ContainerNodeImpl.h:
        * khtml/xml/NodeImpl.cpp:
        (WebCore::NodeImpl::childNode):
        (WebCore::NodeImpl::traversePreviousNode):
        (WebCore::NodeImpl::nextEditable):
        (WebCore::showTree):
        * khtml/xml/NodeImpl.h:
        * khtml/xml/dom_position.cpp:
        (DOM::Position::upstream):
        (DOM::Position::downstream):
        (DOM::Position::inRenderedContent):
        (DOM::showTree):
        * khtml/xml/dom_position.h:
        * rendering/render_canvas.cpp:
        (RenderCanvas::selectionRect):
        * rendering/render_list.cpp:
        (RenderListItem::calcListValue):
        (RenderListItem::isEmpty):
        (getParentOfFirstLineBox):
        (RenderListItem::resetMarkerValue):
        (RenderListItem::updateMarkerLocation):
        * rendering/render_list.h:
        (khtml::RenderListMarker::isListMarker):
        * rendering/render_object.cpp:
        (WebCore::RenderObject::nextRenderer):
        (WebCore::RenderObject::previousRenderer):
        (WebCore::showTree):
        * rendering/render_object.h:
        (WebCore::RenderObject::getBaselineOfLastLineBox):
        (WebCore::RenderObject::isEmpty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoMake Color compile on Win32.
hyatt [Wed, 25 Jan 2006 20:14:08 +0000 (20:14 +0000)]
Make Color compile on Win32.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoMake Win32 build again.
hyatt [Wed, 25 Jan 2006 19:58:47 +0000 (19:58 +0000)]
Make Win32 build again.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Build fix, -[NSFont defaultLineHeightForFont] is deprecated.
thatcher [Wed, 25 Jan 2006 19:37:47 +0000 (19:37 +0000)]
    Build fix, -[NSFont defaultLineHeightForFont] is deprecated.
        We need to use -[NSLayoutManager defaultLineHeightForFont:] instead.

        * kwq/KWQLineEdit.mm:
        (QLineEdit::sizeForCharacterWidth):
        (QLineEdit::baselinePosition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoQuick update for Dave, who's working on getting this compiling again.
darin [Wed, 25 Jan 2006 19:33:17 +0000 (19:33 +0000)]
Quick update for Dave, who's working on getting this compiling again.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoFix JavaScriptCore Win32 bustage by #defining copysign to be _copysign.
hyatt [Wed, 25 Jan 2006 19:12:34 +0000 (19:12 +0000)]
Fix JavaScriptCore Win32 bustage by #defining copysign to be _copysign.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago - removed an unused source file
darin [Wed, 25 Jan 2006 18:20:49 +0000 (18:20 +0000)]
    - removed an unused source file

        * kjs/pointer_hash.h: Removed.
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Removed reference to pointer_hash.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin.
ap [Wed, 25 Jan 2006 12:36:48 +0000 (12:36 +0000)]
    Reviewed by Darin.

        Corrected a test case for http://bugzilla.opendarwin.org/show_bug.cgi?id=6385.

        * fast/frames/frame-element-name.html: Fix a reference to the left frame.
        * fast/frames/frame-element-name-expected.txt: Updated results.
        * fast/frames/frame-element-name-expected.png: Updated results.
        * fast/frames/frame-element-name-expected.checksum: Updated results.
        * fast/frames/resources/frame-element-name-left.html: Use escape() on the name.
        * fast/frames/resources/frame-element-name-right.html: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=6731
darin [Wed, 25 Jan 2006 07:42:04 +0000 (07:42 +0000)]
   - test for bugzilla.opendarwin.org/show_bug.cgi?id=6731
         REGRESSION: change event fires at load time for checked items

        * fast/forms/radio-button-no-change-event.html: Added.
        * fast/forms/radio-button-no-change-event-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Adele.
darin [Wed, 25 Jan 2006 07:41:42 +0000 (07:41 +0000)]
    Reviewed by Adele.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6731
          REGRESSION: change event fires at load time for checked items

        Test: fast/forms/radio-button-no-change-event.html

        * khtml/html/HTMLInputElementImpl.cpp: (WebCore::HTMLInputElementImpl::setChecked):
        One of many possible fixes: Don't send the event if the element is not yet in
        a document (as in when parsing the initial attributes).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
adele [Wed, 25 Jan 2006 07:35:27 +0000 (07:35 +0000)]
LayoutTests:

        Test for focus and blur for new text fields.

        * fast/forms/input-appearance-focus.html: Added.
        * fast/forms/input-appearance-focus-expected.txt: Added.
        * fast/forms/input-appearance-focus-expected.png: Added.
        * fast/forms/input-appearance-focus-expected.checksum: Added.

WebCore:

        Reviewed by Hyatt.

        This change will allow the new text field elements to get focus, and to respond to the focus and blur events.

        Added: fast/forms/input-appearance-focus.html

        * khtml/html/HTMLElementImpl.cpp: (WebCore::HTMLElementImpl::isFocusable):
          Removed recently added code that allowed editable elements with no parent to be focusable.
          We don't need to do this now that we try to focus the input element, instead of the inner div.
        * khtml/html/HTMLGenericFormElementImpl.cpp: (WebCore::HTMLGenericFormElementImpl::isMouseFocusable): Added case to for text fields.
        * khtml/html/HTMLInputElementImpl.cpp:
        (WebCore::HTMLInputElementImpl::focus): Added. Selects contents of text field.
        (WebCore::HTMLInputElementImpl::setSelectionStart): Added break; in switch statement.
        (WebCore::HTMLInputElementImpl::setSelectionEnd): ditto.
        (WebCore::HTMLInputElementImpl::select): ditto.
        (WebCore::HTMLInputElementImpl::setSelectionRange): ditto.
        * khtml/html/HTMLInputElementImpl.h: Added focus()
        * khtml/xml/dom_elementimpl.h: Made focus() virtual.
        * page/Frame.cpp: (Frame::setFocusNodeIfNeeded):
          Walk up the Render Tree instead of the DOM tree when trying to find a node to focus.
          This will let us choose the input node instead of one of the nodes in the shadow tree.
        * page/FrameView.cpp: (FrameView::dispatchMouseEvent): ditto.
        * rendering/RenderContainer.cpp: (WebCore::RenderContainer::destroyLeftoverChildren): Corrected misspelling.
        * rendering/RenderTextField.cpp:
        (WebCore::RenderTextField::select): Implemented.  Select contents of inner div.
        * rendering/RenderTextField.h:
        (WebCore::RenderTextField::renderName): Changed order.
        (WebCore::RenderTextField::removeLeftoverAnonymousBoxes): ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12345 268f45cc-cd09-0410-ab3c-d52691b4dbfc