Reviewed by Mark.

        Auto-generate image arrays.

        * libWebKitSystemInterfaceLeopard.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Reviewed by Darin

        <rdar://problem/5771227> - Incorrect password handling text in credential sheet

        * platform/network/ProtectionSpace.cpp:
        (WebCore::ProtectionSpace::receivesCredentialSecurely): Call functional CFNetwork method to
          get "secureness" of the auth challenge instead of figuring it out ourselves

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Rubber-stamped by Sam Weinig.

        - update test results following r30649

        * svg/css/getComputedStyle-basic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-02-29  Brent Fulgham  <bfulgham@gmail.com>
JavaScriptCore:

        http://bugs.webkit.org/show_bug.cgi?id=17483
        Implement scrollbars on Windows (Cairo)

        Reviewed by Adam Roben.

        * wtf/Platform.h:

WebCore:

        http://bugs.webkit.org/show_bug.cgi?id=17483
        Implement scrollbars on Windows (Cairo)

        Reviewed by Adam Roben.

        * platform/win/PlatfromScrollBarWin.cpp: Duplicate implementation
          from PlatformScrollBarWinSafari.cpp, then modify to use the
          native Windows theme engine.  Use SOFT_LINK.  Use platform
          'GetSystemMetrics' call to decide size of scrollbars and buttons.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Delete an unused file

        Rubberstamped by Brady.

        * Interfaces/IWebScriptScope.idl: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Change WebPreferences to be backed by CFPreferences

        Reviewed by Ada, Geoff, Steve, and Darin.

        * WebPreferenceKeysPrivate.h:
        * WebPreferences.cpp:
        (WebPreferences::sharedStandardPreferences): Changed to call
        setAutoSaves(TRUE) before calling load(). This ensures that the
        preferences being migrated to CFPreferences are saved to disk.
        (WebPreferences::valueForKey): Changed to return a RetainPtr to ensure
        that the refcount is managed properly. Now attempts to retrieve a
        value from CFPreferences before falling back to the default settings.
        (WebPreferences::setValueForKey): Now saves the value in
        CFPreferences if m_autoSaves is true.
        (WebPreferences::stringValueForKey): Updated for valueForKey changes.
        (WebPreferences::integerValueForKey): DItto.
        (WebPreferences::boolValueForKey): Ditto.
        (WebPreferences::floatValueForKey): Ditto.
        (WebPreferences::save): Now simply calls CFPreferencesAppSynchronize.
        (WebPreferences::load): Always initializes m_privatePrefs to an empty
        CFMutableDictionary.
        (WebPreferences::migrateWebKitPreferencesToCFPreferences): Migrates
        preferences from our old custom plist to CFPreferences and then
        deletes our custom plist, if the migration has never occurred before.
        (WebPreferences::copyWebKitPreferencesToCFPreferences): Copies
        preferences to CFPreferences. If we've never migrated the default
        settings from Safari 3 Beta before, we omit them from this copying
        procedure.
        * WebPreferences.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Refactor value <-> CFNumber conversions into some helper functions

        Reviewed by Jon.

        * WebPreferences.cpp:
        (preferencesPath): Changed to return a const String&.
        (numberValueForPreferencesValue): Converts a value from preferences to
        a native numeric type.
        (cfNumber): Converts a native numeric value to a CFNumberRef.
        (booleanValueForPreferencesValue): Converts a value from preferences
        to a native boolean.
        (WebPreferences::integerValueForKey): Changed to call
        numberValueForPreferencesValue.
        (WebPreferences::floatValueForKey): Ditto.
        (WebPreferences::boolValueForKey): Changed to call
        booleanValueForPreferencesValue.
        (WebPreferences::setIntegerValue): Changed to call cfNumber.
        (WebPreferences::setLongLongValue): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Add WebPreferences::setValueForKey

        This is just a small refactoring of some duplicated logic into a
        shared method.

        Reviewed by Sam.

        * WebPreferences.cpp:
        (WebPreferences::setValueForKey): Added.
        (WebPreferences::setStringValue): Call setValueForKey.
        (WebPreferences::setIntegerValue): Ditto.
        (WebPreferences::setBoolValue): Ditto.
        (WebPreferences::setLongLongValue): Ditto.
        * WebPreferences.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Remove WebPreferences' static members

        s_defaultSettings is now a file-level static, and
        s_standardPreferences has been removed completely (it wasn't being
        used).

        Reviewed by Sam.

        * WebPreferences.cpp:
        (WebPreferences::initializeDefaultSettings):
        (WebPreferences::valueForKey):
        (WebPreferences::migrateDefaultSettingsFromSafari3Beta):
        (WebPreferences::removeValuesMatchingDefaultSettings):
        * WebPreferences.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Windows build fix

        * WebCore.vcproj/WebCore.vcproj: Remove bridge/* from the include path
        and the post-build event, and add page/win to each. Also let VS have
        its way with the order of the files.
        * page/win/PageWin.cpp: Copied from bridge/win/PageWin.cpp in r30673
        * page/win/GlobalHistoryWin.cpp: Copied from
        bridge/win/GlobalHistoryWin.cpp in r30673

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Remove unused DebuggerImp::abort and DebuggerImp::aborted

        Reviewed by Tim and Sam.

        * kjs/function_object.cpp:
        (KJS::FunctionObjectImp::construct):
        * kjs/internal.h:
        (KJS::DebuggerImp::DebuggerImp):
        * kjs/nodes.cpp:
        (KJS::Node::handleException):
        (KJS::FunctionBodyNodeWithDebuggerHooks::execute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Build fix.

        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Reviewed by David Harrison.

        Fixed <rdar://problem/5765063> TOT REGRESSION: Software Update crash in
        KJS::Collector::collect() (missing JSLock)

        * JSValueWrapper.cpp:
        (unprotectGlobalObject): Added missing JSLock.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-02-29  Mark Rowe  <mrowe@apple.com>

        Reviewed by Tim Hatcher.

        64-bit build fix.

        * platform/graphics/mac/SimpleFontDataMac.mm:
        (WebCore::pathFromFont): Provide stub implementation of pathFromFont for 64-bit as
        FMGetATSFontRefFromFont is not available.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Build fix.  Only declare pathFromFont in debug builds as it is unused in release builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Reviewed by Adam.

        Copy the remaining files in bridge/ over to page/

        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bridge: Removed.
        * bridge/AXObjectCache.h: Removed.
        * bridge/EditorClient.h: Removed.
        * bridge/GlobalHistory.h: Removed.
        * bridge/win: Removed.
        * bridge/win/FrameCGWin.cpp: Removed.
        * bridge/win/FrameCairoWin.cpp: Removed.
        * bridge/win/FrameWin.cpp: Removed.
        * bridge/win/FrameWin.h: Removed.
        * bridge/win/GlobalHistoryWin.cpp: Removed.
        * bridge/win/PageWin.cpp: Removed.
        * page/AXObjectCache.h: Copied from bridge/AXObjectCache.h.
        * page/EditorClient.h: Copied from bridge/EditorClient.h.
        * page/GlobalHistory.h: Copied from bridge/GlobalHistory.h.
        * page/win/FrameCGWin.cpp: Copied from bridge/win/FrameCGWin.cpp.
        * page/win/FrameCairoWin.cpp: Copied from bridge/win/FrameCairoWin.cpp.
        * page/win/FrameWin.cpp: Copied from bridge/win/FrameWin.cpp.
        * page/win/FrameWin.h: Copied from bridge/win/FrameWin.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-02-29  Robert Blaut  <webkit@blaut.biz>

        Reviewed by Darin Adler.

        - fix http://bugs.webkit.org/show_bug.cgi?id=17532
          Webkit imports styles from <link> element which doesn't have rel=stylesheet defined

        Test: fast/html/link-rel-stylesheet.html

        * html/HTMLLinkElement.cpp:
        (WebCore::HTMLLinkElement::process):

2008-02-29  Robert Blaut  <webkit@blaut.biz>

        Reviewed by Darin Adler.

        - Tests for http://bugs.webkit.org/show_bug.cgi?id=17532
          Webkit imports styles from <link> element which doesn't have rel=stylesheet defined

        * fast/html/link-rel-stylesheet.html: Added.
        * fast/media/mq-simple-query-02.html:
        * fast/media/mq-width-absolute-02.html:
        * platform/mac/fast/html/link-rel-stylesheet-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-02-29  Mark Rowe  <mrowe@apple.com>

        Reviewed by Anders Carlsson.

        Replace use of WKPathFromFont with implementation in terms of public API.

        * WebCore.base.exp: Remove unused symbol.
        * platform/graphics/mac/SimpleFontDataMac.mm:
        (WebCore::initFontData):
        (WebCore::pathFromFont): Implement pathFromFont in terms of public API.
        (WebCore::SimpleFontData::platformInit):
        * platform/mac/WebCoreSystemInterface.h: Remove unused symbol.
        * platform/mac/WebCoreSystemInterface.mm: Ditto.

2008-02-29  Mark Rowe  <mrowe@apple.com>

        Reviewed by Anders Carlsson.

        Replace use of WKPathFromFont with implementation in terms of public API.

        * WebCoreSupport/WebSystemInterface.m:
        (InitWebCoreSystemInterface): Remove unused symbol.

2008-02-29  Mark Rowe  <mrowe@apple.com>

        Reviewed by Anders Carlsson.

        Replace use of WKPathFromFont with implementation in terms of public API.

        * WebKitSystemInterface.h:  Remove unused symbol.
        * libWebKitSystemInterfaceLeopard.a:
        * libWebKitSystemInterfaceTiger.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Reviewed by Adam.

        Move a bunch of files from bridge/mac to page/mac.

        * WebCore.xcodeproj/project.pbxproj:
        * bridge/mac: Removed.
        * bridge/mac/AXObjectCacheMac.mm: Removed.
        * bridge/mac/GlobalHistoryMac.mm: Removed.
        * bridge/mac/WebCoreAXObject.h: Removed.
        * bridge/mac/WebCoreAXObject.mm: Removed.
        * bridge/mac/WebCoreScriptDebugger.h: Removed.
        * bridge/mac/WebCoreScriptDebugger.mm: Removed.
        * page/mac/AXObjectCacheMac.mm: Copied from bridge/mac/AXObjectCacheMac.mm.
        * page/mac/GlobalHistoryMac.mm: Copied from bridge/mac/GlobalHistoryMac.mm.
        * page/mac/WebCoreAXObject.h: Copied from bridge/mac/WebCoreAXObject.h.
        * page/mac/WebCoreAXObject.mm: Copied from bridge/mac/WebCoreAXObject.mm.
        * page/mac/WebCoreScriptDebugger.h: Copied from bridge/mac/WebCoreScriptDebugger.h.
        * page/mac/WebCoreScriptDebugger.mm: Copied from bridge/mac/WebCoreScriptDebugger.mm.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Fix for bugs.webkit.org/show_bug.cgi?id=17559, media query tests crashing under
        guard malloc.  Pass along the style selector so it can be accessed, since it has not yet
        been assigned into the document's member variable.

        Reviewed by aroben

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSRuleSet::addRulesFromSheet):
        * css/MediaQueryEvaluator.cpp:
        (WebCore::MediaQueryEvaluator::eval):
        * css/MediaQueryEvaluator.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Don't free the VARIANT passed into Write, since it is an input parameter owned by the caller.
        Found via code inspection.

        Reviewed by Adam.

        * WebActionPropertyBag.cpp:
        (WebActionPropertyBag::Write):
        * WebElementPropertyBag.cpp:
        (WebElementPropertyBag::Write):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Pass the correct configuration switch (--Debug|--Release) to build-testkjs.

        Reviewed by Dan.

        Originally broken in r26838.

        * Scripts/run-javascriptcore-tests: Push configuration switch onto @xcodeArgs
        not local, unused @args variable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    <rdar://problem/5755916> REGRESSION: Loading HTML5 spec is 5x slower on TOT than in 3.0.4

        Improve the performance of dynamic sibling and CSS3 selectors so that there is no slowdown any more.
        Be more precise in terms of what nodes we mark dirty.

        Reviewed by Beth

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::checkSelector):
        * dom/Element.cpp:
        (WebCore::Element::recalcStyle):
        (WebCore::checkForSiblingStyleChanges):
        (WebCore::Element::childrenChanged):
        (WebCore::Element::finishParsingChildren):
        * rendering/RenderStyle.cpp:
        (WebCore::RenderStyle::RenderStyle):
        * rendering/RenderStyle.h:
        (WebCore::RenderStyle::childrenAffectedByPositionalRules):
        (WebCore::RenderStyle::childrenAffectedByDirectAdjacentRules):
        (WebCore::RenderStyle::setChildrenAffectedByDirectAdjacentRules):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Bug 15754: webarchive layout tests fail when WebKit directory path contains symlinks

        <http://bugs.webkit.org/show_bug.cgi?id=15754>

        Reviewed by Geoff and Darin.

        We were using -[NSFileManager currentDirectoryPath] to get the current working directory,
        then removing that path from all file:/// URLs in the WebArchive output so these tests
        would pass no matter where they were run.

        The problem was that -[NSFileManager currentDirectoryPath] resolves symlinks in the
        current working directory, but the WebArchive does not.  This left the current working
        directory in all file:/// URLs in the test output, and thus all tests failed, for any
        developer that used symlinks to get to their WebKit source directory.

        The fix is to look backwards for "/LayoutTests/" in the URL we're passed, and simply
        remove the current working directory path (no matter what it is) after "file://" but
        before "/LayoutTests/".

        * DumpRenderTree/mac/DumpRenderTree.mm:
        (normalizeWebResourceURL): Removed unused oldURLBase argument.  We now replace the
        current working directory as described above.
        (convertWebResourceResponseToDictionary): Remove unused oldURLBase argument.  Update
        calls to normalizeWebResourceURL().
        (serializeWebArchiveToXML): Removed now unused cwdURL variable.  Update calls to
        normalizeWebResourceURL() and convertWebResourceResponseToDictionary().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Reviewed by Darin.

        <rdar://problem/5766352> REGRESSION (r27151): XMLHttpRequest.abort() resets response status

        Test: http/tests/xmlhttprequest/status-after-abort.html

        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::getStatus):
        (WebCore::XMLHttpRequest::getStatusText):
        Changed to match Firefox more closely (IE just raises an exception in most of those cases).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore:

        Reviewed by Darin Adler.

        - fix a bug where explicit embedding past the end of a line could
          affect text that line

        Test: fast/text/embed-at-end-of-pre-wrap-line.html

        * rendering/bidi.cpp:
        (WebCore::RenderBlock::skipWhitespace): Removed calls to
        setAdjustEmbedding().
        (WebCore::RenderBlock::findNextLineBreak): Added calls to
        setAdjustEmbedding() around skipWhitespace() only where needed.

LayoutTests:

        Reviewed by Darin Adler.

        - test for a bug where explicit embedding past the end of a line could
          affect text that line

        * fast/text/embed-at-end-of-pre-wrap-line.html: Added.
        * platform/mac-leopard/fast/text/embed-at-end-of-pre-wrap-line-expected.checksum: Added.
        * platform/mac-leopard/fast/text/embed-at-end-of-pre-wrap-line-expected.png: Added.
        * platform/mac/fast/text/embed-at-end-of-pre-wrap-line-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-02-29  Mark Rowe  <mrowe@apple.com>

        Reviewed by Oliver Hunt.

        Fix spelling of "request" in name of WKNSURLProtocolClassForRequest.

        * Misc/WebNSURLExtras.mm:
        (-[NSURL _webkit_canonicalize]):
        * WebKit.order:

2008-02-29  Mark Rowe  <mrowe@apple.com>

        Reviewed by Oliver Hunt.

        Fix spelling of "request" in name of WKNSURLProtocolClassForRequest.

        * WebKitSystemInterface.h:
        * libWebKitSystemInterfaceLeopard.a:
        * libWebKitSystemInterfaceTiger.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-02-29  Mark Rowe  <mrowe@apple.com>

        Reviewed by Oliver Hunt.

        Don't use WKSupportsMultipartXMixedReplace on Leopard as multipart/x-mixed-replace is always handled by NSURLRequest.

        * platform/mac/WebCoreSystemInterface.h: Don't declare WKSupportsMultipartXMixedReplace on Leopard.
        * platform/mac/WebCoreSystemInterface.mm: Ditto.
        * platform/network/mac/ResourceRequestMac.mm:
        (WebCore::ResourceRequest::doUpdatePlatformRequest): Don't call WKSupportsMultipartXMixedReplace on Leopard.
        * WebCore.Tiger.exp: Move Tiger-only symbol here.
        * WebCore.base.exp:

2008-02-29  Mark Rowe  <mrowe@apple.com>

        Reviewed by Oliver Hunt.

        Don't use WKSupportsMultipartXMixedReplace on Leopard as multipart/x-mixed-replace is always handled by NSURLRequest.

        * WebKitSystemInterface.h:
        * libWebKitSystemInterfaceLeopard.a:

2008-02-29  Mark Rowe  <mrowe@apple.com>

        Reviewed by Oliver Hunt.

        Don't use WKSupportsMultipartXMixedReplace on Leopard as multipart/x-mixed-replace is always handled by NSURLRequest.

        * WebCoreSupport/WebSystemInterface.m:
        (InitWebCoreSystemInterface):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-02-29  Mark Rowe  <mrowe@apple.com>

        Reviewed by Oliver Hunt.

        Remove obsolete code that had been left intact to support users running WebKit with older versions of Safari.

        * Misc/WebNSViewExtras.m:  Remove _web_superviewOfClass:stoppingAtClass:.
        * Misc/WebNSWindowExtras.m:  Remove _webkit_displayThrottledWindows.
        * Misc/WebSearchableTextView.m:  Remove selectionImageForcingWhiteText:.
        * WebCoreSupport/WebImageRendererFactory.m:  Update comment to mention the last version of Safari that
        requires this class.
        * WebInspector/WebInspector.mm:  Remove sharedWebInspector and update comments to mention the last version
        of Safari that calls other obsolete methods.
        * WebView/WebDocumentPrivate.h:  Remove selectionImageForcingWhiteText:.
        * WebView/WebHTMLView.mm:  Ditto.
        * WebView/WebPDFView.mm:  Ditto.
        * WebView/WebView.mm:  Update comment to mentoin the last version of Safari that requires the obsolete method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-02-29  Mark Rowe  <mrowe@apple.com>

        Rubber-stamped by Eric Seidel.

        Remove unneeded includes of WebCoreSystemInterface.h.

        * loader/mac/LoaderNSURLExtras.m:
        * page/mac/FrameMac.mm:
        * page/mac/WebCoreFrameBridge.mm:
        * platform/MIMETypeRegistry.cpp:
        * platform/graphics/mac/ImageMac.mm:
        * platform/mac/PasteboardMac.mm:

2008-02-29  Mark Rowe  <mrowe@apple.com>

        Rubber-stamped by Eric Seidel.

        Remove unneeded includes of WebKitSystemInterface.h.

        * History/WebHistoryItem.mm:
        * Misc/WebNSViewExtras.m:
        * WebCoreSupport/WebFrameLoaderClient.mm:
        * WebView/WebDataSource.mm:
        * WebView/WebPDFView.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-02-29  Mark Rowe  <mrowe@apple.com>

        Reviewed by Oliver Hunt and Oliver Hunt.

        <rdar://problem/4753845> WebKit should use CGEventSourceSecondsSinceLastEventType in place of WKSecondsSinceLastInputEvent SPI.

        * platform/mac/SystemTimeMac.cpp:  Replace use of WKSecondsSinceLastInputEvent with CGEventSourceSecondsSinceLastEventType.
        * platform/mac/WebCoreSystemInterface.h:  Remove unused symbol.
        * platform/mac/WebCoreSystemInterface.mm:  Ditto.
        * WebCore.base.exp:  Ditto.

2008-02-29  Mark Rowe  <mrowe@apple.com>

        Reviewed by Oliver Hunt and Oliver Hunt.

        <rdar://problem/4753845> WebKit should use CGEventSourceSecondsSinceLastEventType in place of WKSecondsSinceLastInputEvent SPI.

        * WebCoreSupport/WebSystemInterface.m:
        (InitWebCoreSystemInterface):  Remove unused symbol.
        * WebKit.order:  Ditto.

2008-02-29  Mark Rowe  <mrowe@apple.com>

        Reviewed by Oliver Hunt and Oliver Hunt.

        <rdar://problem/4753845> WebKit should use CGEventSourceSecondsSinceLastEventType in place of WKSecondsSinceLastInputEvent SPI.

        * WebKitSystemInterface.h:  Remove unused symbol.
        * libWebKitSystemInterfaceLeopard.a:
        * libWebKitSystemInterfaceTiger.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-02-28  Mark Rowe  <mrowe@apple.com>

        Reviewed by Dan Bernstein.

        Remove two unused functions from WebKitSystemInterface.

        * WebKitSystemInterface.h:  Remove WKPreferRGB32Key and WKGetDefaultGlyphForChar as they are unused. Also remove
        a duplicate declaration of WKSecondsSinceLastInputEvent.
        * libWebKitSystemInterfaceLeopard.a:
        * libWebKitSystemInterfaceTiger.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-02-28  Mark Rowe  <mrowe@apple.com>

        Reviewed by Dave Hyatt.

        Make use of new CGFont APIs on Leopard rather than making a WebKitSystemInterface call.

        * DerivedSources.make:  Add Tiger-only symbols to the export file when running on Tiger.
        * WebCore.Tiger.exp:  Added.  Move Tiger-only symbol here from WebCore.base.exp.
        * WebCore.base.exp:
        * platform/graphics/mac/SimpleFontDataMac.mm:
        (WebCore::SimpleFontData::platformInit):  Use Leopard APIs when building on Leopard.
        * platform/mac/WebCoreSystemInterface.h:  Don't declare wkGetFontMetrics on Leopard as it is unused.
        * platform/mac/WebCoreSystemInterface.mm:  Ditto.

2008-02-28  Mark Rowe  <mrowe@apple.com>

        Reviewed by Dave Hyatt.

        Make use of new CGFont APIs on Leopard rather than making a WebKitSystemInterface call.

        * WebKitSystemInterface.h:  Only declare WKGetFontMetrics on Tiger.
        * libWebKitSystemInterfaceLeopard.a:  Update for removal of WKGetFontMetrics.

2008-02-28  Mark Rowe  <mrowe@apple.com>

        Reviewed by Dave Hyatt.

        Make use of new CGFont APIs on Leopard rather than making a WebKitSystemInterface call.

        * WebCoreSupport/WebSystemInterface.m:
        (InitWebCoreSystemInterface): Only initialize wkGetFontMetrics on Tiger.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Reviewed by Tim Hatcher.

        Bug 16535: Stylesheets loaded with @import are not editable
        http://bugs.webkit.org/show_bug.cgi?id=16535
        <rdar://problem/5712899>

        Sheets loaded using @import were incorrectly being flagged as non-editable
        user agent sheets because their parent sheet doesn't have an ownerNode. We now
        check to make sure sheets also don't have a href before restricting their editability.

        * page/inspector/StylesSidebarPane.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Reviewed by Geoffrey Garen.

        ** TOTAL **:          1.005x as fast    2867.6ms +/- 0.4%  2853.2ms +/- 0.3%    significant

        * kjs/nodes.cpp: Tell the compiler that exceptions are unexpected (for
        the sake of branch prediction and code organization).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-02-28  Rodney Dawes  <dobey@wayofthemonkey.com>

        Reviewed by Adam Roben.

        Copy PluginPackageWin.cpp to shared PluginPackage.cpp.
        Add PluginPackage.cpp to build configurations.
        Remove PluginPackage destructor from TemporaryLinkStubs.cpp.
        Use cross-platform pathGetFilename method.
        Remove platform-specific code from shared PluginPackage implementation.
        Remove shared code from PluginPackageWin.cpp.

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCoreSources.bkl:
        * WebCore.vcproj/WebCore.vcproj:
        * platform/gtk/TemporaryLinkStubs.cpp:
        * platform/qt/TemporaryLinkStubs.cpp:
        * platform/wx/TemporaryLinkStubs.cpp:
        * plugins/PluginPackage.cpp:
        * plugins/win/PluginPackageWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore:

        Reviewed by Darin Adler.

        <rdar://problem/4930986> REGRESSION: Paste As Quotation pastes black text instead of blue

        Add a second style span at copy time to hold document default styles.  This helps us
        differentiate between those and user applied styles at paste time, where we'll want
        to let Mail's Paste As Quotation blockquote override document default styles, but
        not others.

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Changed the unit type used
        for -webkit-text-stroke-width from CSS_NUMBER to CSS_PX, to match other properties that
        are thick | medium | thin | <length>.  Before, there was a mismatch between the unit
        type of -webkit-text-stroke-width property values in a CSSComputedStyleDeclaration for
        an element and that element's inlineStyleDecl(), causing identical values to always appear
        different to diff().
        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::handlePasteAsQuotationNode): Fixed.  Don't just change
        the class to an empty string, completely remove it, it's no longer needed.
        (WebCore::handleStyleSpansBeforeInsertion): Moved the optimization from doApply here.
        (WebCore::ReplaceSelectionCommand::handleStyleSpans):
        Added, replaces removeRedundantStyles.
        We aren't (yet) removing all redundant styles, just those on style spans, so I removed the
        unused code and renamed the function.
        There won't be more than two style spans that we need to consider, the one with the
        source document's default styles and styles on the commonAncestor of the copied Range,
        so don't look for more than two.
        Let elements that wrap the incoming fragment override the source document's styles.
        (WebCore::ReplaceSelectionCommand::doApply): Moved code to handleStyleSpansBeforeInsertion
        and call the renamed handleStyleSpans.
        * editing/ReplaceSelectionCommand.h:
        * editing/markup.cpp:
        (WebCore::removeDefaultStyles): Added.  Don't add document defaults to the style span
        that holds user applied styles, since they'll be added to their own style span.
        (WebCore::createMarkup):
        Add a second style span that holds just the document defaults. This lets us differentiate
        between those and user applied styles at paste time.
        Mail blockquotes are just another type of special element, moved their handling there. This
        also lets paste code make assumptions about the position of the two style spans (they are
        *always* parent-child).

LayoutTests:

        Reviewed by Darin Adler.

        <rdar://problem/4930986> REGRESSION: Paste As Quotation pastes black text instead of blue

        Demonstrates the bug:
        * editing/pasteboard/4930986-1-expected.txt: Added.
        * editing/pasteboard/4930986-1.html: Added.
        * editing/pasteboard/4930986-2-expected.txt: Added.
        * editing/pasteboard/4930986-2.html: Added.

        Demonstrates a problem with the first version of the patch:
        * editing/pasteboard/4930986-3-expected.txt: Added.
        * editing/pasteboard/4930986-3.html: Added.

        Visual problem fixed.  An anonymous renderer changed position, DOM remains unchanged:
        * editing/execCommand/5144139-1.html:
        * platform/mac/editing/execCommand/5144139-1-expected.checksum:
        * platform/mac/editing/execCommand/5144139-1-expected.png:
        * platform/mac/editing/execCommand/5144139-1-expected.txt:

        Removed unnecessary style spans, visual result unchanged:
        * platform/mac/editing/pasteboard/merge-end-blockquote-expected.checksum:
        * platform/mac/editing/pasteboard/merge-end-blockquote-expected.png:
        * platform/mac/editing/pasteboard/merge-end-blockquote-expected.txt:
        * platform/mac/editing/style/font-family-with-space-expected.checksum:
        * platform/mac/editing/style/font-family-with-space-expected.png:
        * platform/mac/editing/style/font-family-with-space-expected.txt:

        A style span isn't removed because at paste time because we don't anticipate
        encountering styles on style spans that are non-inheritable, because we don't
        create style spans like that at copy time. Turned this into a text only
        test. Test remains visually unchanged:
        * editing/pasteboard/5245519-expected.txt: Added.
        * editing/pasteboard/5245519.html:
        * platform/mac/editing/pasteboard/5245519-expected.checksum: Removed.
        * platform/mac/editing/pasteboard/5245519-expected.png: Removed.
        * platform/mac/editing/pasteboard/5245519-expected.txt: Removed.

        Added an extra empty anonymous renderer, DOM and visual result remain unchanged:
        * platform/mac/editing/execCommand/create-list-with-hr-expected.checksum:
        * platform/mac/editing/execCommand/create-list-with-hr-expected.png:
        * platform/mac/editing/execCommand/create-list-with-hr-expected.txt:
        * platform/mac/editing/pasteboard/paste-list-001-expected.checksum:
        * platform/mac/editing/pasteboard/paste-list-001-expected.png:
        * platform/mac/editing/pasteboard/paste-list-001-expected.txt:
        * platform/mac/editing/pasteboard/paste-table-001-expected.checksum:
        * platform/mac/editing/pasteboard/paste-table-001-expected.png:
        * platform/mac/editing/pasteboard/paste-table-001-expected.txt:
        * platform/mac/editing/pasteboard/paste-text-003-expected.checksum:
        * platform/mac/editing/pasteboard/paste-text-003-expected.png:
        * platform/mac/editing/pasteboard/paste-text-003-expected.txt:

        Reflects changes to CSSComputedStyleDeclaration::getPropertyCSSValue:
        * fast/css/computed-style-expected.txt:
        * fast/css/computed-style-without-renderer-expected.txt:

        We don't remove styles from style spans that are overridden by all of their
        children, even though they are unnecessary. We've never done this, but now
        that there can be two style spans at paste time we are more likely to have
        a style span left over because of this problem.  Mentioned this in the test
        case and turned this into a text only test:
        * editing/pasteboard/4840662.html:
        * editing/pasteboard/4840662-expected.txt: Added.
        * platform/mac/editing/pasteboard/4840662-expected.checksum: Removed.
        * platform/mac/editing/pasteboard/4840662-expected.png: Removed.
        * platform/mac/editing/pasteboard/4840662-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-02-28  Brent Fulgham <bfulgham@gmail.com>

        http://bugs.webkit.org/show_bug.cgi?id=17576
        Modify RenderThemeWin to use SOFT_LINK

        Reviewed by Adam Roben.

        * rendering/RenderThemeWin.h: Remove unneeded library handle
        * rendering/RenderThemeWin.cpp: Change to use SOFT_LINK
          rather than hand-coded load library calls.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Reviewed by Darin Adler.

        - fix http://bugs.webkit.org/show_bug.cgi?id=17590
          ASSERTION FAILED: subject in jsRegExpExecute()

        * page/mac/FrameMac.mm:
        (WebCore::Frame::matchLabelsAgainstElement): Added an early return in
        case the element name is empty.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Reviewed by Dan Bernstein

        Small editing speed up.

        * dom/Position.cpp:
        (WebCore::Position::upstream): Don't check for a change in editability
        if the current node hasn't changed.
        (WebCore::Position::downstream): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-02-28  Alp Toker  <alp@atoker.com>

        Fix a configure script typo spotted by Kalle Vahlman.

        * configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore:

        Reviewed by John Sullivan.

        - fix <rdar://problem/5607547> Single letter surrounded by soft hyphens can disappear

        Test: fast/text/soft-hyphen-2.html

        * rendering/bidi.cpp:
        (WebCore::chopMidpointsAt): Changed to iterate midpoints backwards, so
        that if there are two midpoints at the given position, only the last one
        will be chopped off.

LayoutTests:

        Reviewed by John Sullivan.

        - test for <rdar://problem/5607547> Single letter surrounded by soft hyphens can disappear

        * fast/text/soft-hyphen-2.html: Added.
        * platform/mac/fast/text/soft-hyphen-2-expected.checksum: Added.
        * platform/mac/fast/text/soft-hyphen-2-expected.png: Added.
        * platform/mac/fast/text/soft-hyphen-2-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Updated resource used in the layout test I landed yesterday.
        Due to a difference between Foundation on Tiger vs Leopard, the resource generated on
        Leopard caused different results on Leopard and Tiger.
        Regenerating the resource on Tiger, however, agrees with Leopard.

        * webarchive/loading/resources/cache-expired-subresource.webarchive:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore:

        Reviewed by Darin Adler.

        - make centered text in right-to-left blocks spill over to the left

        Test: fast/text/align-center-rtl-spill.html

        * rendering/bidi.cpp:
        (WebCore::RenderBlock::computeHorizontalPositionsForLine):

LayoutTests:

        Reviewed by Darin Adler.

        - test that centered text in right-to-left blocks spills over to the left

        * fast/text/align-center-rtl-spill.html: Added.
        * platform/mac/fast/text/align-center-rtl-spill-expected.checksum: Added.
        * platform/mac/fast/text/align-center-rtl-spill-expected.png: Added.
        * platform/mac/fast/text/align-center-rtl-spill-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Tiger build fix

        * libWebKitSystemInterfaceTiger.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Reviewed by Darin Adler.

        - more bidi.cpp cleanup

        * platform/text/BidiResolver.h:
        (WebCore::BidiCharacterRun::destroy): Added. Overridden by BidiRun .
        (WebCore::BidiResolver<Iterator, Run>::addRun): Moved BidiState::addRun()
        here.
        (WebCore::BidiResolver<Iterator, Run>::appendRun): Changed to use
        addRun().
        (WebCore::BidiResolver<Iterator, Run>::deleteRuns): Changed to use
        destroy(), avoiding the need to specialize this method in BidiState.
        * rendering/bidi.cpp:
        (WebCore::BidiRun::destroy): Removed the RenderArena parameter.
        (WebCore::BidiState::deleteRuns): Removed now-unnecessary specialization.
        (WebCore::BidiState::addRun): Removed now-unnecessary specialization.
        (WebCore::RenderBlock::createLineBoxes):
        (WebCore::RenderBlock::constructLine):
        (WebCore::RenderBlock::computeHorizontalPositionsForLine): Added a FIXME.
        (WebCore::RenderBlock::computeVerticalPositionsForLine):
        (WebCore::buildCompactRuns):
        (WebCore::RenderBlock::layoutInlineChildren):
        (WebCore::RenderBlock::determineStartPosition):
        (WebCore::RenderBlock::determineEndPosition):
        (WebCore::RenderBlock::matchedEndLine):
        (WebCore::skipNonBreakingSpace):
        (WebCore::RenderBlock::skipWhitespace):
        (WebCore::shouldSkipWhitespaceAfterStartObject):
        * rendering/bidi.h:
        (WebCore::BidiRun): Added m_ prefixes to several member variables.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Reviewed by Mark Rowe

        Removed some unused methods:
        WKGetNSURLResponseCalculatedExpiration
        WKGetNSURLResponseMustRevalidate

        * WebKitSystemInterface.h:
        * libWebKitSystemInterfaceLeopard.a:
        * libWebKitSystemInterfaceTiger.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Rubber-stamped by Adam.

        Fix svn:eol-style on all LayoutTest results
        I simply ran:
        cd LayoutTests
        find . -name "*-expected.txt" | xargs svn ps svn:eol-style native

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore:

        Reviewed by Darin.

        Fix for <rdar://problem/5768769>

        - Don't allow cross-origin calls using window.functionName.call(otherFrame)
          syntax.

        * bindings/js/JSLocation.cpp:
        (WebCore::jsLocationProtoFuncToString): Do same-origin check.
        * bindings/js/kjs_window.cpp:
        (KJS::windowProtoFuncAToB): Ditto.
        (KJS::windowProtoFuncBToA): Ditto.
        (KJS::windowProtoFuncOpen): Ditto.
        (KJS::windowProtoFuncClearTimeout): Ditto.
        * bindings/scripts/CodeGeneratorJS.pm: Ditto.

LayoutTests:

        Reviewed by Darin.

        Updates tests for <rdar://problem/5768769>

        * http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt:
        * http/tests/security/cross-frame-access-call-expected.txt:
        * http/tests/security/cross-frame-access-call.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    More cleanup in preparation for fixing the HTML5 spec performance regression.

        Reviewed by Sam Weinig

        * dom/Attr.cpp:
        (WebCore::Attr::childrenChanged):
        * dom/Attr.h:
        * dom/ContainerNode.cpp:
        (WebCore::ContainerNode::insertBefore):
        (WebCore::ContainerNode::replaceChild):
        (WebCore::ContainerNode::removeChild):
        (WebCore::ContainerNode::removeChildren):
        (WebCore::ContainerNode::appendChild):
        (WebCore::ContainerNode::addChild):
        (WebCore::ContainerNode::childrenChanged):
        * dom/ContainerNode.h:
        * dom/Document.cpp:
        (WebCore::Document::childrenChanged):
        * dom/Document.h:
        * dom/Element.cpp:
        (WebCore::Element::childrenChanged):
        * dom/Element.h:
        * dom/Node.h:
        (WebCore::Node::childrenChanged):
        * html/HTMLObjectElement.cpp:
        (WebCore::HTMLObjectElement::childrenChanged):
        * html/HTMLObjectElement.h:
        * html/HTMLOptGroupElement.cpp:
        (WebCore::HTMLOptGroupElement::childrenChanged):
        * html/HTMLOptGroupElement.h:
        * html/HTMLOptionElement.cpp:
        (WebCore::HTMLOptionElement::childrenChanged):
        * html/HTMLOptionElement.h:
        * html/HTMLScriptElement.cpp:
        (WebCore::HTMLScriptElement::childrenChanged):
        * html/HTMLScriptElement.h:
        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::childrenChanged):
        * html/HTMLSelectElement.h:
        * html/HTMLStyleElement.cpp:
        (WebCore::HTMLStyleElement::childrenChanged):
        * html/HTMLStyleElement.h:
        * html/HTMLTextAreaElement.cpp:
        (WebCore::HTMLTextAreaElement::childrenChanged):
        * html/HTMLTextAreaElement.h:
        * html/HTMLTitleElement.cpp:
        (WebCore::HTMLTitleElement::childrenChanged):
        * html/HTMLTitleElement.h:
        * svg/SVGClipPathElement.cpp:
        (WebCore::SVGClipPathElement::childrenChanged):
        * svg/SVGClipPathElement.h:
        * svg/SVGDefinitionSrcElement.cpp:
        (WebCore::SVGDefinitionSrcElement::childrenChanged):
        * svg/SVGDefinitionSrcElement.h:
        * svg/SVGFontFaceElement.cpp:
        (WebCore::SVGFontFaceElement::childrenChanged):
        * svg/SVGFontFaceElement.h:
        * svg/SVGFontFaceFormatElement.cpp:
        (WebCore::SVGFontFaceFormatElement::childrenChanged):
        * svg/SVGFontFaceFormatElement.h:
        * svg/SVGFontFaceSrcElement.cpp:
        (WebCore::SVGFontFaceSrcElement::childrenChanged):
        * svg/SVGFontFaceSrcElement.h:
        * svg/SVGFontFaceUriElement.cpp:
        (WebCore::SVGFontFaceUriElement::childrenChanged):
        * svg/SVGFontFaceUriElement.h:
        * svg/SVGGElement.cpp:
        (WebCore::SVGGElement::childrenChanged):
        * svg/SVGGElement.h:
        * svg/SVGGradientElement.cpp:
        (WebCore::SVGGradientElement::childrenChanged):
        * svg/SVGGradientElement.h:
        * svg/SVGMarkerElement.cpp:
        (WebCore::SVGMarkerElement::childrenChanged):
        * svg/SVGMarkerElement.h:
        * svg/SVGMaskElement.cpp:
        (WebCore::SVGMaskElement::childrenChanged):
        * svg/SVGMaskElement.h:
        * svg/SVGPatternElement.cpp:
        (WebCore::SVGPatternElement::childrenChanged):
        * svg/SVGPatternElement.h:
        * svg/SVGStyleElement.cpp:
        (WebCore::SVGStyleElement::childrenChanged):
        * svg/SVGStyleElement.h:
        * svg/SVGStyledElement.cpp:
        (WebCore::SVGStyledElement::childrenChanged):
        * svg/SVGStyledElement.h:
        * svg/SVGTitleElement.cpp:
        (WebCore::SVGTitleElement::childrenChanged):
        * svg/SVGTitleElement.h:
        * svg/SVGUseElement.cpp:
        (WebCore::SVGUseElement::childrenChanged):
        * svg/SVGUseElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebKit/mac:

        Reviewed by Mark Rowe (code) and Darin (concept)

        Much better fix for <rdar://problem/4930688> (see r19549)
        Original fix for <rdar://problem/3947312> (and 14 dupes)

        Let me tell you a story:
        A long time ago, in a cvs repository far, far away, loader code was almost all up in WebKit.
        WebArchive code was intertwined with that code in bizarre and complex ways.
        During the months long loader re-factoring where we pushed much loader code down into WebCore,
        many portions of the WebKit loader were thinned out until they ceased to exist.  Others remained
        with a sole purpose.

        One such section of code whose lineage traces back from WebFrameLoaderClient to WebFrameLoader
        to WebLoader was originally rooted in the method [WebLoader loadRequest:].  This method was the
        single entry point for almost all loading (network or web archives)

        This method would check various headers and other fields on the NSURLRequest and NSURLResponse
        to make decisions about the load.  If the cache control fields were expired or other conditions
        in the headers were met, the load would be forced to go out to the network.

        As the loader was moved and tweaked repeatedly, most of this code was pruned or re-factored.
        At some point, all that remained was the special cases for loading WebArchives.

        Somewhere in the r16,000s, this remaining responsibility was noticed and related methods we renamed
        to be WebArchive specific, further cementing the assumed design.

        Problem is, the design was bad.  A WebArchive is meant to be a static snapshot of a WebPage at a
        specific point in time.  Referring to the request to see if the resource should be reloaded seems
        nonsensical, as does referring to the response headers to see if the resource is "expired".  In the
        context of loading a WebArchive, available data should *always* be loaded from the WebArchive, at least
        during the initial load!

        After discovering the secret to reproducing all of these bugs is both emptying our your Foundation
        cache and disconnecting your network, it was easy to reproduce the 16 individually reported cases
        that were all symptoms of this bug, and easy to verify that they are fixed with this patch.

        * WebCoreSupport/WebFrameLoaderClient.h:
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::willUseArchive): Do not call either form of "canUseArchivedResource()" that
          inspect the request or response objects - We are loading from a WebArchive, and we should never
          make the decision to go out to the network when we actually have the resource available.

        * WebCoreSupport/WebSystemInterface.m:
        (InitWebCoreSystemInterface):  Remove two methods that are no longer used anywhere in WebKit

LayoutTests:

        Reviewed by Mark Rowe

        Test for better fix for <rdar://problem/4930688> (see r19549) and
        original fix for <rdar://problem/3947312> (and 14 dupes)

        Crafting custom WebArchives for layout tests is a pain and something that should
        be resolved if we decide to pursue a new format.

        Using a custom php script to act as a stand in for an image resource, I set its
        cache-control header to expire immediately.  Without the fix for the above bugs,
        the resource will be "expired" and an attempt to fetch it from the network will
        go out and fail.  This failure will manifest with different ResourceLoadDelegate
        information, as well as different dimensions in the render tree - the missing
        image icon versus the archived image.

        With the fix in place, the response will be ignored and the image will be pulled
        from the WebArchive.

        * webarchive/loading/cache-expired-subresource-expected.txt: Added.
        * webarchive/loading/cache-expired-subresource.html: Added.
        * webarchive/loading/resources/cache-expired-subresource.webarchive: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebKit/mac:

        Reviewed by Adam Roben.

        Bug 14348: Messing up the inspector by dragging an URL into it
        http://bugs.webkit.org/show_bug.cgi?id=14348
        <rdar://problem/5283620> and <rdar://problem/5712808>

        * WebCoreSupport/WebInspectorClient.mm:
        (-[WebInspectorWindowController init]): Remove duplicate preference setting.
        (-[WebInspectorWindowController webView:dragDestinationActionMaskForDraggingInfo:]):

WebKit/win:

        Reviewed by Adam Roben.

        Bug 14348: Messing up the inspector by dragging an URL into it
        http://bugs.webkit.org/show_bug.cgi?id=14348
        <rdar://problem/5283620> and <rdar://problem/5712808>

        Add a new class to handle the Inspector's delegate calls.

        * WebCoreSupport/WebInspectorClient.cpp:
        (WebInspectorClient::createPage):
        * WebCoreSupport/WebInspectorDelegate.cpp: Added.
        (:m_refCount):
        (WebInspectorDelegate::createInstance):
        (WebInspectorDelegate::AddRef):
        (WebInspectorDelegate::Release):
        (WebInspectorDelegate::dragDestinationActionMaskForDraggingInfo):
        * WebCoreSupport/WebInspectorDelegate.h: Added.
        (WebInspectorDelegate::QueryInterface):
        (WebInspectorDelegate::createWebViewWithRequest):
        (WebInspectorDelegate::webViewShow):
        (WebInspectorDelegate::webViewClose):
        (WebInspectorDelegate::webViewFocus):
        (WebInspectorDelegate::webViewUnfocus):
        (WebInspectorDelegate::webViewFirstResponder):
        (WebInspectorDelegate::makeFirstResponder):
        (WebInspectorDelegate::setStatusText):
        (WebInspectorDelegate::webViewStatusText):
        (WebInspectorDelegate::webViewAreToolbarsVisible):
        (WebInspectorDelegate::setToolbarsVisible):
        (WebInspectorDelegate::webViewIsStatusBarVisible):
        (WebInspectorDelegate::setStatusBarVisible):
        (WebInspectorDelegate::webViewIsResizable):
        (WebInspectorDelegate::setResizable):
        (WebInspectorDelegate::setFrame):
        (WebInspectorDelegate::webViewFrame):
        (WebInspectorDelegate::setContentRect):
        (WebInspectorDelegate::webViewContentRect):
        (WebInspectorDelegate::runJavaScriptAlertPanelWithMessage):
        (WebInspectorDelegate::runJavaScriptConfirmPanelWithMessage):
        (WebInspectorDelegate::runJavaScriptTextInputPanelWithPrompt):
        (WebInspectorDelegate::runBeforeUnloadConfirmPanelWithMessage):
        (WebInspectorDelegate::runOpenPanelForFileButtonWithResultListener):
        (WebInspectorDelegate::mouseDidMoveOverElement):
        (WebInspectorDelegate::contextMenuItemsForElement):
        (WebInspectorDelegate::validateUserInterfaceItem):
        (WebInspectorDelegate::shouldPerformAction):
        (WebInspectorDelegate::willPerformDragDestinationAction):
        (WebInspectorDelegate::dragSourceActionMaskForPoint):
        (WebInspectorDelegate::willPerformDragSourceAction):
        (WebInspectorDelegate::contextMenuItemSelected):
        (WebInspectorDelegate::hasCustomMenuImplementation):
        (WebInspectorDelegate::trackCustomPopupMenu):
        (WebInspectorDelegate::measureCustomMenuItem):
        (WebInspectorDelegate::drawCustomMenuItem):
        (WebInspectorDelegate::addCustomMenuDrawingData):
        (WebInspectorDelegate::cleanUpCustomMenuDrawingData):
        (WebInspectorDelegate::canTakeFocus):
        (WebInspectorDelegate::takeFocus):
        (WebInspectorDelegate::registerUndoWithTarget):
        (WebInspectorDelegate::removeAllActionsWithTarget):
        (WebInspectorDelegate::setActionTitle):
        (WebInspectorDelegate::undo):
        (WebInspectorDelegate::redo):
        (WebInspectorDelegate::canUndo):
        (WebInspectorDelegate::canRedo):
        * WebKit.vcproj/WebKit.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Landing test that was forgotten in the original patch (r30087).

        Test for: http://bugs.webkit.org/show_bug.cgi?id=17191
        HTML5: Client-side database queries should return values of type number

        * storage/sql-data-types-expected.txt: Added.
        * storage/sql-data-types.html: Added.
        * storage/sql-data-types.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Add bug number to ChangeLog.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-02-27  Julien Chaffraix <julien.chaffraix@gmail.com>

        Reviewed by Alexey.

        http://bugs.webkit.org/show_bug.cgi?id=17481
        Several consecutive calls to XMLHttpRequest::open should dispatch only one readyState event

        Test: http/tests/xmlhttprequest/xmlhttprequest-multiple-open.html

        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::open):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Reviewed by Sam Weinig.

        http://bugs.webkit.org/show_bug.cgi?id=17030
        Small buffer overflow within initialization

        * kjs/date_object.cpp:
        (KJS::DateObjectFuncImp::callAsFunction):
        (KJS::parseDate):
        Remove unnecessary and incorrect memset() calls - GregorianDateTime can initialize itself.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-02-27  Sriram Neelakandan  <sriram.neelakandan@gmail.com>

        Reviewed, tweaked and landed by ap.

        http://bugs.webkit.org/show_bug.cgi?id=17487
        HTMLInput mysteriously fails to work if ICU dat file is missing

        * platform/text/TextBreakIteratorICU.cpp: (WebCore::setUpIterator): Assert that the iterator
        has been opened.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Attempt to fix the GTK+ build

        * webkit/webkitwebframe.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Fix revision number in ChangeLog

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Windows build fix after r30613

        * platform/win/ClipboardWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Reviewed by Simon.

Small style cleanup, and obvious fix: SVGGElement reacted on
'clipPathUnits' changes, which is a funny copy&paste error.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Reviewed by Simon.

Cleanup coding style. Still on my way to fix dynamic updates of all SVG elements.
Currently at SVGF*. SVGDefs/DescElement don't need any dyn update fixes but cleanups.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Reviewed by Darin.

        Fix <rdar://problem/5761326>
        REGRESSION: 1.5% -2% Sunspider regression from r30009 (ebay photo upload hang)

        Generate better code with VS:
        - Use ALWAYS_INLINE macro to guarantee versions of allowsAccessFrom() are reduced to single functions
        - Refactor error reporting so that there is no need to construct/destruct Strings in common cases
        - Add a separate version of the function for cases where error messages are not wanted

        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::customGetOwnPropertySlot):
        * bindings/js/kjs_window.cpp:
        (KJS::Window::allowsAccessFrom):
        (KJS::Window::allowsAccessFromNoErrorMessage):
        (KJS::Window::allowsAccessFromPrivate):
        (KJS::Window::crossDomainAccessErrorMessage):
        * bindings/js/kjs_window.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Reviewed by Dave Hyatt.

        - remove DeprecatedCString, DeprecatedArray, and ArrayImpl.

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * platform/ArrayImpl.cpp: Removed.
        * platform/ArrayImpl.h: Removed.
        * platform/DeprecatedArray.h: Removed.
        * platform/DeprecatedCString.cpp: Removed.
        * platform/DeprecatedCString.h: Removed.
        * platform/text/CString.cpp:
        (WebCore::CString::length):
        * platform/text/CString.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Cleanup of childrenChanged in preparation for fixing the HTML5 spec slowdown.

        Reviewed by Sam Weinig

        * dom/Attr.cpp:
        (WebCore::Attr::childrenChanged):
        * dom/ContainerNode.cpp:
        (WebCore::ContainerNode::insertBefore):
        (WebCore::ContainerNode::replaceChild):
        (WebCore::ContainerNode::removeChild):
        (WebCore::ContainerNode::removeChildren):
        (WebCore::ContainerNode::appendChild):
        (WebCore::ContainerNode::addChild):
        (WebCore::ContainerNode::childrenChanged):
        * dom/ContainerNode.h:
        * dom/EventTargetNode.cpp:
        (WebCore::EventTargetNode::dispatchSubtreeModifiedEvent):
        * dom/EventTargetNode.h:
        * dom/NamedAttrMap.cpp:
        (WebCore::NamedAttrMap::addAttribute):
        (WebCore::NamedAttrMap::removeAttribute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Improvements to the wx build script.

http://bugs.webkit.org/show_bug.cgi?id=17492

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Reviewed by Sam.

        - remove use of DeprecatedCString from Windows pasteboard code

        * platform/win/ClipboardUtilitiesWin.cpp:
        (WebCore::createGlobalData): Added an overload for Vector<char>.
        Streamlined the logic a bit.
        (WebCore::append): Added. Helper functions for appending to a
        Vector<char>.
        (WebCore::markupToCF_HTML): Rewrote to use Vector<char> instead
        of DeprecatedCString. Also simplified the logic a bit and used
        macros to handle the integer width.
        (WebCore::urlToMarkup): Use Vector<UChar> instead of String.
        (WebCore::replaceNewlinesWithWindowsStyleNewlines): Tweaked.
        * platform/win/ClipboardUtilitiesWin.h: Update type of return
        value from markupToCF_HTML. Did a bit of streamlining too.
        * platform/win/ClipboardWin.cpp:
        (WebCore::writeURL): Update for above changes.
        (WebCore::ClipboardWin::declareAndWriteDragImage): Ditto.
        (WebCore::ClipboardWin::writeRange): Ditto.
        * platform/win/PasteboardWin.cpp:
        (WebCore::Pasteboard::writeSelection): Ditto.
        (WebCore::Pasteboard::writeURL): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

     Move ResourceLoadDelegate methods to WebFrameLoaderClient

         Changed all methods to use early returns where possible and COMPtr's
         AdoptCOM/Query constructors.

         Reviewed by Anders.

         * WebCoreSupport/WebFrameLoaderClient.cpp:
         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
         (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
         (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge):
         (WebFrameLoaderClient::dispatchWillSendRequest):
         (WebFrameLoaderClient::dispatchDidReceiveResponse):
         (WebFrameLoaderClient::dispatchDidReceiveContentLength):
         (WebFrameLoaderClient::dispatchDidFinishLoading):
         (WebFrameLoaderClient::dispatchDidFailLoading):
         * WebCoreSupport/WebFrameLoaderClient.h:
         * WebFrame.cpp:
         * WebFrame.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

     Move two more methods to WebFrameLoaderClient

         Reviewed by Anders.

         * WebCoreSupport/WebFrameLoaderClient.cpp:
         (kit):
         (WebFrameLoaderClient::dispatchCreatePage): Changed nested ifs to
         early returns, and changed to use the COMPtr Query constructor.
         (WebFrameLoaderClient::dispatchDidLoadMainResource): Added an early
         return, and changed to use getWebDataSource.
         * WebCoreSupport/WebFrameLoaderClient.h:
         * WebFrame.cpp:
         * WebFrame.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

     Get rid of IID_WebFrame

         Reviewed by Anders.

         * WebFrame.cpp: Removed IID_WebFrame definition.
         (WebFrame::QueryInterface): Use __uuidof(WebFrame) instead of
         IID_WebFrame.
         (WebFrame::isDescendantOfFrame): Use COMPtr's Query constructor
         instead of a manual QueryInterface.
         * WebFrame.h: Removed IID_WebFrame declaration, gave WebFrame a
         DECLSPEC_UUID.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

     Move WebHistory-related methods to WebFrameLoaderClient

         Reviewed by Anders.

         * WebCoreSupport/WebFrameLoaderClient.cpp:
         (WebFrameLoaderClient::updateGlobalHistory):
         (WebFrameLoaderClient::shouldGoToHistoryItem):
         (WebFrameLoaderClient::setTitle): Changed some nested ifs into early
         returns.
         (WebFrameLoaderClient::webHistory): Changed to return a COMPtr to
         make the reference management foolproof.
         * WebCoreSupport/WebFrameLoaderClient.h:
         * WebFrame.cpp:
         * WebFrame.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

     Move cache-related methods to WebFrameLoaderClient

         Reviewed by Anders.

         * WebCoreSupport/WebFrameLoaderClient.cpp:
         (getWebDataSource): Moved to the top of the file.
         (WebFrameLoaderClient::savePlatformDataToCachedPage):
         (WebFrameLoaderClient::transitionToCommittedForNewPage):
         (WebFrameLoaderClient::canCachePage):
         * WebCoreSupport/WebFrameLoaderClient.h:
         * WebFrame.cpp:
         * WebFrame.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Reviewed by Adam Roben.

        <rdar://problem/5712777> REGRESSION: Arrow up/down in inspector
        source list does not scroll when item at edge is reached (16572)

        Use scrollIntoViewIfNeeded() instead of the hand-rolled scrollToElement
        we were using in utilities.js.

        * page/inspector/DocumentPanel.js: Use scrollIntoViewIfNeeded instead of scrollToElement.
        * page/inspector/Resource.js: Ditto.
        * page/inspector/inspector.js: Ditto.
        * page/inspector/SourcePanel.js: Use scrollIntoViewIfNeeded instead
        of scrollIntoView, so the source line is centered in the view if needed.
        * page/inspector/utilities.js: Removed scrollToElement().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Add a skipped storage test for now

        * platform/win/Skipped: Added storage/multiple-transactions.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Reviewed by Dan

        http://bugs.webkit.org/show_bug.cgi?id=17485

        Refine our behavior for empty inlines so that they work more correctly with margins/borders/padding.
        Fixes a regression on huffingtonpost.com.

        New tests added to fast/inline

        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::computeLogicalBoxHeights):
        (WebCore::InlineFlowBox::placeBoxesVertically):
        (WebCore::InlineFlowBox::shrinkBoxesWithNoTextChildren):
        * rendering/RenderFlow.cpp:
        (WebCore::RenderFlow::calcMargins):
        * rendering/RenderFlow.h:
        * rendering/RenderObject.h:
        (WebCore::RenderObject::hasHorizontalBordersPaddingOrMargin):
        (WebCore::RenderObject::hasHorizontalBordersOrPadding):
        * rendering/bidi.cpp:
        (WebCore::getBorderPaddingMargin):
        (WebCore::RenderBlock::layoutInlineChildren):
        (WebCore::inlineFlowRequiresLineBox):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

.:

        Reviewed by Darin Adler.

        Add "64" and "64u" make rules to allow easy building of 64-bit versions.

        make 64: will build Intel-only 64-bit.
        make 64u: will build 4-way universal for PPC and Intel.

        * Makefile:
        * Makefile.shared:

WebKitTools:

        Reviewed by Darin Adler.

        * Scripts/build-webkit: Add --universal and --64-bit flags to make building
        64-bit architectures easy. Combine the two flags to build 4-way universal.
        * Makefile: Add "64" and "64u" make rules. Fix the universal rule to return
        non-zero when the build failes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Fix Windows build.

        * platform/text/PlatformString.h:
        (WebCore::reverseFind):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore:

        Reviewed by Darin Adler.

        - fix http://bugs.webkit.org/show_bug.cgi?id=17555
          <rdar://problem/5766016> REGRESSION (r27351): Thumbnails positioned wrong on Getty Images results page

        Test: fast/dynamic/subtree-table-cell-height.html

        * rendering/RenderObject.cpp:
        (WebCore::objectIsRelayoutBoundary): Exclude table cells, since their
        height depends on their contents even if the CSS height property is
        fixed.

LayoutTests:

        Reviewed by Darin Adler.

        - test for http://bugs.webkit.org/show_bug.cgi?id=17555
          <rdar://problem/5766016> REGRESSION (r27351): Thumbnails positioned wrong on Getty Images results page

        * fast/dynamic/subtree-table-cell-height.html: Added.
        * platform/mac/fast/dynamic/subtree-table-cell-height-expected.checksum: Added.
        * platform/mac/fast/dynamic/subtree-table-cell-height-expected.png: Added.
        * platform/mac/fast/dynamic/subtree-table-cell-height-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Reviewed by Darin.

        * Scripts/gdb-safari: Set WEBKIT_UNSET_DYLD_FRAMEWORK_PATH in gdb's environment,
        so that Safari inherits it when launched. Preexisting code in WebKit checks this
        environment variable, and if set, unsets DYLD_FRAMEWORK_PATH, so that applications
        launched by Safari continue to use the standard system WebKit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

JavaScriptCore:

        Reviewed by Dan Bernstein.

        - Add a variant of remove that takes a position and a length.

        * wtf/Vector.h:
        (WTF::Vector::remove):

WebCore:

        Reviewed by Dan Bernstein.

        Make the cleanPath function in CSSStyleSelector more efficient by using
        a Vector<UChar>.

        * css/CSSStyleSelector.cpp:
        (WebCore::cleanPath): Make this function work on a Vector<UChar> instead
        of a String.  Also remove unnecessary reverseFind call that could be acomplished
        with two compares.
        (WebCore::checkPseudoState): Remove reserveCapacity calls now that we are using
        a stack buffer.
        * platform/text/PlatformString.h:
        (WebCore::find): Make this find generic enough that it can be used for
        String::find.
        (WebCore::reverseFind): Implement reverseFind so that it can be used
        for with a UChar* and length.
        * platform/text/StringImpl.cpp:
        (WebCore::StringImpl::find): Use implementation in PlatformString.cpp
        (WebCore::StringImpl::reverseFind): Ditto,

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Reviewed by Darin. Tweaked and landed by Alexey.

        http://bugs.webkit.org/show_bug.cgi?id=17411
        Ideographic comma and full stop should be treated as line-breakable characters

        Test: fast/text/line-breaks-after-ideographic-comma-or-full-stop.html

        * platform/text/CharacterNames.h: Added ideographicComma and ideographicFullStop.
        * rendering/break_lines.cpp: (WebCore::shouldBreakAfter): Added a workaround for an issue in
        Unicode 5.0 that is causing this.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Reviewed by eseidel.  Landed by eseidel

        Fix improperly initialized m_isUpToDate member variable.
        Fixs 50+ layout tests when run on Tiger.
        http://bugs.webkit.org/show_bug.cgi?id=17549

        * platform/network/cf/ResourceResponse.h:
        (WebCore::ResourceResponse::ResourceResponse):
        * platform/network/mac/ResourceResponse.h:
        (WebCore::ResourceResponse::ResourceResponse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore:

        Reviewed by Sam Weinig.

        - fix http://bugs.webkit.org/show_bug.cgi?id=17152
          Paragraphs indented with :first-letter and text-align CSS render incorrectly

        Test: fast/text/apply-start-width-after-skipped-text.html

        * rendering/bidi.cpp:
        (WebCore::RenderBlock::findNextLineBreak): Improved the logic for when
        to figure in the padding, border and margin before a text node when the
        line begins inside a text node.

LayoutTests:

        Reviewed by Sam Weinig.

        - test for http://bugs.webkit.org/show_bug.cgi?id=17152
          Paragraphs indented with :first-letter and text-align CSS render incorrectly

        * fast/text/apply-start-width-after-skipped-text.html: Added.
        * platform/mac/fast/text/apply-start-width-after-skipped-text-expected.checksum: Added.
        * platform/mac/fast/text/apply-start-width-after-skipped-text-expected.png: Added.
        * platform/mac/fast/text/apply-start-width-after-skipped-text-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Windows build fix for wx port.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-02-25  Mark Rowe  <mrowe@apple.com>

        Windows build fix.

        * platform/network/cf/ResourceResponseCFNet.cpp:
        (WebCore::ResourceResponse::platformCompare):  Implement platformCompare for ResourceResponseCFNet.cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore:

        Reviewed by Geoff.

        Fixed for <rdar://problem/5760530> REGRESSION: Assertion failure in
        Document::removePendingSheet() from r30438

        r30438 added a call to CachedResource::error() from inside
        Loader::didReceiveData() if a CSS file 4xxs. There was an
        assumption in the loader, though, that either error() would be
        called, or didFinishLoading() would be called, so some work is
        duplicated in each. Now that we are calling an error() on files
        that will also make it to didFinishLoading() (since they succeeded
        in the network layer), we need to make sure we do not duplicate the
        work. CachedCSSStyleSheet::error() calls checkNotify, which ends up
        decrementing the document's pending style sheet counter.
        checkNotify() was still getting called, though, through the normal
        didFinishLoading code path, and the counter was being decremented
        twice. Bad!

        * loader/loader.cpp:
        (WebCore::Loader::didFinishLoading):
        (WebCore::Loader::didReceiveData):

LayoutTests:

        Reviewed by Geoff.

        Test for <rdar://problem/5760530> REGRESSION: Assertion failure in
        Document::removePendingSheet() from r30438

        * http/tests/misc/missing-style-sheet-expected.txt: Added.
        * http/tests/misc/missing-style-sheet.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Fix the Gtk, wx and Qt builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Fix bug number in ChangeLog.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-02-25  MorganL  <morganl.webkit@yahoo.com>

        Reviewed by Darin Adler.

        Eliminate some #ifdefs from headers in platform/network.
        http://bugs.webkit.org/show_bug.cgi?id=11786

        * WebCore.base.exp:
        * WebCore.order:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * dom/XMLTokenizer.cpp:
        * loader/ResourceLoader.h:
        * platform/network/AuthenticationChallenge.cpp: Removed.
        * platform/network/AuthenticationChallenge.h: Removed.
        * platform/network/AuthenticationChallengeBase.cpp: Copied from platform/network/AuthenticationChallenge.cpp.
        (WebCore::AuthenticationChallengeBase::AuthenticationChallengeBase):
        (WebCore::AuthenticationChallengeBase::previousFailureCount):
        (WebCore::AuthenticationChallengeBase::proposedCredential):
        (WebCore::AuthenticationChallengeBase::protectionSpace):
        (WebCore::AuthenticationChallengeBase::failureResponse):
        (WebCore::AuthenticationChallengeBase::error):
        (WebCore::AuthenticationChallengeBase::isNull):
        (WebCore::AuthenticationChallengeBase::nullify):
        (WebCore::AuthenticationChallengeBase::compare):
        * platform/network/AuthenticationChallengeBase.h: Copied from platform/network/AuthenticationChallenge.h.
        (WebCore::AuthenticationChallengeBase::platformCompare):
        (WebCore::operator==):
        (WebCore::operator!=):
        * platform/network/ResourceError.cpp: Removed.
        * platform/network/ResourceError.h: Removed.
        * platform/network/ResourceErrorBase.cpp: Copied from platform/network/ResourceError.cpp.
        (WebCore::ResourceErrorBase::lazyInit):
        (WebCore::ResourceErrorBase::compare):
        * platform/network/ResourceErrorBase.h: Copied from platform/network/ResourceError.h.
        (WebCore::ResourceErrorBase::isNull):
        (WebCore::ResourceErrorBase::domain):
        (WebCore::ResourceErrorBase::errorCode):
        (WebCore::ResourceErrorBase::failingURL):
        (WebCore::ResourceErrorBase::localizedDescription):
        (WebCore::ResourceErrorBase::ResourceErrorBase):
        (WebCore::ResourceErrorBase::platformLazyInit):
        (WebCore::ResourceErrorBase::platformCompare):
        (WebCore::operator==):
        * platform/network/ResourceResponseBase.cpp:
        (WebCore::ResourceResponseBase::isHTTP):
        (WebCore::ResourceResponseBase::url):
        (WebCore::ResourceResponseBase::setUrl):
        (WebCore::ResourceResponseBase::mimeType):
        (WebCore::ResourceResponseBase::setMimeType):
        (WebCore::ResourceResponseBase::expectedContentLength):
        (WebCore::ResourceResponseBase::setExpectedContentLength):
        (WebCore::ResourceResponseBase::textEncodingName):
        (WebCore::ResourceResponseBase::setTextEncodingName):
        (WebCore::ResourceResponseBase::suggestedFilename):
        (WebCore::ResourceResponseBase::setSuggestedFilename):
        (WebCore::ResourceResponseBase::httpStatusCode):
        (WebCore::ResourceResponseBase::setHTTPStatusCode):
        (WebCore::ResourceResponseBase::httpStatusText):
        (WebCore::ResourceResponseBase::setHTTPStatusText):
        (WebCore::ResourceResponseBase::httpHeaderField):
        (WebCore::ResourceResponseBase::setHTTPHeaderField):
        (WebCore::ResourceResponseBase::httpHeaderFields):
        (WebCore::ResourceResponseBase::isAttachment):
        (WebCore::ResourceResponseBase::setExpirationDate):
        (WebCore::ResourceResponseBase::expirationDate):
        (WebCore::ResourceResponseBase::setLastModifiedDate):
        (WebCore::ResourceResponseBase::lastModifiedDate):
        (WebCore::ResourceResponseBase::lazyInit):
        (WebCore::ResourceResponseBase::compare):
        * platform/network/ResourceResponseBase.h:
        (WebCore::ResourceResponseBase::ResourceResponseBase):
        (WebCore::ResourceResponseBase::platformLazyInit):
        (WebCore::ResourceResponseBase::platformCompare):
        (WebCore::operator==):
        * platform/network/cf/AuthenticationCF.cpp:
        (WebCore::AuthenticationChallenge::AuthenticationChallenge):
        (WebCore::AuthenticationChallenge::platformCompare):
        * platform/network/cf/AuthenticationChallenge.h: Added.
        (WebCore::AuthenticationChallenge::AuthenticationChallenge):
        (WebCore::AuthenticationChallenge::sourceHandle):
        (WebCore::AuthenticationChallenge::cfURLAuthChallengeRef):
        * platform/network/cf/ResourceError.h: Added.
        (WebCore::ResourceError::ResourceError):
        * platform/network/cf/ResourceErrorCF.cpp:
        (WebCore::ResourceError::ResourceError):
        (WebCore::ResourceError::platformLazyInit):
        (WebCore::ResourceError::platformCompare):
        (WebCore::ResourceError::operator CFStreamError):
        * platform/network/cf/ResourceResponse.h:
        (WebCore::ResourceResponse::ResourceResponse):
        * platform/network/cf/ResourceResponseCFNet.cpp:
        (WebCore::ResourceResponse::platformLazyInit):
        * platform/network/curl/AuthenticationChallenge.h: Added.
        (WebCore::AuthenticationChallenge::AuthenticationChallenge):
        * platform/network/curl/ResourceError.h: Added.
        (WebCore::ResourceError::ResourceError):
        * platform/network/curl/ResourceResponse.h:
        (WebCore::ResourceResponse::ResourceResponse):
        * platform/network/mac/AuthenticationChallenge.h: Added.
        (WebCore::AuthenticationChallenge::AuthenticationChallenge):
        (WebCore::AuthenticationChallenge::sender):
        (WebCore::AuthenticationChallenge::nsURLAuthenticationChallenge):
        * platform/network/mac/AuthenticationMac.mm:
        (WebCore::AuthenticationChallenge::AuthenticationChallenge):
        (WebCore::AuthenticationChallenge::platformCompare):
        * platform/network/mac/ResourceError.h: Added.
        (WebCore::ResourceError::ResourceError):
        * platform/network/mac/ResourceErrorMac.mm:
        (WebCore::ResourceError::platformLazyInit):
        (WebCore::ResourceError::platformCompare):
        * platform/network/mac/ResourceResponse.h:
        (WebCore::ResourceResponse::ResourceResponse):
        * platform/network/mac/ResourceResponseMac.mm:
        (WebCore::ResourceResponse::platformLazyInit):
        (WebCore::ResourceResponse::platformCompare):
        * platform/network/qt/AuthenticationChallenge.h: Added.
        (WebCore::AuthenticationChallenge::AuthenticationChallenge):
        * platform/network/qt/ResourceError.h: Added.
        (WebCore::ResourceError::ResourceError):
        * platform/network/qt/ResourceResponse.h:
        (WebCore::ResourceResponse::ResourceResponse):
        * xml/XSLTProcessor.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Fix run-webkit-tests after r30394

        * Scripts/webkitdirs.pm: Never append _debug to FindSafari's
        executable name.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

     Move plugin-related methods to WebFrameLoaderClient

         Reviewed by Anders.

         * WebCoreSupport/WebFrameLoaderClient.cpp:
         (WebFrameLoaderClient::WebFrameLoaderClient):
         (WebFrameLoaderClient::setMainDocumentError):
         (WebFrameLoaderClient::committedLoad): Added some early returns.
         (WebFrameLoaderClient::receivedData):
         (WebFrameLoaderClient::finishedLoading): Ditto.
         (getWebDataSource):
         (WebFrameLoaderClient::createPlugin):
         * WebCoreSupport/WebFrameLoaderClient.h:
         * WebFrame.cpp:
         (WebFrame::WebFramePrivate::WebFramePrivate):
         * WebFrame.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

     Move createFrame to WebFrameLoaderClient

         Reviewed by Anders.

         * WebCoreSupport/WebFrameLoaderClient.cpp:
         (WebFrameLoaderClient::createFrame):
         (WebFrameLoaderClient::loadURLIntoChild):
         * WebCoreSupport/WebFrameLoaderClient.h:
         * WebFrame.cpp:
         * WebFrame.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

     Move progress-related methods to WebFrameLoaderClient

         Reviewed by Anders.

         * WebCoreSupport/WebFrameLoaderClient.cpp:
         (WebFrameLoaderClient::postProgressStartedNotification):
         (WebFrameLoaderClient::postProgressEstimateChangedNotification):
         (WebFrameLoaderClient::postProgressFinishedNotification):
         * WebCoreSupport/WebFrameLoaderClient.h:
         * WebFrame.cpp:
         * WebFrame.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

     Remove WebFrame::detachedFromParent1

         This method was removed from FrameLoaderClient in r19042, but was
         never removed from WebFrame.

         Reviewed by Anders.

         * WebFrame.cpp:
         * WebFrame.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Reviewed by T3h Mitz Pettel (Dan Bernstein)

        Layout test for already fixed bug <rdar://problem/5729445>

        * storage/multiple-transactions-expected.txt: Added.
        * storage/multiple-transactions.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Reviewed by Darin.

        Move remaining render style objects over to start with a refcount of 1 and get
        rid of DeprecatedDataRef.

        * rendering/DataRef.h:
        (WebCore::DataRef::operator*):
        (WebCore::DataRef::operator->):
        * rendering/RenderStyle.h:
        * rendering/SVGRenderStyle.cpp:
        (WebCore::SVGRenderStyle::SVGRenderStyle):
        * rendering/SVGRenderStyle.h:
        (WebCore::SVGRenderStyle::create):
        (WebCore::SVGRenderStyle::copy):
        * rendering/SVGRenderStyleDefs.cpp:
        (StyleFillData::StyleFillData):
        (StyleStrokeData::StyleStrokeData):
        (StyleStopData::StyleStopData):
        (StyleTextData::StyleTextData):
        (StyleClipData::StyleClipData):
        (StyleMaskData::StyleMaskData):
        (StyleMarkerData::StyleMarkerData):
        (StyleMiscData::StyleMiscData):
        * rendering/SVGRenderStyleDefs.h:
        (WebCore::StyleFillData::create):
        (WebCore::StyleFillData::copy):
        (WebCore::StyleStrokeData::create):
        (WebCore::StyleStrokeData::copy):
        (WebCore::StyleStopData::create):
        (WebCore::StyleStopData::copy):
        (WebCore::StyleTextData::create):
        (WebCore::StyleTextData::copy):
        (WebCore::StyleClipData::create):
        (WebCore::StyleClipData::copy):
        (WebCore::StyleMaskData::create):
        (WebCore::StyleMaskData::copy):
        (WebCore::StyleMarkerData::create):
        (WebCore::StyleMarkerData::copy):
        (WebCore::StyleMiscData::create):
        (WebCore::StyleMiscData::copy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-02-25  Mark Mentovai  <mark@moxienet.com>

        Reviewed by Mark Rowe.

        Enable CollectorHeapIntrospector to build by itself, as well as in an AllInOneFile build.
        http://bugs.webkit.org/show_bug.cgi?id=17538

        * kjs/CollectorHeapIntrospector.cpp: Provide "using" declaration for
          WTF::RemoteMemoryReader.
        * kjs/collector.h: Move CollectorHeap declaration here...
        * kjs/collector.cpp: ... from here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Reviewed by Dave Hyatt.

        - remove file-static BidiRun variables from bidi.cpp

        * platform/text/BidiResolver.h:
        (WebCore::BidiResolver::): Initialize m_logicallyLastRun.
        (WebCore::BidiResolver::logicallyLastRun): Added.
        (WebCore::BidiResolver::runCount): Made unsigned.
        (WebCore::::reverseRuns): Changed ints to unsigned.
        (WebCore::::createBidiRunsForLine): Made this function set
        m_logicallyLastRun.
        * rendering/RenderBlock.h:
        * rendering/bidi.cpp:
        (WebCore::BidiState::addRun): Removed setting of sLogicallyLastBidiRun.
        (WebCore::RenderBlock::constructLine): Removed unused start parameter
        and added run count and first and last run parameters. Replaced end
        parameter with lastLine boolean and endObject pointer.
        (WebCore::RenderBlock::computeHorizontalPositionsForLine): Added first
        and logically last run parameters.
        (WebCore::RenderBlock::computeVerticalPositionsForLine): Added firstRun
        parameter.
        (WebCore::RenderBlock::bidiReorderLine): Removed setting of static
        variables.
        (WebCore::RenderBlock::layoutInlineChildren): Changed to use BidiState
        accessors instead of file statics.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30575 268f45cc-cd09-0410-ab3c-d52691b4dbfc