WebKit-https.git
10 years ago[GTK] Show url of history items in a status bar in MiniBrowser
carlosgc@webkit.org [Thu, 3 Nov 2011 17:06:51 +0000 (17:06 +0000)]
[GTK] Show url of history items in a status bar in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=71474

Reviewed by Martin Robinson.

* MiniBrowser/gtk/BrowserWindow.c:
(browserWindowSetStatusText): Set status text and show/hide the
status label.
(resetStatusText): Reset status text when history menu is hidden.
(browserWindowHistoryItemSelected): Show url of currently selected
history item.
(browserWindowCreateBackForwardMenu): Connect to hide signal of
menu to reset the status text.
(browserWindowConstructed): Use GtkOverlay if available to show
status text.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[GTK] Add back/forward menus to MiniBrowser using WebKit2 GTK+ API
carlosgc@webkit.org [Thu, 3 Nov 2011 17:01:42 +0000 (17:01 +0000)]
[GTK] Add back/forward menus to MiniBrowser using WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=71466

Reviewed by Martin Robinson.

* MiniBrowser/gtk/BrowserWindow.c:
(browserWindowHistoryItemActivated): Go to selected back formard
list item using webkit_web_view_go_to_back_forward_list_item()
(browserWindowCreateBackForwardMenu): Create a GtkMenu for the
given GList of WebKitBackForwardListItems.
(browserWindowUpdateNavigationActions): Enable/disable back and
forward buttons depending on whether it's possible to go
back/forward. Create a menu for back and forward toolbar buttons.
(backForwadlistChanged): Call browserWindowUpdateNavigationActions().
(browserWindowConstructed): Connect to WebKitBackForwardList
changed signal.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUse the right function to determine whether NPWindow coordinates should be window...
andersca@apple.com [Thu, 3 Nov 2011 16:54:23 +0000 (16:54 +0000)]
Use the right function to determine whether NPWindow coordinates should be window relative
https://bugs.webkit.org/show_bug.cgi?id=71480

Reviewed by Adam Roben.

We want to use wantsWindowRelativeNPWindowCoordinates here, and not wantsWindowRelativeCoordinates
which is a temporary function that will be removed (and that returns the wrong value!)

* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::geometryDidChange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCSSRuleList: Move rule orphaning from deleteRule() out to callers.
commit-queue@webkit.org [Thu, 3 Nov 2011 16:31:26 +0000 (16:31 +0000)]
CSSRuleList: Move rule orphaning from deleteRule() out to callers.
https://bugs.webkit.org/show_bug.cgi?id=71470

Patch by Andreas Kling <kling@webkit.org> on 2011-11-03
Reviewed by Antti Koivisto.

Rule parenting is the responsibility of the owner rule (the rule containing
the rule list), so move parent clearing out of CSSRuleList::deleteRule() and
into the (two) call sites.

* css/CSSMediaRule.cpp:
(WebCore::CSSMediaRule::deleteRule):
* css/CSSRuleList.cpp:
(WebCore::CSSRuleList::deleteRule):
* css/WebKitCSSKeyframesRule.cpp:
(WebCore::WebKitCSSKeyframesRule::deleteRule):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: do not map scripts generated with document.write to the document resou...
pfeldman@chromium.org [Thu, 3 Nov 2011 16:28:29 +0000 (16:28 +0000)]
Web Inspector: do not map scripts generated with document.write to the document resources.
https://bugs.webkit.org/show_bug.cgi?id=71114

Reviewed by Yury Semikhatsky.

* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype._addScript):
(WebInspector.DebuggerPresentationModel.prototype._bindScriptToRawSourceCode):
(WebInspector.DebuggerPresentationModel.prototype.uiSourceCodes):
(WebInspector.DebuggerPresentationModel.prototype.setFormatSource):
(WebInspector.DebuggerPresentationModel.prototype._consoleCleared):
(WebInspector.DebuggerPresentationModel.prototype._rawSourceCodeForScriptWithURL):
(WebInspector.DebuggerPresentationModel.prototype._rawSourceCodeForScript):
(WebInspector.DebuggerPresentationModel.prototype._scriptForRawSourceCode):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.reset):
* inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode.prototype._createSourceMapping.didRequestContent.didFormatContent):
(WebInspector.RawSourceCode.prototype._createSourceMapping.didRequestContent):
(WebInspector.RawSourceCode.prototype._createSourceMapping):
* inspector/front-end/Script.js:
(WebInspector.Script.prototype.editSource):
(WebInspector.Script.prototype.isInlineScript):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Remove Maemo specific code paths
hausmann@webkit.org [Thu, 3 Nov 2011 16:16:37 +0000 (16:16 +0000)]
[Qt] Remove Maemo specific code paths
https://bugs.webkit.org/show_bug.cgi?id=71476

Reviewed by Kenneth Rohde Christiansen.

.:

* Source/WebKit.pri:

Source/WebCore:

* WebCore.pri:
* features.pri:
* plugins/PluginPackage.cpp:
(WebCore::PluginPackage::determineQuirks):
* plugins/PluginView.cpp:
(WebCore::PluginView::setValue):
* plugins/PluginView.h:
* plugins/qt/PluginViewQt.cpp:
(WebCore::PluginView::updatePluginWidget):
(WebCore::PluginView::paint):
(WebCore::PluginView::platformGetValueStatic):

Source/WebKit/qt:

* Api/qwebpage.cpp:
(QWebPage::userAgentForUrl):
* Api/qwebview.cpp:
(QWebView::QWebView):
* QtWebKit.pro:
* WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::createSelectPopup):
* WebCoreSupport/EditorClientQt.cpp:
(WebCore::EditorClientQt::setInputMethodState):
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::createPlugin):
* WebCoreSupport/QtMaemoWebPopup.cpp: Removed.
* WebCoreSupport/QtMaemoWebPopup.h: Removed.
* tests/qgraphicswebview/tst_qgraphicswebview.cpp:
(tst_QGraphicsWebView::focusInputTypes):
* tests/qwebframe/tst_qwebframe.cpp:
* tests/qwebview/tst_qwebview.cpp:
(tst_QWebView::focusInputTypes):

Tools:

* QtTestBrowser/launcherwindow.cpp:
(LauncherWindow::~LauncherWindow):
(LauncherWindow::init):
(LauncherWindow::showLinkHover):
(LauncherWindow::selectElements):
(LauncherWindow::showFPS):
(LauncherWindow::updateFPS):
* QtTestBrowser/launcherwindow.h:
(WindowOptions::WindowOptions):
* QtTestBrowser/locationedit.cpp:
* QtTestBrowser/locationedit.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[GTK] Show load progress information in MiniBrowser using WebKit2 GTK+ API
carlosgc@webkit.org [Thu, 3 Nov 2011 16:13:49 +0000 (16:13 +0000)]
[GTK] Show load progress information in MiniBrowser using WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=71461

Reviewed by Martin Robinson.

* MiniBrowser/gtk/BrowserWindow.c:
(resetEntryProgress): Reset the entry progress after a while when
load has been completed.
(webViewLoadProgressChanged): Update location entry progress.
(browserWindowConstructed): Connect to WebView
notify::estimated-load-progress signal.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[GTK] Remove WebKit2 C API from MiniBrowser
carlosgc@webkit.org [Thu, 3 Nov 2011 16:10:42 +0000 (16:10 +0000)]
[GTK] Remove WebKit2 C API from MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=71459

Reviewed by Martin Robinson.

Use the GTK+ API instead to add minimum functionality. The other
features will be ported to GTK+ API in following patches.

* MiniBrowser/gtk/BrowserWindow.c:
(activateUriEntryCallback): Use webkit_web_view_load_uri().
(goBackCallback): Use webkit_web_view_go_back().
(goForwardCallback): Use webkit_web_view_go_forward().
(webViewURIChanged): Update location entry with current uri using
webkit_web_view_get_uri().
(browserWindowFinalize):
(browserWindowGetProperty):
(browserWindowSetProperty):
(browser_window_init):
(browserWindowConstructed): Connect to notify::uri signal of
WebView to be notified when the URI changes.
(browser_window_class_init):
(browser_window_new): Use WebKitWebView.
(browser_window_get_view): Use WebKitWebView
* MiniBrowser/gtk/BrowserWindow.h:
* MiniBrowser/gtk/GNUmakefile.am:
* MiniBrowser/gtk/WebBundle/WebBundleMain.c: Removed.
* MiniBrowser/gtk/main.c:
(loadURI): Use webkit_web_view_new().
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed build fix after r99195.
hausmann@webkit.org [Thu, 3 Nov 2011 16:07:22 +0000 (16:07 +0000)]
Unreviewed build fix after r99195.

The right name is restrictMinimumScaleFactorToViewportSize.

* UIProcess/API/qt/qtouchwebview.cpp:
(QTouchWebViewPrivate::updateViewportConstraints):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[GTK] Use WEBKIT_API instead of WK_EXPORT in WebKitEnumTypes.h
carlosgc@webkit.org [Thu, 3 Nov 2011 16:04:49 +0000 (16:04 +0000)]
[GTK] Use WEBKIT_API instead of WK_EXPORT in WebKitEnumTypes.h
https://bugs.webkit.org/show_bug.cgi?id=71457

Reviewed by Martin Robinson.

* GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Bounce back limits are wrong in some situations
kenneth@webkit.org [Thu, 3 Nov 2011 15:40:22 +0000 (15:40 +0000)]
[Qt] Bounce back limits are wrong in some situations
https://bugs.webkit.org/show_bug.cgi?id=71471

Reviewed by Simon Hausmann.

The valid position points were in viewport coordinates, but we were
requiring valid position points in content coordinates.

* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::animateContentIntoBoundariesIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoPatch by Jesus Sanchez-Palencia <jesus@webkit.org> on 2011-11-03
hausmann@webkit.org [Thu, 3 Nov 2011 15:31:38 +0000 (15:31 +0000)]
Patch by Jesus Sanchez-Palencia <jesus@webkit.org> on 2011-11-03
Reviewed by Kenneth Rohde Christiansen.

[Qt] QtWebKit should have documentation clarifying its mobile features usage
https://bugs.webkit.org/show_bug.cgi?id=41465

Add "QtWebKit Goes Mobile" documentation

* docs/qtwebkit-goes-mobile.qdoc: Added.
* docs/qtwebkit.qdoc: Linked to qtwebkit-goes-mobile documentation
* docs/webkitsnippets/qtwebkit_goes_mobile_snippets.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemoving line in computeViewportAttributes that enforces a minimum scale factor to...
fsamuel@chromium.org [Thu, 3 Nov 2011 15:22:16 +0000 (15:22 +0000)]
Removing line in computeViewportAttributes that enforces a minimum scale factor to never allow zooming out more than viewport
https://bugs.webkit.org/show_bug.cgi?id=70609

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Operations in computeViewportAttributes that are not a part of the spec:

http://www.w3.org/TR/2011/WD-css-device-adapt-20110915/#constraining-viewport-property-values

were moved into the functions restrictMinimumScaleFactorToViewportSize and
restrictScaleFactorToInitialScaleIfNotUserScalable.

* WebCore.exp.in:
* dom/ViewportArguments.cpp:
(WebCore::computeViewportAttributes):
(WebCore::restrictMinimumScaleFactorToViewportSize):
(WebCore::restrictScaleFactorToInitialScaleIfNotUserScalable):
* dom/ViewportArguments.h:

Source/WebKit/efl:

* ewk/ewk_view.cpp:
(_ewk_view_viewport_attributes_compute):

Source/WebKit/gtk:

* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::dumpConfigurationForViewport):
* webkit/webkitviewportattributes.cpp:
(webkitViewportAttributesRecompute):

Source/WebKit/qt:

* Api/qwebpage.cpp:
(QWebPage::viewportAttributesForSize):
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::viewportAsText):

Source/WebKit2:

* UIProcess/API/qt/qtouchwebview.cpp:
(QTouchWebViewPrivate::updateViewportConstraints):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::viewportConfigurationAsText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt][WK2] Fix the signal signature of the loadFailed API test.
abecsi@webkit.org [Thu, 3 Nov 2011 15:21:06 +0000 (15:21 +0000)]
[Qt][WK2] Fix the signal signature of the loadFailed API test.

Rubber-stamped by Simon Hausmann.

* UIProcess/API/qt/tests/commonviewtests/webviewabstraction.cpp:
(WebViewAbstraction::touchViewLoadFailed):
(WebViewAbstraction::desktopViewLoadFailed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Unable to start MiniBrowser after run-webkit-tests
hausmann@webkit.org [Thu, 3 Nov 2011 15:05:21 +0000 (15:05 +0000)]
[Qt] Unable to start MiniBrowser after run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=71469

Reviewed by Csaba Osztrogonác.

* Scripts/run-launcher: Pass @ARGV instead of @args, which is stripped
from things like -2. Neither Gtk or Qt MiniBrowser like unknown command
line arguments.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Fix an assertion under WebPage::setViewportSize.
jocelyn.turcotte@nokia.com [Thu, 3 Nov 2011 14:49:43 +0000 (14:49 +0000)]
[Qt] Fix an assertion under WebPage::setViewportSize.
https://bugs.webkit.org/show_bug.cgi?id=71473

Reviewed by Simon Hausmann.

The web view can have an empty size and it causes the assert in computeViewportAttributes.
Don't notify the web page of such a size change in this case.

* UIProcess/API/qt/qtouchwebview.cpp:
(QTouchWebViewPrivate::updateViewportSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed expectations update.
caseq@chromium.org [Thu, 3 Nov 2011 14:44:40 +0000 (14:44 +0000)]
Unreviewed expectations update.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed build fix, sigh.
andreas.kling@nokia.com [Thu, 3 Nov 2011 14:42:28 +0000 (14:42 +0000)]
Unreviewed build fix, sigh.

* css/CSSFontFaceRule.h:
* css/CSSMutableStyleDeclaration.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, skipping 3 new svg tests presenting pixel differences
philn@webkit.org [Thu, 3 Nov 2011 14:39:11 +0000 (14:39 +0000)]
Unreviewed, skipping 3 new svg tests presenting pixel differences
between the 32-bits and 64-bits bots.

* platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[WK2] State variable name refactor in WebPageProxy.cpp
commit-queue@webkit.org [Thu, 3 Nov 2011 14:32:17 +0000 (14:32 +0000)]
[WK2] State variable name refactor in WebPageProxy.cpp
https://bugs.webkit.org/show_bug.cgi?id=71467

Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2011-11-03
Reviewed by Andreas Kling.

Renaming m_inDecidePolicyForMIMEType to m_inDecidePolicyForResponse after
https://bugs.webkit.org/show_bug.cgi?id=55827 .

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::receivedPolicyDecision):
(WebKit::WebPageProxy::decidePolicyForResponse):
* UIProcess/WebPageProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed build fix, out-of-line StyleSheet::parentStyleSheet()
andreas.kling@nokia.com [Thu, 3 Nov 2011 14:27:18 +0000 (14:27 +0000)]
Unreviewed build fix, out-of-line StyleSheet::parentStyleSheet()
again since there's a cycle in the includes between CSSRule/StyleSheet.

* css/StyleSheet.cpp:
(WebCore::StyleSheet::parentStyleSheet):
* css/StyleSheet.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed build fix after r99185, removing forward-declaration
andreas.kling@nokia.com [Thu, 3 Nov 2011 14:12:34 +0000 (14:12 +0000)]
Unreviewed build fix after r99185, removing forward-declaration
of CSSRule since CSSRule.h is already included.

* css/StyleSheet.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCSSOM: Inline some trivial methods.
andreas.kling@nokia.com [Thu, 3 Nov 2011 14:01:40 +0000 (14:01 +0000)]
CSSOM: Inline some trivial methods.
https://bugs.webkit.org/show_bug.cgi?id=71468

Reviewed by Antti Koivisto.

* css/CSSFontFaceRule.cpp:
* css/CSSFontFaceRule.h:
(WebCore::CSSFontFaceRule::setDeclaration):
* css/CSSStyleRule.cpp:
* css/CSSStyleRule.h:
(WebCore::CSSStyleRule::setDeclaration):
* css/CSSStyleSheet.cpp:
* css/CSSStyleSheet.h:
(WebCore::CSSStyleSheet::ownerRule):
* css/StyleSheet.cpp:
* css/StyleSheet.h:
(WebCore::StyleSheet::parentStyleSheet):
* css/WebKitCSSKeyframesRule.cpp:
* css/WebKitCSSKeyframesRule.h:
(WebCore::WebKitCSSKeyframesRule::name):
(WebCore::WebKitCSSKeyframesRule::length):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDevirtualize MediaList.
andreas.kling@nokia.com [Thu, 3 Nov 2011 13:53:45 +0000 (13:53 +0000)]
Devirtualize MediaList.
https://bugs.webkit.org/show_bug.cgi?id=71464

Reviewed by Antti Koivisto.

* css/MediaList.h: Make the destructor non-virtual.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoOptimizing arithmetic composite filter to ARM-neon SIMD instruction set
zherczeg@webkit.org [Thu, 3 Nov 2011 13:48:11 +0000 (13:48 +0000)]
Optimizing arithmetic composite filter to ARM-neon SIMD instruction set
https://bugs.webkit.org/show_bug.cgi?id=65522

Reviewed by Dirk Schulze.

This patch continues the work of Felician Marton.

The arithmetic operation of feComposite SVG filter can be greatly enhanced
by the ARM-NEON instruction set since we are able to calculate the pixel data
for all four RGBA channels at the same time.

It won't affect the general behavior and existing tests will cover the changes.

* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* platform/graphics/filters/FEComposite.cpp:
(WebCore::computeArithmeticPixels):
(WebCore::arithmeticSoftware):
(WebCore::FEComposite::platformArithmeticSoftware):
(WebCore::FEComposite::platformApplySoftware):
* platform/graphics/filters/FEComposite.h:
* platform/graphics/filters/arm/FECompositeArithmeticNEON.cpp: Added.
* platform/graphics/filters/arm/FECompositeArithmeticNEON.h: Added.
(WebCore::FEComposite::platformArithmeticNeon):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Add pageScaleFactor to the serialized history item
hausmann@webkit.org [Thu, 3 Nov 2011 13:40:03 +0000 (13:40 +0000)]
[Qt] Add pageScaleFactor to the serialized history item
https://bugs.webkit.org/show_bug.cgi?id=71463

Reviewed by Tor Arne Vestbø.

r75758 added the pageScaleFactor member, which we need to
serialize.

* history/qt/HistoryItemQt.cpp:
(WebCore::HistoryItem::restoreState):
(WebCore::HistoryItem::saveState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUse createPrimitiveNumericValue function
mikelawther@chromium.org [Thu, 3 Nov 2011 13:33:57 +0000 (13:33 +0000)]
Use createPrimitiveNumericValue function
https://bugs.webkit.org/show_bug.cgi?id=71432

Reviewed by Andreas Kling.

No new tests - no change in functionality.

* css/CSSParser.cpp:
(WebCore::CSSParser::parseWrapShapeRect):
(WebCore::CSSParser::parseWrapShapeCircle):
(WebCore::CSSParser::parseWrapShapeEllipse):
(WebCore::CSSParser::parseWrapShapePolygon):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, skip
philn@webkit.org [Thu, 3 Nov 2011 13:28:20 +0000 (13:28 +0000)]
Unreviewed, skip
http/tests/security/xssAuditor/script-tag-with-callbacks.html on
GTK, relying on an unimplemented feature.

* platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[GTK][WEBKIT2] Add support for title property in WebKitWebView.
commit-queue@webkit.org [Thu, 3 Nov 2011 13:26:39 +0000 (13:26 +0000)]
[GTK][WEBKIT2] Add support for title property in WebKitWebView.
https://bugs.webkit.org/show_bug.cgi?id=68074

Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-11-03
Reviewed by Philippe Normand.

Support for 'title' property is added in WebKitWebView.
Functions to get the value of this property is provided.

* UIProcess/API/gtk/WebKitWebLoaderClient.cpp:
(didReceiveTitleForFrame): LoaderClient titleRecieve callback.
(webkitWebLoaderClientAttachLoaderClientToPage): Register didReceiveTitleForFrame callback.
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewGetProperty): 'title' property get function.
(webkit_web_view_class_init): Register new property.
(webkitWebViewSetTitle): Notify WebKitWebView about title receive.
(webkit_web_view_get_title): API to get main frame title.
* UIProcess/API/gtk/WebKitWebView.h: webkit_web_view_get_title API expose.
* UIProcess/API/gtk/WebKitWebViewPrivate.h: Added private API.
* UIProcess/API/gtk/tests/TestWebKitWebLoaderClient.cpp:
(testWebViewTitle): Test webkit_web_view_get_title API.
(beforeAll): Add testWebViewTitle test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt][WK2] Download support and API in UIProcess
commit-queue@webkit.org [Thu, 3 Nov 2011 13:05:25 +0000 (13:05 +0000)]
[Qt][WK2] Download support and API in UIProcess
https://bugs.webkit.org/show_bug.cgi?id=68962

Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2011-11-03
Reviewed by Simon Hausmann.

Source/WebKit/qt:

Registering new qml type QWebDownloadItem.

* declarative/plugin.cpp:
(WebKitQmlPlugin::registerTypes):

Source/WebKit2:

We implement our WkContextDownloadClient and the needed callbacks.
We also add APIs by exposing QWebDownloadItem. Objects from this type
have their ownership handled by QDesktopWebView and will be created or
destroyed as needed. Classes implementing ViewInterface (QDesktopWebViewPrivate
and TouchViewInterface) will receive a signal (downloadRequested) with a pointer
to the recently created QWebDownloadItem. With that they can connect the proper
signals and slots, set the download destination path and then call start().
Objects of this type will provide the progress of a download, a slot to cancel it,
and signals for getting finished or failure status.
QWebDownloadItem was also exposed in QML.
Qt needed an asynchronous way for UIProcess to return a destination path to WebProcess,
therefore the startTransfer API was added to WebKit2's Download handlers.

* Shared/qt/WebCoreArgumentCodersQt.cpp:
(CoreIPC::::encode):
(CoreIPC::::decode):
Add encoding and decoding of suggestedFilename for ResourceResponse.

* UIProcess/API/qt/WKView.h:
* UIProcess/API/qt/qbasewebview.h: Add signal downloadRequested.
* UIProcess/API/qt/qdesktopwebview.cpp:
(QDesktopWebViewPrivate::downloadRequested):
* UIProcess/API/qt/qdesktopwebview_p.h:

* UIProcess/API/qt/qwebdownloaditem.cpp: Added.
(QWebDownloadItemPrivate::QWebDownloadItemPrivate):
(QWebDownloadItem::QWebDownloadItem):
(QWebDownloadItem::~QWebDownloadItem):
(QWebDownloadItem::url):
(QWebDownloadItem::destinationPath):
(QWebDownloadItem::setDestinationPath):
(QWebDownloadItem::suggestedFilename):
(QWebDownloadItem::mimeType):
(QWebDownloadItem::expectedContentLength):
(QWebDownloadItem::totalBytesReceived):
(QWebDownloadItem::cancel):
(QWebDownloadItem::start):
* UIProcess/API/qt/qwebdownloaditem.h: Added.
* UIProcess/API/qt/qwebdownloaditem_p.h: Added.
(QWebDownloadItemPrivate::didReceiveResponse):

* UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_download.qml: Added.
* UIProcess/API/qt/tests/qmltests/common/download.html: Added.
* UIProcess/API/qt/tests/qmltests/common/download.zip: Added.
* UIProcess/API/qt/tests/qmltests/qmltests.pro:

* UIProcess/Downloads/DownloadProxy.cpp:
(WebKit::DownloadProxy::startTransfer): Qt only function added.
* UIProcess/Downloads/DownloadProxy.h:

* UIProcess/PageClient.h: Added Qt specific function to call handleDownloadRequest from QtWebPageProxy.

* UIProcess/WebContext.cpp:
(WebKit::WebContext::download):
Using WebPageProxy::handleDownloadRequest to bootstrap a download through PageClient.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::receivedPolicyDecision):
Using handleDownloadRequest() to bootstrap a download through PageClient.
(WebKit::WebPageProxy::handleDownloadRequest): Calls PageClient::handleDownloadRequest().
* UIProcess/WebPageProxy.h:

* UIProcess/qt/QtDownloadManager.cpp: Added.
(WebKit::toQtDownloadManager):
(WebKit::qt_wk_didReceiveResponse):
(WebKit::qt_wk_didCreateDestination):
(WebKit::qt_wk_didFinishDownload):
(WebKit::qt_wk_didFailDownload):
(WebKit::qt_wk_didReceiveDataForDownload):
(QtDownloadManager::downloadReceivedResponse): Will reach QtWebPageProxy::didReceiveDownloadResponse.
(QtDownloadManager::downloadCreatedDestination):
(QtDownloadManager::downloadFinished):
(QtDownloadManager::downloadFailed):
(QtDownloadManager::downloadDataReceived):
* UIProcess/qt/QtDownloadManager.h: Added.
Bootstrap our WKContextDownloadClient and set its callbacks.
This entity will also handle all downloads and keep a map of them.
It will be kept alive together with the WebContext as a static member
of QtWebPageProxy, so we can keep it across several WebPages and, therefore,
WebViews.

* UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::defaultWKContext):
(QtWebPageProxy::~QtWebPageProxy):
(QtWebPageProxy::handleDownloadRequest):
(QtWebPageProxy::didReceiveDownloadResponse):
* UIProcess/qt/QtWebPageProxy.h:
From now on it will keep a static QtDownloadManager to live together
with the default WebContext. It implements PageClient::handleDownloadRequest.
QtWebPageProxy::didReceiveDownloadResponse will emit the view's signal downloadRequested.

       * UIProcess/qt/QtTouchViewInterface.h:
(WebKit::QtTouchViewInterface::downloadRequested):
* UIProcess/qt/QtViewInterface.h:

* UIProcess/qt/qweberror.cpp:
(QWebError::description):
* UIProcess/qt/qweberror.h:
(QWebError::errorCodeAsDownloadError):
Add Download error handling to QWebError and a new API
to retrieve the error description from the original ResourceError.
Also, it now has QWebDownloadItem::DownloadError errorCodeAsDownloadError()
that returns the error code as a DownloadError.

* WebKit2.pro:
* WebKit2API.pri:

* WebProcess/Downloads/Download.h:
* WebProcess/Downloads/DownloadManager.cpp:
(WebKit::DownloadManager::startTransfer):
* WebProcess/Downloads/DownloadManager.h:
Adding Qt specific startTransfer function.

* WebProcess/Downloads/qt/DownloadQt.cpp:
(WebKit::Download::start):
(WebKit::Download::startWithHandle):
(WebKit::Download::didDecideDestination):
(WebKit::Download::startTransfer):
* WebProcess/Downloads/qt/QtFileDownloader.cpp:
(WebKit::QtFileDownloader::init): start() was renamed to init().
(WebKit::QtFileDownloader::determineFilename):
Calling onReadyRead() here was unnecessary and it was triggering the overall
download process even before DownloadManager finished startDownload(). This
was leading to a DownloadManager with an empty list of downloads.
(WebKit::QtFileDownloader::startTransfer): decidedDestination() became startTransfer().
(WebKit::QtFileDownloader::abortDownloadWritingAndEmitError):
(WebKit::QtFileDownloader::handleDownloadResponse):
(WebKit::QtFileDownloader::onReadyRead):
(WebKit::QtFileDownloader::onFinished):
(WebKit::QtFileDownloader::cancel):
* WebProcess/Downloads/qt/QtFileDownloader.h:

* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::startTransfer):
* WebProcess/WebProcess.h:
* WebProcess/WebProcess.messages.in:
Adding Qt specific message StartTransfer and handling function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-11-03 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 3 Nov 2011 13:04:12 +0000 (13:04 +0000)]
2011-11-03  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: fixing win build. step2.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd webkit_web_view_load_html and webkit_web_view_load_plain_text APIs.
commit-queue@webkit.org [Thu, 3 Nov 2011 12:52:48 +0000 (12:52 +0000)]
Add webkit_web_view_load_html and webkit_web_view_load_plain_text APIs.
https://bugs.webkit.org/show_bug.cgi?id=69249

Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-11-03
Reviewed by Philippe Normand.

This patch adds support for 2 more load APIs, namely
webkit_web_view_load_html and webkit_web_view_load_plain_text.

* UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_load_html): New API to load html string.
(webkit_web_view_load_plain_text): New API to load plain text.
* UIProcess/API/gtk/WebKitWebView.h: Public API addition.
* UIProcess/API/gtk/tests/TestWebKitWebLoaderClient.cpp:
(testLoadHtml): Test webkit_web_view_load_html API.
(testLoadPlainText): Test webkit_web_view_load_plain_text API.
(beforeAll): Add new tests.
* UIProcess/API/gtk/tests/WebViewTest.cpp:
(WebViewTest::loadHtml): Test webkit_web_view_load_html API.
(WebViewTest::loadPlainText): Test webkit_web_view_load_plain_text API.
* UIProcess/API/gtk/tests/WebViewTest.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-11-03 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Thu, 3 Nov 2011 12:49:15 +0000 (12:49 +0000)]
2011-11-03  Pavel Feldman  <pfeldman@google.com>

        Not reviewed: win build fix. Assign autoDPI at all cases (breakage introduced in r99173).

        * dom/ViewportArguments.cpp:
        (WebCore::computeViewportAttributes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-11-03 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 3 Nov 2011 12:33:57 +0000 (12:33 +0000)]
2011-11-03  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: fix windows build, step1

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDifferentiate implicit viewport from that of the meta tag
kenneth@webkit.org [Thu, 3 Nov 2011 12:21:27 +0000 (12:21 +0000)]
Differentiate implicit viewport from that of the meta tag
https://bugs.webkit.org/show_bug.cgi?id=71453

Reviewed by Simon Hausmann.

This is needed because of DPI adjustment taking place with the meta
tag. This is to be avoided when no viewport meta tag is present.

* dom/Document.cpp:
(WebCore::Document::processViewport):
* dom/ViewportArguments.cpp:
(WebCore::computeViewportAttributes):
* dom/ViewportArguments.h:
(WebCore::ViewportArguments::ViewportArguments):
(WebCore::ViewportArguments::operator==):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99173 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Another batch of expectations clean-up.
caseq@chromium.org [Thu, 3 Nov 2011 12:16:02 +0000 (12:16 +0000)]
Unreviewed. Another batch of expectations clean-up.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDevirtualize CSSRule.
andreas.kling@nokia.com [Thu, 3 Nov 2011 12:14:49 +0000 (12:14 +0000)]
Devirtualize CSSRule.
https://bugs.webkit.org/show_bug.cgi?id=71382

Reviewed by Antti Koivisto.

Remove the virtual destructor from CSSRule, and reimplement RefCounted's deref()
to invoke operator delete on the appropriate subclass type.

This removes the CSSRule vtable and shrinks each instance by one CPU word.

* css/CSSCharsetRule.h:
* css/CSSFontFaceRule.h:
* css/CSSMediaRule.h:
* css/CSSPageRule.h:
* css/CSSRegionStyleRule.h:
* css/CSSRule.cpp:
* css/CSSRule.h:
(WebCore::CSSRule::deref):
(WebCore::CSSRule::~CSSRule):
* css/CSSStyleRule.h:
* css/WebKitCSSKeyframeRule.h:

    Devirtualize!

* css/CSSRule.cpp:
(WebCore::CSSRule::destroy):

    Added, invokes operator delete on the right subclass type.

* css/CSSImportRule.cpp:
(WebCore::CSSImportRule::CSSImportRule):
(WebCore::CSSImportRule::~CSSImportRule):
(WebCore::CSSImportRule::requestStyleSheet):
* css/CSSImportRule.h:
(WebCore::CSSImportRule::ImportedStyleSheetClient::ImportedStyleSheetClient):
(WebCore::CSSImportRule::ImportedStyleSheetClient::~ImportedStyleSheetClient):
(WebCore::CSSImportRule::ImportedStyleSheetClient::setCSSStyleSheet):

    Break out the inheritance from CachedStyleSheetClient into a member variable
    that simply redirects the setCSSStyleSheet() callback to the CSSImportRule.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt][WK2] Failing assertion with desktop webview when touch mocking in MinBrowser
hausmann@webkit.org [Thu, 3 Nov 2011 12:09:47 +0000 (12:09 +0000)]
[Qt][WK2] Failing assertion with desktop webview when touch mocking in MinBrowser
https://bugs.webkit.org/show_bug.cgi?id=71452

Reviewed by Andreas Kling.

Don't re-implement touchEvent(), we don't intend to support touch events as we
receive them from the QQuickCanvas at this point.

* UIProcess/API/qt/qdesktopwebview.cpp:
* UIProcess/API/qt/qdesktopwebview.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoIndexedDB: Recycle cursor objects when calling continue()
hans@chromium.org [Thu, 3 Nov 2011 12:03:55 +0000 (12:03 +0000)]
IndexedDB: Recycle cursor objects when calling continue()
https://bugs.webkit.org/show_bug.cgi?id=71115

Reviewed by Darin Fisher.

Source/WebCore:

The IndexedDB spec says that cursors should be recycled when calling
continue(). Let the IDBRequest keep track of which cursor to return
upon success, and have the cursor use a new callback:
onSuccessWithContinuation() to signal that the continue was successful.

When we start using the new callback, the
storage/indexeddb/cursor-inconsistency.html layout test will start
passing.

* storage/IDBCallbacks.h:
* storage/IDBCursorBackendImpl.cpp:
(WebCore::IDBCursorBackendImpl::continueFunctionInternal):
* storage/IDBRequest.cpp:
(WebCore::IDBRequest::IDBRequest):
(WebCore::IDBRequest::setCursor):
(WebCore::IDBRequest::onSuccess):
(WebCore::IDBRequest::onSuccessWithContinuation):
* storage/IDBRequest.h:

Source/WebKit/chromium:

Add the new onSuccessWithContinuation() callback to IDB wrappers.

* public/WebIDBCallbacks.h:
(WebKit::WebIDBCallbacks::onSuccessWithContinuation):
* src/IDBCallbacksProxy.cpp:
(WebKit::IDBCallbacksProxy::onSuccessWithContinuation):
* src/IDBCallbacksProxy.h:
* src/WebIDBCallbacksImpl.cpp:
(WebKit::WebIDBCallbacksImpl::onSuccessWithContinuation):
* src/WebIDBCallbacksImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Unreviewed gardening.
ossy@webkit.org [Thu, 3 Nov 2011 12:03:51 +0000 (12:03 +0000)]
[Qt] Unreviewed gardening.

* platform/qt/Skipped: Skip failing tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: preserve script location for inline handlers.
pfeldman@chromium.org [Thu, 3 Nov 2011 12:02:05 +0000 (12:02 +0000)]
Web Inspector: preserve script location for inline handlers.
https://bugs.webkit.org/show_bug.cgi?id=71367

Source/JavaScriptCore:

Makes SourceCode factories receive TextPosition instead of the line number;
Stores consistent position values in SourceCode and SourceProvider;

Patch by Pavel Feldman <pfeldman@google.com> on 2011-11-03
Reviewed by Yury Semikhatsky.

* API/JSBase.cpp:
(JSEvaluateScript):
(JSCheckScriptSyntax):
* API/JSObjectRef.cpp:
(JSObjectMakeFunction):
* parser/SourceCode.h:
(JSC::makeSource):
* parser/SourceProvider.h:
(JSC::SourceProvider::SourceProvider):
(JSC::SourceProvider::startPosition):
(JSC::UStringSourceProvider::create):
(JSC::UStringSourceProvider::UStringSourceProvider):
* runtime/FunctionConstructor.cpp:
(JSC::constructFunction):
(JSC::constructFunctionSkippingEvalEnabledCheck):
* runtime/FunctionConstructor.h:

Source/WebCore:

Makes eventHandler report position, not line number;

Patch by Pavel Feldman <pfeldman@google.com> on 2011-11-03
Reviewed by Yury Semikhatsky.

* bindings/js/CachedScriptSourceProvider.h:
(WebCore::CachedScriptSourceProvider::CachedScriptSourceProvider):
* bindings/js/JSLazyEventListener.cpp:
(WebCore::JSLazyEventListener::JSLazyEventListener):
(WebCore::JSLazyEventListener::initializeJSFunction):
* bindings/js/JSLazyEventListener.h:
(WebCore::JSLazyEventListener::create):
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::eventHandlerPosition):
* bindings/js/ScriptController.h:
* bindings/js/ScriptEventListener.cpp:
(WebCore::createAttributeEventListener):
* bindings/js/ScriptSourceProvider.h:
(WebCore::ScriptSourceProvider::ScriptSourceProvider):
* bindings/js/StringSourceProvider.h:
(WebCore::StringSourceProvider::create):
(WebCore::StringSourceProvider::StringSourceProvider):
(WebCore::makeSource):

LayoutTests:

Linkifier test reimplemented for simplisity.

Patch by Pavel Feldman <pfeldman@google.com> on 2011-11-03
Reviewed by Yury Semikhatsky.

* inspector/debugger/debugger-scripts-expected.txt:
* inspector/debugger/debugger-scripts.html:
* inspector/debugger/linkifier-expected.txt:
* inspector/debugger/linkifier.html:
* platform/chromium/inspector/debugger/debugger-scripts-expected.txt: Copied from LayoutTests/inspector/debugger/debugger-scripts-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed update of test expectations.
caseq@chromium.org [Thu, 3 Nov 2011 11:52:25 +0000 (11:52 +0000)]
Unreviewed update of test expectations.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] [WK2] MiniBrowser assert in QtWebProccess on startup in debug build.
hausmann@webkit.org [Thu, 3 Nov 2011 11:20:39 +0000 (11:20 +0000)]
[Qt] [WK2] MiniBrowser assert in QtWebProccess on startup in debug build.
https://bugs.webkit.org/show_bug.cgi?id=71196

Reviewed by Kenneth Rohde Christiansen.

Ensure AC is turned off for the desktop view before we launch the process.
This avoids "accidential" enterAc/exitAc calls that cause failing assertions
because we don't really support AC in this setup.

The touch side works the same way, i.e. enable the preference before calling
init().

* UIProcess/qt/QtDesktopWebPageProxy.cpp:
(QtDesktopWebPageProxy::QtDesktopWebPageProxy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: [Styles] Do not check isEditingAnyField in StylesSidebarPane._createNe...
apavlov@chromium.org [Thu, 3 Nov 2011 11:09:55 +0000 (11:09 +0000)]
Web Inspector: [Styles] Do not check isEditingAnyField in StylesSidebarPane._createNewRule
https://bugs.webkit.org/show_bug.cgi?id=71217

Reviewed by Yury Semikhatsky.

* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype.set _createNewRule):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] X11 plugins need to be reworked for Qt5
kbalazs@webkit.org [Thu, 3 Nov 2011 10:37:19 +0000 (10:37 +0000)]
[Qt] X11 plugins need to be reworked for Qt5
https://bugs.webkit.org/show_bug.cgi?id=70023

Reviewed by Simon Hausmann.

Source/WebCore:

Disable X11 plugins with Qt5.
* features.pri:

Source/WebKit2:

Disable X11 plugins.
* config.h:

LayoutTests:

Disable plugin tests with Qt5.
* platform/qt-5.0/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r99138.
commit-queue@webkit.org [Thu, 3 Nov 2011 10:33:35 +0000 (10:33 +0000)]
Unreviewed, rolling out r99138.
http://trac.webkit.org/changeset/99138
https://bugs.webkit.org/show_bug.cgi?id=71455

It made 200+ tests flakey on SL and on Qt (Requested by Ossy
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-03

Source/WebCore:

* html/HTMLIFrameElement.cpp:
(WebCore::parseSandboxAttribute):
(WebCore::HTMLIFrameElement::parseMappedAttribute):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::setOpener):
(WebCore::createWindow):
* loader/FrameLoader.h:
(WebCore::FrameLoader::setForcedSandboxFlags):
* loader/FrameLoaderTypes.h:
* loader/PolicyChecker.cpp:
(WebCore::PolicyChecker::checkNewWindowPolicy):
* page/SecurityOrigin.cpp:
* page/SecurityOrigin.h:
* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::dataChanged):

LayoutTests:

* http/tests/security/popup-allowed-by-sandbox-is-sandboxed-control-expected.txt: Removed.
* http/tests/security/popup-allowed-by-sandbox-is-sandboxed-control.html: Removed.
* http/tests/security/popup-allowed-by-sandbox-is-sandboxed-expected.txt: Removed.
* http/tests/security/popup-allowed-by-sandbox-is-sandboxed.html: Removed.
* http/tests/security/popup-allowed-by-sandbox-when-allowed-expected.txt: Removed.
* http/tests/security/popup-allowed-by-sandbox-when-allowed.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFixed wrong implementation of doubleValue % 2^{64}.
haraken@chromium.org [Thu, 3 Nov 2011 10:23:10 +0000 (10:23 +0000)]
Fixed wrong implementation of doubleValue % 2^{64}.
https://bugs.webkit.org/show_bug.cgi?id=67980

Reviewed by Hajime Morita.

Source/JavaScriptCore:

fast/events/constructors/progress-event-constructor.html was failing
because of the wrong implementation of conversion from an ECMAScript value
to an IDL unsigned long long value (Spec: http://www.w3.org/TR/WebIDL/#es-unsigned-long-long).
In particular, the calculation of doubleValue % 2^{64} was wrong.
This patch implemented it correctly in doubleToInteger() in wtf/MathExtras.h.

* wtf/MathExtras.h:
(doubleToInteger): Implemented the spec correctly.

Source/WebCore:

fast/events/constructors/progress-event-constructor.html was failing
because of the wrong implementation of conversion from an ECMAScript value
to an IDL unsigned long long value (Spec: http://www.w3.org/TR/WebIDL/#es-unsigned-long-long).
In particular, the calculation of doubleValue % 2^{64} was wrong.
This patch implemented it correctly in doubleToInteger() in wtf/MathExtras.h.

* bindings/js/JSDictionary.cpp:
(WebCore::JSDictionary::convertValue): Uses doubleToInteger().
* bindings/v8/OptionsObject.cpp:
(WebCore::OptionsObject::getKeyValue): Ditto.

LayoutTests:

Enabled progress-event-constructor.html on Chromium-Mac.

* fast/events/constructors/progress-event-constructor-expected.txt:
* fast/events/constructors/progress-event-constructor.html: The change from "12345678901234567168" to "12345678901234567890" is not related to this patch. Just to fix typo. The reason for whether "12345678901234567168" or "12345678901234567890" does not matter is that both values are toStringed to the same value "12345678901234567000".
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99161 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, skip fast/css/webkit-mask-crash-table.html crasher on
philn@webkit.org [Thu, 3 Nov 2011 10:21:49 +0000 (10:21 +0000)]
Unreviewed, skip fast/css/webkit-mask-crash-table.html crasher on
GTK.

* platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: Introduce SuggestBox for TextPrompt
apavlov@chromium.org [Thu, 3 Nov 2011 10:08:25 +0000 (10:08 +0000)]
Web Inspector: Introduce SuggestBox for TextPrompt
https://bugs.webkit.org/show_bug.cgi?id=71288

Reviewed by Pavel Feldman.

Drive-by fix for a regression where clicking in the Database query view did not focus the prompt.

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView):
(WebInspector.ConsoleView.prototype.completions):
(WebInspector.ConsoleView.prototype._completions.receivedPropertyNames):
(WebInspector.ConsoleView.prototype._completions):
(WebInspector.ConsoleView.prototype._reportCompletions):
* inspector/front-end/DatabaseQueryView.js:
(WebInspector.DatabaseQueryView):
(WebInspector.DatabaseQueryView.prototype.afterShow):
(WebInspector.DatabaseQueryView.prototype.completions):
(WebInspector.DatabaseQueryView.prototype._selectStart.moveBackIfOutside):
(WebInspector.DatabaseQueryView.prototype._selectStart):
(WebInspector.DatabaseQueryView.prototype._appendViewQueryResult):
(WebInspector.DatabaseQueryView.prototype._appendErrorQueryResult):
(WebInspector.DatabaseQueryView.prototype._appendQueryResult):
* inspector/front-end/ElementsPanel.js:
* inspector/front-end/Popover.js:
(WebInspector.Popover):
(WebInspector.Popover.prototype._positionElement):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertyTreeElement.prototype):
():
* inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt):
(WebInspector.TextPrompt.prototype.setSuggestForceable):
(WebInspector.TextPrompt.prototype._attachInternal):
(WebInspector.TextPrompt.prototype._removeFromElement):
(WebInspector.TextPrompt.prototype.defaultKeyHandler):
(WebInspector.TextPrompt.prototype.onKeyDown):
(WebInspector.TextPrompt.prototype.acceptAutoComplete):
(WebInspector.TextPrompt.prototype.autoCompleteSoon):
(WebInspector.TextPrompt.prototype.complete):
(WebInspector.TextPrompt.prototype._completionsReady):
(WebInspector.TextPrompt.prototype.applySuggestion):
(WebInspector.TextPrompt.prototype.acceptSuggestion):
(WebInspector.TextPrompt.prototype.isSuggestBoxVisible):
(WebInspector.TextPrompt.prototype.moveCaretToEndOfPrompt):
(WebInspector.TextPrompt.prototype.tabKeyPressed):
(WebInspector.TextPrompt.prototype.enterKeyPressed):
(WebInspector.TextPrompt.prototype.upKeyPressed):
(WebInspector.TextPrompt.prototype.downKeyPressed):
(WebInspector.TextPrompt.SuggestBoxConfig):
(WebInspector.TextPromptWithHistory):
(WebInspector.TextPromptWithHistory.prototype.pushHistoryItem):
(WebInspector.TextPromptWithHistory.prototype.defaultKeyHandler):
(WebInspector.TextPrompt.SuggestBox):
(WebInspector.TextPrompt.SuggestBox.prototype.get visible):
(WebInspector.TextPrompt.SuggestBox.prototype.get hasSelection):
(WebInspector.TextPrompt.SuggestBox.prototype._onscrollresize):
(WebInspector.TextPrompt.SuggestBox.prototype._updateBoxPosition):
(WebInspector.TextPrompt.SuggestBox.prototype._onboxmousedown):
(WebInspector.TextPrompt.SuggestBox.prototype.hide):
(WebInspector.TextPrompt.SuggestBox.prototype.removeFromElement):
(WebInspector.TextPrompt.SuggestBox.prototype._applySuggestion):
(WebInspector.TextPrompt.SuggestBox.prototype.acceptSuggestion):
(WebInspector.TextPrompt.SuggestBox.prototype._onNextItem):
(WebInspector.TextPrompt.SuggestBox.prototype._onPreviousItem):
(WebInspector.TextPrompt.SuggestBox.prototype.updateSuggestionsSoon):
(WebInspector.TextPrompt.SuggestBox.prototype.updateSuggestions):
(WebInspector.TextPrompt.SuggestBox.prototype._onItemMouseDown):
(WebInspector.TextPrompt.SuggestBox.prototype._createItemElement):
(WebInspector.TextPrompt.SuggestBox.prototype._updateItems):
(WebInspector.TextPrompt.SuggestBox.prototype._updateSelection):
(WebInspector.TextPrompt.SuggestBox.prototype._completionsReady):
(WebInspector.TextPrompt.SuggestBox.prototype.upKeyPressed):
(WebInspector.TextPrompt.SuggestBox.prototype.downKeyPressed):
(WebInspector.TextPrompt.SuggestBox.prototype.enterKeyPressed):
(WebInspector.TextPrompt.SuggestBox.prototype.tabKeyPressed):
(WebInspector.TextPrompt.SuggestBox.prototype.spaceKeyPressed):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.css:
(.search-view .search-panel):
(#search-results-pane-file-based .search-match .search-match-content):
(.custom-popup-horizontal-scroll ::-webkit-scrollbar, .custom-popup-vertical-scroll ::-webkit-scrollbar):
(.custom-popup-horizontal-scroll ::-webkit-scrollbar-corner, .custom-popup-vertical-scroll ::-webkit-scrollbar-corner):
(.custom-popup-horizontal-scroll ::-webkit-resizer, .custom-popup-vertical-scroll ::-webkit-resizer):
(.custom-popup-horizontal-scroll ::-webkit-scrollbar-button, .custom-popup-vertical-scroll ::-webkit-scrollbar-button):
(.custom-popup-horizontal-scroll ::-webkit-scrollbar:horizontal:corner-present):
(.custom-popup-horizontal-scroll ::-webkit-scrollbar-thumb:horizontal):
(.custom-popup-horizontal-scroll ::-webkit-scrollbar-thumb:horizontal:hover):
(.custom-popup-horizontal-scroll ::-webkit-scrollbar-thumb:horizontal:active):
(.custom-popup-horizontal-scroll ::-webkit-scrollbar-track-piece:horizontal:start):
(.custom-popup-horizontal-scroll ::-webkit-scrollbar-track-piece:horizontal:end):
(.custom-popup-horizontal-scroll ::-webkit-scrollbar-track-piece:horizontal:end:corner-present):
(.custom-popup-horizontal-scroll ::-webkit-scrollbar-track-piece:horizontal:decrement):
(.custom-popup-horizontal-scroll ::-webkit-scrollbar-track-piece:horizontal:increment):
(.custom-popup-vertical-scroll ::-webkit-scrollbar:vertical:corner-present):
(.custom-popup-vertical-scroll ::-webkit-scrollbar-thumb:vertical):
(.custom-popup-vertical-scroll ::-webkit-scrollbar-thumb:vertical:hover):
(.custom-popup-vertical-scroll ::-webkit-scrollbar-thumb:vertical:active):
(.custom-popup-vertical-scroll ::-webkit-scrollbar-track-piece:vertical:start):
(.custom-popup-vertical-scroll ::-webkit-scrollbar-track-piece:vertical:end):
(.custom-popup-vertical-scroll ::-webkit-scrollbar-track-piece:vertical:end:corner-present):
(.custom-popup-vertical-scroll ::-webkit-scrollbar-track-piece:vertical:decrement):
(.custom-popup-vertical-scroll ::-webkit-scrollbar-track-piece:vertical:increment):
* inspector/front-end/popover.css:
(.popover.right-bottom-arrow .arrow):
* inspector/front-end/textPrompt.css: Added.
(.suggest-box):
(.suggest-box.visible):
(.suggest-box .container):
(.suggest-box-content-item):
(.suggest-box-content-item .prefix):
(.suggest-box-content-item.selected):
(.suggest-box-content-item:hover:not(.selected)):
* inspector/front-end/utilities.js:
(setupPrototypeUtilities.Element.prototype.boxInWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[GTK] [WK2] ttf-liberation fonts moved to a new location (in Debian)
philn@webkit.org [Thu, 3 Nov 2011 10:07:56 +0000 (10:07 +0000)]
[GTK] [WK2] ttf-liberation fonts moved to a new location (in Debian)
https://bugs.webkit.org/show_bug.cgi?id=71445

Reviewed by Martin Robinson.

* DumpRenderTree/gtk/DumpRenderTree.cpp:
(initializeFonts): set directoriesDescription only when needed.
* WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
(WTR::inititializeFontConfigSetting): Add the new font path for Debian fonts and
refactored the font files loading code to avoid copy/pastes, ease
maintenance and future font directories additions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSource/WebCore: REGRESSION (r94132): broke fast/loader/location-port.html on GTK
commit-queue@webkit.org [Thu, 3 Nov 2011 10:00:37 +0000 (10:00 +0000)]
Source/WebCore: REGRESSION (r94132): broke fast/loader/location-port.html on GTK
https://bugs.webkit.org/show_bug.cgi?id=67277

Patch by Devdatta Deshpande <webkit.devdatta@gmail.com> on 2011-11-03
Reviewed by Adam Barth.

If port is 0, SoupURI does not have an explicitly specified port. Due
to this port value is ignored in SoupURI. Hence, an extra check is
required to restore the port.

Test: LayoutTests/fast/loader/location-port.html

* platform/network/soup/ResourceRequestSoup.cpp:
(WebCore::ResourceRequest::updateFromSoupMessage):

LayoutTests: REGRESSION (r94132): broke fast/loader/location-port.html on GTK
https://bugs.webkit.org/show_bug.cgi?id=67277

Patch by Devdatta Deshpande <webkit.devdatta@gmail.com> on 2011-11-03
Reviewed by Adam Barth.

Removed LayoutTests/fast/loader/location-port.html from Skipped tests
for GTK

* platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[GTK] Remove GtkLauncher2
carlosgc@webkit.org [Thu, 3 Nov 2011 09:59:32 +0000 (09:59 +0000)]
[GTK] Remove GtkLauncher2
https://bugs.webkit.org/show_bug.cgi?id=71449

Reviewed by Martin Robinson.

GtkLauncher2 is the GtkLauncher code compiled with webkit2. This
made sense when we wanted to implement the exactly same wk1 API
for wk2. Now the code would require an ifdef for most the api, so
it's better to remove GtkLauncher2 and port MiniBrowser to the new
GTK+ API.

* GNUmakefile.am:
* GtkLauncher/main.c:
(notifyProgressCb):
(closeWebViewCb):
(createBrowser):
(addWebSettingsGroupToContext):
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[EFL] Enable the Page Visibility API.
commit-queue@webkit.org [Thu, 3 Nov 2011 09:56:33 +0000 (09:56 +0000)]
[EFL] Enable the Page Visibility API.
https://bugs.webkit.org/show_bug.cgi?id=69127

Patch by Dongwoo Im <dw.im@samsung.com> on 2011-11-03
Reviewed by Adam Barth.

.:

Build system changes to support ENABLE(PAGE_VISIBILITY_API) on EFL port.

* Source/cmake/OptionsEfl.cmake: Add enabled ENABLE_PAGE_VISIBILITY_API definition.
* Source/cmakeconfig.h.cmake: ditto.

Source/WebKit/efl:

Implement methods to enable the Page Visibility API on EFL port.
(http://www.w3.org/TR/page-visibility)

When the visibility status of the page is changed, browser could
inform the status to WebKit using the APIs below.

* ewk/ewk_view.cpp: Add setter/getter functions to query/set page visibility state.
(ewk_view_visibility_state_set): Sets the page visibility status.
(ewk_view_visibility_state_get): Gets the page visibility status.
* ewk/ewk_view.h: Add public prototypes.

LayoutTests:

* platform/efl/Skipped: Unskip all of the test cases of page visibility.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector [chromium]: fix debug front-end zip generation.
pfeldman@chromium.org [Thu, 3 Nov 2011 09:27:11 +0000 (09:27 +0000)]
Web Inspector [chromium]: fix debug front-end zip generation.
https://bugs.webkit.org/show_bug.cgi?id=71376

Reviewed by Yury Semikhatsky.

* WebKit.gyp:
* scripts/generate_devtools_zip.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Cleaned up obsolete suppressions.
caseq@chromium.org [Thu, 3 Nov 2011 09:25:14 +0000 (09:25 +0000)]
Unreviewed. Cleaned up obsolete suppressions.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r99089.
commit-queue@webkit.org [Thu, 3 Nov 2011 09:10:41 +0000 (09:10 +0000)]
Unreviewed, rolling out r99089.
http://trac.webkit.org/changeset/99089
https://bugs.webkit.org/show_bug.cgi?id=71448

@plt postfix for math functions cause crash on Linux 32 (the
symbol is defined but it points to NULL) (Requested by
zherczeg on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-03

* dfg/DFGOperations.cpp:
* jit/JITStubs.cpp:
* jit/ThunkGenerators.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed Qt build fix(es).
hausmann@webkit.org [Thu, 3 Nov 2011 09:07:33 +0000 (09:07 +0000)]
Unreviewed Qt build fix(es).

* UIProcess/qt/QtDesktopWebPageProxy.cpp:
(QtDesktopWebPageProxy::handleDragMoveEvent): Adapt to dragSession API change.
(QtDesktopWebPageProxy::handleDropEvent): Ditto.
* WebProcess/Plugins/Netscape/NetscapePluginNone.cpp:
(WebKit::NetscapePlugin::wantsWindowRelativeNPWindowCoordinates): Implement here
also, for plugin-disabled builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: Allow the toolbar background to be transparent on mac platforms when...
commit-queue@webkit.org [Thu, 3 Nov 2011 09:07:21 +0000 (09:07 +0000)]
Web Inspector: Allow the toolbar background to be transparent on mac platforms when remote
https://bugs.webkit.org/show_bug.cgi?id=71437

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2011-11-03
Reviewed by Yury Semikhatsky.

* inspector/front-end/inspector.css:
(body.detached.platform-mac-snowleopard #toolbar):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99150 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[GTK] Fix build-break on r99143
philn@webkit.org [Thu, 3 Nov 2011 08:54:30 +0000 (08:54 +0000)]
[GTK] Fix build-break on r99143
https://bugs.webkit.org/show_bug.cgi?id=71440

Patch by ChangSeok Oh <shivamidow@gmail.com> on 2011-11-03
Reviewed by Philippe Normand.

dragOperation() should be replaced with dragSession().operation since it was removed.
And didDetectXSSForFrame of WKPageLoaderClient should be relocated.

* UIProcess/API/gtk/WebKitWebLoaderClient.cpp:
(webkitWebLoaderClientAttachLoaderClientToPage):
* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseDragDataReceived):
(webkitWebViewBaseDragMotion):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSource/JavaScriptCore: DFG inlining breaks function.arguments[something] if the argum...
fpizlo@apple.com [Thu, 3 Nov 2011 08:06:42 +0000 (08:06 +0000)]
Source/JavaScriptCore: DFG inlining breaks function.arguments[something] if the argument being
retrieved was subjected to DFG's unboxing optimizations
https://bugs.webkit.org/show_bug.cgi?id=71436

Reviewed by Oliver Hunt.

This makes inlined arguments retrieval use some of the same machinery as
OSR to determine where from, and how, to retrieve a value that the DFG
might have somehow squirreled away while the old JIT would put it in its
obvious location, using an obvious format.

To that end, previously DFG-internal notions such as DataFormat,
VirtualRegister, and ValueRecovery are now in bytecode/ since they are
stored as part of InlineCallFrames.

* bytecode/CodeOrigin.h:
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
* dfg/DFGJITCompiler32_64.cpp:
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
* dfg/DFGNode.h:
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* interpreter/CallFrame.cpp:
(JSC::CallFrame::trueCallerFrame):
* interpreter/CallFrame.h:
(JSC::ExecState::inlineCallFrame):
* interpreter/Register.h:
(JSC::Register::asInlineCallFrame):
(JSC::Register::unboxedInt32):
(JSC::Register::unboxedBoolean):
(JSC::Register::unboxedCell):
* runtime/Arguments.h:
(JSC::Arguments::finishCreationAndCopyRegisters):

LayoutTests: DFG inlining breaks function.arguments[something] if the argument being
retrieved was subjected to DFG's unboxing optimizations
https://bugs.webkit.org/show_bug.cgi?id=71436

Reviewed by Oliver Hunt.

* fast/js/dfg-inline-arguments-int32-expected.txt: Added.
* fast/js/dfg-inline-arguments-int32.html: Added.
* fast/js/script-tests/dfg-inline-arguments-int32.js: Added.
(foo):
(bar):
(baz):
(argsToStr):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[GTK] [DRT] ttf-liberation fonts moved to a new location (in Debian)
philn@webkit.org [Thu, 3 Nov 2011 07:37:34 +0000 (07:37 +0000)]
[GTK] [DRT] ttf-liberation fonts moved to a new location (in Debian)
https://bugs.webkit.org/show_bug.cgi?id=71359

Reviewed by Martin Robinson.

* DumpRenderTree/gtk/DumpRenderTree.cpp:
(initializeFonts): Add the new font path for Debian fonts and
refactored the font files loading code to avoid copy/pastes, ease
maintenance and future font directories additions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Flagging usage of X11 headers under PLAT_ARCH(X11)
mahesh.kulkarni@nokia.com [Thu, 3 Nov 2011 07:36:28 +0000 (07:36 +0000)]
[Qt] Flagging usage of X11 headers under PLAT_ARCH(X11)
https://bugs.webkit.org/show_bug.cgi?id=71409

Reviewed by Simon Hausmann.

Build fix for building qtwebkit with latest qt5 which has removed Qt X11 headers.

* WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, GTK build fix after r99093...
philn@webkit.org [Thu, 3 Nov 2011 07:34:34 +0000 (07:34 +0000)]
Unreviewed, GTK build fix after r99093...

* PluginProcess/PluginControllerProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoValueRecovery should be moved out of the DFG JIT
fpizlo@apple.com [Thu, 3 Nov 2011 06:55:29 +0000 (06:55 +0000)]
ValueRecovery should be moved out of the DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=71439

Reviewed by Oliver Hunt.

* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/DataFormat.h: Added.
(JSC::dataFormatToString):
(JSC::needDataFormatConversion):
(JSC::isJSFormat):
(JSC::isJSInteger):
(JSC::isJSDouble):
(JSC::isJSCell):
(JSC::isJSBoolean):
* bytecode/ValueRecovery.h: Added.
(JSC::ValueRecovery::ValueRecovery):
(JSC::ValueRecovery::alreadyInRegisterFile):
(JSC::ValueRecovery::alreadyInRegisterFileAsUnboxedInt32):
(JSC::ValueRecovery::alreadyInRegisterFileAsUnboxedCell):
(JSC::ValueRecovery::alreadyInRegisterFileAsUnboxedBoolean):
(JSC::ValueRecovery::inGPR):
(JSC::ValueRecovery::inPair):
(JSC::ValueRecovery::inFPR):
(JSC::ValueRecovery::displacedInRegisterFile):
(JSC::ValueRecovery::constant):
(JSC::ValueRecovery::technique):
(JSC::ValueRecovery::isInRegisters):
(JSC::ValueRecovery::gpr):
(JSC::ValueRecovery::tagGPR):
(JSC::ValueRecovery::payloadGPR):
(JSC::ValueRecovery::fpr):
(JSC::ValueRecovery::virtualRegister):
(JSC::ValueRecovery::dump):
* bytecode/VirtualRegister.h: Added.
* dfg/DFGGenerationInfo.h:
(JSC::DFG::GenerationInfo::isJSFormat):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::ValueSource::dump):
* dfg/DFGSpeculativeJIT.h:
* dfg/DFGVariableAccessData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCSP should handle empty URLs as agreed at TPAC
abarth@webkit.org [Thu, 3 Nov 2011 06:46:45 +0000 (06:46 +0000)]
CSP should handle empty URLs as agreed at TPAC
https://bugs.webkit.org/show_bug.cgi?id=71426

Reviewed by Eric Seidel.

Source/WebCore:

It was somewhat unclear how CSP should treat plugins that lacked a URL
because most of the CSP rules are URL-based.  At TPAC, we decided to
treat "empty" URLs as if there were the URL of the document.  That
means you can use plugins with no URL if you've included 'self' in
object-src, but you can also block them by using 'none' as your
object-src.

Tests: http/tests/security/contentSecurityPolicy/object-src-no-url-allowed.html
       http/tests/security/contentSecurityPolicy/object-src-no-url-blocked.html
       http/tests/security/contentSecurityPolicy/object-src-none-allowed.html
       http/tests/security/contentSecurityPolicy/object-src-none-blocked.html

* page/ContentSecurityPolicy.cpp:
(WebCore::CSPDirective::CSPDirective):
(WebCore::CSPDirective::allows):
(WebCore::ContentSecurityPolicy::createCSPDirective):

LayoutTests:

* http/tests/security/contentSecurityPolicy/object-src-no-url-allowed-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/object-src-no-url-allowed.html: Added.
* http/tests/security/contentSecurityPolicy/object-src-no-url-blocked-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/object-src-no-url-blocked.html: Added.
    - Test the allow and block cases for plugins with no URL.
* http/tests/security/contentSecurityPolicy/object-src-none-allowed.html: Added.
* http/tests/security/contentSecurityPolicy/object-src-none-blocked.html: Added.
    - Somehow these tests got deleted from the repository.  This patch just re-adds them.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnerviewed gardening.
caseq@chromium.org [Thu, 3 Nov 2011 06:40:34 +0000 (06:40 +0000)]
Unerviewed gardening.

* platform/chromium-cg-mac-leopard/fast/borders/block-mask-overlay-image-outset-expected.png: Added.
* platform/chromium-cg-mac-leopard/fast/borders/inline-mask-overlay-image-outset-expected.png: Added.
* platform/chromium-cg-mac-leopard/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.png: Added.
* platform/chromium/test_expectations.txt: fixed qualifiers limit-layer-bounds-transformed-overflow.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] [WK] Debug build broken
commit-queue@webkit.org [Thu, 3 Nov 2011 06:33:00 +0000 (06:33 +0000)]
[Qt] [WK] Debug build broken
https://bugs.webkit.org/show_bug.cgi?id=71417

Add WKNumber.h for WKBooleanGetTypeID
Replace WKGetTypeId with WKGetTypeID
Add initialization for didDetectXSSForFrame member in WKBundlePageLoaderClient
instance.

Patch by Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com> on 2011-11-02
Reviewed by Noam Rosenthal.

* WebProcess/qt/QtBuiltinBundle.cpp:
(WebKit::QtBuiltinBundle::handleSetNavigatorQtObjectEnabled):
* WebProcess/qt/QtBuiltinBundlePage.cpp:
(WebKit::QtBuiltinBundlePage::QtBuiltinBundlePage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99141 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMove Mocks into _mock files near their implementations
eric@webkit.org [Thu, 3 Nov 2011 06:16:11 +0000 (06:16 +0000)]
Move Mocks into _mock files near their implementations
https://bugs.webkit.org/show_bug.cgi?id=71425

Reviewed by Adam Barth.

This entire change is splitting mocktool.py into separate _mock.py files
and placing them next to their real implementations.

I also deleted MockPortFactory (since it was wrong) and was just hiding
the fact that the "skipped-ports" command was broken (and has been for a long time).
So I made MockHost use a real PortFactory (passed a MockHost) and changed
the skipped-ports implementation to use modern PortFactory methods.

* Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
* Scripts/webkitpy/common/checkout/checkout_mock.py: Added.
* Scripts/webkitpy/common/checkout/checkout_unittest.py:
* Scripts/webkitpy/common/checkout/deps_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/__init__.py.
* Scripts/webkitpy/common/checkout/scm/scm_mock.py: Added.
* Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
* Scripts/webkitpy/common/config/ports_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/gtk_unittest.py.
* Scripts/webkitpy/common/host.py:
* Scripts/webkitpy/common/host_mock.py: Added.
* Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py: Added.
* Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
* Scripts/webkitpy/common/net/buildbot/buildbot_mock.py: Added.
* Scripts/webkitpy/common/net/credentials_unittest.py:
* Scripts/webkitpy/common/net/failuremap_unittest.py:
* Scripts/webkitpy/common/net/irc/irc_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/__init__.py.
* Scripts/webkitpy/common/net/statusserver_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/gtk_unittest.py.
* Scripts/webkitpy/common/net/statusserver_unittest.py:
* Scripts/webkitpy/common/net/web_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/gtk_unittest.py.
* Scripts/webkitpy/common/system/executive.py:
* Scripts/webkitpy/common/system/executive_mock.py:
* Scripts/webkitpy/common/system/platforminfo_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/__init__.py.
* Scripts/webkitpy/common/system/user_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/gtk_unittest.py.
* Scripts/webkitpy/common/system/workspace_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/__init__.py.
* Scripts/webkitpy/common/system/workspace_unittest.py:
* Scripts/webkitpy/common/watchlist/watchlist_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/__init__.py.
* Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
* Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
* Scripts/webkitpy/layout_tests/port/__init__.py:
* Scripts/webkitpy/layout_tests/port/base_unittest.py:
* Scripts/webkitpy/layout_tests/port/efl_unittest.py:
* Scripts/webkitpy/layout_tests/port/factory.py:
* Scripts/webkitpy/layout_tests/port/factory_unittest.py:
* Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
* Scripts/webkitpy/layout_tests/port/http_lock_unittest.py:
* Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
* Scripts/webkitpy/layout_tests/port/mac_unittest.py:
* Scripts/webkitpy/layout_tests/port/port_testcase.py:
* Scripts/webkitpy/layout_tests/port/qt_unittest.py:
* Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
* Scripts/webkitpy/layout_tests/port/win_unittest.py:
* Scripts/webkitpy/test/main.py:
* Scripts/webkitpy/tool/bot/botinfo_unittest.py:
* Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
* Scripts/webkitpy/tool/bot/irc_command_unittest.py:
* Scripts/webkitpy/tool/commands/queries_unittest.py:
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
* Scripts/webkitpy/tool/mocktool.py:
* Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMove NSRange / DOMRange conversion functions to WebFramePrivate
commit-queue@webkit.org [Thu, 3 Nov 2011 05:28:16 +0000 (05:28 +0000)]
Move NSRange / DOMRange conversion functions to WebFramePrivate
https://bugs.webkit.org/show_bug.cgi?id=71435

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2011-11-02
Reviewed by Sam Weinig.

Move conversion functions to WebFramePrivate,
and remove the no longer used versions.

* WebView/WebFrame.mm:
(-[WebFrame _convertNSRangeToDOMRange:]):
(-[WebFrame _convertDOMRangeToNSRange:]):
* WebView/WebFrameInternal.h:
* WebView/WebFramePrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoImplement allow-popups for iframe@sandbox
abarth@webkit.org [Thu, 3 Nov 2011 04:39:32 +0000 (04:39 +0000)]
Implement allow-popups for iframe@sandbox
https://bugs.webkit.org/show_bug.cgi?id=66505

Reviewed by Eric Seidel.

Source/WebCore:

There's been some discussion in the HTML working group about adding an
allow-popups directive to the iframe sandbox.  Microsoft has added it
to IE10 platform preview and is fairly adamant about this feature
because it's needed by one or their products that's planning to use
iframe sandbox.  Hixie says he'll add it to the spec once we implement
it, so here's our implementation.  (See discussion in the W3C linked in
the bug for more details.)

Tests: http/tests/security/popup-allowed-by-sandbox-is-sandboxed-control.html
       http/tests/security/popup-allowed-by-sandbox-is-sandboxed.html
       http/tests/security/popup-allowed-by-sandbox-when-allowed.html

* html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::parseMappedAttribute):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::setOpener):
(WebCore::createWindow):
* loader/FrameLoader.h:
(WebCore::FrameLoader::forceSandboxFlags):
* loader/FrameLoaderTypes.h:
* loader/PolicyChecker.cpp:
(WebCore::PolicyChecker::checkNewWindowPolicy):
* page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::parseSandboxPolicy):
* page/SecurityOrigin.h:
(WebCore::SecurityOrigin::sandboxFlags):
* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::dataChanged):

LayoutTests:

Test that the allow-popups directive works as expected.  Note:
no-popup-from-sandbox.html verifies that we still block popups without
the directive.

* http/tests/security/popup-allowed-by-sandbox-is-sandboxed-control-expected.txt: Added.
* http/tests/security/popup-allowed-by-sandbox-is-sandboxed-control.html: Added.
* http/tests/security/popup-allowed-by-sandbox-is-sandboxed-expected.txt: Added.
* http/tests/security/popup-allowed-by-sandbox-is-sandboxed.html: Added.
* http/tests/security/popup-allowed-by-sandbox-when-allowed-expected.txt: Added.
* http/tests/security/popup-allowed-by-sandbox-when-allowed.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove the ability to generate custom lookupGetter/lookupSetter functions,
weinig@apple.com [Thu, 3 Nov 2011 04:21:21 +0000 (04:21 +0000)]
Remove the ability to generate custom lookupGetter/lookupSetter functions,
now that they can not be overridden

Reviewed by Adam Roben.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSource/JavaScriptCore: Object.getOwnPropertyDescriptor() does not retrieve the getter...
weinig@apple.com [Thu, 3 Nov 2011 04:17:54 +0000 (04:17 +0000)]
Source/JavaScriptCore: Object.getOwnPropertyDescriptor() does not retrieve the getter/setter from a property on the window that has been overridden with a getter/setter
https://bugs.webkit.org/show_bug.cgi?id=71333

Reviewed by Gavin Barraclough.

Tested by fast/dom/getter-on-window-object2.html

* runtime/PropertyDescriptor.cpp:
(JSC::PropertyDescriptor::setDescriptor):
The attributes returned from Structure::get do not include Getter or Setter, so
instead check if the value is a GetterSetter like we do elsewhere. If it is, update
the descriptor's attributes accordingly.

LayoutTests: Object.getOwnPropertyDescriptor() does not retrieve the getter/setter from a property on the window that has been overridden with a getter/setter/
https://bugs.webkit.org/show_bug.cgi?id=71333

Reviewed by Gavin Barraclough.

* fast/dom/getter-on-window-object2-expected.txt:
Update for now correct results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix crashing tests after r99126 (commit for https://bugs.webkit.org/show_bug.cgi...
weinig@apple.com [Thu, 3 Nov 2011 03:33:38 +0000 (03:33 +0000)]
Fix crashing tests after r99126 (commit for https://bugs.webkit.org/show_bug.cgi?id=71307)

Reviewed by Adam Roben.

* bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::getOwnPropertyNames):
Since we are proxying to the window, we need to pass it as the this object,
not the shell.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFixed the build and removed another copy to ColorBits.ttf.
mitz@apple.com [Thu, 3 Nov 2011 03:13:48 +0000 (03:13 +0000)]
Fixed the build and removed another copy to ColorBits.ttf.

* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
* WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
* WebKitTestRunner/fonts/ColorBits.ttf: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFunctionPtr should accept FASTCALL functions on X86
commit-queue@webkit.org [Thu, 3 Nov 2011 03:13:27 +0000 (03:13 +0000)]
FunctionPtr should accept FASTCALL functions on X86
https://bugs.webkit.org/show_bug.cgi?id=71434

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-11-02
Reviewed by Filip Pizlo.

On X86 we sometimes use FASTCALL convention functions, for example the
cti functions, and we may need the pointers to such functions, e.g.,
in current DFG register file check and arity check, though long term
we may avoid such usage of cti calls in DFG.

* assembler/MacroAssemblerCodeRef.h:
(JSC::FunctionPtr::FunctionPtr):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoInlined uses of the global object should use the right global object
fpizlo@apple.com [Thu, 3 Nov 2011 02:58:37 +0000 (02:58 +0000)]
Inlined uses of the global object should use the right global object
https://bugs.webkit.org/show_bug.cgi?id=71427

Reviewed by Oliver Hunt.

* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::globalObjectFor):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd new StorageInfo test to the respective skip lists.
arv@chromium.org [Thu, 3 Nov 2011 02:19:17 +0000 (02:19 +0000)]
Add new StorageInfo test to the respective skip lists.

Unreviewed.

* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
* platform/wincairo/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove LegacyDefaultOptionalArguments flag from storage IDL files
arv@chromium.org [Thu, 3 Nov 2011 01:56:09 +0000 (01:56 +0000)]
Remove LegacyDefaultOptionalArguments flag from storage IDL files
https://bugs.webkit.org/show_bug.cgi?id=65744

Reviewed by Adam Barth.

Source/WebCore:

Test: storage/domstorage/localstorage/missing-arguments.html

* storage/DatabaseCallback.idl:
* storage/IDBRequest.idl:
* storage/IDBTransaction.idl:
* storage/SQLResultSetRowList.idl:
* storage/SQLStatementCallback.idl:
* storage/SQLStatementErrorCallback.idl:
* storage/SQLTransaction.idl:
* storage/SQLTransactionCallback.idl:
* storage/SQLTransactionErrorCallback.idl:
* storage/SQLTransactionSync.idl:
* storage/SQLTransactionSyncCallback.idl:
* storage/Storage.idl:
* storage/StorageInfo.idl:
* storage/StorageInfoErrorCallback.idl:
* storage/StorageInfoQuotaCallback.idl:
* storage/StorageInfoUsageCallback.idl:

LayoutTests:

* storage/domstorage/localstorage/missing-arguments-expected.txt: Added.
* storage/domstorage/localstorage/missing-arguments.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove some unnecessary loads/stores in DFG JIT 32_64
commit-queue@webkit.org [Thu, 3 Nov 2011 01:53:07 +0000 (01:53 +0000)]
Remove some unnecessary loads/stores in DFG JIT 32_64
https://bugs.webkit.org/show_bug.cgi?id=71090

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-11-02
Reviewed by Filip Pizlo.

In fillSpeculateCell and OSR exit, some unnecessary loads/stores can
be eliminated.

* dfg/DFGJITCompiler32_64.cpp:
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoReplace usage of StringImpl with String where possible in CharacterData and Text
adamk@chromium.org [Thu, 3 Nov 2011 01:28:58 +0000 (01:28 +0000)]
Replace usage of StringImpl with String where possible in CharacterData and Text
https://bugs.webkit.org/show_bug.cgi?id=71383

Reviewed by Darin Adler.

Source/JavaScriptCore:

* wtf/text/WTFString.h:
(WTF::String::containsOnlyWhitespace): Added new method.

Source/WebCore:

Ryosuke Niwa, in http://webkit.org/b/70862, asked me to replace usages
of String with StringImpl. I've done more than what he asked in this
patch, the biggest change being that CharacterData now holds a String
instead of a RefPtr<StringImpl>.

No new tests, as this should have no effect on behavior.

* dom/CharacterData.cpp:
(WebCore::CharacterData::setData):
(WebCore::CharacterData::substringData):
(WebCore::CharacterData::parserAppendData):
(WebCore::CharacterData::appendData):
(WebCore::CharacterData::insertData):
(WebCore::CharacterData::deleteData):
(WebCore::CharacterData::replaceData):
(WebCore::CharacterData::containsOnlyWhitespace):
(WebCore::CharacterData::setDataAndUpdate):
(WebCore::CharacterData::updateRenderer):
(WebCore::CharacterData::dispatchModifiedEvent):
* dom/CharacterData.h:
(WebCore::CharacterData::length):
(WebCore::CharacterData::dataImpl):
(WebCore::CharacterData::CharacterData):
(WebCore::CharacterData::setDataWithoutUpdate):
* dom/Text.cpp:
(WebCore::Text::splitText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSION (r98759-r98773): platform/mac/fonts/color-bitmap.html failing on Lion...
mitz@apple.com [Thu, 3 Nov 2011 00:55:00 +0000 (00:55 +0000)]
REGRESSION (r98759-r98773): platform/mac/fonts/color-bitmap.html failing on Lion Intel Debug (Tests)
https://bugs.webkit.org/show_bug.cgi?id=71424

Reviewed by Sam Weinig.

Tools:

Removed the ColorBits font and the code to register it in the process
running the tests. The font was only used by the aforementioned test,
which is now being removed.

* DumpRenderTree/fonts/ColorBits-A.png: Removed.
* DumpRenderTree/fonts/ColorBits.ttf: Removed.
* DumpRenderTree/mac/DumpRenderTree.mm:
(allowedFontFamilySet):
(activateTestingFonts):
* WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
(WTR::inititializeFontConfigSetting):
* WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
(WTR::allowedFontFamilySet):
(WTR::activateFonts):

LayoutTests:

Removed this test and its results, because it was relying on a feature
that is no longer present in any OS X version. The color bitmap font
rendering code is now covered by another test.

* platform/mac/fonts/color-bitmap-expected.png: Removed.
* platform/mac/fonts/color-bitmap-expected.txt: Removed.
* platform/mac/fonts/color-bitmap.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDe-virtualize JSObject::getOwnPropertyNames
mhahnenberg@apple.com [Thu, 3 Nov 2011 00:25:45 +0000 (00:25 +0000)]
De-virtualize JSObject::getOwnPropertyNames
https://bugs.webkit.org/show_bug.cgi?id=71307

Reviewed by Darin Adler.

Source/JavaScriptCore:

Added getOwnPropertyNames to the MethodTable, changed all the virtual
implementations of getOwnPropertyNames to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

* API/JSCallbackObject.h:
* API/JSCallbackObjectFunctions.h:
(JSC::::getOwnPropertyNames):
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::getOwnPropertyNames):
* debugger/DebuggerActivation.h:
* runtime/Arguments.cpp:
(JSC::Arguments::getOwnPropertyNames):
* runtime/Arguments.h:
* runtime/ClassInfo.h:
* runtime/JSActivation.cpp:
(JSC::JSActivation::getOwnPropertyNames):
* runtime/JSActivation.h:
* runtime/JSArray.cpp:
(JSC::JSArray::getOwnPropertyNames):
* runtime/JSArray.h:
* runtime/JSByteArray.cpp:
(JSC::JSByteArray::getOwnPropertyNames):
* runtime/JSByteArray.h:
* runtime/JSCell.cpp:
(JSC::JSCell::getOwnPropertyNames):
* runtime/JSCell.h:
* runtime/JSFunction.cpp:
(JSC::JSFunction::getOwnPropertyNames):
* runtime/JSFunction.h:
* runtime/JSNotAnObject.cpp:
(JSC::JSNotAnObject::getOwnPropertyNames):
* runtime/JSNotAnObject.h:
* runtime/JSONObject.cpp:
(JSC::Stringifier::Holder::appendNextProperty):
(JSC::Walker::walk):
* runtime/JSObject.cpp:
(JSC::JSObject::getPropertyNames):
(JSC::JSObject::getOwnPropertyNames):
* runtime/JSObject.h:
* runtime/JSVariableObject.cpp:
(JSC::JSVariableObject::~JSVariableObject):
(JSC::JSVariableObject::getOwnPropertyNames):
* runtime/JSVariableObject.h:
* runtime/ObjectConstructor.cpp:
(JSC::objectConstructorGetOwnPropertyNames):
(JSC::objectConstructorKeys):
(JSC::defineProperties):
* runtime/RegExpMatchesArray.h:
(JSC::RegExpMatchesArray::getOwnPropertyNames):
* runtime/StringObject.cpp:
(JSC::StringObject::getOwnPropertyNames):
* runtime/StringObject.h:
* runtime/Structure.h:

Source/JavaScriptGlue:

Added getOwnPropertyNames to the MethodTable, changed all the virtual
implementations of getOwnPropertyNames to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

* UserObjectImp.cpp:
(UserObjectImp::getOwnPropertyNames):
* UserObjectImp.h:

Source/WebCore:

No new tests.

Added getOwnPropertyNames to the MethodTable, changed all the virtual
implementations of getOwnPropertyNames to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

* WebCore.exp.in:
* bindings/js/JSDOMStringMapCustom.cpp:
(WebCore::JSDOMStringMap::getOwnPropertyNames):
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::getOwnPropertyNames):
* bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::getOwnPropertyNames):
* bindings/js/JSDOMWindowShell.h:
* bindings/js/JSHistoryCustom.cpp:
(WebCore::JSHistory::getOwnPropertyNames):
* bindings/js/JSLocationCustom.cpp:
(WebCore::JSLocation::getOwnPropertyNames):
* bindings/js/JSStorageCustom.cpp:
(WebCore::JSStorage::getOwnPropertyNames):
* bindings/js/ScriptValue.cpp:
(WebCore::jsToInspectorValue):
* bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneSerializer::serialize):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtRuntimeMetaMethod::getOwnPropertyNames):
(JSC::Bindings::QtRuntimeConnectionMethod::getOwnPropertyNames):
* bridge/qt/qt_runtime.h:
* bridge/runtime_array.cpp:
(JSC::RuntimeArray::getOwnPropertyNames):
* bridge/runtime_array.h:
* bridge/runtime_object.cpp:
(JSC::Bindings::RuntimeObject::getOwnPropertyNames):
* bridge/runtime_object.h:

Source/WebKit2:

Added getOwnPropertyNames to the MethodTable, changed all the virtual
implementations of getOwnPropertyNames to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

* WebProcess/Plugins/Netscape/JSNPObject.cpp:
(WebKit::JSNPObject::getOwnPropertyNames):
* WebProcess/Plugins/Netscape/JSNPObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSION (r97496-r97499): 6 fast/workers tests failing on SnowLeopard Intel Release...
simon.fraser@apple.com [Thu, 3 Nov 2011 00:16:26 +0000 (00:16 +0000)]
REGRESSION (r97496-r97499): 6 fast/workers tests failing on SnowLeopard Intel Release (Tests)
https://bugs.webkit.org/show_bug.cgi?id=70619

Skip some failing worker tests.

* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix an intermittent hang in RenderedImageFromDOMRange.
mitz@apple.com [Thu, 3 Nov 2011 00:12:03 +0000 (00:12 +0000)]
Fix an intermittent hang in RenderedImageFromDOMRange.

Reviewed by Anders Carlsson.

* TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
(TestWebKitAPI::Util::run): Made the call to -runMode:beforeDate: return
immediately if there are no sources by passing a date in the distant past.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd git-add-reviewer
aroben@apple.com [Thu, 3 Nov 2011 00:02:03 +0000 (00:02 +0000)]
Add git-add-reviewer

I've been using this script for a while to add reviewers to git commits in my local
repository before pushing them to the Subversion repository. Basic usage is:

git-add-reviewer HEAD^ "Joe Schmoe"
or
git-add-reviewer -i trunk

Fixes <http://webkit.org/b/71419> Would like an easy way to add reviewer names to existing
git commits

Reviewed by Sam Weinig.

* Scripts/git-add-reviewer: Added.
(top level): Parse options, check that the working tree is clean, then run in either
interactive or non-interactive mode as appropriate.
(interactive): Write out a temp file that contains each commit with "NOBODY" next to it and
open it in the user's editor. The user can replace "NOBODY" with reviewer names. When the
editor exits, we check out the commit just before the earliest one we're modifying. Then
for each commit, we check it out, update the reviewer, and amend the commit to contain the
new reviewer. Finally, we update the branch that was originally checked out to point to the
last amended commit.
(nonInteractive): Check out the commit to modify, write the current commit message to the
MERGE_MSG file so addReviewer will update it, add the reviewer to the ChangeLog(s), amend
the commit, and rebase the original branch on top of the amended commit. (usage): Print out
a usage message and exit.
(requireCleanWorkTree): Do the same steps git-rebase does to ensure that the working tree
and index are clean.
(fail): Print out the specified error message, if any, and return false. This function is
used as a return value in various error cases throughout the script.
(cherryPick): Cherry-pick the specified commit and return 1 if we succeeded.
(addReviewer): Add the specified reviewer to all the ChangeLogs modified in this commit, and
to .git/MERGE_MSG, which will be used as the commit message for the next commit.
(commit): Call git-commit and use .git/MERGE_MSG as the commit message.

(addReviewerToChangeLog):
(addReviewerToCommitMessage):
These just call through to addReviewerToFile.

(addReviewerToFile): Read in the file, replacing any "NOBODY" text with the reviewer name(s)
and replacing "Reviewed" with "Rubber-stamped" if specified. Write the resulting text to a
temp file, then move the temp file over the original file and stage it for the next commit.
(head): Returns the name of the currently-checked-out branch.
(isAncestor): Returns true if the first commit is an ancestor of the second.
(toCommit): Converts a commitish to a commit ID using git-rev-parse.
(changeLogsForCommit): Returns a list of all the ChangeLogs modified in the given commit.
(resetToCommit): Checks out the given commit, throwing away any local changes.
(writeCommitMessageToFile): Gets the commit message for the current commit and writes it to
the specified file.
(rebaseOntoHead): Rebases the specified branch onto HEAD.
(checkout): Checks out the given commit.
(getConfigValue): Reads the specified config variable from git-config.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDon't call NPP_SetWindow if the plug-in size or clip rect hasn't changed if the plug...
andersca@apple.com [Wed, 2 Nov 2011 23:57:03 +0000 (23:57 +0000)]
Don't call NPP_SetWindow if the plug-in size or clip rect hasn't changed if the plug-in isn't using window relative coordinates
https://bugs.webkit.org/show_bug.cgi?id=71418

Reviewed by Adam Roben.

This avoids calling into the plug-in when only the plug-in position relative to the window changes.

* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::geometryDidChange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix syntax error.
jonlee@apple.com [Wed, 2 Nov 2011 23:43:11 +0000 (23:43 +0000)]
Fix syntax error.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::performDragControllerAction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoforce inline flexitems to be wrapped in anonymous blocks
tony@chromium.org [Wed, 2 Nov 2011 23:30:28 +0000 (23:30 +0000)]
force inline flexitems to be wrapped in anonymous blocks
https://bugs.webkit.org/show_bug.cgi?id=71314

Reviewed by Ojan Vafai.

Source/WebCore:

If there is a mix of inline and block items, all the inline items were already getting wrapped
(see RenderBlock::addChildIgnoringAnonymousColumnBlocks).  However, if there are only inline items,
we need to force them into an anonymous block.

There are still lots of bugs because we're trying to read style values from the anonymous block,
but this at least causes layout to be called on all the render objects.

Tests: css3/flexbox/anonymous-block.html

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::TreeOrderIterator::next):
(WebCore::RenderFlexibleBox::FlexOrderIterator::next):
(WebCore::RenderFlexibleBox::RenderFlexibleBox): force children into blocks

LayoutTests:

* css3/flexbox/anonymous-block-expected.html: Added.
* css3/flexbox/anonymous-block.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix build error from r99108.
jonlee@apple.com [Wed, 2 Nov 2011 23:22:54 +0000 (23:22 +0000)]
Fix build error from r99108.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::performDragControllerAction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd ENABLE_CSS_SHADERS flag
dino@apple.com [Wed, 2 Nov 2011 23:17:47 +0000 (23:17 +0000)]
Add ENABLE_CSS_SHADERS flag
https://bugs.webkit.org/show_bug.cgi?id=71394

Reviewed by Sam Weinig.

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:

Tools:

* Scripts/build-webkit:

WebKitLibraries:

* win/tools/vsprops/FeatureDefines.vsprops:
* win/tools/vsprops/FeatureDefinesCairo.vsprops:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAllow the various plug-in ports to decide whether NPWindow coordinates should be...
andersca@apple.com [Wed, 2 Nov 2011 23:14:27 +0000 (23:14 +0000)]
Allow the various plug-in ports to decide whether NPWindow coordinates should be window-relative
https://bugs.webkit.org/show_bug.cgi?id=71415

Reviewed by Darin Adler.

* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::callSetWindow):
Remove the PLUGIN_ARCHITECTURE(X11) ifdef and set the NPWindow members
based on the return value of wantsWindowRelativeNPWindowCoordinates.

* WebProcess/Plugins/Netscape/NetscapePlugin.h:
* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::NetscapePlugin::wantsWindowRelativeNPWindowCoordinates):
* WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
(WebKit::NetscapePlugin::wantsWindowRelativeNPWindowCoordinates):
* WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
(WebKit::NetscapePlugin::wantsWindowRelativeNPWindowCoordinates):
Add platform specific implementations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] [WK] Debug build broken after r99065
commit-queue@webkit.org [Wed, 2 Nov 2011 23:02:51 +0000 (23:02 +0000)]
[Qt] [WK] Debug build broken after r99065
https://bugs.webkit.org/show_bug.cgi?id=71397

Remove reference to panGestureActive becuase it is not defined anywhere.

Patch by Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com> on 2011-11-02
Reviewed by Simon Hausmann.

* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::panGestureStarted):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove references to non existing file; js-test-post-function.js
arv@chromium.org [Wed, 2 Nov 2011 23:00:53 +0000 (23:00 +0000)]
Remove references to non existing file; js-test-post-function.js
https://bugs.webkit.org/show_bug.cgi?id=71398

Reviewed by Ojan Vafai.

This js file no longer exists and the code it defined is now in js-test-pre.js.

* fast/events/touch/gesture/gesture-scroll.html:
* storage/indexeddb/factory-deletedatabase-interactions.html:
* storage/indexeddb/factory-deletedatabase.html:
* storage/indexeddb/open-during-transaction.html:
* storage/indexeddb/version-change-abort-expected.txt:
* storage/indexeddb/version-change-abort.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSwitch RenderText to new layout types
eae@chromium.org [Wed, 2 Nov 2011 22:53:39 +0000 (22:53 +0000)]
Switch RenderText to new layout types
https://bugs.webkit.org/show_bug.cgi?id=71389

Reviewed by Eric Seidel.

Switch RenderText methods (and overriden methods in related classes) to
LayoutRect/LayoutUnit.

No new tests.

* rendering/RenderText.cpp:
(WebCore::RenderText::absoluteRectsForRange):
(WebCore::RenderText::linesBoundingBox):
(WebCore::RenderText::linesVisualOverflowBoundingBox):
* rendering/RenderText.h:
Change RenderText to expose its bounding box, selection and caret rects
as LayoutRects.

* rendering/svg/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::localCaretRect):
* rendering/svg/RenderSVGInlineText.h:
Change localCaretRect to return a LayoutRect.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdate dragging info on mac when user is dragging files into view
jonlee@apple.com [Wed, 2 Nov 2011 22:47:28 +0000 (22:47 +0000)]
Update dragging info on mac when user is dragging files into view
https://bugs.webkit.org/show_bug.cgi?id=71325
<rdar://problem/10379193>

Reviewed by Darin Adler.

* UIProcess/API/mac/WKView.mm:
(-[WKView draggingUpdated:]): Based on the DragSession, we update NSDraggingInfo
to update the badge and dragging formation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoLand chromium baselines for tests added in r94912.
tony@chromium.org [Wed, 2 Nov 2011 22:44:07 +0000 (22:44 +0000)]
Land chromium baselines for tests added in r94912.

* fast/borders/border-image-outset-split-inline-vertical-lr-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/border-image-outset-split-inline-vertical-lr-expected.txt.
* fast/borders/inline-mask-overlay-image-outset-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/inline-mask-overlay-image-outset-expected.txt.
* fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.txt.
* platform/chromium-cg-mac-snowleopard/fast/borders/block-mask-overlay-image-outset-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/borders/border-image-outset-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/borders/border-image-outset-in-shorthand-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/borders/inline-mask-overlay-image-outset-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.png: Added.
* platform/chromium-linux/fast/borders/block-mask-overlay-image-outset-expected.png: Added.
* platform/chromium-linux/fast/borders/border-image-outset-expected.png: Added.
* platform/chromium-linux/fast/borders/border-image-outset-in-shorthand-expected.png: Added.
* platform/chromium-linux/fast/borders/inline-mask-overlay-image-outset-expected.png: Added.
* platform/chromium-linux/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.png: Added.
* platform/chromium-mac-leopard/fast/borders/block-mask-overlay-image-outset-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/borders/block-mask-overlay-image-outset-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/borders/border-image-outset-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/borders/border-image-outset-in-shorthand-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/borders/inline-mask-overlay-image-outset-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.png: Added.
* platform/chromium-win/fast/borders/block-mask-overlay-image-outset-expected.png: Added.
* platform/chromium-win/fast/borders/block-mask-overlay-image-outset-expected.txt: Added.
* platform/chromium-win/fast/borders/border-image-outset-expected.png: Added.
* platform/chromium-win/fast/borders/border-image-outset-expected.txt: Added.
* platform/chromium-win/fast/borders/border-image-outset-in-shorthand-expected.png: Added.
* platform/chromium-win/fast/borders/border-image-outset-in-shorthand-expected.txt: Added.
* platform/chromium-win/fast/borders/border-image-outset-split-inline-vertical-lr-expected.png: Added.
* platform/chromium-win/fast/borders/inline-mask-overlay-image-outset-expected.png: Added.
* platform/chromium-win/fast/borders/inline-mask-overlay-image-outset-expected.txt: Added.
* platform/chromium-win/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.png: Added.
* platform/chromium-win/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.txt: Added.
* platform/chromium/fast/borders/border-image-outset-split-inline-vertical-lr-expected.png: Added.
* platform/chromium/test_expectations.txt:
* platform/mac/fast/borders/border-image-outset-split-inline-vertical-lr-expected.txt: Removed.
* platform/mac/fast/borders/inline-mask-overlay-image-outset-expected.txt: Removed.
* platform/mac/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove <track>-related LayoutTests that don't actually work yet.
annacc@chromium.org [Wed, 2 Nov 2011 22:42:19 +0000 (22:42 +0000)]
Remove <track>-related LayoutTests that don't actually work yet.
https://bugs.webkit.org/show_bug.cgi?id=71378

Reviewed by Eric Carlson.

* media/track/track-mutable-expected.txt: Removed.
* media/track/track-mutable.html: Removed.
* media/track/track-text-track-cue-list-expected.txt: Removed.
* media/track/track-text-track-cue-list.html: Removed.
* media/track/track-text-track-expected.txt: Removed.
* media/track/track-text-track.html: Removed.
* media/track/track-webvtt-tc000-empty-expected.txt: Removed.
* media/track/track-webvtt-tc000-empty.html: Removed.
* media/track/track-webvtt-tc001-utf8-expected.txt: Removed.
* media/track/track-webvtt-tc001-utf8.html: Removed.
* media/track/track-webvtt-tc002-bom-expected.txt: Removed.
* media/track/track-webvtt-tc002-bom.html: Removed.
* media/track/track-webvtt-tc003-newlines-expected.txt: Removed.
* media/track/track-webvtt-tc003-newlines.html: Removed.
* media/track/track-webvtt-tc004-magic-header-expected.txt: Removed.
* media/track/track-webvtt-tc004-magic-header.html: Removed.
* media/track/track-webvtt-tc005-header-comment-expected.txt: Removed.
* media/track/track-webvtt-tc005-header-comment.html: Removed.
* media/track/track-webvtt-tc006-cue-identifiers-expected.txt: Removed.
* media/track/track-webvtt-tc006-cue-identifiers.html: Removed.
* media/track/track-webvtt-tc007-cue-no-id-expected.txt: Removed.
* media/track/track-webvtt-tc007-cue-no-id.html: Removed.
* media/track/track-webvtt-tc008-timings-no-hours-expected.txt: Removed.
* media/track/track-webvtt-tc008-timings-no-hours.html: Removed.
* media/track/track-webvtt-tc009-timings-hour-expected.txt: Removed.
* media/track/track-webvtt-tc009-timings-hour.html: Removed.
* media/track/track-webvtt-tc010-no-timings-expected.txt: Removed.
* media/track/track-webvtt-tc010-no-timings.html: Removed.
* media/track/track-webvtt-tc011-blank-lines-expected.txt: Removed.
* media/track/track-webvtt-tc011-blank-lines.html: Removed.
* media/track/track-webvtt-tc012-out-of-order-expected.txt: Removed.
* media/track/track-webvtt-tc012-out-of-order.html: Removed.
* media/track/track-webvtt-tc013-settings-expected.txt: Removed.
* media/track/track-webvtt-tc013-settings.html: Removed.
* media/track/track-webvtt-tc014-alignment-expected.txt: Removed.
* media/track/track-webvtt-tc014-alignment.html: Removed.
* media/track/track-webvtt-tc015-positioning-expected.txt: Removed.
* media/track/track-webvtt-tc015-positioning.html: Removed.
* media/track/track-webvtt-tc016-align-positioning-expected.txt: Removed.
* media/track/track-webvtt-tc016-align-positioning.html: Removed.
* media/track/track-webvtt-tc017-line-position-expected.txt: Removed.
* media/track/track-webvtt-tc017-line-position.html: Removed.
* media/track/track-webvtt-tc018-align-text-line-position-expected.txt: Removed.
* media/track/track-webvtt-tc018-align-text-line-position.html: Removed.
* media/track/track-webvtt-tc019-cue-size-expected.txt: Removed.
* media/track/track-webvtt-tc019-cue-size.html: Removed.
* media/track/track-webvtt-tc020-cue-size-align-expected.txt: Removed.
* media/track/track-webvtt-tc020-cue-size-align.html: Removed.
* media/track/track-webvtt-tc021-valign-expected.txt: Removed.
* media/track/track-webvtt-tc021-valign.html: Removed.
* media/track/track-webvtt-tc022-entities-expected.txt: Removed.
* media/track/track-webvtt-tc022-entities.html: Removed.
* media/track/track-webvtt-tc023-markup-expected.txt: Removed.
* media/track/track-webvtt-tc023-markup.html: Removed.
* media/track/track-webvtt-tc024-timestamp-expected.txt: Removed.
* media/track/track-webvtt-tc024-timestamp.html: Removed.
* media/track/track-webvtt-tc025-class-markup-expected.txt: Removed.
* media/track/track-webvtt-tc025-class-markup.html: Removed.
* media/track/track-webvtt-tc026-voice-expected.txt: Removed.
* media/track/track-webvtt-tc026-voice.html: Removed.
* media/track/track-webvtt-tc027-empty-cue-expected.txt: Removed.
* media/track/track-webvtt-tc027-empty-cue.html: Removed.
* media/track/track-webvtt-tc028-unsupported-markup-expected.txt: Removed.
* media/track/track-webvtt-tc028-unsupported-markup.html: Removed.

* platform/chromium/test_expectations.txt: Remove all, remaining tests currently pass.
* platform/gtk/Skipped: Remove all, remaining tests currently pass.
* platform/mac/Skipped: Make sure all are skipped, <track> not enabled.
* platform/qt/Skipped: Remove all, remaining tests currently pass.
* platform/win/Skipped: Make sure all are skipped, <track> not enabled.
* platform/wk2/Skipped: Remove all, remaining tests currently pass.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoInfinite recursion in RenderSVGResourceContainer::markAllClientsForInvalidation
leviw@chromium.org [Wed, 2 Nov 2011 22:35:16 +0000 (22:35 +0000)]
Infinite recursion in RenderSVGResourceContainer::markAllClientsForInvalidation
https://bugs.webkit.org/show_bug.cgi?id=71384

Reviewed by Darin Adler.

Source/WebCore:

Adding a reentrancy guard to RenderSVGResourceContainer to prevent infinite recursion when
resources reference one another and share ids.

Test: svg/custom/resource-invalidation-crash.svg

* rendering/svg/RenderSVGResourceContainer.cpp:
(WebCore::RenderSVGResourceContainer::RenderSVGResourceContainer):
(WebCore::RenderSVGResourceContainer::markAllClientsForInvalidation):
* rendering/svg/RenderSVGResourceContainer.h:

LayoutTests:

Fixes a stack overflow when SVG resources reference one another and share ids.

* svg/custom/resource-invalidation-crash-expected.png: Added.
* svg/custom/resource-invalidation-crash-expected.txt: Added.
* svg/custom/resource-invalidation-crash.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoExpand DragController to provide more information about the dragging session
jonlee@apple.com [Wed, 2 Nov 2011 22:32:26 +0000 (22:32 +0000)]
Expand DragController to provide more information about the dragging session
https://bugs.webkit.org/show_bug.cgi?id=71324
<rdar://problem/10379175>

Reviewed by Darin Adler.

Source/WebCore:

* WebCore.xcodeproj/project.pbxproj:
* page/DragController.cpp:
(WebCore::DragController::dragEntered):
(WebCore::DragController::dragUpdated):
(WebCore::DragController::dragEnteredOrUpdated):
(WebCore::DragController::tryDocumentDrag): In addition to determining the
drag operation, DragSession is updated with data regarding whether the mouse
is over a file input, and the number of items that would be accepted based on
the mouse's location.
* page/DragController.h:
* page/DragSession.h: Added.
(WebCore::DragSession::DragSession): Keep track of current operation, whether
the mouse is over a file input element, and how many files would be accepted if
dropped.
* platform/DragData.h: Added numberOfFiles()
* platform/chromium/DragDataChromium.cpp:
(WebCore::DragData::numberOfFiles):
* platform/efl/DragDataEfl.cpp:
(WebCore::DragData::numberOfFiles):
* platform/gtk/DragDataGtk.cpp:
(WebCore::DragData::numberOfFiles):
* platform/mac/DragDataMac.mm:
(WebCore::DragData::numberOfFiles):
* platform/qt/DragDataQt.cpp:
(WebCore::DragData::numberOfFiles):
* platform/win/DragDataWin.cpp:
(WebCore::DragData::numberOfFiles):
* platform/wince/DragDataWinCE.cpp:
(WebCore::DragData::numberOfFiles):
* platform/wx/DragDataWx.cpp:
(WebCore::DragData::numberOfFiles):

Source/WebKit/chromium:

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::dragTargetDragEnterOrOver): The drag operation is contained
within the new DragSession struct. Minor refactor.

Source/WebKit/gtk:

* webkit/webkitwebview.cpp:
(webkit_web_view_drag_motion): Minor refactoring.
(webkit_web_view_drag_data_received): Minor refactoring.

Source/WebKit/mac:

* WebView/WebView.mm:
(-[WebView draggingEntered:]): DragOperation is now inside the DragSession struct.
(-[WebView draggingUpdated:]):

Source/WebKit/qt:

* Api/qwebpage.cpp:
(QWebPagePrivate::dragEnterEvent): Minor refactoring because operation is stored in
new DragSession struct.
(QWebPagePrivate::dragMoveEvent): Ditto.

Source/WebKit/win:

* WebView.cpp:
(WebView::DragEnter): Minor refactoring because operation is stored in
new DragSession struct.
(WebView::DragOver): Ditto.

Source/WebKit2:

We now pass the DragSession struct from the Web to the UI process, instead of the
DragOperation enum.

* Scripts/webkit2/messages.py:
* Shared/WebCoreArgumentCoders.cpp:
(CoreIPC::::encode):
(CoreIPC::::decode):
* Shared/WebCoreArgumentCoders.h:
* UIProcess/API/mac/WKView.mm:
(-[WKView draggingUpdated:]):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy): We now cache the last known DragSession state
(WebKit::WebPageProxy::didPerformDragControllerAction):
* UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::dragSession):
(WebKit::WebPageProxy::resetDragOperation):
* UIProcess/WebPageProxy.messages.in:
* UIProcess/win/WebView.cpp:
(WebKit::WebView::keyStateToDragOperation):
(WebKit::WebView::DragEnter):
(WebKit::WebView::DragOver):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::performDragControllerAction):

LayoutTests:

* editing/pasteboard/script-tests/file-input-files-access.js:
(runTest): Change the expected behavior of the test-- dragging a file over a disabled
control should not load that file. Instead, the file should be ignored, and the page
remains as is.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoGet rid of Plugin::deprecatedGeometryDidChange
andersca@apple.com [Wed, 2 Nov 2011 22:26:15 +0000 (22:26 +0000)]
Get rid of Plugin::deprecatedGeometryDidChange
https://bugs.webkit.org/show_bug.cgi?id=71411

Reviewed by Sam Weinig.

Now that all Plugin subclasses implement geometryDidChange and do all the work there
we can get rid of deprecatedGeometryDidChange.

* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
* WebProcess/Plugins/Netscape/NetscapePlugin.h:
* WebProcess/Plugins/PDF/BuiltInPDFView.cpp:
* WebProcess/Plugins/PDF/BuiltInPDFView.h:
* WebProcess/Plugins/Plugin.h:
* WebProcess/Plugins/PluginProxy.cpp:
* WebProcess/Plugins/PluginProxy.h:
* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::viewGeometryDidChange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99107 268f45cc-cd09-0410-ab3c-d52691b4dbfc