eae@chromium.org [Thu, 22 Mar 2012 21:53:05 +0000 (21:53 +0000)]
Unreviewed, add missing include statement for CSSValueList.h.
* css/CSSStyleSelector.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111768
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Thu, 22 Mar 2012 21:45:58 +0000 (21:45 +0000)]
flexbox flexing implementation should match the spec
https://bugs.webkit.org/show_bug.cgi?id=70796
Reviewed by Ojan Vafai.
Source/WebCore:
Match the algorithm in the spec. Handling min/max constraints are slightly improved.
http://dev.w3.org/csswg/css3-flexbox/#resolve-the-flexible-lengths
New test cases in css3/flexbox/flex-algorithm-min-max.html.
* rendering/RenderFlexibleBox.cpp:
(WebCore::adjustFlexSizeForMinAndMax): Step 5 of resolving flexible lengths.
(WebCore):
(WebCore::RenderFlexibleBox::Violation::Violation):
(RenderFlexibleBox::Violation):
(WebCore::RenderFlexibleBox::freezeViolations): Used by step 6.
(WebCore::RenderFlexibleBox::resolveFlexibleLengths):
* rendering/RenderFlexibleBox.h:
LayoutTests:
* css3/flexbox/flex-algorithm-min-max-expected.txt:
* css3/flexbox/flex-algorithm-min-max.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111767
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
robert@webkit.org [Thu, 22 Mar 2012 21:27:33 +0000 (21:27 +0000)]
Make reference result added in r111755 compatible with Qt and GTK ports.
Unreviewed.
* fast/css/heightless-list-item-expected.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111766
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Thu, 22 Mar 2012 21:24:28 +0000 (21:24 +0000)]
new-run-webkit-tests blames the wrong test for crashing
https://bugs.webkit.org/show_bug.cgi?id=81951
Reviewed by Adam Barth.
NRWT wasn't extracting the WebProcess pid correct; should've
used re.search instead of re.match :(. Add more tests!
* Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort._get_crash_log):
* Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitDriver.has_crashed):
(WebKitDriver._check_for_driver_crash):
* Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
(WebKitDriverTest.test_no_timeout):
(WebKitDriverTest):
(WebKitDriverTest.test_check_for_driver_crash):
(WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess):
(WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess.__init__):
(WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess.pid):
(WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess.name):
(WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess.has_crashed):
(WebKitDriverTest.test_check_for_driver_crash.assert_crash):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111765
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eae@chromium.org [Thu, 22 Mar 2012 21:19:08 +0000 (21:19 +0000)]
Unreviewed, add missing import.
* rendering/RenderThemeMac.mm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111764
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 22 Mar 2012 21:14:49 +0000 (21:14 +0000)]
ASSERT(!needsLayout) in RenderView.cpp when visiting panic.com/blog/
https://bugs.webkit.org/show_bug.cgi?id=81953
<rdar://problem/
11086998>
Reviewed by Sam Weinig.
Source/WebCore:
If a page ends up creating CATiledLayers, CA transactions can be committed outside of the normal
CA run loop observer, so we can't call setNeedsDisplay on tile cache layers directly because then
we'll end up calling into painting code before all the layers have been flushed.
Fix this by adding a list of dirty rects to platformCALayerDidCreateTiles and change GraphicsLayerCA to
mark them as dirty. This ensures that any CA transaction commits won't cause newly added layers to be painted.
* platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
(WebCore::LayerClient::platformCALayerDidCreateTiles):
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::platformCALayerDidCreateTiles):
* platform/graphics/ca/GraphicsLayerCA.h:
(GraphicsLayerCA):
* platform/graphics/ca/PlatformCALayerClient.h:
(PlatformCALayerClient):
* platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::setScale):
(WebCore::TileCache::revalidateTiles):
* platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::LayerClient::platformCALayerDidCreateTiles):
Source/WebKit/win:
Update for changes to WebCore.
* FullscreenVideoController.cpp:
(FullscreenVideoController::LayerClient::platformCALayerDidCreateTiles):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111762
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Thu, 22 Mar 2012 21:10:52 +0000 (21:10 +0000)]
Added fast/events/suspend-timers.html to the Mac WebKit2 skipped list, and removed the
failing results checked in as expected results. The results vary across runs.
* platform/mac-wk2/Skipped:
* platform/mac-wk2/fast/events: Removed.
* platform/mac-wk2/fast/events/suspend-timers-expected.txt: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111761
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mifenton@rim.com [Thu, 22 Mar 2012 20:58:15 +0000 (20:58 +0000)]
[BlackBerry] DOMSupport isPositionInNode should have early returns for null nodes
https://bugs.webkit.org/show_bug.cgi?id=81929
Reviewed by Rob Buis.
Make suggested style clean up and move int offset = 0 directly
above is actual usage.
* WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::isPositionInNode):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111757
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 22 Mar 2012 20:51:48 +0000 (20:51 +0000)]
[EFL] [DRT] Implement LayoutTestController::markerTextForListItem()
https://bugs.webkit.org/show_bug.cgi?id=81512
Source/WebKit/efl:
Add missing implementation markerTextForListItem to EFL's
DumpRenderTreeSupport.
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-03-22
Reviewed by Antonio Gomes.
* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::markerTextForListItem):
* WebCoreSupport/DumpRenderTreeSupportEfl.h:
Tools:
Adding missing implementation markerTextForListItem to EFL's
LayoutTestController so that we can unskip related tests from
the skip list.
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-03-22
Reviewed by Antonio Gomes.
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::markerTextForListItem): Implemented.
LayoutTests:
Unskip tests connected with markerTextForListItem().
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-03-22
Reviewed by Antonio Gomes.
* platform/efl/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111756
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
robert@webkit.org [Thu, 22 Mar 2012 20:49:24 +0000 (20:49 +0000)]
Text should overflow when list item height set to 0
https://bugs.webkit.org/show_bug.cgi?id=78726
Reviewed by Julien Chaffraix.
Source/WebCore:
Tests: css2.1/
20110323/height-applies-to-010a-expected.html
fast/css/heightless-list-item-expected.html
fast/css/heightless-list-item.html
* rendering/RenderListItem.cpp:
(WebCore::RenderListItem::paint):
If the list item has height:0, only paint it if the list item allows any block or inline content
to overflow unclipped. The zero-height check is a shortcut to avoid unnecessary painting and
this seems to be the only case where there's something to do.
LayoutTests:
* css2.1/
20110323/height-applies-to-010a-expected.html: Added.
* css2.1/
20110323/height-applies-to-010a.htm: Added.
* fast/css/heightless-list-item-expected.html: Added.
* fast/css/heightless-list-item.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111755
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 22 Mar 2012 20:45:36 +0000 (20:45 +0000)]
HTMLPluginElement is not destroyed on reload or navigation if getNPObject is called
https://bugs.webkit.org/show_bug.cgi?id=80428
Patch by Dave Michael <dmichael@chromium.org> on 2012-03-22
Reviewed by Eric Seidel.
.:
Test: plugins/netscape-dom-access-and-reload.html
* Source/autotools/symbols.filter: Export a symbol for InspectorCounters::counterValue.
Source/WebCore:
Make HTMLPluginElement release its m_NPObject in detach() to break a
reference-counting cycle that happens on reload or navigation. With this
change, HTMLPlugInElement::removedFromDocument is unnecessary, so it
was removed. Note that Releasing m_NPObject does not result in a call to
the plugin; it simply releases a reference count on the wrapper object
for this HTMLPlugInElement. (The plugin's NPP_Deallocate is invoked
when the render tree is destroyed, when PluginView calls
PluginPackage::unload.) Thus, it is safe to release m_NPObject in
detach, because it can not result in layout or style changes.
Also added numberOfLiveNodes() and numberOfLiveDocuments() to
window.internals to enable testing.
Test: plugins/netscape-dom-access-and-reload.html
* WebCore.exp.in:
* html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::detach):
* html/HTMLPlugInElement.h:
(HTMLPlugInElement):
* testing/Internals.cpp:
(WebCore::Internals::numberOfLiveDocuments):
(WebCore::Internals::numberOfLiveNodes):
(WebCore):
* testing/Internals.h:
(Internals):
* testing/Internals.idl:
Source/WebKit2:
Test: plugins/netscape-dom-access-and-reload.html
* win/WebKit2.def: Export a symbol for InspectorCounters::counterValue
* win/WebKit2CFLite.def: Export a symbol for InspectorCounters::counterValue
LayoutTests:
* plugins/netscape-dom-access-and-reload-expected.txt: Added.
* plugins/netscape-dom-access-and-reload.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111754
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 22 Mar 2012 20:43:12 +0000 (20:43 +0000)]
[EFL] Enable view mode media feature layout tests
https://bugs.webkit.org/show_bug.cgi?id=81205
Tools:
Adding missing implementation setViewModeMediaFeature to EFL's
LayoutTestController so that we can unskip view mode
media feature layout tests.
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-03-22
Reviewed by Antonio Gomes.
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::setViewModeMediaFeature): Implemented.
LayoutTests:
Unskip tests connected with setViewModeMediaFeature.
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-03-22
Reviewed by Antonio Gomes.
* platform/efl/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111753
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
shawnsingh@chromium.org [Thu, 22 Mar 2012 20:42:38 +0000 (20:42 +0000)]
[chromium] Make CCDamageTracker robust to empty layer lists
https://bugs.webkit.org/show_bug.cgi?id=81831
Reviewed by Adrienne Walker.
Source/WebCore:
Added a unit test in CCDamageTrackerTest that causes a crash in
the old code. With this patch applied, the crash will not occur.
In theory, that crash should never occur anyway, unless there is a
bug outside the damage tracker, but for robustness it's
appropriate to handle it properly.
In addition to this fix, performed some trivial maintenance on the
damage tracker code.
* platform/graphics/chromium/cc/CCDamageTracker.cpp:
(WebCore::CCDamageTracker::updateDamageTrackingState): removed
unclean code that accessed the targetSurface to get necessary
information. Instead, we now pass those args through the damage
tracker's API.
* platform/graphics/chromium/cc/CCDamageTracker.h:
(CCDamageTracker): modified args passed to damage tracker on update.
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::trackDamageForAllSurfaces):
modified args passed to damage tracker on update.
Source/WebKit/chromium:
* tests/CCDamageTrackerTest.cpp:
(WebKitTests::emulateDrawingOneFrame): modified args passed to damage tracker on update.
(WebKitTests::TEST_F): Added another unit test.
(WebKitTests):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111752
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jchaffraix@webkit.org [Thu, 22 Mar 2012 20:36:34 +0000 (20:36 +0000)]
Enable style sharing for elements with a style attribute
https://bugs.webkit.org/show_bug.cgi?id=81523
Reviewed by Antti Koivisto.
Memory improvement change only.
Overall, this is a performance wash (some benchmarks may regress a bit due to the increase in time taken
by CSSStyleSelector::locateSharedStyle as we try more nodes, others increase their performance due to style sharing).
Instrumenting our style sharing, this should give us some nice memory shavings on some benchmarks:
- HTML5 isn't impacted as it doesn't use much inline style
- page cyclers' intl1 showed a 6% increase in style sharing.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::canShareStyleWithElement):
This method now handles inline style like presentation attributes on the element.
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
(WebCore::CSSStyleSelector::locateSharedStyle):
Don't bail out for an element with an inline style declaration.
(WebCore::CSSStyleSelector::stylesEqual):
Generalized attributeStylesEqual to share the logic between attribute and
inline style property set. This means that attribute checks are actually
doing a little extra more work but that didn't impact our benchmarks.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111751
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Thu, 22 Mar 2012 20:29:22 +0000 (20:29 +0000)]
nrwt: crash while stopping layout test helper on apple mac lion
https://bugs.webkit.org/show_bug.cgi?id=81949
Reviewed by Eric Seidel.
stop_helper() didn't work right if the helper process wasn't
still running or didn't respond properly to being shut down. Fix
this and add some tests. Also add code to MockExecutive() to be
able to mock executive.popen() properly.
* Scripts/webkitpy/common/system/executive_mock.py:
(MockProcess.__init__):
(MockProcess.wait):
(MockExecutive.__init__):
(MockExecutive.popen):
* Scripts/webkitpy/common/system/systemhost_mock.py:
(MockSystemHost.__init__):
* Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort.start_helper):
(MacPort.stop_helper):
* Scripts/webkitpy/layout_tests/port/mac_unittest.py:
(test_get_crash_log):
(test_helper_starts):
(test_helper_fails_to_start):
(test_helper_fails_to_stop):
(test_helper_fails_to_stop.bad_waiter):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111750
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kov@webkit.org [Thu, 22 Mar 2012 20:23:01 +0000 (20:23 +0000)]
[GTK] Add make to the jhbuild moduleset
https://bugs.webkit.org/show_bug.cgi?id=81769
Reviewed by Martin Robinson.
Mostly based on a patch by Carlos Garcia Campos <cgarcia@igalia.com>.
Add GNU make with custom patches to fix several issues:
- make-3.82-arg-list-length.patch: Patch by Ralf Wildenhues to
fix the argument list limit of GNU make when running make
distcheck.
- make-3.82-parallel-build.patch: Patch by Kamil Mierzejewski
and Jeremy Devenport to fix parallel build issues present in
GNU make 3.82
* gtk/jhbuild.modules: Added make with patches.
* gtk/patches/make-3.82-arg-list-length.patch: Added.
* gtk/patches/make-3.82-parallel-build.patch: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111749
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Thu, 22 Mar 2012 20:03:05 +0000 (20:03 +0000)]
Added all tests that failed on the Lion WebKit2 Debug bot in r111739 to the Mac WebKit2
skip list (except those already on the list because they failed on the WebKit2 Releast bot).
Removed fast/events/suspend-timers.html from the list since its failure was addressed in a
later revision.
Rubber-stamped by Geoff Garen.
* platform/mac-wk2/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111748
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Thu, 22 Mar 2012 19:57:46 +0000 (19:57 +0000)]
Added all tests that failed on the Lion WebKit2 Release bot in r111739 to the Mac WebKit2
skip list.
Rubber-stamped by Geoff Garen.
* platform/mac-wk2/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111747
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino@webkit.org [Thu, 22 Mar 2012 19:43:29 +0000 (19:43 +0000)]
[wx] Unreviewed. Adding Source/WTF to the build and updating waf port list.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111746
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino@webkit.org [Thu, 22 Mar 2012 19:37:22 +0000 (19:37 +0000)]
[wx] Unreviewed. WebDOM build fix after array type changes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111745
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Thu, 22 Mar 2012 19:23:02 +0000 (19:23 +0000)]
Initial triage pass of css3/selectors3/html for the Chromium ports.
All changes done to the non-chromium ports were done automatically
by "webkit-patch optimize-baselines".
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111744
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Thu, 22 Mar 2012 19:11:07 +0000 (19:11 +0000)]
Web Inspector: text gutter decorations should move upon edits.
https://bugs.webkit.org/show_bug.cgi?id=81932
Reviewed by Vsevolod Vlasov.
Decorations set by the line number now shift as editing inserts / removes lines.
* inspector/front-end/TextViewer.js:
(WebInspector.TextViewer.prototype._syncLineHeight):
(WebInspector.TextEditorGutterPanel):
(WebInspector.TextEditorGutterPanel.prototype.textChanged):
(WebInspector.TextEditorGutterPanel.prototype.syncClientHeight):
(WebInspector.TextEditorGutterPanel.prototype.addDecoration):
(WebInspector.TextEditorGutterPanel.prototype.removeDecoration):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111743
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
robert@webkit.org [Thu, 22 Mar 2012 19:07:32 +0000 (19:07 +0000)]
CSS 2.1 failure: fixed-table-layout-006 fails
https://bugs.webkit.org/show_bug.cgi?id=78412
Reviewed by Julien Chaffraix.
Source/WebCore:
Tests: css2.1/
20110323/fixed-table-layout-006.htm
fast/css/fixed-table-layout-cell-padding.htm
In fixed tables, positive width specified on a column should include borders and padding.
See the thread at http://lists.w3.org/Archives/Public/www-style/2011Oct/0502.html. The discussion
there resulted in a whole new set of tests for section 17.5.2.1 in the CSS 2.1 spec. See
http://test.csswg.org/harness/test/CSS21_DEV/section/17.5.2.1/. This patch allows WebKit
to pass all of them, and all tests for the 17.5.2.1 section as a whole. I'll land them all separately.
* rendering/FixedTableLayout.cpp:
(WebCore::FixedTableLayout::calcWidthArray): Include border width and cell padding in the width of the column.
Note that borderAndPaddingLogicalWidth() returns the border width for separate and collapsed borders as appropriate.
LayoutTests:
* css2.1/
20110323/fixed-table-layout-006-expected.html: Added.
* css2.1/
20110323/fixed-table-layout-006.htm: Added.
* css2.1/
20110323/fixed-table-layout-013-expected.html: The reference test relied on the broken behaviour we're fixing here.
* fast/css/fixed-table-layout-cell-padding-expected.html: Added.
* fast/css/fixed-table-layout-cell-padding.htm: Added.
* platform/chromium-linux/fast/repaint/scroll-inside-table-cell-expected.png:
* platform/chromium-linux/fast/repaint/scroll-relative-table-inside-table-cell-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug2123-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug2509-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug34176-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug44505-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug44505-expected.txt:
Progression against FF is most evident in this test. The table with the black 'div' cell
content is proportioned the same as mozilla now.
* platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug59252-expected.png:
* platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug7243-expected.png:
* platform/chromium-win/fast/table/cell-pref-width-invalidation-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug2123-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug2509-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug34176-expected.txt:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug59252-expected.txt:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug7243-expected.txt:
* platform/chromium/test_expectations.txt: Update expectations until rebaseline
* platform/gtk/test_expectations.txt: ditto
* platform/mac/Skipped: Skip until rebaselined
* platform/qt/test_expectations.txt: Update expectations until rebaseline
* platform/win/Skipped: Skip until rebaselined
* tables/hittesting/filltable-stress.html: Adjusted to traverse the cells for hit-testing given their new dimensions.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111742
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Thu, 22 Mar 2012 19:04:18 +0000 (19:04 +0000)]
Added Mac WebKit2 expected results for this test. <webkit.org/b/81945> tracks the
fact that these results are wrong.
* platform/mac-wk2/fast/events: Added.
* platform/mac-wk2/fast/events/suspend-timers-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111741
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Thu, 22 Mar 2012 19:01:10 +0000 (19:01 +0000)]
Factor compositing layer updates after scroll into a new method
https://bugs.webkit.org/show_bug.cgi?id=81943
Reviewed by Dean Jackson.
Move some code that updates compositing layers after scrolling
into its own method, for cleanliness.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollTo):
(WebCore::RenderLayer::updateCompositingLayersAfterScroll):
(WebCore):
* rendering/RenderLayer.h:
(RenderLayer):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111740
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Thu, 22 Mar 2012 18:54:50 +0000 (18:54 +0000)]
Add JSValue::isFunction
https://bugs.webkit.org/show_bug.cgi?id=81935
Reviewed by Geoff Garen.
This would be useful in the WebCore bindings code.
Also, remove asFunction, replace with jsCast<JSFunction*>.
Source/JavaScriptCore:
* API/JSContextRef.cpp:
* debugger/Debugger.cpp:
* debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::functionName):
* dfg/DFGGraph.h:
(JSC::DFG::Graph::valueOfFunctionConstant):
* dfg/DFGOperations.cpp:
* interpreter/CallFrame.cpp:
(JSC::CallFrame::isInlineCallFrameSlow):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
(JSC::jitCompileFor):
(JSC::lazyLinkFor):
* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::traceFunctionPrologue):
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
(JSC::LLInt::setUpCall):
* runtime/Arguments.h:
(JSC::Arguments::finishCreation):
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncFilter):
(JSC::arrayProtoFuncMap):
(JSC::arrayProtoFuncEvery):
(JSC::arrayProtoFuncForEach):
(JSC::arrayProtoFuncSome):
(JSC::arrayProtoFuncReduce):
(JSC::arrayProtoFuncReduceRight):
* runtime/CommonSlowPaths.h:
(JSC::CommonSlowPaths::arityCheckFor):
* runtime/Executable.h:
(JSC::FunctionExecutable::compileFor):
(JSC::FunctionExecutable::compileOptimizedFor):
* runtime/FunctionPrototype.cpp:
(JSC::functionProtoFuncToString):
* runtime/JSArray.cpp:
(JSC::JSArray::sort):
* runtime/JSFunction.cpp:
(JSC::JSFunction::argumentsGetter):
(JSC::JSFunction::callerGetter):
(JSC::JSFunction::lengthGetter):
* runtime/JSFunction.h:
(JSC):
(JSC::asJSFunction):
(JSC::JSValue::isFunction):
* runtime/JSGlobalData.cpp:
(WTF::Recompiler::operator()):
(JSC::JSGlobalData::releaseExecutableMemory):
* runtime/JSValue.h:
* runtime/StringPrototype.cpp:
(JSC::replaceUsingRegExpSearch):
Source/WebCore:
* bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::JSInjectedScriptHost::functionDetails):
* bindings/js/ScriptCallStackFactory.cpp:
(WebCore::createScriptCallStack):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111739
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pierre.rossi@gmail.com [Thu, 22 Mar 2012 18:53:45 +0000 (18:53 +0000)]
Revert back the device DPI to 160.
This corresponds to a device pixel ratio of 1, which
is nicer on the eye in many cases.
Rubber-stamped by Kenneth Rohde Christiansen.
* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewFlickablePrivate::computeViewportConstraints):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111738
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ahf@0x90.dk [Thu, 22 Mar 2012 18:50:31 +0000 (18:50 +0000)]
[Qt][WK2] Remember to initialize databaseQuotaDialog https://bugs.webkit.org/show_bug.cgi?id=81942
Reviewed by Kenneth Rohde Christiansen.
* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::QQuickWebViewPrivate):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111737
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Thu, 22 Mar 2012 18:44:10 +0000 (18:44 +0000)]
Re-land fix for r81603 yet again (!) with latest build fix.
https://bugs.webkit.org/show_bug.cgi?id=81603
Unreviewed, build fix.
The latest problem was a bad sprintf() in
BasePort._get_crash_log(). I've reworked that routine and added
unit tests for coverage.
* Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner._handle_error):
* Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
(write_test_result):
(TestResultWriter.write_crash_log):
* Scripts/webkitpy/layout_tests/port/base.py:
(Port.diff_text):
(Port._get_crash_log):
* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumDriver.run_test):
* Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
(ChromiumDriverTest.test_crash_log):
* Scripts/webkitpy/layout_tests/port/driver.py:
(DriverOutput.__init__):
* Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort.is_lion):
(MacPort._get_crash_log):
* Scripts/webkitpy/layout_tests/port/mac_unittest.py:
(test_default_child_processes):
(test_get_crash_log):
* Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
(MockDRTPortTest.test_get_crash_log):
* Scripts/webkitpy/layout_tests/port/port_testcase.py:
(PortTestCase.test_get_crash_log):
* Scripts/webkitpy/layout_tests/port/test.py:
(TestDriver.run_test):
* Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitDriver.__init__):
(WebKitDriver._start):
(WebKitDriver.has_crashed):
(WebKitDriver._check_for_driver_crash):
(WebKitDriver.run_test):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111736
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jocelyn.turcotte@nokia.com [Thu, 22 Mar 2012 18:32:49 +0000 (18:32 +0000)]
TiledBackingStore: Fix test regressions that appeared with r111560.
https://bugs.webkit.org/show_bug.cgi?id=81519
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
The visible rect wasn't intersected with the contents rect anymore which
could lead to an astronomical layer size to check for intersecting tiles.
Add a visibleContentsRect that doesn't do the conversion and use it
in visibleAreaIsCovered.
* platform/graphics/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::visibleContentsRect):
(WebCore):
(WebCore::TiledBackingStore::visibleRect):
(WebCore::TiledBackingStore::visibleAreaIsCovered):
* platform/graphics/TiledBackingStore.h:
(TiledBackingStore):
LayoutTests:
* platform/qt-5.0-wk2/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111735
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 22 Mar 2012 18:23:16 +0000 (18:23 +0000)]
[chromium] Plug-in failing to load shouldn't say "Missing Plug-in"
https://bugs.webkit.org/show_bug.cgi?id=81907
Patch by Bernhard Bauer <bauerb@google.com> on 2012-03-22
Reviewed by Adam Barth.
Adding a MissingPluginText value to WebLocalizedString which can be used to override the "Missing Plug-in" message.
* public/platform/WebLocalizedString.h:
* src/LocalizedStrings.cpp:
(WebCore::missingPluginText):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111734
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 22 Mar 2012 18:10:55 +0000 (18:10 +0000)]
Make Length Calculation functions non-inline
https://bugs.webkit.org/show_bug.cgi?id=81733
Currently length calculation functions in LengthFunctions.h are inline. These functions are pretty big to be inline.
And these functions are expected to grow again when new length units will be introduced in bug 27160.
A decent rule of thumb is to not inline a function if it is more than 10 lines long. Also it's typically not cost effective to inline
functions with loops or switch statements. (Reference: http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Inline_Functions).
Ran PerformanceTests/Parser/html5-full-render.html on Mac Snow-Leopard with and without the patch and did not see much performance difference.
Patch by Joe Thomas <joethomas@motorola.com> on 2012-03-22
Reviewed by Antti Koivisto.
* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* css/LengthFunctions.cpp: Added.
(WebCore):
(WebCore::miminumValueForLength):
(WebCore::valueForLength):
(WebCore::floatValueForLength):
* css/LengthFunctions.h:
(WebCore):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111733
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Thu, 22 Mar 2012 18:02:00 +0000 (18:02 +0000)]
Added fast/events/drag-link.html to the Mac WebKit2 skip list, because running it has
the undesireable side effect of dropping a URL into another application’s window or the
desktop. <http://webkit.org/b/81833> tracks this test.
* platform/mac-wk2/Skipped:
* platform/mac-wk2/fast/events: Removed.
* platform/mac-wk2/fast/events/drag-link-expected.txt: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111732
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alexis.menard@openbossa.org [Thu, 22 Mar 2012 17:54:50 +0000 (17:54 +0000)]
Increase code sharing between CSSParser and CSSPropertyLonghand.
https://bugs.webkit.org/show_bug.cgi?id=81587
Reviewed by Antti Koivisto.
Expose the longhands declaration for a given shorthand in CSSPropertyLonghand and
make CSSParser use them. It will make the declaration of longhands in one place only.
Remove the map of CSSPropertyLonghand and replace it by a regular switch/case.
The map doesn't bring much here and it's cleaner and faster to use the switch.
It also shows a little performance improvement in CSS/CSSPropertySetterGetter.html.
No new tests : no behavior change.
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseAnimationShorthand):
(WebCore::CSSParser::parseTransitionShorthand):
(WebCore::CSSParser::parseShorthand):
Modify the prototype of this function to directly use the CSSPropertyLonghand.
* css/CSSParser.h:
(WebCore):
(CSSParser):
* css/CSSPropertyLonghand.cpp:
(WebCore):
(WebCore::backgroundLonghand):
(WebCore::backgroundPositionLonghand):
(WebCore::backgroundRepeatLonghand):
(WebCore::borderLonghand):
(WebCore::borderBottomLonghand):
(WebCore::borderColorLonghand):
(WebCore::borderImageLonghand):
(WebCore::borderLeftLonghand):
(WebCore::borderRadiusLonghand):
(WebCore::borderRightLonghand):
(WebCore::borderSpacingLonghand):
(WebCore::borderStyleLonghand):
(WebCore::borderTopLonghand):
(WebCore::borderWidthLonghand):
(WebCore::listStyleLonghand):
(WebCore::fontLonghand):
(WebCore::marginLonghand):
(WebCore::outlineLonghand):
(WebCore::overflowLonghand):
(WebCore::paddingLonghand):
(WebCore::webkitAnimationLonghand):
(WebCore::webkitBorderAfterLonghand):
(WebCore::webkitBorderBeforeLonghand):
(WebCore::webkitBorderEndLonghand):
(WebCore::webkitBorderStartLonghand):
(WebCore::webkitColumnsLonghand):
(WebCore::webkitColumnRuleLonghand):
(WebCore::webkitFlexFlowLonghand):
(WebCore::webkitMarginCollapseLonghand):
(WebCore::webkitMarqueeLonghand):
(WebCore::webkitMaskLonghand):
(WebCore::webkitMaskPositionLonghand):
(WebCore::webkitMaskRepeatLonghand):
(WebCore::webkitTextEmphasisLonghand):
(WebCore::webkitTextStrokeLonghand):
(WebCore::webkitTransitionLonghand):
(WebCore::webkitTransformOriginLonghand):
(WebCore::webkitWrapLonghand):
(WebCore::longhandForProperty):
* css/CSSPropertyLonghand.h:
(WebCore):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111731
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Thu, 22 Mar 2012 17:47:41 +0000 (17:47 +0000)]
Fixed a typo in the change log
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111730
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Thu, 22 Mar 2012 17:46:26 +0000 (17:46 +0000)]
Added Mac expected results for this test from r110938, and removed the render tree dump
results from the cross-platform location, because this test contains text, so the render
varies by platform.
* fast/events/resize-events-expected.txt: Removed.
* platform/mac/fast/events/resize-events-expected.png: Added.
* platform/mac/fast/events/resize-events-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111729
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 22 Mar 2012 17:41:53 +0000 (17:41 +0000)]
Use stereo AudioBuffer instead of RealtimeAnalyserNode in the layout test of stereo2mono-down-mixing
https://bugs.webkit.org/show_bug.cgi?id=81881
Patch by Xingnan Wang <xingnan.wang@intel.com> on 2012-03-22
Reviewed by Chris Rogers.
* webaudio/stereo2mono-down-mixing.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111728
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eae@chromium.org [Thu, 22 Mar 2012 17:41:16 +0000 (17:41 +0000)]
Unreviewed, touching file to force bots to pick up CSS_SHADERS flag change.
* css/CSSStyleSelector.h:
(CSSStyleSelector):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111727
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mifenton@rim.com [Thu, 22 Mar 2012 17:38:36 +0000 (17:38 +0000)]
[BlackBerry] DOMSupport isPositionInNode should have early returns for null nodes
https://bugs.webkit.org/show_bug.cgi?id=81929
Reviewed by Rob Buis.
Add early returns in isPositionInNode when either
node or the position node is null.
* WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::isPositionInNode):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111726
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 22 Mar 2012 17:28:06 +0000 (17:28 +0000)]
ReverbConvolver::latencyFrames() should return 0.
https://bugs.webkit.org/show_bug.cgi?id=81806
Patch by Xingnan Wang <xingnan.wang@intel.com> on 2012-03-22
Reviewed by Chris Rogers.
* platform/audio/ReverbConvolver.cpp:
(WebCore::ReverbConvolver::latencyFrames):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111725
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eae@chromium.org [Thu, 22 Mar 2012 17:25:36 +0000 (17:25 +0000)]
Unreviewed test_expectations update for chromium.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111724
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Thu, 22 Mar 2012 17:24:22 +0000 (17:24 +0000)]
Added fast/events/remove-target-with-shadow-in-drag.html to the Mac WebKit2 skip list, since
it relies on dragging using EventSender, which doesn’t work in WebKitTestRunner.
<http://webkit.org/b/68552> tracks this issue.
* platform/mac-wk2/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111723
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ahf@0x90.dk [Thu, 22 Mar 2012 17:23:02 +0000 (17:23 +0000)]
[Qt] Enable support for handling database quota's in the MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=81928
Reviewed by Simon Hausmann.
* MiniBrowser/qt/qml/BrowserWindow.qml:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111722
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ahf@0x90.dk [Thu, 22 Mar 2012 17:22:38 +0000 (17:22 +0000)]
[Qt][WK2] Pass Origin information to the DatabaseQuotaDialogContextObject https://bugs.webkit.org/show_bug.cgi?id=81910
Reviewed by Simon Hausmann.
* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::exceededDatabaseQuota):
* UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate):
* UIProcess/qt/QtDialogRunner.cpp:
(DatabaseQuotaDialogContextObject):
(DatabaseQuotaDialogContextObject::DatabaseQuotaDialogContextObject):
(DatabaseQuotaDialogContextObject::securityOrigin):
(QtDialogRunner::initForDatabaseQuotaDialog):
* UIProcess/qt/QtDialogRunner.h:
(QtDialogRunner):
* UIProcess/qt/QtWebPageUIClient.cpp:
(QtWebPageUIClient::exceededDatabaseQuota):
* UIProcess/qt/QtWebPageUIClient.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111721
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Thu, 22 Mar 2012 17:16:30 +0000 (17:16 +0000)]
refactor flexbox in preparation for flex-line-pack
https://bugs.webkit.org/show_bug.cgi?id=81843
Reviewed by Ojan Vafai.
Replace WrapReverseContext with a vector of LineContexts that contain
the same information, plus values needed for flex-align.
alignChildren has been moved to after all the lines have been
positioned. We want to align children after flex-line-pack has changed
the size of each line to avoid unnecessary layouts.
Take 2: Remove the assert. If there are no children, then there are no
flex lines. Instead, assert that child is not null.
No new tests, just refactoring.
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::LineContext::LineContext): New struct,
holds information needed for wrap-reverse and aligning children.
(RenderFlexibleBox::LineContext):
(WebCore::RenderFlexibleBox::layoutFlexItems): alignChildren after layout out all the lines rather than after each line.
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren): don't alignChildren
(WebCore::RenderFlexibleBox::alignChildren): align all flex items, not just a line at a time.
(WebCore::RenderFlexibleBox::flipForWrapReverse): Update to use LineContext
* rendering/RenderFlexibleBox.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111720
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kubo@profusion.mobi [Thu, 22 Mar 2012 17:12:24 +0000 (17:12 +0000)]
[EFL] Gardening, add and update animations/, fast/css,
fast/line-grid and fast/repaint baselines and expectations.
* platform/efl/animations/cross-fade-background-image-expected.png: Added.
* platform/efl/animations/cross-fade-background-image-expected.txt: Added.
* platform/efl/animations/cross-fade-border-image-source-expected.png: Added.
* platform/efl/animations/cross-fade-border-image-source-expected.txt: Added.
* platform/efl/animations/cross-fade-list-style-image-expected.png: Added.
* platform/efl/animations/cross-fade-list-style-image-expected.txt: Added.
* platform/efl/animations/cross-fade-webkit-mask-image-expected.png: Added.
* platform/efl/animations/cross-fade-webkit-mask-image-expected.txt: Added.
* platform/efl/fast/css/003-expected.txt:
* platform/efl/fast/css/004-expected.txt:
* platform/efl/fast/css/005-expected.txt:
* platform/efl/fast/css/acid2-expected.txt:
* platform/efl/fast/css/acid2-pixel-expected.txt:
* platform/efl/fast/css/bidi-override-in-anonymous-block-expected.txt:
* platform/efl/fast/css/color-correction-backgrounds-and-text-expected.txt:
* platform/efl/fast/css/color-correction-on-text-expected.txt:
* platform/efl/fast/css/css2-system-fonts-expected.txt:
* platform/efl/fast/css/empty-inline-003-quirksmode-expected.txt: Added.
* platform/efl/fast/css/empty-inline-line-height-first-line-expected.txt: Added.
* platform/efl/fast/css/empty-inline-line-height-first-line-quirksmode-expected.txt: Added.
* platform/efl/fast/css/first-letter-first-line-hover-expected.txt:
* platform/efl/fast/css/font-face-woff-expected.txt:
* platform/efl/fast/css/font-weight-1-expected.txt:
* platform/efl/fast/css/font_property_normal-expected.txt:
* platform/efl/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Added.
* platform/efl/fast/css/hover-subselector-expected.txt:
* platform/efl/fast/css/hsl-color-expected.txt:
* platform/efl/fast/css/ignore-text-zoom-expected.png: Added.
* platform/efl/fast/css/inline-properties-important-expected.txt:
* platform/efl/fast/css/invalidation-errors-3-expected.txt:
* platform/efl/fast/css/non-empty-span-expected.png: Added.
* platform/efl/fast/css/non-empty-span-expected.txt: Added.
* platform/efl/fast/css/preserve-user-specified-zoom-level-on-reload-expected.png: Added.
* platform/efl/fast/css/pseudo-first-line-border-width-expected.png: Added.
* platform/efl/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-expected.png: Added.
* platform/efl/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-expected.txt: Added.
* platform/efl/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed-expected.png: Added.
* platform/efl/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed-expected.txt: Added.
* platform/efl/fast/css/relative-positioned-block-nested-with-inline-parent-expected.png: Added.
* platform/efl/fast/css/relative-positioned-block-nested-with-inline-parent-expected.txt: Added.
* platform/efl/fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic-expected.png: Added.
* platform/efl/fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic-expected.txt: Added.
* platform/efl/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.png: Added.
* platform/efl/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.txt: Added.
* platform/efl/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.png: Added.
* platform/efl/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.txt: Added.
* platform/efl/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.png: Added.
* platform/efl/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.txt: Added.
* platform/efl/fast/css/relative-positioned-block-with-inline-ancestor-expected.png: Added.
* platform/efl/fast/css/relative-positioned-block-with-inline-ancestor-expected.txt: Added.
* platform/efl/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.png: Added.
* platform/efl/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.txt: Added.
* platform/efl/fast/css/relative-positioned-block-with-inline-parent-dynamic-removed-expected.png: Added.
* platform/efl/fast/css/relative-positioned-block-with-inline-parent-dynamic-removed-expected.txt: Added.
* platform/efl/fast/css/relative-positioned-block-with-inline-parent-keeps-style-expected.png: Added.
* platform/efl/fast/css/relative-positioned-block-with-inline-parent-keeps-style-expected.txt: Added.
* platform/efl/fast/css/selector-set-attribute-expected.txt:
* platform/efl/fast/css/transform-default-parameter-expected.txt:
* platform/efl/fast/css/zoom-body-scroll-expected.txt: Added.
* platform/efl/fast/css/zoom-font-size-expected.txt:
* platform/efl/fast/line-grid/line-align-left-edges-expected.png: Added.
* platform/efl/fast/line-grid/line-align-left-edges-expected.txt: Added.
* platform/efl/fast/line-grid/line-align-right-edges-expected.png: Added.
* platform/efl/fast/line-grid/line-align-right-edges-expected.txt: Added.
* platform/efl/fast/line-grid/line-grid-contains-value-expected.png: Added.
* platform/efl/fast/line-grid/line-grid-contains-value-expected.txt: Added.
* platform/efl/fast/line-grid/line-grid-into-columns-expected.png: Added.
* platform/efl/fast/line-grid/line-grid-into-columns-expected.txt: Added.
* platform/efl/fast/repaint/scroll-inside-table-cell-expected.png: Added.
* platform/efl/fast/repaint/table-hover-on-link-expected.png: Added.
* platform/efl/fast/repaint/transform-rotate-and-remove-expected.png: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111719
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eae@chromium.org [Thu, 22 Mar 2012 17:06:44 +0000 (17:06 +0000)]
Unreviewed test_expectations update for chromium. Marking a couple of tests as SLOW on SNOWLEOPARD DEBUG.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111718
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 22 Mar 2012 17:01:48 +0000 (17:01 +0000)]
Event dispatching in XMLHttpRequestProgressEventThrottle should go through XMLHttpRequestProgressEventThrottle::dispatchEvent
https://bugs.webkit.org/show_bug.cgi?id=46743
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-03-22
Reviewed by Julien Chaffraix
Based on original patch by Anton D'Auria
In preparation for platform-specific queuing of XMLHttpRequest events,
this patch changes all calls to m_target->dispatchEvent to
XMLHttpRequestProgressEventThrottle::dispatchEvent.
Currently, we queue only one progress event on suspend() if we have
throttled progress events. We should be able to queue all XHR events
that can be generated after suspend(), if the platform network layer
continues to receive data.
XMLHttpRequest uses XMLHttpRequestProgressEventThrottle to dispatch only
download events, so this doesn't change behavior of upload events, which
aren't throttled or queued.
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::callReadyStateChangeListener):
* xml/XMLHttpRequestProgressEventThrottle.cpp:
(WebCore::XMLHttpRequestProgressEventThrottle::dispatchReadyStateChangeEvent):
(WebCore::XMLHttpRequestProgressEventThrottle::dispatchEvent):
(WebCore::XMLHttpRequestProgressEventThrottle::flushProgressEvent):
(WebCore::XMLHttpRequestProgressEventThrottle::dispatchPausedEvent):
(WebCore::XMLHttpRequestProgressEventThrottle::fired):
* xml/XMLHttpRequestProgressEventThrottle.h:
(XMLHttpRequestProgressEventThrottle):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111717
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 22 Mar 2012 16:59:46 +0000 (16:59 +0000)]
[EFL] Map BackSpace key code to Unicode value
https://bugs.webkit.org/show_bug.cgi?id=81130
Source/WebCore:
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-03-22
Reviewed by Gustavo Noronha Silva.
Test: fast/events/backspace-navigates-back.html
* platform/efl/EflKeyboardUtilities.cpp:
(WebCore::createKeyMap): Map BackSpace to Unicode value
LayoutTests:
Unskip fast/events/backspace-navigates-back.html
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-03-22
Reviewed by Gustavo Noronha Silva.
* platform/efl/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111716
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kkristof@inf.u-szeged.hu [Thu, 22 Mar 2012 16:57:57 +0000 (16:57 +0000)]
[Qt] Gardening, skip failing tests after r111560.
https://bugs.webkit.org/show_bug.cgi?id=81519
Reviewed by Csaba Osztrogonác.
* platform/qt-5.0-wk2/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111715
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
inferno@chromium.org [Thu, 22 Mar 2012 16:52:55 +0000 (16:52 +0000)]
Incorrect beforeChild parent calculation in RenderRubyBase::moveChildren.
https://bugs.webkit.org/show_bug.cgi?id=80297
Reviewed by Julien Chaffraix.
Source/WebCore:
beforeChild might share the same anonymous block parent with other previous
siblings. Before moving the children across ruby bases, we need to make sure
to split the tree across the beforeChild correctly.
Test: fast/ruby/ruby-text-before-child-split.html
* rendering/RenderRubyBase.cpp:
(WebCore::RenderRubyBase::moveChildren):
LayoutTests:
Test passes if you see the inline continuation in the first ruby base and only the
simple text in the second ruby base.
* fast/ruby/ruby-text-before-child-split-expected.png: Added.
* fast/ruby/ruby-text-before-child-split-expected.txt: Added.
* fast/ruby/ruby-text-before-child-split.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111714
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kubo@profusion.mobi [Thu, 22 Mar 2012 16:16:30 +0000 (16:16 +0000)]
[EFL] Gardening, update a few more fast/forms baselines.
* platform/efl/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.png: Added.
* platform/efl/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.txt: Added.
* platform/efl/fast/forms/file/file-input-pressed-state-expected.png: Added.
* platform/efl/fast/forms/input-placeholder-text-indent-expected.png:
* platform/efl/fast/forms/isindex-placeholder-expected.png:
* platform/efl/fast/forms/placeholder-with-positioned-element-expected.png:
* platform/efl/fast/forms/select-overflow-scroll-expected.png: Added.
* platform/efl/fast/forms/select-overflow-scroll-expected.txt: Added.
* platform/efl/fast/forms/select-overflow-scroll-inherited-expected.png: Added.
* platform/efl/fast/forms/select-overflow-scroll-inherited-expected.txt: Added.
* platform/efl/fast/forms/textarea-placeholder-wrapping-expected.png:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111712
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kkristof@inf.u-szeged.hu [Thu, 22 Mar 2012 16:13:45 +0000 (16:13 +0000)]
[Qt] Gardening, skip failing tests after r111560.
https://bugs.webkit.org/show_bug.cgi?id=81519
Reviewed by Csaba Osztrogonác.
* platform/qt-5.0-wk2/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111711
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kkristof@inf.u-szeged.hu [Thu, 22 Mar 2012 16:01:58 +0000 (16:01 +0000)]
[Qt] Fix Qt minimal build after r111692
Reviewed by Csaba Osztrogonác.
* bindings/js/JSScriptProfileNodeCustom.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111710
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 22 Mar 2012 15:50:48 +0000 (15:50 +0000)]
[EFL] Implement LayoutTestController::setEditingBehavior
https://bugs.webkit.org/show_bug.cgi?id=81124
Source/WebKit/efl:
Add missing implementation setEditingBehavior to EFL's
DumpRenderTreeSupport. This setting controls various editing
behaviors that differ between platforms.
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-03-22
Reviewed by Martin Robinson.
* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::setEditingBehavior):
* WebCoreSupport/DumpRenderTreeSupportEfl.h:
Tools:
Adding missing implementation setEditingBehavior to EFL's
LayoutTestController. This implementation allows us to
unskip some tests from the skip list.
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-03-22
Reviewed by Martin Robinson.
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::setEditingBehavior): Implemented.
LayoutTests:
Unskip tests connected with setEditingBehavior.
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-03-22
Reviewed by Martin Robinson.
* platform/efl/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111709
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enne@google.com [Thu, 22 Mar 2012 15:37:30 +0000 (15:37 +0000)]
[chromium] Fix scrollbar layers holding onto invalid textures after lost context
https://bugs.webkit.org/show_bug.cgi?id=81841
Reviewed by James Robinson.
Source/WebCore:
Unit test: CCLayerTreeHostImplTest.scrollbarLayerLostContext
* platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp:
(WebCore::CCScrollbarLayerImpl::willDraw):
Source/WebKit/chromium:
* tests/CCLayerTreeHostImplTest.cpp:
(WebKitTests::TEST_F):
(WebKitTests):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111708
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 22 Mar 2012 15:36:10 +0000 (15:36 +0000)]
[GTK] Add MediaStream feature to avoid MediaStream test failure
https://bugs.webkit.org/show_bug.cgi?id=81727
Patch by Mao Yujie <yujie.mao@intel.com> on 2012-03-22
Reviewed by Martin Robinson.
* GNUmakefile.am:
* WebCoreSupport/UserMediaClientGtk.cpp: Added.
(WebKit):
(WebKit::UserMediaClientGtk::UserMediaClientGtk):
(WebKit::UserMediaClientGtk::~UserMediaClientGtk):
(WebKit::UserMediaClientGtk::pageDestroyed):
(WebKit::UserMediaClientGtk::requestUserMedia):
(WebKit::UserMediaClientGtk::cancelUserMediaRequest):
* WebCoreSupport/UserMediaClientGtk.h: Added.
(WebKit):
(UserMediaClientGtk):
* webkit/webkitwebview.cpp:
(webkit_web_view_init):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111707
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Thu, 22 Mar 2012 15:30:26 +0000 (15:30 +0000)]
[GTK] ASSERT bug in WebAudio (AudioFileReader)
https://bugs.webkit.org/show_bug.cgi?id=81777
Reviewed by Martin Robinson.
* platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
(WebCore::AudioFileReader::decodeAudioForBusCreation): Don't steal
the GstBus floating reference.
(WebCore::AudioFileReader::createBus): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111706
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jocelyn.turcotte@nokia.com [Thu, 22 Mar 2012 15:24:26 +0000 (15:24 +0000)]
[Qt] Don't resume the suspended page if the user is continuously flicking.
https://bugs.webkit.org/show_bug.cgi?id=81895
Reviewed by Kenneth Rohde Christiansen.
Create an additional suspend deferrer between TouchBegin and TouchEnd to
relay with the one kept while the flick animation is running.
This allows the page to be suspended when a pan gesture starts and stay
that way until the last flick animation ends.
* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::touchBegin):
(WebKit):
(WebKit::QtViewportInteractionEngine::touchEnd):
(WebKit::QtViewportInteractionEngine::pinchGestureStarted):
* UIProcess/qt/QtViewportInteractionEngine.h:
(QtViewportInteractionEngine):
* UIProcess/qt/QtWebPageEventHandler.cpp:
(QtWebPageEventHandler::doneWithTouchEvent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111705
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Thu, 22 Mar 2012 15:22:54 +0000 (15:22 +0000)]
Unreviewed: Web Inspector: fix syntax error in text.
* English.lproj/localizedStrings.js:
* inspector/front-end/HeapSnapshotProxy.js:
(WebInspector.HeapSnapshotWorker.prototype._messageReceived):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111704
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 22 Mar 2012 15:17:57 +0000 (15:17 +0000)]
[EFL] Change returned view mode in case of NULL of ewkView.
https://bugs.webkit.org/show_bug.cgi?id=81636
Patch by Krzysztof Czech <k.czech@samsung.com> on 2012-03-22
Reviewed by Eric Seidel.
Function ewk_view_mode_get returns wrong view mode in case of NULL of ewkView.
* ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(ewk_view_mode_get):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111703
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Thu, 22 Mar 2012 15:15:52 +0000 (15:15 +0000)]
Unreviewed, rolling out r111688.
http://trac.webkit.org/changeset/111688
https://bugs.webkit.org/show_bug.cgi?id=81912
"Heap profiler test fails" (Requested by yurys on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-22
* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshot.prototype._buildRetainers):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111702
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 22 Mar 2012 15:09:08 +0000 (15:09 +0000)]
[chromium] Early out in a new prepareToDraw() step if checkerboarding an accelerated animation in order to skip the frame
https://bugs.webkit.org/show_bug.cgi?id=81437
Patch by Dana Jansens <danakj@chromium.org> on 2012-03-22
Reviewed by Adrienne Walker.
Source/WebCore:
Split CCLayerTreeHostImpl::drawLayers() into two phases:
prepareToDraw() and drawLayers().
When calculating a RenderPass, and we checkerboard a quad on a
layer, bubble this info back up to CCLayerTreeHostImpl. If the
layer is transforming in an animation, then abort the prepareToDraw()
phase and cause it to return false back to the thread proxy.
Unit test: CCLayerTreeHostImplTest.prepareToDrawFailsWhenAnimationUsesCheckerboard
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::appendQuads):
* platform/graphics/chromium/cc/CCLayerImpl.h:
(CCLayerImpl):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::prepareToDraw):
(WebCore):
(WebCore::CCLayerTreeHostImpl::drawLayers):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(CCLayerTreeHostImpl):
(FrameData):
* platform/graphics/chromium/cc/CCQuadCuller.cpp:
(WebCore::CCQuadCuller::append):
* platform/graphics/chromium/cc/CCQuadCuller.h:
(CCQuadCuller):
* platform/graphics/chromium/cc/CCRenderPass.cpp:
(WebCore::CCRenderPass::appendQuadsForLayer):
* platform/graphics/chromium/cc/CCRenderPass.h:
(CCRenderPass):
* platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp:
(WebCore::CCScrollbarLayerImpl::appendQuads):
* platform/graphics/chromium/cc/CCScrollbarLayerImpl.h:
(CCScrollbarLayerImpl):
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::doComposite):
* platform/graphics/chromium/cc/CCSolidColorLayerImpl.cpp:
(WebCore::CCSolidColorLayerImpl::appendQuads):
* platform/graphics/chromium/cc/CCSolidColorLayerImpl.h:
(CCSolidColorLayerImpl):
* platform/graphics/chromium/cc/CCTextureLayerImpl.cpp:
(WebCore::CCTextureLayerImpl::appendQuads):
* platform/graphics/chromium/cc/CCTextureLayerImpl.h:
(CCTextureLayerImpl):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::scheduledActionDrawAndSwap):
* platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::appendQuads):
* platform/graphics/chromium/cc/CCTiledLayerImpl.h:
(CCTiledLayerImpl):
* platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::appendQuads):
* platform/graphics/chromium/cc/CCVideoLayerImpl.h:
(CCVideoLayerImpl):
Source/WebKit/chromium:
* tests/CCAnimationTestCommon.cpp:
(WebCore):
(WebCore::addAnimatedTransform):
(WebKitTests::addOpacityTransitionToLayer):
(WebKitTests):
(WebKitTests::addAnimatedTransformToLayer):
* tests/CCAnimationTestCommon.h:
(WebCore):
(WebKitTests):
* tests/CCLayerTreeHostImplTest.cpp:
(WebKitTests::TEST_F):
(DidDrawCheckLayer):
(WebKitTests::DidDrawCheckLayer::DidDrawCheckLayer):
(MissingTextureAnimatingLayer):
(WebKitTests::MissingTextureAnimatingLayer::create):
(WebKitTests::MissingTextureAnimatingLayer::MissingTextureAnimatingLayer):
(WebKitTests):
(WebKitTests::BlendStateCheckLayer::appendQuads):
* tests/CCLayerTreeHostTest.cpp:
(WTF::TestHooks::prepareToDrawOnCCThread):
(WTF::MockLayerTreeHostImpl::prepareToDraw):
(MockLayerTreeHostImpl):
(WTF::MockLayerTreeHostImpl::drawLayers):
* tests/CCQuadCullerTest.cpp:
(WebCore::appendQuads):
* tests/CCSolidColorLayerImplTest.cpp:
(CCLayerTestCommon::TEST):
* tests/CCTiledLayerImplTest.cpp:
(CCLayerTestCommon::TEST):
(CCLayerTestCommon::getQuads):
* tests/MockCCQuadCuller.h:
(WebCore::MockCCQuadCuller::append):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111700
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
leviw@chromium.org [Thu, 22 Mar 2012 15:07:02 +0000 (15:07 +0000)]
Correct LayoutUnit usage in Accessibility code
https://bugs.webkit.org/show_bug.cgi?id=81789
Reviewed by Eric Seidel.
Reverting Accessibility hit testing code back to integers. Accessibility hit tests originate from
the embedder and don't accumulate offsets, so we get nothing from using LayoutUnits, and needlessly
expose them to the embedder.
No new tests. No change in behavior.
* accessibility/AccessibilityListBox.cpp:
(WebCore::AccessibilityListBox::elementAccessibilityHitTest): See above.
* accessibility/AccessibilityListBox.h:
(AccessibilityListBox):
* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::clickPoint): This value is only ever used to display a context menu,
which is always done with integer coordinates.
(WebCore::AccessibilityObject::boundingBoxForQuads): This is a bounding box built from floats. We
don't pixel snap floats, so we return an integer bounding box.
(WebCore::AccessibilityObject::elementAccessibilityHitTest): See above.
(WebCore::AccessibilityObject::scrollToMakeVisible): Pixel snapping the bounding box and simplifying
up the code to position it at (0,0).
* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::accessibilityHitTest): See above.
(AccessibilityObject):
(WebCore::AccessibilityObject::pixelSnappedBoundingBoxRect): Convenience method for embedder callers.
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::visiblePositionForPoint): The point passed in here is comes from
screen coordinates and originates in embedder code. Reverting it to take an integer.
(WebCore::AccessibilityRenderObject::accessibilityImageMapHitTest): See above.
(WebCore::AccessibilityRenderObject::accessibilityHitTest): See above.
* accessibility/AccessibilityRenderObject.h:
(AccessibilityRenderObject):
* accessibility/AccessibilityScrollView.cpp:
(WebCore::AccessibilityScrollView::accessibilityHitTest): See above.
* accessibility/AccessibilityScrollView.h:
(AccessibilityScrollView):
* accessibility/AccessibilitySlider.cpp:
(WebCore::AccessibilitySlider::elementAccessibilityHitTest): See above.
* accessibility/AccessibilitySlider.h:
(AccessibilitySlider):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111699
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sergio@webkit.org [Thu, 22 Mar 2012 15:05:41 +0000 (15:05 +0000)]
[GTK] icon database requests not dispatched until new data arrives
https://bugs.webkit.org/show_bug.cgi?id=81665
Reviewed by Martin Robinson.
Wait for the import to finish before reporting that the favicon
cache does not have a pixbuf for an URL.
Changes already covered by the favicon database unit tests.
* webkit/webkitfavicondatabase.cpp:
(webkit_favicon_database_get_favicon_pixbuf):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111698
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Thu, 22 Mar 2012 15:04:38 +0000 (15:04 +0000)]
Web Inspector: HeapProfiler: Heap snapshot worker has to report the errors to the front-end
https://bugs.webkit.org/show_bug.cgi?id=81804
Sometimes the worker process of HeapSnapshot does some wrong thing and throw an Exception.
At this momemnt we have no way to see the error in the front-end.
Reviewed by Yury Semikhatsky.
* English.lproj/localizedStrings.js:
* inspector/front-end/HeapSnapshotProxy.js: check the exception field and dump it into front-end's console.
(WebInspector.HeapSnapshotWorker.prototype._messageReceived):
* inspector/front-end/HeapSnapshotWorkerDispatcher.js: catch the exception and transfer it's text to requester's side.
(WebInspector.HeapSnapshotWorkerDispatcher.prototype.dispatchMessage):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111697
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Thu, 22 Mar 2012 14:56:33 +0000 (14:56 +0000)]
[GTK] Use the angle-bracket form to include wtf headers
https://bugs.webkit.org/show_bug.cgi?id=81884
Patch by Carlos Garcia Campos <cgarcia@bb-webkit-rel-64.local.igalia.com> on 2012-03-22
Reviewed by Eric Seidel.
Source/WebCore:
Use #include <wtf/foo> instead of #include "foo".
* platform/graphics/freetype/FontPlatformData.h:
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
* platform/gtk/DataObjectGtk.h:
* platform/network/ResourceHandleInternal.h:
* platform/network/soup/SocketStreamHandleSoup.cpp:
Source/WebKit/gtk:
Use #include <wtf/foo> instead of #include "foo".
* WebCoreSupport/DocumentLoaderGtk.cpp:
* WebCoreSupport/DragClientGtk.h:
* WebCoreSupport/FrameLoaderClientGtk.cpp:
* WebCoreSupport/FullscreenVideoController.h:
* WebCoreSupport/GeolocationClientGtk.h:
* WebCoreSupport/InspectorClientGtk.h:
* WebCoreSupport/TextCheckerClientGtk.cpp:
* WebCoreSupport/TextCheckerClientGtk.h:
* webkit/webkitdownload.cpp:
* webkit/webkitfavicondatabase.cpp:
* webkit/webkitglobals.cpp:
* webkit/webkithittestresult.cpp:
* webkit/webkitnetworkrequest.cpp:
* webkit/webkitnetworkresponse.cpp:
* webkit/webkitspellcheckerenchant.cpp:
* webkit/webkitwebdatasourceprivate.h:
* webkit/webkitwebsettings.cpp:
* webkit/webkitwebsettingsprivate.h:
* webkit/webkitwebviewprivate.h:
Source/WebKit2:
Use #include <wtf/foo> instead of #include <JavaScriptCore/foo>.
* UIProcess/API/gtk/tests/TestMain.h:
* UIProcess/API/gtk/tests/TestWebKitSettings.cpp:
Tools:
Use #include <wtf/foo> instead of #include "foo".
* DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
* DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
* DumpRenderTree/gtk/DumpRenderTree.cpp:
* DumpRenderTree/gtk/EditingCallbacks.cpp:
* DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
* WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111696
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Thu, 22 Mar 2012 14:53:28 +0000 (14:53 +0000)]
Web Inspector: Case of the elements of the xml document should be shown as it is in the console
https://bugs.webkit.org/show_bug.cgi?id=81902
Source/WebCore:
When registering a detached root, DOMAgent always presumes it is a node,
while it can also be a document.
Reviewed by Vsevolod Vlasov.
Test: inspector/console/console-xml-document.html
* inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl.prototype._formatParameterAsNode):
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMAgent.prototype._setDetachedRoot):
LayoutTests:
Reviewed by Vsevolod Vlasov.
* inspector/console/console-xml-document-expected.txt: Added.
* inspector/console/console-xml-document.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111695
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Thu, 22 Mar 2012 14:48:01 +0000 (14:48 +0000)]
Web Inspector: Introduce ScriptBound/ScriptUnbound events in ScriptMapping.
https://bugs.webkit.org/show_bug.cgi?id=81904
Reviewed by Pavel Feldman.
This is another step on the way to cleaner BreakpointManager logic.
Here we extract ScriptBound/ScriptUnbound events from UISourceCodeListChanged event.
This allows us to handle script-uiSourceCode binding separately from
uiSourceCode creation/deletion and to handle unbinding that was not
possible at all before.
* inspector/front-end/CompilerScriptMapping.js:
(WebInspector.CompilerScriptMapping.prototype._uiSourceCodesForSourceMap):
(WebInspector.CompilerScriptMapping.prototype.addScript.get this):
(WebInspector.CompilerScriptMapping.prototype.addScript):
(WebInspector.CompilerScriptMapping.prototype.reset):
* inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeChanged):
* inspector/front-end/ScriptMapping.js:
(WebInspector.MainScriptMapping):
(WebInspector.MainScriptMapping.prototype._updateLiveLocation):
(WebInspector.MainScriptMapping.prototype._handleUISourceCodeListChanged):
(WebInspector.MainScriptMapping.prototype._handleScriptBound):
(WebInspector.MainScriptMapping.prototype._handleScriptUnbound):
* inspector/front-end/SnippetsModel.js:
(WebInspector.SnippetsScriptMapping.prototype.addScript.get this):
(WebInspector.SnippetsScriptMapping.prototype._snippetAdded):
(WebInspector.SnippetsScriptMapping.prototype._createUISourceCodeForScript):
(WebInspector.SnippetsScriptMapping.prototype._snippetRemoved.get this):
(WebInspector.SnippetsScriptMapping.prototype._snippetRemoved):
(WebInspector.SnippetsScriptMapping.prototype.reset):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111694
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 22 Mar 2012 14:35:51 +0000 (14:35 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=81893
Remove custom bindings form ScriptProfileNode.idl of attribute type Array.
Patch by Vineet Chaudhary <rgf748@motorola.com> on 2012-03-22
Reviewed by Kentaro Hara.
Replace [CustomGetter] Array with sequence<ScriptProfileNode>.
To remove the custom bindings code.
Test: No new tests. LayoutTests/fast/profiler/* test are enough for this.
* bindings/js/JSScriptProfileNodeCustom.cpp: Removed custom function.
(WebCore::JSScriptProfileNode::callUID):
* bindings/v8/custom/V8ScriptProfileNodeCustom.cpp: Removed custom function.
(WebCore):
* inspector/ScriptProfileNode.idl: Replaced Array with sequence<ScriptProfileNode>.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111692
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Thu, 22 Mar 2012 14:29:39 +0000 (14:29 +0000)]
Web Inspector: only update timeline overview categories strips when these are visible
https://bugs.webkit.org/show_bug.cgi?id=81903
Reviewed by Pavel Feldman.
- factor out category strips update into a separate method;
- only invoke it when "Timeline" overview mode is selected.
* inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewPane.prototype._showTimelines):
(WebInspector.TimelineOverviewPane.prototype.update):
(WebInspector.TimelineOverviewPane.prototype._updateCategoryStrips):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111691
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
leviw@chromium.org [Thu, 22 Mar 2012 14:14:13 +0000 (14:14 +0000)]
Update LayoutUnit usage in FrameSelection
https://bugs.webkit.org/show_bug.cgi?id=81754
Reviewed by Eric Seidel.
FrameSelection stores its caret and repaint bounds in absolute coordinates. Absolute coordinates
we treat as pixel values, so this patch changes these values to integers. Sub-pixel precision
will still be used when these coordinates are passed down and used locally.
No new tests. No change in behavior.
* editing/FrameSelection.cpp:
(WebCore::absoluteCaretY): Uses absolute coordinates, which are ints.
(WebCore::FrameSelection::modify): Uses absolute coordinates to handle vertical selection
modification. Sub-pixel precision will be used when these values are converted to local ones.
(WebCore::CaretBase::absoluteBoundsForLocalRect): Absolute coordinates -> ints.
(WebCore::FrameSelection::absoluteCaretBounds): Ditto.
(WebCore::CaretBase::caretRepaintRect): The caret repaint rect is stored in absolute coordinates.
Reverting the values to ints.
(WebCore::FrameSelection::recomputeCaretRect): Ditto.
* editing/FrameSelection.h:
(FrameSelection):
* editing/mac/FrameSelectionMac.mm:
(WebCore::FrameSelection::notifyAccessibilityForSelectionChange): Switching to store absolute
coordinates as integers.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111689
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Thu, 22 Mar 2012 14:12:31 +0000 (14:12 +0000)]
Web Inspector: Speed up the build retainers phase.
https://bugs.webkit.org/show_bug.cgi?id=81763
Replacing the edge iterator with a raw loop makes it
faster by more than 10 times.
Patch by Alexei Filippov <alexeif@chromium.org> on 2012-03-22
Reviewed by Yury Semikhatsky.
* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshot.prototype._buildRetainers):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111688
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
noam.rosenthal@nokia.com [Thu, 22 Mar 2012 14:07:23 +0000 (14:07 +0000)]
[Qt][WK2] The background appears to have one extra pixel from the contents
https://bugs.webkit.org/show_bug.cgi?id=81830
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
TextureMapperGL applied a 1-offset that was covering for another bug,
which was already fixed.
No new tests, this would be tested once we test GL rendering results.
* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGLData::SharedGLData::scissorClip):
Source/WebKit2:
The clip-polygon from the scenegraph uses floats, not integers.
This could cause 1-offset clipping problems in some cases.
* UIProcess/qt/QtWebPageSGNode.cpp:
(WebKit::ContentsSGNode::clipRect):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111687
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
wjmaclean@chromium.org [Thu, 22 Mar 2012 14:03:06 +0000 (14:03 +0000)]
Rename touchpad fling curve, add curve parameters to constructor.
https://bugs.webkit.org/show_bug.cgi?id=81820
Reviewed by Adrienne Walker.
Source/WebCore:
Covered by existing unit tests.
* GNUmakefile.list.am:
* WebCore.gypi:
* platform/ScrollAnimatorNone.cpp:
(WebCore::ScrollAnimatorNone::fireUpAnAnimation):
* platform/TouchpadFlingPlatformGestureCurve.cpp: Renamed from Source/WebCore/platform/TouchFlingPlatformGestureCurve.cpp.
(WebCore):
(WebCore::TouchpadFlingPlatformGestureCurve::create):
(WebCore::TouchpadFlingPlatformGestureCurve::TouchpadFlingPlatformGestureCurve):
(WebCore::TouchpadFlingPlatformGestureCurve::~TouchpadFlingPlatformGestureCurve):
(WebCore::TouchpadFlingPlatformGestureCurve::apply):
* platform/TouchpadFlingPlatformGestureCurve.h: Renamed from Source/WebCore/platform/TouchFlingPlatformGestureCurve.h.
(WebCore):
(TouchpadFlingPlatformGestureCurve):
Source/WebKit/chromium:
* src/WebCompositorInputHandlerImpl.cpp:
(WebKit::WebCompositorInputHandlerImpl::handleGestureFling):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::gestureEvent):
* tests/PlatformGestureCurveTest.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111686
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ahf@0x90.dk [Thu, 22 Mar 2012 13:59:41 +0000 (13:59 +0000)]
Unreviewed, add Michael Brüning and Allan Jensen to committers.py.
* Scripts/webkitpy/common/config/committers.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111685
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ahf@0x90.dk [Thu, 22 Mar 2012 13:51:44 +0000 (13:51 +0000)]
[Qt][WK2] Add QML API for handling database quotas https://bugs.webkit.org/show_bug.cgi?id=81827
Reviewed by Simon Hausmann.
Patch by Pierre Rossi and Alexander Færøy.
This patch adds a QML API for handling database quotas.
* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::exceededDatabaseQuota):
(QQuickWebViewExperimental::databaseQuotaDialog):
(QQuickWebViewExperimental::setDatabaseQuotaDialog):
* UIProcess/API/qt/qquickwebview_p.h:
* UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate):
* UIProcess/qt/QtDialogRunner.cpp:
(DatabaseQuotaDialogContextObject):
(DatabaseQuotaDialogContextObject::DatabaseQuotaDialogContextObject):
(DatabaseQuotaDialogContextObject::databaseName):
(DatabaseQuotaDialogContextObject::displayName):
(DatabaseQuotaDialogContextObject::currentQuota):
(DatabaseQuotaDialogContextObject::currentOriginUsage):
(DatabaseQuotaDialogContextObject::currentDatabaseUsage):
(DatabaseQuotaDialogContextObject::expectedUsage):
(DatabaseQuotaDialogContextObject::accept):
(DatabaseQuotaDialogContextObject::reject):
(QtDialogRunner::initForDatabaseQuotaDialog):
* UIProcess/qt/QtDialogRunner.h:
(QtDialogRunner):
(QtDialogRunner::databaseQuota):
(QtDialogRunner::onDatabaseQuotaAccepted):
* UIProcess/qt/QtWebPageUIClient.cpp:
(QtWebPageUIClient::QtWebPageUIClient):
(QtWebPageUIClient::exceededDatabaseQuota):
* UIProcess/qt/QtWebPageUIClient.h:
* UIProcess/qt/WebContextQt.cpp:
(WebKit::WebContext::platformDefaultDatabaseDirectory):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111684
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kkristof@inf.u-szeged.hu [Thu, 22 Mar 2012 13:40:06 +0000 (13:40 +0000)]
[Qt] Gardening. Skip failing test.
https://bugs.webkit.org/show_bug.cgi?id=81899
Reviewed by Csaba Osztrogonác.
* platform/qt/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111683
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Thu, 22 Mar 2012 13:25:59 +0000 (13:25 +0000)]
Web Inspector: make CSS and JavaScript files editable by default.
https://bugs.webkit.org/show_bug.cgi?id=81787
Reviewed by Vsevolod Vlasov.
This change removes cancelEditing and setReadOnly capabilities from source frame.
It removes dblclick handler as well since one does not need to enter editing mode.
It also establishes proper content dispatching so that views are updated with the
resource content. All these are inter-dependent, need to be landed simultaneously.
Drive-by follow up to the r111675 where range is modified prior to the exiting
edit mode.
* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype.requestContent):
(WebInspector.JavaScriptSourceFrame.prototype.afterTextChanged):
(WebInspector.JavaScriptSourceFrame.prototype.beforeTextChanged):
(WebInspector.JavaScriptSourceFrame.prototype.didEditContent):
(WebInspector.JavaScriptSourceFrame.prototype._lineNumberAfterEditing):
* inspector/front-end/ResourceView.js:
(WebInspector.ResourceSourceFrame):
(WebInspector.ResourceSourceFrame.prototype.suggestedFileName):
(WebInspector.ResourceSourceFrame.prototype._contentChanged):
(WebInspector.EditableResourceSourceFrame.prototype.canEditSource):
(WebInspector.EditableResourceSourceFrame.prototype.editContent.callbackWrapper):
(WebInspector.EditableResourceSourceFrame.prototype.editContent):
(WebInspector.EditableResourceSourceFrame.prototype._contentChanged):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype._innerShowView):
(WebInspector.FrameResourceTreeElement.prototype._appendRevision):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.setScriptSourceIsDirty):
* inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame):
(WebInspector.SourceFrame.prototype.wasShown):
(WebInspector.SourceFrame.prototype.willHide):
(WebInspector.SourceFrame.prototype.beforeTextChanged):
(WebInspector.SourceFrame.prototype.setContent):
(WebInspector.SourceFrame.prototype.commitEditing):
(WebInspector.SourceFrame.prototype.didEditContent):
(WebInspector.SourceFrame.prototype.editContent):
* inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.prototype._startEditing):
(WebInspector.TextPrompt.prototype._stopEditing):
* inspector/front-end/TextViewer.js:
(WebInspector.TextViewer):
(WebInspector.TextViewer.prototype._registerShortcuts):
(WebInspector.TextEditorMainPanel.prototype.handleEnterKey):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111682
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Thu, 22 Mar 2012 13:24:25 +0000 (13:24 +0000)]
Unreviewed chromium test rebaseline.
* platform/chromium/inspector/debugger/breakpoint-manager-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111681
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kubo@profusion.mobi [Thu, 22 Mar 2012 13:18:57 +0000 (13:18 +0000)]
[EFL] Unreviewed gardening.
Update expectations for some fast/forms tests which were rendering
placeholders with the wrong colors.
* platform/efl/fast/forms/input-placeholder-text-indent-expected.png: Added.
* platform/efl/fast/forms/isindex-placeholder-expected.png: Added.
* platform/efl/fast/forms/placeholder-with-positioned-element-expected.png: Added.
* platform/efl/fast/forms/textarea-placeholder-wrapping-expected.png: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111680
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 22 Mar 2012 13:17:02 +0000 (13:17 +0000)]
[Qt] Enable FAST_MOBILE_SCROLLING when scrolling is delegated.
https://bugs.webkit.org/show_bug.cgi?id=81889
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-03-22
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
On the Qt platform only enable the fast mobile scroll feature when scrolling is delegated.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::styleWillChange):
Tools:
Enable FAST_MOBILE_SCROLLING feature.
* qmake/mkspecs/features/features.prf:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111679
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kubo@profusion.mobi [Thu, 22 Mar 2012 13:06:05 +0000 (13:06 +0000)]
[EFL] DRT: Do not pass a relative path to DOWNLOADED_FONTS_DIR.
https://bugs.webkit.org/show_bug.cgi?id=81900
Reviewed by Gustavo Noronha Silva.
r111598 added the DOWNLOADED_FONTS_DIR define, but it used a relative
path which assumed a certain directory structure for the build
directory which may noy be true.
Instead, hardcode the path to the downloaded fonts starting from the
top-level source directory. While this solution is also far from
perfect, it makes it more consistent and reliable, and easier to
tackle at once with the rest of bug 81475.
* DumpRenderTree/efl/CMakeLists.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111678
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Thu, 22 Mar 2012 12:56:47 +0000 (12:56 +0000)]
Source/WebCore: Web Inspector: dispatch styleSheetChanged event synchronously.
https://bugs.webkit.org/show_bug.cgi?id=81892
Reviewed by Vsevolod Vlasov.
Today, backend generates stylesheet change event synchronously from within set* command.
But CSSStyleModel defers its dispatching until the stylesheet content is available. This
prevents us from ignoring update events from within commands that initiated those updates.
This change makes stylesheet change event dispatch synchronously and delegates stylesheet
content fetching to the event client.
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel.prototype._fireStyleSheetChanged):
(WebInspector.CSSStyleDeclaration.prototype.insertPropertyAt):
(WebInspector.CSSStyleModelResourceBinding.prototype.setContent):
(WebInspector.CSSStyleModelResourceBinding.prototype._innerSetContent.callbackWrapper):
(WebInspector.CSSStyleModelResourceBinding.prototype._innerSetContent):
(WebInspector.CSSStyleModelResourceBinding.prototype._styleSheetChanged.callback):
(WebInspector.CSSStyleModelResourceBinding.prototype._styleSheetChanged):
(WebInspector.CSSStyleModelResourceBinding.prototype._innerStyleSheetChanged):
Source/WebKit/chromium: [chromium] timing functions are getting incorrectly applied for accelerated css transitions
https://bugs.webkit.org/show_bug.cgi?id=81692
Patch by Ian Vollick <vollick@chromium.org> on 2012-03-21
Reviewed by Adrienne Walker.
* tests/CCAnimationTestCommon.cpp:
(WebCore::addOpacityTransition):
(WebKitTests::addOpacityTransitionToController):
(WebKitTests::addOpacityTransitionToLayer):
* tests/CCAnimationTestCommon.h:
(WebKitTests):
* tests/CCLayerAnimationControllerTest.cpp:
(WebKitTests::TEST):
* tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTest::dispatchAddInstantAnimation):
(WTF::CCLayerTreeHostTest::dispatchAddAnimation):
(WTF::TEST_F):
(WTF):
(CCLayerTreeHostTestAddAnimationWithTimingFunction):
(WTF::CCLayerTreeHostTestAddAnimationWithTimingFunction::CCLayerTreeHostTestAddAnimationWithTimingFunction):
(WTF::CCLayerTreeHostTestAddAnimationWithTimingFunction::beginTest):
(WTF::CCLayerTreeHostTestAddAnimationWithTimingFunction::animateLayers):
(WTF::CCLayerTreeHostTestAddAnimationWithTimingFunction::afterTest):
LayoutTests: Web Inspector: dispatch styleSheetChanged event synchronously.
https://bugs.webkit.org/show_bug.cgi?id=81892
Reviewed by Vsevolod Vlasov.
* http/tests/inspector/resources-test.js:
(initialize_ResourceTest.InspectorTest.showResource.callbackWrapper):
(initialize_ResourceTest.InspectorTest.showResource.showResourceCallback.visit):
(initialize_ResourceTest.InspectorTest.showResource.showResourceCallback):
(initialize_ResourceTest.InspectorTest.showResource):
(initialize_ResourceTest):
* inspector/styles/styles-history.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111677
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Thu, 22 Mar 2012 12:54:32 +0000 (12:54 +0000)]
Web Inspector: allow on-hover popover while in edit mode.
https://bugs.webkit.org/show_bug.cgi?id=81898
Reviewed by Vsevolod Vlasov.
This change allows popover while in-edit mode, hides it upon Esc. It also introduces anchorOverride
concept in ObjectPopoverHelper that allows dynamically switching the anchor (say if we want to highlight anchor itself).
* inspector/front-end/DetailedHeapshotView.js:
* inspector/front-end/ElementsPanel.js:
* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype._resolveObjectForPopover.showObjectPopover):
(WebInspector.JavaScriptSourceFrame.prototype._resolveObjectForPopover):
(WebInspector.JavaScriptSourceFrame.prototype._onKeyDown):
* inspector/front-end/NetworkPanel.js:
* inspector/front-end/ObjectPopoverHelper.js:
(WebInspector.ObjectPopoverHelper.prototype._showObjectPopover.showObjectPopover.):
(WebInspector.ObjectPopoverHelper.prototype._showObjectPopover):
* inspector/front-end/Popover.js:
(WebInspector.PopoverHelper.prototype.isPopoverVisible):
* inspector/front-end/TimelinePanel.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111676
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Thu, 22 Mar 2012 12:52:35 +0000 (12:52 +0000)]
Web Inspector: breakpoints should shift when line break is inserted in the middle of the line.
https://bugs.webkit.org/show_bug.cgi?id=81896
Reviewed by Vsevolod Vlasov.
There is a bug that collapses selection prior to exiting change mode, we should never
collapse edit area prior committing.
* inspector/front-end/TextEditorModel.js:
(WebInspector.TextEditorModel.endsWithBracketRegex.):
* inspector/front-end/TextViewer.js:
(WebInspector.TextViewer):
(WebInspector.TextEditorMainPanel.prototype.highlightLine):
(WebInspector.TextEditorMainPanel.prototype.handleUndoRedo.callback):
(WebInspector.TextEditorMainPanel.prototype.handleUndoRedo):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111675
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zherczeg@webkit.org [Thu, 22 Mar 2012 12:51:40 +0000 (12:51 +0000)]
Merge SVGImageBufferTools to SVGRenderingContext
https://bugs.webkit.org/show_bug.cgi?id=81890
Reviewed by Nikolas Zimmermann.
Copy the code to SVGRenderingContext and delete
SVGImageBufferTools[.cpp.h]. Update build systems,
no functionality change. This is the first step
towards making SVGImageBufferTools stageful.
Existing tests cover this issue.
* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/filters/FETile.cpp:
(WebCore::FETile::platformApplySoftware):
* rendering/svg/RenderSVGAllInOne.cpp:
* rendering/svg/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::computeNewScaledFontForStyle):
* rendering/svg/RenderSVGResourceClipper.cpp:
(WebCore::RenderSVGResourceClipper::applyClippingToContext):
(WebCore::RenderSVGResourceClipper::drawContentIntoMaskImage):
* rendering/svg/RenderSVGResourceFilter.cpp:
(WebCore::RenderSVGResourceFilter::applyResource):
* rendering/svg/RenderSVGResourceGradient.cpp:
(WebCore::createMaskAndSwapContextForTextGradient):
(WebCore::clipToTextMask):
* rendering/svg/RenderSVGResourceMasker.cpp:
(WebCore::RenderSVGResourceMasker::applyResource):
(WebCore::RenderSVGResourceMasker::drawContentIntoMaskImage):
* rendering/svg/RenderSVGResourcePattern.cpp:
(WebCore::RenderSVGResourcePattern::applyResource):
(WebCore::RenderSVGResourcePattern::createTileImage):
* rendering/svg/SVGImageBufferTools.cpp: Removed.
* rendering/svg/SVGImageBufferTools.h: Removed.
* rendering/svg/SVGInlineTextBox.cpp:
* rendering/svg/SVGRenderingContext.cpp:
(WebCore::currentContentTransformation):
(WebCore):
(WebCore::SVGRenderingContext::calculateTransformationToOutermostSVGCoordinateSystem):
(WebCore::SVGRenderingContext::createImageBuffer):
(WebCore::SVGRenderingContext::createImageBufferForPattern):
(WebCore::SVGRenderingContext::renderSubtreeToImageBuffer):
(WebCore::SVGRenderingContext::clipToImageBuffer):
(WebCore::SVGRenderingContext::clampedAbsoluteTargetRect):
(WebCore::SVGRenderingContext::clampedAbsoluteSize):
(WebCore::SVGRenderingContext::clear2DRotation):
* rendering/svg/SVGRenderingContext.h:
(SVGRenderingContext):
(WebCore::SVGRenderingContext::calculateImageBufferRect):
* svg/graphics/filters/SVGFEImage.cpp:
(WebCore::FEImage::platformApplySoftware):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111674
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 22 Mar 2012 12:43:03 +0000 (12:43 +0000)]
[EFL] Add PageClientEfl to WebCoreSupport.
https://bugs.webkit.org/show_bug.cgi?id=80748
Patch by Hyowon Kim <hw1008.kim@samsung.com> on 2012-03-22
Reviewed by Noam Rosenthal.
Source/WebCore:
* platform/Widget.h: Use PageClientEfl as type for PlatformPageClient.
(WebCore):
* platform/graphics/efl/GraphicsContext3DPrivate.cpp:
(WebCore::GraphicsContext3DPrivate::createSurface): Change the argument type.
* plugins/efl/PluginViewEfl.cpp:
(WebCore::PluginView::platformGetValue): Use PageClientEfl.
Source/WebKit:
* PlatformEfl.cmake: Add WebCore/platform/graphics/efl to the include path
and PageClientEfl.cpp to the source list.
Source/WebKit/efl:
This patch adds PageClientEfl for implementaion of accelerated compositing.
* WebCoreSupport/ChromeClientEfl.cpp:
(WebCore::ChromeClientEfl::platformPageClient):
* WebCoreSupport/PageClientEfl.cpp: Added.
(WebCore):
(WebCore::PageClientEfl::PageClientEfl):
(WebCore::PageClientEfl::~PageClientEfl):
(WebCore::PageClientEfl::createEvasObjectForAcceleratedCompositing):
Just call ewk_view_accelerated_compositing_object_create().
(WebCore::PageClientEfl::acceleratedCompositingContext):
Just call ewk_view_accelerated_compositing_context_get().
* WebCoreSupport/PageClientEfl.h: Added.
(WebCore):
(PageClientEfl):
(WebCore::PageClientEfl::view): Return ewkView.
* ewk/ewk_private.h:
(WebCore):
(EWKPrivate):
* ewk/ewk_view.cpp:
(_Ewk_View_Private_Data): Add OwnPtr<PageClientEfl>.
(_ewk_view_priv_new): Create a new PageClientEfl.
(ewk_view_accelerated_compositing_object_create): Not implemented.
(ewk_view_accelerated_compositing_context_get): Not implemented.
(EWKPrivate::corePageClient): Return the PageClientEfl pointer.
(EWKPrivate):
Source/WTF:
* wtf/Platform.h: Disable accelerated compositing. It's not ready yet.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111673
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 22 Mar 2012 12:38:45 +0000 (12:38 +0000)]
blur() on shadow host should work when a shadow host contains a focused element in its shadow DOM subtrees
https://bugs.webkit.org/show_bug.cgi?id=81102
Patch by Kaustubh Atrawalkar <kaustubh@motorola.com> on 2012-03-22
Reviewed by Hajime Morita.
Source/WebCore:
This implementation will support blur for a focused element when its shadowHost's blur() is called.
To achieve this Element::blur() function is modified to blur the focused node in it's treeScope.
Test: fast/dom/shadow/shadow-root-blur.html
* dom/Element.cpp:
(WebCore::Element::blur): Modified to blur current treeScope's focused node.
* dom/ShadowRoot.h:
(WebCore::ShadowRoot::activeElement): Rework for code sharing.
* dom/TreeScope.cpp:
(WebCore::TreeScope::focusedNode): Added new function to share code for getting focused node.
* dom/TreeScope.h:
(TreeScope): New function declartion.
* html/HTMLDocument.cpp:
(WebCore::HTMLDocument::activeElement): Rework for code sharing.
LayoutTests:
* fast/dom/shadow/shadow-root-blur-expected.txt: Added.
* fast/dom/shadow/shadow-root-blur.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111672
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Thu, 22 Mar 2012 12:27:39 +0000 (12:27 +0000)]
Web Inspector: RawSourceCode does not need uiSourceCode lists because it never has more than one.
https://bugs.webkit.org/show_bug.cgi?id=81894
Source/WebCore:
RawSourceCode never has more than one uiSourceCode, uiSourceCodeList
are just remains of older implementation. This patch switches RawSourceCode
and SourceMappings from uiSourceCodeList to uiSourceCode.
Reviewed by Pavel Feldman.
* inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode.prototype.uiSourceCode):
(WebInspector.RawSourceCode.prototype._saveSourceMapping):
(WebInspector.RawSourceCode.SourceMapping.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.SourceMapping.prototype.uiSourceCode):
(WebInspector.RawSourceCode.PlainSourceMapping):
(WebInspector.RawSourceCode.PlainSourceMapping.prototype.rawLocationToUILocation):
(WebInspector.RawSourceCode.PlainSourceMapping.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.PlainSourceMapping.prototype.uiSourceCode):
(WebInspector.RawSourceCode.FormattedSourceMapping):
(WebInspector.RawSourceCode.FormattedSourceMapping.prototype.rawLocationToUILocation):
(WebInspector.RawSourceCode.FormattedSourceMapping.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.FormattedSourceMapping.prototype.uiSourceCode):
* inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptMapping.prototype.uiSourceCodeList):
(WebInspector.ResourceScriptMapping.prototype.addScript):
(WebInspector.ResourceScriptMapping.prototype._handleUISourceCodeChanged):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeChanged):
(WebInspector.ResourceScriptMapping.prototype.reset):
LayoutTests:
Reviewed by Pavel Feldman.
* inspector/debugger/raw-source-code.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111670
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 22 Mar 2012 11:17:35 +0000 (11:17 +0000)]
[GTK] Fix the only remaining coding style issue in GTK accessibility code
https://bugs.webkit.org/show_bug.cgi?id=81885
Patch by Mario Sanchez Prada <msanchez@igalia.com> on 2012-03-22
Reviewed by Xan Lopez.
Add needed extra line and remove an unneeded one.
* accessibility/gtk/AccessibilityObjectAtk.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111669
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Thu, 22 Mar 2012 10:50:32 +0000 (10:50 +0000)]
[GTK] Allow to run any jhbuild command with jhbuild-wrapper script
https://bugs.webkit.org/show_bug.cgi?id=81888
Reviewed by Philippe Normand.
* Scripts/update-webkit-libs-jhbuild:
(runJhbuild): Helper function to run jhbuild with a given command.
Instead of running jhbuild directly, use the jhbuild-wrapper, so
that we don't need to run it first to check whether jhbuild is
installed or not.
* efl/run-with-jhbuild: Call jhbuild-wrapper with run command.
* gtk/run-with-jhbuild: Ditto.
* jhbuild/jhbuild-wrapper: Allow to execute any jhbuild command,
not only run.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111668
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 22 Mar 2012 10:45:51 +0000 (10:45 +0000)]
[CSSRegions] Add region styling test for region css rules specificity/position
https://bugs.webkit.org/show_bug.cgi?id=76537
Patch by Mihai Balan <mibalan@adobe.com> on 2012-03-22
Reviewed by Andreas Kling.
* fast/regions/region-style-rule-specificity-expected.html: Added.
* fast/regions/region-style-rule-specificity.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111667
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kkristof@inf.u-szeged.hu [Thu, 22 Mar 2012 09:54:27 +0000 (09:54 +0000)]
Unreviewed gardening after r111595.
* inspector/debugger/breakpoint-manager-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111666
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kkristof@inf.u-szeged.hu [Thu, 22 Mar 2012 09:35:14 +0000 (09:35 +0000)]
[Qt] Unreviewed gardening. Skip the failing test fast/mutation/callback-arguments.html.
* platform/qt/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111664
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Thu, 22 Mar 2012 09:34:41 +0000 (09:34 +0000)]
Unreviewed, test-webkitpy fix after r111661.
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_crash_log):
(MainTest.test_web_process_crash_log):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111663
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Thu, 22 Mar 2012 08:44:47 +0000 (08:44 +0000)]
Unreviewed, test-webkitpy fix after r111642.
* Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
(ChromiumDriverTest.setUp):
(ChromiumDriverTest.test_two_drivers):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111662
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Thu, 22 Mar 2012 08:18:39 +0000 (08:18 +0000)]
webkitpy: clean up actually getting crash logs from DRT/WTR crashes
https://bugs.webkit.org/show_bug.cgi?id=81603
Unreviewed rolling out r111609 and part of r111615,
because it broke NRWT on Qt-WK2 platform.
* Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner._handle_error):
* Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
(write_test_result):
(TestResultWriter.write_crash_report):
* Scripts/webkitpy/layout_tests/port/base.py:
(Port.is_crash_reporter):
(Port._driver_class):
* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumDriver.run_test):
* Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
(ChromiumDriverTest.test_crashed_process_name):
* Scripts/webkitpy/layout_tests/port/driver.py:
(DriverOutput.__init__):
* Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort):
(MacPort.is_crash_reporter):
(MacPort.release_http_lock):
* Scripts/webkitpy/layout_tests/port/test.py:
(TestDriver.run_test):
* Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitDriver.__init__):
(WebKitDriver._start):
(WebKitDriver.has_crashed):
(WebKitDriver._check_for_driver_crash):
(WebKitDriver.run_test):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111661
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Thu, 22 Mar 2012 08:06:37 +0000 (08:06 +0000)]
Expand RenderTextControlSingleLine::controlClipRect() to contain contentRect().
https://bugs.webkit.org/show_bug.cgi?id=81866
Reviewed by Hajime Morita.
We need to expand the controlClipRect because the existing shadow
tree of a text field can be wrapped by another shadow tree. e.g.
A current situation:
<input>
┗ ShadowRoot
┗ container element
┌────────────┐<input>'s border box
│┌──────────┐│
││container box ││
│└──────────┘│
└────────────┘
Wrapped by another ShadowRoot:
<input>
┗ New ShadowRoot
┣ <shadow> represents the existing shadow tree
┃ ┗ container element
┗ D: an additional decoration element
┌────────────┐<input>'s border box
│┌───────┬──┐│
││container box │ D ││
│└───────┴──┘│
└────────────┘
In this case, if we clip child renderers by container box, D is not
drawn. We should clip by the content box of the <input>.
A search field has an exceptional behavior. It can have the container
box of which height is taller than the content box height. The
controlClipRect should contain both of the container box and the content
box in this case. In other cases, the container box is equivalent to the
content box. So the code always unites them.
No new tests. This won't make any behavior change for now.
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::controlClipRect):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111660
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 22 Mar 2012 08:04:11 +0000 (08:04 +0000)]
[Forms] The option element should not be form associated element.
https://bugs.webkit.org/show_bug.cgi?id=79764
Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-03-22
Reviewed by Kent Tamura.
Source/WebCore:
This patch changes base class of HTMLOptionELement to HTMLElement
from HTMLFormControlElement for saving memory space and iteration
time of extra "option" elements in HTMLFormElement::m_formAssociatedElements
and matching the HTML5 specification for ease of maintenance.
This patch changes behavior of handling of CSS pseudo classes "invalid"
and "valid". The "option" elements no longer use these CSS pseudo classes
as HTML5 specification. This bug was filed in https://bugs.webkit.org/show_bug.cgi?id=80088
Changes of TextIterator is lead by usage of isFormControlElement. This
changes will be replaced with more meaningful predicate as part of
https://bugs.webkit.org/show_bug.cgi?id=80381
No new tests but updated select-live-pseudo-selectors.html test.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::canShareStyleWithElement): Added checking of the "option" element and returns false as HTMLFormControlElement.
* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOneSelector): Removed isFormControlElement for PseudoDisabled and PseudoChecked.
* html/HTMLKeygenElement.cpp:
(WebCore::HTMLKeygenElement::HTMLKeygenElement): Removed form parameter of call site of HTMLOptionElement::create.
* html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::HTMLOptionElement): Removed form parameter which no longer needed. Changed base class in initialization list. Added m_disabled initialization.
(WebCore::HTMLOptionElement::create): Removed form parameter which no longer needed.
(WebCore::HTMLOptionElement::attach): Changeid base class.
(WebCore::HTMLOptionElement::detach): Changed base class.
(WebCore::HTMLOptionElement::parseAttribute): Changed base class. Added "disabled" attribute handling.
(WebCore::HTMLOptionElement::childrenChanged): Changed base class.
(WebCore::HTMLOptionElement::insertedIntoTree): Changed base class.
* html/HTMLOptionElement.h:
(HTMLOptionElement): Added new member variable m_disabled which was in HTMLFormControlElement.
(WebCore::HTMLOptionElement::ownElementDisabled): Changed for using m_disabled.
* html/HTMLTagNames.in: Removed constructorNeedsFormElement for the "option" element, which was used for passing form parameter to create function.
LayoutTests:
This patch fixes a bug in select-live-pseudo-selectors.js, adds
assertions to improve coverage, and updates test expectation for
behavior changes (makes the "option" element uses CSS pseudo class
":valid".)
* fast/forms/resources/select-live-pseudo-selectors.js:
(mouseDownOnSelect): Copied from listbox-selection.html for replacing broken simulateClick which used position and size of the "option" element, but these values are zero. Note: five files use mouseDownOnSelect. We'll share this function in future tracked by https://bugs.webkit.org/show_bug.cgi?id=81496.
(backgroundOf): Added String parameter support for ease of writing test case.
* fast/forms/select-live-pseudo-selectors-expected.txt: Added check fo background color of the "selection" element. Changed expected color of the "option" element because the "option" element doesn't support CSS pseudo class ":valid". This also covers bug 80088.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111659
268f45cc-cd09-0410-ab3c-
d52691b4dbfc