WebKit-https.git
9 years agoReuse buffer allocation if canvas size does not change
commit-queue@webkit.org [Tue, 20 Mar 2012 21:39:27 +0000 (21:39 +0000)]
Reuse buffer allocation if canvas size does not change
https://bugs.webkit.org/show_bug.cgi?id=80871

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-03-20
Reviewed by Stephen White.

Source/WebCore:

If the user changes the width or height attributes of a canvas element,
the contents of the canvas should be cleared and the context state
should be reset. This has become a common idiom to clear the canvas
"efficiently" at the start of a frame.

Previously, this code path triggered a full reallocation of the image
buffer backing the canvas, leading to reduced performance. This patch
implements an optimization where we reuse the previous image buffer
allocation if the size of the canvas did not change. Also, instead of
clearing the canvas every time its dimensions are touched, we only clear
if anything has been drawn into the canvas since it was previously
cleared.

Note that for now this optimization only applies for 2D canvases,
since it is not entirely clear how touching the dimensions of a WebGL
canvas should work.

Test: fast/canvas/canvas-resize-after-paint-without-layout.html +
      existing layout tests for canvas resetting.

* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::HTMLCanvasElement):
(WebCore::HTMLCanvasElement::reset):
(WebCore::HTMLCanvasElement::createImageBuffer):
(WebCore::HTMLCanvasElement::clearImageBuffer):
(WebCore):
(WebCore::HTMLCanvasElement::clearCopiedImage):
* html/HTMLCanvasElement.h:
(HTMLCanvasElement):
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D): Save the
initial graphics context state so we can restore it without creating a
new context.
(WebCore::CanvasRenderingContext2D::unwindStateStack):
(WebCore::CanvasRenderingContext2D::reset): No need to notify the
compositor when the context is reset, because clearing the image buffer
does the same thing. We can also skip the notification if we did not
have an image buffer at the time of the reset, because the reset will
not have any visual impact in this case. Finally, if the canvas size
did change, the notification is also unnecessary because of the call
to RenderObject::repaint() from HTMLCanvasElement::reset().

LayoutTests:

Add layout test to check canvas resizing without changing its layout size.

We also update the expected image one canvas clearing test. The test
is setting the size of a canvas and expecting it to be cleared in the process.
With the optimization to retain the underlying ImageBuffer, we no longer call
RenderReplaced::repaint() as a part of this process. This function used to
repaint both the canvas itself (100x50) as well as its local selection
rectangle (100x54).

In this case the local selection rectangle is larger than the canvas because
the canvas is contained within an anonymous RenderBlock that also has two empty
text nodes. The extra 4 pixels are needed for drawing the selection rectangle
around any descenders in the the text of those nodes.

Since clearing the canvas has no effect on the selection rectangle, we only
need to repaint the area of the canvas itself.

* fast/canvas/canvas-resize-after-paint-without-layout.html: Added.
* fast/canvas/canvas-resize-after-paint-without-layout-expected.txt: Added.
* platform/chromium-linux/fast/canvas/canvas-resize-after-paint-without-layout-expected.png: Added.
* platform/chromium-linux/fast/canvas/setWidthResetAfterForcedRender-expected.png: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Allow us to disable overdraw metrics when tracing is off
commit-queue@webkit.org [Tue, 20 Mar 2012 21:34:10 +0000 (21:34 +0000)]
[chromium] Allow us to disable overdraw metrics when tracing is off
https://bugs.webkit.org/show_bug.cgi?id=81431

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-20
Reviewed by Adrienne Walker.

Source/WebCore:

This change allows us to disable overdraw metrics conditionally in the
future with a one-line change in each LayerTreeHost class.

Unit test: CCQuadCullerTest.verifyWithoutMetrics

* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::paintLayerContents):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
* platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
(WebCore::::CCOcclusionTrackerBase):
(WebCore):
* platform/graphics/chromium/cc/CCOcclusionTracker.h:
(CCOcclusionTrackerBase):
* platform/graphics/chromium/cc/CCOverdrawMetrics.cpp:
(WebCore::CCOverdrawMetrics::CCOverdrawMetrics):
(WebCore::CCOverdrawMetrics::didCull):
(WebCore::CCOverdrawMetrics::didDraw):
(WebCore::CCOverdrawMetrics::recordMetrics):
* platform/graphics/chromium/cc/CCOverdrawMetrics.h:
(WebCore::CCOverdrawMetrics::create):
(CCOverdrawMetrics):

Source/WebKit/chromium:

* tests/CCOcclusionTrackerTest.cpp:
(WebCore::TestCCOcclusionTrackerBase::TestCCOcclusionTrackerBase):
* tests/CCQuadCullerTest.cpp:
(WebCore::TestCCOcclusionTrackerImpl::TestCCOcclusionTrackerImpl):
(WebCore::TEST):
(WebCore):
* tests/TiledLayerChromiumTest.cpp:
(WTF::TestCCOcclusionTracker::TestCCOcclusionTracker):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdded Mac WebKit2 expected results for this test. <http://webkit.org/b/81700> tracks the
mitz@apple.com [Tue, 20 Mar 2012 21:33:55 +0000 (21:33 +0000)]
Added Mac WebKit2 expected results for this test. <webkit.org/b/81700> tracks the
difference in results between WebKit1 and WebKit2 in this test.

* platform/mac-wk2/fast/dom: Added.
* platform/mac-wk2/fast/dom/horizontal-scrollbar-in-rtl-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUse-after-free of continuation in RenderBlock::paintContinuationOutlines()
robert@webkit.org [Tue, 20 Mar 2012 21:31:46 +0000 (21:31 +0000)]
Use-after-free of continuation in RenderBlock::paintContinuationOutlines()
https://bugs.webkit.org/show_bug.cgi?id=81276

Reviewed by David Hyatt.

Source/WebCore:

Test: fast/css/relative-positioned-block-crash.html

https://trac.webkit.org/changeset/108185/ allowed anonymous blocks to get their own layer (when they're
relatively positioned). This broke the dependency in addContinuationWithOutline() on the owner of the continuation
table and the renderer getting added to it always being in the same layer. When they're not in the same layer
there's no guarantee that the owner of the continuation table will get painted again and so avoid any stale pointers
in its continuation table should any of the renderers in there get destroyed.

Fix this for now by only adding renderers to the containing block's continuation table if we don't have our own layer.
This fix causes fast/inline/continuation-outlines-with-layers.html to regress as it uses blocks inside relatively positioned
inlines, so skip it on all platforms pending a medium-term fix.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintObject):

LayoutTests:

* fast/css/relative-positioned-block-crash-expected.txt: Added.
* fast/css/relative-positioned-block-crash.html: Added.
* platform/chromium/test_expectations.txt: Skip fast/inline/continuation-outlines-with-layers.html for now.
* platform/gtk/Skipped: ditto
* platform/mac/Skipped: ditto
* platform/qt/Skipped: ditto
* platform/win/Skipped: ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/JavaScriptCore: Move WTF-related Windows project files out of JavaScriptCore
sfalken@apple.com [Tue, 20 Mar 2012 21:25:32 +0000 (21:25 +0000)]
Source/JavaScriptCore: Move WTF-related Windows project files out of JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=80680

This change only moves the vcproj and related files from JavaScriptCore/JavaScriptCore.vcproj/WTF.
It does not move any source code. This is in preparation for the WTF source move out of
JavaScriptCore.

Reviewed by Jessie Berlin.

* JavaScriptCore.vcproj/JavaScriptCore.sln:
* JavaScriptCore.vcproj/JavaScriptCoreSubmit.sln:
* JavaScriptCore.vcproj/WTF: Removed.
* JavaScriptCore.vcproj/WTF/WTF.vcproj: Removed.
* JavaScriptCore.vcproj/WTF/WTFCommon.vsprops: Removed.
* JavaScriptCore.vcproj/WTF/WTFDebug.vsprops: Removed.
* JavaScriptCore.vcproj/WTF/WTFDebugAll.vsprops: Removed.
* JavaScriptCore.vcproj/WTF/WTFDebugCairoCFLite.vsprops: Removed.
* JavaScriptCore.vcproj/WTF/WTFGenerated.make: Removed.
* JavaScriptCore.vcproj/WTF/WTFGenerated.vcproj: Removed.
* JavaScriptCore.vcproj/WTF/WTFGeneratedCommon.vsprops: Removed.
* JavaScriptCore.vcproj/WTF/WTFGeneratedDebug.vsprops: Removed.
* JavaScriptCore.vcproj/WTF/WTFGeneratedDebugAll.vsprops: Removed.
* JavaScriptCore.vcproj/WTF/WTFGeneratedDebugCairoCFLite.vsprops: Removed.
* JavaScriptCore.vcproj/WTF/WTFGeneratedProduction.vsprops: Removed.
* JavaScriptCore.vcproj/WTF/WTFGeneratedRelease.vsprops: Removed.
* JavaScriptCore.vcproj/WTF/WTFGeneratedReleaseCairoCFLite.vsprops: Removed.
* JavaScriptCore.vcproj/WTF/WTFPostBuild.cmd: Removed.
* JavaScriptCore.vcproj/WTF/WTFPreBuild.cmd: Removed.
* JavaScriptCore.vcproj/WTF/WTFProduction.vsprops: Removed.
* JavaScriptCore.vcproj/WTF/WTFRelease.vsprops: Removed.
* JavaScriptCore.vcproj/WTF/WTFReleaseCairoCFLite.vsprops: Removed.
* JavaScriptCore.vcproj/WTF/build-generated-files.sh: Removed.
* JavaScriptCore.vcproj/WTF/copy-files.cmd: Removed.
* JavaScriptCore.vcproj/WTF/work-around-vs-dependency-tracking-bugs.py: Removed.

Source/WebKit/win: Move WTF-related Windows project files out of JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=80680

Reviewed by Jessie Berlin.

* WebKit.vcproj/WebKit.sln:

Source/WTF: Move WTF-related Windows project files out of JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=80680

This change only moves the vcproj and related files from JavaScriptCore/JavaScriptCore.vcproj/WTF.
It does not move any source code. This is in preparation for the WTF source move out of
JavaScriptCore.

Reviewed by Jessie Berlin.

* WTF.vcproj: Added.
* WTF.vcproj/WTF.vcproj: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTF.vcproj.
* WTF.vcproj/WTFCommon.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFCommon.vsprops.
* WTF.vcproj/WTFDebug.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFDebug.vsprops.
* WTF.vcproj/WTFDebugAll.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFDebugAll.vsprops.
* WTF.vcproj/WTFDebugCairoCFLite.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFDebugCairoCFLite.vsprops.
* WTF.vcproj/WTFGenerated.make: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFGenerated.make.
* WTF.vcproj/WTFGenerated.vcproj: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFGenerated.vcproj.
* WTF.vcproj/WTFGeneratedCommon.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFGeneratedCommon.vsprops.
* WTF.vcproj/WTFGeneratedDebug.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFGeneratedDebug.vsprops.
* WTF.vcproj/WTFGeneratedDebugAll.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFGeneratedDebugAll.vsprops.
* WTF.vcproj/WTFGeneratedDebugCairoCFLite.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFGeneratedDebugCairoCFLite.vsprops.
* WTF.vcproj/WTFGeneratedProduction.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFGeneratedProduction.vsprops.
* WTF.vcproj/WTFGeneratedRelease.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFGeneratedRelease.vsprops.
* WTF.vcproj/WTFGeneratedReleaseCairoCFLite.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFGeneratedReleaseCairoCFLite.vsprops.
* WTF.vcproj/WTFPostBuild.cmd: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFPostBuild.cmd.
* WTF.vcproj/WTFPreBuild.cmd: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFPreBuild.cmd.
* WTF.vcproj/WTFProduction.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFProduction.vsprops.
* WTF.vcproj/WTFRelease.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFRelease.vsprops.
* WTF.vcproj/WTFReleaseCairoCFLite.vsprops: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTFReleaseCairoCFLite.vsprops.
* WTF.vcproj/build-generated-files.sh: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/build-generated-files.sh.
* WTF.vcproj/copy-files.cmd: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/copy-files.cmd.
* WTF.vcproj/work-around-vs-dependency-tracking-bugs.py: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/work-around-vs-dependency-tracking-bugs.py.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWork around the inconsistency in test results caused by <http://webkit.org/b/81696...
mitz@apple.com [Tue, 20 Mar 2012 21:19:31 +0000 (21:19 +0000)]
Work around the inconsistency in test results caused by <webkit.org/b/81696> in a few
tests, by appending a # character to the href attributes of links to other tests. This
ensures that they are never visited.

* fast/block/margin-collapse/001.html:
* fast/block/margin-collapse/005.html:
* fast/block/margin-collapse/010.html:
* fast/block/margin-collapse/011.html:
* fast/block/margin-collapse/012.html:
* fast/block/margin-collapse/015.html:
* fast/block/margin-collapse/016.html:
* fast/block/margin-collapse/017.html:
* fast/block/margin-collapse/020.html:
* fast/block/margin-collapse/056.html:
* fast/block/margin-collapse/059.html:
* fast/block/margin-collapse/block-inside-inline/001.html:
* fast/block/margin-collapse/block-inside-inline/005.html:
* fast/block/margin-collapse/block-inside-inline/010.html:
* fast/block/margin-collapse/block-inside-inline/011.html:
* fast/block/margin-collapse/block-inside-inline/012.html:
* fast/block/margin-collapse/block-inside-inline/015.html:
* fast/block/margin-collapse/block-inside-inline/016.html:
* fast/block/margin-collapse/block-inside-inline/017.html:
* fast/block/margin-collapse/block-inside-inline/020.html:
* platform/mac/fast/block/margin-collapse/056-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: "Attempt to insert nil value " exception when calling attributed...
adele@apple.com [Tue, 20 Mar 2012 21:05:32 +0000 (21:05 +0000)]
Source/WebCore: "Attempt to insert nil value " exception when calling attributed string APIs on content with a custom font
https://bugs.webkit.org/show_bug.cgi?id=81630
<rdar://problem/10650660>

Reviewed by Alexey Proskuryakov.

Test: TestWebKitAPI/Tests/mac/AttributedString.mm

If content is using a custom font, then the platform font will be nil and needs to be nil checked.

* platform/mac/HTMLConverter.mm: (+[WebHTMLConverter editingAttributedStringFromRange:]):

Tools: "Attempt to insert nil value " exception when calling attributed string APIs on content with a custom font
https://bugs.webkit.org/show_bug.cgi?id=81630
<rdar://problem/10650660>

Reviewed by Alexey Proskuryakov.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/mac/Ahem.ttf: Added.
* TestWebKitAPI/Tests/mac/AttributedString.mm: Added.
(-[AttributedStringTest webView:didFinishLoadForFrame:]):
(TestWebKitAPI):
(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/mac/attributedStringCustomFont.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake distributeExtraLogicalHeightToRows return the consumed logical height
jchaffraix@webkit.org [Tue, 20 Mar 2012 21:02:34 +0000 (21:02 +0000)]
Make distributeExtraLogicalHeightToRows return the consumed logical height
https://bugs.webkit.org/show_bug.cgi?id=81678

Reviewed by Tony Chang.

Small refactoring, no change in behavior.

* rendering/RenderTable.cpp:
(WebCore::RenderTable::distributeExtraLogicalHeight):
Remove the consumed logical height from the available height.

* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::distributeExtraLogicalHeightToPercentRows):
(WebCore::RenderTableSection::distributeExtraLogicalHeightToAutoRows):
(WebCore::RenderTableSection::distributeRemainingExtraLogicalHeight):
Changed those method to not return anything but remove from the available width.

(WebCore::RenderTableSection::distributeExtraLogicalHeightToRows):
Return the consumed logical height.

* rendering/RenderTableSection.h:
Updated the previous distribute functions signature and the comment about
the returned value from distributeExtraLogicalHeightToRows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Dijit crash WebCore::CookieManager::getRawCookies
commit-queue@webkit.org [Tue, 20 Mar 2012 20:56:39 +0000 (20:56 +0000)]
[BlackBerry] Dijit crash WebCore::CookieManager::getRawCookies
https://bugs.webkit.org/show_bug.cgi?id=81686

Patch by Jacky Jiang <zhajiang@rim.com> on 2012-03-20
Reviewed by Rob Buis.

Source/WebCore:

HTML plugin element with an empty src caused an ASSERT failure on debug
build and a crash on release build.
When getting cookie, url can be null, so we need to check for it to
avoid the crash.

No new tests as this is covered by
LayoutTests/fast/loader/empty-embed-src-attribute.html.

* platform/network/blackberry/ResourceRequestBlackBerry.cpp:
(WebCore::ResourceRequest::initializePlatformRequest):

Source/WebKit/blackberry:

When deciding the policy for navigation action, if the url of the
request is null, ignore it to avoid the ASSERT failure in
MainResourceLoader::willSendRequest.

* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNavigationAction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCache the type string of JavaScript object
benjamin@webkit.org [Tue, 20 Mar 2012 20:22:57 +0000 (20:22 +0000)]
Cache the type string of JavaScript object
https://bugs.webkit.org/show_bug.cgi?id=81446

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-03-20
Reviewed by Geoffrey Garen.

Instead of creating the JSString every time, we create
lazily the strings in JSGlobalData.

This avoid the construction of the StringImpl and of the JSString,
which gives some performance improvements.

* runtime/CommonIdentifiers.h:
* runtime/JSValue.cpp:
(JSC::JSValue::toStringSlowCase):
* runtime/Operations.cpp:
(JSC::jsTypeStringForValue):
* runtime/SmallStrings.cpp:
(JSC::SmallStrings::SmallStrings):
(JSC::SmallStrings::finalizeSmallStrings):
(JSC::SmallStrings::initialize):
(JSC):
* runtime/SmallStrings.h:
(SmallStrings):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd link on queues.webkit.org to kov's fancy queue-depth graph
eric@webkit.org [Tue, 20 Mar 2012 20:07:01 +0000 (20:07 +0000)]
Add link on queues.webkit.org to kov's fancy queue-depth graph
https://bugs.webkit.org/show_bug.cgi?id=81690

Reviewed by Adam Barth.

* QueueStatusServer/templates/recentstatus.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAllow LLINT to work even when executable allocation fails.
oliver@apple.com [Tue, 20 Mar 2012 20:02:05 +0000 (20:02 +0000)]
Allow LLINT to work even when executable allocation fails.
https://bugs.webkit.org/show_bug.cgi?id=81693

Reviewed by Gavin Barraclough.

Don't crash if executable allocation fails if we can fall back on LLINT

* jit/ExecutableAllocatorFixedVMPool.cpp:
(JSC::FixedVMPoolExecutableAllocator::FixedVMPoolExecutableAllocator):
* wtf/OSAllocatorPosix.cpp:
(WTF::OSAllocator::reserveAndCommit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Tabbed pane drop down should be sorted.
vsevik@chromium.org [Tue, 20 Mar 2012 19:58:19 +0000 (19:58 +0000)]
Web Inspector: Tabbed pane drop down should be sorted.
https://bugs.webkit.org/show_bug.cgi?id=81680

Reviewed by Pavel Feldman.

* inspector/front-end/TabbedPane.js:
(WebInspector.TabbedPane.prototype._populateDropDownFromIndex.compareFunction):
(WebInspector.TabbedPane.prototype._populateDropDownFromIndex):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[mac] Restore color space switching code to run-webkit-tests
timothy_horton@apple.com [Tue, 20 Mar 2012 19:58:02 +0000 (19:58 +0000)]
[mac] Restore color space switching code to run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=80571
<rdar://problem/11008529>

Reviewed by Simon Fraser.

Make use of the layout test helper hooks to restore the Mac system-wide
color profile switching code. This makes WkTR and DRT results match, and
causes the main display's color profile to not affect results on Lion.

* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
* DumpRenderTree/mac/LayoutTestHelper.m: Added.
(installLayoutTestColorProfile):
(restoreUserColorProfile):
(simpleSignalHandler):
(main):
* Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort.release_http_lock):
(MacPort):
(MacPort._path_to_helper):
(MacPort.start_helper):
(MacPort.stop_helper):
* WebKitTestRunner/mac/PlatformWebViewMac.mm:
(WTR::PlatformWebView::PlatformWebView):
(WTR::PlatformWebView::windowSnapshotImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Open resource dialog scripts list should be sorted.
vsevik@chromium.org [Tue, 20 Mar 2012 19:53:36 +0000 (19:53 +0000)]
Web Inspector: Open resource dialog scripts list should be sorted.
https://bugs.webkit.org/show_bug.cgi?id=81682

Reviewed by Pavel Feldman.

* inspector/front-end/FilteredItemSelectionDialog.js:
(WebInspector.OpenResourceDialog.compareFunction):
(WebInspector.OpenResourceDialog):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdded Mac WebKit2 expected results for this test. <http://webkit.org/b/81679> tracks the
mitz@apple.com [Tue, 20 Mar 2012 19:52:30 +0000 (19:52 +0000)]
Added Mac WebKit2 expected results for this test. <webkit.org/b/81679> tracks the
difference in results between WebKit1 and WebKit2 in this test.

* platform/mac-wk2/compositing/geometry: Added.
* platform/mac-wk2/compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt: Copied from LayoutTests/compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Use opaque contents for paint culling
commit-queue@webkit.org [Tue, 20 Mar 2012 19:51:20 +0000 (19:51 +0000)]
[chromium] Use opaque contents for paint culling
https://bugs.webkit.org/show_bug.cgi?id=81676

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-20
Reviewed by Adrienne Walker.

Source/WebCore:

UnitTest: CCLayerTreeHostTestContentLayerOcclusion

* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::paintLayerContents):

Source/WebKit/chromium:

* tests/CCLayerTreeHostTest.cpp:
(WTF::TestLayerChromium::opaqueContentsRegion):
(WTF::TestLayerChromium::setOpaqueContentsRect):
(TestLayerChromium):
(CCLayerTreeHostTestContentLayerOcclusion):
(WTF::CCLayerTreeHostTestContentLayerOcclusion::CCLayerTreeHostTestContentLayerOcclusion):
(WTF::CCLayerTreeHostTestContentLayerOcclusion::beginTest):
(WTF::CCLayerTreeHostTestContentLayerOcclusion::afterTest):
(WTF):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Updating Chromium expectations following r111412.
leviw@chromium.org [Tue, 20 Mar 2012 19:47:22 +0000 (19:47 +0000)]
[Chromium] Updating Chromium expectations following r111412.

* platform/chromium-win/compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix after r111419.
mitz@apple.com [Tue, 20 Mar 2012 19:04:16 +0000 (19:04 +0000)]
Build fix after r111419.

* dom/WebKitNamedFlow.cpp:
* dom/WebKitNamedFlow.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION (r111229): css1/basic/inheritance.html is failing
mitz@apple.com [Tue, 20 Mar 2012 18:37:58 +0000 (18:37 +0000)]
REGRESSION (r111229): css1/basic/inheritance.html is failing
https://bugs.webkit.org/show_bug.cgi?id=81684

Reverted r111229.

Rubber-stamped by Dave Hyatt.

Source/WebCore:

* dom/Document.cpp:
(WebCore::Document::webkitGetFlowByName):
* dom/Document.h:
(Document):
* dom/Element.cpp:
(WebCore::Element::detach):
* dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):
* dom/WebKitNamedFlow.cpp:
(WebCore):
* dom/WebKitNamedFlow.h:
(WebCore):
(WebKitNamedFlow):
* dom/WebKitNamedFlow.idl:

LayoutTests:

* fast/regions/webkit-named-flow-content-nodes-expected.txt: Removed.
* fast/regions/webkit-named-flow-content-nodes.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=80696
commit-queue@webkit.org [Tue, 20 Mar 2012 18:26:51 +0000 (18:26 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=80696
Remove custom bindings for attribute type Array.

Patch by Vineet Chaudhary <rgf748@motorola.com> on 2012-03-20
Reviewed by Kentaro Hara.

No new tests.

* bindings/js/JSConsoleCustom.cpp: Removed custom function.
(WebCore):
* bindings/js/JSDOMBinding.h: Added template jsArray and toNativeArray.
(WebCore):
(WebCore::jsArray):
(WebCore::toNativeArray):
* bindings/scripts/CodeGenerator.pm: Modified codegenerators to generate appropriate code.
(GetArrayType): Added GetArrayType to get return type of attribute interface.
* bindings/scripts/CodeGeneratorGObject.pm: Modified codegenerators to generate appropriate code.
(SkipAttribute):
* bindings/scripts/CodeGeneratorJS.pm: Modified codegenerators to generate appropriate code.
(AddIncludesForType):
(JSValueToNative):
(NativeToJSValue):
* bindings/scripts/CodeGeneratorV8.pm: Modified codegenerators to generate appropriate code.
(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(JSValueToNative):
(NativeToJSValue):
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: Updated results from running binding tests.
(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_class_init):
* bindings/scripts/test/GObject/WebKitDOMTestObj.h: Ditto.
* bindings/scripts/test/JS/JSTestObj.cpp: Ditto.
(WebCore::jsTestObjSequenceAttr):
(WebCore::setJSTestObjSequenceAttr):
(WebCore::jsTestObjPrototypeFunctionMethodReturningSequence):
* bindings/scripts/test/V8/V8TestObj.cpp: Ditto.
(WebCore::TestObjInternal::sequenceAttrAttrGetter):
(WebCore::TestObjInternal::sequenceAttrAttrSetter):
(WebCore::TestObjInternal::methodReturningSequenceCallback):
* bindings/v8/V8Binding.h: Added template v8Array and toNativeArray.
(WebCore):
(WebCore::v8Array):
(WebCore::toNativeArray):
* bindings/v8/custom/V8ConsoleCustom.cpp: Removed custom function.
(WebCore):
* page/Console.idl: Replaced attribute type Array to sequence<SriptProfile> to remove
  custom bindings.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r111310.
commit-queue@webkit.org [Tue, 20 Mar 2012 18:18:22 +0000 (18:18 +0000)]
Unreviewed, rolling out r111310.
http://trac.webkit.org/changeset/111310
https://bugs.webkit.org/show_bug.cgi?id=81683

Broke layout test
dom/xhtml/level3/core/nodereplacechild30.xhtml (Requested by
aklein on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-20

* dom/ContainerNode.cpp:
(WebCore::ContainerNode::replaceChild):
(WebCore::ContainerNode::appendChild):
(WebCore::ContainerNode::parserAddChild):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2012-02-24 Darin Fisher <darin@chromium.org>
darin@chromium.org [Tue, 20 Mar 2012 18:12:49 +0000 (18:12 +0000)]
2012-02-24  Darin Fisher  <darin@chromium.org>

        Add more Chromium WebKit API reviewers
        https://bugs.webkit.org/show_bug.cgi?id=81576

        Reviewed by Adam Barth and David Levin.

        Simplify watchlist to lump all WebKit API into one.

        * Scripts/webkitpy/common/config/watchlist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago WebProcess should use private temporary and cache directories
ap@apple.com [Tue, 20 Mar 2012 18:08:15 +0000 (18:08 +0000)]
    WebProcess should use private temporary and cache directories
        https://bugs.webkit.org/show_bug.cgi?id=80876

        Reviewed by Sam Weinig.

        * Shared/WebProcessCreationParameters.cpp:
        (WebKit::WebProcessCreationParameters::encode):
        (WebKit::WebProcessCreationParameters::decode):
        * Shared/WebProcessCreationParameters.h: (WebProcessCreationParameters):
        * UIProcess/mac/WebContextMac.mm: (WebKit::WebContext::platformInitializeWebProcess):
        Always pass uiProcessBundleIdentifier to WebProcess on Mac, it's now used for more than
        CFURL sessions.

        * WebProcess/com.apple.WebProcess.sb.in: Limit old workaround to platforms that need it.

        * WebProcess/mac/WebProcessMac.mm: (WebKit::initializeSandbox): Tell confstr to use a suffix
        on user directories.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdated expected results for a test, while <http://webkit.org/b/81679> is tracking...
mitz@apple.com [Tue, 20 Mar 2012 18:02:25 +0000 (18:02 +0000)]
Updated expected results for a test, while <webkit.org/b/81679> is tracking this
possible regression.

* compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoConvert regions parsing test to use testharness.js
commit-queue@webkit.org [Tue, 20 Mar 2012 17:56:15 +0000 (17:56 +0000)]
Convert regions parsing test to use testharness.js
https://bugs.webkit.org/show_bug.cgi?id=80709

Patch by Jacob Goldstein <jacobg@adobe.com> on 2012-03-20
Reviewed by Ryosuke Niwa.

* fast/regions/script-tests/webkit-flow-parsing.js:
(testParse):
(testComputedStyle):
(testNotInherited):
(test):
* fast/regions/webkit-flow-parsing-expected.txt:
* fast/regions/webkit-flow-parsing.html:
* resources/testharness.js: Added.
(.):
* resources/testharnessreport.js: Added.
(convertResult):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed test fix and unskip.
vsevik@chromium.org [Tue, 20 Mar 2012 17:46:41 +0000 (17:46 +0000)]
Unreviewed test fix and unskip.

* inspector/debugger/snippets-model-expected.txt:
* inspector/debugger/snippets-model.html:
* platform/gtk/Skipped:
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Adding missing linux expectations for error-to-string-stack-overflow.
leviw@chromium.org [Tue, 20 Mar 2012 17:25:55 +0000 (17:25 +0000)]
[Chromium] Adding missing linux expectations for error-to-string-stack-overflow.

* platform/chromium-linux/fast/dom/error-to-string-stack-overflow-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoGraphic distortion effect when launching with empty page Safari after reset
andersca@apple.com [Tue, 20 Mar 2012 17:21:00 +0000 (17:21 +0000)]
Graphic distortion effect when launching with empty page Safari after reset
https://bugs.webkit.org/show_bug.cgi?id=81677
<rdar://problem/11065904>

Reviewed by Sam Weinig.

Don't set the redraw policy to never, since that was causing the WKView layer to never be updated. Instead,
let AppKit decide which redraw policy to use.

* UIProcess/API/mac/WKView.mm:
(-[WKView initWithFrame:contextRef:pageGroupRef:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Adding missing results for canvas-putImageData for Windows.
leviw@chromium.org [Tue, 20 Mar 2012 17:18:40 +0000 (17:18 +0000)]
[Chromium] Adding missing results for canvas-putImageData for Windows.

* platform/chromium-win/fast/repaint/canvas-putImageData-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoConvert hasSpellingMarker to use Internals interface.
gyuyoung.kim@samsung.com [Tue, 20 Mar 2012 16:59:44 +0000 (16:59 +0000)]
Convert hasSpellingMarker to use Internals interface.
https://bugs.webkit.org/show_bug.cgi?id=81300

Reviewed by Ryosuke Niwa.

.:

* Source/autotools/symbols.filter: Export a symbol for hasSpellingMarker.

Source/WebCore:

Remove hasSpellingMarker functions, because it is able to work in the
cross-port way through the Internals interface.

No new tests, since we are improving here the infra-structure
for testing a specific method.

* testing/Internals.cpp:
(WebCore::Internals::hasSpellingMarker):
(WebCore):
* testing/Internals.h:
(Internals):
* testing/Internals.idl:

Source/WebKit/gtk:

Remove DumpRenderTreeSupportGtk::webkitWebFrameSelectionHasSpellingMarker support,
since it can support in the cross-port way through the Internals interface.

* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
* WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):

Source/WebKit/mac:

Remove hasSpellingMarker support, since it can support in the cross-port way
through the Internals interface.

* WebKit.order:
* WebView/WebFrame.mm:
* WebView/WebFramePrivate.h:

Source/WebKit/win:

Remove hasSpellingMarker interface support, since it can support in the cross-port
way through the Internals interface.

* Interfaces/IWebFramePrivate.idl:

Source/WebKit2:

* win/WebKit2.def: Export a symbol for hasSpellingMarker.

Tools:

Remove hasSpellingMarker functions, because it is able to work in the
cross-port way through the Internals interface.

* DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::staticFunctions):
* DumpRenderTree/LayoutTestController.h:
(LayoutTestController):
* DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
* DumpRenderTree/chromium/LayoutTestController.h:
(LayoutTestController):
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
* DumpRenderTree/qt/LayoutTestControllerQt.h:
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
* DumpRenderTree/wx/LayoutTestControllerWx.cpp:

LayoutTests:

Adjust hasSpellingMarker tests to use Internals instead of LayoutTestController
interface.

* editing/spelling/design-mode-spellcheck-off.html:
* editing/spelling/script-tests/spellcheck-paste.js:
(verifyMarker):
* editing/spelling/script-tests/spelling-attribute-at-child.js:
(childHasSpellingMarker):
* editing/spelling/script-tests/spelling-attribute-change.js:
(testSpellCheckingEnabled):
* editing/spelling/script-tests/spelling-backspace-between-lines.js:
(testWithDelete):
(testWithForwardDelete):
* editing/spelling/script-tests/spelling-hasspellingmarker.js:
(hasMarked):
* editing/spelling/spellcheck-attribute.html:
* editing/spelling/spelling-attribute-change-expected.txt:
* editing/spelling/spelling-backspace-between-lines-expected.txt:
* editing/spelling/spelling-hasspellingmarker-expected.txt:
* editing/spelling/spelling-linebreak.html:
* platform/chromium-mac-snowleopard/editing/spelling/spelling-backspace-between-lines-expected.txt:
* platform/chromium-win/editing/spelling/spelling-backspace-between-lines-expected.txt:
* platform/chromium/editing/spelling/spelling-backspace-between-lines-expected.txt:
* platform/mac/editing/spelling/delete-into-misspelled-word.html:
* platform/mac/editing/spelling/editing-multiple-words-with-markers.html:
* platform/mac/editing/spelling/editing-word-with-marker-1.html:
* platform/mac/editing/spelling/editing-word-with-marker-2.html:
* platform/mac/editing/spelling/move-cursor-around-misspelled-word.html:
* platform/win/editing/spelling/spelling-backspace-between-lines-expected.txt:
* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] BlackBerry can clear cookies and cache from the Web Inspector
commit-queue@webkit.org [Tue, 20 Mar 2012 16:40:46 +0000 (16:40 +0000)]
[BlackBerry] BlackBerry can clear cookies and cache from the Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=81670

Patch by Konrad Piascik <kpiascik@rim.com> on 2012-03-20
Reviewed by Rob Buis.

* WebCoreSupport/InspectorClientBlackBerry.h:
(WebCore::InspectorClientBlackBerry::canClearBrowserCache):
(WebCore::InspectorClientBlackBerry::canClearBrowserCookies):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd new Qt-WK2 performance tester bot to build.webkit.org
ossy@webkit.org [Tue, 20 Mar 2012 16:33:53 +0000 (16:33 +0000)]
Add new Qt-WK2 performance tester bot to build.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=80842

Reviewed by Ryosuke Niwa.

* BuildSlaveSupport/build.webkit.org-config/config.json:
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(RunAndUploadPerfTestsWebKit2):
(RunAndUploadPerfTestsWebKit2.start):
(BuildAndPerfTestWebKit2Factory):
(BuildAndPerfTestWebKit2Factory.__init__):
(DownloadAndPerfTestWebKit2Factory):
(DownloadAndPerfTestWebKit2Factory.__init__):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix.
mitz@apple.com [Tue, 20 Mar 2012 16:28:29 +0000 (16:28 +0000)]
Build fix.

* history/PageCache.cpp: Fixed an unused function warning introduced in r111391.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed. Added new platform expectations.
kkristof@inf.u-szeged.hu [Tue, 20 Mar 2012 16:27:44 +0000 (16:27 +0000)]
[Qt] Unreviewed. Added new platform expectations.
        Skipped. https://bugs.webkit.org/show_bug.cgi?id=81671

        * platform/qt-5.0-wk2/Skipped:
        * platform/qt-5.0-wk2/css1/basic/inheritance-expected.txt: Added after r111229.
        * platform/qt-5.0-wk2/platform/qt/plugins/application-plugin-plugins-disabled-expected.txt: Added after r111351.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago(r110063) m_mouseDownMayStartDrag is used without being behind the ENABLE(DRAG_SUPPOR...
commit-queue@webkit.org [Tue, 20 Mar 2012 16:17:57 +0000 (16:17 +0000)]
(r110063) m_mouseDownMayStartDrag is used without being behind the ENABLE(DRAG_SUPPORT) macro
https://bugs.webkit.org/show_bug.cgi?id=81666

Patch by Konrad Piascik <kpiascik@rim.com> on 2012-03-20
Reviewed by Rob Buis.

Compiled with feature disabled and built.

* page/EventHandler.cpp:
(WebCore::EventHandler::selectCursor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] [WK2] Add javascript clipboard functionality settings to WebKit2 GTK+ API.
mrobinson@webkit.org [Tue, 20 Mar 2012 15:38:40 +0000 (15:38 +0000)]
[GTK] [WK2] Add javascript clipboard functionality settings to WebKit2 GTK+ API.
https://bugs.webkit.org/show_bug.cgi?id=80981

Patch by Antaryami Pandia <antaryami.pandia@motorola.com> on 2012-03-20
Reviewed by Martin Robinson.

Add WebSettings to enable/disable javascript clipboard functionality.

* UIProcess/API/gtk/WebKitSettings.cpp:
(webKitSettingsSetProperty):
(webKitSettingsGetProperty):
(webkit_settings_class_init):
(webkit_settings_get_javascript_can_access_clipboard):
(webkit_settings_set_javascript_can_access_clipboard):
* UIProcess/API/gtk/WebKitSettings.h:
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
* UIProcess/API/gtk/tests/TestWebKitSettings.cpp:
(testWebKitSettings):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Removing doubly defined methods in BackingStore.cpp
commit-queue@webkit.org [Tue, 20 Mar 2012 15:31:16 +0000 (15:31 +0000)]
[BlackBerry] Removing doubly defined methods in BackingStore.cpp
https://bugs.webkit.org/show_bug.cgi?id=81664

Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-03-20
Reviewed by Rob Buis.

* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::drawAndBlendLayersForDirectRendering):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Marking compositing/iframes/scrolling-iframe.html as flaky on Linux
leviw@chromium.org [Tue, 20 Mar 2012 15:24:49 +0000 (15:24 +0000)]
[Chromium] Marking compositing/iframes/scrolling-iframe.html as flaky on Linux
as well.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Remove OutOfMemoryHandler from the build system
charles.wei@torchmobile.com.cn [Tue, 20 Mar 2012 15:03:33 +0000 (15:03 +0000)]
[BlackBerry] Remove OutOfMemoryHandler from the build system
https://bugs.webkit.org/show_bug.cgi?id=81649

Remove OutOfMemoryHandler, and change GLES2Context to WebKitSupport,
in the build system for BlackBerry porting.

Reviewed by Rob Buis.

* PlatformBlackBerry.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Tune fling physics curve. [Not for review yet]
wjmaclean@chromium.org [Tue, 20 Mar 2012 14:51:58 +0000 (14:51 +0000)]
[chromium] Tune fling physics curve. [Not for review yet]
https://bugs.webkit.org/show_bug.cgi?id=81398

Reviewed by James Robinson.

Source/WebCore:

Existing tests updated.

Tune physics of curve for better feel.

* platform/TouchFlingPlatformGestureCurve.cpp:
(WebCore::TouchFlingPlatformGestureCurve::apply):

Source/WebKit/chromium:

* tests/PlatformGestureCurveTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImplement a fast path when setting CSS properties with keywords from JS.
alexis.menard@openbossa.org [Tue, 20 Mar 2012 14:46:27 +0000 (14:46 +0000)]
Implement a fast path when setting CSS properties with keywords from JS.
https://bugs.webkit.org/show_bug.cgi?id=80874

Reviewed by Antti Koivisto.

The idea is to avoid the creation of the CSSParser instance and to run the parser on
a string we know it should be a keyword. When JS calls parseValue we try to check if we can
use the fast path and if the keyword is accepted then we just add it to the declaration directly.
For the sake of maintenance the parseValue function used by CSSGrammar.y is sharing some code with
the fast path (keyword matching mostly).

This patch improves this use case by 20%. Setting keyword properties from JS is used a lot in
Google Maps for example (when zooming or panning).

No new tests : it's a performance improvement, there shouldn't be any behavior change.

* css/CSSParser.cpp:
(WebCore):
(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::parseKeywordValue):
(WebCore::CSSParser::parseValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Infrastructure to allow animating layers to be only partially updated
commit-queue@webkit.org [Tue, 20 Mar 2012 14:42:28 +0000 (14:42 +0000)]
[chromium] Infrastructure to allow animating layers to be only partially updated
https://bugs.webkit.org/show_bug.cgi?id=81106

Patch by Ian Vollick <vollick@chromium.org> on 2012-03-20
Reviewed by James Robinson

Source/WebCore:

Merged the controller tests in CCLayerAnimationControllerTest

* WebCore.gypi:
* platform/graphics/chromium/GraphicsLayerChromium.cpp:
* platform/graphics/chromium/GraphicsLayerChromium.h:
(GraphicsLayerChromium):
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::pushPropertiesTo):
(WebCore::LayerChromium::setOpacityFromAnimation):
(WebCore):
(WebCore::LayerChromium::setTransformFromAnimation):
(WebCore::LayerChromium::addAnimation):
(WebCore::LayerChromium::pauseAnimation):
(WebCore::LayerChromium::removeAnimation):
(WebCore::LayerChromium::suspendAnimations):
(WebCore::LayerChromium::resumeAnimations):
(WebCore::LayerChromium::setLayerAnimationController):
(WebCore::LayerChromium::hasActiveAnimation):
(WebCore::LayerChromium::setAnimationEvent):
* platform/graphics/chromium/LayerChromium.h:
(WebCore):
(LayerChromium):
(WebCore::LayerChromium::id):
(WebCore::LayerChromium::opacity):
(WebCore::LayerChromium::transform):
(WebCore::LayerChromium::bounds):
* platform/graphics/chromium/cc/CCActiveAnimation.h:
(CCActiveAnimation):
* platform/graphics/chromium/cc/CCAnimationEvents.cpp:
(WebCore::CCAnimationEvent::CCAnimationEvent):
(WebCore::CCAnimationEvent::toFloatAnimationFinishedEvent):
(WebCore::CCAnimationEvent::toTransformAnimationFinishedEvent):
(WebCore::CCAnimationStartedEvent::create):
(WebCore):
(WebCore::CCAnimationStartedEvent::CCAnimationStartedEvent):
(WebCore::CCFloatAnimationFinishedEvent::create):
(WebCore::CCFloatAnimationFinishedEvent::CCFloatAnimationFinishedEvent):
(WebCore::CCFloatAnimationFinishedEvent::~CCFloatAnimationFinishedEvent):
(WebCore::CCFloatAnimationFinishedEvent::type):
(WebCore::CCTransformAnimationFinishedEvent::create):
(WebCore::CCTransformAnimationFinishedEvent::CCTransformAnimationFinishedEvent):
(WebCore::CCTransformAnimationFinishedEvent::~CCTransformAnimationFinishedEvent):
(WebCore::CCTransformAnimationFinishedEvent::type):
* platform/graphics/chromium/cc/CCAnimationEvents.h:
(WebCore):
(WebCore::CCAnimationEvent::targetProperty):
(CCAnimationEvent):
(CCAnimationStartedEvent):
(CCFloatAnimationFinishedEvent):
(WebCore::CCFloatAnimationFinishedEvent::finalValue):
(CCTransformAnimationFinishedEvent):
(WebCore::CCTransformAnimationFinishedEvent::finalValue):
* platform/graphics/chromium/cc/CCLayerAnimationController.cpp:
(WebCore::CCLayerAnimationController::CCLayerAnimationController):
(WebCore::CCLayerAnimationController::create):
(WebCore::CCLayerAnimationController::pushAnimationUpdatesTo):
(WebCore::CCLayerAnimationController::animate):
(WebCore):
(WebCore::CCLayerAnimationController::add):
(WebCore::CCLayerAnimationController::getActiveAnimation):
(WebCore::CCLayerAnimationController::hasActiveAnimation):
(WebCore::CCLayerAnimationController::isAnimatingProperty):
(WebCore::CCLayerAnimationController::pushNewAnimationsToImplThread):
(WebCore::CCLayerAnimationController::removeAnimationsCompletedOnMainThread):
(WebCore::CCLayerAnimationController::startAnimationsWaitingForNextTick):
(WebCore::CCLayerAnimationController::startAnimationsWaitingForStartTime):
(WebCore::CCLayerAnimationController::startAnimationsWaitingForTargetAvailability):
(WebCore::CCLayerAnimationController::resolveConflicts):
(WebCore::CCLayerAnimationController::purgeFinishedAnimations):
(WebCore::CCLayerAnimationController::tickAnimations):
* platform/graphics/chromium/cc/CCLayerAnimationController.h:
(WebCore):
(CCLayerAnimationControllerClient):
(WebCore::CCLayerAnimationControllerClient::~CCLayerAnimationControllerClient):
(CCLayerAnimationController):
* platform/graphics/chromium/cc/CCLayerAnimationControllerImpl.cpp: Removed.
* platform/graphics/chromium/cc/CCLayerAnimationControllerImpl.h: Removed.
* platform/graphics/chromium/cc/CCLayerAnimationDelegate.h:
(CCLayerAnimationDelegate):
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::CCLayerImpl):
(WebCore::CCLayerImpl::setOpacityFromAnimation):
(WebCore):
(WebCore::CCLayerImpl::setTransformFromAnimation):
* platform/graphics/chromium/cc/CCLayerImpl.h:
(CCLayerImpl):
(WebCore::CCLayerImpl::id):
(WebCore::CCLayerImpl::layerAnimationController):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::updateAnimations):
(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
(WebCore::CCLayerTreeHost::didBecomeInvisibleOnImplThread):
(WebCore::CCLayerTreeHost::animateLayers):
(WebCore):
(WebCore::CCLayerTreeHost::animateLayersRecursive):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::animateLayersRecursive):
(WebCore::CCLayerTreeHostImpl::animateLayers):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(CCLayerTreeHostImpl):
* platform/graphics/chromium/cc/CCThreadProxy.h:
(WebCore::CCThreadProxy::BeginFrameAndCommitState::BeginFrameAndCommitState):

Source/WebKit/chromium:

* WebKit.gypi:
* tests/CCAnimationTestCommon.cpp:
(WebKitTests::FakeLayerAnimationControllerClient::FakeLayerAnimationControllerClient):
(WebKitTests::FakeLayerAnimationControllerClient::~FakeLayerAnimationControllerClient):
* tests/CCAnimationTestCommon.h:
(FakeLayerAnimationControllerClient):
(WebKitTests::FakeLayerAnimationControllerClient::setOpacityFromAnimation):
(WebKitTests::FakeLayerAnimationControllerClient::setTransformFromAnimation):
* tests/CCLayerAnimationControllerImplTest.cpp: Removed.
* tests/CCLayerAnimationControllerTest.cpp:
(WebKitTests::TEST):
(WebKitTests):
* tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTestAddAnimation::CCLayerTreeHostTestAddAnimation):
(WTF::CCLayerTreeHostTestAddAnimation::animateLayers):
(CCLayerTreeHostTestAddAnimation):
* tests/TreeSynchronizerTest.cpp:
(WebKitTests::FakeLayerAnimationController::create):
(WebKitTests::FakeLayerAnimationController::FakeLayerAnimationController):
(WebKitTests::FakeLayerAnimationController::pushAnimationUpdatesTo):
(WebKitTests::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: REGRESSION Detached DOM Nodes are not highlighted
loislo@chromium.org [Tue, 20 Mar 2012 14:37:51 +0000 (14:37 +0000)]
Web Inspector: REGRESSION Detached DOM Nodes are not highlighted
https://bugs.webkit.org/show_bug.cgi?id=81662

Reviewed by Yury Semikhatsky.

* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshotNode.prototype.get isDetachedDOMTree):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNew PageCache histogram for tracking the highest leverage frame reject reasons.
gavinp@chromium.org [Tue, 20 Mar 2012 14:31:17 +0000 (14:31 +0000)]
New PageCache histogram for tracking the highest leverage frame reject reasons.
https://bugs.webkit.org/show_bug.cgi?id=81358

Reviewed by Adam Barth.

The current chromium FrameClientImpl always denies page cache; but
that's easily fixable.  This histogram tracks which rejection
causes occur alone with that cause.  I'm particularly interested
in knowing how many more pages would work in the page cache if we
could get plugins in.

* history/PageCache.cpp:
(WebCore::logCanCachePageDecision):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Crash when dragging the FCC caret over an invalid node.
mifenton@rim.com [Tue, 20 Mar 2012 14:24:51 +0000 (14:24 +0000)]
[BlackBerry] Crash when dragging the FCC caret over an invalid node.
https://bugs.webkit.org/show_bug.cgi?id=81654

Reviewed by Rob Buis.

PR 144505.

The position did not have a valid container node and was causing
a crash.  Validate the node pointer before using it.

* WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::DOMContainerNodeForPosition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: support inline source maps.
podivilov@chromium.org [Tue, 20 Mar 2012 14:01:05 +0000 (14:01 +0000)]
Web Inspector: support inline source maps.
https://bugs.webkit.org/show_bug.cgi?id=81248

Source/WebCore:

- support optional map.sourcesContent array with sources content
- support data: url as script sourceMapURL, e.g. "//@ sourceMappingURL=data:application/json;base64,<base64-encoded map>"

Reviewed by Pavel Feldman.

* inspector/front-end/CompilerSourceMapping.js:
(WebInspector.ClosureCompilerSourceMapping):
(WebInspector.ClosureCompilerSourceMapping.prototype.loadSourceCode):
(WebInspector.ClosureCompilerSourceMapping.prototype._parseMap):
(WebInspector.ClosureCompilerSourceMapping.prototype._canonicalizeURL):

LayoutTests:

Reviewed by Pavel Feldman.

* http/tests/inspector/compiler-source-mapping-expected.txt:
* http/tests/inspector/compiler-source-mapping.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: treat Uint* external arrays as arrays in console.
pfeldman@chromium.org [Tue, 20 Mar 2012 12:57:04 +0000 (12:57 +0000)]
Web Inspector: treat Uint* external arrays as arrays in console.
https://bugs.webkit.org/show_bug.cgi?id=81653

Reviewed by Yury Semikhatsky.

Source/WebCore:

* bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::JSInjectedScriptHost::type):
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::typeCallback):

LayoutTests:

* inspector/console/console-external-array-expected.txt:
* inspector/console/console-external-array.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoLet CSSImageValue inherit directly from CSSValue.
kling@webkit.org [Tue, 20 Mar 2012 12:38:45 +0000 (12:38 +0000)]
Let CSSImageValue inherit directly from CSSValue.
<http://webkit.org/b/81635>

Reviewed by Antti Koivisto.

Source/WebCore:

This removes the last of the CSSPrimitiveValue subclasses, which will
open up the class to heavier refactoring.

Those CSSImageValues that used to represent the 'none' value are now
simply created as CSSPrimitiveValue identifiers by the parser.

Test: fast/css/image-value-type.html

* css/CSSCursorImageValue.cpp:
(WebCore::CSSCursorImageValue::~CSSCursorImageValue):
(WebCore::CSSCursorImageValue::updateIfSVGCursorIsUsed):
(WebCore::CSSCursorImageValue::cachedImage):
* css/CSSImageValue.cpp:
(WebCore::CSSImageValue::CSSImageValue):
(WebCore::CSSImageValue::cachedOrPendingImage):
(WebCore::CSSImageValue::cachedImage):
(WebCore::CSSImageValue::customCssText):
* css/CSSImageValue.h:
(WebCore::CSSImageValue::url):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFillImage):
(WebCore::CSSParser::parseBorderImage):
* css/CSSStyleApplyProperty.cpp:
(WebCore::ApplyPropertyCursor::applyValue):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
* css/CSSValue.h:
(WebCore::CSSValue::isPrimitiveValue):

LayoutTests:

Added a test to document the fact that image values are no longer CSSPrimitiveValues.
Updated setPrimitiveValue.html and expectation to reflect this as well.

* fast/css/image-value-type-expected.txt: Added.
* fast/css/image-value-type.html: Added.
* fast/dom/setPrimitiveValue-expected.txt:
* fast/dom/setPrimitiveValue.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][Mac] Unreviewed gardening, skip new failing tests to paint the bot green.
ossy@webkit.org [Tue, 20 Mar 2012 12:27:12 +0000 (12:27 +0000)]
[Qt][Mac] Unreviewed gardening, skip new failing tests to paint the bot green.

* platform/qt-mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: call .length as the last check when detecting arrays.
pfeldman@chromium.org [Tue, 20 Mar 2012 12:22:22 +0000 (12:22 +0000)]
Web Inspector: call .length as the last check when detecting arrays.
https://bugs.webkit.org/show_bug.cgi?id=81335

Reviewed by Yury Semikhatsky.

Source/WebCore:

* inspector/InjectedScriptSource.js:

LayoutTests:

* inspector/console/console-format-collections-expected.txt:
* inspector/console/console-format-collections.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: newly added CSS rules shouldn't rewrite HTML content in the resources...
apavlov@chromium.org [Tue, 20 Mar 2012 12:17:26 +0000 (12:17 +0000)]
Web Inspector: newly added CSS rules shouldn't rewrite HTML content in the resources panel
https://bugs.webkit.org/show_bug.cgi?id=81414

Reviewed by Vsevolod Vlasov.

Source/WebCore:

* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModelResourceBinding.prototype._styleSheetChanged.setContent):
(WebInspector.CSSStyleModelResourceBinding.prototype._styleSheetChanged):

LayoutTests:

* inspector/styles/styles-add-new-rule.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: provide class name filter for "comparison" view in heap profiler
yurys@chromium.org [Tue, 20 Mar 2012 12:01:26 +0000 (12:01 +0000)]
Web Inspector: provide class name filter for "comparison" view in heap profiler
https://bugs.webkit.org/show_bug.cgi?id=81641

Class name filtering now works for both Summary and Comparison views.

Reviewed by Pavel Feldman.

* inspector/front-end/DetailedHeapshotView.js:
(WebInspector.DetailedHeapshotView.prototype._createToolbarWithClassNameFilter):
(WebInspector.DetailedHeapshotView.prototype._changeNameFilter):
* inspector/front-end/heapProfiler.css:
(.detailed-heapshot-view .class-view-grid):
(.detailed-heapshot-view .class-view-toolbar):
(.detailed-heapshot-view .class-view-toolbar input.class-name-filter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Update to Android NDK r7b
peter@chromium.org [Tue, 20 Mar 2012 11:57:34 +0000 (11:57 +0000)]
[Chromium] Update to Android NDK r7b
https://bugs.webkit.org/show_bug.cgi?id=81005

Reviewed by Adam Barth.

Update to version r7b of the Android NDK, release notes of which are
available on the following page:
http://developer.android.com/sdk/ndk/index.html

* Scripts/update-webkit-chromium:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDivision optimizations fail to infer cases of truncated division and mishandle -21474...
ossy@webkit.org [Tue, 20 Mar 2012 11:52:54 +0000 (11:52 +0000)]
Division optimizations fail to infer cases of truncated division and mishandle -2147483648/-1
https://bugs.webkit.org/show_bug.cgi?id=81428

32 bit buildfix after r111355.

2147483648 (2^31) isn't valid int literal in ISO C90, because 2147483647 (2^31-1) is the biggest int.
The smallest int is -2147483648 (-2^31) == -2147483647 - 1  == -INT32_MAX-1 == INT32_MIN (stdint.h).

Reviewed by Zoltan Herczeg.

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileIntegerArithDivForX86):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake animVal support type-safe
zimmermann@webkit.org [Tue, 20 Mar 2012 11:47:05 +0000 (11:47 +0000)]
Make animVal support type-safe
https://bugs.webkit.org/show_bug.cgi?id=81640

Reviewed by Antti Koivisto.

Source/WebCore:

Test: svg/animations/force-use-shadow-tree-recreation-while-animating.html

Redesign animVal support in a type-safe fashion, avoiding the SVGGenericAnimatedType
and associated reinterpret_casts, which require all call-sites to assure that the
types are safe to cast, before actually calling the method.

Remove pure virtual animationStarted/Ended/ValueWillChange/ValueDidChange & currentBaseValueVariant methods from SVGAnimatedProperty,
and de-virtualize them in classes that inherit from SVGAnimatedProperty, like SVGAnimatedPropertyTearOff, etc.

Add startAnimValAnimation/stopAnimValAnimation/resetAnimValToBaseVal/animValWillChange/animVallDidChange methods to all
SVGAnimatedXXXAnimator classes that currently support animVal (SVGAnimatedLength/LengthList/Number(OptionalNumber)/NumberList/TransformList).
Those SVGAnimatedLengthAnimator can cast the generic SVGAnimatedProperty* associated with a certain SVG DOM property, to the real type
eg. SVGAnimatedLength (which is a SVGAnimatedPropertyTearOff<SVGLength>). This way we can call those methods, without relying on virtual
function calls. Also it makes the "SVGGenericAnimatedType* currentBaseValueVariant()" accessor needless, as we can just call the method
right on eg. the SVGAnimatedLength, which gives us the "const SVGLength&" object, instead of a generic pointer type, that we have to
reinterpret_cast to some hopefully-matching expected type. The new approach is truly type-safey, but needs a bit more boilerplate code.

To reduce the amount of copy&paste across the SVGAnimatedXXXAnimator classes, all code is placed in template functions in
SVGAnimatedTypeAnimator.h, which can be shared across all SVGAnimatedXXXAnimator classes, that inherit from SVGAnimatedTypeAnimator.

Test: svg/animations/force-use-shadow-tree-recreation-while-animating.html

* svg/SVGAnimateElement.cpp:
(WebCore::SVGAnimateElement::calculateAnimatedValue):
(WebCore::SVGAnimateElement::resetToBaseValue):
(WebCore::SVGAnimateElement::applyResultsToTarget):
(WebCore):
(WebCore::SVGAnimateElement::targetElementWillChange):
* svg/SVGAnimatedLength.cpp:
(WebCore::SVGAnimatedLengthAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedLengthAnimator::stopAnimValAnimation):
(WebCore):
(WebCore::SVGAnimatedLengthAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedLengthAnimator::animValWillChange):
(WebCore::SVGAnimatedLengthAnimator::animValDidChange):
* svg/SVGAnimatedLength.h:
(WebCore):
(SVGAnimatedLengthAnimator):
* svg/SVGAnimatedLengthList.cpp:
(WebCore::SVGAnimatedLengthListAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedLengthListAnimator::stopAnimValAnimation):
(WebCore):
(WebCore::SVGAnimatedLengthListAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedLengthListAnimator::animValWillChange):
(WebCore::SVGAnimatedLengthListAnimator::animValDidChange):
* svg/SVGAnimatedLengthList.h:
(WebCore):
(SVGAnimatedLengthListAnimator):
* svg/SVGAnimatedNumber.cpp:
(WebCore::SVGAnimatedNumberAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedNumberAnimator::stopAnimValAnimation):
(WebCore):
(WebCore::SVGAnimatedNumberAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedNumberAnimator::animValWillChange):
(WebCore::SVGAnimatedNumberAnimator::animValDidChange):
* svg/SVGAnimatedNumber.h:
(WebCore):
(SVGAnimatedNumberAnimator):
* svg/SVGAnimatedNumberList.cpp:
(WebCore::SVGAnimatedNumberListAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedNumberListAnimator::stopAnimValAnimation):
(WebCore):
(WebCore::SVGAnimatedNumberListAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedNumberListAnimator::animValWillChange):
(WebCore::SVGAnimatedNumberListAnimator::animValDidChange):
* svg/SVGAnimatedNumberList.h:
(WebCore):
(SVGAnimatedNumberListAnimator):
* svg/SVGAnimatedNumberOptionalNumber.cpp:
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::stopAnimValAnimation):
(WebCore):
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::animValWillChange):
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::animValDidChange):
* svg/SVGAnimatedNumberOptionalNumber.h:
(WebCore):
(SVGAnimatedNumberOptionalNumberAnimator):
* svg/SVGAnimatedTransformList.cpp:
(WebCore::SVGAnimatedTransformListAnimator::startAnimValAnimation):
(WebCore):
(WebCore::SVGAnimatedTransformListAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedTransformListAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedTransformListAnimator::animValWillChange):
(WebCore::SVGAnimatedTransformListAnimator::animValDidChange):
* svg/SVGAnimatedTransformList.h:
(WebCore):
(SVGAnimatedTransformListAnimator):
* svg/SVGAnimatedType.h:
(WebCore):
* svg/SVGAnimatedTypeAnimator.h:
(WebCore):
(SVGAnimatedTypeAnimator):
(WebCore::SVGAnimatedTypeAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedTypeAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedTypeAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedTypeAnimator::animValWillChange):
(WebCore::SVGAnimatedTypeAnimator::animValDidChange):
(WebCore::SVGAnimatedTypeAnimator::findAnimatedPropertiesForAttributeName):
(WebCore::SVGAnimatedTypeAnimator::startAnimation):
(WebCore::SVGAnimatedTypeAnimator::stopAnimValAnimationForType):
(WebCore::SVGAnimatedTypeAnimator::animValDidChangeForType):
(WebCore::SVGAnimatedTypeAnimator::animValWillChangeForType):
(WebCore::SVGAnimatedTypeAnimator::constructFromOneBaseValue):
(WebCore::SVGAnimatedTypeAnimator::resetFromOneBaseValue):
(WebCore::SVGAnimatedTypeAnimator::constructFromTwoBaseValues):
(WebCore::SVGAnimatedTypeAnimator::resetFromTwoBaseValues):
(WebCore::SVGAnimatedTypeAnimator::castAnimatedPropertyToActualType):
(WebCore::SVGAnimatedTypeAnimator::collectAnimatedPropertiesFromInstances):
* svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::applyAnimatedValue):
(WebCore::SVGAnimationElement::setTargetAttributeAnimatedValue):
* svg/SVGAnimationElement.h:
(SVGAnimationElement):
* svg/SVGElementInstance.cpp:
(WebCore::SVGElementInstance::invalidateAllInstancesOfElement):
(WebCore::SVGElementInstance::InstanceUpdateBlocker::InstanceUpdateBlocker):
(WebCore):
(WebCore::SVGElementInstance::InstanceUpdateBlocker::~InstanceUpdateBlocker):
* svg/SVGElementInstance.h:
(WebCore):
(InstanceUpdateBlocker):
(SVGElementInstance):
* svg/properties/SVGAnimatedListPropertyTearOff.h:
(WebCore::SVGAnimatedListPropertyTearOff::currentBaseValue):
(WebCore::SVGAnimatedListPropertyTearOff::animationStarted):
(WebCore::SVGAnimatedListPropertyTearOff::animationEnded):
(WebCore::SVGAnimatedListPropertyTearOff::animValWillChange):
(WebCore::SVGAnimatedListPropertyTearOff::animValDidChange):
* svg/properties/SVGAnimatedProperty.h:
(WebCore):
* svg/properties/SVGAnimatedPropertyTearOff.h:
(WebCore::SVGAnimatedPropertyTearOff::currentBaseValue):
(WebCore::SVGAnimatedPropertyTearOff::animationStarted):
(WebCore::SVGAnimatedPropertyTearOff::animationEnded):
(WebCore::SVGAnimatedPropertyTearOff::animValWillChange):
(WebCore::SVGAnimatedPropertyTearOff::animValDidChange):
* svg/properties/SVGAnimatedStaticPropertyTearOff.h:
(WebCore::SVGAnimatedStaticPropertyTearOff::currentBaseValue):
(WebCore::SVGAnimatedStaticPropertyTearOff::animationStarted):
(WebCore::SVGAnimatedStaticPropertyTearOff::animationEnded):
(WebCore::SVGAnimatedStaticPropertyTearOff::animValWillChange):
(WebCore::SVGAnimatedStaticPropertyTearOff::animValDidChange):

LayoutTests:

Add a new test which forces recreation of a <use> shadow tree while animation is running.

* svg/animations/force-use-shadow-tree-recreation-while-animating-expected.txt: Added.
* svg/animations/force-use-shadow-tree-recreation-while-animating.html: Added.
* svg/animations/resources/force-use-shadow-tree-recreation-while-animating.svg: Added.
* svg/animations/script-tests/force-use-shadow-tree-recreation-while-animating.js: Added.
(sample1):
(sample2):
(forceUseShadowTreeRecreation):
(sample3):
(executeTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Marking WebFrameTest.DivAutoZoomParamsTest as failing.
keishi@webkit.org [Tue, 20 Mar 2012 11:26:04 +0000 (11:26 +0000)]
[chromium] Marking WebFrameTest.DivAutoZoomParamsTest as failing.

* tests/WebFrameTest.cpp:
(WebKit::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Gardening, skip failing tests, add platform specific expected files.
ossy@webkit.org [Tue, 20 Mar 2012 10:24:57 +0000 (10:24 +0000)]
[Qt] Gardening, skip failing tests, add platform specific expected files.

Patch by Szilard Ledan <szledan@inf.u-szeged.hu> on 2012-03-20
Reviewed by Csaba Osztrogonác.

* platform/qt/Skipped:
* platform/qt/fast/events/touch/gesture/pad-gesture-cancel-expected.png: Added after r111182.
* platform/qt/fast/events/touch/gesture/pad-gesture-cancel-expected.txt: Added after r111182.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Fix the Android build by building NEWWTF for host
peter@chromium.org [Tue, 20 Mar 2012 10:21:26 +0000 (10:21 +0000)]
[Chromium] Fix the Android build by building NEWWTF for host
https://bugs.webkit.org/show_bug.cgi?id=81643

Reviewed by Tony Gentilcore.

Chromium for Android builds the ImageDiff target for the host architecture,
so all dependencies it has need to be able to build for host as well.
r111258 added (new)WTF as a dependency instead of just including the
header files, so make it possible to build the newwtf target for host.

* WTF.gyp/WTF.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[CSSRegions]Implement NamedFlow::getRegionsByContentNode
mihnea@adobe.com [Tue, 20 Mar 2012 10:08:26 +0000 (10:08 +0000)]
[CSSRegions]Implement NamedFlow::getRegionsByContentNode
https://bugs.webkit.org/show_bug.cgi?id=77746

Reviewed by David Hyatt.

The list of regions returned is a static node list.

Source/WebCore:

Tests: fast/regions/get-regions-by-content-node-horiz-bt.html
       fast/regions/get-regions-by-content-node-horiz-tb.html
       fast/regions/get-regions-by-content-node-vert-lr.html
       fast/regions/get-regions-by-content-node-vert-rl.html
       fast/regions/get-regions-by-content-node.html
       fast/regions/get-regions-by-content-node2.html

* dom/WebKitNamedFlow.cpp:
(WebCore::WebKitNamedFlow::getRegionsByContentNode):
(WebCore):
* dom/WebKitNamedFlow.h:
(WebKitNamedFlow):
* dom/WebKitNamedFlow.idl:
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::regionInRange):
(WebCore):
(WebCore::RenderFlowThread::objectInFlowRegion):
* rendering/RenderFlowThread.h:
* rendering/RenderRegion.h:
(WebCore::RenderRegion::flowThread):

LayoutTests:

* fast/regions/get-regions-by-content-node-expected.txt: Added.
* fast/regions/get-regions-by-content-node-horiz-bt-expected.txt: Added.
* fast/regions/get-regions-by-content-node-horiz-bt.html: Added.
* fast/regions/get-regions-by-content-node-horiz-tb-expected.txt: Added.
* fast/regions/get-regions-by-content-node-horiz-tb.html: Added.
* fast/regions/get-regions-by-content-node-vert-lr-expected.txt: Added.
* fast/regions/get-regions-by-content-node-vert-lr.html: Added.
* fast/regions/get-regions-by-content-node-vert-rl-expected.txt: Added.
* fast/regions/get-regions-by-content-node-vert-rl.html: Added.
* fast/regions/get-regions-by-content-node.html: Added.
* fast/regions/get-regions-by-content-node2-expected.txt: Added.
* fast/regions/get-regions-by-content-node2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agox86 GCC bug triggers a compilation error in generated copy constructor of CollapsedBo...
ossy@webkit.org [Tue, 20 Mar 2012 09:49:59 +0000 (09:49 +0000)]
x86 GCC bug triggers a compilation error in generated copy constructor of CollapsedBorderValue
https://bugs.webkit.org/show_bug.cgi?id=81502

Unreviewed.

* qmake/mkspecs/features/unix/default_post.prf: Reenable Werror after r111171.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Fixing mime type for test expectation png files.
keishi@webkit.org [Tue, 20 Mar 2012 09:40:05 +0000 (09:40 +0000)]
[chromium] Fixing mime type for test expectation png files.

* platform/chromium-linux-x86/fast/table/max-width-integer-overflow-expected.png: Added property svn:mime-type.
* platform/chromium-linux/fast/clip/overflow-border-radius-fixed-position-expected.png: Modified property svn:mime-type.
* platform/chromium-linux/fast/table/max-width-integer-overflow-expected.png: Added property svn:mime-type.
* platform/chromium-mac-leopard/fast/clip/overflow-border-radius-fixed-position-expected.png: Modified property svn:mime-type.
* platform/chromium-mac-snowleopard/compositing/geometry/video-opacity-overlay-expected.png: Added property svn:mime-type.
* platform/chromium-mac-snowleopard/compositing/reflections/load-video-in-reflection-expected.png: Added property svn:mime-type.
* platform/chromium-mac/fast/clip/overflow-border-radius-fixed-position-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Modified property svn:mime-type.
* platform/chromium-win-vista/compositing/shadows/shadow-drawing-expected.png: Added property svn:mime-type.
* platform/chromium-win-xp/fast/table/max-width-integer-overflow-expected.png: Added property svn:mime-type.
* platform/chromium-win/compositing/layer-creation/fixed-position-scroll-expected.png: Added property svn:mime-type.
* platform/chromium-win/fast/clip/overflow-border-radius-fixed-position-expected.png: Modified property svn:mime-type.
* platform/chromium-win/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.png: Modified property svn:mime-type.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed Chromium gardening.
leviw@chromium.org [Tue, 20 Mar 2012 09:09:22 +0000 (09:09 +0000)]
Unreviewed Chromium gardening.

Marking editing/selection/iframe.html as flaky on 10.6 debug. Occasionally the caret isn't painted for some reason.
Removing iframe-reparenting-new-page.html entry from test_expectations.txt since the test no longer exists.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=81637 fast/dom/Window/timer-resume-on-navigat...
slewis@apple.com [Tue, 20 Mar 2012 08:53:45 +0000 (08:53 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=81637 fast/dom/Window/timer-resume-on-navigation-back.html times out.
Skips a test that times out.

Unreviewed.

* platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove min and max parameters from CSSPrimitiveValue's roundForImpreciseConversion...
macpherson@chromium.org [Tue, 20 Mar 2012 08:32:11 +0000 (08:32 +0000)]
Remove min and max parameters from CSSPrimitiveValue's roundForImpreciseConversion function.
https://bugs.webkit.org/show_bug.cgi?id=81629

Reviewed by Andreas Kling.

No new tests / refactoring only.

* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::computeLength):
* css/CSSPrimitiveValue.h:
(WebCore::roundForImpreciseConversion):
* rendering/style/RenderStyle.h:
(WebCore::adjustForAbsoluteZoom):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry]Cookies shouldn't be set into each of webcore's request and platform...
commit-queue@webkit.org [Tue, 20 Mar 2012 08:24:37 +0000 (08:24 +0000)]
[BlackBerry]Cookies shouldn't be set into each of webcore's request and platform's request. And this makes a regression.
https://bugs.webkit.org/show_bug.cgi?id=80800

Source/WebCore:

FrameLoaderClientBlackBerry::dispatchWillSendRequest sets cookies to resourceRequest's header
list to show cookies in inspector. And NetworkManager::startJob will set cookies to platformRequest's
m_cookieData again. So cookies are set two times. This causes performance issue.

Moreover, platformRequest will copy cookies from the resourceRequest. And then platformRequest has
the same cookies in its header list and m_cookieData. Network will use header list's cookies which
are output as latin1 only. This causes the regression of https://bugs.webkit.org/show_bug.cgi?id=80307.

Now, set cookies in initializePlatformRequest to ensure setting cookies only once.

Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-03-20
Reviewed by George Staikos.

Test: http/tests/cookies/resources/setUtf8Cookies.php

* platform/network/blackberry/NetworkManager.cpp:
(WebCore::NetworkManager::startJob):
* platform/network/blackberry/ResourceRequest.h:
(ResourceRequest):
* platform/network/blackberry/ResourceRequestBlackBerry.cpp:
(WebCore::ResourceRequest::initializePlatformRequest):

Source/WebKit/blackberry:

Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-03-20
Reviewed by George Staikos.

* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNavigationAction):
(WebCore::FrameLoaderClientBlackBerry::dispatchWillSendRequest):
(WebCore::FrameLoaderClientBlackBerry::decidePolicyForExternalLoad):

LayoutTests:

Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-03-20
Reviewed by George Staikos.

* http/tests/cookies/resources/setUtf8Cookies-expected.txt: Added.
* http/tests/cookies/resources/setUtf8Cookies-result.php: Added.
* http/tests/cookies/resources/setUtf8Cookies.php: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Marking listbox-clear-restore.html on Linux as flaky.
keishi@webkit.org [Tue, 20 Mar 2012 08:20:04 +0000 (08:20 +0000)]
[chromium] Marking listbox-clear-restore.html on Linux as flaky.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=81634 some SVG Zoom tests fail on Lion WK2...
slewis@apple.com [Tue, 20 Mar 2012 07:59:07 +0000 (07:59 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=81634 some SVG Zoom tests fail on Lion WK2 bots

Unreviewed.

Check in new expected (failing?) results.

* platform/mac-wk2/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
* platform/mac-wk2/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
* platform/mac-wk2/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt:
* platform/mac-wk2/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] New test introduced in r110532 fails on 32 bit.
ossy@webkit.org [Tue, 20 Mar 2012 06:49:27 +0000 (06:49 +0000)]
[Qt] New test introduced in r110532 fails on 32 bit.

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-03-19
Reviewed by Csaba Osztrogonác.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSplit WTFReportBacktrace into WTFReportBacktrace and WTFPrintBacktrace
jochen@chromium.org [Tue, 20 Mar 2012 06:48:17 +0000 (06:48 +0000)]
Split WTFReportBacktrace into WTFReportBacktrace and WTFPrintBacktrace
https://bugs.webkit.org/show_bug.cgi?id=80983

Reviewed by Darin Adler.

This allows printing a backtrace acquired by an earlier WTFGetBacktrace
call which is useful for local debugging.

* wtf/Assertions.cpp:
* wtf/Assertions.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Rebaselining nested-fragment-parser-crash.html again.
keishi@webkit.org [Tue, 20 Mar 2012 06:43:17 +0000 (06:43 +0000)]
[chromium] Rebaselining nested-fragment-parser-crash.html again.

* platform/chromium-linux-x86/fast/parser/nested-fragment-parser-crash-expected.txt: Added.
* platform/chromium-linux/fast/parser/nested-fragment-parser-crash-expected.txt: Added.
* platform/chromium-mac-leopard/fast/parser/nested-fragment-parser-crash-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/parser/nested-fragment-parser-crash-expected.txt: Added.
* platform/chromium-win-vista/fast/parser/nested-fragment-parser-crash-expected.txt: Added.
* platform/chromium-win-xp/fast/parser/nested-fragment-parser-crash-expected.txt: Added.
* platform/chromium-win/fast/parser/nested-fragment-parser-crash-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix for Debug build after r111358
benjamin@webkit.org [Tue, 20 Mar 2012 06:37:36 +0000 (06:37 +0000)]
Build fix for Debug build after r111358

Unreviewed.

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-03-19

* bindings/js/CachedScriptSourceProvider.h:
* bindings/js/StringSourceProvider.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agofast/table/max-width-integer-overflow.html should be skipped because it gives
ossy@webkit.org [Tue, 20 Mar 2012 06:35:23 +0000 (06:35 +0000)]
fast/table/max-width-integer-overflow.html should be skipped because it gives
different results on 32- and 64-bit systems.

Patch by János Badics <jbadics@inf.u-szeged.hu> on 2012-03-19
Reviewed by Csaba Osztrogonác.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd FractionalLayoutUnit version of blend to AnimationUtilities
eae@chromium.org [Tue, 20 Mar 2012 06:17:23 +0000 (06:17 +0000)]
Add FractionalLayoutUnit version of blend to AnimationUtilities
https://bugs.webkit.org/show_bug.cgi?id=81572

Reviewed by Eric Seidel.

Add version of blend method that operates on FractionalLayoutUnits. This
will be used in place of the integer version in many places once we
enable support for subpixel layout.

No new tests.

* platform/FractionalLayoutUnit.h:
Include math.h to make GTK build happy.

* platform/animation/AnimationUtilities.h:
(WebCore::blend):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove support for "magic" iframe
abarth@webkit.org [Tue, 20 Mar 2012 05:58:36 +0000 (05:58 +0000)]
Remove support for "magic" iframe
https://bugs.webkit.org/show_bug.cgi?id=81590

Reviewed by Eric Seidel.

Source/WebCore:

This patch removes support for "magic" iframe, which previously allowed
an iframe to be transfered from one document to another without
reloading the iframe.  The idea behind this feature was to let sites
create "pop out" windows that could outlive their parents by
transfering state to these windows via these magic iframes.

Unforuntately, this feature was never implemented by other browsers and
has been the source of a series of security vulnerabilities.  Although
we have fixed each vulnerability as it has been discovered, the feature
is still a complex corner case that isn't widely exercised on the web.
For that reason, it's likely to have more vulnerabilities in the
future.

I'm not aware of any web sites that use this feature anymore.  There
were a handful of them, but we appear to have been successful in
evangalizing them to move away from "magic" iframe.

* dom/Document.cpp:
(WebCore::Document::adoptNode):
* html/HTMLFrameElementBase.cpp:
(WebCore):
(WebCore::HTMLFrameElementBase::HTMLFrameElementBase):
(WebCore::HTMLFrameElementBase::insertedIntoDocument):
* html/HTMLFrameElementBase.h:
(HTMLFrameElementBase):
* loader/DocumentLoader.cpp:
(WebCore):
* loader/DocumentLoader.h:
(DocumentLoader):
* loader/EmptyClients.h:
(WebCore::EmptyFrameLoaderClient::createFrame):
* loader/FrameLoader.cpp:
(WebCore):
* loader/FrameLoader.h:
(FrameLoader):
* loader/FrameLoaderClient.h:
(FrameLoaderClient):
* loader/ResourceLoadNotifier.cpp:
(WebCore):
* loader/ResourceLoadNotifier.h:
(ResourceLoadNotifier):
* page/Frame.cpp:
(WebCore):
* page/Frame.h:
(Frame):

Source/WebKit/blackberry:

Remove FrameLoaderClient methods that no longer exist.

* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore):
* WebCoreSupport/FrameLoaderClientBlackBerry.h:
(FrameLoaderClientBlackBerry):
(WebCore::FrameLoaderClientBlackBerry::didDetectXSS):

Source/WebKit/chromium:

Remove FrameLoaderClient methods that no longer exist.

* public/WebFrameClient.h:
(WebFrameClient):
* src/FrameLoaderClientImpl.cpp:
(WebKit):
* src/FrameLoaderClientImpl.h:
(FrameLoaderClientImpl):

Source/WebKit/efl:

Remove FrameLoaderClient methods that no longer exist.

* WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore):
* WebCoreSupport/FrameLoaderClientEfl.h:
(FrameLoaderClientEfl):

Source/WebKit/gtk:

Remove FrameLoaderClient methods that no longer exist.

* WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit):
* WebCoreSupport/FrameLoaderClientGtk.h:
(FrameLoaderClient):

Source/WebKit/mac:

Remove FrameLoaderClient methods that no longer exist.

* WebCoreSupport/WebFrameLoaderClient.h:
* WebCoreSupport/WebFrameLoaderClient.mm:

Source/WebKit/qt:

Remove FrameLoaderClient methods that no longer exist.

* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore):
* WebCoreSupport/FrameLoaderClientQt.h:
(FrameLoaderClientQt):

Source/WebKit/win:

Remove FrameLoaderClient methods that no longer exist.

* WebCoreSupport/WebFrameLoaderClient.cpp:
* WebCoreSupport/WebFrameLoaderClient.h:
(WebFrameLoaderClient):

Source/WebKit/wince:

Remove FrameLoaderClient methods that no longer exist.

* WebCoreSupport/FrameLoaderClientWinCE.cpp:
(WebKit):
* WebCoreSupport/FrameLoaderClientWinCE.h:
(FrameLoaderClientWinCE):

Source/WebKit/wx:

Remove FrameLoaderClient methods that no longer exist.

* WebKitSupport/FrameLoaderClientWx.cpp:
(WebCore):
* WebKitSupport/FrameLoaderClientWx.h:
(FrameLoaderClientWx):

Source/WebKit2:

Remove FrameLoaderClient methods that no longer exist.

* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit):
* WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

LayoutTests:

Remove tests of magic iframe. These tests don't reall make sense to
keep without the feature.

* fast/frames/adopt-iframe-into-itself-expected.txt: Added.
* fast/frames/adopt-iframe-into-itself.html: Added.
    - I've added a test about adopting an iframe into itself. We might
      already have a test for this, but it covers a mistake I made in
      an earlier iteration of this patch.
* fast/frames/iframe-reparenting-adopt-node-expected.txt: Removed.
* fast/frames/iframe-reparenting-adopt-node.html: Removed.
* fast/frames/iframe-reparenting-embed-elements-expected.txt: Removed.
* fast/frames/iframe-reparenting-embed-elements.html: Removed.
* fast/frames/iframe-reparenting-expected.txt: Removed.
* fast/frames/iframe-reparenting-fail-load-expected.txt: Removed.
* fast/frames/iframe-reparenting-fail-load.html: Removed.
* fast/frames/iframe-reparenting-new-page-expected.txt: Removed.
* fast/frames/iframe-reparenting-new-page.html: Removed.
* fast/frames/iframe-reparenting-plugins-expected.txt: Removed.
* fast/frames/iframe-reparenting-plugins.html: Removed.
* fast/frames/iframe-reparenting.html: Removed.
* fast/frames/resources/iframe-reparenting-adopt-node-iframe-content.html: Removed.
* fast/frames/resources/iframe-reparenting-adopt-node-new-page.html: Removed.
* fast/frames/resources/iframe-reparenting-embed-frame1.html: Removed.
* fast/frames/resources/iframe-reparenting-embed-iframe.html: Removed.
* fast/frames/resources/iframe-reparenting-frame1.html: Removed.
* fast/frames/resources/iframe-reparenting-frame2.html: Removed.
* fast/frames/resources/iframe-reparenting-iframe-content.html: Removed.
* fast/frames/resources/iframe-reparenting-new-page-1.html: Removed.
* fast/frames/resources/iframe-reparenting-new-page-2.html: Removed.
* fast/frames/resources/iframe-reparenting-new-page-iframe.html: Removed.
* fast/frames/resources/iframe-reparenting-plugins-iframe-content.html: Removed.
* fast/frames/resources/iframe-reparenting-plugins-new-page.html: Removed.
* fast/frames/script-tests/iframe-reparenting-new-page.js: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION(r110072): Improper repainting on table with overflow: hidden
jchaffraix@webkit.org [Tue, 20 Mar 2012 05:37:44 +0000 (05:37 +0000)]
REGRESSION(r110072): Improper repainting on table with overflow: hidden
https://bugs.webkit.org/show_bug.cgi?id=81460

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/repaint/table-hover-on-link.html

* rendering/RenderTable.cpp:
(WebCore::RenderTable::layout): Add a call to RenderBlock::updateCachedSizeForOverflowClip
so that we properly keep our cached size up to date. This fixes the problem for now but the
real solution is to make sure it is called on all classes that needs to. This is tracked by
bug 81461.

LayoutTests:

* fast/repaint/table-hover-on-link-expected.txt: Added.
* fast/repaint/table-hover-on-link.html: Added.

* platform/chromium-linux/fast/repaint/table-hover-on-link-expected.png: Added.
* platform/chromium-mac/fast/repaint/table-hover-on-link-expected.png: Added.
* platform/mac/fast/repaint/table-hover-on-link-expected.png: Added.
There seem to be some small color difference here (maybe color profile related).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd support for crossorigin attribute in script elements
commit-queue@webkit.org [Tue, 20 Mar 2012 05:29:11 +0000 (05:29 +0000)]
Add support for crossorigin attribute in script elements
https://bugs.webkit.org/show_bug.cgi?id=81438

Patch by Pablo Flouret <pablof@motorola.com> on 2012-03-19
Reviewed by Adam Barth.

Source/WebCore:

Works similarly to img and its crossorigin attribute. In the future it
could allow for things like showing full error messages in error
handlers, etc.

Tests: http/tests/security/script-crossorigin-loads-correctly.html
       http/tests/security/script-crossorigin-loads-same-origin.html
       http/tests/security/script-with-failed-cors-check-fails-to-load.html

* dom/ScriptElement.cpp:
(WebCore::ScriptElement::ScriptElement):
(WebCore::ScriptElement::requestScript):
(WebCore::ScriptElement::notifyFinished):
* dom/ScriptElement.h:
(ScriptElement):
* html/HTMLScriptElement.idl:

LayoutTests:

* http/tests/security/resources/alert-fail.js: Added.
* http/tests/security/resources/cors-script.php: Added.
* http/tests/security/script-crossorigin-loads-correctly-expected.txt: Added.
* http/tests/security/script-crossorigin-loads-correctly.html: Added.
* http/tests/security/script-crossorigin-loads-same-origin-expected.txt: Added.
* http/tests/security/script-crossorigin-loads-same-origin.html: Added.
* http/tests/security/script-with-failed-cors-check-fails-to-load-expected.txt: Added.
* http/tests/security/script-with-failed-cors-check-fails-to-load.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDo not copy the script source in the SourceProvider, just reference the existing...
benjamin@webkit.org [Tue, 20 Mar 2012 05:24:24 +0000 (05:24 +0000)]
Do not copy the script source in the SourceProvider, just reference the existing string
https://bugs.webkit.org/show_bug.cgi?id=81466

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

* parser/SourceCode.h: Remove the unused, and incorrect, function data().
* parser/SourceProvider.h: Add OVERRIDE for clarity.

Source/WebCore:

Instead of creating a copy of the string with 16bits characters, we just return
a shared StringImpl.

* bindings/js/CachedScriptSourceProvider.h:
* bindings/js/StringSourceProvider.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoA quick early-out for Region::contains() test
commit-queue@webkit.org [Tue, 20 Mar 2012 05:21:20 +0000 (05:21 +0000)]
A quick early-out for Region::contains() test
https://bugs.webkit.org/show_bug.cgi?id=81625

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-19
Reviewed by Anders Carlsson.

If the bounds of region B include a row/column that is outside the bounds of
region A, then region B contains a pixel within that row/column that is
outside of region A.

* platform/graphics/Region.cpp:
(WebCore::Region::contains):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed attempt to fix the EFL build.
eric@webkit.org [Tue, 20 Mar 2012 05:20:04 +0000 (05:20 +0000)]
Unreviewed attempt to fix the EFL build.

* platform/graphics/efl/IconEfl.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDivision optimizations fail to infer cases of truncated division and
fpizlo@apple.com [Tue, 20 Mar 2012 05:15:50 +0000 (05:15 +0000)]
Division optimizations fail to infer cases of truncated division and
mishandle -2147483648/-1
https://bugs.webkit.org/show_bug.cgi?id=81428
<rdar://problem/11067382>

Reviewed by Oliver Hunt.

If you're a division over integers and you're only used as an integer, then you're
an integer division and remainder checks become unnecessary. If you're dividing
-2147483648 by -1, don't crash.

* assembler/MacroAssemblerX86Common.h:
(MacroAssemblerX86Common):
(JSC::MacroAssemblerX86Common::add32):
* dfg/DFGSpeculativeJIT.cpp:
(DFG):
(JSC::DFG::SpeculativeJIT::compileIntegerArithDivForX86):
* dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* llint/LowLevelInterpreter64.asm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix more WTF header include paths in WebCore
eric@webkit.org [Tue, 20 Mar 2012 05:04:58 +0000 (05:04 +0000)]
Fix more WTF header include paths in WebCore
https://bugs.webkit.org/show_bug.cgi?id=81602

Reviewed by Martin Robinson.

Chromium, Mac and Win already build w/o including wtf subdirectories
in their include paths for WebCore/WebKit.  Gtk, Qt, and other ports
should eventually do the same.  This patch fixes up a few loose
wtf includes in these ports using some search/replace across WebCore.
If the EWS bots pass this patch doesn't really need any other review.

* accessibility/gtk/AXObjectCacheAtk.cpp:
* accessibility/gtk/WebKitAccessibleInterfaceText.cpp:
* platform/KURL.cpp:
* platform/audio/gstreamer/AudioDestinationGStreamer.cpp:
* platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
* platform/audio/gtk/AudioBusGtk.cpp:
* platform/clutter/GRefPtrClutter.h:
* platform/graphics/gstreamer/GRefPtrGStreamer.h:
* platform/graphics/gstreamer/ImageGStreamerCairo.cpp:
* platform/graphics/gstreamer/ImageGStreamerQt.cpp:
* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
* platform/graphics/gtk/ImageBufferGtk.cpp:
* platform/graphics/pango/FontPango.cpp:
* platform/graphics/qt/ImageBufferDataQt.h:
* platform/graphics/wx/ImageBufferDataWx.h:
* platform/gtk/ContextMenuGtk.cpp:
* platform/gtk/ContextMenuItemGtk.cpp:
* platform/gtk/FileSystemGtk.cpp:
* platform/gtk/GOwnPtrGtk.h:
* platform/gtk/GtkAuthenticationDialog.h:
* platform/gtk/GtkPopupMenu.cpp:
* platform/gtk/LanguageGtk.cpp:
* platform/gtk/LocalizedStringsGtk.cpp:
* platform/gtk/PopupMenuGtk.cpp:
* platform/gtk/RenderThemeGtk.cpp:
* platform/gtk/RenderThemeGtk.h:
* platform/network/soup/GOwnPtrSoup.h:
* platform/network/soup/ResourceRequestSoup.cpp:
* platform/network/soup/ResourceResponseSoup.cpp:
* platform/network/soup/SocketStreamHandle.h:
* platform/network/soup/SoupURIUtils.cpp:
* platform/text/TextEncoding.cpp:
* platform/text/gtk/TextBreakIteratorGtk.cpp:
* platform/text/gtk/TextCodecGtk.cpp:
* platform/text/gtk/TextCodecGtk.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMove the extra logical height distribution into RenderTable as a new step in our...
jchaffraix@webkit.org [Tue, 20 Mar 2012 04:53:14 +0000 (04:53 +0000)]
Move the extra logical height distribution into RenderTable as a new step in our layout algorithm
https://bugs.webkit.org/show_bug.cgi?id=81548

Reviewed by Tony Chang.

Refactoring, no expected change in behavior.

Moving the distribution step into RenderTable is needed to implement a better distribution algorithm that would
span several RenderTableSection (which is what IE and FF are doing right now).

* rendering/RenderTable.cpp:
(WebCore::RenderTable::distributeExtraLogicalHeight):
(WebCore::RenderTable::layout):
Moved the distribution step into distributeExtraLogicalHeight. While at it, changed the code to make use of the helper
methods to iterate over the sections and explicitly floor the LayoutUnit before calling distributeExtraLogicalHeight.

* rendering/RenderTable.h:
Added distributeExtraLogicalHeight.

* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::layoutRows):
Changed the method signature as it doesn't handle the distribution step anymore.

* rendering/RenderTableSection.h:
Updated layoutRows signature and exposed distributeExtraLogicalHeightToRows for RenderTable use.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAnother attempt at fixing the Windows build.
andersca@apple.com [Tue, 20 Mar 2012 04:50:55 +0000 (04:50 +0000)]
Another attempt at fixing the Windows build.

* platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
(WebCore::LayerClient::platformCALayerDeviceScaleFactor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoplugins/application-plugin-plugins-disabled.html should be a Qt specific test
andersca@apple.com [Tue, 20 Mar 2012 04:48:53 +0000 (04:48 +0000)]
plugins/application-plugin-plugins-disabled.html should be a Qt specific test
https://bugs.webkit.org/show_bug.cgi?id=81628

Reviewed by Jessie Berlin.

This test tests an "application specific plug-in" feature that only Qt has so this should be
a Qt specific test.

* platform/chromium-linux/plugins/application-plugin-plugins-disabled-expected.png: Removed.
* platform/chromium-mac-leopard/plugins/application-plugin-plugins-disabled-expected.png: Removed.
* platform/chromium-mac-snowleopard/plugins/application-plugin-plugins-disabled-expected.png: Removed.
* platform/chromium-mac/plugins/application-plugin-plugins-disabled-expected.png: Removed.
* platform/chromium-win/plugins/application-plugin-plugins-disabled-expected.png: Removed.
* platform/chromium-win/plugins/application-plugin-plugins-disabled-expected.txt: Removed.
* platform/gtk/plugins/application-plugin-plugins-disabled-expected.txt: Removed.
* platform/mac-snowleopard/plugins/application-plugin-plugins-disabled-expected.png: Removed.
* platform/mac/plugins/application-plugin-plugins-disabled-expected.txt: Removed.
* platform/qt/plugins/application-plugin-plugins-disabled.html: Renamed from LayoutTests/plugins/application-plugin-plugins-disabled.html.
* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Add registerURLSchemeAsEmptyDocument to WebSecurityPolicy
commit-queue@webkit.org [Tue, 20 Mar 2012 04:47:25 +0000 (04:47 +0000)]
[Chromium] Add registerURLSchemeAsEmptyDocument to WebSecurityPolicy
https://bugs.webkit.org/show_bug.cgi?id=81421

Patch by Charlie Reis <creis@chromium.org> on 2012-03-19
Reviewed by Adam Barth.

* public/WebSecurityPolicy.h:
(WebSecurityPolicy):
* src/WebSecurityPolicy.cpp:
(WebKit::WebSecurityPolicy::registerURLSchemeAsEmptyDocument):
(WebKit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Rebaseline caused by r111334
keishi@webkit.org [Tue, 20 Mar 2012 04:45:15 +0000 (04:45 +0000)]
[chromium] Rebaseline caused by r111334

* platform/chromium-linux-x86/fast/repaint/canvas-putImageData-expected.txt: Added.
* platform/chromium-linux/fast/repaint/canvas-putImageData-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/repaint/canvas-putImageData-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Fix build break because of PlatformString.h
gyuyoung.kim@samsung.com [Tue, 20 Mar 2012 04:39:36 +0000 (04:39 +0000)]
[EFL] Fix build break because of PlatformString.h
https://bugs.webkit.org/show_bug.cgi?id=81619

Unreviewed. Fix build break because of PlatformString.h.

* platform/graphics/efl/IconEfl.cpp: Include PlatformString.h from text directory.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix CrWin build after r111258.
eric@webkit.org [Tue, 20 Mar 2012 04:25:21 +0000 (04:25 +0000)]
Fix CrWin build after r111258.
https://bugs.webkit.org/show_bug.cgi?id=81281

Unreviewed build fix.
I also fixed similarly incorrect wtf/ includes for other ports
(which aren't yet as strict as Chromium about wtf includes).

* platform/blackberry/CookieManager.cpp:
* platform/blackberry/CookieParser.cpp:
* platform/blackberry/ParsedCookie.cpp:
* platform/blackberry/SharedTimerBlackBerry.cpp:
* platform/graphics/qt/GraphicsLayerQt.cpp:
* platform/graphics/texmap/TextureMapperAnimation.cpp:
* rendering/RenderThemeChromiumWin.cpp:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WK2] Four http/tests/xmlhttprequest tests fail on mac-wk2
timothy_horton@apple.com [Tue, 20 Mar 2012 04:04:28 +0000 (04:04 +0000)]
[WK2] Four http/tests/xmlhttprequest tests fail on mac-wk2
https://bugs.webkit.org/show_bug.cgi?id=81627

Unreviewed; skip failing http/tests/xmlhttprequest tests on mac-wk2.

* platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix CrWin build after r111258.
eric@webkit.org [Tue, 20 Mar 2012 03:48:20 +0000 (03:48 +0000)]
Fix CrWin build after r111258.
https://bugs.webkit.org/show_bug.cgi?id=81281

Unreviewed build fix.

* platform/graphics/chromium/FontCacheChromiumWin.cpp:
* platform/graphics/chromium/FontPlatformDataChromiumWin.cpp:
* platform/graphics/texmap/TextureMapperAnimation.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed; roll out http://trac.webkit.org/changeset/111307 and http://trac.webkit...
jberlin@webkit.org [Tue, 20 Mar 2012 03:46:26 +0000 (03:46 +0000)]
Unreviewed; roll out trac.webkit.org/changeset/111307 and http://trac.webkit.org/changeset/111293
because they broke running the layout tests on mac.

* Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitDriver._check_for_driver_crash):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoadd css parsing of flex-line-pack
tony@chromium.org [Tue, 20 Mar 2012 03:32:29 +0000 (03:32 +0000)]
add css parsing of flex-line-pack
https://bugs.webkit.org/show_bug.cgi?id=81427

Reviewed by Ojan Vafai.

Source/WebCore:

Spec: http://dev.w3.org/csswg/css3-flexbox/#flex-line-pack

Updated tests in css3/flexbox/css-properties.html

* css/CSSComputedStyleDeclaration.cpp:
(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore):
(WebCore::CSSPrimitiveValue::operator EFlexLinePack):
* css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
* css/CSSPropertyNames.in:
* css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
* css/CSSValueKeywords.in:
* rendering/style/RenderStyle.h:
* rendering/style/RenderStyleConstants.h:
* rendering/style/StyleFlexibleBoxData.cpp:
(WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
(WebCore::StyleFlexibleBoxData::operator==):
* rendering/style/StyleFlexibleBoxData.h:
(StyleFlexibleBoxData):

LayoutTests:

* css3/flexbox/css-properties-expected.txt:
* css3/flexbox/script-tests/css-properties.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago http://bugs.webkit.org/show_bug.cgi?id=81618
slewis@apple.com [Tue, 20 Mar 2012 03:27:27 +0000 (03:27 +0000)]
http://bugs.webkit.org/show_bug.cgi?id=81618
fast/workers/storage/use-same-database-in-page-and-workers.html times out on the lion bots
parser test that times out waiting for notifyDone

Unreviewed.

Skip test that times out on the Lion WK1 bots.

* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] libWebCore.la has become too big for make
kov@webkit.org [Tue, 20 Mar 2012 03:22:34 +0000 (03:22 +0000)]
[GTK] libWebCore.la has become too big for make
https://bugs.webkit.org/show_bug.cgi?id=81582

Unreviewed build fix.

Source/WebCore:

* GNUmakefile.am: build an intermediate library for modules, so that the list
of source files used to build WebCore can be split and not reach make's limits;
also try to force relinking libWebCore.la and libWebCoreModules.la when the
GNUmakefile.am or GNUmakefile.list.am change

Source/WebKit/gtk:

* GNUmakefile.am: link-in the new libDerivedWebCore.la

Source/WebKit2:

* GNUmakefile.am: link-in the new libWebCoreModules.la

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=81620 tables/mozilla/bugs/bug27038-* fail...
slewis@apple.com [Tue, 20 Mar 2012 03:17:10 +0000 (03:17 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=81620 tables/mozilla/bugs/bug27038-* fail on Lion Bots.

Unreviewed.

Check in new expected (failing?) results.

* platform/mac/tables/mozilla/bugs/bug27038-1-expected.txt:
* platform/mac/tables/mozilla/bugs/bug27038-2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Fixing build. Adding missing virtual.
keishi@webkit.org [Tue, 20 Mar 2012 03:14:24 +0000 (03:14 +0000)]
[chromium] Fixing build. Adding missing virtual.

* src/GraphicsContext3DPrivate.h:
(GraphicsContext3DPrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WK2] http/tests/websocket/tests/hixie76/frame-lengths.html times out on mac-wk2
timothy_horton@apple.com [Tue, 20 Mar 2012 03:13:06 +0000 (03:13 +0000)]
[WK2] http/tests/websocket/tests/hixie76/frame-lengths.html times out on mac-wk2
https://bugs.webkit.org/show_bug.cgi?id=81624

Unreviewed; skip timing out http/tests/websocket/tests/hixie76/frame-lengths.html on mac-wk2

* platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=81615
slewis@apple.com [Tue, 20 Mar 2012 03:12:09 +0000 (03:12 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=81615
fast/parser/nested-fragment-parser-crash.html is failing on the lion bots

Unreviewed.

Check in new expected (failing?) results.

* platform/mac/fast/parser/nested-fragment-parser-crash-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Push culled tiles that are prepainted
commit-queue@webkit.org [Tue, 20 Mar 2012 03:10:45 +0000 (03:10 +0000)]
[chromium] Push culled tiles that are prepainted
https://bugs.webkit.org/show_bug.cgi?id=81552

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-19
Reviewed by Adrienne Walker.

Source/WebCore:

If a tile was culled during paint, but then prepainted in the following
idle paint pass, it was still marked as culled (and thus dirty) and not
pushed to the impl side.

Renames tile->m_updateCulled to tile->m_updated. This value is true if
the tile is updated any time during a commit, and remains false if it
is culled every time the layer is painted.

Unit test: TiledLayerChromiumTest.pushIdlePaintedOccludedTiles

* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::UpdatableTile::isDirtyForCurrentFrame):
(UpdatableTile):
(WebCore::UpdatableTile::UpdatableTile):
(WebCore::TiledLayerChromium::updateCompositorResources):
(WebCore::TiledLayerChromium::prepareToUpdateTiles):
(WebCore::TiledLayerChromium::resetUpdateState):

Source/WebKit/chromium:

* tests/TiledLayerChromiumTest.cpp:
(WTF::TEST):
(WTF):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111335 268f45cc-cd09-0410-ab3c-d52691b4dbfc