WebKit-https.git
9 years agoVersioning.
lforschler@apple.com [Sat, 3 Dec 2011 02:12:22 +0000 (02:12 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Remove entry pointer before freeing it from matrix.
commit-queue@webkit.org [Sat, 3 Dec 2011 01:59:48 +0000 (01:59 +0000)]
[EFL] Remove entry pointer before freeing it from matrix.
https://bugs.webkit.org/show_bug.cgi?id=73625

Patch by JungJik Lee <jungjik.lee@samsung.com> on 2011-12-02
Reviewed by Ryosuke Niwa.

To prevent leaving dangling pointer on the matrix, remove the entry before freeing it.

* ewk/ewk_tiled_matrix.cpp:
(ewk_tile_matrix_free):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImprove float array support in the DFG JIT
oliver@apple.com [Sat, 3 Dec 2011 01:47:27 +0000 (01:47 +0000)]
Improve float array support in the DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=73722

Reviewed by Gavin Barraclough.

Add basic support for float typed arrays in JSC.  This is currently
less optimal than it could be in the following ways:
 * float32Array1[0] = float32Array2[0] (eg. an element by element copy)
   promotes float to double and then back to float.
 * float64Array[0] will always perform NaN tests in order to prevent
   signalling NaNs from entering the engine.

We also don't support Float32Array on ARMv7

* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::loadDouble):
(JSC::MacroAssemblerARMv7::loadFloat):
(JSC::MacroAssemblerARMv7::storeDouble):
(JSC::MacroAssemblerARMv7::storeFloat):
(JSC::MacroAssemblerARMv7::convertFloatToDouble):
(JSC::MacroAssemblerARMv7::convertDoubleToFloat):
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::loadDouble):
(JSC::MacroAssemblerX86Common::loadFloat):
(JSC::MacroAssemblerX86Common::storeDouble):
(JSC::MacroAssemblerX86Common::storeFloat):
(JSC::MacroAssemblerX86Common::convertDoubleToFloat):
(JSC::MacroAssemblerX86Common::convertFloatToDouble):
* assembler/X86Assembler.h:
(JSC::X86Assembler::cvtsd2ss_rr):
(JSC::X86Assembler::cvtss2sd_rr):
(JSC::X86Assembler::movsd_rm):
(JSC::X86Assembler::movss_rm):
(JSC::X86Assembler::movsd_mr):
(JSC::X86Assembler::movss_mr):
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGNode.h:
(JSC::DFG::Node::shouldSpeculateFloat32Array):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
(JSC::DFG::SpeculativeJIT::compileGetByValOnFloatTypedArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForFloatTypedArray):
* dfg/DFGSpeculativeJIT.h:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Move WebLayer APIs to platform directory
jamesr@google.com [Sat, 3 Dec 2011 01:42:23 +0000 (01:42 +0000)]
[chromium] Move WebLayer APIs to platform directory
https://bugs.webkit.org/show_bug.cgi?id=73610

Reviewed by Darin Fisher.

* public/WebContentLayer.h:
* public/WebContentLayerClient.h:
* public/WebExternalTextureLayer.h:
* public/WebLayer.h:
* public/WebLayerClient.h:
* public/WebLayerTreeView.h:
* public/WebLayerTreeViewClient.h:
* public/platform/WebContentLayer.h: Copied from Source/WebKit/chromium/public/WebContentLayer.h.
(WebKit::WebContentLayer::WebContentLayer):
(WebKit::WebContentLayer::~WebContentLayer):
(WebKit::WebContentLayer::operator=):
* public/platform/WebContentLayerClient.h: Copied from Source/WebKit/chromium/public/WebContentLayerClient.h.
(WebKit::WebContentLayerClient::~WebContentLayerClient):
* public/platform/WebExternalTextureLayer.h: Copied from Source/WebKit/chromium/public/WebExternalTextureLayer.h.
(WebKit::WebExternalTextureLayer::WebExternalTextureLayer):
(WebKit::WebExternalTextureLayer::~WebExternalTextureLayer):
(WebKit::WebExternalTextureLayer::operator=):
* public/platform/WebLayer.h: Copied from Source/WebKit/chromium/public/WebLayer.h.
(WebKit::WebLayer::WebLayer):
(WebKit::WebLayer::~WebLayer):
(WebKit::WebLayer::operator=):
(WebKit::WebLayer::isNull):
(WebKit::WebLayer::to):
(WebKit::WebLayer::toConst):
(WebKit::WebLayer::unwrap):
(WebKit::WebLayer::constUnwrap):
(WebKit::operator==):
(WebKit::operator!=):
* public/platform/WebLayerClient.h: Copied from Source/WebKit/chromium/public/WebLayerClient.h.
(WebKit::WebLayerClient::~WebLayerClient):
* public/platform/WebLayerTreeView.h: Copied from Source/WebKit/chromium/public/WebLayerTreeView.h.
(WebKit::WebLayerTreeView::Settings::Settings):
(WebKit::WebLayerTreeView::WebLayerTreeView):
(WebKit::WebLayerTreeView::~WebLayerTreeView):
(WebKit::WebLayerTreeView::operator=):
(WebKit::operator==):
(WebKit::operator!=):
* public/platform/WebLayerTreeViewClient.h: Copied from Source/WebKit/chromium/public/WebLayerTreeViewClient.h.
(WebKit::WebLayerTreeViewClient::~WebLayerTreeViewClient):
* public/platform/WebPrivatePtr.h:
* src/WebContentLayer.cpp:
* src/WebContentLayerImpl.cpp:
* src/WebExternalTextureLayer.cpp:
* src/WebExternalTextureLayerImpl.cpp:
* src/WebLayer.cpp:
* src/WebLayerImpl.cpp:
* src/WebLayerTreeView.cpp:
* src/WebLayerTreeViewImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: Fix mixed content handling for video in Chromium by having
commit-queue@webkit.org [Sat, 3 Dec 2011 01:38:26 +0000 (01:38 +0000)]
Source/WebCore: Fix mixed content handling for video in Chromium by having
CachedResourceLoader & SubresourceLoader use the
ResourceRequest::TargetType when determining if a RawResource can
be requested.
https://bugs.webkit.org/show_bug.cgi?id=72178

Patch by Aaron Colwell <acolwell@chromium.org> on 2011-12-02
Reviewed by Adam Barth.

Tests: http/tests/security/mixedContent/insecure-video-in-iframe.html
       http/tests/security/mixedContent/insecure-video-in-main-frame.html
       http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame.html
       http/tests/security/mixedContent/redirect-https-to-http-video-in-main-frame.html

* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::willSendRequest):
* loader/cache/CachedRawResource.cpp:
(WebCore::CachedRawResource::CachedRawResource):
* loader/cache/CachedRawResource.h:
* loader/cache/CachedResource.cpp:
(WebCore::defaultPriorityForResourceType):
(WebCore::cachedResourceTypeToTargetType):
(WebCore::CachedResource::targetTypeToCachedResourceType):
* loader/cache/CachedResource.h:
* loader/cache/CachedResourceLoader.cpp:
(WebCore::createResource):
(WebCore::CachedResourceLoader::checkInsecureContent):
(WebCore::CachedResourceLoader::canRequest):
(WebCore::CachedResourceLoader::requestResource):

LayoutTests: Adding mixed content tests for video tag.
https://bugs.webkit.org/show_bug.cgi?id=72178

Patch by Aaron Colwell <acolwell@chromium.org> on 2011-12-02
Reviewed by Adam Barth.

* http/tests/security/mixedContent/insecure-video-in-iframe-expected.txt: Added.
* http/tests/security/mixedContent/insecure-video-in-iframe.html: Added.
* http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt: Added.
* http/tests/security/mixedContent/insecure-video-in-main-frame.html: Added.
* http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt: Added.
* http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame.html: Added.
* http/tests/security/mixedContent/redirect-https-to-http-video-in-main-frame-expected.txt: Added.
* http/tests/security/mixedContent/redirect-https-to-http-video-in-main-frame.html: Added.
* http/tests/security/mixedContent/resources/frame-with-insecure-video.html: Added.
* http/tests/security/mixedContent/resources/frame-with-redirect-http-to-https-video.html: Added.
* http/tests/security/mixedContent/resources/frame-with-redirect-https-to-http-video.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Rebaselining svg/custom/svg-fonts-word-spacing.html
scheib@chromium.org [Sat, 3 Dec 2011 01:35:56 +0000 (01:35 +0000)]
[Chromium] Rebaselining svg/custom/svg-fonts-word-spacing.html

* platform/chromium-cg-mac-snowleopard/accessibility/aria-checkbox-sends-notification-expected.txt: Copied from LayoutTests/platform/chromium/accessibility/aria-checkbox-sends-notification-expected.txt.
* platform/chromium-mac-snowleopard/accessibility/aria-checkbox-sends-notification-expected.txt: Copied from LayoutTests/platform/chromium/accessibility/aria-checkbox-sends-notification-expected.txt.
* platform/chromium-win/accessibility/aria-checkbox-sends-notification-expected.txt: Renamed from LayoutTests/platform/chromium/accessibility/aria-checkbox-sends-notification-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Marking svg/W3C-SVG-1.1/fonts-elem-04-b.svg flaky for image+text
scheib@chromium.org [Sat, 3 Dec 2011 01:28:19 +0000 (01:28 +0000)]
[Chromium] Marking svg/W3C-SVG-1.1/fonts-elem-04-b.svg flaky for image+text

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoEnable parallel testing for Win and Gtk bots
eric@webkit.org [Sat, 3 Dec 2011 01:04:36 +0000 (01:04 +0000)]
Enable parallel testing for Win and Gtk bots
after confirming with Lucas and Martin the bots should be OK.

Unreviewed. (I ran the idea by Lucas and Martin.)

* Scripts/run-webkit-tests:
(platformIsReadyForParallelTesting):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] add setOpener method to WebFrame
commit-queue@webkit.org [Sat, 3 Dec 2011 00:53:47 +0000 (00:53 +0000)]
[chromium] add setOpener method to WebFrame
https://bugs.webkit.org/show_bug.cgi?id=73379

Patch by Karl Koscher <supersat@chromium.org> on 2011-12-02
Reviewed by Darin Fisher.

* public/WebFrame.h:
(WebKit::WebFrame::clearOpener): now an inline call to setOpener(0)
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::setOpener): sets window.opener
* src/WebFrameImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r101731.
dcheng@chromium.org [Sat, 3 Dec 2011 00:13:51 +0000 (00:13 +0000)]
Unreviewed, rolling out r101731.
http://trac.webkit.org/changeset/101731
https://bugs.webkit.org/show_bug.cgi?id=73706

Broke copy and paste in chromium. (Requested by dcheng on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-02

Source/WebCore:

* editing/SpellChecker.cpp:
(WebCore::SpellChecker::SpellChecker):
(WebCore::SpellChecker::initRequest):
(WebCore::SpellChecker::clearRequest):
(WebCore::SpellChecker::canCheckAsynchronously):
(WebCore::SpellChecker::isBusy):
(WebCore::SpellChecker::isValid):
(WebCore::SpellChecker::requestCheckingFor):
(WebCore::SpellChecker::doRequestCheckingFor):
(WebCore::SpellChecker::didCheck):
* editing/SpellChecker.h:

LayoutTests:

* editing/spelling/spellcheck-queue-expected.txt: Removed.
* editing/spelling/spellcheck-queue.html: Removed.
* platform/gtk/Skipped:
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWhen page scaling is in use position:fixed has incorrect results
fsamuel@chromium.org [Sat, 3 Dec 2011 00:04:46 +0000 (00:04 +0000)]
When page scaling is in use position:fixed has incorrect results
https://bugs.webkit.org/show_bug.cgi?id=68617

Reviewed by Simon Fraser.

.:

* Source/autotools/symbols.filter:

Source/WebCore:

Add the option for position:fixed elements to be fixed to the frame
instead of the layout rectangle of the document.

Tests: fast/repaint/fixed-in-page-scale.html
       fast/repaint/fixed-right-bottom-in-page-scale.html
       fast/repaint/fixed-right-in-page-scale.html

* WebCore.exp.in:
* page/FrameView.cpp:
(WebCore::FrameView::reset):
(WebCore::FrameView::scrollXForFixedPosition):
(WebCore::FrameView::scrollYForFixedPosition):
  If position:fixed elements are relative to the frame, disregard the
  drag factor.
(WebCore::FrameView::setShouldLayoutFixedElementsRelativeToFrame):
* page/FrameView.h:
(WebCore::FrameView::shouldLayoutFixedElementsRelativeToFrame):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::shouldLayoutFixedElementRelativeToFrame):
(WebCore::RenderBox::containingBlockLogicalWidthForPositioned):
(WebCore::RenderBox::containingBlockLogicalHeightForPositioned):
  If position:fixed elements are relative to the frame, their container
  is the frame instead of the layout rect of the document.
  This allows proper positioning of these elements to the right and
  bottom.
* rendering/RenderBox.h:
* testing/Internals.cpp:
(WebCore::Internals::setShouldLayoutFixedElementsRelativeToFrame):
* testing/Internals.h:
* testing/Internals.idl:
  Allow enabling and disabling the new behavior in layout tests.

Source/WebKit2:

* win/WebKit2.def:
* win/WebKit2CFLite.def:

LayoutTests:

* fast/repaint/fixed-in-page-scale-expected.png: Added.
* fast/repaint/fixed-in-page-scale-expected.txt: Added.
* fast/repaint/fixed-in-page-scale.html: Added.
* fast/repaint/fixed-right-bottom-in-page-scale-expected.png: Added.
* fast/repaint/fixed-right-bottom-in-page-scale-expected.txt: Added.
* fast/repaint/fixed-right-bottom-in-page-scale.html: Added.
* fast/repaint/fixed-right-in-page-scale-expected.png: Added.
* fast/repaint/fixed-right-in-page-scale-expected.txt: Added.
* fast/repaint/fixed-right-in-page-scale.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix for SubresourceLoader when building with Core Foundation
benjamin@webkit.org [Fri, 2 Dec 2011 23:55:21 +0000 (23:55 +0000)]
Build fix for SubresourceLoader when building with Core Foundation
https://bugs.webkit.org/show_bug.cgi?id=73709

Patch by Benjamin Poulain <bpoulain@apple.com> on 2011-12-02
Reviewed by David Kilzer.

The patch r100311 removed SubresourceClient and merged it in SubresourceLoader.
Consequently, m_client does not exist anymore and there is no need to do the check
before invoking didReceiveData().

* loader/cf/SubresourceLoaderCF.cpp:
(WebCore::SubresourceLoader::didReceiveDataArray):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/10423627> Layers are flipped in WebKit1 views
simon.fraser@apple.com [Fri, 2 Dec 2011 23:54:43 +0000 (23:54 +0000)]
<rdar://problem/10423627> Layers are flipped in WebKit1 views

Reviewed by Sam Weinig.

Host the compositing layers in an NSView which is flipped, which helps AppKit
get the geometry right in some situations.

* WebView/WebHTMLView.mm:
(-[WebLayerHostingFlippedView isFlipped]):
(-[WebHTMLView attachRootLayer:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFixed a typo
mitz@apple.com [Fri, 2 Dec 2011 23:48:50 +0000 (23:48 +0000)]
Fixed a typo

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoStyledElement: Simplify addCSSColor().
kling@webkit.org [Fri, 2 Dec 2011 23:48:34 +0000 (23:48 +0000)]
StyledElement: Simplify addCSSColor().
<http://webkit.org/b/73703>

Reviewed by Darin Adler.

The Color(const String&) constructor handles both named and 3/6-digit
hex colors, so there's no need to handle those separately here.
Also tweaked some comments and minor things.

* dom/StyledElement.cpp:
(WebCore::StyledElement::addCSSColor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTry to fix the GTK+ debug bot. As discussed with other GTK+
mrobinson@webkit.org [Fri, 2 Dec 2011 23:45:39 +0000 (23:45 +0000)]
Try to fix the GTK+ debug bot. As discussed with other GTK+
hackers recently. It makes sense to just remove G_DISABLE_DEPRECATIONS
now in WebKit. The flag itself is now deprecated in GLib in favor of
the gcc attribute.

* GNUmakefile.am: Remove G_DISABLE_DEPRECATED.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Marking svg/W3C-SVG-1.1/fonts-elem-04-b.svg flaky for text
scheib@chromium.org [Fri, 2 Dec 2011 23:38:23 +0000 (23:38 +0000)]
[Chromium] Marking svg/W3C-SVG-1.1/fonts-elem-04-b.svg flaky for text

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate platform/iphone to platform/ios
benjamin@webkit.org [Fri, 2 Dec 2011 23:36:06 +0000 (23:36 +0000)]
Update platform/iphone to platform/ios
https://bugs.webkit.org/show_bug.cgi?id=73708

Patch by Benjamin Poulain <bpoulain@apple.com> on 2011-12-02
Reviewed by Darin Adler.

The platform is now best known as iOS, update the platform layer accordingly.

* Configurations/WebCore.xcconfig:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* platform/cocoa/KeyEventCocoa.mm:
* platform/ios/KeyEventCodesIOS.h: Renamed from Source/WebCore/platform/iphone/KeyEventCodesIPhone.h.
* platform/ios/KeyEventIOS.mm: Renamed from Source/WebCore/platform/iphone/KeyEventIPhone.mm.
(WebCore::keyIdentifierForKeyEvent):
(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
(WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent):
(WebCore::PlatformKeyboardEvent::currentCapsLockState):
(WebCore::PlatformKeyboardEvent::getCurrentModifierState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Adding test expectation that svg/animations/svginteger-animation-1.html...
scheib@chromium.org [Fri, 2 Dec 2011 23:31:35 +0000 (23:31 +0000)]
[Chromium] Adding test expectation that svg/animations/svginteger-animation-1.html crashes leopard cg

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Marking http/tests/appcache/video.html TIMEOUT
scheib@chromium.org [Fri, 2 Dec 2011 23:18:09 +0000 (23:18 +0000)]
[Chromium] Marking http/tests/appcache/video.html TIMEOUT

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Eliminate unnecessary state on previous CL
commit-queue@webkit.org [Fri, 2 Dec 2011 23:03:06 +0000 (23:03 +0000)]
[chromium] Eliminate unnecessary state on previous CL
https://bugs.webkit.org/show_bug.cgi?id=73661

Patch by Jonathan Backer <backer@chromium.org> on 2011-12-02
Reviewed by Kenneth Russell.

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::initialize):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::didBecomeInvisibleOnImplThread):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCSettings::CCSettings):
(WebCore::LayerRendererCapabilities::LayerRendererCapabilities):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Suppressing failures in test_expectations for 101844
scheib@chromium.org [Fri, 2 Dec 2011 23:02:58 +0000 (23:02 +0000)]
[Chromium] Suppressing failures in test_expectations for 101844

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTry to fix the GTK+ build.
mrobinson@webkit.org [Fri, 2 Dec 2011 22:59:58 +0000 (22:59 +0000)]
Try to fix the GTK+ build.

* gtk/jhbuild.modules: Properly specify the glib-networking
dependency for soup.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix a syntax error in the committers.py file.
mrobinson@webkit.org [Fri, 2 Dec 2011 22:58:21 +0000 (22:58 +0000)]
Fix a syntax error in the committers.py file.

* Scripts/webkitpy/common/config/committers.py: Add a missing comma.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Update sandbox rules
ap@apple.com [Fri, 2 Dec 2011 22:56:23 +0000 (22:56 +0000)]
    Update sandbox rules
        https://bugs.webkit.org/show_bug.cgi?id=73675
        <rdar://problem/9276430>

        Reviewed by Sam Weinig.

        * WebProcess/com.apple.WebProcess.sb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd Alan Stearns and Peter Linss to the contributors list.
rniwa@webkit.org [Fri, 2 Dec 2011 22:49:58 +0000 (22:49 +0000)]
Add Alan Stearns and Peter Linss to the contributors list.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/10520670> REGRESSION (r91738): didFinishLoad is called before custom...
mitz@apple.com [Fri, 2 Dec 2011 22:49:53 +0000 (22:49 +0000)]
<rdar://problem/10520670> REGRESSION (r91738): didFinishLoad is called before custom fonts have finished loading
https://bugs.webkit.org/show_bug.cgi?id=73688

Reviewed by Darin Adler.

Source/WebCore:

The problem was that after CSSFontFaceSource::getFontData() had scheduled a 0-delay timer to
begin loading the font, but before that timer fired, the subresource loader appeared to have
had no resources waiting to be loaded, and therefore didFinishLoad could be called. This change
reworks the fix for <http://webkit.org/b/65123> so that while the load is still started on a
0-dealy timer, the subresource loader’s request count is incremented immediately, preventing
it from hitting 0 while the font load is scheduled to begin. The delayed load mechanism is
moved from CSSFontFaceSource into CSSFontSelector in order to safely handle the possibility of
the latter being decommissioned while waiting for font loading to begin.

* css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::CSSFontFaceSource): Removed initializer for m_loadStartTimer.
(WebCore::CSSFontFaceSource::~CSSFontFaceSource): Removed stopping of m_loadStartTimer.
(WebCore::CSSFontFaceSource::getFontData): Replaced code to schedule loading on a timer with
a call to CSSFontSelector::beginLoadingFontSoon.
* css/CSSFontFaceSource.h: Removed m_loadStartTimer and m_fontSelector member variables.
* css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::CSSFontSelector): Added initialized for m_beginLoadingTimer.
(WebCore::CSSFontSelector::~CSSFontSelector): Added call to clearDocument(), to deal with
anything remaining in m_fontsToBeginLoading at this time.
(WebCore::CSSFontSelector::clearDocument): Now stops m_beginLoadingTimer and balances
incrementRequestCount() calls for anything remaining in m_fontsToBeginLoading.
(WebCore::CSSFontSelector::beginLoadingFontSoon): Added. Schedules the actual call to
CachedFont::beginLoadingIfNeeded on a 0-delay timer, and meanwhile increments the request count
on the CachedResourceLoader, which ensures that didFinishLoad will not be called while waiting
for the timer to fire.
(WebCore::CSSFontSelector::beginLoadTimerFired): Added. Actually calls
CachedFont::beginLoadIfNeeded and balances the incrementRequestCount() made when the timer was
scheduled.
* css/CSSFontSelector.h:

LayoutTests:

Reverted test chnages from r91738. These tests were made to wait for the fonts to finish loading
using a DOM. Now again they do not need to.

* fast/css/color-leakage.html:
* fast/css/custom-font-xheight.html:
* fast/css/font-face-multiple-faces.html:
* fast/css/font-face-multiple-remote-sources.html:
* fast/css/font-face-remote.html:
* fast/css/font-face-woff.html:
* fast/writing-mode/broken-ideograph-small-caps.html:
* svg/W3C-SVG-1.1-SE/text-intro-09-b.svg:
* svg/W3C-SVG-1.1/fonts-elem-07-b.svg:
* svg/custom/svg-fonts-fallback.xhtml:
* svg/custom/svg-fonts-in-html.html:
* svg/custom/svg-fonts-segmented.xhtml:
* svg/custom/svg-fonts-with-no-element-reference.html:
* svg/custom/svg-fonts-without-missing-glyph.xhtml:
* svg/text/text-overflow-ellipsis-svgfont.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Fix compilation warnings for ASSERT()
tkent@chromium.org [Fri, 2 Dec 2011 22:42:23 +0000 (22:42 +0000)]
[Chromium] Fix compilation warnings for ASSERT()
https://bugs.webkit.org/show_bug.cgi?id=73623

Reviewed by Tony Chang.

* DumpRenderTree/chromium/ImageDiff.cpp:
 - Fix fprintf format: %s -> %d for __LINE__
 - Do nothing for ASSERT() if NDEBUG.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoEnable parallel testing for all Mac bots.
eric@webkit.org [Fri, 2 Dec 2011 22:37:13 +0000 (22:37 +0000)]
Enable parallel testing for all Mac bots.

Unreviewed.

* Scripts/run-webkit-tests:
(platformIsReadyForParallelTesting):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSend an AXCheckedStateChanged notification when the aria-checked attribute changes.
commit-queue@webkit.org [Fri, 2 Dec 2011 22:34:53 +0000 (22:34 +0000)]
Send an AXCheckedStateChanged notification when the aria-checked attribute changes.
https://bugs.webkit.org/show_bug.cgi?id=72754

Patch by David Tseng <dtseng@google.com> on 2011-12-02
Reviewed by Chris Fleizach.

Source/WebCore:

Test: accessibility/aria-checkbox-sends-notification.html

* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::checkedStateChanged):
* accessibility/AXObjectCache.h:
* dom/Element.cpp:
(WebCore::Element::updateAfterAttributeChanged):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setChecked):

LayoutTests:

* accessibility/aria-checkbox-sends-notification.html: Added.
* platform/chromium/accessibility/aria-checkbox-sends-notification-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Recycle tile-sized textures during commit to prevent reallocations
commit-queue@webkit.org [Fri, 2 Dec 2011 22:30:08 +0000 (22:30 +0000)]
[chromium] Recycle tile-sized textures during commit to prevent reallocations
https://bugs.webkit.org/show_bug.cgi?id=70645

Patch by Grace Kloba <klobag@chromium.org> on 2011-12-02
Reviewed by James Robinson.

Currently texture request is capped by the high limit while we reclaim the
textures in each commit. This triggers new tiles always allocated when scrolling.
The proposal is to recycle the texture during request if the total used memory
is about to exceed the reclaim limit.

* platform/graphics/chromium/ManagedTexture.cpp:
(WebCore::ManagedTexture::reserve):
* platform/graphics/chromium/TextureManager.cpp:
(WebCore::TextureManager::setMemoryLimitBytes):
(WebCore::TextureManager::replaceTexture):
(WebCore::TextureManager::requestTexture):
* platform/graphics/chromium/TextureManager.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoEnable parallel testing for run-webkit-tests on Mac Lion.
eric@webkit.org [Fri, 2 Dec 2011 22:26:56 +0000 (22:26 +0000)]
Enable parallel testing for run-webkit-tests on Mac Lion.
I plan to move all the machines to parallel testing shortly
but we're starting with Lion.

Unreviewed.

* Scripts/run-webkit-tests:
(platformIsReadyForParallelTesting):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r101337.
tkent@chromium.org [Fri, 2 Dec 2011 22:17:27 +0000 (22:17 +0000)]
Unreviewed, rolling out r101337.
http://trac.webkit.org/changeset/101337
https://bugs.webkit.org/show_bug.cgi?id=73189

It's a wrong way to fix the problem

Source/WebKit/chromium:

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::popupOpened):

LayoutTests:

* fast/forms/select-popup-crash-expected.txt: Removed.
* fast/forms/select-popup-crash.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdded helper method to identify whether the page has custom page size style.
tkent@chromium.org [Fri, 2 Dec 2011 22:07:11 +0000 (22:07 +0000)]
Added helper method to identify whether the page has custom page size style.
https://bugs.webkit.org/show_bug.cgi?id=73585

Patch by Kausalya Madhusudhanan <kmadhusu@chromium.org> on 2011-12-02
Reviewed by Darin Fisher.

Source/WebKit/chromium:

* public/WebFrame.h:
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::hasCustomPageSizeStyle):
* src/WebFrameImpl.h:

Tools:

* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::hasCustomPageSizeStyle):
* DumpRenderTree/chromium/LayoutTestController.h:

LayoutTests:

* platform/chromium/printing/custom-page-size-style-expected.txt: Added.
* platform/chromium/printing/custom-page-size-style.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Adding flaky tests to test_expectations
scheib@chromium.org [Fri, 2 Dec 2011 22:02:58 +0000 (22:02 +0000)]
[Chromium] Adding flaky tests to test_expectations

inspector/extensions tests even flakier
newly flaky media/event-attributes.html

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed: reset expectation for tests until https://bugs.webkit.org/show_bug.cgi...
dslomov@google.com [Fri, 2 Dec 2011 21:59:05 +0000 (21:59 +0000)]
Unreviewed: reset expectation for tests until https://bugs.webkit.org/show_bug.cgi?id=73691
is fixed.

* fast/dom/Window/window-postmessage-args-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Show placeholder even if the element is focused
tkent@chromium.org [Fri, 2 Dec 2011 21:55:41 +0000 (21:55 +0000)]
[Chromium] Show placeholder even if the element is focused
https://bugs.webkit.org/show_bug.cgi?id=73629

Reviewed by Hajime Morita.

No new tests. Need to update some existing placeholder tests.

* rendering/RenderThemeChromiumMac.h: Add shouldShowPlaceholderWhenFocused().
* rendering/RenderThemeChromiumMac.mm:
(WebCore::RenderThemeChromiumMac::shouldShowPlaceholderWhenFocused):
Returns true.
* rendering/RenderThemeChromiumSkia.cpp:
(WebCore::RenderThemeChromiumSkia::shouldShowPlaceholderWhenFocused): ditto.
* rendering/RenderThemeChromiumSkia.h: Add shouldShowPlaceholderWhenFocused().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Lion][Windows] Both of placeholder and input text are shown in <input type=number>
tkent@chromium.org [Fri, 2 Dec 2011 21:49:30 +0000 (21:49 +0000)]
[Lion][Windows] Both of placeholder and input text are shown in <input type=number>
https://bugs.webkit.org/show_bug.cgi?id=73615

Reviewed by Joseph Pecoraro.

Source/WebCore:

Placeholder visibility was checked by HTMLInputElement::value
emptiness. It should be innerTextValue emptiness because it is
possible that a number field has empty HTMLInputElement::value and
non-empty innerTextValue.

Tests: fast/forms/number/number-placeholder-with-unacceptable-value.html

* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::updateInnerTextValue):
We should update placeholder visiblity when the innerTextValue is updated.
(WebCore::HTMLInputElement::subtreeHasChanged): ditto.
(WebCore::HTMLInputElement::setSuggestedValue):
We don't need to call updatePlaceholderVisibility() because updateInnerTextValue() calls it.
(WebCore::HTMLInputElement::setValueFromRenderer):
We don't need to call updatePlaceholderVisibility() because subtreeHasChanged() calls it.
* html/HTMLInputElement.h: Checks innerTextValue emptiness.
* html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::setValue):
We don't need to call updatePlaceholderVisibility() because updateInnerTextValue() calls it.

LayoutTests:

* fast/forms/number/number-placeholder-with-unacceptable-value-expected.html: Added.
* fast/forms/number/number-placeholder-with-unacceptable-value.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] GYP fix for Windows 2010 build
tony@chromium.org [Fri, 2 Dec 2011 21:49:17 +0000 (21:49 +0000)]
[Chromium] GYP fix for Windows 2010 build
https://bugs.webkit.org/show_bug.cgi?id=73483

Reviewed by Adam Barth.

Patch by Carlos Pizano.

* WebKit.gyp: Exclude the android directory and remove a file match that doesn't match anything.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[NRWT] reftest should support having multiple references per test
rniwa@webkit.org [Fri, 2 Dec 2011 21:42:32 +0000 (21:42 +0000)]
[NRWT] reftest should support having multiple references per test
https://bugs.webkit.org/show_bug.cgi?id=73613

Reviewed by Dirk Pranke.

Add a support for having multiple reference files for a single test.

Because a reftest succeeds when it matches at least one of expected matches and fails when it matches
at least one of expected mismatches, we compare expected mismatches first in order to minimize
the number of reference files to open on DRT.

* Scripts/webkitpy/layout_tests/controllers/manager.py:
(interpret_test_failures): Remove checks no longer applicable.
* Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
(ResultSummaryTest.test_interpret_test_failures): Ditto.
* Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner.__init__): Remove a bunch of code and just call port.reference_files.
(SingleTestRunner._driver_input):
(SingleTestRunner.run):
(SingleTestRunner._run_reftest): Compare the output of the test to each reference file.
* Scripts/webkitpy/layout_tests/models/test_input.py:
(TestInput.__init__): Remove ref_file and is_mismatch_reftest because they are no longer used.
* Scripts/webkitpy/layout_tests/port/base.py:
(Port.reference_files): Renamed from _reference_file_for. Returns a list of expectation, filename pairs.
(_parse_reftest_list): Now supports parsing multiple entries for a single test.
* Scripts/webkitpy/layout_tests/port/base_unittest.py:
(PortTest.test_parse_reftest_list):
* Scripts/webkitpy/layout_tests/port/test.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_unexpected_failures):
(MainTest.test_reftest_skipped_if_unlisted): Renamed from test_missing_and_unexpected_results.
(EndToEndTest.test_end_to_end):
(EndToEndTest.test_reftest_with_two_notrefs): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: [chromium] CCLayerQuad does not return FloatQuad in correct order
alokp@chromium.org [Fri, 2 Dec 2011 21:08:40 +0000 (21:08 +0000)]
Source/WebCore: [chromium] CCLayerQuad does not return FloatQuad in correct order
https://bugs.webkit.org/show_bug.cgi?id=73247

Reviewed by James Robinson.

Returned the FloatQuad coordinates in correct order.

Covered by new unit tests in CCLayerQuadTest.cpp.

* platform/graphics/chromium/cc/CCLayerQuad.cpp:
(WebCore::CCLayerQuad::floatQuad):

Source/WebKit/chromium: [chromium] CCLayerQuad does not return FloatQuad in correct order
https://bugs.webkit.org/show_bug.cgi?id=73247

Reviewed by James Robinson.

* WebKit.gypi:
* tests/CCLayerQuadTest.cpp: Added.
(WebCore::TEST):

LayoutTests: [chromium] CCLayerQuad does not return FloatQuad in correct order
https://bugs.webkit.org/show_bug.cgi?id=73247

Reviewed by James Robinson.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Marking slow test: http/tests/appcache/video.html
scheib@chromium.org [Fri, 2 Dec 2011 19:57:28 +0000 (19:57 +0000)]
[Chromium] Marking slow test: http/tests/appcache/video.html

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] WebKitMutationObserver::deliverAllMutations should be exposed through...
adamk@chromium.org [Fri, 2 Dec 2011 19:39:04 +0000 (19:39 +0000)]
[chromium] WebKitMutationObserver::deliverAllMutations should be exposed through the Chromium API
https://bugs.webkit.org/show_bug.cgi?id=71242

Reviewed by Darin Fisher.

Relanding, depends on http://codereview.chromium.org/8748015/
to fix a sandboxing issue on Chromium/Linux.

Add addTaskObserver and removeTaskObserver to WebThread,
along with a new WebThread::TaskObserver interface.

For mutation observers, add a TaskObserver to the main thread
to deliver mutations after each task runs.

The Chromium implementation of the new WebThread methods is in
http://codereview.chromium.org/8586038/.

* public/platform/WebThread.h:
(WebKit::WebThread::TaskObserver::~TaskObserver):
* src/WebKit.cpp:
(WebKit::initialize):
(WebKit::shutdown):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r101833.
scheib@chromium.org [Fri, 2 Dec 2011 19:31:10 +0000 (19:31 +0000)]
Unreviewed, rolling out r101833.
http://trac.webkit.org/changeset/101833
https://bugs.webkit.org/show_bug.cgi?id=73678

test_expectations file invalid: run Tools/Scripts/new-run-
webkit-tests --lint-test-files (Requested by scheib on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-02

Source/WebCore:

* platform/graphics/chromium/cc/CCLayerQuad.cpp:
(WebCore::CCLayerQuad::floatQuad):

Source/WebKit/chromium:

* WebKit.gypi:
* tests/CCLayerQuadTest.cpp: Removed.

LayoutTests:

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild libsoup without gnome dependencies (like keyring).
kov@webkit.org [Fri, 2 Dec 2011 19:24:08 +0000 (19:24 +0000)]
Build libsoup without gnome dependencies (like keyring).

* gtk/jhbuild.modules:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Fixe test_expectations.txt parse error
scheib@chromium.org [Fri, 2 Dec 2011 19:21:58 +0000 (19:21 +0000)]
[Chromium] Fixe test_expectations.txt parse error

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebKit2: Freeze the state of the layer tree until frame load completion if incrementa...
aestes@apple.com [Fri, 2 Dec 2011 19:21:19 +0000 (19:21 +0000)]
WebKit2: Freeze the state of the layer tree until frame load completion if incremental rendering is suppressed
https://bugs.webkit.org/show_bug.cgi?id=73641

Reviewed by Darin Adler.

* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidFirstLayout): Do not
un-freeze the layer tree state if incremental rendering is suppressed.
* WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::layerTreeStateIsFrozen): Add a getter for
m_layerTreeStateIsFrozen.
* WebProcess/WebPage/DrawingAreaImpl.h:
(WebKit::DrawingAreaImpl::layerTreeStateIsFrozen): Ditto.
* WebProcess/WebPage/ca/LayerTreeHostCA.cpp:
(WebKit::LayerTreeHostCA::initialize): WebFrameLoaderClient might have
tried to freeze the state of the layer tree before the layer tree host
was created. When creating the layer tree host, only schedule a layer
flush if the layer tree state isn't frozen.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAlso build gcrypt and p11-kit, and make them dependencies of
kov@webkit.org [Fri, 2 Dec 2011 19:19:49 +0000 (19:19 +0000)]
Also build gcrypt and p11-kit, and make them dependencies of
gnutls.

* gtk/jhbuild.modules:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Expected flakey tests after fix for 73021 is committed
scheib@chromium.org [Fri, 2 Dec 2011 19:19:41 +0000 (19:19 +0000)]
[Chromium] Expected flakey tests after fix for 73021 is committed
https://bugs.webkit.org/show_bug.cgi?id=73677

Unreviewed test_expectations update.

Patch by Stephen Chenney <schenney@chromium.org> on 2011-12-02

* platform/chromium/test_expectations.txt: Added flakey for svg/stroke/...

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[wx] Unreviewed build fixes for Windows build.
kevino@webkit.org [Fri, 2 Dec 2011 19:16:46 +0000 (19:16 +0000)]
[wx] Unreviewed build fixes for Windows build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReviewed by Adam Barth.
eric@webkit.org [Fri, 2 Dec 2011 19:10:30 +0000 (19:10 +0000)]
Reviewed by Adam Barth.

webkit-patch post, post-commits, upload should warn when posting to a closed bug, and offer to reopen it
https://bugs.webkit.org/show_bug.cgi?id=32006

I decided not to make it warn, and just have it re-open the bug.
That's not that different from today's behavior which will
just silently attach the patch.

This patch makes behavior between upload and land-safely consistent
(previously one would assign patches and the other would not)
as well as adds the ability for both to ensure that the bug is open.

To test this I had to add a few more methods to MockBugzilla which
(positively) affected a few other test results.

I also made AbstractStep keep a cached copy of the Bug object
and used the cached copy where appropriate (including for 'bug_title').
This should reduce the number of bug fetches we perform.

* Scripts/webkitpy/tool/commands/download_unittest.py:
* Scripts/webkitpy/tool/commands/upload.py:
* Scripts/webkitpy/tool/commands/upload_unittest.py:
* Scripts/webkitpy/tool/mocktool.py:
* Scripts/webkitpy/tool/steps/__init__.py:
* Scripts/webkitpy/tool/steps/abstractstep.py:
* Scripts/webkitpy/tool/steps/closebug.py:
* Scripts/webkitpy/tool/steps/ensurebugisopenandassigned.py: Added.
* Scripts/webkitpy/tool/steps/postdiff.py:
* Scripts/webkitpy/tool/steps/postdiffforcommit.py:
* Scripts/webkitpy/tool/steps/preparechangelog.py:
* Scripts/webkitpy/tool/steps/steps_unittest.py:
* Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] CCLayerQuad does not return FloatQuad in correct orientation
alokp@chromium.org [Fri, 2 Dec 2011 19:08:22 +0000 (19:08 +0000)]
[chromium] CCLayerQuad does not return FloatQuad in correct orientation
https://bugs.webkit.org/show_bug.cgi?id=73247

Reviewed by James Robinson.

Source/WebCore:

Returned the FloatQuad coordinates in correct order.

Covered by new unit tests in CCLayerQuadTest.cpp.

* platform/graphics/chromium/cc/CCLayerQuad.cpp:
(WebCore::CCLayerQuad::floatQuad):

Source/WebKit/chromium:

* WebKit.gypi:
* tests/CCLayerQuadTest.cpp: Added.
(WebCore::TEST):

LayoutTests:

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAlso pass --no-interact to jhbuild when updating dependencies.
kov@webkit.org [Fri, 2 Dec 2011 19:05:20 +0000 (19:05 +0000)]
Also pass --no-interact to jhbuild when updating dependencies.

* Scripts/update-webkitgtk-libs:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=73589
dslomov@google.com [Fri, 2 Dec 2011 19:00:27 +0000 (19:00 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=73589
[V8][Chromium] Adjust postMessage to the latest "implementation-ready" spec.
- postMessage should support transfer of MessagePorts
- the order of arguments to Window::postMessage and Window::webkitPostMessage should be (msg, targetOrigin [, transfer])

Reviewed by David Levin.

Source/WebCore:

* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::handlePostMessageCallback):
* bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:
(WebCore::handlePostMessageCallback):
* bindings/v8/custom/V8MessagePortCustom.cpp:
(WebCore::handlePostMessageCallback):
* bindings/v8/custom/V8WorkerCustom.cpp:
(WebCore::handlePostMessageCallback):

LayoutTests:

* fast/canvas/webgl/script-tests/arraybuffer-transfer-of-control.js:
(wrapSend):
(wrapFailSend):
* fast/dom/Window/window-postmessage-args.html:
* platform/chromium/fast/dom/Window/window-postmessage-args-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=73497
enrica@apple.com [Fri, 2 Dec 2011 18:57:09 +0000 (18:57 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=73497
This is a followup to the patch submitted for the bug above.
Tha patch was landed in r101575 and I missed to make one of the changes
suggested by the reviewer that had pointed out that the code was still
making use of the deprecatedNode method.

Unreviewed.

* editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::removeRedundantBlocks): Changed deprecatedNode to containerNode.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoContent-security-policy script-src not enforced on workers.
tsepez@chromium.org [Fri, 2 Dec 2011 18:55:05 +0000 (18:55 +0000)]
Content-security-policy script-src not enforced on workers.
https://bugs.webkit.org/show_bug.cgi?id=73240

Reviewed by Adam Barth.

Source/WebCore:

Add a CSP check in AbstractWorker.cpp as part of resolving URL.

Test: http/tests/security/contentSecurityPolicy/worker-script-src.html

* workers/AbstractWorker.cpp:
(WebCore::AbstractWorker::resolveURL):

LayoutTests:

Added test to verify bug.

* http/tests/security/contentSecurityPolicy/worker-script-src-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/worker-script-src.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Add plumbing for supporting custom MIME types in DataTransfer.
dcheng@chromium.org [Fri, 2 Dec 2011 18:52:52 +0000 (18:52 +0000)]
[chromium] Add plumbing for supporting custom MIME types in DataTransfer.
https://bugs.webkit.org/show_bug.cgi?id=73594

Reviewed by David Levin.

Source/WebCore:

Tests: editing/pasteboard/clipboard-customData.html
       fast/events/drag-customData.html

* platform/chromium/ChromiumDataObject.cpp:
(WebCore::ChromiumDataObject::types):
(WebCore::ChromiumDataObject::getData):
(WebCore::ChromiumDataObject::setData):
* platform/chromium/ChromiumDataObject.h:
(WebCore::ChromiumDataObject::customData):
* platform/chromium/PlatformSupport.h:

Source/WebKit/chromium:

* public/platform/WebClipboard.h:
(WebKit::WebClipboard::readCustomData):
* public/platform/WebDragData.h:
* src/PlatformSupport.cpp:
(WebCore::PlatformSupport::clipboardReadCustomData):
* src/WebDragData.cpp:
(WebKit::WebDragData::customData):
(WebKit::WebDragData::setCustomData):

LayoutTests:

* editing/pasteboard/clipboard-customData-expected.txt: Added.
* editing/pasteboard/clipboard-customData.html: Added.
* fast/events/drag-customData-expected.txt: Added.
* fast/events/drag-customData.html: Added.
* platform/chromium/test_expectations.txt:
* platform/efl/Skipped:
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake _build_path check more thoroughly that build paths exist.
aboxhall@chromium.org [Fri, 2 Dec 2011 18:47:17 +0000 (18:47 +0000)]
Make _build_path check more thoroughly that build paths exist.
https://bugs.webkit.org/show_bug.cgi?id=73601

Reviewed by Ojan Vafai.

* Scripts/webkitpy/layout_tests/port/chromium_mac.py:
(ChromiumMacPort._build_path):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd libffi to the jhbuild modules list as a glib dependency.
kov@webkit.org [Fri, 2 Dec 2011 18:44:54 +0000 (18:44 +0000)]
Add libffi to the jhbuild modules list as a glib dependency.

Rubber-stamped by Martin Robinson.

* gtk/jhbuild.modules:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Mac] Form stream data structures still not threadsafe
darin@apple.com [Fri, 2 Dec 2011 18:34:37 +0000 (18:34 +0000)]
[Mac] Form stream data structures still not threadsafe
https://bugs.webkit.org/show_bug.cgi?id=73674

Reviewed by Anders Carlsson.

* platform/network/mac/FormDataStreamMac.mm:
(WebCore::streamFieldsMapMutex): Added.
(WebCore::associateStreamWithResourceHandle): Use streamFieldsMapMutex.
(WebCore::formCreate): Ditto.
(WebCore::formFinalize): Ditto.
(WebCore::httpBodyFromStream): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIndexedDB: Rename "multientry" to "multiEntry" per spec change
commit-queue@webkit.org [Fri, 2 Dec 2011 18:31:40 +0000 (18:31 +0000)]
IndexedDB: Rename "multientry" to "multiEntry" per spec change
https://bugs.webkit.org/show_bug.cgi?id=73578

Patch by Joshua Bell <jsbell@chromium.org> on 2011-12-02
Reviewed by Darin Fisher.

Source/WebCore:

* storage/IDBIndex.h:
(WebCore::IDBIndex::multiEntry):
* storage/IDBIndex.idl:
* storage/IDBIndexBackendImpl.cpp:
(WebCore::IDBIndexBackendImpl::IDBIndexBackendImpl):
* storage/IDBIndexBackendImpl.h:
(WebCore::IDBIndexBackendImpl::create):
(WebCore::IDBIndexBackendImpl::multiEntry):
* storage/IDBIndexBackendInterface.h:
* storage/IDBLevelDBBackingStore.cpp:
(WebCore::IDBLevelDBBackingStore::getIndexes):
(WebCore::IDBLevelDBBackingStore::createIndex):
* storage/IDBLevelDBCoding.cpp:
* storage/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::createIndex):
* storage/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::putInternal):
(WebCore::IDBObjectStoreBackendImpl::createIndex):
(WebCore::IDBObjectStoreBackendImpl::createIndexInternal):
(WebCore::IDBObjectStoreBackendImpl::loadIndexes):
* storage/IDBObjectStoreBackendImpl.h:
* storage/IDBObjectStoreBackendInterface.h:

Source/WebKit/chromium:

* public/WebIDBIndex.h:
(WebKit::WebIDBIndex::multiEntry):
* public/WebIDBObjectStore.h:
(WebKit::WebIDBObjectStore::createIndex):
* src/IDBIndexBackendProxy.cpp:
(WebKit::IDBIndexBackendProxy::multiEntry):
* src/IDBIndexBackendProxy.h:
* src/IDBObjectStoreBackendProxy.cpp:
(WebKit::IDBObjectStoreBackendProxy::createIndex):
* src/IDBObjectStoreBackendProxy.h:
* src/WebIDBIndexImpl.cpp:
(WebKit::WebIDBIndexImpl::multiEntry):
* src/WebIDBIndexImpl.h:
* src/WebIDBObjectStoreImpl.cpp:
(WebKit::WebIDBObjectStoreImpl::createIndex):
* src/WebIDBObjectStoreImpl.h:

LayoutTests:

* storage/indexeddb/index-basics-expected.txt:
* storage/indexeddb/index-basics.html:
* storage/indexeddb/index-multientry-expected.txt:
* storage/indexeddb/index-multientry.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix. Use internal pcre on glib, make gnutls a dependency of
kov@webkit.org [Fri, 2 Dec 2011 18:30:58 +0000 (18:30 +0000)]
Build fix. Use internal pcre on glib, make gnutls a dependency of
glib-networking, unset AR_FLAGS for jhbuild builds, and run jhbuild
in non-interactive mode.

* Scripts/update-webkitgtk-libs:
* gtk/jhbuild.modules:
* gtk/run-with-jhbuild:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix for Python 2.6
aroben@apple.com [Fri, 2 Dec 2011 18:26:31 +0000 (18:26 +0000)]
Fix for Python 2.6

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(RunUnitTests.countFailures): Removed the flags parameter to re.split, which was only added
in Python 2.7, and used whitespace instead of start-of-string/end-of-string markers when
searching for "Tests that timed out:" etc. This makes our check less strict, but it
shouldn't matter given the kinds of content we parse.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix names of failed/timed out tests in run-api-tests output
aroben@apple.com [Fri, 2 Dec 2011 18:19:40 +0000 (18:19 +0000)]
Fix names of failed/timed out tests in run-api-tests output

Fixes <http://webkit.org/b/73663> run-api-tests prints suite names twice for failed or timed
out tests

We were ending up with the suite name doubled (e.g., "WebKit2.WebKit2.MouseMoveAfterCrash").

Reviewed by Simon Fraser.

* Scripts/run-api-tests:
(runTest): Don't prepend the suite name to $test. It's already been prepended at the start
of this function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] generate-gtkdoc should respect build type
mrobinson@webkit.org [Fri, 2 Dec 2011 18:17:17 +0000 (18:17 +0000)]
[GTK] generate-gtkdoc should respect build type
https://bugs.webkit.org/show_bug.cgi?id=73296

Reviewed by Philippe Normand.

* Scripts/webkitdirs.pm:
(buildAutotoolsProject): Pass the --debug to the generate-gtkdoc script.
* gtk/common.py: If --build is passed give preference to the Debug build directory.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[nrwt] fix wdiff output
tony@chromium.org [Fri, 2 Dec 2011 18:11:45 +0000 (18:11 +0000)]
[nrwt] fix wdiff output
https://bugs.webkit.org/show_bug.cgi?id=73604

Reviewed by Adam Barth.

* Scripts/webkitpy/layout_tests/port/base.py:
(Port.wdiff_text):
* Scripts/webkitpy/layout_tests/port/base_unittest.py:
(PortTest.test_wdiff_text):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTeach build.webkit.org to display how many unit tests failed or timed out
aroben@apple.com [Fri, 2 Dec 2011 18:01:31 +0000 (18:01 +0000)]
Teach build.webkit.org to display how many unit tests failed or timed out

Fixes <http://webkit.org/b/73659> It's hard to tell how many unit tests are failing on
build.webkit.org

We now display something like "5 unit tests failed or timed out". Eventually we might want
to split out how many failure vs. timeouts there were.

Reviewed by Darin Adler.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(TestWithFailureCount): Moved this class up to the top of the file so it is before any other
classes that may want to subclass it.
(RunUnitTests): Changed to inherit from TestWithFailureCount.
(RunUnitTests.countFailures): Added. Counts the number of tests following the "Tests that
timed out:" and "Tests that failed:" lines, if present.

* BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
(StubStdio):
(StubRemoteCommand):
Added these two stub classes to mimic buildbot's RemoteCommand and log classes.

(RunUnitTestsTest.assertFailures): Helper method to check that we interpreted the results of
the test run correctly.

(RunUnitTestsTest.test_no_failures_or_timeouts):
(RunUnitTestsTest.test_one_failure):
(RunUnitTestsTest.test_multiple_failures):
(RunUnitTestsTest.test_one_timeout):
(RunUnitTestsTest.test_multiple_timeouts):
(RunUnitTestsTest.test_multiple_failures_and_timeouts):
Test various cases.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTeach prepare-ChangeLog to treat master.cfg as a Python file
aroben@apple.com [Fri, 2 Dec 2011 18:00:43 +0000 (18:00 +0000)]
Teach prepare-ChangeLog to treat cfg as a Python file

Fixes <http://webkit.org/b/73658> prepare-ChangeLog doesn't show modified classes/functions
in buildbot's master.cfg

Reviewed by Darin Adler.

* Scripts/prepare-ChangeLog:
(get_function_line_ranges): Use get_function_line_ranges_for_python if the filename is
master.cfg.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r101805.
darin@apple.com [Fri, 2 Dec 2011 17:49:02 +0000 (17:49 +0000)]
Unreviewed, rolling out r101805.
http://trac.webkit.org/changeset/101805
https://bugs.webkit.org/show_bug.cgi?id=73670

Many canvas tests started failing due to the isEmpty change
(Requested by darin on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-02

Source/WebCore:

* platform/graphics/cg/PathCG.cpp:
(WebCore::Path::boundingRect):
(WebCore::Path::fastBoundingRect):
(WebCore::Path::isEmpty):

LayoutTests:

* platform/chromium-mac/svg/custom/path-moveto-only-rendering-expected.png: Removed.
* platform/chromium-mac/svg/custom/path-moveto-only-rendering-expected.txt: Removed.
* platform/chromium-mac/svg/custom/subpaths-moveto-only-rendering-expected.png: Removed.
* platform/chromium-mac/svg/custom/subpaths-moveto-only-rendering-expected.txt: Removed.
* platform/chromium-mac/svg/custom/zero-path-square-cap-rendering2-expected.txt: Copied from LayoutTests/svg/custom/zero-path-square-cap-rendering2-expected.txt.
* platform/chromium-win/svg/custom/zero-path-square-cap-rendering2-expected.txt: Copied from LayoutTests/svg/custom/zero-path-square-cap-rendering2-expected.txt.
* platform/chromium/test_expectations.txt:
* platform/mac/svg/custom/path-moveto-only-rendering-expected.png: Removed.
* platform/mac/svg/custom/path-moveto-only-rendering-expected.txt: Removed.
* platform/mac/svg/custom/subpaths-moveto-only-rendering-expected.png: Removed.
* platform/mac/svg/custom/subpaths-moveto-only-rendering-expected.txt: Removed.
* platform/win/svg/custom/path-moveto-only-rendering-expected.png: Removed.
* platform/win/svg/custom/path-moveto-only-rendering-expected.txt: Removed.
* platform/win/svg/custom/subpaths-moveto-only-rendering-expected.png: Removed.
* platform/win/svg/custom/subpaths-moveto-only-rendering-expected.txt: Removed.
* svg/custom/path-moveto-only-rendering.svg: Removed.
* svg/custom/subpaths-moveto-only-rendering.svg: Removed.
* svg/custom/zero-path-square-cap-rendering2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WebKit2][gtk] Add 'enable-dns-prefetching' property to WebKitSettings
commit-queue@webkit.org [Fri, 2 Dec 2011 17:44:27 +0000 (17:44 +0000)]
[WebKit2][gtk] Add 'enable-dns-prefetching' property to WebKitSettings
https://bugs.webkit.org/show_bug.cgi?id=73414

Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-12-02
Reviewed by Martin Robinson.

* UIProcess/API/gtk/WebKitSettings.cpp:
(webKitSettingsSetProperty): Add new set function.
(webKitSettingsGetProperty): Add new get function.
(webkit_settings_class_init): Register new property.
(webkit_settings_get_enable_dns_prefetching): API to get 'enable-dns-prefetching' property.
(webkit_settings_set_enable_dns_prefetching): API to set 'enable-dns-prefetching' property.
* UIProcess/API/gtk/WebKitSettings.h: Expose new public API's.
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new APIs to gtk-doc sections file.
* UIProcess/API/gtk/tests/TestWebKitSettings.cpp:
(testWebKitSettings): Add new tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Create a wrapper script that knows how to install jhbuild and run commands...
mrobinson@webkit.org [Fri, 2 Dec 2011 17:44:05 +0000 (17:44 +0000)]
[GTK] Create a wrapper script that knows how to install jhbuild and run commands with it
https://bugs.webkit.org/show_bug.cgi?id=73669

Reviewed by Gustavo Noronha Silva.

Add a wrapper script that knows how to install jhbuild and also to wrap commands
in the jhbuild shell.

* Scripts/webkitdirs.pm:
(runAutogenForAutotoolsProject): Use the new wrapper script.
(mustReRunAutogen): Ditto.
(buildAutotoolsProject): Ditto.
* Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkDriver.cmd_line): Ditto.
* gtk/run-with-jhbuild: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Mac] Reference count threading violation in FormDataStreamMac.mm
darin@apple.com [Fri, 2 Dec 2011 17:42:54 +0000 (17:42 +0000)]
[Mac] Reference count threading violation in FormDataStreamMac.mm
https://bugs.webkit.org/show_bug.cgi?id=73627

Reviewed by Sam Weinig.

Shows up as a crash during existing layout test runs so no new tests are required.

* platform/network/mac/FormDataStreamMac.mm:
(WebCore::streamFieldsMap): Replaced getStreamFormDataMap with this.
Use an NSMapTable instead of a HashMap because we need to remove items from this
on a non-main thread.
(WebCore::associateStreamWithResourceHandle): Use NSMapGet instead of
HashMap::contains here.
(WebCore::formCreate): FormStreamFields now stores a RefPtr to the form data.
Added the code to fill that in. Did it in a more modern way to avoid the leakRef
and adoptRef that were used before. Replaced the code that set up the stream
form data map entry with code that sets an entry in the streamFieldsMap.
(WebCore::formFinishFinalizationOnMainThread): Added. Contains the work of
finalization that must be done on the main thread, specifically, destroying the
fields structure that contains objects with RefPtr in them. We can't touch these
reference counts on non-main threads.
(WebCore::formFinalize): Changed this to use NSMapRemove on the streamFieldsMap.
Added a callOnMainThread to finish the finalization.
(WebCore::setHTTPBody): Removed the leakRef, no longer needed, that used to be
balanced by an adoptRef in formCreate.
(WebCore::httpBodyFromStream): Changed to use NSMapGet.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=73520
antti@apple.com [Fri, 2 Dec 2011 17:42:04 +0000 (17:42 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=73520
REGRESSION(r101524): Article titles invisible until hover on blaze.com

Source/WebCore:

Reviewed by Darin Adler.

We need to invalidate the matched declaration cache when new web fonts are loaded.
Fonts in the cached RenderStyles may not be valid anymore.

Also renamed m_matchStyleDeclarationCache -> m_matchedStyleDeclarationCache.

Test reduction by the Reduction Fairy (aka kling).

Test: fast/css/font-face-cache-bug.html

* css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::dispatchInvalidationCallbacks):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::findFromMatchedDeclarationCache):
(WebCore::CSSStyleSelector::addToMatchedDeclarationCache):
(WebCore::CSSStyleSelector::invalidateMatchedDeclarationCache):
* css/CSSStyleSelector.h:

LayoutTests:

Reviewed by Darin Adler.

Test reduction by the Reduction Fairy (aka kling).

* fast/css/font-face-cache-bug-expected.txt: Added.
* fast/css/font-face-cache-bug.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Add glib, glib-networking, gnutls and libsoup to jhbuild
kov@webkit.org [Fri, 2 Dec 2011 17:41:04 +0000 (17:41 +0000)]
[GTK] Add glib, glib-networking, gnutls and libsoup to jhbuild
https://bugs.webkit.org/show_bug.cgi?id=73664

Reviewed by Martin Robinson.

This patch adds our HTTP library and its main dependencies; this
should not affect layout or rendering.

* gtk/jhbuild.modules:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMediaControls should use MediaController if present.
jer.noble@apple.com [Fri, 2 Dec 2011 17:35:54 +0000 (17:35 +0000)]
MediaControls should use MediaController if present.
https://bugs.webkit.org/show_bug.cgi?id=71410

Reviewed by Eric Carlson.

No new tests; covered by existing tests.

Add support for individual media controls to control the MediaController of their associated
HTMLMediaElement, if present.

The video spec requires that UA provided media controls be implemented in terms of their
HTMLMediaElement's MediaController, if present.  So for each of the media controls, modify
their constructor to take a Document* instead of an HTMLMediaElement, and add an setter
taking a MediaControllerInterface.

Now that MediaControls have an abstract interface instead of an HTMLMediaElement, use toParentMediaElement
to find the controllingVideoElement.
* accessibility/AccessibilityMediaControls.cpp:
(WebCore::AccessibilityMediaControlsContainer::controllingVideoElement):

Pass the MediaController or the HTMLMediaElement when setting up the elements controls.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::createMediaControls):
(WebCore::HTMLMediaElement::setMediaController):

The following functions have only constructor changes:
* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlElement::MediaControlElement):
(WebCore::MediaControlPanelElement::MediaControlPanelElement):
(WebCore::MediaControlPanelElement::create):
(WebCore::MediaControlTimelineContainerElement::MediaControlTimelineContainerElement):
(WebCore::MediaControlTimelineContainerElement::create):
(WebCore::MediaControlVolumeSliderContainerElement::MediaControlVolumeSliderContainerElement):
(WebCore::MediaControlVolumeSliderContainerElement::create):
(WebCore::MediaControlStatusDisplayElement::MediaControlStatusDisplayElement):
(WebCore::MediaControlStatusDisplayElement::create):
(WebCore::MediaControlInputElement::MediaControlInputElement):
(WebCore::MediaControlMuteButtonElement::MediaControlMuteButtonElement):
(WebCore::MediaControlMuteButtonElement::defaultEventHandler):
(WebCore::MediaControlPanelMuteButtonElement::MediaControlPanelMuteButtonElement):
(WebCore::MediaControlPanelMuteButtonElement::create):
(WebCore::MediaControlVolumeSliderMuteButtonElement::MediaControlVolumeSliderMuteButtonElement):
(WebCore::MediaControlVolumeSliderMuteButtonElement::create):
(WebCore::MediaControlPlayButtonElement::MediaControlPlayButtonElement):
(WebCore::MediaControlPlayButtonElement::create):
(WebCore::MediaControlSeekButtonElement::MediaControlSeekButtonElement):
(WebCore::MediaControlSeekForwardButtonElement::MediaControlSeekForwardButtonElement):
(WebCore::MediaControlSeekForwardButtonElement::create):
(WebCore::MediaControlSeekBackButtonElement::MediaControlSeekBackButtonElement):
(WebCore::MediaControlSeekBackButtonElement::create):
(WebCore::MediaControlRewindButtonElement::MediaControlRewindButtonElement):
(WebCore::MediaControlRewindButtonElement::create):
(WebCore::MediaControlReturnToRealtimeButtonElement::MediaControlReturnToRealtimeButtonElement):
(WebCore::MediaControlReturnToRealtimeButtonElement::create):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::MediaControlToggleClosedCaptionsButtonElement):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::create):
(WebCore::MediaControlTimelineElement::MediaControlTimelineElement):
(WebCore::MediaControlTimelineElement::create):
(WebCore::MediaControlVolumeSliderElement::MediaControlVolumeSliderElement):
(WebCore::MediaControlVolumeSliderElement::create):
(WebCore::MediaControlVolumeSliderElement::defaultEventHandler):
(WebCore::MediaControlFullscreenVolumeSliderElement::MediaControlFullscreenVolumeSliderElement):
(WebCore::MediaControlFullscreenVolumeSliderElement::create):
(WebCore::MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement):
(WebCore::MediaControlFullscreenButtonElement::create):
(WebCore::MediaControlFullscreenVolumeMinButtonElement::MediaControlFullscreenVolumeMinButtonElement):
(WebCore::MediaControlFullscreenVolumeMinButtonElement::create):
(WebCore::MediaControlFullscreenVolumeMaxButtonElement::MediaControlFullscreenVolumeMaxButtonElement):
(WebCore::MediaControlFullscreenVolumeMaxButtonElement::create):
(WebCore::MediaControlTimeDisplayElement::MediaControlTimeDisplayElement):
(WebCore::MediaControlTimeRemainingDisplayElement::create):
(WebCore::MediaControlTimeRemainingDisplayElement::MediaControlTimeRemainingDisplayElement):
(WebCore::MediaControlCurrentTimeDisplayElement::create):
(WebCore::MediaControlCurrentTimeDisplayElement::MediaControlCurrentTimeDisplayElement):
* html/shadow/MediaControlRootElement.cpp:
(WebCore::MediaControlRootElement::MediaControlRootElement):
(WebCore::MediaControls::create):
(WebCore::MediaControlRootElement::create):
* html/shadow/MediaControlRootElement.h:
* html/shadow/MediaControls.cpp:
(WebCore::MediaControls::MediaControls):
* html/shadow/MediaControls.h:

The following functions now call MediaControllerInterface instead of HTMLMediaElement directly:
* html/shadow/MediaControlElements.h:
(WebCore::MediaControlStatusDisplayElement::update):
(WebCore::MediaControlMuteButtonElement::updateDisplayType):
(WebCore::MediaControlPlayButtonElement::defaultEventHandler):
(WebCore::MediaControlPlayButtonElement::updateDisplayType):
(WebCore::MediaControlSeekButtonElement::startTimer):
(WebCore::MediaControlSeekButtonElement::stopTimer):
(WebCore::MediaControlSeekButtonElement::nextRate):
(WebCore::MediaControlSeekButtonElement::seekTimerFired):
(WebCore::MediaControlRewindButtonElement::defaultEventHandler):
(WebCore::MediaControlReturnToRealtimeButtonElement::defaultEventHandler):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::defaultEventHandler):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::updateDisplayType):
(WebCore::MediaControlTimelineElement::defaultEventHandler):
(WebCore::MediaControlFullscreenButtonElement::defaultEventHandler):
(WebCore::MediaControlFullscreenVolumeMinButtonElement::defaultEventHandler):
(WebCore::MediaControlFullscreenVolumeMaxButtonElement::defaultEventHandler):
* html/shadow/MediaControlRootElement.cpp:
(WebCore::MediaControlRootElement::reset):
(WebCore::MediaControlRootElement::playbackStarted):
(WebCore::MediaControlRootElement::playbackProgressed):
(WebCore::MediaControlRootElement::playbackStopped):
(WebCore::MediaControlRootElement::updateTimeDisplay):
(WebCore::MediaControlRootElement::loadedMetadata):
(WebCore::MediaControlRootElement::changedVolume):
(WebCore::MediaControlRootElement::enteredFullscreen):
(WebCore::MediaControlRootElement::showVolumeSlider):
(WebCore::MediaControlRootElement::defaultEventHandler):
(WebCore::MediaControlRootElement::startHideFullscreenControlsTimer):
(WebCore::MediaControlRootElement::hideFullscreenControlsTimerFired):
* html/shadow/MediaControlRootElementChromium.cpp:
(WebCore::MediaControlRootElementChromium::MediaControlRootElementChromium):
(WebCore::MediaControls::create):
(WebCore::MediaControlRootElementChromium::create):
(WebCore::MediaControlRootElementChromium::reset):
(WebCore::MediaControlRootElementChromium::playbackStarted):
(WebCore::MediaControlRootElementChromium::playbackProgressed):
(WebCore::MediaControlRootElementChromium::playbackStopped):
(WebCore::MediaControlRootElementChromium::updateTimeDisplay):
(WebCore::MediaControlRootElementChromium::defaultEventHandler):
(WebCore::MediaControlRootElementChromium::changedVolume):
(WebCore::MediaControlRootElementChromium::showVolumeSlider):
* html/shadow/MediaControlRootElementChromium.h:

The following functions set the current MediaControllerInterface.
* html/shadow/MediaControlRootElement.cpp:
(WebCore::MediaControlRootElement::setMediaController):
* html/shadow/MediaControlElements.h:
(WebCore::MediaControlElement::setMediaController):
(WebCore::MediaControlElement::mediaController):
(WebCore::MediaControlInputElement::setMediaController):
(WebCore::MediaControlInputElement::mediaController):
* html/shadow/MediaControlRootElementChromium.cpp:
(WebCore::MediaControlRootElementChromium::setMediaController):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r101801.
commit-queue@webkit.org [Fri, 2 Dec 2011 17:07:26 +0000 (17:07 +0000)]
Unreviewed, rolling out r101801.
http://trac.webkit.org/changeset/101801
https://bugs.webkit.org/show_bug.cgi?id=73667

Build is still broken (Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-02

* assembler/SH4Assembler.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoChanges to localStorageDatabasePath don't have any effect on Windows
sfalken@apple.com [Fri, 2 Dec 2011 17:04:45 +0000 (17:04 +0000)]
Changes to localStorageDatabasePath don't have any effect on Windows
https://bugs.webkit.org/show_bug.cgi?id=73606
<rdar://problem/10491296>

Reviewed by Darin Adler.

* WebView.cpp:
(WebView::notifyPreferencesChanged): Propagate local storage path change to m_page's settings.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, skip failing websocket test on GTK.
philn@webkit.org [Fri, 2 Dec 2011 17:01:34 +0000 (17:01 +0000)]
Unreviewed, skip failing websocket test on GTK.

* platform/gtk/Skipped: Skip http/tests/websocket/tests/hybi/bufferedAmount-after-close-in-busy.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPrepare to deploy pass and peek types in the HashMap class
darin@apple.com [Fri, 2 Dec 2011 16:50:32 +0000 (16:50 +0000)]
Prepare to deploy pass and peek types in the HashMap class
https://bugs.webkit.org/show_bug.cgi?id=73477

Reviewed by Adam Roben.

This patch adds private typedefs inside the HashMap class,
and uses them as appropriate. A future patch will actually
tie those typedefs to hash traits, which will allow us to
make HashMap work with OwnPtr mapped values and to optimize
how HashMap works with RefPtr mapped values.

Also changed the hash translator and adapter struct templates
to use template functions to simplify them and make them more
flexible.

Also removed some unused template arguments.

This goes out of its way to not change behavior. Future patches
will change the peek type to be a reference type, which will
reduce reference count churn a bit for hash tables with RefPtr
mapped values, and then do further optimizations for RefPtr
and OwnPtr by getting types from the hash traits.

* wtf/HashMap.h: Added MappedPassInType, MappedPassOutType,
and MappedPeekType typedefs, and used them for the arguments
and return types of the get, set, add, take, and inlineAdd
functions.
(WTF::HashMapTranslator): Changed this struct template to take
fewer arguments, and changed its member functions to be
function templates instead. This allows the compiler to
determine types more flexibly and also simplifies use of it.
(WTF::HashMapTranslatorAdapter): Ditto.
(WTF::HashMap::find): Updated to use new HashMapTranslatorAdapter.
Also reduced the arguments passed to the HashTable function template.
(WTF::HashMap::contains): Ditto.
(WTF::HashMap::inlineAdd): Ditto. Also take MappedPassInType.
(WTF::HashMap::set): Ditto.
(WTF::HashMap::add): Ditto.
(WTF::HashMap::inlineGet): Ditto, but return MappedPeekType.
(WTF::HashMap::get): Ditto.
(WTF::HashMap::take): Ditto, but return MappedPassOutType and use
that type in the implementation.
(WTF::deleteAllValues): Removed unneeded template arguments from
call to deleteAllPairSeconds.
(WTF::deleteAllKeys): Removed unneeded template arguments from
call to deleteAllPairFirsts.

* wtf/HashSet.h:
(WTF::IdentityExtractor): Changed this to be a struct rather than
a struct template, and replaced the extract function with a function
template. This allows the compiler to deduce the type.
(WTF::HashSetTranslatorAdapter): Changed this struct template to take
fewer arguments, and changed its member functions to be
function templates instead. This allows the compiler to
determine types more flexibly and also simplifies use of it.
(WTF::HashSet::find): Updated to use new HashSetTranslatorAdapter.
Also reduced the arguments passed to the HashTable function template.
(WTF::HashSet::contains): Ditto.
(WTF::HashSet::add): Ditto.

* wtf/HashTable.h:
(WTF::IdentityHashTranslator): Changed this struct template to take
fewer arguments, and changed its member functions to be
function templates instead. This allows the compiler to
determine types more flexibly and also simplifies use of it.
(WTF::HashTable::add): Reduced arguments passed to the function template.
(WTF::HashTable::find): Ditto, also reversed the template arguments so the
translator comes first so the compiler can deduce the other type.
(WTF::HashTable::contains): Ditto.
(WTF::HashTable::lookup): Ditto.
(WTF::HashTable::lookupForWriting): Ditto.
(WTF::HashTable::checkKey): Ditto.
(WTF::HashTable::fullLookupForWriting): Ditto.
(WTF::HashTable::add): Ditto.
(WTF::HashTable::addPassingHashCode): Ditto.
(WTF::HashTable::find): Ditto.
(WTF::HashTable::contains): Ditto.

* wtf/ListHashSet.h:
(WTF::ListHashSetNodeHashFunctions): Changed this struct template to take
fewer arguments, and changed its member functions to be function templates
instead. This allows the compiler to determine types more flexibly and
also simplifies use of it.
(WTF::ListHashSet::find): Reduced the arguments passed to the HashTable
functon template.
(WTF::ListHashSetTranslatorAdapter): Changed this struct template in the
same way we changed ListHashSetNodeHashFunctions above.
(WTF::ListHashSetTranslatorAdapter::equal):
(WTF::::contains):
(WTF::::add):
(WTF::::insertBefore):

* wtf/RefPtrHashMap.h: Updated comments. Removed the
RefPtrHashMapRawKeyTranslator struct template; we can use the
HashMapTranslator struct template from HashMap.h instead now that
it is more flexible. Added MappedPassInType, MappedPassOutType,
and MappedPeekType typedefs, and used them for the arguments
and return types of the get, inlineGet, set, add, take, and inlineAdd
functions. Changed the name of the RawKeyTranslator type to
Translator since it's now a class that can handle both raw keys
and conventional keys.
(WTF::HashMap::find): Changed to use Translator instead of RawKeyTranslator.
Reduced the arguments passed to the HashTable function template.
(WTF::HashMap::contains): Ditto.
(WTF::HashMap::inlineAdd): Ditto. Also take MappedPassInType.
(WTF::HashMap::set): Ditto.
(WTF::HashMap::add): Ditto.
(WTF::HashMap::inlineGet): Ditto, but return MappedPeekType.
(WTF::HashMap::get): Ditto.
(WTF::HashMap::take): Ditto, but return MappedPassOutType and use
that type in the implementation.
(WTF::deleteAllValues): Removed unneeded template arguments from
call to deleteAllPairSeconds.
(WTF::deleteAllKeys): Removed unneeded template arguments from
call to deleteAllPairFirsts.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION (r91125): Polyline tool in google docs is broken
commit-queue@webkit.org [Fri, 2 Dec 2011 16:37:36 +0000 (16:37 +0000)]
REGRESSION (r91125): Polyline tool in google docs is broken
https://bugs.webkit.org/show_bug.cgi?id=65796

Source/WebCore:

Patch by Stephen Chenney <schenney@chromium.org> on 2011-12-02
Reviewed by Darin Adler.

Work around a bug in CoreGraphics, that caused incorrect bounds for paths
consisting only of move-to elements. This causes problems in SVG, when the enormous
bounds prevented the drawing of things behind.

Tests: svg/custom/path-moveto-only-rendering.svg
       svg/custom/subpaths-moveto-only-rendering.svg

* platform/graphics/cg/PathCG.cpp:
(WebCore::PathIsEmptyOrSingleMoveTester::PathIsEmptyOrSingleMoveTester): Class to
test for isEmpty accoridng ot the same rules as other platforms.
(WebCore::PathIsEmptyOrSingleMoveTester::isEmpty): Query the result
(WebCore::PathIsEmptyOrSingleMoveTester::testPathElement): Path iterator method
(WebCore::PathHasOnlyMoveToTester::PathHasOnlyMoveToTester): Class to test whether a
path contains only move-to elements, and hence should have null bounds.
(WebCore::PathHasOnlyMoveToTester::hasOnlyMoveTo): Query the result
(WebCore::PathHasOnlyMoveToTester::testPathElement): Path iterator method.
(WebCore::Path::boundingRect): Modified to check for move-to only paths
(WebCore::Path::fastBoundingRect): Modified to check for move-to only paths
(WebCore::Path::isEmpty): Now uses the method that matches other platforms.

LayoutTests:

Work around a bug in CoreGraphics, that caused incorrect bounds for paths
consisting only of move-to elements. This causes problems in SVG, when the enormous
bounds prevented the drawing of things behind.

Will revert expectation file when expectations are stable.

Patch by Stephen Chenney <schenney@chromium.org> on 2011-12-02
Reviewed by Darin Adler.

* platform/chromium-mac/svg/custom/zero-path-square-cap-rendering2-expected.txt: Removed.
* platform/chromium-win/svg/custom/zero-path-square-cap-rendering2-expected.txt: Removed.
* platform/mac/svg/custom/path-moveto-only-rendering-expected.png: Added.
* platform/mac/svg/custom/path-moveto-only-rendering-expected.txt: Added.
* platform/mac/svg/custom/subpaths-moveto-only-rendering-expected.png: Added.
* platform/mac/svg/custom/subpaths-moveto-only-rendering-expected.txt: Added.
* platform/win/svg/custom/path-moveto-only-rendering-expected.png: Added.
* platform/win/svg/custom/path-moveto-only-rendering-expected.txt: Added.
* platform/win/svg/custom/subpaths-moveto-only-rendering-expected.png: Added.
* platform/win/svg/custom/subpaths-moveto-only-rendering-expected.txt: Added.
* svg/custom/path-moveto-only-rendering.svg: Added.
* svg/custom/subpaths-moveto-only-rendering.svg: Added.
* svg/custom/zero-path-square-cap-rendering2-expected.txt: Modified text output
* platform/chromium/test_expectations.txt: Added flakiness for new tests from this patch

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Set event timestamps on custom input events
abecsi@webkit.org [Fri, 2 Dec 2011 16:36:36 +0000 (16:36 +0000)]
[Qt][WK2] Set event timestamps on custom input events

Reviewed by Simon Hausmann.

Since r101791 WebEventFactoryQt uses input event timestamps for WebEvents,
thus set the timestamp on the custom events as well.

* UIProcess/qt/QtWebPageEventHandler.cpp:
(QtWebPageEventHandler::handleHoverLeaveEvent):
(QtWebPageEventHandler::handleHoverMoveEvent):
* UIProcess/qt/WebPopupMenuProxyQtDesktop.cpp:
(WebKit::WebPopupMenuProxyQtDesktop::showPopupMenu):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTeach check-webkit-style how to check the syntax of JSON files
aroben@apple.com [Fri, 2 Dec 2011 16:33:56 +0000 (16:33 +0000)]
Teach check-webkit-style how to check the syntax of JSON files

Fixes <http://webkit.org/b/73590> check-webkit-style doesn't flag JSON syntax errors

I previously landed this patch as r101711, but the new tests failed on Snow Leopard. This
patch is identical to that one except for two change: assertIn(a, b) (which is new to Python
2.7) has been replaced with assertTrue(a in b), and the test_missing_closing_brace test has
been removed, since its output differs by platform.

Reviewed by Darin Adler.

* Scripts/webkitpy/style/checker.py:
(_all_categories): Added JSONChecker's categories to the set of all categories.
(FileType): Added a JSON type. Incremented other types.
(CheckerDispatcher._file_type): Use the JSON file type for .json files.
(CheckerDispatcher._create_checker): Use a JSONChecker for JSON files.

* Scripts/webkitpy/style/checker_unittest.py:
(CheckerDispatcherDispatchTest.assert_checker_json): Added this helper method.
(CheckerDispatcherDispatchTest.test_json_paths): Added. Based on test_python_paths.

* Scripts/webkitpy/style/checkers/jsonchecker.py: Added. (I didn't name this just "json",
which would have matched our other checkers, because I couldn't figure out how to call
"json.loads" without hitting namespace conflicts.)
(JSONChecker.__init__): Turn of line filtering so that we always check the whole file, not
just the modified lines from a patch.
(JSONChecker.check): Try to parse the lines as JSON. Mark an error if there was an
exception.
(JSONChecker.line_number_from_json_exception): Parse the json modules exception message to
try to extract a line number.

* Scripts/webkitpy/style/checkers/jsonchecker_unittest.py: Added.
(MockErrorHandler.__init__):
(MockErrorHandler.turn_off_line_filtering):
(MockErrorHandler.__call__):
Helper class. Copied from xml_unittest.py.

(JSONCheckerTest.test_line_number_from_json_exception): Test the
line_number_from_json_exception helper method.

(JSONCheckerTest.assert_no_error):
(JSONCheckerTest.assert_error):
Helper methods to assert that we did or didn't get an error.

(JSONCheckerTest.mock_handle_style_error): Helper method.

(JSONCheckerTest.test_conflict_marker):
(JSONCheckerTest.test_single_quote):
(JSONCheckerTest.test_init):
(JSONCheckerTest.test_no_error):
Test various cases.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Also run DumpRenderTree under jhbuild
kov@webkit.org [Fri, 2 Dec 2011 16:30:42 +0000 (16:30 +0000)]
[GTK] Also run DumpRenderTree under jhbuild
https://bugs.webkit.org/show_bug.cgi?id=73646

Reviewed by Martin Robinson.

* Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkDriver.cmd_line):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMacroAssemblerSH4 does not implement readCallTarget
ossy@webkit.org [Fri, 2 Dec 2011 16:30:31 +0000 (16:30 +0000)]
MacroAssemblerSH4 does not implement readCallTarget
https://bugs.webkit.org/show_bug.cgi?id=73434

Patch by Zoltan Herczeg <zherczeg@webkit.org> on 2011-12-02
Reviewed by Csaba Osztrogonác.

* assembler/SH4Assembler.h:
(JSC::SH4Assembler::readCallTarget): Support for SH4.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] fast/forms/select/listbox-in-multi-column.html fails
ossy@webkit.org [Fri, 2 Dec 2011 16:17:11 +0000 (16:17 +0000)]
[Qt] fast/forms/select/listbox-in-multi-column.html fails
https://bugs.webkit.org/show_bug.cgi?id=73660

* platform/qt/Skipped: Skip fast/forms/select/listbox-in-multi-column.html until fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-12-02 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Fri, 2 Dec 2011 16:16:07 +0000 (16:16 +0000)]
2011-12-02  Alejandro G. Castro  <alex@igalia.com>

        [GTK] Fix TextureMapperCairo compilation
        https://bugs.webkit.org/show_bug.cgi?id=73655

        Reviewed by Martin Robinson.

        * GNUmakefile.am: The variables need the USE part in the name.
        * configure.ac: We can not define the variable twice.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Unreviewed expectation fix after r101787.
apavlov@chromium.org [Fri, 2 Dec 2011 16:14:29 +0000 (16:14 +0000)]
[Chromium] Unreviewed expectation fix after r101787.

* platform/chromium/svg/css/getComputedStyle-basic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r101794.
vsevik@chromium.org [Fri, 2 Dec 2011 15:51:38 +0000 (15:51 +0000)]
Unreviewed, rolling out r101794.
http://trac.webkit.org/changeset/101794
https://bugs.webkit.org/show_bug.cgi?id=73656

Broke win build (Requested by vsevik on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-02

* bindings/js/ScriptCallStackFactory.cpp:
* bindings/js/ScriptCallStackFactory.h:
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateParametersCheck):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateFunctionCallback):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionCustomArgsAndException):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::customArgsAndExceptionCallback):
* bindings/v8/ScriptCallStackFactory.cpp:
* bindings/v8/ScriptCallStackFactory.h:
* inspector/InspectorInstrumentation.cpp:
* inspector/InspectorInstrumentation.h:
* inspector/WorkerInspectorController.h:
* page/Console.cpp:
(WebCore::Console::shouldCaptureFullStackTrace):
* page/Console.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, revert r101347.
commit-queue@webkit.org [Fri, 2 Dec 2011 15:32:05 +0000 (15:32 +0000)]
Unreviewed, revert r101347.
https://bugs.webkit.org/show_bug.cgi?id=73580

It breaks the linking of Tools/ targets due to missing functions.

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-12-02

.:

* Source/cmake/OptionsEfl.cmake:

Source/WebCore:

* PlatformEfl.cmake:
* platform/graphics/GraphicsLayer.cpp:
* platform/graphics/GraphicsLayer.h:
* platform/graphics/efl/GraphicsLayerEfl.cpp: Added.
(WebCore::GraphicsLayer::create):
(WebCore::GraphicsLayerEfl::GraphicsLayerEfl):
(WebCore::GraphicsLayerEfl::~GraphicsLayerEfl):
(WebCore::GraphicsLayerEfl::setNeedsDisplay):
(WebCore::GraphicsLayerEfl::setNeedsDisplayInRect):
* platform/graphics/efl/GraphicsLayerEfl.h: Added.
* platform/graphics/texmap/TextureMapperNode.cpp:
(WebCore::solveCubicBezierFunction):
(WebCore::solveStepsFunction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, updated chromium test expectations.
vsevik@chromium.org [Fri, 2 Dec 2011 15:27:57 +0000 (15:27 +0000)]
Unreviewed, updated chromium test expectations.

* platform/chromium/fast/events/offsetX-offsetY-expected.txt: Renamed from LayoutTests/platform/chromium-mac/fast/events/offsetX-offsetY-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Extract default call stack creation and check for front-end from console.
vsevik@chromium.org [Fri, 2 Dec 2011 15:24:04 +0000 (15:24 +0000)]
Web Inspector: Extract default call stack creation and check for front-end from console.
https://bugs.webkit.org/show_bug.cgi?id=73566

Reviewed by Yury Semikhatsky.

* bindings/js/ScriptCallStackFactory.cpp:
(WebCore::createScriptCallStack):
* bindings/js/ScriptCallStackFactory.h:
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateParametersCheck):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateFunctionCallback):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionCustomArgsAndException):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::customArgsAndExceptionCallback):
* bindings/v8/ScriptCallStackFactory.cpp:
(WebCore::createScriptCallStack):
* bindings/v8/ScriptCallStackFactory.h:
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::hasFrontendForScriptContext):
* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::hasFrontendForScriptContext):
* inspector/WorkerInspectorController.h:
(WebCore::WorkerInspectorController::hasFrontend):
* page/Console.cpp:
* page/Console.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, skip some new GTK multicol failures because of bug 73653.
philn@webkit.org [Fri, 2 Dec 2011 15:17:50 +0000 (15:17 +0000)]
Unreviewed, skip some new GTK multicol failures because of bug 73653.

* platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove instrumentation tracking a fixed bug
gavinp@chromium.org [Fri, 2 Dec 2011 15:15:43 +0000 (15:15 +0000)]
Remove instrumentation tracking a fixed bug
https://bugs.webkit.org/show_bug.cgi?id=73471

The underlying bug is fixed (bug 72068), and this instrumentation was intrusive and using
memory, plus the conditional compilation made me sad.

Reviewed by Nate Chapin.

No new tests.

* dom/ScriptElement.cpp:
(WebCore::ScriptElement::ScriptElement):
(WebCore::ScriptElement::requestScript):
(WebCore::ScriptElement::stopLoadRequest):
(WebCore::ScriptElement::notifyFinished):
* dom/ScriptElement.h:
* dom/ScriptRunner.cpp:
(WebCore::ScriptRunner::queueScriptForExecution):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] [WK2] Use input event timestamps in WebEvents if available
abecsi@webkit.org [Fri, 2 Dec 2011 14:45:44 +0000 (14:45 +0000)]
[Qt] [WK2] Use input event timestamps in WebEvents if available
https://bugs.webkit.org/show_bug.cgi?id=73647

Reviewed by Simon Hausmann.

Qt5 input events already have a native timestamp, use this timestamp
in WebEventFactory instead of WTF::currentTime if it is available.

* Shared/qt/WebEventFactoryQt.cpp:
(WebKit::currentTimeForEvent):
(WebKit::WebEventFactory::createWebMouseEvent):
(WebKit::WebEventFactory::createWebWheelEvent):
(WebKit::WebEventFactory::createWebKeyboardEvent):
(WebKit::WebEventFactory::createWebTouchEvent):
* Shared/qt/WebEventFactoryQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Split view works weirdly in network panel when resizing, showing/hidin...
vsevik@chromium.org [Fri, 2 Dec 2011 14:44:42 +0000 (14:44 +0000)]
Web Inspector: Split view works weirdly in network panel when resizing, showing/hiding main element.
https://bugs.webkit.org/show_bug.cgi?id=73650

Reviewed by Pavel Feldman.

* inspector/front-end/SplitView.js:
(WebInspector.SplitView.prototype._updateResizer):
(WebInspector.SplitView.prototype.hideMainElement):
(WebInspector.SplitView.prototype.showMainElement):
(WebInspector.SplitView.prototype.onResize):
(WebInspector.SplitView.prototype._restoreSidebarWidth):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r101783.
vsevik@chromium.org [Fri, 2 Dec 2011 14:15:40 +0000 (14:15 +0000)]
Unreviewed, rolling out r101783.
http://trac.webkit.org/changeset/101783
https://bugs.webkit.org/show_bug.cgi?id=73652

Broke chromium win build. (Requested by vsevik on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-02

* WebCore.gyp/WebCore.gyp:
* WebCore.gyp/scripts/action_derivedsourcesallinone.py:
(main):
* WebCore.gypi:
* bindings/scripts/generate-bindings.pl:
* page/DOMWindow.idl:
* webaudio/DOMWindowWebAudio.idl: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Split the QtWebPageProxy into PageClient and QtPageProxy
jesus@webkit.org [Fri, 2 Dec 2011 13:37:20 +0000 (13:37 +0000)]
[Qt][WK2] Split the QtWebPageProxy into PageClient and QtPageProxy
https://bugs.webkit.org/show_bug.cgi?id=66668

Reviewed by Simon Hausmann.

Split QtPageClient out of QtWebPageProxy.
This client will live in QQuickWebViewPrivate and communicate directly
with QtWebPageProxy and QtWebPageEventHandler. The functions that need
anything else than these entities will need to call the proper implementation
through QtWebPageProxy itself.
With this we have a clear separation between PageClient and PageProxy, having
two well defined and separated entities for hooking our clients with our API layer (QtWebPageProxy)
and for hooking the WebPageProxy with our client implementations (QtPageClient).
As a positive side-effect we have a cleaner QtWebPageProxy.

* Target.pri:
* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::QQuickWebViewPrivate):
* UIProcess/API/qt/qquickwebview_p_p.h:
* UIProcess/qt/QtPageClient.cpp: Added.
(QtPageClient::QtPageClient):
(QtPageClient::~QtPageClient):
(QtPageClient::createDrawingAreaProxy):
(QtPageClient::setViewNeedsDisplay):
(QtPageClient::pageDidRequestScroll):
(QtPageClient::processDidCrash):
(QtPageClient::didRelaunchProcess):
(QtPageClient::didChangeContentsSize):
(QtPageClient::didChangeViewportProperties):
(QtPageClient::startDrag):
(QtPageClient::handleDownloadRequest):
(QtPageClient::setCursor):
(QtPageClient::setCursorHiddenUntilMouseMoves):
(QtPageClient::toolTipChanged):
(QtPageClient::registerEditCommand):
(QtPageClient::clearAllEditCommands):
(QtPageClient::canUndoRedo):
(QtPageClient::executeUndoRedo):
(QtPageClient::convertToDeviceSpace):
(QtPageClient::convertToUserSpace):
(QtPageClient::screenToWindow):
(QtPageClient::windowToScreen):
(QtPageClient::createPopupMenuProxy):
(QtPageClient::createContextMenuProxy):
(QtPageClient::flashBackingStoreUpdates):
(QtPageClient::didFindZoomableArea):
(QtPageClient::didReceiveMessageFromNavigatorQtObject):
(QtPageClient::doneWithTouchEvent):
(QtPageClient::displayView):
(QtPageClient::scrollView):
(QtPageClient::viewSize):
(QtPageClient::isViewWindowActive):
(QtPageClient::isViewFocused):
(QtPageClient::isViewVisible):
(QtPageClient::isViewInWindow):
(QtPageClient::enterAcceleratedCompositingMode):
(QtPageClient::exitAcceleratedCompositingMode):
* UIProcess/qt/QtPageClient.h: Added.
(QtPageClient::pageClosed):
(QtPageClient::doneWithKeyEvent):
(QtPageClient::setFindIndicator):
(QtPageClient::didCommitLoadForMainFrame):
(QtPageClient::didFinishLoadingDataForCustomRepresentation):
(QtPageClient::customRepresentationZoomFactor):
(QtPageClient::setCustomRepresentationZoomFactor):
(QtPageClient::didChangeScrollbarsForMainFrame):
(QtPageClient::findStringInCustomRepresentation):
(QtPageClient::countStringMatchesInCustomRepresentation):
(QtPageClient::setEventHandler):
(QtPageClient::setPageProxy):
* UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::QtWebPageProxy):
* UIProcess/qt/QtWebPageProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoInline non-replaced elements are reported to have zero width and height
apavlov@chromium.org [Fri, 2 Dec 2011 13:32:47 +0000 (13:32 +0000)]
Inline non-replaced elements are reported to have zero width and height
https://bugs.webkit.org/show_bug.cgi?id=61117

Reviewed by Antti Koivisto.

Source/WebCore:

According to http://www.w3.org/TR/CSS21/visudet.html, the "width" and "height" properties
do not apply for inline non-replaced elements and should have their initial value of "auto"
as their computed values.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

LayoutTests:

* fast/dom/beforeload/image-object-before-load-innerHTML.html:
* fast/dom/beforeload/image-object-before-load.html:
* platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
* svg/css/getComputedStyle-basic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Unreviewed, GTK rebaseline.
philn@webkit.org [Fri, 2 Dec 2011 12:58:24 +0000 (12:58 +0000)]
    Unreviewed, GTK rebaseline.

        * platform/gtk/Skipped: plugins/invalidate_rect.html was
        removed. Also skip one more SVG test.
        * platform/gtk/fast/writing-mode/broken-ideograph-small-caps-expected.txt:
        * platform/gtk/fonts/custom-font-missing-glyphs-expected.txt:
        * platform/gtk/fonts/fontconfig-synthetic-bold-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Make CCInputHandler scrolling stateful
commit-queue@webkit.org [Fri, 2 Dec 2011 12:34:42 +0000 (12:34 +0000)]
[chromium] Make CCInputHandler scrolling stateful
https://bugs.webkit.org/show_bug.cgi?id=73345

This change makes the scrolling part of CCInputHandler stateful by
replacing scrollRootLayer() with scrollBegin(), scrollBy() and
scrollEnd(). This is done in preparation for scrollable sublayers.
Specifically, scrollBegin() will allow CCLayerTreeHostImpl to perform
input event hit testing to find the layer to be scrolled.

Patch by Sami Kyostila <skyostil@chromium.org> on 2011-12-02
Reviewed by Steve Block.

Source/WebCore:

Tested in CCLayerTreeHostImplTest.

* platform/graphics/chromium/cc/CCInputHandler.h:
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::currentTimeMs):
(WebCore::CCLayerTreeHostImpl::setNeedsRedraw):
(WebCore::findInnermostScrollableLayerAtPoint):
(WebCore::CCLayerTreeHostImpl::scrollBegin):
(WebCore::CCLayerTreeHostImpl::scrollBy):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

Source/WebKit/chromium:

* src/WebCompositorImpl.cpp:
(WebKit::WebCompositorImpl::handleInputEvent):
* tests/CCLayerTreeHostImplTest.cpp:
(WebKit::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101785 268f45cc-cd09-0410-ab3c-d52691b4dbfc