WebKit-https.git
16 years agoForgot to check in these results earlier today.
justing [Tue, 28 Mar 2006 09:33:36 +0000 (09:33 +0000)]
Forgot to check in these results earlier today.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-03-28 Eric Seidel <eseidel@apple.com>
eseidel [Tue, 28 Mar 2006 09:02:15 +0000 (09:02 +0000)]
2006-03-28  Eric Seidel  <eseidel@apple.com>

        Reviewed by mjs.

        Convert a couple DeprecatedPtrList<T> to Vector<T*> and HashSet<T*>

        * bridge/mac/FrameMac.h:
        * bridge/mac/FrameMac.mm:
        (WebCore::regExpForLabels):
        (WebCore::FrameMac::addPluginRootObject):
        (WebCore::FrameMac::cleanupPluginRootObjects):
        * loader/Cache.cpp:
        (WebCore::Cache::init):
        (WebCore::Cache::clear):
        (WebCore::Cache::remove):
        * loader/Cache.h:
        * loader/DocLoader.cpp:
        (WebCore::DocLoader::DocLoader):
        (WebCore::DocLoader::~DocLoader):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-03-27 Eric Seidel <eseidel@apple.com>
eseidel [Tue, 28 Mar 2006 06:32:09 +0000 (06:32 +0000)]
2006-03-27  Eric Seidel  <eseidel@apple.com>

        Reviewed by mjs.

        Give StringImpl a little privacy.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=8022

        * dom/CharacterData.cpp:
        (WebCore::CharacterData::length):
        (WebCore::CharacterData::appendData):
        (WebCore::CharacterData::replaceData):
        (WebCore::CharacterData::checkCharDataOperation):
        (WebCore::CharacterData::rendererIsNeeded):
        * dom/Range.cpp:
        (WebCore::Range::compareBoundaryPoints):
        * dom/Text.cpp:
        (WebCore::Text::splitText):
        * html/HTMLTokenizer.cpp:
        (WebCore::HTMLTokenizer::processToken):
        * platform/AtomicString.cpp:
        (WebCore::operator==):
        * platform/String.cpp:
        (WebCore::String::operator[]):
        (WebCore::String::length):
        (WebCore::String::percentage):
        (WebCore::String::unicode):
        (WebCore::String::deprecatedString):
        (WebCore::String::isEmpty):
        * platform/StringImpl.cpp:
        (WebCore::equal):
        (WebCore::equalIgnoringCase):
        * platform/StringImpl.h:
        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::selectionRect):
        (WebCore::InlineTextBox::paint):
        (WebCore::InlineTextBox::paintSelection):
        (WebCore::InlineTextBox::paintMarkedTextBackground):
        (WebCore::InlineTextBox::paintTextMatchMarker):
        (WebCore::InlineTextBox::offsetForPosition):
        (WebCore::InlineTextBox::positionForOffset):
        * rendering/RenderText.cpp:
        (WebCore::RenderText::widthFromCache):
        (WebCore::RenderText::calcMinMaxWidth):
        (WebCore::RenderText::width):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
mjs [Tue, 28 Mar 2006 06:30:14 +0000 (06:30 +0000)]
LayoutTests:

        Reviewed by Beth.

        - test cases for <rdar://problem/4279765> REGRESSION: "More..." links on flickr groups pages have hover issues (flickr.com)

        * fast/block/float/float-in-float-hit-testing-expected.checksum: Added.
        * fast/block/float/float-in-float-hit-testing-expected.png: Added.
        * fast/block/float/float-in-float-hit-testing-expected.txt: Added.
        * fast/block/float/float-in-float-hit-testing.html: Added.
        * fast/block/float/float-in-float-painting-expected.checksum: Added.
        * fast/block/float/float-in-float-painting-expected.png: Added.
        * fast/block/float/float-in-float-painting-expected.txt: Added.
        * fast/block/float/float-in-float-painting.html: Added.
        * fast/events/capture-on-target.html:

WebCore:

        Reviewed by Beth.

        - fixed <rdar://problem/4279765> REGRESSION: "More..." links on flickr groups pages have hover issues (flickr.com)

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::floatRect): Rewrote in terms of rects, and made it consider child floatRects
        as well as their overflowRects.
        * platform/IntRect.h:
        (WebCore::unionRect): useful helper
        * platform/FloatRect.h:
        (WebCore::unionRect): added same for FloatRect just because

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Eric.
tomernic [Tue, 28 Mar 2006 04:26:14 +0000 (04:26 +0000)]
    Reviewed by Eric.

        <rdar://problem/3694090> -[WebBaseNetscapePluginView finalize] is incorrect; design change needed

        * ChangeLog:
        * Plugins/WebBaseNetscapePluginView.m:
        (-[WebBaseNetscapePluginView dealloc]):
        Instead of calling -stop, assert that the plugin is not running.  A plugin view cannot be deallocated
        until it is removed from its window.  When a plugin view is removed from its window, it calls -stop
        on itself.  Therefore I believe that this call to -stop is unnecessary; if I'm wrong, then the
        assertion will help catch any edge cases.
        (-[WebBaseNetscapePluginView finalize]):
        ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Eric.
tomernic [Tue, 28 Mar 2006 04:15:07 +0000 (04:15 +0000)]
    Reviewed by Eric.

        <rdar://problem/3694086> -[WebBaseNetscapePluginStream finalize] is incorrect; design change needed

        * Plugins/WebBaseNetscapePluginStream.m:
        (-[WebBaseNetscapePluginStream dealloc]):
        Assert that the stream file path either never existed, or was deleted and NULL-ed out.  The stream file
        is now deleted immediately after calling NPP_StreamAsFile().
        (-[WebBaseNetscapePluginStream finalize]):
        ditto
        (-[WebBaseNetscapePluginStream _destroyStream]):
        Delete the file after calling NPP_StreamAsFile(), instead of in -dealloc/-finalize.  It should be OK
        to delete the file here -- NPP_StreamAsFile() is always called immediately before NPP_DestroyStream()
        (the stream destruction function), so there can be no expectation that a plugin will read the stream file
        asynchronously after NPP_StreamAsFile() is called.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Eric.
tomernic [Tue, 28 Mar 2006 04:13:28 +0000 (04:13 +0000)]
    Reviewed by Eric.

        <rdar://problem/3694093> -[WebBasePluginPackage finalize] is incorrect; design change needed

        Call -unload on plug-in packages instead of relying on -dealloc/-finalize to do it.  Currently
        the only place plug-in packages are deallocated is when refreshing the set of plugins, as when
        handling JavaScript's navigator.plugins.refresh().

        * Plugins/WebBasePluginPackage.m:
        (-[WebBasePluginPackage dealloc]):
        Assert that the plug-in has been unloaded by the time -dealloc is called.
        (-[WebBasePluginPackage finalize]):
        ditto

        * Plugins/WebPluginDatabase.m:
        (-[WebPluginDatabase refresh]):
        Call -unload on the plug-in packages before releasing them.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Based on a patch by Michael Emmel <mike.emmel@gmail.com>.
darin [Tue, 28 Mar 2006 01:07:28 +0000 (01:07 +0000)]
    Based on a patch by Michael Emmel <mike.emmel@gmail.com>.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8012
          TransferJob.cpp includes non-existent "String.h" (capital S)

        * platform/TransferJob.cpp: Remove unneeded include of "String.h".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin.
harrison [Tue, 28 Mar 2006 00:57:18 +0000 (00:57 +0000)]
    Reviewed by Darin.

        <rdar://problem/4427002> REGRESSION: VoiceOver doesn't read heading level text in Safari (Range selectNodeContents broken)

        * editing/deleting/delete-block-merge-contents-022.html: Added.
        * editing/deleting/delete-block-merge-contents-023.html: Added.
        * editing/selection/selectNode-expected.checksum: Added.
        * editing/selection/selectNode-expected.png: Added.
        * editing/selection/selectNode-expected.txt: Added.
        * editing/selection/selectNode.html: Added.
        * editing/selection/selectNodeContents-expected.checksum: Added.
        * editing/selection/selectNodeContents-expected.png: Added.
        * editing/selection/selectNodeContents-expected.txt: Added.
        * editing/selection/selectNodeContents.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin.
harrison [Tue, 28 Mar 2006 00:54:30 +0000 (00:54 +0000)]
    Reviewed by Darin.

        <rdar://problem/4427002> REGRESSION: VoiceOver doesn't read heading level text in Safari (Range selectNodeContents broken)

        Better fix than previous checkin, since maxDeepOffset is really an editing hack.

        * editing/selection/selectNodeContents-textNode.html: Added.

        * dom/Range.cpp:
        (WebCore::Range::selectNodeContents):
        Use maxOffset if offsetInCharacters, otherwise use childNodeCount.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago At the request of Michael Emmel <mike.emmel@gmail.com>.
darin [Mon, 27 Mar 2006 22:21:09 +0000 (22:21 +0000)]
    At the request of Michael Emmel <mike.emmel@gmail.com>.

        - fix compilation for Linux
          http://bugzilla.opendarwin.org/show_bug.cgi?id=8013

        * rendering/render_style.h: Add declaration of CSSStyleSelector. Also tweaked
        formatting a bit and removed some extraneous WebCore:: prefixes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Tim Hatcher.
tomernic [Mon, 27 Mar 2006 22:07:12 +0000 (22:07 +0000)]
    Reviewed by Tim Hatcher.

        Part of <rdar://problem/4448350> Deprecated ObjC language API used in JavaScriptCore, WebCore,
        WebKit and WebBrowser

        * Carbon/HIViewAdapter.h:
        HIViewAdapter is no longer an NSView subclass, since we no longer pose it as NSView.
        * Carbon/HIViewAdapter.m:
        (+[NSView bindHIViewToNSView:nsView:]):
        Replace individual NSView methods instead of posing as NSView.
        (_webkit_NSView_setNeedsDisplay):
        Replacement implementation of -[NSView setNeedsDisplay:].
        (_webkit_NSView_setNeedsDisplayInRect):
        Replacement implementation of -[NSView setNeedsDisplayInRect:]
        (_webkit_NSView_nextValidKeyView):
        Replacement implementation of -[NSView nextValidKeyView]

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin Adler and Tim Omernick
sullivan [Mon, 27 Mar 2006 21:44:53 +0000 (21:44 +0000)]
    Reviewed by Darin Adler and Tim Omernick

        - fixed <rdar://problem/4406505> REGRESSION: (japanese text) Clauses is unexpectedly
        confirmed while typing on Safari.

        * bindings/objc/DOMHTML.mm:
        (-[DOMHTMLInputElement _displayedValue]):
        Avoid calling stringValue on the focused NSTextField. This will soon be obsolete, but
        for now it fixes this regression.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin Adler.
sullivan [Mon, 27 Mar 2006 21:33:20 +0000 (21:33 +0000)]
    Reviewed by Darin Adler.

        Removed two overzealous assertions that the steps to reproduce 4451831 were running into.
        Improved comments to match.

        * WebCoreSupport/WebFrameBridge.m:
        (-[WebFrameBridge _nextKeyViewOutsideWebFrameViewsWithValidityCheck:]):
        Remove assertion that _inNextKeyViewOutsideWebFrameViews should always be false here.

        * WebView/WebHTMLView.m:
        (-[NSArray nextValidKeyView]):
        Removed assertion that the frame should never be the main frame here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Tim Hatcher.
tomernic [Mon, 27 Mar 2006 21:20:50 +0000 (21:20 +0000)]
    Reviewed by Tim Hatcher.

        Removed tabs & reformatted code.

        * Carbon/HIViewAdapter.m:
        (+[NSView bindHIViewToNSView:nsView:]):
        (+[NSView getHIViewForNSView:]):
        (+[NSView unbindNSView:]):
        (-[NSView setNeedsDisplay:]):
        (-[NSView setNeedsDisplayInRect:]):
        (-[NSView nextValidKeyView]):
        (SetViewNeedsDisplay):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-03-27 Alexander Kellett <lypanov@kde.org>
lypanov [Mon, 27 Mar 2006 21:10:17 +0000 (21:10 +0000)]
2006-03-27  Alexander Kellett  <lypanov@kde.org>

        Reviewed by darin

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=6520
        the IE extension insertAdjacentElement

        * fast/dynamic/insertAdjacentElement.html: Added.

2006-03-27  Alexander Kellett  <lypanov@kde.org>

        Reviewed by darin

        Implement the IE extension insertAdjacentElement
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6520

        * bindings/scripts/CodeGeneratorJS.pm:
        * dom/Element.cpp:
        (WebCore::ElementImpl::insertAdjacentElement):
        * dom/Element.h:
        * dom/Element.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by beth and geoff
justing [Mon, 27 Mar 2006 17:34:20 +0000 (17:34 +0000)]
    Reviewed by beth and geoff

        * editing/selection/6476-expected.checksum: Added.
        * editing/selection/6476-expected.png: Added.
        * editing/selection/6476-expected.txt: Added.
        * editing/selection/6476.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Tim Hatcher.
harrison [Mon, 27 Mar 2006 16:23:01 +0000 (16:23 +0000)]
    Reviewed by Tim Hatcher.

        <rdar://problem/4427002> REGRESSION: VoiceOver doesn't read heading level text in Safari (Range selectNodeContents broken)

        Range::selectNodeContents() was erroneously using childNodeCount, which is always 0 for text
        nodes.  Turns out that [WebCoreAXObject textUnderElement] is the only code that ends up calling
        selectNodeContents on a text node.

        Test cases added: None.  Manual AX testing is way too awkward, and automated testing
        is not possible.  See following bug...
            <rdar://problem/4256882> Need automated testing support for accessibility APIs

        * dom/Range.cpp:
        (WebCore::Range::selectNodeContents):
        Use maxDeepOffset instead of childNodeCount, so that text node content is selected.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
justing [Mon, 27 Mar 2006 13:17:22 +0000 (13:17 +0000)]
LayoutTests:

        Reviewed by darin

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=7868>
        REGRESSION: Extraneous focus ring drawn at the end of the page

        * fast/css/outline-auto-empty-rects-expected.checksum: Added.
        * fast/css/outline-auto-empty-rects-expected.png: Added.
        * fast/css/outline-auto-empty-rects-expected.txt: Added.
        * fast/css/outline-auto-empty-rects.html: Added.

WebCore:

        Reviewed by darin

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=7868>
        REGRESSION: Extraneous focus ring drawn at the end of the page

        * platform/GraphicsContext.cpp:
        (WebCore::GraphicsContext::addFocusRingRect): Don't add a focus ring for an empty rect.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoJavaScriptCore:
mjs [Mon, 27 Mar 2006 11:29:11 +0000 (11:29 +0000)]
JavaScriptCore:

        Reviewed by Anders.

        - fixed <rdar://problem/4489745> REGRESSION: Safari crashes at to display http://www.lgphilips-lcd.com/

        * kjs/nodes.cpp:
        (Node::deref): take into account the case where the extra refcount table was never created

WebCore:

        Reviewed by Anders.

        - fixed <rdar://problem/4489745> REGRESSION: Safari crashes at to display http://www.lgphilips-lcd.com/

        * manual-tests/empty-script-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Build fix:
mjs [Mon, 27 Mar 2006 09:32:34 +0000 (09:32 +0000)]
    Build fix:

        - reverted fix for <rdar://problem/4362396> capturing listeners do not fire on the target node
        It turns out that the behavior we had was standards-compliant and
        Moz will be changing to match.

        Also added a note so this doesn't get reverted again.

        * dom/EventTargetNode.cpp:
        (WebCore::EventTargetNode::dispatchGenericEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoWebCore:
justing [Mon, 27 Mar 2006 08:34:32 +0000 (08:34 +0000)]
WebCore:

        Reviewed by darn

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=7974>
        Add EditActions and WebUndoActions for CreateLink and Unlink

        * bridge/mac/WebCoreFrameBridge.h:
        * editing/CreateLinkCommand.h:
        (WebCore::CreateLinkCommand::editingAction):
        * editing/EditAction.h:
        * editing/UnlinkCommand.h:
        (WebCore::UnlinkCommand::editingAction):

WebKit:

        Reviewed by darin

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=7974>
        Add EditActions and WebUndoActions for CreateLink and Unlink

        * English.lproj/Localizable.strings:
        * WebCoreSupport/WebFrameBridge.m:
        (-[WebFrameBridge nameForUndoAction:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-03-26 Eric Seidel <eseidel@apple.com>
eseidel [Mon, 27 Mar 2006 03:29:58 +0000 (03:29 +0000)]
2006-03-26  Eric Seidel  <eseidel@apple.com>

        Reviewed by mjs.

        Fix win32 build.

        * WebCore.vcproj/WebCore/WebCore.vcproj:
        * editing/CompositeEditCommand.cpp:
        * editing/InsertTextCommand.cpp:
        * generate-derived-sources:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-03-26 Eric Seidel <eseidel@apple.com>
eseidel [Mon, 27 Mar 2006 01:30:00 +0000 (01:30 +0000)]
2006-03-26  Eric Seidel  <eseidel@apple.com>

        * dom/Element.cpp: fix include case, fixing build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-03-25 Mitz Pettel <opendarwin.org@mitzpettel.com>
eseidel [Sun, 26 Mar 2006 22:58:26 +0000 (22:58 +0000)]
2006-03-25  Mitz Pettel  <opendarwin.org@mitzpettel.com>

        Reviewed by darin.  Landed by eseidel.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7916
          Box repaint rect does not include the left overflow

        * manual-tests/left-overflow-repaint.html: Added.
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::overflowRect): Changed m_overflowWidth and m_overflowHeight
        to overflowWidth() and overflowHeight() since RenderTable overrides the latter.
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::getAbsoluteRepaintRect): Include top and left overflows.
        * rendering/RenderFlow.cpp:
        (WebCore::RenderFlow::getAbsoluteRepaintRect): Removed redundant code.
        * rendering/RenderTableCell.cpp: Removed subclass implementation of
        getAbsoluteRepaintRect().
        * rendering/RenderTableCell.h:
        * rendering/bidi.cpp:
        (WebCore::RenderBlock::layoutInlineChildren): Include left overflow in repaint rect.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-03-25 Eric Seidel <eseidel@apple.com>
eseidel [Sat, 25 Mar 2006 23:52:21 +0000 (23:52 +0000)]
2006-03-25  Eric Seidel  <eseidel@apple.com>

        Reviewed by andersca.

        Build fix.

        * bindings/scripts/CodeGeneratorJS.pm: include Element.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-03-24 Mitz Pettel <opendarwin.org@mitzpettel.com>
eseidel [Sat, 25 Mar 2006 22:24:52 +0000 (22:24 +0000)]
2006-03-24  Mitz Pettel  <opendarwin.org@mitzpettel.com>

        Reviewed by darin.  Landed by eseidel.

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=7947
          Add repaint testing support to run-webkit-tests

        * DumpRenderTree/DumpRenderTree.m:
        (main): Added --repaint and --horizontal-sweep options.
        (dump): Repaint line-by-line or column-by-column when the appropriate option
        is selected.
        (+[LayoutTestController isSelectorExcludedFromWebScript:]): Added testRepaint()
        and repaintSweepHorizontally() methods to layoutTestController.
        (-[LayoutTestController testRepaint]):
        (-[LayoutTestController repaintSweepHorizontally]):
        (dumpRenderTree):
        * Scripts/run-webkit-tests: Added --repaint and --horizontal-sweep options
        to force these settings on tests that do not ask for them.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-03-25 Eric Seidel <eseidel@apple.com>
eseidel [Sat, 25 Mar 2006 22:20:36 +0000 (22:20 +0000)]
2006-03-25  Eric Seidel  <eseidel@apple.com>

        Reviewed by andersca.

        Split dom_elementimpl.* into multiple files (one per class).
        http://bugzilla.opendarwin.org/show_bug.cgi?id=7978

        * ForwardingHeaders/kdom/core/Attr.h: Removed.
        * ForwardingHeaders/kdom/core/Element.h: Removed.
        * ForwardingHeaders/kdom/core/XMLElement.h: Removed.
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/objc/DOM.mm:
        * bindings/objc/DOMHTML.mm:
        * bindings/scripts/CodeGeneratorJS.pm:
        * dom/AbstractView.cpp:
        * dom/Attr.cpp: Added.
        * dom/Attr.h: Added.
        * dom/Attribute.cpp: Added.
        * dom/Attribute.h: Added.
        * dom/CSSMappedAttributeDeclaration.cpp: Added.
        * dom/CSSMappedAttributeDeclaration.h: Added.
        * dom/DOMImplementation.cpp:
        * dom/Document.h:
        * dom/DocumentType.cpp:
        * dom/Element.cpp: Added.
        (WebCore::Element::Element):
        (WebCore::Element::~Element):
        * dom/Element.h: Added.
        * dom/EventNames.cpp:
        * dom/EventTargetNode.cpp:
        * dom/MappedAttribute.cpp: Added.
        * dom/MappedAttribute.h: Added.
        * dom/MappedAttributeEntry.h: Added.
        (WebCore::):
        * dom/NameNodeList.cpp:
        (WebCore::NameNodeList::NameNodeList):
        (WebCore::NameNodeList::item):
        (WebCore::NameNodeList::nodeMatches):
        * dom/NamedAttrMap.cpp: Added.
        * dom/NamedAttrMap.h: Added.
        * dom/NamedMappedAttrMap.cpp: Added.
        (WebCore::NamedMappedAttrMap::NamedMappedAttrMap):
        * dom/NamedMappedAttrMap.h: Added.
        * dom/Node.cpp:
        * dom/NodeList.cpp:
        * dom/Position.cpp:
        * dom/StyledElement.cpp: Added.
        * dom/StyledElement.h: Added.
        * dom/dom_elementimpl.cpp: Removed.
        * dom/dom_elementimpl.h: Removed.
        * editing/BreakBlockquoteCommand.cpp:
        * editing/CompositeEditCommand.cpp:
        * editing/DeleteFromTextNodeCommand.cpp:
        * editing/DeleteSelectionCommand.cpp:
        * editing/InsertLineBreakCommand.cpp:
        * editing/InsertParagraphSeparatorCommand.cpp:
        * editing/InsertTextCommand.cpp:
        * editing/MergeIdenticalElementsCommand.cpp:
        * editing/ModifySelectionListLevelCommand.cpp:
        * editing/MoveSelectionCommand.cpp:
        * editing/RemoveCSSPropertyCommand.cpp:
        * editing/RemoveNodeAttributeCommand.cpp:
        * editing/Selection.cpp:
        * editing/SelectionController.cpp:
        * editing/SetNodeAttributeCommand.cpp:
        * editing/SplitElementCommand.cpp:
        * editing/SplitTextNodeContainingElementCommand.cpp:
        * editing/TextIterator.cpp:
        * editing/TypingCommand.cpp:
        * editing/VisiblePosition.cpp:
        * editing/visible_units.cpp:
        * html/HTMLElement.h:
        * html/HTMLTokenizer.h:
        * html/html_baseimpl.cpp:
        * kcanvas/RenderSVGImage.cpp:
        * khtml/ecma/kjs_views.cpp:
        * khtml/ecma/kjs_window.cpp:
        (KJS::Window::getValueProperty):
        * khtml/xbl/xbl_binding_manager.cpp:
        * khtml/xbl/xbl_tokenizer.cpp:
        * ksvg2/misc/SVGImageLoader.cpp:
        * ksvg2/svg/SVGAElement.cpp:
        * ksvg2/svg/SVGAnimateTransformElement.cpp:
        * ksvg2/svg/SVGAnimationElement.cpp:
        * ksvg2/svg/SVGCircleElement.cpp:
        * ksvg2/svg/SVGClipPathElement.cpp:
        * ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
        * ksvg2/svg/SVGCursorElement.cpp:
        * ksvg2/svg/SVGElement.cpp:
        (WebCore::SVGElement::SVGElement):
        * ksvg2/svg/SVGElement.h:
        * ksvg2/svg/SVGEllipseElement.cpp:
        * ksvg2/svg/SVGExternalResourcesRequired.cpp:
        * ksvg2/svg/SVGFEBlendElement.cpp:
        * ksvg2/svg/SVGFEColorMatrixElement.cpp:
        * ksvg2/svg/SVGFEComponentTransferElement.cpp:
        * ksvg2/svg/SVGFECompositeElement.cpp:
        * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
        * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
        * ksvg2/svg/SVGFEFloodElement.cpp:
        * ksvg2/svg/SVGFEGaussianBlurElement.cpp:
        * ksvg2/svg/SVGFEImageElement.cpp:
        * ksvg2/svg/SVGFELightElement.cpp:
        * ksvg2/svg/SVGFEMergeElement.cpp:
        * ksvg2/svg/SVGFEMergeNodeElement.cpp:
        * ksvg2/svg/SVGFEOffsetElement.cpp:
        * ksvg2/svg/SVGFESpecularLightingElement.cpp:
        * ksvg2/svg/SVGFETileElement.cpp:
        * ksvg2/svg/SVGFETurbulenceElement.cpp:
        * ksvg2/svg/SVGFilterElement.cpp:
        * ksvg2/svg/SVGFilterPrimitiveStandardAttributes.cpp:
        * ksvg2/svg/SVGFitToViewBox.cpp:
        * ksvg2/svg/SVGGradientElement.cpp:
        * ksvg2/svg/SVGImageElement.cpp:
        * ksvg2/svg/SVGLangSpace.cpp:
        * ksvg2/svg/SVGLineElement.cpp:
        * ksvg2/svg/SVGLinearGradientElement.cpp:
        * ksvg2/svg/SVGMarkerElement.cpp:
        * ksvg2/svg/SVGMaskElement.cpp:
        * ksvg2/svg/SVGPathElement.cpp:
        * ksvg2/svg/SVGPatternElement.cpp:
        * ksvg2/svg/SVGPolyElement.cpp:
        * ksvg2/svg/SVGRadialGradientElement.cpp:
        * ksvg2/svg/SVGRectElement.cpp:
        * ksvg2/svg/SVGSVGElement.cpp:
        * ksvg2/svg/SVGScriptElement.cpp:
        * ksvg2/svg/SVGStopElement.cpp:
        * ksvg2/svg/SVGStyledElement.cpp:
        * ksvg2/svg/SVGStyledTransformableElement.cpp:
        * ksvg2/svg/SVGSwitchElement.cpp:
        * ksvg2/svg/SVGTests.cpp:
        * ksvg2/svg/SVGTextContentElement.cpp:
        * ksvg2/svg/SVGTextPositioningElement.cpp:
        * ksvg2/svg/SVGTransformable.cpp:
        * ksvg2/svg/SVGURIReference.cpp:
        * ksvg2/svg/SVGUseElement.cpp:
        * ksvg2/svg/SVGViewElement.cpp:
        * ksvg2/svg/SVGZoomAndPan.cpp:
        * kwq/WebCoreTextArea.mm:
        * platform/Widget.h:
        * rendering/RenderBlock.cpp:
        * rendering/RenderCanvas.cpp:
        * rendering/RenderContainer.cpp:
        * rendering/RenderObject.cpp:
        * rendering/RenderTextField.cpp:
        * rendering/RenderThemeMac.mm:
        * rendering/bidi.cpp:
        * rendering/render_replaced.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-03-25 Eric Seidel <eseidel@apple.com>
eseidel [Sat, 25 Mar 2006 11:22:44 +0000 (11:22 +0000)]
2006-03-25  Eric Seidel  <eseidel@apple.com>

        Reviewed by mjs.

        Fix RenderStyle creation to avoid floating RenderStyle objects.
        This also fixes a bug, were SVG to ever start sharing RenderStyles
        between elements, code would have crashed as there were improperly
        paired style->deref() statements in SVG code.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=7976

        No test possible (no functionality change).

        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::createStyleForElement):
        (WebCore::CSSStyleSelector::createPseudoStyleForElement):
        * css/cssstyleselector.h:
        * dom/Node.cpp:
        (WebCore::Node::createRendererIfNeeded):
        (WebCore::Node::createStyleForRenderer):
        * dom/Node.h:
        * dom/dom_elementimpl.cpp:
        (WebCore::Element::createStyleForRenderer):
        (WebCore::Element::recalcStyle):
        * dom/dom_elementimpl.h:
        * ksvg2/svg/SVGClipPathElement.cpp:
        (SVGClipPathElement::canvasResource):
        * ksvg2/svg/SVGFEFloodElement.cpp:
        (SVGFEFloodElement::filterEffect):
        * ksvg2/svg/SVGGradientElement.cpp:
        (SVGGradientElement::rebuildStops):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::createObject):
        (WebCore::RenderObject::RenderObject):
        (WebCore::selectStartNode):
        (WebCore::RenderObject::draggableNode):
        (WebCore::RenderObject::getPseudoStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-03-23 Eric Seidel <eseidel@apple.com>
eseidel [Sat, 25 Mar 2006 10:46:44 +0000 (10:46 +0000)]
2006-03-23  Eric Seidel  <eseidel@apple.com>

        Reviewed by mjs.

        Shave .2% on PLT by removing bogus strcmp.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=7938

        Test: fast/parser/tag-with-exclamation-point.html

        * html/HTMLTokenizer.cpp:
        (WebCore::HTMLTokenizer::parseTag): remove bogus strcmp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
justing [Sat, 25 Mar 2006 10:17:39 +0000 (10:17 +0000)]
LayoutTests:

        Reviewed by harrison

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=7683>
        TinyMCE: execCommand("Unlink") unimplemented

        * editing/editing.js:
        * editing/execCommand/createLink-expected.checksum: Removed.
        * editing/execCommand/createLink-expected.png: Removed.
        * editing/execCommand/createLink-expected.txt:
        * editing/execCommand/createLink.html:
        * editing/execCommand/unlink-expected.txt: Added.
        * editing/execCommand/unlink.html: Added.

WebCore:

        Reviewed by harrison

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=7683>
        TinyMCE: execCommand("Unlink") unimplemented

        Added code to push partially selected anchor elements down before
        creating or removing links to create fully selected chunks that can be removed.
        Changed __create_link_command_h__ to CreateLinkCommand_h
        Gave styled element application/removal its own ApplyStyleCommand constructor.
        Still need to add new EditActions (7974).

        * WebCore.xcodeproj/project.pbxproj:
        * editing/ApplyStyleCommand.cpp:
        (WebCore::ApplyStyleCommand::ApplyStyleCommand):
        (WebCore::ApplyStyleCommand::applyBlockStyle):
        (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
        * editing/ApplyStyleCommand.h:
        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::applyStyle):
        (WebCore::CompositeEditCommand::applyStyledElement):
        (WebCore::CompositeEditCommand::removeStyledElement):
        (WebCore::enclosingAnchorElement):
        (WebCore::CompositeEditCommand::pushAnchorElementDown):
        (WebCore::CompositeEditCommand::pushPartiallySelectedAnchorElementsDown):
        * editing/CompositeEditCommand.h:
        * editing/CreateLinkCommand.cpp:
        (WebCore::CreateLinkCommand::doApply):
        * editing/CreateLinkCommand.h:
        * editing/JSEditor.cpp:
        * editing/Selection.cpp:
        (WebCore::Selection::selectionFromContentsOfNode):
        * editing/Selection.h:
        * editing/UnlinkCommand.cpp: Added.
        (WebCore::UnlinkCommand::UnlinkCommand):
        (WebCore::UnlinkCommand::doApply):
        * editing/UnlinkCommand.h: Added.
        * page/Frame.cpp:
        (WebCore::Frame::selectContentsOfNode):
        (WebCore::Frame::computeAndSetTypingStyle):
        (WebCore::Frame::applyStyle):
        (WebCore::Frame::applyParagraphStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agogit-svn-id: https://svn.webkit.org/repository/webkit/trunk@13476 268f45cc-cd09-0410...
justing [Sat, 25 Mar 2006 03:34:00 +0000 (03:34 +0000)]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
justing [Sat, 25 Mar 2006 03:28:51 +0000 (03:28 +0000)]
LayoutTests:

        Reviewed by harrison

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=7955>
        REGRESSION: Content with an interchange newline lost when pasted at the end of the document

        * editing/pasteboard/7955-expected.checksum: Added.
        * editing/pasteboard/7955-expected.png: Added.
        * editing/pasteboard/7955-expected.txt: Added.
        * editing/pasteboard/7955.html: Added.

WebCore:

        Reviewed by harrison

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=7955>
        REGRESSION: Content with an interchange newline lost when pasted at the end of the document

        There's no safe place in the document to keep the fragment while pasting, so I avoid
        isProbablyBlock by saving whether or not something was blockFlow during the test
        insertion.

        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplacementFragment::ReplacementFragment):
        (WebCore::ReplacementFragment::~ReplacementFragment):
        (WebCore::ReplacementFragment::firstChild):
        (WebCore::ReplacementFragment::lastChild):
        (WebCore::ReplacementFragment::mergeStartNode):
        (WebCore::ReplacementFragment::enclosingBlock):
        (WebCore::ReplacementFragment::insertFragmentForTestRendering):
        (WebCore::ReplacementFragment::restoreTestRenderingNodesToFragment):
        (WebCore::ReplacementFragment::isBlockFlow):
        (WebCore::ReplaceSelectionCommand::fixupNodeStyles):
        (WebCore::styleForNode):
        (WebCore::ReplacementFragment::saveRenderingInfo):
        (WebCore::ReplacementFragment::removeUnrenderedNodes):
        (WebCore::ReplacementFragment::renderedBlocks):
        (WebCore::ReplacementFragment::removeStyleNodes):
        (WebCore::RenderingInfo::RenderingInfo):
        (WebCore::ReplaceSelectionCommand::ReplaceSelectionCommand):
        (WebCore::ReplaceSelectionCommand::doApply):
        * editing/ReplaceSelectionCommand.h:
        (WebCore::RenderingInfo::isBlockFlow):
        (WebCore::ReplacementFragment::renderingInfo):
        (WebCore::ReplacementFragment::nodes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-03-24 Eric Seidel <eseidel@apple.com>
eseidel [Sat, 25 Mar 2006 03:11:23 +0000 (03:11 +0000)]
2006-03-24  Eric Seidel  <eseidel@apple.com>

        Reviewed by justing.

        * generate-derived-sources: fix clean builds on mac.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
darin [Sat, 25 Mar 2006 01:47:44 +0000 (01:47 +0000)]
LayoutTests:

        Reviewed by Dave Harrison.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=7942
          nightlies after r13387 break js createcontextualfragment

        * fast/dom/Range/create-contextual-fragment-expected.checksum: Added.
        * fast/dom/Range/create-contextual-fragment-expected.png: Added.
        * fast/dom/Range/create-contextual-fragment-expected.txt: Added.
        * fast/dom/Range/create-contextual-fragment.html: Added.

WebCore:

        Reviewed by Dave Harrison.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7942
          nightlies after r13387 break js createcontextualfragment

        Test: fast/dom/Range/create-contextual-fragment.html

        * dom/Range.idl: Add createContextualFragment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoFix typo
eseidel [Fri, 24 Mar 2006 10:42:07 +0000 (10:42 +0000)]
Fix typo

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-03-24 Eric Seidel <eseidel@apple.com>
eseidel [Fri, 24 Mar 2006 10:41:05 +0000 (10:41 +0000)]
2006-03-24  Eric Seidel  <eseidel@apple.com>

        Reviewed by mjs.

        Build fix.

        * Spinneret/Spinneret/WebFrame.cpp:
        (WebKit::WebFrame::openURL): replace QString with DeprecatedString

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-03-24 Eric Seidel <eseidel@apple.com>
eseidel [Fri, 24 Mar 2006 10:40:28 +0000 (10:40 +0000)]
2006-03-24  Eric Seidel  <eseidel@apple.com>

        Reviewed by mjs.

        Fix win32 build.
        Uninify mac/win dependency handling.
        Fix class vs. struct linker problem for win32.

        * WebCore.vcproj/WebCore/WebCore.vcproj: Add DerivedSources
        * WebCore.vcproj/WebCore/build-generated-files.sh:
        * bridge/win/BrowserExtensionWin.h:
        * bridge/win/FrameWin.h:
        * generate-derived-sources:
        * kwq/AccessibilityObjectCache.h:
        * platform/GraphicsContext.cpp:
        (WebCore::GraphicsContext::createGraphicsContextPrivate):
        (WebCore::GraphicsContext::destroyGraphicsContextPrivate):
        * platform/GraphicsContext.h:
        * platform/cairo/GraphicsContextCairo.cpp:
        * platform/mac/GraphicsContextMac.mm:
        * platform/win/TemporaryLinkStubs.cpp:
        (QLineEdit::selectedText):
        (FrameWin::createPlugin):
        (BrowserExtensionWin::setTypedIconURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin.
darin [Fri, 24 Mar 2006 07:17:26 +0000 (07:17 +0000)]
    Reviewed by Darin.

        - Fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7918
        Coding style doc uses illegal entity

        * coding/coding-style.html: Changed &emdash; to &mdash;.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin.
darin [Fri, 24 Mar 2006 07:15:40 +0000 (07:15 +0000)]
    Reviewed by Darin.

        - JSObject in LiveConnect not working.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=7917

        * bindings/jni_jsobject.cpp:
        (JavaJSObject::convertJObjectToValue): Was trying to retrieve the native pointer from the wrong base
        class, and the GetFieldID was using the wrong signature.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Adele.
darin [Fri, 24 Mar 2006 07:07:34 +0000 (07:07 +0000)]
    Reviewed by Adele.

        - fix <rdar://problem/4484787> KWQAccObject dangles under GC

        * kwq/AccessibilityObjectCache.h: Moved AccessibilityObjectCache into the WebCore
        namespace. Renamed accObject to get, removed setAccObject, renamed removeAccObject
        to remove, removed getAccObjectID, renamed removeAXObjectID to removeAXID, change
        from CF dictionaries to HashMap and HashSet.
        * kwq/AccessibilityObjectCache.mm:
        (WebCore::AccessibilityObjectCache::~AccessibilityObjectCache): Detach all objects
        and call CFRelease on all of them.
        (WebCore::AccessibilityObjectCache::get): Call CFRetain on objects before putting
        them in the HashMap, rather than assuming that retain == CFRetain. This is what
        fixes the GC issue.
        (WebCore::AccessibilityObjectCache::remove): Detach and call CFRelease when removing.
        (WebCore::AccessibilityObjectCache::getAXID): Change to use a single global variable
        for the AXIDs, which makes it so we won't reuse the same AXID as much as we did before.
        (WebCore::AccessibilityObjectCache::removeAXID): Updated to use HashSet.
        (WebCore::AccessibilityObjectCache::textMarkerForVisiblePosition): Updated for other changes.
        (WebCore::AccessibilityObjectCache::visiblePositionForTextMarker): Ditto.
        (WebCore::AccessibilityObjectCache::childrenChanged): Ditto.
        (WebCore::AccessibilityObjectCache::postNotificationToTopWebArea): Ditto.
        (WebCore::AccessibilityObjectCache::postNotification): Ditto.

        * bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge accessibilityTree]):
        Change to use functions by new names.

        * dom/Document.h: AccessibilityObjectCache is now in the WebCore namespace.
        getAccObjectCache and ownerElement are const member functions, and m_accCache
        is a mutable data member.
        * dom/Document.cpp:
        (WebCore::Document::getAccObjectCache): Make const.
        (WebCore::Document::ownerElement): Make const.

        * kwq/WebCoreAXObject.h: Changed WebCoreAXID to WebCore::AXID.
        * kwq/WebCoreAXObject.mm:
        (-[WebCoreAXObject anchorElement]): Update for function name change.
        (-[WebCoreAXObject firstChild]): Ditto.
        (-[WebCoreAXObject lastChild]): Ditto.
        (-[WebCoreAXObject previousSibling]): Ditto.
        (-[WebCoreAXObject nextSibling]): Ditto.
        (-[WebCoreAXObject parentObject]): Ditto.
        (-[WebCoreAXObject accessibilityAttributeValue:]): Ditto.
        (-[WebCoreAXObject doAXUIElementForTextMarker:]): Ditto.
        (AXLinkElementForNode): Ditto.
        (AXAttributedStringAppendReplaced): Ditto.
        (-[WebCoreAXObject accessibilityHitTest:]): Ditto.
        (-[WebCoreAXObject _accessibilityParentForSubview:]): Ditto.
        (-[WebCoreAXObject accessibilityFocusedUIElement]): Ditto.
        (-[WebCoreAXObject axObjectID]): Change field name to m_id.
        (-[WebCoreAXObject setAXObjectID:]): Ditto.
        (-[WebCoreAXObject removeAXObjectID]): Ditto.

        * rendering/RenderContainer.cpp:
        (WebCore::RenderContainer::removeChildNode): Remove ifdefs.
        (WebCore::RenderContainer::appendChildNode): Ditto.
        (WebCore::RenderContainer::insertChildNode): Ditto.
        * rendering/RenderObject.cpp: (WebCore::RenderObject::remove): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Maciej.
darin [Fri, 24 Mar 2006 07:05:03 +0000 (07:05 +0000)]
    Reviewed by Maciej.

        - fix buildbot

        * JavaScriptCore.xcodeproj/project.pbxproj: Change target name to JavaScriptCore (it was "include"!?).
        Also add -Y 3 option for linker.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoJavaScriptCore:
darin [Fri, 24 Mar 2006 06:28:07 +0000 (06:28 +0000)]
JavaScriptCore:

        Reviewed by Maciej.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7726
          REGRESSION: orbitz calendar fails (JavaScript function serialization/parsing)

        * kjs/object.h: Take function name, as well as source URL and line number, when
        using the special overloaded construct for making functions.
        * kjs/object.cpp: (KJS::JSObject::construct): Ditto.
        * kjs/function_object.h: Ditto.
        * kjs/function_object.cpp: (FunctionObjectImp::construct): Pass a name when
        constructing the function rather than null. Use "anonymous" when making a
        function using the default function constructor.

        * kjs/nodes2string.cpp: (FuncDeclNode::streamTo): Put a line break just before
        a function declaration.

        - unrelated fix

        * kxmlcore/HashMapPtrSpec.h: Add missing needed friend declaration.

LayoutTests:

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=7726
          REGRESSION: orbitz calendar fails (JavaScript function serialization/parsing)

        * fast/js/resources/function-names.js: Added.
        * fast/js/function-names.html: Generated.
        * fast/js/function-names-expected.txt: Generated.

WebCore:

        Reviewed by Maciej.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7726
          REGRESSION: orbitz calendar fails (JavaScript function serialization/parsing)

        Test: fast/js/function-names.html

        * dom/Document.h: Add function name parameter to createHTMLEventListener.
        * dom/Document.cpp:
        (WebCore::Document::createHTMLEventListener): Pass function name when calling
        createHTMLEventHandler.
        (WebCore::Document::setHTMLWindowEventListener): Pass attribute name as function name
        when calling createHTMLEventListener.

        * html/HTMLElement.cpp: (WebCore::HTMLElement::setHTMLEventListener): Pass attribute
        name as function name when calling createHTMLEventListener.

        * khtml/ecma/kjs_events.h: Add a function name parameter to JSLazyEventListener.
        * khtml/ecma/kjs_events.cpp:
        (KJS::JSLazyEventListener::JSLazyEventListener): Take and store a function name.
        (KJS::JSLazyEventListener::parseCode): Pass function name when constructing the function.

        * khtml/ecma/kjs_proxy.h: Add a function name parameter to createHTMLEventHandler and
        createSVGEventHandler.
        * khtml/ecma/kjs_proxy.cpp:
        (WebCore::KJSProxy::createHTMLEventHandler): Pass function name when creating
        a JSLazyEventListener.
        (WebCore::KJSProxy::createSVGEventHandler): Ditto.

        * ksvg2/events/JSSVGLazyEventListener.h: Add a function name parameter to
        JSSVGLazyEventListener.
        * ksvg2/events/JSSVGLazyEventListener.cpp:
        (WebCore::JSSVGLazyEventListener::JSSVGLazyEventListener): Pass the function name
        on to the base class constructor.

        * ksvg2/misc/SVGDocumentExtensions.h: Add function name parameter to createSVGEventListener.
        * ksvg2/misc/SVGDocumentExtensions.cpp:
        (WebCore::SVGDocumentExtensions::createSVGEventListener): Pass function name when
        calling createSVGEventHandler.

        * ksvg2/svg/SVGElement.cpp: (WebCore::SVGElement::addSVGEventListener):
        * ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::addSVGWindowEventListner):
        Pass attribute name as function name when calling createSVGEventListener.

        * WebCore.xcodeproj/project.pbxproj: Moved generation script to the top.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
tomernic [Fri, 24 Mar 2006 01:51:45 +0000 (01:51 +0000)]
LayoutTests:

        Reviewed by Darin.

        Layout test for:
        <http://bugzilla.opendarwin.org/show_bug.cgi?id=7691>

        * fast/forms/button-default-title-expected.checksum: Added.
        * fast/forms/button-default-title-expected.png: Added.
        * fast/forms/button-default-title-expected.txt: Added.
        * fast/forms/button-default-title.html: Added.

WebCore:

        Reviewed by Darin.

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=7691>
        REGRESSION: imdb.com search button looks wrong because "Submit" is drawn

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::valueWithDefault):
        Only use the default button title if no title was specified; previously we'd use the default
        button title if the specified title was empty, which is not what Firefox does.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago - removed merge artifacts from .checksum files
darin [Fri, 24 Mar 2006 01:20:28 +0000 (01:20 +0000)]
    - removed merge artifacts from .checksum files

        * fast/block/float/vertical-move-relayout-expected.checksum:
        * fast/css/first-letter-detach-expected.checksum:
        * fast/css/hover-subselector-expected.checksum:
        * fast/dom/Element/class-attribute-whitespace-expected.checksum:
        * fast/events/event-sender-mouse-moved-expected.checksum:
        * fast/forms/form-hides-table-expected.checksum:
        * fast/invalid/missing-address-end-tag-expected.checksum:
        * fast/invalid/missing-dl-end-tag-expected.checksum:
        * fast/invalid/missing-dt-end-tag-expected.checksum:
        * fast/invalid/missing-font-end-tag-expected.checksum:
        * fast/text/in-rendered-text-rtl-expected.checksum:
        * fast/tokenizer/missing-title-end-tag-1-expected.checksum:
        * fast/tokenizer/missing-title-end-tag-2-expected.checksum:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
darin [Fri, 24 Mar 2006 01:08:37 +0000 (01:08 +0000)]
LayoutTests:

        Reviewed by Beth.

        - test for <rdar://problem/4335038> REGRESSION: when max-height is none, height value is ignored

        * fast/css/max-height-none-expected.checksum: Added.
        * fast/css/max-height-none-expected.txt: Added.
        * fast/css/max-height-none.html: Added.
        * fast/css/max-height-none-expected.png: Added.

WebCore:

        Reviewed by Beth.

        - fix <rdar://problem/4335038> REGRESSION: when max-height is none, height value is ignored

        * css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
        For max-height of none, set it to Length(undefinedLength, Fixed), which
        is the correct value (same as the default). Also did some formatting fixes
        to the height section.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed, tweaked, and landed by Beth.
bdakin [Thu, 23 Mar 2006 22:44:29 +0000 (22:44 +0000)]
    Reviewed, tweaked, and landed by Beth.

        Test for http://bugzilla.opendarwin.org/show_bug.cgi?id=6431

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin
bdakin [Thu, 23 Mar 2006 22:27:49 +0000 (22:27 +0000)]
    Reviewed by Darin

        Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=6431
        REGRESSION: style change where :hover changes only an :after style
        doesn't work

        * dom/Node.cpp:
        (WebCore::Node::diff): Need to call diff() on the before and after
        styles if we have them.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by John Sullivan.
tomernic [Thu, 23 Mar 2006 22:07:37 +0000 (22:07 +0000)]
    Reviewed by John Sullivan.

        At John's suggestion, renamed a private WebFrame method and tightened up some of the redirect logic I recently touched.

        * WebView/WebFramePrivate.h:
        Renamed -_clientRedirectCancelled: to -_clientRedirectCancelledOrFinished:, since we call this both when a redirect is
        cancelled and when a redirect is successfully committed.
        * WebCoreSupport/WebFrameBridge.m:
        (-[WebFrameBridge reportClientRedirectCancelled:]):
        Call renamed WebFrame method.
        * WebView/WebFrame.m:
        Added sentRedirectNotification flag to WebFramePrivate.  This flag is set when we notify the frame load delegate that a
        redirect will occur.  We check this flag when committing a provisional load to ensure that the frame load delegate is
        notified that the redirect finished.
        (-[WebFrame _commitProvisionalLoad:]):
        After committing a provisional load, make sure that the frame load delegate is notified that there is no longer a pending
        redirect.
        (-[WebFrame _clientRedirectedTo:delay:fireDate:lockHistory:isJavaScriptFormAction:]):
        Set the new sentRedirectNotification flag.
        (-[WebFrame _clientRedirectCancelledOrFinished:]):
        Renamed method.
        Clear the sentRedirectNotification flag.
        (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]):
        Call renamed method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
adele [Thu, 23 Mar 2006 21:58:32 +0000 (21:58 +0000)]
LayoutTests:

        - Test for http://bugzilla.opendarwin.org/show_bug.cgi?id=7935
        <rdar://problem/4489010>
        Infinite recursion in table code when button or new text fields get display:table-row

        Added:
        * fast/forms/button-table-styles.txt: Added.
        * fast/forms/button-table-styles.png: Added.
        * fast/forms/button-table-styles.checksum: Added.
        * fast/forms/button-table-styles.html: Added.

WebCore:

        Reviewed by Hyatt.

        - Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=7935
        <rdar://problem/4489010>
        Infinite recursion in table code when button or new text fields get display:table-row

        Test:
        fast/forms/button-table-styles.html

        * rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustStyle):
        The theme should disallow table display styles form elements.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoCorrected the date on my previous ChangeLog entry for 4439752.
tomernic [Thu, 23 Mar 2006 21:28:44 +0000 (21:28 +0000)]
Corrected the date on my previous ChangeLog entry for 4439752.
Also moved to the top of the file (merge problem).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Eric.
tomernic [Thu, 23 Mar 2006 21:17:51 +0000 (21:17 +0000)]
    Reviewed by Eric.

        - fix <rdar://problem/4380465> repro crash when unsuccessfully attempting to import image from Services menu

        * WebView/WebDataSource.m:
        (-[WebDataSource _imageElementWithImageResource:]): Quietly do nothing if passed nil.
        (-[WebDataSource _documentFragmentWithImageResource:]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Maciej.
darin [Thu, 23 Mar 2006 16:31:32 +0000 (16:31 +0000)]
    Reviewed by Maciej.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7805
          LEAK: method name leaks in KJS::Bindings::CInstance::invokeMethod

        * bindings/c/c_utility.h: Remove NPN_UTF16FromString declaration (not implemented).
        * bindings/c/c_utility.cpp:
        (KJS::Bindings::convertValueToNPVariant): Use DOUBLE_TO_NPVARIANT,
        BOOLEAN_TO_NPVARIANT, VOID_TO_NPVARIANT, NULL_TO_NPVARIANT, and
        OBJECT_TO_NPVARIANT. In the case of OBJECT, call _NPN_RetainObject in
        one case and remove a _NPN_ReleaseObject in another because this
        should return a retained value.
        (KJS::Bindings::convertNPVariantToValue): Use NPVARIANT_TO_BOOLEAN,
        NPVARIANT_TO_INT32, and NPVARIANT_TO_DOUBLE.

        * bindings/c/c_runtime.h: Removed implementations of CMethod::name and
        CField::name that called _NPN_UTF8FromIdentifier and hence leaked.
        * bindings/c/c_runtime.cpp:
        (KJS::Bindings::CMethod::name): Added. Returns the string from inside the
        method object.
        (KJS::Bindings::CField::name): Added. Returns the string from inside the
        field object.
        (KJS::Bindings::CField::valueFromInstance): Added call to _NPN_ReleaseVariantValue
        on the result of getProperty after using it to fix a storage leak.
        (KJS::Bindings::CField::setValueToInstance): Added call to _NPN_ReleaseVariantValue
        after pasing a value to setProperty now that the conversion function does a retain.

        * bindings/c/c_instance.cpp:
        (KJS::Bindings::CInstance::invokeMethod): Changed to use Vector for a local
        stack buffer. Removed special case for NPVARIANT_IS_VOID because the
        convertNPVariantToValue function handles that properly.
        (KJS::Bindings::CInstance::invokeDefaultMethod): Ditto.

        * bindings/NP_jsobject.h: Formatting changes only.
        * bindings/NP_jsobject.cpp:
        (jsDeallocate): Changed parameter type so we don't need a function cast.
        (_NPN_InvokeDefault): Use VOID_TO_NPVARIANT.
        (_NPN_Invoke): Use NULL_TO_NPVARIANT and VOID_TO_NPVARIANT.
        (_NPN_Evaluate): Use VOID_TO_NPVARIANT.
        (_NPN_GetProperty): Use NULL_TO_NPVARIANT and VOID_TO_NPVARIANT.

        * bindings/c/c_class.cpp: Formatting changes only.
        * bindings/c/c_class.h: Formatting changes only.

        * bindings/npruntime_priv.h: Removed obsolete and now-unused functions:
        NPN_VariantIsVoid, NPN_VariantIsNull, NPN_VariantIsUndefined,
        NPN_VariantIsBool, NPN_VariantIsInt32, NPN_VariantIsDouble,
        NPN_VariantIsString, NPN_VariantIsObject, NPN_VariantToBool,
        NPN_VariantToInt32, NPN_VariantToDouble, NPN_VariantToString,
        NPN_VariantToStringCopy, NPN_VariantToObject, NPN_InitializeVariantAsVoid,
        NPN_InitializeVariantAsNull, NPN_InitializeVariantAsUndefined,
        NPN_InitializeVariantWithBool, NPN_InitializeVariantWithInt32,
        NPN_InitializeVariantWithDouble, NPN_InitializeVariantWithString,
        NPN_InitializeVariantWithObject, and NPN_InitializeVariantWithVariant.
        * bindings/npruntime.cpp:
        (getIntIdentifierDictionary): Don't bother creating custom callbacks for the
        integer dictionary since the default behavior is fine for integers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago * generate-derived-sources: Tweaked formatting a tiny bit and removed a stray
darin [Thu, 23 Mar 2006 16:08:29 +0000 (16:08 +0000)]
    * generate-derived-sources: Tweaked formatting a tiny bit and removed a stray
        touch that was left in here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Eric.
darin [Thu, 23 Mar 2006 15:36:47 +0000 (15:36 +0000)]
    Reviewed by Eric.

        - fix <rdar://problem/4380465> repro crash when unsuccessfully attempting to import image from Services menu

        * WebView/WebDataSource.m:
        (-[WebDataSource _imageElementWithImageResource:]): Quietly do nothing if passed nil.
        (-[WebDataSource _documentFragmentWithImageResource:]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-03-23 Eric Seidel <eseidel@apple.com>
eseidel [Thu, 23 Mar 2006 08:21:53 +0000 (08:21 +0000)]
2006-03-23  Eric Seidel  <eseidel@apple.com>

        Reviewed by mjs.

        REGRESSION: Dashed borders paint with the wrong phase
        http://bugzilla.opendarwin.org/show_bug.cgi?id=7879

        Test: Already covered by css1/box_properties/border_style.html

        * platform/cairo/GraphicsContextCairo.cpp:
        (WebCore::GraphicsContext::drawLine):
        * platform/mac/GraphicsContextMac.mm:
        (WebCore::GraphicsContext::drawLine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Eric.
mjs [Thu, 23 Mar 2006 06:30:24 +0000 (06:30 +0000)]
    Reviewed by Eric.

        * generate-derived-sources: Suppress warning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago * generate-derived-sources: Added.
mjs [Thu, 23 Mar 2006 06:13:17 +0000 (06:13 +0000)]
    * generate-derived-sources: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Eric.
mjs [Thu, 23 Mar 2006 06:03:35 +0000 (06:03 +0000)]
    Reviewed by Eric.

        Handle dependencies for derived sources properly.

        - Made a new generate-derived-sources script that does all the depedency checking
        and source generation.
        - Put this script in a subtarget instead of a phase.
        - Made derived sources go in the build root, not a source root.
        - Added derived sources to the project.
        - Removed files whose sole purpose was to include and compile derived sources,
        just compile those directly for now.
        - Tweaked the IDL code generator so it can handle one IDL at a time, to make
        it easier to get the dependencies right.

        * generate-derived-sources: Added.
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSDOMCore.cpp: Removed.
        * bindings/js/JSDOMEvents.cpp: Removed.
        * bindings/js/JSDOMHTML.cpp: Removed.
        * bindings/scripts/CodeGenerator.pm:
        * bindings/scripts/CodeGeneratorJS.pm:
        * bindings/scripts/generate-bindings.pl:
        * css/UserAgentStyleSheets.cpp: Removed.
        * dom/Range.cpp:
        (WebCore::Range::~Range):
        * dom/Range.h:
        * khtml/ecma/kjs_css.cpp:
        (KJS::DOMStyleSheet::DOMStyleSheet):
        (KJS::DOMStyleSheetList::DOMStyleSheetList):
        (KJS::DOMCSSRuleList::DOMCSSRuleList):
        (KJS::DOMCSSRule::DOMCSSRule):
        * khtml/ecma/kjs_css.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed and landed by Maciej.
mjs [Thu, 23 Mar 2006 05:46:18 +0000 (05:46 +0000)]
    Reviewed and landed by Maciej.

        - WebKit no longer builds with bison 2.1
        http://bugzilla.opendarwin.org/show_bug.cgi?id=7923

        * generate-derived-sources:  Handle generated header named either grammar.cpp.h
        or grammar.hpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
justing [Thu, 23 Mar 2006 01:37:40 +0000 (01:37 +0000)]
LayoutTests:

        Reviewed by harrison

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=7904>
        Avoid a layout after test insertion and remove isProbablyBlock

        Added:
        * editing/pasteboard/display-block-on-spans-expected.txt: Added.
        * editing/pasteboard/display-block-on-spans-expected.png: Added.
        * editing/pasteboard/display-block-on-spans-expected.checksum: Added.
        * editing/pasteboard/display-block-on-spans.html: Added.

        I'm disabling this layout test because of 7899:
        * editing/pasteboard/paste-empty-startcontainer.html

WebCore:

        Reviewed by harrison

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=7904>
        Avoid a layout after test insertion and remove isProbablyBlock

        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplacementFragment::ReplacementFragment):
        (WebCore::ReplacementFragment::~ReplacementFragment):
        (WebCore::ReplacementFragment::firstChild):
        (WebCore::ReplacementFragment::lastChild):
        (WebCore::ReplacementFragment::mergeStartNode):
        (WebCore::ReplacementFragment::enclosingBlock):
        (WebCore::ReplacementFragment::insertFragmentForTestRendering):
        (WebCore::ReplacementFragment::computeAndStoreNodeStyles):
        (WebCore::ReplacementFragment::removeUnrenderedNodes):
        (WebCore::ReplacementFragment::renderedBlocks):
        (WebCore::ReplacementFragment::removeStyleNodes):
        (WebCore::ReplaceSelectionCommand::ReplaceSelectionCommand):
        (WebCore::ReplaceSelectionCommand::doApply):
        * editing/ReplaceSelectionCommand.h:
        (WebCore::ReplacementFragment::root):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Kevin Decker.
tomernic [Thu, 23 Mar 2006 01:31:42 +0000 (01:31 +0000)]
    Reviewed by Kevin Decker.

        Even better fix for <rdar://problem/4432562>.  We need to notify the frame delegate of a finished redirect for both
        "fast" and "slow" redirects, after committing the load.  My previous change only notified for "fast", history-locking
        redirects.  Now we notify the frame delegate after committing any kind of provisional load, not just in the case of
        a fast redirect.

        * WebView/WebFrame.m:
        (-[WebFrame _transitionToCommitted:]):
        (-[WebFrame _commitProvisionalLoad:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-03-22 Eric Seidel <eseidel@apple.com>
eseidel [Thu, 23 Mar 2006 01:21:25 +0000 (01:21 +0000)]
2006-03-22  Eric Seidel  <eseidel@apple.com>

        Reviewed by hyatt.

        Fix attribute mutation events to not fire for "style" attributes.
        We lazily update style attributes, so sending mutation events for them makes no sense anymore.
        <rdar://problem/4474910> repro assertion failure @ apple.com/store: !eventDispatchForbidden()

        Test: fast/events/delayed-style-mutation-event-crash.html

        * dom/dom_elementimpl.cpp:
        (WebCore::Element::dispatchAttrRemovalEvent): add assert
        (WebCore::Element::dispatchAttrAdditionEvent): add assert
        (WebCore::NamedAttrMap::addAttribute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-03-22 Eric Seidel <eseidel@apple.com>
eseidel [Wed, 22 Mar 2006 23:37:17 +0000 (23:37 +0000)]
2006-03-22  Eric Seidel  <eseidel@apple.com>

        Reviewed by darin.

        Remove more DeprecatedString usage.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=7882

        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::attributedString):
        (WebCore::FrameMac::fontForSelection):
        (WebCore::FrameMac::tokenizerProcessedData):
        (WebCore::FrameMac::registerCommandForUndoOrRedo):
        (WebCore::FrameMac::markMisspellings):
        (WebCore::FrameMac::respondToChangedSelection):
        (WebCore::FrameMac::dashboardRegionsDictionary):
        (WebCore::FrameMac::dragSourceMovedTo):
        * css/CSSGrammar.y:
        * css/css_valueimpl.h:
        * css/cssparser.cpp:
        (WebCore::CSSParser::CSSParser):
        (WebCore::CSSParser::parseValue):
        (WebCore::CSSParser::parseColor):
        (WebCore::CSSParser::parseDeclaration):
        (WebCore::CSSParser::validUnit):
        (WebCore::CSSParser::parseShorthand):
        (WebCore::CSSParser::parseContent):
        (WebCore::skipCommaInDashboardRegion):
        (WebCore::CSSParser::parseDashboardRegions):
        (WebCore::CSSParser::parseShape):
        (WebCore::CSSParser::parseFont):
        (WebCore::CSSParser::parseFontFamily):
        (WebCore::CSSParser::parseColorFromValue):
        (WebCore::yyerror):
        (WebCore::CSSParser::lex):
        (WebCore::CSSParser::text):
        * css/cssparser.h:
        (WebCore::deprecatedString):
        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):
        * khtml/ecma/kjs_dom.cpp:
        (KJS::DOMDocument::getValueProperty):
        * ksvg2/css/SVGCSSParser.cpp:
        (WebCore::CSSParser::parseSVGPaint):
        (WebCore::CSSParser::parseSVGColor):
        * ksvg2/svg/SVGAnimationElement.cpp:
        (SVGAnimationElement::parseMappedAttribute):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::layoutPositionedObjects):
        (WebCore::RenderBlock::positionNewFloats):
        (WebCore::RenderBlock::newLine):
        * rendering/RenderCanvas.cpp:
        (WebCore::RenderCanvas::absolutePosition):
        (WebCore::RenderCanvas::paint):
        * rendering/RenderFlexibleBox.cpp:
        (WebCore::RenderFlexibleBox::layoutBlock):
        * rendering/RenderObject.h:
        * rendering/bidi.cpp:
        (WebCore::RenderBlock::bidiReorderLine):
        (WebCore::RenderBlock::layoutInlineChildren):
        * rendering/render_form.cpp:
        (WebCore::RenderFieldset::paintBoxDecorations):
        * rendering/render_style.h:
        (WebCore::RenderStyle::setDashboardRegion):
        * rendering/table_layout.cpp:
        (WebCore::AutoTableLayout::calcEffectiveWidth):
        (WebCore::AutoTableLayout::insertSpanCell):
        (WebCore::AutoTableLayout::layout):
        (WebCore::AutoTableLayout::calcPercentages):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Hyatt
bdakin [Wed, 22 Mar 2006 23:33:51 +0000 (23:33 +0000)]
    Reviewed by Hyatt

        Layout text for <rdar://problem/4471984> repro crash CSS position
        for html/table=relative causes crash when hiding table

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago - fix the build
mjs [Wed, 22 Mar 2006 22:42:40 +0000 (22:42 +0000)]
    - fix the build

        * JavaScriptCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoWebCore:
tomernic [Wed, 22 Mar 2006 22:30:39 +0000 (22:30 +0000)]
WebCore:

        Reviewed by Kevin Decker.

        Part of <rdar://problem/4351664> REGRESSION (420+): extra URL in b/f list - navigating back to previous page fails at apple.com/retail/)
        This also fixes <rdar://problem/4477821> REGRESSION (10.4.5-TOT): meta tag specifying refresh is being added to history.

        * bridge/mac/FrameMac.h:
        * bridge/mac/FrameMac.mm:
        Removed redirectionTimerFired().  This was added as attempt to fix <http://bugzilla.opendarwin.org/show_bug.cgi?id=7058>.  The
        aim was to cause Safari and WebKit to update their loading status after a redirect.  Unfortunately, the fix had a bad side
        effect.  Calling -reportClientRedirectCancelled: on a successful redirect causes WebKit to forget that the redirect was supposed
        to lock history (i.e. reuse the current back/forward entry for the new page).  The end result was that intermediate "quick" redirects
        were creating back/forward entries when they should not have been.  See 4351664.  That fix was almost correct, in that we do need to
        notify the frame load delegate when a redirect ends, either because it succeeded or because it was cancelled.  However, this is the
        wrong place to do it.  WebCore's redirect notification logic did not need to change to fix 7058.  The never-ending spinning indicators
        problem was actually caused by a bug at the WebKit level.

        * manual-tests/redirectHistory: Added.
        * manual-tests/redirectHistory/redir-1.html: Added.
        * manual-tests/redirectHistory/redir-2.html: Added.
        * manual-tests/redirectHistory/redir-3.html: Added.
        Manual test case.  I couldn't figure out how to create a layout test for this, because it involves navigation through history and
        it was unclear how/when to tell DumpRenderTree to dump its output.

WebKit:

        Reviewed by Kevin Decker.

        Better fix for <rdar://problem/4432562> REGRESSION (TOT): Safari's "stop loading" active, "view source" inactive after page load [7058]

        * WebView/WebFrame.m:
        (-[WebFrame _transitionToCommitted:]):
        Cancel the client redirect when we commit the provisional load, if we were waiting for a redirect.
        This is a better fix for 7058 (<rdar://problem/4432562>).  The original fix for 7058 changed the timing of the redirect cancel
        in such a way that WebKit was precluded from ever reusing back/forward list entries for redirects.  Clearing the redirect state
        here actually makes logical sense, as the redirect's target page is being committed at this point.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-03-22 Eric Seidel <eseidel@apple.com>
eseidel [Wed, 22 Mar 2006 22:27:45 +0000 (22:27 +0000)]
2006-03-22  Eric Seidel  <eseidel@apple.com>

        Reviewed by darin.

        Replace more DeprecatedString with String.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=7907

        * WebCore+SVG/kdom.h:
        * bindings/objc/DOMHTML.mm:
        (-[DOMHTMLDocument _createDocumentFragmentWithMarkupString:baseURLString:]):
        * bridge/BrowserExtension.h:
        * bridge/mac/BrowserExtensionMac.h:
        * bridge/mac/BrowserExtensionMac.mm:
        (WebCore::BrowserExtensionMac::setTypedIconURL):
        * bridge/mac/FrameMac.h:
        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::searchForLabelsBeforeElement):
        (WebCore::nsArray):
        (WebCore::FrameMac::createPlugin):
        (WebCore::FrameMac::bindingRootObject):
        (WebCore::FrameMac::windowScriptObject):
        (WebCore::FrameMac::windowScriptNPObject):
        (WebCore::FrameMac::partClearedInBegin):
        (WebCore::FrameMac::openURLFromPageCache):
        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge openURL:reload:contentType:refresh:lastModified:pageCache:]):
        (-[WebCoreFrameBridge scrollToAnchor:]):
        (-[WebCoreFrameBridge URLWithAttributeString:]):
        (-[WebCoreFrameBridge highlightAllMatchesForString:caseSensitive:]):
        * bridge/mac/WebCoreScriptDebugger.mm:
        (-[WebCoreScriptCallFrame evaluateWebScript:]):
        * bridge/mac/WebCoreSettings.mm:
        (-[WebCoreSettings _updateAllViews]):
        (-[WebCoreSettings setStandardFontFamily:]):
        (-[WebCoreSettings setMinimumFontSize:]):
        (-[WebCoreSettings setMinimumLogicalFontSize:]):
        (-[WebCoreSettings setDefaultFontSize:]):
        (-[WebCoreSettings setDefaultFixedFontSize:]):
        (-[WebCoreSettings setUserStyleSheetLocation:]):
        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
        * css/CSSGrammar.y:
        * css/css_stylesheetimpl.cpp:
        (WebCore::MediaList::setMediaText):
        * css/css_valueimpl.cpp:
        (WebCore::quoteStringIfNeeded):
        * css/cssparser.cpp:
        (WebCore::CSSParser::parseColor):
        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::CSSStyleSelector):
        * css/cssstyleselector.h:
        * dom/Document.cpp:
        (WebCore::Document::resetActiveLinkColor):
        (WebCore::Document::nextState):
        (WebCore::Document::setUserStyleSheet):
        (WebCore::Document::processHttpEquiv):
        (WebCore::Document::recalcStyleSelector):
        * dom/Document.h:
        (WebCore::Document::userStyleSheet):
        (WebCore::Document::setPrintStyleSheet):
        (WebCore::Document::printStyleSheet):
        * editing/markup.cpp:
        (WebCore::createMarkup):
        (WebCore::createFragmentFromMarkup):
        (WebCore::createFragmentFromText):
        * editing/markup.h:
        * html/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::setGlobalCompositeOperation):
        * html/HTMLTokenizer.cpp:
        (WebCore::HTMLTokenizer::scriptHandler):
        * html/html_baseimpl.cpp:
        (WebCore::HTMLFrameElement::openURL):
        (WebCore::HTMLFrameElement::attach):
        * html/html_headimpl.cpp:
        (WebCore::HTMLLinkElement::process):
        (WebCore::HTMLLinkElement::setStyleSheet):
        * html/html_headimpl.h:
        * html/html_imageimpl.cpp:
        (WebCore::HTMLImageElement::parseMappedAttribute):
        * html/html_imageimpl.h:
        (WebCore::HTMLImageElement::compositeOperator):
        * html/html_objectimpl.cpp:
        (WebCore::HTMLAppletElement::createRenderer):
        * ksvg2/svg/SVGStringList.cpp:
        (SVGStringList::reset):
        * kwq/AccessibilityObjectCache.h:
        * kwq/AccessibilityObjectCache.mm:
        (AccessibilityObjectCache::textMarkerForVisiblePosition):
        (AccessibilityObjectCache::postNotificationToTopWebArea):
        (AccessibilityObjectCache::postNotification):
        * kwq/ClipboardMac.mm:
        (WebCore::cocoaTypeFromMIMEType):
        * kwq/KWQKHTMLSettings.h:
        (KHTMLSettings::userStyleSheetLocation):
        (KHTMLSettings::setUserStyleSheetLocation):
        * kwq/KWQLineEdit.h:
        * kwq/KWQLineEdit.mm:
        (QLineEdit::selectedText):
        * loader/CachedCSSStyleSheet.cpp:
        (WebCore::CachedCSSStyleSheet::ref):
        * page/Frame.cpp:
        (WebCore::UserStyleSheetLoader::setStyleSheet):
        (WebCore::Frame::jScriptEnabled):
        (WebCore::Frame::javaEnabled):
        (WebCore::Frame::pluginsEnabled):
        (WebCore::Frame::receivedFirstData):
        (WebCore::Frame::begin):
        (WebCore::Frame::setUserStyleSheet):
        (WebCore::Frame::requestObject):
        (WebCore::Frame::loadPlugin):
        (WebCore::Frame::referrer):
        (WebCore::Frame::lastModified):
        (WebCore::Frame::reparseConfiguration):
        (WebCore::Frame::handleMousePressEventSingleClick):
        (WebCore::Frame::appliedEditing):
        (WebCore::Frame::unappliedEditing):
        (WebCore::Frame::reappliedEditing):
        * page/Frame.h:
        * page/FramePrivate.h:
        (WebCore::FramePrivate::FramePrivate):
        * platform/AtomicString.h:
        (WebCore::AtomicString::AtomicString):
        * platform/DeprecatedString.cpp:
        (DeprecatedString::replace):
        * platform/GraphicsContext.h:
        * platform/Image.h:
        * platform/KURL.cpp:
        * platform/KURL.h:
        * platform/PlatformString.h:
        (WebCore::String::String):
        (WebCore::String::replace):
        * platform/String.cpp:
        (WebCore::operator+):
        * platform/StringImpl.cpp:
        (WebCore::StringImpl::remove):
        (WebCore::parseLength):
        (WebCore::StringImpl::replace):
        * platform/StringImpl.h:
        * platform/mac/GraphicsContextMac.mm:
        (WebCore::GraphicsContext::setCompositeOperation):
        * rendering/RenderHTMLCanvas.cpp:
        (WebCore::RenderHTMLCanvas::paint):
        * rendering/render_form.cpp:
        (WebCore::RenderSelect::updateFromElement):
        * rendering/render_frames.cpp:
        (WebCore::isURLAllowed):
        (WebCore::mapClassIdToServiceType):
        (WebCore::RenderPartObject::updateWidget):
        * rendering/render_style.h:
        (WebCore::RenderStyle::setDashboardRegion):
        * xml/xmlhttprequest.cpp:
        (WebCore::getCharset):
        (WebCore::XMLHttpRequest::send):
        (WebCore::XMLHttpRequest::overrideMIMEType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Hyatt
bdakin [Wed, 22 Mar 2006 22:21:10 +0000 (22:21 +0000)]
    Reviewed by Hyatt

        Fix for <rdar://problem/4471984> repro crash CSS position for html/
        table=relative causes crash when hiding table

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago * kjs/generate-derived-sources: Set executable property.
mjs [Wed, 22 Mar 2006 22:10:35 +0000 (22:10 +0000)]
    * kjs/generate-derived-sources: Set executable property.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Fix for residual style problem where form elements lose their connection
hyatt [Wed, 22 Mar 2006 22:10:20 +0000 (22:10 +0000)]
    Fix for residual style problem where form elements lose their connection
        to a degenerate table form because of a residual style fixup.  This is
        Radar bug #4330765.

        Reviewed by eric

        * khtml/html/HTMLFormElement.cpp:
        (WebCore::HTMLFormElement::HTMLFormElement):
        * khtml/html/HTMLFormElement.h:
        (WebCore::HTMLFormElement::setPreserveFormConnectionAcrossRemove):
        (WebCore::HTMLFormElement::preserveFormConnectionAcrossRemove):
        * khtml/html/HTMLGenericFormElement.cpp:
        (WebCore::HTMLGenericFormElement::removedFromTree):
        * khtml/html/htmlparser.cpp:
        (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Adele.
adele [Wed, 22 Mar 2006 22:09:09 +0000 (22:09 +0000)]
    Reviewed by Adele.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7747
          REGRESSION: Background tab/window auto-refresh in GMail will take focus.

        * manual-tests/named-window-blank-target.html: Added.
        * manual-tests/resources/named-window-blank-target-step2.html: Added.
        * manual-tests/resources/named-window-blank-target-step3.html: Added.
        * manual-tests/resources/named-window-blank-target-step4.html: Added.
        * page/FrameTree.cpp:
        (WebCore::FrameTree::find): If the given name is empty, just return our frame,
        even if it has a name.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin.
mjs [Wed, 22 Mar 2006 21:31:48 +0000 (21:31 +0000)]
    Reviewed by Darin.

        Ensure that generated source dependencies are handled properly, as follows:

        - Made an external script that generates the sources into a
          DerivedSources dir in the build products directory.
        - Added a new build target that builds all the generated sources
          if needed. Sadly it has to be a target, not a phase for Xcode to notice changes.
        - Added the DerivedSources dir in question to the include path.
        - Added the new DerivedSources dir and its contents to the project as build-relative.

        * JavaScriptCore.xcodeproj/project.pbxproj:
        * kjs/generate-derived-sources: Added. Based on the windows version - maybe someday they
        can share more.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoAdded Bugzilla bug number.
darin [Wed, 22 Mar 2006 20:18:03 +0000 (20:18 +0000)]
Added Bugzilla bug number.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
darin [Wed, 22 Mar 2006 20:16:58 +0000 (20:16 +0000)]
LayoutTests:

        Reviewed by Adele.

        - test for <rdar://problem/4483856> REGRESSION (417.8-TOT): onclick handler cannot call a function named OnClick (7143)

        * fast/dom/Element/onclick-case-expected.txt: Added.
        * fast/dom/Element/onclick-case.html: Added.

WebCore:

        Reviewed by Adele.

        - fix <rdar://problem/4483856> REGRESSION (417.8-TOT): onclick handler cannot call a function named OnClick (7143)

        Test: fast/dom/Element/onclick-case.html

        We discussed this with Maciej. In the long run we may need to remove the "all attributes
        show up as properties in JavaScript" feature entirely. Gecko does not do it, and it's
        not really the same thing IE does either.

        * khtml/ecma/kjs_dom.cpp:
        (KJS::DOMElement::attributeGetter): Use getAttributeNS so we're case sensitive.
        (KJS::DOMElement::getOwnPropertySlot): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-03-22 Eric Seidel <eseidel@apple.com>
eseidel [Wed, 22 Mar 2006 20:02:32 +0000 (20:02 +0000)]
2006-03-22  Eric Seidel  <eseidel@apple.com>

        Reviewed by beth.

        <rdar://problem/4486417> REGRESSION: Mail linked against TOT WebKit crashes when composing a message

        No test possible.

        * bridge/mac/WebCoreSettings.mm:
        (-[WebCoreSettings init]): call AtomicString::init()

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=3784
darin [Wed, 22 Mar 2006 04:59:58 +0000 (04:59 +0000)]
    - fix bugzilla.opendarwin.org/show_bug.cgi?id=3784
          <rdar://problem/4483827> JavaScript save dialog disappears right away (sheet triggers blur event) (3784)

        * WebView/WebHTMLView.m:
        (-[WebHTMLView _updateFocusState]): Treat window as having focus if its sheet is key.
        (-[WebHTMLView addWindowObservers]): Observe all focus notifications, not just the ones involving this window.
        (-[WebHTMLView removeWindowObservers]): Ditto.
        (-[WebHTMLView windowDidBecomeKey:]): Add checks so that we call the methods only when appropriate,
        since this will now be called for all windows.
        (-[WebHTMLView windowDidResignKey:]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago - fix buildbot (and everyone else)
darin [Wed, 22 Mar 2006 04:44:43 +0000 (04:44 +0000)]
    - fix buildbot (and everyone else)

        * bindings/js/JSDOMCore.cpp: Touch, because Adele's change adds a virtual function,
        and Xcode doesn't know this needs recompiling.
        * bindings/js/JSDOMEvents.cpp: Ditto.
        * bindings/js/JSDOMHTML.cpp: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Eric and Darin.
darin [Wed, 22 Mar 2006 04:38:28 +0000 (04:38 +0000)]
    Reviewed by Eric and Darin.

        - get Windows building again

        * WebCore.vcproj/WebCore/WebCore.vcproj:
        * bridge/win/FrameWin.cpp:
        (WebCore::FrameWin::userAgent):
        * bridge/win/FrameWin.h:
        * platform/GraphicsContext.h:
        * platform/cairo/ImageCairo.cpp:
        (WebCore::Image::supportsType):
        * platform/win/TemporaryLinkStubs.cpp:
        (FrameWin::mimeTypeForFileName):
        (FrameWin::objectContentType):
        (FrameWin::createPlugin):
        (FrameWin::overrideMediaType):
        (FrameWin::passSubframeEventToSubframe):
        (FrameWin::createFrame):
        (FrameWin::incomingReferrer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin.
darin [Wed, 22 Mar 2006 03:42:48 +0000 (03:42 +0000)]
    Reviewed by Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7884
          REGRESSION: Selecting a custom style sheet crashes 20/3 nightly

        * page/Frame.cpp:
        (WebCore::UserStyleSheetLoader::setStyleSheet): This was calling the function
        that sets the stylesheet URL, passing it the actual stylesheet.
        (WebCore::Frame::begin):
        (WebCore::Frame::setUserStyleSheetLocation): Renamed the version of
        setUserStyleSheet() that takes a URL to this.
        (WebCore::Frame::reparseConfiguration):
        * page/Frame.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
adele [Wed, 22 Mar 2006 01:08:07 +0000 (01:08 +0000)]
LayoutTests:

        Tests for:
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6813
        elementAtPoint needs to return input element when clicking on new text field
        http://bugzilla.opendarwin.org/show_bug.cgi?id=7799
        New text fields don't respect the disabled attribute

        * fast/forms/input-appearance-disabled-expected.checksum: Added.
        * fast/forms/input-appearance-disabled-expected.png: Added.
        * fast/forms/input-appearance-disabled-expected.txt: Added.
        * fast/forms/input-appearance-disabled.html: Added.
        * fast/forms/input-appearance-elementFromPoint-expected.txt: Added.
        * fast/forms/input-appearance-elementFromPoint.html: Added.
        * fast/forms/input-appearance-preventDefault-expected.checksum: Added.
        * fast/forms/input-appearance-preventDefault-expected.png: Added.
        * fast/forms/input-appearance-preventDefault-expected.txt: Added.
        * fast/forms/input-appearance-preventDefault.html: Added.

WebCore:

        Reviewed by Darin.

        - Fix for
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6813
        elementAtPoint needs to return input element when clicking on new text field
        http://bugzilla.opendarwin.org/show_bug.cgi?id=7799
        New text fields don't respect the disabled attribute

        - Tests:
        fast/forms/input-appearance-disabled.html
        fast/forms/input-appearance-elementFromPoint.html
        fast/forms/input-appearance-preventDefault.html

        * bridge/mac/WebCoreFrameBridge.h: Added allowShadowContent parameter to getInnerNonSharedNode so new elementAtPoint method in WebKit can call this.
        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge getInnerNonSharedNode:innerNode:URLElement:atPoint:allowShadowContent:]): Passes allowShadowContent parameter to nodeInfoAtPoint.
        (-[WebCoreFrameBridge _visiblePositionForPoint:]): Updated to call nodeInfoAtPoint allowing shadow content.
        (-[WebCoreFrameBridge RenderObject::nodeInfoAtPoint:allowShadowContent:]): Added allowShadowContent parameter.

        * dom/Node.h:
        (WebCore::Node::isShadowNode): Added.
        (WebCore::Node::shadowParentNode): Added.
        * dom/Node.cpp: (WebCore::Node::shadowAncestorNode): Added.  If an ancestor is a shadow node, return its shadow parent node.
        * html/HTMLTextFieldInnerElement.h: (WebCore::HTMLTextFieldInnerElement::isShadowNode): Added.

        * dom/Document.cpp: (WebCore::Document::elementFromPoint): Gets the shadowAncestorNode (so we get the input element, and not the inner div).
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::isKeyboardFocusable): If text fields are focusable, then they should be keyboard focusable.  This works for the
        old text fields because HTMLGenericFormElement::isKeyboardFocusable does the right thing for RenderWidgets.  That's not needed for the new form
        elements.
        (WebCore::HTMLInputElement::defaultEventHandler): let the renderer forward drag, mouse, and wheel events.

        * page/FrameView.cpp:
        (WebCore::FrameView::updateDragAndDrop): Send drag events to the shadowAncestorNode.
        (WebCore::FrameView::dispatchMouseEvent): Send mouse events to the shadowAncestorNode.
        (WebCore::FrameView::handleWheelEvent): Send wheel events to the shadowAncestorNode.

        * rendering/RenderTextField.cpp: (WebCore::RenderTextField::forwardEvent): forwards events to the inner div element.
        * rendering/RenderTextField.h: Added forwardEvent method.

        * kwq/WebCoreAXObject.mm:
        (-[WebCoreAXObject accessibilityHitTest:]): Gets the  shadowAncestorNode (so we get the input element, and not the inner div).
        (-[WebCoreAXObject role]): Gets the right role for text fields, since we no longer get that from AppKit.
        (-[WebCoreAXObject roleDescription]): Gets the right description for text fields.

WebKit:

        Reviewed by Darin.

        - Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=6813
        elementAtPoint needs to return input element when clicking on new text field

        * WebView/WebDocumentInternal.h: Added elementAtPoint:allowShadowContent:
        * WebView/WebHTMLView.m:
        (-[NSArray elementAtPoint:]): Does not allow shadow content.  This way, by default, callers would get the input element instead of the inner div.
        (-[NSArray elementAtPoint:allowShadowContent:]): Allows callers to specify whether or not the element can be a shadow node.
        (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]): Allows shadow content when getting element.
        (-[WebHTMLView _mayStartDragAtEventLocation:]): ditto.
        (-[NSArray _isSelectionEvent:]): ditto.
        (-[NSArray _canProcessDragWithDraggingInfo:]): ditto.
        * WebView/WebFrame.m: (-[WebFrame _actionInformationForNavigationType:event:originalURL:]): Does not allow shadow content when getting element.
        * WebView/WebImageView.m: (-[WebImageView elementAtPoint:allowShadowContent:]): Added to conform to the WebDocumentElement protocol.
        * WebView/WebPDFView.m: (-[WebPDFView elementAtPoint:allowShadowContent:]): ditto.
        * WebView/WebTextView.m: (-[WebTextView elementAtPoint:allowShadowContent:]): ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
darin [Tue, 21 Mar 2006 23:52:24 +0000 (23:52 +0000)]
LayoutTests:

        - test for <rdar://problem/4251515> REGRESSION: listing tag broken in TOT

        * fast/html: Added.
        * fast/html/listing-expected.checksum: Added.
        * fast/html/listing-expected.png: Added.
        * fast/html/listing-expected.txt: Added.
        * fast/html/listing.html: Added.

WebCore:

        Reviewed by Tim O.

        - fixed <rdar://problem/4251515> REGRESSION: listing tag broken in TOT

        Test: fast/html/listing.html

        * html/HTMLNames.h: Add listing tag.

        * bindings/objc/DOM.mm: (+[DOMNode _nodeWith:]):
        * bridge/mac/FrameMac.mm: (WebCore::FrameMac::attributedString):
        * css/html4.css:
        * editing/ReplaceSelectionCommand.cpp: (WebCore::isProbablyBlock):
        * editing/TextIterator.cpp:
        (WebCore::TextIterator::handleNonTextNode):
        (WebCore::TextIterator::exitNode):
        (WebCore::SimplifiedBackwardsTextIterator::handleNonTextNode):
        * editing/markup.cpp:
        (WebCore::startMarkup):
        (WebCore::createMarkup):
        * html/HTMLElement.cpp: (WebCore::blockTagList):
        * html/HTMLElementFactory.cpp:
        (WebCore::addTag):
        (WebCore::createFunctionMap):
        (WebCore::HTMLElementFactory::createHTMLElement):
        * html/HTMLParser.cpp: (WebCore::HTMLParser::isAffectedByResidualStyle):
        * html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseTag):
        * khtml/ecma/kjs_html.cpp:
        (KJS::JSHTMLElement::classInfo):
        (KJS::JSHTMLElement::accessors):
        Add listing tags everywhere pre tags are listed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoTouching the idl files to force a build after Maciej's change.
thatcher [Tue, 21 Mar 2006 23:41:48 +0000 (23:41 +0000)]
Touching the idl files to force a build after Maciej's change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin.
mjs [Tue, 21 Mar 2006 23:36:17 +0000 (23:36 +0000)]
    Reviewed by Darin.

        - fix horrible build fallout from my attr fix

        * bindings/js/JSCanvasRenderingContext2DBase.cpp:
        * bindings/js/JSDOMCore.cpp:
        * bindings/js/JSDOMEvents.cpp:
        * bindings/js/JSDOMHTML.cpp:
        * bindings/scripts/CodeGeneratorJS.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Tim Hatcher and Darin.
tomernic [Tue, 21 Mar 2006 22:49:43 +0000 (22:49 +0000)]
    Reviewed by Tim Hatcher and Darin.

        <rdar://problem/4427068> LMGetCurApRefNum, CloseConnection and GetDiskFragment deprecated, used in Netscape
        plugin code

        * Plugins/WebNetscapeDeprecatedFunctions.h: Added.
        * Plugins/WebNetscapeDeprecatedFunctions.c: Added.
        Added wrappers for deprecated CFM and LowMem functions.  These exist in a separate file so that we can set
        -Wno-deprecated-declarations on this one file without ignoring other deprecated function usage elsewhere.
        (WebGetDiskFragment):
        (WebCloseConnection):
        (WebLMGetCurApRefNum):
        (WebLMSetCurApRefNum):

        * Plugins/WebNetscapePluginPackage.h:
        Don't include connID ivar in 64-bit, since CFM is not supported in 64-bit.
        * Plugins/WebNetscapePluginPackage.m:
        (+[WebNetscapePluginPackage initialize]):
        Don't bother setting the resource refNum in 64-bit, because the API to get and set it does not exist.
        A theoretical 64-bit plugin couldn't possibly rely this, since there is no API.
        (-[WebNetscapePluginPackage unloadWithoutShutdown]):
        No need to close the connID in 64-bit.
        (-[WebNetscapePluginPackage load]):
        Don't load CFM bundles in 64-bit, because CFM is not supported.

        * WebKit.xcodeproj/project.pbxproj:
        Added WebNetscapeDeprecatedFunctions.[hm].

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Kevin Decker.
sullivan [Tue, 21 Mar 2006 19:36:44 +0000 (19:36 +0000)]
    Reviewed by Kevin Decker.

        - fixed <rdar://problem/4485637> Implementors of searchFor:direction:caseSensitive:wrap: should bail
        out early if search string is empty

        This doesn't change any existing behavior, but avoids unnecessary work.

        * Misc/WebSearchableTextView.m:
        (-[WebSearchableTextView searchFor:direction:caseSensitive:wrap:]):
        bail out immediately (returning NO) if search string is empty

        * WebView/WebHTMLView.m:
        (-[WebView searchFor:direction:caseSensitive:wrap:]):
        ditto

        * WebView/WebPDFView.m:
        (-[WebPDFView searchFor:direction:caseSensitive:wrap:]):
        ditto

        * WebView/WebView.m:
        (-[WebView searchFor:direction:caseSensitive:wrap:]):
        ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reducing the amount of time this test waits for the frame to fully
bdakin [Tue, 21 Mar 2006 18:12:42 +0000 (18:12 +0000)]
    Reducing the amount of time this test waits for the frame to fully
        load per Justin's request.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=7223
bdakin [Tue, 21 Mar 2006 17:36:47 +0000 (17:36 +0000)]
    Fix for bugzilla.opendarwin.org/show_bug.cgi?id=7223
        Reproducible crash when tabbing to a frame that has not been loaded
        Also adds support for keyDown() to DumpRenderTree.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-03-20 Eric Seidel <eseidel@apple.com>
eseidel [Tue, 21 Mar 2006 10:53:05 +0000 (10:53 +0000)]
2006-03-20  Eric Seidel  <eseidel@apple.com>

        Reviewed by mjs.

        Fix a unsafe static cast causing intermittent crashes.
        <rdar://problem/4411663> crash at KXMLCore::RefPtr<WebCore::DOMStringImpl>::get() const + 20 (RefPtr.h:45)

        Test: fast/dom/NodeList/item-by-id-with-no-document.html

        * dom/NodeList.cpp:
        (WebCore::NodeList::itemById): fix unsafe static cast.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by vicki
justing [Tue, 21 Mar 2006 07:57:14 +0000 (07:57 +0000)]
    Reviewed by vicki

        Testcase for fix for:
        <http://bugzilla.opendarwin.org/show_bug.cgi?id=7363>
        REGRESSION (r12872): Repro crash when clicking the Quick Reply box in Gmail

        * fast/forms/textfield-focus-out-expected.txt: Added.
        * fast/forms/textfield-focus-out.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago - touch this file in hopes of fixing build
mjs [Tue, 21 Mar 2006 07:56:41 +0000 (07:56 +0000)]
    - touch this file in hopes of fixing build

        * bindings/js/JSDOMCore.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agofix accidentally reversed changelog entries
mjs [Tue, 21 Mar 2006 07:12:13 +0000 (07:12 +0000)]
fix accidentally reversed changelog entries

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
mjs [Tue, 21 Mar 2006 07:08:57 +0000 (07:08 +0000)]
LayoutTests:

        Reviewed by mjs.

        Test for: <rdar://problem/4483882> REGRESSION (417.8-TOT): crash at yourmovies.com.au in WebCore::HTMLTokenizer::reset() + 92 (7818)

        * fast/tokenizer/external-script-document-open-expected.txt: Added.
        * fast/tokenizer/external-script-document-open.html: Added.
        * fast/tokenizer/resources/external-script-document-open.js: Added.
        * fast/tokenizer/resources/write-external-script-open.js: Added.
        * fast/tokenizer/write-external-script-open-expected.txt: Added.
        * fast/tokenizer/write-external-script-open.html: Added.
        * fast/tokenizer/write-inline-script-open-expected.txt: Added.
        * fast/tokenizer/write-inline-script-open.html: Added.

WebCore:

        Reviewed by Anders.

        - fixed <rdar://problem/4446749> 10.4.4: safari crash in DOM::NamedAttrMapImpl::setNamedItem

        * bindings/scripts/CodeGeneratorJS.pm: Add a framework for typechecking method
        arguments. For now only use it for parameters of type Attr.
        * dom/Element.idl: Arbitrary change to make it regenerate.
        * dom/dom_elementimpl.cpp:
        (WebCore::Element::setAttributeNode): ASSERT that attr is not null
        * khtml/ecma/kjs_dom.cpp:
        (KJS::toAttr): add bool ok parameter
        * khtml/ecma/kjs_dom.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-03-20 Eric Seidel <eseidel@apple.com>
eseidel [Tue, 21 Mar 2006 07:02:59 +0000 (07:02 +0000)]
2006-03-20  Eric Seidel  <eseidel@apple.com>

        * ksvg2/css/SVGCSSParser.h: Removed unused file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-03-20 Eric Seidel <eseidel@apple.com>
eseidel [Tue, 21 Mar 2006 06:46:47 +0000 (06:46 +0000)]
2006-03-20  Eric Seidel  <eseidel@apple.com>

        Reviewed by mjs.

        Fix tokenizer crash when document.open() is called from an external script:
        <rdar://problem/4483882> REGRESSION (417.8-TOT): crash at yourmovies.com.au in WebCore::HTMLTokenizer::reset() + 92 (7818)

        * dom/Document.cpp:
        (WebCore::Document::open): Check to make sure the current tokenizer isn't executing a script
        * dom/xml_tokenizer.h:
        (WebCore::Tokenizer::executingScript): Add a way for others to know if scripts are executing.
        * html/HTMLTokenizer.cpp:
        (WebCore::HTMLTokenizer::scriptExecution): Wire into existing m_executingScript member var.
        * html/HTMLTokenizer.h:
        (WebCore::HTMLTokenizer::executingScript):
        * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
        (WebCore::KCanvasFilterQuartz::prepareFilter): Unrelated code cleanup.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by darin
justing [Tue, 21 Mar 2006 06:22:21 +0000 (06:22 +0000)]
    Reviewed by darin

        <rdar://problem/3997958>
        REGRESSION (Mail): Mail takes half of forever to paste >1500 lines - replaceSelectionWithNode

        * dom/Position.cpp:
        (WebCore::Position::upstream): Avoid calling previous() when we know that
        it will 1) end the search and 2) be expensive to compute.
        (WebCore::Position::downstream): Removed some dead code.
        (WebCore::Position::inRenderedText): Return false for offsets inside composed characters.
        * dom/Position.h:
        * editing/VisiblePosition.cpp:
        (WebCore::VisiblePosition::init): If there are two visually equivalent candidates, we choose
        the one that occurs first in document order.  Using upstream() to find the one that occurs first is
        much faster than the old code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
mjs [Tue, 21 Mar 2006 05:52:13 +0000 (05:52 +0000)]
LayoutTests:

        Reviewed by Adele.

        - test case for <rdar://problem/4362396> REGRESSION: (417-420) stopPropagation is not working for click event listener (onclick works fine)

        Make sure that capturing event listeners trigger on the target and that if they
        stopPropagation, then bubbling listeners on ancestors do not trigger.

        * fast/events/capture-on-target-expected.txt: Added.
        * fast/events/capture-on-target.html: Added.

WebCore:

        Reviewed by adele & ggaren.

        Added new cachePluginDataIfNecessary function to update
        plugins and mimes arrays.  Made sure to call this in
        constructor as well as refresh.  The crash was caused by
        a refresh rendering a "plugins" object invalid.
        Changed existing test case to depend on this new correct behavior.

        <rdar://problem/4480571> Safari crashed at exit at KXMLCore::deleteAllValues + 24

        * khtml/ecma/kjs_navigator.cpp:
        (KJS::PluginBase::cachePluginDataIfNecessary):
        (KJS::PluginBase::PluginBase):
        (KJS::PluginBase::~PluginBase):
        (KJS::PluginBase::refresh):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-03-20 Eric Seidel <eseidel@apple.com>
eseidel [Tue, 21 Mar 2006 04:23:44 +0000 (04:23 +0000)]
2006-03-20  Eric Seidel  <eseidel@apple.com>

        Reviewed by adele & ggaren.

        Added new cachePluginDataIfNecessary function to update
        plugins and mimes arrays.  Made sure to call this in
        constructor as well as refresh.  The crash was caused by
        a refresh rendering a "plugins" object invalid.
        Changed existing test case to depend on this new correct behavior.

        <rdar://problem/4480571> Safari crashed at exit at KXMLCore::deleteAllValues + 24

        * khtml/ecma/kjs_navigator.cpp:
        (KJS::PluginBase::cachePluginDataIfNecessary):
        (KJS::PluginBase::PluginBase):
        (KJS::PluginBase::~PluginBase):
        (KJS::PluginBase::refresh):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Justin.
adele [Tue, 21 Mar 2006 03:52:22 +0000 (03:52 +0000)]
    Reviewed by Justin.

        * rendering/RenderTextField.cpp: (WebCore::RenderTextField::visiblePositionForIndex):
        When calculating the VisiblePosition for the first position in the text field, it
        makes more sense for the position to have a downstream affinity.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-03-20 Eric Seidel <eseidel@apple.com>
eseidel [Tue, 21 Mar 2006 01:54:46 +0000 (01:54 +0000)]
2006-03-20  Eric Seidel  <eseidel@apple.com>

        Reviewed by justing.

        Re-enable previously failing test.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6560

        * dom/xhtml/level2/html/HTMLIFrameElement11.xhtml: Added.
        * dom/xhtml/level2/html/HTMLIFrameElement11.xhtml-disabled: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13408 268f45cc-cd09-0410-ab3c-d52691b4dbfc