WebKit-https.git
4 years agoMarked inspector/css/add-rule.html as flaky on macOS
jlewis3@apple.com [Mon, 21 Aug 2017 18:15:19 +0000 (18:15 +0000)]
Marked inspector/css/add-rule.html as flaky on macOS
https://bugs.webkit.org/show_bug.cgi?id=173560

Unreviewed test gardening.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Payment Request] Implement the PaymentRequest constructor
aestes@apple.com [Mon, 21 Aug 2017 17:41:04 +0000 (17:41 +0000)]
[Payment Request] Implement the PaymentRequest constructor
https://bugs.webkit.org/show_bug.cgi?id=175755

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

* web-platform-tests/payment-request/payment-request-constructor.https-expected.txt:
* web-platform-tests/payment-request/payment-request-id.https-expected.txt:

Source/WebCore:

* Modules/paymentrequest/PaymentDetailsModifier.h: Changed total to an std::optional<PaymentItem>.
* Modules/paymentrequest/PaymentRequest.cpp:
(WebCore::isWellFormedCurrencyCode): Implements the IsWellFormedCurrencyCode abstract operation from ECMA 402.
(WebCore::isValidDecimalMonetaryValue): Implements the "valid decimal monetary value" validity checker.
(WebCore::checkAndCanonicalizeAmount): Implements the "check and canonicalize amount" validity checker.
(WebCore::checkAndCanonicalizeTotal): Implements the "check and canonicalize total" validity checker.
(WebCore::PaymentRequest::create): Implements the PaymentRequest Constructor
(WebCore::PaymentRequest::PaymentRequest):
(WebCore::PaymentRequest::id const): Implements the PaymentRequest id attribute.
(WebCore::PaymentRequest::shippingType const): Implements the PaymentRequest shippingType attribute.
* Modules/paymentrequest/PaymentRequest.h:
* Modules/paymentrequest/PaymentRequest.idl: Annotated PaymentRequest with ConstructorMayThrowException.
* WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Win] DRT should only allow any https certificate for localhost.
pvollan@apple.com [Mon, 21 Aug 2017 17:21:30 +0000 (17:21 +0000)]
[Win] DRT should only allow any https certificate for localhost.
https://bugs.webkit.org/show_bug.cgi?id=175147

Reviewed by Brent Fulgham.

Source/WebCore:

Disabling validation of certificate chains, breaks SSL on Windows. In order
for SSL tests to succeed on Windows, we should avoid disabling it.

No new tests, covered by existing tests.

* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::ResourceHandle::createCFURLConnection):

Tools:

Add check to make sure only localhost requests allow any https certificate.

* DumpRenderTree/win/DumpRenderTree.cpp:
(runTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRebaselined js/dom/global-constructors-attributes.html on macOS.
jlewis3@apple.com [Mon, 21 Aug 2017 17:00:48 +0000 (17:00 +0000)]
Rebaselined js/dom/global-constructors-attributes.html on macOS.

Unreviewed test gardening.

* platform/mac-elcapitan-wk2/js/dom/global-constructors-attributes-expected.txt:
* platform/mac-highsierra-wk1/js/dom/global-constructors-attributes-expected.txt:
* platform/mac-highsierra/js/dom/global-constructors-attributes-expected.txt:
* platform/mac/js/dom/global-constructors-attributes-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoSkip imported/w3c/web-platform-tests/payment-request/payment-request-constructor...
ryanhaddad@apple.com [Mon, 21 Aug 2017 16:45:53 +0000 (16:45 +0000)]
Skip imported/w3c/web-platform-tests/payment-request/payment-request-constructor-crash.https.html.
https://bugs.webkit.org/show_bug.cgi?id=175773

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[GTK][WPE] Rebaseline tests with list item markers.
commit-queue@webkit.org [Mon, 21 Aug 2017 16:36:59 +0000 (16:36 +0000)]
[GTK][WPE] Rebaseline tests with list item markers.
https://bugs.webkit.org/show_bug.cgi?id=175771

Unreviewed test gardening.

The output was changed in r220858 and rebaselined for ios and mac only.
They're changes in render tree dumps that don't affect rendering.

Patch by Ms2ger <Ms2ger@igalia.com> on 2017-08-21

* platform/gtk/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
* platform/gtk/fast/doctypes/002-expected.txt:
* platform/gtk/fast/lists/marker-before-empty-inline-expected.txt:
* platform/wpe/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAdd WTFLogChannel level to allow runtime log filtering
eric.carlson@apple.com [Mon, 21 Aug 2017 16:30:54 +0000 (16:30 +0000)]
Add WTFLogChannel level to allow runtime log filtering
https://bugs.webkit.org/show_bug.cgi?id=175731
<rdar://problem/33967234>

Unreviewed build fix.

* TestWebKitAPI/Tests/WebCore/Logging.cpp:
(TestWebKitAPI::LoggingTest::output): Disable testing output by default because it
fails on some of the bots.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agomedia-captions.html improvements
commit-queue@webkit.org [Mon, 21 Aug 2017 15:44:28 +0000 (15:44 +0000)]
media-captions.html improvements
https://bugs.webkit.org/show_bug.cgi?id=175768

Patch by Ms2ger <Ms2ger@igalia.com> on 2017-08-21
Reviewed by Eric Carlson.

* media/media-captions.html: remove reference to unused script file.
* platform/gtk/TestExpectations: remove Timeout, Crash annotations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAdd WTFLogChannel level to allow runtime log filtering
eric.carlson@apple.com [Mon, 21 Aug 2017 13:03:05 +0000 (13:03 +0000)]
Add WTFLogChannel level to allow runtime log filtering
https://bugs.webkit.org/show_bug.cgi?id=175731
<rdar://problem/33967234>

Reviewed by Jer Noble.
Source/WTF:

Add WTFLog*, LOG, and RELEASE_LOG variants that take a "log level" parameter so code
can include logging statements that are only conditionally emitted.

* wtf/Assertions.cpp:
* wtf/Assertions.h:
* wtf/MemoryPressureHandler.cpp:
* wtf/RefCountedLeakCounter.cpp:

Tools:

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebCore/Logging.cpp: Added.
(TestWebKitAPI::LoggingTest::output):
(TestWebKitAPI::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoMemoryCache::setCapacities assertion failure maxDeadBytes <= totalBytes
commit-queue@webkit.org [Mon, 21 Aug 2017 12:59:00 +0000 (12:59 +0000)]
MemoryCache::setCapacities assertion failure maxDeadBytes <= totalBytes
https://bugs.webkit.org/show_bug.cgi?id=175571

Patch by Charlie Turner <cturner@igalia.com> on 2017-08-21
Reviewed by Antti Koivisto.

* Shared/CacheModel.cpp:
(WebKit::calculateMemoryCacheSizes): Ensure cacheTotalCapacity is
set to a reasonable value even in low-memory environments.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[EME] HTMLMediaElement: basic implementations of 'Attempt to Decrypt', 'Attempt to...
zandobersek@gmail.com [Mon, 21 Aug 2017 12:56:44 +0000 (12:56 +0000)]
[EME] HTMLMediaElement: basic implementations of 'Attempt to Decrypt', 'Attempt to Resume Playback If Necessary'
https://bugs.webkit.org/show_bug.cgi?id=175761

Reviewed by Xabier Rodriguez-Calvar.

Add initial and incomplete implementations of the 'Attempt to Decrypt' and
'Attempt to Resume Playback If Necessary' algorithms.  The implementations
are interleaved with the specification text for clarity.

'Attempt to Decrypt' implementation doesn't yet address the encrypted block
queue or the 'decryption blocked waiting for key' flag since it's not yet
clear whether it would make more sense for this state to reside lower, in
the platform layer. The gist of the algorithm is to invoke the decryption
attempt through the MediaPlayer object, passing along the CDMInstance object
retrieved from the MediaKeys object that is associated with this media
element.

'Attempt to Resume Playback if Necessary' implementation similarly for now
omits the various state flag operations. The main task at this point is to
dispatch the 'Attempt to Decrypt' algorithm.

HTMLMediaElement::cdmClientAttemptToResumePlaybackIfNecessary() method now
invokes the attemptToResumePlaybackIfNecessary() method.

MediaKeys::hasOpenSessions() is introduced, returning true if any session
that was created through this MediaKeys instance is still open. This allows
the 'Attempt to Decrypt' algorithm to proceed with the decryption attempt
dispatch into the MediaPlayer hierarchy.

For that, the MediaPlayer::attemptToDecryptWithInstance() method is added,
which simply dispatches the mirror method on MediaPlayerPrivate interface.
This will enable the platform-layer implementations to use the passed-in
CDMInstance object for decryption purposes.

* Modules/encryptedmedia/MediaKeySession.h:
* Modules/encryptedmedia/MediaKeys.cpp:
(WebCore::MediaKeys::hasOpenSessions const):
* Modules/encryptedmedia/MediaKeys.h:
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::attemptToDecrypt):
(WebCore::HTMLMediaElement::attemptToResumePlaybackIfNecessary):
(WebCore::HTMLMediaElement::cdmClientAttemptToResumePlaybackIfNecessary):
* html/HTMLMediaElement.h: Mark cdmClientAttemptToResumePlaybackIfNecessary() as final.
* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::attemptToDecryptWithInstance):
* platform/graphics/MediaPlayer.h:
* platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::attemptToDecryptWithInstance):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[GTK] Remove some old flaky crash expectations.
commit-queue@webkit.org [Mon, 21 Aug 2017 08:28:48 +0000 (08:28 +0000)]
[GTK] Remove some old flaky crash expectations.
https://bugs.webkit.org/show_bug.cgi?id=108682

Unreviewed test gardening.

Patch by Ms2ger <Ms2ger@gmail.com> on 2017-08-21

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoGardening: fix CLoop build.
mark.lam@apple.com [Mon, 21 Aug 2017 06:56:19 +0000 (06:56 +0000)]
Gardening: fix CLoop build.
https://bugs.webkit.org/show_bug.cgi?id=175688
<rdar://problem/33436870>

Not reviewed.

Source/JavaScriptCore:

Make these files dependent on ENABLE(MASM_PROBE).

* assembler/ProbeContext.cpp:
* assembler/ProbeContext.h:
* assembler/ProbeStack.cpp:
* assembler/ProbeStack.h:

Source/WTF:

Disable MASM_PROBE if !ENABLE(JIT).

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[EME] Add basic implementation of HTMLMediaElement::setMediaKeys()
zandobersek@gmail.com [Mon, 21 Aug 2017 06:21:38 +0000 (06:21 +0000)]
[EME] Add basic implementation of HTMLMediaElement::setMediaKeys()
https://bugs.webkit.org/show_bug.cgi?id=175717

Reviewed by Xabier Rodriguez-Calvar.

Source/WebCore:

Add an initial and incomplete implementation of HTMLMediaElement::setMediaKeys(),
interleaved with the specification wording of how this operation should behave.
The implementation still doesn't cover cases of CDM instances being already
associated with a different HTMLMediaElement, of CDM instances that can't be
disassociated from the current HTMLMediaElement, and of failures during both
association and disassociation of MediaKeys with the HTMLMediaElement.

The HTMLMediaElement (as a CDMClient inheritor) has to be attached or detached
from the MediaKeys object as appropriate. This attachment allows MediaKeys to
initiate an attempt to resume playback whenever the key statuses of the
associated MediaKeys object are updated.

Upon association and disassociation with MediaKeys, the CDMInstance object of
that specific MediaKeys instance is attached to or detached from the MediaPlayer
instance. This allows the platform layer to gather information about the
CDMInstance that will be used for decryption of media content for this specific
media element.

Additionally, the detachment from both MediaKeys and MediaPlayer is done upon
HTMLMediaElement destruction.

Upon setting the MediaKeys object, a task is queued that launches the 'Attempt to
Resume Playback If Necessary' algorithm. A placeholder method is added that will
implement the algorithm in the future.

The HTMLMediaElement::mediaKeys() getter is also implemented, returning pointer
held in m_mediaKeys.

Covered to a degree by existing imported W3C tests, with a setMediaKeys()-oriented
test having WPE-specific baseline update.

* Modules/encryptedmedia/MediaKeys.h:
(WebCore::MediaKeys::cdmInstance const):
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::~HTMLMediaElement):
(WebCore::HTMLMediaElement::mediaKeys const):
(WebCore::HTMLMediaElement::setMediaKeys):
(WebCore::HTMLMediaElement::attemptToResumePlaybackIfNecessary):
(WebCore::HTMLMediaElement::contextDestroyed):
* html/HTMLMediaElement.h:
* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::cdmInstanceAttached):
(WebCore::MediaPlayer::cdmInstanceDetached):
* platform/graphics/MediaPlayer.h:
* platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::cdmInstanceAttached):
(WebCore::MediaPlayerPrivateInterface::cdmInstanceDetached):

LayoutTests:

* platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-expected.txt:
Update the baseline, with the test no longer timing out but instead
failing with a NotAllowed exception thrown.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoEnhance MacroAssembler::probe() to allow the probe function to resize the stack frame...
mark.lam@apple.com [Mon, 21 Aug 2017 04:26:40 +0000 (04:26 +0000)]
Enhance MacroAssembler::probe() to allow the probe function to resize the stack frame and alter stack data in one pass.
https://bugs.webkit.org/show_bug.cgi?id=175688
<rdar://problem/33436870>

Reviewed by JF Bastien.

With this patch, the clients of the MacroAssembler::probe() can now change
stack values without having to worry about whether there is enough room in the
current stack frame for it or not.  This is done using the Probe::Context's stack
member like so:

    jit.probe([] (Probe::Context& context) {
        auto cpu = context.cpu;
        auto stack = context.stack();
        uintptr_t* currentSP = cpu.sp<uintptr_t*>();

        // Get a value at the current stack pointer location.
        auto value = stack.get<uintptr_t>(currentSP);

        // Set a value above the current stack pointer (within current frame).
        stack.set<uintptr_t>(currentSP + 10, value);

        // Set a value below the current stack pointer (out of current frame).
        stack.set<uintptr_t>(currentSP - 10, value);

        // Set the new stack pointer.
        cpu.sp() = currentSP - 20;
    });

What happens behind the scene:

1. the generated JIT probe code will now call Probe::executeProbe(), and
   Probe::executeProbe() will in turn call the client's probe function.

   Probe::executeProbe() receives the Probe::State on the machine stack passed
   to it by the probe trampoline.  Probe::executeProbe() will instantiate a
   Probe::Context to be passed to the client's probe function.  The client will
   no longer see the Probe::State directly.

2. The Probe::Context comes with a Probe::Stack which serves as a manager of
   stack pages.  Currently, each page is 1K in size.
   Probe::Context::stack() returns a reference to an instance of Probe::Stack.

3. Invoking get() of set() on Probe::Stack with an address will lead to the
   following:

   a. the address will be decoded to a baseAddress that points to the 1K page
      that contains that address.

   b. the Probe::Stack will check if it already has a cached 1K page for that baseAddress.
      If so, go to step (f).  Else, continue with step (c).

   c. the Probe::Stack will malloc a 1K mirror page, and memcpy the 1K stack page
      for that specified baseAddress to this mirror page.

   d. the mirror page will be added to the ProbeStack's m_pages HashMap,
      keyed on the baseAddress.

   e. the ProbeStack will also cache the last baseAddress and its corresponding
      mirror page in use.  With memory accesses tending to be localized, this
      will save us from having to look up the page in the HashMap.

   f. get() will map the requested address to a physical address in the mirror
      page, and return the value at that location.

   g. set() will map the requested address to a physical address in the mirror
      page, and set the value at that location in the mirror page.

      set() will also set a dirty bit corresponding to the "cache line" that
      was modified in the mirror page.

4. When the client's probe function returns, Probe::executeProbe() will check if
   there are stack changes that need to be applied.  If stack changes are needed:

   a. Probe::executeProbe() will adjust the stack pointer to ensure enough stack
      space is available to flush the dirty stack pages.  It will also register a
      flushStackDirtyPages callback function in the Probe::State.  Thereafter,
      Probe::executeProbe() returns to the probe trampoline.

   b. the probe trampoline adjusts the stack pointer, moves the Probe::State to
      a safe place if needed, and then calls the flushStackDirtyPages callback
      if needed.

   c. the flushStackDirtyPages() callback iterates the Probe::Stack's m_pages
      HashMap and flush all dirty "cache lines" to the machine stack.
      Thereafter, flushStackDirtyPages() returns to the probe trampoline.

   d. lastly, the probe trampoline will restore all register values and return
      to the pc set in the Probe::State.

To make this patch work, I also had to do the following work:

5. Refactor MacroAssembler::CPUState into Probe::CPUState.
   Mainly, this means moving the code over to ProbeContext.h.
   I also added some convenience accessor methods for spr registers.

   Moved Probe::Context over to its own file ProbeContext.h/cpp.

6. Fix all probe trampolines to pass the address of Probe::executeProbe in
   addition to the client's probe function and arg.

   I also took this opportunity to optimize the generated JIT probe code to
   minimize the amount of memory stores needed.

7. Simplified the ARM64 probe trampoline.  The ARM64 probe only supports changing
   either lr or pc (or neither), but not both at in the same probe invocation.
   The ARM64 probe trampoline used to have to check for this invariant in the
   assembly trampoline code.  With the introduction of Probe::executeProbe(),
   we can now do it there and simplify the trampoline.

8. Fix a bug in the old  ARM64 probe trampoline for the case where the client
   changes lr.  That code path never worked before, but has now been fixed.

9. Removed trustedImm32FromPtr() helper functions in MacroAssemblerARM and
   MacroAssemblerARMv7.

   We can now use move() with TrustedImmPtr, and it does the same thing but in a
   more generic way.

       10. ARMv7's move() emitter may encode a T1 move instruction, which happens to have
   the same semantics as movs (according to the Thumb spec).  This means these
   instructions may trash the APSR flags before we have a chance to preserve them.

   This patch changes MacroAssemblerARMv7's probe() to preserve the APSR register
   early on.  This entails adding support for the mrs instruction in the
   ARMv7Assembler.

       10. Change testmasm's testProbeModifiesStackValues() to now modify stack values
   the easy way.

   Also fixed testmasm tests which check flag registers to only compare the
   portions that are modifiable by the client i.e. some masking is applied.

This patch has passed the testmasm tests on x86, x86_64, arm64, and armv7.

* CMakeLists.txt:
* JavaScriptCore.xcodeproj/project.pbxproj:
* assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::mrs):
* assembler/AbstractMacroAssembler.h:
* assembler/MacroAssembler.cpp:
(JSC::stdFunctionCallback):
(JSC::MacroAssembler::probe):
* assembler/MacroAssembler.h:
(JSC::MacroAssembler::CPUState::gprName): Deleted.
(JSC::MacroAssembler::CPUState::sprName): Deleted.
(JSC::MacroAssembler::CPUState::fprName): Deleted.
(JSC::MacroAssembler::CPUState::gpr): Deleted.
(JSC::MacroAssembler::CPUState::spr): Deleted.
(JSC::MacroAssembler::CPUState::fpr): Deleted.
(JSC:: const): Deleted.
(JSC::MacroAssembler::CPUState::fpr const): Deleted.
(JSC::MacroAssembler::CPUState::pc): Deleted.
(JSC::MacroAssembler::CPUState::fp): Deleted.
(JSC::MacroAssembler::CPUState::sp): Deleted.
(JSC::MacroAssembler::CPUState::pc const): Deleted.
(JSC::MacroAssembler::CPUState::fp const): Deleted.
(JSC::MacroAssembler::CPUState::sp const): Deleted.
(JSC::Probe::State::gpr): Deleted.
(JSC::Probe::State::spr): Deleted.
(JSC::Probe::State::fpr): Deleted.
(JSC::Probe::State::gprName): Deleted.
(JSC::Probe::State::sprName): Deleted.
(JSC::Probe::State::fprName): Deleted.
(JSC::Probe::State::pc): Deleted.
(JSC::Probe::State::fp): Deleted.
(JSC::Probe::State::sp): Deleted.
* assembler/MacroAssemblerARM.cpp:
(JSC::MacroAssembler::probe):
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::trustedImm32FromPtr): Deleted.
* assembler/MacroAssemblerARM64.cpp:
(JSC::MacroAssembler::probe):
(JSC::arm64ProbeError): Deleted.
* assembler/MacroAssemblerARMv7.cpp:
(JSC::MacroAssembler::probe):
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::armV7Condition):
(JSC::MacroAssemblerARMv7::trustedImm32FromPtr): Deleted.
* assembler/MacroAssemblerPrinter.cpp:
(JSC::Printer::printCallback):
* assembler/MacroAssemblerPrinter.h:
* assembler/MacroAssemblerX86Common.cpp:
(JSC::ctiMasmProbeTrampoline):
(JSC::MacroAssembler::probe):
* assembler/Printer.h:
(JSC::Printer::Context::Context):
* assembler/ProbeContext.cpp: Added.
(JSC::Probe::executeProbe):
(JSC::Probe::handleProbeStackInitialization):
(JSC::Probe::probeStateForContext):
* assembler/ProbeContext.h: Added.
(JSC::Probe::CPUState::gprName):
(JSC::Probe::CPUState::sprName):
(JSC::Probe::CPUState::fprName):
(JSC::Probe::CPUState::gpr):
(JSC::Probe::CPUState::spr):
(JSC::Probe::CPUState::fpr):
(JSC::Probe:: const):
(JSC::Probe::CPUState::fpr const):
(JSC::Probe::CPUState::pc):
(JSC::Probe::CPUState::fp):
(JSC::Probe::CPUState::sp):
(JSC::Probe::CPUState::pc const):
(JSC::Probe::CPUState::fp const):
(JSC::Probe::CPUState::sp const):
(JSC::Probe::Context::Context):
(JSC::Probe::Context::gpr):
(JSC::Probe::Context::spr):
(JSC::Probe::Context::fpr):
(JSC::Probe::Context::gprName):
(JSC::Probe::Context::sprName):
(JSC::Probe::Context::fprName):
(JSC::Probe::Context::pc):
(JSC::Probe::Context::fp):
(JSC::Probe::Context::sp):
(JSC::Probe::Context::stack):
(JSC::Probe::Context::hasWritesToFlush):
(JSC::Probe::Context::releaseStack):
* assembler/ProbeStack.cpp: Added.
(JSC::Probe::Page::Page):
(JSC::Probe::Page::flushWrites):
(JSC::Probe::Stack::Stack):
(JSC::Probe::Stack::hasWritesToFlush):
(JSC::Probe::Stack::flushWrites):
(JSC::Probe::Stack::ensurePageFor):
* assembler/ProbeStack.h: Added.
(JSC::Probe::Page::baseAddressFor):
(JSC::Probe::Page::chunkAddressFor):
(JSC::Probe::Page::baseAddress):
(JSC::Probe::Page::get):
(JSC::Probe::Page::set):
(JSC::Probe::Page::hasWritesToFlush const):
(JSC::Probe::Page::flushWritesIfNeeded):
(JSC::Probe::Page::dirtyBitFor):
(JSC::Probe::Page::physicalAddressFor):
(JSC::Probe::Stack::Stack):
(JSC::Probe::Stack::lowWatermark):
(JSC::Probe::Stack::get):
(JSC::Probe::Stack::set):
(JSC::Probe::Stack::newStackPointer const):
(JSC::Probe::Stack::setNewStackPointer):
(JSC::Probe::Stack::isValid):
(JSC::Probe::Stack::pageFor):
* assembler/testmasm.cpp:
(JSC::testProbeReadsArgumentRegisters):
(JSC::testProbeWritesArgumentRegisters):
(JSC::testProbePreservesGPRS):
(JSC::testProbeModifiesStackPointer):
(JSC::testProbeModifiesStackPointerToInsideProbeStateOnStack):
(JSC::testProbeModifiesStackPointerToNBytesBelowSP):
(JSC::testProbeModifiesProgramCounter):
(JSC::testProbeModifiesStackValues):
(JSC::run):
(): Deleted.
(JSC::fillStack): Deleted.
(JSC::testProbeModifiesStackWithCallback): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoSimplify calls to LoaderStrategy::startPingLoad()
cdumez@apple.com [Sun, 20 Aug 2017 23:11:40 +0000 (23:11 +0000)]
Simplify calls to LoaderStrategy::startPingLoad()
https://bugs.webkit.org/show_bug.cgi?id=175756

Reviewed by Sam Weinig.

Source/WebCore:

Simplify calls to LoaderStrategy::startPingLoad() by passing the Frame to it
and let its implementation gets what it needs from the frame. This reduces
the number of parameters to startPingLoad() and is more easily extensible.

* dom/Document.h:
* loader/LoaderStrategy.h:
* loader/PingLoader.cpp:
(WebCore::PingLoader::loadImage):
(WebCore::PingLoader::sendPing):
(WebCore::PingLoader::sendViolationReport):
(WebCore::PingLoader::startPingLoad):
* loader/PingLoader.h:
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::load):

Source/WebKit:

* WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::WebLoaderStrategy::startPingLoad):
* WebProcess/Network/WebLoaderStrategy.h:

Source/WebKitLegacy:

* WebCoreSupport/WebResourceLoadScheduler.cpp:
(WebResourceLoadScheduler::startPingLoad):
* WebCoreSupport/WebResourceLoadScheduler.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoFactor :before/:after render tree mutations into a RenderTreeUpdater helper class
antti@apple.com [Sun, 20 Aug 2017 09:42:09 +0000 (09:42 +0000)]
Factor :before/:after render tree mutations into a RenderTreeUpdater helper class
https://bugs.webkit.org/show_bug.cgi?id=175752

Reviewed by Andreas Kling.

Move code that constructs generated content renderers out from PseudoElement.
Also refactor the related code from RenderTreeUpdater main class into
RenderTreeUpdater::GeneratedContent helper class.

* WebCore.xcodeproj/project.pbxproj:
* dom/PseudoElement.cpp:
(WebCore::PseudoElement::resolveCustomStyle): Deleted.

    Not needed anymore.

(WebCore::PseudoElement::didAttachRenderers): Deleted.

    Moves to createContentRenderers in GeneratedContent.

(WebCore::PseudoElement::didRecalcStyle): Deleted.

    Moves to updateStyleForContentRenderers in GeneratedContent.

* dom/PseudoElement.h:
* style/RenderTreeUpdater.cpp:
(WebCore::RenderTreeUpdater::RenderTreeUpdater):
(WebCore::RenderTreeUpdater::~RenderTreeUpdater):
(WebCore::RenderTreeUpdater::commit):
(WebCore::RenderTreeUpdater::updateBeforeDescendants):
(WebCore::RenderTreeUpdater::updateAfterDescendants):
(WebCore::needsPseudoElement): Deleted.
(WebCore::RenderTreeUpdater::updateBeforeOrAfterPseudoElement): Deleted.
(WebCore::RenderTreeUpdater::updateQuotesUpTo): Deleted.

    Quotes and other :before/:after support moves to GeneratedContent helpwe.

* style/RenderTreeUpdater.h:
(WebCore::RenderTreeUpdater::generatedContent):
* style/RenderTreeUpdaterGeneratedContent.cpp: Added.
(WebCore::RenderTreeUpdater::GeneratedContent::GeneratedContent):
(WebCore::RenderTreeUpdater::GeneratedContent::updateBeforePseudoElement):
(WebCore::RenderTreeUpdater::GeneratedContent::updateAfterPseudoElement):
(WebCore::RenderTreeUpdater::GeneratedContent::updateRemainingQuotes):
(WebCore::RenderTreeUpdater::GeneratedContent::updateQuotesUpTo):
(WebCore::createContentRenderers):
(WebCore::updateStyleForContentRenderers):
(WebCore::RenderTreeUpdater::GeneratedContent::updatePseudoElement):
(WebCore::RenderTreeUpdater::GeneratedContent::needsPseudoElement):
* style/RenderTreeUpdaterGeneratedContent.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Payment Request] Add interface stubs
aestes@apple.com [Sun, 20 Aug 2017 02:11:33 +0000 (02:11 +0000)]
[Payment Request] Add interface stubs
https://bugs.webkit.org/show_bug.cgi?id=175730

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

* web-platform-tests/payment-request/allowpaymentrequest/active-document-cross-origin.https.sub-expected.txt:
* web-platform-tests/payment-request/allowpaymentrequest/active-document-same-origin.https-expected.txt:
* web-platform-tests/payment-request/allowpaymentrequest/allowpaymentrequest-attribute-same-origin-bc-containers.https-expected.txt:
* web-platform-tests/payment-request/allowpaymentrequest/basic.https-expected.txt:
* web-platform-tests/payment-request/allowpaymentrequest/no-attribute-same-origin-bc-containers.https-expected.txt:
* web-platform-tests/payment-request/historical.https-expected.txt:
* web-platform-tests/payment-request/interfaces.https-expected.txt:
* web-platform-tests/payment-request/payment-request-abort-method.https-expected.txt:
* web-platform-tests/payment-request/payment-request-constructor-crash.https-expected.txt:
* web-platform-tests/payment-request/payment-request-constructor.https-expected.txt:
* web-platform-tests/payment-request/payment-request-id.https-expected.txt:
* web-platform-tests/payment-request/payment-request-in-iframe-expected.txt:
* web-platform-tests/payment-request/payment-request-onshippingaddresschange-attribute.https-expected.txt:
* web-platform-tests/payment-request/payment-request-onshippingoptionchange-attribute.https-expected.txt:
* web-platform-tests/payment-request/payment-request-show-method.https-expected.txt:
* web-platform-tests/payment-request/payment-request-update-event-constructor.http-expected.txt:
* web-platform-tests/payment-request/payment-request-update-event-constructor.https-expected.txt:

Source/JavaScriptCore:

* runtime/CommonIdentifiers.h:

Source/WebCore:

* DerivedSources.make:
* Modules/paymentrequest/PaymentAddress.h: Added.
* Modules/paymentrequest/PaymentAddress.idl: Added.
* Modules/paymentrequest/PaymentComplete.h: Added.
* Modules/paymentrequest/PaymentComplete.idl: Added.
* Modules/paymentrequest/PaymentCurrencyAmount.h: Added.
* Modules/paymentrequest/PaymentCurrencyAmount.idl: Added.
* Modules/paymentrequest/PaymentDetailsBase.h: Added.
* Modules/paymentrequest/PaymentDetailsBase.idl: Added.
* Modules/paymentrequest/PaymentDetailsInit.h: Added.
* Modules/paymentrequest/PaymentDetailsInit.idl: Added.
* Modules/paymentrequest/PaymentDetailsModifier.h: Added.
* Modules/paymentrequest/PaymentDetailsModifier.idl: Added.
* Modules/paymentrequest/PaymentDetailsUpdate.h: Added.
* Modules/paymentrequest/PaymentDetailsUpdate.idl: Added.
* Modules/paymentrequest/PaymentItem.h: Added.
* Modules/paymentrequest/PaymentItem.idl: Added.
* Modules/paymentrequest/PaymentMethodData.h: Added.
* Modules/paymentrequest/PaymentMethodData.idl: Added.
* Modules/paymentrequest/PaymentOptions.h: Added.
* Modules/paymentrequest/PaymentOptions.idl: Added.
* Modules/paymentrequest/PaymentRequest.cpp: Added.
(WebCore::PaymentRequest::create):
(WebCore::PaymentRequest::PaymentRequest):
(WebCore::PaymentRequest::~PaymentRequest):
(WebCore::PaymentRequest::show):
(WebCore::PaymentRequest::abort):
(WebCore::PaymentRequest::canMakePayment):
* Modules/paymentrequest/PaymentRequest.h: Added.
* Modules/paymentrequest/PaymentRequest.idl: Added.
* Modules/paymentrequest/PaymentRequestUpdateEvent.cpp: Added.
(WebCore::PaymentRequestUpdateEvent::~PaymentRequestUpdateEvent):
(WebCore::PaymentRequestUpdateEvent::updateWith):
* Modules/paymentrequest/PaymentRequestUpdateEvent.h: Added.
* Modules/paymentrequest/PaymentRequestUpdateEvent.idl: Added.
* Modules/paymentrequest/PaymentRequestUpdateEventInit.h: Added.
* Modules/paymentrequest/PaymentRequestUpdateEventInit.idl: Added.
* Modules/paymentrequest/PaymentResponse.cpp: Added.
(WebCore::PaymentResponse::complete):
* Modules/paymentrequest/PaymentResponse.h: Added.
* Modules/paymentrequest/PaymentResponse.idl: Added.
* Modules/paymentrequest/PaymentShippingOption.h: Added.
* Modules/paymentrequest/PaymentShippingOption.idl: Added.
* Modules/paymentrequest/PaymentShippingType.h: Added.
* Modules/paymentrequest/PaymentShippingType.idl: Added.
* WebCore.xcodeproj/project.pbxproj:
* dom/EventNames.h:
* dom/EventNames.in:
* dom/EventTargetFactory.in:

LayoutTests:

* TestExpectations: Skipped payment-request tests.
* platform/ios-wk2/TestExpectations: Enabled payment-request tests on ios-wk2.
* platform/mac-wk2/TestExpectations: Ditto for mac-wk2.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[WebCrypto] Remove the KeyAlgorithm type hierarchy
commit-queue@webkit.org [Sat, 19 Aug 2017 17:28:59 +0000 (17:28 +0000)]
[WebCrypto] Remove the KeyAlgorithm type hierarchy
https://bugs.webkit.org/show_bug.cgi?id=175750

Patch by Sam Weinig <sam@webkit.org> on 2017-08-19
Reviewed by Chris Dumez.

Removes the unnecessary indirection that existed to generate a
KeyAlgorithm dictionary (or rather, one of its derived dictionaries)
for a CryptoKey. We were calling the virtual buildAlgorithm(), which
return a std::unique_ptr<KeyAlgorithm>, which we then casted to the
correct derived class and called dictionary() on. This can now be
simplified by making each CryptoKey derived class override a function
that returns the KeyAlgorithm variant.

* crypto/CryptoKey.cpp:
(WebCore::CryptoKey::algorithm const): Deleted.
* crypto/CryptoKey.h:
(WebCore::CryptoKey::extractable const):
(WebCore::KeyAlgorithm::~KeyAlgorithm): Deleted.
(WebCore::KeyAlgorithm::name const): Deleted.
(WebCore::KeyAlgorithm::KeyAlgorithm): Deleted.
* crypto/gcrypt/CryptoKeyRSAGCrypt.cpp:
(WebCore::CryptoKeyRSA::algorithm const):
(WebCore::CryptoKeyRSA::buildAlgorithm const): Deleted.
* crypto/keys/CryptoKeyAES.cpp:
(WebCore::CryptoKeyAES::algorithm const):
(WebCore::AesKeyAlgorithm::dictionary const): Deleted.
(WebCore::CryptoKeyAES::buildAlgorithm const): Deleted.
* crypto/keys/CryptoKeyAES.h:
* crypto/keys/CryptoKeyEC.cpp:
(WebCore::CryptoKeyEC::algorithm const):
(WebCore::EcKeyAlgorithm::dictionary const): Deleted.
(WebCore::CryptoKeyEC::buildAlgorithm const): Deleted.
* crypto/keys/CryptoKeyEC.h:
(WebCore::EcKeyAlgorithm::EcKeyAlgorithm): Deleted.
(WebCore::EcKeyAlgorithm::namedCurve const): Deleted.
* crypto/keys/CryptoKeyHMAC.cpp:
(WebCore::CryptoKeyHMAC::algorithm const):
(WebCore::HmacKeyAlgorithm::dictionary const): Deleted.
(WebCore::CryptoKeyHMAC::buildAlgorithm const): Deleted.
* crypto/keys/CryptoKeyHMAC.h:
* crypto/keys/CryptoKeyRSA.cpp:
(WebCore::RsaKeyAlgorithm::dictionary const): Deleted.
(WebCore::RsaHashedKeyAlgorithm::dictionary const): Deleted.
* crypto/keys/CryptoKeyRSA.h:
(WebCore::RsaKeyAlgorithm::RsaKeyAlgorithm): Deleted.
(WebCore::RsaKeyAlgorithm::modulusLength const): Deleted.
(WebCore::RsaKeyAlgorithm::publicExponent const): Deleted.
* crypto/keys/CryptoKeyRaw.cpp:
(WebCore::CryptoKeyRaw::algorithm const):
(WebCore::RawKeyAlgorithm::dictionary const): Deleted.
(WebCore::CryptoKeyRaw::buildAlgorithm const): Deleted.
* crypto/keys/CryptoKeyRaw.h:
(WebCore::RawKeyAlgorithm::RawKeyAlgorithm): Deleted.
* crypto/mac/CryptoKeyRSAMac.cpp:
(WebCore::CryptoKeyRSA::algorithm const):
(WebCore::CryptoKeyRSA::buildAlgorithm const): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Mac] Change uint8_t* to Vector<uint8_t> type in all crypto algorithm implementation
commit-queue@webkit.org [Sat, 19 Aug 2017 16:41:47 +0000 (16:41 +0000)]
[Mac] Change uint8_t* to Vector<uint8_t> type in all crypto algorithm implementation
https://bugs.webkit.org/show_bug.cgi?id=164939

Patch by Sam Weinig <sam@webkit.org> on 2017-08-19
Reviewed by Chris Dumez.

Address FIXMEs, replacing uint8_t*/size_t parameters with Vector<uint8_t>&.

* crypto/mac/CryptoAlgorithmAES_CBCMac.cpp:
(WebCore::transformAES_CBC):
(WebCore::CryptoAlgorithmAES_CBC::platformEncrypt):
(WebCore::CryptoAlgorithmAES_CBC::platformDecrypt):
* crypto/mac/CryptoAlgorithmAES_KWMac.cpp:
(WebCore::wrapKeyAES_KW):
(WebCore::unwrapKeyAES_KW):
(WebCore::CryptoAlgorithmAES_KW::platformWrapKey):
(WebCore::CryptoAlgorithmAES_KW::platformUnwrapKey):
* crypto/mac/CryptoAlgorithmHMACMac.cpp:
(WebCore::calculateSignature):
(WebCore::CryptoAlgorithmHMAC::platformSign):
(WebCore::CryptoAlgorithmHMAC::platformVerify):
* crypto/mac/CryptoAlgorithmRSAES_PKCS1_v1_5Mac.cpp:
(WebCore::encryptRSAES_PKCS1_v1_5):
(WebCore::decryptRSAES_PKCS1_v1_5):
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformEncrypt):
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformDecrypt):
* crypto/mac/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:
(WebCore::signRSASSA_PKCS1_v1_5):
(WebCore::verifyRSASSA_PKCS1_v1_5):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformSign):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformVerify):
* crypto/mac/CryptoAlgorithmRSA_OAEPMac.cpp:
(WebCore::encryptRSA_OAEP):
(WebCore::decryptRSA_OAEP):
(WebCore::CryptoAlgorithmRSA_OAEP::platformEncrypt):
(WebCore::CryptoAlgorithmRSA_OAEP::platformDecrypt):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[iOS WK2] Add a version of DataInteractionTests.ExternalSourceAttributedStringToConte...
wenson_hsieh@apple.com [Sat, 19 Aug 2017 08:46:16 +0000 (08:46 +0000)]
[iOS WK2] Add a version of DataInteractionTests.ExternalSourceAttributedStringToContentEditable that doesn't hit a debug assertion
https://bugs.webkit.org/show_bug.cgi?id=175509
<rdar://problem/33728169>

Reviewed by Ryosuke Niwa.

Removes ExternalSourceAttributedStringToContentEditable and adds
ExternalSourceColoredAttributedStringToContentEditable, which tests dropping an attributed string with colored
text instead of a bold attributed string of system font. Due to a recent change in behavior in UIKit, the
original test (which this patch renames to ExternalSourceBoldSystemAttributedStringToContentEditable) hits a
debug assertion when dropping text of system bold font. Since the original intent of this test was to verify
that the attributed string UTI can be accepted in richly contenteditable areas, it suffices to check that some
other style attribute, such as color, carries over from the NSAttributedString to the DOM.

Also marks ExternalSourceBoldSystemAttributedStringToContentEditable as disabled for the time being.

* TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoForbid setDragImage after dragstart
rniwa@webkit.org [Sat, 19 Aug 2017 06:40:30 +0000 (06:40 +0000)]
Forbid setDragImage after dragstart
https://bugs.webkit.org/show_bug.cgi?id=175751

Reviewed by Wenson Hsieh.

Removed the code to allow setting the drag mage after dragstart had happened.

The feature was apparently used in Mac WebKit1 port but using it today causes the drag image
to disapepar while the user is moving the mouse cursor and being drawn once it's stopped
and results in the contionus flickering of the drag image.

The feaure was never supported in WebKit2 and doesn't match the HTML5 specification:
https://html.spec.whatwg.org/multipage/dnd.html#concept-dnd-rw
https://html.spec.whatwg.org/multipage/dnd.html#dom-datatransfer-setdragimage
or the behaviors of other browsers such as Chrome and Firefox.

No new tests. This patch simply removes code.

* dom/DataTransfer.cpp:
(WebCore::DataTransfer::setDragImage):
(WebCore::DataTransfer::canSetDragImage const): Deleted.
* dom/DataTransfer.h:
(WebCore::DataTransfer::makeDragImageWritable): Deleted.
* page/EventHandler.cpp:
(WebCore::EventHandler::handleDrag):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoREGRESSION(r219640): Speedometer no longer runs on Safari 7
rniwa@webkit.org [Sat, 19 Aug 2017 03:05:57 +0000 (03:05 +0000)]
REGRESSION(r219640): Speedometer no longer runs on Safari 7
https://bugs.webkit.org/show_bug.cgi?id=175749

Reviewed by Joseph Pecoraro.

PerformanceTests:

Use regular string instead of template literal to make the script compatible with older versions of Safari.

* Speedometer/resources/benchmark-runner.js:
(BenchmarkRunner.prototype._runTest):

Websites/browserbench.org:

Fix the bug on browserbench.org.

* Speedometer/resources/benchmark-runner.js:
(BenchmarkRunner.prototype._runTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[WebCrypto] Get rid of CryptoKeyData class and all its subclasses
weinig@apple.com [Sat, 19 Aug 2017 01:40:54 +0000 (01:40 +0000)]
[WebCrypto] Get rid of CryptoKeyData class and all its subclasses
https://bugs.webkit.org/show_bug.cgi?id=169806

Reviewed by Chris Dumez.

- Replaces the CryptoKeyData type hierarchy

    CryptoKeyData
      - CryptoKeyDataOctetSequence
      - CryptoKeyDataRSAComponents

  with the renamed CryptoKeyRSAComponents.

- Removes pure virtual exportData function on CryptoKey, and all
  the implementations except the one on CryptoKeyRSA, which now is
  non-virtual, and returns a CryptoKeyRSAComponents. Update the one
  external caller, SerializedScriptValue, to handle this.

* CMakeLists.txt:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/SerializedScriptValue.cpp:
* crypto/CryptoAlgorithm.h:
* crypto/CryptoKey.h:
* crypto/CryptoKeyData.h: Removed.
* crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:
* crypto/algorithms/CryptoAlgorithmAES_KW.cpp:
* crypto/algorithms/CryptoAlgorithmHMAC.cpp:
* crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.cpp:
* crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp:
* crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp:
* crypto/gcrypt/CryptoKeyRSAGCrypt.cpp:
(WebCore::CryptoKeyRSA::create):
(WebCore::CryptoKeyRSA::exportData const):
* crypto/keys/CryptoKeyAES.cpp:
(WebCore::CryptoKeyAES::exportData const): Deleted.
* crypto/keys/CryptoKeyAES.h:
* crypto/keys/CryptoKeyDataOctetSequence.cpp: Removed.
* crypto/keys/CryptoKeyDataOctetSequence.h: Removed.
* crypto/keys/CryptoKeyDataRSAComponents.cpp: Removed.
* crypto/keys/CryptoKeyDataRSAComponents.h: Removed.
* crypto/keys/CryptoKeyEC.cpp:
(WebCore::CryptoKeyEC::exportData const): Deleted.
* crypto/keys/CryptoKeyEC.h:
* crypto/keys/CryptoKeyHMAC.cpp:
(WebCore::CryptoKeyHMAC::exportData const): Deleted.
* crypto/keys/CryptoKeyHMAC.h:
* crypto/keys/CryptoKeyRSA.cpp:
(WebCore::CryptoKeyRSA::importJwk):
(WebCore::CryptoKeyRSA::exportJwk const):
* crypto/keys/CryptoKeyRSA.h:
* crypto/keys/CryptoKeyRSAComponents.cpp: Copied from crypto/keys/CryptoKeyDataRSAComponents.cpp.
(WebCore::CryptoKeyRSAComponents::CryptoKeyRSAComponents):
(WebCore::CryptoKeyRSAComponents::~CryptoKeyRSAComponents):
(WebCore::CryptoKeyDataRSAComponents::CryptoKeyDataRSAComponents): Deleted.
(WebCore::CryptoKeyDataRSAComponents::~CryptoKeyDataRSAComponents): Deleted.
* crypto/keys/CryptoKeyRSAComponents.h: Copied from crypto/keys/CryptoKeyDataRSAComponents.h.
(WebCore::CryptoKeyRSAComponents::createPublic):
(WebCore::CryptoKeyRSAComponents::createPrivate):
(WebCore::CryptoKeyRSAComponents::createPrivateWithAdditionalData):
* crypto/keys/CryptoKeyRaw.cpp:
(WebCore::CryptoKeyRaw::exportData const): Deleted.
* crypto/keys/CryptoKeyRaw.h:
* crypto/mac/CryptoKeyRSAMac.cpp:
(WebCore::getPrivateKeyComponents):
(WebCore::CryptoKeyRSA::create):
(WebCore::CryptoKeyRSA::exportData const):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Cache API] Add support for being loaded responses
commit-queue@webkit.org [Sat, 19 Aug 2017 01:29:50 +0000 (01:29 +0000)]
[Cache API] Add support for being loaded responses
https://bugs.webkit.org/show_bug.cgi?id=175732

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-18
Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

* web-platform-tests/service-workers/cache-storage/common.https-expected.txt:

Source/WebCore:

Covered by existing and rebased tests.

Introducing a callback-based method to consume the body when the load is finished.
Using that new method in Cache::put and calling batchPutOperation when the load is finished.

Fixing the case of a fetch response being cloned, in which case its body should be marked as ReadableStream.

* Modules/cache/Cache.cpp:
(WebCore::Cache::put): Changing order of checks to reduce test flakiness risks as there is not yet support for putting responses with ReadableStream.
(WebCore::toConnectionRecord):
(WebCore::Cache::batchPutOperation):
* Modules/cache/Cache.h:
* Modules/fetch/FetchBody.cpp:
(WebCore::FetchBody::readableStreamBody): Deleted.
* Modules/fetch/FetchBody.h:
(WebCore::FetchBody::loadingBody):
(WebCore::FetchBody::setAsReadableStream):
* Modules/fetch/FetchResponse.cpp:
(WebCore::FetchResponse::BodyLoader::didSucceed):
(WebCore::FetchResponse::BodyLoader::didFail):
(WebCore::FetchResponse::consumeBody):
(WebCore::FetchResponse::consumeBodyWhenLoaded):
* Modules/fetch/FetchResponse.h:

LayoutTests:

* TestExpectations: Removing some flaky test expectations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, rolling out r220938.
ryanhaddad@apple.com [Sat, 19 Aug 2017 00:30:59 +0000 (00:30 +0000)]
Unreviewed, rolling out r220938.

The API tests added with this change are failing.

Reverted changeset:

"Add WTFLogChannel level to allow runtime log filtering"
https://bugs.webkit.org/show_bug.cgi?id=175731
http://trac.webkit.org/changeset/220938

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Beacon] Improve error reporting
cdumez@apple.com [Sat, 19 Aug 2017 00:27:59 +0000 (00:27 +0000)]
[Beacon] Improve error reporting
https://bugs.webkit.org/show_bug.cgi?id=175723

Reviewed by Darin Adler.

Source/WebCore:

Have Ping loads such as beacons report errors via their completion handler.
The Beacon API is using this error to log a console message when beacon loads
fail, provided that the page is still alive.

Test: http/wpt/beacon/beacon-async-error-logging.html

* Modules/beacon/NavigatorBeacon.cpp:
(WebCore::NavigatorBeacon::NavigatorBeacon):
(WebCore::NavigatorBeacon::~NavigatorBeacon):
(WebCore::NavigatorBeacon::from):
(WebCore::NavigatorBeacon::supplementName):
(WebCore::NavigatorBeacon::notifyFinished):
(WebCore::NavigatorBeacon::logError):
(WebCore::NavigatorBeacon::sendBeacon):
* Modules/beacon/NavigatorBeacon.h:
* loader/LoaderStrategy.h:
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::load):
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestBeaconResource):
* loader/cache/CachedResourceLoader.h:
* platform/network/PingHandle.h:

Source/WebKit:

Have Ping loads such as beacons report errors via their completion handler.
The Beacon API is using this error to log a console message when beacon loads
fail, provided that the page is still alive.

* NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::loadPing):
(WebKit::NetworkConnectionToWebProcess::didFinishPingLoad):
* NetworkProcess/NetworkConnectionToWebProcess.h:
* NetworkProcess/PingLoad.cpp:
(WebKit::PingLoad::~PingLoad):
(WebKit::PingLoad::didFinish):
(WebKit::PingLoad::willPerformHTTPRedirection):
(WebKit::PingLoad::didReceiveChallenge):
(WebKit::PingLoad::didReceiveResponseNetworkSession):
(WebKit::PingLoad::didCompleteWithError):
(WebKit::PingLoad::wasBlocked):
(WebKit::PingLoad::cannotShowURL):
(WebKit::PingLoad::timeoutTimerFired):
(WebKit::PingLoad::currentRequest const):
(WebKit::PingLoad::makeCrossOriginAccessRequestWithPreflight):
* NetworkProcess/PingLoad.h:
* WebProcess/Network/NetworkProcessConnection.cpp:
(WebKit::NetworkProcessConnection::didFinishPingLoad):
* WebProcess/Network/NetworkProcessConnection.h:
* WebProcess/Network/NetworkProcessConnection.messages.in:
* WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::WebLoaderStrategy::networkProcessCrashed):
(WebKit::WebLoaderStrategy::startPingLoad):
(WebKit::WebLoaderStrategy::didFinishPingLoad):
* WebProcess/Network/WebLoaderStrategy.h:

Source/WebKitLegacy:

Have Ping loads such as beacons report errors via their completion handler.
The Beacon API is using this error to log a console message when beacon loads
fail, provided that the page is still alive.

* WebCoreSupport/WebResourceLoadScheduler.cpp:
(WebResourceLoadScheduler::startPingLoad):
* WebCoreSupport/WebResourceLoadScheduler.h:

LayoutTests:

Add layout test coverage.

* http/wpt/beacon/beacon-async-error-logging-expected.txt: Added.
* http/wpt/beacon/beacon-async-error-logging.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, change my email.
webkit@devinrousso.com [Sat, 19 Aug 2017 00:27:29 +0000 (00:27 +0000)]
Unreviewed, change my email.

* Scripts/webkitpy/common/config/contributors.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoMarked fast/scrolling/arrow-key-scroll-in-rtl-document.html as flaky.
jlewis3@apple.com [Sat, 19 Aug 2017 00:20:21 +0000 (00:20 +0000)]
Marked fast/scrolling/arrow-key-scroll-in-rtl-document.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=173779

Unreviewed Test gardening.

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoSkip flaky JSC test microbenchmarks/generator-with-several-types.js.
ryanhaddad@apple.com [Sat, 19 Aug 2017 00:03:20 +0000 (00:03 +0000)]
Skip flaky JSC test microbenchmarks/generator-with-several-types.js.
https://bugs.webkit.org/show_bug.cgi?id=172543

Unreviewed test gardening.

* microbenchmarks/generator-with-several-types.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoFix leak-checking for iOS Simulators
jbedard@apple.com [Fri, 18 Aug 2017 23:26:40 +0000 (23:26 +0000)]
Fix leak-checking for iOS Simulators
https://bugs.webkit.org/show_bug.cgi?id=175735

Reviewed by Darin Adler.

If the leak checking currently occurs in ServerProcess, we can’t check leaks on an iOS
Simulator (or device) because the process will have already been killed by the time we
check for leaks. Duplicate leak-checking code and share code waiting on a process to stop.

* Scripts/webkitpy/port/server_process.py:
(ServerProcess.stop): Move code waiting for the process to close to _wait_for_stop(...).
(ServerProcess._wait_for_stop): Share code shutting down a process between ServerProcess
and SimulatorProcess.
* Scripts/webkitpy/port/simulator_process.py:
(SimulatorProcess.stop): Before closing the process, check for leaks.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRemove the deprecated WebKitSubtleCrypto interface
weinig@apple.com [Fri, 18 Aug 2017 23:24:59 +0000 (23:24 +0000)]
Remove the deprecated WebKitSubtleCrypto interface
https://bugs.webkit.org/show_bug.cgi?id=164938
<rdar://problem/29894563>

Reviewed by Chris Dumez.

Source/WebCore:

Remove WebKitSubtleCrypto and all of its helper classes / functionality.

* CMakeLists.txt:
* DerivedSources.cpp:
* DerivedSources.make:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSCryptoAlgorithmDictionary.cpp: Removed.
* bindings/js/JSCryptoAlgorithmDictionary.h: Removed.
* bindings/js/JSCryptoKeySerializationJWK.cpp: Removed.
* bindings/js/JSCryptoKeySerializationJWK.h: Removed.
* bindings/js/JSCryptoOperationData.cpp: Removed.
* bindings/js/JSCryptoOperationData.h: Removed.
* bindings/js/JSWebKitSubtleCryptoCustom.cpp: Removed.
* crypto/CryptoAlgorithm.cpp:
(WebCore::CryptoAlgorithm::deriveKey): Deleted.
(WebCore::CryptoAlgorithm::encryptForWrapKey): Deleted.
(WebCore::CryptoAlgorithm::decryptForUnwrapKey): Deleted.
* crypto/CryptoAlgorithm.h:
* crypto/CryptoAlgorithmParametersDeprecated.h: Removed.
* crypto/CryptoKeySerialization.h: Removed.
* crypto/WebKitSubtleCrypto.cpp: Removed.
* crypto/WebKitSubtleCrypto.h: Removed.
* crypto/WebKitSubtleCrypto.idl: Removed.
* crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:
(WebCore::CryptoAlgorithmAES_CBC::keyAlgorithmMatches const): Deleted.
* crypto/algorithms/CryptoAlgorithmAES_CBC.h:
* crypto/algorithms/CryptoAlgorithmAES_KW.cpp:
(WebCore::CryptoAlgorithmAES_KW::encryptForWrapKey): Deleted.
(WebCore::CryptoAlgorithmAES_KW::decryptForUnwrapKey): Deleted.
* crypto/algorithms/CryptoAlgorithmAES_KW.h:
* crypto/algorithms/CryptoAlgorithmHMAC.cpp:
(WebCore::CryptoAlgorithmHMAC::keyAlgorithmMatches const): Deleted.
* crypto/algorithms/CryptoAlgorithmHMAC.h:
* crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.cpp:
* crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.h:
* crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp:
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::keyAlgorithmMatches const): Deleted.
* crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.h:
* crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp:
(WebCore::CryptoAlgorithmRSA_OAEP::keyAlgorithmMatches const): Deleted.
* crypto/algorithms/CryptoAlgorithmRSA_OAEP.h:
* crypto/algorithms/CryptoAlgorithmSHA1.cpp:
* crypto/algorithms/CryptoAlgorithmSHA1.h:
* crypto/algorithms/CryptoAlgorithmSHA224.cpp:
* crypto/algorithms/CryptoAlgorithmSHA224.h:
* crypto/algorithms/CryptoAlgorithmSHA256.cpp:
* crypto/algorithms/CryptoAlgorithmSHA256.h:
* crypto/algorithms/CryptoAlgorithmSHA384.cpp:
* crypto/algorithms/CryptoAlgorithmSHA384.h:
* crypto/algorithms/CryptoAlgorithmSHA512.cpp:
* crypto/algorithms/CryptoAlgorithmSHA512.h:
* crypto/gcrypt/CryptoAlgorithmAES_CBCGCrypt.cpp:
* crypto/gcrypt/CryptoAlgorithmAES_KWGCrypt.cpp:
(WebCore::CryptoAlgorithmAES_KW::platformEncrypt): Deleted.
(WebCore::CryptoAlgorithmAES_KW::platformDecrypt): Deleted.
* crypto/gcrypt/CryptoAlgorithmHMACGCrypt.cpp:
* crypto/gcrypt/CryptoAlgorithmRSAES_PKCS1_v1_5GCrypt.cpp:
* crypto/gcrypt/CryptoAlgorithmRSASSA_PKCS1_v1_5GCrypt.cpp:
* crypto/gcrypt/CryptoAlgorithmRSA_OAEPGCrypt.cpp:
* crypto/keys/CryptoKeySerializationRaw.cpp: Removed.
* crypto/keys/CryptoKeySerializationRaw.h: Removed.
* crypto/mac/CryptoAlgorithmAES_CBCMac.cpp:
* crypto/mac/CryptoAlgorithmAES_KWMac.cpp:
(WebCore::CryptoAlgorithmAES_KW::platformEncrypt): Deleted.
(WebCore::CryptoAlgorithmAES_KW::platformDecrypt): Deleted.
* crypto/mac/CryptoAlgorithmHMACMac.cpp:
* crypto/mac/CryptoAlgorithmRSAES_PKCS1_v1_5Mac.cpp:
* crypto/mac/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:
* crypto/mac/CryptoAlgorithmRSA_OAEPMac.cpp:
* crypto/parameters/CryptoAlgorithmAesCbcParamsDeprecated.h: Removed.
* crypto/parameters/CryptoAlgorithmAesKeyGenParamsDeprecated.h: Removed.
* crypto/parameters/CryptoAlgorithmHmacKeyParamsDeprecated.h: Removed.
* crypto/parameters/CryptoAlgorithmHmacParamsDeprecated.h: Removed.
* crypto/parameters/CryptoAlgorithmRsaKeyGenParamsDeprecated.h: Removed.
* crypto/parameters/CryptoAlgorithmRsaKeyParamsWithHashDeprecated.h: Removed.
* crypto/parameters/CryptoAlgorithmRsaOaepParamsDeprecated.h: Removed.
* crypto/parameters/CryptoAlgorithmRsaSsaParamsDeprecated.h: Removed.
* features.json:
* page/Crypto.cpp:
* page/Crypto.h:
* page/Crypto.idl:

LayoutTests:

* crypto/webkitSubtle: Removed.
* crypto/webkitSubtle/aes-cbc-192-encrypt-decrypt-expected.txt: Removed.
* crypto/webkitSubtle/aes-cbc-192-encrypt-decrypt.html: Removed.
* crypto/webkitSubtle/aes-cbc-256-encrypt-decrypt-expected.txt: Removed.
* crypto/webkitSubtle/aes-cbc-256-encrypt-decrypt.html: Removed.
* crypto/webkitSubtle/aes-cbc-encrypt-decrypt-expected.txt: Removed.
* crypto/webkitSubtle/aes-cbc-encrypt-decrypt-with-padding-expected.txt: Removed.
* crypto/webkitSubtle/aes-cbc-encrypt-decrypt-with-padding.html: Removed.
* crypto/webkitSubtle/aes-cbc-encrypt-decrypt.html: Removed.
* crypto/webkitSubtle/aes-cbc-generate-key-expected.txt: Removed.
* crypto/webkitSubtle/aes-cbc-generate-key.html: Removed.
* crypto/webkitSubtle/aes-cbc-import-jwk-expected.txt: Removed.
* crypto/webkitSubtle/aes-cbc-import-jwk.html: Removed.
* crypto/webkitSubtle/aes-cbc-invalid-length-expected.txt: Removed.
* crypto/webkitSubtle/aes-cbc-invalid-length.html: Removed.
* crypto/webkitSubtle/aes-cbc-unwrap-failure-expected.txt: Removed.
* crypto/webkitSubtle/aes-cbc-unwrap-failure.html: Removed.
* crypto/webkitSubtle/aes-cbc-unwrap-rsa-expected.txt: Removed.
* crypto/webkitSubtle/aes-cbc-unwrap-rsa.html: Removed.
* crypto/webkitSubtle/aes-cbc-wrap-rsa-expected.txt: Removed.
* crypto/webkitSubtle/aes-cbc-wrap-rsa-non-extractable-expected.txt: Removed.
* crypto/webkitSubtle/aes-cbc-wrap-rsa-non-extractable.html: Removed.
* crypto/webkitSubtle/aes-cbc-wrap-rsa.html: Removed.
* crypto/webkitSubtle/aes-cbc-wrong-key-class-expected.txt: Removed.
* crypto/webkitSubtle/aes-cbc-wrong-key-class.html: Removed.
* crypto/webkitSubtle/aes-export-key-expected.txt: Removed.
* crypto/webkitSubtle/aes-export-key.html: Removed.
* crypto/webkitSubtle/aes-kw-key-manipulation-expected.txt: Removed.
* crypto/webkitSubtle/aes-kw-key-manipulation.html: Removed.
* crypto/webkitSubtle/aes-kw-wrap-unwrap-aes-expected.txt: Removed.
* crypto/webkitSubtle/aes-kw-wrap-unwrap-aes.html: Removed.
* crypto/webkitSubtle/aes-postMessage-expected.txt: Removed.
* crypto/webkitSubtle/aes-postMessage.html: Removed.
* crypto/webkitSubtle/argument-conversion-expected.txt: Removed.
* crypto/webkitSubtle/argument-conversion.html: Removed.
* crypto/webkitSubtle/array-buffer-view-offset-expected.txt: Removed.
* crypto/webkitSubtle/array-buffer-view-offset.html: Removed.
* crypto/webkitSubtle/disallowed-in-worker-expected.txt: Removed.
* crypto/webkitSubtle/disallowed-in-worker.html: Removed.
* crypto/webkitSubtle/gc-2-expected.txt: Removed.
* crypto/webkitSubtle/gc-2.html: Removed.
* crypto/webkitSubtle/gc-3-expected.txt: Removed.
* crypto/webkitSubtle/gc-3.html: Removed.
* crypto/webkitSubtle/gc-expected.txt: Removed.
* crypto/webkitSubtle/gc.html: Removed.
* crypto/webkitSubtle/hmac-check-algorithm-expected.txt: Removed.
* crypto/webkitSubtle/hmac-check-algorithm.html: Removed.
* crypto/webkitSubtle/hmac-export-key-expected.txt: Removed.
* crypto/webkitSubtle/hmac-export-key.html: Removed.
* crypto/webkitSubtle/hmac-generate-key-expected.txt: Removed.
* crypto/webkitSubtle/hmac-generate-key.html: Removed.
* crypto/webkitSubtle/hmac-import-jwk-expected.txt: Removed.
* crypto/webkitSubtle/hmac-import-jwk.html: Removed.
* crypto/webkitSubtle/hmac-postMessage-expected.txt: Removed.
* crypto/webkitSubtle/hmac-postMessage.html: Removed.
* crypto/webkitSubtle/hmac-sign-verify-empty-key-expected.txt: Removed.
* crypto/webkitSubtle/hmac-sign-verify-empty-key.html: Removed.
* crypto/webkitSubtle/hmac-sign-verify-expected.txt: Removed.
* crypto/webkitSubtle/hmac-sign-verify.html: Removed.
* crypto/webkitSubtle/import-export-raw-key-leak-expected.txt: Removed.
* crypto/webkitSubtle/import-export-raw-key-leak.html: Removed.
* crypto/webkitSubtle/import-jwk-expected.txt: Removed.
* crypto/webkitSubtle/import-jwk.html: Removed.
* crypto/webkitSubtle/jwk-export-use-values-expected.txt: Removed.
* crypto/webkitSubtle/jwk-export-use-values.html: Removed.
* crypto/webkitSubtle/jwk-import-use-values-expected.txt: Removed.
* crypto/webkitSubtle/jwk-import-use-values.html: Removed.
* crypto/webkitSubtle/resources: Removed.
* crypto/webkitSubtle/resources/disallowed-in-worker.js: Removed.
* crypto/webkitSubtle/resources/rsa-indexeddb-non-exportable.js: Removed.
* crypto/webkitSubtle/resources/rsa-indexeddb.js: Removed.
* crypto/webkitSubtle/rsa-export-generated-keys-expected.txt: Removed.
* crypto/webkitSubtle/rsa-export-generated-keys.html: Removed.
* crypto/webkitSubtle/rsa-export-key-expected.txt: Removed.
* crypto/webkitSubtle/rsa-export-key.html: Removed.
* crypto/webkitSubtle/rsa-export-private-key-expected.txt: Removed.
* crypto/webkitSubtle/rsa-export-private-key.html: Removed.
* crypto/webkitSubtle/rsa-indexeddb-expected.txt: Removed.
* crypto/webkitSubtle/rsa-indexeddb-non-exportable-expected.txt: Removed.
* crypto/webkitSubtle/rsa-indexeddb-non-exportable-private-expected.txt: Removed.
* crypto/webkitSubtle/rsa-indexeddb-non-exportable-private.html: Removed.
* crypto/webkitSubtle/rsa-indexeddb-non-exportable.html: Removed.
* crypto/webkitSubtle/rsa-indexeddb-private-expected.txt: Removed.
* crypto/webkitSubtle/rsa-indexeddb-private.html: Removed.
* crypto/webkitSubtle/rsa-indexeddb.html: Removed.
* crypto/webkitSubtle/rsa-oaep-generate-non-extractable-key-expected.txt: Removed.
* crypto/webkitSubtle/rsa-oaep-generate-non-extractable-key.html: Removed.
* crypto/webkitSubtle/rsa-oaep-key-manipulation-expected.txt: Removed.
* crypto/webkitSubtle/rsa-oaep-key-manipulation.html: Removed.
* crypto/webkitSubtle/rsa-oaep-plaintext-length-expected.txt: Removed.
* crypto/webkitSubtle/rsa-oaep-plaintext-length.html: Removed.
* crypto/webkitSubtle/rsa-oaep-wrap-unwrap-aes-expected.txt: Removed.
* crypto/webkitSubtle/rsa-oaep-wrap-unwrap-aes.html: Removed.
* crypto/webkitSubtle/rsa-postMessage-expected.txt: Removed.
* crypto/webkitSubtle/rsa-postMessage.html: Removed.
* crypto/webkitSubtle/rsaes-pkcs1-v1_5-decrypt-expected.txt: Removed.
* crypto/webkitSubtle/rsaes-pkcs1-v1_5-decrypt.html: Removed.
* crypto/webkitSubtle/rsaes-pkcs1-v1_5-wrap-unwrap-aes-expected.txt: Removed.
* crypto/webkitSubtle/rsaes-pkcs1-v1_5-wrap-unwrap-aes.html: Removed.
* crypto/webkitSubtle/rsassa-pkcs1-v1_5-generate-key-expected.txt: Removed.
* crypto/webkitSubtle/rsassa-pkcs1-v1_5-generate-key-with-leading-zeroes-in-exponent-expected.txt: Removed.
* crypto/webkitSubtle/rsassa-pkcs1-v1_5-generate-key-with-leading-zeroes-in-exponent.html: Removed.
* crypto/webkitSubtle/rsassa-pkcs1-v1_5-generate-key.html: Removed.
* crypto/webkitSubtle/rsassa-pkcs1-v1_5-import-jwk-expected.txt: Removed.
* crypto/webkitSubtle/rsassa-pkcs1-v1_5-import-jwk-small-key-expected.txt: Removed.
* crypto/webkitSubtle/rsassa-pkcs1-v1_5-import-jwk-small-key.html: Removed.
* crypto/webkitSubtle/rsassa-pkcs1-v1_5-import-jwk.html: Removed.
* crypto/webkitSubtle/rsassa-pkcs1-v1_5-sign-verify-expected.txt: Removed.
* crypto/webkitSubtle/rsassa-pkcs1-v1_5-sign-verify.html: Removed.
* crypto/webkitSubtle/sha-1-expected.txt: Removed.
* crypto/webkitSubtle/sha-1.html: Removed.
* crypto/webkitSubtle/sha-224-expected.txt: Removed.
* crypto/webkitSubtle/sha-224.html: Removed.
* crypto/webkitSubtle/sha-256-expected.txt: Removed.
* crypto/webkitSubtle/sha-256.html: Removed.
* crypto/webkitSubtle/sha-384-expected.txt: Removed.
* crypto/webkitSubtle/sha-384.html: Removed.
* crypto/webkitSubtle/sha-512-expected.txt: Removed.
* crypto/webkitSubtle/sha-512.html: Removed.
* crypto/webkitSubtle/unimplemented-unwrap-crash-expected.txt: Removed.
* crypto/webkitSubtle/unimplemented-unwrap-crash.html: Removed.
* crypto/webkitSubtle/unwrapKey-check-usage-expected.txt: Removed.
* crypto/webkitSubtle/unwrapKey-check-usage.html: Removed.
* crypto/webkitSubtle/wrapKey-check-usage-expected.txt: Removed.
* crypto/webkitSubtle/wrapKey-check-usage.html: Removed.

    Remove webkitSubtleCrypto tests.

* fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt:

    Remove webkitSubtleCrypto deprecation warning that no longer happens.

* platform/ios-wk1/TestExpectations:
* platform/win/TestExpectations:
* platform/wpe/TestExpectations:

    Remove webkitSubtle tests from expectations files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRemove classic mode screen scale clamping
timothy_horton@apple.com [Fri, 18 Aug 2017 23:15:06 +0000 (23:15 +0000)]
Remove classic mode screen scale clamping
https://bugs.webkit.org/show_bug.cgi?id=175739
<rdar://problem/33894531>

Reviewed by Andy Estes.

* platform/ios/PlatformScreenIOS.mm:
(WebCore::screenScaleFactor):
This code is no longer needed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Curl] Improve multi-threaded networking
commit-queue@webkit.org [Fri, 18 Aug 2017 23:02:51 +0000 (23:02 +0000)]
[Curl] Improve multi-threaded networking
https://bugs.webkit.org/show_bug.cgi?id=175713

Patch by Daewoong Jang <daewoong.jang@navercorp.com> on 2017-08-18
Reviewed by Alex Christensen.

* platform/Curl.cmake:
* platform/network/ResourceHandleInternal.h:
(WebCore::ResourceHandleInternal::ResourceHandleInternal):
(WebCore::ResourceHandleInternal::m_failureTimer): Deleted.
* platform/network/curl/CurlCacheManager.cpp:
(WebCore::CurlCacheManager::didReceiveResponse):
* platform/network/curl/CurlDownload.cpp:
(WebCore::CurlDownload::init):
(WebCore::CurlDownload::start):
(WebCore::CurlDownload::cancel):
(WebCore::CurlDownload::retain):
(WebCore::CurlDownload::release):
(WebCore::CurlDownload::setupRequest):
(WebCore::CurlDownload::notifyFinish):
(WebCore::CurlDownload::notifyFail):
* platform/network/curl/CurlDownload.h:
* platform/network/curl/CurlJobManager.cpp:
(WebCore::CurlJobList::isEmpty const):
(WebCore::CurlJobList::startJobs):
(WebCore::CurlJobList::finishJobs):
(WebCore::CurlJobList::notifyResult):
(WebCore::CurlJobManager::add):
(WebCore::CurlJobManager::cancel):
(WebCore::CurlJobManager::callOnJobThread):
(WebCore::CurlJobManager::startThreadIfNeeded):
(WebCore::CurlJobManager::updateJobList):
(WebCore::CurlJobManager::workerThread):
(WebCore::CurlJobList::append): Deleted.
(WebCore::CurlJobList::cancel): Deleted.
(WebCore::CurlJobList::complete): Deleted.
(WebCore::CurlJobList::withJob): Deleted.
(WebCore::CurlJobList::withCurlHandle): Deleted.
(WebCore::CurlJob::invoke): Deleted.
(WebCore::CurlJobManager::updateJobs): Deleted.
* platform/network/curl/CurlJobManager.h:
(WebCore::CurlJob::CurlJob): Deleted.
(WebCore::CurlJob::~CurlJob): Deleted.
(WebCore::CurlJob::operator=): Deleted.
(WebCore::CurlJob::curlHandle const): Deleted.
(WebCore::CurlJob::ticket const): Deleted.
(WebCore::CurlJob::finished): Deleted.
(WebCore::CurlJob::error): Deleted.
(WebCore::CurlJob::cancel): Deleted.
(WebCore::CurlJobManager::isActiveJob const): Deleted.
* platform/network/curl/MultipartHandle.cpp:
(WebCore::MultipartHandle::didReceiveData):
* platform/network/curl/ResourceHandleCurl.cpp:
(WebCore::ResourceHandleInternal::~ResourceHandleInternal):
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::cancel):
(WebCore::ResourceHandle::platformSetDefersLoading):
(WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
(WebCore::ResourceHandle::receivedCredential):
(WebCore::ResourceHandle::receivedRequestToContinueWithoutCredential):
(WebCore::ResourceHandle::platformLoadResourceSynchronously):
(WebCore::ResourceHandleInternal::initialize): Deleted.
(WebCore::ResourceHandleInternal::applyAuthentication): Deleted.
(WebCore::getFormElementsCount): Deleted.
(WebCore::ResourceHandleInternal::setupPUT): Deleted.
(WebCore::ResourceHandleInternal::setupPOST): Deleted.
(WebCore::ResourceHandleInternal::setupFormData): Deleted.
(WebCore::ResourceHandleInternal::didFinish): Deleted.
(WebCore::ResourceHandleInternal::didFail): Deleted.
(WebCore::ResourceHandleInternal::calculateWebTimingInformations): Deleted.
(WebCore::ResourceHandleInternal::handleLocalReceiveResponse): Deleted.
(WebCore::isHttpInfo): Deleted.
(WebCore::isHttpRedirect): Deleted.
(WebCore::isHttpAuthentication): Deleted.
(WebCore::isHttpNotModified): Deleted.
(WebCore::isAppendableHeader): Deleted.
(WebCore::removeLeadingAndTrailingQuotes): Deleted.
(WebCore::getProtectionSpace): Deleted.
(WebCore::ResourceHandleInternal::willPrepareSendData): Deleted.
(WebCore::ResourceHandleInternal::didReceiveHeaderLine): Deleted.
(WebCore::ResourceHandleInternal::didReceiveAllHeaders): Deleted.
(WebCore::ResourceHandleInternal::didReceiveContentData): Deleted.
(WebCore::ResourceHandleInternal::readCallback): Deleted.
(WebCore::ResourceHandleInternal::headerCallback): Deleted.
(WebCore::ResourceHandleInternal::writeCallback): Deleted.
(WebCore::ResourceHandleInternal::dispatchSynchronousJob): Deleted.
(WebCore::ResourceHandleInternal::handleDataURL): Deleted.
* platform/network/curl/ResourceHandleCurlDelegate.cpp: Added.
(WebCore::ResourceHandleCurlDelegate::ResourceHandleCurlDelegate):
(WebCore::ResourceHandleCurlDelegate::~ResourceHandleCurlDelegate):
(WebCore::ResourceHandleCurlDelegate::hasHandle const):
(WebCore::ResourceHandleCurlDelegate::releaseHandle):
(WebCore::ResourceHandleCurlDelegate::start):
(WebCore::ResourceHandleCurlDelegate::cancel):
(WebCore::ResourceHandleCurlDelegate::setDefersLoading):
(WebCore::ResourceHandleCurlDelegate::setAuthentication):
(WebCore::ResourceHandleCurlDelegate::dispatchSynchronousJob):
(WebCore::ResourceHandleCurlDelegate::retain):
(WebCore::ResourceHandleCurlDelegate::release):
(WebCore::ResourceHandleCurlDelegate::setupRequest):
(WebCore::ResourceHandleCurlDelegate::notifyFinish):
(WebCore::ResourceHandleCurlDelegate::notifyFail):
(WebCore::ResourceHandleCurlDelegate::response):
(WebCore::ResourceHandleCurlDelegate::setupAuthentication):
(WebCore::removeLeadingAndTrailingQuotes):
(WebCore::ResourceHandleCurlDelegate::getProtectionSpace):
(WebCore::isHttpInfo):
(WebCore::isHttpRedirect):
(WebCore::isHttpAuthentication):
(WebCore::isHttpNotModified):
(WebCore::isAppendableHeader):
(WebCore::ResourceHandleCurlDelegate::didReceiveHeaderLine):
(WebCore::ResourceHandleCurlDelegate::didReceiveAllHeaders):
(WebCore::ResourceHandleCurlDelegate::didReceiveContentData):
(WebCore::ResourceHandleCurlDelegate::handleLocalReceiveResponse):
(WebCore::ResourceHandleCurlDelegate::prepareSendData):
(WebCore::ResourceHandleCurlDelegate::didFinish):
(WebCore::ResourceHandleCurlDelegate::didFail):
(WebCore::ResourceHandleCurlDelegate::handleDataURL):
(WebCore::ResourceHandleCurlDelegate::setupPOST):
(WebCore::ResourceHandleCurlDelegate::setupPUT):
(WebCore::ResourceHandleCurlDelegate::getFormElementsCount):
(WebCore::ResourceHandleCurlDelegate::setupFormData):
(WebCore::ResourceHandleCurlDelegate::applyAuthentication):
(WebCore::ResourceHandleCurlDelegate::setWebTimings):
(WebCore::ResourceHandleCurlDelegate::didReceiveHeader):
(WebCore::ResourceHandleCurlDelegate::didReceiveData):
(WebCore::ResourceHandleCurlDelegate::willSendData):
(WebCore::ResourceHandleCurlDelegate::didReceiveHeaderCallback):
(WebCore::ResourceHandleCurlDelegate::didReceiveDataCallback):
(WebCore::ResourceHandleCurlDelegate::willSendDataCallback):
* platform/network/curl/ResourceHandleCurlDelegate.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAdd WTFLogChannel level to allow runtime log filtering
eric.carlson@apple.com [Fri, 18 Aug 2017 22:46:17 +0000 (22:46 +0000)]
Add WTFLogChannel level to allow runtime log filtering
https://bugs.webkit.org/show_bug.cgi?id=175731
<rdar://problem/33967234>

Reviewed by Jer Noble.
Source/WTF:

Add WTFLog*, LOG, and RELEASE_LOG variants that take a "log level" parameter so code
can include logging statements that are only conditionally emitted.

* wtf/Assertions.cpp:
* wtf/Assertions.h:
* wtf/MemoryPressureHandler.cpp:
* wtf/RefCountedLeakCounter.cpp:

Tools:

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebCore/Logging.cpp: Added.
(TestWebKitAPI::LoggingTest::output):
(TestWebKitAPI::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoiOS 10 debug build fix.
rniwa@webkit.org [Fri, 18 Aug 2017 22:34:24 +0000 (22:34 +0000)]
iOS 10 debug build fix.

* dom/DataTransfer.cpp:
(WebCore::DataTransfer::DataTransfer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoMarking canvas/webgl tests as failing
jbedard@apple.com [Fri, 18 Aug 2017 22:15:25 +0000 (22:15 +0000)]
Marking canvas/webgl tests as failing
https://bugs.webkit.org/show_bug.cgi?id=175736

Unreviewed test gardening.

* platform/ios-device/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRename DataTransferAccessPolicy to match spec and refactor related node
rniwa@webkit.org [Fri, 18 Aug 2017 21:53:51 +0000 (21:53 +0000)]
Rename DataTransferAccessPolicy to match spec and refactor related node
https://bugs.webkit.org/show_bug.cgi?id=175704

Reviewed by Wenson Hsieh.

Renamed DataTransferAccessPolicy to DataTransfer::StoreMode to match the drag data store mode concept
in the HTML5 specification:
https://html.spec.whatwg.org/multipage/dnd.html#drag-data-store-mode

DataTransfer in addition to those states can be disassociated from the drag data store when it becomes
no longer valid. We also support a special mode which allows only updating the drag image.
These two states, Invalid and DragImageWritable, are added in addition to the three states in the spec.

Also split DragAndDrop type of DataTransfer into DragAndDropData and DragAndDropFiles, and refactored
the related code.

No new tests since there should be no behavioral change.

* WebCore.xcodeproj/project.pbxproj:
* dom/DataTransfer.cpp:
(WebCore::DataTransfer::DataTransfer): No longer takes forFileDrag boolean since it's folded into type.
(WebCore::DataTransfer::createForCopyAndPaste):
(WebCore::DataTransfer::~DataTransfer):
(WebCore::DataTransfer::setAccessPolicy): Deleted.
(WebCore::DataTransfer::canReadTypes const):
(WebCore::DataTransfer::canReadData const):
(WebCore::DataTransfer::canWriteData const):
(WebCore::DataTransfer::createForInputEvent):
(WebCore::DataTransfer::createForDrag):
(WebCore::DataTransfer::createForDrop):
(WebCore::DataTransfer::canSetDragImage const):
* dom/DataTransfer.h:
(WebCore::DataTransfer::makeInvalidForSecurity): Added.
(WebCore::DataTransfer::makeDragImageWritable): Added.
* dom/DataTransferAccessPolicy.h: Removed.
* editing/Editor.cpp:
(WebCore::dispatchClipboardEvent): Moved and renamed from dispatchCPPEvent. Now computes the store mode
inside the function to match the spec: https://w3c.github.io/clipboard-apis/#fire-a-clipboard-event
(WebCore::Editor::canDHTMLCut):
(WebCore::Editor::canDHTMLCopy):
(WebCore::Editor::canDHTMLPaste):
(WebCore::Editor::tryDHTMLCopy):
(WebCore::Editor::tryDHTMLCut):
(WebCore::Editor::tryDHTMLPaste):
(WebCore::Editor::dispatchCPPEvent): Deleted.
* editing/Editor.h:
* page/DragController.cpp:
(WebCore::createDataTransferToUpdateDrag): Extracted to share code.
(WebCore::DragController::dragExited):
(WebCore::DragController::performDragOperation):
(WebCore::DragController::tryDHTMLDrag):
* page/EventHandler.cpp:
(WebCore::EventHandler::invalidateDataTransfer):
(WebCore::EventHandler::handleDrag):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoFollowup (r220289): RenderImageResourceStyleImage code clean up
commit-queue@webkit.org [Fri, 18 Aug 2017 21:40:42 +0000 (21:40 +0000)]
Followup (r220289): RenderImageResourceStyleImage code clean up
https://bugs.webkit.org/show_bug.cgi?id=175444

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2017-08-18
Reviewed by Darin Adler.

RenderImageResourceStyleImage may be created with a StyleImage of type
StyleGeneratedImage. It may also be associated with a CachedImage which
is loaded through a source URL. In this case, adding and removing m_renderer
as a client of the CachedImage will be done through
RenderImageResource::setCachedImage().

RenderImageResource::setCachedImage() is already called from
ImageLoader::updateRenderer() when the CachedImage finishes loading. This
call adds m_renderer to the clients of the CachedImage.
RenderImageResource::setCachedImage() will also be called from
RenderImageResourceStyleImage::shutdown() via RenderImageResource::shutdown()
to remove m_renderer from the clients of CachedImage by passing a null pointer.

* rendering/RenderImage.cpp:
(WebCore::RenderImage::styleWillChange):
* rendering/RenderImageResource.cpp:
(WebCore::RenderImageResource::initialize):
(WebCore::RenderImageResource::shutdown):
(WebCore::RenderImageResource::setCachedImage):
(WebCore::RenderImageResource::resetAnimation):
(WebCore::RenderImageResource::image const):
(WebCore::RenderImageResource::setContainerSizeForRenderer):
(WebCore::RenderImageResource::imageSize const):
(WebCore::RenderImageResource::~RenderImageResource): Deleted.
(WebCore::RenderImageResource::errorOccurred const): Deleted.
(WebCore::RenderImageResource::imageHasRelativeWidth const): Deleted.
(WebCore::RenderImageResource::imageHasRelativeHeight const): Deleted.
(WebCore::RenderImageResource::intrinsicSize const): Deleted.
(WebCore::RenderImageResource::getImageSize const): Deleted.
* rendering/RenderImageResource.h:
(WebCore::RenderImageResource::initialize):
(WebCore::RenderImageResource::renderer const):
(WebCore::RenderImageResource::errorOccurred const):
(WebCore::RenderImageResource::imageHasRelativeWidth const):
(WebCore::RenderImageResource::imageHasRelativeHeight const):
(WebCore::RenderImageResource::imageSize const):
(WebCore::RenderImageResource::intrinsicSize const):
(WebCore::RenderImageResource::imagePtr const):
* rendering/RenderImageResourceStyleImage.cpp:
(WebCore::RenderImageResourceStyleImage::initialize):
(WebCore::RenderImageResourceStyleImage::shutdown):
(WebCore::RenderImageResourceStyleImage::image const):
(WebCore::RenderImageResourceStyleImage::setContainerSizeForRenderer):
(WebCore::RenderImageResourceStyleImage::~RenderImageResourceStyleImage): Deleted.
* rendering/RenderImageResourceStyleImage.h:
* rendering/RenderSnapshottedPlugIn.cpp:
(WebCore::RenderSnapshottedPlugIn::RenderSnapshottedPlugIn):
* rendering/svg/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::RenderSVGImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[WebCrypto][Mac] Replace CCECCryptorGetKeyComponents with CCECCryptorExportKey for...
jiewen_tan@apple.com [Fri, 18 Aug 2017 21:30:45 +0000 (21:30 +0000)]
[WebCrypto][Mac] Replace CCECCryptorGetKeyComponents with CCECCryptorExportKey for exporting ECC JWKs
https://bugs.webkit.org/show_bug.cgi?id=175657
<rdar://problem/33797150>

Reviewed by Brent Fulgham.

Source/WebCore:

CCECCryptorGetKeyComponents returns components in unpadded formats. In some minor cases, the ECC components
do need padding. Therefore, we occasionally see some corrupted outputs in JWKs. To overcome that, this patch
replaces CCECCryptorGetKeyComponents with CCECCryptorExportKey which does padding all the time.

In the meantime, this patch also makes export* methods return OperationError if any error occur in the
underlying operations though very unlikely.

Test: crypto/subtle/ecdsa-generate-export-import-jwk-sign-verify.html

* crypto/algorithms/CryptoAlgorithmECDH.cpp:
(WebCore::CryptoAlgorithmECDH::exportKey):
* crypto/algorithms/CryptoAlgorithmECDSA.cpp:
(WebCore::CryptoAlgorithmECDSA::exportKey):
* crypto/gcrypt/CryptoKeyECGCrypt.cpp:
(WebCore::CryptoKeyEC::platformAddFieldElements const):
* crypto/keys/CryptoKeyEC.cpp:
(WebCore::CryptoKeyEC::exportRaw const):
(WebCore::CryptoKeyEC::exportJwk const):
(WebCore::CryptoKeyEC::exportSpki const):
(WebCore::CryptoKeyEC::exportPkcs8 const):
* crypto/keys/CryptoKeyEC.h:
* crypto/mac/CryptoKeyECMac.cpp:
(WebCore::CryptoKeyEC::platformExportRaw const):
(WebCore::CryptoKeyEC::platformAddFieldElements const):
(WebCore::CryptoKeyEC::platformExportSpki const):
(WebCore::CryptoKeyEC::platformExportPkcs8 const):

LayoutTests:

* crypto/subtle/ecdsa-generate-export-import-jwk-sign-verify-expected.txt: Added.
* crypto/subtle/ecdsa-generate-export-import-jwk-sign-verify.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoMarked imported/w3c/web-platform-tests/IndexedDB/open-request-queue.html as flaky...
jlewis3@apple.com [Fri, 18 Aug 2017 21:07:51 +0000 (21:07 +0000)]
Marked imported/w3c/web-platform-tests/IndexedDB/open-request-queue.html as flaky timeout.
https://bugs.webkit.org/show_bug.cgi?id=172044

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoREGRESSION (r220601): Crash when closing google doc after switching the order of...
cdumez@apple.com [Fri, 18 Aug 2017 20:53:33 +0000 (20:53 +0000)]
REGRESSION (r220601): Crash when closing google doc after switching the order of tabs in safari
https://bugs.webkit.org/show_bug.cgi?id=175721
<rdar://problem/33928369>

Reviewed by Geoffrey Garen.

Make sure WebProcess::markAllLayersVolatile() does not call WTFMove() multiple times
on the same completion handler. Use a RefCounter to hold on to the completion handler
and make sure the handler gets called when the RefCounter's value becomes 0.

* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::cancelPrepareToSuspend):
(WebKit::WebProcess::markAllLayersVolatile):
(WebKit::WebProcess::cancelMarkAllLayersVolatile):
* WebProcess/WebProcess.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Win] accessibility/heading-crash-after-hidden.html is a flaky crash.
pvollan@apple.com [Fri, 18 Aug 2017 20:50:59 +0000 (20:50 +0000)]
[Win] accessibility/heading-crash-after-hidden.html is a flaky crash.
https://bugs.webkit.org/show_bug.cgi?id=173536

Reviewed by Brent Fulgham.

If the tree state is dirty, accessible objects are deleted while iterating over children
under AccessibilityNodeObject::textUnderElement when the style is updated. Make sure the
style is updated before this method is called.

Source/WebCore:

No new tests, covered by existing tests.

* accessibility/win/AccessibilityObjectWrapperWin.cpp:
(WebCore::AccessibilityObjectWrapper::accessibilityAttributeValue):

Source/WebKitLegacy/win:

* AccessibleBase.cpp:
(AccessibleBase::getAccessibilityObjectForChild):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoMarked js/slow-stress/Int32Array-alloc-huge.html as flaky on mac.
jlewis3@apple.com [Fri, 18 Aug 2017 20:16:57 +0000 (20:16 +0000)]
Marked js/slow-stress/Int32Array-alloc-huge.html as flaky on mac.
https://bugs.webkit.org/show_bug.cgi?id=173010

Unreviewed test gardening.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Cache API] Add response body storage
commit-queue@webkit.org [Fri, 18 Aug 2017 19:32:48 +0000 (19:32 +0000)]
[Cache API] Add response body storage
https://bugs.webkit.org/show_bug.cgi?id=175658

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-18
Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

* web-platform-tests/service-workers/cache-storage/window/cache-match.https-expected.txt:
* web-platform-tests/service-workers/cache-storage/window/cache-put.https-expected.txt:
* web-platform-tests/service-workers/cache-storage/worker/cache-match.https-expected.txt:
* web-platform-tests/service-workers/cache-storage/worker/cache-put.https-expected.txt:

Source/WebCore:

Covered by rebased tests.
Tests are still flaky until waiting for end of fetch load is implemented.

Adding a response body within CacheStorageConnection::Record.
Adding ability to pass this body from/to the main thread.

Adding response body consumption into a CacheStorageConnection::Record.
Adding response body setting from a CacheStorageConnection::Record.

* Modules/beacon/NavigatorBeacon.cpp:
(WebCore::NavigatorBeacon::sendBeacon):
* Modules/cache/Cache.cpp:
(WebCore::Cache::put):
(WebCore::toConnectionRecord):
(WebCore::Cache::updateRecords):
* Modules/cache/CacheStorageConnection.cpp:
(WebCore::CacheStorageConnection::copyResponseBody):
(WebCore::CacheStorageConnection::isolatedResponseBody):
(WebCore::CacheStorageConnection::Record::copy const):
* Modules/cache/CacheStorageConnection.h:
* Modules/cache/WorkerCacheStorageConnection.cpp:
(WebCore::toCrossThreadRecordData):
(WebCore::fromCrossThreadRecordData):
* Modules/fetch/FetchBody.cpp:
(WebCore::FetchBody::bodyAsFormData const):
(WebCore::FetchBody::take):
(WebCore::FetchBody::bodyForInternalRequest const): Deleted.
* Modules/fetch/FetchBody.h:
(WebCore::FetchBody::setAsFormData):
* Modules/fetch/FetchBodyConsumer.h:
(WebCore::FetchBodyConsumer::setData):
* Modules/fetch/FetchRequest.cpp:
(WebCore::FetchRequest::resourceRequest const):
* Modules/fetch/FetchResponse.cpp:
(WebCore::FetchResponse::consumeBody):
(WebCore::FetchResponse::setBodyData):
* Modules/fetch/FetchResponse.h:

Source/WebKit:

Added IPC serialization of Record response body.
Updated CacheStorageEngine implementation as Record has no longer a copy constructor.

* NetworkProcess/cache/CacheStorageEngine.cpp:
(WebKit::CacheStorageEngine::retrieveRecords):
(WebKit::CacheStorageEngine::deleteMatchingRecords):
* Shared/WebCoreArgumentCoders.cpp:
(IPC::encodeSharedBuffer):
(IPC::decodeSharedBuffer):
(IPC::ArgumentCoder<CacheStorageConnection::Record>::encode):
(IPC::ArgumentCoder<CacheStorageConnection::Record>::decode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Fetch API] Add support for a callback-based fetch
commit-queue@webkit.org [Fri, 18 Aug 2017 19:32:17 +0000 (19:32 +0000)]
[Fetch API] Add support for a callback-based fetch
https://bugs.webkit.org/show_bug.cgi?id=175710

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-18
Reviewed by Alex Christensen.

No change of behavior.

Moving from a DOMPromise to a Callback taking an ExceptionOr<FetchResponse&>.
Updating window and worker call sites.

* Modules/fetch/DOMWindowFetch.cpp:
(WebCore::DOMWindowFetch::fetch):
* Modules/fetch/FetchResponse.cpp:
(WebCore::FetchResponse::fetch):
(WebCore::FetchResponse::BodyLoader::didFail):
(WebCore::FetchResponse::BodyLoader::BodyLoader):
(WebCore::FetchResponse::BodyLoader::didReceiveResponse):
(WebCore::FetchResponse::BodyLoader::stop):
* Modules/fetch/FetchResponse.h:
* Modules/fetch/WorkerGlobalScopeFetch.cpp:
(WebCore::WorkerGlobalScopeFetch::fetch):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoImplement 32-bit MacroAssembler::probe support for Windows.
pvollan@apple.com [Fri, 18 Aug 2017 19:20:23 +0000 (19:20 +0000)]
Implement 32-bit MacroAssembler::probe support for Windows.
https://bugs.webkit.org/show_bug.cgi?id=175449

Reviewed by Mark Lam.

Source/JavaScriptCore:

This is needed to enable the DFG.

* assembler/MacroAssemblerX86Common.cpp:
* assembler/testmasm.cpp:
(JSC::run):
(dllLauncherEntryPoint):
* shell/CMakeLists.txt:
* shell/PlatformWin.cmake:

Source/WTF:

Enable the DFG on Win32.

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAdd Dean Johnson to contributors.json for Bugzilla autocomplete.
ap@apple.com [Fri, 18 Aug 2017 18:56:04 +0000 (18:56 +0000)]
Add Dean Johnson to contributors.json for Bugzilla autocomplete.

* Scripts/webkitpy/common/config/contributors.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoBounce ServiceWorker jobs to the Storage Process.
beidson@apple.com [Fri, 18 Aug 2017 18:52:43 +0000 (18:52 +0000)]
Bounce ServiceWorker jobs to the Storage Process.
https://bugs.webkit.org/show_bug.cgi?id=175650

Reviewed by Andy Estes.

LayoutTests/imported/w3c:

Now that the serviceWorker.register() call is asynchronous, update a whole bunch of test results.

* web-platform-tests/FileAPI/historical.https-expected.txt:
* web-platform-tests/background-fetch/interfaces-worker.https-expected.txt:
* web-platform-tests/fetch/api/policies/referrer-no-referrer-service-worker.https-expected.txt:
* web-platform-tests/fetch/api/policies/referrer-origin-service-worker.https-expected.txt:
* web-platform-tests/fetch/api/policies/referrer-origin-when-cross-origin-service-worker.https-expected.txt:
* web-platform-tests/fetch/api/policies/referrer-unsafe-url-service-worker.https-expected.txt:
* web-platform-tests/html/webappapis/scripting/processing-model-2/integration-with-the-javascript-agent-formalism/canblock-serviceworker.https-expected.txt:
* web-platform-tests/service-workers/cache-storage/serviceworker/cache-add.https-expected.txt:
* web-platform-tests/service-workers/cache-storage/serviceworker/cache-delete.https-expected.txt:
* web-platform-tests/service-workers/cache-storage/serviceworker/cache-keys.https-expected.txt:
* web-platform-tests/service-workers/cache-storage/serviceworker/cache-match.https-expected.txt:
* web-platform-tests/service-workers/cache-storage/serviceworker/cache-matchAll.https-expected.txt:
* web-platform-tests/service-workers/cache-storage/serviceworker/cache-put.https-expected.txt:
* web-platform-tests/service-workers/cache-storage/serviceworker/cache-storage-keys.https-expected.txt:
* web-platform-tests/service-workers/cache-storage/serviceworker/cache-storage-match.https-expected.txt:
* web-platform-tests/service-workers/cache-storage/serviceworker/cache-storage.https-expected.txt:
* web-platform-tests/streams/byte-length-queuing-strategy.serviceworker.https-expected.txt:
* web-platform-tests/streams/count-queuing-strategy.serviceworker.https-expected.txt:
* web-platform-tests/streams/piping/close-propagation-backward.serviceworker.https-expected.txt:
* web-platform-tests/streams/piping/close-propagation-forward.serviceworker.https-expected.txt:
* web-platform-tests/streams/piping/error-propagation-backward.serviceworker.https-expected.txt:
* web-platform-tests/streams/piping/error-propagation-forward.serviceworker.https-expected.txt:
* web-platform-tests/streams/piping/flow-control.serviceworker.https-expected.txt:
* web-platform-tests/streams/piping/general.serviceworker.https-expected.txt:
* web-platform-tests/streams/piping/multiple-propagation.serviceworker.https-expected.txt:
* web-platform-tests/streams/piping/pipe-through.serviceworker.https-expected.txt:
* web-platform-tests/streams/piping/transform-streams.serviceworker.https-expected.txt:
* web-platform-tests/streams/readable-byte-streams/general.serviceworker.https-expected.txt:
* web-platform-tests/streams/readable-streams/bad-strategies.serviceworker.https-expected.txt:
* web-platform-tests/streams/readable-streams/bad-underlying-sources.serviceworker.https-expected.txt:
* web-platform-tests/streams/readable-streams/brand-checks.serviceworker.https-expected.txt:
* web-platform-tests/streams/readable-streams/cancel.serviceworker.https-expected.txt:
* web-platform-tests/streams/readable-streams/count-queuing-strategy-integration.serviceworker.https-expected.txt:
* web-platform-tests/streams/readable-streams/default-reader.serviceworker.https-expected.txt:
* web-platform-tests/streams/readable-streams/floating-point-total-queue-size.serviceworker.https-expected.txt:
* web-platform-tests/streams/readable-streams/garbage-collection.serviceworker.https-expected.txt:
* web-platform-tests/streams/readable-streams/general.serviceworker.https-expected.txt:
* web-platform-tests/streams/readable-streams/pipe-through.serviceworker.https-expected.txt:
* web-platform-tests/streams/readable-streams/readable-stream-reader.serviceworker.https-expected.txt:
* web-platform-tests/streams/readable-streams/tee.serviceworker.https-expected.txt:
* web-platform-tests/streams/readable-streams/templated.serviceworker.https-expected.txt:

Source/WebCore:

No new tests (Covered by both changes and consistencies in existing tests)

This lays the groundwork for the SW job queue being in the StorageProcess by actually
setting up some objects for IPC communication and actually sending things over the wire.

The main point of IPC is the WebCore abstract base class "SWServer::Connection"

A collection of them will soon be managed by the SWServer itself in the StorageProcess.

That object will be the stand-in for IPC on both the WebProcess and StorageProcess side.

Currently, any job that we try to schedule still immediately rejects (though now it does
so asynchronously instead of synchronously).

* CMakeLists.txt:
* WebCore.xcodeproj/project.pbxproj:

* dom/ExceptionData.h: Copied from Source/WebCore/workers/service/ServiceWorkerProvider.h.
(WebCore::ExceptionData::toException const):
(WebCore::ExceptionData::encode const):
(WebCore::ExceptionData::decode):

* workers/service/ServiceWorkerContainer.cpp:
(WebCore::ServiceWorkerContainer::addRegistration):
(WebCore::ServiceWorkerContainer::scheduleJob):
* workers/service/ServiceWorkerContainer.h:

* workers/service/ServiceWorkerJob.cpp:
(WebCore::ServiceWorkerJob::failedWithException):
(WebCore::ServiceWorkerJob::data const):
* workers/service/ServiceWorkerJob.h:

* workers/service/ServiceWorkerJobData.h: Copied from Source/WebCore/workers/service/ServiceWorkerProvider.h.
(WebCore::ServiceWorkerJobData::encode const):
(WebCore::ServiceWorkerJobData::decode):

* workers/service/ServiceWorkerJobType.h: Copied from Source/WebCore/workers/service/ServiceWorkerProvider.h.

* workers/service/ServiceWorkerProvider.h:

* workers/service/ServiceWorkerRegistrationParameters.h:

* workers/service/server/SWServer.cpp: Copied from Source/WebKit/WebProcess/Storage/WebServiceWorkerProvider.cpp.
(WebCore::SWServer::Connection::scheduleJob):
(WebCore::SWServer::Connection::jobRejected):
* workers/service/server/SWServer.h: Copied from Source/WebCore/workers/service/ServiceWorkerProvider.h.
(WebCore::SWServer::Connection::~Connection):

Source/WebKit:

* CMakeLists.txt:
* DerivedSources.make:
* WebKit.xcodeproj/project.pbxproj:

* Platform/Logging.h:

* StorageProcess/StorageToWebProcessConnection.cpp:
(WebKit::StorageToWebProcessConnection::didReceiveMessage):
(WebKit::StorageToWebProcessConnection::didClose):
(WebKit::StorageToWebProcessConnection::establishSWServerConnection):
(WebKit::StorageToWebProcessConnection::removeSWServerConnection):
(WebKit::StorageToWebProcessConnection::establishIDBConnectionToServer):
* StorageProcess/StorageToWebProcessConnection.h:
* StorageProcess/StorageToWebProcessConnection.messages.in:

* WebProcess/Storage/WebSWServerConnection.cpp: Added.
(WebKit::WebSWServerConnection::WebSWServerConnection):
(WebKit::WebSWServerConnection::~WebSWServerConnection):
(WebKit::WebSWServerConnection::disconnectedFromWebProcess):
(WebKit::WebSWServerConnection::scheduleJob):
(WebKit::WebSWServerConnection::scheduleStorageJob):
* WebProcess/Storage/WebSWServerConnection.h: Copied from Source/WebCore/workers/service/ServiceWorkerJob.h.
(WebKit::WebSWServerConnection::create):
(WebKit::WebSWServerConnection::identifier const):
* WebProcess/Storage/WebSWServerConnection.messages.in: Copied from Source/WebKit/StorageProcess/StorageToWebProcessConnection.messages.in.

* WebProcess/Storage/WebServiceWorkerProvider.cpp:
(WebKit::WebServiceWorkerProvider::serviceWorkerConnectionForSession):
(WebKit::WebServiceWorkerProvider::scheduleJob): Deleted.
* WebProcess/Storage/WebServiceWorkerProvider.h:

* WebProcess/Storage/WebToStorageProcessConnection.cpp:
(WebKit::WebToStorageProcessConnection::didReceiveMessage):
(WebKit::WebToStorageProcessConnection::serviceWorkerConnectionForSession):
* WebProcess/Storage/WebToStorageProcessConnection.h:

LayoutTests:

Service worker tests will always be dumpAsText and always be asynchronous.

* http/tests/workers/service/basic-register.html:
* http/tests/workers/service/resources/basic-register.js:
* http/tests/workers/service/resources/sw-test-pre.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Beacon] Add support for quota limitation
cdumez@apple.com [Fri, 18 Aug 2017 17:58:41 +0000 (17:58 +0000)]
[Beacon] Add support for quota limitation
https://bugs.webkit.org/show_bug.cgi?id=175443
<rdar://problem/33729002>

Reviewed by Youenn Fablet.

Source/WebCore:

LoaderStrategy::startPingLoad() now takes a completion handler parameter, allowing CachedResource::load()
to know when a Beacon load is complete. This was needed in order for the fetch in-flight keepalive request
quota limit to work properly for beacon loads as well. We need to know when the beacon load completes in
order to know if the beacon is in-flight or not and only free up its allocated quota once it is no longer
in-flight.

No new tests, updated existing test.

* loader/LoaderStrategy.h:
* loader/PingLoader.cpp:
(WebCore::PingLoader::startPingLoad):
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::load):
* platform/network/PingHandle.h:

Source/WebKit:

WebLoaderStrategy now generates an identifier for ping loads and keep
the completion handler in a local HashMap. Once the ping load is done,
the network process sends an IPC message back to the WebContent process
so that WebLoaderStrategy can look up the completion handler for the
ping load and call it.

* NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::loadPing):
(WebKit::NetworkConnectionToWebProcess::didFinishPingLoad):
* NetworkProcess/NetworkConnectionToWebProcess.h:
* NetworkProcess/PingLoad.cpp:
(WebKit::PingLoad::PingLoad):
(WebKit::PingLoad::~PingLoad):
* NetworkProcess/PingLoad.h:
* WebProcess/Network/NetworkProcessConnection.cpp:
(WebKit::NetworkProcessConnection::didFinishPingLoad):
* WebProcess/Network/NetworkProcessConnection.h:
* WebProcess/Network/NetworkProcessConnection.messages.in:
* WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::generatePingLoadIdentifier):
(WebKit::WebLoaderStrategy::startPingLoad):
(WebKit::WebLoaderStrategy::didFinishPingLoad):
* WebProcess/Network/WebLoaderStrategy.h:

Source/WebKitLegacy:

* WebCoreSupport/WebResourceLoadScheduler.cpp:
(WebResourceLoadScheduler::startPingLoad):
* WebCoreSupport/WebResourceLoadScheduler.h:

LayoutTests:

Extend layout test coverage and rebaseline test.

* http/wpt/beacon/beacon-quota-expected.txt:
* http/wpt/beacon/beacon-quota.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRename ProbeContext and ProbeFunction to Probe::State and Probe::Function.
mark.lam@apple.com [Fri, 18 Aug 2017 17:54:50 +0000 (17:54 +0000)]
Rename ProbeContext and ProbeFunction to Probe::State and Probe::Function.
https://bugs.webkit.org/show_bug.cgi?id=175725
<rdar://problem/33965477>

Rubber-stamped by JF Bastien.

This is purely a refactoring patch (in preparation for the introduction of a
Probe::Context data structure in https://bugs.webkit.org/show_bug.cgi?id=175688
later).  This patch does not change any semantics / behavior.

* assembler/AbstractMacroAssembler.h:
* assembler/MacroAssembler.cpp:
(JSC::stdFunctionCallback):
(JSC::MacroAssembler::probe):
* assembler/MacroAssembler.h:
(JSC::ProbeContext::gpr): Deleted.
(JSC::ProbeContext::spr): Deleted.
(JSC::ProbeContext::fpr): Deleted.
(JSC::ProbeContext::gprName): Deleted.
(JSC::ProbeContext::sprName): Deleted.
(JSC::ProbeContext::fprName): Deleted.
(JSC::ProbeContext::pc): Deleted.
(JSC::ProbeContext::fp): Deleted.
(JSC::ProbeContext::sp): Deleted.
* assembler/MacroAssemblerARM.cpp:
(JSC::MacroAssembler::probe):
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::trustedImm32FromPtr):
* assembler/MacroAssemblerARM64.cpp:
(JSC::arm64ProbeError):
(JSC::MacroAssembler::probe):
* assembler/MacroAssemblerARMv7.cpp:
(JSC::MacroAssembler::probe):
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::trustedImm32FromPtr):
* assembler/MacroAssemblerPrinter.cpp:
(JSC::Printer::printCallback):
* assembler/MacroAssemblerPrinter.h:
* assembler/MacroAssemblerX86Common.cpp:
(JSC::MacroAssembler::probe):
* assembler/Printer.h:
(JSC::Printer::Context::Context):
* assembler/testmasm.cpp:
(JSC::testProbeReadsArgumentRegisters):
(JSC::testProbeWritesArgumentRegisters):
(JSC::testProbePreservesGPRS):
(JSC::testProbeModifiesStackPointer):
(JSC::testProbeModifiesStackPointerToInsideProbeStateOnStack):
(JSC::testProbeModifiesStackPointerToNBytesBelowSP):
(JSC::testProbeModifiesProgramCounter):
(JSC::fillStack):
(JSC::testProbeModifiesStackWithCallback):
(JSC::run):
(JSC::testProbeModifiesStackPointerToInsideProbeContextOnStack): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, land TestExpectations for rdar://problem/33850189.
ryanhaddad@apple.com [Fri, 18 Aug 2017 17:49:05 +0000 (17:49 +0000)]
Unreviewed, land TestExpectations for rdar://problem/33850189.

* platform/mac-highsierra/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRebaseline js/dom/global-constructors-attributes.html for El Capitan WK2.
ryanhaddad@apple.com [Fri, 18 Aug 2017 17:42:36 +0000 (17:42 +0000)]
Rebaseline js/dom/global-constructors-attributes.html for El Capitan WK2.

Unreviewed test gardening.

* platform/mac-elcapitan-wk2/js/dom/global-constructors-attributes-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Tools] Add script to download a GitHub release
commit-queue@webkit.org [Fri, 18 Aug 2017 16:08:15 +0000 (16:08 +0000)]
[Tools] Add script to download a GitHub release
https://bugs.webkit.org/show_bug.cgi?id=175279

Patch by Ross Kirsling <ross.kirsling@sony.com> on 2017-08-18
Reviewed by Brent Fulgham.

* Scripts/download-latest-github-release.py: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Cache API] Add a WK2 implementation of CacheStorageConnection
commit-queue@webkit.org [Fri, 18 Aug 2017 15:51:45 +0000 (15:51 +0000)]
[Cache API] Add a WK2 implementation of CacheStorageConnection
https://bugs.webkit.org/show_bug.cgi?id=175640

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-18
Reviewed by Alex Christensen & Chris Dumez.

LayoutTests/imported/w3c:

* web-platform-tests/service-workers/cache-storage/window/cache-add.https-expected.txt:
* web-platform-tests/service-workers/cache-storage/window/cache-delete.https-expected.txt:
* web-platform-tests/service-workers/cache-storage/window/cache-keys.https-expected.txt:
* web-platform-tests/service-workers/cache-storage/window/cache-match.https-expected.txt:
* web-platform-tests/service-workers/cache-storage/window/cache-matchAll.https-expected.txt:
* web-platform-tests/service-workers/cache-storage/window/cache-put.https-expected.txt:
* web-platform-tests/service-workers/cache-storage/window/cache-storage-keys.https-expected.txt:
* web-platform-tests/service-workers/cache-storage/window/cache-storage.https-expected.txt:
* web-platform-tests/service-workers/cache-storage/window/sandboxed-iframes.https-expected.txt:
* web-platform-tests/service-workers/cache-storage/worker/cache-add.https-expected.txt:
* web-platform-tests/service-workers/cache-storage/worker/cache-delete.https-expected.txt:
* web-platform-tests/service-workers/cache-storage/worker/cache-keys.https-expected.txt:
* web-platform-tests/service-workers/cache-storage/worker/cache-match.https-expected.txt:
* web-platform-tests/service-workers/cache-storage/worker/cache-matchAll.https-expected.txt:
* web-platform-tests/service-workers/cache-storage/worker/cache-put.https-expected.txt:
* web-platform-tests/service-workers/cache-storage/worker/cache-storage-keys.https-expected.txt:
* web-platform-tests/service-workers/cache-storage/worker/cache-storage.https-expected.txt:

Source/WebCore:

* Modules/cache/CacheStorageConnection.cpp: Adding Internal error.
* Modules/cache/CacheStorageConnection.h: Ditto.
* WebCore.xcodeproj/project.pbxproj: Exporting CacheQueryOptions.h header.

Source/WebKit:

Adding WebCacheStorageConnection as an implementation of CacheStorageConnection.
Making WebCacheStorageProvider instantiates such class.
One WebCacheStorageConnection is created for each session of a given WebProcess.

WebCacheStorageConnection is sending IPC calls to the network process.
Main implementation of the cache API is done in the network process by CacheStorageEngineConnection and CacheStorageEngine.
There is one WebCacheStorageConnection per session.
WebCacheStorageConnection is passing the session ID for each call to the network process to ensure the right cache storage engine is used.

CacheStorageEngineConnection mirrors WebCacheStorageConnection on the network process.
There is one CacheStorageEngine per session and CacheStorageEngineConnection will select the right CacheStorageEngine using the given session ID.

CacheStorageEngine is responsible of storing and matching cache API records.
Current implementation only keeps in memory the cached objects.

CacheStorageEngine is keeping (for each different origin) caches and records as a Vector as the order of insertion is important as per spec.
It also keeps a list of removed caches. These caches should remain functional until the last web page having access to these is gone.
The mechanism to fully remove these caches is not implemented yet.

Adding IPC encodings for WTF::Expected, CacheQueryOptions, FetchOptions, CacheStorageConnection Record and CacheInfo.

* CMakeLists.txt:
* DerivedSources.make:
* NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::didReceiveMessage):
(WebKit::generateCacheStorageConnectionIdentifier):
(WebKit::NetworkConnectionToWebProcess::createCacheStorageConnection):
(WebKit::NetworkConnectionToWebProcess::closeCacheStorageConnection):
* NetworkProcess/NetworkConnectionToWebProcess.h:
* NetworkProcess/NetworkConnectionToWebProcess.messages.in:
* NetworkProcess/cache/CacheStorageEngine.cpp: Added.
(WebKit::defaultCacheStorageEngine):
(WebKit::globalEngineMap):
(WebKit::CacheStorageEngine::from):
(WebKit::CacheStorageEngine::destroyEngine):
(WebKit::CacheStorageEngine::defaultEngine):
(WebKit::CacheStorageEngine::open):
(WebKit::CacheStorageEngine::remove):
(WebKit::CacheStorageEngine::retrieveCaches):
(WebKit::CacheStorageEngine::retrieveRecords):
(WebKit::CacheStorageEngine::putRecords):
(WebKit::CacheStorageEngine::deleteMatchingRecords):
(WebKit::CacheStorageEngine::writeCachesToDisk):
(WebKit::CacheStorageEngine::readCachesFromDisk):
(WebKit::CacheStorageEngine::readCache):
(WebKit::CacheStorageEngine::writeCacheRecords):
(WebKit::CacheStorageEngine::removeCacheRecords):
(WebKit::CacheStorageEngine::cache):
(WebKit::CacheStorageEngine::caches const):
(WebKit::CacheStorageEngine::records):
(WebKit::CacheStorageEngine::queryCache):
* NetworkProcess/cache/CacheStorageEngine.h: Added.
* NetworkProcess/cache/CacheStorageEngineConnection.cpp: Added.
(WebKit::CacheStorageEngineConnection::CacheStorageEngineConnection):
(WebKit::CacheStorageEngineConnection::open):
(WebKit::CacheStorageEngineConnection::remove):
(WebKit::CacheStorageEngineConnection::caches):
(WebKit::CacheStorageEngineConnection::records):
(WebKit::CacheStorageEngineConnection::deleteMatchingRecords):
(WebKit::CacheStorageEngineConnection::putRecords):
* NetworkProcess/cache/CacheStorageEngineConnection.h: Added.
(WebKit::CacheStorageEngineConnection::create):
* NetworkProcess/cache/CacheStorageEngineConnection.messages.in: Added.
* Platform/IPC/ArgumentCoders.h:
* Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<CacheQueryOptions>::encode):
(IPC::ArgumentCoder<CacheQueryOptions>::decode):
(IPC::ArgumentCoder<FetchOptions>::encode):
(IPC::ArgumentCoder<FetchOptions>::decode):
(IPC::ArgumentCoder<CacheStorageConnection::CacheInfo>::encode):
(IPC::ArgumentCoder<CacheStorageConnection::CacheInfo>::decode):
(IPC::ArgumentCoder<CacheStorageConnection::Record>::encode):
(IPC::ArgumentCoder<CacheStorageConnection::Record>::decode):
* Shared/WebCoreArgumentCoders.h:
* WebKit.xcodeproj/project.pbxproj:
* WebProcess/Cache/WebCacheStorageConnection.cpp: Added.
(WebKit::WebCacheStorageConnection::WebCacheStorageConnection):
(WebKit::WebCacheStorageConnection::~WebCacheStorageConnection):
(WebKit::WebCacheStorageConnection::messageSenderConnection):
(WebKit::WebCacheStorageConnection::doOpen):
(WebKit::WebCacheStorageConnection::doRemove):
(WebKit::WebCacheStorageConnection::doRetrieveCaches):
(WebKit::WebCacheStorageConnection::doRetrieveRecords):
(WebKit::WebCacheStorageConnection::doBatchDeleteOperation):
(WebKit::WebCacheStorageConnection::doBatchPutOperation):
(WebKit::WebCacheStorageConnection::openCompleted):
(WebKit::WebCacheStorageConnection::removeCompleted):
(WebKit::WebCacheStorageConnection::updateCaches):
(WebKit::WebCacheStorageConnection::updateRecords):
(WebKit::WebCacheStorageConnection::deleteRecordsCompleted):
(WebKit::WebCacheStorageConnection::putRecordsCompleted):
* WebProcess/Cache/WebCacheStorageConnection.h: Added.
* WebProcess/Cache/WebCacheStorageConnection.messages.in: Added.
* WebProcess/Cache/WebCacheStorageProvider.cpp: Copied from Source/WebKit/WebProcess/Cache/WebCacheStorageProvider.h.
(WebKit::WebCacheStorageProvider::createCacheStorageConnection):
* WebProcess/Cache/WebCacheStorageProvider.h:
* WebProcess/Network/NetworkProcessConnection.cpp:
(WebKit::NetworkProcessConnection::didReceiveMessage):

LayoutTests:

* TestExpectations: Marking some tests as flaky until being loaded resources can be cached.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoFactor render tree mutation code from RenderListItem to RenderTreeUpdater
antti@apple.com [Fri, 18 Aug 2017 14:52:22 +0000 (14:52 +0000)]
Factor render tree mutation code from RenderListItem to RenderTreeUpdater
https://bugs.webkit.org/show_bug.cgi?id=175718

Reviewed by Andreas Kling.

We already stopped doing layout time mutations. We can now move the code out too.

* WebCore.xcodeproj/project.pbxproj:
* rendering/RenderListItem.cpp:
(WebCore::isHTMLListElement):
(WebCore::getParentOfFirstLineBox): Deleted.
(WebCore::firstNonMarkerChild): Deleted.
(WebCore::RenderListItem::updateMarkerRenderer): Deleted.

    Moved to RenderTreeUpdater::ListItem.

* rendering/RenderListItem.h:
* rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::willBeDestroyed):
* rendering/TextAutoSizing.cpp:
(WebCore::TextAutoSizingValue::adjustTextNodeSizes):
* style/RenderTreeUpdater.cpp:
(WebCore::RenderTreeUpdater::pushParent):
(WebCore::RenderTreeUpdater::popParent):
(WebCore::RenderTreeUpdater::updateBeforeDescendants):
(WebCore::RenderTreeUpdater::updateAfterDescendants):

    Factor pre/post update into functions.

(WebCore::RenderTreeUpdater::updateBeforeOrAfterPseudoElement):
* style/RenderTreeUpdater.h:
* style/RenderTreeUpdaterListItem.cpp: Added.

    Mutation functions move here.

(WebCore::getParentOfFirstLineBox):
(WebCore::firstNonMarkerChild):
(WebCore::RenderTreeUpdater::ListItem::updateMarker):
* style/RenderTreeUpdaterListItem.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[GTK] Layout Test media/video-controls-no-scripting.html is failing
commit-queue@webkit.org [Fri, 18 Aug 2017 13:41:58 +0000 (13:41 +0000)]
[GTK] Layout Test media/video-controls-no-scripting.html is failing
https://bugs.webkit.org/show_bug.cgi?id=141835

Unreviewed test gardening.

The output appears to be consistent based on local testing.

Rebaseline video-controls-no-scripting.html.

Patch by Ms2ger <Ms2ger@igalia.com> on 2017-08-18

* platform/gtk/TestExpectations:
* platform/gtk/media/video-controls-no-scripting-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUpdate track-datacue.html test to the current code.
commit-queue@webkit.org [Fri, 18 Aug 2017 09:24:35 +0000 (09:24 +0000)]
Update track-datacue.html test to the current code.
https://bugs.webkit.org/show_bug.cgi?id=175624

Patch by Ms2ger <Ms2ger@igalia.com> on 2017-08-18
Reviewed by Eric Carlson.

* media/track/track-datacue-expected.txt: rebaselined.
* media/track/track-datacue.html: updated for IDL, exception changes, addition of a new constructor.
* platform/gtk/TestExpectations: removed failure expectation.
* platform/ios/TestExpectations: enable.
* platform/mac/TestExpectations: enable.
* platform/win/TestExpectations: enable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[GTK] Remove some obsolete expected failures.
commit-queue@webkit.org [Fri, 18 Aug 2017 09:12:38 +0000 (09:12 +0000)]
[GTK] Remove some obsolete expected failures.
https://bugs.webkit.org/show_bug.cgi?id=175674

Unreviewed test gardening.

Patch by Ms2ger <Ms2ger@gmail.com> on 2017-08-18

* platform/gtk/TestExpectations:
  - imported/w3c/web-platform-tests/IndexedDB/keyorder.htm: passing since r204279.
  - imported/w3c/web-platform-tests/resource-timing/rt-cors.html: passing since r212944 and r212993.
  - imported/w3c/web-platform-tests/resource-timing/rt-cors.worker.html: passing since r212944 and r212993.
  - imported/w3c/web-platform-tests/webrtc/getstats.html: passing since test update and rebaseline in r217225.
  - mathml/opentype/large-operators-displaystyle-dynamic.html: used to be flaky, seems to be passing consistently now.
  - media/media-fullscreen-return-to-inline.html: likely passing since r218270.
  - media/video-fast-seek.html: passing since r207879-r207894.
  - platform/gtk/scrollbars/main-frame-scrollbar-horizontal-wheel-scroll.html: passing since r205075.
  - security/contentSecurityPolicy/video-with-data-url-allowed-by-media-src-star.html: flaky.
  - storage/indexeddb/cursor-key-order.html: likely passing since r209135.
  - svg/dom/SVGScriptElement/script-change-externalResourcesRequired-while-loading.svg: flaky.
  - svg/repaint/add-outline-property-on-root.html: passing since r211277
  - svg/repaint/remove-outline-property-on-root.html: passing since r211277

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[GTK] Show controls if a video element isn't allowed to play inline.
commit-queue@webkit.org [Fri, 18 Aug 2017 08:58:34 +0000 (08:58 +0000)]
[GTK] Show controls if a video element isn't allowed to play inline.
https://bugs.webkit.org/show_bug.cgi?id=141705

Patch by Ms2ger <Ms2ger@gmail.com> on 2017-08-18
Reviewed by Xabier Rodriguez-Calvar.

Source/WebCore:

Test: covered by media/video-fullscreeen-only-controls.html [sic].

* Modules/mediacontrols/mediaControlsGtk.js:
(ControllerGtk.prototype.shouldHaveControls):

LayoutTests:

* platform/gtk/TestExpectations: enable test for this case.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[EME] MediaKeySession has to initiate playback resume on HTMLMediaElement
zandobersek@gmail.com [Fri, 18 Aug 2017 07:45:49 +0000 (07:45 +0000)]
[EME] MediaKeySession has to initiate playback resume on HTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=175671

Reviewed by Xabier Rodriguez-Calvar.

In MediaKeySession::updateKeyStatuses(), HTMLMediaElement objects that are
associated with the MediaKeys instance that created this session have to
be notified in order to run the 'Attempt to Resume Playback If Necessary'
algorithm.

MediaKeys object now tracks the sessions that were created through it.
MediaKeySession object is passed a MediaKeys reference, and has that
reference invalidated if/when the MediaKeys object is destroyed.

In MediaKeySession::updateKeyStatuses(), a task is now queued, notifying
the MediaKeys object, if any, that the associated HTMLMediaElement
instances have to run the mentioned algorithm. The associated media
elements are stored through CDMClient pointers, with HTMLMediaElement
class inheriting from the newly-introduced CDMClient interface.

HTMLMediaElement::cdmClientAttemptToResumePlaybackIfNecessary() is left
unimplemented for now. The object will attach itself to and detach from
the associated MediaKeys object in setMediaKeys() and the destructor,
enabling the MediaKeys object to properly dispatch the playback resume
requests for the attached clients.

* Modules/encryptedmedia/CDMClient.h: Copied from Source/WebCore/Modules/encryptedmedia/MediaKeys.h.
(WebCore::CDMClient::~CDMClient):
* Modules/encryptedmedia/MediaKeySession.cpp:
(WebCore::MediaKeySession::create):
(WebCore::MediaKeySession::MediaKeySession):
(WebCore::MediaKeySession::detachKeys):
(WebCore::MediaKeySession::updateKeyStatuses):
* Modules/encryptedmedia/MediaKeySession.h:
* Modules/encryptedmedia/MediaKeys.cpp:
(WebCore::MediaKeys::~MediaKeys):
(WebCore::MediaKeys::createSession):
(WebCore::MediaKeys::attachCDMClient):
(WebCore::MediaKeys::detachCDMClient):
(WebCore::MediaKeys::attemptToResumePlaybackOnClients):
* Modules/encryptedmedia/MediaKeys.h:
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::cdmClientAttemptToResumePlaybackIfNecessary):
* html/HTMLMediaElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, rolling out r220854.
commit-queue@webkit.org [Fri, 18 Aug 2017 07:22:13 +0000 (07:22 +0000)]
Unreviewed, rolling out r220854.
https://bugs.webkit.org/show_bug.cgi?id=175716

I'm not sure we really need this (Requested by KaL on
#webkit).

Reverted changeset:

"[GTK][WPE] Add NTLM authentication enabled API"
https://bugs.webkit.org/show_bug.cgi?id=122952
http://trac.webkit.org/changeset/220854

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[GTK] Make TestContextMenu work on Fedora
mcatanzaro@igalia.com [Fri, 18 Aug 2017 06:27:26 +0000 (06:27 +0000)]
[GTK] Make TestContextMenu work on Fedora
https://bugs.webkit.org/show_bug.cgi?id=175708

Reviewed by Carlos Garcia Campos.

TestContextMenu has been broken for as long as I remember, but not on the bots, only for me
and my student last summer who was trying to work on a context menu API. It's trying to load
an MPEG-2 video file and confirm that right-clicking on it shows media element context menu
entries. Doesn't work on Fedora. Dunno why, since Fedora actually can play MPEG-2, but I
don't care to investigate. Let's switch it to WebM so I can move on.

* TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
(prepareContextMenuTestView):
* TestWebKitAPI/Tests/WebKitGLib/resources/silence.mpg: Removed.
* TestWebKitAPI/Tests/WebKitGLib/resources/silence.webm: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Input Events] Rename inputType "formatForeColor" to "formatFontColor"
wenson_hsieh@apple.com [Fri, 18 Aug 2017 04:13:36 +0000 (04:13 +0000)]
[Input Events] Rename inputType "formatForeColor" to "formatFontColor"
https://bugs.webkit.org/show_bug.cgi?id=175703

Reviewed by Ryosuke Niwa.

Source/WebCore:

Renames an inputType value to match the spec. There is no other change in behavior.
Rebaselines fast/events/input-events-selection-forecolor-data.html and fast/events/input-events-forecolor-data.html.

* editing/EditCommand.cpp:
(WebCore::inputTypeNameForEditingAction):

LayoutTests:

Rebaselines two LayoutTests that check for the "formatForeColor" inputType.

* fast/events/input-events-forecolor-data-expected.txt:
* fast/events/input-events-selection-forecolor-data.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoSpeedometer: Update to modern Vue.js version
commit-queue@webkit.org [Fri, 18 Aug 2017 04:03:24 +0000 (04:03 +0000)]
Speedometer: Update to modern Vue.js version
https://bugs.webkit.org/show_bug.cgi?id=175660

Patch by Mathias Bynens <mathias@qiwi.be> on 2017-08-17
Reviewed by Ryosuke Niwa.

* Speedometer/resources/todomvc/architecture-examples/vuejs-cli/README.md: Documented build process.
* Speedometer/resources/todomvc/architecture-examples/vuejs-cli/config/index.js: Forced relative URLs to avoid breaking the interactive runner.
* Speedometer/resources/todomvc/architecture-examples/vuejs-cli/dist/*: Updated per build steps.
* Speedometer/resources/todomvc/architecture-examples/vuejs-cli/package-lock.json: Added to pin dependencies and make builds deterministic.
* Speedometer/resources/todomvc/architecture-examples/vuejs-cli/package.json: Update to modern Vue.js version.
* Speedometer/resources/todomvc/architecture-examples/vuejs-cli/src/components/Todos.vue: Fix markup error.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoSpeedometer: Update to modern React/Redux version
commit-queue@webkit.org [Fri, 18 Aug 2017 03:51:17 +0000 (03:51 +0000)]
Speedometer: Update to modern React/Redux version
https://bugs.webkit.org/show_bug.cgi?id=175669

Patch by Mathias Bynens <mathias@qiwi.be> on 2017-08-17
Reviewed by Ryosuke Niwa.

* Speedometer/resources/todomvc/architecture-examples/react-redux/README.md: Documented build steps.
* Speedometer/resources/todomvc/architecture-examples/react-redux/dist/*: Updated per build instructions.
* Speedometer/resources/todomvc/architecture-examples/react-redux/package-lock.json: Pinned dependencies to make builds deterministic.
* Speedometer/resources/todomvc/architecture-examples/react-redux/package.json: Fixed build command.
* Speedometer/resources/todomvc/architecture-examples/react-redux/public/index.html: Made title consistent.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWeb Inspector: create better icon for Canvas Path navigation item
mattbaker@apple.com [Fri, 18 Aug 2017 03:13:53 +0000 (03:13 +0000)]
Web Inspector: create better icon for Canvas Path navigation item
https://bugs.webkit.org/show_bug.cgi?id=175274

Reviewed by Joseph Pecoraro.

* UserInterface/Images/Path.svg: Added.
* UserInterface/Views/RecordingContentView.js:
(WI.RecordingContentView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Curl] Improve multi-threaded networking
commit-queue@webkit.org [Fri, 18 Aug 2017 02:17:28 +0000 (02:17 +0000)]
[Curl] Improve multi-threaded networking
https://bugs.webkit.org/show_bug.cgi?id=175253

Patch by Daewoong Jang <daewoong.jang@navercorp.com> on 2017-08-17
Reviewed by Alex Christensen.

* platform/network/curl/CurlContext.cpp:
(WebCore::CurlMultiHandle::CurlMultiHandle):
(WebCore::CurlHandle::CurlHandle):
(WebCore::CurlHandle::initialize):
(WebCore::CurlHandle::setSslKeyPassword):
(WebCore::CurlHandle::setSslErrors):
(WebCore::CurlHandle::getSslErrors):
* platform/network/curl/CurlContext.h:
* platform/network/curl/CurlDownload.cpp:
(WebCore::CurlDownload::init):
(WebCore::CurlDownload::getResponse const):
(WebCore::CurlDownload::setupRequest):
(WebCore::CurlDownload::didReceiveHeader):
(WebCore::CurlDownload::didReceiveData):
(WebCore::CurlDownload::headerCallback):
(WebCore::CurlDownload::getTempPath const): Deleted.
(WebCore::CurlDownload::getUrl const): Deleted.
(WebCore::CurlDownload::downloadFinishedCallback): Deleted.
(WebCore::CurlDownload::downloadFailedCallback): Deleted.
(WebCore::CurlDownload::receivedDataCallback): Deleted.
(WebCore::CurlDownload::receivedResponseCallback): Deleted.
* platform/network/curl/CurlDownload.h:
* platform/network/curl/ResourceError.h:
(WebCore::ResourceError::ResourceError):
(WebCore::ResourceError::sslErrors const):
(WebCore::ResourceError::setSSLErrors): Deleted.
* platform/network/curl/ResourceHandleCurl.cpp:
(WebCore::ResourceHandleInternal::initialize):
(WebCore::ResourceHandleInternal::didFail):
(WebCore::ResourceHandleInternal::dispatchSynchronousJob):
* platform/network/curl/SSLHandle.cpp:
(WebCore::allowedClientHosts):
(WebCore::addAllowedClientCertificate):
(WebCore::getSSLClientCertificate):
(WebCore::certVerifyCallback):
(WebCore::setSSLVerifyOptions):
(WebCore::setSSLClientCertificate): Deleted.
* platform/network/curl/SSLHandle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agocheck-webkit-style shouldn't check spacing in #elif preprocessor lines
commit-queue@webkit.org [Fri, 18 Aug 2017 02:17:06 +0000 (02:17 +0000)]
check-webkit-style shouldn't check spacing in #elif preprocessor lines
https://bugs.webkit.org/show_bug.cgi?id=175652

Patch by Yoshiaki Jitsukawa <Yoshiaki.Jitsukawa@sony.com> on 2017-08-17
Reviewed by Alex Christensen.

* Scripts/webkitpy/style/checkers/cpp.py:
(check_spacing):
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
(CppStyleTest.test_spacing_for_binary_ops):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUpdate to changeSelectionWithTouchAt:baseIsStart:withFlags:
megan_gardner@apple.com [Fri, 18 Aug 2017 01:34:16 +0000 (01:34 +0000)]
Update to changeSelectionWithTouchAt:baseIsStart:withFlags:
https://bugs.webkit.org/show_bug.cgi?id=175615

Update calls to use the flag versions, as they are used for passing state.
Leave old calls, but set them up to be removed next cycle.

Reviewed by Tim Horton.

* Platform/spi/ios/UIKitSPI.h:
* UIProcess/ios/WKContentViewInteraction.mm:
(selectionChangedWithTouch):
(-[WKContentView changeSelectionWithGestureAt:withGesture:withState:]):
(-[WKContentView changeSelectionWithGestureAt:withGesture:withState:withFlags:]):
(-[WKContentView changeSelectionWithTouchAt:withSelectionTouch:baseIsStart:]):
(-[WKContentView changeSelectionWithTouchAt:withSelectionTouch:baseIsStart:withFlags:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWebAssembly: const in unreachable code decoded incorrectly, erroneously rejects binar...
jfbastien@apple.com [Fri, 18 Aug 2017 01:04:00 +0000 (01:04 +0000)]
WebAssembly: const in unreachable code decoded incorrectly, erroneously rejects binary as invalid
https://bugs.webkit.org/show_bug.cgi?id=175693
<rdar://problem/33952443>

Reviewed by Saam Barati.

JSTests:

Add a regression directory for WebAssembly tests.

* wasm.yaml:
* wasm/regress/175693.js: Added.
(else.else):
(instance.new.WebAssembly.Instance.new.WebAssembly.Module):
(catch):
* wasm/regress/175693.wasm: Added.

Source/JavaScriptCore:

64-bit constants in an unreachable context were being decoded as
32-bit constants. This is pretty benign because unreachable code
shouldn't occur often. The effect is that 64-bit constants which
can't be encoded as 32-bit constants would cause the binary to be
rejected.

At the same time, 32-bit integer constants should be decoded as signed.

* wasm/WasmFunctionParser.h:
(JSC::Wasm::FunctionParser<Context>::parseUnreachableExpression):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAdd a Unicode test to RexBench that matches non-BMP characters
msaboff@apple.com [Fri, 18 Aug 2017 00:56:59 +0000 (00:56 +0000)]
Add a Unicode test to RexBench that matches non-BMP characters
https://bugs.webkit.org/show_bug.cgi?id=175697

Reviewed by JF Bastien.

Added a new sub test that simulates 5 card stud poker.  This test uses the Unicode playing
cards code points, U+1F0A1..U+1F0DE, as the card representation.  The scoring of hands is
done using three regular expressions, one to check for a flush, one to check for straights
and one to check for pairs, three of a kind and four of a kind.

* RexBench/UniPoker: Added.
* RexBench/UniPoker/benchmark.js: Added.
(UniPokerBenchmark):
(UniPokerBenchmark.prototype.setup.):
(UniPokerBenchmark.prototype.setup.Math.random):
(UniPokerBenchmark.prototype.setup):
(UniPokerBenchmark.prototype.runOnce):
(UniPokerBenchmark.prototype.validate):
* RexBench/UniPoker/expected.js: Added.
(PlayerExpectation):
(PlayerExpectation.prototype.validate):
* RexBench/UniPoker/poker.js: Added.
(CardDeck):
(CardDeck.prototype.newDeck):
(CardDeck.prototype.shuffle):
(CardDeck.prototype.dealOneCard):
(CardDeck.cardRank):
(CardDeck.cardName):
(Hand):
(Hand.prototype.clear):
(Hand.prototype.takeCard):
(Hand.prototype.score):
(Hand.prototype.get rank):
(Hand.prototype.toString):
(Player):
(Player.prototype.scoreHand):
(Player.prototype.wonHand):
(Player.prototype.get name):
(Player.prototype.get hand):
(Player.prototype.get wins):
(Player.prototype.get handTypeCounts):
(playHands):
* RexBench/about.html:
* RexBench/cli.js:
* RexBench/glue.js:
(driver.reportResult):
* RexBench/index.html:
* RexBench/unipoker_benchmark.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoMark media/video-controls-rendering.html as flaky.
ryanhaddad@apple.com [Fri, 18 Aug 2017 00:54:17 +0000 (00:54 +0000)]
Mark media/video-controls-rendering.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=175700

Unreviewed test gardening.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUseedate TestExpectations for media/video-controls-show-on-kb-or-ax-event.html.
ryanhaddad@apple.com [Fri, 18 Aug 2017 00:46:47 +0000 (00:46 +0000)]
Useedate TestExpectations for media/video-controls-show-on-kb-or-ax-event.html.
https://bugs.webkit.org/show_bug.cgi?id=158889

Unreviewed test gardening.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoTeach DFGFixupPhase.cpp that the current scope is always a cell
commit-queue@webkit.org [Fri, 18 Aug 2017 00:19:39 +0000 (00:19 +0000)]
Teach DFGFixupPhase.cpp that the current scope is always a cell
https://bugs.webkit.org/show_bug.cgi?id=175610

Patch by Robin Morisset <rmorisset@apple.com> on 2017-08-17
Reviewed by Keith Miller.

Also teach it that the argument to with can usually be speculated to be an object,
since toObject() is called on it.

* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePushWithScope):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compilePushWithScope):
* jit/JITOperations.cpp:
* jit/JITOperations.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoMarked accessibility/mac/select-element-selection-with-optgroups.html as flaky.
jlewis3@apple.com [Thu, 17 Aug 2017 23:32:18 +0000 (23:32 +0000)]
Marked accessibility/mac/select-element-selection-with-optgroups.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=175341

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRegression(r220817): We should only copy the original request headers for Ping loads
cdumez@apple.com [Thu, 17 Aug 2017 22:56:59 +0000 (22:56 +0000)]
Regression(r220817): We should only copy the original request headers for Ping loads
https://bugs.webkit.org/show_bug.cgi?id=175679

Reviewed by Youenn Fablet.

Source/WebCore:

For performance reason, we should only copy the original request headers for Ping loads
(Beacon at the moment), not for all CachedResourceRequests.

* loader/LoaderStrategy.h:
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::CachedResource):
(WebCore::CachedResource::load):
* loader/cache/CachedResource.h:
(WebCore::CachedResource::shouldUsePingLoad):
(WebCore::CachedResource::setOriginalRequestHeaders):
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestResource):
* loader/cache/CachedResourceRequest.cpp:
(WebCore::CachedResourceRequest::CachedResourceRequest):
* loader/cache/CachedResourceRequest.h:
(WebCore::CachedResourceRequest::releaseResourceRequest):
(WebCore::CachedResourceRequest::releaseOriginalRequestHeaders): Deleted.

Source/WebKit:

For performance reason, we should only copy the original request headers for Ping loads
(Beacon at the moment), not for all CachedResourceRequests.

* NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::loadPing):
* NetworkProcess/NetworkConnectionToWebProcess.h:
* NetworkProcess/NetworkConnectionToWebProcess.messages.in:
* NetworkProcess/NetworkResourceLoadParameters.cpp:
(WebKit::NetworkResourceLoadParameters::encode const):
(WebKit::NetworkResourceLoadParameters::decode):
* NetworkProcess/NetworkResourceLoadParameters.h:
* NetworkProcess/PingLoad.cpp:
(WebKit::PingLoad::PingLoad):
(WebKit::PingLoad::willPerformHTTPRedirection):
(WebKit::PingLoad::makeCrossOriginAccessRequest):
(WebKit::PingLoad::makeSimpleCrossOriginAccessRequest):
(WebKit::PingLoad::originalRequestHeaders const): Deleted.
* NetworkProcess/PingLoad.h:
* WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::WebLoaderStrategy::createPingHandle):
* WebProcess/Network/WebLoaderStrategy.h:

Source/WebKitLegacy:

* WebCoreSupport/WebResourceLoadScheduler.cpp:
(WebResourceLoadScheduler::createPingHandle):
* WebCoreSupport/WebResourceLoadScheduler.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[PAL] Relocate SessionID to root
don.olmstead@sony.com [Thu, 17 Aug 2017 22:48:54 +0000 (22:48 +0000)]
[PAL] Relocate SessionID to root
https://bugs.webkit.org/show_bug.cgi?id=175684

Reviewed by Alex Christensen.

Source/WebCore:

No new tests. No change in functionality.

* dom/Document.h:
* html/HTMLMediaElement.cpp:
* loader/cache/CachedResource.h:
* loader/cache/CachedResourceLoader.cpp:
* loader/cache/MemoryCache.h:
* loader/cocoa/DiskCacheMonitorCocoa.h:
* page/CacheStorageProvider.h:
* page/Page.h:
* page/PlugInClient.h:
* page/SocketProvider.h:
* platform/CookiesStrategy.h:
* platform/WebCoreCrossThreadCopier.cpp:
* platform/network/CacheValidation.h:
* platform/network/NetworkStorageSession.cpp:
* platform/network/NetworkStorageSession.h:
* platform/network/cf/SocketStreamHandleImpl.h:
* platform/network/curl/SocketStreamHandleImpl.h:
* platform/network/soup/SocketStreamHandleImpl.h:
* workers/WorkerGlobalScope.h:
* workers/service/ServiceWorkerContainer.h:
* workers/service/ServiceWorkerRegistrationParameters.h:

Source/WebCore/PAL:

* PAL.xcodeproj/project.pbxproj:
* pal/CMakeLists.txt:
* pal/SessionID.cpp: Renamed from Source/WebCore/PAL/pal/identifier/SessionID.cpp.
* pal/SessionID.h: Renamed from Source/WebCore/PAL/pal/identifier/SessionID.h.

Source/WebKit:

* NetworkProcess/Downloads/Download.h:
* NetworkProcess/Downloads/DownloadManager.cpp:
* NetworkProcess/NetworkCORSPreflightChecker.h:
* NetworkProcess/NetworkConnectionToWebProcess.cpp:
* NetworkProcess/NetworkLoad.cpp:
* NetworkProcess/NetworkLoadParameters.h:
* NetworkProcess/NetworkProcess.cpp:
* NetworkProcess/NetworkProcess.h:
* NetworkProcess/NetworkResourceLoadParameters.h:
* NetworkProcess/NetworkSession.h:
* NetworkProcess/NetworkSocketStream.h:
* NetworkProcess/RemoteNetworkingContext.h:
* NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp:
* Scripts/webkit/messages.py:
(forward_declarations_and_headers.templates): Deleted.
(class_template_headers.template): Deleted.
* Shared/ChildProcess.cpp:
* Shared/SessionTracker.h:
* Shared/Storage/StorageProcessCreationParameters.h:
* Shared/WebCoreArgumentCoders.cpp:
* Shared/WebPageCreationParameters.h:
* Shared/WebProcessCreationParameters.h:
* Shared/WebsiteDataStoreParameters.h:
* Shared/mac/CookieStorageShim.mm:
* StorageProcess/IndexedDB/WebIDBConnectionToClient.h:
* StorageProcess/StorageProcess.cpp:
* StorageProcess/StorageProcess.h:
* StorageProcess/StorageToWebProcessConnection.h:
* UIProcess/API/APIPageConfiguration.h:
* UIProcess/API/APIWebsiteDataStore.h:
* UIProcess/API/glib/WebKitCookieManager.cpp:
* UIProcess/Plugins/PlugInAutoStartProvider.h:
* UIProcess/WebCookieManagerProxy.h:
* UIProcess/WebProcessPool.cpp:
* UIProcess/WebProcessPool.h:
* UIProcess/WebProcessProxy.h:
* UIProcess/WebsiteData/WebsiteDataStore.h:
* WebProcess/Cookies/WebCookieManager.h:
* WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.h:
* WebProcess/Databases/WebDatabaseProvider.cpp:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
* WebProcess/Network/NetworkProcessConnection.cpp:
* WebProcess/Network/WebLoaderStrategy.cpp:
* WebProcess/Network/WebSocketStream.cpp:
* WebProcess/Network/WebSocketStream.h:
* WebProcess/Storage/WebToStorageProcessConnection.h:
* WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
* WebProcess/WebCoreSupport/WebPlugInClient.h:
* WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h:
* WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.cpp:
* WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.h:
* WebProcess/WebPage/WebPage.cpp:
* WebProcess/WebProcess.h:

Source/WebKitLegacy:

* Storage/WebDatabaseProvider.cpp:

Source/WebKitLegacy/mac:

* WebCoreSupport/WebFrameNetworkingContext.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRebaseline js/dom/global-constructors-attributes.html for Sierra.
ryanhaddad@apple.com [Thu, 17 Aug 2017 22:47:03 +0000 (22:47 +0000)]
Rebaseline js/dom/global-constructors-attributes.html for Sierra.

Unreviewed test gardening.

* platform/mac/js/dom/global-constructors-attributes-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRebaseline two tests after r220870.
ryanhaddad@apple.com [Thu, 17 Aug 2017 22:41:08 +0000 (22:41 +0000)]
Rebaseline two tests after r220870.

Unreviewed test gardening.

* inspector/dom/content-node-region-info-expected.txt:
* platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoMark inspector/canvas/context-attributes.html as flaky.
ryanhaddad@apple.com [Thu, 17 Aug 2017 22:41:05 +0000 (22:41 +0000)]
Mark inspector/canvas/context-attributes.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=173931

Unreviewed test gardening.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoFix the build on other platforms after r220865
wenson_hsieh@apple.com [Thu, 17 Aug 2017 22:20:02 +0000 (22:20 +0000)]
Fix the build on other platforms after r220865
https://bugs.webkit.org/show_bug.cgi?id=175683

Reviewed by Tim Horton.

Source/WebCore:

Instead of special casing iOS 10 behavior with __IPHONE_OS_VERSION_MAX_ALLOWED < 110000, revert to special
casing iOS 11 behavior with __IPHONE_OS_VERSION_MAX_ALLOWED >= 110000. This is because other targets that are
neither iOS 10 nor 11 will fail the "before iOS 11" compile-time check, and subsequently assume that item
providers exist. To fix this, flip the compiler-time checks and the order of codeblocks in the
PlatformPasteboard::write methods.

There is no change in behavior.

* platform/ios/PlatformPasteboardIOS.mm:
(WebCore::registerItemToPasteboard):
(WebCore::PlatformPasteboard::write):

Tools:

Check __IPHONE_OS_VERSION_MAX_ALLOWED instead of __IPHONE_OS_VERSION_MIN_REQUIRED in an SPI header. SPI
availability is determined by SDK version rather than deployment version.

* TestWebKitAPI/ios/UIKitSPI.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoNumber each section in ReadMe.md and add more clarifications
rniwa@webkit.org [Thu, 17 Aug 2017 22:03:37 +0000 (22:03 +0000)]
Number each section in ReadMe.md and add more clarifications
https://bugs.webkit.org/show_bug.cgi?id=175687

Rubber-stamped by Joseph Pecoraro.

Numbered each section and added more clarifications per issues Aakash encountered.

* ReadMe.md:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoMarked fast/hidpi/hidpi-long-page-with-inset-element.html as a flaky ImageOnlyFailure.
jlewis3@apple.com [Thu, 17 Aug 2017 21:50:37 +0000 (21:50 +0000)]
Marked fast/hidpi/hidpi-long-page-with-inset-element.html as a flaky ImageOnlyFailure.
https://bugs.webkit.org/show_bug.cgi?id=172384

Unreviewed test gardening.

* platform/ios-simulator-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoREGRESSION (r220601): Crash under ProcessAssertion::markAsInvalidated()
cdumez@apple.com [Thu, 17 Aug 2017 21:40:15 +0000 (21:40 +0000)]
REGRESSION (r220601): Crash under ProcessAssertion::markAsInvalidated()
https://bugs.webkit.org/show_bug.cgi?id=175685
<rdar://problem/33868623>

Reviewed by Sam Weinig.

After r220601, it is no longer safe to call a default-initialized WTF::Function.

* UIProcess/ios/ProcessAssertionIOS.mm:
(WebKit::ProcessAssertion::markAsInvalidated):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoBuild fix. Make the test work with the latest versions of node modules.
rniwa@webkit.org [Thu, 17 Aug 2017 21:23:46 +0000 (21:23 +0000)]
Build fix. Make the test work with the latest versions of node modules.

* server-tests/privileged-api-upload-file-tests.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago-Wreturn-type warnings in CryptoKey.cpp and SubtleCrypto.cpp
mcatanzaro@igalia.com [Thu, 17 Aug 2017 21:17:34 +0000 (21:17 +0000)]
-Wreturn-type warnings in CryptoKey.cpp and SubtleCrypto.cpp
https://bugs.webkit.org/show_bug.cgi?id=175675

Reviewed by Jiewen Tan.

* crypto/CryptoKey.cpp:
(WebCore::CryptoKey::algorithm const):
* crypto/SubtleCrypto.cpp:
(WebCore::toCryptoKeyUsageBitmap):
(WebCore::toKeyData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWeb Inspector: Styles: replace "Enter Class Name" with "Add New Class"
nvasilyev@apple.com [Thu, 17 Aug 2017 20:54:17 +0000 (20:54 +0000)]
Web Inspector: Styles: replace "Enter Class Name" with "Add New Class"
https://bugs.webkit.org/show_bug.cgi?id=175686

Reviewed by Matt Baker.

"Enter Class Name" isn't very descriptive. It doesn't suggest what's going to happen after you enter a class name.

* Localizations/en.lproj/localizedStrings.js:
* UserInterface/Views/CSSStyleDetailsSidebarPanel.js:
(WI.CSSStyleDetailsSidebarPanel.prototype.initialLayout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoChanged expectations to include release for memory/memory-pressure-simulation.html.
jlewis3@apple.com [Thu, 17 Aug 2017 20:38:15 +0000 (20:38 +0000)]
Changed expectations to include release for memory/memory-pressure-simulation.html.
https://bugs.webkit.org/show_bug.cgi?id=170629

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWeb Inspector: Ensure three.js gets minified properly for production builds.
commit-queue@webkit.org [Thu, 17 Aug 2017 20:30:12 +0000 (20:30 +0000)]
Web Inspector: Ensure three.js gets minified properly for production builds.
https://bugs.webkit.org/show_bug.cgi?id=175452

Patch by Ross Kirsling <ross.kirsling@sony.com> on 2017-08-17
Reviewed by Brian Burg.

* Scripts/copy-user-interface-resources.pl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWeb Inspector: remove unused private struct from InspectorScriptProfilerAgent
mattbaker@apple.com [Thu, 17 Aug 2017 20:25:32 +0000 (20:25 +0000)]
Web Inspector: remove unused private struct from InspectorScriptProfilerAgent
https://bugs.webkit.org/show_bug.cgi?id=175644

Reviewed by Brian Burg.

* inspector/agents/InspectorScriptProfilerAgent.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoOnly use 16 VFP registers if !CPU(ARM_NEON).
mark.lam@apple.com [Thu, 17 Aug 2017 19:57:46 +0000 (19:57 +0000)]
Only use 16 VFP registers if !CPU(ARM_NEON).
https://bugs.webkit.org/show_bug.cgi?id=175514

Reviewed by JF Bastien.

Source/JavaScriptCore:

Deleted q16-q31 FPQuadRegisterID enums in ARMv7Assembler.h.  The NEON spec
says that there are only 16 128-bit NEON registers.  This change is merely to
correct the code documentation of these registers.  The FPQuadRegisterID are
currently unused.

* assembler/ARMAssembler.h:
(JSC::ARMAssembler::lastFPRegister):
(JSC::ARMAssembler::fprName):
* assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::lastFPRegister):
(JSC::ARMv7Assembler::fprName):
* assembler/MacroAssemblerARM.cpp:
* assembler/MacroAssemblerARMv7.cpp:

Source/WTF:

If CPU(ARM_NEON) is not enabled, we'll conservatively assume only VFP2 support is
available. Hence, we'll only the first 16 FPDoubleRegisterIDs are available.

For reference, see:
NEON registers: http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0473c/CJACABEJ.html
VFP2 and VFP3 registers: http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0473c/CIHDIBDG.html
NEON to VFP register mapping: http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0473c/CJAIJHFC.html

This is mostly for GTK toolchains which may target older ARM CPUs which only have
VFP2 support.

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoDisable CSS regions at compile time
akling@apple.com [Thu, 17 Aug 2017 19:18:54 +0000 (19:18 +0000)]
Disable CSS regions at compile time
https://bugs.webkit.org/show_bug.cgi?id=175630

Reviewed by Antti Koivisto.

.:

* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsMac.cmake:
* Source/cmake/OptionsWPE.cmake:
* Source/cmake/OptionsWin.cmake:
* Source/cmake/tools/vsprops/FeatureDefines.props:
* Source/cmake/tools/vsprops/FeatureDefinesCairo.props:

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore/PAL:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit:

* Configurations/FeatureDefines.xcconfig:

Source/WebKitLegacy/mac:

* Configurations/FeatureDefines.xcconfig:

Tools:

* Scripts/webkitperl/FeatureList.pm:
* TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

LayoutTests:

Skip tests that are entirely about regions, and tweak logic
and/or expectations for tests that test regions in addition to
other things.

* TestExpectations:
* fast/css/will-change/resources/will-change-stacking-helper.js:
* fast/dom/collection-iterators-expected.txt:
* fast/dom/collection-iterators.html:
* js/dom/dom-static-property-for-in-iteration-expected.txt:
* platform/gtk/js/dom/dom-static-property-for-in-iteration-expected.txt:
* platform/ios/fast/dom/collection-iterators-expected.txt:
* platform/mac-wk2/TestExpectations:
* platform/win/js/dom/dom-static-property-for-in-iteration-expected.txt:
* platform/wpe/js/dom/dom-static-property-for-in-iteration-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, try to fix the internal iOS 10 build after r220865.
wenson_hsieh@apple.com [Thu, 17 Aug 2017 19:01:08 +0000 (19:01 +0000)]
Unreviewed, try to fix the internal iOS 10 build after r220865.

* TestWebKitAPI/ios/UIKitSPI.h:

On the iOS 10 SDK, UIApplication_Private.h cannot be imported in the simulator. Simply fall back to using the
extern declaration when building for pre-iOS 11; once the bots stop building for iOS 10, we can safely remove
this compiler guard.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[iOS] Respect type fidelities when copying image elements to the pasteboard
wenson_hsieh@apple.com [Thu, 17 Aug 2017 18:34:15 +0000 (18:34 +0000)]
[iOS] Respect type fidelities when copying image elements to the pasteboard
https://bugs.webkit.org/show_bug.cgi?id=175638
<rdar://problem/26556043>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Ensures that we respect type fidelities when copying on iOS, by unifying pasteboard writing codepaths across
dragging and copying. When dragging and copying, we now generate and set UIItemProviders on the UIPasteboard.

Tests: ActionSheetTests.CopyImageElementWithHREF
       ActionSheetTests.CopyImageElementWithoutHREF

* platform/PlatformPasteboard.h:

Remove all variants of the writeObjectRepresentations helper method. Now that both paths for writing to the
pasteboard are unified, it's no longer useful to separate out item-provider-based pasteboard logic.

* platform/ios/AbstractPasteboard.h:
* platform/ios/PlatformPasteboardIOS.mm:

Replaces -setItemsUsingRegistrationInfoLists: with -setRegistrationInfoLists:. Rather than have a helper that
both sets up item providers and item registration lists, split this functionality out into two setters. This is
because UIPasteboard does not need to know about the registration info lists used to set up the item providers
in the first place, but internal drag-and-drop clients require this information immediately when starting a drag
in order to construct custom drag previews.

(WebCore::richTextRepresentationsForPasteboardWebContent):
(WebCore::registerItemToPasteboard):

Add a new helper to register item providers to the pasteboard, given an WebItemProviderRegistrationInfoList.

(WebCore::PlatformPasteboard::write):
(WebCore::PlatformPasteboard::writeObjectRepresentations): Deleted.

Refactors PlatformPasteboard::write to always generate and set item providers, unless we're building for an SDK
prior to iOS 11. For images, strings and URLs, we can simply transition to using the new item-provider-based
codepaths used for drag and drop. For web content, we add two additional UTIs that were present when copying,
but not when dragging: flat RTFD and a string constant used to indicate to UIKit that the pasteboard contains
rich text.

* platform/ios/WebItemProviderPasteboard.h:
* platform/ios/WebItemProviderPasteboard.mm:
(-[WebItemProviderRegistrationInfoList init]):
(-[WebItemProviderRegistrationInfoList addData:forType:]):
(-[WebItemProviderRegistrationInfoList addRepresentingObject:]):
(-[WebItemProviderRegistrationInfoList numberOfItems]):
(-[WebItemProviderRegistrationInfoList itemAtIndex:]):
(-[WebItemProviderRegistrationInfoList itemProvider]):
(-[WebItemProviderRegistrationInfoList description]):

Make some small tweaks in WebItemProviderPasteboard (and related classes):
1. Transition to preferredPresentationSize from estimatedDisplayedSize, which is now deprecated.
2. Remove calls to -initWithItemProviderData:typeIdentifier:error:, which is deprecated.
3. Rename _items to _representations to better reflect the role of WebItemProviderRegistrationInfo.
4. Implement -description for WebItemProviderRegistrationInfoList for debugging purposes.

(-[WebItemProviderPasteboard valuesForPasteboardType:inItemSet:]):
(-[WebItemProviderPasteboard setRegistrationInfoLists:]):
(-[WebItemProviderPasteboard setItemsUsingRegistrationInfoLists:]): Deleted.

Source/WebCore/PAL:

Replace -estimatedDisplayedSize with its non-deprecated counterpart, -preferredPresentationSize.

* pal/spi/ios/UIKitSPI.h:

Source/WebKit:

Currently, we treat the case when copying an image enclosed by a link by only writing a URL to the pasteboard.
This patch tweaks logic in WebPage::performActionOnElement to write both an image and a link to the pasteboard
if the hit-tested image element is enclosed by an anchor.

* Platform/spi/ios/UIKitSPI.h:
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::containingLinkElement):

Tweak this helper to be more restrictive when finding an enclosing 'link' -- only return an element if isLink()
is true, and it is an HTMLAnchorElement. Currently, the isLink() also matches HTMLLinkElements, but this isn't
the intention here.

(WebKit::WebPage::performActionOnElement):

Tools:

Add API tests that simulate copying an image element using the action sheet, and verifying that the pasteboard
contains UTIs in order of fidelity (image type before URL). Also pulls out UIKit SPI (UIApplicationInitialize)
used in UIPasteboardTests and ActionSheetTests into a common UIKitSPI header.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
(-[ActionSheetObserver _webView:actionsForElement:defaultActions:]):
(TestWebKitAPI::TEST):
(TestWebKitAPI::presentActionSheetAndChooseAction):
(-[ActionSheetObserver waitForActionSheetAfterBlock:]): Deleted.
* TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
(checkEstimatedSize):
(checkSuggestedNameAndEstimatedSize):

Replace -estimatedDisplayedSize with its non-deprecated counterpart, -preferredPresentationSize.

* TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
(TestWebKitAPI::TEST):
* TestWebKitAPI/ios/DataInteractionSimulator.h:
* TestWebKitAPI/ios/UIKitSPI.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRecursively create resource load statistics folder for testing
jbedard@apple.com [Thu, 17 Aug 2017 18:21:27 +0000 (18:21 +0000)]
Recursively create resource load statistics folder for testing
https://bugs.webkit.org/show_bug.cgi?id=175676

Reviewed by Brady Eidson.

* WebKitTestRunner/cocoa/TestControllerCocoa.mm:
(WTR::TestController::cocoaPlatformInitialize): Recursively create resourceLoadStatisticsFolder.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAdd a DOMPromiseDeferred method to handle ExceptionOr<> results
commit-queue@webkit.org [Thu, 17 Aug 2017 18:07:26 +0000 (18:07 +0000)]
Add a DOMPromiseDeferred method to handle ExceptionOr<> results
https://bugs.webkit.org/show_bug.cgi?id=175603

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-17
Reviewed by Darin Adler.

No change of behavior.

Introduce DOMPromiseDeferred::settle to reject/resolve a promise with an ExceptionOr<>.
Making batchPutOperation/batchDeleteOperation take a Function with an ExceptionOr<>.
Using DOMPromiseDeferred::settle in Cache put/remove.
Updated CacheStorageConnection to create ExceptionOr<> from CacheStorageConnection::Error.

* Modules/cache/Cache.cpp:
(WebCore::Cache::put):
(WebCore::Cache::remove):
(WebCore::Cache::batchDeleteOperation):
(WebCore::Cache::batchPutOperation):
* Modules/cache/Cache.h:
* Modules/cache/CacheStorage.cpp:
(WebCore::CacheStorage::open):
(WebCore::CacheStorage::remove):
* Modules/cache/CacheStorageConnection.cpp:
(WebCore::CacheStorageConnection::errorToException):
* Modules/cache/CacheStorageConnection.h:
(WebCore::CacheStorageConnection::errorToException):
(WebCore::CacheStorageConnection::exceptionOrResult):
* bindings/js/JSDOMPromiseDeferred.h:
(WebCore::DOMPromiseDeferred::settle):
(WebCore::DOMPromiseDeferred<void>::settle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[GStreamer] AppendPipeline: support dispatch of decryption-specific GstStructure...
zandobersek@gmail.com [Thu, 17 Aug 2017 16:40:56 +0000 (16:40 +0000)]
[GStreamer] AppendPipeline: support dispatch of decryption-specific GstStructure into the pipeline
https://bugs.webkit.org/show_bug.cgi?id=175668

Reviewed by Xabier Rodriguez-Calvar.

Add the AppendPipeline::dispatchDecryptionStructure() method. Callers can
pass in a GstStructure object that contains all the information the
decryption elements in the pipeline will require to properly decrypt the
content. In case the decryptor element isn't available yet, the
GstStructure is stored and dispatched when that element becomes available.

The dispatch itself simply creates a new custom GstEvent that adopts the
given GstStructure object, sends that into the pipeline element, and
shifts the state to 'ongoing'.

* platform/graphics/gstreamer/mse/AppendPipeline.cpp:
(WebCore::AppendPipeline::connectDemuxerSrcPadToAppsinkFromAnyThread):
(WebCore::AppendPipeline::dispatchPendingDecryptionStructure):
(WebCore::AppendPipeline::dispatchDecryptionStructure):
* platform/graphics/gstreamer/mse/AppendPipeline.h: Remove a redundant private: label.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[GStreamer] GstStructure shouldn't be handled through GRefPtr
zandobersek@gmail.com [Thu, 17 Aug 2017 16:37:28 +0000 (16:37 +0000)]
[GStreamer] GstStructure shouldn't be handled through GRefPtr
https://bugs.webkit.org/show_bug.cgi?id=175673

Reviewed by Xabier Rodriguez-Calvar.

* platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp:
(webkitMediaCommonEncryptionDecryptTransformCaps): GstStructure isn't
ref-counted, so it should be handled through the GUniquePtr<GstStructure>
smart pointer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[WPE][GTK] Ensure proper casting of data in gvariants
commit-queue@webkit.org [Thu, 17 Aug 2017 16:17:19 +0000 (16:17 +0000)]
[WPE][GTK] Ensure proper casting of data in gvariants
https://bugs.webkit.org/show_bug.cgi?id=175667

Patch by Jacobo Aragunde Pérez <jaragunde@igalia.com> on 2017-08-17
Reviewed by Michael Catanzaro.

Source/JavaScriptCore:

g_variant_new requires data to have the correct width for their types, using
casting if necessary. Some data of type `unsigned` were being saved to `guint64`
types without explicit casting, leading to undefined behavior in some platforms.

* inspector/remote/glib/RemoteInspectorGlib.cpp:
(Inspector::RemoteInspector::listingForInspectionTarget const):
(Inspector::RemoteInspector::listingForAutomationTarget const):
(Inspector::RemoteInspector::sendMessageToRemote):

Source/WebKit:

g_variant_builder_add requires data to have the correct width for their types, using
casting if necessary. Corrected a call where a single precision float was being put
into a double precision parameter without a cast.

* UIProcess/API/glib/WebKitWebViewSessionState.cpp:
(encodeFrameState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220860 268f45cc-cd09-0410-ab3c-d52691b4dbfc