mitz@apple.com [Tue, 11 Nov 2008 09:11:30 +0000 (09:11 +0000)]
2008-11-11 Pierre-Olivier Latour <pol@apple.com>
Rubber-stamped by Dan Bernstein
https://bugs.webkit.org/show_bug.cgi?id=21821
Remaining set of updated expected pixel results. This includes http/,
media/, plugins/, scrollbars/, tables/, transforms/, transitions/ and
webarchive/.
(file listing elided)
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38297
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Tue, 11 Nov 2008 09:10:58 +0000 (09:10 +0000)]
2008-11-11 Maciej Stachowiak <mjs@apple.com>
Reviewed by Mark Rowe.
- remove inline capacity from declaration stacks (15M savings on membuster test)
No perf regression on SunSpider or V8 test combined with other upcoming memory improvement patch.
* JavaScriptCore.exp:
* parser/Nodes.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38296
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cwzwarich@webkit.org [Tue, 11 Nov 2008 08:06:47 +0000 (08:06 +0000)]
2008-11-11 Cameron Zwarich <zwarich@apple.com>
Reviewed by Oliver Hunt.
While r38286 removed the need for the m_callFrame member variable of
CTI, it should be also be removed.
* VM/CTI.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38295
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cwzwarich@webkit.org [Tue, 11 Nov 2008 07:57:57 +0000 (07:57 +0000)]
2008-11-10 Cameron Zwarich <zwarich@apple.com>
Reviewed by Oliver Hunt.
Make CTI::asInteger() a non-member function, since it needs no access to
any of CTI's member variables.
* VM/CTI.cpp:
(JSC::asInteger):
* VM/CTI.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38294
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
slewis@apple.com [Tue, 11 Nov 2008 07:06:41 +0000 (07:06 +0000)]
2008-11-10 Stephanie Lewis <slewis@apple.com>
Reviewed by Dan Bernstein.
Clear the image source cache even if we haven't decoded any of the image data.
We use the image source cache when calculating layout.
* loader/Cache.cpp:
(WebCore::Cache::pruneDeadResources):
* platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::destroyDecodedData):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38293
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cwzwarich@webkit.org [Tue, 11 Nov 2008 06:04:37 +0000 (06:04 +0000)]
2008-11-10 Cameron Zwarich <zwarich@apple.com>
Reviewed by Maciej Stachowiak.
Use 'value' instead of 'js' in CTI as a name for JSValue* to match our
usual convention elsewhere.
* VM/CTI.cpp:
(JSC::CTI::emitGetArg):
(JSC::CTI::emitGetPutArg):
(JSC::CTI::getConstantImmediateNumericArg):
(JSC::CTI::printOpcodeOperandTypes):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38292
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cwzwarich@webkit.org [Tue, 11 Nov 2008 05:55:50 +0000 (05:55 +0000)]
2008-11-10 Cameron Zwarich <zwarich@apple.com>
Reviewed by Maciej Stachowiak.
Make CTI::getConstant() a member function of CodeBlock instead.
* VM/CTI.cpp:
(JSC::CTI::emitGetArg):
(JSC::CTI::emitGetPutArg):
(JSC::CTI::getConstantImmediateNumericArg):
(JSC::CTI::printOpcodeOperandTypes):
(JSC::CTI::privateCompileMainPass):
* VM/CTI.h:
* VM/CodeBlock.h:
(JSC::CodeBlock::getConstant):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38291
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cwzwarich@webkit.org [Tue, 11 Nov 2008 05:45:14 +0000 (05:45 +0000)]
2008-11-10 Cameron Zwarich <zwarich@apple.com>
Reviewed by Sam Weinig.
Rename CodeBlock::isConstant() to isConstantRegisterIndex().
* VM/CTI.cpp:
(JSC::CTI::emitGetArg):
(JSC::CTI::emitGetPutArg):
(JSC::CTI::getConstantImmediateNumericArg):
(JSC::CTI::printOpcodeOperandTypes):
(JSC::CTI::privateCompileMainPass):
* VM/CodeBlock.h:
(JSC::CodeBlock::isConstantRegisterIndex):
* bytecompiler/CodeGenerator.cpp:
(JSC::CodeGenerator::emitEqualityOp):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38290
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Tue, 11 Nov 2008 05:40:13 +0000 (05:40 +0000)]
non-CTI build fix take 2
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38289
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Tue, 11 Nov 2008 05:31:49 +0000 (05:31 +0000)]
non-CTI build fix
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38288
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cwzwarich@webkit.org [Tue, 11 Nov 2008 05:22:55 +0000 (05:22 +0000)]
2008-11-10 Cameron Zwarich <zwarich@apple.com>
Reviewed by Sam Weinig.
Remove the unused labels member variable of CodeBlock.
* VM/CodeBlock.h:
* VM/LabelID.h:
(JSC::LabelID::setLocation):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38287
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Tue, 11 Nov 2008 05:09:46 +0000 (05:09 +0000)]
2008-11-10 Gavin Barraclough <barraclough@apple.com>
Reviewed by Camron Zwarich.
Batch compile the set of static trampolines at the point Machine is constructed, using a single allocation.
Refactor out m_callFrame from CTI, since this is only needed to access the global data (instead store a
pointer to the global data directly, since this is available at the point the Machine is constructed).
Add a method to align the code buffer, to allow JIT generation for multiple trampolines in one block.
* VM/CTI.cpp:
(JSC::CTI::getConstant):
(JSC::CTI::emitGetArg):
(JSC::CTI::emitGetPutArg):
(JSC::CTI::getConstantImmediateNumericArg):
(JSC::CTI::printOpcodeOperandTypes):
(JSC::CTI::CTI):
(JSC::CTI::compileBinaryArithOp):
(JSC::CTI::privateCompileMainPass):
(JSC::CTI::privateCompileGetByIdProto):
(JSC::CTI::privateCompileGetByIdChain):
(JSC::CTI::privateCompileCTIMachineTrampolines):
(JSC::CTI::freeCTIMachineTrampolines):
* VM/CTI.h:
(JSC::CTI::compile):
(JSC::CTI::compileGetByIdSelf):
(JSC::CTI::compileGetByIdProto):
(JSC::CTI::compileGetByIdChain):
(JSC::CTI::compilePutByIdReplace):
(JSC::CTI::compilePutByIdTransition):
(JSC::CTI::compileCTIMachineTrampolines):
(JSC::CTI::compilePatchGetArrayLength):
* VM/Machine.cpp:
(JSC::Machine::initialize):
(JSC::Machine::~Machine):
(JSC::Machine::execute):
(JSC::Machine::tryCTICachePutByID):
(JSC::Machine::tryCTICacheGetByID):
(JSC::Machine::cti_op_call_JSFunction):
(JSC::Machine::cti_vm_lazyLinkCall):
* VM/Machine.h:
* masm/X86Assembler.h:
(JSC::JITCodeBuffer::isAligned):
(JSC::X86Assembler::):
(JSC::X86Assembler::align):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38286
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Tue, 11 Nov 2008 03:51:24 +0000 (03:51 +0000)]
2008-11-10 Maciej Stachowiak <mjs@apple.com>
Reviewed by Antti Koivisto.
- Make Vector::clear() release the Vector's memory (1MB savings on membuster)
https://bugs.webkit.org/show_bug.cgi?id=22170
* wtf/Vector.h:
(WTF::VectorBufferBase::deallocateBuffer): Set capacity to 0 as
well as size, otherwise shrinking capacity to 0 can fail to reset
the capacity and thus cause a future crash.
(WTF::Vector::~Vector): Shrink size not capacity; we only need
to call destructors, the buffer will be freed anyway.
(WTF::Vector::clear): Change this to shrinkCapacity(0), not just shrink(0).
(WTF::::shrinkCapacity): Use shrink() instead of resize() for case where
the size is greater than the new capacity, to work with types that have no
default constructor.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38285
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cwzwarich@webkit.org [Tue, 11 Nov 2008 03:38:18 +0000 (03:38 +0000)]
2008-11-10 Cameron Zwarich <zwarich@apple.com>
Reviewed by Maciej Stachowiak.
Split multiple definitions into separate lines.
* VM/CTI.cpp:
(JSC::CTI::compileBinaryArithOp):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38284
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 11 Nov 2008 01:26:35 +0000 (01:26 +0000)]
2008-11-10 Anders Carlsson <andersca@apple.com>
Reviewed by Kevin Decker.
Move renewGState to the base class.
* Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView renewGState]):
* Plugins/WebNetscapePluginView.mm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38283
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 11 Nov 2008 01:23:36 +0000 (01:23 +0000)]
2008-11-10 Anders Carlsson <andersca@apple.com>
Reviewed by Kevin Decker.
Move start, stop and all the related methods down to WebBaseNetscapePluginView.
* Plugins/WebBaseNetscapePluginView.h:
* Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView updateAndSetWindow]):
(-[WebBaseNetscapePluginView addWindowObservers]):
(-[WebBaseNetscapePluginView removeWindowObservers]):
(-[WebBaseNetscapePluginView start]):
(-[WebBaseNetscapePluginView stop]):
(-[WebBaseNetscapePluginView viewWillMoveToWindow:]):
(-[WebBaseNetscapePluginView viewWillMoveToSuperview:]):
(-[WebBaseNetscapePluginView viewDidMoveToWindow]):
(-[WebBaseNetscapePluginView viewWillMoveToHostWindow:]):
(-[WebBaseNetscapePluginView viewDidMoveToHostWindow]):
(-[WebBaseNetscapePluginView windowWillClose:]):
(-[WebBaseNetscapePluginView windowBecameKey:]):
(-[WebBaseNetscapePluginView windowResignedKey:]):
(-[WebBaseNetscapePluginView windowDidMiniaturize:]):
(-[WebBaseNetscapePluginView windowDidDeminiaturize:]):
(-[WebBaseNetscapePluginView loginWindowDidSwitchFromUser:]):
(-[WebBaseNetscapePluginView loginWindowDidSwitchToUser:]):
(-[WebBaseNetscapePluginView preferencesHaveChanged:]):
* Plugins/WebNetscapePluginView.h:
* Plugins/WebNetscapePluginView.mm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38282
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 11 Nov 2008 01:13:29 +0000 (01:13 +0000)]
2008-11-10 Anders Carlsson <andersca@apple.com>
Reviewed by Kevin Decker.
Move rightMouseDown, rightMouseUp and sendActivateEvent to the base plugin view.
Add stubs for createPlugin, loadStream, shouldStop and destroyPlugin.
* Plugins/WebBaseNetscapePluginView.h:
* Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView windowFocusChanged:]):
(-[WebBaseNetscapePluginView createPlugin]):
(-[WebBaseNetscapePluginView loadStream]):
(-[WebBaseNetscapePluginView destroyPlugin]):
(-[WebBaseNetscapePluginView sendActivateEvent:]):
(-[WebBaseNetscapePluginView rightMouseDown:]):
(-[WebBaseNetscapePluginView rightMouseUp:]):
* Plugins/WebNetscapePluginView.mm:
(-[WebNetscapePluginView windowFocusChanged:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38281
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 11 Nov 2008 00:51:26 +0000 (00:51 +0000)]
2008-11-10 Anders Carlsson <andersca@apple.com>
Reviewed by Kevin Decker.
Factor plug-in type specific code out to three new methods, createPlugin, destroyPlugin and loadStream.
* Plugins/WebNetscapePluginView.mm:
(-[WebNetscapePluginView createPlugin]):
(-[WebNetscapePluginView loadStream]):
(-[WebNetscapePluginView start]):
(-[WebNetscapePluginView shouldStop]):
(-[WebNetscapePluginView destroyPlugin]):
(-[WebNetscapePluginView stop]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38280
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 11 Nov 2008 00:38:21 +0000 (00:38 +0000)]
2008-11-10 Anders Carlsson <andersca@apple.com>
Fix Tiger build.
* Plugins/WebNetscapePluginPackage.m:
(-[WebNetscapePluginPackage load]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38279
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 11 Nov 2008 00:29:54 +0000 (00:29 +0000)]
2008-11-10 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Move even more code down to WebBaseNetscapePluginView, get rid of some unnecessary methods.
* Plugins/WebBaseNetscapePluginView.h:
* Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView focusChanged]):
(-[WebBaseNetscapePluginView visibleRect]):
(-[WebBaseNetscapePluginView acceptsFirstResponder]):
(-[WebBaseNetscapePluginView setHasFocus:]):
(-[WebBaseNetscapePluginView becomeFirstResponder]):
(-[WebBaseNetscapePluginView resignFirstResponder]):
* Plugins/WebNetscapePluginView.h:
* Plugins/WebNetscapePluginView.mm:
(-[WebNetscapePluginView focusChanged]):
(-[WebNetscapePluginView tellQuickTimeToChill]):
(-[WebNetscapePluginView updateAndSetWindow]):
(-[WebNetscapePluginView start]):
(-[WebNetscapePluginView stop]):
(-[WebNetscapePluginView viewWillMoveToWindow:]):
(-[WebNetscapePluginView createPluginScriptableObject]):
(-[WebNetscapePluginView pluginView:receivedData:]):
(-[WebNetscapePluginView pluginView:receivedError:]):
(-[WebNetscapePluginView pluginViewFinishedLoading:]):
(-[WebNetscapePluginView inputContext]):
(-[WebNetscapePluginView hasMarkedText]):
(-[WebNetscapePluginView insertText:]):
(-[WebNetscapePluginView markedRange]):
(-[WebNetscapePluginView selectedRange]):
(-[WebNetscapePluginView setMarkedText:selectedRange:]):
(-[WebNetscapePluginView unmarkText]):
(-[WebNetscapePluginView validAttributesForMarkedText]):
(-[WebNetscapePluginView attributedSubstringFromRange:]):
(-[WebNetscapePluginView characterIndexForPoint:]):
(-[WebNetscapePluginView doCommandBySelector:]):
(-[WebNetscapePluginView firstRectForCharacterRange:]):
(-[WebNetscapePluginView _viewHasMoved]):
(-[WebNetscapePluginView _redeliverStream]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38278
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Mon, 10 Nov 2008 23:43:18 +0000 (23:43 +0000)]
2008-11-10 Anders Carlsson <andersca@apple.com>
Reviewed by Kevin Decker.
Move timer handling code down to WebBaseNetscapePluginView.
* Plugins/WebBaseNetscapePluginView.h:
* Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView stopTimers]):
(-[WebBaseNetscapePluginView startTimers]):
(-[WebBaseNetscapePluginView restartTimers]):
* Plugins/WebNetscapePluginView.h:
* Plugins/WebNetscapePluginView.mm:
(-[WebNetscapePluginView stopTimers]):
(-[WebNetscapePluginView startTimers]):
(-[WebNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]):
* WebView/WebHTMLView.mm:
(-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38277
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Mon, 10 Nov 2008 22:59:13 +0000 (22:59 +0000)]
WebKit:
2008-11-10 Anders Carlsson <andersca@apple.com>
Reviewed by Kevin Decker.
Add WebHostedNetscapePluginView to the project.
* WebKit.xcodeproj/project.pbxproj:
WebKit/mac:
2008-11-10 Anders Carlsson <andersca@apple.com>
Reviewed by Kevin Decker.
Move a bunch of methods and ivars up to WebBaseNetscapePluginView.
* Plugins/WebBaseNetscapePluginView.h:
* Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView dealloc]):
(-[WebBaseNetscapePluginView finalize]):
(-[WebBaseNetscapePluginView removeTrackingRect]):
(-[WebBaseNetscapePluginView resetTrackingRect]):
(-[WebBaseNetscapePluginView dataSource]):
(-[WebBaseNetscapePluginView webFrame]):
(-[WebBaseNetscapePluginView webView]):
(-[WebBaseNetscapePluginView currentWindow]):
* Plugins/WebNetscapePluginEventHandlerCarbon.mm:
(WebNetscapePluginEventHandlerCarbon::windowFocusChanged):
* Plugins/WebNetscapePluginView.h:
* Plugins/WebNetscapePluginView.mm:
(-[WebNetscapePluginView sendEvent:isDrawRect:]):
(-[WebNetscapePluginView sendActivateEvent:]):
(-[WebNetscapePluginView restartTimers]):
(-[WebNetscapePluginView setHasFocus:]):
(-[WebNetscapePluginView mouseDown:]):
(-[WebNetscapePluginView mouseUp:]):
(-[WebNetscapePluginView mouseEntered:]):
(-[WebNetscapePluginView mouseExited:]):
(-[WebNetscapePluginView handleMouseMoved:]):
(-[WebNetscapePluginView mouseDragged:]):
(-[WebNetscapePluginView scrollWheel:]):
(-[WebNetscapePluginView keyUp:]):
(-[WebNetscapePluginView keyDown:]):
(-[WebNetscapePluginView flagsChanged:]):
(-[WebNetscapePluginView updateAndSetWindow]):
(-[WebNetscapePluginView setWindowIfNecessary]):
(-[WebNetscapePluginView start]):
(-[WebNetscapePluginView stop]):
(-[WebNetscapePluginView isStarted]):
(-[WebNetscapePluginView dealloc]):
(-[WebNetscapePluginView finalize]):
(-[WebNetscapePluginView drawRect:]):
(-[WebNetscapePluginView windowBecameKey:]):
(-[WebNetscapePluginView preferencesHaveChanged:]):
(-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]):
(-[WebNetscapePluginView webFrame:didFinishLoadWithReason:]):
(-[WebNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]):
(-[WebNetscapePluginView _viewHasMoved]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38276
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Mon, 10 Nov 2008 22:27:34 +0000 (22:27 +0000)]
2008-11-10 Anders Carlsson <andersca@apple.com>
Reviewed by Kevin Decker and Mark Rowe.
Add a WebHostedNetscapePluginView class.
* Plugins/WebHostedNetscapePluginView.h: Added.
* Plugins/WebHostedNetscapePluginView.mm: Added.
* Plugins/WebNetscapePluginPackage.h:
Use the right define.
* Plugins/WebPluginDatabase.mm:
(-[WebPluginDatabase removePluginInstanceViewsFor:]):
Check for WebBaseNetscapePluginView.
(-[WebPluginDatabase destroyAllPluginInstanceViews]):
Check for WebBaseNetscapePluginView.
* WebCoreSupport/WebFrameLoaderClient.mm:
(NetscapePluginWidget::NetscapePluginWidget):
(NetscapePluginWidget::handleEvent):
Use WebBaseNetscapePluginView.
(netscapePluginViewClass):
New function that returns the right netscape plugin view type to use.
(WebFrameLoaderClient::createPlugin):
Get the right class.
* WebKitPrefix.h:
Prefix the #define with WTF_.
* WebView/WebHTMLView.mm:
(-[NSArray _web_makePluginViewsPerformSelector:withObject:]):
Check for WebBaseNetscapePluginView.
* WebView/WebView.mm:
Remove an unnecessary include.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38275
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Mon, 10 Nov 2008 22:12:57 +0000 (22:12 +0000)]
Fix Bug 22161: Assertion failure in RenderThemeWin::systemColor when loading microsoftpdc.com
WebCore:
Fix Bug 22161: Assertion failure in RenderThemeWin::systemColor when
loading microsoftpdc.com
<https://bugs.webkit.org/show_bug.cgi?id=22161>
Reviewed by Dan Bernstein.
Test: fast/css/outline-invert-assertion.html
* rendering/RenderThemeWin.cpp:
(WebCore::RenderThemeWin::systemColor): If we can't determine a good
Win32 system color to use, defer to RenderTheme instead of asserting.
This matches what RenderThemeMac does.
LayoutTests:
Test for Bug 22161: Assertion failure in RenderThemeWin::systemColor
when loading microsoftpdc.com
<https://bugs.webkit.org/show_bug.cgi?id=22161>
Note that this test would only fail if DumpRenderTree used
RenderThemeWin, which it doesn't. I did test that locally, though.
Reviewed by Dan Bernstein.
* fast/css/outline-invert-assertion-expected.txt: Added.
* fast/css/outline-invert-assertion.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38274
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin@apple.com [Mon, 10 Nov 2008 21:51:22 +0000 (21:51 +0000)]
WebCore:
2008-11-10 Justin Garcia <justin.garcia@apple.com>
Reviewed by Beth Dakin.
<rdar://problem/
4037481> REGRESSION (Mail): pasting quoted text
into quoted text yields double-quoting
Don't nest inserted content in Mail blockquotes. Perform a
BreakBlockquoteCommand if we're in
one and insert the incoming fragment between the split blockquotes.
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::shouldMerge): Renamed from ->
source and to -> destination.
(WebCore::ReplaceSelectionCommand::doApply):
LayoutTests:
2008-11-10 Beth Dakin <bdakin@apple.com>
Rubber stamped by Justin Garcia.
New tests for <rdar://problem/
4037481> REGRESSION (Mail): pasting
quoted text into quoted text yields double-quoting
* editing/pasteboard/paste-blockquote-into-blockquote-2.html:
Added.
* editing/pasteboard/paste-blockquote-into-blockquote.html: Added.
* platform/mac/editing/pasteboard/paste-blockquote-into-
blockquote-2-expected.checksum: Added.
* platform/mac/editing/pasteboard/paste-blockquote-into-
blockquote-2-expected.png: Added.
* platform/mac/editing/pasteboard/paste-blockquote-into-
blockquote-2-expected.txt: Added.
* platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-
expected.checksum: Added.
* platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-
expected.png: Added.
* platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-
expected.txt: Added.
Test with new results because of this patch:
* platform/mac/editing/pasteboard/merge-end-blockquote-
expected.checksum:
* platform/mac/editing/pasteboard/merge-end-blockquote-
expected.png:
* platform/mac/editing/pasteboard/merge-end-blockquote-
expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38273
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Mon, 10 Nov 2008 21:47:26 +0000 (21:47 +0000)]
Commit the current configuration of build.webkit.org.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38272
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Mon, 10 Nov 2008 21:45:32 +0000 (21:45 +0000)]
Commit the current configuration of build.webkit.org.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38271
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Mon, 10 Nov 2008 21:33:22 +0000 (21:33 +0000)]
2008-11-10 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Don't use individual ivars for each plug-in vtable function. Instead, get them from the plugin package.
* Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:DOMElement:]):
* Plugins/WebNetscapePluginPackage.h:
* Plugins/WebNetscapePluginPackage.m:
(-[WebNetscapePluginPackage load]):
(-[WebNetscapePluginPackage _unloadWithShutdown:]):
* Plugins/WebNetscapePluginView.h:
* Plugins/WebNetscapePluginView.mm:
(-[WebNetscapePluginView sendEvent:isDrawRect:]):
(-[WebNetscapePluginView setWindowIfNecessary]):
(-[WebNetscapePluginView start]):
(-[WebNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:DOMElement:]):
(-[WebNetscapePluginView createPluginScriptableObject]):
(-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]):
(-[WebNetscapePluginView webFrame:didFinishLoadWithReason:]):
(-[WebNetscapePluginView loadPluginRequest:]):
(-[WebNetscapePluginView _createPlugin]):
(-[WebNetscapePluginView _destroyPlugin]):
(-[WebNetscapePluginView _printedPluginBitmap]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38270
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Mon, 10 Nov 2008 21:00:28 +0000 (21:00 +0000)]
WebKit:
2008-11-10 Anders Carlsson <andersca@apple.com>
Reviewed by Kevin Decker.
Add a new WebBaseNetscapePluginView class.
* WebKit.xcodeproj/project.pbxproj:
WebKit/mac:
2008-11-10 Anders Carlsson <andersca@apple.com>
Reviewed by Kevin Decker.
Add a new WebBaseNetscapePluginView class.
* Plugins/WebBaseNetscapePluginView.h: Added.
* Plugins/WebBaseNetscapePluginView.mm: Added.
(-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:DOMElement:]):
(-[WebBaseNetscapePluginView setAttributeKeys:andValues:]):
(-[WebBaseNetscapePluginView handleMouseMoved:]):
* Plugins/WebNetscapePluginView.h:
* Plugins/WebNetscapePluginView.mm:
(-[WebNetscapePluginView cut:]):
(-[WebNetscapePluginView copy:]):
(-[WebNetscapePluginView paste:]):
(-[WebNetscapePluginView selectAll:]):
(-[WebNetscapePluginView start]):
(-[WebNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:DOMElement:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38269
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cwzwarich@webkit.org [Mon, 10 Nov 2008 20:25:35 +0000 (20:25 +0000)]
2008-11-10 Cameron Zwarich <zwarich@apple.com>
Reviewed by Geoff Garen.
Bug 22162: Remove cachedValueGetter from the JavaScriptCore API implementation
<https://bugs.webkit.org/show_bug.cgi?id=22162>
There is no more need for the cachedValueGetter hack now that we have
PropertySlot::setValue(), so we should remove it.
* API/JSCallbackObject.h:
* API/JSCallbackObjectFunctions.h:
(JSC::::getOwnPropertySlot):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38268
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Mon, 10 Nov 2008 20:20:27 +0000 (20:20 +0000)]
WebKit:
2008-11-10 Anders Carlsson <andersca@apple.com>
Reviewed by Adam Roben.
Rename WebBaseNetscapePluginView to WebNetscapePluginView.
* StringsNotToBeLocalized.txt:
* WebKit.xcodeproj/project.pbxproj:
WebKit/mac:
2008-11-10 Anders Carlsson <andersca@apple.com>
Reviewed by Adam Roben.
Rename WebBaseNetscapePluginView to WebNetscapePluginView.
* Plugins/WebBaseNetscapePluginStream.h:
* Plugins/WebBaseNetscapePluginStream.mm:
(WebNetscapePluginStream::WebNetscapePluginStream):
(WebNetscapePluginStream::setPlugin):
* Plugins/WebBaseNetscapePluginView.h: Removed.
* Plugins/WebBaseNetscapePluginView.mm: Removed.
* Plugins/WebNetscapePluginEventHandler.h:
(WebNetscapePluginEventHandler::WebNetscapePluginEventHandler):
* Plugins/WebNetscapePluginEventHandler.mm:
(WebNetscapePluginEventHandler::create):
* Plugins/WebNetscapePluginEventHandlerCarbon.h:
* Plugins/WebNetscapePluginEventHandlerCarbon.mm:
(WebNetscapePluginEventHandlerCarbon::WebNetscapePluginEventHandlerCarbon):
* Plugins/WebNetscapePluginEventHandlerCocoa.h:
* Plugins/WebNetscapePluginEventHandlerCocoa.mm:
(WebNetscapePluginEventHandlerCocoa::WebNetscapePluginEventHandlerCocoa):
* Plugins/WebNetscapePluginView.h: Copied from mac/Plugins/WebBaseNetscapePluginView.h.
* Plugins/WebNetscapePluginView.mm: Copied from mac/Plugins/WebBaseNetscapePluginView.mm.
(+[WebNetscapePluginView setCurrentPluginView:]):
(+[WebNetscapePluginView currentPluginView]):
(-[WebNetscapePluginView loadPluginRequest:]):
* Plugins/WebPluginDatabase.mm:
(-[WebPluginDatabase removePluginInstanceViewsFor:]):
(-[WebPluginDatabase destroyAllPluginInstanceViews]):
* Plugins/npapi.mm:
(pluginViewForInstance):
(NPN_MarkedTextAbandoned):
(NPN_MarkedTextSelectionChanged):
* WebCoreSupport/WebFrameLoaderClient.mm:
(NetscapePluginWidget::NetscapePluginWidget):
(NetscapePluginWidget::handleEvent):
(WebFrameLoaderClient::createPlugin):
* WebView/WebHTMLView.mm:
(-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]):
(-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]):
(-[NSArray _web_makePluginViewsPerformSelector:withObject:]):
* WebView/WebView.mm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38267
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Mon, 10 Nov 2008 18:38:56 +0000 (18:38 +0000)]
Fix Bug 22158: Would like to turn on WebCore logging channels via an environment variable
WebCore:
Fix Bug 22158: Would like to turn on WebCore logging channels via an
environment variable
<https://bugs.webkit.org/show_bug.cgi?id=22158>
Logging channels can now be enabled by setting the WebCoreLogLevel
environment variable to a hexadecimal number.
Reviewed by Anders Carlsson.
* WebCore.vcproj/WebCore.vcproj: Added LoggingWin.cpp.
* platform/win/LoggingWin.cpp: Copied from WebCore/platform/mac/LoggingMac.mm.
(WebCore::initializeWithUserDefault): Read in the WebCoreLogLevel
environment variable, parse its value as a hexadecimal number, and
turn the channel on/off based on whether the mask bit is set.
(WebCore::InitializeLoggingChannelsIfNecessary): Initialize each
logging channel in turn.
WebKit/win:
Fix Bug 22158: Would like to turn on WebCore logging channels via an
environment variable
<https://bugs.webkit.org/show_bug.cgi?id=22158>
Reviewed by Anders Carlsson.
* WebView.cpp:
(WebView::initWithFrame): Call WebCore's
InitializeLoggingChannelsIfNecessary.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38266
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cwzwarich@webkit.org [Mon, 10 Nov 2008 18:17:15 +0000 (18:17 +0000)]
2008-11-10 Cameron Zwarich <zwarich@apple.com>
Reviewed by Darin Adler.
Bug 22152: Remove asObject() call from JSCallbackObject::getOwnPropertySlot()
<https://bugs.webkit.org/show_bug.cgi?id=22152>
With the recent change to adopt asType() style cast functions with
assertions instead of static_casts in many places, the assertion for
the asObject() call in JSCallbackObject::getOwnPropertySlot() has been
failing when using any nontrivial client of the JavaScriptCore API.
The cast isn't even necessary to call slot.setCustom(), so it should
be removed.
* API/JSCallbackObjectFunctions.h:
(JSC::JSCallbackObject::getOwnPropertySlot):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38265
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Mon, 10 Nov 2008 17:06:04 +0000 (17:06 +0000)]
2008-11-10 Darin Adler <darin@apple.com>
Reviewed by Adam Roben.
- fix https://bugs.webkit.org/show_bug.cgi?id=22103
Changing fonts in preferences does not immediately update WebViews
This broke when the meaning of FrameView::invalidate changed.
I changed setNeedsReapplyStyles to no longer depend on invalidate.
* dom/Document.cpp: (WebCore::Document::shouldScheduleLayout):
Removed the part of this function that duplicated what's already in
FrameView::needsLayout, since the copy here left out a few key things.
For example, it didn't handle the fact that "needs reapply styles"
counts as needing layout.
* page/Frame.cpp: (WebCore::Frame::setNeedsReapplyStyles): This called
FrameView::invalidate before. There were two things wrong with that.
1) It requested that the entire view repaint even if the style change
didn't necessitate that. 2) FrameView::invalidate no longer causes any
repainting at all in certain cases, because of Hyatt's changes to how
widgets and the host window are involved in the repainting process.
So call FrameView::scheduleRelayout instead, which is more precisely
what we want and need here.
* page/FrameView.cpp:
(WebCore::FrameView::scheduleRelayout): Add a call to needsLayout here
so that Document::shouldScheduleLayout doesn't have to replicate the
logic that's in needsLayout and can instead rely on the fact that it
was already called.
(WebCore::FrameView::needsLayout): Tweaked the comments and formatting
in this function.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38264
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Mon, 10 Nov 2008 17:03:36 +0000 (17:03 +0000)]
2008-11-10 Darin Adler <darin@apple.com>
Reviewed by Adam Roben.
- speculative fix for <rdar://problem/
5557243> crashes in Safari at
WebCore::HTMLSelectElement::updateListBoxSelection + 280
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::updateListBoxSelection):
Check index against size of vector before indexing into the vector.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38263
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Mon, 10 Nov 2008 15:55:10 +0000 (15:55 +0000)]
2008-11-10 Tor Arne Vestbø <tavestbo@trolltech.com>
Rubber-stamped by Simon Hausmann.
Distinguish between building from trunk and as part of Qt
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38262
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Mon, 10 Nov 2008 15:42:34 +0000 (15:42 +0000)]
2008-11-10 Darin Adler <darin@apple.com>
- fix more of https://bugs.webkit.org/show_bug.cgi?id=21400
"Edit" links for patches in comments, review queue, review emails
should be replaced by "Review Patch" links
* globals.pl: Fix cases that are automatically generated, such as links
in comments in bugs.
* template/en/custom/attachment/created.html.tmpl: Fix the link on the
"I just created an attachment" page.
* template/en/custom/request/queue.html.tmpl: Fix the link in the queue
page.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38261
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Mon, 10 Nov 2008 15:31:34 +0000 (15:31 +0000)]
2008-11-10 Darin Adler <darin@apple.com>
* template/en/custom/request/email.txt.tmpl: Send review links instead
of edit links when flags are set on a bug.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38260
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Mon, 10 Nov 2008 15:03:44 +0000 (15:03 +0000)]
Reviewed by Adam Roben.
A few coding style fixes for AVLTree.
* wtf/AVLTree.h: Moved to WTF namespace, Removed "KJS_" from include guards.
(WTF::AVLTree::Iterator::start_iter): Fixed indentation
* runtime/JSArray.cpp: Added "using namepace WTF".
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38259
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Mon, 10 Nov 2008 14:37:11 +0000 (14:37 +0000)]
2008-11-10 Ariya Hidayat <ariya.hidayat@trolltech.com>
Rubber-stamped by Simon Hausmann.
To fit Qt API, scroll offset is a QPoint instead of a QSize.
* Api/qwebframe.cpp:
(QWebFrame::scrollOffset):
(QWebFrame::setScrollOffset):
* Api/qwebframe.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38258
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Mon, 10 Nov 2008 11:46:11 +0000 (11:46 +0000)]
2008-11-10 Morten Sørvig <msorvig@trolltech.com>
Reviewed by Simon Hausmann.
Make tests/auto/qwebframe compile on Qt/Mac.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38257
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Mon, 10 Nov 2008 11:46:04 +0000 (11:46 +0000)]
2008-11-10 David Boddie <dboddie@trolltech.com>
Reviewed by Simon Hausmann.
Doc: Fixed qdoc warnings by supplying function documentation.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38256
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Mon, 10 Nov 2008 11:45:56 +0000 (11:45 +0000)]
2008-11-10 Tobias Koenig <tobias.koenig@trolltech.com>
Reviewed by Simon Hausmann.
Removed old and stale prf file that breaks the MingW build.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38255
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Mon, 10 Nov 2008 11:45:48 +0000 (11:45 +0000)]
2008-11-10 Tom Cooksey <thomas.cooksey@trolltech.com>
Reviewed by Tor Arne Vestbø.
Fix QtWebkit build failure on arm.
pen.widthF() is a qreal, which means it's a float on arm.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38254
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Mon, 10 Nov 2008 11:45:39 +0000 (11:45 +0000)]
2008-11-10 Kavindra Palaraja <kdpalara@trolltech.com>
Reviewed by Simon Hausmann.
Clarify QWebFrame/View::setHTML docs with regards to relative URLs
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38253
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Mon, 10 Nov 2008 11:45:30 +0000 (11:45 +0000)]
2008-11-10 Joerg Bornemann <joerg.bornemann@nokia.com>
Reviewed by Simon Hausmann
Don't define _CRT_RAND_S on Windows CE in the precompiled
header, to fix the CE build.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38252
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Mon, 10 Nov 2008 11:45:21 +0000 (11:45 +0000)]
2008-11-10 Morten Sørvig <msorvig@trolltech.com>
Reviewed by Simon Hausmann.
Improve mouse wheel scolling on Qt/Cocoa.
Cocoa differs from Carbon (and other platforms I think) in that the
mouse wheel events we get have a much higher acceleration factor.
This submit switches over to scroll-per-pixel from scroll-per-line
for most of our scrolling views. This matches the native views
and works well with the increased acceleration.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38251
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cwzwarich@webkit.org [Mon, 10 Nov 2008 06:26:05 +0000 (06:26 +0000)]
2008-11-09 Cameron Zwarich <zwarich@apple.com>
Not reviewed.
Speculatively fix the non-AllInOne build.
* runtime/NativeErrorConstructor.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38250
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Mon, 10 Nov 2008 01:28:10 +0000 (01:28 +0000)]
2008-11-09 Darin Adler <darin@apple.com>
Reviewed by Tim Hatcher.
- https://bugs.webkit.org/show_bug.cgi?id=22149
remove unused code from the parser
* AllInOneFile.cpp: Removed nodes2string.cpp.
* GNUmakefile.am: Ditto.
* JavaScriptCore.exp: Ditto.
* JavaScriptCore.pri: Ditto.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Ditto.
* JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
* JavaScriptCoreSources.bkl: Ditto.
* VM/CodeBlock.h: Added include.
* VM/Machine.cpp: (JSC::Machine::execute): Use the types from
DeclarationStacks as DeclarationStacks:: rather than Node:: since
"Node" really has little to do with it.
* bytecompiler/CodeGenerator.cpp:
(JSC::CodeGenerator::CodeGenerator): Ditto.
* jsc.cpp:
(Options::Options): Removed prettyPrint option.
(runWithScripts): Ditto.
(printUsageStatement): Ditto.
(parseArguments): Ditto.
(jscmain): Ditto.
* parser/Grammar.y: Removed use of obsolete ImmediateNumberNode.
* parser/Nodes.cpp:
(JSC::ThrowableExpressionData::emitThrowError): Use inline functions
instead of direct member access for ThrowableExpressionData values.
(JSC::BracketAccessorNode::emitCode): Ditto.
(JSC::DotAccessorNode::emitCode): Ditto.
(JSC::NewExprNode::emitCode): Ditto.
(JSC::EvalFunctionCallNode::emitCode): Ditto.
(JSC::FunctionCallValueNode::emitCode): Ditto.
(JSC::FunctionCallResolveNode::emitCode): Ditto.
(JSC::FunctionCallBracketNode::emitCode): Ditto.
(JSC::FunctionCallDotNode::emitCode): Ditto.
(JSC::PostfixResolveNode::emitCode): Ditto.
(JSC::PostfixBracketNode::emitCode): Ditto.
(JSC::PostfixDotNode::emitCode): Ditto.
(JSC::DeleteResolveNode::emitCode): Ditto.
(JSC::DeleteBracketNode::emitCode): Ditto.
(JSC::DeleteDotNode::emitCode): Ditto.
(JSC::PrefixResolveNode::emitCode): Ditto.
(JSC::PrefixBracketNode::emitCode): Ditto.
(JSC::PrefixDotNode::emitCode): Ditto.
(JSC::ThrowableBinaryOpNode::emitCode): Ditto.
(JSC::InstanceOfNode::emitCode): Ditto.
(JSC::ReadModifyResolveNode::emitCode): Ditto.
(JSC::AssignResolveNode::emitCode): Ditto.
(JSC::AssignDotNode::emitCode): Ditto.
(JSC::ReadModifyDotNode::emitCode): Ditto.
(JSC::AssignBracketNode::emitCode): Ditto.
(JSC::ReadModifyBracketNode::emitCode): Ditto.
(JSC::statementListEmitCode): Take a const StatementVector instead
of a non-const one. Also removed unused statementListPushFIFO.
(JSC::ForInNode::emitCode): Inline functions instead of member access.
(JSC::ThrowNode::emitCode): Ditto.
(JSC::EvalNode::emitCode): Ditto.
(JSC::FunctionBodyNode::emitCode): Ditto.
(JSC::ProgramNode::emitCode): Ditto.
* parser/Nodes.h: Removed unused includes and forward declarations.
Removed Precedence enum. Made many more members private instead of
protected or public. Removed unused NodeStack typedef. Moved the
VarStack and FunctionStack typedefs from Node to ScopeNode. Made
Node::emitCode pure virtual and changed classes that don't emit
any code to inherit from ParserRefCounted rather than Node.
Moved isReturnNode from Node to StatementNode. Removed the
streamTo, precedence, and needsParensIfLeftmost functions from
all classes. Removed the ImmediateNumberNode class and make
NumberNode::setValue nonvirtual.
* parser/nodes2string.cpp: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38249
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cwzwarich@webkit.org [Mon, 10 Nov 2008 01:19:13 +0000 (01:19 +0000)]
2008-11-09 Cameron Zwarich <zwarich@apple.com>
Reviewed by Darin Adler.
Bug 19541: Null pointer in showModalDialog()
<https://bugs.webkit.org/show_bug.cgi?id=19541>
Add null frame->page() checks to JSDOMWindowBase::canShowModalDialog()
and JSDOMWindowBase::canShowModalDialogNow()C
WebCore:
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::canShowModalDialog):
(WebCore::canShowModalDialogNow):
LayoutTests:
* fast/dom/null-page-show-modal-dialog-crash-expected.txt: Added.
* fast/dom/null-page-show-modal-dialog-crash.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38248
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Mon, 10 Nov 2008 01:04:30 +0000 (01:04 +0000)]
JavaScriptCore:
2008-11-09 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig and Maciej Stachowiak.
Includes some work done by Chris Brichford.
- fix https://bugs.webkit.org/show_bug.cgi?id=14886
Stack overflow due to deeply nested parse tree doing repeated string concatentation
Test: fast/js/large-expressions.html
1) Code generation is recursive, so takes stack proportional to the complexity
of the source code expression. Fixed by setting an arbitrary recursion limit
of 10,000 nodes.
2) Destruction of the syntax tree was recursive. Fixed by introducing a
non-recursive mechanism for destroying the tree.
* bytecompiler/CodeGenerator.cpp:
(JSC::CodeGenerator::CodeGenerator): Initialize depth to 0.
(JSC::CodeGenerator::emitThrowExpressionTooDeepException): Added. Emits the code
to throw a "too deep" exception.
* bytecompiler/CodeGenerator.h:
(JSC::CodeGenerator::emitNode): Check depth and emit an exception if we exceed
the maximum depth.
* parser/Nodes.cpp:
(JSC::NodeReleaser::releaseAllNodes): Added. To be called inside node destructors
to avoid recursive calls to destructors for nodes inside this one.
(JSC::NodeReleaser::release): Added. To be called inside releaseNodes functions.
Also added releaseNodes functions and calls to releaseAllNodes inside destructors
for each class derived from Node that has RefPtr to other nodes.
(JSC::NodeReleaser::adopt): Added. Used by the release function.
(JSC::NodeReleaser::adoptFunctionBodyNode): Added.
* parser/Nodes.h: Added declarations of releaseNodes and destructors in all classes
that needed it. Eliminated use of ListRefPtr and releaseNext, which are the two parts
of an older solution to the non-recursive destruction problem that works only for
lists, whereas the new solution works for other graphs. Changed ReverseBinaryOpNode
to use BinaryOpNode as a base class to avoid some duplicated code.
LayoutTests:
2008-11-09 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=22104
Javascript URL percent encoding/decoding broken by some characters
* fast/loader/javascript-url-encoding-2-expected.txt:
* fast/loader/javascript-url-encoding-2.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38247
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Mon, 10 Nov 2008 00:22:18 +0000 (00:22 +0000)]
2008-11-09 Darin Adler <darin@apple.com>
- try to fix Windows build
* platform/graphics/Color.cpp: For some reason MSVC doesn't follow the rules
about needed a separate definition for static const integer data members.
Until I get to the bottom of this, put the definitions inside an ifdef.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38246
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Sun, 9 Nov 2008 20:19:54 +0000 (20:19 +0000)]
2008-11-09 Darin Adler <darin@apple.com>
Reviewed by John Sullivan.
- fix https://bugs.webkit.org/show_bug.cgi?id=15063
<rdar://problem/
5452227> REGRESSION (r25151): Switching to a tab waiting
for first data does not clear the window
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::frameLoadCompleted): Added comments, and got rid of
a local variable to make this code match the code in the function below
more closely.
(WebFrameLoaderClient::provisionalLoadStarted): Added comments.
* WebView/WebFrame.mm:
(-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]): Improved comment.
* WebView/WebFrameView.mm:
(-[WebFrameView _scrollView]): Tweaked formatting.
(-[WebFrameView initWithFrame:]): Ditto.
(-[WebFrameView setFrameSize:]): Added a comment and tweaked formatting.
(-[WebFrameView viewDidMoveToWindow]): Added. This is the change that fixes
the bug. Calls setDrawsBackground:YES as appropriate since moving the view
out of the window to switch to another view disrupts the special technique
for showing the old page during the start of loading. This is the identical
reason for the setFrameSize: method above, and the code is almost the same.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38245
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer@apple.com [Sun, 9 Nov 2008 19:50:37 +0000 (19:50 +0000)]
BUILD FIX: Qt build broke after r38235.
Added HAVE(ACCESSIBILITY) header guards to platform implementation
source files.
* page/gtk/AccessibilityObjectAtk.cpp: Added HAVE(ACCESSIBILITY)
guards.
* page/gtk/AccessibilityObjectWrapperAtk.cpp: Ditto.
* page/qt/AccessibilityObjectQt.cpp: Ditto.
* page/win/AccessibilityObjectWin.cpp: Ditto.
* page/wx/AccessibilityObjectWx.cpp: Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38244
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Sun, 9 Nov 2008 19:08:07 +0000 (19:08 +0000)]
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=22104
Javascript URL percent encoding/decoding broken by some characters
Test: fast/loader/javascript-url-encoding-2.html
* platform/KURL.cpp: (WebCore::encodeRelativeString): Don't try to break down javascript URLs.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38243
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Sun, 9 Nov 2008 18:20:53 +0000 (18:20 +0000)]
2008-11-09 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed and tweaked by Darin Adler.
* platform/graphics/Color.cpp: Added definitions for the static data members
in this class. Static data members need a definition, even when they are the
simple integer constant kind that can be initialized in the header.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38242
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Sun, 9 Nov 2008 15:50:32 +0000 (15:50 +0000)]
2008-11-09 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
- fix https://bugs.webkit.org/show_bug.cgi?id=22142
a few fast/canvas tests use non-standard HTML wrappers but don't need to
* fast/canvas/gradient-addColorStop-with-invalid-color-expected.txt:
Fixed spelling error: "gradieints".
* fast/canvas/gradient-addColorStop-with-invalid-color.html: Regenerated with
make-js-test-wrappers script; removes the canvas element that was in here.
* fast/canvas/linearGradient-infinite-values.html: Ditto.
* fast/canvas/radialGradient-infinite-values.html: Ditto.
* fast/canvas/resources/gradient-addColorStop-with-invalid-color.js:
Fixed spelling error and changed code to use createElement to make a canvas
element rather than using getElementById to find an existing canvas element.
* fast/canvas/resources/linearGradient-infinite-values.js: Ditto.
* fast/canvas/resources/radialGradient-infinite-values.js: Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38241
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Sun, 9 Nov 2008 04:11:26 +0000 (04:11 +0000)]
WebCore:
2008-11-08 Antti Koivisto <antti@apple.com>
Reviewed by Sam Weinig.
Fix https://bugs.webkit.org/show_bug.cgi?id=22141
REGRESSION: Safari error page is not fully styled when loaded from cache
Reset text decoder on flush so it does not pass through the BOM when it is reused.
Test: fast/encoding/css-cached-bom.html
* loader/TextResourceDecoder.cpp:
(WebCore::TextResourceDecoder::flush):
LayoutTests:
2008-11-08 Antti Koivisto <antti@apple.com>
Reviewed by Sam Weinig.
Test for https://bugs.webkit.org/show_bug.cgi?id=22141
REGRESSION: Safari error page is not fully styled when loaded from cache
* fast/encoding/css-cached-bom.html: Added.
* fast/encoding/css-cached-bom-expected.txt: Added.
* fast/encoding/resources/css-cached-bom-frame.html: Added.
* fast/encoding/resources/utf-16-little-endian.css: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38240
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino@webkit.org [Sun, 9 Nov 2008 03:14:07 +0000 (03:14 +0000)]
Reviewed by Mark Rowe.
Send URL errors to stderr rather than stdout. While debugging wx DumpRenderTree,
it was causing these errors to end up in the page's text representation.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38239
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino@webkit.org [Sun, 9 Nov 2008 02:35:45 +0000 (02:35 +0000)]
wx build fixes after addition of JSCore parser and bycompiler dirs.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38238
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Sun, 9 Nov 2008 01:09:14 +0000 (01:09 +0000)]
2008-11-08 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein
https://bugs.webkit.org/show_bug.cgi?id=21906
Override addFocusRingRects() in RenderTextControl to avoid
the RenderFlow behavior of recursing on descendent renderers.
RenderTextControl should only ever need a simple focus rect.
This fixes focus ring issues with transforms on text controls.
Test: fast/transforms/transformed-focused-text-input.html
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::addFocusRingRects):
* rendering/RenderTextControl.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38237
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Sun, 9 Nov 2008 00:33:06 +0000 (00:33 +0000)]
Make sure the icon thumbnail width/height is at least 1px in
the Web Inspector's resource panel.
<rdar://problem/
5988888>
Reviewed by Tim Hatcher.
* inspector/front-end/inspector.css:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38236
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer@apple.com [Sat, 8 Nov 2008 19:42:33 +0000 (19:42 +0000)]
Bug 22137: PLATFORM(MAC) build broken with HAVE(ACCESSIBILITY) disabled
<https://bugs.webkit.org/show_bug.cgi?id=22137>
Reviewed by Darin Adler.
WebCore:
* page/AccessibilityObject.h:
(WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
Provide a default implementation when HAVE(ACCESSIBILITY) is false.
* page/mac/AXObjectCacheMac.mm: Added HAVE(ACCESSIBILITY) guard.
* page/mac/AccessibilityObjectMac.mm: Ditto.
* page/mac/AccessibilityObjectWrapper.mm: Ditto.
WebKit/mac:
* WebView/WebFrame.mm:
(-[WebFrame _accessibilityTree]): Return nil if HAVE(ACCESSIBILITY)
is false.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38235
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Sat, 8 Nov 2008 19:12:23 +0000 (19:12 +0000)]
WebCore:
Reviewed by Darin Adler.
- WebCore part of adding WebPreferences for controlling databases and local storage
* WebCore.base.exp: Exported Settings::setDatabasesEnabled() and
Settings::setLocalStorageEnabled().
* page/DOMWindow.cpp:
(WebCore::DOMWindow::localStorage): Changed to return 0 if local storage
is disabled in settings.
(WebCore::DOMWindow::openDatabase): Changed to return 0 if databases
are disabled in settings.
* page/Settings.cpp:
(WebCore::Settings::Settings): Initialize m_databasesEnabled and
m_localStorageEnabled.
(WebCore::Settings::setDatabasesEnabled): Added.
(WebCore::Settings::setLocalStorageEnabled): Added.
* page/Settings.h:
(WebCore::Settings::databasesEnabled): Added.
(WebCore::Settings::localStorageEnabled): Added.
WebKit/mac:
Reviewed by Darin Adler.
- WebKit/mac part of adding WebPreferences for controlling databases and local storage
* WebView/WebPreferenceKeysPrivate.h: Added
WebKitDatabasesEnabledPreferenceKey and
WebKitLocalStorageEnabledPreferenceKey.
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]): Made databases and local storage enabled
by default.
(-[WebPreferences databasesEnabled]): Added.
(-[WebPreferences setDatabasesEnabled:]): Added.
(-[WebPreferences localStorageEnabled]): Added.
(-[WebPreferences setLocalStorageEnabled:]): Added.
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView _preferencesChangedNotification:]): Transfer the databases
and local storage preferences to WebCore settings.
WebKit/win:
Reviewed by Darin Adler.
- WebKit/win part of adding WebPreferences for controlling databases and local storage
* Interfaces/IWebPreferencesPrivate.idl: Declared setDatabasesEnabled,
databasesEnabled, setLocalStorageEnabled and localStorageEnabled.
* WebPreferenceKeysPrivate.h: Added WebKitDatabasesEnabledPreferenceKey
and WebKitLocalStorageEnabledPreferenceKey.
* WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings): Made databases and local
storage enabled by default.
(WebPreferences::setDatabasesEnabled): Added.
(WebPreferences::databasesEnabled): Added.
(WebPreferences::setLocalStorageEnabled): Added.
(WebPreferences::localStorageEnabled): Added.
* WebPreferences.h:
* WebView.cpp:
(WebView::notifyPreferencesChanged): Transfer the databases and local
storage preferences to WebCore settings.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38234
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos@webkit.org [Sat, 8 Nov 2008 13:57:54 +0000 (13:57 +0000)]
Just adjusting email address in changelog.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38233
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Fri, 7 Nov 2008 22:29:56 +0000 (22:29 +0000)]
2008-11-07 Alp Toker <alp@nuanti.com>
Fix build with bleeding edge GTK+ versions. GTK+ and other libraries
now require that only their top-level header file is included.
Patch tested and still builds fine with older GTK+ versions (back to
2.8).
Future WebKit GTK+ contributions are required to adhere to this
policy.
* platform/gtk/FileSystemGtk.cpp:
* platform/gtk/KeyEventGtk.cpp:
* platform/gtk/MouseEventGtk.cpp:
* platform/gtk/WheelEventGtk.cpp:
* platform/gtk/gtkdrawing.h:
* plugins/gtk/gtk2xtbin.c:
* plugins/gtk/gtk2xtbin.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38232
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 7 Nov 2008 21:34:02 +0000 (21:34 +0000)]
2008-11-07 Anders Carlsson <andersca@apple.com>
Reviewed by Kevin Decker
Explicitly initialize the NPDrawingModelCoreAnimation.
* bridge/npapi.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38231
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cwzwarich@webkit.org [Fri, 7 Nov 2008 21:15:18 +0000 (21:15 +0000)]
2008-11-07 Cameron Zwarich <zwarich@apple.com>
Reviewed by Geoff Garen.
Bug 21801: REGRESSION (r37821): YUI date formatting JavaScript puts the letter 'd' in place of the day
<https://bugs.webkit.org/show_bug.cgi?id=21801>
Fix the constant register check in the 'typeof' optimization in
CodeGenerator, which was completely broken after r37821.
JavaScriptCore:
* bytecompiler/CodeGenerator.cpp:
(JSC::CodeGenerator::emitEqualityOp):
LayoutTests:
* fast/js/resources/typeof-constant-string.js: Added.
* fast/js/typeof-constant-string-expected.txt: Added.
* fast/js/typeof-constant-string.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38230
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cwzwarich@webkit.org [Fri, 7 Nov 2008 20:41:47 +0000 (20:41 +0000)]
2008-11-07 Cameron Zwarich <zwarich@apple.com>
Reviewed by Geoff Garen.
Bug 22129: Move CTI::isConstant() to CodeBlock
<https://bugs.webkit.org/show_bug.cgi?id=22129>
* VM/CTI.cpp:
(JSC::CTI::emitGetArg):
(JSC::CTI::emitGetPutArg):
(JSC::CTI::getConstantImmediateNumericArg):
(JSC::CTI::printOpcodeOperandTypes):
(JSC::CTI::privateCompileMainPass):
* VM/CTI.h:
* VM/CodeBlock.h:
(JSC::CodeBlock::isConstant):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38229
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Fri, 7 Nov 2008 19:35:47 +0000 (19:35 +0000)]
2008-11-07 Alp Toker <alp@nuanti.com>
autotools fix. Always use the configured perl binary (which may be
different to the one in $PATH) when generating sources.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38228
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Fri, 7 Nov 2008 19:17:08 +0000 (19:17 +0000)]
2008-11-07 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein
https://bugs.webkit.org/show_bug.cgi?id=22122
Use a stack-based object to simplify the pushLayoutState/popLayoutState
code. LayoutStateMaintainer either pushes in the constructor, or allows
an explicit push() later. Both cases require an explicit pop().
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::layoutOnlyPositionedObjects):
* rendering/RenderContainer.cpp:
(WebCore::RenderContainer::layout):
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock):
* rendering/RenderTable.cpp:
(WebCore::RenderTable::layout):
* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::layout):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::setCellWidths):
(WebCore::RenderTableSection::calcRowHeight):
(WebCore::RenderTableSection::layoutRows):
* rendering/RenderView.h:
(WebCore::LayoutStateMaintainer::LayoutStateMaintainer):
(WebCore::LayoutStateMaintainer::~LayoutStateMaintainer):
(WebCore::LayoutStateMaintainer::pop):
(WebCore::LayoutStateMaintainer::push):
(WebCore::LayoutStateMaintainer::didPush):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38227
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cwzwarich@webkit.org [Fri, 7 Nov 2008 18:07:20 +0000 (18:07 +0000)]
2008-11-07 Cameron Zwarich <zwarich@apple.com>
Not reviewed.
Change grammar.cpp to Grammar.cpp and grammar.h to Grammar.h in several
build scripts.
* DerivedSources.make:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCoreSources.bkl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38226
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Fri, 7 Nov 2008 17:48:38 +0000 (17:48 +0000)]
2008-11-07 Alp Toker <alp@nuanti.com>
More grammar.cpp -> Grammar.cpp build fixes.
* AllInOneFile.cpp:
* GNUmakefile.am:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38225
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Fri, 7 Nov 2008 15:39:56 +0000 (15:39 +0000)]
2008-11-07 Tor Arne Vestbø <tavestbo@trolltech.com>
Fix the QtWebKit build on Mac
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38224
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Fri, 7 Nov 2008 15:01:55 +0000 (15:01 +0000)]
2008-11-07 Tor Arne Vestbø <tavestbo@trolltech.com>
Rubber-stamped by Simon Hausmann.
Don't allow Phonon's invisible video widget to keep the app running
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38223
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Fri, 7 Nov 2008 14:47:17 +0000 (14:47 +0000)]
2008-11-07 Ariya Hidayat <ariya.hidayat@trolltech.com>
Reviewed by Tor Arne Vestbø and Simon Hausmann.
Added an option to allow printing the background color and images.
Mostly reworked from a patch by Holger.
This setting is enabled by default.
* Api/qwebsettings.cpp:
(QWebSettingsPrivate::apply):
(QWebSettings::QWebSettings):
* Api/qwebsettings.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38222
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Fri, 7 Nov 2008 14:11:22 +0000 (14:11 +0000)]
2008-11-07 Simon Hausmann <hausmann@webkit.org>
Fix the build on case-sensitive file systems. grammar.y was renamed to
Grammar.y but Lexer.cpp includes grammar.h. The build bots didn't
notice this change because of stale files.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38221
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Fri, 7 Nov 2008 11:32:04 +0000 (11:32 +0000)]
2008-11-07 Henrik Hartz <henrik.hartz@nokia.com>
Reviewed by Simon Hausmann.
Fix valgrind warning about uninitialized lastStop variable.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38220
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cwzwarich@webkit.org [Fri, 7 Nov 2008 09:22:41 +0000 (09:22 +0000)]
2008-11-07 Cameron Zwarich <zwarich@apple.com>
Reviewed by Alexey Proskuryakov.
Rename the m_nextGlobal, m_nextParameter, and m_nextConstant member
variables of CodeGenerator to m_nextGlobalIndex, m_nextParameterIndex,
and m_nextConstantIndex respectively. This is to distinguish these from
member variables like m_lastConstant, which are actually RefPtrs to
Registers.
* bytecompiler/CodeGenerator.cpp:
(JSC::CodeGenerator::addGlobalVar):
(JSC::CodeGenerator::allocateConstants):
(JSC::CodeGenerator::CodeGenerator):
(JSC::CodeGenerator::addParameter):
(JSC::CodeGenerator::addConstant):
* bytecompiler/CodeGenerator.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38219
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Fri, 7 Nov 2008 09:22:36 +0000 (09:22 +0000)]
Reviewed by Maciej Stachowiak.
Fix layout test brokenness following r38211.
* page/EventHandler.cpp: (WebCore::EventHandler::handleAccessKey):
Restore old Shift key behavior. We ignore Shift key state when matching access keys (which
matches neither IE nor Firefox), and this patch made WebKit behave like Firefox
inadvertently. This may or may not be a good thing, but it's certainly not something that
should change by accident.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38218
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zecke@webkit.org [Fri, 7 Nov 2008 08:59:21 +0000 (08:59 +0000)]
2008-11-07 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=22039
Enable text only and succeeding fast tests for the gtk port
Enable the tests from the fast directory that succeed. Classify the
remaining tests from the fast directory.
* platform/gtk/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38217
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zecke@webkit.org [Fri, 7 Nov 2008 08:53:30 +0000 (08:53 +0000)]
2008-11-07 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=22039
Skip every test on the Gtk+ platform
Add every test directory to the Skipped list in order to create
a baseline for the Gtk+ port.
* platform/gtk/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38216
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cwzwarich@webkit.org [Fri, 7 Nov 2008 07:41:18 +0000 (07:41 +0000)]
2008-11-06 Cameron Zwarich <zwarich@apple.com>
Reviewed by Geoff Garen.
Move the remaining files in the kjs subdirectory of JavaScriptCore to
a new parser subdirectory, and remove the kjs subdirectory entirely.
JavaScriptCore:
* AllInOneFile.cpp:
* DerivedSources.make:
* GNUmakefile.am:
* JavaScriptCore.pri:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.vcproj/jsc/jsc.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* JavaScriptCoreSources.bkl:
* VM/CodeBlock.h:
* VM/ExceptionHelpers.cpp:
* VM/SamplingTool.h:
* bytecompiler/CodeGenerator.h:
* jsc.pro:
* jscore.bkl:
* kjs: Removed.
* kjs/NodeInfo.h: Removed.
* kjs/Parser.cpp: Removed.
* kjs/Parser.h: Removed.
* kjs/ResultType.h: Removed.
* kjs/SourceCode.h: Removed.
* kjs/SourceProvider.h: Removed.
* kjs/grammar.y: Removed.
* kjs/keywords.table: Removed.
* kjs/lexer.cpp: Removed.
* kjs/lexer.h: Removed.
* kjs/nodes.cpp: Removed.
* kjs/nodes.h: Removed.
* kjs/nodes2string.cpp: Removed.
* parser: Added.
* parser/Grammar.y: Copied from kjs/grammar.y.
* parser/Keywords.table: Copied from kjs/keywords.table.
* parser/Lexer.cpp: Copied from kjs/lexer.cpp.
* parser/Lexer.h: Copied from kjs/lexer.h.
* parser/NodeInfo.h: Copied from kjs/NodeInfo.h.
* parser/Nodes.cpp: Copied from kjs/nodes.cpp.
* parser/Nodes.h: Copied from kjs/nodes.h.
* parser/Parser.cpp: Copied from kjs/Parser.cpp.
* parser/Parser.h: Copied from kjs/Parser.h.
* parser/ResultType.h: Copied from kjs/ResultType.h.
* parser/SourceCode.h: Copied from kjs/SourceCode.h.
* parser/SourceProvider.h: Copied from kjs/SourceProvider.h.
* parser/nodes2string.cpp: Copied from kjs/nodes2string.cpp.
* pcre/pcre.pri:
* pcre/pcre_exec.cpp:
* runtime/FunctionConstructor.cpp:
* runtime/JSActivation.h:
* runtime/JSFunction.h:
* runtime/JSGlobalData.cpp:
* runtime/JSGlobalObjectFunctions.cpp:
* runtime/JSObject.cpp:
(JSC::JSObject::toNumber):
* runtime/RegExp.cpp:
WebCore:
* ForwardingHeaders/kjs: Removed.
* ForwardingHeaders/kjs/Parser.h: Removed.
* ForwardingHeaders/kjs/SavedBuiltins.h: Removed.
* ForwardingHeaders/kjs/SourceCode.h: Removed.
* ForwardingHeaders/kjs/SourceProvider.h: Removed.
* ForwardingHeaders/parser: Added.
* ForwardingHeaders/parser/Parser.h: Copied from ForwardingHeaders/kjs/Parser.h.
* ForwardingHeaders/parser/SourceCode.h: Copied from ForwardingHeaders/kjs/SourceCode.h.
* ForwardingHeaders/parser/SourceProvider.h: Copied from ForwardingHeaders/kjs/SourceProvider.h.
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* bindings/js/StringSourceProvider.h:
* bindings/js/WorkerScriptController.cpp:
* bridge/NP_jsobject.cpp:
* bridge/jni/jni_jsobject.mm:
* bridge/testbindings.pro:
* inspector/JavaScriptDebugServer.cpp:
WebKit/mac:
* ForwardingHeaders/kjs: Removed.
* ForwardingHeaders/kjs/SavedBuiltins.h: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38215
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Fri, 7 Nov 2008 07:26:09 +0000 (07:26 +0000)]
2008-11-06 Antti Koivisto <antti@apple.com>
Eh, this trivial last minute change was wrong.
* loader/CachedCSSStyleSheet.cpp:
(WebCore::CachedCSSStyleSheet::sheetText):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38214
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Fri, 7 Nov 2008 07:22:43 +0000 (07:22 +0000)]
2008-11-06 Antti Koivisto <antti@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=22093
Delaying the text decoding caused regression since the decoding
also determines the encoding in case of @charset rule.
Decode immediately in data() and keep the decoded string around
during the checkNotify().
* loader/CachedCSSStyleSheet.cpp:
(WebCore::CachedCSSStyleSheet::sheetText):
(WebCore::CachedCSSStyleSheet::data):
* loader/CachedCSSStyleSheet.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38213
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Fri, 7 Nov 2008 05:54:49 +0000 (05:54 +0000)]
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=22097
Expose MessageEvent constructor on WorkerContext
* bindings/js/JSWorkerContext.cpp:
(WebCore::jsWorkerContextMessageEvent):
(WebCore::setJSWorkerContextMessageEvent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38212
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Fri, 7 Nov 2008 05:52:46 +0000 (05:52 +0000)]
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=21107
<rdar://problem/
6264219> New access key combination conflicts with VoiceOver
* page/EventHandler.h:
* page/gtk/EventHandlerGtk.cpp:
(WebCore::EventHandler::accessKeyModifiers):
* page/qt/EventHandlerQt.cpp:
(WebCore::EventHandler::accessKeyModifiers):
* page/win/EventHandlerWin.cpp:
(WebCore::EventHandler::accessKeyModifiers):
* page/wx/EventHandlerWx.cpp:
(WebCore::EventHandler::accessKeyModifiers):
Access access key modifiers via a function, not a static variable.
* page/mac/EventHandlerMac.mm: (WebCore::EventHandler::accessKeyModifiers):
Use Ctrl when VoiceOver is enabled, because a conflict with Emacs-style key bindings is
less troublesome than one with VO keys.
* page/EventHandler.cpp: (WebCore::EventHandler::handleAccessKey):
Also fix an access key matching bug introduced in r32424 - Any superset of specified
modifier set invoked access keys. We can use simple equality comparison instead because
CapsLock is not part of modifiers(), so it doesn't need to be ignored explicitly.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38211
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 7 Nov 2008 04:04:52 +0000 (04:04 +0000)]
WebCore:
2008-11-06 Anders Carlsson <andersca@apple.com>
Reviewed by Kevin Decker.
https://bugs.webkit.org/show_bug.cgi?id=22115
NPN_HasPropertyUPP and NPN_HasMethodUPP entries in NPNetscapeFuncs are NULL
Export _NPN_HasMethod and _NPN_HasProperty.
* WebCore.NPAPI.exp:
WebKit/mac:
2008-11-06 Anders Carlsson <andersca@apple.com>
Reviewed by Kevin Decker.
https://bugs.webkit.org/show_bug.cgi?id=22115
NPN_HasPropertyUPP and NPN_HasMethodUPP entries in NPNetscapeFuncs are NULL
Initialize the browser funcs correctly.
* Plugins/WebNetscapePluginPackage.m:
(-[WebNetscapePluginPackage load]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38210
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Fri, 7 Nov 2008 01:30:03 +0000 (01:30 +0000)]
2008-11-06 Gavin Barraclough barraclough@apple.com
Reviewed by Oliver Hunt.
Do not make a cti_* call to perform an op_call unless either:
(1) The codeblock for the function body has not been generated.
(2) The number of arguments passed does not match the callee arity.
~1% progression on sunspider --v8
* VM/CTI.cpp:
(JSC::CTI::compileOpCallInitializeCallFrame):
(JSC::CTI::compileOpCall):
(JSC::CTI::privateCompileSlowCases):
* VM/CTI.h:
* VM/Machine.cpp:
(JSC::Machine::cti_op_call_JSFunction):
(JSC::Machine::cti_op_call_arityCheck):
(JSC::Machine::cti_op_construct_JSConstruct):
* VM/Machine.h:
* kjs/nodes.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38209
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Fri, 7 Nov 2008 01:11:13 +0000 (01:11 +0000)]
2008-11-06 Simon Fraser <simon.fraser@apple.com>
Reviewed by Antti Koivisto
https://bugs.webkit.org/show_bug.cgi?id=15678
Fix transformed menu selects to show the popup in the correct
location.
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::showPopup):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38208
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer@apple.com [Fri, 7 Nov 2008 00:55:52 +0000 (00:55 +0000)]
BUILD FIX: Backed out r38189 (and r38203) for Xcode 3.0.
WebCore:
BUILD FIX: Backed out r38189 (and r38203) for Xcode 3.0.
Apparently older versions of gcc have issues with this patch.
Backing out a second time until the issues are resolved.
WebKit/mac:
BUILD FIX: Backed out r38189 (and r38203) for Xcode 3.0.
Apparently older versions of gcc have issues with this patch.
Backing out a second time until the issues are resolved.
WebKitTools:
BUILD FIX: Backed out r38189 (and r38203) for Xcode 3.0.
Apparently older versions of gcc have issues with this patch.
Backing out a second time until the issues are resolved.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38207
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jchaffraix@webkit.org [Fri, 7 Nov 2008 00:47:12 +0000 (00:47 +0000)]
2008-11-06 Julien Chaffraix <jchaffraix@pleyo.com>
Reviewed by Maciej Stachowiak.
Bug 21106: .in format discussed changes
https://bugs.webkit.org/show_bug.cgi?id=21106
Include the namespace into the interfaceName.
* dom/make_names.pl: Do not append the namespace when
using the interfaceName.
* html/HTMLTagNames.in: Added namespace prefix for custom
interfaceName.
* svg/svgtags.in: Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38206
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cwzwarich@webkit.org [Fri, 7 Nov 2008 00:18:07 +0000 (00:18 +0000)]
2008-11-06 Cameron Zwarich <zwarich@apple.com>
Reviewed by Geoff Garen.
Move the remaining files in the kjs subdirectory of JavaScriptCore to
a new parser subdirectory, and remove the kjs subdirectory entirely.
JavaScriptCore:
* AllInOneFile.cpp:
* DerivedSources.make:
* GNUmakefile.am:
* JavaScriptCore.pri:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.vcproj/jsc/jsc.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* JavaScriptCoreSources.bkl:
* VM/CodeBlock.h:
* VM/ExceptionHelpers.cpp:
* VM/SamplingTool.h:
* bytecompiler/CodeGenerator.h:
* jsc.pro:
* jscore.bkl:
* kjs: Removed.
* kjs/NodeInfo.h: Removed.
* kjs/Parser.cpp: Removed.
* kjs/Parser.h: Removed.
* kjs/ResultType.h: Removed.
* kjs/SourceCode.h: Removed.
* kjs/SourceProvider.h: Removed.
* kjs/grammar.y: Removed.
* kjs/keywords.table: Removed.
* kjs/lexer.cpp: Removed.
* kjs/lexer.h: Removed.
* kjs/nodes.cpp: Removed.
* kjs/nodes.h: Removed.
* kjs/nodes2string.cpp: Removed.
* parser: Added.
* parser/Grammar.y: Copied from kjs/grammar.y.
* parser/Keywords.table: Copied from kjs/keywords.table.
* parser/Lexer.cpp: Copied from kjs/lexer.cpp.
* parser/Lexer.h: Copied from kjs/lexer.h.
* parser/NodeInfo.h: Copied from kjs/NodeInfo.h.
* parser/Nodes.cpp: Copied from kjs/nodes.cpp.
* parser/Nodes.h: Copied from kjs/nodes.h.
* parser/Parser.cpp: Copied from kjs/Parser.cpp.
* parser/Parser.h: Copied from kjs/Parser.h.
* parser/ResultType.h: Copied from kjs/ResultType.h.
* parser/SourceCode.h: Copied from kjs/SourceCode.h.
* parser/SourceProvider.h: Copied from kjs/SourceProvider.h.
* parser/nodes2string.cpp: Copied from kjs/nodes2string.cpp.
* pcre/pcre.pri:
* pcre/pcre_exec.cpp:
* runtime/FunctionConstructor.cpp:
* runtime/JSActivation.h:
* runtime/JSFunction.h:
* runtime/JSGlobalData.cpp:
* runtime/JSGlobalObjectFunctions.cpp:
* runtime/JSObject.cpp:
(JSC::JSObject::toNumber):
* runtime/RegExp.cpp:
WebCore:
* ForwardingHeaders/kjs: Removed.
* ForwardingHeaders/kjs/Parser.h: Removed.
* ForwardingHeaders/kjs/SavedBuiltins.h: Removed.
* ForwardingHeaders/kjs/SourceCode.h: Removed.
* ForwardingHeaders/kjs/SourceProvider.h: Removed.
* ForwardingHeaders/parser: Added.
* ForwardingHeaders/parser/Parser.h: Copied from ForwardingHeaders/kjs/Parser.h.
* ForwardingHeaders/parser/SourceCode.h: Copied from ForwardingHeaders/kjs/SourceCode.h.
* ForwardingHeaders/parser/SourceProvider.h: Copied from ForwardingHeaders/kjs/SourceProvider.h.
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* bindings/js/StringSourceProvider.h:
* bindings/js/WorkerScriptController.cpp:
* bridge/NP_jsobject.cpp:
* bridge/jni/jni_jsobject.mm:
* bridge/testbindings.pro:
* inspector/JavaScriptDebugServer.cpp:
WebKit/mac:
* ForwardingHeaders/kjs: Removed.
* ForwardingHeaders/kjs/SavedBuiltins.h: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38205
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Fri, 7 Nov 2008 00:17:12 +0000 (00:17 +0000)]
2008-11-06 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Fix test that would fail if it had the wrong set of plugins.
* plugins/plugin-javascript-access.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38204
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer@apple.com [Thu, 6 Nov 2008 23:46:40 +0000 (23:46 +0000)]
BUILD WAS NOT BROKEN: Rolling r38189 back in.
WebCore:
BUILD WAS NOT BROKEN: Rolling r38189 back in.
Please perform a clean build if you see crashes.
WebKit/mac:
BUILD WAS NOT BROKEN: Rolling r38189 back in.
Please perform a clean build if you see crashes.
WebKitTools:
BUILD WAS NOT BROKEN: Rolling r38189 back in.
Please perform a clean build if you see crashes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38203
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer@apple.com [Thu, 6 Nov 2008 23:10:10 +0000 (23:10 +0000)]
BUILD FIX: Backed out r38189 since it apparently broke the world.
WebCore:
BUILD FIX: Backed out r38189 since it apparently broke the world.
WebKit/mac:
BUILD FIX: Backed out r38189 since it apparently broke the world.
WebKitTools:
BUILD FIX: Backed out r38189 since it apparently broke the world.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38202
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer@apple.com [Thu, 6 Nov 2008 22:23:43 +0000 (22:23 +0000)]
Fix indentation.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38201
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cfleizach@apple.com [Thu, 6 Nov 2008 22:16:27 +0000 (22:16 +0000)]
Bug 22112: if a <body> has contenteditable=true, it should report a writable AXValue
https://bugs.webkit.org/show_bug.cgi?id=22112
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38200
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 6 Nov 2008 22:03:49 +0000 (22:03 +0000)]
Windows build fix after r38196
* JavaScriptCore.vcproj/jsc/jsc.vcproj: Added bytecompiler/ to the
include path.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38199
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Thu, 6 Nov 2008 21:55:29 +0000 (21:55 +0000)]
2008-11-06 Sam Weinig <sam@webkit.org>
Reviewed by Alice Liu.
Fix failed assert at launch caused by unintialized data member on the mac.
* platform/network/mac/NetworkStateNotifierMac.cpp:
(WebCore::NetworkStateNotifier::NetworkStateNotifier):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38198
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
git://git.webkit.org / WebKit-https.git / log