WebKit-https.git
10 years agohttps://bugs.webkit.org/show_bug.cgi?id=47021
hyatt@apple.com [Sat, 2 Oct 2010 00:13:00 +0000 (00:13 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=47021

Reviewed by Dan Bernstein.

Patch the floatBottom function and its friends.  Rename them and consolidate them to be block-flow-aware.

Nothing testable yet, since most of the float code is still unpatched.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::layoutBlockChildren):
(WebCore::RenderBlock::layoutBlockChild):
(WebCore::RenderBlock::positionNewFloats):
(WebCore::RenderBlock::newLine):
(WebCore::RenderBlock::nextFloatLogicalBottomBelow):
(WebCore::RenderBlock::lowestFloatLogicalBottom):
(WebCore::RenderBlock::clearFloats):
(WebCore::RenderBlock::addOverhangingFloats):
(WebCore::RenderBlock::getClearDelta):
* rendering/RenderBlock.h:
(WebCore::RenderBlock::logicalBottomForFloat):
(WebCore::RenderBlock::hasOverhangingFloats):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::fitBelowFloats):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix Snow Leopard build.
andersca@apple.com [Sat, 2 Oct 2010 00:11:08 +0000 (00:11 +0000)]
Fix Snow Leopard build.

* Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::getProxy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix typo.
andersca@apple.com [Fri, 1 Oct 2010 23:49:58 +0000 (23:49 +0000)]
Fix typo.

* platform/network/qt/ProxyServerQt.cpp:
(WebCore::proxyServersForURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd Qt ProxyServer stub.
andersca@apple.com [Fri, 1 Oct 2010 23:45:33 +0000 (23:45 +0000)]
Add Qt ProxyServer stub.

* WebCore.pro:
* platform/network/qt/ProxyServerQt.cpp: Added.
(WebCore::proxyServersForURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoImplement proxiesForURL, cookiesForURL and setCookiesForURL
andersca@apple.com [Fri, 1 Oct 2010 23:42:13 +0000 (23:42 +0000)]
Implement proxiesForURL, cookiesForURL and setCookiesForURL
https://bugs.webkit.org/show_bug.cgi?id=47029

Reviewed by Sam Weinig.

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::proxiesForURL):
(WebKit::PluginView::cookiesForURL):
(WebKit::PluginView::setCookiesForURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd proxy server query function proxyServersForURL and change the Mac plug-in code...
andersca@apple.com [Fri, 1 Oct 2010 23:28:17 +0000 (23:28 +0000)]
Add proxy server query function proxyServersForURL and change the Mac plug-in code to use it
https://bugs.webkit.org/show_bug.cgi?id=47022
<rdar://problem/8504712>

Reviewed by Dan Bernstein.

WebCore:

* WebCore.exp.in:
Export proxyServersForURL and toString.

* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
Add new files.

* platform/network/ProxyServer.cpp: Added.
(WebCore::appendProxyServerString):
(WebCore::toString):
New function that converts a vector of ProxyServers into a PAC style string.

* platform/network/ProxyServer.h: Added.
(WebCore::ProxyServer::ProxyServer):
(WebCore::ProxyServer::type):
(WebCore::ProxyServer::hostName):
(WebCore::ProxyServer::port):
Add ProxyServer class.

* platform/network/cf/ProxyServerCFNet.cpp: Added.
(WebCore::proxyServersForURL):
(WebCore::addProxyServersForURL):
Query CFNetwork for the proxy servers given a URL.

WebKit/mac:

* Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::getProxy):
* Plugins/WebBaseNetscapePluginView.h:
* Plugins/WebBaseNetscapePluginView.mm:
* Plugins/WebNetscapePluginView.mm:
(-[WebNetscapePluginView getVariable:forURL:value:length:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-01 Evan Martin <evan@chromium.org>
tony@chromium.org [Fri, 1 Oct 2010 23:21:29 +0000 (23:21 +0000)]
2010-10-01  Evan Martin  <evan@chromium.org>

        Reviewed by Tony Chang.

        editing/selection/5354455-1 has incorrect description text
        https://bugs.webkit.org/show_bug.cgi?id=44990

        This test includes descriptive text that describes an OS X-specific behavior.
        I almost checked in an incorrect baseline because I believed the text.
        This change amends the text to describe expected behavior on Mac/Win/Linux.

        Rather than requiring new baselines on all platforms, I took this opportunity
        to also convert the test to a markup dump.  We'll then end up with just one
        Mac baseline and one non-Mac baseline.

        * editing/selection/5354455-1.html:
        * platform/chromium-linux/editing/selection/5354455-1-expected.checksum: Removed.
        * platform/chromium-linux/editing/selection/5354455-1-expected.png: Removed.
        * platform/chromium-win/editing/selection/5354455-1-expected.checksum: Removed.
        * platform/chromium-win/editing/selection/5354455-1-expected.png: Removed.
        * platform/chromium-win/editing/selection/5354455-1-expected.txt: Removed.
        * platform/chromium/test_expectations.txt:
        * platform/gtk/editing/selection/5354455-1-expected.txt: Removed.
        * platform/mac-leopard/editing/selection/5354455-1-expected.checksum: Removed.
        * platform/mac-leopard/editing/selection/5354455-1-expected.png: Removed.
        * platform/mac/editing/selection/5354455-1-expected.checksum: Removed.
        * platform/mac/editing/selection/5354455-1-expected.png: Removed.
        * platform/mac/editing/selection/5354455-1-expected.txt: Updated.
        * platform/win/editing/selection/5354455-1-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix. Not reviewed.
hclam@chromium.org [Fri, 1 Oct 2010 23:17:29 +0000 (23:17 +0000)]
Build fix. Not reviewed.

Add test expectations for Chromium.

* platform/chromium-linux/fast/blockflow/block-level-images-expected.checksum: Added.
* platform/chromium-linux/fast/blockflow/block-level-images-expected.png: Added.
* platform/chromium-linux/fast/css/rtl-to-viewport-expected.checksum: Added.
* platform/chromium-linux/fast/css/rtl-to-viewport-expected.png: Added.
* platform/chromium-linux/fast/css/rtl-to-viewport-expected.txt: Added.
* platform/chromium-linux/http/tests/websocket/tests/bad-sub-protocol-control-chars-expected.txt: Copied from LayoutTests/platform/chromium-linux/websocket/tests/bad-sub-protocol-control-chars-expected.txt.
* platform/chromium-linux/http/tests/websocket/tests/url-parsing-expected.txt: Added.
* platform/chromium-mac/fast/blockflow/block-level-images-expected.checksum: Added.
* platform/chromium-mac/fast/blockflow/block-level-images-expected.png: Added.
* platform/chromium-mac/fast/css/rtl-to-viewport-expected.checksum: Added.
* platform/chromium-mac/fast/css/rtl-to-viewport-expected.png: Added.
* platform/chromium-mac/http/tests/websocket/tests/bad-sub-protocol-control-chars-expected.txt: Copied from LayoutTests/platform/chromium-linux/websocket/tests/bad-sub-protocol-control-chars-expected.txt.
* platform/chromium-mac/http/tests/websocket/tests/url-parsing-expected.txt: Added.
* platform/chromium-win-xp/fast/blockflow/block-level-images-expected.png: Added.
* platform/chromium-win-xp/fast/css/rtl-to-viewport-expected.png: Added.
* platform/chromium-win/fast/blockflow/block-level-images-expected.checksum: Added.
* platform/chromium-win/fast/blockflow/block-level-images-expected.png: Added.
* platform/chromium-win/fast/css/rtl-to-viewport-expected.checksum: Added.
* platform/chromium-win/fast/css/rtl-to-viewport-expected.png: Added.
* platform/chromium-win/fast/css/rtl-to-viewport-expected.txt: Added.
* platform/chromium-win/http/tests/websocket/tests/bad-sub-protocol-control-chars-expected.txt: Copied from LayoutTests/platform/chromium-win/websocket/tests/bad-sub-protocol-control-chars-expected.txt.
* platform/chromium-win/http/tests/websocket/tests/url-parsing-expected.txt: Added.
* platform/chromium-win/platform/win/plugins/get-value-netscape-window-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFixed a typo
mitz@apple.com [Fri, 1 Oct 2010 23:09:33 +0000 (23:09 +0000)]
Fixed a typo

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-30 Zhenyao Mo <zmo@google.com>
zmo@google.com [Fri, 1 Oct 2010 23:08:27 +0000 (23:08 +0000)]
2010-09-30  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        texImage2D fails on 16-bit-per-channel images
        https://bugs.webkit.org/show_bug.cgi?id=46947

        * platform/graphics/GraphicsContext3D.cpp: Handling 16-bit-per-channel source formats.
        (WebCore::convertColor16To8):
        (WebCore::doPacking):
        * platform/graphics/GraphicsContext3D.h: Ditto.
        * platform/graphics/cg/GraphicsContext3DCG.cpp: Ditto.
        (WebCore::GraphicsContext3D::getImageData):
2010-09-30  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        texImage2D fails on 16-bit-per-channel images
        https://bugs.webkit.org/show_bug.cgi?id=46947

        * fast/canvas/webgl/gl-teximage-expected.txt: Add a test case for loading 16-bit-per-channel images as textures.
        * fast/canvas/webgl/gl-teximage.html: Ditto.
        * fast/canvas/webgl/resources/green-2x2-16bit.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix. Not reviewed.
hclam@chromium.org [Fri, 1 Oct 2010 22:30:19 +0000 (22:30 +0000)]
Build fix. Not reviewed.

Add test expectations for Chromium.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-01 Eric Uhrhane <ericu@chromium.org>
commit-queue@webkit.org [Fri, 1 Oct 2010 22:09:45 +0000 (22:09 +0000)]
2010-10-01  Eric Uhrhane  <ericu@chromium.org>

        Reviewed by Nate Chapin.

        Add v8 binding helpers to make FileWriter be an EventTarget.
        https://bugs.webkit.org/show_bug.cgi?id=46910

        No new tests; still waiting for the first complete implementation.

        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::convertEventTargetToV8Object):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd additional WKString API
weinig@apple.com [Fri, 1 Oct 2010 22:00:00 +0000 (22:00 +0000)]
Add additional WKString API
https://bugs.webkit.org/show_bug.cgi?id=46958

Reviewed by Kenneth Rohde Christiansen.

WebKit2:

API Test: WebKit2/WKString

* Shared/API/c/WKString.cpp:
(WKStringCreateWithUTF8CString):
(WKStringGetMaximumUTF8CStringSize):
(WKStringGetUTF8CString):
(WKStringIsEqual):
(WKStringIsEqualToUTF8CString):
* Shared/API/c/WKString.h:
* Shared/WebString.h:
(WebKit::WebString::createFromUTF8String):
(WebKit::WebString::maximumUTF8CStringSize):
(WebKit::WebString::getUTF8CString):
(WebKit::WebString::equal):
(WebKit::WebString::equalToUTF8String):

WebKitTools:

Add basic WKStringRef tests.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit2/WKString.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-01 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Fri, 1 Oct 2010 21:57:35 +0000 (21:57 +0000)]
2010-10-01  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Nate Chapin.

        [Chromium] Remove WebURLLoaderClient::didFinishLoading(WebURLLoader*)
        https://bugs.webkit.org/show_bug.cgi?id=47008

        Now that WebURLLoaderClient::didFinishLoading(WebURLLoader*) has no
        more callers, it can be removed (requires a Chromium roll to
        http://crrev.com/61206, which actually removed the last usage).

        * DEPS:
        * public/WebURLLoaderClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-01 Alex Mathews <possessedpenguinbob@gmail.com>
commit-queue@webkit.org [Fri, 1 Oct 2010 21:43:05 +0000 (21:43 +0000)]
2010-10-01  Alex Mathews  <possessedpenguinbob@gmail.com>

        Reviewed by Simon Fraser.

        Bug 47013 - Main Web Inspector link on webkit.org links to old wiki page
        https://bugs.webkit.org/show_bug.cgi?id=47013

        * nav.inc: Removed the space from the web inspector wiki link.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoLand post-XP results for fast/text/backslash-to-yen-sign-euc.html
aroben@apple.com [Fri, 1 Oct 2010 21:30:29 +0000 (21:30 +0000)]
Land post-XP results for fast/text/backslash-to-yen-sign-euc.html

The fonts this test uses must have changed after Windows XP

* platform/win-xp/fast/text/backslash-to-yen-sign-euc-expected.txt:
Copied from LayoutTests/platform/win/fast/text/backslash-to-yen-sign-euc-expected.txt.
* platform/win/fast/text/backslash-to-yen-sign-euc-expected.txt:
Updated for post-XP.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=47015
hyatt@apple.com [Fri, 1 Oct 2010 21:25:39 +0000 (21:25 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=47015

Reviewed by Sam Weinig.

Change FloatingObject to store its dimensions as a rect.
This will make it easier for logical access for block-flow later on if
top/bottom is no different from left/width.  This change also simplifies
calling code a bit in places.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addOverflowFromFloats):
(WebCore::RenderBlock::repaintOverhangingFloats):
(WebCore::RenderBlock::paintFloats):
(WebCore::RenderBlock::fillSelectionGaps):
(WebCore::RenderBlock::insertFloatingObject):
(WebCore::RenderBlock::removeFloatingObject):
(WebCore::RenderBlock::removeFloatingObjectsBelow):
(WebCore::RenderBlock::positionNewFloats):
(WebCore::RenderBlock::positionNewFloatOnLine):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::logicalRightOffsetForLine):
(WebCore::RenderBlock::nextFloatBottomBelow):
(WebCore::RenderBlock::floatBottom):
(WebCore::RenderBlock::lowestPosition):
(WebCore::RenderBlock::rightmostPosition):
(WebCore::RenderBlock::leftmostPosition):
(WebCore::RenderBlock::leftBottom):
(WebCore::RenderBlock::rightBottom):
(WebCore::RenderBlock::clearFloats):
(WebCore::RenderBlock::addOverhangingFloats):
(WebCore::RenderBlock::addIntrudingFloats):
(WebCore::RenderBlock::hitTestFloats):
(WebCore::RenderBlock::adjustForBorderFit):
* rendering/RenderBlock.h:
(WebCore::RenderBlock::FloatingObject::FloatingObject):
(WebCore::RenderBlock::FloatingObject::left):
(WebCore::RenderBlock::FloatingObject::right):
(WebCore::RenderBlock::FloatingObject::top):
(WebCore::RenderBlock::FloatingObject::bottom):
(WebCore::RenderBlock::FloatingObject::width):
(WebCore::RenderBlock::FloatingObject::height):
(WebCore::RenderBlock::FloatingObject::setLeft):
(WebCore::RenderBlock::FloatingObject::setTop):
(WebCore::RenderBlock::FloatingObject::setWidth):
(WebCore::RenderBlock::FloatingObject::setHeight):
(WebCore::RenderBlock::FloatingObject::frameRect):
(WebCore::RenderBlock::FloatingObject::setFrameRect):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::matchedEndLine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-01 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 1 Oct 2010 21:18:28 +0000 (21:18 +0000)]
2010-10-01  Adam Barth  <abarth@webkit.org>

        Add a Gtk-specific baseline for a WebSocket test.

        * platform/gtk/http/tests/websocket: Added.
        * platform/gtk/http/tests/websocket/tests: Added.
        * platform/gtk/http/tests/websocket/tests/bad-sub-protocol-control-chars-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix. Not reviewed.
hclam@chromium.org [Fri, 1 Oct 2010 21:07:37 +0000 (21:07 +0000)]
Build fix. Not reviewed.

Add the dummy README file to solve build breakages in Chromium.
It should be removed once the breakage is resolved.

* websocket/tests/workers/README: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDOMFocusIn/DOMFocusOut return focusin/focusout Event.type
enrica@apple.com [Fri, 1 Oct 2010 20:50:41 +0000 (20:50 +0000)]
DOMFocusIn/DOMFocusOut return focusin/focusout Event.type
https://bugs.webkit.org/show_bug.cgi?id=42580
<rdar://problem/8107311>

Reviewed by Darin Adler.

WebCore:

This change removes the aliased type machinery from the Event class.
We now fire the event with the new name and the oldname.

Tests: Modified fast/events/focusinout.html to check the event
type.

* dom/Document.cpp:
(WebCore::Document::setFocusedNode):
* dom/Event.cpp: Removed aliasedType and hasAliasedType.
* dom/Event.h: Removed aliasedType and hasAliasedType.
* dom/EventTarget.cpp:
(WebCore::EventTarget::fireEventListeners): Removed aliasedType related code.

LayoutTests:

* fast/events/focusinout.html: Modified to check the event type.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd makefile for TestWebKitAPI and call it from the base makefile.
weinig@apple.com [Fri, 1 Oct 2010 20:44:35 +0000 (20:44 +0000)]
Add makefile for TestWebKitAPI and call it from the base makefile.

Reviewed by Dan Bernstein.

* Makefile:
* TestWebKitAPI/Makefile: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoLand new Windows results for fast/text/international/bidi-mirror-he-ar.html
aroben@apple.com [Fri, 1 Oct 2010 20:42:20 +0000 (20:42 +0000)]
Land new Windows results for fast/text/international/bidi-mirror-he-ar.html

Fixes <http://webkit.org/b/47001> <rdar://problem/8503550>
fast/text/international/bidi-mirror-he-ar.html fails on Windows

Recommended by Dan Bernstein.

* platform/win/fast/text/international/bidi-mirror-he-ar-expected.checksum: Added.
* platform/win/fast/text/international/bidi-mirror-he-ar-expected.png: Added.
* platform/win/fast/text/international/bidi-mirror-he-ar-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-01 Rafael Antognolli <antognolli@profusion.mobi>
commit-queue@webkit.org [Fri, 1 Oct 2010 20:29:19 +0000 (20:29 +0000)]
2010-10-01  Rafael Antognolli  <antognolli@profusion.mobi>

        Reviewed by Kenneth Rohde Christiansen.

        [EFL] Remove check for InitLayoutCompleted on fixed_layout_size_set.
        https://bugs.webkit.org/show_bug.cgi?id=47006

        This check isn't needed and isn't done on the other ports. The fixed
        layout property can be set before we have the first layout.

        * ewk/ewk_view.cpp:
        (ewk_view_fixed_layout_size_set):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove unnecessary ForwardingHeaders from test runners.
weinig@apple.com [Fri, 1 Oct 2010 20:25:22 +0000 (20:25 +0000)]
Remove unnecessary ForwardingHeaders from test runners.
https://bugs.webkit.org/show_bug.cgi?id=47010

Reviewed by Adam Roben.

* TestWebKitAPI/Configurations/Base.xcconfig:
* TestWebKitAPI/ForwardingHeaders: Removed.
* WebKitTestRunner/Configurations/Base.xcconfig:
* WebKitTestRunner/ForwardingHeaders: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-01 Rafael Antognolli <antognolli@profusion.mobi>
commit-queue@webkit.org [Fri, 1 Oct 2010 20:05:16 +0000 (20:05 +0000)]
2010-10-01  Rafael Antognolli  <antognolli@profusion.mobi>

        Reviewed by Kenneth Rohde Christiansen.

        [EFL] Call contents_resize when the main frame gets resized.
        https://bugs.webkit.org/show_bug.cgi?id=47004

        The previous implementation was just calling contents_resize when the
        viewport size had changed. That's not enough, and contents_resize
        shouldn't be called if the contents size didn't change.

        Now the contents_size_changed function is called directly from the
        ChromeClientEfl.

        * WebCoreSupport/ChromeClientEfl.cpp:
        (WebCore::ChromeClientEfl::contentsSizeChanged):
        * ewk/ewk_private.h:
        * ewk/ewk_view.cpp:
        (_ewk_view_smart_calculate):
        (ewk_view_fixed_layout_size_set):
        (ewk_view_contents_size_changed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=46642, make replaced elements work with block...
hyatt@apple.com [Fri, 1 Oct 2010 19:59:48 +0000 (19:59 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=46642, make replaced elements work with block-flow.  This patch changes
all of the computeReplacedLogicalWidth and comuteReplacedLogicalHeight functions (and their helpers) to use logical width
and logical height instead.

Reviewed by Darin Adler.

Added fast/blockflow/block-level-images.html

WebCore:

* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeLogicalWidth):
(WebCore::RenderBox::computeLogicalHeight):
(WebCore::RenderBox::computeReplacedLogicalWidth):
(WebCore::RenderBox::computeReplacedLogicalWidthUsing):
(WebCore::RenderBox::computeReplacedLogicalHeight):
(WebCore::RenderBox::computeReplacedLogicalHeightUsing):
(WebCore::RenderBox::computePositionedLogicalWidthReplaced):
(WebCore::RenderBox::computePositionedLogicalHeightReplaced):
* rendering/RenderBox.h:
(WebCore::RenderBox::intrinsicLogicalWidth):
(WebCore::RenderBox::intrinsicLogicalHeight):
* rendering/RenderImage.cpp:
(WebCore::RenderImage::isLogicalWidthSpecified):
(WebCore::RenderImage::isLogicalHeightSpecified):
(WebCore::RenderImage::computeReplacedLogicalWidth):
(WebCore::RenderImage::computeReplacedLogicalHeight):
(WebCore::RenderImage::calcAspectRatioLogicalWidth):
(WebCore::RenderImage::calcAspectRatioLogicalHeight):
* rendering/RenderImage.h:
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::layout):
(WebCore::RenderReplaced::computeReplacedLogicalWidth):
(WebCore::RenderReplaced::computeReplacedLogicalHeight):
(WebCore::RenderReplaced::calcAspectRatioLogicalWidth):
(WebCore::RenderReplaced::calcAspectRatioLogicalHeight):
(WebCore::RenderReplaced::computePreferredLogicalWidths):
* rendering/RenderReplaced.h:
* rendering/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::computePreferredLogicalWidths):
(WebCore::RenderSVGRoot::computeReplacedLogicalWidth):
(WebCore::RenderSVGRoot::computeReplacedLogicalHeight):
* rendering/RenderSVGRoot.h:
* rendering/RenderVideo.cpp:
(WebCore::RenderVideo::computeReplacedLogicalWidth):
(WebCore::RenderVideo::computeReplacedLogicalHeight):
* rendering/RenderVideo.h:

LayoutTests:

* fast/blockflow/block-level-images.html: Added.
* fast/blockflow/resources: Added.
* fast/blockflow/resources/circle.svg: Added.
* fast/blockflow/resources/oval.png: Added.
* platform/mac/fast/blockflow/block-level-images-expected.checksum: Added.
* platform/mac/fast/blockflow/block-level-images-expected.png: Added.
* platform/mac/fast/blockflow/block-level-images-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-01 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Fri, 1 Oct 2010 19:52:55 +0000 (19:52 +0000)]
2010-10-01  Nate Chapin  <japhet@chromium.org>

        Reviewed by Darin Adler.

        Remove unused Request::buffer() and Request::m_buffer.

        https://bugs.webkit.org/show_bug.cgi?id=47003

        * loader/Request.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-01 Daniel Cheng <dcheng@chromium.org>
commit-queue@webkit.org [Fri, 1 Oct 2010 19:40:35 +0000 (19:40 +0000)]
2010-10-01  Daniel Cheng  <dcheng@chromium.org>

        Reviewed by Tony Chang.

        [chromium] Minor naming cleanup in WebDragData
        https://bugs.webkit.org/show_bug.cgi?id=46937

        This is a two-part patch--one to add the new methods with normalized
        names that follow general WebKit convention, and a followup patch to
        remove the original methods once Chromium is updated.

        * public/WebDragData.h:
        * src/WebDragData.cpp:
        (WebKit::WebDragData::hasFileNames): renamed to containsFilenames
        (WebKit::WebDragData::fileNames): renamed to filenames
        (WebKit::WebDragData::setFileNames): renamed to setFilenames
        (WebKit::WebDragData::appendToFileNames): renamed to appendToFilenames
        (WebKit::WebDragData::containsFilenames):
        (WebKit::WebDragData::filenames):
        (WebKit::WebDragData::setFilenames):
        (WebKit::WebDragData::appendToFilenames):
        (WebKit::WebDragData::fileContentFileName): renamed to fileContentFilename
        (WebKit::WebDragData::setFileContentFileName): renamed to setFileContentFilename
        (WebKit::WebDragData::fileContentFilename):
        (WebKit::WebDragData::setFileContentFilename):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-30 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 1 Oct 2010 19:40:07 +0000 (19:40 +0000)]
2010-09-30  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        WebSocket tests are flaky
        https://bugs.webkit.org/show_bug.cgi?id=46956

        Hosting the WebSocket tests using the Python HTTP server causes the
        tests to time out occationally.  This patch moves the tests to be
        hosted by the usual Apache server.

        This patch doesn't completely eliminate the flakiness.  However,
        testing on my local machine shows that it reduces it by a large factor.
        I suspect there's more flakiness hiding in the Python server, but this
        patch makes some amount of progress on the issue.

        * http/tests/websocket: Copied from LayoutTests/websocket.
        * http/tests/websocket/tests/alert-in-event-handler.html:
        * http/tests/websocket/tests/bad-handshake-crash.html:
        * http/tests/websocket/tests/bad-sub-protocol-control-chars.html:
        * http/tests/websocket/tests/bad-sub-protocol-empty.html:
        * http/tests/websocket/tests/bad-sub-protocol-non-ascii.html:
        * http/tests/websocket/tests/bufferedAmount-after-close.html:
        * http/tests/websocket/tests/close-on-navigate-new-location.html:
        * http/tests/websocket/tests/close-on-unload-and-force-gc.html:
        * http/tests/websocket/tests/close-on-unload-reference-in-parent.html:
        * http/tests/websocket/tests/close-on-unload.html:
        * http/tests/websocket/tests/cross-origin-expected.txt:
        * http/tests/websocket/tests/cross-origin.html:
        * http/tests/websocket/tests/error-detect.html:
        * http/tests/websocket/tests/frame-length-longer-than-buffer.html:
        * http/tests/websocket/tests/frame-length-overflow.html:
        * http/tests/websocket/tests/frame-length-skip.html:
        * http/tests/websocket/tests/handshake-challenge-randomness.html:
        * http/tests/websocket/tests/handshake-error.html:
        * http/tests/websocket/tests/handshake-fail-by-cross-origin-expected.txt:
        * http/tests/websocket/tests/handshake-fail-by-cross-origin.html:
        * http/tests/websocket/tests/handshake-fail-by-no-cr.html:
        * http/tests/websocket/tests/handshake-fail-by-sub-protocol-mismatch.html:
        * http/tests/websocket/tests/httponly-cookie.pl:
        * http/tests/websocket/tests/long-invalid-header.html:
        * http/tests/websocket/tests/null-character.html:
        * http/tests/websocket/tests/reload-crash.html:
        * http/tests/websocket/tests/resources/close-on-unload-iframe-reference-in-parent.html:
        * http/tests/websocket/tests/resources/close-on-unload-iframe.html:
        * http/tests/websocket/tests/resources/js-test-post-function.js: Copied from LayoutTests/fast/js/resources/js-test-post-function.js.
        * http/tests/websocket/tests/resources/js-test-pre.js: Copied from LayoutTests/fast/js/resources/js-test-pre.js.
        * http/tests/websocket/tests/resources/js-test-style.css: Copied from LayoutTests/fast/js/resources/js-test-style.css.
        * http/tests/websocket/tests/resources/reload-crash-iframe.html:
        * http/tests/websocket/tests/script-tests/TEMPLATE.html:
        * http/tests/websocket/tests/script-tests/cross-origin.js:
        (endTest):
        * http/tests/websocket/tests/send-after-close-on-unload.html:
        * http/tests/websocket/tests/send-throw.html:
        * http/tests/websocket/tests/send.html:
        * http/tests/websocket/tests/simple.html:
        * http/tests/websocket/tests/sub-protocol-with-space.html:
        * http/tests/websocket/tests/sub-protocol.html:
        * http/tests/websocket/tests/unicode.html:
        * http/tests/websocket/tests/url-no-trailing-slash.html:
        * http/tests/websocket/tests/url-parsing-expected.txt:
        * http/tests/websocket/tests/url-parsing.html:
        * http/tests/websocket/tests/url-with-credential.html:
        * http/tests/websocket/tests/url-with-empty-query.html:
        * http/tests/websocket/tests/url-with-query-for-no-query.html:
        * http/tests/websocket/tests/url-with-query.html:
        * http/tests/websocket/tests/websocket-event-target.html:
        * http/tests/websocket/tests/websocket-protocol-ignored.html:
        * platform/chromium-gpu/test_expectations.txt:
        * platform/chromium/test_expectations.txt:
        * platform/mac/test_expectations.txt:
        * platform/win/Skipped:
        * websocket: Removed.
        * websocket/resources: Removed.
        * websocket/resources/server-failed-to-start.html: Removed.
        * websocket/tests: Removed.
        * websocket/tests/alert-in-event-handler-expected.txt: Removed.
        * websocket/tests/alert-in-event-handler.html: Removed.
        * websocket/tests/bad-handshake-crash-expected.txt: Removed.
        * websocket/tests/bad-handshake-crash.html: Removed.
        * websocket/tests/bad-handshake-crash_wsh.py: Removed.
        * websocket/tests/bad-sub-protocol-control-chars-expected.txt: Removed.
        * websocket/tests/bad-sub-protocol-control-chars.html: Removed.
        * websocket/tests/bad-sub-protocol-empty-expected.txt: Removed.
        * websocket/tests/bad-sub-protocol-empty.html: Removed.
        * websocket/tests/bad-sub-protocol-non-ascii-expected.txt: Removed.
        * websocket/tests/bad-sub-protocol-non-ascii.html: Removed.
        * websocket/tests/bufferedAmount-after-close-expected.txt: Removed.
        * websocket/tests/bufferedAmount-after-close.html: Removed.
        * websocket/tests/close-on-navigate-new-location-expected.txt: Removed.
        * websocket/tests/close-on-navigate-new-location.html: Removed.
        * websocket/tests/close-on-unload-and-force-gc-expected.txt: Removed.
        * websocket/tests/close-on-unload-and-force-gc.html: Removed.
        * websocket/tests/close-on-unload-expected.txt: Removed.
        * websocket/tests/close-on-unload-reference-in-parent-expected.txt: Removed.
        * websocket/tests/close-on-unload-reference-in-parent.html: Removed.
        * websocket/tests/close-on-unload.html: Removed.
        * websocket/tests/close-on-unload_wsh.py: Removed.
        * websocket/tests/cross-origin-expected.txt: Removed.
        * websocket/tests/cross-origin.html: Removed.
        * websocket/tests/echo-challenge_wsh.py: Removed.
        * websocket/tests/echo-cookie_wsh.py: Removed.
        * websocket/tests/echo-location_wsh.py: Removed.
        * websocket/tests/echo_wsh.py: Removed.
        * websocket/tests/error-detect-expected.txt: Removed.
        * websocket/tests/error-detect.html: Removed.
        * websocket/tests/fixed-origin_wsh.py: Removed.
        * websocket/tests/frame-length-longer-than-buffer-expected.txt: Removed.
        * websocket/tests/frame-length-longer-than-buffer.html: Removed.
        * websocket/tests/frame-length-longer-than-buffer_wsh.py: Removed.
        * websocket/tests/frame-length-overflow-expected.txt: Removed.
        * websocket/tests/frame-length-overflow.html: Removed.
        * websocket/tests/frame-length-overflow_wsh.py: Removed.
        * websocket/tests/frame-length-skip-expected.txt: Removed.
        * websocket/tests/frame-length-skip.html: Removed.
        * websocket/tests/frame-length-skip_wsh.py: Removed.
        * websocket/tests/frame-lengths-expected.txt: Removed.
        * websocket/tests/frame-lengths.html: Removed.
        * websocket/tests/handler_map.txt: Removed.
        * websocket/tests/handshake-challenge-randomness-expected.txt: Removed.
        * websocket/tests/handshake-challenge-randomness.html: Removed.
        * websocket/tests/handshake-error-expected.txt: Removed.
        * websocket/tests/handshake-error.html: Removed.
        * websocket/tests/handshake-error_wsh.py: Removed.
        * websocket/tests/handshake-fail-by-cross-origin-expected.txt: Removed.
        * websocket/tests/handshake-fail-by-cross-origin.html: Removed.
        * websocket/tests/handshake-fail-by-no-cr-expected.txt: Removed.
        * websocket/tests/handshake-fail-by-no-cr.html: Removed.
        * websocket/tests/handshake-fail-by-no-cr_wsh.py: Removed.
        * websocket/tests/handshake-fail-by-sub-protocol-mismatch-expected.txt: Removed.
        * websocket/tests/handshake-fail-by-sub-protocol-mismatch.html: Removed.
        * websocket/tests/httponly-cookie-expected.txt: Removed.
        * websocket/tests/httponly-cookie.pl: Removed.
        * websocket/tests/long-invalid-header-expected.txt: Removed.
        * websocket/tests/long-invalid-header.html: Removed.
        * websocket/tests/long-invalid-header_wsh.py: Removed.
        * websocket/tests/multiple-connections-expected.txt: Removed.
        * websocket/tests/multiple-connections.html: Removed.
        * websocket/tests/no-query_wsh.py: Removed.
        * websocket/tests/null-character-expected.txt: Removed.
        * websocket/tests/null-character.html: Removed.
        * websocket/tests/origin-test_wsh.py: Removed.
        * websocket/tests/protocol-test_wsh.py: Removed.
        * websocket/tests/reload-crash-expected.txt: Removed.
        * websocket/tests/reload-crash.html: Removed.
        * websocket/tests/resources: Removed.
        * websocket/tests/resources/close-on-unload-iframe-reference-in-parent.html: Removed.
        * websocket/tests/resources/close-on-unload-iframe.html: Removed.
        * websocket/tests/resources/reload-crash-iframe.html: Removed.
        * websocket/tests/script-tests: Removed.
        * websocket/tests/script-tests/TEMPLATE.html: Removed.
        * websocket/tests/script-tests/alert-in-event-handler.js: Removed.
        * websocket/tests/script-tests/bad-handshake-crash.js: Removed.
        * websocket/tests/script-tests/bad-sub-protocol-control-chars.js: Removed.
        * websocket/tests/script-tests/bad-sub-protocol-empty.js: Removed.
        * websocket/tests/script-tests/bad-sub-protocol-non-ascii.js: Removed.
        * websocket/tests/script-tests/bufferedAmount-after-close.js: Removed.
        * websocket/tests/script-tests/cross-origin.js: Removed.
        * websocket/tests/script-tests/error-detect.js: Removed.
        * websocket/tests/script-tests/frame-length-longer-than-buffer.js: Removed.
        * websocket/tests/script-tests/frame-length-skip.js: Removed.
        * websocket/tests/script-tests/handshake-challenge-randomness.js: Removed.
        * websocket/tests/script-tests/handshake-error.js: Removed.
        * websocket/tests/script-tests/handshake-fail-by-cross-origin.js: Removed.
        * websocket/tests/script-tests/handshake-fail-by-no-cr.js: Removed.
        * websocket/tests/script-tests/handshake-fail-by-sub-protocol-mismatch.js: Removed.
        * websocket/tests/script-tests/long-invalid-header.js: Removed.
        * websocket/tests/script-tests/null-character.js: Removed.
        * websocket/tests/script-tests/send-throw.js: Removed.
        * websocket/tests/script-tests/send.js: Removed.
        * websocket/tests/script-tests/simple.js: Removed.
        * websocket/tests/script-tests/sub-protocol-with-space.js: Removed.
        * websocket/tests/script-tests/sub-protocol.js: Removed.
        * websocket/tests/script-tests/unicode.js: Removed.
        * websocket/tests/script-tests/url-no-trailing-slash.js: Removed.
        * websocket/tests/script-tests/url-parsing.js: Removed.
        * websocket/tests/script-tests/url-with-credential.js: Removed.
        * websocket/tests/script-tests/url-with-empty-query.js: Removed.
        * websocket/tests/script-tests/url-with-query-for-no-query.js: Removed.
        * websocket/tests/script-tests/url-with-query.js: Removed.
        * websocket/tests/script-tests/websocket-event-target.js: Removed.
        * websocket/tests/script-tests/websocket-protocol-ignored.js: Removed.
        * websocket/tests/send-after-close-on-unload-expected.txt: Removed.
        * websocket/tests/send-after-close-on-unload.html: Removed.
        * websocket/tests/send-expected.txt: Removed.
        * websocket/tests/send-throw-expected.txt: Removed.
        * websocket/tests/send-throw.html: Removed.
        * websocket/tests/send.html: Removed.
        * websocket/tests/send2_wsh.py: Removed.
        * websocket/tests/send_wsh.py: Removed.
        * websocket/tests/simple-expected.txt: Removed.
        * websocket/tests/simple-stress-expected.txt: Removed.
        * websocket/tests/simple-stress.html: Removed.
        * websocket/tests/simple.html: Removed.
        * websocket/tests/simple_wsh.py: Removed.
        * websocket/tests/sub-protocol-expected.txt: Removed.
        * websocket/tests/sub-protocol-with-space-expected.txt: Removed.
        * websocket/tests/sub-protocol-with-space.html: Removed.
        * websocket/tests/sub-protocol.html: Removed.
        * websocket/tests/unicode-expected.txt: Removed.
        * websocket/tests/unicode.html: Removed.
        * websocket/tests/unicode_wsh.py: Removed.
        * websocket/tests/unknown-frame-type_wsh.py: Removed.
        * websocket/tests/url-no-trailing-slash-expected.txt: Removed.
        * websocket/tests/url-no-trailing-slash.html: Removed.
        * websocket/tests/url-parsing-expected.txt: Removed.
        * websocket/tests/url-parsing.html: Removed.
        * websocket/tests/url-with-credential-expected.txt: Removed.
        * websocket/tests/url-with-credential.html: Removed.
        * websocket/tests/url-with-empty-query-expected.txt: Removed.
        * websocket/tests/url-with-empty-query.html: Removed.
        * websocket/tests/url-with-query-expected.txt: Removed.
        * websocket/tests/url-with-query-for-no-query-expected.txt: Removed.
        * websocket/tests/url-with-query-for-no-query.html: Removed.
        * websocket/tests/url-with-query.html: Removed.
        * websocket/tests/websocket-event-target-expected.txt: Removed.
        * websocket/tests/websocket-event-target.html: Removed.
        * websocket/tests/websocket-pending-activity-expected.txt: Removed.
        * websocket/tests/websocket-pending-activity.html: Removed.
        * websocket/tests/websocket-protocol-ignored-expected.txt: Removed.
        * websocket/tests/websocket-protocol-ignored.html: Removed.
        * websocket/tests/workers: Removed.
        * websocket/tests/workers/close-in-onmessage-crash-expected.txt: Removed.
        * websocket/tests/workers/close-in-onmessage-crash.html: Removed.
        * websocket/tests/workers/close-in-shared-worker-expected.txt: Removed.
        * websocket/tests/workers/close-in-shared-worker.html: Removed.
        * websocket/tests/workers/close-in-worker-expected.txt: Removed.
        * websocket/tests/workers/close-in-worker.html: Removed.
        * websocket/tests/workers/resources: Removed.
        * websocket/tests/workers/resources/close-in-onmessage-crash.js: Removed.
        * websocket/tests/workers/resources/close-in-worker.js: Removed.
        * websocket/tests/workers/resources/echo-challenge_wsh.py: Removed.
        * websocket/tests/workers/resources/echo_wsh.py: Removed.
        * websocket/tests/workers/resources/simple_wsh.py: Removed.
        * websocket/tests/workers/resources/worker-handshake-challenge-randomness.js: Removed.
        * websocket/tests/workers/resources/worker-simple.js: Removed.
        * websocket/tests/workers/shared-worker-simple-expected.txt: Removed.
        * websocket/tests/workers/shared-worker-simple.html: Removed.
        * websocket/tests/workers/worker-handshake-challenge-randomness-expected.txt: Removed.
        * websocket/tests/workers/worker-handshake-challenge-randomness.html: Removed.
        * websocket/tests/workers/worker-simple-expected.txt: Removed.
        * websocket/tests/workers/worker-simple.html: Removed.
2010-09-30  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        WebSocket tests are flaky
        https://bugs.webkit.org/show_bug.cgi?id=46956

        Update these tools to understand how to run the WebSocket tests off the
        Apache server.

        * Scripts/old-run-webkit-tests:
        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/websocket_server.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoEncode Executive command arguments using UTF-8 on Cygwin
aroben@apple.com [Fri, 1 Oct 2010 19:38:00 +0000 (19:38 +0000)]
Encode Executive command arguments using UTF-8 on Cygwin

Cygwin's Python's os.execv doesn't support unicode command arguments.
Cygwin's execv expects arguments to be encoded using the current code
page. But code pages are limited in what characters they can handle,
and our tests include characters that the English code page can't
handle.  So for now we'll just encode everything in UTF-8 on Cygwin,
which can handle all characters but might confuse some commands, for
expediency's sake. I'm sure we'll run into cases where UTF-8 isn't
good enough, but we can deal with that when the problem arises.

Reviewed by Adam Barth.

Fixes <http://webkit.org/b/46892> <rdar://problem/8496639>
webkitpy.common.system.executive_unittest.ExecutiveTest.test_run_command_with_unicode
fails on Windows

* Scripts/webkitpy/common/system/executive.py:
(Executive._run_command_with_teed_output):
(Executive.run_command):
On Cygwin, encode arguments using UTF-8.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNot reviewed. Build fix.
hclam@chromium.org [Fri, 1 Oct 2010 19:25:18 +0000 (19:25 +0000)]
Not reviewed. Build fix.

Adjust test expectations for Chromium.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/7563219> Null dereference when dragging an element with generated...
mitz@apple.com [Fri, 1 Oct 2010 19:16:25 +0000 (19:16 +0000)]
<rdar://problem/7563219> Null dereference when dragging an element with generated content
https://bugs.webkit.org/show_bug.cgi?id=47005

Reviewed by Adele Peterson.

WebCore:

Test: fast/css-generated-content/drag-state.html

* rendering/RenderObject.cpp:
(WebCore::RenderObject::updateDragState): Null-check node().

LayoutTests:

* fast/css-generated-content/drag-state-expected.txt: Added.
* fast/css-generated-content/drag-state.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd simple API tester for WebKit2
weinig@apple.com [Fri, 1 Oct 2010 19:07:40 +0000 (19:07 +0000)]
Add simple API tester for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=46953

Reviewed by Adam Roben.

This adds a very simple testing infrastructure for testing APIs exposed
through the WebKit project. It consists of two parts: 1) a project that
builds the all the tests 2) a script that searches the tests directory and
calls the tester once for each test.

This adds the infrastructure and two tests:
- Tests/WTF/Vector1.cpp - A proof of concept test of WTF data-structures.
- Tests/WebKit2/BasicTest1.cpp - A proof of concept test of WebKit2 API.

This currently only works on the mac, but is designed to be easily ported
to any platform.

* Scripts/run-api-tests: Added.
* Scripts/build-api-tests: Added.
Scripts to build/run the tests.

* TestWebKitAPI: Added.
* TestWebKitAPI/Configurations: Added.
* TestWebKitAPI/Configurations/Base.xcconfig: Added.
* TestWebKitAPI/Configurations/DebugRelease.xcconfig: Added.
* TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig: Added.
* TestWebKitAPI/ForwardingHeaders: Added.
* TestWebKitAPI/ForwardingHeaders/wtf: Added.
* TestWebKitAPI/PlatformUtilities.h: Added.
* TestWebKitAPI/PlatformWebView.h: Added.
(TestWebKitAPI::PlatformWebView::platformView):
* TestWebKitAPI/StringFunctions.h: Added.
* TestWebKitAPI/Test.h: Added.
(TestWebKitAPI::Test::~Test):
(TestWebKitAPI::Test::name):
(TestWebKitAPI::Test::Register::Register):
(TestWebKitAPI::Test::Register::create):
(TestWebKitAPI::Test::Test):
* TestWebKitAPI/TestWebKitAPI.xcodeproj: Added.
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added.
* TestWebKitAPI/TestWebKitAPIPrefix.h: Added.
* TestWebKitAPI/TestsController.cpp: Added.
(TestWebKitAPI::TestsController::shared):
(TestWebKitAPI::TestsController::TestsController):
(TestWebKitAPI::TestsController::runTestNamed):
(TestWebKitAPI::TestsController::testFailed):
(TestWebKitAPI::TestsController::registerCreateTestFunction):
* TestWebKitAPI/TestsController.h: Added.
* TestWebKitAPI/mac: Added.
* TestWebKitAPI/mac/PlatformUtilitiesMac.mm: Added.
(TestWebKitAPI::Util::run):
(TestWebKitAPI::Util::createURLForResource):
* TestWebKitAPI/mac/PlatformWebViewMac.mm: Added.
(TestWebKitAPI::PlatformWebView::PlatformWebView):
(TestWebKitAPI::PlatformWebView::resizeTo):
(TestWebKitAPI::PlatformWebView::~PlatformWebView):
(TestWebKitAPI::PlatformWebView::page):
(TestWebKitAPI::PlatformWebView::focus):
* TestWebKitAPI/mac/main.mm: Added.
Infrastructure.

* TestWebKitAPI/Tests: Added.
* TestWebKitAPI/Tests/WTF: Added.
* TestWebKitAPI/Tests/WTF/Vector1.cpp: Added.
* TestWebKitAPI/Tests/WebKit2: Added.
* TestWebKitAPI/Tests/WebKit2/BasicTest1.cpp: Added.
(TestWebKitAPI::State::State):
* TestWebKitAPI/Tests/WebKit2/basic-1.html: Added.
Proof of concept tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNot reviewed. Build fix.
hclam@chromium.org [Fri, 1 Oct 2010 19:03:38 +0000 (19:03 +0000)]
Not reviewed. Build fix.

Change test expectations for Chromium.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove a test I just fixed from the Skipped file
aroben@apple.com [Fri, 1 Oct 2010 18:58:53 +0000 (18:58 +0000)]
Remove a test I just fixed from the Skipped file

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDon't assume AccessibleObjectFromEvent succeeds
aroben@apple.com [Fri, 1 Oct 2010 18:56:10 +0000 (18:56 +0000)]
Don't assume AccessibleObjectFromEvent succeeds

Fixes <http://webkit.org/b/44136> <rdar://problem/8321684> Crash in
DumpRenderTree!notificationListenerProc when running
plugins/access-after-page-destroyed.html

Reviewed by Sam Weinig.

* DumpRenderTree/win/AccessibilityControllerWin.cpp:
(notificationListenerProc): Check both the return value of
AccessibleObjectFromEvent and the object it returns, as MSDN
recommends.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-01 Robert Hogan <robert@webkit.org>
robert@webkit.org [Fri, 1 Oct 2010 18:40:19 +0000 (18:40 +0000)]
2010-10-01  Robert Hogan  <robert@webkit.org>

        Reviewed by Adam Barth.

        [Qt] Fix http/tests/loading/redirect-methods.html

        https://bugs.webkit.org/show_bug.cgi?id=41571

        Unskip http/tests/loading/redirect-methods.html

        * platform/qt/Skipped:
2010-10-01  Robert Hogan  <robert@webkit.org>

        Reviewed by Adam Barth.

        [Qt] Fix http/tests/loading/redirect-methods.html

        Document our redirection behaviour too.

        https://bugs.webkit.org/show_bug.cgi?id=41571

        * platform/network/qt/QNetworkReplyHandler.cpp:
        (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
        (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
        * platform/network/qt/QNetworkReplyHandler.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCopy forwarding headers and Inspector JS files as part of WebCoreGenerated.vcproj
aroben@apple.com [Fri, 1 Oct 2010 18:31:14 +0000 (18:31 +0000)]
Copy forwarding headers and Inspector JS files as part of WebCoreGenerated.vcproj

WebCoreGenerated.vcproj runs on every build, while WebCore.vcproj only
runs when a .h or .cpp file changes. By moving the copying to
WebCoreGenerated, it will happen even when someone only changes a JS
file (as happened in r68887).

Fixes <http://webkit.org/b/46988> <rdar://problem/8502489> REGRESSION
(r68887): Web Inspector: inspector/extensions*.html are failing on
Windows

Reviewed by Anders Carlsson.

* WebCore.vcproj/WebCore.vcproj: Moved invocation of
copyForwardingHeaders and copyInspectorFiles from here...
* WebCore.vcproj/WebCoreGenerated.vcproj: ...to here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-30 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Fri, 1 Oct 2010 18:25:59 +0000 (18:25 +0000)]
2010-09-30  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        Implement queryCommandState('justifyFull')
        https://bugs.webkit.org/show_bug.cgi?id=46954

        Implemented queryCommandState('justifyFull').
        New tests are added to editing/style/inline-style-container.html

        * editing/ApplyStyleCommand.cpp:
        (WebCore::getTextAlignment): Added support for CSSValueJustify.
        * editing/EditorCommand.cpp:
        (WebCore::stateJustifyFull): Added.
        (WebCore::createCommandMap): Added stateJustifyFull.
2010-09-30  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        Implement queryCommandState('justifyFull')
        https://bugs.webkit.org/show_bug.cgi?id=46954

        Added tests for queryCommandState('justifyFull') to editing/execCommand/query-text-alignment.html

        * editing/execCommand/query-text-alignment-expected.txt:
        * editing/execCommand/script-tests/query-text-alignment.js:
        (queryTextAlignment):
        (runRangeTests):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-01 Gabor Rapcsanyi <rgabor@inf.u-szeged.hu>
ossy@webkit.org [Fri, 1 Oct 2010 18:17:35 +0000 (18:17 +0000)]
2010-10-01  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>

        Reviewed by Tony Chang.

        [NRWT] Put the http and websocket tests first in the test list.
        https://bugs.webkit.org/show_bug.cgi?id=46453

        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-01 Jia Pu <jpu@apple.com>
commit-queue@webkit.org [Fri, 1 Oct 2010 18:11:24 +0000 (18:11 +0000)]
2010-10-01  Jia Pu  <jpu@apple.com>

        Reviewed by Darin Adler.

        Autocorrection shouldn't prompt the same correction after user has edited previous correction.
        https://bugs.webkit.org/show_bug.cgi?id=46839
        <rdar://problem/8476963>

        * editing/Editor.cpp:
        (WebCore::Editor::respondToChangedSelection): Remove "CorrectionIndicator" marker instead of
          "Replacement" marker. Since the former controls whether we draw autocorrection underline,
          and the latter is used to prevent autocorrection from being applied again on already auto-
          corrected word. So the "Replacement" shouldn't be removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-01 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Fri, 1 Oct 2010 18:05:40 +0000 (18:05 +0000)]
2010-10-01  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Anders Carlsson.

        [CMake] Add handling for ENABLE(NETSCAPE_PLUGIN_API)
        https://bugs.webkit.org/show_bug.cgi?id=46309

        * CMakeLists.txt:
        * CMakeListsEfl.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=46996, patch the functions dealing with the...
hyatt@apple.com [Fri, 1 Oct 2010 17:55:12 +0000 (17:55 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=46996, patch the functions dealing with the bottom of the block to
be block-flow-aware.

Reviewed by Darin Adler.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::setCollapsedBottomMargin):
(WebCore::RenderBlock::handleAfterSideOfBlock):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-01 Pratik Solanki <psolanki@apple.com>
commit-queue@webkit.org [Fri, 1 Oct 2010 17:50:39 +0000 (17:50 +0000)]
2010-10-01  Pratik Solanki  <psolanki@apple.com>

        Reviewed by Geoffrey Garen.
        Specify ALWAYS_INLINE at function declaration not function definition
        https://bugs.webkit.org/show_bug.cgi?id=46960

        For functions defined with ALWAYS_INLINE, add the attribute to the declaration as well.

        * bytecompiler/BytecodeGenerator.h:
        * wtf/FastMalloc.cpp:
2010-10-01  Pratik Solanki  <psolanki@apple.com>

        Reviewed by Geoffrey Garen.
        Specify ALWAYS_INLINE at function declaration not function definition
        https://bugs.webkit.org/show_bug.cgi?id=46960

        For functions defined with ALWAYS_INLINE, add the attribute to the declaration as well.

        * css/CSSStyleSelector.h:
        * rendering/InlineIterator.h:
        * rendering/style/RenderStyle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoImplement NPN_GetValueForURL/NPN_SetValueForURL and stub out PluginController functions
andersca@apple.com [Fri, 1 Oct 2010 17:46:27 +0000 (17:46 +0000)]
Implement NPN_GetValueForURL/NPN_SetValueForURL and stub out PluginController functions
https://bugs.webkit.org/show_bug.cgi?id=46992

Reviewed by Dan Bernstein.

* WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::copyCString):
Helper function for allocating a string using NPN_MemAlloc.

(WebKit::NPN_GetValueForURL):
Ask the plug-in for either the proxy or the cookies given an URL.

(WebKit::NPN_SetValueForURL):
* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
Tell the plug-in to set the cookies for the given URL.

(WebKit::NetscapePlugin::proxiesForURL):
(WebKit::NetscapePlugin::cookiesForURL):
(WebKit::NetscapePlugin::setCookiesForURL):
Call the corresponding PluginController functions.

* WebProcess/Plugins/PluginController.h:
Add new pure virtual member functions.

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::proxiesForURL):
(WebKit::PluginView::cookiesForURL):
(WebKit::PluginView::setCookiesForURL):
Add stubbed out implementations of the new PluginController functions.

* WebProcess/Plugins/PluginView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=46995, make direction propagate up to the...
hyatt@apple.com [Fri, 1 Oct 2010 17:43:59 +0000 (17:43 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=46995, make direction propagate up to the viewport from the root element.

Reviewed by Dan Bernstein.

WebCore:

Added fast/css/rtl-to-viewport.html

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::styleForDocument):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::styleDidChange):

LayoutTests:

* fast/css/rtl-to-viewport.html: Added.
* platform/mac/fast/css/rtl-to-viewport-expected.checksum: Added.
* platform/mac/fast/css/rtl-to-viewport-expected.png: Added.
* platform/mac/fast/css/rtl-to-viewport-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Anders Carlsson.
ap@apple.com [Fri, 1 Oct 2010 17:29:18 +0000 (17:29 +0000)]
    Reviewed by Anders Carlsson.

        https://bugs.webkit.org/show_bug.cgi?id=44406
        <rdar://problem/8310921> Application Cache crash when a fallback document has a manifest URL

        Test: http/tests/appcache/foreign-fallback.html

        * loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::selectCache):
        Changed ApplicationCacheResource lookup to find fallback resources correctly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, Brew MP build fix.
kseo@webkit.org [Fri, 1 Oct 2010 17:20:27 +0000 (17:20 +0000)]
Unreviewed, Brew MP build fix.

* platform/brew/ClipboardBrew.cpp:
(WebCore::ClipboardBrew::ClipboardBrew):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdated stuff.
fsamuel@chromium.org [Fri, 1 Oct 2010 17:01:16 +0000 (17:01 +0000)]
Updated stuff.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed.
kseo@webkit.org [Fri, 1 Oct 2010 16:54:59 +0000 (16:54 +0000)]
Unreviewed.

[BREWMP] Change Collector BLOCK_SIZE to 64KB
https://bugs.webkit.org/show_bug.cgi?id=46436

Lower BLOCK_SIZE to 64KB because Brew MP runs on low end devices.

* runtime/Collector.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-01 Rafael Antognolli <antognolli@profusion.mobi>
commit-queue@webkit.org [Fri, 1 Oct 2010 16:32:27 +0000 (16:32 +0000)]
2010-10-01  Rafael Antognolli  <antognolli@profusion.mobi>

        Unreviewed build fix.

        [CMAKE] Build fix for r68878
        https://bugs.webkit.org/show_bug.cgi?id=46985

        Fix name of files added to CMakeLists.txt:
        SVGTextLayoutBaseline.cpp -> SVGTextLayoutEngineBaseline.cpp
        SVGTextLayoutSpacing.cpp -> SVGTextLayoutEngineSpacing.cpp

        No features added, so no new tests.

        * CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoImplement NPN_GetValue(NPNVnetscapeWindow)
aroben@apple.com [Fri, 1 Oct 2010 16:16:03 +0000 (16:16 +0000)]
Implement NPN_GetValue(NPNVnetscapeWindow)

Fixes <http://webkit.org/b/46726> <rdar://problem/8486319>
Right-clicking on windowless Flash plugin in WebKit2 makes a context
menu appear in the bottom-right corner of the screen

Test: platform/win/plugins/get-value-netscape-window.html

Reviewed by Anders Carlsson.

WebKit2:

* WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::NPN_GetValue): Added case for NPNVnetscapeWindow that calls
through to NetscapePlugin::containingWindow.

* WebProcess/Plugins/Netscape/NetscapePlugin.h: Added containingWindow
on Windows.

* WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
(WebKit::NetscapePlugin::containingWindow): Added. Calls through to
the PluginController.
(WebKit::NetscapePlugin::platformPostInitialize): Changed to use
containingWindow.

WebKitTools:

Test NPN_GetValue(NPNVnetscapeWindow)

* DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
(PluginTest::NPN_GetValue): Added. Calls through to the browser.

* DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added NPN_GetValue.

* DumpRenderTree/TestNetscapePlugIn/Tests/win/GetValueNetscapeWindow.cpp: Added.
(GetValueNetscapeWindow::GetValueNetscapeWindow): Initialize members.
(GetValueNetscapeWindow::NPP_SetWindow): Test that
NPN_GetValue(NPNVnetscapeWindow) returns a valid HWND and that it
isn't our HWND.

* DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
Added GetValueNetscapeWindow.

LayoutTests:

Support for testing NPN_GetValue(NPNVnetscapeWindow)

* platform/win/plugins/get-value-netscape-window-expected.txt: Added.
* platform/win/plugins/get-value-netscape-window.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-01 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
commit-queue@webkit.org [Fri, 1 Oct 2010 14:56:18 +0000 (14:56 +0000)]
2010-10-01  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] Stack overflow on symbian platform.
        https://bugs.webkit.org/show_bug.cgi?id=40598

        Move big allocation in arrayProtoFuncToString from stack to heap.
        JSC::arrayProtoFuncToString function can be called recursivly and
        1K allocation on stack cahse stack overflow.
        Can be useful for other platforms with limited stack size.

        * runtime/ArrayPrototype.cpp:
        (JSC::arrayProtoFuncToString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-01 Ragner Magalhaes <ragner.magalhaes@openbossa.org>
andreas.kling@nokia.com [Fri, 1 Oct 2010 13:52:33 +0000 (13:52 +0000)]
2010-10-01  Ragner Magalhaes  <ragner.magalhaes@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] New buttons style for Qt Mobile theme
        https://bugs.webkit.org/show_bug.cgi?id=46920

        Rename Maemo5Webstyle to QtMobileWebStyle since it implements the style for all Qt mobile platform.
        Adjust new Qt mobile style for buttons, radios, checks and combos.

        * WebCore.pro:
        * css/themeQtMobile.css: Adjust gradient color for buttons and combos.
        (select):
        (select:active):
        * platform/qt/QtMobileWebStyle.cpp: Renamed from platform/qt/Maemo5Webstyle.cpp to match name scheme.
        (QtMobileWebStyle::QtMobileWebStyle):
        (drawRectangularControlBackground):
        (QtMobileWebStyle::drawChecker):
        (QtMobileWebStyle::findChecker):
        (QtMobileWebStyle::drawRadio): Adjust gradient color for RadioButton.
        (QtMobileWebStyle::findRadio):
        (QtMobileWebStyle::drawControl): Adjust gradient color for CheckBox.
        (QtMobileWebStyle::drawMultipleComboButton):
        (QtMobileWebStyle::drawSimpleComboButton): Adjust ComboBox arrow.
        (QtMobileWebStyle::getButtonImageSize):
        (QtMobileWebStyle::findComboButton):
        (QtMobileWebStyle::drawComplexControl):
        * platform/qt/QtMobileWebStyle.h: Renamed from platform/qt/Maemo5Webstyle.h to match name scheme.
        * platform/qt/RenderThemeQt.cpp:
        (WebCore::RenderThemeQt::RenderThemeQt):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd expected Windows results for scrollbars/custom-scrollbar-with-incomplete-style...
aroben@apple.com [Fri, 1 Oct 2010 13:49:59 +0000 (13:49 +0000)]
Add expected Windows results for scrollbars/custom-scrollbar-with-incomplete-style.html

This test was added in r66372 without any expected results.

* platform/win/scrollbars/custom-scrollbar-with-incomplete-style-expected.checksum: Added.
* platform/win/scrollbars/custom-scrollbar-with-incomplete-style-expected.png: Added.
* platform/win/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-01 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Fri, 1 Oct 2010 13:43:02 +0000 (13:43 +0000)]
2010-10-01  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Extensions API] expose page load events timings
        Added webInspector.resources.getPageTimings()
        https://bugs.webkit.org/show_bug.cgi?id=45954

        * inspector/front-end/ExtensionAPI.js:
        (WebInspector.injectedExtensionAPI.Resources.prototype):
        (WebInspector.injectedExtensionAPI.Resources.prototype.getPageTimings):
        * inspector/front-end/ExtensionServer.js:
        (WebInspector.ExtensionServer):
        (WebInspector.ExtensionServer.prototype._onGetPageTimings):
        * inspector/front-end/HAREntry.js: Return page event timings as -1 if start or event time unknown.
        (WebInspector.HARLog.prototype._buildPages):
        (WebInspector.HARLog.prototype.buildMainResourceTimings):
        (WebInspector.HARLog.prototype._convertResource):
        (WebInspector.HARLog.prototype._pageEventTime):

2010-10-01  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Extensions API] expose page load events timings
        Added webInspector.resources.getPageTimings()
        https://bugs.webkit.org/show_bug.cgi?id=45954

        * inspector/extensions-api-expected.txt:
        * inspector/extensions-resources-expected.txt:
        * inspector/extensions-resources.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove the fixed test from the Skipped file, too
aroben@apple.com [Fri, 1 Oct 2010 13:37:38 +0000 (13:37 +0000)]
Remove the fixed test from the Skipped file, too

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove bogus Windows results for clip-path-referencing-use2.svg
aroben@apple.com [Fri, 1 Oct 2010 13:35:19 +0000 (13:35 +0000)]
Remove bogus Windows results for clip-path-referencing-use2.svg

Fixes <http://webkit.org/b/46919> <rdar://problem/8497626> REGRESSION?
(r65617?): svg/custom/clip-path-referencing-use2.svg fails on Windows

Rubber-stamped by Nikolas Zimmermann.

* platform/win/svg/custom/clip-path-referencing-use2-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake regression tests pass on machines with 16-bit displays
aroben@apple.com [Fri, 1 Oct 2010 13:30:29 +0000 (13:30 +0000)]
Make regression tests pass on machines with 16-bit displays

I made these tests require 24-bit displays in r68808 and r68809,
thinking that we didn't have any testers that had 16-bit displays. But
apparently I was wrong; at least one Windows tester has a 16-bit
display.

Fixes <http://webkit.org/b/46980>
fast/media/color-does-not-include-alpha.html failing on Windows

Reviewed by Nikolas Zimmermann.

* fast/dom/Window/window-screen-properties-expected.txt: Updated
results.
* fast/dom/Window/window-screen-properties.html: Changed to allow
either 16 or 24 bits.
* fast/media/color-does-not-include-alpha.html: Changed to allow
either 5 or 8 bits per channel.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-01 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Fri, 1 Oct 2010 13:09:56 +0000 (13:09 +0000)]
2010-10-01  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Adam Roben.

        [WIN] Add GDIExtras
        https://bugs.webkit.org/show_bug.cgi?id=46974

        Some, but not all WinCE environments have support for AlphaBlend().
        Add this files to check for AlphaBlend (and SoftLink) on WinCE.
        On WinNT alphaBlendIfSupported() inlines AlphaBlend and returns true.

        * platform/graphics/win/GDIExtras.cpp: Added.
        (WebCore::AlphaBlendPointer):
        * platform/graphics/win/GDIExtras.h: Added.
        (WebCore::hasAlphaBlendSupport):
        (WebCore::alphaBlendIfSupported):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-01 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Fri, 1 Oct 2010 13:04:42 +0000 (13:04 +0000)]
2010-10-01  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Adam Roben.

        [WINCE] Use alphaBlendIfSupported in GraphicsContext
        https://bugs.webkit.org/show_bug.cgi?id=46979

        * platform/graphics/wince/GraphicsContextWinCE.cpp:
        (WebCore::GraphicsContextPlatformPrivate::paintBackTransparentLayerBitmap):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed rolling out r68633, because we don't need Qt specific expected results...
ossy@webkit.org [Fri, 1 Oct 2010 12:58:49 +0000 (12:58 +0000)]
Unreviewed rolling out r68633, because we don't need Qt specific expected results any more.

* platform/qt/canvas: Removed.
* platform/qt/canvas/philip: Removed.
* platform/qt/canvas/philip/tests: Removed.
* platform/qt/canvas/philip/tests/2d.gradient.radial.cone.front-expected.txt: Removed.
* platform/qt/canvas/philip/tests/2d.gradient.radial.inside2-expected.txt: Removed.
* platform/qt/canvas/philip/tests/2d.gradient.radial.inside3-expected.txt: Removed.
* platform/qt/canvas/philip/tests/2d.gradient.radial.outside1-expected.txt: Removed.
* platform/qt/canvas/philip/tests/2d.line.cap.closed-expected.txt: Removed.
* platform/qt/canvas/philip/tests/2d.line.join.parallel-expected.txt: Removed.
* platform/qt/canvas/philip/tests/2d.shadow.enable.blur-expected.txt: Removed.
* platform/qt/canvas/philip/tests/2d.shadow.enable.x-expected.txt: Removed.
* platform/qt/canvas/philip/tests/2d.shadow.enable.y-expected.txt: Removed.
* platform/qt/canvas/philip/tests/2d.shadow.gradient.alpha-expected.txt: Removed.
* platform/qt/canvas/philip/tests/2d.shadow.gradient.basic-expected.txt: Removed.
* platform/qt/canvas/philip/tests/2d.shadow.gradient.transparent.2-expected.txt: Removed.
* platform/qt/canvas/philip/tests/2d.strokeRect.zero.4-expected.txt: Removed.
* platform/qt/canvas/philip/tests/toDataURL.jpeg.alpha-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-01 Andreas Kling <andreas.kling@nokia.com>
andreas.kling@nokia.com [Fri, 1 Oct 2010 12:24:51 +0000 (12:24 +0000)]
2010-10-01  Andreas Kling  <andreas.kling@nokia.com>

        Unreviewed, adding my webkit.org identity to reviewer list.

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd some more failing tests to the Windows Skipped file
aroben@apple.com [Fri, 1 Oct 2010 12:03:13 +0000 (12:03 +0000)]
Add some more failing tests to the Windows Skipped file

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-01 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Fri, 1 Oct 2010 11:38:11 +0000 (11:38 +0000)]
2010-10-01  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        Add two new helper files for the new SVGTextLayoutEngine
        https://bugs.webkit.org/show_bug.cgi?id=46972

        Refactor code from SVGTextLayoutUtilities into two seperated classes.
        SVGTextLayoutUtilities will be removed, as soon as the main clss SVGTextLayoutEngine lands and gets used.

        Doesn't affect any functionality yet, as the new classes are not used so far.

        * Android.mk:
        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * rendering/svg/SVGTextFragment.h:
        * rendering/svg/SVGTextLayoutEngineBaseline.cpp: Added.
        (WebCore::SVGTextLayoutEngineBaseline::SVGTextLayoutEngineBaseline):
        (WebCore::SVGTextLayoutEngineBaseline::calculateBaselineShift):
        (WebCore::SVGTextLayoutEngineBaseline::dominantBaselineToAlignmentBaseline):
        (WebCore::SVGTextLayoutEngineBaseline::calculateAlignmentBaselineShift):
        (WebCore::SVGTextLayoutEngineBaseline::calculateGlyphOrientationAngle):
        (WebCore::glyphOrientationIsMultiplyOf180Degrees):
        (WebCore::SVGTextLayoutEngineBaseline::calculateGlyphAdvanceAndOrientation):
        * rendering/svg/SVGTextLayoutEngineBaseline.h: Added.
        * rendering/svg/SVGTextLayoutEngineSpacing.cpp: Added.
        (WebCore::SVGTextLayoutEngineSpacing::SVGTextLayoutEngineSpacing):
        (WebCore::SVGTextLayoutEngineSpacing::calculateSVGKerning):
        (WebCore::SVGTextLayoutEngineSpacing::calculateCSSKerningAndSpacing):
        * rendering/svg/SVGTextLayoutEngineSpacing.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-01 MORITA Hajime <morrita@google.com>
morrita@google.com [Fri, 1 Oct 2010 10:50:53 +0000 (10:50 +0000)]
2010-10-01  MORITA Hajime  <morrita@google.com>

        Unreviewed, added a expectation.

        * platform/chromium-mac/fast/repaint/canvas-putImageData-expected.checksum: Added.
        * platform/chromium-mac/fast/repaint/canvas-putImageData-expected.png: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-01 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Fri, 1 Oct 2010 10:45:15 +0000 (10:45 +0000)]
2010-10-01  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Andreas Kling.

        Rename SVGTextLayoutBuilder to SVGTextLayoutAttributesBuilder
        https://bugs.webkit.org/show_bug.cgi?id=46971

        Doesn't affect any functionality, just moves files around.

        * Android.mk:
        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * rendering/svg/RenderSVGText.cpp:
        (WebCore::RenderSVGText::layout): Adopt to renaming.
        * rendering/svg/SVGTextLayoutAttributesBuilder.cpp: Copied from rendering/svg/SVGTextLayoutBuilder.cpp.
        * rendering/svg/SVGTextLayoutAttributesBuilder.h: Copied from rendering/svg/SVGTextLayoutBuilder.h.
        * rendering/svg/SVGTextLayoutBuilder.cpp: Removed.
        * rendering/svg/SVGTextLayoutBuilder.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-01 MORITA Hajime <morrita@google.com>
morrita@google.com [Fri, 1 Oct 2010 10:41:28 +0000 (10:41 +0000)]
2010-10-01  MORITA Hajime  <morrita@google.com>

        Unreviewed build fix.

        * platform/graphics/skia/PlatformContextSkia.cpp:
        (WebCore::PlatformContextSkia::PlatformContextSkia):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-01 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Fri, 1 Oct 2010 10:19:45 +0000 (10:19 +0000)]
2010-10-01  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Andreas Kling.

        Move SVG text related renderers into rendering/svg/
        https://bugs.webkit.org/show_bug.cgi?id=46969

        Doesn't affect any functionality, just moves files around.

        * Android.mk:
        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * rendering/RenderSVGAllInOne.cpp:
        * rendering/RenderSVGInline.cpp: Removed.
        * rendering/RenderSVGInline.h: Removed.
        * rendering/RenderSVGInlineText.cpp: Removed.
        * rendering/RenderSVGInlineText.h: Removed.
        * rendering/RenderSVGTSpan.cpp: Removed.
        * rendering/RenderSVGTSpan.h: Removed.
        * rendering/RenderSVGText.cpp: Removed.
        * rendering/RenderSVGText.h: Removed.
        * rendering/RenderSVGTextPath.cpp: Removed.
        * rendering/RenderSVGTextPath.h: Removed.
        * rendering/SVGInlineFlowBox.cpp: Removed.
        * rendering/SVGInlineFlowBox.h: Removed.
        * rendering/SVGInlineTextBox.cpp: Removed.
        * rendering/SVGInlineTextBox.h: Removed.
        * rendering/SVGRootInlineBox.cpp: Removed.
        * rendering/SVGRootInlineBox.h: Removed.
        * rendering/SVGTextQuery.cpp: Removed.
        * rendering/SVGTextQuery.h: Removed.
        * rendering/svg/RenderSVGInline.cpp: Copied from rendering/RenderSVGInline.cpp.
        * rendering/svg/RenderSVGInline.h: Copied from rendering/RenderSVGInline.h.
        * rendering/svg/RenderSVGInlineText.cpp: Copied from rendering/RenderSVGInlineText.cpp.
        * rendering/svg/RenderSVGInlineText.h: Copied from rendering/RenderSVGInlineText.h.
        * rendering/svg/RenderSVGTSpan.cpp: Copied from rendering/RenderSVGTSpan.cpp.
        * rendering/svg/RenderSVGTSpan.h: Copied from rendering/RenderSVGTSpan.h.
        * rendering/svg/RenderSVGText.cpp: Copied from rendering/RenderSVGText.cpp.
        * rendering/svg/RenderSVGText.h: Copied from rendering/RenderSVGText.h.
        * rendering/svg/RenderSVGTextPath.cpp: Copied from rendering/RenderSVGTextPath.cpp.
        * rendering/svg/RenderSVGTextPath.h: Copied from rendering/RenderSVGTextPath.h.
        * rendering/svg/SVGInlineFlowBox.cpp: Copied from rendering/SVGInlineFlowBox.cpp.
        * rendering/svg/SVGInlineFlowBox.h: Copied from rendering/SVGInlineFlowBox.h.
        * rendering/svg/SVGInlineTextBox.cpp: Copied from rendering/SVGInlineTextBox.cpp.
        * rendering/svg/SVGInlineTextBox.h: Copied from rendering/SVGInlineTextBox.h.
        * rendering/svg/SVGRootInlineBox.cpp: Copied from rendering/SVGRootInlineBox.cpp.
        * rendering/svg/SVGRootInlineBox.h: Copied from rendering/SVGRootInlineBox.h.
        * rendering/svg/SVGTextQuery.cpp: Copied from rendering/SVGTextQuery.cpp.
        * rendering/svg/SVGTextQuery.h: Copied from rendering/SVGTextQuery.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-01 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Fri, 1 Oct 2010 09:11:21 +0000 (09:11 +0000)]
2010-10-01  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        Add SVGTextMetrics/SVGTextFragment/SVGTextChunk primitives used by the new layout engine
        https://bugs.webkit.org/show_bug.cgi?id=46964

        The new SVG text layout engine will use these new classes.
        1) SVGTextMetrics is used to measure either single glyphs (which may span multiple characters, when ligatures are defined) or a range of characters.

           -> In "single glyph" mode, it returns the width/height of the glyph, the length of the glyph (> 1, when ligatures are used) and a "Glyph" object
              describing the glyph (name of glyph, when used together with SVG Fonts and the unicode string the glyph describes).
           -> In "range of characters" mode, it returns the width/height of the range, and its length.

           All measurements are done using the regular Font::floatWidth() methods, this class just encapsulates its usage for the SVG text layout engine.

        2) SVGTextFragment describes a fragment of text, living in a SVGInlineTextBox, which can be measured/rendered in one shot.
           It contains all necessary information to render the fragment (x/y/width/height, offset into characters() buffer for the first char of the fragment,
           length, and an arbitary transformation, holding information about rotations/scale/glyph-orientation etc.)

           In future the SVGTextLayoutEngine will generate SVGTextFragment objects for each SVGInlineTextBox. When painting no more measurements have to
           be performed as SVGTextFragment contains all necessary information to render text / select text etc.

        3) SVGTextChunk describes a SVG text chunk, which may span multiple text boxes (and in turn text fragments).

           Quotes from SVG spec:
           Each absolute position adjustment defines a new "text chunk". Absolute position adjustments impact text layout in the following ways:
            * Ligatures only occur when a set of characters which might map to a ligature are all in the same text chunk.
            * Each text chunk represents a separate block of text for alignment due to "text-anchor" property values.
            * Reordering of characters due to bidirectionality only occurs within a text chunk. Reordering does not happen across text chunks.

            An absolute position adjustment occurs in the following circumstances:
            * At the start of a <text> element
            * At the start of each <textPath> element
            * For each character within a <text>, <tspan>, <tref> and <altGlyph> element which has an "x" or "y" attribute value assigned to it explicitly

            After the line-layout finishes, each "text chunk" is altered according to the textLength and text-anchor processing rules
            (eg. for text-anchor="middle" moving the whole text chunk by -fragmentWidth/2, for horizontal text).

            SVGTextChunk is just a simple helper class, that encapsulates measuring/altering a text chunk.

        Doesn't affect any tests, as these classes aren't used so far.

        * Android.mk: Add SVGTextMetrics.*, SVGTextFragment.h, SVGTextChunk.* to build.
        * CMakeLists.txt: Ditto.
        * GNUmakefile.am: Ditto.
        * WebCore.gypi: Ditto.
        * WebCore.pro: Ditto.
        * WebCore.vcproj/WebCore.vcproj: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * rendering/svg/SVGTextChunk.cpp: Added.
        * rendering/svg/SVGTextChunk.h: Added.
        * rendering/svg/SVGTextFragment.h: Added.
        * rendering/svg/SVGTextMetrics.cpp: Added.
        * rendering/svg/SVGTextMetrics.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed.
ossy@webkit.org [Fri, 1 Oct 2010 08:21:08 +0000 (08:21 +0000)]
Unreviewed.

[Qt] fast/media/color-does-not-include-alpha.html fails
https://bugs.webkit.org/show_bug.cgi?id=46966

* platform/qt/Skipped: fast/media/color-does-not-include-alpha.html added until fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-01 Jochen Eisinger <jochen@chromium.org>
jochen@chromium.org [Fri, 1 Oct 2010 08:06:10 +0000 (08:06 +0000)]
2010-10-01  Jochen Eisinger  <jochen@chromium.org>

        Reviewed by Darin Fisher.

        [chromium] add an identifier method to WebFrame. The identifier can be used to identify
        a given frame of a view over time. Using a pointer to the WebFrame object is fragile,
        since a new frame might have been allocated at the same address as an old, deleted frame.
        https://bugs.webkit.org/show_bug.cgi?id=46884

        * public/WebFrame.h:
        * src/WebFrameImpl.cpp:
        (WebKit::generateFrameIdentifier):
        (WebKit::WebFrameImpl::identifier):
        (WebKit::WebFrameImpl::WebFrameImpl):
        * src/WebFrameImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-01 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 1 Oct 2010 07:52:36 +0000 (07:52 +0000)]
2010-10-01  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        http/tests/navigation/ping-same-origin.html is flaky
        https://bugs.webkit.org/show_bug.cgi?id=46961

        This test fails by forgetting to print out the REQUEST_METHOD:

        http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r68727%20(18470)/http/tests/navigation/ping-same-origin-pretty-diff.html

        The only way this makes sense is if the file isn't finished writing by
        the time it gets read.  This can happen because the reader is polling
        the file for existence (!) to decide whether to read it.

        This patch writes to a temporary location and then moves the finished
        bytes into the well-known location atomically.  I haven't verified that
        it fixes the flakiness, but it seems like a good bet.

        * http/tests/navigation/resources/save-ping.php:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-29 John Abd-El-Malek <jam@chromium.org>
jam@chromium.org [Fri, 1 Oct 2010 07:32:27 +0000 (07:32 +0000)]
2010-09-29  John Abd-El-Malek  <jam@chromium.org>

        Reviewed by NOBODY (OOPS!).

        [chromium] Changes to consolidate plugin zoom
        https://bugs.webkit.org/show_bug.cgi?id=46550

        * public/WebPlugin.h:
        (WebKit::WebPlugin::setZoomLevel):
        * public/WebPluginContainer.h:
        * public/WebView.h:
        * public/WebViewClient.h:
        (WebKit::WebViewClient::zoomLimitsChanged):
        (WebKit::WebViewClient::zoomLevelChanged):
        * src/FrameLoaderClientImpl.cpp:
        (WebKit::FrameLoaderClientImpl::createPlugin):
        * src/WebPluginContainerImpl.cpp:
        (WebKit::WebPluginContainerImpl::loadFrameRequest):
        (WebKit::WebPluginContainerImpl::zoomChanged):
        (WebKit::WebPluginContainerImpl::zoomLimitsChanged):
        * src/WebPluginContainerImpl.h:
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::WebViewImpl):
        (WebKit::WebViewImpl::zoomLevel):
        (WebKit::WebViewImpl::setZoomLevel):
        (WebKit::WebViewImpl::zoomLimitsChanged):
        (WebKit::WebViewImpl::fullFramePluginZoomLevelChanged):
        (WebKit::WebView::zoomLevelToZoomFactor):
        (WebKit::WebView::zoomFactorToZoomLevel):
        * src/WebViewImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-01 Vincent Scheib <scheib@chromium.org>
commit-queue@webkit.org [Fri, 1 Oct 2010 07:28:59 +0000 (07:28 +0000)]
2010-10-01  Vincent Scheib  <scheib@chromium.org>

        Reviewed by James Robinson.

        REGRESSION: Lots of fast canvas updates fail to completely render
        https://bugs.webkit.org/show_bug.cgi?id=46319

        * fast/repaint/canvas-putImageData-expected.txt: Added.
        * fast/repaint/canvas-putImageData.html: Added.
        * platform/chromium-win/fast/repaint/canvas-putImageData-expected.checksum: Added.
        * platform/chromium-win/fast/repaint/canvas-putImageData-expected.png: Added.
        * platform/chromium/test_expectations.txt:
2010-10-01  Vincent Scheib  <scheib@chromium.org>

        Reviewed by James Robinson.

        REGRESSION: Lots of fast canvas updates fail to completely render
        https://bugs.webkit.org/show_bug.cgi?id=46319

        Test: fast/repaint/canvas-putImageData.html

        * html/canvas/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::putImageData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-01 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Fri, 1 Oct 2010 07:16:23 +0000 (07:16 +0000)]
2010-10-01  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        Add helper methods to cast between renderers & SVGTextContent/PositioningElement
        https://bugs.webkit.org/show_bug.cgi?id=46963

        Doesn't affect any tests.

        * svg/SVGTextContentElement.cpp:
        (WebCore::SVGTextContentElement::elementFromRenderer):
        * svg/SVGTextContentElement.h:
        * svg/SVGTextPositioningElement.cpp:
        (WebCore::SVGTextPositioningElement::elementFromRenderer):
        * svg/SVGTextPositioningElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-30 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 1 Oct 2010 06:41:17 +0000 (06:41 +0000)]
2010-09-30  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        The WebSocket server should flush its logs
        https://bugs.webkit.org/show_bug.cgi?id=46946

        The WebSocket server logs are truncated because the driver just
        terminates the child.  It should run Python without buffering so we can
        see the end of the log.

        * Scripts/webkitpy/layout_tests/port/websocket_server.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-30 MORITA Hajime <morrita@google.com>
morrita@google.com [Fri, 1 Oct 2010 05:58:36 +0000 (05:58 +0000)]
2010-09-30  MORITA Hajime  <morrita@google.com>

        Reviewed by James Robinson.

        [Chromium] build fails unless ACCELERATED_2D_CANVAS defined
        https://bugs.webkit.org/show_bug.cgi?id=46955

        Added ifdef guard around SharedGraphicsContext3D.

        No new tests. just a build fix.

        * platform/graphics/skia/PlatformContextSkia.cpp:
        (WebCore::PlatformContextSkia::~PlatformContextSkia):
        (WebCore::PlatformContextSkia::setSharedGraphicsContext3D):
        (WebCore::PlatformContextSkia::uploadSoftwareToHardware):
        (WebCore::PlatformContextSkia::readbackHardwareToSoftware):
        * platform/graphics/skia/PlatformContextSkia.h:
        (WebCore::PlatformContextSkia::gpuCanvas):
2010-09-30  MORITA Hajime  <morrita@google.com>

        Reviewed by James Robinson.

        [Chromium] build fails unless ACCELERATED_2D_CANVAS defined
        https://bugs.webkit.org/show_bug.cgi?id=46955

        Added ifdef guard around SharedGraphicsContext3D.

        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::getSharedGraphicsContext3D):
        * src/WebViewImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-30 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Fri, 1 Oct 2010 05:09:08 +0000 (05:09 +0000)]
2010-09-30  Kent Tamura  <tkent@chromium.org>

        Reviewed by Chris Fleizach.

        [Windows] Implement <input type=number> UI
        https://bugs.webkit.org/show_bug.cgi?id=38381

        Implement theme drawing for inner-spin-button.
        No new tests. Existing tests for type=number will cover this change.

        * rendering/RenderThemeWin.cpp:
        (WebCore::RenderThemeWin::RenderThemeWin):
         Handle m_spinButtonTheme.
        (WebCore::RenderThemeWin::spinButtonTheme): ditto.
        (WebCore::RenderThemeWin::close): ditto.
        (WebCore::RenderThemeWin::determineClassicState):
         Add ControlSubPart parameter, and add support for InnerSpinButtonPart.
        (WebCore::RenderThemeWin::determineSpinButtonState): Added.
        (WebCore::RenderThemeWin::getClassicThemeData):
         Add ControlSubPart parameter, and handle InnerSpinButtonPart.
        (WebCore::RenderThemeWin::getThemeData): ditto.
        (WebCore::RenderThemeWin::adjustInnerSpinButtonStyle):
         Set SM_CXVSCROLL value to the width.
        (WebCore::RenderThemeWin::paintInnerSpinButton):
         Call drawControl() for the upper part and the lower part.
        * rendering/RenderThemeWin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-30 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Fri, 1 Oct 2010 05:05:14 +0000 (05:05 +0000)]
2010-09-30  Kent Tamura  <tkent@chromium.org>

        Unreviewed, test expectation update.

        * platform/chromium/drt_expectations.txt: Add recent failures.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, Windows build fix for r68854
tkent@chromium.org [Fri, 1 Oct 2010 04:51:53 +0000 (04:51 +0000)]
Unreviewed, Windows build fix for r68854

* WebCore.vcproj/copyForwardingHeaders.cmd:
  Copy WebCore/html/parser/*.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-30 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 1 Oct 2010 03:55:48 +0000 (03:55 +0000)]
2010-09-30  Simon Fraser  <simon.fraser@apple.com>

        Add a button to jump to the next untested test.

        * CSSTestSuiteHarness/harness/harness.css:
        (.test-type):
        (.name > button):
        * CSSTestSuiteHarness/harness/harness.html:
        * CSSTestSuiteHarness/harness/harness.js:
        (Chapter.prototype.description):
        (Chapter.prototype.untestedCount):
        (TestSuite.prototype.testInfoDataLoaded):
        (TestSuite.prototype.fillChapterPopup):
        (TestSuite.prototype.updateChapterPopup):
        (TestSuite.prototype.buildTestListForChapter):
        (TestSuite.prototype.goToNextIncompleteTest):
        (TestSuite.prototype.firstIncompleteTestIndex):
        (TestSuite.prototype.testCompletionStateChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-30 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Fri, 1 Oct 2010 03:25:11 +0000 (03:25 +0000)]
2010-09-30  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Dan Bernstein.

        While updating :before and :after content, make sure that the generated
        container is allowed to add the child type.
        https://bugs.webkit.org/show_bug.cgi?id=46106

        Test: fast/css-generated-content/text-before-table-col-crash.html

        * rendering/RenderObjectChildList.cpp:
        (WebCore::RenderObjectChildList::updateBeforeAfterContent):
2010-09-30  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Dan Bernstein.

        Tests that adding text to a :before container that is styled as a
        table column group does not result in crash.
        https://bugs.webkit.org/show_bug.cgi?id=46106

        * fast/css-generated-content/text-before-table-col-crash-expected.txt: Added.
        * fast/css-generated-content/text-before-table-col-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNot reviewed. Build fix.
hclam@chromium.org [Fri, 1 Oct 2010 01:35:20 +0000 (01:35 +0000)]
Not reviewed. Build fix.

Adjust test expectations for Chromium.

* platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-expected.txt: Added.
* platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-getAttribute-value-expected.txt: Added.
* platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-htmldom-expected.txt: Added.
* platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttribute-expected.txt: Added.
* platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNS-expected.txt: Added.
* platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNode-expected.txt: Added.
* platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNodeNS-expected.txt: Added.
* platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-getAttribute-value-expected.txt: Added.
* platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-htmldom-expected.txt: Added.
* platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute-expected.txt: Added.
* platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNS-expected.txt: Added.
* platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNode-expected.txt: Added.
* platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNodeNS-expected.txt: Added.
* platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-expected.txt: Added.
* platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-getAttribute-value-expected.txt: Added.
* platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-htmldom-expected.txt: Added.
* platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttribute-expected.txt: Added.
* platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNS-expected.txt: Added.
* platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNode-expected.txt: Added.
* platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNodeNS-expected.txt: Added.
* platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-getAttribute-value-expected.txt: Added.
* platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-htmldom-expected.txt: Added.
* platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute-expected.txt: Added.
* platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNS-expected.txt: Added.
* platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNode-expected.txt: Added.
* platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNodeNS-expected.txt: Added.
* platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-expected.txt: Added.
* platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-getAttribute-value-expected.txt: Added.
* platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-htmldom-expected.txt: Added.
* platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttribute-expected.txt: Added.
* platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNS-expected.txt: Added.
* platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNode-expected.txt: Added.
* platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNodeNS-expected.txt: Added.
* platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-getAttribute-value-expected.txt: Added.
* platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-htmldom-expected.txt: Added.
* platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute-expected.txt: Added.
* platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNS-expected.txt: Added.
* platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNode-expected.txt: Added.
* platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNodeNS-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-30 Mario Sanchez Prada <msanchez@igalia.com>
commit-queue@webkit.org [Fri, 1 Oct 2010 01:24:15 +0000 (01:24 +0000)]
2010-09-30  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Daniel Bates.

        [GTK] Crash on testatk.c unittest because of a call to ASSERT_NOT_REACHED
        https://bugs.webkit.org/show_bug.cgi?id=46886

        Removed call to ASSERT_NOT_REACHED() from listMarkerSuffix().

        So far, this assertion made sense because it was not possible that
        a call to listMarkerSuffix() happened when the style of the list
        item was one of the following: Asterisks, Circle, Discm Footnotes,
        NoneListStyle or Square (it's easy to figure this out by checking
        the functions where listMarkerSuffix() was called).

        However, since revision 68415 (about bug 45381), there's a new
        place where listMarkerSuffix() is being called (the suffix()
        public method), regardless of the style of the item being or not
        one of those pointed out, so the aforementioned assertion in
        listMarkerSuffix() would no longer be correct, as now it's ok to
        reach those cases in the switch statement.

        * rendering/RenderListMarker.cpp:
        (WebCore::listMarkerSuffix): Removed call to ASSERT_NOT_REACHED().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=46948 Crash with all-
bdakin@apple.com [Fri, 1 Oct 2010 01:13:37 +0000 (01:13 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=46948 Crash with all-
whitespace separators for mfenced

Reviewed by Adele Peterson.

WebCore:

Check the size of characters instead of separators in case all the
separators were whitespace.

* mathml/RenderMathMLFenced.cpp:
(WebCore::RenderMathMLFenced::updateFromElement):

LayoutTests:

* mathml/fenced-whitespace-separators-crash-expected.txt: Added.
* mathml/fenced-whitespace-separators-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-30 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 1 Oct 2010 00:39:14 +0000 (00:39 +0000)]
2010-09-30  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Jon Honeycutt.

        REGRESSION (r65681): Crash in AccessibilityUIElement::addSelection when running platform/win/accessibility/selection-and-focus.html
        https://bugs.webkit.org/show_bug.cgi?id=46913

        REGRESSION (r65681): platform/win/accessibility/img-alt-attribute.html failing on Windows
        https://bugs.webkit.org/show_bug.cgi?id=46914

        <rdar://problem/8497332&8497393>

        Fix two layout tests that made incorrect assumptions about the structure of the
        accessibility tree.

        * platform/win/Skipped:
        * platform/win/accessibility/img-alt-attribute.html:
        * platform/win/accessibility/selection-and-focus.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-30 Darin Adler <darin@apple.com>
darin@apple.com [Fri, 1 Oct 2010 00:04:02 +0000 (00:04 +0000)]
2010-09-30  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Remove remaining calls to deprecatedParseURL
        https://bugs.webkit.org/show_bug.cgi?id=26599

        * WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebFrameLoaderClient::dispatchDidFailToStartPlugin):
        Call stripLeadingAndTrailingHTMLSpaces instead of deprecatedParseURL.
2010-09-30  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Remove remaining calls to deprecatedParseURL
        https://bugs.webkit.org/show_bug.cgi?id=26599

        * DOM/WebDOMOperations.mm:
        (-[DOMDocument URLWithAttributeString:]):
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::createPlugin):
        Call stripLeadingAndTrailingHTMLSpaces instead of deprecatedParseURL.
2010-09-30  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Remove remaining calls to deprecatedParseURL
        https://bugs.webkit.org/show_bug.cgi?id=26599

        Test: fast/replaced/object-param-spaces.html

        * css/CSSHelper.cpp: Removed.
        * css/CSSHelper.h: Removed deprecatedParseURL.

        * html/parser/HTMLParserIdioms.cpp:
        (WebCore::stripLeadingAndTrailingHTMLSpaces):
        Fixed bug where the function would turn the null string into the empty string.
        Fixed bug where the function would not strip all trailing spaces.

        * html/parser/CSSPreloadScanner.cpp:
        (WebCore::CSSPreloadScanner::CSSPreloadScanner): Initialize m_state
        instead of calling the reset function.
        (WebCore::CSSPreloadScanner::scan): Tweaked coding style.
        (WebCore::CSSPreloadScanner::tokenize): Use isHTMLSpace instead of
        an identical local function named isWhitespace.
        (WebCore::parseCSSStringOrURL): Added. This function does what
        deprecatedParseURL did before, and this is the only place in WebKit
        that needs it. The code implements the rules for a string or URL
        token. The real CSS parser does this with flex and the code to hook
        flex up to yacc, so the function is not needed there.
        (WebCore::CSSPreloadScanner::emitRule): Streamlined the code a bit
        and mae it call parseCSSStringOrURL.

        * bindings/generic/BindingSecurity.h:
        (WebCore::::allowSettingFrameSrcToJavascriptUrl):
        * bindings/js/JSDOMBinding.cpp:
        (WebCore::allowSettingSrcToJavascriptURL):
        * bindings/js/JSHTMLFrameElementCustom.cpp:
        (WebCore::allowSettingJavascriptURL):
        * bindings/objc/DOM.mm:
        (-[DOMElement _getURLAttribute:]):
        * bindings/objc/DOMHTML.mm:
        (-[DOMHTMLDocument _createDocumentFragmentWithMarkupString:baseURLString:]):
        * dom/Document.cpp:
        (WebCore::Document::processBaseElement):
        * dom/Element.cpp:
        (WebCore::isAttributeToRemove):
        (WebCore::Element::getURLAttribute):
        (WebCore::Element::getNonEmptyURLAttribute):
        * html/HTMLAnchorElement.cpp:
        (WebCore::HTMLAnchorElement::defaultEventHandler):
        (WebCore::HTMLAnchorElement::parseMappedAttribute):
        (WebCore::HTMLAnchorElement::href):
        * html/HTMLBodyElement.cpp:
        (WebCore::HTMLBodyElement::parseMappedAttribute):
        * html/HTMLEmbedElement.cpp:
        (WebCore::HTMLEmbedElement::parseMappedAttribute):
        * html/HTMLFrameElementBase.cpp:
        (WebCore::HTMLFrameElementBase::parseMappedAttribute):
        * html/HTMLImageElement.cpp:
        (WebCore::HTMLImageElement::parseMappedAttribute):
        * html/HTMLImageLoader.cpp:
        (WebCore::HTMLImageLoader::sourceURI):
        * html/HTMLLinkElement.cpp:
        (WebCore::HTMLLinkElement::parseMappedAttribute):
        * html/HTMLMediaElement.cpp:
        * html/HTMLObjectElement.cpp:
        (WebCore::HTMLObjectElement::parseMappedAttribute):
        (WebCore::HTMLObjectElement::parametersForPlugin):
        * html/HTMLTableElement.cpp:
        (WebCore::HTMLTableElement::parseMappedAttribute):
        * html/HTMLTablePartElement.cpp:
        (WebCore::HTMLTablePartElement::parseMappedAttribute):
        * html/parser/HTMLPreloadScanner.cpp:
        (WebCore::HTMLNames::PreloadTask::setUrlToLoad):
        * loader/FormSubmission.cpp:
        (WebCore::FormSubmission::Attributes::parseAction):
        * platform/chromium/ClipboardChromium.cpp:
        (WebCore::ClipboardChromium::declareAndWriteDragImage):
        * platform/chromium/PasteboardChromium.cpp:
        (WebCore::Pasteboard::writeImage):
        * platform/qt/ClipboardQt.cpp:
        (WebCore::ClipboardQt::declareAndWriteDragImage):
        * platform/win/ClipboardWin.cpp:
        (WebCore::ClipboardWin::declareAndWriteDragImage):
        * rendering/HitTestResult.cpp:
        (WebCore::HitTestResult::absoluteImageURL):
        (WebCore::HitTestResult::absoluteMediaURL):
        (WebCore::HitTestResult::absoluteLinkURL):
        * svg/SVGAElement.cpp:
        (WebCore::SVGAElement::defaultEventHandler):
        * svg/SVGImageLoader.cpp:
        (WebCore::SVGImageLoader::sourceURI):
        * wml/WMLAElement.cpp:
        (WebCore::WMLAElement::defaultEventHandler):
        * wml/WMLImageLoader.cpp:
        (WebCore::WMLImageLoader::sourceURI):
        Call stripLeadingAndTrailingHTMLSpaces instead of deprecatedParseURL.

        * WebCore.exp.in: Updated.

        * Android.mk: Removed CSSHelper.cpp.
        * CMakeLists.txt: Ditto.
        * GNUmakefile.am: Ditto.
        * WebCore.gypi: Ditto.
        * WebCore.pro: Ditto.
        * WebCore.vcproj/WebCore.vcproj: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.

        * bindings/js/JSAttrCustom.cpp:
        * bindings/js/JSElementCustom.cpp:
        * bindings/v8/custom/V8ElementCustom.cpp:
        * bindings/v8/custom/V8LocationCustom.cpp:
        * css/CSSParser.cpp:
        * html/HTMLMediaElement.cpp:
        * html/HTMLVideoElement.cpp:
        * loader/ImageLoader.cpp:
        * rendering/style/RenderStyle.h:
        Removed unneeded include of CSSHelper.h.
2010-09-30  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Remove remaining calls to deprecatedParseURL
        https://bugs.webkit.org/show_bug.cgi?id=26599

        * fast/replaced/object-param-spaces-expected.txt: Copied from
        LayoutTests/fast/replaced/object-param-url-control-char-expected.txt.
        * fast/replaced/object-param-spaces.html: Copied from
        LayoutTests/fast/replaced/object-param-url-control-char.html.
        * fast/replaced/object-param-url-control-char-expected.txt: Removed.
        * fast/replaced/object-param-url-control-char.html: Removed.
        Changed this test to expect HTML standard space trimming, but not the WebKit-only
        control character stripping we had historically.

        * fast/url/query-expected.txt: Updated to expect the test to pass.

        * fast/url/script-tests/segments-from-data-url.js: Changed expected result to not
        expect stripping of newline characters.
        * fast/url/script-tests/segments.js: Ditto.
        * fast/url/segments-expected.txt: Updated results.
        * fast/url/segments-from-data-url-expected.txt: Ditto.

        * http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-expected.txt:
        * http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-getAttribute-value-expected.txt:
        * http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-htmldom-expected.txt:
        * http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttribute-expected.txt:
        * http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNS-expected.txt:
        * http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNode-expected.txt:
        * http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNodeNS-expected.txt:
        * http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-getAttribute-value-expected.txt:
        * http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-htmldom-expected.txt:
        * http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute-expected.txt:
        * http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNS-expected.txt:
        * http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNode-expected.txt:
        * http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNodeNS-expected.txt:
        These tests had multiple test cases with embedded control characters. These URLs no
        longer qualify as javascript URLs, so there are no longer any unsafe JavaScript log
        messages for them. The test cases themselves need not be changed at this time.

        * http/tests/security/xssAuditor/embed-tag-control-char-expected.txt:
        * http/tests/security/xssAuditor/object-embed-tag-control-char-expected.txt:
        Updated expected results to reflect the fact that the control character is no longer
        stripped from the URL in these cases. The test is still valid, but these are not as
        interesting test cases any more since control characters do not have special handling.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-30 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 30 Sep 2010 23:41:15 +0000 (23:41 +0000)]
2010-09-30  Martin Robinson  <mrobinson@igalia.com>

        Unskip some tests that are passing and rebaseline a couple others.

        * platform/gtk/Skipped: Unskip tests and do a little reorganization.
        * platform/gtk/fast/dom/Window/window-properties-expected.txt: Rebaselined.
        * platform/gtk/fast/overflow/line-clamp-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix. Not reviewed.
hclam@chromium.org [Thu, 30 Sep 2010 23:25:39 +0000 (23:25 +0000)]
Build fix. Not reviewed.

Remove a test expectation since the problem was fixed.

* platform/chromium-win/editing/execCommand/toggle-compound-styles-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-30 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 30 Sep 2010 23:18:57 +0000 (23:18 +0000)]
2010-09-30  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler.

        Background doesn't draw when entering accelerated compositing
        https://bugs.webkit.org/show_bug.cgi?id=45848

        LayerBackedDrawingArea::setSize() is normally called in response
        to a message from the UI process, so this can come some time after
        LayerBackedDrawingArea creation. Depending on the timing, we could
        end up being at size 0x0 for the first invalidate and paint, resulting
        in missing content.

        The fix is to size the backing layer on creation, using the WebView's size.

        Also changed various calls to syncCompositingStateForThisLayerOnly()
        to do lazy updates via scheduleCompositingLayerSync().

        Also add the fix for https://bugs.webkit.org/show_bug.cgi?id=46226 (r68028)
        to the WebKit2 code, in scheduleUpdateLayoutRunLoopObserver().

        * WebProcess/WebPage/LayerBackedDrawingArea.cpp:
        (WebKit::LayerBackedDrawingArea::LayerBackedDrawingArea):
        (WebKit::LayerBackedDrawingArea::setNeedsDisplay):
        (WebKit::LayerBackedDrawingArea::setSize):
        * WebProcess/WebPage/mac/LayerBackedDrawingAreaMac.mm:
        (WebKit::LayerBackedDrawingArea::platformInit):
        (WebKit::LayerBackedDrawingArea::attachCompositingContext):
        (WebKit::LayerBackedDrawingArea::detachCompositingContext):
        (WebKit::LayerBackedDrawingArea::setRootCompositingLayer):
        (WebKit::LayerBackedDrawingArea::syncCompositingLayers):
        (WebKit::LayerBackedDrawingArea::scheduleUpdateLayoutRunLoopObserver):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-30 Alexey Marinichev <amarinichev@chromium.org>
commit-queue@webkit.org [Thu, 30 Sep 2010 23:17:43 +0000 (23:17 +0000)]
2010-09-30  Alexey Marinichev  <amarinichev@chromium.org>

        Reviewed by Chris Marrin.

        Add GetGraphicsResetStatusARB entry point from ARB_robustness
        extension to GraphicsContext3D
        https://bugs.webkit.org/show_bug.cgi?id=46850

        Added stubs for GraphicsContext3D::getGraphicsResetStatusARB for
        Mac and QT.

        * platform/graphics/GraphicsContext3D.h:
        * platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
        (WebCore::GraphicsContext3D::getGraphicsResetStatusARB):
        * platform/graphics/qt/GraphicsContext3DQt.cpp:
        (WebCore::GraphicsContext3D::getGraphicsResetStatusARB):
2010-09-30  Alexey Marinichev  <amarinichev@chromium.org>

        Reviewed by Chris Marrin.

        Add GetGraphicsResetStatusARB entry point from ARB_robustness
        extension to GraphicsContext3D
        https://bugs.webkit.org/show_bug.cgi?id=46850

        Added a stub for GraphicsContext3D::getGraphicsResetStatusARB.

        * src/GraphicsContext3DChromium.cpp:
        (WebCore::GraphicsContext3D::getGraphicsResetStatusARB):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebKit2 on Windows should use Windows fonts for the various standard
jhoneycutt@apple.com [Thu, 30 Sep 2010 23:17:39 +0000 (23:17 +0000)]
WebKit2 on Windows should use Windows fonts for the various standard
font families
https://bugs.webkit.org/show_bug.cgi?id=43499
<rdar://problem/8272758>

Reviewed by Adam Roben.

WebKit2:

* Shared/WebPreferencesStore.cpp:
(WebKit::WebPreferencesStore::WebPreferencesStore):
Use Windows fonts on Windows.

WebKitTools:

* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):
Use the Mac fonts for running tests. This matches DRT behavior.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix. Not reviewed.
hclam@chromium.org [Thu, 30 Sep 2010 23:08:51 +0000 (23:08 +0000)]
Build fix. Not reviewed.

Add test expectations for Chromium.

* platform/chromium-win/editing/execCommand/toggle-compound-styles-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix. Not reviewed.
hclam@chromium.org [Thu, 30 Sep 2010 23:04:13 +0000 (23:04 +0000)]
Build fix. Not reviewed.

Update test expectations for Chromium.

* platform/chromium-linux/fast/text/international/thai-baht-space-expected.checksum:
* platform/chromium-linux/fast/text/international/thai-baht-space-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=46774 - Add WKStringIsEqual API
beidson@apple.com [Thu, 30 Sep 2010 22:41:05 +0000 (22:41 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=46774 - Add WKStringIsEqual API

Reviewed by Sam Weinig.

* Shared/API/c/WKString.cpp:
(WKStringIsEqual):
* Shared/API/c/WKString.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=46938
hyatt@apple.com [Thu, 30 Sep 2010 22:24:22 +0000 (22:24 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=46938

Reviewed by Sam Weinig.

Rewrite margin collapsing to be block-flow-aware.  Eliminate a bunch of the margin functions on RenderBox in favor of a single
master function for grabbing all the margin values for a child: marginValuesForChild on RenderBlock.  Introduce a new
MarginValues struct to make returning the collection of 4 margin values easy.

fast/blockflow/inline-direction-positioning.html progresses to have the correct results.
Added fast/blockflow/margin-collapse.html

WebCore:

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::MarginInfo::MarginInfo):
(WebCore::RenderBlock::adjustPositionedBlock):
(WebCore::RenderBlock::collapseMargins):
(WebCore::RenderBlock::clearFloatsIfNeeded):
(WebCore::RenderBlock::setCollapsedBottomMargin):
(WebCore::RenderBlock::layoutBlockChild):
(WebCore::RenderBlock::setMaxMarginBeforeValues):
(WebCore::RenderBlock::setMaxMarginAfterValues):
(WebCore::RenderBlock::marginValuesForChild):
* rendering/RenderBlock.h:
(WebCore::RenderBlock::MarginValues::MarginValues):
(WebCore::RenderBlock::MarginValues::positiveMarginBefore):
(WebCore::RenderBlock::MarginValues::negativeMarginBefore):
(WebCore::RenderBlock::MarginValues::positiveMarginAfter):
(WebCore::RenderBlock::MarginValues::negativeMarginAfter):
(WebCore::RenderBlock::MarginValues::setPositiveMarginBefore):
(WebCore::RenderBlock::MarginValues::setNegativeMarginBefore):
(WebCore::RenderBlock::MarginValues::setPositiveMarginAfter):
(WebCore::RenderBlock::MarginValues::setNegativeMarginAfter):
(WebCore::RenderBlock::maxPositiveMarginBefore):
(WebCore::RenderBlock::maxNegativeMarginBefore):
(WebCore::RenderBlock::maxPositiveMarginAfter):
(WebCore::RenderBlock::maxNegativeMarginAfter):
(WebCore::RenderBlock::initMaxMarginValues):
(WebCore::RenderBlock::collapsedMarginBefore):
(WebCore::RenderBlock::collapsedMarginAfter):
(WebCore::RenderBlock::MarginInfo::clearMargin):
(WebCore::RenderBlock::MarginInfo::setPositiveMargin):
(WebCore::RenderBlock::MarginInfo::setNegativeMargin):
(WebCore::RenderBlock::MarginInfo::setPositiveMarginIfLarger):
(WebCore::RenderBlock::MarginInfo::setNegativeMarginIfLarger):
(WebCore::RenderBlock::MarginInfo::setMargin):
(WebCore::RenderBlock::MarginInfo::positiveMargin):
(WebCore::RenderBlock::MarginInfo::negativeMargin):
(WebCore::RenderBlock::MarginInfo::margin):
(WebCore::RenderBlock::RenderBlockRareData::RenderBlockRareData):
(WebCore::RenderBlock::RenderBlockRareData::positiveMarginBeforeDefault):
(WebCore::RenderBlock::RenderBlockRareData::negativeMarginBeforeDefault):
(WebCore::RenderBlock::RenderBlockRareData::positiveMarginAfterDefault):
(WebCore::RenderBlock::RenderBlockRareData::negativeMarginAfterDefault):
* rendering/RenderBox.h:
(WebCore::RenderBox::collapsedMarginBefore):
(WebCore::RenderBox::collapsedMarginAfter):
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock):

LayoutTests:

* fast/blockflow/margin-collapse.html: Added.
* platform/mac/fast/blockflow/inline-direction-positioning-expected.checksum:
* platform/mac/fast/blockflow/inline-direction-positioning-expected.png:
* platform/mac/fast/blockflow/inline-direction-positioning-expected.txt:
* platform/mac/fast/blockflow/margin-collapse-expected.checksum: Added.
* platform/mac/fast/blockflow/margin-collapse-expected.png: Added.
* platform/mac/fast/blockflow/margin-collapse-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-30 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Thu, 30 Sep 2010 22:19:05 +0000 (22:19 +0000)]
2010-09-30  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Adam Roben.

        [WINCE] Fix InternetGetCookie in CookieJarWin.cpp
        https://bugs.webkit.org/show_bug.cgi?id=46929

        If the InternetGetCookie fails the output size won't be set.
        Set the default size to 0, so we always get the correct size
        and check the return value of InternetGetCookie.

        * platform/network/win/CookieJarWin.cpp:
        (WebCore::cookies):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-30 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 30 Sep 2010 22:11:18 +0000 (22:11 +0000)]
2010-09-30  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed rebaseline for Qt and Windows platforms required by r68830.

        * platform/qt/editing/execCommand/toggle-compound-styles-expected.txt: Merged b elements.
        * platform/win/editing/execCommand/toggle-compound-styles-expected.txt: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-30 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Thu, 30 Sep 2010 22:08:40 +0000 (22:08 +0000)]
2010-09-30  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Adam Roben.

        [WINCE] Use OwnPtr for HBRUSH and HPEN in GraphicsContext
        https://bugs.webkit.org/show_bug.cgi?id=46881

        Also add some missing SelectObject calls.

        * platform/graphics/wince/GraphicsContextWinCE.cpp:
        (WebCore::createPen):
        (WebCore::createBrush):
        (WebCore::GraphicsContext::drawRect):
        (WebCore::GraphicsContext::drawLine):
        (WebCore::GraphicsContext::drawEllipse):
        (WebCore::GraphicsContext::strokeArc):
        (WebCore::GraphicsContext::drawConvexPolygon):
        (WebCore::GraphicsContext::strokeRect):
        (WebCore::GraphicsContext::fillRoundedRect):
        (WebCore::GraphicsContext::fillPath):
        (WebCore::GraphicsContext::strokePath):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68839 268f45cc-cd09-0410-ab3c-d52691b4dbfc