WebKit-https.git
11 years ago2010-08-20 Leandro Pereira <leandro@profusion.mobi>
leandro@webkit.org [Fri, 20 Aug 2010 18:24:18 +0000 (18:24 +0000)]
2010-08-20  Leandro Pereira  <leandro@profusion.mobi>

        [EFL] Unreviewed. Fix build when using GNU gold.
        When linking with GNU gold, some symbols are not found: explicitly
        link with the required libraries.

        * CMakeListsEfl.txt: Depend on Fontconfig, PNG, JPEG and dl
        libraries.
2010-08-20  Leandro Pereira  <leandro@profusion.mobi>

        [EFL] Unreviewed. Fix build when using GNU gold.
        When linking with GNU gold, some symbols are not found: explicitly
        link with the required libraries.

        * cmake/FindFontconfig.cmake: Added.
        * cmake/OptionsEfl.cmake: Find Fontconfig, JPEG, and PNG libraries.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-20 Jay Civelli <jcivelli@chromium.org>
jcivelli@chromium.org [Fri, 20 Aug 2010 18:12:01 +0000 (18:12 +0000)]
2010-08-20  Jay Civelli  <jcivelli@chromium.org>

        Reviewed by Darin Fisher.

        Removing the deprecated class WebEvent and friends.
        https://bugs.webkit.org/show_bug.cgi?id=44296

        * WebKit.gyp:
        * public/WebEvent.h: Removed.
        * public/WebEventListener.h: Removed.
        * public/WebMutationEvent.h: Removed.
        * public/WebNode.h:
        * src/EventListenerWrapper.cpp:
        (WebKit::EventListenerWrapper::webDOMEventListenerDeleted):
        * src/EventListenerWrapper.h:
        * src/WebEvent.cpp: Removed.
        * src/WebEventListener.cpp: Removed.
        * src/WebEventListenerPrivate.cpp: Removed.
        * src/WebEventListenerPrivate.h: Removed.
        * src/WebNode.cpp:
        (WebKit::WebNode::removeEventListener):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-20 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Fri, 20 Aug 2010 18:00:21 +0000 (18:00 +0000)]
2010-08-20  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Darin Fisher.

        Prevent use of stale notification presenter pointer in notifications by instead using
        a notification center pointer and deriving the presenter from it. Notification presenter
        gets properly destroyed using disconnectFrame function inside notification center. Add
        null checks for notification presenter.
        https://bugs.webkit.org/show_bug.cgi?id=43645

        Test: fast/notifications/notifications-window-close-crash.html

        * notifications/Notification.cpp:
        (WebCore::Notification::Notification):
        (WebCore::Notification::create):
        (WebCore::Notification::show):
        (WebCore::Notification::cancel):
        (WebCore::Notification::contextDestroyed):
        (WebCore::Notification::finishLoading):
        * notifications/Notification.h:
        (WebCore::Notification::detachPresenter):
        * notifications/NotificationCenter.h:
        (WebCore::NotificationCenter::createHTMLNotification):
        (WebCore::NotificationCenter::createNotification):
2010-08-20  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Darin Fisher.

        Manual test to check that canceling the notification on a closed window does
        not result in crash.
        https://bugs.webkit.org/show_bug.cgi?id=43645

        * fast/notifications/notifications-window-close-crash-expected.txt: Added.
        * fast/notifications/notifications-window-close-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-20 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Fri, 20 Aug 2010 17:50:05 +0000 (17:50 +0000)]
2010-08-20  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        r64526 broke the GTK+-3 build
        https://bugs.webkit.org/show_bug.cgi?id=44254

        No new tests, as this is covered by manual-tests/cursor.html.

        * platform/gtk/CursorGtk.cpp:
        (WebCore::createPixmapFromBits): Added this method which turns the inline data
        structures into GdkPixmaps using Cairo and GDK-Cairo.
        (WebCore::createNamedCursor): Modified this method to use the new helper.
        * platform/gtk/CursorGtk.h: Changed all inline data structures to be unsigned
        char arrays (which Cairo requires). The progress cursor is known in X11 icon themes
        as "left_ptr_watch." This change to the name preserves the old behavior of taking this
        icon from the theme when available. It seems that this worked in the past due to a fluke
        or failure of the previous code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-19 Zhenyao Mo <zmo@google.com>
zmo@google.com [Fri, 20 Aug 2010 17:24:31 +0000 (17:24 +0000)]
2010-08-19  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        Fix failing WebGL tests in Chromium in-process-webgl port
        https://bugs.webkit.org/show_bug.cgi?id=44305

        * src/WebGraphicsContext3DDefaultImpl.cpp:
        (WebKit::WebGraphicsContext3DDefaultImpl::getVertexAttribOffset): Add implementation.
2010-08-19  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        Fix failing WebGL tests in Chromium in-process-webgl port
        https://bugs.webkit.org/show_bug.cgi?id=44305

        * fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html: Add "#ifdef GLES" around precision keywords.
        * fast/canvas/webgl/gl-bind-attrib-location-test-expected.txt: Re-enable the failing tests.
        * fast/canvas/webgl/gl-bind-attrib-location-test.html: Add "#ifdef GLES" around precision keywords.
        * fast/canvas/webgl/read-pixels-pack-alignment-expected.txt: Ditto.
        * fast/canvas/webgl/read-pixels-pack-alignment.html: Ditto.
        * fast/canvas/webgl/resources/fragmentShader.frag: Ditto.
        * fast/canvas/webgl/texImage2DImageDataTest.html: Ditto.
        * fast/canvas/webgl/texture-active-bind.html: Ditto.
        * fast/canvas/webgl/texture-complete.html: Ditto.
        * fast/canvas/webgl/texture-transparent-pixels-initialized.html: Ditto.
        * platform/chromium/test_expectations.txt: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-20 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Fri, 20 Aug 2010 17:13:57 +0000 (17:13 +0000)]
2010-08-20  Martin Robinson  <mrobinson@igalia.com>

        [GTK] Inspector extensions tests fail on GTK+ bots because onSelectionChanged is missing
        https://bugs.webkit.org/show_bug.cgi?id=44342

        * platform/gtk/Skipped: Skip failing tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-20 John Gregg <johnnyg@google.com>
johnnyg@google.com [Fri, 20 Aug 2010 17:07:43 +0000 (17:07 +0000)]
2010-08-20  John Gregg  <johnnyg@google.com>

        Unreviewed, test expectations.

        Add fail expectations for some SVG tests after r65729.  See bug 44341.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-20 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Fri, 20 Aug 2010 16:32:24 +0000 (16:32 +0000)]
2010-08-20  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Pavel Feldman.

        Web Inspector: Inspector tests were disabled for GTK.
        https://bugs.webkit.org/show_bug.cgi?id=43977

        * platform/gtk/Skipped: Unskip tests which should now be passing.
2010-08-20  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Pavel Feldman.

        Web Inspector: Inspector tests were disabled for GTK.
        https://bugs.webkit.org/show_bug.cgi?id=43977

        Allow setting the inspector resources path via an environment variables
        and add a method, inspectorFilesPath, to the WebKit InspectorClient that
        encapsulates this logic.

        * WebCoreSupport/InspectorClientGtk.cpp:
        (WebKit::InspectorClient::openInspectorFrontend): Use the new inspectorFilesPath method to
        get the path to the resource.
        (WebKit::InspectorClient::inspectorFilesPath): Added.
        (WebKit::InspectorFrontendClient::localizedStringsURL): Use inspectorFilesPath method.
        * WebCoreSupport/InspectorClientGtk.h: Add method and member variables for caching the result.
2010-08-20  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Pavel Feldman.

        Web Inspector: Inspector tests were disabled for GTK.
        https://bugs.webkit.org/show_bug.cgi?id=43977

        * Scripts/old-run-webkit-tests: Set the WEBKIT_INSPECTOR_PATH to the appropriate
        path before running tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-20 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Fri, 20 Aug 2010 16:01:06 +0000 (16:01 +0000)]
2010-08-20  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Dirk Schulze.

        [Cairo] Eliminate full-surface copy from canvas.drawImage(...)
        https://bugs.webkit.org/show_bug.cgi?id=44190

        Covered by canvas layout tests.

        * platform/graphics/cairo/ImageBufferCairo.cpp:
        (WebCore::ImageBuffer::drawsUsingCopy): Return false now.
        (WebCore::ImageBuffer::clip): Add a link to the bug which tracks this feature.
        (WebCore::ImageBuffer::draw): Construct the bitmap image without the full-surface copy.
        (WebCore::ImageBuffer::drawPattern): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-20 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Fri, 20 Aug 2010 15:13:55 +0000 (15:13 +0000)]
2010-08-20  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Xan Lopez.

        [REGRESSION] r65608 broke gtk distcheck
        https://bugs.webkit.org/show_bug.cgi?id=44333

        Define the inspector.html as a noinst_DATA intead of using the dir
        suffix, which is used for installation.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-20 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Fri, 20 Aug 2010 15:07:32 +0000 (15:07 +0000)]
2010-08-20  Daniel Bates  <dbates@rim.com>

        Reviewed by Eric Seidel.

        svn-apply doesn't detect empty line with Windows line endings
        after property value
        https://bugs.webkit.org/show_bug.cgi?id=43981

        Part 2 of 2

        Add unit tests that were not landed in the first commit.

        * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
          - Added the following test cases:
            "SVN: binary file (isBinary true) using Windows line endings"
            "SVN: property diff, followed by file change diff using Windows line endings"
            "SVN: two consecutive property diffs using Windows line endings"
            "SVN: binary file with executable bit change usng Windows line endings"
            "SVN: binary file followed by property change on different file using Windows line endings"
            "SVN: binary file followed by file change on different file using Windows line endings"
            "SVN: file change diff with property change, followed by property change diff using Windows line endings"
            "SVN: file change diff with property change, followed by file change diff using Windows line endings"
        * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
          - Added the following test cases:
            "add svn:executable, followed by empty line and start of next diff using Windows line endings"
            "add svn:executable, followed by empty line and start of next property diff using Windows line endings"
            "multi-line '+' change, followed by empty line and start of next diff using Windows line endings"
            "multi-line '+' change, followed by empty line and start of next property diff using Windows line endings"
            "add svn:executable, followed by empty line and start of binary patch using Windows line endings"
            "multi-line '+' change, followed by empty line and start of binary patch using Windows line endings"
            "multi-line '-' change, followed by multi-line '+' change, empty line, and start of binary patch using Windows line endings"
            "single-line '+' with trailing new line using Windows line endings"
            "single-line '+' with trailing new line, followed by empty line and start of binary patch using Windows line endings"
            "single-line '-' change with trailing new line, and single-line '+' change using Windows line endings"
            "multi-line '-' change with trailing new line, and multi-line '+' change using Windows line endings"
        * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
          - Added the following test cases:
            "single-line '-' change followed by empty line with Windows line endings"
            "multi-line '+' change and start of binary patch with Windows line endings"

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-20 Lucas De Marchi <lucas.demarchi@profusion.mobi>
demarchi@webkit.org [Fri, 20 Aug 2010 14:48:31 +0000 (14:48 +0000)]
2010-08-20  Lucas De Marchi  <lucas.demarchi@profusion.mobi>

        Unreviewed build fix.

        As opposed to WebCore, JavascriptCore and wtf, webkit is always a
        shared library. After r65366, libewebkit.so was not being installed
        anymore when building with SHARED_CORE=0 (which is the default). This
        partially reverts that revision in order to fix this issue.

        * CMakeLists.txt: always install webkit library.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-20 Daniel Bates <dbates@rim.com>
commit-queue@webkit.org [Fri, 20 Aug 2010 14:45:03 +0000 (14:45 +0000)]
2010-08-20  Daniel Bates  <dbates@rim.com>

        Reviewed by Eric Seidel.

        svn-apply doesn't detect empty line with Windows line endings
        after property value
        https://bugs.webkit.org/show_bug.cgi?id=43981

        Fixes an issue where an empty line following the property value
        in an SVN property change diff would not be detected if it had
        Windows line endings (i.e. ended in CRLF). Hence it was consumed
        as if it was part of a multi-line property value.

        * Scripts/VCSUtils.pm:
          - Modified parseSvnPropertyValue() to detect empty line
            with Windows line endings.
          - Added toWindowsLineEndings().
        * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
          - Added the following test cases:
            "SVN: binary file (isBinary true) using Windows line endings"
            "SVN: property diff, followed by file change diff using Windows line endings"
            "SVN: two consecutive property diffs using Windows line endings"
            "SVN: binary file with executable bit change usng Windows line endings"
            "SVN: binary file followed by property change on different file using Windows line endings"
            "SVN: binary file followed by file change on different file using Windows line endings"
            "SVN: file change diff with property change, followed by property change diff using Windows line endings"
            "SVN: file change diff with property change, followed by file change diff using Windows line endings"
        * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
          - Added the following test cases:
            "add svn:executable, followed by empty line and start of next diff using Windows line endings"
            "add svn:executable, followed by empty line and start of next property diff using Windows line endings"
            "multi-line '+' change, followed by empty line and start of next diff using Windows line endings"
            "multi-line '+' change, followed by empty line and start of next property diff using Windows line endings"
            "add svn:executable, followed by empty line and start of binary patch using Windows line endings"
            "multi-line '+' change, followed by empty line and start of binary patch using Windows line endings"
            "multi-line '-' change, followed by multi-line '+' change, empty line, and start of binary patch using Windows line endings"
            "single-line '+' with trailing new line using Windows line endings"
            "single-line '+' with trailing new line, followed by empty line and start of binary patch using Windows line endings"
            "single-line '-' change with trailing new line, and single-line '+' change using Windows line endings"
            "multi-line '-' change with trailing new line, and multi-line '+' change using Windows line endings"
        * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
          - Added the following test cases:
            "single-line '-' change followed by empty line with Windows line endings"
            "multi-line '+' change and start of binary patch with Windows line endings"

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-19 Pavel Podivilov <podivilov@chromium.org>
yurys@chromium.org [Fri, 20 Aug 2010 13:38:14 +0000 (13:38 +0000)]
2010-08-19  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: implement breaking on DOM node subtree mutations.
        https://bugs.webkit.org/show_bug.cgi?id=42886

        Add two entries to Web Inspector DOM element context menu:
        1. "Stop on subtree modifications": will break on adding/removing of any element which is a child of the DOM element
        2. "Remove breakpoints": will remove all breakpoints associated with the DOM element

        * English.lproj/localizedStrings.js:
        * bindings/js/ScriptDebugServer.cpp:
        (WebCore::ScriptDebugServer::breakProgram):
        * bindings/js/ScriptDebugServer.h:
        * bindings/v8/ScriptDebugServer.cpp:
        (WebCore::ScriptDebugServer::breakProgram):
        (WebCore::ScriptDebugServer::breakProgramCallback):
        (WebCore::ScriptDebugServer::handleV8DebugEvent):
        * bindings/v8/ScriptDebugServer.h:
        * inspector/Inspector.idl:
        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::~InspectorDOMAgent):
        (WebCore::InspectorDOMAgent::discardBindings):
        (WebCore::InspectorDOMAgent::setDOMBreakpoint):
        (WebCore::InspectorDOMAgent::removeDOMBreakpoint):
        (WebCore::InspectorDOMAgent::didInsertDOMNode):
        (WebCore::InspectorDOMAgent::didRemoveDOMNode):
        (WebCore::InspectorDOMAgent::hasBreakpoint):
        (WebCore::InspectorDOMAgent::pauseOnBreakpoint):
        (WebCore::InspectorDOMAgent::updateSubtreeBreakpoints):
        * inspector/InspectorDOMAgent.h:
        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeElement.prototype._populateTagContextMenu):
        * inspector/front-end/Settings.js:

2010-08-19  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: enable DOM breakpoints for chromium
        https://bugs.webkit.org/show_bug.cgi?id=42886

        * src/js/DevTools.js:
        (WebInspector.loaded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-20 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Fri, 20 Aug 2010 11:34:16 +0000 (11:34 +0000)]
2010-08-20  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: discard InjectedScript reference on ScriptState when clearing injected scripts
        https://bugs.webkit.org/show_bug.cgi?id=44328

        Otherwise if the reference is not cleared we may remove InjectedScript from the
        map on InjectedScriptHost but keep it on ScriptState and try to reuse it later.

        * bindings/js/JSInjectedScriptHostCustom.cpp:
        (WebCore::InjectedScriptHost::discardInjectedScript):
        * bindings/v8/V8HiddenPropertyName.h:
        * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
        (WebCore::InjectedScriptHost::discardInjectedScript):
        (WebCore::InjectedScriptHost::injectedScriptFor):
        * inspector/InjectedScript.h:
        (WebCore::InjectedScript::scriptState):
        * inspector/InjectedScriptHost.cpp:
        (WebCore::InjectedScriptHost::discardInjectedScripts):
        * inspector/InjectedScriptHost.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-20 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Fri, 20 Aug 2010 09:13:49 +0000 (09:13 +0000)]
2010-08-20  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        Clippers are rasterized, when applied to scaled target object
        https://bugs.webkit.org/show_bug.cgi?id=44325

        Use SVGImageBufferTools logic for RenderSVGResourceClipper, just like RenderSVGResourceMasker/Gradient,
        to avoid pixelation, when the clipper is applied to a scaled target object, or when the document is scaled.

        Test: svg/clip-path/clip-path-pixelation.svg

        * rendering/RenderSVGResourceClipper.cpp:
        (WebCore::RenderSVGResourceClipper::applyClippingToContext):
        (WebCore::RenderSVGResourceClipper::createClipData):
        * rendering/RenderSVGResourceClipper.h:

2010-08-20  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        Clippers are rasterized, when applied to scaled target object
        https://bugs.webkit.org/show_bug.cgi?id=44325

        * platform/mac/svg/clip-path/clip-path-pixelation-expected.checksum: Added.
        * platform/mac/svg/clip-path/clip-path-pixelation-expected.png: Added.
        * platform/mac/svg/clip-path/clip-path-pixelation-expected.txt: Added.
        * svg/clip-path/clip-path-pixelation.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-20 Andreas Kling <andreas.kling@nokia.com>
andreas.kling@nokia.com [Fri, 20 Aug 2010 08:12:08 +0000 (08:12 +0000)]
2010-08-20  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Initialize GDK before loading plugins
        https://bugs.webkit.org/show_bug.cgi?id=44324

        Attempt to call gdk_init_check() before loading any plugins.
        This prevents various crashes and freezes in Adobe's Flash plugin.

        * plugins/qt/PluginPackageQt.cpp:
        (WebCore::initializeGdkIfPossible):
        (WebCore::PluginPackage::load):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFollow-up to r41020.
mitz@apple.com [Fri, 20 Aug 2010 07:58:04 +0000 (07:58 +0000)]
Follow-up to r41020.

Reviewed by Mark Rowe.

No change in behavior, thus no new tests.

* platform/graphics/mac/FontPlatformDataMac.mm:
(WebCore::FontPlatformData::FontPlatformData): Asserted that the NSFont parameter is not nil,
and removed nil check.
(WebCore::FontPlatformData::setFont): Asserted that the NSFont parameter is not nil and that
this is not the deleted value, and removed code to handle those cases.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-19 Vincent Scheib <scheib@chromium.org>
commit-queue@webkit.org [Fri, 20 Aug 2010 04:51:40 +0000 (04:51 +0000)]
2010-08-19  Vincent Scheib  <scheib@chromium.org>

        Reviewed by David Levin.

        [chromium] TilingData::tilePositionY has typo of X where Y should be used
        https://bugs.webkit.org/show_bug.cgi?id=44195

        Corrected error, and rewrote functions to use for loop instead of recursion.

        Unit Tests added to WebKit/chromium/tests/TilingDataTest.cpp

        * platform/graphics/chromium/TilingData.cpp:
        (WebCore::TilingData::tilePositionX):
        (WebCore::TilingData::tilePositionY):
2010-08-19  Vincent Scheib  <scheib@chromium.org>

        Reviewed by David Levin.

        [chromium] TilingData::tilePositionY has typo of X where Y should be used
        https://bugs.webkit.org/show_bug.cgi?id=44195

        Unit tests added for tileSize and tilePosition.

        * tests/TilingDataTest.cpp:
        (WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-19 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Fri, 20 Aug 2010 04:28:39 +0000 (04:28 +0000)]
2010-08-19  Kent Tamura  <tkent@chromium.org>

        Unreviewed, test expectation update.

        Update for r65723.

        * platform/chromium-win/fast/forms/listbox-selection-expected.txt: Removed.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-19 Mihai Parparita <mihaip@chromium.org>
commit-queue@webkit.org [Fri, 20 Aug 2010 03:57:13 +0000 (03:57 +0000)]
2010-08-19  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Brady Eidson.

        Assertion failure when going back inside frame during onload
        https://bugs.webkit.org/show_bug.cgi?id=44217

        Adds a test that does a history.back() within the main frame during
        onload of a child frame. If HISTORY_ALWAYS_ASYNC was set to 0, this
        would crash the DRT with an assertion failure, since we hadn't called
        updateForFrameLoadCompleted in the main frame yet.

        (renames history-back-within-subframe to history-back-within-subframe-hash
        to differentiate between the two otherwise similar tests)

        * fast/history/history-back-within-subframe-hash-expected.txt: Renamed from LayoutTests/fast/history/history-back-within-subframe-expected.txt.
        * fast/history/history-back-within-subframe-hash.html: Renamed from LayoutTests/fast/history/history-back-within-subframe.html.
        * fast/history/history-back-within-subframe-url-expected.txt: Added
        * fast/history/history-back-within-subframe-url.html: Added.
        * fast/history/resources/history-back-within-subframe-hash-2.html: Renamed from LayoutTests/fast/history/resources/history-back-within-subframe-2.html.
        * fast/history/resources/history-back-within-subframe-url-2.html: Added.
        * fast/history/resources/history-back-within-subframe-url-3.html: Added.
2010-08-19  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Brady Eidson.

        Assertion failure when going back inside frame during onload
        https://bugs.webkit.org/show_bug.cgi?id=44217

        Fix assertion failure when doing a history.back() within the main frame
        during onload of a child frame. This would happen when
        HISTORY_ALWAYS_ASYNC was set to 0, because we would only compare the
        current frame document sequence numbers when determining if we're in the
        same document, instead of also recursing over child frames.

        Test: fast/history/history-back-within-subframe-hash.html

        * history/HistoryItem.cpp:
        (WebCore::HistoryItem::hasSameDocuments):
        * history/HistoryItem.h:
        * loader/RedirectScheduler.cpp:
        (WebCore::RedirectScheduler::scheduleHistoryNavigation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-19 Kenichi Ishibashi <bashi@google.com>
commit-queue@webkit.org [Fri, 20 Aug 2010 03:37:28 +0000 (03:37 +0000)]
2010-08-19  Kenichi Ishibashi  <bashi@google.com>

        Reviewed by Kent Tamura.

        Improve portability of fast/forms/listbox-selection.html
        https://bugs.webkit.org/show_bug.cgi?id=35786

        Changed to use script-tests style for improving portability.
        - For sending mouse events to the target element, calculating the
        item height at runtime instead using Mac-specific metrics.
        - Using mouseDown(), mouseUp(), and keyDown() to send events with
        modifier keys in a platform-independent way.

        * fast/forms/listbox-selection-expected.txt: Updated to match with new test.
        * fast/forms/listbox-selection.html: Modified to use script-tests style.
        * fast/forms/script-tests/listbox-selection.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-19 Balazs Kelemen <kb@inf.u-szeged.hu>
commit-queue@webkit.org [Fri, 20 Aug 2010 02:51:57 +0000 (02:51 +0000)]
2010-08-19  Balazs Kelemen  <kb@inf.u-szeged.hu>

        Reviewed by Antonio Gomes.

        [Qt] Fix cursor change propagation
        https://bugs.webkit.org/show_bug.cgi?id=44250

        No functional change so new tests.

        Propagate the setCursor callback to the PageClient via the HostWindow instead of preassuming
        the concrete type of the ChromeClient (what was generally wrong and actually incompatible with WebKit2).
        * platform/qt/WidgetQt.cpp:
        (WebCore::Widget::setCursor):
2010-08-19  Balazs Kelemen  <kb@inf.u-szeged.hu>

        Reviewed by Antonio Gomes.

        [Qt] Fix cursor change propagation
        https://bugs.webkit.org/show_bug.cgi?id=44250

        * WebCoreSupport/ChromeClientQt.cpp:
        (WebCore::ChromeClientQt::setCursor): Implemented. Propagete the callback forward to the PageClient.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-19 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Fri, 20 Aug 2010 01:22:32 +0000 (01:22 +0000)]
2010-08-19  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Tony Chang.

        dumpAsMarkup conversion: editing/pasteboard/4242293-1.html and editing/pasteboard/copy-paste-bidi.html
        https://bugs.webkit.org/show_bug.cgi?id=44220

        Converted the tests.

        * editing/pasteboard/4242293-1-expected.txt: Added.
        * editing/pasteboard/4242293-1.html:
        * editing/pasteboard/copy-paste-bidi-expected.txt: Added.
        * editing/pasteboard/copy-paste-bidi.html:
        * platform/chromium-linux/editing/pasteboard/4242293-1-expected.checksum: Removed.
        * platform/chromium-linux/editing/pasteboard/4242293-1-expected.png: Removed.
        * platform/chromium-linux/editing/pasteboard/copy-paste-bidi-expected.checksum: Removed.
        * platform/chromium-linux/editing/pasteboard/copy-paste-bidi-expected.png: Removed.
        * platform/chromium-win/editing/pasteboard/4242293-1-expected.checksum: Removed.
        * platform/chromium-win/editing/pasteboard/4242293-1-expected.png: Removed.
        * platform/chromium-win/editing/pasteboard/4242293-1-expected.txt: Removed.
        * platform/chromium-win/editing/pasteboard/copy-paste-bidi-expected.checksum: Removed.
        * platform/chromium-win/editing/pasteboard/copy-paste-bidi-expected.png: Removed.
        * platform/chromium-win/editing/pasteboard/copy-paste-bidi-expected.txt: Removed.
        * platform/mac-leopard/editing/pasteboard/4242293-1-expected.checksum: Removed.
        * platform/mac-leopard/editing/pasteboard/4242293-1-expected.png: Removed.
        * platform/mac-leopard/editing/pasteboard/copy-paste-bidi-expected.checksum: Removed.
        * platform/mac-leopard/editing/pasteboard/copy-paste-bidi-expected.png: Removed.
        * platform/mac/editing/pasteboard/4242293-1-expected.checksum: Removed.
        * platform/mac/editing/pasteboard/4242293-1-expected.png: Removed.
        * platform/mac/editing/pasteboard/4242293-1-expected.txt: Removed.
        * platform/mac/editing/pasteboard/copy-paste-bidi-expected.checksum: Removed.
        * platform/mac/editing/pasteboard/copy-paste-bidi-expected.png: Removed.
        * platform/mac/editing/pasteboard/copy-paste-bidi-expected.txt: Removed.
        * platform/qt/editing/pasteboard/4242293-1-expected.txt: Removed.
        * platform/qt/editing/pasteboard/copy-paste-bidi-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-19 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Fri, 20 Aug 2010 01:05:21 +0000 (01:05 +0000)]
2010-08-19  Martin Robinson  <mrobinson@igalia.com>

        [GTK] r65681 broke a couple GTK+ a11y tests
        https://bugs.webkit.org/show_bug.cgi?id=44316

        * platform/gtk/Skipped: Skip some newly failing tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-19 James Robinson <jamesr@chromium.org>
jamesr@google.com [Fri, 20 Aug 2010 00:58:06 +0000 (00:58 +0000)]
2010-08-19  James Robinson  <jamesr@chromium.org>

        Unreviewed. Clean up test_expectations now that tables/hittesting/filltable-* pass on Chromium.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-19 Kinuko Yasuda <kinuko@chromium.org>
kinuko@chromium.org [Fri, 20 Aug 2010 00:47:31 +0000 (00:47 +0000)]
2010-08-19  Kinuko Yasuda  <kinuko@chromium.org>

        Reviewed by Darin Fisher.

        Add WebKit API for FileSystem API
        https://bugs.webkit.org/show_bug.cgi?id=43151

        Add asynchronous FileSystem interface to WebKit API for
        FileSystem API.
        http://dev.w3.org/2009/dap/file-system/file-dir-sys.html

        * WebKit.gyp:
        * public/WebFileError.h: Added.
        * public/WebFileSystem.h: Added.
        * public/WebFileSystemEntry.h: Added.
        * public/WebFileSystemCallbacks.h: Added.
        * public/WebKitClient.h:
        (WebKit::WebKitClient::fileSystem):
        * public/WebFrameClient.h:
        (WebKit::WebFrameClient::openFileSystem):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-19 Vangelis Kokkevis <vangelis@chromium.org>
vangelis@chromium.org [Fri, 20 Aug 2010 00:46:30 +0000 (00:46 +0000)]
2010-08-19  Vangelis Kokkevis  <vangelis@chromium.org>

        Reviewed by Kenneth Russell.

        [chromium] Rearranging the accelerated compositing code such that the
        layer rendering logic now lives in the layer classes rather than the
        compositor. This lifts the restriction of having one texture per layer
        and significantly cleans up the compositor code. This change mostly
        resulted in a lot of code moving around files. Noteworthy changes
        include:
        * Made LayerChromium a proper based class for layers that mostly handles
          the updates to the layer properties and superlayer / sublayer updates.
        * Introduced a new layer type, ContentLayerChromium, which handles
          layers that require a GraphicsContext to render their content.
        * ImageLayerChromium and VideoLayerChromium now derive from
          ContentLayerChromium as they share the same shader and draw function.
        * Removed TransformLayerChromium as its functionality is now replaced by
          the base LayerChromium class.
        * Re-arranged the order in which the members of LayerChromium are defined
          in the header file to form a more reasonable logical grouping.
        * Changed LayerRendererChromium to use the shader creation and drawing
          methods defined in the layer classes. As a result, a lot of GL code was
          removed from the implementation file.
        * Eliminated randomly dispersed calls to check for GL errors by a macro (GLC)
          which allows turning error testing on/off with a single define (DEBUG_GL_CALLS
          defined in LayerRendererChromium.h)
        * Replaced the previous layer render loop with two traversals of the layer
          hierarchy, the first to update transforms and opacity values and the
          second to render the layers. Eliminated global Z sorting of all layers as
          it was wrong.
        https://bugs.webkit.org/show_bug.cgi?id=44148

        Test: Verified that pages using the compositor and compositor
              layout tests have not regressed.

        * WebCore.gypi:
        * platform/graphics/chromium/CanvasLayerChromium.cpp:
        (WebCore::CanvasLayerChromium::SharedValues::SharedValues):
        (WebCore::CanvasLayerChromium::SharedValues::~SharedValues):
        (WebCore::CanvasLayerChromium::updateContents):
        (WebCore::CanvasLayerChromium::draw):
        * platform/graphics/chromium/CanvasLayerChromium.h:
        (WebCore::CanvasLayerChromium::SharedValues::canvasShaderProgram):
        (WebCore::CanvasLayerChromium::SharedValues::shaderSamplerLocation):
        (WebCore::CanvasLayerChromium::SharedValues::shaderMatrixLocation):
        (WebCore::CanvasLayerChromium::SharedValues::shaderAlphaLocation):
        (WebCore::CanvasLayerChromium::SharedValues::initialized):
        * platform/graphics/chromium/ContentLayerChromium.cpp: Added.
        (WebCore::ContentLayerChromium::SharedValues::SharedValues):
        (WebCore::ContentLayerChromium::SharedValues::~SharedValues):
        (WebCore::ContentLayerChromium::create):
        (WebCore::ContentLayerChromium::ContentLayerChromium):
        (WebCore::ContentLayerChromium::~ContentLayerChromium):
        (WebCore::ContentLayerChromium::updateContents):
        (WebCore::ContentLayerChromium::updateTextureRect):
        (WebCore::ContentLayerChromium::draw):
        * platform/graphics/chromium/ContentLayerChromium.h: Added.
        (WebCore::ContentLayerChromium::drawsContent):
        (WebCore::ContentLayerChromium::SharedValues::contentShaderProgram):
        (WebCore::ContentLayerChromium::SharedValues::shaderSamplerLocation):
        (WebCore::ContentLayerChromium::SharedValues::shaderMatrixLocation):
        (WebCore::ContentLayerChromium::SharedValues::shaderAlphaLocation):
        (WebCore::ContentLayerChromium::SharedValues::initialized):
        * platform/graphics/chromium/GraphicsLayerChromium.cpp:
        (WebCore::GraphicsLayerChromium::GraphicsLayerChromium):
        (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
        * platform/graphics/chromium/ImageLayerChromium.cpp:
        (WebCore::ImageLayerChromium::ImageLayerChromium):
        (WebCore::ImageLayerChromium::updateContents):
        * platform/graphics/chromium/ImageLayerChromium.h:
        * platform/graphics/chromium/LayerChromium.cpp:
        (WebCore::loadShader):
        (WebCore::LayerChromium::SharedValues::SharedValues):
        (WebCore::LayerChromium::SharedValues::~SharedValues):
        (WebCore::LayerChromium::LayerChromium):
        (WebCore::LayerChromium::~LayerChromium):
        (WebCore::LayerChromium::createShaderProgram):
        (WebCore::LayerChromium::toGLMatrix):
        (WebCore::LayerChromium::drawTexturedQuad):
        (WebCore::LayerChromium::drawDebugBorder):
        (WebCore::LayerChromium::prepareForDraw):
        * platform/graphics/chromium/LayerChromium.h:
        (WebCore::LayerChromium::getSublayers):
        (WebCore::LayerChromium::setPosition):
        (WebCore::LayerChromium::contentsDirty):
        (WebCore::LayerChromium::drawsContent):
        (WebCore::LayerChromium::updateContents):
        (WebCore::LayerChromium::draw):
        (WebCore::LayerChromium::SharedValues::quadVerticesVbo):
        (WebCore::LayerChromium::SharedValues::quadElementsVbo):
        (WebCore::LayerChromium::SharedValues::maxTextureSize):
        (WebCore::LayerChromium::SharedValues::borderShaderProgram):
        (WebCore::LayerChromium::SharedValues::borderShaderMatrixLocation):
        (WebCore::LayerChromium::SharedValues::borderShaderColorLocation):
        (WebCore::LayerChromium::SharedValues::initialized):
        (WebCore::LayerChromium::layerRenderer):
        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::LayerRendererChromium):
        (WebCore::LayerRendererChromium::~LayerRendererChromium):
        (WebCore::LayerRendererChromium::debugGLCall):
        (WebCore::LayerRendererChromium::useShader):
        (WebCore::LayerRendererChromium::drawLayers):
        (WebCore::LayerRendererChromium::createLayerTexture):
        (WebCore::LayerRendererChromium::updateLayersRecursive):
        (WebCore::LayerRendererChromium::drawLayersRecursive):
        (WebCore::LayerRendererChromium::drawLayer):
        (WebCore::LayerRendererChromium::checkTextureSize):
        (WebCore::LayerRendererChromium::initializeSharedObjects):
        (WebCore::LayerRendererChromium::cleanupSharedObjects):
        * platform/graphics/chromium/LayerRendererChromium.h:
        (WebCore::LayerRendererChromium::projectionMatrix):
        (WebCore::LayerRendererChromium::layerSharedValues):
        (WebCore::LayerRendererChromium::contentLayerSharedValues):
        (WebCore::LayerRendererChromium::canvasLayerSharedValues):
        * platform/graphics/chromium/TransformLayerChromium.cpp: Removed.
        * platform/graphics/chromium/TransformLayerChromium.h: Removed.
        * platform/graphics/chromium/VideoLayerChromium.cpp:
        (WebCore::VideoLayerChromium::VideoLayerChromium):
        (WebCore::VideoLayerChromium::updateContents):
        (WebCore::VideoLayerChromium::createTextureRect):
        * platform/graphics/chromium/VideoLayerChromium.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-19 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 20 Aug 2010 00:40:14 +0000 (00:40 +0000)]
2010-08-19  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Sam Weinig.

        Clean up some selection code
        https://bugs.webkit.org/show_bug.cgi?id=44314

        Change the concept of "layout" in SelectionController to "updateCaretRect", renaming
        methods accordingly.

        Move selection and printing methods in RenderView.h into groups.

        No behavioral changes.

        * editing/SelectionController.cpp:
        (WebCore::SelectionController::SelectionController):
        (WebCore::SelectionController::setSelection):
        (WebCore::SelectionController::modify):
        (WebCore::SelectionController::setCaretRectNeedsUpdate):
        (WebCore::SelectionController::updateCaretRect):
        (WebCore::SelectionController::localCaretRect):
        (WebCore::SelectionController::recomputeCaretRect): Test m_caretRectNeedsUpdate first.
        (WebCore::SelectionController::invalidateCaretRect):
        * editing/SelectionController.h:
        * page/FrameView.cpp:
        (WebCore::FrameView::layout):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::scrollToOffset):
        * rendering/RenderView.h:
        (WebCore::RenderView::selectionStart):
        (WebCore::RenderView::selectionEnd):
        (WebCore::RenderView::printRect):
        (WebCore::RenderView::setPrintRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-19 Kinuko Yasuda <kinuko@chromium.org>
kinuko@chromium.org [Fri, 20 Aug 2010 00:03:17 +0000 (00:03 +0000)]
2010-08-19  Kinuko Yasuda  <kinuko@chromium.org>

        Reviewed by Jian Li.

        [Chromium] Rolls Chromium DEPS forward to 56564
        https://bugs.webkit.org/show_bug.cgi?id=44281

        Roll Chromium DEPS forward to 56564 to include WebFileSystem
        implementation changes.

        * DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-19 Fady Samuel <fsamuel@chromium.org>
commit-queue@webkit.org [Thu, 19 Aug 2010 23:39:13 +0000 (23:39 +0000)]
2010-08-19  Fady Samuel  <fsamuel@chromium.org>

        Reviewed by Dimitri Glazkov.

        Fixed table hit testing layout test issues
        https://bugs.webkit.org/show_bug.cgi?id=44204

        Moved expectations to the same directory as tests.
        Expectations were failing due to inconsistent eventSender behavior:
        Switched to using elementFromPoint

        * platform/gtk/tables/hittesting/filltable-emptycells-expected.txt: Removed.
        * platform/gtk/tables/hittesting/filltable-levels-expected.txt: Removed.
        * platform/gtk/tables/hittesting/filltable-outline-expected.txt: Removed.
        * platform/gtk/tables/hittesting/filltable-rtl-expected.txt: Removed.
        * platform/gtk/tables/hittesting/filltable-stress-expected.txt: Removed.
        * tables/hittesting/filltable-emptycells-expected.txt: Renamed from LayoutTests/platform/chromium-linux/tables/hittesting/filltable-emptycells-expected.txt.
        * tables/hittesting/filltable-emptycells.html:
        * tables/hittesting/filltable-levels-expected.txt: Renamed from LayoutTests/platform/chromium-linux/tables/hittesting/filltable-levels-expected.txt.
        * tables/hittesting/filltable-levels.html:
        * tables/hittesting/filltable-outline-expected.txt: Renamed from LayoutTests/platform/chromium-linux/tables/hittesting/filltable-outline-expected.txt.
        * tables/hittesting/filltable-outline.html:
        * tables/hittesting/filltable-rtl-expected.txt: Renamed from LayoutTests/platform/chromium-linux/tables/hittesting/filltable-rtl-expected.txt.
        * tables/hittesting/filltable-rtl.html:
        * tables/hittesting/filltable-stress-expected.txt: Renamed from LayoutTests/platform/chromium-linux/tables/hittesting/filltable-stress-expected.txt.
        * tables/hittesting/filltable-stress.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBUILD FIX: Fix Mac build after Windows WebKit2 changes for Netscape Plug-ins
ddkilzer@apple.com [Thu, 19 Aug 2010 22:52:40 +0000 (22:52 +0000)]
BUILD FIX: Fix Mac build after Windows WebKit2 changes for Netscape Plug-ins

WebCore:

* WebCore.exp.in:
(WebCore::ScrollView::contentsToWindow): Added export.

WebKit2:

* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::NetscapePlugin::platformPaint): Changed frameRect() to
m_frameRect.

WebKitTools:

* MiniBrowser/mac/BrowserWindowController.m:
(decidePolicyForNavigationAction): Updated method signature.
(decidePolicyForNewWindowAction): Updated method signature.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-19 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 19 Aug 2010 22:35:24 +0000 (22:35 +0000)]
2010-08-19  Adam Barth  <abarth@webkit.org>

        Reviewed by Alexey Proskuryakov.

        <style> inside <noscript> is parsed when JavaScript is enabled.
        https://bugs.webkit.org/show_bug.cgi?id=44021

        More random bugs fixed by the HTML5 parser.  Time to document with a
        couple tests.  I added both these tests because <noscript> in <body> is
        slightly different than <noscript> before <body>.

        * fast/parser/no-style-in-noscript-expected.txt: Added.
        * fast/parser/no-style-in-noscript-with-body-expected.txt: Added.
        * fast/parser/no-style-in-noscript-with-body.html: Added.
        * fast/parser/no-style-in-noscript.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBUILD FIX #3: <http://webkit.org/b/44285> Fix compilation with NETSCAPE_PLUGIN_API...
ddkilzer@apple.com [Thu, 19 Aug 2010 22:09:41 +0000 (22:09 +0000)]
BUILD FIX #3: <webkit.org/b/44285> Fix compilation with NETSCAPE_PLUGIN_API disabled

Still trying to make Qt Linux Release minimal buildbot happy.

WebCore:

* plugins/PluginViewNone.cpp: Compile missing methods for Qt.

WebKit/qt:

* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::createPlugin): Wrap code that
handles Netscape plugins in #if ENABLE(NETSCAPE_PLUGIN_API)
and #endif.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-19 Sam Weinig <sam@webkit.org>
johnnyg@google.com [Thu, 19 Aug 2010 21:59:07 +0000 (21:59 +0000)]
2010-08-19  Sam Weinig  <sam@webkit.org>

        Rubber-stamped by Jon Honeycutt.

        Add a few items in the WebKitTestRunner Skipped list.

        * platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd a few items in the WebKitTestRunner Skipped list.
weinig@apple.com [Thu, 19 Aug 2010 21:41:13 +0000 (21:41 +0000)]
Add a few items in the WebKitTestRunner Skipped list.

Rubber-stamped by Jon Honeycutt.

* platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBUILD FIX: FrameLoaderClientQt.h should include ResourceError.h
ddkilzer@apple.com [Thu, 19 Aug 2010 21:32:45 +0000 (21:32 +0000)]
BUILD FIX: FrameLoaderClientQt.h should include ResourceError.h

* WebCoreSupport/FrameLoaderClientQt.h: Include ResourceError.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBUILD FIX: <http://webkit.org/b/44285> Fix compilation with NETSCAPE_PLUGIN_API disabled
ddkilzer@apple.com [Thu, 19 Aug 2010 21:25:37 +0000 (21:25 +0000)]
BUILD FIX: <webkit.org/b/44285> Fix compilation with NETSCAPE_PLUGIN_API disabled

Reviewed by Joseph Pecoraro.

* plugins/PluginView.cpp: Added #if ENABLE(NETSCAPE_PLUGIN_API)
and #endif macros around the source to fix the Qt Linux Release
Minimal build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoSend mouse events to windowless plugins on Windows
aroben@apple.com [Thu, 19 Aug 2010 21:23:12 +0000 (21:23 +0000)]
Send mouse events to windowless plugins on Windows

This seems to have been the last issue blocking us from playing videos
on vimeo.com.

Fixes <http://webkit.org/b/44276> <rdar://problem/8330398> Can't click
play button in vimeo.com Flash video player in WebKit2 on Windows

Reviewed by Sam Weinig.

* WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
(WebKit::toNP): Added. Converts a WebMouseEvent to an NPEvent. Code
was adapted from WebCore's PluginViewWin.cpp.

(WebKit::NetscapePlugin::platformHandleMouseEvent):
(WebKit::NetscapePlugin::platformHandleMouseEnterEvent):
(WebKit::NetscapePlugin::platformHandleMouseLeaveEvent):
Convert the WebMouseEvent to an NPEvent and send it to the plugin.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd support for painting windowless plugins on Windows
aroben@apple.com [Thu, 19 Aug 2010 21:22:52 +0000 (21:22 +0000)]
Add support for painting windowless plugins on Windows

This gets the video on the front page of vimeo.com painting (though
you can't make it play because we don't support mouse events yet).

Fixes <http://webkit.org/b/44274> <rdar://problem/8330398> Windowless
plugins don't paint in WebKit2 on Windows

Reviewed by Sam Weinig.

* WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::NPN_GetValue): Tell the plugin that we support windowless
mode on Windows.
(WebKit::NPN_SetValue): Implemented handling of NPPVpluginWindowBool
by calling through to NetscapePlugin::setIsWindowed.

* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::NetscapePlugin): Added initialization of
m_isWindowed. It defaults to false on Mac and true on other platforms,
matching WebCore's PluginView.

* WebProcess/Plugins/Netscape/NetscapePlugin.h: Added m_isWindowed.
(WebKit::NetscapePlugin::setIsWindowed): Added standard setter.

* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::NetscapePlugin::platformPaint): Moved Mac-specific context
translation code here from PluginView::paint.

* WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
(WebKit::NetscapePlugin::platformPaint): Implemented. Code was ported
from WebCore's PluginViewWin.cpp.

* WebProcess/Plugins/Plugin.h: Updated the comment for Plugin::paint
to explain the coordinate system of the context.

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::paint): Changed to translate the context from
document to window coordinates. We were previously trying to translate
to plugin-local coordinates, but this only worked for documents whose
origin was the same as the window's origin (i.e., the main frame). The
plugin takes care of any further translations needed. (Mac translates
the context into plugin-local coordinates, and Windows leaves it in
window coordinates.)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoImplement PluginInfoStore::pluginsDirectories
aroben@apple.com [Thu, 19 Aug 2010 21:22:32 +0000 (21:22 +0000)]
Implement PluginInfoStore::pluginsDirectories

This makes WebKit2 able to find and load Flash on Windows.

Note that we aren't yet respecting the MozillaPlugins registry key.
That's covered by <http://webkit.org/b/44271>.

Fixes <http://webkit.org/b/43510> <rdar://problem/8273827> WebKit2
should load plugins from the same directories as old-WebKit

Reviewed by Jon Honeycutt and Ada Chan.

* UIProcess/Plugins/win/PluginInfoStoreWin.cpp:
(WebKit::parseVersionString):
(WebKit::compareVersions):
(WebKit::safariPluginsDirectory):
(WebKit::addMozillaPluginDirectories):
(WebKit::addWindowsMediaPlayerPluginDirectory):
(WebKit::addQuickTimePluginDirectory):
(WebKit::addAdobeAcrobatPluginDirectory):
(WebKit::addMacromediaPluginDirectories):
(WebKit::PluginInfoStore::pluginsDirectories):
Ported (and ever-so-slightly cleaned up) code from WebCore's
PluginDatabaseWin.cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoCall NP_GetEntryPoints before NP_Initialize on Windows
aroben@apple.com [Thu, 19 Aug 2010 21:22:13 +0000 (21:22 +0000)]
Call NP_GetEntryPoints before NP_Initialize on Windows

Doing otherwise will cause Flash and QuickTime to crash inside
NP_Initialize.

Fixes <http://webkit.org/b/44270> <rdar://problem/8330393> Crash in
NP_Initialize when loading QuickTime when running
plugins/embed-attributes-setting.html in WebKit2 on Windows

Reviewed by Sam Weinig.

WebKit2:

* WebProcess/Plugins/Netscape/NetscapePluginModule.cpp:
(WebKit::NetscapePluginModule::tryLoad): On Windows, first call
NP_GetEntryPoints, then NP_Initialize. Do the reverse on Mac to
prevent Silverlight (e.g.) from crashing (see r38858).

WebKitTools:

Test that NP_Initialize and NP_GetEntryPoints are called in the
correct order

The order differs between Mac and Windows (see r38858).

* DumpRenderTree/TestNetscapePlugIn/main.cpp: Added a CRASH macro and
a boolean to record whether NP_GetEntryPoints has been called.
(NP_Initialize): Crash on Windows if NP_GetEntryPoints hasn't been
called yet. This matches Flash and QuickTime's behavior. Crash on Mac
if NP_GetEntryPoints has been called already. This matches
Silverlight's behavior.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd NetscapePluginWin.cpp
aroben@apple.com [Thu, 19 Aug 2010 21:21:54 +0000 (21:21 +0000)]
Add NetscapePluginWin.cpp

Fixes <http://webkit.org/b/44269> <rdar://problem/8330391>
NetscapePlugin.h contains functions that should be in
NetscapePluginWin.cpp

Reviewed by Sam Weinig.

* WebProcess/Plugins/Netscape/NetscapePlugin.h: Moved functions from
here...
* WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp: ...to here.

* win/WebKit2.vcproj: Added NetscapePluginWin.cpp and let VS reorder
the file list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoMake build-webkittestrunner build TestNetscapePlugIn on Windows
aroben@apple.com [Thu, 19 Aug 2010 21:21:32 +0000 (21:21 +0000)]
Make build-webkittestrunner build TestNetscapePlugIn on Windows

Fixes <http://webkit.org/b/44268> <rdar://problem/8330388>

Reviewed by Sam Weinig.

* WebKitTestRunner/WebKitTestRunner.sln: Added TestNetscapePlugIn.
Threaded it in between ImageDiff and InjectedBundleGenerated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-19 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Thu, 19 Aug 2010 21:13:15 +0000 (21:13 +0000)]
2010-08-19  Stephen White  <senorblanco@chromium.org>

        Reviewed by Kenneth Russell.

        [CHROMIUM] Assert w/canvas image draw
        https://bugs.webkit.org/show_bug.cgi?id=44279

        Don't use bitmap->pixelRef()->getPixels() directly; prefer
        bitmap->pixels() and an SkAutoLockPixels.  Also, make sure to set
        the backing store state to Software when it was None.  This handles
        missing draws when the first call is software.  Finally, remove some
        spurious prepareForSoftwareDraw() calls in addPath() and beginPath().
        It's really the fillPath() or strokePath() that matters.

        Covered by LayoutTests/fast/canvas/arc360.html and others.

        * platform/graphics/skia/GraphicsContextSkia.cpp:
        (WebCore::GraphicsContext::addPath):
        (WebCore::GraphicsContext::beginPath):
        Remove spurious prepareForSoftwareDraw() calls.
        * platform/graphics/skia/ImageSkia.cpp:
        (WebCore::drawBitmapGLES2):
        Lock SkBitmap's pixels, and use ->getPixels().
        * platform/graphics/skia/PlatformContextSkia.cpp:
        (WebCore::PlatformContextSkia::prepareForSoftwareDraw):
        Switch backing store state to Software when it was None.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd modifier key info to policy client functions in WebKit2
weinig@apple.com [Thu, 19 Aug 2010 21:09:18 +0000 (21:09 +0000)]
Add modifier key info to policy client functions in WebKit2
<rdar://problem/8185298>
https://bugs.webkit.org/show_bug.cgi?id=44280

Reviewed by Adam Roben.

* UIProcess/API/C/WKAPICast.h:
Add conversion function for modifiers and rename an incorrectly named
toWK to toRef.

* UIProcess/API/C/WKPage.h:
Add WKEventModifiers enum.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::decidePolicyForNewWindowAction):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPolicyClient.cpp:
(WebKit::WebPolicyClient::decidePolicyForNavigationAction):
(WebKit::WebPolicyClient::decidePolicyForNewWindowAction):
* UIProcess/WebPolicyClient.h:
Pipe through modifier info.

* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::modifiersForNavigationAction):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
Get modifier info out of the NavigationInfo class in the same manner as
WebKit1.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-19 Andreas Kling <andreas.kling@nokia.com>
andreas.kling@nokia.com [Thu, 19 Aug 2010 21:03:38 +0000 (21:03 +0000)]
2010-08-19  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Geoffrey Garen.

        JSC: Move the static_cast into to(U)Int32 fast case
        https://bugs.webkit.org/show_bug.cgi?id=44037

        Do the static_cast<(u)int32_t> inline to avoid the function call overhead
        for easily converted values (within (u)int32_t range.)

        * runtime/JSValue.cpp:
        (JSC::toInt32SlowCase):
        (JSC::toUInt32SlowCase):
        * runtime/JSValue.h:
        (JSC::JSValue::toInt32):
        (JSC::JSValue::toUInt32):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago<http://webkit.org/b/44285> Fix compilation with NETSCAPE_PLUGIN_API disabled
ddkilzer@apple.com [Thu, 19 Aug 2010 20:51:28 +0000 (20:51 +0000)]
<webkit.org/b/44285> Fix compilation with NETSCAPE_PLUGIN_API disabled

Reviewed by Joseph Pecoraro.

WebCore:

* WebCore.exp.in:
(WebCore::HTMLPlugInElement::getNPObject): Moved from general
section into ENABLE(NETSCAPE_PLUGIN_API) section.
(WebCore::FrameView::windowClipRectForLayer): Moved from
ENABLE(NETSCAPE_PLUGIN_API) section to general section since
it's used by WebKit2.
* plugins/PluginView.h: Added #if ENABLE(NETSCAPE_PLUGIN_API)
and #endif macros as needed to make iOS WebKit build with
NETSCAPE_PLUGIN_API disabled.
* plugins/PluginViewNone.cpp: Ditto.
(WebCore::PluginView::platformGetValueStatic):

WebKit/mac:

* Plugins/Hosted/HostedNetscapePluginStream.mm: Changed
USE(PLUGIN_HOST_PROCESS) to
USE(PLUGIN_HOST_PROCESS) && ENABLE(NETSCAPE_PLUGIN_API).
* Plugins/Hosted/NetscapePluginHostManager.mm: Ditto.
* Plugins/Hosted/NetscapePluginHostProxy.mm: Ditto.
* Plugins/Hosted/NetscapePluginInstanceProxy.mm: Ditto.
* Plugins/Hosted/ProxyInstance.mm: Ditto.
* Plugins/Hosted/WebHostedNetscapePluginView.mm: Ditto.
* WebCoreSupport/WebChromeClient.mm: Ditto.
(WebChromeClient::createWindow):
* WebCoreSupport/WebFrameLoaderClient.mm: Ditto.
(WebFrameLoaderClient::dispatchCreatePage):
* WebView/WebHTMLView.mm:
(needsCursorRectsSupportAtPoint): Added #if
ENABLE(NETSCAPE_PLUGIN_API) and #endif macros as needed.
* WebView/WebView.mm:
(+[WebView _isNodeHaltedPlugin:]): Ditto.
(+[WebView _hasPluginForNodeBeenHalted:]): Ditto.
(+[WebView _restartHaltedPluginForNode:]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-19 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Thu, 19 Aug 2010 20:46:40 +0000 (20:46 +0000)]
2010-08-19  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        install rietveld's upload script from a versioned url
        https://bugs.webkit.org/show_bug.cgi?id=44291

        autoinstall expects the file at a given URL to never change.
        In order to be able to update the file, we need to be able to
        change the path.

        * Scripts/webkitpy/thirdparty/__init__.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-19 John Gregg <johnnyg@google.com>
johnnyg@google.com [Thu, 19 Aug 2010 20:16:02 +0000 (20:16 +0000)]
2010-08-19  John Gregg  <johnnyg@google.com>

        Unreviewed, chromium test expectations.

        Add expected failures for caret-based pixel tests.  See bug 44290.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-19 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Thu, 19 Aug 2010 20:04:22 +0000 (20:04 +0000)]
2010-08-19  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        add --webkit_patch_id to reitveld uploads
        https://bugs.webkit.org/show_bug.cgi?id=44289

        This is the first step in having rietveld store which
        patches have been uploaded and getting rid of the
        in-rietveld flag.

        * Scripts/webkitpy/common/net/rietveld.py:
        * Scripts/webkitpy/tool/mocktool.py:
        * Scripts/webkitpy/tool/steps/postcodereview.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-19 John Gregg <johnnyg@google.com>
johnnyg@google.com [Thu, 19 Aug 2010 19:48:21 +0000 (19:48 +0000)]
2010-08-19  John Gregg  <johnnyg@google.com>

        Unreviewed, chromium rebaselines.

        Add new baselines after http://trac.webkit.org/changeset/65665/

        * platform/chromium-linux/svg/custom/pattern-rotate-expected.checksum: Added.
        * platform/chromium-linux/svg/custom/pattern-rotate-expected.png: Added.
        * platform/chromium-linux/svg/transforms: Added.
        * platform/chromium-linux/svg/transforms/text-with-pattern-inside-transformed-html-expected.checksum: Added.
        * platform/chromium-linux/svg/transforms/text-with-pattern-inside-transformed-html-expected.png: Added.
        * platform/chromium-linux/svg/transforms/text-with-pattern-with-svg-transform-expected.checksum: Added.
        * platform/chromium-linux/svg/transforms/text-with-pattern-with-svg-transform-expected.png: Added.
        * platform/chromium-win/svg/custom/pattern-rotate-expected.checksum:
        * platform/chromium-win/svg/custom/pattern-rotate-expected.png:
        * platform/chromium-win/svg/transforms/text-with-pattern-inside-transformed-html-expected.checksum:
        * platform/chromium-win/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
        * platform/chromium-win/svg/transforms/text-with-pattern-with-svg-transform-expected.checksum:
        * platform/chromium-win/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
        * platform/chromium/test_expectations.txt

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-16 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 19 Aug 2010 19:32:02 +0000 (19:32 +0000)]
2010-08-16  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Make DocumentParser safer to use
        https://bugs.webkit.org/show_bug.cgi?id=43055

        This also includes a test from
        https://bugs.webkit.org/show_bug.cgi?id=42099

        These tests were kindly provided by Nate Chapin and Adam Barth.

        * fast/frames/document-write-in-iframe-onload-expected.txt: Copied from LayoutTests/editing/selection/5136696-expected.txt.
        * fast/frames/document-write-in-iframe-onload.html: Added.
        * fast/frames/resources/set-src-to-javascript-url.html: Added.
        * fast/frames/set-parent-src-synchronously-expected.txt: Added.
        * fast/frames/set-parent-src-synchronously.html: Added.
        * fast/parser/document-close-iframe-load-expected.txt: Added.
        * fast/parser/document-close-iframe-load.html: Added.
        * fast/parser/document-close-nested-iframe-load-expected.txt: Added.
        * fast/parser/document-close-nested-iframe-load.html: Added.
        * fast/parser/iframe-sets-parent-to-javascript-url-expected.txt: Added.
        * fast/parser/iframe-sets-parent-to-javascript-url.html: Added.
        * fast/parser/resources/set-parent-to-javascript-url.html: Added.
2010-08-17  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Make DocumentParser safer to use
        https://bugs.webkit.org/show_bug.cgi?id=43055

        Make DocumentParser and its subclasses RefCounted, and protect
        HTMLDocumentParser during parsing. It's possible for a parser to
        get deleted if certain actions (e.g., a document.write()) occur
        synchronously.

        The original version of this patch was written by Nate Chapin.

        DocumentParser doesn't actually have to be fully RefCounted, since
        the only two things which should ever hold a reference to it are
        Document and DocumentParser itself.  However using RefCounted and
        RefPtr was easier/cleaner than inventing a custom ref() scheme.

        This deploys a new "detach()" method throughout the parsing
        framework.  detach() causes the parser to disconnect from the
        document so that no further modifications will be made to the
        document while any possible DocumentParser stacks are unwound.

        The irony of this patch is that the new detach() system is never
        used, since Document always outlives the DocumentParser in all of
        our layout tests.  There is an ASSERT in ~Document() to verify
        that the DocumentParser will not outlive the Document.

        However I expect that we will soon either find new test cases, or change
        the architecture in such a way that DocumentParser will outlive
        Document.  At which point, the detach() plumbing will be crucial.
        Right now detach() serves as a safe-guard against use-after-free bugs
        for any case where DocumentParser does outlive the Document.

        This also fixes test cases attached to:
        https://bugs.webkit.org/show_bug.cgi?id=42099

        Tests: fast/frames/document-write-in-iframe-onload.html
               fast/frames/set-parent-src-synchronously.html
               fast/parser/document-close-iframe-load.html
               fast/parser/document-close-nested-iframe-load.html
               fast/parser/iframe-sets-parent-to-javascript-url.html

        * dom/Document.cpp:
         - Added a new detachParser() call to be used anywhere we
           used to call m_parser.clear().
           There is an ASSERT in ~DocumentParser which ensures that
           we get this right.
        (WebCore::Document::removedLastRef):
        (WebCore::Document::~Document):
        (WebCore::Document::createParser):
        (WebCore::Document::detachParser):
        (WebCore::Document::cancelParsing):
        (WebCore::Document::implicitOpen):
         - removed redundant m_parser.clear()
        (WebCore::Document::implicitClose):
        * dom/Document.h:
        * dom/DocumentParser.cpp:
        (WebCore::DocumentParser::~DocumentParser):
         - ASSERT that callers always call detach() before destruction.
         - This ASSERT might prove too cumbersome, but for now it's useful.
        (WebCore::DocumentParser::detach):
        * dom/DocumentParser.h:
        * dom/RawDataDocumentParser.h:
        * dom/XMLDocumentParser.cpp:
        (WebCore::XMLDocumentParser::finish):
         - Add a FIXME explaining part of the reason why
           stopParsing() and detach() are separate concepts.
        * dom/XMLDocumentParser.h:
        (WebCore::XMLDocumentParser::create):
        * dom/XMLDocumentParserLibxml2.cpp:
        (WebCore::XMLDocumentParser::parseDocumentFragment):
        * dom/XMLDocumentParserQt.cpp:
        (WebCore::XMLDocumentParser::parseDocumentFragment):
        * html/HTMLConstructionSite.cpp:
        (WebCore::HTMLConstructionSite::detach):
        (WebCore::HTMLConstructionSite::dispatchDocumentElementAvailableIfNeeded):
        * html/HTMLConstructionSite.h:
        * html/HTMLDocument.cpp:
        (WebCore::HTMLDocument::createParser):
        * html/HTMLDocument.h:
        * html/HTMLDocumentParser.cpp:
         - We need to protect(this) before calling into any code
           which might cause the parser to be destroyed.
        (WebCore::HTMLDocumentParser::~HTMLDocumentParser):
        (WebCore::HTMLDocumentParser::detach):
        (WebCore::HTMLDocumentParser::resumeParsingAfterYield):
        (WebCore::HTMLDocumentParser::pumpTokenizer):
        (WebCore::HTMLDocumentParser::insert):
        (WebCore::HTMLDocumentParser::append):
        (WebCore::HTMLDocumentParser::end):
        (WebCore::HTMLDocumentParser::finish):
        (WebCore::HTMLDocumentParser::notifyFinished):
        (WebCore::HTMLDocumentParser::executeScriptsWaitingForStylesheets):
        (WebCore::HTMLDocumentParser::parseDocumentFragment):
        * html/HTMLDocumentParser.h:
        (WebCore::HTMLDocumentParser::create):
        * html/HTMLScriptRunner.cpp:
        (WebCore::HTMLScriptRunner::detach):
        (WebCore::HTMLScriptRunner::executeParsingBlockingScript):
        (WebCore::HTMLScriptRunner::executeScript):
        (WebCore::HTMLScriptRunner::executeScriptsWaitingForStylesheets):
        (WebCore::HTMLScriptRunner::runScript):
        * html/HTMLScriptRunner.h:
        * html/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::detach):
        (WebCore::HTMLTreeBuilder::passTokenToLegacyParser):
        (WebCore::HTMLTreeBuilder::finished):
        * html/HTMLTreeBuilder.h:
        * html/HTMLViewSourceDocument.cpp:
        (WebCore::HTMLViewSourceDocument::createParser):
        * html/HTMLViewSourceDocument.h:
        * html/HTMLViewSourceParser.cpp:
        (WebCore::HTMLViewSourceParser::HTMLViewSourceParser):
        * html/HTMLViewSourceParser.h:
        (WebCore::HTMLViewSourceParser::create):
        * loader/FTPDirectoryDocument.cpp:
        (WebCore::FTPDirectoryDocumentParser::create):
        (WebCore::FTPDirectoryDocument::createParser):
        * loader/FTPDirectoryDocument.h:
        * loader/ImageDocument.cpp:
        (WebCore::ImageDocumentParser::create):
        (WebCore::ImageDocumentParser::ImageDocumentParser):
        (WebCore::ImageDocument::createParser):
        * loader/ImageDocument.h:
        * loader/MediaDocument.cpp:
        (WebCore::MediaDocumentParser::create):
        (WebCore::MediaDocument::createParser):
        * loader/MediaDocument.h:
        * loader/PluginDocument.cpp:
        (WebCore::PluginDocumentParser::create):
        (WebCore::PluginDocument::createParser):
        * loader/PluginDocument.h:
        * loader/SinkDocument.cpp:
        (WebCore::SinkDocumentParser::create):
        (WebCore::SinkDocument::createParser):
        * loader/SinkDocument.h:
        * loader/TextDocument.cpp:
        (WebCore::TextDocumentParser::create):
        (WebCore::TextDocument::createParser):
        (WebCore::createTextDocumentParser):
        * loader/TextDocument.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix compilation of SelectElement.cpp with ARROW_KEYS_POP_MENU == 0
ddkilzer@apple.com [Thu, 19 Aug 2010 19:29:11 +0000 (19:29 +0000)]
Fix compilation of SelectElement.cpp with ARROW_KEYS_POP_MENU == 0

Reviewed by Simon Fraser.

* dom/SelectElement.cpp:
(WebCore::SelectElement::menuListDefaultEventHandler): Added
UNUSED_PARAM() macro for htmlForm argument when
ARROW_KEYS_POP_MENU defined as zero.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-19 Laszlo Gombos <laszlo.1.gombos@nokia.com>
laszlo.1.gombos@nokia.com [Thu, 19 Aug 2010 19:07:27 +0000 (19:07 +0000)]
2010-08-19  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Disable XSLT for production configuration
        https://bugs.webkit.org/show_bug.cgi?id=37445

        Introduce a new CONFIG option to maintain stable configuration for
        the QtWebKit port and disable XSLT for the stable configuration
        because of bug 37445.

        No new tests as there is no new functionality.

        * features.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-18 Zhenyao Mo <zmo@google.com>
zmo@google.com [Thu, 19 Aug 2010 18:59:21 +0000 (18:59 +0000)]
2010-08-18  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        Implement strict type checking in js bindings for WebGL functions
        https://bugs.webkit.org/show_bug.cgi?id=44202

        Test: fast/canvas/webgl/bad-arguments-test.html

        * bindings/js/JSWebGLRenderingContextCustom.cpp: Add type check for wrapper types and DOMString and throw error in case of mismatch.
        (WebCore::JSWebGLRenderingContext::getAttachedShaders):
        (WebCore::JSWebGLRenderingContext::getProgramParameter):
        (WebCore::JSWebGLRenderingContext::getShaderParameter):
        (WebCore::JSWebGLRenderingContext::getUniform):
        (WebCore::dataFunctionf):
        (WebCore::dataFunctioni):
        (WebCore::dataFunctionMatrix):
        * bindings/scripts/CodeGeneratorJS.pm: Ditto.
        * bindings/scripts/CodeGeneratorV8.pm: Ditto.
        * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp: Ditto.
        (WebCore::V8WebGLRenderingContext::getAttachedShadersCallback):
        (WebCore::V8WebGLRenderingContext::getProgramParameterCallback):
        (WebCore::V8WebGLRenderingContext::getShaderParameterCallback):
        (WebCore::V8WebGLRenderingContext::getUniformCallback):
        (WebCore::vertexAttribAndUniformHelperf):
        (WebCore::uniformHelperi):
        (WebCore::uniformMatrixHelper):
        * html/canvas/WebGLRenderingContext.idl: Add attribute StrictTypeChecking for WebGL functions.
2010-08-18  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        Implement strict type checking in js bindings for WebGL functions
        https://bugs.webkit.org/show_bug.cgi?id=44202

        * fast/canvas/webgl/bad-arguments-test-expected.txt: Added.
        * fast/canvas/webgl/bad-arguments-test.html: Added.
        * fast/canvas/webgl/error-reporting-expected.txt: Fix bugs due to strict type checking in the js bindings.
        * fast/canvas/webgl/error-reporting.html: ditto.
        * fast/canvas/webgl/gl-object-get-calls-expected.txt: ditto.
        * fast/canvas/webgl/gl-object-get-calls.html: ditto.
        * fast/canvas/webgl/null-object-behaviour-expected.txt: ditto.
        * fast/canvas/webgl/null-object-behaviour.html: ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-19 Vincent Scheib <scheib@chromium.org>
commit-queue@webkit.org [Thu, 19 Aug 2010 18:45:39 +0000 (18:45 +0000)]
2010-08-19  Vincent Scheib  <scheib@chromium.org>

        Reviewed by David Levin.

        Fixing previous Mac only build breakage with TilingDataTest.cpp
        https://bugs.webkit.org/show_bug.cgi?id=44223

        TilingDataTest.cpp included the wrong header, which had a compile
        option around the definition of the WebCore namespace. Without the
        namespace defined, error. Fixed by correctly including TilingData.h,
        which has no conditional compilation.

        * WebKit.gyp:
        * tests/TilingDataTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-19 John Gregg <johnnyg@google.com>
johnnyg@google.com [Thu, 19 Aug 2010 18:44:54 +0000 (18:44 +0000)]
2010-08-19  John Gregg  <johnnyg@google.com>

        Unreviewed, test expectations.

        Add some new exceptions for SVG failures, see
        https://bugs.webkit.org/show_bug.cgi?id=44278

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-19 Tony Chang <tony@chromium.org>
tony@chromium.org [Thu, 19 Aug 2010 18:28:29 +0000 (18:28 +0000)]
2010-08-19  Tony Chang  <tony@chromium.org>

        Reviewed by Adam Barth.

        webkit-patch barfed on upload with a new image test result
        https://bugs.webkit.org/show_bug.cgi?id=39097

        * PrettyPatch/PrettyPatch.rb: don't use full path to git

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-19 Kenneth Russell <kbr@google.com>
kbr@google.com [Thu, 19 Aug 2010 18:25:14 +0000 (18:25 +0000)]
2010-08-19  Kenneth Russell  <kbr@google.com>

        Reviewed by David Levin.

        Adjust my status from committer to reviewer
        https://bugs.webkit.org/show_bug.cgi?id=44277

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-19 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Thu, 19 Aug 2010 18:13:53 +0000 (18:13 +0000)]
2010-08-19  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Simon Fraser.

        https://bugs.webkit.org/show_bug.cgi?id=33671
        media/video-loop.html fails intermittently on GTK and Chromium bots

        Rewrite test to make it less timing dependent.

        * media/video-loop-expected.txt:
        * media/video-loop.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-19 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 19 Aug 2010 17:56:38 +0000 (17:56 +0000)]
2010-08-19  Simon Fraser  <simon.fraser@apple.com>

        Fix Chromium build.

        * svg/SVGElement.cpp:
        (WebCore::SVGElement::attributeChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-19 John Gregg <johnnyg@google.com>
johnnyg@google.com [Thu, 19 Aug 2010 17:35:53 +0000 (17:35 +0000)]
2010-08-19  John Gregg  <johnnyg@google.com>

        Unreviewed; test expectations.

        Update chromium-mac expectations for zoom-mask-with-percentages.svg after
        http://trac.webkit.org/changeset/65665/

        * platform/chromium-mac/svg/zoom/page/zoom-mask-with-percentages-expected.checksum:
        * platform/chromium-mac/svg/zoom/page/zoom-mask-with-percentages-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-19 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 19 Aug 2010 17:19:40 +0000 (17:19 +0000)]
2010-08-19  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Nikolas Zimmermann.

        HTMLElement::isContentEditable() can cause an updateStyleIfNeeded() to happen in the middle of layout
        https://bugs.webkit.org/show_bug.cgi?id=21834
        <rdar://problem/8093653&8261394>

        If we're in the middle of layout, or painting, and something causes updateStyleIfNeeded() to
        get called, then we can end up entering recalcStyle() during layout or painting. This is bad
        because it can create/destry the renderers and RenderLayers which are in use by layout/painting.
        This is the cause of a number of random crashers, some of which show up more frequently
        in content which uses accelerated compositing.

        The changes here:
        1. Add an assertion in Document::updateStyleIfNeeded() that we are not laying out or painting.
        2. Remove calls to updateStyleIfNeeded() in editing and caret painting code
        3. Pass along information to CTM and BBox-related SVG methods to indicate whether it's safe
           to update style.

        Tested by new assertions and existing tests.

        * dom/Document.cpp:
        (WebCore::Document::updateStyleIfNeeded): New assertion that we are not mid-layout or painting.
        (WebCore::command): Call updateStyleIfNeeded() to ensure that subsequent calls to isContentEditable()
        return the correct result.

        * dom/Element.cpp:
        (WebCore::Element::focus): Move the supportsFocus() call to after style has been updated.

        * editing/SelectionController.cpp:
        (WebCore::SelectionController::localCaretRect):
        (WebCore::SelectionController::caretRepaintRect):
        (WebCore::SelectionController::paintCaret):
        * editing/SelectionController.h:
        (WebCore::SelectionController::localCaretRectForPainting): When painting, use localCaretRectForPainting()
        which does not update style. Make localCaretRect() non-const so allowing it to update style without ugly casts.

        * html/HTMLElement.cpp:
        (WebCore::HTMLElement::isContentEditable): Don't call updateStyleIfNeeded() here.
        (WebCore::HTMLElement::isContentRichlyEditable): Ditto.
        (WebCore::HTMLElement::contentEditable): Ditto.

        * page/FrameView.h:
        (WebCore::FrameView::isMidLayout): New accessor, used for asserting.

        * rendering/RenderPath.cpp:
        (WebCore::fillAndStrokePath): Pass DisallowStyleUpdate to getScreenCTM since we are painting.
        * rendering/RenderSVGResourceContainer.cpp:
        (WebCore::RenderSVGResourceContainer::transformOnNonScalingStroke): This is only called when
        painting, so use DisallowStyleUpdate.

        * svg/SVGElement.cpp:
        (WebCore::SVGElement::attributeChanged): Changes to the style attribute should not have
        side effects, since a call to Element::getAttribute() is allowed to result in a call to
        setAttribute() for the style attribute. To avoid updateStyleIfNeeded() during painting,
        this must not cause SVG to do extra work.

        * svg/SVGLocatable.cpp: Pass StyleUpdateStrategy down to these methods to indicate
        whether it's OK to update style.
        (WebCore::SVGLocatable::getBBox):
        (WebCore::SVGLocatable::computeCTM):
        (WebCore::SVGLocatable::getTransformToElement):
        * svg/SVGLocatable.h:
        (WebCore::SVGLocatable::):
        * svg/SVGStyledLocatableElement.cpp:
        (WebCore::SVGStyledLocatableElement::getBBox):
        (WebCore::SVGStyledLocatableElement::getCTM):
        (WebCore::SVGStyledLocatableElement::getScreenCTM):
        * svg/SVGStyledLocatableElement.h:
        * svg/SVGStyledTransformableElement.cpp:
        (WebCore::SVGStyledTransformableElement::getCTM):
        (WebCore::SVGStyledTransformableElement::getScreenCTM):
        (WebCore::SVGStyledTransformableElement::getBBox):
        * svg/SVGStyledTransformableElement.h:
        * svg/SVGTextElement.cpp:
        (WebCore::SVGTextElement::getBBox):
        (WebCore::SVGTextElement::getCTM):
        (WebCore::SVGTextElement::getScreenCTM):
        * svg/SVGTextElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-19 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 19 Aug 2010 17:16:09 +0000 (17:16 +0000)]
2010-08-19  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        Range, EAnnotateForInterchange, and EAbsoluteURLs should be member variables of MarkupAccumulator
        https://bugs.webkit.org/show_bug.cgi?id=44229

        No new tests are added since this is a clean up.

        * editing/markup.cpp:
        (WebCore::MarkupAccumulator::MarkupAccumulator): Added shouldResolveURLs, shouldAnnotate, and range.
        (WebCore::MarkupAccumulator::shouldResolveURLs): Private inline accessor for m_shouldResolveURLs.
        (WebCore::MarkupAccumulator::shouldAnnotate): Private inline accessor for m_shouldAnnotate.
        (WebCore::MarkupAccumulator::appendEndTag): Renamed local variable result to markup.
        (WebCore::MarkupAccumulator::appendStartTag): Removed range, annotate, shouldResolveURLs from the function arguments.
        (WebCore::MarkupAccumulator::wrapWithNode): Ditto.
        (WebCore::MarkupAccumulator::appendStartMarkup): Ditto.
        (WebCore::serializeNodes): Ditto and uses MarkupAccumulator.
        (WebCore::createMarkup): Uses MarkupAccumulator.
        (WebCore::serializeNodesWithNamespaces): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-19 Tony Chang <tony@chromium.org>
tony@chromium.org [Thu, 19 Aug 2010 17:04:26 +0000 (17:04 +0000)]
2010-08-19  Tony Chang  <tony@chromium.org>

        Unreviewed, setting svn:eol-style native on ChangeLog.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-19 Tony Chang <tony@chromium.org>
tony@chromium.org [Thu, 19 Aug 2010 16:54:38 +0000 (16:54 +0000)]
2010-08-19  Tony Chang  <tony@chromium.org>

        Unreviewed.  Just removing \r's from ChangeLog.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-19 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 19 Aug 2010 16:46:10 +0000 (16:46 +0000)]
2010-08-19  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: do not dump inspector errors into the inspected window console.
        https://bugs.webkit.org/show_bug.cgi?id=44272

        * inspector/front-end/inspector.js:
        (WebInspector.reportProtocolError):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-19 Jochen Eisinger <jochen@chromium.org>
jochen@chromium.org [Thu, 19 Aug 2010 16:11:04 +0000 (16:11 +0000)]
2010-08-19  Jochen Eisinger  <jochen@chromium.org>

        Reviewed by Pavel Feldman.

        concatenated_devtools_js should depend on inspector_protocol_sources
        https://bugs.webkit.org/show_bug.cgi?id=44255

        * WebKit.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd ability to get all the keys from a WKDictionaryRef
weinig@apple.com [Thu, 19 Aug 2010 15:47:52 +0000 (15:47 +0000)]
Add ability to get all the keys from a WKDictionaryRef
https://bugs.webkit.org/show_bug.cgi?id=44221

Reviewed by Adam Roben.

* Shared/ImmutableDictionary.cpp:
(WebKit::ImmutableDictionary::keys):
* Shared/ImmutableDictionary.h:
Add keys function.

* UIProcess/API/C/WKDictionary.cpp:
(WKDictionaryCopyKeys):
* UIProcess/API/C/WKDictionary.h:
Wrap keys function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-19 Pavel Podivilov <podivilov@chromium.org>
commit-queue@webkit.org [Thu, 19 Aug 2010 15:44:35 +0000 (15:44 +0000)]
2010-08-19  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: activate/deactivate breakpoints using v8 debugger flag.
        https://bugs.webkit.org/show_bug.cgi?id=44112

        * src/js/DebuggerScript.js:
        ():

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-19 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Thu, 19 Aug 2010 15:19:53 +0000 (15:19 +0000)]
2010-08-19  Jeremy Orlow  <jorlow@chromium.org>

        Chromium build fix.

        Use ASSERT_UNUSED on variables that aren't used besides by the ASSERT.

        * storage/IDBDatabaseBackendImpl.cpp:
        (WebCore::IDBDatabaseBackendImpl::createObjectStore):
        (WebCore::IDBDatabaseBackendImpl::removeObjectStore):
        (WebCore::IDBDatabaseBackendImpl::loadObjectStores):
        * storage/IDBObjectStoreBackendImpl.cpp:
        (WebCore::IDBObjectStoreBackendImpl::get):
        (WebCore::IDBObjectStoreBackendImpl::put):
        (WebCore::IDBObjectStoreBackendImpl::remove):
        (WebCore::IDBObjectStoreBackendImpl::createIndex):
        (WebCore::IDBObjectStoreBackendImpl::removeIndex):
        (WebCore::IDBObjectStoreBackendImpl::openCursor):
        (WebCore::IDBObjectStoreBackendImpl::loadIndexes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-19 Andrey Kosyakov <caseq@chromium.org>
commit-queue@webkit.org [Thu, 19 Aug 2010 15:06:05 +0000 (15:06 +0000)]
2010-08-19  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: expose Panel.onSelectionChanged in extension API
        https://bugs.webkit.org/show_bug.cgi?id=44171

        * inspector/extensions-api-expected.txt:
        * inspector/extensions-expected.txt:
2010-08-19  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: expose Panel.onSelectionChanged in extension API
        https://bugs.webkit.org/show_bug.cgi?id=44171

        * inspector/front-end/ExtensionAPI.js:
        (injectedExtensionAPI.PanelImpl):
        (injectedExtensionAPI):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-19 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 19 Aug 2010 15:04:57 +0000 (15:04 +0000)]
2010-08-19  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Chromium DevTools: remove injected script fetcher from test harness.
        https://bugs.webkit.org/show_bug.cgi?id=44266

        * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
        * DumpRenderTree/chromium/DRTDevToolsAgent.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-19 Andrei Popescu <andreip@google.com>
andreip@google.com [Thu, 19 Aug 2010 14:53:51 +0000 (14:53 +0000)]
2010-08-19  Andrei Popescu  <andreip@google.com>

        Reviewed by Jeremy Orlow.

        [IndexedDB] Abort idle IDBTransactions when the JS context they were created in finishes execution.
        https://bugs.webkit.org/show_bug.cgi?id=44101

        * storage/indexeddb/resources/shared.js:
        (unexpectedErrorCallback):
        * storage/indexeddb/script-tests/transaction-basics.js: Added.
        (abortCallback):
        (createTransactionCallback):
        (test):
        * storage/indexeddb/transaction-basics-expected.txt: Added.
        * storage/indexeddb/transaction-basics.html: Added.
2010-08-19  Andrei Popescu  <andreip@google.com>

        Reviewed by Jeremy Orlow.

        [IndexedDB] Abort idle IDBTransactions when the JS context they were created in finishes execution.
        https://bugs.webkit.org/show_bug.cgi?id=44101

        This change also introduces the TransactionCoordinator, which will be used
        to schedule transactions for execution.

        Test: storage/indexeddb/transaction-basics.html

        * WebCore.gypi:
        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::convertEventTargetToV8Object):
        * bindings/v8/V8Proxy.cpp:
        (WebCore::V8Proxy::runScript):
        (WebCore::V8Proxy::callFunction):
        (WebCore::V8Proxy::didLeaveScriptContext):
        * bindings/v8/V8Proxy.h:
        * dom/EventTarget.cpp:
        (WebCore::EventTarget::toIDBTransaction):
        * dom/EventTarget.h:
        * page/PageGroup.h:
        (WebCore::PageGroup::hasIDBFactory):
        * storage/IDBAbortEvent.cpp: Added.
        (WebCore::IDBAbortEvent::create):
        (WebCore::IDBAbortEvent::IDBAbortEvent):
        (WebCore::IDBAbortEvent::~IDBAbortEvent):
        * storage/IDBAbortEvent.h: Added.
        (WebCore::IDBAbortEvent::isIDBAbortEvent):
        * storage/IDBDatabase.cpp:
        (WebCore::IDBDatabase::transaction):
        * storage/IDBDatabaseBackendImpl.cpp:
        (WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):
        (WebCore::IDBDatabaseBackendImpl::transaction):
        * storage/IDBDatabaseBackendImpl.h:
        (WebCore::IDBDatabaseBackendImpl::create):
        * storage/IDBDatabaseBackendInterface.h:
        * storage/IDBFactoryBackendImpl.cpp:
        (WebCore::IDBFactoryBackendImpl::IDBFactoryBackendImpl):
        (WebCore::IDBFactoryBackendImpl::open):
        (WebCore::IDBFactoryBackendImpl::abortPendingTransactions):
        * storage/IDBFactoryBackendImpl.h:
        * storage/IDBFactoryBackendInterface.h:
        * storage/IDBPendingTransactionMonitor.cpp: Added.
        (WebCore::IDBPendingTransactionMonitor::addPendingTransaction):
        (WebCore::IDBPendingTransactionMonitor::removePendingTransaction):
        (WebCore::IDBPendingTransactionMonitor::clearPendingTransactions):
        (WebCore::IDBPendingTransactionMonitor::pendingTransactions):
        * storage/IDBPendingTransactionMonitor.h: Added.
        * storage/IDBTransaction.cpp:
        (WebCore::IDBTransaction::IDBTransaction):
        (WebCore::IDBTransaction::onAbort):
        (WebCore::IDBTransaction::id):
        (WebCore::IDBTransaction::stop):
        (WebCore::IDBTransaction::timerFired):
        * storage/IDBTransaction.h:
        * storage/IDBTransactionBackendInterface.h:
        * storage/IDBTransactionCallbacks.h: Added.
        (WebCore::IDBTransactionCallbacks::~IDBTransactionCallbacks):
        * storage/IDBTransactionCoordinator.cpp: Added.
        (WebCore::IDBTransactionBackendImpl::~IDBTransactionBackendImpl):
        (WebCore::IDBTransactionBackendImpl::create):
        (WebCore::IDBTransactionBackendImpl::IDBTransactionBackendImpl):
        (WebCore::IDBTransactionBackendImpl::objectStore):
        (WebCore::IDBTransactionBackendImpl::mode):
        (WebCore::IDBTransactionBackendImpl::scheduleTask):
        (WebCore::IDBTransactionBackendImpl::abort):
        (WebCore::IDBTransactionBackendImpl::sqliteDatabase):
        (WebCore::IDBTransactionBackendImpl::id):
        (WebCore::IDBTransactionBackendImpl::setCallbacks):
        (WebCore::IDBTransactionCoordinator::IDBTransactionCoordinator):
        (WebCore::IDBTransactionCoordinator::~IDBTransactionCoordinator):
        (WebCore::IDBTransactionCoordinator::createTransaction):
        (WebCore::IDBTransactionCoordinator::abort):
        * storage/IDBTransactionCoordinator.h: Added.
        (WebCore::IDBTransactionCoordinator::create):
2010-08-19  Andrei Popescu  <andreip@google.com>

        Reviewed by Jeremy Orlow.

        [IndexedDB] Abort idle IDBTransactions when the JS context they were created in finishes execution.
        https://bugs.webkit.org/show_bug.cgi?id=44101

        * WebKit.gyp:
        * public/WebIDBDatabase.h:
        (WebKit::WebIDBDatabase::transaction):
        * public/WebIDBFactory.h:
        (WebKit::WebIDBFactory::abortPendingTransactions):
        * public/WebIDBTransaction.h: Added.
        (WebKit::WebIDBTransaction::~WebIDBTransaction):
        (WebKit::WebIDBTransaction::mode):
        (WebKit::WebIDBTransaction::objectStore):
        (WebKit::WebIDBTransaction::abort):
        (WebKit::WebIDBTransaction::id):
        (WebKit::WebIDBTransaction::setCallbacks):
        * public/WebIDBTransactionCallbacks.h: Added.
        (WebKit::WebIDBTransactionCallbacks::~WebIDBTransactionCallbacks):
        (WebKit::WebIDBTransactionCallbacks::onAbort):
        (WebKit::WebIDBTransactionCallbacks::id):
        * src/IDBDatabaseProxy.cpp:
        (WebCore::IDBDatabaseProxy::transaction):
        * src/IDBFactoryBackendProxy.cpp:
        (WebCore::IDBFactoryBackendProxy::abortPendingTransactions):
        * src/IDBFactoryBackendProxy.h:
        * src/IDBTransactionBackendProxy.cpp: Added.
        (WebCore::IDBTransactionBackendProxy::create):
        (WebCore::IDBTransactionBackendProxy::IDBTransactionBackendProxy):
        (WebCore::IDBTransactionBackendProxy::~IDBTransactionBackendProxy):
        (WebCore::IDBTransactionBackendProxy::objectStore):
        (WebCore::IDBTransactionBackendProxy::mode):
        (WebCore::IDBTransactionBackendProxy::abort):
        (WebCore::IDBTransactionBackendProxy::scheduleTask):
        (WebCore::IDBTransactionBackendProxy::sqliteDatabase):
        (WebCore::IDBTransactionBackendProxy::id):
        (WebCore::IDBTransactionBackendProxy::setCallbacks):
        * src/IDBTransactionBackendProxy.h: Added.
        * src/IDBTransactionCallbacksProxy.cpp: Added.
        (WebCore::IDBTransactionCallbacksProxy::create):
        (WebCore::IDBTransactionCallbacksProxy::IDBTransactionCallbacksProxy):
        (WebCore::IDBTransactionCallbacksProxy::~IDBTransactionCallbacksProxy):
        (WebCore::IDBTransactionCallbacksProxy::onAbort):
        (WebCore::IDBTransactionCallbacksProxy::id):
        * src/IDBTransactionCallbacksProxy.h: Added.
        * src/WebDOMStringList.cpp:
        (WebKit::WebDOMStringList::length):
        * src/WebIDBDatabaseImpl.cpp:
        (WebKit::WebIDBDatabaseImpl::transaction):
        * src/WebIDBDatabaseImpl.h:
        * src/WebIDBFactoryImpl.cpp:
        (WebKit::WebIDBFactoryImpl::abortPendingTransactions):
        * src/WebIDBFactoryImpl.h:
        * src/WebIDBTransactionCallbacksImpl.cpp: Added.
        (WebCore::WebIDBTransactionCallbacksImpl::WebIDBTransactionCallbacksImpl):
        (WebCore::WebIDBTransactionCallbacksImpl::~WebIDBTransactionCallbacksImpl):
        (WebCore::WebIDBTransactionCallbacksImpl::onAbort):
        (WebCore::WebIDBTransactionCallbacksImpl::id):
        * src/WebIDBTransactionCallbacksImpl.h: Added.
        * src/WebIDBTransactionImpl.cpp: Added.
        (WebKit::WebIDBTransactionImpl::WebIDBTransactionImpl):
        (WebKit::WebIDBTransactionImpl::~WebIDBTransactionImpl):
        (WebKit::WebIDBTransactionImpl::mode):
        (WebKit::WebIDBTransactionImpl::objectStore):
        (WebKit::WebIDBTransactionImpl::abort):
        (WebKit::WebIDBTransactionImpl::id):
        (WebKit::WebIDBTransactionImpl::setCallbacks):
        * src/WebIDBTransactionImpl.h: Added.
        (WebKit::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-19 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 19 Aug 2010 14:47:59 +0000 (14:47 +0000)]
2010-08-19  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Chromium DevTools: There is no need in resource-based InjectedScript.js source.
        Now that we populate front-end after its onload handler, we don't need
        to install injected script early. Exposing injected script source on the WebCore
        level here.
        https://bugs.webkit.org/show_bug.cgi?id=44029

        * inspector/InjectedScriptHost.h:
        (WebCore::InjectedScriptHost::injectedScriptSource):
2010-08-19  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Chromium DevTools: There is no need in resource-based InjectedScript.js source.
        Now that we populate front-end after its onload handler, I don't think we need
        to install injected script early.
        https://bugs.webkit.org/show_bug.cgi?id=44029

        * public/WebDevToolsAgentClient.h:
        * src/WebDevToolsAgentImpl.cpp:
        (WebKit::):
        (WebKit::WebDevToolsAgentImpl::attach):
        (WebKit::WebDevToolsAgentImpl::frontendLoaded):
2010-08-19  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Chromium DevTools: There is no need in resource-based InjectedScript.js source.
        Now that we populate front-end after its onload handler, we don't need
        to install injected script early. Exposing injected script source on the WebCore
        level here.
        https://bugs.webkit.org/show_bug.cgi?id=44029

        * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
        (DRTDevToolsAgent::runtimePropertyChanged):
        (DRTDevToolsAgent::delayedFrontendLoaded):
        (DRTDevToolsAgent::frontendLoaded):
        * DumpRenderTree/chromium/DRTDevToolsAgent.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Inject wmode=opaque for both QWebView and QGraphicsWebView on Maemo5
girish@forwardbias.in [Thu, 19 Aug 2010 14:47:23 +0000 (14:47 +0000)]
[Qt] Inject wmode=opaque for both QWebView and QGraphicsWebView on Maemo5
as Flash XEmbed support is flaky.

https://bugs.webkit.org/show_bug.cgi?id=44043

Reviewed by Kenneth Christiansen.

* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::createPlugin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-18 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Thu, 19 Aug 2010 14:38:34 +0000 (14:38 +0000)]
2010-08-18  Jeremy Orlow  <jorlow@chromium.org>

        Implement persistance for IndexedDB ObjectStores
        https://bugs.webkit.org/show_bug.cgi?id=44164

        Remove old object stores before running test.

        * storage/indexeddb/resources/shared.js:
        (deleteAllObjectStores):
        * storage/indexeddb/script-tests/objectstore-basics.js:
        (openSuccess):
        * storage/indexeddb/script-tests/open-cursor.js:
        (openSuccess):
2010-08-18  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Steve Block.

        Implement persistance for IndexedDB ObjectStores
        https://bugs.webkit.org/show_bug.cgi?id=44164

        Get rid of the in-memory storage of ObjectStores and instead
        use SQL backed memory.

        Existing tests give most of the coverage.  Will update the manual
        test in the next patch (which will also re-work database.description).

        * manual-tests/indexed-database.html: Get rid of race where you can click before the page loads.
        * platform/sql/SQLiteStatement.cpp: Add two helper functions
        (WebCore::SQLiteStatement::bindInt):
        (WebCore::SQLiteStatement::isColumnNull):
        * platform/sql/SQLiteStatement.h:
        * storage/IDBCursorBackendImpl.cpp:
        * storage/IDBDatabaseBackendImpl.cpp:
        (WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):
        (WebCore::IDBDatabaseBackendImpl::createObjectStore):
        (WebCore::IDBDatabaseBackendImpl::removeObjectStore):
        (WebCore::IDBDatabaseBackendImpl::importObjectStores):
        * storage/IDBDatabaseBackendImpl.h:
        (WebCore::IDBDatabaseBackendImpl::sqliteDatabase):
        * storage/IDBFactoryBackendImpl.cpp:
        (WebCore::createTables):
        * storage/IDBIndexBackendImpl.cpp:
        (WebCore::IDBIndexBackendImpl::IDBIndexBackendImpl):
        (WebCore::IDBIndexBackendImpl::sqliteDatabase):
        * storage/IDBIndexBackendImpl.h:
        (WebCore::IDBIndexBackendImpl::create):
        * storage/IDBObjectStoreBackendImpl.cpp:
        (WebCore::IDBObjectStoreBackendImpl::IDBObjectStoreBackendImpl):
        (WebCore::whereClause):
        (WebCore::bindKey):
        (WebCore::IDBObjectStoreBackendImpl::get):
        (WebCore::IDBObjectStoreBackendImpl::put):
        (WebCore::IDBObjectStoreBackendImpl::remove):
        (WebCore::IDBObjectStoreBackendImpl::createIndex):
        (WebCore::IDBObjectStoreBackendImpl::removeIndex):
        (WebCore::IDBObjectStoreBackendImpl::openCursor):
        (WebCore::IDBObjectStoreBackendImpl::importIndexes):
        (WebCore::IDBObjectStoreBackendImpl::sqliteDatabase):
        * storage/IDBObjectStoreBackendImpl.h:
        (WebCore::IDBObjectStoreBackendImpl::create):
        (WebCore::IDBObjectStoreBackendImpl::database):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoLayoutTests
kov@webkit.org [Thu, 19 Aug 2010 13:30:53 +0000 (13:30 +0000)]
LayoutTests

2010-08-19  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Kenneth Rohde Christiansen.

        [Gtk] Enable view mode media feature layout test
        https://bugs.webkit.org/show_bug.cgi?id=43278

        Unskip tests that are now passing.

        * platform/gtk/Skipped:

WebKit/gtk

2010-08-19  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Kenneth Rohde Christiansen.

        [Gtk] Enable view mode media feature layout test
        https://bugs.webkit.org/show_bug.cgi?id=43278

        Add the view-mode property, to control the WebCore page's viewMode.

        * docs/webkitgtk-sections.txt:
        * webkit/webkitwebview.cpp:
        (webkit_web_view_get_property):
        (webkit_web_view_set_property):
        (webkit_web_view_class_init):
        (webkit_web_view_set_view_mode):
        (webkit_web_view_get_view_mode):
        * webkit/webkitwebview.h:

WebKitTools

2010-08-19  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Kenneth Rohde Christiansen.

        [Gtk] Enable view mode media feature layout test
        https://bugs.webkit.org/show_bug.cgi?id=43278

        Add view mode media feature testing infrastructure, and add
        placeholder methods for the other platforms'
        LayoutTestControllers.

        * DumpRenderTree/LayoutTestController.cpp:
        (setViewModeMediaFeatureCallback):
        (LayoutTestController::staticFunctions):
        * DumpRenderTree/LayoutTestController.h:
        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::setViewModeMediaFeature):
        * DumpRenderTree/mac/LayoutTestControllerMac.mm:
        (LayoutTestController::setViewModeMediaFeature):
        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
        (LayoutTestController::setViewModeMediaFeature):
        * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
        (LayoutTestController::setViewModeMediaFeature):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-19 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Thu, 19 Aug 2010 12:41:23 +0000 (12:41 +0000)]
2010-08-19  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        Pattern is rasterized
        https://bugs.webkit.org/show_bug.cgi?id=41396

        SVG pattern size changed when resizing browser
        https://bugs.webkit.org/show_bug.cgi?id=38704

        Incorrect pattern tilling
        https://bugs.webkit.org/show_bug.cgi?id=41603

        Apply same fixes to <pattern> that <mask> recently received. Build the tile image in absolute coordinates,
        to avoid pixelation, when the target element is scaled. Also fixes problems when zooming into patterns.

        Clamp ImageBuffer sizes to RenderSVGRoots viewport, now that gradient/pattern and mask buffers are created
        in absolute coordinates -> no more huge image buffer allocations, that could fail.

        Drop overflow="visible" support for <pattern>, which complicates the code a lot. Neither Opera nor Firefox
        support this, and SVG 1.1 2nd Edition says that the rendering behaviour is "undefined".

        Tests: svg/batik/paints/patternRegions-positioned-objects.svg
               svg/custom/pattern-incorrect-tiling.svg
               svg/custom/pattern-no-pixelation.svg
               svg/transforms/text-with-mask-with-svg-transform.svg

        * rendering/PaintInfo.h:
        (WebCore::PaintInfo::applyTransform): Don't alter the repaint rect if it's infinite (only affects SVG).
        (WebCore::PaintInfo::infiniteRect): Moved from RenderLayer into PaintInfo, as applyTransform() needs it.
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::calculateClipRects): s/ClipRects::infiniteRect/PaintInfo::infiniteRect/
        * rendering/RenderLayer.h: Moved infiniteRect() to PaintInfo.
        * rendering/RenderLayerBacking.cpp:
        (WebCore::clipBox): s/ClipRects::infiniteRect/PaintInfo::infiniteRect/
        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::clippedByAncestor): Ditto.
        * rendering/RenderSVGResourceGradient.cpp:
        (WebCore::createMaskAndSwapContextForTextGradient): Clamp image buffer size, use new SVGImageBufferTools helper methods for that.
        (WebCore::clipToTextMask): Adapt to renames/code changes in SVGImageBufferTools.
        (WebCore::RenderSVGResourceGradient::applyResource): Ditto.
        * rendering/RenderSVGResourceMasker.cpp:
        (WebCore::RenderSVGResourceMasker::applyResource): lamp image buffer size, use new SVGImageBufferTools helper methods for that.
        (WebCore::RenderSVGResourceMasker::drawContentIntoMaskImage): Adapt to renames/code changes in SVGImageBufferTools.
        * rendering/RenderSVGResourceMasker.h:
        * rendering/RenderSVGResourcePattern.cpp:
        (WebCore::RenderSVGResourcePattern::applyResource): Rewrite to create tile image buffers in absolute coordinates, avoids pixelation artefacts.
        (WebCore::calculatePatternBoundaries):
        (WebCore::RenderSVGResourcePattern::buildTileImageTransform):
        (WebCore::RenderSVGResourcePattern::createTileImage):
        * rendering/RenderSVGResourcePattern.h:
        * rendering/SVGImageBufferTools.cpp:
        (WebCore::SVGImageBufferTools::transformationToOutermostSVGCoordinateSystem): Helper method, concating all localToParentTransforms() up until RenderSVGRoot is reached.
        (WebCore::SVGImageBufferTools::createImageBuffer): Simplified.
        (WebCore::SVGImageBufferTools::clipToImageBuffer): Rename absoluteTargetRect to clampedAbsoluteTargetRect.
        (WebCore::SVGImageBufferTools::roundedImageBufferSize): New helper method to centralize FloatSize -> IntSize rounding, when creating image buffers.
        (WebCore::SVGImageBufferTools::clampedAbsoluteTargetRectForRenderer): New helper methods to clamp an image buffer rect against the viewport.
        * rendering/SVGImageBufferTools.h:
        * rendering/SVGRenderSupport.cpp:
        (WebCore::SVGRenderSupport::renderSubtreeToImage): Use PaintInfo::infiniteRect() as repaint rect, to avoid any culling.
        (WebCore::SVGRenderSupport::findTreeRootObject): Renamed from svgRootTreeObject, and expose it.
        (WebCore::SVGRenderSupport::layoutChildren): s/svgRootTreeObject/findTreeRootObject/.
        * rendering/SVGRenderSupport.h:
        * svg/SVGSVGElement.cpp:
        (WebCore::SVGSVGElement::setCurrentTranslate): Be sure to relayout on invalidation, otherwhise resources are not updated, and we have to update them, as they depend on the absolute transform.

2010-08-19  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        Pattern is rasterized
        https://bugs.webkit.org/show_bug.cgi?id=41396

        SVG pattern size changed when resizing browser
        https://bugs.webkit.org/show_bug.cgi?id=38704

        Incorrect pattern tilling
        https://bugs.webkit.org/show_bug.cgi?id=41603

        Update pattern results after fixing the pixelation issues.

        * platform/mac-leopard/svg/batik/paints/patternRegions-expected.checksum:
        * platform/mac-leopard/svg/batik/paints/patternRegions-expected.png:
        * platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.checksum:
        * platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png:
        * platform/mac/svg/batik/paints/patternRegions-positioned-objects-expected.checksum: Added.
        * platform/mac/svg/batik/paints/patternRegions-positioned-objects-expected.png: Added.
        * platform/mac/svg/batik/paints/patternRegions-positioned-objects-expected.txt: Added.
        * platform/mac/svg/batik/text/textEffect3-expected.checksum:
        * platform/mac/svg/batik/text/textEffect3-expected.png:
        * platform/mac/svg/custom/absolute-sized-content-with-resources-expected.checksum:
        * platform/mac/svg/custom/absolute-sized-content-with-resources-expected.png:
        * platform/mac/svg/custom/grayscale-gradient-mask-expected.checksum:
        * platform/mac/svg/custom/grayscale-gradient-mask-expected.png:
        * platform/mac/svg/custom/js-late-gradient-and-object-creation-expected.checksum:
        * platform/mac/svg/custom/js-late-gradient-and-object-creation-expected.png:
        * platform/mac/svg/custom/js-late-gradient-creation-expected.checksum:
        * platform/mac/svg/custom/js-late-gradient-creation-expected.png:
        * platform/mac/svg/custom/js-late-pattern-and-object-creation-expected.checksum:
        * platform/mac/svg/custom/js-late-pattern-and-object-creation-expected.png:
        * platform/mac/svg/custom/js-late-pattern-creation-expected.checksum:
        * platform/mac/svg/custom/js-late-pattern-creation-expected.png:
        * platform/mac/svg/custom/non-scaling-stroke-expected.checksum:
        * platform/mac/svg/custom/non-scaling-stroke-expected.png:
        * platform/mac/svg/custom/pattern-incorrect-tiling-expected.checksum: Added.
        * platform/mac/svg/custom/pattern-incorrect-tiling-expected.png: Added.
        * platform/mac/svg/custom/pattern-incorrect-tiling-expected.txt: Added.
        * platform/mac/svg/custom/pattern-no-pixelation-expected.checksum: Added.
        * platform/mac/svg/custom/pattern-no-pixelation-expected.png: Added.
        * platform/mac/svg/custom/pattern-no-pixelation-expected.txt: Added.
        * platform/mac/svg/custom/pattern-rotate-expected.checksum:
        * platform/mac/svg/custom/pattern-rotate-expected.png:
        * platform/mac/svg/custom/stroked-pattern-expected.checksum:
        * platform/mac/svg/custom/stroked-pattern-expected.png:
        * platform/mac/svg/custom/text-rotated-gradient-expected.checksum:
        * platform/mac/svg/custom/text-rotated-gradient-expected.png:
        * platform/mac/svg/dynamic-updates/SVGMaskElement-dom-height-attr-expected.checksum:
        * platform/mac/svg/dynamic-updates/SVGMaskElement-dom-height-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGMaskElement-dom-maskContentUnits-attr-expected.checksum:
        * platform/mac/svg/dynamic-updates/SVGMaskElement-dom-maskContentUnits-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGMaskElement-dom-width-attr-expected.checksum:
        * platform/mac/svg/dynamic-updates/SVGMaskElement-dom-width-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGMaskElement-dom-x-attr-expected.checksum:
        * platform/mac/svg/dynamic-updates/SVGMaskElement-dom-x-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGMaskElement-dom-y-attr-expected.checksum:
        * platform/mac/svg/dynamic-updates/SVGMaskElement-dom-y-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-height-prop-expected.checksum:
        * platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-height-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-maskContentUnits-prop-expected.checksum:
        * platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-maskContentUnits-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-width-prop-expected.checksum:
        * platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-width-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-x-prop-expected.checksum:
        * platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-x-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-y-prop-expected.checksum:
        * platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-y-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGPatternElement-dom-patternContentUnits-attr-expected.checksum:
        * platform/mac/svg/dynamic-updates/SVGPatternElement-dom-patternContentUnits-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGPatternElement-svgdom-patternContentUnits-prop-expected.checksum:
        * platform/mac/svg/dynamic-updates/SVGPatternElement-svgdom-patternContentUnits-prop-expected.png:
        * platform/mac/svg/text/selection-background-color-expected.checksum:
        * platform/mac/svg/text/selection-background-color-expected.png:
        * platform/mac/svg/transforms/text-with-mask-with-svg-transform-expected.checksum: Added.
        * platform/mac/svg/transforms/text-with-mask-with-svg-transform-expected.png: Added.
        * platform/mac/svg/transforms/text-with-mask-with-svg-transform-expected.txt: Added.
        * platform/mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.checksum:
        * platform/mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
        * platform/mac/svg/transforms/text-with-pattern-with-svg-transform-expected.checksum:
        * platform/mac/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
        * platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.checksum:
        * platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.png:
        * svg/batik/paints/patternRegions-positioned-objects.svg: Added.
        * svg/custom/pattern-incorrect-tiling.svg: Added.
        * svg/custom/pattern-no-pixelation.svg: Added.
        * svg/transforms/text-with-mask-with-svg-transform.svg: Added.
        * svg/transforms/text-with-pattern-inside-transformed-html.xhtml:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed.
ossy@webkit.org [Thu, 19 Aug 2010 12:35:36 +0000 (12:35 +0000)]
Unreviewed.

[Qt] Add platform specific expected results for new passing tests.
Compared to Mac png files and Mac expected files.

* platform/qt/fast/canvas/setWidthResetAfterForcedRender-expected.checksum: Added.
* platform/qt/fast/canvas/setWidthResetAfterForcedRender-expected.png: Added.
* platform/qt/fast/canvas/setWidthResetAfterForcedRender-expected.txt: Added.
* platform/qt/fast/table/early-table-layout-expected.checksum: Added.
* platform/qt/fast/table/early-table-layout-expected.png: Added.
* platform/qt/fast/table/early-table-layout-expected.txt: Added.
* platform/qt/http/tests/misc/slow-loading-image-in-pattern-expected.checksum: Added.
* platform/qt/http/tests/misc/slow-loading-image-in-pattern-expected.png: Added.
* platform/qt/http/tests/misc/slow-loading-image-in-pattern-expected.txt: Added.
* platform/qt/svg/W3C-SVG-1.1/filters-turb-02-f-expected.checksum: Added.
* platform/qt/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png: Added.
* platform/qt/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt: Added.
* platform/qt/svg/custom/absolute-sized-content-with-resources-expected.checksum: Added.
* platform/qt/svg/custom/absolute-sized-content-with-resources-expected.png: Added.
* platform/qt/svg/custom/absolute-sized-content-with-resources-expected.txt: Added.
* platform/qt/svg/custom/js-update-stop-linked-gradient-expected.checksum: Added.
* platform/qt/svg/custom/js-update-stop-linked-gradient-expected.png: Added.
* platform/qt/svg/custom/js-update-stop-linked-gradient-expected.txt: Added.
* platform/qt/svg/in-html: Added.
* platform/qt/svg/in-html/circle-expected.checksum: Added.
* platform/qt/svg/in-html/circle-expected.png: Added.
* platform/qt/svg/in-html/circle-expected.txt: Added.
* platform/qt/svg/zoom/page/zoom-mask-with-percentages-expected.checksum: Added.
* platform/qt/svg/zoom/page/zoom-mask-with-percentages-expected.png: Added.
* platform/qt/svg/zoom/page/zoom-mask-with-percentages-expected.txt: Added.
* platform/qt/tables/layering: Added.
* platform/qt/tables/layering/paint-test-layering-1-expected.checksum: Added.
* platform/qt/tables/layering/paint-test-layering-1-expected.png: Added.
* platform/qt/tables/layering/paint-test-layering-1-expected.txt: Added.
* platform/qt/tables/layering/paint-test-layering-2-expected.checksum: Added.
* platform/qt/tables/layering/paint-test-layering-2-expected.png: Added.
* platform/qt/tables/layering/paint-test-layering-2-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-19 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 19 Aug 2010 12:28:22 +0000 (12:28 +0000)]
2010-08-19  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Chromium DevTools: remove setRuntimeFeatureEnabled API method that
        is no longer used.
        https://bugs.webkit.org/show_bug.cgi?id=44237

        * public/WebDevToolsAgent.h:
        * src/WebDevToolsAgentImpl.cpp:
        * src/WebDevToolsAgentImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-19 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>
commit-queue@webkit.org [Thu, 19 Aug 2010 12:19:11 +0000 (12:19 +0000)]
2010-08-19  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        Remove outdated reference to http/tests/history/redirect-*.pl tests

        [Qt] DRT keepWebHistory is not being called in redirect-30*.pl tests
        https://bugs.webkit.org/show_bug.cgi?id=34212

        Those tests have been renamed on
        http://trac.webkit.org/changeset/65340

        And are passing on the bot since then.

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-19 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Thu, 19 Aug 2010 11:00:26 +0000 (11:00 +0000)]
2010-08-19  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Dirk Schulze.

        [GTK] The size of the shadow image uses the standard deviation
        size instead of the blur radius
        https://bugs.webkit.org/show_bug.cgi?id=40793

        The kernelSize variable was renamed to radius and recalculated
        considering the CSS3 specification
        http://www.w3.org/TR/css3-background/#the-box-shadow, and the
        visual result of other browsers. The HTML5 canvas shadow standard
        deviation calculation that was used, was not appropiate for the
        blur distance specified in the CSS3.

        * platform/graphics/GraphicsContext.h:
        * platform/graphics/cairo/FontCairo.cpp:
        (WebCore::Font::drawGlyphs):
        * platform/graphics/cairo/GraphicsContextCairo.cpp:
        (WebCore::GraphicsContext::calculateShadowBufferDimensions):
        Changed the calculation, now we use the parameter in the style
        directly as recomended in the CSS3 standard.
        (WebCore::drawPathShadow):
        (WebCore::drawBorderlessRectShadow):
        (WebCore::GraphicsContext::createPlatformShadow): We get the
        standard deviation from the radius using the new function and we
        create the filter with that deviation.
        * platform/graphics/cairo/ImageCairo.cpp:
        (WebCore::BitmapImage::draw):
        * platform/graphics/filters/FEGaussianBlur.cpp:
        (WebCore::FEGaussianBlur::calculateStdDeviation):  Added this
        function that gets the standard deviation from the blur
        radius. Required in the CSS3 case where we have this radio and we
        need the deviation to initialize the algorithm.
        * platform/graphics/filters/FEGaussianBlur.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-19 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 19 Aug 2010 08:21:12 +0000 (08:21 +0000)]
2010-08-19  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, skip crashing test.

        [GStreamer] multiple <video> elements + PulseAudio are crash-prone
        https://bugs.webkit.org/show_bug.cgi?id=44235

        * platform/gtk/Skipped: Skip media/video-layer-crash.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-19 Andreas Kling <andreas.kling@nokia.com>
andreas.kling@nokia.com [Thu, 19 Aug 2010 08:16:03 +0000 (08:16 +0000)]
2010-08-19  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Avoid unnecessary string copy in TextCodecQt::decode()
        https://bugs.webkit.org/show_bug.cgi?id=44232

        * platform/text/qt/TextCodecQt.cpp:
        (WebCore::TextCodecQt::decode): Use String::append(const UChar*, int)
        to avoid creating a temporary string.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Gustavo Noronha Silva.
philn@webkit.org [Thu, 19 Aug 2010 08:04:50 +0000 (08:04 +0000)]
    Reviewed by Gustavo Noronha Silva.

        [GStreamer] GTK XOverlay support in GStreamerGWorld
        https://bugs.webkit.org/show_bug.cgi?id=39474

        * configure.ac: gst-interfaces link support needed for use of
        GstXOverlay interface.
        * GNUmakefile.am: Added new FullscreenVideoController files in the
        build.

LayoutTests:

        Reviewed by Gustavo Noronha Silva.

        [GStreamer] GTK XOverlay support in GStreamerGWorld
        https://bugs.webkit.org/show_bug.cgi?id=39474

        Rebaselined tests showing the video controls containing the new
        fullscreen button.

        * platform/gtk/media/controls-after-reload-expected.txt:
        * platform/gtk/media/controls-drag-timebar-expected.txt:
        * platform/gtk/media/controls-strict-expected.txt:
        * platform/gtk/media/controls-styling-expected.txt:
        * platform/gtk/media/video-controls-rendering-expected.txt:

WebCore:

        Reviewed by Gustavo Noronha Silva.

        [GStreamer] GTK XOverlay support in GStreamerGWorld
        https://bugs.webkit.org/show_bug.cgi?id=39474

        GStreamerGWorld now catches synchronous messages coming from the
        sinks and creates a GTK window where the video can be overlayed if
        fullscreen display is requested using enterFullscreen.

        * GNUmakefile.am:
        * platform/graphics/gstreamer/GStreamerGWorld.cpp:
        (WebCore::gstGWorldSyncMessageCallback):
        (WebCore::GStreamerGWorld::GStreamerGWorld):
        (WebCore::GStreamerGWorld::~GStreamerGWorld):
        (WebCore::GStreamerGWorld::enterFullscreen):
        (WebCore::GStreamerGWorld::exitFullscreen):
        (WebCore::GStreamerGWorld::setWindowOverlay):
        * platform/graphics/gstreamer/GStreamerGWorld.h:
        (WebCore::GStreamerGWorld::pipeline):
        (WebCore::GStreamerGWorld::platformVideoWindow):
        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
        * platform/graphics/gstreamer/PlatformVideoWindow.h: Added.
        (WebCore::PlatformVideoWindow::createWindow):
        (WebCore::PlatformVideoWindow::window):
        (WebCore::PlatformVideoWindow::videoWindowId):
        * platform/graphics/gstreamer/PlatformVideoWindowGtk.cpp: Added.
        (PlatformVideoWindow::PlatformVideoWindow):

WebKt/gtk:

        Reviewed by Gustavo Noronha Silva.

        [GStreamer] GTK XOverlay support in GStreamerGWorld
        https://bugs.webkit.org/show_bug.cgi?id=39474

        New FullscreenVideoController object, private in the webview. It
        is created when the user presses the fullscreen button of the
        video controls. Video is displayed in fullscreen, controls are
        displayed when the user moves the mouse and when the video is
        paused. There's also basic keyboard shortcuts support: F/f to
        leave fullscreen, space to toggle play/pause and up/down to
        control volume.

        * WebCoreSupport/ChromeClientGtk.cpp:
        (WebKit::ChromeClient::supportsFullscreenForNode):
        (WebKit::ChromeClient::enterFullscreenForNode):
        (WebKit::ChromeClient::exitFullscreenForNode):
        * WebCoreSupport/ChromeClientGtk.h:
        * WebCoreSupport/FullscreenVideoController.cpp: Added.
        (hideHudCallback):
        (onFullscreenGtkMotionNotifyEvent):
        (onFullscreenGtkActiveNotification):
        (onFullscreenGtkConfigureEvent):
        (onFullscreenGtkDestroy):
        (togglePlayPauseActivated):
        (exitFullscreenActivated):
        (progressBarUpdateCallback):
        (timeScaleButtonPressed):
        (timeScaleButtonReleased):
        (timeScaleValueChanged):
        (volumeValueChanged):
        (playerVolumeChangedCallback):
        (playerMuteChangedCallback):
        (FullscreenVideoController::FullscreenVideoController):
        (FullscreenVideoController::~FullscreenVideoController):
        (FullscreenVideoController::setMediaElement):
        (FullscreenVideoController::gtkConfigure):
        (FullscreenVideoController::showHud):
        (FullscreenVideoController::hideHud):
        (onFullscreenGtkKeyPressEvent):
        (FullscreenVideoController::enterFullscreen):
        (FullscreenVideoController::updateHudPosition):
        (FullscreenVideoController::exitOnUserRequest):
        (FullscreenVideoController::exitFullscreen):
        (FullscreenVideoController::canPlay):
        (FullscreenVideoController::play):
        (FullscreenVideoController::pause):
        (FullscreenVideoController::playStateChanged):
        (FullscreenVideoController::togglePlay):
        (FullscreenVideoController::volume):
        (FullscreenVideoController::muted):
        (FullscreenVideoController::setVolume):
        (FullscreenVideoController::volumeChanged):
        (FullscreenVideoController::muteChanged):
        (FullscreenVideoController::currentTime):
        (FullscreenVideoController::setCurrentTime):
        (FullscreenVideoController::duration):
        (FullscreenVideoController::percentLoaded):
        (FullscreenVideoController::beginSeek):
        (FullscreenVideoController::doSeek):
        (FullscreenVideoController::endSeek):
        (timeToString):
        (FullscreenVideoController::updateHudProgressBar):
        (FullscreenVideoController::createHud):
        * WebCoreSupport/FullscreenVideoController.h: Added.
        (FullscreenVideoController::mediaElement):
        * webkit/webkitprivate.cpp:
        (webkit_web_view_enter_fullscreen):
        (webkit_web_view_exit_fullscreen):
        * webkit/webkitprivate.h:

WebKit/gtk/po:

        Reviewed by Gustavo Noronha Silva.

        [GStreamer] GTK XOverlay support in GStreamerGWorld
        https://bugs.webkit.org/show_bug.cgi?id=39474

        * POTFILES: Added new file that contains strings to extract.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-19 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 19 Aug 2010 07:45:48 +0000 (07:45 +0000)]
2010-08-19  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Tony Chang.

        REGRESSION(r64303): dumpAsMarkup doesn't print the output without layoutTestController
        https://bugs.webkit.org/show_bug.cgi?id=44225

        Have notifyDone append Markup._container to document.body even if window.layoutTestController is undefined.

        * resources/dump-as-markup.js:
        (Markup.notifyDone):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-19 Eric Uhrhane <ericu@chromium.org>
commit-queue@webkit.org [Thu, 19 Aug 2010 07:18:12 +0000 (07:18 +0000)]
2010-08-19  Eric Uhrhane  <ericu@chromium.org>

        Reviewed by David Levin.

        Add idl and mock classes for FileWriter.
        https://bugs.webkit.org/show_bug.cgi?id=44075

        No new tests, since there's no new functionality.

        New do-nothing classes, but the real IDL:
        * FileWriter.idl:
        * FileWriter.h:
        * FileWriter.cpp:

        The build file changes to include the above:
        * CMakeLists.txt:
        * DerivedSources.cpp:
        * DerivedSources.make:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pri:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:

        Added FileWriter event names and required EventTarget changes.
        * dom/EventNames.h:
        * dom/EventTarget.cpp:
        (WebCore::EventTarget::toFileWriter):
        * dom/EventTarget.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-18 Andreas Kling <andreas.kling@nokia.com>
andreas.kling@nokia.com [Thu, 19 Aug 2010 06:56:58 +0000 (06:56 +0000)]
2010-08-18  Andreas Kling  <andreas.kling@nokia.com>

        Rubber-stamped by Ariya Hidayat.

        [Qt] Remove unused variable in GraphicsContext::fillRect()

        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::fillRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Short lived shadow buffer for blur operation
ariya@webkit.org [Thu, 19 Aug 2010 05:59:53 +0000 (05:59 +0000)]
[Qt] Short lived shadow buffer for blur operation
https://bugs.webkit.org/show_bug.cgi?id=44094

Patch by Ariya Hidayat <ariya@sencha.com> on 2010-08-18
Reviewed by Kenneth Rohde Christiansen.

ContextShadow needs a scratch image as the buffer for the blur filter.
Instead of creating and destroying the buffer for every operation,
we create a buffer which will be automatically purged via a timer.

* platform/graphics/qt/ContextShadow.cpp:
(WebCore::):
(WebCore::ShadowBuffer::ShadowBuffer):
(WebCore::ShadowBuffer::scratchImage):
(WebCore::ShadowBuffer::schedulePurge):
(WebCore::ShadowBuffer::purgeBuffer):
(WebCore::ContextShadow::drawShadowRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-18 Andreas Kling <andreas.kling@nokia.com>
andreas.kling@nokia.com [Thu, 19 Aug 2010 05:56:30 +0000 (05:56 +0000)]
2010-08-18  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Geoffrey Garen.

        REGRESSION(r58469): Math.pow() always returns double-backed JSValue which is extremely slow as array subscript
        https://bugs.webkit.org/show_bug.cgi?id=43742

        Add codegen for pow() to return Int32 values when possible.

        * jit/ThunkGenerators.cpp:
        (JSC::powThunkGenerator):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agofast/text/hyphenate-character.html is failing on the Leopard Commit Bot
mitz@apple.com [Thu, 19 Aug 2010 05:41:31 +0000 (05:41 +0000)]
fast/text/hyphenate-character.html is failing on the Leopard Commit Bot
https://bugs.webkit.org/show_bug.cgi?id=41093
-and some of-
fast/text/hyphen* tests have different results on Leopard
https://bugs.webkit.org/show_bug.cgi?id=43296

Reviewed by Mark Rowe.

* fast/text/hyphenate-character.html: Specify the hyphenation locale, which removes the
dependency on user preferences.
* fast/text/hyphens.html: Ditto.
* platform/mac-leopard/Skipped: Don’t skip the above tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-18 Alexey Marinichev <amarinichev@chromium.org>
commit-queue@webkit.org [Thu, 19 Aug 2010 05:38:12 +0000 (05:38 +0000)]
2010-08-18  Alexey Marinichev  <amarinichev@chromium.org>

        Reviewed by Darin Fisher.

        [chromium] scrolling issues when accelerated compositor is enabled
        https://bugs.webkit.org/show_bug.cgi?id=43992

        Corrected scroll position not being updated, and an off-by-half error.
        Int cast and floorf are taken out because they produce incorrect
        transformation matrix.  The information lost there is not immediately
        obvious because of rounding that happens when texture is mapped with
        GL_NEAREST filtering mode.  These errors accumulate, and after some
        scrolling it becomes more apparent.

        To test the former, follow instructions in the bug.  To test the
        latter, change GL_NEAREST to GL_LINEAR in LayerRendererChromium.cpp.
        Scrolling should work properly for all window sizes, without blurring
        images and shifting them to the left.

        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::drawLayers):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-18 Simon Hausmann <simon.hausmann@nokia.com>
commit-queue@webkit.org [Thu, 19 Aug 2010 05:20:22 +0000 (05:20 +0000)]
2010-08-18  Simon Hausmann  <simon.hausmann@nokia.com>

        Reviewed by Ariya Hidayat.

        [Qt] Implement GraphicsContext::clipOut more efficiently
        https://bugs.webkit.org/show_bug.cgi?id=43416

        The current implementation of clipOut uses QPainter::clipRegion().boundingRect(),
        which is a very slow function because it converts the entire clip region - which
        may potentially contain a complex path - into a set of QRegion rectangles, just
        to throw away all that information and use the bounding rect.

        QTBUG-12618 implements a faster function in QPainter: QPainter::clipBoundingRect().

        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::clipOut): Use QPainter::clipBoundingRect() with Qt >= 4.8.
        (WebCore::GraphicsContext::clipOutEllipseInRect): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-18 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 19 Aug 2010 04:35:14 +0000 (04:35 +0000)]
2010-08-18  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] Since the GSEAL changes moz_gtk_scrollbar_button_paint fiddles the widget allocation but doesn't preserve it
        https://bugs.webkit.org/show_bug.cgi?id=44211

        No new tests as we do not currently use the scrollbar button painting
        code. Tests for this issue will be enabled when we have pixel tests
        for WebCore-drawn interior frame scrollbars.

        * platform/gtk/GtkVersioning.h: Add backward-compatible functions for getting
        and setting the widget allocation.
        * platform/gtk/gtk2drawing.c:
        (moz_gtk_scrollbar_button_paint): Use new backward-compatible functions for getting
        and setting the widget allocation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-17 MORITA Hajime <morrita@google.com>
morrita@google.com [Thu, 19 Aug 2010 02:14:38 +0000 (02:14 +0000)]
2010-08-17  MORITA Hajime  <morrita@google.com>

        Reviewed by Tony Chang.

        [Chromium] editing/pasteboard/drop-text-events.html failed.
        https://bugs.webkit.org/show_bug.cgi?id=44051

        * editing/pasteboard/drop-text-events-expected.txt:
        * editing/pasteboard/script-tests/drop-text-events.js: Supressed side effect during a drag.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-18 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 19 Aug 2010 01:04:27 +0000 (01:04 +0000)]
2010-08-18  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        Group functions in markup.cpp into MarkupAccumulatorWrapper
        https://bugs.webkit.org/show_bug.cgi?id=43936

        Renamed MarkupAccumulatorWrapper to MarkupAccumulator and moved the MarkupAccumulatorWrapper
        to the top of markup.cpp. Made various functions private member functions of MarkupAccumulator.

        No new tests are added since this is a cleanup.

        * editing/markup.cpp:
        (WebCore::MarkupAccumulator::):
        (WebCore::MarkupAccumulator::MarkupAccumulator):
        (WebCore::MarkupAccumulator::appendString):
        (WebCore::MarkupAccumulator::appendStartTag):
        (WebCore::MarkupAccumulator::appendEndTag):
        (WebCore::MarkupAccumulator::wrapWithNode):
        (WebCore::MarkupAccumulator::wrapWithStyleNode):
        (WebCore::MarkupAccumulator::takeResults):
        (WebCore::MarkupAccumulator::appendAttributeValue):
        (WebCore::MarkupAccumulator::escapeContentText):
        (WebCore::MarkupAccumulator::appendQuotedURLAttributeValue):
        (WebCore::MarkupAccumulator::stringValueForRange):
        (WebCore::MarkupAccumulator::ucharRange):
        (WebCore::MarkupAccumulator::appendUCharRange):
        (WebCore::MarkupAccumulator::renderedText):
        (WebCore::MarkupAccumulator::shouldAddNamespaceElement):
        (WebCore::MarkupAccumulator::shouldAddNamespaceAttribute):
        (WebCore::MarkupAccumulator::appendNamespace):
        (WebCore::MarkupAccumulator::appendDocumentType):
        (WebCore::MarkupAccumulator::removeExteriorStyles):
        (WebCore::MarkupAccumulator::appendStartMarkup):
        (WebCore::MarkupAccumulator::shouldSelfClose):
        (WebCore::MarkupAccumulator::appendEndMarkup):
        (WebCore::serializeNodes):
        (WebCore::createMarkup):
        (WebCore::serializeNodesWithNamespaces):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=44207 Empty mfrac
bdakin@apple.com [Thu, 19 Aug 2010 00:26:20 +0000 (00:26 +0000)]
WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=44207 Empty mfrac
and empty munderover cause crashes
       -and corresponding-
<rdar://problem/8325160>

Reviewed by Sam Weinig.

This is just a  matter of adding null checks in the right places.
* mathml/RenderMathMLFraction.cpp:
(WebCore::RenderMathMLFraction::baselinePosition):
* mathml/RenderMathMLUnderOver.cpp:
(WebCore::RenderMathMLUnderOver::baselinePosition):

LayoutTests: Tests for https://bugs.webkit.org/show_bug.cgi?id=44207 Empty mfrac
and empty munderover cause crashes
       -and corresponding-
<rdar://problem/8325160>
* mathml/EmptyMFracCrash-expected.txt: Added.
* mathml/EmptyMFracCrash.xhtml: Added.
* mathml/EmptyMunderOverCrash-expected.txt: Added.
* mathml/EmptyMunderOverCrash.xhtml: Added.

Reviewed by Sam Weinig.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoMove FileStream to platform.
jianli@chromium.org [Wed, 18 Aug 2010 23:52:03 +0000 (23:52 +0000)]
Move FileStream to platform.
https://bugs.webkit.org/show_bug.cgi?id=44213

Reviewed by David Levin.

In addition to moving files over, FileStream has been changed to remove
ExceptionCode dependency. Also update FileStreamProxy and FileRead to
account for this change.

* Android.mk:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* html/FileReader.cpp:
(WebCore::FileReader::didOpen):
* html/FileReader.h:
* html/FileStream.cpp: Removed.
* html/FileStream.h: Removed.
* html/FileStreamClient.h:
(WebCore::FileStreamClient::didTruncate):
(WebCore::FileStreamClient::didOpen):
* html/FileStreamProxy.cpp:
(WebCore::didOpen):
(WebCore::FileStreamProxy::openForReadOnFileThread):
(WebCore::FileStreamProxy::openForWriteOnFileThread):
(WebCore::FileStreamProxy::write):
(WebCore::FileStreamProxy::writeOnFileThread):
(WebCore::didTruncate):
(WebCore::FileStreamProxy::truncateOnFileThread):
* html/FileStreamProxy.h:
* platform/FileStream.cpp: Renamed from WebCore/FileStream.cpp and updated.
* platform/FileStream.h: Renamed from WebCore/FileStream.h and updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65645 268f45cc-cd09-0410-ab3c-d52691b4dbfc