mihaip@chromium.org [Thu, 3 Mar 2011 22:41:43 +0000 (22:41 +0000)]
2011-03-03 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium expectations update.
Two tests crash on Snow Leopard on the GPU path.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80286
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Thu, 3 Mar 2011 22:30:59 +0000 (22:30 +0000)]
2011-03-03 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
JSVariableObject needs to use WriteBarrier for symboltable property storage
https://bugs.webkit.org/show_bug.cgi?id=55698
Replace the direct usage of Register in JSVariableObject (and descendents)
with WriteBarrier. This requires updating the Arguments object to use
WriteBarrier as well.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::unwindCallFrame):
(JSC::Interpreter::privateExecute):
(JSC::Interpreter::retrieveArguments):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/ArgList.h:
(JSC::MarkedArgumentBuffer::initialize):
* runtime/Arguments.cpp:
(JSC::Arguments::markChildren):
(JSC::Arguments::copyToRegisters):
(JSC::Arguments::fillArgList):
(JSC::Arguments::getOwnPropertySlot):
(JSC::Arguments::getOwnPropertyDescriptor):
(JSC::Arguments::put):
* runtime/Arguments.h:
(JSC::Arguments::setActivation):
(JSC::Arguments::Arguments):
(JSC::Arguments::copyRegisters):
(JSC::JSActivation::copyRegisters):
* runtime/JSActivation.cpp:
(JSC::JSActivation::markChildren):
(JSC::JSActivation::symbolTableGet):
(JSC::JSActivation::symbolTablePut):
(JSC::JSActivation::symbolTablePutWithAttributes):
(JSC::JSActivation::put):
(JSC::JSActivation::putWithAttributes):
(JSC::JSActivation::argumentsGetter):
* runtime/JSActivation.h:
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::put):
(JSC::JSGlobalObject::putWithAttributes):
(JSC::JSGlobalObject::markChildren):
(JSC::JSGlobalObject::copyGlobalsFrom):
(JSC::JSGlobalObject::copyGlobalsTo):
(JSC::JSGlobalObject::resizeRegisters):
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::setRegisters):
(JSC::JSGlobalObject::addStaticGlobals):
* runtime/JSStaticScopeObject.cpp:
(JSC::JSStaticScopeObject::put):
(JSC::JSStaticScopeObject::putWithAttributes):
* runtime/JSVariableObject.cpp:
(JSC::JSVariableObject::symbolTableGet):
* runtime/JSVariableObject.h:
(JSC::JSVariableObject::registerAt):
(JSC::JSVariableObject::JSVariableObjectData::JSVariableObjectData):
(JSC::JSVariableObject::symbolTableGet):
(JSC::JSVariableObject::symbolTablePut):
(JSC::JSVariableObject::symbolTablePutWithAttributes):
(JSC::JSVariableObject::copyRegisterArray):
(JSC::JSVariableObject::setRegisters):
2011-03-03 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
JSVariableObject needs to use WriteBarrier for symboltable property storage
https://bugs.webkit.org/show_bug.cgi?id=55698
Update to pass JSGlobalData for the symbol table write used
to set the document property.
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::updateDocument):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80285
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Thu, 3 Mar 2011 22:18:54 +0000 (22:18 +0000)]
2011-03-03 Mihai Parparita <mihaip@chromium.org>
Reviewed by Tony Chang.
NRWT: AttributeError: TestRunner2 instance has no attribute '_cancel_workers'
https://bugs.webkit.org/show_bug.cgi?id=55694
Fixes for interruptions in NRWT:
- Make TestRunInterruptedException be pickleable correctly (the base
Exception class defines a __reduce__ that does not include the reason)
- Fix ordering of returned arguments from TestRunner2._run_tests
(interrupted and keyboard_interrupted were reversed)
- Fix cancel_workers callsites (was using old name).
- In handle_exception re-raise actual exception instance that was thrown
* Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
* Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
* Scripts/webkitpy/layout_tests/layout_package/worker.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80284
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Thu, 3 Mar 2011 22:04:35 +0000 (22:04 +0000)]
More build fixing. Move WebCoreKeyboardUIMode.h to a cross-platform location.
* WebCore.xcodeproj/project.pbxproj:
* page/WebCoreKeyboardUIMode.h: Copied from WebCore/page/mac/WebCoreKeyboardUIMode.h.
* page/mac/WebCoreKeyboardUIMode.h: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80283
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Thu, 3 Mar 2011 21:55:03 +0000 (21:55 +0000)]
Build fix. Should include WebCoreKeyboardUIMode.h on all platforms now.
* page/ChromeClient.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80282
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Thu, 3 Mar 2011 21:42:44 +0000 (21:42 +0000)]
2011-03-03 Maciej Stachowiak <mjs@apple.com>
Reviewed by Brady Eidson.
WebProcess is calling CFURLCacheRemoveAllCachedResponses when loading, results in origin-load for all resources
https://bugs.webkit.org/show_bug.cgi?id=55701
<rdar://problem/
9074017>
* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::WebProcessCreationParameters): Initialize cache-clearing
flag parameters to false.
(WebKit::WebProcessCreationParameters::encode): Serialize them properly.
(WebKit::WebProcessCreationParameters::decode): And deserialize.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80281
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Thu, 3 Mar 2011 21:39:38 +0000 (21:39 +0000)]
Try to fix Windows build.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Removed obsolete symbol.
* runtime/JSStaticScopeObject.cpp:
(JSC::JSStaticScopeObject::getOwnPropertySlot): Don't mark this function
inline -- it's virtual.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80280
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Thu, 3 Mar 2011 21:34:20 +0000 (21:34 +0000)]
Reviewed by Darin Adler.
REGRESSION (WebKit2): Tab keys no longer observe Full Keyboard Access
https://bugs.webkit.org/show_bug.cgi?id=55633
<rdar://problem/
8963023>
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/mac/FullKeyboardAccessWatcher.h: Added.
* WebProcess/mac/FullKeyboardAccessWatcher.mm: Added.
(-[FullKeyboardAccessWatcher retrieveKeyboardUIModeFromPreferences:]):
(-[FullKeyboardAccessWatcher init]):
(+[FullKeyboardAccessWatcher fullKeyboardAccessEnabled]):
Get the current state of full keyboard access, listening for change notifications.
* WebProcess/WebProcess.h: Added fullKeyboardAccessEnabled().
* WebProcess/WebProcess.cpp: (WebKit::WebProcess::fullKeyboardAccessEnabled):
WebKit1 also doesn't implement this on platforms other than Mac.
* WebProcess/mac/WebProcessMac.mm: (WebKit::WebProcess::fullKeyboardAccessEnabled):
Just ask FullKeyboardAccessWatcher.
* WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::keyboardUIMode):
* WebProcess/WebCoreSupport/WebChromeClient.h:
Added keyboardUIMode(), removed tabsToLinks().
* WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::keyboardUIMode):
* WebProcess/WebPage/WebPage.h:
Generate keyboard UI mode from tabToLinks preference and current state of FKA.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80279
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Thu, 3 Mar 2011 21:28:19 +0000 (21:28 +0000)]
2011-03-03 Dimitri Glazkov <dglazkov@chromium.org>
Fix Win compile break, caused by r80276.
* rendering/RenderThemeWin.h: Changed signature of volumeSliderOffsetFromMuteButton
to match RenderTheme.h.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80278
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Thu, 3 Mar 2011 21:24:14 +0000 (21:24 +0000)]
2011-03-02 Geoffrey Garen <ggaren@apple.com>
Reviewed by Darin Adler.
Moved all variable object storage inline -- upping the object size limit to 1K
https://bugs.webkit.org/show_bug.cgi?id=55653
* JavaScriptCore.exp:
* bytecompiler/BytecodeGenerator.cpp:
* jit/JITOpcodes.cpp:
* runtime/Arguments.h:
* runtime/JSActivation.h: Removed out-of-line storage. Changed d-> to m_.
* runtime/JSCell.h:
(JSC::JSCell::MarkedSpace::sizeClassFor): Added an imprecise size class
to accomodate objects up to 1K.
* runtime/JSGlobalObject.cpp:
* runtime/JSGlobalObject.h: Removed out-of-line storage. Changed d-> to m_.
* runtime/JSObject.cpp: Don't ASSERT that JSFinalObject fills the maximum
object size, since it doesn't anymore.
* runtime/JSStaticScopeObject.cpp:
* runtime/JSStaticScopeObject.h:
* runtime/JSVariableObject.h: Removed out-of-line storage. Changed d-> to m_.
* runtime/MarkedSpace.cpp:
(JSC::MarkedSpace::MarkedSpace):
(JSC::MarkedSpace::reset):
* runtime/MarkedSpace.h: Added an imprecise size class to accomodate objects up to 1K.
2011-03-02 Geoffrey Garen <ggaren@apple.com>
Reviewed by Darin Adler.
Moved all variable object storage inline -- upping the object size limit to 1K
https://bugs.webkit.org/show_bug.cgi?id=55653
* JSRun.cpp:
(JSGlueGlobalObject::JSGlueGlobalObject):
* JSRun.h:
(JSGlueGlobalObject::Flags):
(JSGlueGlobalObject::userObjectStructure): Removed out-of-line storage. Changed d-> to m_.
2011-03-02 Geoffrey Garen <ggaren@apple.com>
Reviewed by Darin Adler.
Moved all variable object storage inline -- upping the object size limit to 1K
https://bugs.webkit.org/show_bug.cgi?id=55653
* bindings/js/JSDOMGlobalObject.cpp:
* bindings/js/JSDOMGlobalObject.h:
* bindings/js/JSDOMWindowBase.cpp:
* bindings/js/JSDOMWindowBase.h:
* bindings/js/JSDOMWindowCustom.h:
* bindings/js/JSWorkerContextBase.cpp: Removed out-of-line storage. Changed d-> to m_.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80277
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Thu, 3 Mar 2011 21:19:23 +0000 (21:19 +0000)]
2011-03-03 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
Use RenderBox in volumeSliderOffsetFromMuteButton, since that's what is actually being used.
https://bugs.webkit.org/show_bug.cgi?id=55099
Cleanup, no behavior change.
* html/shadow/MediaControls.cpp:
(WebCore::MediaControls::updateVolumeSliderContainer): Changed to pass RenderBox
instead of Node.
* rendering/RenderMediaControls.cpp:
(WebCore::RenderMediaControls::volumeSliderOffsetFromMuteButton): Changed
to use RenderBox as argument.
* rendering/RenderMediaControls.h: Ditto.
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::volumeSliderOffsetFromMuteButton): Ditto.
* rendering/RenderTheme.h: Ditto.
* rendering/RenderThemeChromiumMac.h: Ditto.
* rendering/RenderThemeChromiumMac.mm:
(WebCore::RenderThemeChromiumMac::volumeSliderOffsetFromMuteButton): Ditto.
* rendering/RenderThemeMac.h: Ditto.
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::volumeSliderOffsetFromMuteButton): Ditto.
* rendering/RenderThemeWin.cpp:
(WebCore::RenderThemeWin::volumeSliderOffsetFromMuteButton): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80276
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Thu, 3 Mar 2011 21:06:05 +0000 (21:06 +0000)]
2011-03-03 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Give the Bundle's policy client the option of deciding the policy
https://bugs.webkit.org/show_bug.cgi?id=55699
* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
Add WKBundlePagePolicyAction enum and make it the return value of
the WKBundlePagePolicyClient functions.
* WebProcess/InjectedBundle/InjectedBundlePagePolicyClient.cpp:
(WebKit::InjectedBundlePagePolicyClient::decidePolicyForNavigationAction):
(WebKit::InjectedBundlePagePolicyClient::decidePolicyForNewWindowAction):
(WebKit::InjectedBundlePagePolicyClient::decidePolicyForMIMEType):
* WebProcess/InjectedBundle/InjectedBundlePagePolicyClient.h:
Pass the return value back to the caller. For unimplemented functions, return WKBundlePagePolicyActionPassThrough.
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForMIMEType):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
Call the policy function early if the bundle handles it.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80275
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Thu, 3 Mar 2011 21:03:04 +0000 (21:03 +0000)]
2011-03-03 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Andreas Kling.
When building with DEFINES+=USE_GSTREAMER=1 we don't want to define ENABLE_QT_MULTIMEDIA to 1.
Also add the new files added after https://bugs.webkit.org/show_bug.cgi?id=54870 to support GRefPtr
for GstElement.
* WebCore.pro:
* features.pri:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80274
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Thu, 3 Mar 2011 21:00:46 +0000 (21:00 +0000)]
2011-03-03 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r80272.
http://trac.webkit.org/changeset/80272
https://bugs.webkit.org/show_bug.cgi?id=55700
the test are flaky (Requested by loislo_ on #webkit).
* http/tests/inspector/inspector-test.js:
(initialize_InspectorTest.InspectorTest.addObject):
* http/tests/inspector/protocol-test.js: Removed.
* inspector/protocol/runtime-agent-expected.txt: Removed.
* inspector/protocol/runtime-agent.html: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80273
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Thu, 3 Mar 2011 20:22:54 +0000 (20:22 +0000)]
2011-03-03 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: introduce a protocol test for RuntimeAgent API.
https://bugs.webkit.org/show_bug.cgi?id=55482
* http/tests/inspector/protocol-test.js: Added.
(initialize_ProtocolTest.InspectorTest.filterProps):
(initialize_ProtocolTest.InspectorTest._dumpStepResult):
(initialize_ProtocolTest.InspectorTest._runNextStep):
(initialize_ProtocolTest.InspectorTest.runProtocolTestSuite):
(initialize_ProtocolTest):
* inspector/protocol/runtime-agent-expected.txt: Added.
* inspector/protocol/runtime-agent.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80272
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 3 Mar 2011 19:58:55 +0000 (19:58 +0000)]
Try to fix the Windows build again.
* platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
* platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80271
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 3 Mar 2011 19:58:08 +0000 (19:58 +0000)]
2011-03-03 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Andreas Kling.
[Qt] QGraphicsWebView should use updateMicroFocus() of QGraphicsItem
https://bugs.webkit.org/show_bug.cgi?id=55568
We should use updateMicroFocus() from QGraphicsItem rather than the implementation
in QGraphicsWebView. _q_updateMicroFocus was added when QGraphicsItem didn't have the feature.
In Qt 4.7, updateMicroFocus was added, let's use it, then we can benefit of all bug fixing done
in QGraphicsItem.
* Api/qgraphicswebview.cpp:
(QGraphicsWebView::setPage):
* Api/qgraphicswebview.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80270
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Thu, 3 Mar 2011 19:54:24 +0000 (19:54 +0000)]
2011-03-03 Mihai Parparita <mihaip@chromium.org>
Reviewed by Dimitri Glazkov.
Add another CRASH() for CSSSelector double frees
https://bugs.webkit.org/show_bug.cgi?id=55693
To help track down bug 53045, add a CRASH call when the the array and/or
CSSSelector member in CSSSelectorList is disposed of more than once.
Just a check, no new tests necessary.
* css/CSSSelectorList.cpp:
(WebCore::CSSSelectorList::deleteSelectors):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80269
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 3 Mar 2011 19:51:57 +0000 (19:51 +0000)]
Yet another attempt at fixing the Windows build.
* platform/graphics/ca/win/CACFLayerTreeHost.cpp:
* platform/graphics/ca/win/LegacyCACFLayerTreeHost.cpp:
* platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:
* platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80268
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
qi.2.zhang@nokia.com [Thu, 3 Mar 2011 19:36:52 +0000 (19:36 +0000)]
Unreviewed.
Adding myself as a committer.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80267
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cmarrin@apple.com [Thu, 3 Mar 2011 19:33:09 +0000 (19:33 +0000)]
2011-03-02 Chris Marrin <cmarrin@apple.com>
Reviewed by Simon Fraser.
REGRESSION: Accelerated transitions are jumpy
https://bugs.webkit.org/show_bug.cgi?id=55022
Got rid of default TimingFunction values from PlatformCAAnimation*. A TimingFunction
is now always passed in. The TimingFunction class now has a static method to get
a default object which has the 'ease' values in it. I now assert in both Mac and
Win implementations if a null TimingFunction pointer is seen.
* platform/animation/TimingFunction.h:
(WebCore::CubicBezierTimingFunction::create):
(WebCore::CubicBezierTimingFunction::defaultTimingFunction):
(WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction):
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::timingFunctionForAnimationValue):
* platform/graphics/ca/mac/PlatformCAAnimationMac.mm:
(toCAMediaTimingFunction):
* platform/graphics/ca/win/PlatformCAAnimationWin.cpp:
(toCACFTimingFunction):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80266
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonyg@chromium.org [Thu, 3 Mar 2011 19:28:21 +0000 (19:28 +0000)]
2011-03-03 Tony Gentilcore <tonyg@chromium.org>
Unreviewed build fix.
Fix clang compile after r80220
https://bugs.webkit.org/show_bug.cgi?id=55692
* storage/IDBBackingStore.cpp:
(WebCore::IDBBackingStore::getPrimaryKeyViaIndex):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80265
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 3 Mar 2011 19:21:11 +0000 (19:21 +0000)]
Attempt to fix the Windows build.
* platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
* platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80264
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Thu, 3 Mar 2011 19:16:18 +0000 (19:16 +0000)]
Source/WebCore: Rest of WebKit2: Need a way to send notifications to client when cookies change
https://bugs.webkit.org/show_bug.cgi?id=55427
<rdar://problem/
9056027>
Reviewed by Adam Roben.
Add functions to be exported.
* WebCore.exp.in:
Source/WebKit2: Rest of WebKit2: Need a way to send notifications to client when cookies change
https://bugs.webkit.org/show_bug.cgi?id=55427
<rdar://problem/
9056027>
Reviewed by Adam Roben.
This patch adds the communication from the WebProcess <-> UIProcess about starting/stopping
listening for cookies changing, and adds a mechanism for the WebProcess to notify the UIProcess
when the cookies have changed. The WebProcess sends a message to the UIProcess when the cookies
change, and the UIProcess passes this along to the WebCookieManagerProxyClient.
* UIProcess/API/C/WKCookieManager.cpp:
(WKCookieManagerSetClient): Call through to WebCookieManagerProxy.
(WKCookieManagerStartObservingCookieChanges): Ditto.
(WKCookieManagerStopObservingCookieChanges): Ditto.
* UIProcess/API/C/WKCookieManager.h: Add new functions and a WKCookieManagerClient
which is responsible for cookiesDidChange.
* UIProcess/WebCookieManagerProxy.cpp:
(WebKit::WebCookieManagerProxy::initializeClient):
(WebKit::WebCookieManagerProxy::startObservingCookieChanges): Send the message down to the web process.
(WebKit::WebCookieManagerProxy::stopObservingCookieChanges): Ditto.
(WebKit::WebCookieManagerProxy::cookiesDidChange): Tell the WKCookieManagerClient the cookies were
modified.
* UIProcess/WebCookieManagerProxy.h:
* UIProcess/WebCookieManagerProxy.messages.in: Add new messages.
* UIProcess/WebCookieManagerProxyClient.cpp: Added.
(WebKit::WebCookieManagerProxyClient::cookiesDidChange): Calls through to the client saying that
cookies changed.
* UIProcess/WebCookieManagerProxyClient.h: Added.
* WebProcess/Cookies/WebCookieManager.cpp:
(WebKit::WebCookieManager::startObservingCookieChanges): Call through to WebCore::startObservingCookieChanges
(on platforms that support it).
(WebKit::WebCookieManager::stopObservingCookieChanges): Ditto (for stopObservingCookieChanges).
(WebKit::WebCookieManager::dispatchDidModifyCookies): Send a message to the UI process that cookies changed.
* WebProcess/Cookies/WebCookieManager.h:
* WebProcess/Cookies/WebCookieManager.messages.in:
Add new files.
* WebKit2.pro:
* WebKit2.xcodeproj/project.pbxproj:
* GNUmakefile.am:
* win/WebKit2.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80263
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonyg@chromium.org [Thu, 3 Mar 2011 19:15:58 +0000 (19:15 +0000)]
2011-03-03 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Mihai Parparita.
Teach sheriffbot to answer whois commands
https://bugs.webkit.org/show_bug.cgi?id=55687
* Scripts/webkitpy/tool/bot/irc_command.py:
* Scripts/webkitpy/tool/bot/irc_command_unittest.py:
* Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80262
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 3 Mar 2011 19:14:45 +0000 (19:14 +0000)]
2011-03-03 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
Remove CanRunBeforeUnloadConfirmPanel sync message
https://bugs.webkit.org/show_bug.cgi?id=55689
* Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):
Encode and decode canRunBeforeUnloadConfirmPanel, as well as canRunModal, which wasn't
being encoded/decoded.
* Shared/WebPageCreationParameters.h:
Add canRunBeforeUnloadConfirmPanel.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::initializeUIClient):
Send SetCanRunBeforeUnloadConfirmPanel and SetCanRunModal messages.
(WebKit::WebPageProxy::creationParameters):
Initialize parameters.canRunBeforeUnloadConfirmPanel.
* UIProcess/WebPageProxy.messages.in:
Remove CanRunBeforeUnloadConfirmPanel message.
* UIProcess/WebUIClient.cpp:
(WebKit::WebUIClient::canRunBeforeUnloadConfirmPanel):
* UIProcess/WebUIClient.h:
Make canRunBeforeUnloadConfirmPanel const.
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::canRunBeforeUnloadConfirmPanel):
Ask the web page instead of sending a synchronous message.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
Initialize m_canRunBeforeUnloadConfirmPanel.
* WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::canRunBeforeUnloadConfirmPanel):
(WebKit::WebPage::setCanRunBeforeUnloadConfirmPanel):
Add getter and setter for m_canRunBeforeUnloadConfirmPanel.
(WebKit::WebPage::setCanRunModal):
Add setter for m_canRunModal.
* WebProcess/WebPage/WebPage.messages.in:
Add SetCanRunBeforeUnloadConfirmPanel and SetCanRunModal messages.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80261
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 3 Mar 2011 19:01:54 +0000 (19:01 +0000)]
2011-03-03 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
Improve WebCore build time by ~5%
https://bugs.webkit.org/show_bug.cgi?id=55688
Forward declare the CATransform3D and CGAffineTransform structs instead of including
large chunks of QuartzCore and Core Graphics.
On an 8 core Mac Pro, this sped up building WebCore by about 5%.
* platform/graphics/ca/GraphicsLayerCA.cpp:
* platform/graphics/ca/TransformationMatrixCA.cpp:
* platform/graphics/transforms/TransformationMatrix.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80260
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
imasaki@chromium.org [Thu, 3 Mar 2011 18:57:46 +0000 (18:57 +0000)]
2011-03-03 Kenji Imasaki <imasaki@chromium.org>
Reviewed by Mihai Parparita.
[Chromium] Snow Leopard rebaseline of media/video-layer-crash
http://code.google.com/p/chromium/issues/detail?id=60744
* platform/chromium-mac-leopard/media/video-layer-crash-expected.checksum: Copied from LayoutTests/platform/chromium-mac/media/video-layer-crash-expected.checksum.
* platform/chromium-mac-leopard/media/video-layer-crash-expected.png: Copied from LayoutTests/platform/chromium-mac/media/video-layer-crash-expected.png.
* platform/chromium-mac/media/video-layer-crash-expected.checksum:
* platform/chromium-mac/media/video-layer-crash-expected.png:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80259
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Thu, 3 Mar 2011 18:48:48 +0000 (18:48 +0000)]
2011-03-03 Andrey Kosyakov <caseq@chromium.org>
Unreviewed. Adjusted call to a method renamed in r80102.
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._startEditing):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80258
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Thu, 3 Mar 2011 18:39:26 +0000 (18:39 +0000)]
2011-03-03 Victoria Kirst <vrk@google.com>
Reviewed by Eric Carlson.
Enable media tests in chromium-gpu/test_expectations
https://bugs.webkit.org/show_bug.cgi?id=53608
Suppressing the test failures until baselines are added.
* platform/chromium/test_expectations.txt:
2011-03-03 Victoria Kirst <vrk@google.com>
Reviewed by Eric Carlson.
Enable media tests in chromium-gpu/test_expectations
https://bugs.webkit.org/show_bug.cgi?id=53608
Add media folder to the list of GPU test paths.
* Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80257
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Thu, 3 Mar 2011 18:37:52 +0000 (18:37 +0000)]
Attempt to fix the Windows build.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80256
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
imasaki@chromium.org [Thu, 3 Mar 2011 18:36:32 +0000 (18:36 +0000)]
2011-03-03 Kenji Imasaki <imasaki@chromium.org>
Reviewed by Tony Gentilcore.
[Chromium] Revert the change in http/tests/media/video-referer.html
in rev80227
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80255
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Thu, 3 Mar 2011 18:28:29 +0000 (18:28 +0000)]
Use APIEntryShim instead of JSLock in SerializedScriptValue.
Source/JavaScriptCore: Make APIShims usable from WebCore.
Reviewed by Oliver Hunt.
* ForwardingHeaders/JavaScriptCore/APIShims.h: Added.
* GNUmakefile.am:
* JavaScriptCore.exp:
* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make:
* JavaScriptCore.xcodeproj/project.pbxproj:
Source/WebCore: Use APIEntryShim instead of JSLock in SerializedScriptValue to allow it to be used
by contexts not created by WebCore.
https://webkit.org/b/55642
Reviewed by Oliver Hunt.
* bindings/js/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::create): Use APIEntryShim instead of JSLock.
(WebCore::SerializedScriptValue::deserialize): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80254
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Thu, 3 Mar 2011 18:19:42 +0000 (18:19 +0000)]
2011-03-03 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium Snow Leopard rebaseline.
Rebaseline tables/mozilla/marvin/ tests for Snow Leopard. The current
expectations were just checksums, I also added their corresponding PNGs.
We can't use the mac/ baselines since we scale the raptor image
differently (most likely due to CG i386 vs. x86_64 differences, see
bug 52335).
* platform/chromium-mac-leopard/tables/mozilla/marvin/tbody_valign_baseline-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/tbody_valign_baseline-expected.checksum.
* platform/chromium-mac-leopard/tables/mozilla/marvin/tbody_valign_baseline-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/marvin/tbody_valign_bottom-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/tbody_valign_bottom-expected.checksum.
* platform/chromium-mac-leopard/tables/mozilla/marvin/tbody_valign_bottom-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/marvin/tbody_valign_middle-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/tbody_valign_middle-expected.checksum.
* platform/chromium-mac-leopard/tables/mozilla/marvin/tbody_valign_middle-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/marvin/tbody_valign_top-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/tbody_valign_top-expected.checksum.
* platform/chromium-mac-leopard/tables/mozilla/marvin/tbody_valign_top-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/marvin/td_valign_baseline-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/td_valign_baseline-expected.checksum.
* platform/chromium-mac-leopard/tables/mozilla/marvin/td_valign_baseline-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/marvin/td_valign_bottom-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/td_valign_bottom-expected.checksum.
* platform/chromium-mac-leopard/tables/mozilla/marvin/td_valign_bottom-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/marvin/td_valign_middle-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/td_valign_middle-expected.checksum.
* platform/chromium-mac-leopard/tables/mozilla/marvin/td_valign_middle-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/marvin/td_valign_top-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/td_valign_top-expected.checksum.
* platform/chromium-mac-leopard/tables/mozilla/marvin/td_valign_top-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/marvin/tfoot_valign_baseline-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_baseline-expected.checksum.
* platform/chromium-mac-leopard/tables/mozilla/marvin/tfoot_valign_baseline-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/marvin/tfoot_valign_bottom-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_bottom-expected.checksum.
* platform/chromium-mac-leopard/tables/mozilla/marvin/tfoot_valign_bottom-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/marvin/tfoot_valign_middle-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_middle-expected.checksum.
* platform/chromium-mac-leopard/tables/mozilla/marvin/tfoot_valign_middle-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/marvin/tfoot_valign_top-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_top-expected.checksum.
* platform/chromium-mac-leopard/tables/mozilla/marvin/tfoot_valign_top-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/marvin/th_valign_baseline-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/th_valign_baseline-expected.checksum.
* platform/chromium-mac-leopard/tables/mozilla/marvin/th_valign_baseline-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/marvin/th_valign_bottom-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/th_valign_bottom-expected.checksum.
* platform/chromium-mac-leopard/tables/mozilla/marvin/th_valign_bottom-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/marvin/th_valign_middle-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/th_valign_middle-expected.checksum.
* platform/chromium-mac-leopard/tables/mozilla/marvin/th_valign_middle-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/marvin/th_valign_top-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/th_valign_top-expected.checksum.
* platform/chromium-mac-leopard/tables/mozilla/marvin/th_valign_top-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/marvin/thead_valign_baseline-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/thead_valign_baseline-expected.checksum.
* platform/chromium-mac-leopard/tables/mozilla/marvin/thead_valign_baseline-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/marvin/thead_valign_bottom-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/thead_valign_bottom-expected.checksum.
* platform/chromium-mac-leopard/tables/mozilla/marvin/thead_valign_bottom-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/marvin/thead_valign_middle-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/thead_valign_middle-expected.checksum.
* platform/chromium-mac-leopard/tables/mozilla/marvin/thead_valign_middle-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/marvin/thead_valign_top-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/thead_valign_top-expected.checksum.
* platform/chromium-mac-leopard/tables/mozilla/marvin/thead_valign_top-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/marvin/tr_valign_baseline-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/tr_valign_baseline-expected.checksum.
* platform/chromium-mac-leopard/tables/mozilla/marvin/tr_valign_baseline-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/marvin/tr_valign_bottom-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/tr_valign_bottom-expected.checksum.
* platform/chromium-mac-leopard/tables/mozilla/marvin/tr_valign_bottom-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/marvin/tr_valign_middle-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/tr_valign_middle-expected.checksum.
* platform/chromium-mac-leopard/tables/mozilla/marvin/tr_valign_middle-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/marvin/tr_valign_top-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/marvin/tr_valign_top-expected.checksum.
* platform/chromium-mac-leopard/tables/mozilla/marvin/tr_valign_top-expected.png: Added.
* platform/chromium-mac/tables/mozilla/marvin/tbody_valign_baseline-expected.checksum:
* platform/chromium-mac/tables/mozilla/marvin/tbody_valign_baseline-expected.png: Added.
* platform/chromium-mac/tables/mozilla/marvin/tbody_valign_bottom-expected.checksum:
* platform/chromium-mac/tables/mozilla/marvin/tbody_valign_bottom-expected.png: Added.
* platform/chromium-mac/tables/mozilla/marvin/tbody_valign_middle-expected.checksum:
* platform/chromium-mac/tables/mozilla/marvin/tbody_valign_middle-expected.png: Added.
* platform/chromium-mac/tables/mozilla/marvin/tbody_valign_top-expected.checksum:
* platform/chromium-mac/tables/mozilla/marvin/tbody_valign_top-expected.png: Added.
* platform/chromium-mac/tables/mozilla/marvin/td_valign_baseline-expected.checksum:
* platform/chromium-mac/tables/mozilla/marvin/td_valign_baseline-expected.png: Added.
* platform/chromium-mac/tables/mozilla/marvin/td_valign_bottom-expected.checksum:
* platform/chromium-mac/tables/mozilla/marvin/td_valign_bottom-expected.png: Added.
* platform/chromium-mac/tables/mozilla/marvin/td_valign_middle-expected.checksum:
* platform/chromium-mac/tables/mozilla/marvin/td_valign_middle-expected.png: Added.
* platform/chromium-mac/tables/mozilla/marvin/td_valign_top-expected.checksum:
* platform/chromium-mac/tables/mozilla/marvin/td_valign_top-expected.png: Added.
* platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_baseline-expected.checksum:
* platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_baseline-expected.png: Added.
* platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_bottom-expected.checksum:
* platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_bottom-expected.png: Added.
* platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_middle-expected.checksum:
* platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_middle-expected.png: Added.
* platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_top-expected.checksum:
* platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_top-expected.png: Added.
* platform/chromium-mac/tables/mozilla/marvin/th_valign_baseline-expected.checksum:
* platform/chromium-mac/tables/mozilla/marvin/th_valign_baseline-expected.png: Added.
* platform/chromium-mac/tables/mozilla/marvin/th_valign_bottom-expected.checksum:
* platform/chromium-mac/tables/mozilla/marvin/th_valign_bottom-expected.png: Added.
* platform/chromium-mac/tables/mozilla/marvin/th_valign_middle-expected.checksum:
* platform/chromium-mac/tables/mozilla/marvin/th_valign_middle-expected.png: Added.
* platform/chromium-mac/tables/mozilla/marvin/th_valign_top-expected.checksum:
* platform/chromium-mac/tables/mozilla/marvin/th_valign_top-expected.png: Added.
* platform/chromium-mac/tables/mozilla/marvin/thead_valign_baseline-expected.checksum:
* platform/chromium-mac/tables/mozilla/marvin/thead_valign_baseline-expected.png: Added.
* platform/chromium-mac/tables/mozilla/marvin/thead_valign_bottom-expected.checksum:
* platform/chromium-mac/tables/mozilla/marvin/thead_valign_bottom-expected.png: Added.
* platform/chromium-mac/tables/mozilla/marvin/thead_valign_middle-expected.checksum:
* platform/chromium-mac/tables/mozilla/marvin/thead_valign_middle-expected.png: Added.
* platform/chromium-mac/tables/mozilla/marvin/thead_valign_top-expected.checksum:
* platform/chromium-mac/tables/mozilla/marvin/thead_valign_top-expected.png: Added.
* platform/chromium-mac/tables/mozilla/marvin/tr_valign_baseline-expected.checksum:
* platform/chromium-mac/tables/mozilla/marvin/tr_valign_baseline-expected.png: Added.
* platform/chromium-mac/tables/mozilla/marvin/tr_valign_bottom-expected.checksum:
* platform/chromium-mac/tables/mozilla/marvin/tr_valign_bottom-expected.png: Added.
* platform/chromium-mac/tables/mozilla/marvin/tr_valign_middle-expected.checksum:
* platform/chromium-mac/tables/mozilla/marvin/tr_valign_middle-expected.png: Added.
* platform/chromium-mac/tables/mozilla/marvin/tr_valign_top-expected.checksum:
* platform/chromium-mac/tables/mozilla/marvin/tr_valign_top-expected.png: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80253
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Thu, 3 Mar 2011 18:10:37 +0000 (18:10 +0000)]
Reviewed by Darin Adler.
WebCore should check for "Upgrade" and "Connection" header fields in WebSockets handshake
https://bugs.webkit.org/show_bug.cgi?id=55498
<rdar://problem/
8752706>
Tests: http/tests/websocket/tests/handshake-fail-by-no-connection-header.html
http/tests/websocket/tests/handshake-fail-by-no-upgrade-header.html
* websockets/WebSocketHandshake.h: Removed unused and meaningless setters for response
header fields. Removed separate member variables for those, as they were duplicating data
available in response, and there is no reason to squeeze microsecods here.
* websockets/WebSocketHandshake.cpp:
(WebCore::WebSocketHandshake::reset): There are no longer member variables for header field
values to reset here.
(WebCore::WebSocketHandshake::readServerHandshake): Removed a call for processHeaders().
(WebCore::WebSocketHandshake::serverWebSocketOrigin): Changed to get the value from response.
(WebCore::WebSocketHandshake::serverWebSocketLocation): Ditto.
(WebCore::WebSocketHandshake::serverWebSocketProtocol): Ditto.
(WebCore::WebSocketHandshake::serverSetCookie): Ditto.
(WebCore::WebSocketHandshake::serverSetCookie2): Ditto.
(WebCore::WebSocketHandshake::serverUpgrade): Added.
(WebCore::WebSocketHandshake::serverConnection): Added.
(WebCore::WebSocketHandshake::checkResponseHeaders): Added checks for Upgrade and Connection
header field presence and values.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80252
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Thu, 3 Mar 2011 17:48:43 +0000 (17:48 +0000)]
2011-03-03 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium Snow Leopard rebaseline.
Rebaseline remaining editing/ tests for Snow Leopard. The current
expectations were just checksums, I also added their corresponding PNGs.
We can't use the mac/ baselines since we render selections differently.
* platform/chromium-mac-leopard/editing/selection/
4402375-expected.checksum: Copied from LayoutTests/platform/chromium-mac/editing/selection/
4402375-expected.checksum.
* platform/chromium-mac-leopard/editing/selection/
4402375-expected.png: Added.
* platform/chromium-mac-leopard/editing/selection/image-before-linebreak-expected.checksum: Copied from LayoutTests/platform/chromium-mac/editing/selection/image-before-linebreak-expected.checksum.
* platform/chromium-mac-leopard/editing/selection/image-before-linebreak-expected.png: Added.
* platform/chromium-mac-leopard/editing/selection/replaced-boundaries-1-expected.checksum: Copied from LayoutTests/platform/chromium-mac/editing/selection/replaced-boundaries-1-expected.checksum.
* platform/chromium-mac-leopard/editing/selection/replaced-boundaries-1-expected.png: Added.
* platform/chromium-mac-leopard/editing/selection/replaced-boundaries-2-expected.checksum: Copied from LayoutTests/platform/chromium-mac/editing/selection/replaced-boundaries-2-expected.checksum.
* platform/chromium-mac-leopard/editing/selection/replaced-boundaries-2-expected.png: Added.
* platform/chromium-mac/editing/selection/
4402375-expected.checksum:
* platform/chromium-mac/editing/selection/
4402375-expected.png: Added.
* platform/chromium-mac/editing/selection/image-before-linebreak-expected.checksum:
* platform/chromium-mac/editing/selection/image-before-linebreak-expected.png: Added.
* platform/chromium-mac/editing/selection/replaced-boundaries-1-expected.checksum:
* platform/chromium-mac/editing/selection/replaced-boundaries-1-expected.png: Added.
* platform/chromium-mac/editing/selection/replaced-boundaries-2-expected.checksum:
* platform/chromium-mac/editing/selection/replaced-boundaries-2-expected.png: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80251
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
helder@sencha.com [Thu, 3 Mar 2011 17:43:37 +0000 (17:43 +0000)]
[Qt] fast/canvas/canvas-strokePath-gradient-shadow.html fails
https://bugs.webkit.org/show_bug.cgi?id=55651
Reviewed by Andreas Kling.
When relying on ContextShadow and using a gradient stroke for a path,
the alpha of the shadow is incorrect.
Source/WebCore:
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::strokePath):
LayoutTests:
* platform/qt/Skipped: Remove test from skipped list.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80250
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 3 Mar 2011 17:36:04 +0000 (17:36 +0000)]
Work around a bug in KURL's parsing of Windows-style absolute file: URLs
Fixes <http://webkit.org/b/55674> Many tests fail in WebKit2 mode on Windows due to
incorrect parsing of absolute Windows-style file: URLs
Reviewed by Tim Hatcher.
* WebKitTestRunner/TestInvocation.cpp:
(WTR::createWKURL): Add a "localhost" host to file: URLs we create to work around
<http://webkit.org/b/55683>.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80249
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Thu, 3 Mar 2011 17:34:47 +0000 (17:34 +0000)]
2011-03-03 Tony Chang <tony@chromium.org>
Reviewed by Dimitri Glazkov.
[chromium] Run kill-old-processes on the chromium-win bot too
https://bugs.webkit.org/show_bug.cgi?id=55630
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
* BuildSlaveSupport/win/kill-old-processes: Add wdiff.exe to the kill list.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80248
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Thu, 3 Mar 2011 17:18:51 +0000 (17:18 +0000)]
2011-03-03 Philippe Normand <pnormand@igalia.com>
Unreviewed, skip failing test on GTK. See bug 55682.
* platform/gtk/Skipped: Skip fast/images/support-broken-image-delegate.html
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80247
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Thu, 3 Mar 2011 17:03:31 +0000 (17:03 +0000)]
2011-03-03 Martin Robinson <mrobinson@igalia.com>
XHTMLMP build broken after r78342
https://bugs.webkit.org/show_bug.cgi?id=55286
Fix XHTMLMP build now that the DocumentWriter is a member of DocumentLoader
instead of FrameLoader.
No new tests. This is a build fix.
* dom/Document.cpp:
(WebCore::Document::isXHTMLMPDocument):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80246
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Thu, 3 Mar 2011 16:59:11 +0000 (16:59 +0000)]
2011-03-03 Philippe Normand <pnormand@igalia.com>
Unreviewed, skip svg test failing on 32-bits Release, likely due
to a rounding error, see bug 39022.
* platform/gtk/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80245
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonyg@chromium.org [Thu, 3 Mar 2011 16:54:08 +0000 (16:54 +0000)]
2011-03-03 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r80219.
http://trac.webkit.org/changeset/80219
https://bugs.webkit.org/show_bug.cgi?id=55680
"Causes several media test crashes" (Requested by tonyg-cr on
#webkit).
* src/AssociatedURLLoader.cpp:
(WebKit::AssociatedURLLoader::AssociatedURLLoader):
(WebKit::AssociatedURLLoader::~AssociatedURLLoader):
(WebKit::AssociatedURLLoader::loadSynchronously):
(WebKit::AssociatedURLLoader::loadAsynchronously):
(WebKit::AssociatedURLLoader::cancel):
(WebKit::AssociatedURLLoader::setDefersLoading):
(WebKit::AssociatedURLLoader::prepareRequest):
(WebKit::AssociatedURLLoader::willSendRequest):
(WebKit::AssociatedURLLoader::didSendData):
(WebKit::AssociatedURLLoader::didReceiveResponse):
(WebKit::AssociatedURLLoader::didDownloadData):
(WebKit::AssociatedURLLoader::didReceiveData):
(WebKit::AssociatedURLLoader::didReceiveCachedMetadata):
(WebKit::AssociatedURLLoader::didFinishLoading):
(WebKit::AssociatedURLLoader::didFail):
* src/AssociatedURLLoader.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80244
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Thu, 3 Mar 2011 16:42:49 +0000 (16:42 +0000)]
2011-03-03 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] DRT needs implementation of EventSender.scheduleAsynchronousClick
https://bugs.webkit.org/show_bug.cgi?id=53960
* platform/gtk/Skipped: Unskip
fast/events/popup-blocking-click-in-iframe.html that passes now.
2011-03-03 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] DRT needs implementation of EventSender.scheduleAsynchronousClick
https://bugs.webkit.org/show_bug.cgi?id=53960
* DumpRenderTree/gtk/EventSender.cpp:
(sendClick):
(scheduleAsynchronousClickCallback):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80243
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Thu, 3 Mar 2011 16:40:02 +0000 (16:40 +0000)]
2011-03-03 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Eric Carlson.
Tweak MediaControlMuteButtonElement class hierarchy.
https://bugs.webkit.org/show_bug.cgi?id=55614
This allows the mute button on the panel to have event handlers that are
different from the mute button in the volume slider.
No change in behavior, covered by existing tests.
* html/shadow/MediaControls.cpp:
(WebCore::MediaControls::createMuteButton): Changed to use MediaControlPanelMuteButtonElement.
* rendering/MediaControlElements.cpp:
(WebCore::MediaControlMuteButtonElement::updateDisplayType):
(WebCore::MediaControlPanelMuteButtonElement::MediaControlPanelMuteButtonElement): Added.
(WebCore::MediaControlPanelMuteButtonElement::create): Added.
(WebCore::MediaControlPanelMuteButtonElement::shadowPseudoId): Moved.
* rendering/MediaControlElements.h: Added defs.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80242
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Thu, 3 Mar 2011 16:29:19 +0000 (16:29 +0000)]
2011-03-03 Martin Robinson <mrobinson@igalia.com>
Unskipped one test that just needs platform-independent results (it
does not fail on GTK+) and one failure so that we can get a test diff
from it (not failing locally or when run manually on the bots).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80241
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 3 Mar 2011 16:21:05 +0000 (16:21 +0000)]
Make Inspector tests work in WebKit2 on Windows
Fixes <http://webkit.org/b/55672> <rdar://problem/
9080867> All inspector tests time out or crash on
Windows 7 Release (WebKit2 Tests)
Reviewed by Darin Adler.
Source/WebKit2:
Create the CFBundleRef for WebKit.dll on Windows if needed
* Shared/win/WebKitBundle.cpp: Added.
(WebKit::createWebKitBundle): Returns a pre-existing bundle, if possible, otherwise creates
and returns a new bundle.
(WebKit::webKitBundle): Creates and caches a bundle, and returns it.
* Shared/win/WebKitBundle.h: Added.
* UIProcess/win/WebInspectorProxyWin.cpp:
(WebKit::WebInspectorProxy::inspectorPageURL):
* WebProcess/WebPage/win/WebInspectorWin.cpp:
(WebKit::WebInspector::localizedStringsURL):
Changed to use webKitBundle() to ensure that the bundle has been created.
* win/WebKit2.vcproj: Added new files.
Tools:
Look for Windows-style paths when checking whether a test is an Inspector test
* WebKitTestRunner/TestInvocation.cpp:
(WTR::shouldOpenWebInspector): Also look for backslashes, since that's what we'll get on
Windows.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80240
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Thu, 3 Mar 2011 15:52:10 +0000 (15:52 +0000)]
2011-03-03 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Resource agent should have same lifetime as Inspector agent
https://bugs.webkit.org/show_bug.cgi?id=55461
* inspector/Inspector.idl:
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::InspectorAgent):
(WebCore::InspectorAgent::inspectedPageDestroyed): disconnectFrontend is called before the agent is destroyed
to clear frontend reference in all agents.
(WebCore::InspectorAgent::restoreInspectorStateFromCookie):
(WebCore::InspectorAgent::setFrontend):
(WebCore::InspectorAgent::disconnectFrontend):
(WebCore::InspectorAgent::releaseFrontendLifetimeAgents):
(WebCore::InspectorAgent::didCommitLoad):
* inspector/InspectorAgent.h:
(WebCore::InspectorAgent::resourceAgent):
* inspector/InspectorBrowserDebuggerAgent.cpp:
(WebCore::InspectorBrowserDebuggerAgent::~InspectorBrowserDebuggerAgent):
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::~InspectorDebuggerAgent):
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didCreateWebSocketImpl):
(WebCore::InspectorInstrumentation::willSendWebSocketHandshakeRequestImpl):
(WebCore::InspectorInstrumentation::didReceiveWebSocketHandshakeResponseImpl):
(WebCore::InspectorInstrumentation::didCloseWebSocketImpl):
(WebCore::InspectorInstrumentation::retrieveResourceAgent):
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::setFrontend):
(WebCore::InspectorResourceAgent::clearFrontend):
(WebCore::InspectorResourceAgent::restore):
(WebCore::InspectorResourceAgent::~InspectorResourceAgent):
(WebCore::InspectorResourceAgent::enable):
(WebCore::InspectorResourceAgent::disable):
(WebCore::InspectorResourceAgent::InspectorResourceAgent):
* inspector/InspectorResourceAgent.h:
(WebCore::InspectorResourceAgent::create):
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::restore):
* inspector/InspectorTimelineAgent.h:
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkManager):
(WebInspector.NetworkManager.prototype.frontendReused):
* inspector/front-end/inspector.js:
(WebInspector.frontendReused):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80239
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Thu, 3 Mar 2011 15:02:54 +0000 (15:02 +0000)]
2011-03-03 Philippe Normand <pnormand@igalia.com>
Unreviewed, skip failing test on GTK.
* platform/gtk/Skipped: Skip fast/canvas/rgba-parsing.html
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80238
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 3 Mar 2011 14:31:36 +0000 (14:31 +0000)]
Make Windows 7 Release (Tests) a core builder
We can probably make Windows XP Debug (Tests) a core builder, too, but we should probably
give it a few more days of greenness first.
Fixes <http://webkit.org/b/55665> Windows 7 Release (Tests) should be a core builder
Reviewed by Andreas Kling.
* Scripts/webkitpy/common/net/buildbot/buildbot.py:
(BuildBot): Added a regexp to match Windows 7 Release (Tests).
* Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
(BuildBotTest): Updated the list of builders to match the current list on build.webkit.org.
Updated the core regexps to match the buildbot module. Updated the expected results to match
the current set of core builders.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80237
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Thu, 3 Mar 2011 14:28:47 +0000 (14:28 +0000)]
2011-03-03 Philippe Normand <pnormand@igalia.com>
Unreviewed, GTK baselines for new tests.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80236
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abecsi@webkit.org [Thu, 3 Mar 2011 13:48:10 +0000 (13:48 +0000)]
2011-03-03 Andras Becsi <abecsi@webkit.org>
Reviewed by Andreas Kling.
CSS RGBA fast-path color parsing should clamp of out-of-range alpha values
https://bugs.webkit.org/show_bug.cgi?id=55661
Test case originally written by Andreas Kling <andreas.kling@nokia.com>
Add a test of rgba() color parsing for the edge cases.
* fast/canvas/rgba-parsing-expected.txt: Added.
* fast/canvas/rgba-parsing.html: Added.
* fast/canvas/script-tests/rgba-parsing.js: Added.
(parse):
2011-03-03 Andras Becsi <abecsi@webkit.org>
Reviewed by Andreas Kling.
CSS RGBA fast-path color parsing should clamp of out-of-range alpha values
https://bugs.webkit.org/show_bug.cgi?id=55661
Test case originally written by Andreas Kling <andreas.kling@nokia.com>
Test: fast/canvas/rgba-parsing.html
* css/CSSParser.cpp:
(WebCore::isValidDouble): Check whether the given string is a valid double.
(WebCore::parseAlphaValue): Out-of-range alpha values should be clamped to the (0.0, 1.0) range.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80235
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antonm@chromium.org [Thu, 3 Mar 2011 13:43:23 +0000 (13:43 +0000)]
Unreviewed. Making expectations platform specific.
* platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum
* platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum
* platform/chromium-mac/fast/blockflow/Kusa-Makura-background-canvas-expected.png
* platform/chromium-mac/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum
* platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-rl-expected.png
* platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-lr-expected.png
* platform/chromium-mac-leopard/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum
* platform/chromium-mac-leopard/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum
* platform/chromium-mac-leopard/fast/blockflow/Kusa-Makura-background-canvas-expected.png
* platform/chromium-mac-leopard/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum
* platform/chromium-mac-leopard/fast/blockflow/japanese-ruby-vertical-lr-expected.png
* platform/chromium-mac-leopard/fast/blockflow/japanese-ruby-vertical-rl-expected.png
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80234
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
benjamin.poulain@nokia.com [Thu, 3 Mar 2011 12:16:51 +0000 (12:16 +0000)]
Adding myself as a reviewer.
Reviewed by Andreas Kling.
* Scripts/webkitpy/common/config/committers.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80233
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 3 Mar 2011 12:15:09 +0000 (12:15 +0000)]
2011-03-03 David Holloway <dhollowa@chromium.org>
Reviewed by Dimitri Glazkov.
Changes HTMLTextFormControlElement::placeholderShouldBeVisible to account
for non-empty suggestion text. The visibility of the placeholder text
now turned off when suggestion text is set.
https://bugs.webkit.org/show_bug.cgi?id=55245
No new tests because, by design, the suggestion text is not accessible
through the DOM.
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::placeholderShouldBeVisible):
* html/HTMLFormControlElement.h:
(WebCore::HTMLTextFormControlElement::isEmptySuggestedValue):
* html/HTMLInputElement.h:
(WebCore::HTMLInputElement::isEmptySuggestedValue):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80232
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aestes@apple.com [Thu, 3 Mar 2011 12:13:36 +0000 (12:13 +0000)]
2011-03-03 Andy Estes <aestes@apple.com>
Reviewed by Eric Seidel.
HTML5 TreeBuilder regressed a Peacekeeper DOM test by 25% (was 40%)
https://bugs.webkit.org/show_bug.cgi?id=48719
Instead of pushing a fake HTMLHtmlElement onto the open element stack
during fragment parsing only to later remove it and reparent its
children to the DocumentFragment, push the DocumentFragment directly
onto the open element stack as the root node. This requires refactoring
HTMLElementStack to hold ContainerNode pointers rather than Element
pointers, which has implications for HTMLConstructionSite and
HTMLTreeBuilder as well.
With this patch, the regression in Peacekeeper from Safari 5.0.3 to ToT
is ~14%. However, if you discount the 'domDynamicCreationCreateElement'
test, ToT is now ~4% faster than Safari 5.0.3. This indicates that the
regression no longer lies in fragment parsing.
No new tests. No change in behavior.
* dom/Element.h:
(WebCore::Node::hasLocalName):
* dom/Node.h:
* html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLNames::hasImpliedEndTag):
(WebCore::HTMLConstructionSite::HTMLConstructionSite):
(WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagInBody):
(WebCore::HTMLConstructionSite::insertComment):
(WebCore::HTMLConstructionSite::insertCommentOnHTMLHtmlElement):
(WebCore::HTMLConstructionSite::attachToCurrent):
(WebCore::HTMLConstructionSite::insertScriptElement):
(WebCore::HTMLConstructionSite::insertTextNode):
(WebCore::HTMLConstructionSite::createElement):
(WebCore::HTMLConstructionSite::createHTMLElement):
(WebCore::HTMLConstructionSite::generateImpliedEndTagsWithExclusion):
(WebCore::HTMLConstructionSite::generateImpliedEndTags):
(WebCore::HTMLConstructionSite::findFosterSite):
(WebCore::HTMLConstructionSite::shouldFosterParent):
* html/parser/HTMLConstructionSite.h:
(WebCore::HTMLConstructionSite::currentNode):
* html/parser/HTMLElementStack.cpp:
(WebCore::HTMLNames::isNumberedHeaderElement):
(WebCore::HTMLNames::isScopeMarker):
(WebCore::HTMLNames::isListItemScopeMarker):
(WebCore::HTMLNames::isTableScopeMarker):
(WebCore::HTMLNames::isTableBodyScopeMarker):
(WebCore::HTMLNames::isTableRowScopeMarker):
(WebCore::HTMLNames::isButtonScopeMarker):
(WebCore::HTMLNames::isSelectScopeMarker):
(WebCore::HTMLElementStack::ElementRecord::ElementRecord):
(WebCore::HTMLElementStack::ElementRecord::replaceElement):
(WebCore::HTMLElementStack::HTMLElementStack):
(WebCore::HTMLElementStack::secondElementIsHTMLBodyElement):
(WebCore::HTMLElementStack::popAll):
(WebCore::HTMLElementStack::popUntilNumberedHeaderElementPopped):
(WebCore::HTMLElementStack::popUntil):
(WebCore::HTMLElementStack::popUntilPopped):
(WebCore::HTMLElementStack::popUntilTableScopeMarker):
(WebCore::HTMLElementStack::popUntilTableBodyScopeMarker):
(WebCore::HTMLElementStack::popUntilTableRowScopeMarker):
(WebCore::HTMLElementStack::pushHTMLHtmlElement):
(WebCore::HTMLElementStack::push):
(WebCore::HTMLElementStack::insertAbove):
(WebCore::HTMLElementStack::find):
(WebCore::HTMLElementStack::topmost):
(WebCore::HTMLElementStack::contains):
(WebCore::inScopeCommon):
(WebCore::HTMLElementStack::hasNumberedHeaderElementInScope):
(WebCore::HTMLElementStack::htmlElement):
(WebCore::HTMLElementStack::rootNode):
(WebCore::HTMLElementStack::pushCommon):
* html/parser/HTMLElementStack.h:
(WebCore::HTMLElementStack::ElementRecord::element):
(WebCore::HTMLElementStack::ElementRecord::node):
(WebCore::HTMLElementStack::topNode):
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
(WebCore::HTMLTreeBuilder::processCloseWhenNestedTag):
(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::processColgroupEndTagForInColumnGroup):
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody):
(WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
(WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately):
(WebCore::HTMLTreeBuilder::processEndTagForInCell):
(WebCore::HTMLTreeBuilder::processEndTagForInBody):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::processEndOfFile):
(WebCore::HTMLTreeBuilder::finished):
* html/parser/HTMLTreeBuilder.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80231
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Thu, 3 Mar 2011 11:58:46 +0000 (11:58 +0000)]
2011-03-03 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: inspector protocol should allow different domains to have methods with same name
https://bugs.webkit.org/show_bug.cgi?id=55558
* inspector/report-protocol-errors-expected.txt:
* inspector/report-protocol-errors.html:
2011-03-02 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: inspector protocol should allow different domains to have methods with same name
https://bugs.webkit.org/show_bug.cgi?id=55558
* inspector/CodeGeneratorInspector.pm: each command is now identified by domain + command-name(was command-name only).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80230
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 3 Mar 2011 11:28:10 +0000 (11:28 +0000)]
2011-03-03 Dominic Mazzoni <dmazzoni@google.com>
Reviewed by Dimitri Glazkov.
Add an equals() method to WebAccessibilityObject.
https://bugs.webkit.org/show_bug.cgi?id=55631
* public/WebAccessibilityObject.h:
* src/WebAccessibilityObject.cpp:
(WebKit::WebAccessibilityObject::equals):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80229
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Thu, 3 Mar 2011 11:27:00 +0000 (11:27 +0000)]
2011-03-02 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: make selected call frame debugger presentation model property.
https://bugs.webkit.org/show_bug.cgi?id=55582
* inspector/front-end/CallStackSidebarPane.js:
(WebInspector.CallStackSidebarPane):
(WebInspector.CallStackSidebarPane.prototype.update):
(WebInspector.CallStackSidebarPane.prototype.set selectedCallFrame):
(WebInspector.CallStackSidebarPane.prototype._selectedCallFrameIndex):
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype.completions):
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame):
(WebInspector.DebuggerPresentationModel.prototype.get selectedCallFrame):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
(WebInspector.ScriptsPanel.prototype.getCompletionsOnCallFrame):
(WebInspector.ScriptsPanel.prototype._debuggerResumed):
(WebInspector.ScriptsPanel.prototype._sourceFrameLoaded):
(WebInspector.ScriptsPanel.prototype._callFrameSelected):
2011-03-03 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: make selected call frame debugger presentation model property.
https://bugs.webkit.org/show_bug.cgi?id=55582
* src/js/Tests.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80228
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 3 Mar 2011 11:21:33 +0000 (11:21 +0000)]
2011-03-03 Kenji Imasaki <imasaki@chromium.org>
Reviewed by David Levin.
[Chromium] Remove non-flaky tests and update bugs/comments in
media related layout tests in test expectation
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80227
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 3 Mar 2011 11:13:52 +0000 (11:13 +0000)]
2011-03-03 Jia Pu <jpu@apple.com>
Reviewed by Darin Adler.
On Mac OS X, spelling suggestion panel stops showing up after change set 80121
https://bugs.webkit.org/show_bug.cgi?id=55628
Rebaselined tests affected by changeset 80121.
* platform/mac/editing/spelling/autocorrection-contraction-expected.txt:
* platform/mac/editing/spelling/autocorrection-delete-expected.txt:
* platform/mac/editing/spelling/autocorrection-removing-underline-after-paste-expected.txt:
* platform/mac/editing/spelling/autocorrection-removing-underline-expected.txt:
* platform/mac/editing/spelling/autocorrection-simple-expected.txt:
* platform/mac/editing/spelling/click-autocorrected-word-expected.txt:
* platform/mac/editing/spelling/click-autocorrected-word.html:
* platform/mac/editing/spelling/delete-autocorrected-word-1-expected.txt:
* platform/mac/editing/spelling/delete-into-autocorrected-word-expected.checksum:
* platform/mac/editing/spelling/delete-into-autocorrected-word-expected.png:
* platform/mac/editing/spelling/delete-into-autocorrected-word-expected.txt:
* platform/mac/editing/spelling/delete-into-autocorrected-word.html:
* platform/mac/editing/spelling/forward-delete-into-autocorrected-word-expected.checksum:
* platform/mac/editing/spelling/forward-delete-into-autocorrected-word-expected.png:
* platform/mac/editing/spelling/forward-delete-into-autocorrected-word-expected.txt:
* platform/mac/editing/spelling/forward-delete-into-autocorrected-word.html:
* platform/mac/editing/spelling/move-cursor-to-autocorrected-word-expected.checksum:
* platform/mac/editing/spelling/move-cursor-to-autocorrected-word-expected.png:
* platform/mac/editing/spelling/move-cursor-to-autocorrected-word-expected.txt:
* platform/mac/editing/spelling/move-cursor-to-autocorrected-word.html:
* platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word-expected.checksum:
* platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word-expected.png:
* platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word-expected.txt:
* platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word.html:
* platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation-expected.txt:
2011-03-03 Jia Pu <jpu@apple.com>
Reviewed by Darin Adler.
On Mac OS X, spelling suggestion panel stops showing up after change set 80121
https://bugs.webkit.org/show_bug.cgi?id=55628
Removed a call to stopCorrectionPanelTimer() to fix a regression introduced by changeset 80121.
* editing/Editor.cpp:
(WebCore::Editor::appliedEditing):
* manual-tests/autocorrection/autocorrection-contraction.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80226
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 3 Mar 2011 11:06:35 +0000 (11:06 +0000)]
2011-03-03 Lukasz Slachciak <l.slachciak@samsung.com>
Reviewed by Xan Lopez.
[GTK] Extended application cache database API and added unit tests file.
https://bugs.webkit.org/show_bug.cgi?id=55335
* GNUmakefile.am: Add testapplicationcache.c and remove webkitapplicationcacheprivate.h.
* tests/testapplicationcache.c: Added.
(test_applicationcache_maximum_size): Tests if application cache storage is set/get correctly.
(test_applicationcache_database_directory_path): Tests if application cache directory path is set/get correctly.
(main):
* webkit/webkitapplicationcache.cpp:
(webkit_application_cache_get_maximum_size): New API for getting application cache maximum storage size.
* webkit/webkitapplicationcache.h: Declaration of API for getting/setting application cache maximum storage size.
2011-03-03 Lukasz Slachciak <l.slachciak@samsung.com>
Reviewed by Xan Lopez.
[GTK] Extended application cache database API and added unit tests file.
https://bugs.webkit.org/show_bug.cgi?id=55335
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: removed external declaration
of webkit_application_cache_set_maximum_size due to API exposal.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80225
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Thu, 3 Mar 2011 11:03:32 +0000 (11:03 +0000)]
2011-03-03 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: rename "sourceName" to "sourceFileId" in ScriptsPanel.js.
https://bugs.webkit.org/show_bug.cgi?id=55569
* inspector/debugger/scripts-panel.html:
2011-03-03 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: rename "sourceName" to "sourceFileId" in ScriptsPanel.js.
https://bugs.webkit.org/show_bug.cgi?id=55569
sourceFileId better reflects the intention to have unique identifier for each source that is shown in scripts panel.
* inspector/front-end/DebuggerPresentationModel.js:
* inspector/front-end/ScriptsPanel.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80224
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jeremy@chromium.org [Thu, 3 Mar 2011 10:58:33 +0000 (10:58 +0000)]
2011-03-03 Jeremy Moskovich <jeremy@chromium.org>
Reviewed by Dimitri Glazkov.
Convert offsetLeft-offsetTop-borders.html to dumpAsText()
https://bugs.webkit.org/show_bug.cgi?id=55612
This test outputs the values of offsetLeft/offsetTop for portions
of the DOM. It appears it would do just as well as a text-based test.
* fast/block/positioning/offsetLeft-offsetTop-borders-expected.txt: Added.
* fast/block/positioning/offsetLeft-offsetTop-borders.html:
* platform/chromium-linux/fast/block/positioning/offsetLeft-offsetTop-borders-expected.checksum: Removed.
* platform/chromium-linux/fast/block/positioning/offsetLeft-offsetTop-borders-expected.png: Removed.
* platform/chromium-win/fast/block/positioning/offsetLeft-offsetTop-borders-expected.checksum: Removed.
* platform/chromium-win/fast/block/positioning/offsetLeft-offsetTop-borders-expected.png: Removed.
* platform/chromium-win/fast/block/positioning/offsetLeft-offsetTop-borders-expected.txt: Removed.
* platform/gtk/fast/block/positioning/offsetLeft-offsetTop-borders-expected.checksum: Removed.
* platform/gtk/fast/block/positioning/offsetLeft-offsetTop-borders-expected.png: Removed.
* platform/gtk/fast/block/positioning/offsetLeft-offsetTop-borders-expected.txt: Removed.
* platform/mac-leopard/fast/block/positioning/offsetLeft-offsetTop-borders-expected.checksum: Removed.
* platform/mac-leopard/fast/block/positioning/offsetLeft-offsetTop-borders-expected.png: Removed.
* platform/mac/fast/block/positioning/offsetLeft-offsetTop-borders-expected.checksum: Removed.
* platform/mac/fast/block/positioning/offsetLeft-offsetTop-borders-expected.png: Removed.
* platform/mac/fast/block/positioning/offsetLeft-offsetTop-borders-expected.txt: Removed.
* platform/qt/fast/block/positioning/offsetLeft-offsetTop-borders-expected.txt: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80223
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
steveblock@google.com [Thu, 3 Mar 2011 10:51:05 +0000 (10:51 +0000)]
2011-03-03 Steve Block <steveblock@google.com>
Reviewed by David Levin.
JavaString API should be implementable by both JSC and V8
https://bugs.webkit.org/show_bug.cgi?id=55567
Remove JavaString's UString operator and replace it with a
script-engine-independent impl() method, which returns a
StringImpl and can be implemented with both JSC and V8.
No new tests, refactoring only.
* bridge/jni/JNIBridge.h:
(JSC::Bindings::JavaString::impl):
* bridge/jni/jni_jsobject.mm:
(JavaJSObject::call):
(JavaJSObject::eval):
(JavaJSObject::getMember):
(JavaJSObject::setMember):
(JavaJSObject::removeMember):
* bridge/jni/jsc/JNIBridgeJSC.cpp:
(JavaField::valueFromInstance):
(JavaField::setValueToInstance):
* bridge/jni/jsc/JavaClassJSC.cpp:
(JavaClass::JavaClass):
* bridge/jni/jsc/JavaInstanceJSC.cpp:
(JavaInstance::invokeMethod):
* bridge/jni/jsc/JavaStringJSC.h:
(JSC::Bindings::JavaStringImpl::impl):
* bridge/jni/v8/JavaStringV8.h:
(JSC::Bindings::JavaStringImpl::impl):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80222
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 3 Mar 2011 10:44:39 +0000 (10:44 +0000)]
2011-03-03 Benjamin Poulain <ikipou@gmail.com>
Reviewed by Adam Roben.
REGRESSION (r79817): Lots of leaks of FloatingObjects seen on SnowLeopard Intel Leaks bot
https://bugs.webkit.org/show_bug.cgi?id=55602
Delete the FloatingObject referenced by m_floatingObjects when clearing the floats.
The DeprecatedPtrList was deleting the objects automatically due to its autoDelete behavior. The
objects need to be deleted manually with ListHashSet.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::clearFloats):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80221
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hans@chromium.org [Thu, 3 Mar 2011 10:37:41 +0000 (10:37 +0000)]
2011-03-03 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
IndexedDB: Move SQL code, especially for cursors, to IDBBackingStore
https://bugs.webkit.org/show_bug.cgi?id=55376
Move SQL code from IDBKey, IDBKeyRange, IDBIndexBackendImpl,
IDBObjectStoreBackendImpl, and especially IDBCursorBackendImpl.
No new functionality, so no new tests.
* storage/IDBBackingStore.cpp:
(WebCore::lowerCursorWhereFragment):
(WebCore::upperCursorWhereFragment):
(WebCore::IDBBackingStore::deleteObjectStoreRecord):
(WebCore::IDBBackingStore::keyExistsInObjectStore):
(WebCore::IDBBackingStore::getObjectViaIndex):
(WebCore::keyFromQuery):
(WebCore::IDBBackingStore::getPrimaryKeyViaIndex):
(WebCore::IDBBackingStore::keyExistsInIndex):
(WebCore::CursorImplCommon::CursorImplCommon::continueInternal):
(WebCore::CursorImplCommon::ObjectStoreCursorImpl::ObjectStoreCursorImpl):
(WebCore::CursorImplCommon::ObjectStoreCursorImpl::objectStoreDataId):
(WebCore::CursorImplCommon::ObjectStoreCursorImpl::key):
(WebCore::CursorImplCommon::ObjectStoreCursorImpl::value):
(WebCore::CursorImplCommon::ObjectStoreCursorImpl::continueFunction):
(WebCore::IDBBackingStore::openObjectStoreCursor):
(WebCore::ObjectStoreCursorImpl::loadCurrentRow):
(WebCore::ObjectStoreCursorImpl::currentRowExists):
(WebCore::IndexKeyCursorImpl::IndexKeyCursorImpl):
(WebCore::IndexKeyCursorImpl::indexDataId):
(WebCore::IndexKeyCursorImpl::key):
(WebCore::IndexKeyCursorImpl::primaryKey):
(WebCore::IndexKeyCursorImpl::continueFunction):
(WebCore::IDBBackingStore::openIndexKeyCursor):
(WebCore::IndexKeyCursorImpl::loadCurrentRow):
(WebCore::IndexKeyCursorImpl::currentRowExists):
(WebCore::IndexCursorImpl::IndexCursorImpl):
(WebCore::IndexCursorImpl::indexDataId):
(WebCore::IndexCursorImpl::key):
(WebCore::IndexCursorImpl::primaryKey):
(WebCore::IndexCursorImpl::value):
(WebCore::IndexCursorImpl::continueFunction):
(WebCore::IDBBackingStore::openIndexCursor):
(WebCore::IndexCursorImpl::loadCurrentRow):
(WebCore::IndexCursorImpl::currentRowExists):
* storage/IDBBackingStore.h:
(WebCore::IDBBackingStore::Cursor::~Cursor):
* storage/IDBCursorBackendImpl.cpp:
(WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl):
(WebCore::IDBCursorBackendImpl::key):
(WebCore::IDBCursorBackendImpl::value):
(WebCore::IDBCursorBackendImpl::update):
(WebCore::IDBCursorBackendImpl::continueFunctionInternal):
(WebCore::IDBCursorBackendImpl::deleteFunction):
* storage/IDBCursorBackendImpl.h:
(WebCore::IDBCursorBackendImpl::create):
* storage/IDBIndexBackendImpl.cpp:
(WebCore::IDBIndexBackendImpl::openCursorInternal):
(WebCore::IDBIndexBackendImpl::getInternal):
(WebCore::IDBIndexBackendImpl::addingKeyAllowed):
* storage/IDBIndexBackendImpl.h:
* storage/IDBKey.cpp:
(WebCore::IDBKey::isEqual):
* storage/IDBKey.h:
* storage/IDBKeyRange.cpp:
* storage/IDBKeyRange.h:
* storage/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::putInternal):
(WebCore::IDBObjectStoreBackendImpl::deleteInternal):
(WebCore::IDBObjectStoreBackendImpl::openCursorInternal):
* storage/IDBObjectStoreBackendImpl.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80220
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 3 Mar 2011 10:28:47 +0000 (10:28 +0000)]
2011-03-03 Bill Budge <bbudge@chromium.org>
Reviewed by David Levin.
AssociatedURLLoader does not support Cross Origin Requests
https://bugs.webkit.org/show_bug.cgi?id=53925
No tests needed. Exposes no new functionality.
* src/AssociatedURLLoader.cpp:
(WebKit::AssociatedURLLoader::ClientAdapter::create):
(WebKit::AssociatedURLLoader::ClientAdapter::ClientAdapter):
(WebKit::AssociatedURLLoader::ClientAdapter::willSendRequest):
(WebKit::AssociatedURLLoader::ClientAdapter::didSendData):
(WebKit::AssociatedURLLoader::ClientAdapter::didReceiveResponse):
(WebKit::AssociatedURLLoader::ClientAdapter::didReceiveData):
(WebKit::AssociatedURLLoader::ClientAdapter::didReceiveCachedMetadata):
(WebKit::AssociatedURLLoader::ClientAdapter::didFinishLoading):
(WebKit::AssociatedURLLoader::ClientAdapter::didFail):
(WebKit::AssociatedURLLoader::AssociatedURLLoader):
(WebKit::AssociatedURLLoader::~AssociatedURLLoader):
(WebKit::AssociatedURLLoader::loadSynchronously):
(WebKit::AssociatedURLLoader::loadAsynchronously):
(WebKit::AssociatedURLLoader::cancel):
(WebKit::AssociatedURLLoader::setDefersLoading):
* src/AssociatedURLLoader.h:
(WebKit::AssociatedURLLoaderOptions::AssociatedURLLoaderOptions):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80219
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 3 Mar 2011 10:24:49 +0000 (10:24 +0000)]
2011-03-03 Peter Kasting <pkasting@google.com>
Reviewed by James Robinson.
Drop redundant "Windows; " from the Windows-specific User Agent string.
https://bugs.webkit.org/show_bug.cgi?id=54567
* http/tests/navigation/useragent-expected.txt:
* http/tests/navigation/useragent.php:
2011-03-03 Peter Kasting <pkasting@google.com>
Reviewed by James Robinson.
Drop redundant "Windows; " from the Windows-specific User Agent string.
https://bugs.webkit.org/show_bug.cgi?id=54567
* StringsNotToBeLocalized.txt:
2011-03-03 Peter Kasting <pkasting@google.com>
Reviewed by James Robinson.
Drop redundant "Windows; " from the Windows-specific User Agent string.
https://bugs.webkit.org/show_bug.cgi?id=54567
* webkit/webkitwebsettings.cpp:
(webkitPlatform):
(webkitUserAgent):
2011-03-03 Peter Kasting <pkasting@google.com>
Reviewed by James Robinson.
Drop redundant "Windows; " from the Windows-specific User Agent string.
https://bugs.webkit.org/show_bug.cgi?id=54567
* Api/qwebpage.cpp:
(QWebPage::userAgentForUrl):
2011-03-03 Peter Kasting <pkasting@google.com>
Reviewed by James Robinson.
Drop redundant "Windows; " from the Windows-specific User Agent string.
https://bugs.webkit.org/show_bug.cgi?id=54567
* WebView.cpp:
(WebView::standardUserAgentWithApplicationName):
2011-03-03 Peter Kasting <pkasting@google.com>
Reviewed by James Robinson.
Drop redundant "Windows; " from the Windows-specific User Agent string.
https://bugs.webkit.org/show_bug.cgi?id=54567
* UIProcess/win/WebPageProxyWin.cpp:
(WebKit::WebPageProxy::standardUserAgent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80218
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pvarga@webkit.org [Thu, 3 Mar 2011 10:22:56 +0000 (10:22 +0000)]
2011-03-03 Peter Varga <pvarga@webkit.org>
Reviewed by Oliver Hunt.
Begin Characters Optimization Causes YARR Interpreter Errors
https://bugs.webkit.org/show_bug.cgi?id=55479
The addBeginTerm function is removed because it doesn't correctly handle those
cases when an "invalid" term has been
collected (e.g. CharacterClass). Move the removed function to the
setupAlternativeBeginTerms method's switch-case
where the non-allowed cases are correctly handled.
Reenable the Beginning Character Optimization in the YARR Interpreter again.
* fast/js/regexp-alternatives-expected.txt: Added.
* fast/js/regexp-alternatives.html: Added.
* fast/js/script-tests/regexp-alternatives.js: Added.
2011-03-03 Peter Varga <pvarga@webkit.org>
Reviewed by Oliver Hunt.
Begin Characters Optimization Causes YARR Interpreter Errors
https://bugs.webkit.org/show_bug.cgi?id=55479
The addBeginTerm function is removed because it doesn't correctly handle those
cases when an "invalid" term has been
collected (e.g. CharacterClass). Move the removed function to the
setupAlternativeBeginTerms method's switch-case
where the non-allowed cases are correctly handled.
Reenable the Beginning Character Optimization in the YARR Interpreter again.
* yarr/YarrPattern.cpp:
(JSC::Yarr::YarrPatternConstructor::setupAlternativeBeginTerms):
(JSC::Yarr::YarrPattern::compile):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80217
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Thu, 3 Mar 2011 10:09:12 +0000 (10:09 +0000)]
2011-03-03 Philippe Normand <pnormand@igalia.com>
Unreviewed, unskip tests fixed by r80214 on GTK.
* platform/gtk/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80216
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 3 Mar 2011 09:33:13 +0000 (09:33 +0000)]
2011-03-03 Steve Lacey <sjl@chromium.org>
Reviewed by Darin Fisher.
Wire up webkit metrics changes to chromium changes.
https://bugs.webkit.org/show_bug.cgi?id=54580
* features.gypi:
* public/WebMediaPlayer.h:
* src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::decodedFrameCount):
(WebKit::WebMediaPlayerClientImpl::droppedFrameCount):
(WebKit::WebMediaPlayerClientImpl::audioDecodedByteCount):
(WebKit::WebMediaPlayerClientImpl::videoDecodedByteCount):
* src/WebMediaPlayerClientImpl.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80215
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 3 Mar 2011 09:00:17 +0000 (09:00 +0000)]
2011-03-03 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Martin Robinson.
[GTK] Combo boxes should emit object:selection-changed even when collapsed
https://bugs.webkit.org/show_bug.cgi?id=53146
New GTK-specific layout test to check the right signals are emitted.
* platform/gtk/accessibility/combo-box-collapsed-selection-changed-expected.txt: Added.
* platform/gtk/accessibility/combo-box-collapsed-selection-changed.html: Added.
2011-03-03 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Martin Robinson.
[GTK] Combo boxes should emit object:selection-changed even when collapsed
https://bugs.webkit.org/show_bug.cgi?id=53146
Emit the selection-changed signals when the menu list value has changed
Test: platform/gtk/accessibility/combo-box-collapsed-selection-changed.html
* accessibility/gtk/AXObjectCacheAtk.cpp:
(WebCore::getListObject): New, return the right list object for
menu lists and list boxes.
(WebCore::notifyChildrenSelectionChange): Support menu lists.
(WebCore::AXObjectCache::postPlatformNotification): Call function
notifyChildrenSelectionChange for AXMenuListValueChanged.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80214
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Thu, 3 Mar 2011 08:35:09 +0000 (08:35 +0000)]
2011-03-03 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
applyInlineStyleToPushDown and removeInlineStyleFromElement should take EditingStyle
https://bugs.webkit.org/show_bug.cgi?id=55338
Include wtf/Forward.h instead of wtf/text/String.h
* editing/EditingStyle.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80213
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Thu, 3 Mar 2011 08:32:33 +0000 (08:32 +0000)]
Unreviewed trivial fix after r80169.
[Qt][WK2] Memory exhausted when building qtwebkit2 on linux
https://bugs.webkit.org/show_bug.cgi?id=55484
* WebCore.pro: Typo fix. We have to use linux-g++* instead of linux-g++.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80212
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Thu, 3 Mar 2011 08:02:02 +0000 (08:02 +0000)]
2011-03-02 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
make webkit-patch upload work for security bugs
https://bugs.webkit.org/show_bug.cgi?id=55655
The problem is that we shell out to prepare-ChangeLog,
which does not authenticate with bugzilla. All it needs from
bugzilla is the bug title though. We just pass it through from
webkit-patch instead.
* Scripts/prepare-ChangeLog:
* Scripts/webkitpy/common/net/bugzilla/bug.py:
* Scripts/webkitpy/tool/steps/preparechangelog.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80211
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Thu, 3 Mar 2011 06:28:57 +0000 (06:28 +0000)]
2011-03-02 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
[Refactoring] Make ScheduledEvent on FrameView abstract out to ScheduleAction
https://bugs.webkit.org/show_bug.cgi?id=54440
- Extracted FrameActionScheduler from FrameView
- Extracted FrameAction abstract class from ScheduledEvent,
which has fire() virtual method.
- Renamed ScheduledEvent EventFrameAction
With this change, Any action can be hooked up to the end of the layout.
No new tests. No behavioral change.
* Android.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* page/FrameActionScheduler.cpp: Added.
(WebCore::EventFrameAction::EventFrameAction):
(WebCore::EventFrameAction::fire):
(WebCore::FrameActionScheduler::FrameActionScheduler):
(WebCore::FrameActionScheduler::~FrameActionScheduler):
(WebCore::FrameActionScheduler::isEmpty):
(WebCore::FrameActionScheduler::clear):
(WebCore::FrameActionScheduler::pause):
(WebCore::FrameActionScheduler::resume):
(WebCore::FrameActionScheduler::dispatch):
(WebCore::FrameActionScheduler::scheduleAction):
(WebCore::FrameActionScheduler::scheduleEvent):
* page/FrameActionScheduler.h: Added.
(WebCore::FrameAction::FrameAction):
(WebCore::FrameAction::~FrameAction):
(WebCore::FrameActionScheduler::isScheduled):
* page/FrameView.cpp:
(WebCore::FrameView::FrameView):
(WebCore::FrameView::~FrameView):
(WebCore::FrameView::layout):
(WebCore::FrameView::scheduleEvent):
(WebCore::FrameView::pauseScheduledEvents):
(WebCore::FrameView::resumeScheduledEvents):
(WebCore::FrameView::performPostLayoutTasks):
(WebCore::FrameView::updateOverflowStatus):
* page/FrameView.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80210
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Thu, 3 Mar 2011 06:18:55 +0000 (06:18 +0000)]
2011-03-02 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r80201.
http://trac.webkit.org/changeset/80201
https://bugs.webkit.org/show_bug.cgi?id=55648
"caused tests to crash on several bots" (Requested by rniwa on
#webkit).
* dom/Element.h:
(WebCore::Node::hasTagName):
* dom/Node.h:
* html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLNames::hasImpliedEndTag):
(WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagInBody):
(WebCore::HTMLConstructionSite::insertComment):
(WebCore::HTMLConstructionSite::insertCommentOnHTMLHtmlElement):
(WebCore::HTMLConstructionSite::attachToCurrent):
(WebCore::HTMLConstructionSite::insertScriptElement):
(WebCore::HTMLConstructionSite::insertTextNode):
(WebCore::HTMLConstructionSite::createElement):
(WebCore::HTMLConstructionSite::createHTMLElement):
(WebCore::HTMLConstructionSite::generateImpliedEndTagsWithExclusion):
(WebCore::HTMLConstructionSite::generateImpliedEndTags):
(WebCore::HTMLConstructionSite::findFosterSite):
(WebCore::HTMLConstructionSite::shouldFosterParent):
* html/parser/HTMLConstructionSite.h:
* html/parser/HTMLElementStack.cpp:
(WebCore::HTMLNames::isNumberedHeaderElement):
(WebCore::HTMLNames::isScopeMarker):
(WebCore::HTMLNames::isListItemScopeMarker):
(WebCore::HTMLNames::isTableScopeMarker):
(WebCore::HTMLNames::isTableBodyScopeMarker):
(WebCore::HTMLNames::isTableRowScopeMarker):
(WebCore::HTMLNames::isButtonScopeMarker):
(WebCore::HTMLNames::isSelectScopeMarker):
(WebCore::HTMLElementStack::ElementRecord::ElementRecord):
(WebCore::HTMLElementStack::ElementRecord::replaceElement):
(WebCore::HTMLElementStack::HTMLElementStack):
(WebCore::HTMLElementStack::secondElementIsHTMLBodyElement):
(WebCore::HTMLElementStack::popAll):
(WebCore::HTMLElementStack::popUntilTableScopeMarker):
(WebCore::HTMLElementStack::popUntilTableBodyScopeMarker):
(WebCore::HTMLElementStack::popUntilTableRowScopeMarker):
(WebCore::HTMLElementStack::popUntilForeignContentScopeMarker):
(WebCore::HTMLElementStack::pushHTMLHtmlElement):
(WebCore::HTMLElementStack::push):
(WebCore::HTMLElementStack::insertAbove):
(WebCore::HTMLElementStack::find):
(WebCore::HTMLElementStack::topmost):
(WebCore::inScopeCommon):
(WebCore::HTMLElementStack::hasNumberedHeaderElementInScope):
(WebCore::HTMLElementStack::htmlElement):
(WebCore::HTMLElementStack::bodyElement):
(WebCore::HTMLElementStack::pushCommon):
* html/parser/HTMLElementStack.h:
(WebCore::HTMLElementStack::ElementRecord::element):
(WebCore::HTMLElementStack::top):
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
(WebCore::HTMLTreeBuilder::FragmentParsingContext::finished):
(WebCore::HTMLTreeBuilder::processCloseWhenNestedTag):
(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::processColgroupEndTagForInColumnGroup):
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody):
(WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
(WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately):
(WebCore::HTMLTreeBuilder::processEndTagForInCell):
(WebCore::HTMLTreeBuilder::processEndTagForInBody):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::processEndOfFile):
(WebCore::HTMLTreeBuilder::finished):
* html/parser/HTMLTreeBuilder.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80209
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Thu, 3 Mar 2011 06:12:41 +0000 (06:12 +0000)]
2011-03-02 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium Snow Leopard baseline update
With the exception of fast/repaint/select-option-background-color.html
and fast/repaint/slider-thumb-drag-release.html (which didn't have any
SL baselines at all), this was updating of baselines after r78846.
* platform/chromium-mac-leopard/fast/repaint/select-option-background-color-expected.checksum: Copied from LayoutTests/platform/chromium-mac/fast/repaint/select-option-background-color-expected.checksum.
* platform/chromium-mac-leopard/fast/repaint/select-option-background-color-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/repaint/select-option-background-color-expected.png.
* platform/chromium-mac-leopard/fast/repaint/slider-thumb-drag-release-expected.checksum: Copied from LayoutTests/platform/chromium-mac/fast/repaint/slider-thumb-drag-release-expected.checksum.
* platform/chromium-mac-leopard/fast/repaint/slider-thumb-drag-release-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/repaint/slider-thumb-drag-release-expected.png.
* platform/chromium-mac/fast/repaint/japanese-rl-selection-clear-expected.checksum:
* platform/chromium-mac/fast/repaint/japanese-rl-selection-clear-expected.png:
* platform/chromium-mac/fast/repaint/japanese-rl-selection-repaint-expected.checksum:
* platform/chromium-mac/fast/repaint/japanese-rl-selection-repaint-expected.png:
* platform/chromium-mac/fast/repaint/line-flow-with-floats-1-expected.checksum:
* platform/chromium-mac/fast/repaint/line-flow-with-floats-1-expected.png:
* platform/chromium-mac/fast/repaint/line-flow-with-floats-10-expected.checksum:
* platform/chromium-mac/fast/repaint/line-flow-with-floats-10-expected.png:
* platform/chromium-mac/fast/repaint/line-flow-with-floats-2-expected.checksum:
* platform/chromium-mac/fast/repaint/line-flow-with-floats-2-expected.png:
* platform/chromium-mac/fast/repaint/line-flow-with-floats-3-expected.checksum:
* platform/chromium-mac/fast/repaint/line-flow-with-floats-3-expected.png:
* platform/chromium-mac/fast/repaint/line-flow-with-floats-4-expected.checksum:
* platform/chromium-mac/fast/repaint/line-flow-with-floats-4-expected.png:
* platform/chromium-mac/fast/repaint/line-flow-with-floats-5-expected.checksum:
* platform/chromium-mac/fast/repaint/line-flow-with-floats-5-expected.png:
* platform/chromium-mac/fast/repaint/line-flow-with-floats-6-expected.checksum:
* platform/chromium-mac/fast/repaint/line-flow-with-floats-6-expected.png:
* platform/chromium-mac/fast/repaint/line-flow-with-floats-7-expected.checksum:
* platform/chromium-mac/fast/repaint/line-flow-with-floats-7-expected.png:
* platform/chromium-mac/fast/repaint/line-flow-with-floats-8-expected.checksum:
* platform/chromium-mac/fast/repaint/line-flow-with-floats-8-expected.png:
* platform/chromium-mac/fast/repaint/line-flow-with-floats-9-expected.checksum:
* platform/chromium-mac/fast/repaint/line-flow-with-floats-9-expected.png:
* platform/chromium-mac/fast/repaint/repaint-across-writing-mode-boundary-expected.checksum:
* platform/chromium-mac/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
* platform/chromium-mac/fast/repaint/select-option-background-color-expected.checksum:
* platform/chromium-mac/fast/repaint/select-option-background-color-expected.png:
* platform/chromium-mac/fast/repaint/slider-thumb-drag-release-expected.checksum:
* platform/chromium-mac/fast/repaint/slider-thumb-drag-release-expected.png:
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80208
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ukai@chromium.org [Thu, 3 Mar 2011 06:10:20 +0000 (06:10 +0000)]
Unreviewed Chromium expectations update
Mark http/tests/cache/subresource-expiration-*.html as SLOW on Win
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80207
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Thu, 3 Mar 2011 05:57:02 +0000 (05:57 +0000)]
2011-03-02 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium expectations update
Clean up svg/ expectations (there were some non-test files with
expectations, as well as a couple of tests that have never failed).
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80206
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Thu, 3 Mar 2011 05:55:38 +0000 (05:55 +0000)]
Fix crashes in private browsing tests in WK1 on Snow Leopard.
Rubber-stamped by Dan Bernstein.
* WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
Put the INIT call for wkCreatePrivateStorageSession outside of the
#if !defined(BUILDING_ON_TIGER) && !defined(BUILDING_ON_LEOPARD) && !defined(BUILDING_ON_SNOW_LEOPARD)
guards.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80205
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Thu, 3 Mar 2011 05:43:34 +0000 (05:43 +0000)]
2011-03-02 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: break down InspectorFrontend into domain-specific classes
https://bugs.webkit.org/show_bug.cgi?id=55584
* inspector/elements/elements-panel-search.html:
2011-03-02 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: break down InspectorFrontend into domain-specific classes
https://bugs.webkit.org/show_bug.cgi?id=55584
* inspector/CodeGeneratorInspector.pm: InspectorFrontend now contains nested classes for
all domains that have event notifications.
* inspector/ConsoleMessage.cpp:
(WebCore::ConsoleMessage::addToFrontend):
(WebCore::ConsoleMessage::updateRepeatCountInConsole):
* inspector/ConsoleMessage.h:
* inspector/InjectedScriptHost.cpp:
(WebCore::InjectedScriptHost::inspectImpl):
* inspector/Inspector.idl:
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::inspectedPageDestroyed):
(WebCore::InspectorAgent::restoreInspectorStateFromCookie):
(WebCore::InspectorAgent::setFrontend):
(WebCore::InspectorAgent::disconnectFrontend):
(WebCore::InspectorAgent::populateScriptObjects):
(WebCore::InspectorAgent::pushDataCollectedOffline):
(WebCore::InspectorAgent::didCommitLoad):
(WebCore::InspectorAgent::domContentLoadedEventFired):
(WebCore::InspectorAgent::loadEventFired):
(WebCore::InspectorAgent::postWorkerNotificationToFrontend):
(WebCore::InspectorAgent::evaluateForTestInFrontend):
(WebCore::InspectorAgent::showPanel):
* inspector/InspectorApplicationCacheAgent.cpp:
(WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent):
* inspector/InspectorApplicationCacheAgent.h:
* inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::setFrontend):
* inspector/InspectorConsoleAgent.h:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::show):
(WebCore::InspectorController::close):
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::setFrontend):
* inspector/InspectorDOMAgent.h:
* inspector/InspectorDOMStorageResource.cpp:
(WebCore::InspectorDOMStorageResource::bind):
* inspector/InspectorDOMStorageResource.h:
* inspector/InspectorDatabaseAgent.cpp:
(WebCore::InspectorDatabaseAgent::FrontendProvider::frontend):
(WebCore::InspectorDatabaseAgent::FrontendProvider::FrontendProvider):
(WebCore::InspectorDatabaseAgent::setFrontend):
* inspector/InspectorDatabaseResource.cpp:
(WebCore::InspectorDatabaseResource::bind):
* inspector/InspectorDatabaseResource.h:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::setFrontend):
* inspector/InspectorDebuggerAgent.h:
* inspector/InspectorProfilerAgent.cpp:
* inspector/InspectorProfilerAgent.h:
(WebCore::InspectorProfilerAgent::setFrontend):
(WebCore::InspectorProfilerAgent::clearFrontend):
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::InspectorResourceAgent):
* inspector/InspectorResourceAgent.h:
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::setFrontend):
* inspector/InspectorTimelineAgent.h:
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMDispatcher.prototype.inspectElementRequested):
(WebInspector.DOMDispatcher.prototype.addNodesToSearchResult):
* inspector/front-end/inspector.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80204
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Thu, 3 Mar 2011 04:53:13 +0000 (04:53 +0000)]
2011-03-02 Kent Tamura <tkent@chromium.org>
Unreviewed, a trivial regression fix.
Fix LocalizedNumberICU regression by r80198 and r80199.
https://bugs.webkit.org/show_bug.cgi?id=55629
* platform/text/LocalizedNumberICU.cpp:
We should use U_SUCCESS().
(WebCore::createFormatterForCurrentLocale):
(WebCore::parseLocalizedNumber):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80203
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Thu, 3 Mar 2011 04:50:35 +0000 (04:50 +0000)]
Let Xcode know that Localizable.strings is UTF-16-encoded.
* WebCore.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80202
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aestes@apple.com [Thu, 3 Mar 2011 04:40:56 +0000 (04:40 +0000)]
2011-03-02 Andy Estes <aestes@apple.com>
Reviewed by Eric Seidel.
HTML5 TreeBuilder regressed a Peacekeeper DOM test by 25% (was 40%)
https://bugs.webkit.org/show_bug.cgi?id=48719
Instead of pushing a fake HTMLHtmlElement onto the open element stack
during fragment parsing only to later remove it and reparent its
children to the DocumentFragment, push the DocumentFragment directly
onto the open element stack as the root node. This requires refactoring
HTMLElementStack to hold ContainerNode pointers rather than Element
pointers, which has implications for HTMLConstructionSite and
HTMLTreeBuilder as well.
With this patch, the regression in Peacekeeper due to the introduction
of the HTML5 fragment parsing algorithm is ~14%. The regression from
Safari 5.0.3 is ~24%.
No new tests. No change in behavior.
* dom/Element.h:
(WebCore::Node::hasLocalName):
* dom/Node.h:
* html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLNames::hasImpliedEndTag):
(WebCore::HTMLConstructionSite::HTMLConstructionSite):
(WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagInBody):
(WebCore::HTMLConstructionSite::insertComment):
(WebCore::HTMLConstructionSite::insertCommentOnHTMLHtmlElement):
(WebCore::HTMLConstructionSite::attachToCurrent):
(WebCore::HTMLConstructionSite::insertScriptElement):
(WebCore::HTMLConstructionSite::insertTextNode):
(WebCore::HTMLConstructionSite::createElement):
(WebCore::HTMLConstructionSite::createHTMLElement):
(WebCore::HTMLConstructionSite::generateImpliedEndTagsWithExclusion):
(WebCore::HTMLConstructionSite::generateImpliedEndTags):
(WebCore::HTMLConstructionSite::findFosterSite):
(WebCore::HTMLConstructionSite::shouldFosterParent):
* html/parser/HTMLConstructionSite.h:
(WebCore::HTMLConstructionSite::currentNode):
* html/parser/HTMLElementStack.cpp:
(WebCore::HTMLNames::isNumberedHeaderElement):
(WebCore::HTMLNames::isScopeMarker):
(WebCore::HTMLNames::isListItemScopeMarker):
(WebCore::HTMLNames::isTableScopeMarker):
(WebCore::HTMLNames::isTableBodyScopeMarker):
(WebCore::HTMLNames::isTableRowScopeMarker):
(WebCore::HTMLNames::isButtonScopeMarker):
(WebCore::HTMLNames::isSelectScopeMarker):
(WebCore::HTMLElementStack::ElementRecord::ElementRecord):
(WebCore::HTMLElementStack::ElementRecord::replaceElement):
(WebCore::HTMLElementStack::HTMLElementStack):
(WebCore::HTMLElementStack::secondElementIsHTMLBodyElement):
(WebCore::HTMLElementStack::popAll):
(WebCore::HTMLElementStack::popUntilNumberedHeaderElementPopped):
(WebCore::HTMLElementStack::popUntil):
(WebCore::HTMLElementStack::popUntilPopped):
(WebCore::HTMLElementStack::popUntilTableScopeMarker):
(WebCore::HTMLElementStack::popUntilTableBodyScopeMarker):
(WebCore::HTMLElementStack::popUntilTableRowScopeMarker):
(WebCore::HTMLElementStack::pushHTMLHtmlElement):
(WebCore::HTMLElementStack::push):
(WebCore::HTMLElementStack::insertAbove):
(WebCore::HTMLElementStack::find):
(WebCore::HTMLElementStack::topmost):
(WebCore::HTMLElementStack::contains):
(WebCore::inScopeCommon):
(WebCore::HTMLElementStack::hasNumberedHeaderElementInScope):
(WebCore::HTMLElementStack::htmlElement):
(WebCore::HTMLElementStack::rootNode):
(WebCore::HTMLElementStack::pushCommon):
* html/parser/HTMLElementStack.h:
(WebCore::HTMLElementStack::ElementRecord::element):
(WebCore::HTMLElementStack::ElementRecord::node):
(WebCore::HTMLElementStack::topNode):
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
(WebCore::HTMLTreeBuilder::processCloseWhenNestedTag):
(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::processColgroupEndTagForInColumnGroup):
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody):
(WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
(WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately):
(WebCore::HTMLTreeBuilder::processEndTagForInCell):
(WebCore::HTMLTreeBuilder::processEndTagForInBody):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::processEndOfFile):
(WebCore::HTMLTreeBuilder::finished):
* html/parser/HTMLTreeBuilder.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80201
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Thu, 3 Mar 2011 04:21:40 +0000 (04:21 +0000)]
2011-03-02 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r80188.
http://trac.webkit.org/changeset/80188
https://bugs.webkit.org/show_bug.cgi?id=55647
Broke the WebKit API tests. (Requested by xenon on #webkit).
* WebCore.exp.in:
2011-03-02 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r80188.
http://trac.webkit.org/changeset/80188
https://bugs.webkit.org/show_bug.cgi?id=55647
Broke the WebKit API tests. (Requested by xenon on #webkit).
* UIProcess/API/C/WKPage.cpp:
(WKPageRunJavaScriptInMainFrame):
(callRunJavaScriptBlockAndRelease):
* UIProcess/API/C/WKPage.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::runJavaScriptInMainFrame):
(WebKit::WebPageProxy::processDidCrash):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::runJavaScriptInMainFrame):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80200
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Thu, 3 Mar 2011 03:44:56 +0000 (03:44 +0000)]
2011-03-02 Kent Tamura <tkent@chromium.org>
Unreviewed, build fix.
* platform/text/LocalizedNumberICU.cpp:
(WebCore::createFormatterForCurrentLocale): Fix a typo.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80199
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Thu, 3 Mar 2011 03:16:08 +0000 (03:16 +0000)]
Caching number formatter instances in LocalizedNumber* implementations
https://bugs.webkit.org/show_bug.cgi?id=55629
Reviewed by Darin Adler.
No new tests. This change doesn't change existing behavior, and is
covered by existing tests.
* platform/text/LocalizedNumberICU.cpp:
(WebCore::createFormatterForCurrentLocale):
(WebCore::numberFormatter): Introduce a function to return a static
instance of NumberFormat.
(WebCore::parseLocalizedNumber): Use numberFormatter().
(WebCore::formatLocalizedNumber): Use numberFormatter().
* platform/text/mac/LocalizedNumberMac.mm:
(WebCore::createFormatterForCurrentLocale):
(WebCore::numberFormatter): Introduce a function to return a static
instance of NSNumberFormatter.
(WebCore::parseLocalizedNumber): Use numberFormatter().
(WebCore::formatLocalizedNumber): Use numberFormatter().
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80198
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Thu, 3 Mar 2011 03:02:17 +0000 (03:02 +0000)]
2011-03-01 Ojan Vafai <ojan@chromium.org>
Reviewed by Tony Chang.
[test-dashboard] make gtest JSON match layout-tests JSON
https://bugs.webkit.org/show_bug.cgi?id=55556
http://trac.webkit.org/changeset/80090 stopped converting time_ms to t.
Make this code match.
* Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80197
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Thu, 3 Mar 2011 02:40:07 +0000 (02:40 +0000)]
Update WebKitSystemInterface libraries. Library changes reviewed by Darin Adler.
* libWebKitSystemInterfaceLeopard.a:
* libWebKitSystemInterfaceSnowLeopard.a:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80196
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
leviw@chromium.org [Thu, 3 Mar 2011 02:30:20 +0000 (02:30 +0000)]
2011-03-02 Levi Weintraub <leviw@chromium.org>
Reviewed by Ryosuke Niwa.
deprecatedEditingOffset should actually return the expected deprecated value for "after" positions
https://bugs.webkit.org/show_bug.cgi?id=54986
Calls to deprecatedEditingOffset needs to return the expected value for new Before/After positions
until we can update all the call sites to consider the new position types.
No tests. This is intended to simplify the transition to new Positions, not to change behavior.
* dom/Position.cpp:
(WebCore::Position::deprecatedEditingOffset):
(WebCore::Position::offsetForPositionAfterAnchor): Added to do the right thing while ensuring
inline-speed for most calls to deprecatedEditingOffset.
* dom/Position.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80195
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jeffm@apple.com [Thu, 3 Mar 2011 01:59:29 +0000 (01:59 +0000)]
2011-03-02 Jeff Miller <jeffm@apple.com>
Reviewed by Darin Adler.
Rename WebKit::WebPage::validateMenuItem() to validateCommand()
https://bugs.webkit.org/show_bug.cgi?id=55636
Since this method can validate more than menu items, validateCommand() is a better name. Also rename various messages and WebKit::WebPageProxy::didValidateMenuItem() to didValidateCommand().
* UIProcess/API/mac/WKView.mm:
(-[WKView validateUserInterfaceItem:]): Call validateCommand() instead of validateMenuItem().
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::validateCommand): Renamed from validateMenuItem().
(WebKit::WebPageProxy::didValidateCommand): Renamed from didValidateMenuItem().
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in: Renamed DidValidateMenuItem to DidValidateCommand.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::validateCommand): Renamed from validateMenuItem().
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in: Renamed ValidateMenuItem to ValidateCommand.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80194
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Thu, 3 Mar 2011 01:57:15 +0000 (01:57 +0000)]
2011-03-02 Mihai Parparita <mihaip@chromium.org>
Reviewed by Tony Gentilcore.
Split up http/tests/cache/subresource-expiration.html so it stops timing out
https://bugs.webkit.org/show_bug.cgi?id=55639
http/tests/cache/subresource-expiration.html does a lot of sequential
loads, some with delays in between them. This seems unavoidable, so
to make the test less likely to time out (especially on debug bots),
the test cases are split across two tests.
* http/tests/cache/subresource-expiration-1-expected.txt: Added.
* http/tests/cache/subresource-expiration-1.html: Added.
* http/tests/cache/subresource-expiration-2-expected.txt: Added.
* http/tests/cache/subresource-expiration-2.html: Added.
* http/tests/cache/subresource-expiration-expected.txt: Removed.
* http/tests/cache/subresource-expiration.html: Removed.
* platform/chromium/test_expectations.txt:
* platform/mac-wk2/Skipped:
* platform/mac/test_expectations.txt:
* platform/qt-wk2/Skipped:
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80193
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Thu, 3 Mar 2011 01:45:24 +0000 (01:45 +0000)]
2011-03-02 Dirk Pranke <dpranke@chromium.org>
Reviewed by Tony Chang.
NRWT - implement Linux Hardy 64-bit port support. This involves
adding support for non-'x86' architectures and updating the
"deduplicate_tests" script to correctly understand that
port.name() is not always equal to basename(port.baseline_path()).
This change introduces two new port names: 'chromium-linux-x86'
and 'chromium-linux-x86_64'. Using the prior 'chromium-linux'
flag will cause the code to determine which one to use at
runtime, just like we currently do with 'chromium-win'.
https://bugs.webkit.org/show_bug.cgi?id=55535
* Scripts/webkitpy/common/system/executive_mock.py:
Handle 'return_stderr' keyword arg to run_command()
* Scripts/webkitpy/layout_tests/deduplicate_tests.py:
* Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
* Scripts/webkitpy/layout_tests/port/base.py:
* Scripts/webkitpy/layout_tests/port/chromium_linux.py:
* Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
* Scripts/webkitpy/layout_tests/port/factory.py:
* Scripts/webkitpy/layout_tests/port/google_chrome.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80192
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino@webkit.org [Thu, 3 Mar 2011 01:41:14 +0000 (01:41 +0000)]
[wx] Build fixes after recent changes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80191
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 3 Mar 2011 01:38:21 +0000 (01:38 +0000)]
2011-03-02 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
WKPageSetMemoryCacheClientCallsEnabled doesn't persist if web process crashes
https://bugs.webkit.org/show_bug.cgi?id=55635
* Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):
Encode and decode areMemoryCacheClientCallsEnabled.
* Shared/WebPageCreationParameters.h:
Add areMemoryCacheClientCallsEnabled member variable.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
Initialize m_areMemoryCacheClientCallsEnabled.
(WebKit::WebPageProxy::setMemoryCacheClientCallsEnabled):
Update m_areMemoryCacheClientCallsEnabled. Send a message if necessary.
(WebKit::WebPageProxy::creationParameters):
Set areMemoryCacheClientCallsEnabled.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
Call WebPage::setMemoryCacheMessagesEnabled.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80190
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonyg@chromium.org [Thu, 3 Mar 2011 01:32:52 +0000 (01:32 +0000)]
2011-03-02 Tony Gentilcore <tonyg@chromium.org>
Unreviewed expectations update
[chromium] xss-ALLOWED-from-javascript-url-sub-frame-to-javascript-url-sub-frame.html is crashy
https://bugs.webkit.org/show_bug.cgi?id=55634
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80189
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Thu, 3 Mar 2011 01:17:45 +0000 (01:17 +0000)]
Make the runJavaScriptInMainFrame callback send a WKSerializedScriptValueRef.
Source/WebCore: Export SerializedScriptValue::create(JSC::ExecState* exec, JSC::JSValue value).
Reviewed by Darin Adler.
* WebCore.exp.in: Added __ZN7WebCore21SerializedScriptValue6createEPN3JSC9ExecStateENS1_7JSValueE.
Source/WebKit2: Make the runJavaScriptInMainFrame callback send a WKSerializedScriptValueRef.
https://webkit.org/b/55623
Reviewed by Darin Adler.
* UIProcess/API/C/WKPage.cpp:
(WKPageRunJavaScriptInMainFrame): Use ScriptValueCallback.
(callRunJavaScriptBlockAndRelease): Use WKSerializedScriptValueRef.
* UIProcess/API/C/WKPage.h: Use WKSerializedScriptValueRef.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::close): Call invalidateCallbackMap for m_scriptValueCallbacks.
(WebKit::WebPageProxy::runJavaScriptInMainFrame): Take a ScriptValueCallback.
(WebKit::WebPageProxy::scriptValueCallback): Added. Create a WebSerializedScriptValue
from the DataReference before calling the callback.
(WebKit::WebPageProxy::processDidCrash): Call invalidateCallbackMap for m_scriptValueCallbacks.
* UIProcess/WebPageProxy.h: Added ScriptValueCallback and m_scriptValueCallbacks.
* UIProcess/WebPageProxy.messages.in: Added ScriptValueCallback.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::runJavaScriptInMainFrame): Create a DataReference from a WebCore::SerializedScriptValue.
And use ScriptValueCallback to send the message back.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80188
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Thu, 3 Mar 2011 01:12:30 +0000 (01:12 +0000)]
Windows build fix. Unreviewed.
* win/lib/WebKitSystemInterface.lib:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80187
268f45cc-cd09-0410-ab3c-
d52691b4dbfc