benjamin@webkit.org [Mon, 8 Apr 2013 01:09:50 +0000 (01:09 +0000)]
Simplify the page "Getting the Code" on WebKit.org
https://bugs.webkit.org/show_bug.cgi?id=113980
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-07
Reviewed by Sam Weinig.
* building/checkout.html:
Instead of interleaving instructions for Mac and Windows, just
copy the things that make sense and have two clear sections.
Also mention Linux, it is the exact same instructions as Mac OS X.
Make svn checkout the alternative to a download of the tarball. It is
almost impossible to do a svn checkout on slow networks nowadays.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147890
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
benjamin@webkit.org [Mon, 8 Apr 2013 01:01:22 +0000 (01:01 +0000)]
Do not allocate static AtomicStrings when searching for alternate font names
https://bugs.webkit.org/show_bug.cgi?id=114110
Reviewed by Geoffrey Garen.
FontCache's alternateFamilyName does some font name substitutions
when a font is not found for a given name.
In the vast majority of cases, no substitutions are made and
alternateFamilyName returns the null atom.
Given the usage the function had a couple of problems:
-It created 6 static AtomicString.
-It did a case insensitive comparison with 6 differents strings
before failing.
This patch aims at solving both issues.
Instead of creating all AtomicString statically, the alternate name
are simply created on the fly as needed. Because the operation is so
unfrequent, and it uses the fast constructor, doing so should not slow
down the function.
To avoid comparing the input to every string, every time, the length of
the input is first evaluated, and we only do the necessary string comparisons.
On x86_64, this reduces the binary size by 2128 bytes.
* platform/graphics/FontCache.cpp:
(WebCore::familyNameEqualIgnoringCase):
When comparing strings, we know:
-The family name is non null.
-The length of both strings is equal.
-The length is not null.
Make the comparison accordingly.
(WebCore::alternateFamilyName):
(WebCore::FontCache::getCachedFontPlatformData):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147889
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
benjamin@webkit.org [Mon, 8 Apr 2013 00:52:39 +0000 (00:52 +0000)]
Remove remaining PLATFORM(CHROMIUM)-guarded code in WebCore
https://bugs.webkit.org/show_bug.cgi?id=114081
Remove the remaining PLATFORM(CHROMIUM) build guards. There are still a couple of guards
that most likely apply only to Chromium, like OS(ANDROID) or USE(SKIA_ON_MAC_CHROMIUM),
but removal of these should go into separate patches.
Patch by Zan Dobersek <zdobersek@igalia.com> on 2013-04-07
* bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore):
* config.h:
* history/PageCache.cpp:
(WebCore):
(WebCore::logCanCacheFrameDecision):
(WebCore::logCanCachePageDecision):
(WebCore::PageCache::canCache):
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::getContext):
(WebCore::HTMLCanvasElement::shouldAccelerate):
* html/HTMLCanvasElement.h:
* html/HTMLMediaElement.cpp:
(WebCore::createFileURLForApplicationCacheResource):
(WebCore::HTMLMediaElement::loadResource):
* html/HTMLSelectElement.cpp:
(WebCore):
(WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
* html/MediaDocument.cpp:
(WebCore::MediaDocument::defaultEventHandler):
* html/canvas/EXTDrawBuffers.cpp:
(WebCore::EXTDrawBuffers::satisfiesWebGLRequirements):
* html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::create):
(WebCore::WebGLRenderingContext::WebGLRenderingContext):
(WebCore::WebGLRenderingContext::paintRenderingResultsToCanvas):
(WebCore::WebGLRenderingContext::platformLayer):
* inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::willPaintImpl):
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::didBeginFrame):
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::notifyFinished):
* page/FeatureObserver.cpp:
(WebCore::FeatureObserver::~FeatureObserver):
* platform/AsyncFileSystem.cpp:
(WebCore):
* platform/ContextMenu.h:
(ContextMenu):
* platform/ContextMenuItem.h:
* platform/Cursor.h:
* platform/DragData.cpp:
(WebCore):
* platform/DragData.h:
* platform/DragImage.h:
* platform/LocalizedStrings.h:
(WebCore):
* platform/Pasteboard.h:
(Pasteboard):
* platform/PlatformExportMacros.h:
* platform/PlatformInstrumentation.h:
(WebCore::PlatformInstrumentation::willDecodeImage):
(WebCore::PlatformInstrumentation::didDecodeImage):
(WebCore::PlatformInstrumentation::willResizeImage):
(WebCore::PlatformInstrumentation::didResizeImage):
* platform/PlatformMenuDescription.h:
(WebCore):
* platform/PlatformSpeechSynthesizer.h:
(PlatformSpeechSynthesizer):
* platform/PlatformWheelEvent.h:
(WebCore::PlatformWheelEvent::PlatformWheelEvent):
(PlatformWheelEvent):
* platform/ScrollAnimator.cpp:
(WebCore):
(WebCore::ScrollAnimator::handleWheelEvent):
* platform/ScrollAnimator.h:
(ScrollAnimator):
* platform/ScrollAnimatorNone.cpp:
(WebCore::ScrollAnimatorNone::scroll):
(WebCore::ScrollAnimatorNone::animationTimerFired):
* platform/ScrollView.cpp:
(WebCore::ScrollView::updateOverhangAreas):
* platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::scrollPositionChanged):
* platform/Scrollbar.cpp:
* platform/SecureTextInput.cpp: Removed.
* platform/SecureTextInput.h:
(WebCore):
* platform/SuddenTermination.h:
(WebCore):
* platform/Widget.h:
(Widget):
* platform/graphics/ANGLEWebKitBridge.h:
* platform/graphics/BitmapImage.h:
* platform/graphics/FloatPoint.h:
(FloatPoint):
* platform/graphics/FloatRect.h:
(FloatRect):
* platform/graphics/FloatSize.h:
(FloatSize):
* platform/graphics/Font.cpp:
(WebCore):
(WebCore::Font::width):
* platform/graphics/Font.h:
(Font):
* platform/graphics/FontCache.cpp:
(WebCore):
* platform/graphics/FontCache.h:
(FontCache):
* platform/graphics/FontDescription.h:
* platform/graphics/FontPlatformData.cpp:
* platform/graphics/GlyphBuffer.h:
(WebCore):
(WebCore::GlyphBuffer::add):
* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::drawImage):
(WebCore::GraphicsContext::drawImageBuffer):
* platform/graphics/GraphicsContext3D.h:
(GraphicsContext3D):
* platform/graphics/GraphicsLayer.h:
(WebCore::GraphicsLayer::supportsBackgroundColorContent):
* platform/graphics/Icon.h:
(Icon):
* platform/graphics/ImageSource.cpp:
* platform/graphics/ImageSource.h:
(WebCore):
* platform/graphics/IntRect.h:
(IntRect):
(WebCore):
* platform/graphics/MediaPlayer.cpp:
* platform/graphics/PlatformLayer.h:
* platform/graphics/SimpleFontData.h:
(SimpleFontData):
(DerivedFontData):
* platform/graphics/filters/FECustomFilter.cpp:
(WebCore::FECustomFilter::resizeContext):
* platform/graphics/gpu/DrawingBuffer.h:
(WebCore):
(DrawingBuffer):
* platform/graphics/gpu/SharedGraphicsContext3D.cpp:
* platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:
(WebCore::Extensions3DOpenGLCommon::getTranslatedShaderSourceANGLE):
* platform/image-decoders/ImageDecoder.h:
* platform/leveldb/LevelDBDatabase.cpp:
(WebCore::LevelDBDatabase::open):
* platform/network/BlobRegistry.cpp:
(WebCore::blobRegistry):
* platform/network/BlobRegistryImpl.cpp:
* platform/network/NetworkStateNotifier.cpp:
* platform/network/NetworkStateNotifier.h:
(NetworkStateNotifier):
* platform/network/NetworkingContext.h:
(NetworkingContext):
* platform/network/ResourceHandleClient.h:
* platform/network/ResourceRequestBase.cpp:
(WebCore):
* platform/text/cf/HyphenationCF.cpp:
* plugins/PluginViewNone.cpp:
(WebCore):
* testing/Internals.cpp:
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::createRequest):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147888
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
benjamin@webkit.org [Mon, 8 Apr 2013 00:43:46 +0000 (00:43 +0000)]
Use Vector::reserveInitialCapacity() when possible in JavaScriptCore runtime
https://bugs.webkit.org/show_bug.cgi?id=114111
Reviewed by Andreas Kling.
Almost all the code was already using Vector::reserveInitialCapacity()
and Vector::uncheckedAppend(). Fix the remaining parts.
* runtime/ArgList.h:
(MarkedArgumentBuffer): The type VectorType is unused.
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncSort):
Move the variable closer to where it is needed.
* runtime/JSArray.cpp:
(JSC::JSArray::setLengthWithArrayStorage):
* runtime/JSObject.cpp:
(JSC::JSObject::getOwnPropertyNames):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147887
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Sun, 7 Apr 2013 23:56:39 +0000 (23:56 +0000)]
[EFL] --minimal build fails because of incorrect usage of GENERATE_THEME in CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=113902
Unreviewed.
Patch by Ed Bartosh <bartosh@gmail.com> on 2013-04-07
* platform/efl/DefaultTheme/CMakeLists.txt:
Put possibly empty variable after non-empty to avoid space
at the beginning of string parameter
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147886
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Sun, 7 Apr 2013 23:41:17 +0000 (23:41 +0000)]
[EFL] --minimal build fails with error: expected `;' before `return'
https://bugs.webkit.org/show_bug.cgi?id=113953
Unreviewed.
Patch by Ed Bartosh <bartosh@gmail.com> on 2013-04-07
* ewk/ewk_security_origin.cpp:
(ewk_security_origin_web_database_quota_get): Added missing semicolon.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147885
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Sun, 7 Apr 2013 23:00:28 +0000 (23:00 +0000)]
[WIN] Fix problems with export macros of AutodrainedPool
https://bugs.webkit.org/show_bug.cgi?id=114132
Reviewed by Geoffrey Garen.
Exporting an inline function results in an error with the MS compiler.
* wtf/AutodrainedPool.h:
(AutodrainedPool):
(WTF::AutodrainedPool::AutodrainedPool):
(WTF::AutodrainedPool::~AutodrainedPool):
(WTF::AutodrainedPool::cycle):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147884
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Sun, 7 Apr 2013 22:18:48 +0000 (22:18 +0000)]
Add default implementation for KURL::fileSystemPath()
https://bugs.webkit.org/show_bug.cgi?id=108326
Reviewed by Benjamin Poulain.
The code for KURL::fileSystemPath() has been duplicated in different ports.
Add an implementation of this function to KURL.cpp for this ports and
get rid of the very similar port specific implementation files.
* PlatformBlackBerry.cmake:
* PlatformEfl.cmake:
* PlatformWinCE.cmake:
* platform/KURL.cpp:
(WebCore):
(WebCore::KURL::fileSystemPath):
* platform/blackberry/KURLBlackBerry.cpp: Removed.
* platform/efl/KURLEfl.cpp: Removed.
* platform/wince/KURLWinCE.cpp: Removed.
* platform/wx/KURLWx.cpp: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147883
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Sun, 7 Apr 2013 22:09:45 +0000 (22:09 +0000)]
[WinCE] Add workaround for UNUSED_PARAM()
https://bugs.webkit.org/show_bug.cgi?id=113440
Reviewed by Benjamin Poulain.
The MSVC compiler for Windwos CE throws an error when
an function parameter is passed to UNUSED_PARAM() and
its type is only forward declared.
* wtf/UnusedParam.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147882
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Sun, 7 Apr 2013 22:08:32 +0000 (22:08 +0000)]
Do not check if WTF_ARM_ARCH_VERSION is defined in WTF_ARM_ARCH_AT_LEAST macro
https://bugs.webkit.org/show_bug.cgi?id=114127
Reviewed by Benjamin Poulain.
Platform.h defines WTF_ARM_ARCH_VERSION for CPU(ARM) always and removing
the check works around a bug in older Microsoft compiler versions.
* wtf/Platform.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147881
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ch.dumez@sisa.samsung.com [Sun, 7 Apr 2013 21:28:33 +0000 (21:28 +0000)]
Unreviewed EFL gardening.
Marked another webaudio test as flaky.
* platform/efl/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147880
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Sun, 7 Apr 2013 21:19:46 +0000 (21:19 +0000)]
Remove references to Skia and V8 from CMake files
https://bugs.webkit.org/show_bug.cgi?id=114130
Reviewed by Geoffrey Garen.
.:
* Source/cmake/OptionsBlackBerry.cmake:
* Source/cmake/WebKitPackaging.cmake:
Source/JavaScriptCore:
* shell/PlatformBlackBerry.cmake:
Source/WebCore:
* PlatformBlackBerry.cmake:
Source/WebKit:
* PlatformBlackBerry.cmake:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147879
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer@apple.com [Sun, 7 Apr 2013 20:56:41 +0000 (20:56 +0000)]
Remove the rest of SVG_DOM_OBJC_BINDINGS
<http://webkit.org/b/114112>
Reviewed by Geoffrey Garen.
.:
* Source/autotools/SetupWebKitFeatures.m4:
* Source/cmake/WebKitFeatures.cmake:
* Source/cmakeconfig.h.cmake:
- Remove references to ENABLE_SVG_DOM_OBJC_BINDINGS.
Source/JavaScriptCore:
* Configurations/FeatureDefines.xcconfig:
- Remove ENABLE_SVG_DOM_OBJC_BINDINGS macro.
Source/WebCore:
* Configurations/WebCore.xcconfig:
- Remove EXCLUDED_SOURCE_FILE_NAMES_SVG_DOM_OBJC_BINDINGS. Note
that DOMHTMLIFrameElementPrivate.h should not have been in
this list because the class contained methods other than just
-getSVGDocument.
* WebCore.xcodeproj/project.pbxproj:
- Remove DOMHTMLFrameElementPrivate.h since the only method it
contained was -[DOMHTMLFrameElement getSVGDocument], which was
part of the SVG DOM Objective-C bindings.
* bindings/objc/DOM.mm:
(kitClass):
* bindings/objc/DOMEvents.mm:
(kitClass):
* bindings/objc/ExceptionHandlers.mm:
(WebCore::raiseDOMException):
- Remove code in ENABLE(SVG_DOM_OBJC_BINDINGS).
Source/WebKit/blackberry:
* WebCoreSupport/AboutDataEnableFeatures.in:
- Remove reference to SVG_DOM_OBJC_BINDINGS.
Source/WebKit2:
* Configurations/FeatureDefines.xcconfig:
- Remove ENABLE_SVG_DOM_OBJC_BINDINGS macro.
Source/WTF:
* wtf/FeatureDefines.h:
- Remove ENABLE_SVG_DOM_OBJC_BINDINGS macro.
Tools:
* Scripts/webkitperl/FeatureList.pm:
- Remove --svg-dom-objc-bindings switch.
* qmake/mkspecs/features/features.pri:
- Remove reference to ENABLE_SVG_DOM_OBJC_BINDINGS.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147878
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ch.dumez@sisa.samsung.com [Sun, 7 Apr 2013 20:27:04 +0000 (20:27 +0000)]
Unreviewed gardening.
Rebaseline several test cases that have line number information after r147872.
* http/tests/inspector-enabled/console-exception-while-no-inspector-expected.txt:
* http/tests/security/window-onerror-exception-in-iframe-expected.txt:
* inspector/console/alert-toString-exception-expected.txt:
* storage/indexeddb/exception-in-event-aborts-expected.txt:
* storage/websql/sql-error-codes-expected.txt:
* storage/websql/statement-error-callback-expected.txt:
* storage/websql/transaction-callback-exception-crash-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147877
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ch.dumez@sisa.samsung.com [Sun, 7 Apr 2013 20:02:07 +0000 (20:02 +0000)]
Unreviewed EFL gardening.
Skip a few test failing due to missing Quota API support.
* platform/efl/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147876
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ch.dumez@sisa.samsung.com [Sun, 7 Apr 2013 19:55:10 +0000 (19:55 +0000)]
Unreviewed EFL gardening.
Mark a few tests as crashing on EFL port.
* platform/efl/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147875
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ch.dumez@sisa.samsung.com [Sun, 7 Apr 2013 19:38:16 +0000 (19:38 +0000)]
Unreviewed EFL gardening.
Generate missing baselines.
* platform/efl/editing/pasteboard/paste-text-004-expected.png: Added.
* platform/efl/svg/filters/feDropShadow-zero-deviation-expected.png: Added.
* platform/efl/svg/filters/feDropShadow-zero-deviation-expected.txt: Added.
* platform/efl/svg/filters/feGaussianBlur-zero-deviation-expected.png: Added.
* platform/efl/svg/filters/feGaussianBlur-zero-deviation-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147874
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ch.dumez@sisa.samsung.com [Sun, 7 Apr 2013 19:30:17 +0000 (19:30 +0000)]
Unreviewed EFL gardening.
Rebaseline several test cases.
* platform/efl-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
* platform/efl-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
* platform/efl/fast/forms/datalist/input-list-expected.txt:
* platform/efl/fast/forms/search-display-none-cancel-button-expected.png:
* platform/efl/fast/forms/search-display-none-cancel-button-expected.txt:
* platform/efl/fast/js/dom-static-property-for-in-iteration-expected.txt: Added.
* platform/efl/fast/js/global-constructors-expected.txt:
* platform/efl/http/tests/inspector/console-websocket-error-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147873
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Sun, 7 Apr 2013 18:47:20 +0000 (18:47 +0000)]
Inspector should display information about non-object exceptions
https://bugs.webkit.org/show_bug.cgi?id=114123
Reviewed by Adele Peterson.
Source/JavaScriptCore:
Make sure we store the right stack information, even when throwing
a primitive.
* interpreter/CallFrame.h:
(JSC::ExecState::clearSupplementaryExceptionInfo):
(ExecState):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::addStackTraceIfNecessary):
(JSC::Interpreter::throwException):
Source/WebCore:
Make use of the stack trace for line information when we're reporting
an exception
* bindings/js/JSDOMBinding.cpp:
(WebCore::reportException):
LayoutTests:
All these tests throw primitives as exceptions, and now they have source
and line number information
* fast/dom/exception-getting-event-handler-expected.txt:
* fast/dom/javascript-url-exception-isolation-expected.txt:
* fast/dom/nested-script-exceptions-expected.txt:
* fast/events/onerror-no-constructor-expected.txt:
* fast/events/window-onerror13-expected.txt:
* fast/events/window-onerror16-expected.txt:
* fast/events/window-onerror2-expected.txt:
* fast/events/window-onerror8-expected.txt:
* fast/js/uncaught-exception-line-number-expected.txt:
* fast/sub-pixel/inline-block-with-padding-expected.txt:
* platform/mac/fast/AppleScript/001-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147872
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
robert@webkit.org [Sun, 7 Apr 2013 18:37:39 +0000 (18:37 +0000)]
table element may get larger when its contents are recreated
https://bugs.webkit.org/show_bug.cgi?id=111342
Reviewed by Darin Adler.
Source/WebCore:
Remove anonymous table section wrappers when destroying their children.
Test: fast/table/anonymous-table-section-removed.html
* rendering/RenderObject.cpp:
(WebCore::RenderObject::destroyAndCleanupAnonymousWrappers):
LayoutTests:
* fast/table/anonymous-table-section-removed-expected.txt: Added.
* fast/table/anonymous-table-section-removed.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147871
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Sun, 7 Apr 2013 18:31:09 +0000 (18:31 +0000)]
[WIN] Fix build without precompiled header after r145827.
* platform/ContextMenuItem.h:
* platform/PlatformMenuDescription.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147870
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Sun, 7 Apr 2013 18:30:17 +0000 (18:30 +0000)]
Fix compilation of LocaleWin with !ENABLE(CALENDAR_PICKER) && !ENABLE(DATE_AND_TIME_INPUT_TYPES)
* platform/text/win/LocaleWin.cpp:
(WebCore::LocaleWin::ensureShortMonthLabels):
(WebCore):
(WebCore::LocaleWin::ensureMonthLabels):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147869
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Sun, 7 Apr 2013 17:07:54 +0000 (17:07 +0000)]
[WIN] Fix build without precompiled header after r144216.
* platform/network/cf/FormDataStreamCFNet.h:
* platform/network/mac/FormDataStreamMac.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147868
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sun, 7 Apr 2013 16:42:28 +0000 (16:42 +0000)]
Source/WebCore: [EFL] --minimal build fails with error: WebCore::FrameSelection::notifyAccessibilityForSelectionChange()
https://bugs.webkit.org/show_bug.cgi?id=114089
Patch by Ed Bartosh <bartosh@gmail.com> on 2013-04-07
Reviewed by Chris Fleizach.
Wrapped accessibility related code in #if HAVE(ACCESSIBILITY)
* editing/FrameSelection.cpp:
(WebCore::FrameSelection::setSelection):
* editing/FrameSelection.h:
(WebCore):
Tools: [EFL] -minimal build fails with error: WebCore::FrameSelection::notifyAccessibilityForSelectionChange()
https://bugs.webkit.org/show_bug.cgi?id=114089
Patch by Ed Bartosh <bartosh@gmail.com> on 2013-04-07
Reviewed by Chris Fleizach.
Wrapped accessibility related code in #if HAVE(ACCESSIBILITY)
* DumpRenderTree/AccessibilityController.cpp:
* DumpRenderTree/AccessibilityUIElement.cpp:
* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::DumpRenderTreeChrome):
* DumpRenderTree/efl/DumpRenderTreeChrome.h:
(DumpRenderTreeChrome):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147867
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
l.gombos@samsung.com [Sun, 7 Apr 2013 03:52:05 +0000 (03:52 +0000)]
2013-04-06 Laszlo Gombos <l.gombos@samsung.com>
Build fix after r147857, remove remaining USE(JSC) guards.
Unreviewed.
* DumpRenderTree/config.h:
* TestWebKitAPI/config.h:
* WebKitTestRunner/config.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147866
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Sun, 7 Apr 2013 01:59:39 +0000 (01:59 +0000)]
Rename sheriffbot to webkitbot
https://bugs.webkit.org/show_bug.cgi?id=114109
Reviewed by Benjamin Poulain.
Renamed since sheriffbot will be used in Blink.
* Scripts/webkitpy/tool/commands/sheriffbot.py:
(SheriffBot):
(SheriffBot.begin_work_queue):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147865
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
benjamin@webkit.org [Sun, 7 Apr 2013 01:32:53 +0000 (01:32 +0000)]
Get rid of skia
https://bugs.webkit.org/show_bug.cgi?id=114108
Reviewed by Anders Carlsson.
* platform/graphics/filters/skia/*: Removed.
* platform/graphics/skia/*: Removed.
* platform/image-decoders/skia/*: Removed.
* platform/image-encoders/skia/*: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147864
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
benjamin@webkit.org [Sun, 7 Apr 2013 01:31:33 +0000 (01:31 +0000)]
Remove the chromium code from platform/graphics/mac
https://bugs.webkit.org/show_bug.cgi?id=114107
Reviewed by Anders Carlsson.
* platform/graphics/mac/FontCacheMac.mm:
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::createFontPlatformData):
* platform/graphics/mac/FontComplexTextMac.cpp:
(WebCore::Font::selectionRectForComplexText):
(WebCore::Font::drawComplexText):
(WebCore::Font::floatWidthForComplexText):
(WebCore::Font::offsetForPositionForComplexText):
* platform/graphics/mac/FontMac.mm:
(WebCore::hasBrokenCTFontGetVerticalTranslationsForGlyphs):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147863
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
benjamin@webkit.org [Sun, 7 Apr 2013 01:30:21 +0000 (01:30 +0000)]
Clean platform/graphics/cg of the chromium bits
https://bugs.webkit.org/show_bug.cgi?id=114106
Reviewed by Anders Carlsson.
* platform/graphics/cg/BitmapImageCG.cpp:
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::roundToDevicePixels):
* platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
(GraphicsContextPlatformPrivate):
* platform/graphics/cg/ImageBufferCG.cpp:
* platform/graphics/cg/ImageCG.cpp:
* platform/graphics/cg/PathCG.cpp:
* platform/graphics/cg/PatternCG.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147862
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Sat, 6 Apr 2013 23:48:05 +0000 (23:48 +0000)]
Remove InjectedScriptHost.evaluateReturnsEvalFunction.
https://webkit.org/b/114099
Source/WebCore:
* inspector/InjectedScriptHost.h:
(InjectedScriptHost):
* inspector/InjectedScriptHost.idl:
* inspector/InjectedScriptSource.js:
(InjectedScript.prototype._evaluateOn):
LayoutTests:
Reviewed by Joseph Pecoraro.
* inspector/console/command-line-api-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147861
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
benjamin@webkit.org [Sat, 6 Apr 2013 23:23:17 +0000 (23:23 +0000)]
Remove the chromium code from WebCore/platform/mac
https://bugs.webkit.org/show_bug.cgi?id=114104
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-06
Reviewed by Sam Weinig.
* platform/mac/NSScrollerImpDetails.h:
(WebCore::isScrollbarOverlayAPIAvailable):
* platform/mac/NSScrollerImpDetails.mm:
* platform/mac/ScrollAnimatorMac.mm:
(-[WebScrollbarPainterDelegate layer]):
(WebCore::scrollAnimationEnabledForSystem):
* platform/mac/ScrollElasticityController.mm:
(WebCore):
* platform/mac/ScrollbarThemeMac.h:
(ScrollbarThemeMac):
* platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarTheme::nativeTheme):
(WebCore::ScrollbarThemeMac::paint):
(WebCore):
* platform/mac/ThemeMac.mm:
(WebCore::ThemeMac::ensuredView):
* platform/mac/WebCoreNSCellExtras.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147860
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
benjamin@webkit.org [Sat, 6 Apr 2013 23:19:08 +0000 (23:19 +0000)]
Remove the Chromium code from Mac's FontPlatformData
https://bugs.webkit.org/show_bug.cgi?id=114103
Reviewed by Sam Weinig.
* platform/graphics/FontPlatformData.h:
(WebCore):
(FontPlatformData):
* platform/graphics/cocoa/FontPlatformDataCocoa.mm:
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::platformDataInit):
(WebCore::FontPlatformData::platformDataAssign):
(WebCore::FontPlatformData::setFont):
(WebCore::FontPlatformData::ctFont):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147859
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Sat, 6 Apr 2013 22:47:56 +0000 (22:47 +0000)]
Unify the many and varied stack trace mechanisms, and make the result sane.
https://bugs.webkit.org/show_bug.cgi?id=114072
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
Makes JSC::StackFrame record the bytecode offset and other necessary data
rather than requiring us to perform eager evaluation of the line number, etc.
Then remove most of the users of retrieveLastCaller, as most of them were
using it to create a stack trace in a fairly incomplete and inefficient way.
StackFrame now also has a couple of helpers to get the line and column info.
* API/JSContextRef.cpp:
(JSContextCreateBacktrace):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitDebugHook):
* interpreter/Interpreter.cpp:
(JSC):
(JSC::Interpreter::dumpRegisters):
(JSC::Interpreter::unwindCallFrame):
(JSC::getBytecodeOffsetForCallFrame):
(JSC::getCallerInfo):
(JSC::StackFrame::line):
(JSC::StackFrame::column):
(JSC::StackFrame::expressionInfo):
(JSC::StackFrame::toString):
(JSC::Interpreter::getStackTrace):
(JSC::Interpreter::addStackTraceIfNecessary):
(JSC::Interpreter::retrieveCallerFromVMCode):
* interpreter/Interpreter.h:
(StackFrame):
(Interpreter):
* runtime/Error.cpp:
(JSC::throwError):
* runtime/JSGlobalData.h:
(JSC):
(JSGlobalData):
* runtime/JSGlobalObject.cpp:
(JSC::DynamicGlobalObjectScope::DynamicGlobalObjectScope):
Source/WebCore:
Now that we've fleshed out the StackFrames from Interpreter::getStackTrace
WebCore can just ask us for a stack trace rather than implementing its own
stack walking.
* bindings/js/ScriptCallStackFactory.cpp:
(WebCore::createScriptCallStack):
* inspector/ScriptCallFrame.cpp:
(WebCore::ScriptCallFrame::isEqual):
* inspector/ScriptCallFrame.h:
(ScriptCallFrame):
(WebCore::ScriptCallFrame::columnNumber):
Tools:
The commandline jsc executable no longer requires arguments, so
I've made run-jsc work without them.
* Scripts/run-jsc:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147858
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Sat, 6 Apr 2013 22:42:32 +0000 (22:42 +0000)]
Removed v8 bindings hooks from IDL files
https://bugs.webkit.org/show_bug.cgi?id=114091
Patch by Geoffrey Garen <ggaren@apple.com> on 2013-04-06
Reviewed by Anders Carlsson and Sam Weinig.
Source/JavaScriptCore:
* heap/HeapStatistics.h:
Source/WebCore:
* Modules/encryptedmedia/MediaKeySession.idl:
* Modules/filesystem/DOMWindowFileSystem.idl:
* Modules/filesystem/WorkerContextFileSystem.idl:
* Modules/gamepad/NavigatorGamepad.idl:
* Modules/geolocation/NavigatorGeolocation.idl:
* Modules/indexeddb/DOMWindowIndexedDatabase.idl:
* Modules/indexeddb/WorkerContextIndexedDatabase.idl:
* Modules/mediastream/DOMWindowMediaStream.idl:
* Modules/mediastream/NavigatorMediaStream.idl:
* Modules/notifications/DOMWindowNotifications.idl:
* Modules/notifications/NotificationCenter.idl:
* Modules/notifications/WorkerContextNotifications.idl:
* Modules/quota/DOMWindowQuota.idl:
* Modules/speech/DOMWindowSpeech.idl:
* Modules/webaudio/AudioBufferSourceNode.idl:
* Modules/webaudio/AudioContext.idl:
* Modules/webaudio/AudioParam.idl:
* Modules/webaudio/DOMWindowWebAudio.idl:
* Modules/webdatabase/DOMWindowWebDatabase.idl:
* Modules/webdatabase/WorkerContextWebDatabase.idl:
* Modules/websockets/DOMWindowWebSocket.idl:
* Modules/websockets/WorkerContextWebSocket.idl:
* bindings/js/JSDOMBinding.cpp:
* bindings/js/ScriptController.h:
(ScriptController):
* bindings/scripts/test/TestNode.idl:
* bindings/scripts/test/TestObj.idl:
* css/CSSFontFaceLoadEvent.idl:
* css/CSSHostRule.idl:
* css/CSSRule.idl:
* css/CSSRuleList.idl:
* css/CSSStyleDeclaration.idl:
* css/CSSStyleSheet.idl:
* css/CSSValue.idl:
* css/FontLoader.idl:
* css/StyleSheet.idl:
* css/WebKitCSSRegionRule.idl:
* dom/Clipboard.idl:
* dom/CustomElementConstructor.idl:
* dom/CustomEvent.idl:
* dom/DOMNamedFlowCollection.idl:
* dom/DOMStringMap.idl:
* dom/DataTransferItemList.idl:
* dom/Document.idl:
* dom/DocumentFragment.idl:
* dom/Element.idl:
* dom/Event.idl:
* dom/EventTarget.idl:
* dom/MessageChannel.idl:
* dom/MouseEvent.idl:
* dom/MutationRecord.idl:
* dom/NamedNodeMap.idl:
* dom/Node.idl:
* dom/NodeList.idl:
* dom/RequestAnimationFrameCallback.idl:
* dom/ShadowRoot.idl:
* dom/Text.idl:
* history/HistoryItem.cpp:
(WebCore::HistoryItem::encodeBackForwardTreeNode):
(WebCore::HistoryItem::decodeBackForwardTree):
* html/DOMSettableTokenList.idl:
* html/DOMTokenList.idl:
* html/HTMLAllCollection.idl:
* html/HTMLAppletElement.idl:
* html/HTMLCollection.idl:
* html/HTMLDialogElement.idl:
* html/HTMLDivElement.idl:
* html/HTMLDocument.idl:
* html/HTMLElement.idl:
* html/HTMLEmbedElement.idl:
* html/HTMLFormControlsCollection.idl:
* html/HTMLFormElement.idl:
* html/HTMLImageElement.idl:
* html/HTMLInputElement.idl:
* html/HTMLMediaElement.idl:
* html/HTMLObjectElement.idl:
* html/HTMLOptionsCollection.idl:
* html/HTMLSelectElement.idl:
* html/HTMLSpanElement.idl:
* html/HTMLStyleElement.idl:
* html/HTMLTemplateElement.idl:
* html/HTMLTrackElement.idl:
* html/HTMLUnknownElement.idl:
* html/MediaKeyError.idl:
* html/MediaKeyEvent.idl:
* html/MicroDataItemValue.idl:
* html/canvas/CanvasRenderingContext2D.idl:
* html/canvas/DOMPath.idl:
* html/shadow/HTMLContentElement.idl:
* html/shadow/HTMLShadowElement.idl:
* html/track/TextTrack.idl:
* inspector/InjectedScriptHost.idl:
* inspector/InspectorIndexedDBAgent.cpp:
(WebCore::InspectorIndexedDBAgent::requestDatabaseNames):
(WebCore::InspectorIndexedDBAgent::requestDatabase):
(WebCore::InspectorIndexedDBAgent::requestData):
(WebCore::InspectorIndexedDBAgent::clearObjectStore):
(WebCore):
* loader/EmptyClients.h:
(EmptyFrameLoaderClient):
* loader/FrameLoaderClient.h:
(FrameLoaderClient):
* page/Console.idl:
* page/DOMWindow.idl:
* page/DOMWindowPagePopup.idl:
* page/History.idl:
* page/Location.idl:
* platform/graphics/skia/PatternSkia.cpp:
(WebCore::Pattern::platformDestroy):
(WebCore::Pattern::platformPattern):
* testing/Internals.cpp:
(WebCore::Internals::serializeObject):
(WebCore::Internals::deserializeBuffer):
Source/WTF:
* wtf/ArrayBuffer.h:
(WTF):
(WTF::ArrayBufferContents::ArrayBufferContents):
(WTF::ArrayBufferContents::transfer):
(ArrayBufferContents):
(ArrayBuffer):
(WTF::ArrayBufferContents::~ArrayBufferContents):
* wtf/Platform.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147857
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
roger_fong@apple.com [Sat, 6 Apr 2013 22:05:35 +0000 (22:05 +0000)]
Windows VS2010 build fix.
* JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147856
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zandobersek@gmail.com [Sat, 6 Apr 2013 21:38:46 +0000 (21:38 +0000)]
Remove the USE(SKIA_ON_MAC_CHROMIUM) guards
https://bugs.webkit.org/show_bug.cgi?id=114084
Reviewed by Ryosuke Niwa.
Source/WebCore:
Remove the USE(SKIA_ON_MAC_CHROMIUM) guards. The guards were enabled only
for the Chromium port via the features.gypi file that was removed in r147714.
* platform/graphics/FloatPoint.h:
(FloatPoint):
* platform/graphics/FloatRect.h:
(FloatRect):
* platform/graphics/FloatSize.h:
(FloatSize):
* platform/graphics/FontPlatformData.cpp:
(WebCore):
* platform/graphics/FontPlatformData.h:
(FontPlatformData):
(WebCore::FontPlatformData::hash):
* platform/graphics/IntPoint.h:
(IntPoint):
* platform/graphics/IntRect.h:
(IntRect):
(WebCore):
* platform/graphics/IntSize.h:
(IntSize):
* platform/graphics/SimpleFontData.h:
(SimpleFontData):
(WebCore::SimpleFontData::widthForGlyph):
* platform/graphics/cg/FloatPointCG.cpp:
* platform/graphics/cg/FloatRectCG.cpp:
* platform/graphics/cg/FloatSizeCG.cpp:
* platform/graphics/cg/IntPointCG.cpp:
* platform/graphics/cg/IntRectCG.cpp:
* platform/graphics/cg/IntSizeCG.cpp:
* platform/graphics/mac/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::~FontCustomPlatformData):
(WebCore::createFontCustomPlatformData):
* platform/graphics/mac/FontCustomPlatformData.h:
(WebCore::FontCustomPlatformData::FontCustomPlatformData):
(FontCustomPlatformData):
Source/WebKit/blackberry:
* WebCoreSupport/AboutDataUseFeatures.in: Remove the SKIA_ON_MAC_(CHROME|CHROMIUM) reference.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147855
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 6 Apr 2013 21:21:32 +0000 (21:21 +0000)]
[EFL] build fails with error: 'UINT_MAX' was not declared in this scope
https://bugs.webkit.org/show_bug.cgi?id=114086
Patch by Ed Bartosh <bartosh@gmail.com> on 2013-04-06
Reviewed by Tim Horton.
* DumpRenderTree/AccessibilityUIElement.cpp: Included limits.h
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147854
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zandobersek@gmail.com [Sat, 6 Apr 2013 21:19:38 +0000 (21:19 +0000)]
Remove remaining PLATFORM(CHROMIUM) guards in TestWebKitAPI, WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=114083
Reviewed by Ryosuke Niwa.
Remove the remaining three occurrences of the PLATFORM(CHROMIUM) build guards
in TestWebKitAPI and WebKitTestRunner.
* TestWebKitAPI/config.h:
* TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
(TestWebKitAPI::InjectedBundleController::platformInitialize):
* WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
(WTR::InjectedBundle::platformInitialize):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147853
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zandobersek@gmail.com [Sat, 6 Apr 2013 21:18:32 +0000 (21:18 +0000)]
Remove the remaining PLATFORM(CHROMIUM) guard in JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=114082
Reviewed by Ryosuke Niwa.
* runtime/JSExportMacros.h: Remove the remaining PLATFORM(CHROMIUM) guard.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147852
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 6 Apr 2013 20:04:05 +0000 (20:04 +0000)]
--minimal build fails with error: control reaches end of non-void function
https://bugs.webkit.org/show_bug.cgi?id=114085
Patch by Ed Bartosh <bartosh@gmail.com> on 2013-04-06
Reviewed by Oliver Hunt.
* interpreter/Interpreter.cpp: return 0 if JIT is not enabled
(JSC::getBytecodeOffsetForCallFrame):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147851
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
robert@webkit.org [Sat, 6 Apr 2013 19:48:51 +0000 (19:48 +0000)]
REGRESSION(r142152): Text wraps in menu
https://bugs.webkit.org/show_bug.cgi?id=113706
Reviewed by David Hyatt.
Source/WebCore:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::inlineLogicalWidth): Empty inline elements add their inline border/padding/margin to the width of the
line when we iterate through them in nextLineBreak(), so no need to add them again here when climbing back up
from their first child looking for border/padding/margin to add. (An empty inline element can have floating children.)
LayoutTests:
* fast/inline/inline-with-empty-inline-children-expected.txt:
* fast/inline/inline-with-empty-inline-children.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147850
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Sat, 6 Apr 2013 19:17:05 +0000 (19:17 +0000)]
Try to fix the Windows build.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
Added back a symbol that is exported.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147849
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Sat, 6 Apr 2013 18:58:08 +0000 (18:58 +0000)]
Try to fix the WebKit2 build.
* NetworkProcess/NetworkResourceLoader.cpp:
(WebKit):
* NetworkProcess/NetworkResourceLoader.h:
(NetworkResourceLoader): Removed a defunct function.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147848
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Sat, 6 Apr 2013 18:54:18 +0000 (18:54 +0000)]
Try to fix the Windows build.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
Removed symbols that aren't exported.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147847
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Sat, 6 Apr 2013 18:24:37 +0000 (18:24 +0000)]
Rolled out 147820 and 147818 because they caused plugins tests to ASSERT
https://bugs.webkit.org/show_bug.cgi?id=114094
Reviewed by Anders Carlsson.
Source/JavaScriptCore:
* API/JSContextRef.cpp:
(JSContextCreateBacktrace):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitDebugHook):
* interpreter/Interpreter.cpp:
(JSC):
(JSC::Interpreter::dumpRegisters):
(JSC::Interpreter::unwindCallFrame):
(JSC::getLineNumberForCallFrame):
(JSC::getCallerInfo):
(JSC::Interpreter::getStackTrace):
(JSC::Interpreter::addStackTraceIfNecessary):
(JSC::Interpreter::retrieveCallerFromVMCode):
* interpreter/Interpreter.h:
(StackFrame):
(JSC::StackFrame::toString):
(JSC::StackFrame::friendlyLineNumber):
(Interpreter):
* runtime/Error.cpp:
(JSC::throwError):
* runtime/JSGlobalData.h:
(JSC):
(JSGlobalData):
* runtime/JSGlobalObject.cpp:
(JSC::DynamicGlobalObjectScope::DynamicGlobalObjectScope):
Source/WebCore:
* bindings/js/ScriptCallStackFactory.cpp:
(WebCore::createScriptCallStack):
* inspector/ScriptCallFrame.cpp:
(WebCore::ScriptCallFrame::isEqual):
* inspector/ScriptCallFrame.h:
(ScriptCallFrame):
(WebCore::ScriptCallFrame::lineNumber):
Tools:
* Scripts/run-jsc:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147846
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Sat, 6 Apr 2013 18:24:02 +0000 (18:24 +0000)]
Unreviewed WinCE build fix after r145849.
* WebCoreSupport/EditorClientWinCE.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147845
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Sat, 6 Apr 2013 18:23:12 +0000 (18:23 +0000)]
[CMake] Remove general include directories from platform specific files
Move the include directories, which are required by all CMake ports
to the general CMakeLists.txt to fix the build for Windows CE port.
* CMakeLists.txt:
* PlatformBlackBerry.cmake:
* PlatformEfl.cmake:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147844
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Sat, 6 Apr 2013 18:15:03 +0000 (18:15 +0000)]
Remove VisitedLinks.{cpp|h}
https://bugs.webkit.org/show_bug.cgi?id=114095
Reviewed by Geoffrey Garen.
* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* platform/VisitedLinks.cpp: Removed.
* platform/VisitedLinks.h: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147843
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Sat, 6 Apr 2013 18:10:18 +0000 (18:10 +0000)]
Unreviewed build fix after r146932.
* profiler/ProfilerDatabase.cpp:
(Profiler):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147842
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Sat, 6 Apr 2013 18:07:37 +0000 (18:07 +0000)]
Another build fix.
Actually remove the right files from WebCore.vcxproj.
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147841
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Sat, 6 Apr 2013 18:03:39 +0000 (18:03 +0000)]
Fix build.
ThreadableLoaderClientWrapper was still calling didReceiveCachedMetadata; I didn't notice it
because the file was not in the Xcode project so I went ahead and added it.
* WebCore.xcodeproj/project.pbxproj:
* loader/ThreadableLoaderClientWrapper.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147840
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Sat, 6 Apr 2013 17:55:06 +0000 (17:55 +0000)]
Remove dead CachedMetadata code
https://bugs.webkit.org/show_bug.cgi?id=114093
Reviewed by Geoffrey Garen.
* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* loader/CachedMetadata.cpp: Removed.
* loader/CachedMetadata.h: Removed.
* loader/ResourceLoader.h:
(ResourceLoader):
* loader/SubresourceLoader.cpp:
* loader/SubresourceLoader.h:
(SubresourceLoader):
* loader/ThreadableLoaderClient.h:
* loader/WorkerThreadableLoader.cpp:
* loader/WorkerThreadableLoader.h:
(MainThreadBridge):
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::reportMemoryUsage):
* loader/cache/CachedResource.h:
(WebCore):
(CachedResource):
* platform/network/ResourceHandle.cpp:
* platform/network/ResourceHandle.h:
(ResourceHandle):
* platform/network/ResourceHandleClient.h:
(ResourceHandleClient):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147839
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Sat, 6 Apr 2013 16:57:06 +0000 (16:57 +0000)]
Remove more dead Chromium code
https://bugs.webkit.org/show_bug.cgi?id=114090
Reviewed by Alp Toker.
* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.xcodeproj/project.pbxproj:
* platform/StatsCounter.cpp: Removed.
* platform/StatsCounter.h: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147838
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Sat, 6 Apr 2013 10:06:46 +0000 (10:06 +0000)]
Build fix for WinCE after r143046.
* platform/graphics/wince/ImageWinCE.cpp:
(WebCore::Image::drawPattern):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147837
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Sat, 6 Apr 2013 09:54:03 +0000 (09:54 +0000)]
Do not call getenv() on Windows CE where it does not exist.
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147836
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Sat, 6 Apr 2013 09:31:25 +0000 (09:31 +0000)]
[WinCE] Do not call missing method createDragImageFromImage()
https://bugs.webkit.org/show_bug.cgi?id=110421
Patch by Mark Salisbury <mark.salisbury@hp.com> on 2013-04-06
* platform/win/ClipboardWin.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147835
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Sat, 6 Apr 2013 09:22:20 +0000 (09:22 +0000)]
[WinCE] Compile missing NetworkStorageSession methods
https://bugs.webkit.org/show_bug.cgi?id=110419
Patch by Mark Salisbury <mark.salisbury@hp.com> on 2013-04-05
* PlatformWinCE.cmake:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147834
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Sat, 6 Apr 2013 06:27:37 +0000 (06:27 +0000)]
Move the flakiness dashboard to the new instance at webkit-test-results.appspot.com
https://bugs.webkit.org/show_bug.cgi?id=114080
Reviewed by Ryosuke Niwa.
This way, the WebKit and Blink dashboard code can change as appropriate without
needing to consider the other project's needs. This still doesn't update the
buildbots to upload to the new location, or the dashboard code to pull the
results.json files from the new location, but it at least allows for changing the
UI code (e.g. the WebKit one can remove all knowledge of the Chromium bots).
* TestResultServer/app.yaml:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147833
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kangil.han@samsung.com [Sat, 6 Apr 2013 04:41:38 +0000 (04:41 +0000)]
Prefer prefix ++/-- operators for non-primitive types
https://bugs.webkit.org/show_bug.cgi?id=114033
Reviewed by Alexey Proskuryakov.
Post ++/-- creates a copy of current value and it is not necessary, so use prefix instead.
* bindings/js/Dictionary.cpp:
(WebCore::Dictionary::getOwnPropertiesAsStringHashMap):
(WebCore::Dictionary::getOwnPropertyNames):
* bindings/js/ScriptCallStackFactory.cpp:
(WebCore::createScriptCallStack):
* dom/ContainerNode.cpp:
(WebCore::willRemoveChildren):
* dom/Range.cpp:
(WebCore::Range::processAncestorsAndTheirSiblings):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::detachChildren):
* platform/graphics/gpu/LoopBlinnPathProcessor.cpp:
(WebCore):
(WebCore::LoopBlinnPathProcessor::subdivideCurvesSlow):
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paintDocumentMarkers):
* xml/XPathFunctions.cpp:
(WebCore::XPath::Function::setArguments):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147832
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hmuller@adobe.com [Sat, 6 Apr 2013 04:21:08 +0000 (04:21 +0000)]
[CSS Exclusions] Add support for the simple case of shape-margin polygonal shape-outside
https://bugs.webkit.org/show_bug.cgi?id=113726
Reviewed by Dirk Schulze.
Source/WebCore:
Add support for computing the shape-outside shape-margin boundary for a polygon.
This change is similar to the one added for padding polygons, see bug 112592.
The algorithm used for computing the margin boundary is is provisional. It works
correctly for convex polygons and will work correctly for non self-intersecting
polygons whose margin boundary is the same shape as the original polygon.
Tests: fast/exclusions/shape-outside-floats/shape-outside-floats-diamond-margin-polygon.html
fast/exclusions/shape-outside-floats/shape-outside-floats-left-margin-polygon.html
fast/exclusions/shape-outside-floats/shape-outside-floats-right-margin-polygon.html
* rendering/ExclusionPolygon.cpp:
(WebCore::appendArc): Generalized this method a little, to deal with margin and padding connecting arcs.
(WebCore::computeShapePaddingBounds): Pass the new appendArc() parameter.
(WebCore::computeShapeMarginBounds): Compute the margin boundary for a polygon, per the constraints summarized above.
(WebCore::ExclusionPolygon::getExcludedIntervals): Use the margin polygon for this computation.
LayoutTests:
Verify that shape-outside layout works correctly on floats, when shape-margin is specifed.
* fast/exclusions/shape-outside-floats/shape-outside-floats-diamond-margin-polygon-expected.txt: Added.
* fast/exclusions/shape-outside-floats/shape-outside-floats-diamond-margin-polygon.html: Added.
* fast/exclusions/shape-outside-floats/shape-outside-floats-left-margin-polygon-expected.html: Added.
* fast/exclusions/shape-outside-floats/shape-outside-floats-left-margin-polygon.html: Added.
* fast/exclusions/shape-outside-floats/shape-outside-floats-right-margin-polygon-expected.html: Added.
* fast/exclusions/shape-outside-floats/shape-outside-floats-right-margin-polygon.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147831
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
benjamin@webkit.org [Sat, 6 Apr 2013 03:33:54 +0000 (03:33 +0000)]
Modernize fast/events/autoscroll.html
https://bugs.webkit.org/show_bug.cgi?id=112508
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-05
Reviewed by Jer Noble.
The test fast/events/autoscroll.html was introduced in
https://bugs.webkit.org/show_bug.cgi?id=12331 (r19102) to verify the page
does not scroll when the text is selected.
It seems reasonable to test the use case with a text dump instead of a pixel test.
This should reduces the maintenance needed to keep the test useful.
* fast/events/autoscroll.html: Removed.
* fast/events/no-scroll-on-input-text-selection-expected.txt: Added.
* fast/events/no-scroll-on-input-text-selection.html: Added.
* platform/efl/fast/events/autoscroll-expected.png: Removed.
* platform/efl/fast/events/autoscroll-expected.txt: Removed.
* platform/gtk/fast/events/autoscroll-expected.png: Removed.
* platform/gtk/fast/events/autoscroll-expected.txt: Removed.
* platform/mac-wk2/TestExpectations:
* platform/mac/fast/events/autoscroll-expected.png: Removed.
* platform/mac/fast/events/autoscroll-expected.txt: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147830
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aestes@apple.com [Sat, 6 Apr 2013 03:09:25 +0000 (03:09 +0000)]
Returning NULL from willSendRequest should cancel a load from the memory cache
https://bugs.webkit.org/show_bug.cgi?id=114075
Reviewed by Darin Adler.
Source/WebCore:
When a resource is loaded from the memory cache and the client does not
implement the didLoadResourceFromMemoryCache delegate method, WebKit
synthesizes the typical sequence of resource load callbacks. One of
these is willSendRequest, which gives the client the opportunity to
modify the request. We should respect these modifications.
Handling any arbitrary modification is difficult given where in the
loading process we check the memory cache (see <http://webkit.org/b/113251>),
but we can handle the common case where the client cancels the load by
returning a NULL request.
Test: fast/loader/willsendrequest-returns-null-for-memory-cache-load.html
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::willLoadMediaElementURL): Passed request to sendRemainingDelegateMessages.
(WebCore::FrameLoader::commitProvisionalLoad): Ditto.
(WebCore::FrameLoader::loadResourceSynchronously): Ditto.
(WebCore::FrameLoader::loadedResourceFromMemoryCache): Added an out
parameter to pass back a request potentially modified by
requestFromDelegate, which is also passed to sendRemainingDelegateMessages.
* loader/FrameLoader.h:
* loader/ResourceLoadNotifier.cpp:
(WebCore::ResourceLoadNotifier::dispatchDidFailLoading): Added a
function to dispatch didFailLoading and to call the correct InspectorInstrumentation.
(WebCore::ResourceLoadNotifier::sendRemainingDelegateMessages): If the
request is NULL, call dispatchDidFailLoading and return. This matches
the delegate callback sequence of a non memory cache load that is
cancelled by willSendRequest.
* loader/ResourceLoadNotifier.h:
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::shouldContinueAfterNotifyingLoadedFromMemoryCache):
Return false if the memory cache load is cancelled by the client.
(WebCore::CachedResourceLoader::requestResource): Return early if
shouldContinueAfterNotifyingLoadedFromMemoryCache is false.
LayoutTests:
* fast/loader/resources/cached-image.html: Added.
* fast/loader/willsendrequest-returns-null-for-memory-cache-load-expected.txt: Added.
* fast/loader/willsendrequest-returns-null-for-memory-cache-load.html: Added.
* platform/wk2/TestExpectations: Expect the test to fail in WKTR due to <http://webkit.org/b/114074>.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147829
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
benjamin@webkit.org [Sat, 6 Apr 2013 02:57:56 +0000 (02:57 +0000)]
Second attempt to fix the Windows bot
Unreviewed.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
* JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147828
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
benjamin@webkit.org [Sat, 6 Apr 2013 02:40:13 +0000 (02:40 +0000)]
Attempt to fix the Windows bot
Unreviewed.
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-05
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
* JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
r147825 removed the symbol for nullptr_t. Add it back.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147827
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Sat, 6 Apr 2013 02:05:18 +0000 (02:05 +0000)]
Re-enable testing on the commit queue
https://bugs.webkit.org/show_bug.cgi?id=114078
Reviewed by Darin Adler.
Re-enabled the feature and the associated tests.
* Scripts/webkitpy/tool/bot/commitqueuetask.py:
(CommitQueueTask.run):
* Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
(CommitQueueTaskTest._run_through_task):
* Scripts/webkitpy/tool/commands/queues_unittest.py:
(CommitQueueTest._mock_test_result):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147826
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
roger_fong@apple.com [Sat, 6 Apr 2013 01:22:51 +0000 (01:22 +0000)]
Build fix.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
* JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147825
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cfleizach@apple.com [Sat, 6 Apr 2013 01:08:24 +0000 (01:08 +0000)]
AX: VoiceOver can't press on items
https://bugs.webkit.org/show_bug.cgi?id=114071
Reviewed by Tim Horton.
Source/WebCore:
The AXScrollToVisibleAction should not be used on earlier Mac versions because
it confuses VoiceOver.
Updated existing tests.
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityActionNames]):
LayoutTests:
* platform/mac-future/accessibility: Added.
* platform/mac-future/accessibility/press-action-is-first-expected.txt: Added.
* platform/mac/accessibility/press-action-is-first-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147824
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 6 Apr 2013 00:49:26 +0000 (00:49 +0000)]
[WK2] --no-tiled-backing-store build fails because FloatPoint is not declared
https://bugs.webkit.org/show_bug.cgi?id=113618
Patch by Ed Bartosh <bartosh@gmail.com> on 2013-04-05
Reviewed by Simon Fraser.
* WebProcess/Plugins/Plugin.h: Forward declared FloatPoint
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147823
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Sat, 6 Apr 2013 00:42:49 +0000 (00:42 +0000)]
Stop building Objective-C bindings for the SVG DOM
https://bugs.webkit.org/show_bug.cgi?id=114076
Reviewed by Geoffrey Garen.
The DOM SVG Objective-C bindings have never been exposed as API, and not building them cuts WebCore build by 10%.
Source/WebCore:
* Configurations/FeatureDefines.xcconfig:
* Configurations/WebCore.xcconfig:
* WebCore.exp.in:
* WebCore.xcodeproj/project.pbxproj:
* bindings/objc/DOM.mm:
(WebCore::createElementClassMap):
(kitClass):
* bindings/objc/DOMCSS.mm:
(kitClass):
* bindings/objc/DOMEvents.mm:
* bindings/objc/DOMSVG.h: Removed.
* bindings/objc/DOMSVGException.h: Removed.
* bindings/objc/DOMSVGPathSegInternal.mm: Removed.
* bindings/objc/ExceptionHandlers.mm:
* html/HTMLEmbedElement.idl:
* html/HTMLFrameElement.idl:
* html/HTMLIFrameElement.idl:
* html/HTMLObjectElement.idl:
Source/WebKit/mac:
* Configurations/FeatureDefines.xcconfig:
* MigrateHeaders.make:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147822
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Sat, 6 Apr 2013 00:07:46 +0000 (00:07 +0000)]
Build fix.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147820
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
benjamin@webkit.org [Sat, 6 Apr 2013 00:06:09 +0000 (00:06 +0000)]
Change css1/basic/comments-expected.html to be a ref-test
https://bugs.webkit.org/show_bug.cgi?id=113996
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-05
Reviewed by Jer Noble.
The test css1/basic/comments.html verifies the handling
of comments inside a CSS declaration.
The test is changed to a ref-test by simply defining the style
directly on each element on the reference.
* css1/basic/comments-expected.html: Added.
* platform/efl/css1/basic/comments-expected.png: Removed.
* platform/efl/css1/basic/comments-expected.txt: Removed.
* platform/gtk/css1/basic/comments-expected.txt: Removed.
* platform/mac/css1/basic/comments-expected.png: Removed.
* platform/mac/css1/basic/comments-expected.txt: Removed.
* platform/qt/css1/basic/comments-expected.png: Removed.
* platform/qt/css1/basic/comments-expected.txt: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147819
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Fri, 5 Apr 2013 23:53:12 +0000 (23:53 +0000)]
Unify the many and varied stack trace mechanisms, and make the result sane.
https://bugs.webkit.org/show_bug.cgi?id=114072
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
Makes JSC::StackFrame record the bytecode offset and other necessary data
rather than requiring us to perform eager evaluation of the line number, etc.
Then remove most of the users of retrieveLastCaller, as most of them were
using it to create a stack trace in a fairly incomplete and inefficient way.
StackFrame now also has a couple of helpers to get the line and column info.
* API/JSContextRef.cpp:
(JSContextCreateBacktrace):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitDebugHook):
* interpreter/Interpreter.cpp:
(JSC):
(JSC::Interpreter::dumpRegisters):
(JSC::Interpreter::unwindCallFrame):
(JSC::getBytecodeOffsetForCallFrame):
(JSC::getCallerInfo):
(JSC::StackFrame::line):
(JSC::StackFrame::column):
(JSC::StackFrame::expressionInfo):
(JSC::StackFrame::toString):
(JSC::Interpreter::getStackTrace):
(JSC::Interpreter::addStackTraceIfNecessary):
(JSC::Interpreter::retrieveCallerFromVMCode):
* interpreter/Interpreter.h:
(StackFrame):
(Interpreter):
* runtime/Error.cpp:
(JSC::throwError):
* runtime/JSGlobalData.h:
(JSC):
(JSGlobalData):
* runtime/JSGlobalObject.cpp:
(JSC::DynamicGlobalObjectScope::DynamicGlobalObjectScope):
Source/WebCore:
Now that we've fleshed out the StackFrames from Interpreter::getStackTrace
WebCore can just ask us for a stack trace rather than implementing its own
stack walking.
* bindings/js/ScriptCallStackFactory.cpp:
(WebCore::createScriptCallStack):
* inspector/ScriptCallFrame.cpp:
(WebCore::ScriptCallFrame::isEqual):
* inspector/ScriptCallFrame.h:
(ScriptCallFrame):
(WebCore::ScriptCallFrame::columnNumber):
Tools:
The commandline jsc executable no longer requires arguments, so
I've made run-jsc work without them.
* Scripts/run-jsc:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147818
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mhahnenberg@apple.com [Fri, 5 Apr 2013 23:52:20 +0000 (23:52 +0000)]
tryCacheGetByID sets StructureStubInfo accessType to an incorrect value
https://bugs.webkit.org/show_bug.cgi?id=114068
Reviewed by Geoffrey Garen.
In the case where we have a non-Value cacheable property, we set the StructureStubInfo accessType to
get_by_id_self, but then we don't patch self and instead patch in a get_by_id_self_fail. This leads to
incorrect profiling data so when the DFG compiles the function, it uses a GetByOffset rather than a GetById,
which leads to loading a GetterSetter directly out of an object.
Source/JavaScriptCore:
* jit/JITStubs.cpp:
(JSC::tryCacheGetByID):
(JSC::DEFINE_STUB_FUNCTION):
LayoutTests:
* fast/js/jit-set-profiling-access-type-only-for-get-by-id-self-expected.txt: Added.
* fast/js/jit-set-profiling-access-type-only-for-get-by-id-self.html: Added.
* fast/js/script-tests/jit-set-profiling-access-type-only-for-get-by-id-self.js: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147816
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kov@webkit.org [Fri, 5 Apr 2013 23:50:15 +0000 (23:50 +0000)]
Translation of WebKitGTK+ for Malayalam (ml)
https://bugs.webkit.org/show_bug.cgi?id=113280
Patch by Ani Peter <peter.ani@gmail.com> on 2013-04-05
Reviewed by Gustavo Noronha Silva.
* ml.po: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147814
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kov@webkit.org [Fri, 5 Apr 2013 23:44:54 +0000 (23:44 +0000)]
webkit translations for gujarati
https://bugs.webkit.org/show_bug.cgi?id=113190
Patch by Sweta Kothari <swkothar@redhat.com> on 2013-04-05
Reviewed by Gustavo Noronha Silva.
* gu.po:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147812
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kov@webkit.org [Fri, 5 Apr 2013 23:35:18 +0000 (23:35 +0000)]
[l10n] [hi] Updated WebKit Translation in Hindi [hi] language
https://bugs.webkit.org/show_bug.cgi?id=113180
Patch by Rajesh Ranjan <rajeshkajha@yahoo.com> on 2013-04-05
Reviewed by Gustavo Noronha Silva.
* hi.po:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147811
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 5 Apr 2013 23:22:31 +0000 (23:22 +0000)]
[BlackBerry] FatFingers Don't check the shadow tree for all elements.
https://bugs.webkit.org/show_bug.cgi?id=114066
Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-04-05
Reviewed by Rob Buis.
BlackBerry PR 263078
Internally reviewed by Genevieve Mak.
No need to check shadow tree since sliders use touch events.
* WebKitSupport/FatFingers.cpp:
(BlackBerry::WebKit::FatFingers::isElementClickable):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147807
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin@apple.com [Fri, 5 Apr 2013 22:52:47 +0000 (22:52 +0000)]
Setting a header or footer should cause a relayout
https://bugs.webkit.org/show_bug.cgi?id=114070
Reviewed by Sam Weinig.
Mark the RenderView as needing layout in order to adjust everything for the new
header/footer.
* page/FrameView.cpp:
(WebCore::FrameView::setHeaderHeight):
(WebCore::FrameView::setFooterHeight):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147806
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cfleizach@apple.com [Fri, 5 Apr 2013 21:56:58 +0000 (21:56 +0000)]
AX: Make SVG Group containers accessible elements
https://bugs.webkit.org/show_bug.cgi?id=113939
Reviewed by Simon Fraser.
Source/WebCore:
SVG group containers are currently not exposed in the AX tree.
When an SVG element has a <title> child, that is not being used for the AX label.
When hit-testing, from Accessibility, SVG groups are never returned.
All these issues are fixed for Mac and iOS.
There are two tests because right now iOS skips all the top-level accessibility tests
due to fundamental architectural differences.
Tests: accessibility/svg-group-element-with-title.html
platform/iphone-simulator/accessibility/svg-group-element-with-title.html
* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::alternativeText):
(WebCore::AccessibilityNodeObject::accessibilityDescription):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityHitTest):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
* accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper isSVGGroupElement]):
(-[WebAccessibilityObjectWrapper determineIsAccessibilityElement]):
(-[WebAccessibilityObjectWrapper accessibilityClickPoint]):
* rendering/HitTestRequest.h:
Add a new option, AccessibilityHitTest, that will allow us to override normal behavior.
* rendering/svg/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::nodeAtFloatPoint):
Allow a SVG group to be the node at a point, for accessibility hit tests.
Tools:
Implement axController.elementAtPoint for iOS.
Implement a correct version of clickPoint for iOS.
* DumpRenderTree/ios/AccessibilityControllerIOS.mm:
(AccessibilityController::elementAtPoint):
* DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
(AccessibilityUIElement::clickPointX):
(AccessibilityUIElement::clickPointY):
LayoutTests:
* accessibility/svg-group-element-with-title-expected.txt: Added.
* accessibility/svg-group-element-with-title.html: Added.
* platform/iphone-simulator/accessibility/svg-group-element-with-title-expected.txt: Added.
* platform/iphone-simulator/accessibility/svg-group-element-with-title.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147802
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cfleizach@apple.com [Fri, 5 Apr 2013 21:54:22 +0000 (21:54 +0000)]
WebSpeech: event.elapsedTime is always
1364484608
https://bugs.webkit.org/show_bug.cgi?id=114045
Reviewed by Tim Horton.
Source/WebCore:
We were calculating elapsed time incorrectly.
Test: platform/mac/fast/speechsynthesis/speech-synthesis-elapsed-time.html
* Modules/speech/SpeechSynthesis.cpp:
(WebCore::SpeechSynthesis::fireEvent):
LayoutTests:
* platform/mac/fast/speechsynthesis/speech-synthesis-elapsed-time-expected.txt: Added.
* platform/mac/fast/speechsynthesis/speech-synthesis-elapsed-time.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147801
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cfleizach@apple.com [Fri, 5 Apr 2013 21:51:17 +0000 (21:51 +0000)]
WebSpeech: crash at WebCore::SpeechSynthesis::speak
https://bugs.webkit.org/show_bug.cgi?id=113937
Reviewed by Tim Horton.
Source/WebCore:
Protect against the case when invalid data is passed in.
Test: platform/mac/fast/speechsynthesis/speech-synthesis-crash-on-bad-utterance.html
* Modules/speech/SpeechSynthesis.cpp:
(WebCore::SpeechSynthesis::speak):
* Modules/speech/SpeechSynthesisUtterance.cpp:
(WebCore::SpeechSynthesisUtterance::setVoice):
LayoutTests:
* platform/mac/fast/speechsynthesis/speech-synthesis-crash-on-bad-utterance-expected.txt: Added.
* platform/mac/fast/speechsynthesis/speech-synthesis-crash-on-bad-utterance.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147800
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 5 Apr 2013 21:47:17 +0000 (21:47 +0000)]
[GTK] Change from PLATFORM(GTK) to USE(GLIB) in WTF/CurrentTime.cpp
https://bugs.webkit.org/show_bug.cgi?id=114061
Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2013-04-05
Reviewed by Gustavo Noronha Silva.
Now other ports using GLib can use the correct implementation
and not the fallback one without adding any other PLATFORM guards
here.
* wtf/CurrentTime.cpp:
(WTF):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147799
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Fri, 5 Apr 2013 21:34:15 +0000 (21:34 +0000)]
If CallFrame::trueCallFrame() knows that it's about to read garbage instead of a valid CodeOrigin/InlineCallFrame, then it should give up and return 0 and all callers should be robust against this
https://bugs.webkit.org/show_bug.cgi?id=114062
Reviewed by Oliver Hunt.
* bytecode/CodeBlock.h:
(JSC::CodeBlock::canGetCodeOrigin):
(CodeBlock):
* interpreter/CallFrame.cpp:
(JSC::CallFrame::trueCallFrame):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::getStackTrace):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147798
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Fri, 5 Apr 2013 21:19:56 +0000 (21:19 +0000)]
Throttle compositing layer flushes during page loading
https://bugs.webkit.org/show_bug.cgi?id=113786
Reviewed by Simon Fraser.
Page content can change rapidly during page loading triggering excessive layer flushes and repainting. We should avoid this unnecessary work.
This patch reduces layer flushes (and painting) during loading by 50-70% on many popular pages.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadProgressingStatusChanged):
* loader/FrameLoader.h:
* loader/ProgressTracker.cpp:
(WebCore::ProgressTracker::ProgressTracker):
(WebCore::ProgressTracker::reset):
(WebCore::ProgressTracker::progressStarted):
(WebCore::ProgressTracker::finalProgressComplete):
(WebCore::ProgressTracker::isLoadProgressing):
(WebCore::ProgressTracker::progressHeartbeatTimerFired):
* loader/ProgressTracker.h:
Track if the document load is progressing. This is done with a heartbeat timer that checks every 100ms if we have received more than 1k of data.
If four heartbeats pass without progress then we consider the load stalled.
* page/FrameView.cpp:
(WebCore::FrameView::resetDeferredRepaintDelay):
Disable throttling temporary on user interaction so the page stays as responsive as possible even during loading.
(WebCore::FrameView::updateLayerFlushThrottling):
Enable throttling when the load is progressing, disable otherwise.
* page/FrameView.h:
* platform/graphics/GraphicsLayer.h:
(WebCore::GraphicsLayer::canThrottleLayerFlush):
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::platformCALayerDidCreateTiles):
(WebCore::GraphicsLayerCA::canThrottleLayerFlush):
Don't throttle if new tiles have been added by the tile controller. They may have stale content and need to be flushed immediately.
(WebCore::GraphicsLayerCA::noteLayerPropertyChanged):
Set the new TilesAdded change flag.
* platform/graphics/ca/GraphicsLayerCA.h:
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::notifyFlushRequired):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::RenderLayerCompositor):
(WebCore::RenderLayerCompositor::notifyFlushRequired):
(WebCore::RenderLayerCompositor::scheduleLayerFlushNow):
Factor the actual flush scheduling to private function.
(WebCore::RenderLayerCompositor::scheduleLayerFlush):
Mark the compositor for flush and return without flushing if the flushes are currently being throttled.
(WebCore::RenderLayerCompositor::flushPendingLayerChanges):
After a flush, start the throtting timer (currently 0.5s) coalescing the subsequent flushes.
(WebCore::RenderLayerCompositor::didChangeVisibleRect):
Do immediately flush if needed.
(WebCore::RenderLayerCompositor::setLayerFlushThrottlingEnabled):
Flush immediately if disabled.
(WebCore::RenderLayerCompositor::disableLayerFlushThrottlingTemporarilyForInteraction):
(WebCore::RenderLayerCompositor::isThrottlingLayerFlushes):
(WebCore::RenderLayerCompositor::startLayerFlushTimerIfNeeded):
(WebCore::RenderLayerCompositor::layerFlushTimerFired):
Flush when the timer fires timer.
* rendering/RenderLayerCompositor.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147797
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
benjamin@webkit.org [Fri, 5 Apr 2013 20:52:10 +0000 (20:52 +0000)]
Clean the chromium bits of WebCore's WebDatabase
https://bugs.webkit.org/show_bug.cgi?id=114010
Reviewed by Ryosuke Niwa.
* Modules/webdatabase/AbstractDatabaseServer.h:
* Modules/webdatabase/ChangeVersionWrapper.cpp:
(WebCore::ChangeVersionWrapper::performPreflight):
(WebCore::ChangeVersionWrapper::performPostflight):
* Modules/webdatabase/Database.cpp:
* Modules/webdatabase/Database.h:
(Database):
* Modules/webdatabase/DatabaseBackend.cpp:
(WebCore::DatabaseBackend::openAndVerifyVersion):
* Modules/webdatabase/DatabaseBackendBase.cpp:
(WebCore::DoneCreatingDatabaseOnExitCaller::~DoneCreatingDatabaseOnExitCaller):
(WebCore::DatabaseBackendBase::performOpenAndVerify):
(WebCore::DatabaseBackendBase::getActualVersionForTransaction):
(WebCore::DatabaseBackendBase::incrementalVacuumIfNeeded):
* Modules/webdatabase/DatabaseBackendBase.h:
(DatabaseBackendBase):
* Modules/webdatabase/DatabaseBackendSync.cpp:
(WebCore::DatabaseBackendSync::openAndVerifyVersion):
* Modules/webdatabase/DatabaseContext.cpp:
(WebCore::DatabaseContext::databaseExceededQuota):
* Modules/webdatabase/DatabaseManager.cpp:
* Modules/webdatabase/DatabaseManager.h:
(DatabaseManager):
* Modules/webdatabase/DatabaseServer.cpp:
(WebCore::DatabaseServer::initialize):
(WebCore::DatabaseServer::setClient):
(WebCore::DatabaseServer::databaseDirectoryPath):
(WebCore::DatabaseServer::setDatabaseDirectoryPath):
(WebCore::DatabaseServer::openDatabase):
* Modules/webdatabase/DatabaseServer.h:
* Modules/webdatabase/DatabaseSync.cpp:
(WebCore::DatabaseSync::changeVersion):
* Modules/webdatabase/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::canEstablishDatabase):
(WebCore::DatabaseTracker::retryCanEstablishDatabase):
* Modules/webdatabase/DatabaseTracker.h:
(WebCore):
(DatabaseTracker):
* Modules/webdatabase/SQLStatementBackend.cpp:
(WebCore::SQLStatementBackend::execute):
(WebCore::SQLStatementBackend::setDatabaseDeletedError):
(WebCore::SQLStatementBackend::setVersionMismatchedError):
(WebCore::SQLStatementBackend::setFailureDueToQuota):
* Modules/webdatabase/SQLStatementBackend.h:
(SQLStatementBackend):
* Modules/webdatabase/SQLTransaction.cpp:
(WebCore::SQLTransaction::deliverTransactionCallback):
(WebCore::SQLTransaction::deliverStatementCallback):
* Modules/webdatabase/SQLTransactionBackend.cpp:
(WebCore::SQLTransactionBackend::executeSQL):
(WebCore::SQLTransactionBackend::openTransactionAndPreflight):
(WebCore::SQLTransactionBackend::runCurrentStatementAndGetNextState):
(WebCore::SQLTransactionBackend::nextStateForCurrentStatementError):
(WebCore::SQLTransactionBackend::postflightAndCommit):
(WebCore::SQLTransactionBackend::acquireOriginLock):
(WebCore::SQLTransactionBackend::releaseOriginLockIfNeeded):
* Modules/webdatabase/SQLTransactionBackend.h:
(SQLTransactionBackend):
* Modules/webdatabase/SQLTransactionBackendSync.cpp:
(WebCore::SQLTransactionBackendSync::begin):
(WebCore::SQLTransactionBackendSync::commit):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147796
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Fri, 5 Apr 2013 20:44:20 +0000 (20:44 +0000)]
Made USE(JSC) unconditional
https://bugs.webkit.org/show_bug.cgi?id=114058
Reviewed by Anders Carlsson.
../JavaScriptCore:
* config.h:
../ThirdParty:
* gtest/include/gtest/internal/gtest-port.h:
../WebCore:
* Modules/webdatabase/Database.cpp:
* bindings/ScriptControllerBase.cpp:
(WebCore::ScriptController::executeIfJavaScriptURL):
* bindings/js/JavaScriptCallFrame.cpp:
* bindings/js/JavaScriptCallFrame.h:
* bindings/scripts/InFilesCompiler.pm:
(generateHeadersHeader):
* css/MediaQueryListListener.cpp:
(WebCore::MediaQueryListListener::queryChanged):
* dom/ContainerNode.cpp:
(WebCore::dispatchChildRemovalEvents):
* dom/EventListener.h:
(EventListener):
(WebCore::EventListener::visitJSFunction):
* dom/EventTarget.h:
(EventTarget):
(WebCore):
(WebCore::EventTarget::visitJSEventListeners):
* dom/Node.cpp:
* dom/Node.h:
* dom/ScriptExecutionContext.cpp:
(WebCore):
(WebCore::ScriptExecutionContext::globalData):
* dom/ScriptExecutionContext.h:
(ScriptExecutionContext):
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::createImageBuffer):
* html/HTMLImageLoader.cpp:
(WebCore::HTMLImageLoader::notifyFinished):
* inspector/InjectedScriptHost.h:
(InjectedScriptHost):
(WebCore::InjectedScriptHost::evaluateReturnsEvalFunction):
* inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::didCommitLoadImpl):
* page/Frame.cpp:
* page/Settings.cpp:
(WebCore):
(WebCore::Settings::shouldRespectPriorityInCSSAttributeSetters):
* page/Settings.h:
(Settings):
* plugins/PluginView.cpp:
(WebCore::PluginView::start):
(WebCore::PluginView::stop):
(WebCore::PluginView::performRequest):
(WebCore::PluginView::npObject):
(WebCore):
(WebCore::PluginView::bindingInstance):
(WebCore::PluginView::privateBrowsingStateChanged):
* plugins/PluginView.h:
(PluginView):
* plugins/PluginViewBase.h:
(PluginViewBase):
(WebCore::PluginViewBase::scriptObject):
* plugins/PluginViewNone.cpp:
(WebCore):
(WebCore::PluginView::bindingInstance):
* plugins/qt/PluginViewQt.cpp:
(WebCore::PluginView::dispatchNPEvent):
(WebCore::PluginView::setNPWindowIfNeeded):
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::dropProtection):
../WebKit/efl:
* ewk/ewk_frame.cpp:
(ewk_frame_script_execute):
../WebKit/qt:
* Api/qwebscriptworld.cpp:
(QWebScriptWorld::QWebScriptWorld):
../WebKit2:
* Shared/linux/WebMemorySamplerLinux.cpp:
(WebKit::WebMemorySampler::sampleWebKit):
* config.h:
../WTF:
* wtf/ThreadRestrictionVerifier.h:
(WTF):
* wtf/WTFThreadData.cpp:
(WTF::WTFThreadData::WTFThreadData):
(WTF::WTFThreadData::~WTFThreadData):
* wtf/WTFThreadData.h:
(WTFThreadData):
* wtf/text/StringImpl.cpp:
(WTF::StringImpl::~StringImpl):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147795
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Fri, 5 Apr 2013 20:41:01 +0000 (20:41 +0000)]
Unreviewed, rolling out trac.webkit.org/changeset/147729
It's causing a bunch of breakage on some more strict compilers:
<inline asm>:1267:2: error: ambiguous instructions require an explicit suffix (could be 'ficomps', or 'ficompl')
* offlineasm/x86.rb:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147794
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
roger_fong@apple.com [Fri, 5 Apr 2013 20:38:35 +0000 (20:38 +0000)]
Unreviewed. More VS2010 solution makefile fixes.
<rdar://problem/
13588964>
* WTF.vcxproj/WTF.make:
* JavaScriptCore.vcxproj/JavaScriptCore.make:
* WebCore.vcxproj/WebCore.make:
* WebKit.vcxproj/WebKit.make:
* win/tools/WinTools.make:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147793
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 5 Apr 2013 20:29:44 +0000 (20:29 +0000)]
[EFL] --no-tiled-backing-store build fails because of not used #if USE(ACCELERATED_COMPOSITING)
https://bugs.webkit.org/show_bug.cgi?id=113627
Patch by Ed Bartosh <bartosh@gmail.com> on 2013-04-05
Reviewed by Simon Fraser.
.:
* Source/cmake/OptionsEfl.cmake: Disabled 3D_GRAPHICS and WEB_GL when accelerated compositing is on
Source/WebCore:
Wrapped code with #if USE(ACCELERATED_COMPOSITING) to make it compilable
with --no-tiled-backing-store build option:
* page/animation/ImplicitAnimation.cpp:
(WebCore::ImplicitAnimation::animate):
* page/animation/KeyframeAnimation.cpp:
(WebCore::KeyframeAnimation::animate):
* platform/graphics/TextTrackRepresentation.cpp:
(NullTextTrackRepresentation):
* platform/graphics/TextTrackRepresentation.h:
(TextTrackRepresentation):
* testing/Internals.cpp:
(WebCore::Internals::resetToConsistentState):
(WebCore::Internals::setHeaderHeight):
(WebCore::Internals::setFooterHeight):
Source/WebKit2:
Wrapped code with #if USE(ACCELERATED_COMPOSITING) to make it compilable
with --no-tiled-backing-store build option:
* UIProcess/API/C/efl/WKView.cpp:
* UIProcess/API/efl/EvasGLContext.cpp:
* UIProcess/API/efl/EvasGLContext.h:
* UIProcess/API/efl/EvasGLSurface.cpp:
* UIProcess/API/efl/EvasGLSurface.h:
* UIProcess/API/efl/EwkView.cpp:
(EwkView::EwkView):
(EwkView::displayTimerFired):
(EwkView::takeSnapshot):
* UIProcess/API/efl/EwkView.h:
(WebKit):
(EwkView):
* UIProcess/API/efl/SnapshotImageGL.cpp:
* UIProcess/API/efl/SnapshotImageGL.h:
* UIProcess/PageViewportController.cpp:
* UIProcess/PageViewportController.h:
* UIProcess/efl/PageViewportControllerClientEfl.cpp:
* UIProcess/efl/ViewClientEfl.cpp:
(WebKit::ViewClientEfl::didChangeContentsSize):
* UIProcess/efl/WebView.cpp:
(WebKit::WebView::didCommitLoad):
(WebKit::WebView::updateViewportSize):
(WebKit::WebView::didChangeViewportProperties):
(WebKit::WebView::pageDidRequestScroll):
(WebKit::WebView::didRenderFrame):
(WebKit::WebView::pageTransitionViewportReady):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147792
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 5 Apr 2013 20:04:25 +0000 (20:04 +0000)]
Unreviewed, rolling out r147773 and r147774.
http://trac.webkit.org/changeset/147773
http://trac.webkit.org/changeset/147774
https://bugs.webkit.org/show_bug.cgi?id=114056
Causing some exceptions on AppEngine I don't understand
(Requested by rniwa on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-04-05
* QueueStatusServer/config/queues.py:
* QueueStatusServer/model/queues.py:
(Queue.short_name):
(Queue.display_name):
* QueueStatusServer/model/queues_unittest.py:
(QueueTest.test_short_name):
(QueueTest.test_display_name):
(QueueTest.test_name_with_underscores):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147791
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 5 Apr 2013 19:55:35 +0000 (19:55 +0000)]
Remove the remaining Chromium files from WebCore
https://bugs.webkit.org/show_bug.cgi?id=114055
Reviewed by Benjamin Poulain.
Removed.
* Resources/pagepopups/chromium: Removed.
* Resources/pagepopups/chromium/calendarPickerChromium.css: Removed.
* Resources/pagepopups/chromium/pickerCommonChromium.css: Removed.
* html/shadow/MediaControlsChromium.cpp: Removed.
* html/shadow/MediaControlsChromium.h: Removed.
* html/shadow/MediaControlsChromiumAndroid.cpp: Removed.
* html/shadow/MediaControlsChromiumAndroid.h: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147790
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Fri, 5 Apr 2013 19:49:20 +0000 (19:49 +0000)]
Fixed run-bindings-tests by removing V8
https://bugs.webkit.org/show_bug.cgi?id=114053
Reviewed by Benjamin Poulain.
* Scripts/run-bindings-tests:
(main):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147789
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 5 Apr 2013 19:48:12 +0000 (19:48 +0000)]
Remove Chromium code from WebCore/css
https://bugs.webkit.org/show_bug.cgi?id=114052
Reviewed by Benjamin Poulain.
Removed.
* css/mediaControlsChromium.css: Removed.
* css/mediaControlsChromiumAndroid.css: Removed.
* css/themeChromium.css: Removed.
* css/themeChromiumAndroid.css: Removed.
* css/themeChromiumLinux.css: Removed.
* css/themeChromiumSkia.css: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147788
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 5 Apr 2013 19:45:03 +0000 (19:45 +0000)]
[GStreamer] Segfault when attempting to install missing plugins
https://bugs.webkit.org/show_bug.cgi?id=114046
gst_install_plugins_async expects a null terminated list, but we weren't
adding a null terminator.
Patch by Brendan Long <self@brendanlong.com> on 2013-04-05
Reviewed by Philippe Normand.
No new tests since this just fixes a segfault.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::handleMessage):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147787
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
benjamin@webkit.org [Fri, 5 Apr 2013 19:40:18 +0000 (19:40 +0000)]
Remove the chromium code for WebCore's indexeddb module
https://bugs.webkit.org/show_bug.cgi?id=114004
Reviewed by Ryosuke Niwa.
* Modules/indexeddb/IDBBackingStore.cpp:
(WebCore::IDBBackingStore::IDBBackingStore):
* Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::openConnection):
(WebCore::IDBDatabaseBackendImpl::close):
* Modules/indexeddb/IDBFactoryBackendInterface.cpp:
* Modules/indexeddb/IDBTracing.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147786
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Fri, 5 Apr 2013 19:36:19 +0000 (19:36 +0000)]
Removed a chunk of the v8 bindings. Reviewed by Sam 'Anders Carlsson' Weinig. I'm using a direct http commit to reduce email traffic.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147785
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Fri, 5 Apr 2013 19:36:11 +0000 (19:36 +0000)]
Removed a chunk of the v8 bindings. Reviewed by Sam 'Anders Carlsson' Weinig. I'm using a direct http commit to reduce email traffic.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147784
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Fri, 5 Apr 2013 19:34:17 +0000 (19:34 +0000)]
Removed a chunk of the v8 bindings. Reviewed by Sam 'Anders Carlsson' Weinig. I'm using a direct http commit to reduce email traffic.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147783
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Fri, 5 Apr 2013 19:34:13 +0000 (19:34 +0000)]
Removed a chunk of the v8 bindings. Reviewed by Sam 'Anders Carlsson' Weinig. I'm using a direct http commit to reduce email traffic.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147782
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Fri, 5 Apr 2013 19:34:10 +0000 (19:34 +0000)]
Removed a chunk of the v8 bindings. Reviewed by Sam 'Anders Carlsson' Weinig. I'm using a direct http commit to reduce email traffic.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147781
268f45cc-cd09-0410-ab3c-
d52691b4dbfc