mjs [Sat, 20 Oct 2007 08:51:48 +0000 (08:51 +0000)]
Reviewed by Nikolas.
- Rebalance test complexity.
Scaled all the tests so they take 400-600ms on a reasonably normal user setup:
Internet Explorer 7, Window XP, Dell Latitude D810 with a 2.13GHz Pentium M
However, for some tests, IE7 was a huge outlier compared to other
major browsers. For those tests, I used Firefox 2.0.0.8 on the
same OS and hardware as a normalization basis.
* tests/3d-morph.js:
* tests/3d-raytrace.js:
* tests/bitops-3bit-bits-in-byte.js:
* tests/bitops-bits-in-byte.js:
* tests/bitops-bitwise-and.js:
* tests/math-cordic.js:
* tests/string-base64.js:
* tests/string-tagcloud.js:
* tests/string-unpack-code.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26814
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Sat, 20 Oct 2007 08:11:55 +0000 (08:11 +0000)]
Reviewed by Oliver.
- Fix the browser-hosted driver to be compatible with Safari 2
* hosted/sunspider-driver.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26813
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Sat, 20 Oct 2007 08:05:36 +0000 (08:05 +0000)]
Rubber stamped by Hyatt.
- Add BSD license notice to cordic test, the original author said to do so.
* tests/math-cordic.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26812
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Sat, 20 Oct 2007 07:11:53 +0000 (07:11 +0000)]
Reviewed by Maciej Stachowiak.
Fixed http://bugs.webkit.org/show_bug.cgi?id=15570
Store gathered declaration nodes in the function body node.
This means that you only have to gather the declaration nodes the first
time the function executes. Performance gain of 2.10% on SunSpider,
0.90% on command-line JS iBench.
* kjs/nodes.cpp: Split declaration stack initialization code off into
initializeDeclarationStacks().
(FunctionBodyNode::FunctionBodyNode):
(FunctionBodyNode::initializeDeclarationStacks):
(FunctionBodyNode::processDeclarations):
* kjs/nodes.h: Changed DeclarationStacks structure to hold references,
since the actual Vectors are now stored either on the stack or in the
function body node.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26811
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp [Sat, 20 Oct 2007 05:37:07 +0000 (05:37 +0000)]
2007-10-19 Alp Toker <alp@atoker.com>
Reviewed by Oliver.
GTK+ build fix enabling the new local database storage feature.
There is also a prospective Qt build fix.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26810
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Sat, 20 Oct 2007 05:20:20 +0000 (05:20 +0000)]
Added Bugzilla link to ChangeLog
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26809
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Sat, 20 Oct 2007 05:18:23 +0000 (05:18 +0000)]
Reviewed by Darin Adler.
To improve encapsulation, moved processDeclarations call into
FunctionBodyNode::execute. Also marked processDeclarations
ALWAYS_INLINE, since it has only 1 caller now. This is a .71% speedup
on command-line JS iBench.
* kjs/function.cpp:
(KJS::FunctionImp::callAsFunction):
(KJS::GlobalFuncImp::callAsFunction):
* kjs/function.h:
* kjs/interpreter.cpp:
(KJS::Interpreter::evaluate):
* kjs/nodes.cpp:
(FunctionBodyNode::execute):
* kjs/nodes.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26808
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andrew [Sat, 20 Oct 2007 04:08:30 +0000 (04:08 +0000)]
Reviewed by Brady Eidson.
Mac build fix.
* WebCore.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26806
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver [Sat, 20 Oct 2007 03:09:43 +0000 (03:09 +0000)]
Updating window properties to include new features from HTML5 database support
RS=Mark
* fast/dom/Window/window-properties-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26805
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Sat, 20 Oct 2007 02:20:01 +0000 (02:20 +0000)]
Reviewed by Mark Rowe.
Fix a couple of exceptions for first time users.
* misc/DatabaseExample.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26804
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp [Sat, 20 Oct 2007 01:48:21 +0000 (01:48 +0000)]
2007-10-19 Alp Toker <alp@atoker.com>
Reviewed by Oliver.
Use platform colors for text selection.
Update the cache when the GTK style is changed.
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::platformActiveSelectionBackgroundColor):
(WebCore::RenderThemeGtk::platformInactiveSelectionBackgroundColor):
(WebCore::RenderThemeGtk::platformActiveSelectionForegroundColor):
(WebCore::RenderThemeGtk::platformInactiveSelectionForegroundColor):
(WebCore::RenderThemeGtk::gtkStyleSet):
(WebCore::RenderThemeGtk::gtkEntry):
* platform/gtk/RenderThemeGtk.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26803
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Sat, 20 Oct 2007 01:18:27 +0000 (01:18 +0000)]
WebCore:
Reviewed by Beth.
Fix for: <rdar://problem/
5518461> REGRESSION (2.0.4-3): Popup arrows are missing in small popups at homedepot.com
Test: fast/forms/menulist-no-overflow.html
* rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::setStyle): Don't allow overflow on menu lists.
LayoutTests:
Reviewed by Beth.
Test for <rdar://problem/
5518461> REGRESSION (2.0.4-3): Popup arrows are missing in small popups at homedepot.com
* fast/forms/menulist-no-overflow.html: Added.
* platform/mac/fast/forms/menulist-no-overflow-expected.checksum: Added.
* platform/mac/fast/forms/menulist-no-overflow-expected.png: Added.
* platform/mac/fast/forms/menulist-no-overflow-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26802
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Sat, 20 Oct 2007 01:06:26 +0000 (01:06 +0000)]
Reviewed by Brady.
Move some SQL-related classes to platform/sql.
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* loader/icon/SQLDatabase.cpp: Removed.
* loader/icon/SQLDatabase.h: Removed.
* loader/icon/SQLStatement.cpp: Removed.
* loader/icon/SQLStatement.h: Removed.
* loader/icon/SQLTransaction.cpp: Removed.
* loader/icon/SQLTransaction.h: Removed.
* platform/sql/SQLDatabase.cpp: Copied from loader/icon/SQLDatabase.cpp.
* platform/sql/SQLDatabase.h: Copied from loader/icon/SQLDatabase.h.
* platform/sql/SQLStatement.cpp: Copied from loader/icon/SQLStatement.cpp.
* platform/sql/SQLStatement.h: Copied from loader/icon/SQLStatement.h.
* platform/sql/SQLTransaction.cpp: Copied from loader/icon/SQLTransaction.cpp.
* platform/sql/SQLTransaction.h: Copied from loader/icon/SQLTransaction.h.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26801
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Sat, 20 Oct 2007 00:49:20 +0000 (00:49 +0000)]
Reviewed by Brady.
Make example actually work.
* misc/DatabaseExample.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26800
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Sat, 20 Oct 2007 00:45:33 +0000 (00:45 +0000)]
WebCore:
Reviewed by Adam.
Update to match the latest version of the spec. Now, executeSQL takes an array
of SQL parameters instead of them being passed as arguments.
* bindings/js/JSDatabaseCustom.cpp:
(WebCore::JSDatabase::executeSql):
* page/inspector/DatabasePanel.js:
* storage/Database.idl:
WebKitSite:
Reviewed by Adam.
Update example.
* misc/DatabaseExample.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26799
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kmccullo [Sat, 20 Oct 2007 00:38:37 +0000 (00:38 +0000)]
Reviewed by Adam.
- This change should be identical but for some reason was not working
on my machine.
* Scripts/prepare-ChangeLog:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26798
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Sat, 20 Oct 2007 00:22:56 +0000 (00:22 +0000)]
WebCore:
Reviewed by Tim
Tiger's SQLite doesn't support CREATE TABLE IF NOT EXISTS :(
* storage/Database.cpp:
(WebCore::Database::performOpenAndVerify):
* storage/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::DatabaseTracker):
WebKitSite:
Reviewed by Tim
Tiger's SQLite doesn't support CREATE TABLE IF NOT EXISTS :(
* misc/DatabaseExample.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26797
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Fri, 19 Oct 2007 23:57:36 +0000 (23:57 +0000)]
Release build fix.
* WebCore.vcproj/WebCore.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26796
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Fri, 19 Oct 2007 23:37:09 +0000 (23:37 +0000)]
Remove stray printfs
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::~Document):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26793
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Fri, 19 Oct 2007 23:36:21 +0000 (23:36 +0000)]
Reviewed by Brady.
Apparently the Win32 pthreads impl we use does not allow unlocking a mutex that has not
already been locked, so lock the mutex first.
* storage/DatabaseThread.cpp:
(WebCore::DatabaseThread::databaseThread):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26792
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Fri, 19 Oct 2007 23:34:03 +0000 (23:34 +0000)]
Better build fix
* loader/icon/SQLDatabase.cpp:
(WebCore::SQLDatabase::authorizerFunction): Definite works by 3.3.13
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26791
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Fri, 19 Oct 2007 23:25:46 +0000 (23:25 +0000)]
Build fix
* loader/icon/SQLDatabase.cpp:
(WebCore::SQLDatabase::authorizerFunction): I don't know *when* these constants were
added to SQLite, but I know they were by 3.4.0
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26790
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Fri, 19 Oct 2007 22:50:08 +0000 (22:50 +0000)]
JavaScriptCore:
2007-10-19 Brady Eidson <beidson@apple.com>
Reviewed by Sam
Queue -> Deque! and small style tweaks
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj
* wtf/Deque.h: Added.
(WTF::DequeNode::DequeNode):
(WTF::Deque::Deque):
(WTF::Deque::~Deque):
(WTF::Deque::size):
(WTF::Deque::isEmpty):
(WTF::Deque::append):
(WTF::Deque::prepend):
(WTF::Deque::first):
(WTF::Deque::last):
(WTF::Deque::removeFirst):
(WTF::Deque::clear):
* wtf/Queue.h: Removed.
2007-10-19 Brady Eidson <beidson@apple.com>
Reviewed by Oliver
Added a simple LinkedList based Queue to wtf
We can make a better, more sophisticated an efficient one later, but have
needed one for some time, now!
* JavaScriptCore.xcodeproj/project.pbxproj:
* wtf/Queue.h: Added.
(WTF::QueueNode::QueueNode):
(WTF::Queue::Queue):
(WTF::Queue::~Queue):
(WTF::Queue::size):
(WTF::Queue::isEmpty):
(WTF::Queue::append):
(WTF::Queue::prepend):
(WTF::Queue::first):
(WTF::Queue::last):
(WTF::Queue::removeFirst):
(WTF::Queue::clear):
WebCore:
2007-10-19 Brady Eidson <beidson@apple.com>
Reviewed by Anders
Windows specific changes, as well as renaming Queue -> Deque
* ForwardingHeaders/wtf/Deque.h: Added.
* ForwardingHeaders/wtf/Queue.h: Removed.
* platform/win/FileSystemWin.cpp:
(WebCore::fileSize):
(WebCore::fileExists):
(WebCore::deleteFile):
(WebCore::pathByAppendingComponent):
(WebCore::fileSystemRepresentation):
(WebCore::makeAllDirectories):
(WebCore::homeDirectoryPath):
* storage/Database.h:
* storage/DatabaseThread.cpp:
(WebCore::DatabaseThread::documentGoingAway):
(WebCore::DatabaseThread::databaseGoingAway):
(WebCore::DatabaseThread::dispatchNextTaskIdentifier):
(WebCore::DatabaseThread::scheduleTask):
(WebCore::DatabaseThread::scheduleImmediateTask):
* storage/DatabaseThread.h:
2007-10-19 Brady Eidson <beidson@apple.com>
Reviewed by Tim and Anders
Preliminary support for HTML5 local database storage (http://www.whatwg.org/specs/web-apps/current-work/)
The specification is still in flux but the fundamentals are pretty solid and we can start using and testing
this implementation even while filing bugs to track changes in the spec as it becomes more final
There are some implementation details in this patch that seem unused or useless, but they remain in place
while the spec is in flux and might go one way or another.
* platform/Logging.cpp: Add StorageAPI logging channel
* platform/Logging.h:
* storage/Database.cpp: Added.
(WebCore::Database::databaseInfoTableName):
(WebCore::databaseVersionKey):
(WebCore::Database::openDatabase): C++ version of the window.openDatabase() javascript API
(WebCore::Database::Database):
(WebCore::Database::~Database):
(WebCore::Database::openAndVerifyVersion):
(WebCore::retrieveTextResultFromDatabase):
(WebCore::Database::getVersionFromDatabase):
(WebCore::setTextValueInDatabase):
(WebCore::Database::setVersionInDatabase):
(WebCore::Database::databaseThreadGoingAway): May be removed in the future
(WebCore::Database::disableAuthorizer): For internal (WebInspector) use to get around the authorizer's restrictions
(WebCore::Database::enableAuthorizer):
(WebCore::Database::guidForOriginAndName): Candidate for refactoring and/or moving to the database tracker.
The GUID for each database identifier is currently for tracking the database version, but might be rescoped in the future
(WebCore::Database::resetAuthorizer):
(WebCore::Database::performPolicyChecks): Currently, the only post-executeSql policy check planned is the origin size usage
(WebCore::Database::scheduleDatabaseCallback):
(WebCore::Database::performOpenAndVerify):
(WebCore::Database::performChangeVersion):
(WebCore::Database::performExecuteSql):
(WebCore::Database::performCloseTransaction):
(WebCore::Database::performGetTableNames):
(WebCore::Database::version): C++ version of the javascript API
(WebCore::Database::changeVersion): Ditto
(WebCore::Database::executeSql): Ditto
(WebCore::Database::closeTransaction): Ditto
(WebCore::Database::tableNames): For internal (WebInspector) use
(WebCore::Database::deliverAllPendingCallbacks):
(WebCore::Database::deliverPendingCallbacks):
* storage/Database.h: Added.
(WebCore::Database::databaseDebugName): For debug logging purposes
* storage/Database.idl: Added.
* storage/DatabaseAuthorizer.cpp: Added.
The DatabaseAuthorizer is used to both prevent the script from doing "illegal" things in sql as well as
tracking when effects certain sql statements might have (such as increasing the size of the database)
(WebCore::DatabaseAuthorizer::DatabaseAuthorizer):
(WebCore::DatabaseAuthorizer::reset):
(WebCore::DatabaseAuthorizer::createTable):
(WebCore::DatabaseAuthorizer::createTempTable):
(WebCore::DatabaseAuthorizer::dropTable):
(WebCore::DatabaseAuthorizer::dropTempTable):
(WebCore::DatabaseAuthorizer::allowAlterTable):
(WebCore::DatabaseAuthorizer::createIndex):
(WebCore::DatabaseAuthorizer::createTempIndex):
(WebCore::DatabaseAuthorizer::dropIndex):
(WebCore::DatabaseAuthorizer::dropTempIndex):
(WebCore::DatabaseAuthorizer::createTrigger):
(WebCore::DatabaseAuthorizer::createTempTrigger):
(WebCore::DatabaseAuthorizer::dropTrigger):
(WebCore::DatabaseAuthorizer::dropTempTrigger):
(WebCore::DatabaseAuthorizer::createVTable):
(WebCore::DatabaseAuthorizer::dropVTable):
(WebCore::DatabaseAuthorizer::allowDelete):
(WebCore::DatabaseAuthorizer::allowInsert):
(WebCore::DatabaseAuthorizer::allowUpdate):
(WebCore::DatabaseAuthorizer::allowRead):
(WebCore::DatabaseAuthorizer::allowAnalyze):
(WebCore::DatabaseAuthorizer::allowPragma):
(WebCore::DatabaseAuthorizer::allowAttach):
(WebCore::DatabaseAuthorizer::allowDetach):
(WebCore::DatabaseAuthorizer::allowFunction):
(WebCore::DatabaseAuthorizer::disable):
(WebCore::DatabaseAuthorizer::enable):
(WebCore::DatabaseAuthorizer::denyBasedOnTableName): Don't allow access to the __WebKit meta info table as
it should be invisible to scripts
* storage/DatabaseAuthorizer.h: Added.
(WebCore::DatabaseAuthorizer::lastActionWasInsert):
(WebCore::DatabaseAuthorizer::lastActionIncreasedSize):
* storage/DatabaseCallback.cpp: Added.
Generic item to queue up for callbacks on the main thread for database activities that take place on
a secondary thread
(WebCore::DatabaseChangeVersionCallback::DatabaseChangeVersionCallback):
(WebCore::DatabaseChangeVersionCallback::performCallback):
(WebCore::DatabaseExecuteSqlCallback::DatabaseExecuteSqlCallback):
(WebCore::DatabaseExecuteSqlCallback::performCallback):
* storage/DatabaseCallback.h: Added.
(WebCore::DatabaseCallback::~DatabaseCallback):
(WebCore::DatabaseChangeVersionCallback::~DatabaseChangeVersionCallback):
(WebCore::DatabaseExecuteSqlCallback::~DatabaseExecuteSqlCallback):
* storage/DatabaseTask.h: Added.
Generic work-item to be queued up on the background database thread
(WebCore::DatabaseTask::isComplete):
(WebCore::DatabaseOpenTask::exceptionCode):
(WebCore::DatabaseOpenTask::openSuccessful):
(WebCore::DatabaseTableNamesTask::tableNames):
* storage/DatabaseTask.cpp: Added.
(WebCore::DatabaseTask::DatabaseTask):
(WebCore::DatabaseTask::~DatabaseTask):
(WebCore::DatabaseTask::performTask):
(WebCore::DatabaseTask::lockForSynchronousScheduling): Used when the main thread needs this task accomplished
synchronously
(WebCore::DatabaseTask::waitForSynchronousCompletion):
(WebCore::DatabaseOpenTask::DatabaseOpenTask):
(WebCore::DatabaseOpenTask::doPerformTask):
(WebCore::DatabaseExecuteSqlTask::DatabaseExecuteSqlTask):
(WebCore::DatabaseExecuteSqlTask::doPerformTask):
(WebCore::DatabaseChangeVersionTask::DatabaseChangeVersionTask):
(WebCore::DatabaseChangeVersionTask::doPerformTask):
(WebCore::DatabaseTableNamesTask::DatabaseTableNamesTask):
(WebCore::DatabaseTableNamesTask::doPerformTask):
* storage/DatabaseThread.cpp: Added.
The current design is that each Document will have its own DatabaseThread. This makes scripts on each
individual document more response at the cost of adding more threads and potentially creating concurrency
issues when the same database is open twice from two different documents
(WebCore::DatabaseThread::DatabaseThread):
(WebCore::DatabaseThread::~DatabaseThread):
(WebCore::DatabaseThread::start):
(WebCore::DatabaseThread::documentGoingAway): Called to shut the thread down when the document is destroyed
(WebCore::DatabaseThread::databaseGoingAway): Remove all pending tasks for this database
(WebCore::DatabaseThread::databaseThreadStart):
(WebCore::DatabaseThread::databaseThread):
(WebCore::DatabaseThread::dispatchNextTaskIdentifier):
(WebCore::DatabaseThread::scheduleTask):
(WebCore::DatabaseThread::scheduleImmediateTask): Schedule a task that gets to "cut to the front of the line" when
the main thread requires a task be performed synchronously
(WebCore::DatabaseThread::wakeWorkThread):
* storage/DatabaseThread.h: Added.
* storage/DatabaseTracker.cpp: Added.
The DatabaseTracker is the master management of all databases. It will keep track of the filename for a given
unique database, keep track of the total disk usage per-origin, and policys per database/origin
(WebCore::DatabaseTracker::setDatabasePath):
(WebCore::DatabaseTracker::databasePath):
(WebCore::DatabaseTracker::tracker):
(WebCore::DatabaseTracker::DatabaseTracker):
(WebCore::DatabaseTracker::fullPathForDatabase):
(WebCore::DatabaseTracker::populateOrigins):
(WebCore::DatabaseTracker::origins):
(WebCore::DatabaseTracker::databaseNamesForOrigin):
(WebCore::DatabaseTracker::addDatabase):
(WebCore::DatabaseTracker::deleteAllDatabases):
(WebCore::DatabaseTracker::deleteAllDatabasesForOrigin):
* storage/DatabaseTracker.h: Added.
* storage/SQLCallback.h: Added. C++ version of the javascript executeSql() callback
(WebCore::SQLCallback::~SQLCallback):
* storage/SQLCallback.idl: Added.
* storage/SQLResultSet.cpp: Added. C++ version of the javascript SQLResultSet object
(WebCore::SQLResultSet::SQLResultSet):
(WebCore::SQLResultSet::insertId):
(WebCore::SQLResultSet::rowsAffected):
(WebCore::SQLResultSet::errorCode):
(WebCore::SQLResultSet::error):
(WebCore::SQLResultSet::rows):
(WebCore::SQLResultSet::setInsertId):
(WebCore::SQLResultSet::setRowsAffected):
(WebCore::SQLResultSet::setErrorCode):
(WebCore::SQLResultSet::setErrorMessage):
* storage/SQLResultSet.h: Added.
* storage/SQLResultSet.idl: Added.
* storage/SQLResultSetRowList.cpp: Added. C++ version of the javascript SQLResultSetRowList object
(WebCore::SQLResultSetRowList::length):
* storage/SQLResultSetRowList.h: Added.
(WebCore::SQLResultSetRowList::columnNames):
(WebCore::SQLResultSetRowList::values):
(WebCore::SQLResultSetRowList::addColumn):
(WebCore::SQLResultSetRowList::addResult):
* storage/SQLResultSetRowList.idl: Added.
* storage/VersionChangeCallback.h: Added. C++ version of the javascript changeVersion() callback
(WebCore::VersionChangeCallback::~VersionChangeCallback):
* storage/VersionChangeCallback.idl: Added.
2007-10-19 Brady Eidson <beidson@apple.com>
Reviewed by Oliver + Same
Forwarding header for the new wtf/Queue.h
* ForwardingHeaders/wtf/Queue.h: Added.
2007-10-19 Anders Carlsson <beidson@apple.com>
Reviewed by Sam Weinig
Most of the Javascript binding support for the Storage API
* bindings/js/JSCustomSQLCallback.cpp: Added.
(WebCore::JSCustomSQLCallback::JSCustomSQLCallback):
(WebCore::JSCustomSQLCallback::handleEvent):
* bindings/js/JSCustomSQLCallback.h: Added.
Add JSCustomSQLCallback which is an SQLCallback implementation that dispatches
handleEvent to a JS function or a JS object with a handleEvent function.
* bindings/js/JSCustomVersionChangeCallback.cpp: Added.
(WebCore::JSCustomVersionChangeCallback::JSCustomVersionChangeCallback):
(WebCore::JSCustomVersionChangeCallback::handleEvent):
* bindings/js/JSCustomVersionChangeCallback.h: Added.
Add JSCustomSQLCallback which is an SQLCallback implementation that dispatches
handleEvent to a JS function or a JS object with a handleEvent function.
* bindings/js/JSDatabaseCustom.cpp: Added.
(WebCore::JSDatabase::executeSql):
Custom implementation of executeSql that takes an array of parameters.
(WebCore::JSDatabase::changeVersion):
Custom implementation of changeVersion.
* bindings/js/JSSQLResultSetRowListCustom.cpp: Added.
(WebCore::JSSQLResultSetRowList::item):
Custom method that returns a JS object that corresponds to a given row in the database.
* bindings/scripts/CodeGeneratorJS.pm:
* page/DOMWindow.cpp:
(WebCore::DOMWindow::openDatabase):
* page/DOMWindow.h:
* page/DOMWindow.idl:
Add openDatabase implementation.
2007-10-19 Brady Eidson <beidson@apple.com>
Reviewed by Oliver
Added tons of utility to the FileSystem abstractions, including moving
some stuff over from IconDatabase
* platform/FileSystem.h:
* platform/cf/FileSystemCF.cpp: Added.
(WebCore::fileSystemRepresentation):
* platform/mac/FileSystemMac.mm:
* platform/posix/FileSystemPOSIX.cpp: Added.
(WebCore::fileExists):
(WebCore::deleteFile):
(WebCore::fileSize):
(WebCore::pathByAppendingComponent):
(WebCore::makeAllDirectories):
2007-10-19 Timothy Hatcher <timothy@apple.com>
Reviewed by Adam Roben
Preliminary Web Inspector support for the Storage API
(This patch does not include the support artwork)
* page/InspectorController.cpp:
(WebCore::InspectorDatabaseResource::InspectorDatabaseResource):
(WebCore::InspectorDatabaseResource::setScriptObject):
(WebCore::databaseTableNames): Return the table names for a Database object.
(WebCore::InspectorController::setWindowVisible):
(WebCore::InspectorController::windowScriptObjectAvailable):
(WebCore::InspectorController::populateScriptResources):
(WebCore::InspectorController::addDatabaseScriptResource): Add the script object for the database.
(WebCore::InspectorController::removeDatabaseScriptResource): Remove the script object for the database.
(WebCore::InspectorController::clearDatabaseScriptResources): Remove all the database resources.
(WebCore::InspectorController::didCommitLoad): Call clearDatabaseScriptResources().
(WebCore::InspectorController::didOpenDatabase): Make a new InspectorDatabaseResource and add it to m_databaseResources.
* page/InspectorController.h:
* page/inspector/Database.js: Added.
* page/inspector/DatabasePanel.js: Added.
* page/inspector/ResourceCategory.js: Make resource categories assume less about the resource.
* page/inspector/inspector.css: Add styles for the database panel.
* page/inspector/inspector.html: Include DatabasePanel.js
* page/inspector/inspector.js: Support for adding and removing Database resources.
2007-10-19 Brady Eidson <beidson@apple.com>
Reviewed by Tim Hatcher
Added support for Chrome prompts required by the Storage API
* page/Chrome.cpp:
(WebCore::Chrome::runDatabaseSizeLimitPrompt):
* page/Chrome.h:
* page/ChromeClient.h:
* platform/graphics/svg/SVGImageEmptyClients.h:
2007-10-19 Brady Eidson <beidson@apple.com>
Contributions and Review by Anders
Various SQLite tweaks in preparation for the storage API
* loader/icon/SQLDatabase.cpp:
(WebCore::SQLDatabase::~SQLDatabase):
(WebCore::SQLDatabase::authorizerFunction): Static callback from sqlite for authorizer functions
(WebCore::SQLDatabase::setAuthorizer):
(WebCore::SQLDatabase::lock):
(WebCore::SQLDatabase::unlock):
* loader/icon/SQLDatabase.h:
* loader/icon/SQLStatement.cpp:
(WebCore::SQLStatement::prepare): Switch to prepare16_v2
(WebCore::SQLStatement::bindDouble): Added
(WebCore::SQLStatement::bindValue): Bind a wrapped SQLValue object (described later)
(WebCore::SQLStatement::bindParameterCount): Accessor to the sqlite3 API for validating statements
* loader/icon/SQLStatement.h:
(WebCore::SQLStatement::isPrepared):
* platform/sql/SQLAuthorizer.cpp: Added. Fully virtual interface to implement your own SQLite authorizer
* platform/sql/SQLAuthorizer.h: Added.
(WebCore::SQLAuthorizer::~SQLAuthorizer):
(WebCore::SQLAuthorizer::createTable):
(WebCore::SQLAuthorizer::createTempTable):
(WebCore::SQLAuthorizer::dropTable):
(WebCore::SQLAuthorizer::dropTempTable):
(WebCore::SQLAuthorizer::allowAlterTable):
(WebCore::SQLAuthorizer::createIndex):
(WebCore::SQLAuthorizer::createTempIndex):
(WebCore::SQLAuthorizer::dropIndex):
(WebCore::SQLAuthorizer::dropTempIndex):
(WebCore::SQLAuthorizer::createTrigger):
(WebCore::SQLAuthorizer::createTempTrigger):
(WebCore::SQLAuthorizer::dropTrigger):
(WebCore::SQLAuthorizer::dropTempTrigger):
(WebCore::SQLAuthorizer::createView):
(WebCore::SQLAuthorizer::createTempView):
(WebCore::SQLAuthorizer::dropView):
(WebCore::SQLAuthorizer::dropTempView):
(WebCore::SQLAuthorizer::createVTable):
(WebCore::SQLAuthorizer::dropVTable):
(WebCore::SQLAuthorizer::allowDelete):
(WebCore::SQLAuthorizer::allowInsert):
(WebCore::SQLAuthorizer::allowUpdate):
(WebCore::SQLAuthorizer::allowTransaction):
(WebCore::SQLAuthorizer::allowSelect):
(WebCore::SQLAuthorizer::allowRead):
(WebCore::SQLAuthorizer::allowAttach):
(WebCore::SQLAuthorizer::allowDetach):
(WebCore::SQLAuthorizer::allowReindex):
(WebCore::SQLAuthorizer::allowAnalyze):
(WebCore::SQLAuthorizer::allowFunction):
* platform/sql/SQLValue.cpp: Added. Contains a value for a SQLite database that can be one of a few types.
For now, just a String or a double
(WebCore::SQLValue::SQLValue):
(WebCore::SQLValue::string):
(WebCore::SQLValue::number):
* platform/sql/SQLValue.h: Added.
(WebCore::SQLValue::):
(WebCore::SQLValue::SQLValue):
(WebCore::SQLValue::type):
2007-10-19 Brady Eidson <beidson@apple.com>
Reviewed by Maciej
Changed IconDatabase over to use new FileSystem apis
* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::open):
WebKit:
Reviewed by Tim Hatcher
Added support for Chrome prompts required by the Storage API
Added support API for future managing of databases from the WebKit client
Added preference and initialization for the databases path
* Misc/WebDatabaseManager.h: Added. WebDatabaseManager is how a WebKit application can list and
remove the current available databases
* Misc/WebDatabaseManager.mm: Added.
(+[WebDatabaseManager origins]):
(+[WebDatabaseManager databasesWithOrigin:]):
(+[WebDatabaseManager deleteAllDatabases]):
(+[WebDatabaseManager deleteAllDatabasesWithOrigin:]):
(+[WebDatabaseManager deleteDatabaseWithOrigin:named:]):
(WebKitSetWebDatabasesPathIfNecessary): Setup the database path
* Misc/WebDatabaseManagerPrivate.h: Added.
* WebCoreSupport/WebChromeClient.h: Support for calling the delegate to run the prompt for
an origin exceeding its size limit
* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::runDatabaseSizeLimitPrompt):
* WebKit.xcodeproj/project.pbxproj:
* WebView/WebUIDelegate.h:
* WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]): Setup the database path
* WebView/WebViewInternal.h:
WebKitSite:
Reviewed by Tim Hatcher
Sample database API usage
* misc/DatabaseExample.html: Added.
WebKit/win:
Reviewed by Anders
Keep windows building with new Chrome additions
* WebChromeClient.cpp:
* WebChromeClient.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26787
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kmccullo [Fri, 19 Oct 2007 22:21:57 +0000 (22:21 +0000)]
Reviewed by Oliver and Tim.
- Made use of RetainPtr to avoid retain and release issues and moved the
log function to DebuggerDocumentPlatform, which seems to be a more
logical place for it to live.
- Also moved knownServers from the ServerConnection to
DebuggerApplication to match the Windows code and because it makes sense
that a connection knows its own server but not all of them.
* Drosera/mac/DebuggerClient.h: Moved the log function to
DebuggerDocumentPlatform.
* Drosera/mac/DebuggerClient.mm: Ditto. Also do not release the server
Because it's owned by an own Ptr in DebuggerDocument. Also moved the
call for the server name up from the ServerConnection class.
(-[DebuggerClient dealloc]):
(-[DebuggerClient webView:didReceiveTitle:forFrame:]): Moved the call
for the server name up from the ServerConnection.
* Drosera/mac/DebuggerDocumentPlatform.mm: Made the server an OwnPtr.
(DebuggerDocument::platformPause):
(DebuggerDocument::platformResume):
(DebuggerDocument::platformStepInto):
(DebuggerDocument::platformEvaluateScript):
(DebuggerDocument::getPlatformCurrentFunctionStack):
(DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
(DebuggerDocument::platformValueForScopeVariableNamed):
(DebuggerDocument::platformLog): Log directly from here. No need to call
DebuggerClient.
* Drosera/mac/ServerConnection.h: Removed the knownServers function. The
way I see it, a ServerConnection should only know about its connection
and the group of all possible servers should be kept by the
application.
* Drosera/mac/ServerConnection.mm: Removed knownServer but added
currentServerName, it makes sense that the connection should know that
name.
(-[ServerConnection currentServerName]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26786
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Fri, 19 Oct 2007 22:00:16 +0000 (22:00 +0000)]
Fix for ebay parser crash.
Reviewed by Beth
fast/invalid/table-residual-style-crash.html added as a test
* html/HTMLParser.cpp:
(WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26785
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Fri, 19 Oct 2007 21:58:46 +0000 (21:58 +0000)]
Add new layout test for parser crash.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26784
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann [Fri, 19 Oct 2007 21:25:53 +0000 (21:25 +0000)]
Reviewed by Anders.
Try to fix Qt/Win build slave, by including windows.h also on Qt/Win.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26783
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Fri, 19 Oct 2007 21:17:03 +0000 (21:17 +0000)]
Fix Windows, Qt and GTK builds.
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26782
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann [Fri, 19 Oct 2007 21:03:44 +0000 (21:03 +0000)]
Rubberstamped by Oliver.
Land tiger baseline matching my MBP, as discussed with Oliver.
Mostly differences regarding the size of "(" / ")" characters.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26781
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Fri, 19 Oct 2007 20:53:22 +0000 (20:53 +0000)]
WebCore:
Reviewed by Darin.
Encapsulate the same origin check into the new SecurityOrigin class.
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/kjs_window.cpp:
(KJS::Window::isSafeScript):
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::defaultEventHandler):
* dom/Document.h:
(WebCore::Document::securityOrigin):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::begin):
(WebCore::FrameLoader::setOpener):
* loader/FrameLoader.h:
* platform/SecurityOrigin.cpp: Added.
(WebCore::SecurityOrigin::SecurityOrigin):
(WebCore::SecurityOrigin::clear):
(WebCore::SecurityOrigin::isEmpty):
(WebCore::SecurityOrigin::setForFrame):
(WebCore::SecurityOrigin::setDomainFromDOM):
(WebCore::SecurityOrigin::allowsAccessFrom):
(WebCore::SecurityOrigin::isSecureTransitionTo):
* platform/SecurityOrigin.h: Added.
LayoutTests:
Reviewed by Darin.
Update results after changing the warning message in isSafeScript to print the frame URL
rather than the security domain URL. This now also prints the warning when using data:
URLs because we no longer return early.
* http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-2-level-expected.txt:
* http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-expected.txt:
* http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-to-data-url-sub-frame-expected.txt:
* http/tests/security/dataURL/xss-DENIED-from-javascript-url-window-open-expected.txt:
* http/tests/security/dataURL/xss-DENIED-to-data-url-from-data-url-expected.txt:
* http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-2-level-expected.txt:
* http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-expected.txt:
* http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt:
* http/tests/security/dataURL/xss-DENIED-to-data-url-window-open-expected.txt:
* http/tests/security/javascriptURL/xss-DENIED-from-javascipt-url-in-foreign-domain-subframe-expected.txt:
* http/tests/security/javascriptURL/xss-DENIED-from-javascipt-url-in-foreign-domain-window-open-expected.txt:
* http/tests/security/javascriptURL/xss-DENIED-to-javascipt-url-in-foreign-domain-subframe-expected.txt:
* http/tests/security/javascriptURL/xss-DENIED-to-javascipt-url-in-foreign-domain-window-open-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26780
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kmccullo [Fri, 19 Oct 2007 20:04:57 +0000 (20:04 +0000)]
Reviewed by Adam.
- Integrated changes from mac drosera. Recently I've encapsulated
out the server connection object from the rest of Drosera because
it is very platform dependent right now and RPC is not implemented on
windows. This functionality, of communicating with the WebKit server
is the next area I will be focusing on in Windows.
- Other changes and cleanup were made to organize the code and add notes
on which parts still need work. Also some mac code is added and
commented out, to act as pseudocode for the logic of those parts.
* Drosera/DebuggerDocument.h: Make the ServerConnection live in a smart
pointer.
* Drosera/config.h: Added whitespace.
* Drosera/win/DebuggerApplication.cpp: Removed. The functionality of
these files got moved into Drosera.h/cpp
* Drosera/win/DebuggerApplication.h: Removed.
* Drosera/win/DebuggerClient.cpp: Lots of cleanup and restructuring
happened here to better match the logic flow of the same code on the
mac side and to use the new ServerConnection class.
(DebuggerClient::DebuggerClient): Constructor that takes a server name.
(DebuggerClient::initWithServerName): Initializer that will set up the
class to use a ServerConnection object. This was necessary so I could
create a DebuggerClient without having to initilaize it at
construction.
(DebuggerClient::QueryInterface): Moved from Drosera.cpp, the Client
will be the UIDelegate and FrameLoadDelegate.
(DebuggerClient::AddRef): For IUnknown.
(DebuggerClient::Release): For IUnknown.
(DebuggerClient::didFinishLoadForFrame): Part of the FrameLoadDelegate
this still needs to set the global context of the server, but
IWebFrame does not have an accessor for the global context yet.
(DebuggerClient::windowScriptObjectAvailable): Part of FrameLoadDelegate
this is a pass through for the same function in the document.
(DebuggerClient::didReceiveTitle): Unimplemented part of
FrameLoadDelegate this would change the title of the window.
(DebuggerClient::createWebViewWithRequest): Part of the
FrameLoadDelegate. This is about new windows via Window.open() and
how their delegates are set.
(DebuggerClient::runJavaScriptAlertPanelWithMessage): Part of the
UIDelegate. Just a debug function for printing messages.
* Drosera/win/DebuggerClient.h: Moved functionality from Drosera.h
because the Client should be the UIDelegate and FrameLoadDelegate
to match the delegates on mac.
(DebuggerClient::webViewLoaded): Added accessor method.
* Drosera/win/DebuggerDocumentPlatform.cpp: Added. I had apperently
forgotten to add this file before. This is where the platform
dependent versions of the Documents functions live. Most of these are
unimplemented because some piece of functionality does not exist on
Windows yet.
(DebuggerDocument::platformPause):
(DebuggerDocument::platformResume):
(DebuggerDocument::platformStepInto):
(DebuggerDocument::platformEvaluateScript):
(DebuggerDocument::getPlatformCurrentFunctionStack):
(DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
(DebuggerDocument::platformValueForScopeVariableNamed):
(DebuggerDocument::platformLog):
* Drosera/win/Drosera.cpp: Removed UIDelegate and FrameLoadDelegate
responsibilities becaue they belong in the Client. Also I laid the
groundwork for attaching Drosera to a WebKit process
(attachWndProc): Now if a server is selected the Client becomes it's
delegate.
(Drosera::Drosera): Added the construction of the Client and dictionary
of server names.
(Drosera::initUI): This is no longer the delegates, the Client is.
(Drosera::webViewLoaded): Now asks the Client instead of holding local
state.
(Drosera::applicationDidFinishLaunching): Placeholder for needed
notification registration when it's possible to implement.
(Drosera::serverLoaded): Ditto
(Drosera::serverUnloaded): Ditto
(Drosera::attach): Attach Drosera to the WebKit server.
* Drosera/win/Drosera.h: Ditto for Drosera.cpp comment.
(Drosera::getInst):
(Drosera::setInst):
(Drosera::knownServers):
* Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed DebuggerApplication
and added the ServerConnection.
* Drosera/win/DroseraPrefix.h: Added an ifndef check.
* Drosera/win/ServerConnection.cpp: Added. This is the interesting part
Most of the functions are completely unimlemented because they cannot
connect with the WebKit server, because one does not exist on Windows
yet.
(ServerConnection::initWithServerName):
(ServerConnection::~ServerConnection):
(ServerConnection::setGlobalContext):
(ServerConnection::pause):
(ServerConnection::resume):
(ServerConnection::stepInto):
(ServerConnection::switchToServerNamed):
(ServerConnection::applicationTerminating):
(ServerConnection::serverConnectionDidDie):
(ServerConnection::currentFrame):
* Drosera/win/ServerConnection.h: Added. Ditto.
(ServerConnection::ServerConnection):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26779
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aliceli1 [Fri, 19 Oct 2007 18:12:36 +0000 (18:12 +0000)]
Reviewed by Darin.
Fix for these broken layout tests on Windows:
fast/forms/focus-selection-input.html
fast/forms/focus-selection-textarea.html
fast/forms/select-accesskey.html
* DumpRenderTree/win/EventSender.cpp:
(keyDownCallback):
correct the VK code for alt key.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26778
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aliceli1 [Fri, 19 Oct 2007 18:05:46 +0000 (18:05 +0000)]
Reviewed by Darin.
* DumpRenderTree/win/EventSender.cpp:
(keyDownCallback):
correct the VK code for alt key.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26777
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan [Fri, 19 Oct 2007 17:51:57 +0000 (17:51 +0000)]
Reviewed by Tim Hatcher
- fixed <rdar://problem/
5540325> REGRESSION (2.0.4-3): History menu looks odd after clearing history
* History/WebHistory.mm:
(-[WebHistoryPrivate removeAllItems]):
This was fallout from r25275. We need to clear the orderedLastVisitedDays cache here, in addition
to the other places where it's cleared.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26776
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz [Fri, 19 Oct 2007 17:33:38 +0000 (17:33 +0000)]
Rubber-stamped by Sam Weinig.
removing a commented-out test and a test that no longer fails
* platform/mac-leopard/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26775
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer [Fri, 19 Oct 2007 17:14:26 +0000 (17:14 +0000)]
LayoutTests:
Reviewed by Darin.
Provide the functionality of js-test-post.js in a function named isSuccessfullyParsed().
* fast/encoding/char-encoding.html: Updated to use js-test-post-function.js instead of local hack.
* fast/js/resources/js-test-post-function.js: Copied from LayoutTests/fast/js/resources/js-test-post.js.
Modified to create isSuccessfullyParsed() function.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26774
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann [Fri, 19 Oct 2007 15:13:28 +0000 (15:13 +0000)]
Fix the Qt/Windows build: Added missing FontSelector.h include and re-order moc inclusion.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26773
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann [Fri, 19 Oct 2007 14:46:28 +0000 (14:46 +0000)]
Qt/Windows build fix: Threading.h uses int32_t but doesn't include stdint.h.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26772
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann [Fri, 19 Oct 2007 14:14:13 +0000 (14:14 +0000)]
Fix compilation on Windows when wchar_t is a typedef instead of a native type (triggered by -Zc:wchar_t-).
Don't provide the wchar_t overloads then as they conflict with the unsigned short ones.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26771
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann [Fri, 19 Oct 2007 11:28:58 +0000 (11:28 +0000)]
Another build fix for the windows/qt build: Apply the same fix as in revision 26686 also to kjs/config.h to disable the disallowctype feature.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26770
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann [Fri, 19 Oct 2007 11:12:18 +0000 (11:12 +0000)]
Fix the windows/qt build by including config.h first to fix wtf/MathExtras.h inclusion.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26769
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann [Fri, 19 Oct 2007 10:38:45 +0000 (10:38 +0000)]
Fix the qt/windows build.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26768
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Fri, 19 Oct 2007 08:58:14 +0000 (08:58 +0000)]
2007-10-19 Eric Seidel <eric@webkit.org>
Reviewed by Mark Rowe.
Make the GtkLauncher code slightly more readable.
* GtkLauncher/main.cpp:
(setupMainMenu): Added.
(setupMainWindowUI): Added.
(main):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26767
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Fri, 19 Oct 2007 08:01:39 +0000 (08:01 +0000)]
Rubber stamped by Adam.
- don't delay-load WebKit in DumpRenderTree.
* DumpRenderTree/win/DumpRenderTree.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26766
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz [Fri, 19 Oct 2007 02:45:24 +0000 (02:45 +0000)]
Rubber-stamped by Mark Rowe.
removing tests that no longer fail
* platform/mac-leopard/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26762
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Fri, 19 Oct 2007 02:19:44 +0000 (02:19 +0000)]
WebCore:
Reviewed by Kevin McCullough.
<rdar://problem/
5483526>
GoogleDocs: A hang occurs when applying list styling to a selection containing a table and line breaks
* editing/TextIterator.cpp:
(WebCore::TextIterator::exitNode): For selection preservation, we must emit a character
between every VisiblePosition. We weren't emitting a space after some tables, because
we won't try to emit a space if shouldEmitNewlineAFterNode is true, even if no newline
was emitted.
LayoutTests:
Reviewed by Kevin McCullough.
<rdar://problem/
5483526>
GoogleDocs: A hang occurs when applying list styling to a selection containing a table and line breaks
Demonstrates fix for the hang:
* editing/execCommand/
5483526-expected.txt: Added.
* editing/execCommand/
5483526.html: Added.
Fixed selection endpoint (problems with selection painting prevent this
from being reflected in the pixel test results):
* platform/mac/editing/execCommand/
5432254-2-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26761
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Fri, 19 Oct 2007 02:14:09 +0000 (02:14 +0000)]
Reviewed by Adam.
- use __declspec(thread) for fast thread-local storage on Windows
- 2.2% speedup on sunspider (on Windows)
- 7% speedup on the string section
- 6% speedup on JS iBench
- fixed <rdar://problem/
5473084> PLT on Windows got 2.5% slower between r25406 and r25422
- fixed at least some of <rdar://
5527965? i-Bench JS was 14% slower in 310A11 than 310A10
* wtf/FastMalloc.cpp:
(WTF::getThreadHeap):
(WTF::setThreadHeap):
(WTF::TCMalloc_ThreadCache::GetCache):
(WTF::TCMalloc_ThreadCache::GetCacheIfPresent):
(WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26760
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz [Fri, 19 Oct 2007 00:49:23 +0000 (00:49 +0000)]
Tiger build fix.
* WebView/WebDataSource.mm:
(-[WebDataSource _MIMETypeOfResponse:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26759
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz [Fri, 19 Oct 2007 00:33:19 +0000 (00:33 +0000)]
WebCore:
Reviewed by Adam Roben.
- fix <rdar://problem/
5313523>
REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
* platform/network/mac/ResourceResponseMac.mm:
(WebCore::ResourceResponse::doUpdateResourceResponse): Work around
<rdar://problem/
5321972> by testing for the case of a response
with a MIME type of application/octet-stream and a Content-Type header
starting with text/plain and setting the MIME type to text/plain in
that case.
WebKit:
Reviewed by Adam Roben.
- fix <rdar://problem/
5313523>
REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::makeDocumentView): Changed to use _responseMIMEType.
* WebView/WebDataSource.mm:
(-[WebDataSource _MIMETypeOfResponse:]): Added. Works around
<rdar://problem/
5321972> by testing for the case of an NSHTTPURLResponse
with a MIMEType of application/octet-stream and a Content-Type header
starting with text/plain and returning text/plain as the MIME type in
that case.
(-[WebDataSource _responseMIMEType]): Added. Used to get the correct
response MIME type.
(-[WebDataSource _isDocumentHTML]): Changed to use _responseMIMEType.
(-[WebDataSource _makeRepresentation]): Ditto.
(-[WebDataSource mainResource]): Ditto.
(-[WebDataSource subresources]): Changed to use _MIMETypeOfResponse and
pass the MIME type explicitly.
(-[WebDataSource subresourceForURL:]): Ditto.
* WebView/WebDataSourcePrivate.h:
* WebView/WebFrameView.mm:
(-[WebFrameView _makeDocumentViewForDataSource:]): Changed to use
_responseMIMEType.
* WebView/WebResource.mm:
(-[WebResource _initWithData:URL:response:MIMEType:]): Changed this
method to take a MIME type instead of extracting it from the response,
so that WebDataSource could pass the correct MIME type.
* WebView/WebResourcePrivate.h:
WebKitTools:
Reviewed by Adam Roben.
- fix <rdar://problem/
5313523>
REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
* DumpRenderTree/mac/DumpRenderTree.mm:
(dump): Changed to use _responseMIMEType.
LayoutTests:
Reviewed by Adam Roben.
- removing fixed test
* platform/mac-leopard/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26758
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Thu, 18 Oct 2007 23:11:34 +0000 (23:11 +0000)]
2007-10-18 Mark Rowe <mrowe@apple.com>
Fix the no-SVG build.
* css/CSSPrimitiveValueMappings.h: Move the CSSPrimitiveValue implementations for
LineCap, LineJoin and WindRule inside #if ENABLE(SVG).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26757
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Thu, 18 Oct 2007 21:59:23 +0000 (21:59 +0000)]
Reviewed by Anders.
- some small tweaks to the threading implementation
I had trouble building on Windows. Either the problem went away by itself
or one of these changes fixed it.
* platform/Threading.h: Eliminated the use of friend, and shared a single
declaration for the initializeThreading function.
* platform/pthreads/ThreadingPthreads.cpp: (WebCore::ThreadCondition::wait):
Call impl() here.
* platform/win/ThreadingWin.cpp: Got rid of two globals here with static
constructors. Also added a typedef for the type of the function queue.
(WebCore::functionQueueMutex): Added function.
(WebCore::functionQueue): Ditto.
(WebCore::callFunctionsOnMainThread): Use functions instead of using the
globals directly.
(WebCore::callOnMainThread): Ditto.
* css/CSSParser.cpp: Had to touch this file to make things build.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26756
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Thu, 18 Oct 2007 21:35:32 +0000 (21:35 +0000)]
Fix <rdar://
5547784> ProgIDMacros.h should explicitly use wide strings
Reviewed by Adele.
* ProgIDMacros.h: Always use wide strings instead of relying on the
TEXT macro.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26755
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Thu, 18 Oct 2007 20:26:43 +0000 (20:26 +0000)]
Fix <rdar://
5547462> Need to copy Inspector resources in Production builds
I also added an excludes file for the xcopy command to avoid copying
.svn folders.
Reviewed by Geoff.
* WebCore.vcproj/WebCore.make: Make sure we copy the Inspector
resources.
* WebCore.vcproj/WebCore.vcproj: Pass /exclude:xcopy.excludes to
xcopy.
* WebCore.vcproj/xcopy.excludes: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26751
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Thu, 18 Oct 2007 17:00:19 +0000 (17:00 +0000)]
WebCore:
Reviewed by Sam.
- fix http://bugs.webkit.org/show_bug.cgi?id=15541
REGRESSION (r26616): prompt with one argument uses the literal "undefined" as default reply
* page/DOMWindow.idl: Add ConvertUndefinedOrNullToNullString back for defaultValue.
LayoutTests:
Reviewed by Sam.
- test update for http://bugs.webkit.org/show_bug.cgi?id=15541
REGRESSION (r26616): prompt with one argument uses the literal "undefined" as default reply
* fast/dom/Window/alert-undefined-expected.txt: Back to expecting empty string for default value.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26750
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann [Thu, 18 Oct 2007 16:44:04 +0000 (16:44 +0000)]
Build fix. Not reviewed.
Hopefully fix win build by including wtf/MathExtras.h.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26749
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz [Thu, 18 Oct 2007 16:21:34 +0000 (16:21 +0000)]
WebCore:
Reviewed by Nikolas Zimmermann.
- fix http://bugs.webkit.org/show_bug.cgi?id=15367
Assertion failure inspecting a document including soft hyphen code (0xad)
Test: fast/text/word-break-soft-hyphen.html
* rendering/RenderText.cpp:
(WebCore::RenderText::calcPrefWidths): Changed to treat soft hyphens as
word boundaries. This fixes the bug and is consistent with the fact that
run rounding does occur at soft hyphens.
LayoutTests:
Reviewed by Nikolas Zimmermann.
- test for http://bugs.webkit.org/show_bug.cgi?id=15367
Assertion failure inspecting a document including soft hyphen code (0xad)
* fast/text/word-break-soft-hyphen.html: Added.
* platform/mac/fast/text/word-break-soft-hyphen-expected.checksum: Added.
* platform/mac/fast/text/word-break-soft-hyphen-expected.png: Added.
* platform/mac/fast/text/word-break-soft-hyphen-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26746
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann [Thu, 18 Oct 2007 15:19:40 +0000 (15:19 +0000)]
Reviewed by Anders.
Fix last layout test failure seen on buildbot "trunk-mac-ppc-release".
Problem: "svg/custom/mask-excessive-malloc.svg -> crashed"
Clamp any ImageBuffer allocation within SVG to the RenderView's visibleSize
to avoid excessive mallocs (in the testcase above 1000000x1000000)
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26745
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Thu, 18 Oct 2007 09:57:20 +0000 (09:57 +0000)]
Windows build fix.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty): Add braces around cases that have local variables now.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26744
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Thu, 18 Oct 2007 08:57:30 +0000 (08:57 +0000)]
Release build fix.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26743
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Thu, 18 Oct 2007 08:39:44 +0000 (08:39 +0000)]
Reviewed by Darin.
Split most of CSSPrimitiveValue enum mapping out of CSSComputedStyleDeclaration::getPropertyCSSValue()
and CSSStyleSelector::applyProperty() (and their SVG counterparts). This should make the code more readable.
* WebCore.xcodeproj/project.pbxproj:
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::getPositionOffsetValue):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::init):
* css/CSSPrimitiveValue.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
* css/CSSPrimitiveValueMappings.h: Added.
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EBorderStyle):
(WebCore::CSSPrimitiveValue::operator CompositeOperator):
(WebCore::CSSPrimitiveValue::operator EAppearance):
(WebCore::CSSPrimitiveValue::operator EBackgroundBox):
(WebCore::CSSPrimitiveValue::operator EBackgroundRepeat):
(WebCore::CSSPrimitiveValue::operator EBoxAlignment):
(WebCore::CSSPrimitiveValue::operator EBoxDirection):
(WebCore::CSSPrimitiveValue::operator EBoxLines):
(WebCore::CSSPrimitiveValue::operator EBoxOrient):
(WebCore::CSSPrimitiveValue::operator ECaptionSide):
(WebCore::CSSPrimitiveValue::operator EClear):
(WebCore::CSSPrimitiveValue::operator ECursor):
(WebCore::CSSPrimitiveValue::operator EDisplay):
(WebCore::CSSPrimitiveValue::operator EEmptyCell):
(WebCore::CSSPrimitiveValue::operator EFloat):
(WebCore::CSSPrimitiveValue::operator EKHTMLLineBreak):
(WebCore::CSSPrimitiveValue::operator EListStylePosition):
(WebCore::CSSPrimitiveValue::operator EListStyleType):
(WebCore::CSSPrimitiveValue::operator EMarginCollapse):
(WebCore::CSSPrimitiveValue::operator EMarqueeBehavior):
(WebCore::CSSPrimitiveValue::operator EMarqueeDirection):
(WebCore::CSSPrimitiveValue::operator EMatchNearestMailBlockquoteColor):
(WebCore::CSSPrimitiveValue::operator ENBSPMode):
(WebCore::CSSPrimitiveValue::operator EOverflow):
(WebCore::CSSPrimitiveValue::operator EPageBreak):
(WebCore::CSSPrimitiveValue::operator EPosition):
(WebCore::CSSPrimitiveValue::operator EResize):
(WebCore::CSSPrimitiveValue::operator ETableLayout):
(WebCore::CSSPrimitiveValue::operator ETextAlign):
(WebCore::CSSPrimitiveValue::operator ETextSecurity):
(WebCore::CSSPrimitiveValue::operator ETextTransform):
(WebCore::CSSPrimitiveValue::operator EUnicodeBidi):
(WebCore::CSSPrimitiveValue::operator EUserDrag):
(WebCore::CSSPrimitiveValue::operator EUserModify):
(WebCore::CSSPrimitiveValue::operator EUserSelect):
(WebCore::CSSPrimitiveValue::operator EVisibility):
(WebCore::CSSPrimitiveValue::operator EWhiteSpace):
(WebCore::CSSPrimitiveValue::operator EWordBreak):
(WebCore::CSSPrimitiveValue::operator EWordWrap):
(WebCore::CSSPrimitiveValue::operator LineCap):
(WebCore::CSSPrimitiveValue::operator LineJoin):
(WebCore::CSSPrimitiveValue::operator TextDirection):
(WebCore::CSSPrimitiveValue::operator WindRule):
(WebCore::CSSPrimitiveValue::operator EAlignmentBaseline):
(WebCore::CSSPrimitiveValue::operator EColorInterpolation):
(WebCore::CSSPrimitiveValue::operator EColorRendering):
(WebCore::CSSPrimitiveValue::operator EDominantBaseline):
(WebCore::CSSPrimitiveValue::operator EImageRendering):
(WebCore::CSSPrimitiveValue::operator EPointerEvents):
(WebCore::CSSPrimitiveValue::operator EShapeRendering):
(WebCore::CSSPrimitiveValue::operator ETextAnchor):
(WebCore::CSSPrimitiveValue::operator ETextRendering):
(WebCore::CSSPrimitiveValue::operator EWritingMode):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::checkSelector):
(WebCore::CSSStyleSelector::checkOneSelector):
(WebCore::CSSRuleSet::addRulesFromSheet):
(WebCore::convertToLength):
(WebCore::CSSStyleSelector::applyDeclarations):
(WebCore::CSSStyleSelector::applyProperty):
(WebCore::CSSStyleSelector::mapBackgroundAttachment):
(WebCore::CSSStyleSelector::mapBackgroundClip):
(WebCore::CSSStyleSelector::mapBackgroundComposite):
(WebCore::CSSStyleSelector::mapBackgroundOrigin):
(WebCore::CSSStyleSelector::mapBackgroundRepeat):
(WebCore::CSSStyleSelector::mapBackgroundXPosition):
(WebCore::CSSStyleSelector::mapBackgroundYPosition):
* ksvg2/css/SVGCSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):
* ksvg2/css/SVGCSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applySVGProperty):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26742
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Thu, 18 Oct 2007 08:01:51 +0000 (08:01 +0000)]
Reviewed by Eric.
- Support Windows and Windows browsers.
* hosted/sunspider-results.html: Display results correctly in IE.
* sunspider: tweaks to work on Windows, and with spaces in the path.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26741
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Thu, 18 Oct 2007 07:30:13 +0000 (07:30 +0000)]
2007-10-18 Eric Seidel <eric@webkit.org>
Reviewed by Maciej.
Fix crashers in SVGViewSpec::parseViewSpec
http://bugs.webkit.org/show_bug.cgi?id=15504
Test is blocked by bug 15503, landed as:
* svg/dom/viewspec-parser.html-disabled
* bindings/scripts/CodeGeneratorObjC.pm: support classes where all parents are interfaces
* ksvg2/svg/SVGViewSpec.cpp:
(WebCore::SVGViewSpec::parseViewSpec):
* ksvg2/svg/SVGViewSpec.idl: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26740
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Thu, 18 Oct 2007 07:27:04 +0000 (07:27 +0000)]
Rubber stamped by Oliver.
* tests/string-tagcloud.js: Remove stray print()
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26739
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Thu, 18 Oct 2007 07:17:41 +0000 (07:17 +0000)]
Reviewed by Oliver.
Add some string test cases.
* tests/string-base64.js: Added. Does base64 encoding and decoding.
* tests/string-tagcloud.js: Added. Parses a JSON string and
generates tagcloud HTML markup based on the data.
* tests/string-unpack-code.js: Added. Unpack compressed versions of
four of the most popular JavaScript libraries.
* tests/LIST: Added the new tests.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26738
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Thu, 18 Oct 2007 03:56:34 +0000 (03:56 +0000)]
Make it possible to have Windows-specific tests and results
When searching for tests to run and the Skipped file, we will only
look in platform/win and the cross-platform directory. When looking
for expected results, we will look in platform/win, then
platform/mac-leopard, then platform/mac, then finally the
cross-platform directory.
Reviewed by Sam.
* Scripts/run-webkit-tests:
(sub expectedDirectoryForTest): Search in mac-leopard and mac before
searching in the cross-platform directory.
(sub buildPlatformHierarchy): Removed some unneeded calls to
dirname/basename.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26734
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Thu, 18 Oct 2007 03:53:00 +0000 (03:53 +0000)]
Add back the call to register WebKit that we had before WebKitInitializer existed
This is needed to ensure that the right WebKit is used when
instantiating COM objects.
Reviewed by Oliver.
* DumpRenderTree/win/debug_internal.vsprops: Define
DEBUG_WEBKIT_HAS_SUFFIX.
* DumpRenderTree/win/DumpRenderTree.cpp:
(initialize):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26733
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Thu, 18 Oct 2007 03:28:22 +0000 (03:28 +0000)]
WebCore:
Reviewed by Darin, Adam, and Maciej.
http://bugs.webkit.org/show_bug.cgi?id=12988
First element (in document order) is not returned when other duplicate ID-ed elements were created first
Reset the element id cache when an id is added and there is a duplicate for that id.
* dom/Document.cpp:
(WebCore::Document::addElementById):
LayoutTests:
Reviewed by Darin, Adam, and Maciej.
Testcase for:
http://bugs.webkit.org/show_bug.cgi?id=12988
First element (in document order) is not returned when other duplicate ID-ed elements were created first
* fast/dom/duplicate-ids-document-order.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26732
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Thu, 18 Oct 2007 03:17:36 +0000 (03:17 +0000)]
Import File::Basename in webkitdirs since we use it
Reviewed by NOBODY.
* Scripts/webkitdirs.pm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26730
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kmccullo [Thu, 18 Oct 2007 01:07:54 +0000 (01:07 +0000)]
- Updated the tiger leaks list to make the internal bots green.
* Scripts/run-webkit-tests:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26729
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Thu, 18 Oct 2007 00:15:29 +0000 (00:15 +0000)]
Build fix for VC++ Express
Reviewed by NOBODY.
* FindSafari/FindSafari.vcproj: Explicitly link against advapi32.lib
and ole32.lib.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26727
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Thu, 18 Oct 2007 00:10:18 +0000 (00:10 +0000)]
Fix an ASSERT on launch on Windows
Fix dictated to me by Brady.
* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::syncThreadMainLoop): Make sure we hold
m_syncLock before going into the loop.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26726
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Wed, 17 Oct 2007 23:51:34 +0000 (23:51 +0000)]
2007-10-17 Mark Rowe <mrowe@apple.com>
Mac build fix.
* Configurations/WebCore.xcconfig: Make it possible to include CoreGraphics header files.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26725
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Wed, 17 Oct 2007 23:39:15 +0000 (23:39 +0000)]
Fix for clean builds needed after r26683
Reviewed by NOBODY.
* WebView.cpp: Remove #include of non-existant file.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26724
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Wed, 17 Oct 2007 23:10:09 +0000 (23:10 +0000)]
Windows build fix
Reviewed by NOBODY.
* platform/graphics/AffineTransform.h: Don't #include
ApplicationServices.h.
* platform/graphics/cg/GraphicsContextCG.cpp: Add an #include that's
needed now that we're not #including ApplicationServices.h.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26723
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Wed, 17 Oct 2007 22:57:12 +0000 (22:57 +0000)]
2007-10-17 Mark Rowe <mrowe@apple.com>
Gtk build fix. Move non-pthread stubs from Threading.h to ThreadingNone.cpp to prevent
multiple-definition link errors.
* WebCore.pro:
* platform/Threading.h:
* platform/ThreadingNone.cpp: Added.
(WebCore::createThread):
(WebCore::waitForThreadCompletion):
(WebCore::detachThread):
(WebCore::Mutex::Mutex):
(WebCore::Mutex::~Mutex):
(WebCore::Mutex::lock):
(WebCore::Mutex::tryLock):
(WebCore::Mutex::unlock):
(WebCore::ThreadCondition::ThreadCondition):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26722
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aliceli1 [Wed, 17 Oct 2007 22:37:23 +0000 (22:37 +0000)]
Rubber-stamped by Adele.
Correct uses of initKeyboardEvent for tests that test accesskey.
Accesskey modifier is ctrl for mac and alt for other platforms.
* fast/events/access-key-self-destruct.html:
* fast/forms/access-key.html:
* fast/forms/legend-access-key.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26721
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 17 Oct 2007 21:25:59 +0000 (21:25 +0000)]
JavaScriptCore:
Reviewed by Mark Rowe.
- fix http://bugs.webkit.org/show_bug.cgi?id=15543
<rdar://problem/
5545639> REGRESSION (r26697):
GoogleDocs: Can't create new documents or open existing ones
Test: fast/js/regexp-non-character.html
* pcre/pcre_compile.c: (check_escape): Take out the checks for valid characters
in the \u sequences -- not needed and actively harmful.
LayoutTests:
Reviewed by Mark Rowe.
- test for http://bugs.webkit.org/show_bug.cgi?id=15543
<rdar://problem/
5545639> REGRESSION (r26697):
GoogleDocs: Can't create new documents or open existing ones
* fast/js/regexp-non-character-expected.txt: Added.
* fast/js/regexp-non-character.html: Added.
* fast/js/resources/regexp-non-character.js: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26720
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 17 Oct 2007 21:15:16 +0000 (21:15 +0000)]
Remove stray change marker.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26718
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 17 Oct 2007 21:13:59 +0000 (21:13 +0000)]
Remove stray merge marker.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26717
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Wed, 17 Oct 2007 21:05:38 +0000 (21:05 +0000)]
JavaScriptCore:
Reviewed by Oliver.
* wtf/Platform.h:
#define USE_PTHREADS on Mac.
WebCore:
Reviewed by Oliver.
* WebCore.xcodeproj/project.pbxproj:
* WebCore.vcproj/WebCore.vcproj:
* config.h:
#define USE_PTHREADS on Windows.
* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::getOrCreateIconRecord):
(WebCore::IconDatabase::getOrCreatePageURLRecord):
Update for mutex changes.
* platform/Threading.h:
(WebCore::):
(WebCore::ThreadSafeShared::ThreadSafeShared):
(WebCore::ThreadSafeShared::ref):
(WebCore::ThreadSafeShared::deref):
(WebCore::ThreadSafeShared::hasOneRef):
(WebCore::ThreadSafeShared::refCount):
(WebCore::ThreadSafeShared::isThreadSafe):
Add a new Shared base class that uses a mutex to manage its refcount.
(WebCore::createThread):
(WebCore::waitForThreadCompletion):
(WebCore::detachThread):
New functions for thread creation.
(WebCore::Mutex::Mutex):
(WebCore::Mutex::~Mutex):
(WebCore::Mutex::lock):
(WebCore::Mutex::tryLock):
(WebCore::Mutex::unlock):
Move the definitions to ThreadingPthreads.cpp
(WebCore::ThreadCondition::ThreadCondition):
(WebCore::ThreadCondition::~ThreadCondition):
(WebCore::ThreadCondition::wait):
(WebCore::ThreadCondition::signal):
(WebCore::ThreadCondition::broadcast):
Move the definitions to ThreadingPthreads.cpp
* platform/pthreads: Added.
* platform/pthreads/ThreadingPthreads.cpp: Added.
Add pthread specific implementation of the thread creation functions, Mutex and ThreadCondition.
win:
Update for locking primitive changes.
* WebIconDatabase.cpp:
(WebIconDatabase::scheduleNotificationDelivery):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26716
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Wed, 17 Oct 2007 21:01:27 +0000 (21:01 +0000)]
Reviewed by Darin Adler.
Merged DeclaredFunctionImp into FunctionImp (the base class) because
the distinction between the two was unused.
Removed codeType() from FunctionImp because FunctionImp and its
subclasses all returned FunctionCode, so it was unused, practically
speaking.
Removed a different codeType() from GlobalFuncImp because it was unused.
(Perhaps it was vestigial from a time when GlobalFuncImp used to
inherit from FunctionImp.)
* bindings/runtime_method.cpp:
* bindings/runtime_method.h:
* kjs/function.cpp:
(KJS::):
(KJS::FunctionImp::FunctionImp):
(KJS::FunctionImp::callAsFunction):
(KJS::FunctionImp::construct):
(KJS::FunctionImp::execute):
(KJS::FunctionImp::processVarDecls):
* kjs/function.h:
(KJS::FunctionImp::implementsConstruct):
(KJS::FunctionImp::scope):
* kjs/function_object.cpp:
(FunctionProtoFunc::callAsFunction):
(FunctionObjectImp::construct):
* kjs/nodes.cpp:
(FuncDeclNode::processFuncDecl):
(FuncExprNode::evaluate):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26715
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Wed, 17 Oct 2007 20:28:09 +0000 (20:28 +0000)]
Add support for creating a layer when a transform is in effect. Add support to RenderStyle for
handing back a computed AffineTransform.
Reviewed by Mitz Pettel
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::adjustRenderStyle):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::setStyle):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::RenderObject):
(WebCore::RenderObject::requiresLayer):
(WebCore::RenderObject::setStyle):
* rendering/RenderObject.h:
(WebCore::RenderObject::hasTransform):
(WebCore::RenderObject::setHasTransform):
* rendering/RenderStyle.cpp:
(WebCore::RenderStyle::applyTransform):
* rendering/RenderStyle.h:
(WebCore::RenderStyle::hasTransform):
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::requiresLayer):
* rendering/RenderTableRow.h:
(WebCore::RenderTableRow::requiresLayer):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26710
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 17 Oct 2007 20:24:10 +0000 (20:24 +0000)]
Reviewed by Mark Rowe.
- fix <rdar://problem/
5183775> Uninitialized memory in -[WebDynamicScrollBarsView updateScrollers]
* WebView/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView updateScrollers]):
Change code path so it doesn't dispatch a method that returns an NSSize passing a nil object.
It's safe to do that for functions that return integers or pointers, but not structures.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26709
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Wed, 17 Oct 2007 20:12:42 +0000 (20:12 +0000)]
Add a new nightly launcher script for Windows
This new script is for versions of Safari that don't delay-load
WebKit. I had to make FindSafari be able to print out the nightly
launcher script on stdout because Windows shell scripts can't capture
the output from a command into an environment variable.
Reviewed by Steve.
* FindSafari/FindSafari.cpp:
(_tmain): Added /printSafariLauncher option.
* Scripts/run-webkit-nightly.cmd: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26708
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Wed, 17 Oct 2007 20:12:19 +0000 (20:12 +0000)]
Stop delay-loading WebKit in DRT and teskjs
JavaScriptCore:
Make testkjs not delay-load WebKit
Soon, delay-loading WebKit will be impossible (because we will be
using __declspec(thread) for thread-local storage). This change
prepares testkjs for the future.
Reviewed by Sam.
* JavaScriptCore.vcproj/JavaScriptCore.sln: Removed WebKitInitializer,
added FindSafari.
* JavaScriptCore.vcproj/testkjs/testkjs.vcproj: Don't link against
WebKitInitializer, don't delay-load WebKit.
* kjs/testkjs.cpp: Don't use WebKitInitializer.
WebKitTools:
Replace WebKitInitializer with FindSafari
We now rely on setting the PATH environment variable to tell Windows
where to find WebKit and its dependencies (similar to
DYLD_FRAMEWORK_PATH on Mac).
This change also make DumpRenderTree no longer delay-load WebKit.
Reviewed by Sam.
* DumpRenderTree/DumpRenderTree.sln: Removed WebKitInitializer, added
FindSafari.
* DumpRenderTree/win/DumpRenderTree.cpp: Don't use WebKitInitializer.
* DumpRenderTree/win/DumpRenderTree.vcproj: Don't link against
WebKitInitializer, don't delay-load WebKit.
* Scripts/run-javascriptcore-tests: Call setPathForRunningWebKitApp.
* Scripts/run-webkit-tests: Ditto.
* Scripts/webkitdirs.pm:
(sub setPathForRunningWebKitApp): Added.
* WebKitInitializer/WebKitInitializer.cpp: Removed.
* WebKitInitializer/WebKitInitializer.h: Removed.
* WebKitInitializer/WebKitInitializer.vcproj: Removed.
* WebKitInitializer/debug.vsprops: Removed.
* WebKitInitializer/debug_internal.vsprops: Removed.
* WebKitInitializer/release.vsprops: Removed.
WebKit/win:
Remove WebKitInitializer
Reviewed by Sam.
* WebKit.vcproj/WebKit.sln:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26707
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Wed, 17 Oct 2007 20:11:24 +0000 (20:11 +0000)]
Fix Bug 15532: run-safari fails if Safari is installed in a non-default location
WebKitTools:
Fix Bug 15532: run-safari fails if Safari is installed in a non-default location
http://bugs.webkit.org/show_bug.cgi?id=15532
FindSafari simply prints the location of an installed Safari.exe on
stdout.
Reviewed by Darin.
* FindSafari/FindSafari.cpp: Copied from WebKitTools/WebKitInitializer/WebKitInitializer.cpp.
(getStringValue):
(getWebViewCLSID):
(getInstalledWebKitDirectory):
(_tmain):
* FindSafari/FindSafari.vcproj: Added.
* Scripts/webkitdirs.pm:
(sub installedSafariPath): Added. Calls FindSafari on Windows.
WebKit/win:
Add FindSafari
Reviewed by Darin.
* WebKit.vcproj/WebKit.sln:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26706
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Wed, 17 Oct 2007 19:47:00 +0000 (19:47 +0000)]
Add support for mapping of the transform CSS property into RenderStyles. Everything is now ready for the front
end to use.
Reviewed by Mitz Pettel
* WebCore.xcodeproj/project.pbxproj:
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
* css/CSSTransformValue.h:
(WebCore::CSSTransformValue::type):
(WebCore::CSSTransformValue::values):
* platform/graphics/AffineTransform.cpp:
(WebCore::AffineTransform::skew):
* platform/graphics/AffineTransform.h:
* rendering/RenderStyle.cpp:
(WebCore::StyleTransformData::StyleTransformData):
(WebCore::StyleTransformData::operator==):
(WebCore::StyleTransformData::transformDataEquivalent):
* rendering/RenderStyle.h:
(WebCore::TransformOperation::~TransformOperation):
(WebCore::TransformOperation::operator!=):
(WebCore::TransformOperation::isScaleOperation):
(WebCore::TransformOperation::isRotateOperation):
(WebCore::TransformOperation::isSkewOperation):
(WebCore::TransformOperation::isTranslateOperation):
(WebCore::TransformOperation::isMatrixOperation):
(WebCore::ScaleTransformOperation::ScaleTransformOperation):
(WebCore::ScaleTransformOperation::isScaleOperation):
(WebCore::ScaleTransformOperation::operator==):
(WebCore::ScaleTransformOperation::apply):
(WebCore::RotateTransformOperation::RotateTransformOperation):
(WebCore::RotateTransformOperation::isRotateOperation):
(WebCore::RotateTransformOperation::operator==):
(WebCore::RotateTransformOperation::apply):
(WebCore::SkewTransformOperation::SkewTransformOperation):
(WebCore::SkewTransformOperation::isSkewOperation):
(WebCore::SkewTransformOperation::operator==):
(WebCore::SkewTransformOperation::apply):
(WebCore::TranslateTransformOperation::TranslateTransformOperation):
(WebCore::TranslateTransformOperation::isTranslateOperation):
(WebCore::TranslateTransformOperation::operator==):
(WebCore::TranslateTransformOperation::apply):
(WebCore::MatrixTransformOperation::MatrixTransformOperation):
(WebCore::MatrixTransformOperation::isMatrixOperation):
(WebCore::MatrixTransformOperation::operator==):
(WebCore::MatrixTransformOperation::apply):
(WebCore::StyleTransformData::operator!=):
(WebCore::RenderStyle::transform):
(WebCore::RenderStyle::setTransform):
(WebCore::RenderStyle::initialTransform):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26705
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Wed, 17 Oct 2007 19:30:07 +0000 (19:30 +0000)]
Windows build fix part 2.
JavaScriptCore:
Windows build fix part 2.
Fix was by Darin, reviewed by Anders and Adam.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Add
FastMallocPCRE.cpp to the project, and let Visual Studio have its way
with the post-build step.
* pcre/pcre.h: Don't DLL export the entry points just because this
is Win32 -- this is an internal copy of PCRE and should be private.
* pcre/pcre_compile.c: Fix an uninitialized variable warning --
there's no real problem but it's better to quiet the compiler by
tweaking the code slightly than turn off the warning entirely.
WebCore:
* page/Frame.cpp: I had to touch this file when fixing the Windows
build. Checking it in in case it helps others, too.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26704
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Wed, 17 Oct 2007 18:33:25 +0000 (18:33 +0000)]
2007-10-17 Eric Seidel <eric@webkit.org>
Reviewed by Mark Rowe.
Remove a couple more uses of svg_dynamic_cast.
No functional changes, no tests.
* ksvg2/svg/SVGPatternElement.cpp:
(WebCore::SVGPatternElement::buildPattern):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26703
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Wed, 17 Oct 2007 18:05:16 +0000 (18:05 +0000)]
2007-10-17 Mark Rowe <mrowe@apple.com>
Reviewed by Eric and Geoff.
<rdar://problem/
5453743> Repro ASSERT in CachedResource::setEncodedSize() loading image in background tab
http://bugs.webkit.org/show_bug.cgi?id=15191
* loader/DocLoader.cpp:
(WebCore::DocLoader::setAutoLoadImages): Don't start a load if the CachedImage is already loading.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26702
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Wed, 17 Oct 2007 17:54:08 +0000 (17:54 +0000)]
Windows build fix.
Reviewed by Anders.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Disable
some mismatched signed/unsigned comparison warnings.
* pcre/pcre_exec.c:
(match): #if-out some labels that don't seem to exist.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26701
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Wed, 17 Oct 2007 17:51:27 +0000 (17:51 +0000)]
WebCore:
Reviewed by Harrison.
<rdar://problem/
5481523>
GoogleDocs: Safari hangs when indenting a particular table twice
Fixed by fixing problems with the selection preservation done by IndentOutdentCommand.
It is now more difficult to create selections that cause hangs. Those are covered by:
<rdar://problem/
5543472>
* editing/IndentOutdentCommand.cpp:
(WebCore::indexForVisiblePosition): Compute indices from the first VisiblePosition
in the document, instead of the first Position.
Use rangeCompliantEquivalents when creating the Range that we pass to rangeLength.
Tell TextIterator::rangeLength that we're doing selection preservation, so that it
will emit characters between all VisiblePositions.
(WebCore::IndentOutdentCommand::indentRegion): Fixed a bug where the range and location
passed to rangeFromLocationAndLength were reversed.
Tell rangeFromLocationAndLength that we're doing doing selection preservation, as
above.
* editing/TextIterator.cpp:
(WebCore::CharacterIterator::CharacterIterator):
(WebCore::TextIterator::rangeLength): Rename emitSpacesForReplacedElements
to forSelectionPreservation, to match the name of the boolean inside TextIterator and
to match its meaning after r25522.
(WebCore::TextIterator::rangeFromLocationAndLength): Ditto.
LayoutTests:
Reviewed by Harrison.
<rdar://problem/
5481523>
GoogleDocs: Safari hangs when indenting a particular table twice
* editing/execCommand/
5481523.html: Added.
* platform/mac/editing/execCommand/
5481523-expected.checksum: Added.
* platform/mac/editing/execCommand/
5481523-expected.png: Added.
* platform/mac/editing/execCommand/
5481523-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26700
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Wed, 17 Oct 2007 07:45:27 +0000 (07:45 +0000)]
2007-10-17 Mark Rowe <mrowe@apple.com>
Gtk build fix.
* JavaScriptCore.pri: Add FastMallocPCRE.cpp.
* pcre/pcre_get. #if out two functions that depend on pcre_get_stringnumber, which
is currently unavailable for UTF-16.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26699
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Wed, 17 Oct 2007 07:12:51 +0000 (07:12 +0000)]
Reviewed by Anders.
* TODO: Updated with info on how to do the stats properly.
* hosted/sunspider-driver.html: Reduce timeout from 500 to 200 to
avoid overly slowing down the benchmark.
Added some 3D-related test cases.
* tests/3d-cube.js: Added.
* tests/3d-morph.js: Added.
* tests/3d-raytrace.js: Added.
* tests/LIST:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26698
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 17 Oct 2007 05:38:39 +0000 (05:38 +0000)]
Reviewed by Geoff.
- merged PCRE changes between 6.4 and 6.5
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
Removed pcre_config.c, pcre_globals.c, pcre_info.c, pcre_maketables.c,
pcre_printint.src, pcre_refcount.c, pcre_study.c, pcre_try_flipped.c,
pcre_ucp_findchar.c, pcre_version.c, and ucptable.c. Added pcre_ucp_searchfuncs.c.
* pcre/AUTHORS:
* pcre/LICENCE:
* pcre/MERGING:
* pcre/dftables.c:
* pcre/pcre-config.h:
* pcre/pcre.h:
* pcre/pcre.pri:
* pcre/pcre_compile.c:
* pcre/pcre_exec.c:
* pcre/pcre_fullinfo.c:
* pcre/pcre_get.c:
* pcre/pcre_internal.h:
* pcre/pcre_maketables.c:
* pcre/pcre_ord2utf8.c:
* pcre/pcre_tables.c:
* pcre/pcre_ucp_searchfuncs.c: Copied from pcre/pcre_ucp_findchar.c.
* pcre/pcre_xclass.c:
* pcre/ucp.h:
* pcre/ucpinternal.h:
* pcre/ucptable.c:
Updated with new versions from the PCRE 6.5 release, merged with changes.
* pcre/pcre_config.c: Removed.
* pcre/pcre_globals.c: Removed.
* pcre/pcre_info.c: Removed.
* pcre/pcre_printint.src: Removed.
* pcre/pcre_refcount.c: Removed.
* pcre/pcre_study.c: Removed.
* pcre/pcre_try_flipped.c: Removed.
* pcre/pcre_ucp_findchar.c: Removed.
* pcre/pcre_version.c: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26697
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 17 Oct 2007 04:51:50 +0000 (04:51 +0000)]
Reviewed by Mitz.
- fix http://bugs.webkit.org/show_bug.cgi?id=15536
need to cache missing glyph so we're not slow on pages that show missing glyphs
- <rdar://problem/
5404359> UI thread stall (>60sec) in MLANG running stress test
(related to font data caching)
* platform/Font.cpp: (WebCore::Font::glyphDataForCharacter): Check for a null value
for fontData rather than for glyph to detect non-cached entries in the glyph data.
* platform/gtk/GlyphPageTreeNodeGtk.cpp: (WebCore::GlyphPage::fill):
* platform/mac/GlyphPageTreeNodeMac.cpp: (WebCore::GlyphPage::fill):
* platform/win/GlyphPageTreeNodeWin.cpp: (WebCore::GlyphPage::fill):
Set fontData to 0 for missing glyph entries. Also fixed the Windows and GTK versions
to return the proper value for haveGlyphs.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26696
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Wed, 17 Oct 2007 03:47:35 +0000 (03:47 +0000)]
2007-10-16 Mark Rowe <mrowe@apple.com>
Gtk build fix. Replace use of assert with ASSERT_NOT_REACHED.
* platform/gtk/FontCacheGtk.cpp:
(WebCore::FontCache::platformInit):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26695
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer [Wed, 17 Oct 2007 02:02:53 +0000 (02:02 +0000)]
WebCore:
Reviewed by Timothy.
<rdar://problem/
5544354> Wrong delegate method called in WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad()
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad): Fixed selector name.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26694
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kmccullo [Wed, 17 Oct 2007 00:57:12 +0000 (00:57 +0000)]
Reviewed by Sam.
- Minor mac improvements based on observations I made while implementing the
Windows code.
* Drosera/mac/DebuggerApplication.mm: Attach does not need to create the server
then hand it to the Client who will retain it, it should just be the client who
creates and owns the server.
(-[DebuggerApplication attach:]):
* Drosera/mac/DebuggerClient.h: Can now be created with just a server name.
* Drosera/mac/DebuggerClient.mm: Creates the server.
(-[DebuggerClient initWithServerName:]):
* Drosera/mac/ServerConnection.mm: Does not need to include 2 header files, but
can instead forward declare what it needs.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26693
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aliceli1 [Wed, 17 Oct 2007 00:36:35 +0000 (00:36 +0000)]
removing fixed tests
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26692
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
git://git.webkit.org / WebKit-https.git / log