WebKit-https.git
12 years agoRubber stamped by Mark Rowe.
jparent@chromium.org [Fri, 6 Nov 2009 03:27:43 +0000 (03:27 +0000)]
Rubber stamped by Mark Rowe.

Adds some GYP generated files to svn:ignore
https://bugs.webkit.org/show_bug.cgi?id=31194

*.vcproj
*.rules
*.mk
*.scons
SConstruct

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-05 Steve Block <steveblock@google.com>
eric@webkit.org [Fri, 6 Nov 2009 02:46:05 +0000 (02:46 +0000)]
2009-11-05  Steve Block  <steveblock@google.com>

        Reviewed by Eric Seidel.

        If the Geolocation service fails to start, invoke the error callback asynchronously.
        https://bugs.webkit.org/show_bug.cgi?id=28276

        All Geolocation callbacks must be invoked asynchronously.
        See http://www.w3.org/TR/geolocation-API/#geolocation_interface

        No new tests possible with current LayoutTestController.

        * page/Geolocation.cpp:
        (WebCore::Geolocation::getCurrentPosition): Modified. Asserts that startRequest returned a notifier.
        (WebCore::Geolocation::watchPosition): Modified. Asserts that startRequest returned a notifier.
        (WebCore::Geolocation::startRequest): Modified. If the Geolocation service fails to start, set a fatal error on the notifier.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdding a resource that seems to be missing. Without it, several tests in
alice.liu@apple.com [Fri, 6 Nov 2009 00:05:11 +0000 (00:05 +0000)]
Adding a resource that seems to be missing.  Without it, several tests in
fast/dom/beforeload aren't really testing if the default event handling is
prevented, but instead are only testing if the beforeload event fires.

Rubber-stamped by Gavin Barraclough.

* fast/dom/beforeload/resources/fail.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-05 Chris Jerdonek <chris.jerdonek@gmail.com>
eric@webkit.org [Thu, 5 Nov 2009 23:53:45 +0000 (23:53 +0000)]
2009-11-05  Chris Jerdonek  <chris.jerdonek@gmail.com>

        Reviewed by Eric Seidel.

        Removed the "this is part of the KDE project" comments from
        all *.h, *.cpp, *.idl, and *.pm files.

        https://bugs.webkit.org/show_bug.cgi?id=31167

        The maintenance and architecture page in the project wiki lists
        this as a task.

        This change includes no changes or additions to test cases
        since the change affects only comments.

        * wtf/wince/FastMallocWince.h:
2009-11-05  Chris Jerdonek  <chris.jerdonek@gmail.com>

        Reviewed by Eric Seidel.

        Removed the "this is part of the KDE project" comments from
        all *.h, *.cpp, *.idl, and *.pm files.

        https://bugs.webkit.org/show_bug.cgi?id=31167

        The maintenance and architecture page in the project wiki lists
        this as a task.

        This change includes no changes or additions to test cases
        since the change affects only comments.

        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/scripts/IDLParser.pm:
        * bindings/scripts/IDLStructure.pm:
        * css/CSSInheritedValue.cpp:
        * css/CSSInitialValue.cpp:
        * css/CSSMediaRule.cpp:
        * css/CSSNamespace.h:
        * css/CSSProperty.cpp:
        * css/CSSProperty.h:
        * css/CSSRuleList.cpp:
        * css/CSSRuleList.h:
        * css/CSSSelector.h:
        * css/CSSValueList.cpp:
        * css/FontValue.cpp:
        * css/MediaFeatureNames.cpp:
        * css/MediaFeatureNames.h:
        * css/Pair.h:
        * css/SVGCSSStyleSelector.cpp:
        * css/ShadowValue.cpp:
        * css/StyleSheet.cpp:
        * css/StyleSheetList.cpp:
        * css/maketokenizer:
        * dom/BeforeUnloadEvent.cpp:
        * dom/BeforeUnloadEvent.h:
        * dom/CSSMappedAttributeDeclaration.cpp:
        * dom/EventNames.cpp:
        * dom/EventTarget.cpp:
        * dom/MappedAttributeEntry.h:
        * dom/MouseRelatedEvent.h:
        * dom/RangeException.h:
        * dom/StyleElement.h:
        * dom/Tokenizer.h:
        * html/HTMLHeadElement.h:
        * html/HTMLHeadingElement.cpp:
        * html/HTMLHeadingElement.h:
        * html/HTMLHtmlElement.h:
        * html/HTMLImageLoader.h:
        * html/HTMLMetaElement.h:
        * html/HTMLModElement.cpp:
        * html/HTMLModElement.h:
        * html/HTMLOptionsCollection.cpp:
        * html/HTMLPlugInElement.cpp:
        * html/HTMLPreElement.cpp:
        * html/HTMLPreElement.h:
        * html/HTMLTableCellElement.cpp:
        * html/HTMLTableCellElement.h:
        * html/HTMLTableColElement.cpp:
        * html/HTMLTableColElement.h:
        * html/HTMLTablePartElement.cpp:
        * html/HTMLTablePartElement.h:
        * html/HTMLTitleElement.h:
        * page/MouseEventWithHitTestResults.h:
        * platform/StaticConstructors.h:
        * platform/text/AtomicStringImpl.h:
        * platform/text/qt/TextBreakIteratorQt.cpp:
        * rendering/AutoTableLayout.h:
        * rendering/CounterNode.cpp:
        * rendering/EllipsisBox.cpp:
        * rendering/EllipsisBox.h:
        * rendering/FixedTableLayout.cpp:
        * rendering/FixedTableLayout.h:
        * rendering/HitTestRequest.h:
        * rendering/HitTestResult.h:
        * rendering/InlineRunBox.h:
        * rendering/PointerEventsHitRules.cpp:
        * rendering/PointerEventsHitRules.h:
        * rendering/RenderBR.cpp:
        * rendering/RenderBR.h:
        * rendering/RenderButton.cpp:
        * rendering/RenderButton.h:
        * rendering/RenderFieldset.cpp:
        * rendering/RenderFrameSet.cpp:
        * rendering/RenderListItem.cpp:
        * rendering/RenderTableRow.cpp:
        * rendering/RenderView.h:
        * rendering/RootInlineBox.h:
        * rendering/SVGInlineTextBox.cpp:
        * rendering/SVGInlineTextBox.h:
        * rendering/TableLayout.h:
        * rendering/break_lines.h:
        * rendering/style/SVGRenderStyle.cpp:
        * rendering/style/SVGRenderStyle.h:
        * rendering/style/SVGRenderStyleDefs.cpp:
        * rendering/style/SVGRenderStyleDefs.h:
        * svg/GradientAttributes.h:
        * svg/LinearGradientAttributes.h:
        * svg/PatternAttributes.h:
        * svg/RadialGradientAttributes.h:
        * svg/SVGAElement.cpp:
        * svg/SVGAngle.idl:
        * svg/SVGAnimateColorElement.cpp:
        * svg/SVGAnimateColorElement.h:
        * svg/SVGAnimateElement.cpp:
        * svg/SVGAnimateElement.h:
        * svg/SVGAnimateTransformElement.h:
        * svg/SVGAnimatedPathData.cpp:
        * svg/SVGAnimatedPathData.h:
        * svg/SVGAnimatedPoints.cpp:
        * svg/SVGAnimatedPoints.h:
        * svg/SVGAnimationElement.cpp:
        * svg/SVGCircleElement.cpp:
        * svg/SVGClipPathElement.cpp:
        * svg/SVGColor.cpp:
        * svg/SVGColor.idl:
        * svg/SVGComponentTransferFunctionElement.cpp:
        * svg/SVGComponentTransferFunctionElement.h:
        * svg/SVGCursorElement.cpp:
        * svg/SVGDefsElement.cpp:
        * svg/SVGDescElement.cpp:
        * svg/SVGDescElement.h:
        * svg/SVGDocument.idl:
        * svg/SVGElement.idl:
        * svg/SVGElementInstanceList.cpp:
        * svg/SVGElementInstanceList.h:
        * svg/SVGEllipseElement.cpp:
        * svg/SVGExternalResourcesRequired.cpp:
        * svg/SVGFEBlendElement.cpp:
        * svg/SVGFEBlendElement.h:
        * svg/SVGFEColorMatrixElement.cpp:
        * svg/SVGFEColorMatrixElement.h:
        * svg/SVGFEComponentTransferElement.cpp:
        * svg/SVGFEComponentTransferElement.h:
        * svg/SVGFECompositeElement.cpp:
        * svg/SVGFECompositeElement.h:
        * svg/SVGFEFloodElement.cpp:
        * svg/SVGFEFloodElement.h:
        * svg/SVGFEFuncAElement.cpp:
        * svg/SVGFEFuncAElement.h:
        * svg/SVGFEFuncBElement.cpp:
        * svg/SVGFEFuncBElement.h:
        * svg/SVGFEFuncGElement.cpp:
        * svg/SVGFEFuncGElement.h:
        * svg/SVGFEFuncRElement.cpp:
        * svg/SVGFEFuncRElement.h:
        * svg/SVGFEGaussianBlurElement.cpp:
        * svg/SVGFEGaussianBlurElement.h:
        * svg/SVGFEImageElement.cpp:
        * svg/SVGFEMergeElement.cpp:
        * svg/SVGFEMergeElement.h:
        * svg/SVGFEMergeNodeElement.cpp:
        * svg/SVGFEOffsetElement.cpp:
        * svg/SVGFEOffsetElement.h:
        * svg/SVGFETileElement.cpp:
        * svg/SVGFETileElement.h:
        * svg/SVGFETurbulenceElement.cpp:
        * svg/SVGFETurbulenceElement.h:
        * svg/SVGFilterElement.cpp:
        * svg/SVGGElement.cpp:
        * svg/SVGGradientElement.cpp:
        * svg/SVGHKernElement.idl:
        * svg/SVGLangSpace.cpp:
        * svg/SVGLangSpace.h:
        * svg/SVGLength.cpp:
        * svg/SVGLength.h:
        * svg/SVGLength.idl:
        * svg/SVGLengthList.cpp:
        * svg/SVGLengthList.h:
        * svg/SVGLineElement.cpp:
        * svg/SVGLinearGradientElement.h:
        * svg/SVGList.h:
        * svg/SVGListTraits.h:
        * svg/SVGLocatable.h:
        * svg/SVGMaskElement.cpp:
        * svg/SVGMatrix.idl:
        * svg/SVGMetadataElement.cpp:
        * svg/SVGMetadataElement.h:
        * svg/SVGMetadataElement.idl:
        * svg/SVGNumber.idl:
        * svg/SVGNumberList.cpp:
        * svg/SVGNumberList.h:
        * svg/SVGPaint.cpp:
        * svg/SVGPathElement.cpp:
        * svg/SVGPathSeg.h:
        * svg/SVGPathSegArc.cpp:
        * svg/SVGPathSegArc.h:
        * svg/SVGPathSegClosePath.cpp:
        * svg/SVGPathSegClosePath.h:
        * svg/SVGPathSegCurvetoCubic.cpp:
        * svg/SVGPathSegCurvetoCubic.h:
        * svg/SVGPathSegCurvetoCubicSmooth.cpp:
        * svg/SVGPathSegCurvetoCubicSmooth.h:
        * svg/SVGPathSegCurvetoQuadratic.cpp:
        * svg/SVGPathSegCurvetoQuadratic.h:
        * svg/SVGPathSegCurvetoQuadraticSmooth.cpp:
        * svg/SVGPathSegCurvetoQuadraticSmooth.h:
        * svg/SVGPathSegLineto.cpp:
        * svg/SVGPathSegLineto.h:
        * svg/SVGPathSegLinetoHorizontal.cpp:
        * svg/SVGPathSegLinetoHorizontal.h:
        * svg/SVGPathSegLinetoVertical.cpp:
        * svg/SVGPathSegLinetoVertical.h:
        * svg/SVGPathSegMoveto.cpp:
        * svg/SVGPathSegMoveto.h:
        * svg/SVGPatternElement.cpp:
        * svg/SVGPoint.idl:
        * svg/SVGPointList.cpp:
        * svg/SVGPointList.h:
        * svg/SVGPolyElement.cpp:
        * svg/SVGPolygonElement.cpp:
        * svg/SVGPolygonElement.h:
        * svg/SVGPolylineElement.cpp:
        * svg/SVGPolylineElement.h:
        * svg/SVGPreserveAspectRatio.cpp:
        * svg/SVGPreserveAspectRatio.h:
        * svg/SVGRadialGradientElement.h:
        * svg/SVGRect.idl:
        * svg/SVGRectElement.cpp:
        * svg/SVGRenderingIntent.h:
        * svg/SVGSVGElement.idl:
        * svg/SVGScriptElement.cpp:
        * svg/SVGSetElement.cpp:
        * svg/SVGSetElement.h:
        * svg/SVGStopElement.cpp:
        * svg/SVGStringList.cpp:
        * svg/SVGStringList.h:
        * svg/SVGStylable.cpp:
        * svg/SVGStylable.h:
        * svg/SVGStyleElement.cpp:
        * svg/SVGStyleElement.h:
        * svg/SVGStyledElement.h:
        * svg/SVGStyledLocatableElement.cpp:
        * svg/SVGStyledLocatableElement.h:
        * svg/SVGStyledTransformableElement.cpp:
        * svg/SVGStyledTransformableElement.h:
        * svg/SVGSwitchElement.cpp:
        * svg/SVGSymbolElement.cpp:
        * svg/SVGTRefElement.cpp:
        * svg/SVGTSpanElement.cpp:
        * svg/SVGTSpanElement.h:
        * svg/SVGTests.h:
        * svg/SVGTextElement.cpp:
        * svg/SVGTextElement.h:
        * svg/SVGTextPathElement.cpp:
        * svg/SVGTextPositioningElement.cpp:
        * svg/SVGTextPositioningElement.h:
        * svg/SVGTitleElement.cpp:
        * svg/SVGTitleElement.h:
        * svg/SVGTransform.cpp:
        * svg/SVGTransform.h:
        * svg/SVGTransform.idl:
        * svg/SVGTransformList.cpp:
        * svg/SVGTransformList.h:
        * svg/SVGTransformable.h:
        * svg/SVGURIReference.h:
        * svg/SVGUnitTypes.h:
        * svg/SVGUseElement.cpp:
        * svg/SVGViewElement.cpp:
        * svg/SVGZoomAndPan.cpp:
        * svg/SVGZoomAndPan.h:
        * svg/SVGZoomEvent.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-05 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 5 Nov 2009 23:28:42 +0000 (23:28 +0000)]
2009-11-05  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: beautify layout tests.

        https://bugs.webkit.org/show_bug.cgi?id=31189

        * inspector/console-dir-expected.txt:
        * inspector/console-dir.html:
        * inspector/console-dirxml-expected.txt:
        * inspector/console-dirxml.html:
        * inspector/console-format-collections-expected.txt:
        * inspector/console-format-collections.html:
        * inspector/console-format-expected.txt:
        * inspector/console-format.html:
        * inspector/console-tests-expected.txt:
        * inspector/console-tests.html:
        * inspector/console-tests.js: Added.
        (dumpConsoleMessages.callback):
        (dumpConsoleMessages):
        (dumpConsoleMessagesWithClasses.callback):
        (dumpConsoleMessagesWithClasses):
        (frontendScript_dumpConsoleMessages):
        * inspector/css-syntax-highlight.html: Removed.
        * inspector/elements-panel-structure-expected.txt:
        * inspector/elements-panel-structure.html:
        * inspector/elements-tests.js: Added.
        (frontendScript_expandDOMSubtree.processChildren):
        (frontendScript_expandDOMSubtree):
        * inspector/evaluate-in-frontend.html:
        * inspector/evaluate-in-frontend.js: Removed.
        * inspector/inspector-test.js: Added.
        ():
        (evaluateInWebInspector):
        (notifyDone):
        (output):
        (window.didEvaluateForTestInFrontend):
        * inspector/javascript-syntax-highlight.html: Removed.
        * inspector/styles-iframe.html:
        * inspector/syntax-highlight-css-expected.txt: Renamed from LayoutTests/inspector/css-syntax-highlight-expected.txt.
        * inspector/syntax-highlight-css.html: Added.
        * inspector/syntax-highlight-javascript-expected.txt: Renamed from LayoutTests/inspector/javascript-syntax-highlight-expected.txt.
        * inspector/syntax-highlight-javascript.html: Added.
        * inspector/syntax-highlight.js: Added.
        (doit.callback):
        (doit):
        (frontendScript_dumpSyntaxHighlight):
        * inspector/timeline-trivial.html:
        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-05 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Thu, 5 Nov 2009 23:25:47 +0000 (23:25 +0000)]
2009-11-05  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Dimitri Glazkov.

        REGRESSION Clean up security origin usage in DOM Storage.
        https://bugs.webkit.org/show_bug.cgi?id=31188

        Clean up security origin usage in DOM Storage.  This fixes a bug in my
        refactoring here: https://bugs.webkit.org/show_bug.cgi?id=31149

        Instead of having StorageAreaSync's constructor (which is called in the
        constructor for StorageAreaImpl) calling a method on StoargeAreaImpl to get the
        database identifier, simply have StorageAreaImpl pass the identifier into
        StorageAreaSync.

        No test because there's no change in externally observable behavior.

        * storage/StorageAreaImpl.cpp:
        (WebCore::StorageAreaImpl::StorageAreaImpl):
        * storage/StorageAreaImpl.h:
        * storage/StorageAreaSync.cpp:
        (WebCore::StorageAreaSync::create):
        (WebCore::StorageAreaSync::StorageAreaSync):
        * storage/StorageAreaSync.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-05 Scott Violet <sky@google.com>
eric@webkit.org [Thu, 5 Nov 2009 23:08:47 +0000 (23:08 +0000)]
2009-11-05  Scott Violet  <sky@google.com>

        Reviewed by Dimitri Glazkov.

        Need notification of scrolling frame
        https://bugs.webkit.org/show_bug.cgi?id=31145

        Adds FrameLoaderClient::didChangeScrollOffset that is called when
        the frame scrolls. This will be used to know when history state
        needs to be updated.

        * loader/FrameLoaderClient.h:
        (WebCore::FrameLoaderClient::didChangeScrollOffset):
        * page/FrameView.cpp:
        (WebCore::FrameView::valueChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-05 Shu Chang <Chang.Shu@nokia.com>
eric@webkit.org [Thu, 5 Nov 2009 22:46:56 +0000 (22:46 +0000)]
2009-11-05  Shu Chang  <Chang.Shu@nokia.com>

        Reviewed by Adele Peterson.

        The number of selected lines in textarea after a shift-PageDown
        may differ. The test case is modified so that it will not depend
        on the exact number of lines selected. This should resolve regression
        on platforms like Qt and GTK.
        https://bugs.webkit.org/show_bug.cgi?id=31122

        * editing/selection/shrink-selection-after-shift-pagedown.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-05 Kenneth Russell <kbr@google.com>
eric@webkit.org [Thu, 5 Nov 2009 22:17:40 +0000 (22:17 +0000)]
2009-11-05  Kenneth Russell  <kbr@google.com>

        Reviewed by Dimitri Glazkov.

        [V8] Update bindings to use new API for external arrays
        https://bugs.webkit.org/show_bug.cgi?id=31181

        No new tests; covered by existing WebGL tests.

        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::setIndexedPropertiesToExternalArray):
        (WebCore::V8DOMWrapper::getTemplate):
        (WebCore::V8DOMWrapper::convertToV8Object):
        * bindings/v8/V8DOMWrapper.h:
        * bindings/v8/custom/V8CanvasArrayCustom.h:
        (WebCore::constructCanvasArray):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoNot reviewed, Chromium build fix.
hclam@chromium.org [Thu, 5 Nov 2009 21:59:58 +0000 (21:59 +0000)]
Not reviewed, Chromium build fix.

Patch by Alpha Lam <hclam@chromium.org> on 2009-11-05
50561 introduces a custom method for SVGMatrix, we need to implement
this in V8.

* bindings/v8/custom/V8CustomBinding.h:
Adding definition for V8SVGMatrixMultiply.
* bindings/v8/custom/V8SVGMatrixCustom.cpp:
(WebCore::CALLBACK_FUNC_DECL):
Implement V8SVGMatrixMultiply according to the same method in JSC.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-05 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 5 Nov 2009 21:09:01 +0000 (21:09 +0000)]
2009-11-05  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: empty line in expectations build fix.

        * fast/events/event-listener-map-rehash-crash-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRevert 50569 since it broke QT. Build fix and just a revert, so no review.
jorlow@chromium.org [Thu, 5 Nov 2009 20:42:50 +0000 (20:42 +0000)]
Revert 50569 since it broke QT.  Build fix and just a revert, so no review.

Patch by Jeremy Orlow <jorlow@chromium.org> on 2009-11-05
* page/DOMWindow.cpp:
(WebCore::DOMWindow::sessionStorage):
* page/Settings.cpp:
(WebCore::Settings::Settings):
(WebCore::Settings::setSessionStorageEnabled):
* page/Settings.h:
(WebCore::Settings::sessionStorageEnabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-05 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 5 Nov 2009 20:13:29 +0000 (20:13 +0000)]
2009-11-05  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        REGRESSION: Web Inspector doesn't show CSS rules properly for iframes

        https://bugs.webkit.org/show_bug.cgi?id=30884

        Test: inspector/styles-iframe.html

        * inspector/front-end/DOMAgent.js:
        (WebInspector.DOMNode):
        * inspector/front-end/InjectedScript.js:
        (InjectedScript.getStyles):
        (InjectedScript.getComputedStyle):
        (InjectedScript.addStyleSelector):
        * inspector/front-end/TestController.js:
        (WebInspector.TestController.prototype.notifyDone):
        (WebInspector.TestController.prototype.runAfterPendingDispatches):
        (WebInspector.evaluateForTestInFrontend.invokeMethod):
        (WebInspector.evaluateForTestInFrontend):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
dglazkov@chromium.org [Thu, 5 Nov 2009 20:09:12 +0000 (20:09 +0000)]
WebCore:

2009-11-05  Vitaly Repeshko  <vitalyr@chromium.org>

        Reviewed by Geoffrey Garen and Dimitri Glazkov.

        Rehashing of EventListenerMap leads to loss of EvenListenerList.
        https://bugs.webkit.org/show_bug.cgi?id=31027

        Tested by new fast/events/event-listener-map-rehash-crash.html.

        EventListenerMap modified to store pointers to listener vectors:
        * dom/EventTarget.cpp:
        (WebCore::EventTargetData::~EventTargetData):
        (WebCore::EventTarget::addEventListener):
        (WebCore::EventTarget::removeEventListener):
        (WebCore::EventTarget::fireEventListeners):
        (WebCore::EventTarget::getEventListeners):
        (WebCore::EventTarget::removeAllEventListeners):
        * dom/EventTarget.h:

        Usages updated after interface changes:
        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::getEventListenersForNode):
        * svg/SVGUseElement.cpp:
        (WebCore::SVGUseElement::transferEventListenersToShadowTree):

LayoutTests:

2009-11-05  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Geoffrey Garen.

        Rehashing of EventListenerMap leads to loss of EvenListenerList.
        https://bugs.webkit.org/show_bug.cgi?id=31027

        * fast/events/event-listener-map-rehash-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRubber-stamped by Adam Roben.
bweinstein@apple.com [Thu, 5 Nov 2009 20:05:24 +0000 (20:05 +0000)]
Rubber-stamped by Adam Roben.

Add ruby tests and failing accessibility test to Windows Skipped list,
we should be able to re-add ruby tests, but not sure the correct course
of action yet.

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-05 Dan Kegel <dank@chromium.org>
eric@webkit.org [Thu, 5 Nov 2009 19:57:05 +0000 (19:57 +0000)]
2009-11-05  Dan Kegel  <dank@chromium.org>

        Reviewed by Dmitri Titov.

        Add missing initialization for m_createdByParser.
        https://bugs.webkit.org/show_bug.cgi?id=31089

        Test: fast/dom/beforeload/pi-before-load.xhtml in Valgrind

        * dom/ProcessingInstruction.cpp:
        (WebCore::ProcessingInstruction::ProcessingInstruction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-04 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 5 Nov 2009 19:33:48 +0000 (19:33 +0000)]
2009-11-04  Eric Seidel  <eric@webkit.org>

        No review, just add a line which got left out of the patch uploaded for commit.

        commit-queue is crashing when trying to reject patches after unknown failures
        https://bugs.webkit.org/show_bug.cgi?id=31091

        * Scripts/bugzilla-tool: Set bug_log = None after closing to we don't re-close and crash.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-04 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Thu, 5 Nov 2009 19:27:17 +0000 (19:27 +0000)]
2009-11-04  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Adam Barth.

        DOM Storage runtime flag changes
        https://bugs.webkit.org/show_bug.cgi?id=30602

        Part 2/2.

        Revert my changes to Settings and instead implement DOM Storage enabling via
        the methods agreed upon in https://bugs.webkit.org/show_bug.cgi?id=30240

        This stuff was (intentionally) never exposed to web pages or DRT, so there's no
        LayoutTest visible changes and thus no tests.

        * bindings/v8/custom/V8CustomBinding.h:
        * bindings/v8/custom/V8DOMWindowCustom.cpp:
        (WebCore::ACCESSOR_RUNTIME_ENABLER):
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::sessionStorage):
        * page/DOMWindow.idl:
        * page/Settings.cpp:
        (WebCore::Settings::Settings):
        * page/Settings.h:
        * storage/Storage.cpp:
        (WebCore::Storage::setLocalStorageAvailable):
        (WebCore::Storage::localStorageAvailable):
        (WebCore::Storage::setSessionStorageAvailable):
        (WebCore::Storage::sessionStorageAvailable):
        * storage/Storage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBug 31108 - [V8] REGRESSION: Pause on exception is broken
jianli@chromium.org [Thu, 5 Nov 2009 18:33:59 +0000 (18:33 +0000)]
Bug 31108 - [V8] REGRESSION: Pause on exception is broken
https://bugs.webkit.org/show_bug.cgi?id=31108

Reviewed by Pavel Feldman.

* bindings/v8/V8AbstractEventListener.cpp:
(WebCore::V8AbstractEventListener::invokeEventHandler):
* bindings/v8/V8Utilities.cpp:
(WebCore::reportException):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMake CFDictionaryPropertyBag::createInstance return a COMPtr
aroben@apple.com [Thu, 5 Nov 2009 18:14:35 +0000 (18:14 +0000)]
Make CFDictionaryPropertyBag::createInstance return a COMPtr

I also cleaned up CFDictionaryPropertyBag's class declaration a little
while I was at it.

Part of <http://webkit.org/b/25294> <rdar://problem/6803127> All
WebKit/win classes should return COMPtrs from their static constructor
members

Reviewed by Steve Falkenburg.

* CFDictionaryPropertyBag.cpp:
(CFDictionaryPropertyBag::CFDictionaryPropertyBag): Changed to
initialize m_refCount to 0. m_refCount gets increased to 1 by
createInstance.
(CFDictionaryPropertyBag::createInstance): Changed to return a COMPtr.

* CFDictionaryPropertyBag.h:
  - Updated copyright years
  - Fixed header guard to match current style
  - Replaced #include of CoreFoundation.h with forward-declaration of
    CFMutableDictionaryRef
  - Added #include of COMPtr.h
  - Fixed opening brace placement in class declaration
  - Made createInstance return a COMPtr
  - Made constructor/destructor private
  - Made QueryInterface and IPropertyBag functions private
  - Removed unnecessary parameter names and MIDL comments

* WebCache.cpp:
(WebCache::statistics): Updated for change to
CFDictionaryPropertyBag::createInstance. Now uses releaseRef to place
the IPropertyBag pointers into the s array.

* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::dispatchDidFailToStartPlugin):
* WebDatabaseManager.cpp:
(WebDatabaseManager::dispatchDidModifyDatabase):
* WebFrame.cpp:
(WebFrame::createJavaAppletWidget):
Updated for change to CFDictionaryPropertyBag::createInstance.

* WebHistory.cpp: Removed releaseUserInfo, which is no longer needed.
That function was also doing an unnecessary call to setDictionary(0).
(createUserInfoFromArray):
(createUserInfoFromHistoryItem):
Changed to return COMPtr.

(WebHistory::loadFromURL): Updated for change to
CFDictionaryPropertyBag::createInstance.

(WebHistory::removeAllItems): Updated for change to
CFDictionaryPropertyBag::createInstance, which fixed a leak! We had
forgotten to call releaseUserInfo here.

(WebHistory::removeItem):
(WebHistory::addItem):
(WebHistory::visitedURL):
* WebIconDatabase.cpp:
(postDidAddIconNotification):
Updated for change to CFDictionaryPropertyBag::createInstance.

* WebKitClassFactory.cpp:
(releaseRefFromCreateInstance): Added this overloaded function
template to abstract away the difference between createInstance
functions that return a ref'd pointer and createInstance functions
that return a COMPtr.
(WebKitClassFactory::CreateInstance): Changed to use
releaseRefFromCreateInstance.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore: We should not bubble up events if we drag something to an iframe that
jianli@chromium.org [Thu, 5 Nov 2009 17:59:35 +0000 (17:59 +0000)]
WebCore: We should not bubble up events if we drag something to an iframe that
has an invalid source.
https://bugs.webkit.org/show_bug.cgi?id=30469

Reviewed by Dmitri Titov.

Test: http/tests/misc/bubble-drag-events.html

* page/EventHandler.cpp:
(WebCore::EventHandler::handleDragAndDropForTarget):
(WebCore::EventHandler::updateDragAndDrop):
(WebCore::EventHandler::cancelDragAndDrop):
(WebCore::EventHandler::performDragAndDrop):
* page/EventHandler.h:
(WebCore::EventHandler::):

LayoutTests: Tests the drag event bubbling on different targets:
- iframe with invalid source
- iframe with valid source
- non-iframe droppable element
https://bugs.webkit.org/show_bug.cgi?id=30469

Reviewed by Dmitri Titov.

* http/tests/misc/bubble-drag-events-expected.txt: Added.
* http/tests/misc/bubble-drag-events.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRemove bogus else clause in bugzilla-tool
aroben@apple.com [Thu, 5 Nov 2009 16:42:45 +0000 (16:42 +0000)]
Remove bogus else clause in bugzilla-tool

Fixes <http://webkit.org/b/31125> REGRESSION (r47121): bugzilla-tool
create-bug raises exception after entering bug description

Reviewed by David Kilzer.

* Scripts/bugzilla-tool:
(CreateBug): else clauses are only hit if no exception is raised, so
it makes no sense to try to re-raise the exception in an else clause.
The exception will automatically be re-raised if it doesn't match any
of the except clauses, so we don't have to do anything special here at
all to get the desired behavior.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-05 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 5 Nov 2009 15:58:07 +0000 (15:58 +0000)]
2009-11-05  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: speed up Timelines Clear by a factor of thousands.

        https://bugs.webkit.org/show_bug.cgi?id=31160

        * inspector/front-end/utilities.js:
        (Element.prototype.removeChildren):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-05 Shu Chang <Chang.Shu@nokia.com>
eric@webkit.org [Thu, 5 Nov 2009 15:48:43 +0000 (15:48 +0000)]
2009-11-05  Shu Chang  <Chang.Shu@nokia.com>

        Reviewed by Tor Arne Vestbø.

        Add support for Shift-PageUp and Shift-PageDown key events.
        https://bugs.webkit.org/show_bug.cgi?id=31166

        Test: LayoutTests/editing/selection/shrink-selection-after-shift-pagedown.html

        * WebCoreSupport/EditorClientQt.cpp:
        (WebCore::EditorClientQt::handleKeyboardEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-05 Anton Muhin <antonm@chromium.org>
eric@webkit.org [Thu, 5 Nov 2009 15:36:14 +0000 (15:36 +0000)]
2009-11-05  Anton Muhin  <antonm@chromium.org>

        Reviewed by Adam Barth.

        If high memory usage is detected, hint to V8 that it might be due
        to external objects retained by V8 objects.
        https://bugs.webkit.org/show_bug.cgi?id=31051

        * bindings/v8/V8GCController.cpp:
        (WebCore::GetMemoryUsageInMB):
        (WebCore::V8GCController::gcEpilogue):
        (WebCore::V8GCController::checkMemoryUsage):
        * bindings/v8/V8GCController.h:
        * bindings/v8/V8Proxy.cpp:
        (WebCore::V8Proxy::evaluate):
        (WebCore::V8Proxy::runScript):
        (WebCore::V8Proxy::callFunction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-05 Jeff Schiller <codedread@gmail.com>
eric@webkit.org [Thu, 5 Nov 2009 15:28:37 +0000 (15:28 +0000)]
2009-11-05  Jeff Schiller  <codedread@gmail.com>

        Reviewed by Simon Fraser.

        Added test to ensure proper order of matrix multiplication with SVGMatrix.
        https://bugs.webkit.org/show_bug.cgi?id=16062

        * svg/dom/SVGMatrix-interface-expected.txt: Added.
        * svg/dom/SVGMatrix-interface.xhtml: Added.
2009-11-05  Jeff Schiller  <codedread@gmail.com>

        Reviewed by Simon Fraser.

        Correct order of matrix multiplication for SVGMatrix.
        https://bugs.webkit.org/show_bug.cgi?id=16062

        Test: svg/dom/SVGMatrix-interface.xhtml

        * bindings/js/JSSVGMatrixCustom.cpp:
        (WebCore::JSSVGMatrix::multiply):
        * svg/SVGMatrix.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-04 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 5 Nov 2009 10:06:51 +0000 (10:06 +0000)]
2009-11-04  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Make resource-related records in timeline
        actually take some time.

        https://bugs.webkit.org/show_bug.cgi?id=31139

        * English.lproj/localizedStrings.js:
        * inspector/front-end/TimelinePanel.js:
        (WebInspector.TimelinePanel):
        (WebInspector.TimelinePanel.prototype._formatRecord):
        (WebInspector.TimelinePanel.prototype._getRecordDetails):
        (WebInspector.TimelinePanel.prototype.reset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-05 Priit Laes <plaes@plaes.org>
eric@webkit.org [Thu, 5 Nov 2009 09:51:32 +0000 (09:51 +0000)]
2009-11-05  Priit Laes  <plaes@plaes.org>

        Reviewed by Jan Alonzo.

        [Gtk] Build failure with --enable-introspection
        https://bugs.webkit.org/show_bug.cgi?id=31102

        Add search and include paths for JSCore-1.0.gir required by
        gobject-introspection tools.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-04 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Thu, 5 Nov 2009 09:31:14 +0000 (09:31 +0000)]
2009-11-04  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Darin Fisher.

        Simplify LocalStorageThread
        https://bugs.webkit.org/show_bug.cgi?id=30935

        This is a re-submit of 50519.  LocalStorageTask should have never been ref
        counted.  I've removed that and switched a PassRefPtr over to a PassOwnPtr.

        On LocalStoragethread: Remove reference counting. Get rid of locking. Make some
        of the method names a bit more clear. Assert proper thread usage. Join rather
        than detaching the thread and doing an ad-hoc form of join. Avoid touching
        variables on the background thread when simple to do so.  Also create a generic
        scheduleTask function rather than one for each task.

        No behavior should have changed.

        * storage/LocalStorageTask.h:
        * storage/LocalStorageThread.cpp:
        (WebCore::LocalStorageThread::create):
        (WebCore::LocalStorageThread::LocalStorageThread):
        (WebCore::LocalStorageThread::~LocalStorageThread):
        (WebCore::LocalStorageThread::start):
        (WebCore::LocalStorageThread::threadEntryPointCallback):
        (WebCore::LocalStorageThread::threadEntryPoint):
        (WebCore::LocalStorageThread::scheduleTask):
        (WebCore::LocalStorageThread::terminate):
        (WebCore::LocalStorageThread::performTerminate):
        * storage/LocalStorageThread.h:
        * storage/StorageSyncManager.cpp:
        (WebCore::StorageSyncManager::StorageSyncManager):
        (WebCore::StorageSyncManager::~StorageSyncManager):
        (WebCore::StorageSyncManager::scheduleImport):
        (WebCore::StorageSyncManager::scheduleSync):
        * storage/StorageSyncManager.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-04 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Thu, 5 Nov 2009 08:58:36 +0000 (08:58 +0000)]
2009-11-04  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Darin Fisher.

        Calling databaseIdentifier on LocalStorage's background thread is not safe.
        https://bugs.webkit.org/show_bug.cgi?id=31149

        Calling SecurityOrigin::databaseIdentifier on LocalStorage's background thread
        is not safe.  databaseIdentifier does a bunch of string concatenation which
        ref-counts StringImpls in some cases.  This was caught by valgrind thread
        sanitizer: http://code.google.com/p/chromium/issues/detail?id=25645

        There's no way to test for such racyness, unfortunately.

        * storage/StorageAreaSync.cpp:
        (WebCore::StorageAreaSync::StorageAreaSync):
        (WebCore::StorageAreaSync::performImport):
        * storage/StorageAreaSync.h:
        * storage/StorageSyncManager.cpp:
        (WebCore::StorageSyncManager::fullDatabaseFilename):
        * storage/StorageSyncManager.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoLast Qt 4.5 build fix (*sigh*)
hausmann@webkit.org [Thu, 5 Nov 2009 08:40:52 +0000 (08:40 +0000)]
Last Qt 4.5 build fix (*sigh*)

Patch by Simon Hausmann <hausmann@webkit.org> on 2009-11-05
* tests/qwebpage/tst_qwebpage.cpp:
(inputMethodHints): inputMethodHints() is only used for
Qt 4.6, so guard the whole function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-03 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Thu, 5 Nov 2009 08:36:22 +0000 (08:36 +0000)]
2009-11-03  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Darin Fisher.

        Clean up StorageAreaSync
        https://bugs.webkit.org/show_bug.cgi?id=31100

        Major fixes: Break the ref count cycle for StorageArea on the main
        thread, not the background thread since the latter is not safe.
        Length() needs to block on the import completing.

        Small fixes: setItem needs to handle the copy on write case even if it
        has an exception.  setItem and removeItem should just bail from the
        the function if the value hasn't changed rather than wrapping the end
        in an if block.  Clear should only send an event if it wasn't already
        cleared.  StorageAreaSync should assert that the final sync was
        scheduled.

        * storage/StorageAreaImpl.cpp:
        (WebCore::StorageAreaImpl::length):
          Forgot to block on the import.
        (WebCore::StorageAreaImpl::key):
        (WebCore::StorageAreaImpl::setItem):
          Handle the copy on write case even when there's an exception.
        (WebCore::StorageAreaImpl::removeItem):
        (WebCore::StorageAreaImpl::clear):
        * storage/StorageAreaSync.cpp:
        (WebCore::StorageAreaSync::~StorageAreaSync):
        (WebCore::StorageAreaSync::scheduleFinalSync):
        (WebCore::StorageAreaSync::performImport):
        (WebCore::StorageAreaSync::markImported):
        (WebCore::StorageAreaSync::blockUntilImportComplete):
        * storage/StorageAreaSync.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAnother prospective build fix against Qt 4.5 (build bot)
hausmann@webkit.org [Thu, 5 Nov 2009 08:30:51 +0000 (08:30 +0000)]
Another prospective build fix against Qt 4.5 (build bot)

Patch by Simon Hausmann <hausmann@webkit.org> on 2009-11-05
Don't compile & run the QGraphicsWebView portion of the
input methods auto test with Qt 4.5.

* tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::inputMethods_data):
(inputMethodHints):
(inputMethodEnabled):
(tst_QWebPage::inputMethods):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUse ARMv7 specific encoding for immediate constants on ARMv7 target
zoltan@webkit.org [Thu, 5 Nov 2009 08:28:02 +0000 (08:28 +0000)]
Use ARMv7 specific encoding for immediate constants on ARMv7 target
https://bugs.webkit.org/show_bug.cgi?id=31060

Patch by Gabor Loki <loki@inf.u-szeged.hu> on 2009-11-05
Reviewed by Gavin Barraclough.

* assembler/ARMAssembler.cpp:
(JSC::ARMAssembler::getOp2): Use INVALID_IMM
(JSC::ARMAssembler::getImm): Use encodeComplexImm for complex immediate
(JSC::ARMAssembler::moveImm): Ditto.
(JSC::ARMAssembler::encodeComplexImm): Encode a constant by one or two
instructions or a PC relative load.
* assembler/ARMAssembler.h: Use INVALID_IMM if a constant cannot be
encoded as an immediate constant.
(JSC::ARMAssembler::):
(JSC::ARMAssembler::movw_r): 16-bit immediate load
(JSC::ARMAssembler::movt_r): High halfword 16-bit immediate load
(JSC::ARMAssembler::getImm16Op2): Encode immediate constant for
movw_r and mowt_r

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoProspective build fix against Qt 4.5 (build bot)
hausmann@webkit.org [Thu, 5 Nov 2009 08:23:11 +0000 (08:23 +0000)]
Prospective build fix against Qt 4.5 (build bot)

Patch by Simon Hausmann <hausmann@webkit.org> on 2009-11-05
* Api/qgraphicswebview.cpp:
(QGraphicsWebViewPrivate::setInputMethodEnabled): Guard the
use of Qt 4.6 specific API with #ifdefs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Fix enabling of input method support on QGraphicsWebView.
hausmann@webkit.org [Thu, 5 Nov 2009 08:12:07 +0000 (08:12 +0000)]
[Qt] Fix enabling of input method support on QGraphicsWebView.
https://bugs.webkit.org/show_bug.cgi?id=30605

Patch by Simon Hausmann <hausmann@webkit.org> on 2009-11-01
Reviewed by Kenneth Christiansen.

Instead of setting the unsupported widget attribute on the
QGraphicsWidget in setInputMethodEnabled() set the
ItemAcceptsInputMethod GraphicsItem flag directly.

Changed the existing input method auto test to run once
on a QWebView and once on a QGraphicsWebView.

* Api/qgraphicswebview.cpp:
(QGraphicsWebViewPrivate::setInputMethodEnabled):
* tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::inputMethods_data):
(inputMethodHints):
(inputMethodEnabled):
(tst_QWebPage::inputMethods):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdded QGraphicsWebView::modified property, for consistency
hausmann@webkit.org [Thu, 5 Nov 2009 08:11:48 +0000 (08:11 +0000)]
Added QGraphicsWebView::modified property, for consistency
with QWebView.

Patch by Simon Hausmann <hausmann@webkit.org> on 2009-11-04
Reviewed by Kenneth Christiansen.

* Api/qgraphicswebview.cpp:
(QGraphicsWebView::isModified):
* Api/qgraphicswebview.h:
* tests/qgraphicswebview/tst_qgraphicswebview.cpp:
(tst_QGraphicsWebView::qgraphicswebview):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRemoved status and progress properties of QGraphicsWebView.
hausmann@webkit.org [Thu, 5 Nov 2009 08:11:38 +0000 (08:11 +0000)]
Removed status and progress properties of QGraphicsWebView.
Added loadProgress and statusBarMessage signals instead,
after API review.

Patch by Simon Hausmann <hausmann@webkit.org> on 2009-11-04
Reviewed by Kenneth Christiansen.

* Api/qgraphicswebview.cpp:
(QGraphicsWebViewPrivate::QGraphicsWebViewPrivate):
(QGraphicsWebView::setPage):
* Api/qgraphicswebview.h:
* tests/qgraphicswebview/tst_qgraphicswebview.cpp:
(tst_QGraphicsWebView::qgraphicswebview):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAllow custom memory allocation control for WebCore's CachedResource
zoltan@webkit.org [Thu, 5 Nov 2009 07:53:08 +0000 (07:53 +0000)]
Allow custom memory allocation control for WebCore's CachedResource
https://bugs.webkit.org/show_bug.cgi?id=31114

Reviewed by Eric Seidel.

Inherits CachedResource class from Noncopyable because its (its child
class) CachedCSSStyleSheet instantiated by 'new' in WebCore/loader/Cache.cpp:75
and it is no need to be copyable.

* loader/CachedResource.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-04 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 5 Nov 2009 07:07:00 +0000 (07:07 +0000)]
2009-11-04  Eric Seidel  <eric@webkit.org>

        Reviewed by David Kilzer.

        svn-apply's fixChangeLogPatch function seems broken
        https://bugs.webkit.org/show_bug.cgi?id=30683

        Update fixChangeLogPatch to be able to handle patches which
        don't start at line 1.
        Add unit tests for svn-apply to scm_unittest.py.

        * Scripts/VCSUtils.pm:
        * Scripts/modules/scm_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-04 Mark Mentovai <mark@chromium.org>
eric@webkit.org [Thu, 5 Nov 2009 06:52:19 +0000 (06:52 +0000)]
2009-11-04  Mark Mentovai  <mark@chromium.org>

        Reviewed by Mark Rowe.

        Provide TARGETING_TIGER and TARGETING_LEOPARD as analogues to
        BUILDING_ON_TIGER and BUILDING_ON_LEOPARD.  The TARGETING_ macros
        consider the deployment target; the BUILDING_ON_ macros consider the
        headers being built against.

        * wtf/Platform.h:
2009-11-04  Mark Mentovai  <mark@chromium.org>

        Reviewed by Mark Rowe.

        Separate the difference between HAVE(CGINTERPOLATION_MEDIUM), which
        is true when building on 10.6 or later, and USE(CGINTERPOLATION_MEDIUM)
        which is true when targeting 10.6 or later.

        HAVE(CGINTERPOLATION_MEDIUM) indicates that kCGInterpolationMedium
        is present in the CGInterpolationQuality enum, and must be handled
        by a switch that has cases for each enumerated value.

        USE(CGINTERPOLATION_MEDIUM) indicates that the product will only run
        on 10.6 or later, and that CoreGraphics will understand when
        InterpolationMedium is mapped to kCGInterpolationMedium at runtime.

        * platform/graphics/cg/GraphicsContextCG.cpp:
        (WebCore::GraphicsContext::setImageInterpolationQuality):
        (WebCore::GraphicsContext::imageInterpolationQuality):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-04 Dan Kegel <dank@chromium.org>
eric@webkit.org [Thu, 5 Nov 2009 06:39:41 +0000 (06:39 +0000)]
2009-11-04  Dan Kegel  <dank@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Fix buffer overrun in WebCore::Page::userStyleSheetLocationChanged()
        https://bugs.webkit.org/show_bug.cgi?id=31138

        Test: LayoutTests/platform/mac/fast/loader/user-stylesheet-fast-path.html in Valgrind

        * page/Page.cpp:
        (WebCore::Page::userStyleSheetLocationChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUpdate the Web Inspector Timeline panel to better match the mock-up.
timothy@apple.com [Thu, 5 Nov 2009 06:27:45 +0000 (06:27 +0000)]
Update the Web Inspector Timeline panel to better match the mock-up.

https://bugs.webkit.org/show_bug.cgi?id=31150

Reviewed by Pavel Feldman.

* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._getRecordDetails):
(WebInspector.TimelinePanel.prototype._dragWindow):
(WebInspector.TimelinePanel.prototype._resizeWindowLeft):
(WebInspector.TimelinePanel.prototype._resizeWindowRight):
(WebInspector.TimelineCategoryTreeElement.prototype.onattach):
(WebInspector.TimelineRecordTreeElement.prototype.onattach):
(WebInspector.TimelineRecordTreeElement.prototype.refresh):
(WebInspector.TimelineCategoryGraph):
* inspector/front-end/inspector.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFixed typos.
justin.garcia@apple.com [Thu, 5 Nov 2009 05:33:48 +0000 (05:33 +0000)]
Fixed typos.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
justin.garcia@apple.com [Thu, 5 Nov 2009 05:25:24 +0000 (05:25 +0000)]
WebCore:

2009-11-02  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Adele Peterson.

        https://bugs.webkit.org/show_bug.cgi?id=25439
        Deleting when in front of a block image removes character from previous paragraph

        Added editing/deleting/25439-{1,2,3}.html

        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::mergeParagraphs): Block images, tables and HRs cannot
        be made inline with other content.  Instead of merging, just move the caret to just before
        the selection we deleted.
        * editing/htmlediting.cpp:
        (WebCore::firstInSpecialElement): Added a FIXME.  This function begins iterating up from pos.node(), which
        doesn't necessarily contain pos (suppose pos was [img, 0]).
        (WebCore::lastInSpecialElement): Ditto.
        (WebCore::isRenderedAsNonInlineTableImageOrHR): Moved from visible_units.cpp.  Added a check for non-inline images.
        * editing/htmlediting.h:
        * editing/visible_units.cpp:
        (WebCore::startOfParagraph): Use moved/renamed function.  Removed FIXME.  The problem causing
        5027702 is now squarely in first/lastInSpecialElement
        (WebCore::endOfParagraph): Ditto.

LayoutTests:

2009-11-03  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Adele Peterson.

        https://bugs.webkit.org/show_bug.cgi?id=25439
        Deleting when in front of a block image removes character from previous paragraph

        * editing/deleting/delete-before-block-image-1-expected.txt: Added.
        * editing/deleting/delete-before-block-image-1.html: Added.
        * editing/deleting/delete-before-block-image-2-expected.txt: Added.
        * editing/deleting/delete-before-block-image-2.html: Added.
        * editing/deleting/delete-before-block-table-expected.txt: Added.
        * editing/deleting/delete-before-block-table.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agohttps://bugs.webkit.org/show_bug.cgi?id=31151
barraclough@apple.com [Thu, 5 Nov 2009 05:02:09 +0000 (05:02 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=31151
Fix branchDouble behaviour on ARM THUMB2 JIT.

Patch by Gavin Barraclough <barraclough@apple.com> on 2009-11-04
Reviewed by Oliver Hunt.

The ARMv7 JIT is currently using ARMv7Assembler::ConditionEQ to branch
for DoubleEqualOrUnordered, however this is incorrect – ConditionEQ won't
branch on unordered operands.  Similarly, DoubleLessThanOrUnordered &
DoubleLessThanOrEqualOrUnordered use ARMv7Assembler::ConditionLO &
ARMv7Assembler::ConditionLS, whereas they should be using
ARMv7Assembler::ConditionLT & ARMv7Assembler::ConditionLE.

Fix these, and fill out the missing DoubleConditions.

* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::):
(JSC::MacroAssemblerARMv7::branchDouble):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRubber Stamped by Oliver Hunt.
barraclough@apple.com [Thu, 5 Nov 2009 03:29:28 +0000 (03:29 +0000)]
Rubber Stamped by Oliver Hunt.

Patch by Gavin Barraclough <barraclough@apple.com> on 2009-11-04
Enable native call optimizations on ARMv7.  (Existing ARM_TRADITIONAL
implementation was generic, worked perfectly, just needed turning on).

* jit/JITOpcodes.cpp:
* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRubber Stamped by Mark Rowe, Oliver Hunt, and Sam Weinig.
barraclough@apple.com [Thu, 5 Nov 2009 03:04:39 +0000 (03:04 +0000)]
Rubber Stamped by Mark Rowe, Oliver Hunt, and Sam Weinig.

Patch by Gavin Barraclough <barraclough@apple.com> on 2009-11-04
Add a missing assert to the ARMv7 JIT.

* assembler/ARMv7Assembler.h:
(JSC::ARMThumbImmediate::ARMThumbImmediate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRemove bogus op_ prefix on dumped version of three opcodes.
mrowe@apple.com [Thu, 5 Nov 2009 02:22:12 +0000 (02:22 +0000)]
Remove bogus op_ prefix on dumped version of three opcodes.

Rubber-stamped by Oliver Hunt.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix dumping of constants in bytecode so that they aren't printed as large positive...
mrowe@apple.com [Thu, 5 Nov 2009 02:22:08 +0000 (02:22 +0000)]
Fix dumping of constants in bytecode so that they aren't printed as large positive register numbers.

Reviewed by Sam Weinig.

We do this by having the registerName function return information about the constant if the register
number corresponds to a constant.  This requires that registerName, and several functions that call it,
be converted to member functions of CodeBlock so that the constant value can be retrieved.  The
ExecState also needs to be threaded down through these functions so that it can be passed on to
constantName when needed.

* bytecode/CodeBlock.cpp:
(JSC::constantName):
(JSC::CodeBlock::registerName):
(JSC::CodeBlock::printUnaryOp):
(JSC::CodeBlock::printBinaryOp):
(JSC::CodeBlock::printConditionalJump):
(JSC::CodeBlock::printGetByIdOp):
(JSC::CodeBlock::printPutByIdOp):
(JSC::CodeBlock::dump):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::isConstantRegisterIndex):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore: Hang in Mail on attempting to change indent level.
enrica@apple.com [Thu, 5 Nov 2009 01:42:25 +0000 (01:42 +0000)]
WebCore: Hang in Mail on attempting to change indent level.
<rdar://problem/7131805>
https://bugs.webkit.org/show_bug.cgi?id=31127

Reviewed by Adele Peterson.

The hang was caused by an infinite loop inside outdentRegion.
The code did not account for the fact that, when a list item
cointains multiple paragraphs, outdent moves all paragraphs at
once, invalidating some of the position we keep track of in the loop.
Some code refactoring has also been done to minimize duplicate code.

Test: editing/execCommand/outdent-multiparagraph-list.html

* editing/IndentOutdentCommand.cpp:
(WebCore::IndentOutdentCommand::indentRegion): Moved code in common with
outdentRegion to doApply.
(WebCore::IndentOutdentCommand::outdentRegion): Fixed endless loop.
(WebCore::IndentOutdentCommand::doApply): Some code refactoring.
* editing/IndentOutdentCommand.h: Added VisiblePosition parameters to
indentRegion and outdentRegion.

LayoutTests: Hang in Mail on attempting to change indent level
<rdar://problem/7131805>
https://bugs.webkit.org/show_bug.cgi?id=31127

Reviewed by Adele Peterson.

Added test to cover all the different code paths.

* editing/execCommand/outdent-multiparagraph-list-expected.txt: Added.
* editing/execCommand/outdent-multiparagraph-list.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-04 Alpha Lam <hclam@chromium.org>
eric@webkit.org [Thu, 5 Nov 2009 00:50:59 +0000 (00:50 +0000)]
2009-11-04  Alpha Lam  <hclam@chromium.org>

        Reviewed by Eric Carlson.

        Volume slider doesn't have a thumb
        https://bugs.webkit.org/show_bug.cgi?id=31135

        Fixed an incorrect if statement that prevents volume slider
        being updated.

        The statement checks if the slider value equals to the current
        volume value of the media control to avoid updating the volume
        slider. Updating the volume slider control shouldn't be within
        this condition because we explicitly set them to be equals
        during creation of the controls and also when mouse events are
        received on the volume control.

        No new tests because existing code breaks:
        LayoutTests/media/video-volume-slider.html

        It should now start passing on Chromium.

        * rendering/MediaControlElements.cpp:
        (WebCore::MediaControlVolumeSliderElement::update):
        Update the volume slider regardless of the current volume value
        of the media control.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoNeed to properly disable applicationCache at runtime
levin@chromium.org [Thu, 5 Nov 2009 00:35:27 +0000 (00:35 +0000)]
Need to properly disable applicationCache at runtime
https://bugs.webkit.org/show_bug.cgi?id=30417

Patch by Jenn Braithwaite <jennb@chromium.org> on 2009-11-04
Reviewed by David Levin.

Adding applicationCacheEnabled bit to V8 RuntimeEnabledFeatures.

No new exposed functionality, so no new tests.

* bindings/v8/RuntimeEnabledFeatures.cpp:
* bindings/v8/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setApplicationCacheEnabled):
(WebCore::RuntimeEnabledFeatures::applicationCacheEnabled):
* bindings/v8/custom/V8CustomBinding.h:
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::ACCESSOR_RUNTIME_ENABLER):
* page/DOMWindow.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-04 Pavel Heimlich <tropikhajma@gmail.com>
ap@apple.com [Thu, 5 Nov 2009 00:12:21 +0000 (00:12 +0000)]
2009-11-04  Pavel Heimlich  <tropikhajma@gmail.com>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=30647
        Solaris build failure due to strnstr.

        * wtf/StringExtras.h: Enable strnstr on Solaris, too.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-04 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Wed, 4 Nov 2009 23:59:15 +0000 (23:59 +0000)]
2009-11-04  Daniel Bates  <dbates@webkit.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=30266

        Changed data format type from "text" to "text/plain" to pass Chrome tests.

        * fast/events/drag-and-drop-dataTransfer-types-nocrash-expected.txt:
        * fast/events/drag-and-drop-dataTransfer-types-nocrash.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agohttps://bugs.webkit.org/show_bug.cgi?id=31104
barraclough@apple.com [Wed, 4 Nov 2009 23:59:14 +0000 (23:59 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=31104
Refactor x86-specific behaviour out of the JIT.

Patch by Gavin Barraclough <barraclough@apple.com> on 2009-11-04
Reviewed by Oliver Hunt.

- Add explicit double branch conditions for ordered and unordered comparisons (presently the brehaviour is a mix).
- Refactor double to int conversion out into the MacroAssembler.
- Remove broken double to int conversion for !JSVALUE32_64 builds - this code was broken and slowing us down, fixing it showed it not to be an improvement.
- Remove exclusion of double to int conversion from (1 % X) cases in JSVALUE32_64 builds - if this was of benefit this is no longer the case; simplify.

* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::):
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::):
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::):
(JSC::MacroAssemblerX86Common::convertInt32ToDouble):
(JSC::MacroAssemblerX86Common::branchDouble):
(JSC::MacroAssemblerX86Common::branchConvertDoubleToInt32):
* jit/JITArithmetic.cpp:
(JSC::JIT::emitBinaryDoubleOp):
(JSC::JIT::emit_op_div):
(JSC::JIT::emitSlow_op_jnless):
(JSC::JIT::emitSlow_op_jnlesseq):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_jfalse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Dan Bernstein.
ap@apple.com [Wed, 4 Nov 2009 23:48:08 +0000 (23:48 +0000)]
    Reviewed by Dan Bernstein.

        https://bugs.webkit.org/show_bug.cgi?id=31143
        Assertion failure in CredentialStorage::set() when proxy credentials are being set

        No test, cannot test proxy behavior.

        * platform/network/CredentialStorage.cpp: (WebCore::CredentialStorage::set): Account for the
        possibility of null url. Release mode changes are likely inconsequential - e.g. we used to
        add "://" to origin set, which is weird, but safe.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-04 Patrick Mueller <Patrick_Mueller@us.ibm.com>
eric@webkit.org [Wed, 4 Nov 2009 22:21:53 +0000 (22:21 +0000)]
2009-11-04  Patrick Mueller  <Patrick_Mueller@us.ibm.com>

        Reviewed by Timothy Hatcher.

        Web Inspector: Leftover Breakpoints in the Sidebar Pane
        https://bugs.webkit.org/show_bug.cgi?id=30659

        No new tests.

        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype.addScript):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-04 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
eric@webkit.org [Wed, 4 Nov 2009 21:44:01 +0000 (21:44 +0000)]
2009-11-04  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>

        Reviewed by Timothy Hatcher.

        WebInspector: Use a different method to identify the webkit port in
        InspectorBackent::platform().
        This corrects the inspector expected behavior with Qt on Windows.
        https://bugs.webkit.org/show_bug.cgi?id=31116

        * inspector/InspectorBackend.cpp:
        (WebCore::InspectorBackend::platform):
        (WebCore::InspectorBackend::port):
        * inspector/InspectorBackend.h:
        * inspector/InspectorBackend.idl:
        * inspector/front-end/InspectorControllerStub.js:
        (.WebInspector.InspectorControllerStub.prototype.port):
        * inspector/front-end/inspector.css:
        * inspector/front-end/inspector.js:
        (WebInspector.loaded):
        (WebInspector.toolbarDragStart):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-04 Benjamin Otte <otte@gnome.org>
eric@webkit.org [Wed, 4 Nov 2009 21:00:11 +0000 (21:00 +0000)]
2009-11-04  Benjamin Otte  <otte@gnome.org>

        Reviewed by Gustavo Noronha.

        Update Cairo requirement to 1.6.

        https://bugs.webkit.org/show_bug.cgi?id=19266

        * configure.ac:
2009-11-04  Benjamin Otte  <otte@gnome.org>

        Reviewed by Gustavo Noronha.

        Update Cairo requirement to 1.6.

        Also remove all conditional code and workarounds for older versions of
        Cairo.
        In particular, gain image quality by removing the use of
        CAIRO_FILTER_NEAREST when rendering images and use the default
        bilinear filter instead.
        https://bugs.webkit.org/show_bug.cgi?id=19266

        * platform/graphics/cairo/GraphicsContextCairo.cpp:
        (WebCore::GraphicsContext::clipOut):
        * platform/graphics/cairo/ImageCairo.cpp:
        (WebCore::BitmapImage::draw):
        (WebCore::BitmapImage::drawPattern):
        * platform/graphics/cairo/PathCairo.cpp:
        (WebCore::Path::isEmpty):
        (WebCore::Path::boundingRect):
        * platform/gtk/RenderThemeGtk.cpp:
        (WebCore::paintMozWidget):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agowx build fix. Restore removed string conversion after cleanup.
kevino@webkit.org [Wed, 4 Nov 2009 20:46:29 +0000 (20:46 +0000)]
wx build fix. Restore removed string conversion after cleanup.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-04 Chris Fleizach <cfleizach@apple.com>
eric@webkit.org [Wed, 4 Nov 2009 20:22:13 +0000 (20:22 +0000)]
2009-11-04  Chris Fleizach  <cfleizach@apple.com>

        Reviewed by Beth Dakin.

        Need to implement ARIA role="combobox"
        https://bugs.webkit.org/show_bug.cgi?id=31096

        * accessibility/aria-combobox.html: Added.
        * platform/gtk/Skipped:
        * platform/mac/accessibility/aria-combobox-expected.txt: Added.
        * platform/win/Skipped:
2009-11-04  Chris Fleizach  <cfleizach@apple.com>

        Reviewed by Beth Dakin.

        Need to implement ARIA role="combobox"
        https://bugs.webkit.org/show_bug.cgi?id=31096

        Test: accessibility/aria-combobox.html

        * accessibility/AccessibilityObject.h:
        (WebCore::AccessibilityObject::isComboBox):
        (WebCore::AccessibilityObject::isExpanded):
        (WebCore::AccessibilityObject::expandObject):
        (WebCore::AccessibilityObject::increment):
        (WebCore::AccessibilityObject::decrement):
        * accessibility/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::expandObject):
        (WebCore::AccessibilityRenderObject::isExpanded):
        (WebCore::createARIARoleMap):
        * accessibility/AccessibilityRenderObject.h:
        * accessibility/mac/AccessibilityObjectWrapper.mm:
        (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
        (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
        (-[AccessibilityObjectWrapper accessibilityPerformShowMenuAction]):
        * html/HTMLAttributeNames.in:
2009-11-04  Chris Fleizach  <cfleizach@apple.com>

        Reviewed by Beth Dakin.

        Need to implement ARIA role="combobox"
        https://bugs.webkit.org/show_bug.cgi?id=31096

        * DumpRenderTree/AccessibilityUIElement.cpp:
        (showMenuCallback):
        (getIsExpandedCallback):
        (AccessibilityUIElement::getJSClass):
        * DumpRenderTree/AccessibilityUIElement.h:
        * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
        (AccessibilityUIElement::isExpanded):
        (AccessibilityUIElement::showMenu):
        * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
        (AccessibilityUIElement::isExpanded):
        (AccessibilityUIElement::showMenu):
        * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
        (AccessibilityUIElement::isSelected):
        (AccessibilityUIElement::isExpanded):
        (AccessibilityUIElement::showMenu):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-04 Kelly Norton <knorton@google.com>
eric@webkit.org [Wed, 4 Nov 2009 20:12:12 +0000 (20:12 +0000)]
2009-11-04  Kelly Norton  <knorton@google.com>

        Reviewed by Pavel Feldman.

        Fixes naming inconsistencies in TimelineRecordFactory.
        https://bugs.webkit.org/show_bug.cgi?id=31132

        * inspector/InspectorTimelineAgent.cpp:
        (WebCore::InspectorTimelineAgent::willPaint):
        (WebCore::InspectorTimelineAgent::willChangeXHRReadyState):
        (WebCore::InspectorTimelineAgent::willLoadXHR):
        (WebCore::InspectorTimelineAgent::willEvaluateScript):
        (WebCore::InspectorTimelineAgent::willSendResourceRequest):
        (WebCore::InspectorTimelineAgent::didReceiveResourceResponse):
        (WebCore::InspectorTimelineAgent::didFinishLoadingResource):
        * inspector/TimelineRecordFactory.cpp:
        (WebCore::TimelineRecordFactory::createXHRReadyStateChangeRecord):
        (WebCore::TimelineRecordFactory::createXHRLoadRecord):
        (WebCore::TimelineRecordFactory::createEvaluateScriptRecord):
        (WebCore::TimelineRecordFactory::createMarkTimelineRecord):
        (WebCore::TimelineRecordFactory::createResourceSendRequestRecord):
        (WebCore::TimelineRecordFactory::createResourceReceiveResponseRecord):
        (WebCore::TimelineRecordFactory::createResourceFinishRecord):
        (WebCore::TimelineRecordFactory::createPaintRecord):
        * inspector/TimelineRecordFactory.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-04 Eric Z. Ayers <zundel@google.com>
eric@webkit.org [Wed, 4 Nov 2009 20:04:16 +0000 (20:04 +0000)]
2009-11-04  Eric Z. Ayers  <zundel@google.com>

        Reviewed by Pavel Feldman.

        Followon to bug 31080, which protects Timeline
        instrumentation in the case where InspectorTimelineAgent
        is enabled or disabled during an event dispatch.

        https://bugs.webkit.org/show_bug.cgi?id=31121

        * bindings/v8/V8Proxy.cpp:
        (WebCore::V8Proxy::evaluate):
        * dom/Document.cpp:
        (WebCore::Document::recalcStyle):
        * dom/Node.cpp:
        (WebCore::Node::dispatchGenericEvent):
        * html/HTMLTokenizer.cpp:
        (WebCore::HTMLTokenizer::write):
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::inspectorTimelineAgent):
        (WebCore::DOMWindow::dispatchEvent):
        * page/DOMWindow.h:
        * page/FrameView.cpp:
        (WebCore::FrameView::layout):
        (WebCore::FrameView::paintContents):
        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::callReadyStateChangeListener):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoReviewed by Kevin Ollivier.
kevino@webkit.org [Wed, 4 Nov 2009 19:55:54 +0000 (19:55 +0000)]
Reviewed by Kevin Ollivier.

Fix an assert on shutdown when wxWebView has captured the mouse,
and make sure wxWebView's right click handling is only active when
the WebCore popup menu is used.

https://bugs.webkit.org/show_bug.cgi?id=31131

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRevert 50519 while I work out what went wrong.
jorlow@chromium.org [Wed, 4 Nov 2009 19:35:04 +0000 (19:35 +0000)]
Revert 50519 while I work out what went wrong.

Patch by Jeremy Orlow <jorlow@chromium.org> on 2009-11-04
* storage/LocalStorageThread.cpp:
(WebCore::LocalStorageThread::create):
(WebCore::LocalStorageThread::LocalStorageThread):
(WebCore::LocalStorageThread::start):
(WebCore::LocalStorageThread::localStorageThreadStart):
(WebCore::LocalStorageThread::localStorageThread):
(WebCore::LocalStorageThread::scheduleImport):
(WebCore::LocalStorageThread::scheduleSync):
(WebCore::LocalStorageThread::terminate):
(WebCore::LocalStorageThread::performTerminate):
* storage/LocalStorageThread.h:
* storage/StorageSyncManager.cpp:
(WebCore::StorageSyncManager::StorageSyncManager):
(WebCore::StorageSyncManager::~StorageSyncManager):
(WebCore::StorageSyncManager::scheduleImport):
(WebCore::StorageSyncManager::scheduleSync):
* storage/StorageSyncManager.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-04 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Wed, 4 Nov 2009 19:32:05 +0000 (19:32 +0000)]
2009-11-04  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Add basic support for resource events and marks.
        Couple of drive-by fixes. Enabling the panel!

        https://bugs.webkit.org/show_bug.cgi?id=31130

        * English.lproj/localizedStrings.js:
        * inspector/front-end/TimelinePanel.js:
        (WebInspector.TimelinePanel):
        (WebInspector.TimelinePanel.prototype._formatRecord):
        (WebInspector.TimelinePanel.prototype._getRecordDetails):
        (WebInspector.TimelinePanel.prototype.reset):
        (WebInspector.TimelineCategoryTreeElement.prototype._onCheckboxClicked):
        (WebInspector.TimelineRecordTreeElement.prototype.onattach):
        * inspector/front-end/inspector.js:
        (WebInspector._createPanels):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-03 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Wed, 4 Nov 2009 19:11:24 +0000 (19:11 +0000)]
2009-11-03  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Darin Fisher.

        Simplify LocalStorageThread
        https://bugs.webkit.org/show_bug.cgi?id=30935

        On LocalStoragethread: Remove reference counting. Get rid of locking. Make some
        of the method names a bit more clear. Assert proper thread usage. Join rather
        than detaching the thread and doing an ad-hoc form of join. Avoid touching
        variables on the background thread when simple to do so.  Also create a generic
        scheduleTask function rather than one for each task.

        No behavior should have changed.

        * storage/LocalStorageThread.cpp:
        (WebCore::LocalStorageThread::create):
        (WebCore::LocalStorageThread::LocalStorageThread):
        (WebCore::LocalStorageThread::~LocalStorageThread):
        (WebCore::LocalStorageThread::start):
        (WebCore::LocalStorageThread::threadEntryPointCallback):
        (WebCore::LocalStorageThread::threadEntryPoint):
        (WebCore::LocalStorageThread::scheduleTask):
        (WebCore::LocalStorageThread::terminate):
        (WebCore::LocalStorageThread::performTerminate):
        * storage/LocalStorageThread.h:
        * storage/StorageSyncManager.cpp:
        (WebCore::StorageSyncManager::StorageSyncManager):
        (WebCore::StorageSyncManager::~StorageSyncManager):
        (WebCore::StorageSyncManager::scheduleImport):
        (WebCore::StorageSyncManager::scheduleSync):
        * storage/StorageSyncManager.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-04 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 4 Nov 2009 18:28:39 +0000 (18:28 +0000)]
2009-11-04  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        commit-queue is crashing when trying to reject patches after unknown failures
        https://bugs.webkit.org/show_bug.cgi?id=31091

        * Scripts/bugzilla-tool:
         - patch['id'] was a copy/paste mistake.  This code has no 'patch' variable
           so we have to find out what the current patch is by asking bugzilla again.
         - Discovered that this code was also leaking file descriptors, so fixed that.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-04 Mark Mentovai <mark@chromium.org>
eric@webkit.org [Wed, 4 Nov 2009 18:21:18 +0000 (18:21 +0000)]
2009-11-04  Mark Mentovai  <mark@chromium.org>

        Reviewed by Eric Seidel.

        Remove BUILDING_ON_LEOPARD from JavaScriptCore.gyp.  This is supposed
        to be set as needed only in wtf/Platform.h.

        * JavaScriptCore.gyp/JavaScriptCore.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-04 Vadim Zeitlin <vadim@wxwidgets.org>
eric@webkit.org [Wed, 4 Nov 2009 18:13:57 +0000 (18:13 +0000)]
2009-11-04  Vadim Zeitlin  <vadim@wxwidgets.org>

        Reviewed by Eric Seidel.

        [wx] Small cleanup: avoid unnecessary wxString::mb_str() calls.

        * platform/graphics/wx/FontPlatformDataWx.cpp:
        (WebCore::FontPlatformData::computeHash):
2009-11-04  Vadim Zeitlin  <vadim@wxwidgets.org>

        Reviewed by Eric Seidel.

        [wx] Small cleanup: avoid unnecessary wxString::mb_str() calls.

        * WebFrame.cpp:
        (wxWebFrame::SetPageSource):
        (wxWebFrame::LoadURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-04 Kelly Norton <knorton@google.com>
eric@webkit.org [Wed, 4 Nov 2009 17:17:14 +0000 (17:17 +0000)]
2009-11-04  Kelly Norton  <knorton@google.com>

        Reviewed by Pavel Feldman.

        Adds lightweight network resources to InspectorTimelineAgent.
        https://bugs.webkit.org/show_bug.cgi?id=31065

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::willSendRequest):
        (WebCore::InspectorController::didReceiveResponse):
        (WebCore::InspectorController::didFinishLoading):
        (WebCore::InspectorController::didFailLoading):
        * inspector/InspectorTimelineAgent.cpp:
        (WebCore::InspectorTimelineAgent::willSendResourceRequest):
        (WebCore::InspectorTimelineAgent::didReceiveResourceResponse):
        (WebCore::InspectorTimelineAgent::didFinishLoadingResource):
        * inspector/InspectorTimelineAgent.h:
        (WebCore::):
        * inspector/TimelineRecordFactory.cpp:
        (WebCore::TimelineRecordFactory::createResourceSendRequestTimelineRecord):
        (WebCore::TimelineRecordFactory::createResourceReceiveResponseTimelineRecord):
        (WebCore::TimelineRecordFactory::createResourceFinishTimelineRecord):
        * inspector/TimelineRecordFactory.h:
        * inspector/front-end/TimelineAgent.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-04 Yael Aharon <yael.aharon@nokia.com>
eric@webkit.org [Wed, 4 Nov 2009 17:08:54 +0000 (17:08 +0000)]
2009-11-04  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Tor Arne Vestbø.

        [Qt] ASSERT failure when receiving 401 HTTP Authentication response.
        https://bugs.webkit.org/show_bug.cgi?id=31077

        Allow sending the response body under the same conditions that we
        allow it to finish without reporting an error.

        * platform/network/qt/QNetworkReplyHandler.cpp:
        (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMake run-webkit-tests work for the Debug_Internal Windows configuration
aroben@apple.com [Wed, 4 Nov 2009 16:58:55 +0000 (16:58 +0000)]
Make run-webkit-tests work for the Debug_Internal Windows configuration

In Debug_Internal, DumpRenderTree.exe and ImageDiff.exe have no _debug
suffix.

Fixes <http://webkit.org/b/31123>.

Reviewed by Sam Weinig.

* Scripts/run-webkit-tests: Don't add the _debug suffix in
Debug_Internal, either.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSort WebCore.base.exp
aroben@apple.com [Wed, 4 Nov 2009 16:13:27 +0000 (16:13 +0000)]
Sort WebCore.base.exp

Rubber-stamped by Dan Bernstein.

* WebCore.base.exp: Sorted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoPut test into skiplist added in r50489 because
ossy@webkit.org [Wed, 4 Nov 2009 12:12:13 +0000 (12:12 +0000)]
Put test into skiplist added in r50489 because
layoutTestController.showWebInspector() is unimplemented now.

Patch by Csaba Osztrogonác <ossy@webkit.org> on 2009-11-04
* platform/qt/Skipped: inspector/timeline-trivial.html added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed rollout.
ossy@webkit.org [Wed, 4 Nov 2009 11:27:21 +0000 (11:27 +0000)]
Unreviewed rollout.

Patch by Csaba Osztrogonác <ossy@webkit.org> on 2009-11-04
Revert r50496 because it broke all layout tests on QtBuildBot.

WebCore:

* WebCore.pro:
* platform/graphics/qt/FontCacheQt.cpp:
(WebCore::fontCache):
(WebCore::FontCache::FontCache):
(WebCore::FontCache::getTraitsInFamily):
(WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey):
(WebCore::FontPlatformDataCacheKey::isHashTableDeletedValue):
(WebCore::FontPlatformDataCacheKey::):
(WebCore::FontPlatformDataCacheKey::operator==):
(WebCore::FontPlatformDataCacheKey::hash):
(WebCore::FontPlatformDataCacheKey::computeHash):
(WebCore::FontPlatformDataCacheKey::hashTableDeletedSize):
(WebCore::FontPlatformDataCacheKeyHash::hash):
(WebCore::FontPlatformDataCacheKeyHash::equal):
(WebCore::FontPlatformDataCacheKeyTraits::emptyValue):
(WebCore::FontPlatformDataCacheKeyTraits::constructDeletedValue):
(WebCore::FontPlatformDataCacheKeyTraits::isDeletedValue):
(WebCore::FontCache::getCachedFontPlatformData):
(WebCore::FontCache::getCachedFontData):
(WebCore::FontCache::getLastResortFallbackFont):
(WebCore::FontCache::releaseFontData):
(WebCore::FontCache::purgeInactiveFontData):
(WebCore::FontCache::addClient):
(WebCore::FontCache::removeClient):
(WebCore::FontCache::invalidate):
* platform/graphics/qt/FontFallbackListQt.cpp: Added.
(WebCore::FontFallbackList::FontFallbackList):
(WebCore::FontFallbackList::invalidate):
(WebCore::FontFallbackList::releaseFontData):
(WebCore::FontFallbackList::determinePitch):
(WebCore::FontFallbackList::fontDataAt):
(WebCore::FontFallbackList::fontDataForCharacters):
(WebCore::FontFallbackList::setPlatformFont):
* platform/graphics/qt/FontPlatformData.h:
(WebCore::FontPlatformData::pixelSize):
* platform/graphics/qt/FontPlatformDataQt.cpp:
(WebCore::FontPlatformData::FontPlatformData):

LayoutTests:

* svg/text/resources: Removed.
* svg/text/resources/text-font-invalid.svg: Removed.
* svg/text/text-font-invalid-expected.txt: Removed.
* svg/text/text-font-invalid.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-04 Joanmarie Diggs <joanmarie.diggs@gmail.com>
eric@webkit.org [Wed, 4 Nov 2009 10:35:56 +0000 (10:35 +0000)]
2009-11-04  Joanmarie Diggs  <joanmarie.diggs@gmail.com>

        Reviewed by Jan Alonzo.

        https://bugs.webkit.org/show_bug.cgi?id=31044
        [Gtk] assertion when webkit_accessible_get_index_in_parent attempts to get parent of the web view

        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
        (atkParentOfWebView):
        (webkit_accessible_get_index_in_parent):
        (webkit_accessible_get_parent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-04 Dominik Röttsches <dominik.roettsches@access-company.com>
eric@webkit.org [Wed, 4 Nov 2009 10:28:01 +0000 (10:28 +0000)]
2009-11-04  Dominik Röttsches  <dominik.roettsches@access-company.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=15914
        [GTK] Implement Unicode functionality using GLib

        Initial version of this patch by Jürg Billeter and Naiem Shaik.
        Patch 2/4 - Moving TextCodecs to GLib

        Added probing for a hard-coded lists of text encodings.
        The basis of this list is taken from the encodings supported by iconv,
        then extended by e.g. tis-620, windows-1251, euc-kr, windows-1253 and
        a number of Chinese ones.

        Probing is necessary with the current design of text codecs
        as iconv/GLib do not support enumerating available encodings.

        * GNUmakefile.am:
        * platform/ThreadGlobalData.cpp:
        (WebCore::ThreadGlobalData::ThreadGlobalData):
        (WebCore::ThreadGlobalData::~ThreadGlobalData):
        * platform/text/TextEncoding.cpp:
        (WebCore::TextEncoding::encode):
        * platform/text/TextEncodingRegistry.cpp:
        (WebCore::buildBaseTextCodecMaps):
        (WebCore::extendTextCodecMaps):
        * platform/text/gtk/TextCodecGtk.cpp: Added.
        (WebCore::):
        (WebCore::newTextCodecGtk):
        (WebCore::TextCodecGtk::isEncodingAvailable):
        (WebCore::TextCodecGtk::registerEncodingNames):
        (WebCore::TextCodecGtk::registerCodecs):
        (WebCore::TextCodecGtk::registerBaseEncodingNames):
        (WebCore::TextCodecGtk::registerBaseCodecs):
        (WebCore::TextCodecGtk::registerExtendedEncodingNames):
        (WebCore::TextCodecGtk::registerExtendedCodecs):
        (WebCore::TextCodecGtk::TextCodecGtk):
        (WebCore::TextCodecGtk::~TextCodecGtk):
        (WebCore::TextCodecGtk::releaseIConv):
        (WebCore::TextCodecGtk::createIConvDecoder):
        (WebCore::TextCodecGtk::createIConvEncoder):
        (WebCore::TextCodecGtk::decode):
        (WebCore::TextCodecGtk::encode):
        * platform/text/gtk/TextCodecGtk.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-04 Martin Robinson <martin.james.robinson@gmail.com>
eric@webkit.org [Wed, 4 Nov 2009 10:19:39 +0000 (10:19 +0000)]
2009-11-04  Martin Robinson  <martin.james.robinson@gmail.com>

        Reviewed by Jan Alonzo.

        [GTK] Enable DOM clipboard and drag-and-drop access
        https://bugs.webkit.org/show_bug.cgi?id=30623

        Unify redudant methods which will always return the same value.

        * platform/gtk/PasteboardGtk.cpp:
        (WebCore::Pasteboard::writeSelection):
        * platform/gtk/PasteboardHelper.h:
2009-11-04  Martin Robinson  <martin.james.robinson@gmail.com>

        Reviewed by Jan Alonzo.

        [GTK] Enable DOM clipboard and drag-and-drop access
        https://bugs.webkit.org/show_bug.cgi?id=30623

        Move handling of target list to PasteboardHelperGtk.

        * WebCoreSupport/PasteboardHelperGtk.cpp:
        (WebKit::PasteboardHelperGtk::PasteboardHelperGtk):
        (WebKit::PasteboardHelperGtk::~PasteboardHelperGtk):
        (WebKit::PasteboardHelperGtk::fullTargetList):
        * WebCoreSupport/PasteboardHelperGtk.h:
        * webkit/webkitprivate.cpp:
        (WebKit::pasteboardHelperInstance):
        (webkit_init):
        * webkit/webkitprivate.h:
        * webkit/webkitwebview.cpp:
        (webkit_web_view_dispose):
        (webkit_web_view_init):
        (webkit_web_view_get_copy_target_list):
        (webkit_web_view_get_paste_target_list):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-04 Joanmarie Diggs <joanmarie.diggs@gmail.com>
eric@webkit.org [Wed, 4 Nov 2009 09:31:06 +0000 (09:31 +0000)]
2009-11-04  Joanmarie Diggs  <joanmarie.diggs@gmail.com>

        Reviewed by Jan Alonzo.

        https://bugs.webkit.org/show_bug.cgi?id=31035
        [GTK] some accessibility tests hitting assertion in debug builds

        Removes the assertions in webkit_accessible_ref_child; adds sanity checks.
        Any app or AT can attempt to ref a child at a bogus index.

        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
        (webkit_accessible_ref_child):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-04 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 4 Nov 2009 09:15:56 +0000 (09:15 +0000)]
2009-11-04  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        committers.py needs a way to store non-bugzilla email addresses
        https://bugs.webkit.org/show_bug.cgi?id=31037

        Make Committer and Reviewer constructors take a single email or a list of emails.
        Change committer_by_bugzilla_email functions to committer_by_email to support lookup by any email.
        Expose reviewers(), used by validate-committer-lists on bug 30970.

        * Scripts/modules/committers.py:
        * Scripts/modules/committers_unittest.py: Added tests for the new code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-04 Benjamin Otte <otte@gnome.org>
eric@webkit.org [Wed, 4 Nov 2009 08:58:09 +0000 (08:58 +0000)]
2009-11-04  Benjamin Otte  <otte@gnome.org>

        Reviewed by Jan Alonzo.

        [gtk] Use gst_element_class_set_details_simple()

        Cosmetic change, just code simplification

        * platform/graphics/gtk/VideoSinkGStreamer.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-04 Yael Aharon <yael.aharon@nokia.com>
eric@webkit.org [Wed, 4 Nov 2009 08:50:20 +0000 (08:50 +0000)]
2009-11-04  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] REGRESSION: Allow applications to use their own QWidget bypassing QWebView.
        https://bugs.webkit.org/show_bug.cgi?id=30979

        Decouple QWebViewPrivate from QWebPageClient, and automatically create
        QWebPageWidgetClient whenever the view is QWidget based.

        * Api/qwebpage.cpp:
        (QWebPageWidgetClient::QWebPageWidgetClient):
        (QWebPageWidgetClient::scroll):
        (QWebPageWidgetClient::update):
        (QWebPageWidgetClient::setInputMethodEnabled):
        (QWebPageWidgetClient::setInputMethodHint):
        (QWebPageWidgetClient::cursor):
        (QWebPageWidgetClient::updateCursor):
        (QWebPageWidgetClient::palette):
        (QWebPageWidgetClient::screenNumber):
        (QWebPageWidgetClient::ownerWidget):
        (QWebPageWidgetClient::pluginParent):
        (QWebPage::setView):
        * Api/qwebview.cpp:
        (QWebView::~QWebView):
        (QWebView::setPage):
        (QWebView::event):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-04 Kelly Norton <knorton@google.com>
eric@webkit.org [Wed, 4 Nov 2009 08:42:44 +0000 (08:42 +0000)]
2009-11-04  Kelly Norton  <knorton@google.com>

        Reviewed by Timothy Hatcher.

        Adds paint rectangle information to TimelineAgent's didPaint callback.
        https://bugs.webkit.org/show_bug.cgi?id=31087

        * inspector/InspectorTimelineAgent.cpp:
        (WebCore::InspectorTimelineAgent::willPaint):
        * inspector/InspectorTimelineAgent.h:
        * inspector/TimelineRecordFactory.cpp:
        (WebCore::TimelineRecordFactory::createPaintTimelineRecord):
        * inspector/TimelineRecordFactory.h:
        * page/FrameView.cpp:
        (WebCore::FrameView::paintContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-04 Jaime Yap <jaimeyap@google.com>
eric@webkit.org [Wed, 4 Nov 2009 08:33:46 +0000 (08:33 +0000)]
2009-11-04  Jaime Yap  <jaimeyap@google.com>

        Reviewed by Timothy Hatcher.

        This patch adds API to the console object for annotating the
        inspector timeline. This allows developers to mark logical
        checkpoints in their apps and have them overlaid in the event
        record tree.

        tests updated: LayoutTests/fast/dom/Window/window-properties.html
        https://bugs.webkit.org/show_bug.cgi?id=31082

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::markTimeline):
        * inspector/InspectorController.h:
        * inspector/InspectorTimelineAgent.cpp:
        (WebCore::InspectorTimelineAgent::didMarkTimeline):
        * inspector/InspectorTimelineAgent.h:
        (WebCore::):
        * inspector/TimelineRecordFactory.cpp:
        (WebCore::TimelineRecordFactory::createMarkTimelineRecord):
        * inspector/TimelineRecordFactory.h:
        * inspector/front-end/TimelineAgent.js:
        * page/Console.cpp:
        (WebCore::Console::markTimeline):
        * page/Console.h:
        * page/Console.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-03 Yuzo Fujishima <yuzo@google.com>
ukai@chromium.org [Wed, 4 Nov 2009 07:50:08 +0000 (07:50 +0000)]
2009-11-03  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by David Levin.

        Start/Stop Web Socket and Web Socket Secure servers for layout tests.
        https://bugs.webkit.org/show_bug.cgi?id=27491

        The test path determination logic is changed to handle websocket and websocket/ssl cases.
        The logic for non-http (and now also non-websocket) tests is moved toward the end of the if-elsif statement.

        Functions to start or stop Web Socket servers are added.

        * Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed build fix for WebInspector with Qt build.
hausmann@webkit.org [Wed, 4 Nov 2009 06:09:04 +0000 (06:09 +0000)]
Unreviewed build fix for WebInspector with Qt build.

Patch by Simon Hausmann <hausmann@webkit.org> on 2009-11-03
Simply re-generate the Qt resource file by running
WebKitTools/Scripts/generate-qt-inspector-resource

* inspector/front-end/WebKit.qrc:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago(on IRC)
rolandsteiner@chromium.org [Wed, 4 Nov 2009 05:52:39 +0000 (05:52 +0000)]
(on IRC)

Reviewed by Mark Rowe.

add ruby layout tests to the Skipped list on mac, since they somehow cause
http/tests/security/mixedContent/about-blank-iframe-in-main-frame.html to fail.

no new tests.

* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSet the MIME type for all PNG files in this directory.
darin@apple.com [Wed, 4 Nov 2009 04:29:09 +0000 (04:29 +0000)]
Set the MIME type for all PNG files in this directory.

WebKitSite:

Patch by Darin Adler <darin@apple.com> on 2009-11-03
* blog-files/3d-transforms/mighty-cubes.png: Added property svn:mime-type.
* blog-files/3d-transforms/poster-circle.png: Added property svn:mime-type.
* blog-files/InspectorDatabaseBrowser.png: Modified property svn:mime-type.
* blog-files/acid3-100.png: Modified property svn:mime-type.
* blog-files/acid3-full-rendering-pass.png: Modified property svn:mime-type.
* blog-files/acid3-rendering-reference.png: Modified property svn:mime-type.
* blog-files/acid3-screenshot.png: Modified property svn:mime-type.
* blog-files/acid3-timing-screenshot.png: Modified property svn:mime-type.
* blog-files/acid3-timing.png: Modified property svn:mime-type.
* blog-files/bounce.png: Added property svn:mime-type.
* blog-files/gebcnwebkitonly.png: Modified property svn:mime-type.
* blog-files/inspector-closure-scope.png: Added property svn:mime-type.
* blog-files/inspector-console-autocomplete.png: Added property svn:mime-type.
* blog-files/inspector-databases-panel-query-view.png: Added property svn:mime-type.
* blog-files/inspector-databases-panel.png: Added property svn:mime-type.
* blog-files/inspector-disabling-properties.png: Added property svn:mime-type.
* blog-files/inspector-elements-panel.png: Added property svn:mime-type.
* blog-files/inspector-event-scope.png: Added property svn:mime-type.
* blog-files/inspector-profiles-panel.png: Added property svn:mime-type.
* blog-files/inspector-resources-panel.png: Added property svn:mime-type.
* blog-files/inspector-scripts-panel.png: Added property svn:mime-type.
* blog-files/inspector-searching-elements.png: Added property svn:mime-type.
* blog-files/inspector-searching-profiles.png: Added property svn:mime-type.
* blog-files/inspector-status-bar-with-errors.png: Added property svn:mime-type.
* blog-files/inspector-toolbar.png: Added property svn:mime-type.
* blog-files/inspector-with-scope.png: Added property svn:mime-type.
* blog-files/inspector/breakpoints.png: Added property svn:mime-type.
* blog-files/inspector/colors.png: Added property svn:mime-type.
* blog-files/inspector/cookies.png: Added property svn:mime-type.
* blog-files/inspector/css_selectors.png: Added property svn:mime-type.
* blog-files/inspector/css_syntax_highlight.png: Added property svn:mime-type.
* blog-files/inspector/dom_storage.png: Added property svn:mime-type.
* blog-files/inspector/edit_attributes.png: Added property svn:mime-type.
* blog-files/inspector/enable.png: Added property svn:mime-type.
* blog-files/inspector/event_listeners.png: Added property svn:mime-type.
* blog-files/inspector/form_data.png: Added property svn:mime-type.
* blog-files/inspector/inline_highlight.png: Added property svn:mime-type.
* blog-files/inspector/inorder.png: Added property svn:mime-type.
* blog-files/inspector/inspect_inspector.png: Added property svn:mime-type.
* blog-files/inspector/inspect_inspector_small.png: Added property svn:mime-type.
* blog-files/inspector/load_lines.png: Added property svn:mime-type.
* blog-files/inspector/nodelist.png: Added property svn:mime-type.
* blog-files/inspector/scope_bar.png: Added property svn:mime-type.
* blog-files/inspector/watched_expression.png: Added property svn:mime-type.
* blog-files/kate-circle.png: Modified property svn:mime-type.
* blog-files/kate-gradient-rounded.png: Modified property svn:mime-type.
* blog-files/kate-gradient.png: Modified property svn:mime-type.
* blog-files/kate-reflected.png: Modified property svn:mime-type.
* blog-files/kate-vignette-mask.png: Modified property svn:mime-type.
* blog-files/kate.png: Modified property svn:mime-type.
* blog-files/leaves/images/apple-touch-icon.png: Added property svn:mime-type.
* blog-files/leaves/images/realLeaf1.png: Added property svn:mime-type.
* blog-files/leaves/images/realLeaf2.png: Added property svn:mime-type.
* blog-files/leaves/images/realLeaf3.png: Added property svn:mime-type.
* blog-files/leaves/images/realLeaf4.png: Added property svn:mime-type.
* blog-files/leaves/images/textBackground.png: Added property svn:mime-type.
* blog-files/maskspeedracer.png: Modified property svn:mime-type.
* blog-files/pulse.png: Added property svn:mime-type.
* blog-files/scrollbarpicture.png: Modified property svn:mime-type.
* blog-files/sfx-perf.png: Modified property svn:mime-type.
* blog-files/squirrelfish-webkit-graph.png: Modified property svn:mime-type.
* blog-files/squirrelfish.png: Modified property svn:mime-type.
* blog-files/vignette-mask.png: Modified property svn:mime-type.
* blog-files/webgl/resources/mars500x250.png: Modified property svn:mime-type.
* blog-files/wsj-nopreload.png: Modified property svn:mime-type.
* blog-files/wsj-preload.png: Modified property svn:mime-type.
* blog-files/wsj-vs.png: Modified property svn:mime-type.
* blog/wp-admin/images/align-center.png: Added property svn:mime-type.
* blog/wp-admin/images/align-left.png: Added property svn:mime-type.
* blog/wp-admin/images/align-none.png: Added property svn:mime-type.
* blog/wp-admin/images/align-right.png: Added property svn:mime-type.
* blog/wp-admin/images/archive-link.png: Added property svn:mime-type.
* blog/wp-admin/images/blue-grad.png: Added property svn:mime-type.
* blog/wp-admin/images/button-grad-active-vs.png: Added property svn:mime-type.
* blog/wp-admin/images/button-grad-active.png: Added property svn:mime-type.
* blog/wp-admin/images/button-grad-vs.png: Added property svn:mime-type.
* blog/wp-admin/images/button-grad.png: Added property svn:mime-type.
* blog/wp-admin/images/comment-grey-bubble.png: Added property svn:mime-type.
* blog/wp-admin/images/fade-butt.png: Modified property svn:mime-type.
* blog/wp-admin/images/fav-top.png: Added property svn:mime-type.
* blog/wp-admin/images/fav-vs.png: Added property svn:mime-type.
* blog/wp-admin/images/fav.png: Added property svn:mime-type.
* blog/wp-admin/images/generic.png: Added property svn:mime-type.
* blog/wp-admin/images/gray-grad.png: Added property svn:mime-type.
* blog/wp-admin/images/icons32-vs.png: Added property svn:mime-type.
* blog/wp-admin/images/icons32.png: Added property svn:mime-type.
* blog/wp-admin/images/list-vs.png: Added property svn:mime-type.
* blog/wp-admin/images/list.png: Added property svn:mime-type.
* blog/wp-admin/images/logo-ghost.png: Added property svn:mime-type.
* blog/wp-admin/images/marker.png: Added property svn:mime-type.
* blog/wp-admin/images/mask.png: Added property svn:mime-type.
* blog/wp-admin/images/menu-vs.png: Added property svn:mime-type.
* blog/wp-admin/images/menu.png: Added property svn:mime-type.
* blog/wp-admin/images/no.png: Added property svn:mime-type.
* blog/wp-admin/images/se.png: Added property svn:mime-type.
* blog/wp-admin/images/wheel.png: Added property svn:mime-type.
* blog/wp-admin/images/white-grad-active.png: Added property svn:mime-type.
* blog/wp-admin/images/white-grad.png: Added property svn:mime-type.
* blog/wp-admin/images/wordpress-logo.png: Modified property svn:mime-type.
* blog/wp-admin/images/yes.png: Added property svn:mime-type.
* blog/wp-content/Picture9.png: Modified property svn:mime-type.
* blog/wp-content/chucknorris.png: Modified property svn:mime-type.
* blog/wp-content/databaseexample.png: Modified property svn:mime-type.
* blog/wp-content/drosera.png: Modified property svn:mime-type.
* blog/wp-content/hitlist.png: Modified property svn:mime-type.
* blog/wp-content/rotate.png: Modified property svn:mime-type.
* blog/wp-content/svgtext.png: Modified property svn:mime-type.
* blog/wp-content/svgtextmini.png: Modified property svn:mime-type.
* blog/wp-content/svgtextmini_01.png: Modified property svn:mime-type.
* blog/wp-content/themes/classic/screenshot.png: Modified property svn:mime-type.
* blog/wp-content/themes/default/screenshot.png: Modified property svn:mime-type.
* blog/wp-content/uploads/2007/06/newinspector.png: Modified property svn:mime-type.
* blog/wp-content/webInspector.png: Modified property svn:mime-type.
* blog/wp-includes/images/crystal/archive.png: Added property svn:mime-type.
* blog/wp-includes/images/crystal/audio.png: Added property svn:mime-type.
* blog/wp-includes/images/crystal/code.png: Added property svn:mime-type.
* blog/wp-includes/images/crystal/default.png: Added property svn:mime-type.
* blog/wp-includes/images/crystal/document.png: Added property svn:mime-type.
* blog/wp-includes/images/crystal/interactive.png: Added property svn:mime-type.
* blog/wp-includes/images/crystal/spreadsheet.png: Added property svn:mime-type.
* blog/wp-includes/images/crystal/text.png: Added property svn:mime-type.
* blog/wp-includes/images/crystal/video.png: Added property svn:mime-type.
* blog/wp-includes/images/rss.png: Modified property svn:mime-type.
* blog/wp-includes/images/upload.png: Added property svn:mime-type.
* blog/wp-includes/images/wlw/wp-comments.png: Added property svn:mime-type.
* blog/wp-includes/images/wlw/wp-icon.png: Added property svn:mime-type.
* blog/wp-includes/images/wlw/wp-watermark.png: Added property svn:mime-type.
* blog/wp-includes/js/codepress/images/line-numbers.png: Added property svn:mime-type.
* blog/wp-includes/js/thickbox/macFFBgHack.png: Added property svn:mime-type.
* blog/wp-includes/js/thickbox/tb-close.png: Added property svn:mime-type.
* blog/wp-includes/js/tinymce/plugins/wpeditimage/img/delete.png: Added property svn:mime-type.
* blog/wp-includes/js/tinymce/plugins/wpeditimage/img/image.png: Added property svn:mime-type.
* blog/wp-includes/js/tinymce/plugins/wpgallery/img/delete.png: Added property svn:mime-type.
* blog/wp-includes/js/tinymce/plugins/wpgallery/img/edit.png: Added property svn:mime-type.
* blog/wp-includes/js/tinymce/plugins/wpgallery/img/gallery.png: Added property svn:mime-type.
* blog/wp-includes/js/tinymce/themes/advanced/img/gotmoxie.png: Added property svn:mime-type.
* blog/wp-includes/js/tinymce/themes/advanced/img/sflogo.png: Added property svn:mime-type.
* blog/wp-includes/js/tinymce/themes/advanced/skins/default/img/buttons.png: Added property svn:mime-type.
* blog/wp-includes/js/tinymce/themes/advanced/skins/o2k7/img/button_bg.png: Added property svn:mime-type.
* blog/wp-includes/js/tinymce/themes/advanced/skins/o2k7/img/button_bg_black.png: Added property svn:mime-type.
* blog/wp-includes/js/tinymce/themes/advanced/skins/o2k7/img/button_bg_silver.png: Added property svn:mime-type.
* blog/wp-includes/js/tinymce/themes/advanced/skins/wp_theme/img/butt2.png: Added property svn:mime-type.
* blog/wp-includes/js/tinymce/themes/advanced/skins/wp_theme/img/button_bg.png: Added property svn:mime-type.
* demos/calendar/Images/AirPort4.png: Modified property svn:mime-type.
* demos/calendar/Images/AirPortError.png: Modified property svn:mime-type.
* demos/calendar/Images/disclosureTriangleSmallDown.png: Modified property svn:mime-type.
* demos/calendar/Images/disclosureTriangleSmallRight.png: Modified property svn:mime-type.
* demos/calendar/Images/statusbarBackground.png: Modified property svn:mime-type.
* demos/calendar/Images/statusbarResizerVertical.png: Modified property svn:mime-type.
* demos/editingToolbar/FancyToolbarImages/button.png: Modified property svn:mime-type.
* demos/editingToolbar/FancyToolbarImages/buttonLeft.png: Modified property svn:mime-type.
* demos/editingToolbar/FancyToolbarImages/buttonMiddle.png: Modified property svn:mime-type.
* demos/editingToolbar/FancyToolbarImages/buttonPressed.png: Modified property svn:mime-type.
* demos/editingToolbar/FancyToolbarImages/buttonPressedLeft.png: Modified property svn:mime-type.
* demos/editingToolbar/FancyToolbarImages/buttonPressedMiddle.png: Modified property svn:mime-type.
* demos/editingToolbar/FancyToolbarImages/buttonPressedRight.png: Modified property svn:mime-type.
* demos/editingToolbar/FancyToolbarImages/buttonRight.png: Modified property svn:mime-type.
* demos/editingToolbar/FancyToolbarImages/camera.png: Modified property svn:mime-type.
* demos/editingToolbar/FancyToolbarImages/link.png: Modified property svn:mime-type.
* demos/editingToolbar/FancyToolbarImages/textAlign.png: Modified property svn:mime-type.
* demos/editingToolbar/FancyToolbarImages/toolbarOutline.png: Modified property svn:mime-type.
* demos/editingToolbar/FancyToolbarImages/toolbarOutlineBottom.png: Modified property svn:mime-type.
* demos/editingToolbar/FancyToolbarImages/toolbarOutlineBottomLeft.png: Modified property svn:mime-type.
* demos/editingToolbar/FancyToolbarImages/toolbarOutlineBottomRight.png: Modified property svn:mime-type.
* demos/editingToolbar/FancyToolbarImages/toolbarOutlineLeft.png: Modified property svn:mime-type.
* demos/editingToolbar/FancyToolbarImages/toolbarOutlineRight.png: Modified property svn:mime-type.
* demos/editingToolbar/FancyToolbarImages/toolbarOutlineTop.png: Modified property svn:mime-type.
* demos/editingToolbar/FancyToolbarImages/toolbarOutlineTopLeft.png: Modified property svn:mime-type.
* demos/editingToolbar/FancyToolbarImages/toolbarOutlineTopRight.png: Modified property svn:mime-type.
* demos/editingToolbar/images/safari.png: Modified property svn:mime-type.
* demos/sticky-notes/deleteButton.png: Added property svn:mime-type.
* demos/sticky-notes/deleteButtonPressed.png: Added property svn:mime-type.
* demos/transitions-and-transforms/Horsehead.png: Modified property svn:mime-type.
* demos/transitions-and-transforms/Spaces.png: Modified property svn:mime-type.
* demos/transitions-and-transforms/Stacks.png: Modified property svn:mime-type.
* images/DroseraPic.png: Modified property svn:mime-type.
* misc/drosera/drosera.png: Modified property svn:mime-type.
* perf/slickspeed/logo.png: Modified property svn:mime-type.

WebKitSite/specs/CSSVisualEffects:

Patch by Darin Adler <darin@apple.com> on 2009-11-03
* css3-2d-transforms/compound_transform.png: Modified property svn:mime-type.
* css3-2d-transforms/transform1.png: Modified property svn:mime-type.
* css3-2d-transforms/transform2.png: Modified property svn:mime-type.
* css3-3d-transforms/compound_transform.png: Modified property svn:mime-type.
* css3-3d-transforms/transform1.png: Modified property svn:mime-type.
* css3-3d-transforms/transform2.png: Modified property svn:mime-type.
* css3-animations/animation1.png: Modified property svn:mime-type.
* css3-animations/sandwich.png: Modified property svn:mime-type.
* css3-transitions/TimingFunction.png: Modified property svn:mime-type.
* css3-transitions/transition1.png: Modified property svn:mime-type.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore: [Qt] Handle fonts like the other ports
hausmann@webkit.org [Wed, 4 Nov 2009 03:37:32 +0000 (03:37 +0000)]
WebCore: [Qt] Handle fonts like the other ports

Patch by Benjamin Poulain <benjamin.poulain@nokia.com> on 2009-11-02
Reviewed by Simon Hausmann.

Remove FontFallbackListQt and rely on the common FontFallbackList
to handle the fonts. FontCache and FontPlatformData have been
updated to work with the common FontFallbackList.

In the previous implementation, FontPlatformDataCacheKey
was a clone of FontPlatformData with the hashing
capabilities added in order to use it as a key in the cache's
hashmap. FontPlatformData has been modified to handle the hashing
function directly so the data are not copied twice in memory.

FontFallbackList::fontDataAt() from FontFallbackListQt was a copy of
code from FontCache::getFontData() and FontFallbackList::fontDataAt().
The behavior is similar except currFamily->family().length() was
not tested and the fallback fonts selector were not used.

https://bugs.webkit.org/show_bug.cgi?id=29856

Test: svg/text/text-font-invalid.html

* WebCore.pro:
* platform/graphics/qt/FontCacheQt.cpp:
(WebCore::FontCache::platformInit):
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
(WebCore::FontCache::getTraitsInFamily):
(WebCore::FontCache::createFontPlatformData):
* platform/graphics/qt/FontFallbackListQt.cpp:
Removed. We now use the implementation from FontFallbackList.cpp
* platform/graphics/qt/FontPlatformData.h:
Add hashing capabilities to be able to use the data with the FontCache.
This was previously done in FontCacheQt.cpp
(WebCore::FontPlatformData::FontPlatformData):
Added a boolean to identify deleted value in the hash table.
(WebCore::FontPlatformData::isHashTableDeletedValue):
(WebCore::FontPlatformData::hash):
(WebCore::FontPlatformData::operator==):
* platform/graphics/qt/FontPlatformDataQt.cpp:
(WebCore::FontPlatformData::FontPlatformData):

LayoutTests: Add a new test to reproduce 29856. The bug only happen
when the SVG file is used as an image.
https://bugs.webkit.org/show_bug.cgi?id=29856

Patch by Benjamin Poulain <benjamin.poulain@nokia.com> on 2009-11-02
Reviewed by Simon Hausmann.

* svg/text/text-font-invalid-expected.txt: Added.
* svg/text/resources/text-font-invalid.svg: Added.
* svg/text/text-font-invalid.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBug 28420 - Implement HTML5 <ruby> rendering
rolandsteiner@chromium.org [Wed, 4 Nov 2009 03:26:29 +0000 (03:26 +0000)]
Bug 28420 -  Implement HTML5 <ruby> rendering
(https://bugs.webkit.org/show_bug.cgi?id=28420)

Reviewed by Dave Hyatt.

First rudimentary implementation of HTML5 ruby rendering support - layout tests.

New layout tests: basic rendering:
* fast/ruby/ruby-empty-rt.html: Added.
* fast/ruby/ruby-length.html: Added.
* fast/ruby/ruby-run-break.html: Added.
* fast/ruby/ruby-runs-spans.html: Added.
* fast/ruby/ruby-runs.html: Added.
* fast/ruby/ruby-simple-rp.html: Added.
* fast/ruby/ruby-simple.html: Added.
* fast/ruby/ruby-trailing.html: Added.

New layout tests: DOM manipulation within <ruby>
* fast/ruby/rubyDOM-insert-rt.html: Added.
* fast/ruby/rubyDOM-insert-text1.html: Added.
* fast/ruby/rubyDOM-insert-text2.html: Added.
* fast/ruby/rubyDOM-insert-text3.html: Added.
* fast/ruby/rubyDOM-remove-rt1.html: Added.
* fast/ruby/rubyDOM-remove-rt2.html: Added.
* fast/ruby/rubyDOM-remove-text1.html: Added.
* fast/ruby/rubyDOM-remove-text2.html: Added.

New layout tests results:
* platform/mac/fast/ruby: Added.
* platform/mac/fast/ruby/ruby-empty-rt-expected.checksum: Added.
* platform/mac/fast/ruby/ruby-empty-rt-expected.png: Added.
* platform/mac/fast/ruby/ruby-empty-rt-expected.txt: Added.
* platform/mac/fast/ruby/ruby-length-expected.checksum: Added.
* platform/mac/fast/ruby/ruby-length-expected.png: Added.
* platform/mac/fast/ruby/ruby-length-expected.txt: Added.
* platform/mac/fast/ruby/ruby-run-break-expected.checksum: Added.
* platform/mac/fast/ruby/ruby-run-break-expected.png: Added.
* platform/mac/fast/ruby/ruby-run-break-expected.txt: Added.
* platform/mac/fast/ruby/ruby-runs-expected.checksum: Added.
* platform/mac/fast/ruby/ruby-runs-expected.png: Added.
* platform/mac/fast/ruby/ruby-runs-expected.txt: Added.
* platform/mac/fast/ruby/ruby-runs-spans-expected.checksum: Added.
* platform/mac/fast/ruby/ruby-runs-spans-expected.png: Added.
* platform/mac/fast/ruby/ruby-runs-spans-expected.txt: Added.
* platform/mac/fast/ruby/ruby-simple-expected.checksum: Added.
* platform/mac/fast/ruby/ruby-simple-expected.png: Added.
* platform/mac/fast/ruby/ruby-simple-expected.txt: Added.
* platform/mac/fast/ruby/ruby-simple-rp-expected.checksum: Added.
* platform/mac/fast/ruby/ruby-simple-rp-expected.png: Added.
* platform/mac/fast/ruby/ruby-simple-rp-expected.txt: Added.
* platform/mac/fast/ruby/ruby-trailing-expected.checksum: Added.
* platform/mac/fast/ruby/ruby-trailing-expected.png: Added.
* platform/mac/fast/ruby/ruby-trailing-expected.txt: Added.
* platform/mac/fast/ruby/rubyDOM-insert-rt-expected.checksum: Added.
* platform/mac/fast/ruby/rubyDOM-insert-rt-expected.png: Added.
* platform/mac/fast/ruby/rubyDOM-insert-rt-expected.txt: Added.
* platform/mac/fast/ruby/rubyDOM-insert-text1-expected.checksum: Added.
* platform/mac/fast/ruby/rubyDOM-insert-text1-expected.png: Added.
* platform/mac/fast/ruby/rubyDOM-insert-text1-expected.txt: Added.
* platform/mac/fast/ruby/rubyDOM-insert-text2-expected.checksum: Added.
* platform/mac/fast/ruby/rubyDOM-insert-text2-expected.png: Added.
* platform/mac/fast/ruby/rubyDOM-insert-text2-expected.txt: Added.
* platform/mac/fast/ruby/rubyDOM-insert-text3-expected.checksum: Added.
* platform/mac/fast/ruby/rubyDOM-insert-text3-expected.png: Added.
* platform/mac/fast/ruby/rubyDOM-insert-text3-expected.txt: Added.
* platform/mac/fast/ruby/rubyDOM-remove-rt1-expected.checksum: Added.
* platform/mac/fast/ruby/rubyDOM-remove-rt1-expected.png: Added.
* platform/mac/fast/ruby/rubyDOM-remove-rt1-expected.txt: Added.
* platform/mac/fast/ruby/rubyDOM-remove-rt2-expected.checksum: Added.
* platform/mac/fast/ruby/rubyDOM-remove-rt2-expected.png: Added.
* platform/mac/fast/ruby/rubyDOM-remove-rt2-expected.txt: Added.
* platform/mac/fast/ruby/rubyDOM-remove-text1-expected.checksum: Added.
* platform/mac/fast/ruby/rubyDOM-remove-text1-expected.png: Added.
* platform/mac/fast/ruby/rubyDOM-remove-text1-expected.txt: Added.
* platform/mac/fast/ruby/rubyDOM-remove-text2-expected.checksum: Added.
* platform/mac/fast/ruby/rubyDOM-remove-text2-expected.png: Added.
* platform/mac/fast/ruby/rubyDOM-remove-text2-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-03 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Wed, 4 Nov 2009 02:09:49 +0000 (02:09 +0000)]
2009-11-03  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Timothy Hatcher.

        Adding images for an upcoming blog post.

        * blog-files/inspector/breakpoints.png: Added.
        * blog-files/inspector/colors.png: Added.
        * blog-files/inspector/cookies.png: Added.
        * blog-files/inspector/css_selectors.png: Added.
        * blog-files/inspector/css_syntax_highlight.png: Added.
        * blog-files/inspector/dom_storage.png: Added.
        * blog-files/inspector/edit_attributes.png: Added.
        * blog-files/inspector/enable.png: Added.
        * blog-files/inspector/event_listeners.png: Added.
        * blog-files/inspector/form_data.png: Added.
        * blog-files/inspector/inline_highlight.png: Added.
        * blog-files/inspector/inorder.png: Added.
        * blog-files/inspector/inspect_inspector.png: Added.
        * blog-files/inspector/inspect_inspector_small.png: Added.
        * blog-files/inspector/load_lines.png: Added.
        * blog-files/inspector/nodelist.png: Added.
        * blog-files/inspector/scope_bar.png: Added.
        * blog-files/inspector/watched_expression.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoLeopard build fix
mitz@apple.com [Wed, 4 Nov 2009 01:34:05 +0000 (01:34 +0000)]
Leopard build fix

* platform/network/mac/AuthenticationMac.mm:
(WebCore::mac):
(WebCore::core):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-03 Kenneth Russell <kbr@google.com>
oliver@apple.com [Wed, 4 Nov 2009 01:25:52 +0000 (01:25 +0000)]
2009-11-03  Kenneth Russell  <kbr@google.com>

        Reviewed by Oliver Hunt.

        Add overridePreference call to all WebGL layout tests
        https://bugs.webkit.org/show_bug.cgi?id=31088

        * fast/canvas/webgl/array-unit-tests.html:
        * fast/canvas/webgl/getActiveTest.html:
        * fast/canvas/webgl/gl-get-calls.html:
        * fast/canvas/webgl/incorrect-context-object-behaviour.html:
        * fast/canvas/webgl/null-object-behaviour.html:
        * fast/canvas/webgl/resources/shader-test.js: Removed.
        * fast/canvas/webgl/resources/webgl-test.js: Copied from LayoutTests/fast/canvas/webgl/resources/shader-test.js.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebActionModifierFlagsKey should return an unsigned, because
bweinstein@apple.com [Wed, 4 Nov 2009 01:11:31 +0000 (01:11 +0000)]
WebActionModifierFlagsKey should return an unsigned, because
flags imply a bitmask, and that is what other classes expect from
it.

Reviewed by Steve Falkenburg.

* WebActionPropertyBag.cpp:
(WebActionPropertyBag::Read):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix an assertion failure in core(NSURLProtectionSpace *) by handling NTLM
mitz@apple.com [Wed, 4 Nov 2009 01:02:59 +0000 (01:02 +0000)]
Fix an assertion failure in core(NSURLProtectionSpace *) by handling NTLM
authentication in AuthenticationMac

Reviewed by Alexey Proskuryakov.

* platform/network/mac/AuthenticationMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-03 Eric Z. Ayers <zundel@google.com>
eric@webkit.org [Wed, 4 Nov 2009 00:00:17 +0000 (00:00 +0000)]
2009-11-03  Eric Z. Ayers  <zundel@google.com>

        Reviewed by Timothy Hatcher.

        Adds a test for turning on the timeline profiler.  This caused
        a crash because profiling was enabled in the middle of processing
        an event.

        https://bugs.webkit.org/show_bug.cgi?id=31080

        * inspector/timeline-trivial-expected.txt: Added.
        * inspector/timeline-trivial.html: Added.
2009-11-03  Eric Z. Ayers  <zundel@google.com>

        Reviewed by Timothy Hatcher.

        Fixes a problem where the timeline instrumentation crashes if
        timeline profiling is enabled or disabled in the middle of an
        event dispatch.

        https://bugs.webkit.org/show_bug.cgi?id=31080

        Test: inspector/timeline-trivial.html

        * bindings/js/ScriptController.cpp:
        (WebCore::ScriptController::evaluateInWorld):
        (WebCore::ScriptController::processingUserGestureEvent):
        * inspector/InspectorTimelineAgent.cpp:
        (WebCore::InspectorTimelineAgent::didCompleteCurrentRecord):
        * page/DOMTimer.cpp:
        (WebCore::DOMTimer::fired):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-03 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 3 Nov 2009 23:34:08 +0000 (23:34 +0000)]
2009-11-03  Eric Seidel  <eric@webkit.org>

        No review, just changing wording of log message.

        Change log string to say "failed" instead of "rejected"
        when a commit fails due to an out of date checkout.
        This makes grepping the commit-queue log for rejected patches easier.

        * Scripts/bugzilla-tool:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-03 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 3 Nov 2009 22:14:51 +0000 (22:14 +0000)]
2009-11-03  Eric Seidel  <eric@webkit.org>

        No review, adding commonly known committers missing from the file.

        * Scripts/modules/committers.py: Add committers found by looking at SVN records.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50487 268f45cc-cd09-0410-ab3c-d52691b4dbfc