WebKit-https.git
10 years ago2011-04-19 Stuart Morgan <stuartmorgan@chromium.org>
commit-queue@webkit.org [Tue, 19 Apr 2011 18:17:30 +0000 (18:17 +0000)]
2011-04-19  Stuart Morgan  <stuartmorgan@chromium.org>

        Reviewed by Tony Chang.

        [chromium] Clicking on plugin for first time blocks focus shift
        https://bugs.webkit.org/show_bug.cgi?id=58419

        Added new test for cross-iframe focus changes on plugin clicks.

        * plugins/mouse-click-iframe-to-plugin-expected.txt: Added.
        * plugins/mouse-click-iframe-to-plugin.html: Added.
2011-04-19  Stuart Morgan  <stuartmorgan@chromium.org>

        Reviewed by Tony Chang.

        [chromium] Clicking on plugin for first time blocks focus shift
        https://bugs.webkit.org/show_bug.cgi?id=58419

        Switched to using FocusController when moving focus to a plugin
        so that cross-frame focus changes are handled correctly.

        * src/WebPluginContainerImpl.cpp:
        (WebKit::WebPluginContainerImpl::handleMouseEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-19 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Tue, 19 Apr 2011 18:17:15 +0000 (18:17 +0000)]
2011-04-19  Ojan Vafai  <ojan@chromium.org>

        Remove accidentally committed debug code.
        * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed build correction.
bfulgham@webkit.org [Tue, 19 Apr 2011 18:15:38 +0000 (18:15 +0000)]
Unreviewed build correction.

Avoid duplicate stub implementation of test routine
for WinCairo build.

* WebKitTestRunner/win/TestInvocationWin.cpp: Exclude
WinCairo from using this stub.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-18 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Tue, 19 Apr 2011 18:12:16 +0000 (18:12 +0000)]
2011-04-18  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Eric Seidel.

        make results file work with audio and reftests
        https://bugs.webkit.org/show_bug.cgi?id=58860

        Also fix bug with timeout tests and store a bit in the JSON
        for new image tests instead of loading the image result to check if it's there.

        * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
        * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-19 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
commit-queue@webkit.org [Tue, 19 Apr 2011 18:08:12 +0000 (18:08 +0000)]
2011-04-19  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>

        Reviewed by Adam Roben.

        PrettyPatch tries to show images for deleted files
        https://bugs.webkit.org/show_bug.cgi?id=28457

        When the image data is empty, instead of generating an <img> tag, generate
        a text to indicate the image was deleted.

        * PrettyPatch/PrettyPatch.rb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-19 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Tue, 19 Apr 2011 18:05:52 +0000 (18:05 +0000)]
2011-04-19  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Dimitri Glazkov.

        REGRESSION(r74228-75294): removing nodes is 200+ times slower when selection is inside a shadow DOM
        https://bugs.webkit.org/show_bug.cgi?id=57061

        The bug was caused by Range::compareNode's incorrectly returning NODE_INSIDE when the selection is inside
        a shadow DOM and the node is outside of the shadow DOM. This caused respondToNodeModification to call
        RenderView::clearSelection every time a node is removed when selection is in a shadow DOM and resulted in
        a significant performance regression.

        Fixed Ranged::compareNode by making Range::compareBoundaryPoints throw a WRONG_DOCUMENT_ERR when there are
        no common ancestors between containerA and containerB. This will force compareNode to also throw an exception
        and prevents respondToNodeModification from clearing selection.

        No new tests because this is a performance improvement and the fix in Range cannot be tested since shadow DOM
        isn't exposed to JavaScript.

        * dom/Range.cpp:
        (WebCore::Range::setStart): Calls compareBoundaryPoints; since we ensures that the root container noes of
        start and end nodes are same, we should never get an exception from compareBoundaryPoints.
        (WebCore::Range::setEnd): Ditto.
        (WebCore::Range::isPointInRange): Calls compareBoundaryPoints; returns false when compareBoundaryPoints
        throws an exception.
        (WebCore::Range::comparePoint): Calls compareBoundaryPoints; exit early when an exception is thrown by
        compareBoundaryPoints.
        (WebCore::Range::compareBoundaryPoints): Throws an exception when two containers do not have a common ancestor.
        (WebCore::Range::boundaryPointsValid): Calls compareBoundaryPoints and checks that it didn't throw an exception.
        * dom/Range.h:
        * editing/SelectionController.cpp:
        (WebCore::SelectionController::respondToNodeModification):
        * editing/htmlediting.cpp:
        (WebCore::comparePositions): Calls compareBoundaryPoints.
        * editing/markup.cpp:
        (WebCore::createMarkup): Calls compareBoundaryPoints; since startNode and pastEnd are both in the same document
        and neither are in a shadow DOM, it should never throw an exception.
        * page/DOMSelection.cpp:
        (WebCore::DOMSelection::containsNode): Calls compareBoundaryPoints; node is fully selected only if no exception
        was thrown.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoIndex: Source/JavaScriptCore/ChangeLog
jshin@chromium.org [Tue, 19 Apr 2011 17:40:45 +0000 (17:40 +0000)]
Index: Source/JavaScriptCore/ChangeLog
===================================================================
--- Source/JavaScriptCore/ChangeLog (revision 84100)
+++ Source/JavaScriptCore/ChangeLog (working copy)
@@ -1,3 +1,15 @@
+2011-04-17  Jungshik Shin  <jshin@chromium.org>
+
+        Reviewed by NOBODY (OOPS!).
+
+        Add U+FEFF (Zero width no-break space) to CharacterNames.h.
+        It's added to the list of characters to treat as zero-width
+        in WebCore.
+
+        https://bugs.webkit.org/show_bug.cgi?id=48860
+
+        * wtf/unicode/CharacterNames.h:
+
 2011-04-16  Patrick Gansterer  <paroga@webkit.org>

         Reviewed by Eric Seidel.
Index: Source/JavaScriptCore/wtf/unicode/CharacterNames.h
===================================================================
--- Source/JavaScriptCore/wtf/unicode/CharacterNames.h (revision 84099)
+++ Source/JavaScriptCore/wtf/unicode/CharacterNames.h (working copy)
@@ -85,6 +85,7 @@ const UChar yenSign = 0x00A5;
 const UChar zeroWidthJoiner = 0x200D;
 const UChar zeroWidthNonJoiner = 0x200C;
 const UChar zeroWidthSpace = 0x200B;
+const UChar zeroWidthNoBreakSpace = 0xFEFF;

 } // namespace Unicode
 } // namespace WTF
@@ -138,5 +139,6 @@ using WTF::Unicode::yenSign;
 using WTF::Unicode::zeroWidthJoiner;
 using WTF::Unicode::zeroWidthNonJoiner;
 using WTF::Unicode::zeroWidthSpace;
+using WTF::Unicode::zeroWidthNoBreakSpace;

 #endif // CharacterNames_h
Index: Source/WebCore/ChangeLog
===================================================================
--- Source/WebCore/ChangeLog (revision 84100)
+++ Source/WebCore/ChangeLog (working copy)
@@ -1,3 +1,37 @@
+2011-04-17  Jungshik Shin  <jshin@chromium.org>
+
+        Reviewed by NOBODY (OOPS!).
+
+        Make U+FEFF be treated as a zero-width character in both
+        simple script and complex script code paths. In Chromium
+        Windows, UniscribeHelper needs a rather extensive changes
+        summarized below.  Other ports need minor changes.
+
+        https://bugs.webkit.org/show_bug.cgi?id=48860
+
+        Test: fast/text/zero-width-characters-complex-script.html
+
+        * platform/graphics/Font.h:
+        (WebCore::Font::treatAsZeroWidthSpace): U+FEFF is added to the list
+        (WebCore::Font::treatAsZeroWidthSpaceInComplexScript): Added. Same as the above except that ZWNJ and ZWJ are excluded.
+        * platform/graphics/GlyphPageTreeNode.cpp:
+        (WebCore::GlyphPageTreeNode::initializePage): U+FEFF is made to have zero-width characters in simple script (fast) code path.
+        * platform/graphics/chromium/FontUtilsChromiumWin.cpp:
+        (WebCore::FontMap::getSpaceGlyph): Added to get the gid for space glyph to use in adjustSpaceAdvance when zero-width glyph character has a non-zero width and potentially 'visible' glyph.
+        (WebCore::FontMap::FontData::FontData): spaceGlyph member added.
+        (WebCore::getDerivedFontData): spaceGlyph is retrieved as well.
+        * platform/graphics/chromium/FontUtilsChromiumWin.h:
+        * platform/graphics/chromium/UniscribeHelper.cpp:
+        (WebCore::UniscribeHelper::UniscribeHelper): m_spaceGlyph added.
+        (WebCore::UniscribeHelper::shape): spaceGlyph is obtained stored for a font tried for each item.
+        (WebCore::UniscribeHelper::adjustSpaceAdvances): For zero-width complex script characters, set the advance width to zero and replace a non-zero-width/visible glyph with a space glyph.
+        (WebCore::UniscribeHelper::applySpacing):
+        (WebCore::UniscribeHelper::containsMissingGlyphs): turned to a member function because it cannot work on glyphs alone any more but need to take into account a character corresponding to a glyph
+        * platform/graphics/chromium/UniscribeHelper.h:
+        (WebCore::UniscribeHelper::Shaping::Shaping): m_spaceGlyph is added
+        * platform/graphics/chromium/UniscribeHelperTextRun.cpp:
+        (WebCore::UniscribeHelperTextRun::UniscribeHelperTextRun): When calling UniscriberHelper, add a new argument for spaceGlyph.
+
 2011-04-16  Adam Barth  <abarth@webkit.org>

         Reviewed by Sam Weinig.
Index: Source/WebCore/platform/graphics/Font.h
===================================================================
--- Source/WebCore/platform/graphics/Font.h (revision 84099)
+++ Source/WebCore/platform/graphics/Font.h (working copy)
@@ -203,7 +203,8 @@ public:

     FontSelector* fontSelector() const;
     static bool treatAsSpace(UChar c) { return c == ' ' || c == '\t' || c == '\n' || c == noBreakSpace; }
-    static bool treatAsZeroWidthSpace(UChar c) { return c < 0x20 || (c >= 0x7F && c < 0xA0) || c == softHyphen || (c >= 0x200c && c <= 0x200f) || (c >= 0x202a && c <= 0x202e) || c == objectReplacementCharacter; }
+    static bool treatAsZeroWidthSpace(UChar c) { return treatAsZeroWidthSpaceInComplexScript(c) || c == 0x200c || c == 0x200d; }
+    static bool treatAsZeroWidthSpaceInComplexScript(UChar c) { return c < 0x20 || (c >= 0x7F && c < 0xA0) || c == softHyphen || (c >= 0x200e && c <= 0x200f) || (c >= 0x202a && c <= 0x202e) || c == zeroWidthNoBreakSpace || c == objectReplacementCharacter; }
     static bool canReceiveTextEmphasis(UChar32 c);

     static inline UChar normalizeSpaces(UChar character)
Index: Source/WebCore/platform/graphics/GlyphPageTreeNode.cpp
===================================================================
--- Source/WebCore/platform/graphics/GlyphPageTreeNode.cpp (revision 84099)
+++ Source/WebCore/platform/graphics/GlyphPageTreeNode.cpp (working copy)
@@ -191,6 +191,9 @@ void GlyphPageTreeNode::initializePage(c
                 } else if (start == (objectReplacementCharacter & ~(GlyphPage::size - 1))) {
                     // Object replacement character must not render at all.
                     buffer[objectReplacementCharacter - start] = zeroWidthSpace;
+                } else if (start == (zeroWidthNoBreakSpace & ~(GlyphPage::size - 1))) {
+                    // ZWNBS/BOM must not render at all.
+                    buffer[zeroWidthNoBreakSpace - start] = zeroWidthSpace;
                 }
             } else {
                 bufferLength = GlyphPage::size * 2;
Index: Source/WebCore/platform/graphics/chromium/FontUtilsChromiumWin.cpp
===================================================================
--- Source/WebCore/platform/graphics/chromium/FontUtilsChromiumWin.cpp (revision 84099)
+++ Source/WebCore/platform/graphics/chromium/FontUtilsChromiumWin.cpp (working copy)
@@ -250,17 +250,31 @@ int getAscent(HFONT hfont)
     return gotMetrics ? tm.tmAscent : kUndefinedAscent;
 }

+WORD getSpaceGlyph(HFONT hfont)
+{
+    HDC dc = GetDC(0);
+    HGDIOBJ oldFont = SelectObject(dc, hfont);
+    WCHAR space = L' ';
+    WORD spaceGlyph = 0;
+    GetGlyphIndices(dc, &space, 1, &spaceGlyph, 0);
+    SelectObject(dc, oldFont);
+    ReleaseDC(0, dc);
+    return spaceGlyph;
+}
+
 struct FontData {
     FontData()
         : hfont(0)
         , ascent(kUndefinedAscent)
         , scriptCache(0)
+        , spaceGlyph(0)
     {
     }

     HFONT hfont;
     int ascent;
     mutable SCRIPT_CACHE scriptCache;
+    WORD spaceGlyph;
 };

 // Again, using hash_map does not earn us much here.  page_cycler_test intl2
@@ -379,7 +393,8 @@ bool getDerivedFontData(const UChar* fam
                         LOGFONT* logfont,
                         int* ascent,
                         HFONT* hfont,
-                        SCRIPT_CACHE** scriptCache)
+                        SCRIPT_CACHE** scriptCache,
+                        WORD* spaceGlyph)
 {
     ASSERT(logfont);
     ASSERT(family);
@@ -408,6 +423,7 @@ bool getDerivedFontData(const UChar* fam
         // cache it so that we won't have to call CreateFontIndirect once
         // more for HFONT next time.
         derived->ascent = getAscent(derived->hfont);
+        derived->spaceGlyph = getSpaceGlyph(derived->hfont);
     } else {
         derived = &iter->second;
         // Last time, GetAscent failed so that only HFONT was
@@ -419,6 +435,7 @@ bool getDerivedFontData(const UChar* fam
     *hfont = derived->hfont;
     *ascent = derived->ascent;
     *scriptCache = &(derived->scriptCache);
+    *spaceGlyph = derived->spaceGlyph;
     return *ascent != kUndefinedAscent;
 }

Index: Source/WebCore/platform/graphics/chromium/FontUtilsChromiumWin.h
===================================================================
--- Source/WebCore/platform/graphics/chromium/FontUtilsChromiumWin.h (revision 84099)
+++ Source/WebCore/platform/graphics/chromium/FontUtilsChromiumWin.h (working copy)
@@ -78,7 +78,7 @@ const UChar* getFallbackFamily(const UCh
 // intl2 page-cycler test is noticeably slower with one out param than
 // the current version although the subsequent 9 passes take about the
 // same time.
-bool getDerivedFontData(const UChar* family, int style, LOGFONT*, int* ascent, HFONT*, SCRIPT_CACHE**);
+bool getDerivedFontData(const UChar* family, int style, LOGFONT*, int* ascent, HFONT*, SCRIPT_CACHE**, WORD* spaceGlyph);

 enum {
     FontStyleNormal = 0,
Index: Source/WebCore/platform/graphics/chromium/UniscribeHelper.cpp
===================================================================
--- Source/WebCore/platform/graphics/chromium/UniscribeHelper.cpp (revision 84099)
+++ Source/WebCore/platform/graphics/chromium/UniscribeHelper.cpp (working copy)
@@ -31,45 +31,16 @@
 #include "config.h"
 #include "UniscribeHelper.h"

-#include <windows.h>
-
+#include "Font.h"
 #include "FontUtilsChromiumWin.h"
 #include "PlatformContextSkia.h"
 #include "SkiaFontWin.h"
 #include "SkPoint.h"
+#include <windows.h>
 #include <wtf/Assertions.h>

 namespace WebCore {

-// This function is used to see where word spacing should be applied inside
-// runs. Note that this must match Font::treatAsSpace so we all agree where
-// and how much space this is, so we don't want to do more general Unicode
-// "is this a word break" thing.
-static bool treatAsSpace(UChar c)
-{
-    return c == ' ' || c == '\t' || c == '\n' || c == 0x00A0;
-}
-
-// SCRIPT_FONTPROPERTIES contains glyph indices for default, invalid
-// and blank glyphs. Just because ScriptShape succeeds does not mean
-// that a text run is rendered correctly. Some characters may be rendered
-// with default/invalid/blank glyphs. Therefore, we need to check if the glyph
-// array returned by ScriptShape contains any of those glyphs to make
-// sure that the text run is rendered successfully.
-static bool containsMissingGlyphs(WORD *glyphs,
-                                  int length,
-                                  SCRIPT_FONTPROPERTIES* properties)
-{
-    for (int i = 0; i < length; ++i) {
-        if (glyphs[i] == properties->wgDefault
-            || (glyphs[i] == properties->wgInvalid
-            && glyphs[i] != properties->wgBlank))
-            return true;
-    }
-
-    return false;
-}
-
 // HFONT is the 'incarnation' of 'everything' about font, but it's an opaque
 // handle and we can't directly query it to make a new HFONT sharing
 // its characteristics (height, style, etc) except for family name.
@@ -102,13 +73,15 @@ UniscribeHelper::UniscribeHelper(const U
                                 bool isRtl,
                                 HFONT hfont,
                                 SCRIPT_CACHE* scriptCache,
-                                SCRIPT_FONTPROPERTIES* fontProperties)
+                                SCRIPT_FONTPROPERTIES* fontProperties,
+                                WORD spaceGlyph)
     : m_input(input)
     , m_inputLength(inputLength)
     , m_isRtl(isRtl)
     , m_hfont(hfont)
     , m_scriptCache(scriptCache)
     , m_fontProperties(fontProperties)
+    , m_spaceGlyph(spaceGlyph)
     , m_directionalOverride(false)
     , m_inhibitLigate(false)
     , m_letterSpacing(0)
@@ -546,6 +519,7 @@ bool UniscribeHelper::shape(const UChar*
     SCRIPT_CACHE* scriptCache = m_scriptCache;
     SCRIPT_FONTPROPERTIES* fontProperties = m_fontProperties;
     int ascent = m_ascent;
+    WORD spaceGlyph = m_spaceGlyph;
     HDC tempDC = 0;
     HGDIOBJ oldFont = 0;
     HRESULT hr;
@@ -601,7 +575,7 @@ bool UniscribeHelper::shape(const UChar*
         } else if (hr == E_OUTOFMEMORY) {
             numGlyphs *= 2;
             continue;
-        } else if (SUCCEEDED(hr) && (lastFallbackTried || !containsMissingGlyphs(&shaping.m_glyphs[0], generatedGlyphs, fontProperties)))
+        } else if (SUCCEEDED(hr) && (lastFallbackTried || !containsMissingGlyphs(shaping, run, fontProperties)))
             break;

         // The current font can't render this run. clear DC and try
@@ -632,7 +606,9 @@ bool UniscribeHelper::shape(const UChar*
             const UChar *family = getFallbackFamily(input, itemLength,
                 FontDescription::StandardFamily, 0, 0);
             bool fontOk = getDerivedFontData(family, m_style, &m_logfont,
-                                              &ascent, &hfont, &scriptCache);
+                                             &ascent, &hfont, &scriptCache,
+                                             &spaceGlyph);
+

             if (!fontOk) {
                 // If this GetDerivedFontData is called from the renderer it
@@ -644,7 +620,8 @@ bool UniscribeHelper::shape(const UChar*

                 // Try again.
                 fontOk = getDerivedFontData(family, m_style, &m_logfont,
-                                             &ascent, &hfont, &scriptCache);
+                                            &ascent, &hfont, &scriptCache,
+                                            &spaceGlyph);
                 ASSERT(fontOk);
             }

@@ -673,6 +650,7 @@ bool UniscribeHelper::shape(const UChar*
     // because it's not used elsewhere.
     shaping.m_hfont = hfont;
     shaping.m_scriptCache = scriptCache;
+    shaping.m_spaceGlyph = spaceGlyph;

     // The ascent of a font for this run can be different from
     // that of the primary font so that we need to keep track of
@@ -806,22 +784,39 @@ void UniscribeHelper::adjustSpaceAdvance
     for (size_t run = 0; run < m_runs.size(); run++) {
         Shaping& shaping = m_shapes[run];

+        // FIXME: This loop is not UTF-16-safe. Unicode 6.0 has a couple
+        // of complex script blocks in Plane 1.
         for (int i = 0; i < shaping.charLength(); i++) {
-            if (!treatAsSpace(m_input[m_runs[run].iCharPos + i]))
+            UChar c = m_input[m_runs[run].iCharPos + i];
+            bool treatAsSpace = Font::treatAsSpace(c);
+            if (!treatAsSpace && !Font::treatAsZeroWidthSpaceInComplexScript(c))
                 continue;

             int glyphIndex = shaping.m_logs[i];
             int currentAdvance = shaping.m_advance[glyphIndex];

-            // currentAdvance does not include additional letter-spacing, but
-            // space_width does. Here we find out how off we are from the
-            // correct width for the space not including letter-spacing, then
-            // just subtract that diff.
-            int diff = currentAdvance - spaceWidthWithoutLetterSpacing;
-            // The shaping can consist of a run of text, so only subtract the
-            // difference in the width of the glyph.
-            shaping.m_advance[glyphIndex] -= diff;
-            shaping.m_abc.abcB -= diff;
+            if (treatAsSpace) {
+                // currentAdvance does not include additional letter-spacing,
+                // but m_spaceWidth does. Here we find out how off we are from
+                // the correct width (spaceWidthWithoutLetterSpacing) and
+                // just subtract that diff.
+                int diff = currentAdvance - spaceWidthWithoutLetterSpacing;
+                // The shaping can consist of a run of text, so only subtract
+                // the difference in the width of the glyph.
+                shaping.m_advance[glyphIndex] -= diff;
+                shaping.m_abc.abcB -= diff;
+                continue;
+            }
+
+            // For characters treated as zero-width space in complex
+            // scripts, set the advance width to zero, adjust
+            // |abcB| of the current run accordingly and set
+            // the glyph to m_spaceGlyph (invisible).
+            shaping.m_advance[glyphIndex] = 0;
+            shaping.m_abc.abcB -= currentAdvance;
+            shaping.m_offsets[glyphIndex].du = 0;
+            shaping.m_offsets[glyphIndex].dv = 0;
+            shaping.m_glyphs[glyphIndex] = shaping.m_spaceGlyph;
         }
     }
 }
@@ -872,7 +867,7 @@ void UniscribeHelper::applySpacing()
         // extra wordspacing amount for the glyphs they correspond to.
         if (m_wordSpacing != 0) {
             for (int i = 0; i < shaping.charLength(); i++) {
-                if (!treatAsSpace(m_input[m_runs[run].iCharPos + i]))
+                if (!Font::treatAsSpace(m_input[m_runs[run].iCharPos + i]))
                     continue;

                 // The char in question is a word separator...
@@ -929,4 +924,31 @@ int UniscribeHelper::advanceForItem(int
     return shaping.m_prePadding + justification;
 }

+// SCRIPT_FONTPROPERTIES contains glyph indices for default, invalid
+// and blank glyphs. Just because ScriptShape succeeds does not mean
+// that a text run is rendered correctly. Some characters may be rendered
+// with default/invalid/blank glyphs. Therefore, we need to check if the glyph
+// array returned by ScriptShape contains any of those glyphs to make
+// sure that the text run is rendered successfully.
+// However, we should not subject zero-width characters to this test.
+
+bool UniscribeHelper::containsMissingGlyphs(const Shaping& shaping,
+                                            const SCRIPT_ITEM& run,
+                                            const SCRIPT_FONTPROPERTIES* properties) const
+{
+    for (int i = 0; i < shaping.charLength(); i++) {
+        UChar c = m_input[run.iCharPos + i];
+        // Skip zero-width space characters because they're not considered to be missing in a font.
+        if (Font::treatAsZeroWidthSpaceInComplexScript(c))
+            continue;
+        int glyphIndex = shaping.m_logs[i];
+        WORD glyph = shaping.m_glyphs[glyphIndex];
+        if (glyph == properties->wgDefault
+            || (glyph == properties->wgInvalid && glyph != properties->wgBlank))
+            return true;
+    }
+    return false;
+}
+
+
 }  // namespace WebCore
Index: Source/WebCore/platform/graphics/chromium/UniscribeHelper.h
===================================================================
--- Source/WebCore/platform/graphics/chromium/UniscribeHelper.h (revision 84099)
+++ Source/WebCore/platform/graphics/chromium/UniscribeHelper.h (working copy)
@@ -76,7 +76,8 @@ public:
                     bool isRtl,
                     HFONT,
                     SCRIPT_CACHE*,
-                    SCRIPT_FONTPROPERTIES*);
+                    SCRIPT_FONTPROPERTIES*,
+                    WORD);

     virtual ~UniscribeHelper();

@@ -225,7 +226,9 @@ private:
             : m_prePadding(0)
             , m_hfont(NULL)
             , m_scriptCache(NULL)
-            , m_ascentOffset(0) {
+            , m_ascentOffset(0)
+            , m_spaceGlyph(0)
+        {
             m_abc.abcA = 0;
             m_abc.abcB = 0;
             m_abc.abcC = 0;
@@ -319,6 +322,8 @@ private:
         // when drawing a string, to align multiple runs rendered with
         // different fonts.
         int m_ascentOffset;
+
+        WORD m_spaceGlyph;
     };

     // Computes the runs_ array from the text run.
@@ -343,6 +348,10 @@ private:
     // Returns the total width of a single item.
     int advanceForItem(int) const;

+    bool containsMissingGlyphs(const Shaping&,
+                               const SCRIPT_ITEM&,
+                               const SCRIPT_FONTPROPERTIES*) const;
+
     // Shapes a run (pointed to by |input|) using |hfont| first.
     // Tries a series of fonts specified retrieved with NextWinFontData
     // and finally a font covering characters in |*input|. A string pointed
@@ -384,6 +393,7 @@ private:
     int m_ascent;
     LOGFONT m_logfont;
     int m_style;
+    WORD m_spaceGlyph;

     // Options, see the getters/setters above.
     bool m_directionalOverride;
Index: Source/WebCore/platform/graphics/chromium/UniscribeHelperTextRun.cpp
===================================================================
--- Source/WebCore/platform/graphics/chromium/UniscribeHelperTextRun.cpp (revision 84099)
+++ Source/WebCore/platform/graphics/chromium/UniscribeHelperTextRun.cpp (working copy)
@@ -43,7 +43,8 @@ UniscribeHelperTextRun::UniscribeHelperT
     : UniscribeHelper(run.characters(), run.length(), run.rtl(),
                       font.primaryFont()->platformData().hfont(),
                       font.primaryFont()->platformData().scriptCache(),
-                      font.primaryFont()->platformData().scriptFontProperties())
+                      font.primaryFont()->platformData().scriptFontProperties(),
+                      font.primaryFont()->spaceGlyph())
     , m_font(&font)
     , m_fontIndex(0)
 {
@@ -69,7 +70,7 @@ UniscribeHelperTextRun::UniscribeHelperT
     SCRIPT_CACHE* scriptCache,
     SCRIPT_FONTPROPERTIES* fontProperties)
     : UniscribeHelper(input, inputLength, isRtl, hfont,
-                      scriptCache, fontProperties)
+                      scriptCache, fontProperties, 0)
     , m_font(0)
     , m_fontIndex(-1)
 {
Index: LayoutTests/ChangeLog
===================================================================
--- LayoutTests/ChangeLog (revision 84100)
+++ LayoutTests/ChangeLog (working copy)
@@ -1,3 +1,21 @@
+2011-04-17  Jungshik Shin  <jshin@chromium.org>
+
+        Reviewed by NOBODY (OOPS!).
+
+        Add a complex-script version of zero-width-characters.html.
+        and add U+FEFF to zero-width-characters.html
+        Chromium Linux fails the test because U+FEFF is rendered
+        with a non-zero width glyph.
+        Filed http://bugs.webkit.org/show_bug.cgi?id=58741 and noted
+        as such in test_expectation.txt.
+
+        https://bugs.webkit.org/show_bug.cgi?id=48860
+
+        * fast/text/zero-width-characters-complex-script-expected.txt: Added.
+        * fast/text/zero-width-characters-complex-script.html: Added.
+        * fast/text/zero-width-characters.html:
+        * platform/chromium/test_expectations.txt:
+
 2011-04-16  Dan Bernstein  <mitz@apple.com>

         Updated results for fast/block/float/032.html after r84096. Filed http://webkit.org/b/58736 to
Index: LayoutTests/fast/text/zero-width-characters-complex-script-expected.txt
===================================================================
--- LayoutTests/fast/text/zero-width-characters-complex-script-expected.txt (revision 0)
+++ LayoutTests/fast/text/zero-width-characters-complex-script-expected.txt (revision 0)
@@ -0,0 +1,3 @@
+This test checks various characters that should always be zero width to ensure that they are when enclosed by complex script characters. The WebKit text system ensures this in a way that's independent of the fonts installed on the system.
+
+PASS: All characters had zero-width.
Index: LayoutTests/fast/text/zero-width-characters-complex-script.html
===================================================================
--- LayoutTests/fast/text/zero-width-characters-complex-script.html (revision 0)
+++ LayoutTests/fast/text/zero-width-characters-complex-script.html (revision 0)
@@ -0,0 +1,66 @@
+<head>
+<script>
+
+function testChar(ch)
+{
+    // Strings a and b selected here do not have any 'interaction' between them.
+    var a = "\u0915\u093E"
+    var b = "\u0916";
+    var span = document.getElementById("characters");
+    span.firstChild.data = a + b;
+    var abWidth = span.offsetWidth;
+    span.firstChild.data = a;
+    var aWidth = span.offsetWidth;
+    span.firstChild.data = a + String.fromCharCode(ch) + b;
+    var abWithChWidth = span.offsetWidth;
+
+    if (abWithChWidth > abWidth)
+        return 1;
+    if (abWidth > aWidth)
+        return 0;
+    return 1;
+}
+
+function test()
+{
+    if (window.layoutTestController)
+        layoutTestController.dumpAsText();
+    var failedCount = 0;
+    for (var i = 1; i < 32; ++i)
+        if (i != 9 && i != 10 && i != 13)
+            failedCount += testChar(i);
+
+    for (var i = 0x7F; i < 0xA0; ++i)
+        failedCount += testChar(i);
+    failedCount += testChar(0xAD);
+    // ZWJ (U+200C) and ZWNJ (U+200D) are excluded because they
+    // can affect the rendering in complex script text.
+    failedCount += testChar(0x200B);
+    failedCount += testChar(0x200E);
+    failedCount += testChar(0x200F);
+    failedCount += testChar(0x202A);
+    failedCount += testChar(0x202B);
+    failedCount += testChar(0x202C);
+    failedCount += testChar(0x202D);
+    failedCount += testChar(0x202E);
+    failedCount += testChar(0xFEFF);
+    failedCount += testChar(0xFFFC);
+
+    var testArea = document.getElementById("testArea");
+    testArea.parentNode.removeChild(testArea);
+
+    if (failedCount > 0)
+        result = "FAIL: " + failedCount + " characters had non-zero width" +
+                 " or failed to get measured.";
+    else
+        result = "PASS: All characters had zero-width.";
+    document.getElementById("result").firstChild.data = result;
+}
+</script>
+</head>
+<body onload="test()">
+<p>This test checks various characters that should always be zero width to ensure that they are when enclosed by complex script characters.
+The WebKit text system ensures this in a way that's independent of the fonts installed on the system.</p>
+<p id="result">FAIL: Script did not run to completion.</p>
+<p id="testArea"><span id="characters">&#x0915;&#x093E;&#x0916;</span></p>
+</body>
Index: LayoutTests/fast/text/zero-width-characters.html
===================================================================
--- LayoutTests/fast/text/zero-width-characters.html (revision 84099)
+++ LayoutTests/fast/text/zero-width-characters.html (working copy)
@@ -13,6 +13,7 @@ function test()
     testString += String.fromCharCode(0x200D);
     testString += String.fromCharCode(0x200E);
     testString += String.fromCharCode(0x200F);
+    testString += String.fromCharCode(0xFEFF);
     testString += String.fromCharCode(0xFFFC);
     var span = document.getElementById("characters");
     var abWidth = span.offsetWidth;
Index: LayoutTests/platform/chromium/test_expectations.txt
===================================================================
--- LayoutTests/platform/chromium/test_expectations.txt (revision 84099)
+++ LayoutTests/platform/chromium/test_expectations.txt (working copy)
@@ -3534,4 +3534,5 @@ BUGMORRITA : fast/html/details-remove-su
 BUGMORRITA : fast/html/details-writing-mode.html = FAIL

 BUGWK58619 GPU LINUX WIN : media/video-volume-slider.html = IMAGE
+BUGWK58741 LINUX : fast/text/zero-width-characters-complex-script.html = FAIL

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-19 Igor Oliveira <igor.oliveira@openbossa.org>
commit-queue@webkit.org [Tue, 19 Apr 2011 17:15:25 +0000 (17:15 +0000)]
2011-04-19  Igor Oliveira  <igor.oliveira@openbossa.org>

        Reviewed by Andreas Kling.

        [Qt] X11: Text selection is causing oncopy event to be called
        https://bugs.webkit.org/show_bug.cgi?id=58656

        Always when text is selected the oncopy event is fired, this behavior does
        not exist in Firefox or Chrome. Now, when selecting a text, QtWebKit
        is making multi part-copies (with rich text metadata), the multi-part
        data can be obtained by data transfer items interface when supported by QtWebKit.
        Also, copies to the clipboard of a selected image, is not supported by Chrome and
        Firefox and was removed from QtWebKit.

        * Api/qwebpage.cpp:
        (QWebPagePrivate::handleClipboard):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-19 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Tue, 19 Apr 2011 17:05:16 +0000 (17:05 +0000)]
2011-04-19  Jer Noble  <jer.noble@apple.com>

        Reviewed by Adam Roben.

        REGRESSION (r84206): 50 tests failing on SnowLeopard Intel Release (WebKit2 Tests) due to extra "supportsFullScreen() == true" output
        https://bugs.webkit.org/show_bug.cgi?id=58890

        Add a layoutTestController flag which controls when full screen callbacks are written to stdout.
        Defaults to false.

        * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added dumpFullScreenCallbacks().
        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
        (WTR::InjectedBundlePage::supportsFullScreen): Only write to stdout if shouldDumpFullScreenCallbacks is set.
        (WTR::InjectedBundlePage::enterFullScreenForElement): Ditto.
        (WTR::InjectedBundlePage::exitFullScreenForElement): Ditto.
        * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
        (WTR::LayoutTestController::LayoutTestController): Initialize new ivar.
        * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
        (WTR::LayoutTestController::dumpFullScreenCallbacks): Added.
        (WTR::LayoutTestController::shouldDumpFullScreenCallbacks): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoExtend the DIBPixelData class with the facility for writing the
bfulgham@webkit.org [Tue, 19 Apr 2011 17:00:46 +0000 (17:00 +0000)]
Extend the DIBPixelData class with the facility for writing the
bitmap representation to disk for debugging purposes.
https://bugs.webkit.org/show_bug.cgi?id=58862.

Reviewed by Adam Roben.

* platform/graphics/win/DIBPixelData.cpp:
(WebCore::DIBPixelData::writeToFile): New function.
* platform/graphics/win/DIBPixelData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-19 Vsevolod Vlasov <vsevik@chromium.org>
commit-queue@webkit.org [Tue, 19 Apr 2011 16:56:17 +0000 (16:56 +0000)]
2011-04-19  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Rename lengthReceived to encodedDataLength/dataLength
        https://bugs.webkit.org/show_bug.cgi?id=58883

        * fileapi/FileReaderLoader.cpp:
        (WebCore::FileReaderLoader::didReceiveData):
        * inspector/InspectorInstrumentation.cpp:
        (WebCore::InspectorInstrumentation::didReceiveContentLengthImpl):
        * inspector/InspectorInstrumentation.h:
        (WebCore::InspectorInstrumentation::didReceiveContentLength):
        * inspector/InspectorResourceAgent.cpp:
        (WebCore::InspectorResourceAgent::didReceiveContentLength):
        * inspector/InspectorResourceAgent.h:
        * inspector/front-end/NetworkManager.js:
        (WebInspector.NetworkDispatcher.prototype.dataReceived):
        * loader/DocumentThreadableLoader.cpp:
        (WebCore::DocumentThreadableLoader::didReceiveData):
        (WebCore::DocumentThreadableLoader::didReceiveCachedMetadata):
        * loader/DocumentThreadableLoader.h:
        * loader/FrameLoaderClient.h:
        * loader/MainResourceLoader.cpp:
        (WebCore::MainResourceLoader::didReceiveData):
        * loader/MainResourceLoader.h:
        * loader/NetscapePlugInStreamLoader.cpp:
        (WebCore::NetscapePlugInStreamLoader::didReceiveData):
        * loader/NetscapePlugInStreamLoader.h:
        * loader/ResourceLoadNotifier.cpp:
        (WebCore::ResourceLoadNotifier::didReceiveData):
        (WebCore::ResourceLoadNotifier::dispatchDidReceiveContentLength):
        (WebCore::ResourceLoadNotifier::sendRemainingDelegateMessages):
        * loader/ResourceLoadNotifier.h:
        * loader/ResourceLoader.cpp:
        (WebCore::ResourceLoader::didReceiveData):
        * loader/ResourceLoader.h:
        * loader/SubresourceLoader.cpp:
        (WebCore::SubresourceLoader::didReceiveData):
        * loader/SubresourceLoader.h:
        * loader/SubresourceLoaderClient.h:
        (WebCore::SubresourceLoaderClient::didReceiveData):
        (WebCore::SubresourceLoaderClient::didReceiveCachedMetadata):
        * loader/WorkerThreadableLoader.cpp:
        (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveData):
        (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveCachedMetadata):
        * loader/appcache/ApplicationCacheGroup.cpp:
        (WebCore::ApplicationCacheGroup::didReceiveData):
        * loader/appcache/ApplicationCacheGroup.h:
        * loader/appcache/ApplicationCacheHost.h:
        * notifications/Notification.cpp:
        (WebCore::Notification::didReceiveData):
        * notifications/Notification.h:
        * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
        (StreamingClient::didReceiveData):
        * platform/network/BlobResourceHandle.cpp:
        * platform/network/ResourceHandleClient.h:
        (WebCore::ResourceHandleClient::didReceiveData):
        * platform/network/android/ResourceHandleAndroid.cpp:
        (WebCore::SyncLoader::didReceiveData):
        * platform/network/cf/ResourceHandleCFNet.cpp:
        (WebCore::WebCoreSynchronousLoaderClient::didReceiveData):
        * platform/network/curl/ResourceHandleCurl.cpp:
        * platform/network/mac/ResourceHandleMac.mm:
        (WebCoreSynchronousLoaderClient::didReceiveData):
        * platform/network/soup/ResourceHandleSoup.cpp:
        * platform/network/win/ResourceHandleWin.cpp:
        * workers/WorkerScriptLoader.h:
        * xml/XMLHttpRequest.h:
2011-04-19  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Rename lengthReceived to encodedDataLength/dataLength
        https://bugs.webkit.org/show_bug.cgi?id=58883

        Renamed lengthReceived to encodedDataLength/dataLength.

        * public/WebURLLoaderClient.h:
        (WebKit::WebURLLoaderClient::didReceiveData):
        * src/AssociatedURLLoader.cpp:
        (WebKit::AssociatedURLLoader::ClientAdapter::didReceiveCachedMetadata):
        * src/FrameLoaderClientImpl.cpp:
        (WebKit::FrameLoaderClientImpl::dispatchDidReceiveContentLength):
        * src/FrameLoaderClientImpl.h:
        * src/ResourceHandle.cpp:
        (WebCore::ResourceHandleInternal::didReceiveData):
2011-04-19  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Rename lengthReceived to encodedDataLength/dataLength
        https://bugs.webkit.org/show_bug.cgi?id=58883

        * WebCoreSupport/FrameLoaderClientEfl.cpp:
        (WebCore::FrameLoaderClientEfl::dispatchDidReceiveContentLength):
        * WebCoreSupport/FrameLoaderClientEfl.h:
2011-04-19  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Rename lengthReceived to encodedDataLength/dataLength
        https://bugs.webkit.org/show_bug.cgi?id=58883

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::dispatchDidReceiveContentLength):
        * WebCoreSupport/FrameLoaderClientGtk.h:
        * webkit/webkitdownload.cpp:
        (DownloadClient::didReceiveData):
2011-04-19  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Rename lengthReceived to encodedDataLength/dataLength
        https://bugs.webkit.org/show_bug.cgi?id=58883

        * WebCoreSupport/WebFrameLoaderClient.h:
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::dispatchDidReceiveContentLength):
2011-04-19  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Rename lengthReceived to encodedDataLength/dataLength
        https://bugs.webkit.org/show_bug.cgi?id=58883

        * WebCoreSupport/WebFrameLoaderClient.h:
2011-04-19  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Rename lengthReceived to encodedDataLength/dataLength
        https://bugs.webkit.org/show_bug.cgi?id=58883

        * WebCoreSupport/FrameLoaderClientWinCE.h:
2011-04-19  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Rename lengthReceived to encodedDataLength/dataLength
        https://bugs.webkit.org/show_bug.cgi?id=58883

        * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebKit::WebFrameLoaderClient::dispatchDidReceiveContentLength):
        * WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-19 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Tue, 19 Apr 2011 16:52:34 +0000 (16:52 +0000)]
2011-04-19  Stephen White  <senorblanco@chromium.org>

        Reviewed by Eric Seidel.

        Pull framebuffer clearing out into its own function.
        https://bugs.webkit.org/show_bug.cgi?id=58897

        Covered by fast/canvas and canvas/philip tests.

        * platform/graphics/gpu/DrawingBuffer.cpp:
        (WebCore::DrawingBuffer::clearFramebuffer):
        (WebCore::DrawingBuffer::reset):
        * platform/graphics/gpu/DrawingBuffer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-19 Vsevolod Vlasov <vsevik@chromium.org>
commit-queue@webkit.org [Tue, 19 Apr 2011 16:36:05 +0000 (16:36 +0000)]
2011-04-19  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Pavel Feldman.

        Chromium DevTools: Network panel timing test is flaky
        https://bugs.webkit.org/show_bug.cgi?id=58699

        Fixed network timing test flakiness.

        * src/js/Tests.js:
        (.TestSuite.prototype.testNetworkTiming.finishResource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-19 Brian Salomon <bsalomon@google.com>
commit-queue@webkit.org [Tue, 19 Apr 2011 16:25:09 +0000 (16:25 +0000)]
2011-04-19 Brian Salomon <bsalomon@google.com>

        Reviewed by Eric Seidel.

        When flushing GrContext in ~PlatformContextSkia be sure correct GL context is set
        https://bugs.webkit.org/show_bug.cgi?id=58788

        Chromium browser test will be added that loads canvas page and then an
        acclerated-composited page. Test must trigger ~PlatformContextSkia()
        followed by invocation of GL compositor.

        * platform/graphics/skia/PlatformContextSkia.cpp:
        (WebCore::PlatformContextSkia::~PlatformContextSkia):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-19 Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu>
commit-queue@webkit.org [Tue, 19 Apr 2011 16:01:13 +0000 (16:01 +0000)]
2011-04-19  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>

        Reviewed by Andreas Kling.

        [Qt] fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html fails (DRT sideeffect)
        https://bugs.webkit.org/show_bug.cgi?id=35086

        * platform/qt/Skipped: unskip fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html
2011-04-19  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>

        Reviewed by Andreas Kling.

        [Qt] fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html fails (DRT sideeffect)
        https://bugs.webkit.org/show_bug.cgi?id=35086

        fast/xmlhttprequest/xmlhttprequest-no-file-access.html caused
        a DRT sideeffect problem, because the resetSettings didn't set
        the default value of LocalContentCanAccessFileUrls.

        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        (WebCore::WebPage::resetSettings):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-19 John Knottenbelt <jknotten@chromium.org>
jknotten@chromium.org [Tue, 19 Apr 2011 15:38:35 +0000 (15:38 +0000)]
2011-04-19  John Knottenbelt  <jknotten@chromium.org>

        Unreviewed.

        [Chromium] Mark fast/block/float/overhanging-tall-block.html as failing on Windows and Linux.
        https://bugs.webkit.org/show_bug.cgi?id=58901

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-19 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Tue, 19 Apr 2011 14:43:24 +0000 (14:43 +0000)]
2011-04-19  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: add chrome.devTools alias to webInspector namespace for chromium port
        https://bugs.webkit.org/show_bug.cgi?id=58894

        * src/js/DevTools.js:
        (WebInspector.platformExtensionAPI):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-19 Andreas Kling <andreas.kling@nokia.com>
andreas.kling@nokia.com [Tue, 19 Apr 2011 14:35:33 +0000 (14:35 +0000)]
2011-04-19  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Antonio Gomes.

        WebKit2: Typo fix in WebPopupMenu::Type.
        https://bugs.webkit.org/show_bug.cgi?id=58891

        Fixed a typo, Seperator -> Separator.
        Also removed m_ prefix on an argument variable name.

        * Shared/WebPopupItem.h:
        * UIProcess/mac/WebPopupMenuProxyMac.mm:
        (WebKit::WebPopupMenuProxyMac::populate):
        * WebProcess/WebCoreSupport/WebPopupMenu.cpp:
        (WebKit::WebPopupMenu::populateItems):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] REGRESSION(84176): http/tests/xmlhttprequest/event-listener-gc.html fails
ossy@webkit.org [Tue, 19 Apr 2011 14:05:00 +0000 (14:05 +0000)]
[Qt] REGRESSION(84176): http/tests/xmlhttprequest/event-listener-gc.html fails
https://bugs.webkit.org/show_bug.cgi?id=58871

Unreviewed, rolling out r84176, r84178, r84186, r84212 and r84231.
http://trac.webkit.org/changeset/84176 (original patch)
http://trac.webkit.org/changeset/84178 (original patch - part 2)
http://trac.webkit.org/changeset/84186 (build fix)
http://trac.webkit.org/changeset/84212
http://trac.webkit.org/changeset/84231 (skip failing test)

original bugs:
 - https://bugs.webkit.org/show_bug.cgi?id=58718
 - https://bugs.webkit.org/show_bug.cgi?id=58853

Source/JavaScriptCore:

* heap/MarkStack.h:
(JSC::MarkStack::deprecatedAppendValues):
(JSC::MarkStack::append):
(JSC::MarkStack::deprecatedAppend):
* runtime/JSValue.h:
* runtime/WriteBarrier.h:
(JSC::DeprecatedPtr::DeprecatedPtr):
(JSC::DeprecatedPtr::get):
(JSC::DeprecatedPtr::operator*):
(JSC::DeprecatedPtr::operator->):
(JSC::DeprecatedPtr::slot):
(JSC::DeprecatedPtr::operator UnspecifiedBoolType*):
(JSC::DeprecatedPtr::operator!):
(JSC::operator==):

Source/WebCore:

* bridge/qt/qt_class.cpp:
(JSC::Bindings::QtClass::fallbackObject):
* bridge/qt/qt_instance.cpp:
(JSC::Bindings::QtInstance::removeCachedMethod):
(JSC::Bindings::QtInstance::markAggregate):
* bridge/qt/qt_instance.h:

LayoutTests:

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-19 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Tue, 19 Apr 2011 13:41:54 +0000 (13:41 +0000)]
2011-04-19  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r84050.
        http://trac.webkit.org/changeset/84050
        https://bugs.webkit.org/show_bug.cgi?id=58892

        fast/dom/HTMLKeygenElement/keygen.html is crashing on Chromium
        (Requested by jknotten on #webkit).

        * dom/ContainerNode.cpp:
        (WebCore::ContainerNode::takeAllChildrenFrom):
        (WebCore::ContainerNode::removeBetween):
        (WebCore::ContainerNode::removeChildren):
        (WebCore::ContainerNode::parserAddChild):
        * dom/Document.cpp:
        (WebCore::Document::Document):
        (WebCore::Document::~Document):
        (WebCore::Document::setDocType):
        * dom/Element.h:
        * dom/Node.cpp:
        (WebCore::Node::treeScope):
        (WebCore::Node::setTreeScope):
        (WebCore::Node::setTreeScopeRecursively):
        * dom/Node.h:
        (WebCore::Node::document):
        * dom/ShadowRoot.cpp:
        (WebCore::ShadowRoot::ShadowRoot):
        * dom/ShadowRoot.h:
        * dom/TreeScope.cpp:
        (WebCore::TreeScope::TreeScope):
        (WebCore::TreeScope::setParentTreeScope):
        * dom/TreeScope.h:
        * rendering/RenderSlider.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-19 Kinuko Yasuda <kinuko@chromium.org>
kinuko@chromium.org [Tue, 19 Apr 2011 13:15:23 +0000 (13:15 +0000)]
2011-04-19  Kinuko Yasuda  <kinuko@chromium.org>

        Not reviewed; another build fix attempt.

        * src/StorageInfoChromium.cpp:
        (WebCore::StorageInfo::queryUsageAndQuota):
        (WebCore::StorageInfo::requestQuota):
        * src/WebStorageQuotaCallbacksImpl.cpp:
        (WebKit::WebStorageQuotaCallbacksImpl::WebStorageQuotaCallbacksImpl):
        * src/WebStorageQuotaCallbacksImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-19 Kinuko Yasuda <kinuko@chromium.org>
kinuko@chromium.org [Tue, 19 Apr 2011 12:49:34 +0000 (12:49 +0000)]
2011-04-19  Kinuko Yasuda  <kinuko@chromium.org>

        Not reviewed; windows build fix attempt.

        * storage/StorageInfo.cpp:
        (WebCore::StorageInfo::~StorageInfo):
        * storage/StorageInfo.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-19 John Knottenbelt <jknotten@chromium.org>
jknotten@chromium.org [Tue, 19 Apr 2011 12:45:06 +0000 (12:45 +0000)]
2011-04-19  John Knottenbelt  <jknotten@chromium.org>

        Unreviewed.

        [Chromium] New mac snowleopard baseline for fast/overflow/003.xml
        https://bugs.webkit.org/show_bug.cgi?id=58885

        * platform/chromium-mac/fast/overflow/003-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-19 Kinuko Yasuda <kinuko@chromium.org>
kinuko@chromium.org [Tue, 19 Apr 2011 12:37:03 +0000 (12:37 +0000)]
2011-04-19  Kinuko Yasuda  <kinuko@chromium.org>

        Reviewed by David Levin.

        [Chromium] Enable QUOTA API at runtime if enable-quota flag is given
        https://bugs.webkit.org/show_bug.cgi?id=58784

        * features.gypi: Added ENABLE_QUOTA=1.
        * public/WebRuntimeFeatures.h:
        * src/WebRuntimeFeatures.cpp:
        (WebKit::WebRuntimeFeatures::enableQuota): Added.
        (WebKit::WebRuntimeFeatures::isQuotaEnabled): Added.
2011-04-19  Kinuko Yasuda  <kinuko@chromium.org>

        Reviewed by David Levin.

        [Chromium] Enable QUOTA API at runtime if enable-quota flag is given
        https://bugs.webkit.org/show_bug.cgi?id=58784

        No new tests as this does not change any functionality.

        * bindings/generic/RuntimeEnabledFeatures.cpp:
        * bindings/generic/RuntimeEnabledFeatures.h:
        (WebCore::RuntimeEnabledFeatures::quotaEnabled):
        (WebCore::RuntimeEnabledFeatures::setQuotaEnabled):
        * page/DOMWindow.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-19 John Knottenbelt <jknotten@chromium.org>
jknotten@chromium.org [Tue, 19 Apr 2011 12:13:24 +0000 (12:13 +0000)]
2011-04-19  John Knottenbelt  <jknotten@chromium.org>

        Unreviewed.

        [Chromium] Mark fast/css/create_element_align.xhtml as slow.
        https://bugs.webkit.org/show_bug.cgi?id=58884

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-19 John Knottenbelt <jknotten@chromium.org>
jknotten@chromium.org [Tue, 19 Apr 2011 12:01:57 +0000 (12:01 +0000)]
2011-04-19  John Knottenbelt  <jknotten@chromium.org>

        Unreviewed.

        [Chromium] Mark fast/events/popup-blocking-timers.html as flaky on Debug Win,Mac,Linux
        https://bugs.webkit.org/show_bug.cgi?id=58882

        Filed chromium bug:
        http://code.google.com/p/chromium/issues/detail?id=79857

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-19 John Knottenbelt <jknotten@chromium.org>
jknotten@chromium.org [Tue, 19 Apr 2011 11:44:00 +0000 (11:44 +0000)]
2011-04-19  John Knottenbelt  <jknotten@chromium.org>

        Unreviewed.

        [Chromium] Mark fast/css/only-child-pseudo-class.html as flaky
        https://bugs.webkit.org/show_bug.cgi?id=58881

        Filed chromium bug:
        http://code.google.com/p/chromium/issues/detail?id=79855

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSkip new eventSender dependent tests.
kbalazs@webkit.org [Tue, 19 Apr 2011 11:35:42 +0000 (11:35 +0000)]
Skip new eventSender dependent tests.

Rubber-stamped by Csaba Osztrogonác.

* platform/qt-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-19 John Knottenbelt <jknotten@chromium.org>
jknotten@chromium.org [Tue, 19 Apr 2011 11:32:02 +0000 (11:32 +0000)]
2011-04-19  John Knottenbelt  <jknotten@chromium.org>

        Unreviewed.

        [Chromium] Mark animations/play-state.html as flaky.
        https://bugs.webkit.org/show_bug.cgi?id=58880

See also existing chromium bug:
http://code.google.com/p/chromium/issues/detail?id=76609

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-19 John Knottenbelt <jknotten@chromium.org>
jknotten@chromium.org [Tue, 19 Apr 2011 11:19:28 +0000 (11:19 +0000)]
2011-04-19  John Knottenbelt  <jknotten@chromium.org>

        Unreviewed.

        [Chromium] Mark tables/mozilla/bugs/bug28341.html as flaky on Mac
        https://bugs.webkit.org/show_bug.cgi?id=58879

See also existing chromium bug:
http://code.google.com/p/chromium/issues/detail?id=32231

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-19 John Knottenbelt <jknotten@chromium.org>
jknotten@chromium.org [Tue, 19 Apr 2011 11:09:30 +0000 (11:09 +0000)]
2011-04-19  John Knottenbelt  <jknotten@chromium.org>

        Unreviewed.

        [Chromium] Mark svg/text/font-size-below-point-five.svg as flaky on Linux, Mac
        https://bugs.webkit.org/show_bug.cgi?id=58878

See also existing chromium bug:
http://code.google.com/p/chromium/issues/detail?id=74710

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-19 John Knottenbelt <jknotten@chromium.org>
jknotten@chromium.org [Tue, 19 Apr 2011 10:49:39 +0000 (10:49 +0000)]
2011-04-19  John Knottenbelt  <jknotten@chromium.org>

        Unreviewed.

        [Chromium] Mark layout test editing/execCommand/delete-empty-container.html as flaky
        https://bugs.webkit.org/show_bug.cgi?id=58877

Chromium bug filed.
http://code.google.com/p/chromium/issues/detail?id=79854

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-19 John Gregg <johnnyg@google.com>
johnnyg@google.com [Tue, 19 Apr 2011 10:07:51 +0000 (10:07 +0000)]
2011-04-19  John Gregg  <johnnyg@google.com>

        Reviewed by Darin Fisher.

        Enable folder drag-n-drop when using a "webkitdirectory" file input
        https://bugs.webkit.org/show_bug.cgi?id=58401

        This uses a new ChromeClient API to enumerate the directory and
        return all the files, as if the user had selected that directory
        by clicking the control in the normal way.

        * loader/EmptyClients.h:
        (WebCore::EmptyChromeClient::enumerateChosenDirectory):
        * page/Chrome.cpp:
        (WebCore::Chrome::enumerateChosenDirectory):
        * page/Chrome.h:
        * page/ChromeClient.h:
        * platform/network/FormData.cpp:
        (WebCore::FormData::appendKeyValuePairItems):
        * rendering/RenderFileUploadControl.cpp:
        (WebCore::RenderFileUploadControl::receiveDropForDirectoryUpload):
        (WebCore::RenderFileUploadControl::receiveDroppedFiles):
        * rendering/RenderFileUploadControl.h:
2011-04-19  John Gregg  <johnnyg@google.com>

        Reviewed by Darin Fisher.

        Enable folder drag-n-drop when using a "webkitdirectory" file input
        https://bugs.webkit.org/show_bug.cgi?id=58401

        This uses a new ChromeClient API to enumerate the directory and
        return all the files, as if the user had selected that directory
        by clicking the control in the normal way.

        * public/WebViewClient.h:
        (WebKit::WebViewClient::enumerateChosenDirectory):
        * src/ChromeClientImpl.cpp:
        (WebKit::ChromeClientImpl::enumerateChosenDirectory):
        * src/ChromeClientImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-19 John Knottenbelt <jknotten@chromium.org>
jknotten@chromium.org [Tue, 19 Apr 2011 10:04:44 +0000 (10:04 +0000)]
2011-04-19  John Knottenbelt  <jknotten@chromium.org>

        Unreviewed.

        [Chromium] Mark animations/combo-transform-translate+scale.html as flaky
        https://bugs.webkit.org/show_bug.cgi?id=58876

        Chromium bug filed.
        http://code.google.com/p/chromium/issues/detail?id=79853

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-19 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Tue, 19 Apr 2011 09:58:22 +0000 (09:58 +0000)]
2011-04-19  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r84150.
        http://trac.webkit.org/changeset/84150
        https://bugs.webkit.org/show_bug.cgi?id=58875

        Broken backspace in Search box of Web Inspector (Requested by
        apavlov on #webkit).

        * inspector/front-end/inspector.js:
        (WebInspector.documentKeyDown):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-19 Andrey Adaikin <aandrey@google.com>
pfeldman@chromium.org [Tue, 19 Apr 2011 09:53:26 +0000 (09:53 +0000)]
2011-04-19  Andrey Adaikin  <aandrey@google.com>

        Reviewed by Pavel Feldman.

        Web Inspector: NPE in TextEditorModel
        https://bugs.webkit.org/show_bug.cgi?id=58870

        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourcesPanel.prototype._frameAdded):
        * inspector/front-end/TextEditorModel.js:
        (WebInspector.TextEditorModel.prototype.setText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-19 John Knottenbelt <jknotten@chromium.org>
jknotten@chromium.org [Tue, 19 Apr 2011 09:50:57 +0000 (09:50 +0000)]
2011-04-19  John Knottenbelt  <jknotten@chromium.org>

        Unreviewed.

        [Chromium] Mark fast/table/frame-and-rules.html as flaky
        https://bugs.webkit.org/show_bug.cgi?id=58874

        Chromium bug filed.
        http://code.google.com/p/chromium/issues/detail?id=79851

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-19 John Knottenbelt <jknotten@chromium.org>
jknotten@chromium.org [Tue, 19 Apr 2011 09:34:04 +0000 (09:34 +0000)]
2011-04-19  John Knottenbelt  <jknotten@chromium.org>

        Unreviewed.

        [Chromium] Reenable layout test canvas/philip/tests/2d.gradient.interpolate.outside.html
        https://bugs.webkit.org/show_bug.cgi?id=58873

Fixed in Chromium r81956.
http://code.google.com/p/chromium/issues/detail?id=79725

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-19 Hans Wennborg <hans@chromium.org>
hans@chromium.org [Tue, 19 Apr 2011 09:04:47 +0000 (09:04 +0000)]
2011-04-19  Hans Wennborg  <hans@chromium.org>

        Reviewed by Tony Gentilcore.

        IndexedDB: Remove accidental header include directive from LevelDB backend.
        https://bugs.webkit.org/show_bug.cgi?id=58872

        No new functionality, no new tests.

        * storage/IDBLevelDBBackingStore.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] REGRESSION(84194): http/tests/xmlhttprequest/event-listener-gc.html fails
ossy@webkit.org [Tue, 19 Apr 2011 09:02:13 +0000 (09:02 +0000)]
[Qt] REGRESSION(84194): http/tests/xmlhttprequest/event-listener-gc.html fails
https://bugs.webkit.org/show_bug.cgi?id=58871

* platform/qt/Skipped: Add http/tests/xmlhttprequest/event-listener-gc.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-19 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Tue, 19 Apr 2011 08:30:53 +0000 (08:30 +0000)]
2011-04-19  Mario Sanchez Prada  <msanchez@igalia.com>

        Unreviewed, rebaselines to fix wrongly added expectations.

        By mistake, I added expectations generated with GTK3 locally
        instead of the expectations generated in the bots using GTK2, so
        we need to add the expectation files as needed.

        * platform/gtk/fast/blockflow/border-styles-vertical-lr-expected.checksum:
        * platform/gtk/fast/blockflow/border-styles-vertical-lr-expected.png:
        * platform/gtk/fast/blockflow/border-styles-vertical-rl-expected.checksum:
        * platform/gtk/fast/blockflow/border-styles-vertical-rl-expected.png:
        * platform/gtk/fast/borders/border-styles-split-expected.checksum:
        * platform/gtk/fast/borders/border-styles-split-expected.png:
        * platform/gtk/fast/borders/mixed-border-styles-radius-expected.checksum:
        * platform/gtk/fast/borders/mixed-border-styles-radius-expected.png:
        * platform/gtk/fast/borders/mixed-border-styles-radius2-expected.checksum:
        * platform/gtk/fast/borders/mixed-border-styles-radius2-expected.png:
        * platform/gtk/fast/borders/webkit-border-radius-expected.checksum:
        * platform/gtk/fast/borders/webkit-border-radius-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWKContextDownloadURLRequest() should return a WKDownloadRef
jhoneycutt@apple.com [Tue, 19 Apr 2011 08:30:00 +0000 (08:30 +0000)]
WKContextDownloadURLRequest() should return a WKDownloadRef
https://bugs.webkit.org/show_bug.cgi?id=58867
Part of <rdar://problem/8931717>

Reviewed by Steve Falkenburg.

* UIProcess/API/C/WKContext.cpp:
(WKContextDownloadURLRequest):
Return the result of calling WebContext::download().

* UIProcess/API/C/WKContext.h:
Updated return type of WKContextDownloadURLRequest().

* UIProcess/WebContext.cpp:
(WebKit::WebContext::download):
Return the DownloadProxy returned by createDownloadProxy().
(WebKit::WebContext::createDownloadProxy):
Return the DownloadProxy.

* UIProcess/WebContext.h:
Changed return type of download() and createDownloadProxy().

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::receivedPolicyDecision):
Call the DownloadProxy's downloadID() function to get the ID.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix.
zherczeg@webkit.org [Tue, 19 Apr 2011 08:25:19 +0000 (08:25 +0000)]
Build fix.

LEFilter change doesn't compile on ARM neon targets
https://bugs.webkit.org/show_bug.cgi?id=58671

Thanks for Charlie Lee to fixing this.

* WebCore.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-19 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Tue, 19 Apr 2011 08:06:53 +0000 (08:06 +0000)]
2011-04-19  Mario Sanchez Prada  <msanchez@igalia.com>

        Unreviewed, added new baselines for the GTK port.

        Added missing baselines to GTK after revisions 83998, 84092 and 84180.

        * platform/gtk/fast/blockflow/border-styles-vertical-lr-expected.checksum: Added.
        * platform/gtk/fast/blockflow/border-styles-vertical-lr-expected.png: Added.
        * platform/gtk/fast/blockflow/border-styles-vertical-lr-expected.txt: Added.
        * platform/gtk/fast/blockflow/border-styles-vertical-rl-expected.checksum: Added.
        * platform/gtk/fast/blockflow/border-styles-vertical-rl-expected.png: Added.
        * platform/gtk/fast/blockflow/border-styles-vertical-rl-expected.txt: Added.
        * platform/gtk/fast/borders/border-styles-split-expected.checksum: Added.
        * platform/gtk/fast/borders/border-styles-split-expected.png: Added.
        * platform/gtk/fast/borders/border-styles-split-expected.txt: Added.
        * platform/gtk/fast/borders/mixed-border-styles-expected.checksum: Added.
        * platform/gtk/fast/borders/mixed-border-styles-expected.png: Added.
        * platform/gtk/fast/borders/mixed-border-styles-expected.txt: Added.
        * platform/gtk/fast/borders/mixed-border-styles-radius-expected.checksum: Added.
        * platform/gtk/fast/borders/mixed-border-styles-radius-expected.png: Added.
        * platform/gtk/fast/borders/mixed-border-styles-radius-expected.txt: Added.
        * platform/gtk/fast/borders/mixed-border-styles-radius2-expected.checksum: Added.
        * platform/gtk/fast/borders/mixed-border-styles-radius2-expected.png: Added.
        * platform/gtk/fast/borders/mixed-border-styles-radius2-expected.txt: Added.
        * platform/gtk/fast/borders/webkit-border-radius-expected.checksum: Added.
        * platform/gtk/fast/borders/webkit-border-radius-expected.png: Added.
        * platform/gtk/fast/borders/webkit-border-radius-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-19 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Tue, 19 Apr 2011 07:24:34 +0000 (07:24 +0000)]
2011-04-19  Daniel Bates  <dbates@webkit.org>

        Attempt to fix the Qt Linux Release Minimal build after changeset 84225
        <http://trac.webkit.org/changeset/84225> (https://bugs.webkit.org/show_bug.cgi?id=52788).

        * dom/EventDispatcher.cpp:
        (WebCore::EventDispatcher::ensureEventAncestors): Add ENABLE(SVG) guards around call
        to Node::svgShadowHost() since this method is only defined when building with SVG enabled.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-18 Dominic Cooney <dominicc@chromium.org>
commit-queue@webkit.org [Tue, 19 Apr 2011 05:44:15 +0000 (05:44 +0000)]
2011-04-18  Dominic Cooney  <dominicc@chromium.org>

        Reviewed by Dimitri Glazkov.

        Makes SVG shadow roots and DOM shadow roots distinct.
        https://bugs.webkit.org/show_bug.cgi?id=52788

        Not a functional change. Covered by existing SVG tests.

        * dom/EventDispatcher.cpp:
        (WebCore::findElementInstance):
        (WebCore::EventDispatcher::adjustToShadowBoundaries):
        (WebCore::EventDispatcher::adjustRelatedTarget):
        (WebCore::EventDispatcher::ensureEventAncestors):
        * dom/Node.cpp:
        (WebCore::Node::setShadowHost):
        (WebCore::Node::svgShadowHost):
        (WebCore::Node::shadowTreeRootNode):
        * dom/Node.h:
        (WebCore::Node::isSVGShadowRoot):
        (WebCore::Node::parentNode):
        (WebCore::Node::parentNodeGuaranteedHostFree):
        * rendering/svg/RenderSVGShadowTreeRootContainer.cpp:
        (WebCore::RenderSVGShadowTreeRootContainer::~RenderSVGShadowTreeRootContainer):
        (WebCore::RenderSVGShadowTreeRootContainer::updateFromElement):
        * rendering/svg/SVGShadowTreeElements.cpp:
        (WebCore::SVGShadowTreeRootElement::SVGShadowTreeRootElement):
        (WebCore::SVGShadowTreeRootElement::create):
        (WebCore::SVGShadowTreeRootElement::attachElement):
        (WebCore::SVGShadowTreeRootElement::clearSVGShadowHost):
        * rendering/svg/SVGShadowTreeElements.h:
        (WebCore::SVGShadowTreeRootElement::isSVGShadowRoot):
        * svg/SVGStyledElement.cpp:
        (WebCore::SVGStyledElement::title):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-18 Taiju TSUIKI <develop@tzik.jp>
commit-queue@webkit.org [Tue, 19 Apr 2011 05:36:36 +0000 (05:36 +0000)]
2011-04-18  Taiju TSUIKI  <develop@tzik.jp>

        Reviewed by Darin Fisher.

        Vendor-prefix requestFileSystem in FileSystem API
        https://bugs.webkit.org/show_bug.cgi?id=58517

        Prefix from:
        - window.requestFileSystem to window.webkitRequestFileSystem
        - window.resolveLocalFileSystemURL to window.webkitResolveLocalFileSystemURL
        - window.Flags to window.WebKitFlags
        - WorkerContext.requestFileSystem to WorkerContext.webkitRequestFileSystem
        - WorkerContext.resolveLocalFileSystemURL to WorkerContext.webkitResolveLocalFileSystemURL
        - WorkerContext.Flags to WorkerContext.WebKitFlags

        * fast/dom/script-tests/prototype-inheritance.js:
        * fast/filesystem/flags-passing-expected.txt:
        * fast/filesystem/resources/async-operations.js:
        * fast/filesystem/resources/directory-entry-to-uri.js:
        * fast/filesystem/resources/file-entry-to-uri-sync.js:
        * fast/filesystem/resources/file-entry-to-uri.js:
        * fast/filesystem/resources/file-from-file-entry-sync.js:
        * fast/filesystem/resources/file-from-file-entry.js:
        * fast/filesystem/resources/file-writer-sync-truncate-extend.js:
        * fast/filesystem/resources/file-writer-sync-write-overlapped.js:
        * fast/filesystem/resources/file-writer-utils.js:
        * fast/filesystem/resources/fs-worker-common.js:
        * fast/filesystem/resources/op-tests-helper.js:
        * fast/filesystem/resources/simple-persistent-sync.js:
        * fast/filesystem/resources/simple-persistent.js:
        * fast/filesystem/resources/simple-temporary-sync.js:
        * fast/filesystem/resources/simple-temporary.js:
        * fast/filesystem/resources/sync-operations.js:
        * fast/filesystem/script-tests/filesystem-reference.js:
        * fast/filesystem/script-tests/flags-passing.js:
        * fast/filesystem/script-tests/read-directory.js:
        * http/tests/filesystem/resolve-uri-expected.txt:
        * http/tests/filesystem/script-tests/resolve-uri.js:
        * http/tests/filesystem/workers/resolve-url-expected.txt:
        * http/tests/filesystem/workers/script-tests/resolve-url-sync.js:
        * platform/chromium/fast/dom/prototype-inheritance-expected.txt:
2011-04-18  Taiju TSUIKI  <develop@tzik.jp>

        Reviewed by Darin Fisher.

        Vendor-prefix requestFileSystem in FileSystem API
        https://bugs.webkit.org/show_bug.cgi?id=58517

        Prefix from:
        - window.requestFileSystem to window.webkitRequestFileSystem
        - window.resolveLocalFileSystemURL to window.webkitResolveLocalFileSystemURL
        - window.Flags to window.WebKitFlags
        - WorkerContext.requestFileSystem to WorkerContext.webkitRequestFileSystem
        - WorkerContext.resolveLocalFileSystemURL to WorkerContext.webkitResolveLocalFileSystemURL
        - WorkerContext.Flags to WorkerContext.WebKitFlags

        * CMakeLists.txt:
        * CodeGenerators.pri:
        * DerivedSources.cpp:
        * DerivedSources.make:
        * GNUmakefile.list.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSDirectoryEntryCustom.cpp:
        (WebCore::JSDirectoryEntry::getFile):
        (WebCore::JSDirectoryEntry::getDirectory):
        * bindings/js/JSDirectoryEntrySyncCustom.cpp:
        (WebCore::getFlags):
        (WebCore::JSDirectoryEntrySync::getFile):
        (WebCore::JSDirectoryEntrySync::getDirectory):
        * bindings/v8/custom/V8DirectoryEntryCustom.cpp:
        (WebCore::V8DirectoryEntry::getDirectoryCallback):
        (WebCore::V8DirectoryEntry::getFileCallback):
        * bindings/v8/custom/V8DirectoryEntrySyncCustom.cpp:
        (WebCore::getFlags):
        (WebCore::V8DirectoryEntrySync::getDirectoryCallback):
        (WebCore::V8DirectoryEntrySync::getFileCallback):
        * fileapi/DOMFileSystemBase.cpp:
        (WebCore::DOMFileSystemBase::getFile):
        (WebCore::DOMFileSystemBase::getDirectory):
        * fileapi/DOMFileSystemBase.h:
        * fileapi/DirectoryEntry.cpp:
        (WebCore::DirectoryEntry::getFile):
        (WebCore::DirectoryEntry::getDirectory):
        * fileapi/DirectoryEntry.h:
        * fileapi/DirectoryEntry.idl:
        * fileapi/DirectoryEntrySync.cpp:
        (WebCore::DirectoryEntrySync::getFile):
        (WebCore::DirectoryEntrySync::getDirectory):
        * fileapi/DirectoryEntrySync.h:
        * fileapi/DirectoryEntrySync.idl:
        * fileapi/WebKitFlags.h: Renamed from Source/WebCore/fileapi/Flags.h.
        (WebCore::WebKitFlags::create):
        (WebCore::WebKitFlags::isCreate):
        (WebCore::WebKitFlags::setCreate):
        (WebCore::WebKitFlags::isExclusive):
        (WebCore::WebKitFlags::setExclusive):
        (WebCore::WebKitFlags::WebKitFlags):
        * fileapi/WebKitFlags.idl: Renamed from Source/WebCore/fileapi/Flags.idl.
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::webkitRequestFileSystem):
        (WebCore::DOMWindow::webkitResolveLocalFileSystemURL):
        * page/DOMWindow.h:
        * page/DOMWindow.idl:
        * workers/WorkerContext.cpp:
        (WebCore::WorkerContext::webkitRequestFileSystem):
        (WebCore::WorkerContext::webkitRequestFileSystemSync):
        (WebCore::WorkerContext::webkitResolveLocalFileSystemURL):
        (WebCore::WorkerContext::webkitResolveLocalFileSystemSyncURL):
        * workers/WorkerContext.h:
        * workers/WorkerContext.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-18 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Tue, 19 Apr 2011 04:32:47 +0000 (04:32 +0000)]
2011-04-18  Daniel Bates  <dbates@rim.com>

        https://bugs.webkit.org/show_bug.cgi?id=58863

        Skip fast/events/fire-mousedown-while-pressing-mouse-button.html which is failing on
        Qt Linux for now. See bug for more details.

        This test was added in changeset 84217 <http://trac.webkit.org/changeset/84217>
        (https://bugs.webkit.org/show_bug.cgi?id=58700).

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-18 Steve Lacey <sjl@chromium.org>
commit-queue@webkit.org [Tue, 19 Apr 2011 04:28:34 +0000 (04:28 +0000)]
2011-04-18  Steve Lacey  <sjl@chromium.org>

        Reviewed by Dimitri Glazkov.

        Decouple media controls usage from implementation.
        This allows each port to implement thier own controls in a different
        manner to the default webkit implementation.

        Convert media controls hooks to a client interface
        https://bugs.webkit.org/show_bug.cgi?id=58346

        No new tests as there is no functional change.

        * Android.mk:
        * CMakeLists.txt:
        * GNUmakefile.list.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::mediaControls):
        (WebCore::HTMLMediaElement::ensureMediaControls):
        (WebCore::HTMLMediaElement::preDispatchEventHandler):
        * html/HTMLMediaElement.h:
        * html/shadow/MediaControlElements.cpp:
        (WebCore::MediaControlPanelMuteButtonElement::MediaControlPanelMuteButtonElement):
        (WebCore::MediaControlPanelMuteButtonElement::create):
        (WebCore::MediaControlTimelineElement::MediaControlTimelineElement):
        (WebCore::MediaControlTimelineElement::create):
        (WebCore::MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement):
        (WebCore::MediaControlFullscreenButtonElement::create):
        * html/shadow/MediaControlElements.h:
        * html/shadow/MediaControlRootElement.cpp:
        (WebCore::MediaControlRootElement::MediaControlRootElement):
        (WebCore::MediaControls::create):
        * html/shadow/MediaControlRootElement.h:
        * html/shadow/MediaControls.cpp: Added.
        (WebCore::MediaControls::MediaControls):
        * html/shadow/MediaControls.h: Added.
        (WebCore::MediaControls::~MediaControls):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-18 Zan Dobersek <zandobersek@gmail.com>
mrobinson@webkit.org [Tue, 19 Apr 2011 03:49:34 +0000 (03:49 +0000)]
2011-04-18  Zan Dobersek  <zandobersek@gmail.com>

        Reviewed by Martin Robinson.

        Update pixel results for tests that draw the selection rectangle.

        * platform/gtk/editing/selection/4402375-expected.checksum:
        * platform/gtk/editing/selection/4402375-expected.png:
        * platform/gtk/editing/selection/image-before-linebreak-expected.checksum:
        * platform/gtk/editing/selection/image-before-linebreak-expected.png:
        * platform/gtk/editing/selection/replaced-boundaries-1-expected.checksum:
        * platform/gtk/editing/selection/replaced-boundaries-1-expected.png:
        * platform/gtk/editing/selection/replaced-boundaries-2-expected.checksum:
        * platform/gtk/editing/selection/replaced-boundaries-2-expected.png:
        * platform/gtk/editing/selection/replaced-boundaries-3-expected.checksum:
        * platform/gtk/editing/selection/replaced-boundaries-3-expected.png:
        * platform/gtk/editing/selection/transformed-selection-rects-expected.checksum:
        * platform/gtk/editing/selection/transformed-selection-rects-expected.png:
        * platform/gtk/svg/text/foreignObject-text-clipping-bug-expected.checksum:
        * platform/gtk/svg/text/foreignObject-text-clipping-bug-expected.png:
        * platform/gtk/svg/text/selection-doubleclick-expected.checksum:
        * platform/gtk/svg/text/selection-doubleclick-expected.png:
        * platform/gtk/svg/text/selection-tripleclick-expected.checksum:
        * platform/gtk/svg/text/selection-tripleclick-expected.png:
        * platform/gtk/svg/text/text-align-01-b-expected.checksum:
        * platform/gtk/svg/text/text-align-01-b-expected.png:
        * platform/gtk/svg/text/text-align-02-b-expected.checksum:
        * platform/gtk/svg/text/text-align-02-b-expected.png:
        * platform/gtk/svg/text/text-align-03-b-expected.checksum:
        * platform/gtk/svg/text/text-align-03-b-expected.png:
        * platform/gtk/svg/text/text-align-04-b-expected.checksum:
        * platform/gtk/svg/text/text-align-04-b-expected.png:
        * platform/gtk/svg/text/text-align-05-b-expected.checksum:
        * platform/gtk/svg/text/text-align-05-b-expected.png:
        * platform/gtk/svg/text/text-align-06-b-expected.checksum:
        * platform/gtk/svg/text/text-align-06-b-expected.png:
        * platform/gtk/svg/text/text-altglyph-01-b-expected.checksum:
        * platform/gtk/svg/text/text-altglyph-01-b-expected.png:
        * platform/gtk/svg/text/text-deco-01-b-expected.checksum:
        * platform/gtk/svg/text/text-deco-01-b-expected.png:
        * platform/gtk/svg/text/text-fonts-01-t-expected.checksum:
        * platform/gtk/svg/text/text-fonts-01-t-expected.png:
        * platform/gtk/svg/text/text-fonts-02-t-expected.checksum:
        * platform/gtk/svg/text/text-fonts-02-t-expected.png:
        * platform/gtk/svg/text/text-intro-05-t-expected.checksum:
        * platform/gtk/svg/text/text-intro-05-t-expected.png:
        * platform/gtk/svg/text/text-path-01-b-expected.checksum:
        * platform/gtk/svg/text/text-path-01-b-expected.png:
        * platform/gtk/svg/text/text-spacing-01-b-expected.checksum:
        * platform/gtk/svg/text/text-spacing-01-b-expected.png:
        * platform/gtk/svg/text/text-text-01-b-expected.checksum:
        * platform/gtk/svg/text/text-text-01-b-expected.png:
        * platform/gtk/svg/text/text-text-03-b-expected.checksum:
        * platform/gtk/svg/text/text-text-03-b-expected.png:
        * platform/gtk/svg/text/text-text-04-t-expected.checksum:
        * platform/gtk/svg/text/text-text-04-t-expected.png:
        * platform/gtk/svg/text/text-text-05-t-expected.checksum:
        * platform/gtk/svg/text/text-text-05-t-expected.png:
        * platform/gtk/svg/text/text-text-06-t-expected.checksum:
        * platform/gtk/svg/text/text-text-06-t-expected.png:
        * platform/gtk/svg/text/text-text-07-t-expected.checksum:
        * platform/gtk/svg/text/text-text-07-t-expected.png:
        * platform/gtk/svg/text/text-text-08-b-expected.checksum:
        * platform/gtk/svg/text/text-text-08-b-expected.png:
        * platform/gtk/svg/text/text-tref-01-b-expected.checksum:
        * platform/gtk/svg/text/text-tref-01-b-expected.png:
        * platform/gtk/svg/text/text-tselect-01-b-expected.checksum:
        * platform/gtk/svg/text/text-tselect-01-b-expected.png:
        * platform/gtk/svg/text/text-tselect-02-f-expected.checksum:
        * platform/gtk/svg/text/text-tselect-02-f-expected.png:
        * platform/gtk/svg/text/text-tspan-01-b-expected.checksum:
        * platform/gtk/svg/text/text-tspan-01-b-expected.png:
        * platform/gtk/svg/text/text-ws-01-t-expected.checksum:
        * platform/gtk/svg/text/text-ws-01-t-expected.png:
        * platform/gtk/svg/text/text-ws-02-t-expected.checksum:
        * platform/gtk/svg/text/text-ws-02-t-expected.png:
        * platform/gtk/svg/text/textPathBoundsBug-expected.checksum:
        * platform/gtk/svg/text/textPathBoundsBug-expected.png:
2011-04-18  Zan Dobersek  <zandobersek@gmail.com>

        Reviewed by Martin Robinson.

        [GTK] Need support for dumping focus rectangles in pixel results
        https://bugs.webkit.org/show_bug.cgi?id=53647

        Add a support function that returns the rectangle of the current
        selection in frame.

        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
        (DumpRenderTreeSupportGtk::rectangleForSelection):
        * WebCoreSupport/DumpRenderTreeSupportGtk.h:
2011-04-18  Zan Dobersek  <zandobersek@gmail.com>

        Reviewed by Martin Robinson.

        [GTK] Need support for dumping focus rectangles in pixel results
        https://bugs.webkit.org/show_bug.cgi?id=53647

        Dump the selection rect if it has been requested.

        * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
        (createBitmapContextFromWebView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-18 Jia Pu <jpu@apple.com>
commit-queue@webkit.org [Tue, 19 Apr 2011 03:47:49 +0000 (03:47 +0000)]
2011-04-18  Jia Pu  <jpu@apple.com>

        Reviewed by Mark Rowe.

        WebKit needs to stop importing <AppKit/NSTextChecker.h>
        https://bugs.webkit.org/show_bug.cgi?id=58798
        <rdar://problem/9294938>

        Use public header <AppKit/NSSpellChecker.h> instead.

        * WebCoreSupport/CorrectionPanel.h:
        * WebCoreSupport/CorrectionPanel.mm:
        (correctionIndicatorType):
        (CorrectionPanel::show):
        (CorrectionPanel::dismissInternal):
        (CorrectionPanel::handleAcceptedReplacement):
        * WebCoreSupport/WebEditorClient.mm:
        * WebView/WebView.mm:
2011-04-18  Jia Pu  <jpu@apple.com>

        Reviewed by Mark Rowe.

        WebKit needs to stop importing <AppKit/NSTextChecker.h>
        https://bugs.webkit.org/show_bug.cgi?id=58798
        <rdar://problem/9294938>

        Use public header <AppKit/NSSpellChecker.h> instead.

        * UIProcess/mac/CorrectionPanel.h:
        * UIProcess/mac/CorrectionPanel.mm:
        (correctionIndicatorType):
        (WebKit::CorrectionPanel::show):
        (WebKit::CorrectionPanel::dismissInternal):
        (WebKit::CorrectionPanel::handleAcceptedReplacement):
        * UIProcess/mac/TextCheckerMac.mm:
        * WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-18 Pascal Massimino <pascal.massimino@gmail.com>
commit-queue@webkit.org [Tue, 19 Apr 2011 03:43:24 +0000 (03:43 +0000)]
2011-04-18  Pascal Massimino  <pascal.massimino@gmail.com>

        Reviewed by Adam Barth.

        Add incremental decoding to WebP decoder
        https://bugs.webkit.org/show_bug.cgi?id=58851

        No new tests, as it's not possible for the layout test framework to
        force the decoders to decode incrementally.

        * platform/image-decoders/webp/WEBPImageDecoder.cpp:
        (WebCore::WEBPImageDecoder::WEBPImageDecoder):
        (WebCore::WEBPImageDecoder::decode):
        * platform/image-decoders/webp/WEBPImageDecoder.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-18 Mike Reed <reed@google.com>
commit-queue@webkit.org [Tue, 19 Apr 2011 03:39:32 +0000 (03:39 +0000)]
2011-04-18  Mike Reed  <reed@google.com>

        Reviewed by Kenneth Russell.

        remove tests from test_expectations.txt, as they now pass
        https://bugs.webkit.org/show_bug.cgi?id=58813

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-18 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Tue, 19 Apr 2011 03:21:10 +0000 (03:21 +0000)]
2011-04-18  Daniel Bates  <dbates@rim.com>

        Reviewed by Adam Roben.

        With PAN_SCROLLING, mousedown events for a mouse button aren't dispatched while
        pressing-and-holding another mouse button
        https://bugs.webkit.org/show_bug.cgi?id=58700

        Fixes an issue where mousedown events weren't dispatched when pressing a mouse button A
        while pressing and holding a mouse button B, where A != B. This issue only affects builds
        that enable PAN_SCROLLING.

        On mouse press with autoscroll in progress (m_autoscrollInProgress == true) we stopped
        the autoscroll timer, invalidated the click, and swallowed the mouse press. Instead, we
        should only stop the autoscroll timer.

        Test: fast/events/fire-mousedown-while-pressing-mouse-button.html

        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleMousePressEvent):
2011-04-18  Daniel Bates  <dbates@rim.com>

        Reviewed by Adam Roben.

        With PAN_SCROLLING, mousedown events for a mouse button aren't dispatched while
        pressing-and-holding another mouse button
        https://bugs.webkit.org/show_bug.cgi?id=58700

        Test to ensure that a mousedown event is fired when pressing a mouse button A
        while pressing and holding a mouse button B, where A != B.

        * fast/events/fire-mousedown-while-pressing-mouse-button-expected.txt: Added.
        * fast/events/fire-mousedown-while-pressing-mouse-button.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-18 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 19 Apr 2011 03:11:20 +0000 (03:11 +0000)]
2011-04-18  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        test-webkitpy should run the ActiveWorkItems tests
        https://bugs.webkit.org/show_bug.cgi?id=58859

        Also make the unit tests pass. :)

        * QueueStatusServer/model/activeworkitems.py:
        * QueueStatusServer/model/queue.py:
        * QueueStatusServer/model/workitems.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-18 Jon Lee <jonlee@apple.com>
commit-queue@webkit.org [Tue, 19 Apr 2011 02:21:06 +0000 (02:21 +0000)]
2011-04-18  Jon Lee  <jonlee@apple.com>

        Reviewed by Maciej Stachowiak.

        With overlay scrollbars, textarea resize corner gains borders when the textarea becomes scrollable
        https://bugs.webkit.org/show_bug.cgi?id=58617
        <rdar://problem/9048012>

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::paintResizer): Check for overlay scrollbars first, and then if the bars were created, before displaying the borders

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-18 Jon Lee <jonlee@apple.com>
commit-queue@webkit.org [Tue, 19 Apr 2011 01:40:21 +0000 (01:40 +0000)]
2011-04-18  Jon Lee  <jonlee@apple.com>

        Reviewed by Maciej Stachowiak.

        Selected item background in list box gets rendered on top of overlay scrollbar knob (58824)
        https://bugs.webkit.org/show_bug.cgi?id=58824
        <rdar://problem/9292680>

        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::paintObject): Moving the stage of painting the scrollbars to the foreground if using overlay scrollbars

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-18 John Bauman <jbauman@chromium.org>
commit-queue@webkit.org [Tue, 19 Apr 2011 01:35:15 +0000 (01:35 +0000)]
2011-04-18  John Bauman  <jbauman@chromium.org>

        Reviewed by Kenneth Russell.

        Don't cast BitmapImageSingleFrameSkia to BitmapImage
        https://bugs.webkit.org/show_bug.cgi?id=58821

        BitmapImageSingleFrameSkia has isBitmap return true, but
        can't be cast to a BitmapImage. Instead of using BitmapImage,
        use isOpaque from SkBitmap to determine if the image has alpha.

        No new tests.

        * platform/graphics/skia/GraphicsContext3DSkia.cpp:
        (WebCore::GraphicsContext3D::getImageData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-18 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Tue, 19 Apr 2011 00:34:44 +0000 (00:34 +0000)]
2011-04-18  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Remove unneeded deprecated methods from MarkStack
        https://bugs.webkit.org/show_bug.cgi?id=58853

        Remove deprecated methods

        * heap/MarkStack.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-18 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 19 Apr 2011 00:00:46 +0000 (00:00 +0000)]
2011-04-18  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        queues.webkit.org should show trailing-days pass counts for queues
        https://bugs.webkit.org/show_bug.cgi?id=58812

        This lets us see if each bot is pulling its own weight or not.
        Before I wrote this patch our suspicious was that one of the
        cq bots was doing most of the work.  Turns out they're actually
        pretty even in their recent pass counts.

        * QueueStatusServer/handlers/queuestatus.py:
        * QueueStatusServer/index.yaml:
        * QueueStatusServer/templates/queuestatus.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-18 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Mon, 18 Apr 2011 23:43:54 +0000 (23:43 +0000)]
2011-04-18  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Eric Seidel.

        new-run-webkit-tests: obsolete old threading code, part 1
        https://bugs.webkit.org/show_bug.cgi?id=58752

        This patch removes support for the 'old-inline' and
        'old-threads' worker models, and deletes the corresponding code.
        Now that the new code is stable, this stuff is no longer
        necessary.

        * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: Removed.
        * Scripts/webkitpy/layout_tests/layout_package/message_broker.py: Removed.
        * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py: Removed.
        * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebKitTestRunner needs a more-complete implementation of eventSender.
jberlin@webkit.org [Mon, 18 Apr 2011 23:43:51 +0000 (23:43 +0000)]
WebKitTestRunner needs a more-complete implementation of eventSender.
https://bugs.webkit.org/show_bug.cgi?id=42194

Skip fullscreen/full-screen-cancel.html (which uses eventSender.keyDown) in the WK2 tests.

* platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoIf deleting the StorageTracker.db file fails, local storage is left in a strange...
jberlin@webkit.org [Mon, 18 Apr 2011 23:34:25 +0000 (23:34 +0000)]
If deleting the StorageTracker.db file fails, local storage is left in a strange state.
https://bugs.webkit.org/show_bug.cgi?id=58805

Reviewed by Steve Falkenburg.

* storage/StorageTracker.cpp:
(WebCore::StorageTracker::syncFileSystemAndTrackerDatabase):
When cleaning up the StorageTracker.db file, is not enough to call syncDeleteOrigin.
deleteOrigin itself must be called to update the data structures that syncDeleteOrigin
depends on and to prevent clashes between a theoretical web page editing local storage
at the same time this method is called.
(WebCore::StorageTracker::syncDeleteAllOrigins):
If it is not possible to delete the StorageTracker.db file, empty it.
(WebCore::StorageTracker::deleteOriginOnMainThread):
Wrapper for deleteOrigin.
* storage/StorageTracker.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-18 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Mon, 18 Apr 2011 23:31:42 +0000 (23:31 +0000)]
2011-04-18  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Eric Seidel.

        new-run-webkit-tests: add an --additional-drt-flag option
        https://bugs.webkit.org/show_bug.cgi?id=58680

        NRWT has a bunch of command line flags that exist to pass
        custom flags to DRT, especially on chromium. It would be nice
        if there was a generic mechanism to pass through flags so we
        didn't have all the custom ones.

        * Scripts/webkitpy/layout_tests/port/chromium.py:
        * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
        * Scripts/webkitpy/layout_tests/port/port_testcase.py:
        * Scripts/webkitpy/layout_tests/port/test.py:
        * Scripts/webkitpy/layout_tests/port/webkit.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-05 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Mon, 18 Apr 2011 23:28:38 +0000 (23:28 +0000)]
2011-04-05  Jer Noble  <jer.noble@apple.com>

        Reviewed by Sam Weinig.

        WebKit2: WKTR should support WebKit2 full screen APIs
        https://bugs.webkit.org/show_bug.cgi?id=56318

        WKTR does not support the eventSender.keyDown() method, so use mouseDown()
        in those cases that keyDown() does not exist.

        * fullscreen/full-screen-test.js:
        (runWithKeyDown.document.addEventListener):
        (runWithKeyDown):
2011-04-05  Jer Noble  <jer.noble@apple.com>

        Reviewed by Sam Weinig.

        WebKit2: WKTR should support WebKit2 full screen APIs
        https://bugs.webkit.org/show_bug.cgi?id=56318

        Add a new WKBundlePage API for Full Screen events, and move some of the implementation
        of WebFullScreenManager into the new InjectedBundlePageFullScreenClient class, so that
        the default behavior can be overridden by a WKBundlePageFullScreenClient.

        * WebKit2.xcodeproj/project.pbxproj:
        * WebProcess/FullScreen/WebFullScreenManager.cpp:
        (WebKit::WebFullScreenManager::supportsFullScreen): Moved contents into InjectedBundlePageFullScreenClient.
        (WebKit::WebFullScreenManager::enterFullScreenForElement): Ditto.
        (WebKit::WebFullScreenManager::exitFullScreenForElement): Ditto.
        * WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
        (WKBundlePageSetFullScreenClient): Added.
        (WKBundlePageWillEnterFullScreenForElement): Added.
        (WKBundlePageDidEnterFullScreenForElement): Added.
        (WKBundlePageWillExitFullScreenForElement): Added.
        (WKBundlePageDidExitFullScreenForElement): Added.
        * WebProcess/InjectedBundle/API/c/WKBundlePage.h:
        * WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.cpp: Added.
        (WebKit::InjectedBundlePageFullScreenClient::supportsFullScreen): Added.
        (WebKit::InjectedBundlePageFullScreenClient::enterFullScreenForElement): Added.
        (WebKit::InjectedBundlePageFullScreenClient::exitFullScreenForElement): Added.
        * WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.h: Added.
        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::initializeInjectedBundleFullScreenClient): Added.
        * WebProcess/WebPage/WebPage.h:
        (WebKit::WebPage::injectedBundleFullScreenClient): Added.
2011-04-05  Jer Noble  <jer.noble@apple.com>

        Reviewed by Sam Weinig.

        WebKit2: WKTR should support WebKit2 full screen APIs
        https://bugs.webkit.org/show_bug.cgi?id=56318

        Respond to enterFullScreenForElement() and exitFullScreenForElement(), allowing
        WKTR to test the LayoutTest/fullscreen/ tests.

        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
        (WTR::InjectedBundlePage::InjectedBundlePage): Add support for WKBundlePageFullScreenClient.
        (WTR::InjectedBundlePage::supportsFullScreen): Added.
        (WTR::InjectedBundlePage::enterFullScreenForElement): Added.
        (WTR::InjectedBundlePage::exitFullScreenForElement): Added.
        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
        * WebKitTestRunner/TestController.cpp:
        (WTR::TestController::resetStateToConsistentValues): Enable the full screen preference.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-18 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Mon, 18 Apr 2011 23:20:09 +0000 (23:20 +0000)]
2011-04-18  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Tony Chang.

        new-run-webkit-tests: remove chromium-specific relpath hack for --results-directory
        https://bugs.webkit.org/show_bug.cgi?id=58388

        * Scripts/webkitpy/layout_tests/port/chromium.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix.
ggaren@apple.com [Mon, 18 Apr 2011 23:11:02 +0000 (23:11 +0000)]
Build fix.

Added back missing #include.

* bindings/js/DOMWrapperWorld.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDropping a file in a WKView (WebKit2) doesn't load the file.
enrica@apple.com [Mon, 18 Apr 2011 23:09:19 +0000 (23:09 +0000)]
Dropping a file in a WKView (WebKit2) doesn't load the file.
https://bugs.webkit.org/show_bug.cgi?id=58842
<rdar://problem/8514409>

Reviewed by Maciej Stachowiak.

The URL string for the file contains an extra %00 at the end
that causes the network framework to fail to load the file.

* platform/win/ClipboardUtilitiesWin.cpp:
(WebCore::getURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Maciej Stachowiak.
ap@apple.com [Mon, 18 Apr 2011 23:07:34 +0000 (23:07 +0000)]
    Reviewed by Maciej Stachowiak.

        Re-add a null check lost in r83081
        https://bugs.webkit.org/show_bug.cgi?id=58846

        * WebProcess/WebPage/mac/WebPageMac.mm:
        (WebKit::WebPage::getSelectedRange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-18 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Mon, 18 Apr 2011 23:06:47 +0000 (23:06 +0000)]
2011-04-18  Andreas Kling  <kling@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt][WK2] Clean up tool-tip/status-bar confusion.
        https://bugs.webkit.org/show_bug.cgi?id=58844

        Tool-tips were incorrectly hooked up to the status bar text.
        Chrome::setStatusbarText() now correctly causes the QWKPage::statusBarMessage() signal.

        New API:
        - QWKPage::toolTipChanged(const QString& toolTip) [signal]

        QGraphicsWKView will automatically listen for this and set its own toolTip().

        * UIProcess/API/qt/ClientImpl.cpp:
        (qt_wk_setStatusText):
        * UIProcess/API/qt/ClientImpl.h:
        * UIProcess/API/qt/qgraphicswkview.cpp:
        (QGraphicsWKView::QGraphicsWKView):
        (QGraphicsWKViewPrivate::onToolTipChanged):
        * UIProcess/API/qt/qgraphicswkview.h:
        * UIProcess/API/qt/qwkpage.cpp:
        (QWKPagePrivate::toolTipChanged):
        (QWKPage::QWKPage):
        * UIProcess/API/qt/qwkpage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-18 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Mon, 18 Apr 2011 23:02:41 +0000 (23:02 +0000)]
2011-04-18  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed.

        Re-land r84112. It was rolled out in r84127 but it didn't need
        to be. Only r84111 actually broke things.

        * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-18 Evan Martin <evan@chromium.org>
evan@chromium.org [Mon, 18 Apr 2011 22:58:38 +0000 (22:58 +0000)]
2011-04-18  Evan Martin  <evan@chromium.org>

        Reviewed by Eric Seidel.

        [chromium] expose title direction to webkit client
        https://bugs.webkit.org/show_bug.cgi?id=58823

        *  Tools/DumpRenderTree/chromium/LayoutTestController.cpp:
        *  Tools/DumpRenderTree/chromium/LayoutTestController.h:
        Adapt to new API.  Expose title direction to JS so it can be tested.

        *  Tools/DumpRenderTree/chromium/WebViewHost.cpp:
        *  Tools/DumpRenderTree/chromium/WebViewHost.h:
        Provide new API.
2011-04-18  Evan Martin  <evan@chromium.org>

        Reviewed by Eric Seidel.

        [chromium] expose title direction to webkit client
        https://bugs.webkit.org/show_bug.cgi?id=58823

        New test that checks the directionality of the title for some
        simple pages.

        * fast/dom/title-directionality-expected.txt: Added.
        * fast/dom/title-directionality.html: Added.
2011-04-18  Evan Martin  <evan@chromium.org>

        Reviewed by Eric Seidel.

        [chromium] expose title direction to webkit client
        https://bugs.webkit.org/show_bug.cgi?id=58823

        * public/WebFrameClient.h:
        (WebKit::WebFrameClient::didReceiveTitle):
        Add new param to API.

        * src/FrameLoaderClientImpl.cpp:
        (WebKit::FrameLoaderClientImpl::dispatchDidReceiveTitle):
        Pass new param in API.
2011-04-18  Evan Martin  <evan@chromium.org>

        Reviewed by Eric Seidel.

        [chromium] expose title direction to webkit client
        https://bugs.webkit.org/show_bug.cgi?id=58823

        * DumpRenderTree/chromium/LayoutTestController.cpp:
        (LayoutTestController::LayoutTestController):
        (LayoutTestController::reset):
        * DumpRenderTree/chromium/LayoutTestController.h:
        (LayoutTestController::setTitleTextDirection):
        Add member and setter to let us stash the title direction at load time.

        * DumpRenderTree/chromium/WebViewHost.cpp:
        (WebViewHost::didReceiveTitle):
        * DumpRenderTree/chromium/WebViewHost.h:
        Adapt to new API; push the title into layoutTestController when we
        receive it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-18 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Mon, 18 Apr 2011 22:53:46 +0000 (22:53 +0000)]
2011-04-18  Geoffrey Garen  <ggaren@apple.com>

        Discovered and rubber-stamped by Stephanie Lewis.

        Restored some code I accidentally deleted in <http://trac.webkit.org/changeset/83990>

        * bindings/js/DOMWrapperWorld.cpp:
        (WebCore::DOMWrapperWorld::~DOMWrapperWorld):
        (WebCore::DOMWrapperWorld::clearWrappers): Do clear / destroy all our
        window shells when clearing / destroying ourselves. r83990 removed this
        behavior for documents since there are no per-document maps anymore,
        but removing this behavior for window shells too was a typo.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-18 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Mon, 18 Apr 2011 22:53:19 +0000 (22:53 +0000)]
2011-04-18  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Tony Chang.

        new-run-webkit-tests: don't run more processes than necessary
        https://bugs.webkit.org/show_bug.cgi?id=58751

        Previously NRWT would start up 1 process for each processor on
        the machine by default, which was a waste if we were only
        running a few shards of tests.

        * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt][WK2] Unreviewed buildfix after r84174.
ossy@webkit.org [Mon, 18 Apr 2011 22:44:49 +0000 (22:44 +0000)]
[Qt][WK2] Unreviewed buildfix after r84174.

* QtWebKit.pro: Missing includepath added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-18 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Mon, 18 Apr 2011 22:44:20 +0000 (22:44 +0000)]
2011-04-18  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Eric Seidel.

        include links to actual.png files for new pixel tests
        https://bugs.webkit.org/show_bug.cgi?id=58831

        Load image elements to confirm whether the files exist.
        Image elements will load without being appended to the DOM.

        * Scripts/webkitpy/layout_tests/layout_package/json_results.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-18 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Mon, 18 Apr 2011 22:41:06 +0000 (22:41 +0000)]
2011-04-18  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Made DOM handle ownership customizable, and customized it for Nodes and NamedAttrMaps
        https://bugs.webkit.org/show_bug.cgi?id=58828

        * WebCore.exp.in: Blah.

        * bindings/js/DOMWrapperWorld.cpp: Moved code related to JSNode ownership
        to JSNodeCustom, where other custom JSNode-related code goes.

        (WebCore::JSDOMWrapperOwner::finalize):
        (WebCore::DOMWrapperWorld::DOMWrapperWorld):
        * bindings/js/DOMWrapperWorld.h:
        (WebCore::JSDOMWrapperOwner::JSDOMWrapperOwner):
        (WebCore::DOMWrapperWorld::defaultWrapperOwner): Renamed DOMObjectHandleOwner
        to JSDOMWrapperOwner, to match the name of JSDOMWrapper.

        * bindings/js/JSArrayBufferViewHelper.h:
        (WebCore::toJSArrayBufferView):
        * bindings/js/JSCSSRuleCustom.cpp:
        (WebCore::toJS):
        * bindings/js/JSCSSValueCustom.cpp:
        (WebCore::toJS):
        * bindings/js/JSCanvasRenderingContextCustom.cpp:
        (WebCore::toJS): Removed "DOMObject" and "Node" from the names of wrapper-
        related functions, since there is no meaningful distinction between the
        two anymore -- they both use the same extensible interface.

        * bindings/js/JSDOMBinding.cpp: Removed some now-unused functions.

        * bindings/js/JSDOMBinding.h:
        (WebCore::getInlineCachedWrapper):
        (WebCore::setInlineCachedWrapper):
        (WebCore::clearInlineCachedWrapper):
        (WebCore::wrapperOwner):
        (WebCore::wrapperContext):
        (WebCore::getCachedWrapper):
        (WebCore::cacheWrapper):
        (WebCore::uncacheWrapper):
        (WebCore::createWrapper):
        (WebCore::wrap): Created a generic, extensible mechanism for creating,
        caching, retrieving, marking, and destroying DOM wrappers. This eliminates
        the difference between DOM object wrappers and DOM node wrappers, and
        lays the groundwork for getting rid of MarkStack::deprecatedAppend usage
        for marking the remainder of our DOM objects.

        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::history):
        (WebCore::JSDOMWindow::location):
        * bindings/js/JSDataViewCustom.cpp:
        (WebCore::toJS):
        * bindings/js/JSDocumentCustom.cpp:
        (WebCore::JSDocument::location):
        (WebCore::toJS):
        * bindings/js/JSElementCustom.cpp:
        (WebCore::toJSNewlyCreated):
        * bindings/js/JSEventCustom.cpp:
        (WebCore::toJS):
        * bindings/js/JSHTMLCollectionCustom.cpp:
        (WebCore::toJS):
        * bindings/js/JSImageDataCustom.cpp:
        (WebCore::toJS): Updated for renames mentioned above.

        * bindings/js/JSNamedNodeMapCustom.cpp:
        (WebCore::JSNamedNodeMapOwner::isReachableFromOpaqueRoots):
        (WebCore::JSNamedNodeMapOwner::finalize):
        (WebCore::wrapperOwner):
        (WebCore::wrapperContext):
        (WebCore::JSNamedNodeMap::markChildren):
        (WebCore::toJS): Updated to use our new interface for customizing wrapper
        lifetime management through function overloading without using
        MarkStack::deprecatedAppend.

        * bindings/js/JSNodeCustom.cpp:
        (WebCore::isObservable):
        (WebCore::isReachableFromDOM):
        (WebCore::JSNodeOwner::isReachableFromOpaqueRoots):
        (WebCore::JSNodeOwner::finalize):
        (WebCore::createWrapperInline): Moved node-related code from JSDOMBinding
        to here. Removed special case marking code for JSNamedNodeMap because
        JSNamedNodeMap now knows how to maintain its own lifetime invariants.

        * bindings/js/JSNodeCustom.h:
        (WebCore::wrapperOwner):
        (WebCore::wrapperContext):
        (WebCore::getInlineCachedWrapper):
        (WebCore::setInlineCachedWrapper):
        (WebCore::clearInlineCachedWrapper):
        (WebCore::toJS): Updated to use our new interface for customizing wrapper
        lifetime management through function overloading without using
        MarkStack::deprecatedAppend or special-case code for nodes.

        * bindings/js/JSSVGPathSegCustom.cpp:
        (WebCore::toJS):
        * bindings/js/JSStyleSheetCustom.cpp:
        (WebCore::toJS): Updated for renames mentioned above.

        * bindings/scripts/CodeGeneratorJS.pm: Fixed up newlines. Updated for
        renames mentioned above.

        * dom/NamedNodeMap.idl: NamedNodeMap needs a custom toJS function now
        because it needs to provide a custom WeakHandleOwner at wrapper creation time.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-18 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Mon, 18 Apr 2011 22:32:39 +0000 (22:32 +0000)]
2011-04-18  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Dan Bernstein.

        sandbox violation for ~/Library/Dictionaries
        https://bugs.webkit.org/show_bug.cgi?id=58841
        <rdar://problem/9294770>

        * WebProcess/com.apple.WebProcess.sb: Add to sandbox profile.
        No obvious harm from allowing this, though it's not 100% clear
        why it's needed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSION (r84094): Many tests failing assertions in WebCore::localizedString on...
jberlin@webkit.org [Mon, 18 Apr 2011 22:28:58 +0000 (22:28 +0000)]
REGRESSION (r84094): Many tests failing assertions in WebCore::localizedString on Windows.
https://bugs.webkit.org/show_bug.cgi?id=58747

Rubber-stamped by Sam Weinig.

Copy the WebCore Localizable.strings file into the output directory.

* WebCore.vcproj/WebCoreGenerated.vcproj:
* WebCore.vcproj/WebCoreGeneratedCairo.vsprops:
* WebCore.vcproj/WebCoreGeneratedCommon.vsprops:
* WebCore.vcproj/copyInspectorFiles.cmd: Removed.
* WebCore.vcproj/copyWebCoreResourceFiles.cmd: Copied from Source/WebCore/WebCore.vcproj/copyInspectorFiles.cmd.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoReviewed by Timothy Hatcher.
cwzwarich@webkit.org [Mon, 18 Apr 2011 22:20:03 +0000 (22:20 +0000)]
Reviewed by Timothy Hatcher.

Stop using -[NSString initWithContentsOfFile:]
https://bugs.webkit.org/show_bug.cgi?id=58763

-[NSString initWithContentsOfFile:] was deprecated in 10.4, so we should stop using it.

* WebView/WebView.mm:
(leakMailQuirksUserScriptContents):
(leakOutlookQuirksUserScriptContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-18 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Mon, 18 Apr 2011 22:16:45 +0000 (22:16 +0000)]
2011-04-18  Oliver Hunt  <oliver@apple.com>

        Reviewed by Adam Roben.

        Off by one initialising repeat callframe
        https://bugs.webkit.org/show_bug.cgi?id=58838
        <rdar://problem/8756810>

        If the end of a callframe made for a repeat call landed on
        a page boundary the following page may not have been committed
        which means that the off by one could lead to a crash.  However
        it could only happen in this case and only on windows which is
        why it was so hard to repro.  Alas given the steps needed to
        reproduce are such that it's not really possible to make a
        testcase.

        This fix makes the code a little less squirrely by not trying
        to avoid the unnecessary initialisation of |this|.

        * interpreter/Interpreter.cpp:
        (JSC::Interpreter::prepareForRepeatCall):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-18 Yi Shen <yi.4.shen@nokia.com>
yi.4.shen@nokia.com [Mon, 18 Apr 2011 21:56:21 +0000 (21:56 +0000)]
2011-04-18  Yi Shen  <yi.4.shen@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt][Symbian] Fix Api test failure -- tst_QWebFrame::inputFieldFocus
        https://bugs.webkit.org/show_bug.cgi?id=57546

        Disable the fullscreen VKB when testing inputFieldFocus().

        * tests/qwebframe/tst_qwebframe.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-18 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Mon, 18 Apr 2011 21:51:21 +0000 (21:51 +0000)]
2011-04-18  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Eric Seidel.

        add a zoomed view for pixel results to the new results html file
        https://bugs.webkit.org/show_bug.cgi?id=58827

        * Scripts/webkitpy/layout_tests/layout_package/json_results.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-18 Robert Hogan <robert@webkit.org>
robert@webkit.org [Mon, 18 Apr 2011 21:48:44 +0000 (21:48 +0000)]
2011-04-18  Robert Hogan  <robert@webkit.org>

        Reviewed by Andreas Kling.

        [Qt] PluginViewQt needs to update geometry of plugin widget before scheduling a repaint

        When scheduling a repaint for the plugin's widget, PluginViewQt
        needs to make sure the widget's geometry is up to date. Otherwise
        the paint event happens on the widget's old location.

        https://bugs.webkit.org/show_bug.cgi?id=57179

        Added a manual test.

        * manual-tests/qt/plugin-painting.html: Added.
        * plugins/qt/PluginViewQt.cpp:
        (WebCore::PluginView::updatePluginWidget):
        (WebCore::PluginView::invalidateRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix Qt build
oliver@apple.com [Mon, 18 Apr 2011 21:44:29 +0000 (21:44 +0000)]
Fix Qt build

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBug 58829 - DFG JIT - Optimize add/sub immediate, multiply.
barraclough@apple.com [Mon, 18 Apr 2011 21:31:52 +0000 (21:31 +0000)]
Bug 58829 - DFG JIT - Optimize add/sub immediate, multiply.

Reviewed by Geoff Garen.

Add code generation for add/subtract instruction with immediate operands
(where a child is a constant), and don't bail to non-speculative if an
integer multiple results in a +0 result (only if it should be generating -0).

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::isDoubleConstantWithInt32Value):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTry to fix the Windows build.
andersca@apple.com [Mon, 18 Apr 2011 21:21:04 +0000 (21:21 +0000)]
Try to fix the Windows build.

* Scripts/webkit2/messages.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-18 Chang Shu <cshu@webkit.org>
chang.shu@nokia.com [Mon, 18 Apr 2011 21:20:24 +0000 (21:20 +0000)]
2011-04-18  Chang Shu  <cshu@webkit.org>

        Unreviewed.

        Skip failed test due to r84160.

        * platform/win-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBug 58817 - DFG JIT - if speculative compilation fails, throw away code.
barraclough@apple.com [Mon, 18 Apr 2011 21:08:28 +0000 (21:08 +0000)]
Bug 58817 - DFG JIT - if speculative compilation fails, throw away code.

Reviewed by Geoff Garen.

If we detect a logical conflict, throw away generated code,
and only compile through the NonSpeculativeJIT.

* assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::rewindToLabel):
* assembler/AssemblerBuffer.h:
(JSC::AssemblerBuffer::rewindToOffset):
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::branchAdd32):
(JSC::MacroAssemblerX86Common::branchSub32):
* assembler/X86Assembler.h:
(JSC::X86Assembler::rewindToLabel):
(JSC::X86Assembler::X86InstructionFormatter::rewindToLabel):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::linkSpeculationChecks):
(JSC::DFG::JITCompiler::compileFunction):
* dfg/DFGNode.h:
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculationCheckIndexIterator::SpeculationCheckIndexIterator):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-18 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 18 Apr 2011 21:04:07 +0000 (21:04 +0000)]
2011-04-18  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Get rid of WebProcessProxyLegacyMessage
        https://bugs.webkit.org/show_bug.cgi?id=58825

        * GNUmakefile.am:
        * Platform/CoreIPC/MessageID.h:
        * Shared/CoreIPCSupport/WebProcessProxyMessageKinds.h: Removed.
        * UIProcess/WebProcessProxy.cpp:
        * WebKit2.xcodeproj/project.pbxproj:
        * WebProcess/Plugins/PluginProcessConnectionManager.cpp:
        * WebProcess/WebCoreSupport/WebChromeClient.cpp:
        * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
        * WebProcess/WebPage/WebPage.cpp:
        * win/WebKit2.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-18 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Mon, 18 Apr 2011 20:59:08 +0000 (20:59 +0000)]
2011-04-18  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dave Hyatt.

        Add some new tests that exercise border-drawing on split inlines.

        * fast/blockflow/border-styles-vertical-lr.html: Added.
        * fast/blockflow/border-styles-vertical-rl.html: Added.
        * fast/borders/border-styles-split.html: Added.
        * platform/mac/fast/blockflow/border-styles-vertical-lr-expected.checksum: Added.
        * platform/mac/fast/blockflow/border-styles-vertical-lr-expected.png: Added.
        * platform/mac/fast/blockflow/border-styles-vertical-lr-expected.txt: Added.
        * platform/mac/fast/blockflow/border-styles-vertical-rl-expected.checksum: Added.
        * platform/mac/fast/blockflow/border-styles-vertical-rl-expected.png: Added.
        * platform/mac/fast/blockflow/border-styles-vertical-rl-expected.txt: Added.
        * platform/mac/fast/borders/border-styles-split-expected.checksum: Added.
        * platform/mac/fast/borders/border-styles-split-expected.png: Added.
        * platform/mac/fast/borders/border-styles-split-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-18 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Mon, 18 Apr 2011 20:46:41 +0000 (20:46 +0000)]
2011-04-18  Andreas Kling  <kling@webkit.org>

        [Qt] DRT: Unreviewed test fix after r84168.

        Dump the original request KURL for blocked access attempts.
        Turns out converting it to a QUrl lower-cases the hostname.

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::dispatchWillSendRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoLand all of the last patch
oliver@apple.com [Mon, 18 Apr 2011 20:43:11 +0000 (20:43 +0000)]
Land all of the last patch

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix build.
andersca@apple.com [Mon, 18 Apr 2011 20:40:59 +0000 (20:40 +0000)]
Fix build.

* UIProcess/Plugins/PluginInfoStore.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-18 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Mon, 18 Apr 2011 20:34:50 +0000 (20:34 +0000)]
2011-04-18  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Remove DeprecatedPtr
        https://bugs.webkit.org/show_bug.cgi?id=58718

        As simple as it sounds.

        * runtime/JSValue.h:
        * runtime/WriteBarrier.h:
2011-04-18  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Remove DeprecatedPtr
        https://bugs.webkit.org/show_bug.cgi?id=58718

        Replace use of DeprecatedPtr<> with Global<> as ownership rules
        aren't obvious, have filed bug #58820 on seeing if this is safe.

        * bridge/qt/qt_class.cpp:
        (JSC::Bindings::QtClass::fallbackObject):
        * bridge/qt/qt_instance.cpp:
        (JSC::Bindings::QtInstance::removeCachedMethod):
        (JSC::Bindings::QtInstance::markAggregate):
        * bridge/qt/qt_instance.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-18 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Mon, 18 Apr 2011 20:29:06 +0000 (20:29 +0000)]
2011-04-18  Alejandro G. Castro  <alex@igalia.com>

        Skipping overhanging-tall-block.html, it is crashing in the GTK+ bots.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-18 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 18 Apr 2011 20:24:44 +0000 (20:24 +0000)]
2011-04-18  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Use the message generator for the GetPluginProcessConnection message
        https://bugs.webkit.org/show_bug.cgi?id=58815

        * Platform/CoreIPC/HandleMessage.h:
        (CoreIPC::callMemberFunction):
        (CoreIPC::handleMessageDelayed):
        Add helper functions.

        * UIProcess/Plugins/PluginInfoStore.h:
        Mark class noncopyable.

        * UIProcess/Plugins/PluginProcessManager.cpp:
        (WebKit::PluginProcessManager::getPluginProcessConnection):
        This now takes a delayed reply.

        * UIProcess/Plugins/PluginProcessProxy.cpp:
        (WebKit::PluginProcessProxy::getPluginProcessConnection):
        This now takes a delayed reply.

        (WebKit::PluginProcessProxy::pluginProcessCrashedOrFailedToLaunch):
        (WebKit::PluginProcessProxy::didCreateWebProcessConnection):
        Call DelayedReply::send.

        * UIProcess/WebProcessProxy.cpp:
        (WebKit::WebProcessProxy::getPluginProcessConnection):
        This now takes a delayed reply.

        (WebKit::WebProcessProxy::didReceiveSyncMessage):
        No need to handle this message here.

        * UIProcess/WebProcessProxy.messages.in:
        Add GetPluginProcessConnection message.

        * WebProcess/Plugins/PluginProcessConnectionManager.cpp:
        (WebKit::PluginProcessConnectionManager::getPluginProcessConnection):
        Don't use deprecatedSendSync.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-18 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 18 Apr 2011 20:04:57 +0000 (20:04 +0000)]
2011-04-18  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam Roben.

        Finish implementing delayed sync replies in the CoreIPC message generator
        https://bugs.webkit.org/show_bug.cgi?id=58814

        Put the DelayedReply function definitions in the .cpp file and fix bugs found by
        actually trying to compile the generated files.

        * Scripts/webkit2/messages.py:
        * Scripts/webkit2/messages_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84173 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-14 Matthew Delaney <mdelaney@apple.com>
mdelaney@apple.com [Mon, 18 Apr 2011 19:58:23 +0000 (19:58 +0000)]
2011-04-14  Matthew Delaney  <mdelaney@apple.com>

        Reviewed by Simon Fraser.

        [CG] Use vImage (un)premultiplyImageData functions for get/putImageData with IOSurfaces
        https://bugs.webkit.org/show_bug.cgi?id=58088

        * platform/graphics/cg/ImageBufferDataCG.cpp:
        (WebCore::convertScanline): un/premultiplies and converts a scanline of image data from/to BGRA to/from RGBA
        (WebCore::unpremultitplyScanline):
        (WebCore::premultitplyScanline):
        (WebCore::ImageBufferData::getData):
        (WebCore::ImageBufferData::putData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-18 Yi Shen <yi.4.shen@nokia.com>
yi.4.shen@nokia.com [Mon, 18 Apr 2011 19:49:26 +0000 (19:49 +0000)]
2011-04-18  Yi Shen  <yi.4.shen@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] Fix Api tests for QWebPage on Symbian
        https://bugs.webkit.org/show_bug.cgi?id=56924

        Ignores the style attribute that selectedHtml() returns.

        * tests/qwebpage/tst_qwebpage.cpp:
        (tst_QWebPage::cursorMovements):
        (tst_QWebPage::textSelection):
        (tst_QWebPage::findText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84171 268f45cc-cd09-0410-ab3c-d52691b4dbfc