WebKit-https.git
10 years ago2011-01-12 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Wed, 12 Jan 2011 23:48:54 +0000 (23:48 +0000)]
2011-01-12  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        review tool formatted diff doesn't match the uploaded diff
        https://bugs.webkit.org/show_bug.cgi?id=51960

        PrettyPatch works just fine if there is no newline at the end of the file.

        * attachment.cgi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Chris Marrin <cmarrin@apple.com>
cmarrin@apple.com [Wed, 12 Jan 2011 23:41:25 +0000 (23:41 +0000)]
2011-01-12  Chris Marrin  <cmarrin@apple.com>

        Unreviewed.

        Another build fix

        * platform/graphics/ca/GraphicsLayerCA.cpp:
        (WebCore::GraphicsLayerCA::clampedContentsScaleForScale):
        * platform/graphics/ca/mac/PlatformCALayerMac.mm:
        (PlatformCALayer::setContentsScale):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-11 Matthew Delaney <mdelaney@apple.com>
mdelaney@apple.com [Wed, 12 Jan 2011 23:35:54 +0000 (23:35 +0000)]
2011-01-11  Matthew Delaney  <mdelaney@apple.com>

        Reviewed by Simon Fraser.

        Max area bound needed in creation of IOSurface in ImageBufferCG.cpp
        https://bugs.webkit.org/show_bug.cgi?id=52172

        Tests: fast/canvas/canvas-large-dimensions.html

        * platform/graphics/cg/ImageBufferCG.cpp:
        (WebCore::ImageBuffer::ImageBuffer):
2011-01-11  Matthew Delaney  <mdelaney@apple.com>

        Reviewed by Simon Fraser.

        Max area bound needed in creation of IOSurface in ImageBufferCG.cpp
        https://bugs.webkit.org/show_bug.cgi?id=52172

        * fast/canvas/canvas-large-dimensions.html: Added.
        * fast/canvas/canvas-large-dimensions-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 12 Jan 2011 23:29:27 +0000 (23:29 +0000)]
2011-01-12  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        More work on getting the drawing area proxy to paint
        https://bugs.webkit.org/show_bug.cgi?id=52328

        * UIProcess/API/mac/WKView.mm:
        (-[WKView drawRect:]):
        Handle the new drawing area.

        * UIProcess/BackingStore.cpp:
        (WebKit::BackingStore::BackingStore):
        Assert that the size isn't empty.

        * UIProcess/BackingStore.h:
        * UIProcess/mac/BackingStoreMac.mm:
        (WebKit::BackingStore::incorporateUpdate):
        Paint all update rects into the bitmap context.

        * WebProcess/WebPage/DrawingAreaImpl.cpp:
        (WebKit::DrawingAreaImpl::display):
        Create a handle so the shareable bitmap will actually be transferred over.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Wed, 12 Jan 2011 23:27:42 +0000 (23:27 +0000)]
2011-01-12  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        Bugzilla: Add keyboard shortcuts to jump to next change
        https://bugs.webkit.org/show_bug.cgi?id=52305

        Comments and diff blocks go in the same queue. If you have a
        comment focused, then j/k will focus the next/prev diff block
        with respect to that comment.

        * PrettyPatch/PrettyPatch.rb:
        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Wed, 12 Jan 2011 23:27:30 +0000 (23:27 +0000)]
2011-01-12  Daniel Bates  <dbates@rim.com>
            And Benjamin C Meyer  <bmeyer@rim.com>

        Build fix when building with Inspector disabled
        https://bugs.webkit.org/show_bug.cgi?id=52313

        After changeset 75604 <http://trac.webkit.org/changeset/75604> it's not
        possible to build when the Inspector is disabled.

        * inspector/InspectorInstrumentation.h:
        (WebCore::InspectorInstrumentation::updateApplicationCacheStatus): Fix build breakage when building
        with Inspector disabled and Offline Web Applications enabled by moving macro guard condition
        ENABLE(INSPECTOR) && ENABLE(OFFLINE_WEB_APPLICATIONS) into function body. This makes us also
        consistent with the form we use for InspectorInstrumentation::networkStateChanged() and other
        InspectorInstrumentation functions.
        * loader/appcache/ApplicationCacheGroup.cpp:
        (WebCore::ApplicationCacheGroup::didReceiveData): Fix build breakage when building with Inspector
        disabled by adding ENABLE(INSPECTOR) guard around code that references the instance variable
        ApplicationCacheGroup::m_currentResourceIdentifier as this variable only exists when building
        with the Inspector.
        (WebCore::ApplicationCacheGroup::didFinishLoading): Ditto.
        (WebCore::ApplicationCacheGroup::didFail): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Chris Marrin <cmarrin@apple.com>
cmarrin@apple.com [Wed, 12 Jan 2011 23:12:57 +0000 (23:12 +0000)]
2011-01-12  Chris Marrin  <cmarrin@apple.com>

        Unreviewed.

        Fix a build issue from http://trac.webkit.org/changeset/75639.

        * platform/graphics/GraphicsLayer.h:
        (WebCore::GraphicsLayer::contentsScale):
        (WebCore::GraphicsLayer::setContentsScale):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Chris Marrin <cmarrin@apple.com>
cmarrin@apple.com [Wed, 12 Jan 2011 23:06:09 +0000 (23:06 +0000)]
2011-01-12  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Kevin Decker.

        Pages with accelerated layers lose subpixel-AA and become blurry when a scale factor is applied
        rdar://problem/8824974

        This prevents the rootLayer (with the WebKit rendered content) from going becoming
        a tiled layer when zoomed, and when there is other layered content on the page.
        This speeds up zooming a lot and avoids some buggy behavior in CA with a very large
        number of layers.

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::paintsWithTransform):
        * rendering/RenderLayer.h:
        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::paintingGoesToWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Wed, 12 Jan 2011 22:58:31 +0000 (22:58 +0000)]
2011-01-12  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        show shared lines on both sides in code review tool
        https://bugs.webkit.org/show_bug.cgi?id=52308

        We were appending the same DOM node twice. Instead, make
        the from column a clone of the original node.

        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix build.
andersca@apple.com [Wed, 12 Jan 2011 22:44:20 +0000 (22:44 +0000)]
Fix build.

* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::incorporateUpdate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 12 Jan 2011 22:34:35 +0000 (22:34 +0000)]
2011-01-12  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Begin stubbing out some more BackingStore member functions
        https://bugs.webkit.org/show_bug.cgi?id=52323

        * UIProcess/BackingStore.cpp:
        (WebKit::BackingStore::~BackingStore):
        This was accidentally made into a constructor; it should be a destructor.

        * UIProcess/DrawingAreaProxyImpl.cpp:
        (WebKit::DrawingAreaProxyImpl::paint):
        Call the backing store.

        (WebKit::DrawingAreaProxyImpl::update):
        Incorporate the update.

        (WebKit::DrawingAreaProxyImpl::incorporateUpdate):
        Create the backing store if needed and incorporate the update.

        * UIProcess/mac/BackingStoreMac.mm: Added.
        (WebKit::BackingStore::platformInitialize):
        Create a bitmap context.

        (WebKit::BackingStore::paint):
        (WebKit::BackingStore::incorporateUpdate):
        Add stubs.

        * WebKit2.xcodeproj/project.pbxproj:
        Add BackingStoreMac.mm

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Chris Marrin <cmarrin@apple.com>
cmarrin@apple.com [Wed, 12 Jan 2011 22:27:27 +0000 (22:27 +0000)]
2011-01-12  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Simon Fraser.

        Pages with accelerated layers lose subpixel-AA and become blurry when a scale factor is applied
        rdar://problem/8824974

        When scaled, WebKit renders the page content at the scaled up size, so there are no
        scaling artifacts. But content drawn into a layer's backing store does not scale up.
        This is made worse by the fact that the root page contents become layered when there
        are other accelerated compositing layers present (video, plugins, etc.).

        Plumb scaling factor from Frame::scalePage() down into all layers with content. It
        eventually calls CALayer::setContentsScale which renders to a backing store whose dimensions
        are scaled, causing them to render larger and appear pixel perfect at the scaled
        page size.

         * page/Frame.cpp:
         (WebCore::Frame::updateContentsScale):
         (WebCore::Frame::scalePage):
         * page/Frame.h:
         * platform/graphics/GraphicsLayer.h:
         * platform/graphics/ca/GraphicsLayerCA.cpp:
         (WebCore::GraphicsLayerCA::setContentsScale):
         (WebCore::GraphicsLayerCA::clampedContentsScaleForScale):
         * platform/graphics/ca/GraphicsLayerCA.h:
         (WebCore::GraphicsLayerCA::contentsScale):
         * platform/graphics/ca/PlatformCALayer.h:
         * platform/graphics/ca/mac/PlatformCALayerMac.mm:
         (PlatformCALayer::contentsScale):
         (PlatformCALayer::setContentsScale):
         * rendering/RenderLayer.cpp:
         (WebCore::RenderLayer::updateContentsScale):
         * rendering/RenderLayer.h:
         * rendering/RenderLayerBacking.cpp:
         (WebCore::RenderLayerBacking::createGraphicsLayer):
         (WebCore::RenderLayerBacking::updateForegroundLayer):
         (WebCore::RenderLayerBacking::updateMaskLayer):
         (WebCore::RenderLayerBacking::updateContentsScale):
         * rendering/RenderLayerBacking.h:
         * rendering/RenderLayerCompositor.cpp:
         (WebCore::RenderLayerCompositor::updateContentsScale):
         * rendering/RenderLayerCompositor.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Tony Chang <tony@chromium.org>
tony@chromium.org [Wed, 12 Jan 2011 22:26:21 +0000 (22:26 +0000)]
2011-01-12  Tony Chang  <tony@chromium.org>

        Reviewed by Ojan Vafai.

        output the value of input and textarea nodes when using dump-as-markup
        https://bugs.webkit.org/show_bug.cgi?id=52319

        * editing/inserting/5607069-2-expected.txt:
        * editing/inserting/5607069-3-expected.txt:
        * editing/selection/dump-as-markup-expected.txt:
        * editing/selection/dump-as-markup-form-text-expected.txt: Added.
        * editing/selection/dump-as-markup-form-text.html: Added.
        * fast/parser/object-with-textarea-fallback-expected.txt:
        * html5lib/runner.html:
        * html5lib/webkit-resumer.html:
        * resources/dump-as-markup.js:
        (Markup.useHTML5libOutputFormat): Add a flag for html5lib compatibility
        (Markup._get):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Wed, 12 Jan 2011 21:58:12 +0000 (21:58 +0000)]
2011-01-12  Stephen White  <senorblanco@chromium.org>

        Reviewed by James Robinson.

        Fix DrawingBuffer issues for depth/stencil, extensions, etc.
        https://bugs.webkit.org/show_bug.cgi?id=52310

        1)  GL_TEXTURE is not a valid argument to glFramebufferTexture2D()
        (should be GL_TEXTURE_2D).
        2)  Support for the multisampling extension was being checked after
        the DrawingBuffer constructor was called, which calls multisample()
        to check for the extension.
        3)  If depth or stencil is set, the corresponding framebuffers must
        be created in the DrawingBuffer constructor.
        4)  GL_DEPTH_STENCIL is not a valid framebuffer internal type in
        GLES2.  Must use GL_OES_DEPTH24_STENCIL8, and check for the
        OES_packed_depth_stencil extension.

        * platform/graphics/chromium/DrawingBufferChromium.cpp:
        (WebCore::DrawingBuffer::DrawingBuffer):
        Record the extension support in the constructor.  Create all the
        secondary drawing buffers (for multisampling, depth/stencil).
        * platform/graphics/gpu/DrawingBuffer.cpp:
        (WebCore::DrawingBuffer::create):
        Check for the extensions before calling the DrawingBuffer constructor.
        (WebCore::DrawingBuffer::createSecondaryBuffers):
        Refactor creation of the secondary buffers from DrawingBufferMac.mm to
        here.
        (WebCore::DrawingBuffer::reset):
        Use DEPTH24_STENCIL8 format, not DEPTH_STENCIL.  Use
        DEPTH_COMPONENT16, not DEPTH_COMPONENT.
        Use GL_TEXTURE_2D, not GL_TEXTURE (for glFramebufferTexture2D).
        * platform/graphics/gpu/DrawingBuffer.h:
        Refactor createSecondaryBuffers().  Add extension support arguments to
        constructor.  Add support for packed_depth_stencil extension.
        * platform/graphics/gpu/mac/DrawingBufferMac.mm:
        (WebCore::DrawingBuffer::DrawingBuffer):
        Record extension support in constructor.  Refactor out creation of
        secondary buffers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Robert Hogan <robert@webkit.org>
robert@webkit.org [Wed, 12 Jan 2011 21:12:25 +0000 (21:12 +0000)]
2011-01-12  Robert Hogan  <robert@webkit.org>

        Unreviewed, add expected results.

        [Qt] Add new expected results from r75632

        https://bugs.webkit.org/show_bug.cgi?id=42887

        * platform/qt/fast/forms/search-display-none-cancel-button-expected.txt: Added.
        * platform/qt/fast/forms/search-placeholder-value-changed-expected.txt: Added.
        * platform/qt/fast/forms/search-rtl-expected.txt: Added.
        * platform/qt/fast/forms/search-styled-expected.txt: Added.
        * platform/qt/fast/forms/search-transformed-expected.txt: Added.
        * platform/qt/fast/forms/search-zoomed-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix for https://bugs.webkit.org/show_bug.cgi?id=52309 Expose
bdakin@apple.com [Wed, 12 Jan 2011 21:04:05 +0000 (21:04 +0000)]
Fix for https://bugs.webkit.org/show_bug.cgi?id=52309 Expose
fixed layout through WebKit SPI
-and corresponding-
<rdar://problem/8844464>

Reviewed by Anders Carlsson.

Source/WebCore:

Export symbols for ScrollView::setUseFixedLayout() and
ScrollView::setFixedLayoutSize()
* WebCore.exp.in:

WebKit/mac:

* WebView/WebView.mm:
(-[WebView _setUseFixedLayout:]):
(-[WebView _setFixedLayoutSize:]):
* WebView/WebViewPrivate.h:

WebKit2:

Store useFixedLayout and fixedLayoutSize in the
WebPageCreationParameters and the WebPageProxy.
* Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):
* Shared/WebPageCreationParameters.h:
* UIProcess/API/C/WKPage.cpp:
(WKPageSetUseFixedLayout):
(WKPageSetFixedLayoutSize):
* UIProcess/API/C/WKPage.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::setUseFixedLayout):
(WebKit::WebPageProxy::setFixedLayoutSize):
(WebKit::WebPageProxy::creationParameters):
* UIProcess/WebPageProxy.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setUseFixedLayout):
(WebKit::WebPage::setFixedLayoutSize):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Robert Hogan <robert@webkit.org>
robert@webkit.org [Wed, 12 Jan 2011 21:03:46 +0000 (21:03 +0000)]
2011-01-12  Robert Hogan  <robert@webkit.org>

        Unreviewed, update expected results.

        [Qt] Update expected results from r75632

        https://bugs.webkit.org/show_bug.cgi?id=42887

        * platform/qt/fast/css/pseudo-cache-stale-expected.txt:
        * platform/qt/fast/css/text-input-with-webkit-border-radius-expected.txt:
        * platform/qt/fast/forms/search-cancel-button-style-sharing-expected.txt:
        * platform/qt/fast/forms/search-vertical-alignment-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 12 Jan 2011 20:53:09 +0000 (20:53 +0000)]
2011-01-12  Anders Carlsson  <andersca@apple.com>

        Reviewed by Beth Dakin.

        Add BackingStore class
        https://bugs.webkit.org/show_bug.cgi?id=52318

        * UIProcess/BackingStore.cpp: Added.
        (WebKit::BackingStore::create):
        (WebKit::BackingStore::BackingStore):
        * UIProcess/BackingStore.h: Added.
        * WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Robert Hogan <robert@webkit.org>
robert@webkit.org [Wed, 12 Jan 2011 20:27:43 +0000 (20:27 +0000)]
2011-01-12  Robert Hogan  <robert@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Search input field doesn't have cancel button

        Add a cancel button to the search field and make it customizable
        by the client. For now, use the close dialog button associated
        with the application's style as the default.

        Unskip a bunch of search field related tests that pass now:

        fast/forms/search-cancel-button-mouseup.html
        fast/forms/search-rtl.html
        fast/forms/search-abs-pos-cancel-button.html
        fast/forms/search-styled.html
        fast/forms/search-transformed.html
        fast/forms/search-zoomed.html
        fast/forms/search-cancel-button-style-sharing.html
        fast/forms/search-display-none-cancel-button.html
        fast/forms/search-placeholder-value-changed.html
        fast/repaint/search-field-cancel.html
        fast/forms/search-cancel-button-events.html

        https://bugs.webkit.org/show_bug.cgi?id=42887

        * platform/qt/Skipped:
2011-01-12  Robert Hogan  <robert@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Search input field doesn't have cancel button

        Add a cancel button to the search field and make it customizable
        by the client. For now, use the close dialog button associated
        with the application's style as the default.

        Unskip a bunch of search field related tests that pass now:

        fast/forms/search-cancel-button-mouseup.html
        fast/forms/search-rtl.html
        fast/forms/search-abs-pos-cancel-button.html
        fast/forms/search-styled.html
        fast/forms/search-transformed.html
        fast/forms/search-zoomed.html
        fast/forms/search-cancel-button-style-sharing.html
        fast/forms/search-display-none-cancel-button.html
        fast/forms/search-placeholder-value-changed.html
        fast/repaint/search-field-cancel.html
        fast/forms/search-cancel-button-events.html

        https://bugs.webkit.org/show_bug.cgi?id=42887

        * platform/graphics/qt/ImageQt.cpp:
        (loadResourcePixmap):
        * platform/qt/RenderThemeQt.cpp:
        (WebCore::RenderThemeQt::isControlStyled):
        (WebCore::RenderThemeQt::computeSizeBasedOnStyle):
        (WebCore::RenderThemeQt::paintSearchField):
        (WebCore::RenderThemeQt::adjustSearchFieldStyle):
        (WebCore::RenderThemeQt::adjustSearchFieldCancelButtonStyle):
        (WebCore::RenderThemeQt::convertToPaintingRect):
        (WebCore::RenderThemeQt::paintSearchFieldCancelButton):
        * platform/qt/RenderThemeQt.h:
2011-01-12  Robert Hogan  <robert@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Search input field doesn't have cancel button

        Add a cancel button to the search field and make it customizable
        by the client. For now, use the close dialog button associated
        with the application's style as the default.

        https://bugs.webkit.org/show_bug.cgi?id=42887

        * Api/qwebsettings.cpp:
        (graphics):
        * Api/qwebsettings.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/8837307>, <rdar://problem/8637038>, and https://bugs.webkit.org/show_...
beidson@apple.com [Wed, 12 Jan 2011 20:12:40 +0000 (20:12 +0000)]
<rdar://problem/8837307>, <rdar://problem/8637038>, and https://bugs.webkit.org/show_bug.cgi?id=52248
Back/forward list recovery after a WebProcess crash is crashy itself.

Reviewed by Sam Weinig.

Add an isEmpty() accessor so the WebProcess knows if it is actually restoring a session:
* Shared/SessionState.cpp:
(WebKit::SessionState::isEmpty):
* Shared/SessionState.h:

Keep track of the highest used itemID so a relaunched WebProcess can later be informed:
* Shared/WebBackForwardListItem.cpp:
(WebKit::WebBackForwardListItem::WebBackForwardListItem):
(WebKit::WebBackForwardListItem::highedUsedItemID):
* Shared/WebBackForwardListItem.h:
* WebProcess/WebPage/WebBackForwardListProxy.cpp:
(WebKit::generateHistoryItemID):
(WebKit::WebBackForwardListProxy::setHighestItemIDFromUIProcess):
(WebKit::WebBackForwardListProxy::addItemFromUIProcess): Remove a now-invalid ASSERT, as the UIProcess
  now tells the WebProcess that a previous WebProcess created.
* WebProcess/WebPage/WebBackForwardListProxy.h:

Encode/decode data relevant to restoring a session on WebPage creation:
* Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):
* Shared/WebPageCreationParameters.h:

If the WebProcess has crashed since the last load, change reload and the various back/forward APIs to
update the current back/forward item (if necessary) then relaunch the process:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::reattachToWebProcessWithItem):
(WebKit::WebPageProxy::reattachToWebProcess): Renamed from "relaunch()" and made private.
(WebKit::WebPageProxy::initializeWebPage):
(WebKit::WebPageProxy::loadURL):
(WebKit::WebPageProxy::loadURLRequest):
(WebKit::WebPageProxy::reload):
(WebKit::WebPageProxy::goForward):
(WebKit::WebPageProxy::goBack):
(WebKit::WebPageProxy::goToBackForwardItem):
(WebKit::WebPageProxy::creationParameters):
* UIProcess/WebPageProxy.h:

Rename "RestoreSession" to "RestoreSessionAndNavigateToCurrentItem"
* WebProcess/WebPage/WebPage.messages.in:
* UIProcess/cf/WebPageProxyCF.cpp:
(WebKit::WebPageProxy::restoreFromSessionStateData):

Restore a session on page creation if the parameters include it:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage): Call restoreSession if session state exists.
(WebKit::WebPage::restoreSessionAndNavigateToCurrentItem):
(WebKit::WebPage::restoreSession):
* WebProcess/WebPage/WebPage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 12 Jan 2011 20:11:47 +0000 (20:11 +0000)]
2011-01-12  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Send Update and DidUpdate messages
        https://bugs.webkit.org/show_bug.cgi?id=52316

        * UIProcess/DrawingAreaProxy.h:
        (WebKit::DrawingAreaProxy::update):
        Add empty stub.

        * UIProcess/DrawingAreaProxy.messages.in:
        Add Update message.

        * UIProcess/DrawingAreaProxyImpl.cpp:
        (WebKit::DrawingAreaProxyImpl::update):
        Just send back a DidUpdate message.

        * WebProcess/WebPage/DrawingArea.h:
        (WebKit::DrawingArea::didUpdate):
        Add empty stub.

        * WebProcess/WebPage/DrawingArea.messages.in:
        Add DidUpdate message.

        * WebProcess/WebPage/DrawingAreaImpl.cpp:
        (WebKit::DrawingAreaImpl::didUpdate):
        Call display().

        (WebKit::DrawingAreaImpl::display):
        Send an Update message.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Wed, 12 Jan 2011 20:07:53 +0000 (20:07 +0000)]
2011-01-12  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: cookie table is multiplied after repeated switching to cookies tab in network item view
        Only create cookiesTable is it hasn't been done yet.
        https://bugs.webkit.org/show_bug.cgi?id=52303

        * inspector/front-end/ResourceCookiesView.js:
        (WebInspector.ResourceCookiesView.prototype.show):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agocheck-webkit-style -- close_expression function doesn't work correctly.
levin@chromium.org [Wed, 12 Jan 2011 19:41:54 +0000 (19:41 +0000)]
check-webkit-style -- close_expression function doesn't work correctly.
https://bugs.webkit.org/show_bug.cgi?id=52272

Reviewed by Shinichiro Hamaji.

* Scripts/webkitpy/style/checkers/cpp.py:
(Position.__str__): Added a way to convert it to a string which is useful in tests.
(Position.__cmp__): Added a way to compare Position which is useful in tests and
generally useful (for upcoming code changes).
(close_expression): Changed to use Position for input and output.
Also, fixed many bugs such as only working correctly for parenthesis,
not working correctly if given an offset in a line and not finding
the real closing element if there were multiple closing elements in
the same line.
(detect_functions): Adjusted due to the change in arguments for
close_expression.
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
(CppStyleTestBase.assert_positions_equal): Added a way to verify that
two positions are the same.
(CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
(CppStyleTest.test_close_expression): Added tests to catch the issues
that were fixed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 12 Jan 2011 19:41:22 +0000 (19:41 +0000)]
2011-01-12  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Make the new drawing area actually draw something
        https://bugs.webkit.org/show_bug.cgi?id=52314

        * Shared/UpdateInfo.cpp:
        (WebKit::UpdateInfo::encode):
        (WebKit::UpdateInfo::decode):
        Encode and decode newly added fields.

        * Shared/UpdateInfo.h:
        Add a vector of update rects and a handle for the sharable bitmap.

        * WebProcess/WebPage/DrawingAreaImpl.cpp:
        (WebKit::DrawingAreaImpl::display):
        Get the individual rects from the region and paint them into the shareable bitmap.

        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::mainFrameHasCustomRepresentation):
        * WebProcess/WebPage/WebPage.h:
        Add helper function.

        * WebProcess/WebPage/mac/ChunkedUpdateDrawingAreaMac.cpp:
        (WebKit::ChunkedUpdateDrawingArea::paintIntoUpdateChunk):
        Use helper function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Wed, 12 Jan 2011 19:25:22 +0000 (19:25 +0000)]
2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r75576.
        http://trac.webkit.org/changeset/75576
        https://bugs.webkit.org/show_bug.cgi?id=52304

        broke rebaseline-chromium-webkit-test (Requested by thakis on
        #webkit).

        * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/chromium.py:
        * Scripts/webkitpy/layout_tests/port/port_testcase.py:
        * Scripts/webkitpy/layout_tests/port/test.py:
        * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
        * Scripts/webkitpy/style/checkers/test_expectations.py:
        * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Wed, 12 Jan 2011 19:24:59 +0000 (19:24 +0000)]
2011-01-12  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        Add new Yarr.h header to the list file.

        * GNUmakefile.am: ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 12 Jan 2011 18:57:07 +0000 (18:57 +0000)]
2011-01-12  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Add UpdateInfo class
        https://bugs.webkit.org/show_bug.cgi?id=52306

        * Shared/UpdateInfo.cpp: Added.
        (WebKit::UpdateInfo::encode):
        (WebKit::UpdateInfo::decode):
        * Shared/UpdateInfo.h: Added.
        (WebKit::UpdateInfo::UpdateInfo):
        * WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Wed, 12 Jan 2011 18:55:13 +0000 (18:55 +0000)]
2011-01-12  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Darin Adler.

        Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
        https://bugs.webkit.org/show_bug.cgi?id=52307

        * Scripts/old-run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Nico Weber <thakis@chromium.org>
thakis@chromium.org [Wed, 12 Jan 2011 18:28:19 +0000 (18:28 +0000)]
2011-01-12  Nico Weber  <thakis@chromium.org>

        Unreviewed, test expectations.

        Remove now-unnecessary vista-specific baseline.
        https://bugs.webkit.org/show_bug.cgi?id=52105

        * platform/chromium-win-vista/svg/custom/js-late-gradient-and-object-creation-expected.checksum: Removed.
        * platform/chromium-win-vista/svg/custom/js-late-gradient-and-object-creation-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 12 Jan 2011 18:19:14 +0000 (18:19 +0000)]
2011-01-12  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        More work on the new drawing area implementation
        https://bugs.webkit.org/show_bug.cgi?id=52302

        * Platform/Region.cpp:
        (WebKit::Region::Shape::segments_end):
        segments_end could end up returning an iterator that is one element past the Vector data, so
        we can't use operator[] since that will assert.

        * WebProcess/WebPage/DrawingAreaImpl.cpp:
        (WebKit::DrawingAreaImpl::DrawingAreaImpl):
        Initialize the timer.

        (WebKit::DrawingAreaImpl::setNeedsDisplay):
        Unite the rect with the dirty region and schedule a display.

        (WebKit::DrawingAreaImpl::setSize):
        Tell the web page to resize.

        (WebKit::DrawingAreaImpl::scheduleDisplay):
        Start a display timer if needed.

        (WebKit::DrawingAreaImpl::display):
        Add a stub.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Koan-Sin Tan <koansin.tan@gmail.com>
mrobinson@webkit.org [Wed, 12 Jan 2011 18:11:44 +0000 (18:11 +0000)]
2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>

        Reviewed by Martin Robinson.

        [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
        https://bugs.webkit.org/show_bug.cgi?id=50867

        * config.h: Don't disallow ctype for (OS(DARWIN) && PLATFORM(GTK))
        Many GTK+ related files include <libintl.h> or <glib/gi18n-lib.h>.
        On Mac, <libintl.h> includes <xlocale.h>. <xclocale.h> includes
        <xlocale/_ctype.h>, which uses isacii().
        * platform/UUID.cpp:
        (WebCore::createCanonicalUUIDString): For OS(DARWIN) && !PLATFORM(CF)
        use the Chromium Linux UUID generation.
2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>

        Reviewed by Martin Robinson.

        [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
        https://bugs.webkit.org/show_bug.cgi?id=50867

        Fixed library extention for Mac in webkitdirs.pm and type conflict in
        TestNetscapePlugin.cpp

        * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
        * Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Justin Schuh <jschuh@chromium.org>
jschuh@chromium.org [Wed, 12 Jan 2011 17:57:31 +0000 (17:57 +0000)]
2011-01-12  Justin Schuh  <jschuh@chromium.org>

        Unreviewed expectatinos update.

        Excluding SVG test for sporadic image failure.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Wed, 12 Jan 2011 17:45:10 +0000 (17:45 +0000)]
2011-01-12  Martin Robinson  <mrobinson@igalia.com>

        Missing Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h in WebKitGtk tarball
        https://bugs.webkit.org/show_bug.cgi?id=52299

        * GNUmakefile.am: Fix the GTK+ build on ARMv7 by including missing source
        files in the source list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Justin Schuh <jschuh@chromium.org>
jschuh@chromium.org [Wed, 12 Jan 2011 17:31:29 +0000 (17:31 +0000)]
2011-01-12  Justin Schuh  <jschuh@chromium.org>

        Unreviewed chromium expectations update.

        Added chromium win to exclusion for bug 48164.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 12 Jan 2011 17:09:57 +0000 (17:09 +0000)]
2011-01-12  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Eric Seidel.

        [CSS Gradients] One color stop should not paint anything for linear-gradient
        https://bugs.webkit.org/show_bug.cgi?id=52259

        Share color stop parsing code between linear and radial gradients.
        Consider the gradient invalid if it has less than two color stops.

        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseLinearGradient):
        (WebCore::CSSParser::parseRadialGradient):
        (WebCore::CSSParser::parseGradientColorStops):
        * css/CSSParser.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed build fix after r75527. Rename 'BackingStoreCairo.cpp'
bfulgham@webkit.org [Wed, 12 Jan 2011 17:05:06 +0000 (17:05 +0000)]
Unreviewed build fix after r75527.  Rename 'BackingStoreCairo.cpp'
to 'ShareableBitmapCairo.cpp' to match VS project changes.

* Shared/cairo/BackingStoreCairo.cpp: Removed.
* Shared/cairo/ShareableBitmapCairo.cpp: Copied from Shared/cairo/BackingStoreCairo.cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Wed, 12 Jan 2011 16:42:46 +0000 (16:42 +0000)]
2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Add check-inspector-strings script.
        Fix inconsistencies in Inspector strings found by the script.

        https://bugs.webkit.org/show_bug.cgi?id=52295

        * English.lproj/localizedStrings.js:
        * inspector/front-end/BreakpointsSidebarPane.js:
        (WebInspector.EventListenerBreakpointsSidebarPane):
        * inspector/front-end/ProfilesPanel.js:
        (WebInspector.ProfilesPanel.prototype.setRecordingProfile):
        * inspector/front-end/Resource.js:
        (WebInspector.Resource.Type.toString):
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourceRevisionTreeElement):
        * inspector/front-end/utilities.js:
        ():
        * Scripts/check-inspector-strings: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Wed, 12 Jan 2011 16:21:54 +0000 (16:21 +0000)]
2011-01-12  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed. Fix WML compilation on Mac.

        * wml/WMLInputElement.cpp:
        (WebCore::WMLInputElement::setValue):
        (WebCore::WMLInputElement::setValueForUser):
        (WebCore::WMLInputElement::initialize):
        (WebCore::WMLInputElement::validateInputMask):
        * wml/WMLSelectElement.cpp:
        (WebCore::WMLSelectElement::listBoxSelectItem):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Justin Schuh <jschuh@chromium.org>
jschuh@chromium.org [Wed, 12 Jan 2011 16:07:53 +0000 (16:07 +0000)]
2011-01-12  Justin Schuh  <jschuh@chromium.org>

        Unreviewed build fix for debug strict compiles.

        Use fprintf for debug statements instead of fwrite, which caused compile failures
        in debug strict mode because of failure to check the fwrite return value.

        No behavior changed.

        * rendering/CounterNode.cpp:
        (WebCore::showTreeAndMark):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdvertise the .testnetscape file extension on Windows
aroben@apple.com [Wed, 12 Jan 2011 16:06:28 +0000 (16:06 +0000)]
Advertise the .testnetscape file extension on Windows

Fixes <http://webkit.org/b/52298>
plugins/no-mime-with-valid-extension.html fails on Windows

Reviewed by Dan Bernstein.

* DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
FileExtents field to map the .testnetscape file extension to the
application/x-webkit-test-netscape MIME type, just as we do on Mac.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed.
ossy@webkit.org [Wed, 12 Jan 2011 15:41:12 +0000 (15:41 +0000)]
Unreviewed.

Add Qt specific expected results for new passing tests introduced in r74954 and r74743.
Compared to Mac png files and Mac expected files.

* platform/qt/fast/css-generated-content/table-before-after-child-add-expected.checksum: Added.
* platform/qt/fast/css-generated-content/table-before-after-child-add-expected.png: Added.
* platform/qt/fast/css-generated-content/table-before-after-child-add-expected.txt: Added.
* platform/qt/fast/css-generated-content/table-cell-before-after-child-add-expected.checksum: Added.
* platform/qt/fast/css-generated-content/table-cell-before-after-child-add-expected.png: Added.
* platform/qt/fast/css-generated-content/table-cell-before-after-child-add-expected.txt: Added.
* platform/qt/fast/css-generated-content/table-row-before-after-child-add-expected.checksum: Added.
* platform/qt/fast/css-generated-content/table-row-before-after-child-add-expected.png: Added.
* platform/qt/fast/css-generated-content/table-row-before-after-child-add-expected.txt: Added.
* platform/qt/fast/css-generated-content/table-table-before-after-child-add-expected.checksum: Added.
* platform/qt/fast/css-generated-content/table-table-before-after-child-add-expected.png: Added.
* platform/qt/fast/css-generated-content/table-table-before-after-child-add-expected.txt: Added.
* platform/qt/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.checksum: Added.
* platform/qt/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png: Added.
* platform/qt/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Justin Schuh <jschuh@chromium.org>
jschuh@chromium.org [Wed, 12 Jan 2011 15:33:33 +0000 (15:33 +0000)]
2011-01-12  Justin Schuh  <jschuh@chromium.org>

        Unreviewed expectations update for chromium.

        Exclude failing test from r75064.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Wed, 12 Jan 2011 15:08:56 +0000 (15:08 +0000)]
2011-01-12  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, skip failing test on GTK.

        * platform/gtk/Skipped: Skip editing/input/page-up-down-scrolls.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Wed, 12 Jan 2011 14:42:13 +0000 (14:42 +0000)]
2011-01-12  Philippe Normand  <pnormand@igalia.com>

        Unreviewed build fix for 32-bits Release. Include GRefPtrGtk.h so
        the GdkCursor templates are found and used at runtime.

        * WebCoreSupport/FullscreenVideoController.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-29 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Wed, 12 Jan 2011 13:06:42 +0000 (13:06 +0000)]
2010-12-29  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        inspector/timeline-network-resource.html fails when run twice
        https://bugs.webkit.org/show_bug.cgi?id=37394

        Send didReceiveResponse notification to the timeline agent from ResourceLoadNotifier
        instead of ResourceLoader::didReceiveResponse to cover the cases when resources
        are loaded from memory cache.

        Network notifications are now send to InspectorInstrumentation which dispatches
        them to interested agents and InspectorController.
        fix

        * inspector/timeline-network-resource-expected.txt:
        * inspector/timeline-network-resource.html:
        * inspector/timeline-network-resource.js:
2010-12-29  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        inspector/timeline-network-resource.html fails when run twice
        https://bugs.webkit.org/show_bug.cgi?id=37394

        Send didReceiveResponse notification to the timeline agent from ResourceLoadNotifier
        instead of ResourceLoader::didReceiveResponse to cover the cases when resources
        are loaded from memory cache.

        Network notifications are now sent to InspectorInstrumentation which dispatches
        them to interested agents and InspectorController.

        * inspector/Inspector.idl:
        * inspector/InspectorApplicationCacheAgent.cpp:
        (WebCore::InspectorApplicationCacheAgent::didReceiveManifestResponse):
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::InspectorController):
        (WebCore::InspectorController::didCommitLoad):
        (WebCore::InspectorController::willSendRequest):
        (WebCore::InspectorController::didReceiveResponse):
        (WebCore::InspectorController::didFailLoading):
        (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest):
        * inspector/InspectorController.h:
        * inspector/InspectorInstrumentation.cpp:
        (WebCore::InspectorInstrumentation::identifierForInitialRequestImpl):
        (WebCore::InspectorInstrumentation::willSendRequestImpl):
        (WebCore::InspectorInstrumentation::markResourceAsCachedImpl):
        (WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCacheImpl):
        (WebCore::InspectorInstrumentation::willReceiveResourceResponseImpl):
        (WebCore::InspectorInstrumentation::didReceiveContentLengthImpl):
        (WebCore::InspectorInstrumentation::didFinishLoadingImpl):
        (WebCore::InspectorInstrumentation::didFailLoadingImpl):
        (WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequestImpl):
        (WebCore::InspectorInstrumentation::scriptImportedImpl):
        (WebCore::InspectorInstrumentation::retrieveResourceAgent):
        * inspector/InspectorInstrumentation.h:
        (WebCore::InspectorInstrumentation::identifierForInitialRequest):
        (WebCore::InspectorInstrumentation::willSendRequest):
        (WebCore::InspectorInstrumentation::markResourceAsCached):
        (WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCache):
        (WebCore::InspectorInstrumentation::willReceiveResourceResponse):
        (WebCore::InspectorInstrumentation::didReceiveContentLength):
        (WebCore::InspectorInstrumentation::didFinishLoading):
        (WebCore::InspectorInstrumentation::didFailLoading):
        (WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequest):
        (WebCore::InspectorInstrumentation::scriptImported):
        * inspector/InspectorResourceAgent.cpp:
        (WebCore::InspectorResourceAgent::identifierForInitialRequest):
        * inspector/InspectorResourceAgent.h:
        * inspector/InspectorTimelineAgent.cpp:
        (WebCore::InspectorTimelineAgent::willSendResourceRequest):
        * inspector/InspectorTimelineAgent.h:
        * inspector/TimelineRecordFactory.cpp:
        (WebCore::TimelineRecordFactory::createResourceSendRequestData):
        * inspector/TimelineRecordFactory.h:
        * inspector/front-end/NetworkManager.js:
        (WebInspector.NetworkManager.prototype.identifierForInitialRequest):
        * inspector/front-end/TimelinePanel.js:
        (WebInspector.TimelinePanel.prototype.addRecordToTimeline):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::loadedResourceFromMemoryCache):
        * loader/ResourceLoadNotifier.cpp:
        (WebCore::ResourceLoadNotifier::didReceiveResponse):
        (WebCore::ResourceLoadNotifier::didFailToLoad):
        (WebCore::ResourceLoadNotifier::assignIdentifierToInitialRequest):
        (WebCore::ResourceLoadNotifier::dispatchWillSendRequest):
        (WebCore::ResourceLoadNotifier::dispatchDidReceiveResponse):
        (WebCore::ResourceLoadNotifier::dispatchDidReceiveContentLength):
        (WebCore::ResourceLoadNotifier::dispatchDidFinishLoading):
        (WebCore::ResourceLoadNotifier::sendRemainingDelegateMessages):
        * loader/ResourceLoader.cpp:
        (WebCore::ResourceLoader::didReceiveResponse):
        * loader/appcache/ApplicationCacheGroup.cpp:
        (WebCore::ApplicationCacheGroup::createResourceHandle):
        (WebCore::ApplicationCacheGroup::didReceiveResponse):
        (WebCore::ApplicationCacheGroup::didReceiveData):
        (WebCore::ApplicationCacheGroup::didFinishLoading):
        (WebCore::ApplicationCacheGroup::didFail):
        * loader/appcache/ApplicationCacheGroup.h:
        * workers/DefaultSharedWorkerRepository.cpp:
        (WebCore::SharedWorkerScriptLoader::notifyFinished):
        * workers/Worker.cpp:
        (WebCore::Worker::notifyFinished):
        * workers/WorkerContext.cpp:
        (WebCore::WorkerContext::importScripts):
        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::didFinishLoading):
2010-12-29  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        inspector/timeline-network-resource.html fails when run twice
        https://bugs.webkit.org/show_bug.cgi?id=37394

        Send didReceiveResponse notification to the timeline agent from ResourceLoadNotifier
        instead of ResourceLoader::didReceiveResponse to cover the cases when resources
        are loaded from memory cache.

        Network notifications are now sent to InspectorInstrumentation which dispatches
        them to interested agents and InspectorController.

        * src/SharedWorkerRepository.cpp:
        (WebCore::SharedWorkerScriptLoader::notifyFinished):
        * src/WebDevToolsAgentImpl.cpp:
        (WebKit::WebDevToolsAgentImpl::mainFrame):
        (WebKit::WebDevToolsAgentImpl::identifierForInitialRequest):
        (WebKit::WebDevToolsAgentImpl::willSendRequest):
        (WebKit::WebDevToolsAgentImpl::didReceiveData):
        (WebKit::WebDevToolsAgentImpl::didReceiveResponse):
        (WebKit::WebDevToolsAgentImpl::didFinishLoading):
        (WebKit::WebDevToolsAgentImpl::didFailLoading):
        * src/WebDevToolsAgentImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Wed, 12 Jan 2011 13:03:48 +0000 (13:03 +0000)]
2011-01-12  Jeremy Orlow  <jorlow@chromium.org>

        Add forgotten file.

        * storage/indexeddb/transaction-read-only-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Peter Varga <pvarga@webkit.org>
pvarga@webkit.org [Wed, 12 Jan 2011 12:57:06 +0000 (12:57 +0000)]
2011-01-12  Peter Varga  <pvarga@webkit.org>

        Reviewed by Gavin Barraclough.

        Add Yarr.h to YARR
        https://bugs.webkit.org/show_bug.cgi?id=51021

        Move other common constants and functions from YARR's different files
        to Yarr.h.
        Use Yarr.h header instead of including other YARR headers where it
        is possible.

        * JavaScriptCore.gypi:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * runtime/RegExp.cpp:
        * yarr/Yarr.h: Added.
        * yarr/YarrInterpreter.cpp:
        * yarr/YarrInterpreter.h:
        * yarr/YarrJIT.cpp:
        (JSC::Yarr::jitCompile):
        (JSC::Yarr::execute):
        * yarr/YarrJIT.h:
        * yarr/YarrParser.h:
        * yarr/YarrPattern.cpp:
        (JSC::Yarr::YarrPattern::compile):
        (JSC::Yarr::YarrPattern::YarrPattern):
        * yarr/YarrPattern.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Wed, 12 Jan 2011 12:55:40 +0000 (12:55 +0000)]
2011-01-12  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: do not replace all tabs with spaces when editing script source
        https://bugs.webkit.org/show_bug.cgi?id=52291

        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype.setContent):
        (WebInspector.SourceFrame.prototype._editLine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 12 Jan 2011 12:29:29 +0000 (12:29 +0000)]
2011-01-12  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Make webkit-patch support subdirectories for SVN checkouts
        https://bugs.webkit.org/show_bug.cgi?id=52261

        os.relpath does not exist on Python 2.5, so we need to call our version
        of the API.

        * Scripts/webkitpy/common/checkout/scm.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Wed, 12 Jan 2011 12:22:15 +0000 (12:22 +0000)]
2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r74344.
        http://trac.webkit.org/changeset/74344
        https://bugs.webkit.org/show_bug.cgi?id=52290

        broke QWebPluginFactory for unusual mime-types (Requested by
        kling on #webkit).

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::createPlugin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed.
ossy@webkit.org [Wed, 12 Jan 2011 11:28:42 +0000 (11:28 +0000)]
Unreviewed.

[Qt] plugins/no-mime-with-valid-extension.html fails
https://bugs.webkit.org/show_bug.cgi?id=52288

* platform/qt/Skipped: plugins/no-mime-with-valid-extension.html added until fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r75595.
ossy@webkit.org [Wed, 12 Jan 2011 11:16:40 +0000 (11:16 +0000)]
Unreviewed, rolling out r75595.
http://trac.webkit.org/changeset/75595
https://bugs.webkit.org/show_bug.cgi?id=52286

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-01-12
It broke fast/regex/pcre-test-1.html (Requested by Ossy on
#webkit).

* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* runtime/RegExp.cpp:
* yarr/Yarr.h: Removed.
* yarr/YarrInterpreter.cpp:
* yarr/YarrInterpreter.h:
* yarr/YarrJIT.cpp:
(JSC::Yarr::jitCompile):
* yarr/YarrJIT.h:
(JSC::Yarr::execute):
* yarr/YarrParser.h:
* yarr/YarrPattern.cpp:
(JSC::Yarr::compile):
(JSC::Yarr::YarrPattern::YarrPattern):
* yarr/YarrPattern.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-11 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Wed, 12 Jan 2011 10:40:39 +0000 (10:40 +0000)]
2011-01-11  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Nate Chapin.

        Enforce READ_ONLY transactions in IndexedDB
        https://bugs.webkit.org/show_bug.cgi?id=52229

        Fix existing errors in tests + add a new test for
        this issue.

        * storage/indexeddb/cursor-delete-expected.txt:
        * storage/indexeddb/cursor-delete.html:
        * storage/indexeddb/cursor-index-delete-expected.txt:
        * storage/indexeddb/cursor-index-delete.html:
        * storage/indexeddb/database-quota-expected.txt:
        * storage/indexeddb/database-quota.html:
        * storage/indexeddb/objectstore-basics-expected.txt:
        * storage/indexeddb/objectstore-basics.html:
        * storage/indexeddb/objectstore-removeobjectstore-expected.txt:
        * storage/indexeddb/objectstore-removeobjectstore.html:
        * storage/indexeddb/transaction-basics-expected.txt:
        * storage/indexeddb/transaction-basics.html:
        * storage/indexeddb/transaction-crash-on-abort-expected.txt:
        * storage/indexeddb/transaction-crash-on-abort.html:
        * storage/indexeddb/transaction-read-only.html: Added.
2011-01-11  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Nate Chapin.

        Enforce READ_ONLY transactions in IndexedDB
        https://bugs.webkit.org/show_bug.cgi?id=52229

        Add READ_ONLY_ERR and return it whenever delete or put
        are called.  Note that IDBCursor's delete and update
        are simply aliases for delete/put, which is why no
        extra code is required to handle those cases.

        Test: storage/indexeddb/transaction-read-only.html

        * dom/ExceptionCode.cpp:
        * storage/IDBCursorBackendImpl.cpp:
        (WebCore::IDBCursorBackendImpl::deleteFunction):
        * storage/IDBDatabase.idl:
        * storage/IDBDatabaseException.h:
        * storage/IDBDatabaseException.idl:
        * storage/IDBObjectStoreBackendImpl.cpp:
        (WebCore::IDBObjectStoreBackendImpl::put):
        (WebCore::IDBObjectStoreBackendImpl::deleteFunction):
        (WebCore::IDBObjectStoreBackendImpl::deleteIndex):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Peter Varga <pvarga@webkit.org>
pvarga@webkit.org [Wed, 12 Jan 2011 10:32:29 +0000 (10:32 +0000)]
2011-01-12  Peter Varga  <pvarga@webkit.org>

        Reviewed by Gavin Barraclough.

        Add Yarr.h to YARR
        https://bugs.webkit.org/show_bug.cgi?id=51021

        Move other common constants and functions from YARR's different files
        to Yarr.h.
        Use Yarr.h header instead of including other YARR headers where it
        is possible.

        * JavaScriptCore.gypi:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * runtime/RegExp.cpp:
        * yarr/Yarr.h: Added.
        * yarr/YarrInterpreter.cpp:
        * yarr/YarrInterpreter.h:
        * yarr/YarrJIT.cpp:
        (JSC::Yarr::jitCompile):
        (JSC::Yarr::execute):
        * yarr/YarrJIT.h:
        * yarr/YarrParser.h:
        * yarr/YarrPattern.cpp:
        (JSC::Yarr::YarrPattern::compile):
        (JSC::Yarr::YarrPattern::YarrPattern):
        * yarr/YarrPattern.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-11 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Wed, 12 Jan 2011 09:27:30 +0000 (09:27 +0000)]
2011-01-11  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Eric Seidel.

        [GTK] minimal build breaks in RenderThemeGtk3
        https://bugs.webkit.org/show_bug.cgi?id=52202

        * platform/gtk/RenderThemeGtk3.cpp: Added VIDEO guards around
        initMediaColors().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-11 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Wed, 12 Jan 2011 09:08:23 +0000 (09:08 +0000)]
2011-01-11  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Eric Carlson.

        [GStreamer] PlatformVideoWindowMac implementation
        https://bugs.webkit.org/show_bug.cgi?id=50770

        This new implementation will be used on Mac OS to display the
        fullscreen video window with the GStreamer-based media player.

        * platform/graphics/gstreamer/GStreamerGWorld.cpp:
        (WebCore::gstGWorldSyncMessageCallback):
        * platform/graphics/gstreamer/PlatformVideoWindow.h:
        (WebCore::PlatformVideoWindow::window):
        * platform/graphics/gstreamer/PlatformVideoWindowMac.mm:
        (PlatformVideoWindow::PlatformVideoWindow):
        (PlatformVideoWindow::~PlatformVideoWindow):
        (PlatformVideoWindow::prepareForOverlay):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Wed, 12 Jan 2011 08:37:43 +0000 (08:37 +0000)]
2011-01-12  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        fix wrapping bug in expansion lines in the code review tool
        https://bugs.webkit.org/show_bug.cgi?id=52270

        * PrettyPatch/PrettyPatch.rb:
        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-11 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Wed, 12 Jan 2011 07:57:01 +0000 (07:57 +0000)]
2011-01-11  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by David Levin.

        Fix typo in WebKit2 skipped list which was causing a test to not get skipped
        https://bugs.webkit.org/show_bug.cgi?id=52277

        * platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-11 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Wed, 12 Jan 2011 07:41:46 +0000 (07:41 +0000)]
2011-01-11  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Eric Seidel.

        Close additional pages opened during a test once the test completes.
        https://bugs.webkit.org/show_bug.cgi?id=52276

        * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
        (WTR::InjectedBundle::done):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-11 David Levin <levin@chromium.org>
levin@chromium.org [Wed, 12 Jan 2011 06:53:51 +0000 (06:53 +0000)]
2011-01-11  David Levin  <levin@chromium.org>

        Reviewed by Eric Seidel.

        Errors should be separated from the command line in bot messages.
        https://bugs.webkit.org/show_bug.cgi?id=52275

        * Scripts/webkitpy/common/system/executive.py:
        (ScriptError.message_with_output): Added a newline to separate the command
        line from the errors.
        * Scripts/webkitpy/common/system/executive_unittest.py:
        (ScriptErrorTest.test_message_with_output): Added tests for the various code
        paths in message_with_output.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-11 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 12 Jan 2011 05:25:00 +0000 (05:25 +0000)]
2011-01-11  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Webkit crashes when a gradient is applied using the first-line pseudo element
        https://bugs.webkit.org/show_bug.cgi?id=52225

        When a pseudostyle references images, we fail to register/unregister
        the relevant RenderObjects as clients of the image in the style.
        For gradients, this caused a crash.

        This patch fixes the crash by returning a null gradient image in this
        situation.

        Test: fast/gradients/gradient-on-pseudoelement-crash.html

        * css/CSSGradientValue.cpp:
        (WebCore::CSSGradientValue::image):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-11 Justin Schuh <jschuh@chromium.org>
jschuh@chromium.org [Wed, 12 Jan 2011 03:35:02 +0000 (03:35 +0000)]
2011-01-11  Justin Schuh  <jschuh@chromium.org>

        Unreviewed chromium expectations update.

        Windows exclusion for no-mime-with-valid-extension.html (from r75567)

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-11 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 12 Jan 2011 03:20:46 +0000 (03:20 +0000)]
2011-01-11  Eric Seidel  <eric@webkit.org>

        Unreviewed.

        commit-queue should know how to upload archived results (for test flakes or general failures)
        https://bugs.webkit.org/show_bug.cgi?id=52048

        The zips are mostly empty due to forgetting -r.
        Expected diffs were not being pulled from the archive due
        to the archive having longer paths than I realized.

        * Scripts/webkitpy/common/system/workspace.py:
        * Scripts/webkitpy/common/system/workspace_unittest.py:
        * Scripts/webkitpy/tool/bot/flakytestreporter.py:
        * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-11 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 12 Jan 2011 02:38:57 +0000 (02:38 +0000)]
2011-01-11  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, fix typo in expectations file.

        * platform/chromium-gpu/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-11 Nico Weber <thakis@chromium.org>
thakis@chromium.org [Wed, 12 Jan 2011 02:16:56 +0000 (02:16 +0000)]
2011-01-11  Nico Weber  <thakis@chromium.org>

        Unreviewed, test expectations.

        Remove now-unnecessary xp-specific baseline.
        https://bugs.webkit.org/show_bug.cgi?id=52105

        * platform/chromium-win-xp/fast/gradients/radial-centered-expected.checksum: Removed.
        * platform/chromium-win-xp/fast/gradients/radial-centered-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-11 Andy Estes <aestes@apple.com>
aestes@apple.com [Wed, 12 Jan 2011 01:57:36 +0000 (01:57 +0000)]
2011-01-11  Andy Estes  <aestes@apple.com>

        Reviewed by Darin Adler.

        REGRESSION (r71562): servePendingRequests() no longer called when
        resources are done loading.
        https://bugs.webkit.org/show_bug.cgi?id=52264
        <rdar://problem/8767429>

        In r71562, servePendingRequests() is no longer called in Loader's
        didFinishLoading(), didFail() and didReceiveResponse() methods. Since
        r71562 was intended only as a refactoring, these calls should be
        restored. At least one WebKit-based Mac OS X application relies on this
        for correct behavior.

        * loader/cache/CachedResourceLoader.cpp:
        (WebCore::CachedResourceLoader::loadDone): Call
        resourceLoadScheduler()->servePendingRequests().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-11 Adrienne Walker <enne@google.com>
enne@google.com [Wed, 12 Jan 2011 01:36:29 +0000 (01:36 +0000)]
2011-01-11  Adrienne Walker  <enne@google.com>

        Unreviewed, test expectations update.

        Revert expect change for Snow Leopard in r75570.

        * platform/mac-snowleopard/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-11 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Wed, 12 Jan 2011 01:28:20 +0000 (01:28 +0000)]
2011-01-11  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed; chromium test expectations update.

        Remove failing expectations for tests that pass after r75569.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-11 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Wed, 12 Jan 2011 01:26:04 +0000 (01:26 +0000)]
2011-01-11  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Eric Seidel.

        Add Document::setContent()
        https://bugs.webkit.org/show_bug.cgi?id=52085

        Add a method to Document to set the whole content at once.
        This removes the hack of the insert method in the xml parser
        and is a predecessor to feed the xml parser with raw data.

        * dom/Document.cpp:
        (WebCore::Document::setContent):
        * dom/Document.h:
        * dom/XMLDocumentParser.cpp:
        (WebCore::XMLDocumentParser::insert): Added ASSERT_NOT_REACHED().
        * loader/cache/CachedFont.cpp:
        (WebCore::CachedFont::ensureSVGFontData): Use setContent.
        * xml/DOMParser.cpp:
        (WebCore::DOMParser::parseFromString): Ditto.
        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::responseXML): Ditto.
        * xml/XSLTProcessor.cpp:
        (WebCore::XSLTProcessor::createDocumentFromSource): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-11 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 12 Jan 2011 01:15:46 +0000 (01:15 +0000)]
2011-01-11  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Ojan Vafai.

        The current modifier parsing code in test_expectations is
        fragile and hard-coded, so it's not easy to understand the logic
        or easily add new types of modifiers (like GPU vs. CPU testing
        for graphics tests, or 32-bit vs. 64-bit differences).

        This is the first of two patches that will add in more generic
        support and then eliminate the GPU-specific test expectations
        files for Chromium.

        This patch adds two standalone objects for handling modifiers. The
        rules for interpreting modifiers, precedence, and conflicts are
        given in the docstring to the ModifierMatcher class, which
        returns ModifierMatchResult objects.

        This patch also adds routines to the Port interface and a
        default set of values in the base object, in order to obtain the
        values needed on a given test run. These values are then passed
        to the expectation parser. This also allows us to clean up the
        logic used to lint all of the different configurations in a
        single test_expectations.txt file.

        The next patch will merge in the separate GPU expectations file.

        https://bugs.webkit.org/show_bug.cgi?id=51222

        * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/base_unittest.py:
        * Scripts/webkitpy/layout_tests/port/chromium.py:
        * Scripts/webkitpy/layout_tests/port/port_testcase.py:
        * Scripts/webkitpy/layout_tests/port/test.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-11 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Wed, 12 Jan 2011 00:56:54 +0000 (00:56 +0000)]
2011-01-11  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Adam Barth.

        Make webkit-patch support subdirectories for SVN checkouts
        https://bugs.webkit.org/show_bug.cgi?id=52261

        * Scripts/webkitpy/common/checkout/scm.py:
        * Scripts/webkitpy/style_references.py:
        * Scripts/webkitpy/tool/main.py:
        * Scripts/webkitpy/tool/steps/preparechangelog.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-11 James Robinson <jamesr@chromium.org>
jamesr@google.com [Wed, 12 Jan 2011 00:56:38 +0000 (00:56 +0000)]
2011-01-11  James Robinson  <jamesr@chromium.org>

        Update test to use layoutTestController.waitUntilDone()/notifyDone() since it relies on the scroll event which is now async.

        * fast/repaint/resources/fixed-move-after-keyboard-scroll-iframe.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed build fix.
bfulgham@webkit.org [Wed, 12 Jan 2011 00:53:21 +0000 (00:53 +0000)]
Unreviewed build fix.

* platform/graphics/cairo/PathCairo.cpp:
(WebCore::Path::addArc): Switch to MathExtra's piFloat define,
rather than M_PI which is not always available.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-11 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Wed, 12 Jan 2011 00:52:40 +0000 (00:52 +0000)]
2011-01-11  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed; chromium test expectations update.

        Remove failing expectations for tests that pass after r75552.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-11 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Wed, 12 Jan 2011 00:43:09 +0000 (00:43 +0000)]
2011-01-11  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        fix difflink centering to be vertical, not horizontal
        https://bugs.webkit.org/show_bug.cgi?id=52263

        * PrettyPatch/PrettyPatch.rb:
        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-11 Adrienne Walker <enne@google.com>
enne@google.com [Wed, 12 Jan 2011 00:39:20 +0000 (00:39 +0000)]
2011-01-11  Adrienne Walker  <enne@google.com>

        Reviewed by Kenneth Russell.

        Sync WebGL texImage2D video test from Khronos and re-enable it.
        https://bugs.webkit.org/show_bug.cgi?id=44459

        * fast/canvas/webgl/resources/quadrants.mp4: Removed.
        * fast/canvas/webgl/resources/quadrants.ogv: Removed.
        * fast/canvas/webgl/resources/red-green.mp4: Added.
        * fast/canvas/webgl/resources/red-green.theora.ogv: Added.
        * fast/canvas/webgl/resources/red-green.webmvp8.webm: Added.
        * fast/canvas/webgl/tex-image-and-sub-image-2d-with-video-expected.txt:
        * fast/canvas/webgl/tex-image-and-sub-image-2d-with-video.html:
        * platform/chromium-gpu/test_expectations.txt:
        * platform/chromium/test_expectations.txt:
        * platform/mac-snowleopard/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-11 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Wed, 12 Jan 2011 00:36:46 +0000 (00:36 +0000)]
2011-01-11  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed, new chromium-mac baselines.

        Rebaseline after the scrollbar change (these tests still need
        chromium-mac baselines since they have controls or images that render
        slightly differently from the Mac port).

        * platform/chromium-mac/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.checksum:
        * platform/chromium-mac/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
        * platform/chromium-mac/fast/block/margin-collapse/103-expected.checksum: Added.
        * platform/chromium-mac/fast/block/margin-collapse/103-expected.png: Added.
        * platform/chromium-mac/fast/borders/border-image-rotate-transform-expected.checksum:
        * platform/chromium-mac/fast/borders/border-image-rotate-transform-expected.png:
        * platform/chromium-mac/fast/events/pointer-events-2-expected.checksum:
        * platform/chromium-mac/fast/events/pointer-events-2-expected.png:
        * platform/chromium-mac/fast/images/gif-large-checkerboard-expected.checksum: Removed.
        * platform/chromium-mac/fast/images/gif-large-checkerboard-expected.png: Removed.
        * platform/chromium-mac/fast/replaced/width100percent-image-expected.checksum: Added.
        * platform/chromium-mac/fast/replaced/width100percent-image-expected.png: Added.
        * platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.checksum: Added.
        * platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png: Added.
        * platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.checksum: Added.
        * platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png: Added.
        * platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.checksum: Added.
        * platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png: Added.
        * platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.checksum: Added.
        * platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png: Added.
        * platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.checksum: Added.
        * platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png: Added.
        * platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.checksum: Added.
        * platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png: Added.
        * platform/chromium-mac/svg/zoom/page/zoom-mask-with-percentages-expected.checksum: Added.
        * platform/chromium-mac/svg/zoom/page/zoom-mask-with-percentages-expected.png: Added.
        * platform/chromium-mac/tables/mozilla/bugs/bug101674-expected.checksum: Added.
        * platform/chromium-mac/tables/mozilla/bugs/bug101674-expected.png: Added.
        * platform/chromium-mac/tables/mozilla/bugs/bug29314-expected.checksum: Added.
        * platform/chromium-mac/tables/mozilla/bugs/bug29314-expected.png: Added.
        * platform/chromium-mac/tables/mozilla/bugs/bug5797-expected.checksum: Added.
        * platform/chromium-mac/tables/mozilla/bugs/bug5797-expected.png: Added.
        * platform/chromium-mac/tables/mozilla/bugs/bug625-expected.checksum: Added.
        * platform/chromium-mac/tables/mozilla/bugs/bug625-expected.png: Added.
        * platform/chromium-mac/tables/mozilla/core/bloomberg-expected.checksum: Added.
        * platform/chromium-mac/tables/mozilla/core/bloomberg-expected.png: Added.
        * platform/chromium-mac/tables/mozilla/core/row_span-expected.checksum: Added.
        * platform/chromium-mac/tables/mozilla/core/row_span-expected.png: Added.
        * platform/chromium-mac/tables/mozilla/other/cell_widths-expected.checksum: Added.
        * platform/chromium-mac/tables/mozilla/other/cell_widths-expected.png: Added.
        * platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug85016-expected.checksum: Added.
        * platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug85016-expected.png: Added.
        * platform/chromium-mac/tables/mozilla_expected_failures/other/test4-expected.checksum: Added.
        * platform/chromium-mac/tables/mozilla_expected_failures/other/test4-expected.png: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-11 Jeff Miller <jeffm@apple.com>
commit-queue@webkit.org [Wed, 12 Jan 2011 00:33:37 +0000 (00:33 +0000)]
2011-01-11  Jeff Miller  <jeffm@apple.com>

        Reviewed by John Sullivan.

        WebKit2: "Webpages not responding" dialog appears when <select> popup menu is showing
        https://bugs.webkit.org/show_bug.cgi?id=52242

        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::showPopupMenu):
        On Windows, stop the responsiveness timer before calling showPopupMenu().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-11 Nicolas Dufresne <nicolas.dufresne@collabora.co.uk>
commit-queue@webkit.org [Wed, 12 Jan 2011 00:33:21 +0000 (00:33 +0000)]
2011-01-11  Nicolas Dufresne  <nicolas.dufresne@collabora.co.uk>

        Reviewed by Adam Barth.

        Use plug-in DB for extensions to MIME type convertion

        Plugins extension to MIME type conversion was not used in the
        frameLoader. This was causing some fallback to be use which as the side
        effect of loosing all the <OBJECT> parameters or <EMBED> attributes.
        This patch ensure that we try to convert the extension to MIME type
        using the plugin database beofre using this fallback.

        Attribute lost with Flash plugin without mime type set
        https://bugs.webkit.org/show_bug.cgi?id=50657

        * plugins/no-mime-with-valid-extension.html: Added.
        * plugins/no-mime-with-valid-extension-expected.txt: Added.
2011-01-11  Nicolas Dufresne  <nicolas.dufresne@collabora.co.uk>

        Reviewed by Adam Barth.

        Use plug-in DB for extensions to MIME type convertion

        Plugins extension to MIME type conversion was not used in the
        frameLoader. This was causing some fallback to be use which as the side
        effect of loosing all the <OBJECT> parameters or <EMBED> attributes.
        This patch ensure that we try to convert the extension to MIME type
        using the plugin database beofre using this fallback.

        Attribute lost with Flash plugin without mime type set
        https://bugs.webkit.org/show_bug.cgi?id=50657

        Test: plugins/no-mime-with-valid-extension.html

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::defaultObjectContentType): Use PluginDatabase for MIME

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-11 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Wed, 12 Jan 2011 00:17:10 +0000 (00:17 +0000)]
2011-01-11  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Anders Carlsson.

        UIProcess kills the WebProcess sometimes when detached frames exist
        https://bugs.webkit.org/show_bug.cgi?id=52227

        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::didSaveFrameToPageCache): Don't consider the message invalid
        if it came in for a detached frame.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-11 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Tue, 11 Jan 2011 23:56:50 +0000 (23:56 +0000)]
2011-01-11  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        remember diffstate for review tool
        https://bugs.webkit.org/show_bug.cgi?id=52253

        If you use the global sidebyside/unified links, store the diff type
        in localstorage. Then, onload, use that diff type. That way, people
        who prefer one diff type or the other can always get that by default.

        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-11 Justin Schuh <jschuh@chromium.org>
jschuh@chromium.org [Tue, 11 Jan 2011 23:44:55 +0000 (23:44 +0000)]
2011-01-11  Justin Schuh  <jschuh@chromium.org>

        Unreviewed, test expectations update.

        Flaky expectations for textOnPath.svg.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix.
andersca@apple.com [Tue, 11 Jan 2011 23:41:14 +0000 (23:41 +0000)]
Build fix.

* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-11 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 11 Jan 2011 23:40:26 +0000 (23:40 +0000)]
2011-01-11  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Add a Region class which represents a graphical region
        https://bugs.webkit.org/show_bug.cgi?id=52255

        * Platform/Region.cpp: Added.
        (WebKit::Region::Region):
        (WebKit::Region::rects):
        (WebKit::Region::Shape::Shape):
        (WebKit::Region::Shape::appendSpan):
        (WebKit::Region::Shape::canCoalesce):
        (WebKit::Region::Shape::appendSpans):
        (WebKit::Region::Shape::appendSegment):
        (WebKit::Region::Shape::spans_begin):
        (WebKit::Region::Shape::spans_end):
        (WebKit::Region::Shape::segments_begin):
        (WebKit::Region::Shape::segments_end):
        (WebKit::Region::Shape::dump):
        (WebKit::Region::Shape::bounds):
        (WebKit::Region::Shape::move):
        (WebKit::Region::Shape::swap):
        (WebKit::Region::Shape::shapeOperation):
        (WebKit::Region::Shape::UnionOperation::trySimpleOperation):
        (WebKit::Region::Shape::unionShapes):
        (WebKit::Region::Shape::IntersectOperation::trySimpleOperation):
        (WebKit::Region::Shape::intersectShapes):
        (WebKit::Region::Shape::SubtractOperation::trySimpleOperation):
        (WebKit::Region::Shape::subtractShapes):
        (WebKit::Region::dump):
        (WebKit::Region::intersect):
        (WebKit::Region::unite):
        (WebKit::Region::subtract):
        (WebKit::Region::move):
        * Platform/Region.h: Added.
        (WebKit::Region::bounds):
        (WebKit::Region::isEmpty):
        (WebKit::Region::Span::Span):
        (WebKit::Region::Shape::isEmpty):
        * WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-11 Tony Chang <tony@chromium.org>
tony@chromium.org [Tue, 11 Jan 2011 23:35:54 +0000 (23:35 +0000)]
2011-01-11  Tony Chang  <tony@chromium.org>

        Reviewed by Eric Seidel.

        [chromium] copy test netscape plugin into TestNetscapePlugin
        https://bugs.webkit.org/show_bug.cgi?id=52232

        * WebKit.gyp: Make a copy of the TestNetscapePlugIn in
            TestNetscapePlugIn and WebKitTestNetscapePlugIn

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-11 James Simonsen <simonjam@chromium.org>
simonjam@chromium.org [Tue, 11 Jan 2011 23:19:29 +0000 (23:19 +0000)]
2011-01-11  James Simonsen  <simonjam@chromium.org>

        Reviewed by Eric Seidel.

        [Web Timing] Rename sslHandshakeStart to secureConnectionStart
        https://bugs.webkit.org/show_bug.cgi?id=52239

        * fast/dom/Window/window-properties-performance-expected.txt:
        * fast/dom/script-tests/webtiming.js:
        (checkTimingBeforeLoad):
        (checkTimingWhileDeferred):
        (checkWebTimingOnDOMContentLoaded):
        (checkWebTimingWhileAsync):
        (checkWebTimingOnLoad):
        (checkWebTimingAfterLoad):
        * fast/dom/webtiming-document-open-expected.txt:
        * fast/dom/webtiming-expected.txt:
        * fast/dom/webtiming-navigate-within-document-expected.txt:
        * http/tests/misc/resources/webtiming-cross-origin-and-back2.html:
        * http/tests/misc/resources/webtiming-cross-origin-redirect.html:
        * http/tests/misc/resources/webtiming-no-origin.html:
        * http/tests/misc/resources/webtiming-ssl.html:
        * http/tests/misc/webtiming-origins-expected.txt:
        * http/tests/misc/webtiming-ssl-expected.txt:
2011-01-11  James Simonsen  <simonjam@chromium.org>

        Reviewed by Eric Seidel.

        [Web Timing] Rename sslHandshakeStart to secureConnectionStart
        https://bugs.webkit.org/show_bug.cgi?id=52239

        * page/PerformanceTiming.cpp:
        (WebCore::PerformanceTiming::secureConnectionStart):
        * page/PerformanceTiming.h:
        * page/PerformanceTiming.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-11 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Tue, 11 Jan 2011 23:16:23 +0000 (23:16 +0000)]
2011-01-11  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        allow sidebysideifying individual files in the code review tool
        https://bugs.webkit.org/show_bug.cgi?id=52226

        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-11 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 11 Jan 2011 22:58:10 +0000 (22:58 +0000)]
2011-01-11  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin Adler.

        Add DidSetSize message
        https://bugs.webkit.org/show_bug.cgi?id=52254

        * DerivedSources.make:
        Add DrawingAReaProxy.messages.in.

        * Platform/CoreIPC/MessageID.h:
        Add DrawingAreaProxy message class.

        * UIProcess/DrawingAreaProxy.h:
        (WebKit::DrawingAreaProxy::didSetSize):
        Add CoreIPC message handler function.

        * UIProcess/DrawingAreaProxy.messages.in: Added.

        * UIProcess/DrawingAreaProxyImpl.cpp:
        (WebKit::DrawingAreaProxyImpl::didSetSize):
        Add stub.

        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::didReceiveMessage):
        Handle DrawingAreaProxy messages.

        * WebKit2.xcodeproj/project.pbxproj:
        Add new files.

        * WebProcess/WebPage/DrawingAreaImpl.cpp:
        (WebKit::DrawingAreaImpl::setSize):
        Send a DidSetSize message for now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-11 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 11 Jan 2011 22:53:39 +0000 (22:53 +0000)]
2011-01-11  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Introduce the notion of a "display-isolated" URL scheme for use by
        Chrome-internal URLs
        https://bugs.webkit.org/show_bug.cgi?id=50182

        This patch actually makes the display-isolated schemes display
        isolated.  The behavior should be the same as the previous iteration of
        this patch, but re-organized a bit because reading the access white
        list is expensive.

        * page/SecurityOrigin.cpp:
        (WebCore::SecurityOrigin::isAccessToURLWhiteListed):
        (WebCore::SecurityOrigin::canDisplay):
        * page/SecurityOrigin.h:
        * platform/SchemeRegistry.cpp:
        * platform/SchemeRegistry.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-11 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Tue, 11 Jan 2011 22:47:10 +0000 (22:47 +0000)]
2011-01-11  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Darin Fisher.

        Scroll event should be fired asynchronously
        https://bugs.webkit.org/show_bug.cgi?id=45631

        Update existing tests that assumed that scroll events fired
        synchronously.

        * editing/input/page-up-down-scrolls-expected.txt:
        * editing/input/page-up-down-scrolls.html:
        * fast/events/fire-scroll-event-element-expected.txt: Copied from LayoutTests/fast/events/fire-scroll-event-expected.txt.
        * fast/events/fire-scroll-event-element.html: Added. Does the same
            tests as fire-scroll-event.html, but on an individual element instead
            of the whole document.
        * fast/events/fire-scroll-event-expected.txt:
        * fast/events/fire-scroll-event.html: Now explicitly tests for
            synchronous behavior when scrolling the document, and that we don't
            fire the event more than once.
        * fast/events/remove-child-onscroll.html:
        * fast/events/scroll-during-zoom-change.html:
        * fast/events/scroll-event-does-not-bubble.html:
        * fast/events/scroll-event-phase-expected.txt: Added.
        * fast/events/scroll-event-phase.html: Added. Checks that we can listen
            for scroll events in both the capture and bubble phase.
        * fast/layers/removed-by-scroll-handler.html:
        * fast/overflow/onscroll-layer-self-destruct.html:
        * fast/repaint/repaint-during-scroll.html:
2011-01-11  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Darin Fisher.

        Scroll event should be fired asynchronously
        https://bugs.webkit.org/show_bug.cgi?id=45631

        Tests: fast/events/fire-scroll-event.html
               fast/events/fire-scroll-event-element.html
               fast/events/scroll-event-phase.html

        Makes scroll events fire asynchronously to be in compliance with the
        CSSOM View Module and consistent with Gecko, Opera and (to some degree)
        IE.

        Implemented via the EventQueue class added by r74062 (EventQueue now
        has a convenience enqueueScrollEvent method).

        * dom/EventQueue.cpp:
        (WebCore::EventQueue::enqueueScrollEvent):
        (WebCore::EventQueue::pendingEventTimerFired):
        * dom/EventQueue.h:
        * page/EventHandler.cpp:
        (WebCore::EventHandler::sendScrollEvent):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::scrollToOffset):
        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::valueChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-11 Kenneth Russell <kbr@google.com>
kbr@google.com [Tue, 11 Jan 2011 22:16:25 +0000 (22:16 +0000)]
2011-01-11  Kenneth Russell  <kbr@google.com>

        Reviewed by James Robinson.

        [chromium] Move WebGraphicsContext3DDefaultImpl to Chromium repository
        https://bugs.webkit.org/show_bug.cgi?id=52235

        Deleted WebGraphicsContext3DDefaultImpl, which has been moved to
        the Chromium repository under WebGraphicsContext3DInProcessImpl.
        Removed WebGraphicsContext3D::createDefault(). Rolled forward
        Chromium version to pick up needed changes.

        Tested with build-webkit --chromium --debug and a run of the WebGL
        layout tests in DRT.

        * DEPS:
        * WebKit.gyp:
        * public/WebGraphicsContext3D.h:
        * src/GraphicsContext3DChromium.cpp:
        * src/WebGraphicsContext3D.cpp: Removed.
        * src/WebGraphicsContext3DDefaultImpl.cpp: Removed.
        * src/WebGraphicsContext3DDefaultImpl.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-11 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Tue, 11 Jan 2011 22:03:50 +0000 (22:03 +0000)]
2011-01-11  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed; new and updated mac-leopard baselines.

        Update stale or missing Leopard baselines (tests currently pass on Snow
        Leopard).

        * platform/chromium/test_expectations.txt:
        * platform/mac-leopard/editing/deleting/delete-line-end-ws-001-expected.checksum:
        * platform/mac-leopard/editing/deleting/delete-line-end-ws-001-expected.png:
        * platform/mac-leopard/editing/deleting/delete-line-end-ws-002-expected.checksum:
        * platform/mac-leopard/editing/deleting/delete-line-end-ws-002-expected.png:
        * platform/mac-leopard/fast/block/basic/016-expected.checksum: Added.
        * platform/mac-leopard/fast/block/basic/016-expected.png: Added.
        * platform/mac-leopard/fast/block/basic/truncation-rtl-expected.checksum: Added.
        * platform/mac-leopard/fast/block/basic/truncation-rtl-expected.png: Added.
        * platform/mac-leopard/fast/blockflow/fieldsets-expected.checksum: Added.
        * platform/mac-leopard/fast/blockflow/fieldsets-expected.png: Added.
        * platform/mac-leopard/fast/borders/border-image-scale-transform-expected.checksum:
        * platform/mac-leopard/fast/borders/border-image-scale-transform-expected.png:
        * platform/mac-leopard/tables/mozilla_expected_failures/bugs/bug2479-5-expected.checksum:
        * platform/mac-leopard/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix spelling mistake. Sharable -> Shareable.
weinig@apple.com [Tue, 11 Jan 2011 22:03:13 +0000 (22:03 +0000)]
Fix spelling mistake. Sharable -> Shareable.

Reviewed by Anders Carlsson.

* Shared/API/c/WKImage.h:
* Shared/API/c/WKSharedAPICast.h:
(WebKit::toImageOptions):
* Shared/ImageOptions.h:
* Shared/WebImage.cpp:
(WebKit::WebImage::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-11 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 11 Jan 2011 21:53:29 +0000 (21:53 +0000)]
2011-01-11  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Add SetSize message
        https://bugs.webkit.org/show_bug.cgi?id=52247

        * DerivedSources.make:
        Add DrawingArea.messages.in

        * Platform/CoreIPC/MessageID.h:
        Add DrawingArea message class.

        * UIProcess/DrawingAreaProxyImpl.cpp:
        (WebKit::DrawingAreaProxyImpl::sizeDidChange):
        Call sendSetSize.

        (WebKit::DrawingAreaProxyImpl::sendSetSize):
        Send a SetSize message.

        * UIProcess/DrawingAreaProxyImpl.h:
        Add setSize override.

        * WebKit2.xcodeproj/project.pbxproj:
        Add new files.

        * WebProcess/WebPage/DrawingArea.h:
        (WebKit::DrawingArea::setSize):
        Add setSize member function.

        * WebProcess/WebPage/DrawingArea.messages.in: Added.

        * WebProcess/WebPage/DrawingAreaImpl.cpp:
        * WebProcess/WebPage/DrawingAreaImpl.h:
        Add setSize.

        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::didReceiveMessage):
        Handle drawing area messages.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-11 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Tue, 11 Jan 2011 21:33:48 +0000 (21:33 +0000)]
2011-01-11  Patrick Gansterer  <paroga@webkit.org>

        Unreviewed WinCE build fix for r75523.

        * platform/wince/DragDataWinCE.cpp: Added missing include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-11 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Tue, 11 Jan 2011 21:28:13 +0000 (21:28 +0000)]
2011-01-11  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Dimitri Glazkov.

        RefPtr the FrameView to prevent scrollbar from getting deleted inside
        its scroll event.
        https://bugs.webkit.org/show_bug.cgi?id=52238

        Test: scrollbars/scrollable-iframe-remove-crash.html

        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::scrollTo):
2011-01-11  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Dimitri Glazkov.

        Tests that we do not crash when we remove scrollable iframe when executing
        inside its scroll event.
        https://bugs.webkit.org/show_bug.cgi?id=52238

        * scrollbars/scrollable-iframe-remove-crash-expected.txt: Added.
        * scrollbars/scrollable-iframe-remove-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoReplace ASSERTs with FIXMEs.
andersca@apple.com [Tue, 11 Jan 2011 21:24:06 +0000 (21:24 +0000)]
Replace ASSERTs with FIXMEs.

Reviewed by Sam Weinig.

* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::sizeDidChange):
(WebKit::DrawingAreaProxyImpl::setPageIsVisible):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-11 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 11 Jan 2011 21:20:35 +0000 (21:20 +0000)]
2011-01-11  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Add DrawingAreaImpl skeleton class
        https://bugs.webkit.org/show_bug.cgi?id=52246

        * UIProcess/API/mac/WKView.mm:
        (useNewDrawingArea):
        New function which controls which drawing area to use, through an environment variable.

        (-[WKView drawRect:]):
        Bail if we're using the new drawing area (for now).

        (-[WKView WebKit::]):
        Create a DrawingAreaProxyImpl when asked to.

        * WebKit2.xcodeproj/project.pbxproj:
        Add new files.

        * WebProcess/WebPage/DrawingArea.cpp:
        (WebKit::DrawingArea::create):
        Create a DrawingAreaImpl when asked to.

        * WebProcess/WebPage/DrawingAreaImpl.cpp: Added.
        * WebProcess/WebPage/DrawingAreaImpl.h: Added.
        Add DrawingAreaImpl class.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-11 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Tue, 11 Jan 2011 21:17:41 +0000 (21:17 +0000)]
2011-01-11  Martin Robinson  <mrobinson@igalia.com>

        Remove some GTK+-specific baselines. GTK+ now enough feature parity with the Mac
        port to make these platform-specific results unnecessary.

        * platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt: Removed.
        * platform/gtk/fast/dom/prototype-inheritance-expected.txt: Removed.
        * platform/gtk/fast/js/global-constructors-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-11 Nico Weber <thakis@chromium.org>
thakis@chromium.org [Tue, 11 Jan 2011 21:08:23 +0000 (21:08 +0000)]
2011-01-11  Nico Weber  <thakis@chromium.org>

        Unreviewed, test expectations.

        Another new baselines due to updated skia
        https://bugs.webkit.org/show_bug.cgi?id=52105

        * platform/chromium-linux/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.checksum:
        * platform/chromium-linux/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75544 268f45cc-cd09-0410-ab3c-d52691b4dbfc