WebKit-https.git
11 years ago2010-12-23 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 23 Dec 2010 18:16:02 +0000 (18:16 +0000)]
2010-12-23  Anders Carlsson  <andersca@apple.com>

        Reviewed by John Sullivan.

        Nothing happens clicking "launch live player" on live.cnn.com
        https://bugs.webkit.org/show_bug.cgi?id=51540
        <rdar://problem/8791086>

        Implement NPN_PushPopupsEnabledState/NPN_PopPopupsEnabledState.

        * WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
        (WebKit::NPN_PushPopupsEnabledState):
        Call NetscapePlugin::pushPopupsEnabledState.

        (WebKit::NPN_PopPopupsEnabledState):
        Call NetscapePlugin::popPopupsEnabledState.

        * WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
        (WebKit::NetscapePlugin::pushPopupsEnabledState):
        Append the boolean to the vector.

        (WebKit::NetscapePlugin::popPopupsEnabledState):
        Remove the last boolean from the vector.

        (WebKit::NetscapePlugin::allowPopups):
        Return the last boolean from the vector.

        * WebProcess/Plugins/Netscape/NetscapePlugin.h:
        * WebProcess/Plugins/PluginView.cpp:
        (WebKit::PluginView::performJavaScriptURLRequest):
        Update the "allowPopupsFromPlugin" state.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-23 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 23 Dec 2010 17:45:08 +0000 (17:45 +0000)]
2010-12-23  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        Move V8 to WebCore's implementation of showModalDialog
        https://bugs.webkit.org/show_bug.cgi?id=51527

        This code is basically verbatim translation from the JavaScriptCore
        bindings.  The only intentional difference is in the world selection
        for the dialog's frame.  I suspect JavaScriptCore's bindings have a
        subtle bug there.

        In this patch, I also remove a bunch of now-unneeded code in the
        generic bindings.

        * bindings/generic/BindingDOMWindow.h:
        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::DialogHandler::dialogCreated):
        (WebCore::setUpDialog):
        * bindings/v8/custom/V8DOMWindowCustom.cpp:
        (WebCore::DialogHandler::DialogHandler):
        (WebCore::DialogHandler::dialogCreated):
        (WebCore::DialogHandler::returnValue):
        (WebCore::setUpDialog):
        (WebCore::V8DOMWindow::showModalDialogCallback):
        (WebCore::V8DOMWindow::openCallback):
        * bindings/v8/specialization/V8BindingDOMWindow.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-23 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Thu, 23 Dec 2010 17:26:16 +0000 (17:26 +0000)]
2010-12-23  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Joseph Pecoraro.

        Web Inspector: Can't backspace from CSS value to CSS key field
        https://bugs.webkit.org/show_bug.cgi?id=51476

        * inspector/front-end/StylesSidebarPane.js:
        (WebInspector.StylePropertyTreeElement.prototype.):
        (WebInspector.StylePropertyTreeElement.prototype):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-23 W. James MacLean <wjmaclean@chromium.org>
commit-queue@webkit.org [Thu, 23 Dec 2010 16:56:36 +0000 (16:56 +0000)]
2010-12-23  W. James MacLean  <wjmaclean@chromium.org>

        Reviewed by Kenneth Russell.

        [chromium] Add asserts to test for contiguous-pixel Skia bitmaps.
        https://bugs.webkit.org/show_bug.cgi?id=51186

        No new tests. Behaviour not changed, but need the asserts to detect when assumptions violated.

        * platform/graphics/chromium/ImageLayerChromium.cpp:
        (WebCore::ImageLayerChromium::updateContentsIfDirty):
        * platform/graphics/skia/GraphicsContext3DSkia.cpp:
        (WebCore::GraphicsContext3D::getImageData):
2010-12-23  W. James MacLean  <wjmaclean@chromium.org>

        Reviewed by Kenneth Russell.

        [chromium] Add asserts to test for contiguous-pixel Skia bitmaps.
        https://bugs.webkit.org/show_bug.cgi?id=51186

        Add asserts to detect if assumptions (about contiguous pixels in Skia bitmaps) are violated.

        * src/GraphicsContext3DChromium.cpp:
        (WebCore::GraphicsContext3DInternal::paintRenderingResultsToCanvas):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd Windows-XP-specific (failing) expected results for
jberlin@webkit.org [Thu, 23 Dec 2010 16:53:35 +0000 (16:53 +0000)]
Add Windows-XP-specific (failing) expected results for
fast/profiler/throw-exception-from-eval-expected.html in order to get the Windows XP Debug
test bot green again. Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=49801

* platform/win-xp/fast/profiler: Added.
* platform/win-xp/fast/profiler/throw-exception-from-eval-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-23 Lucas De Marchi <lucas.demarchi@profusion.mobi>
commit-queue@webkit.org [Thu, 23 Dec 2010 16:39:57 +0000 (16:39 +0000)]
2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>

        Reviewed by Kenneth Rohde Christiansen.

        [EFL] Make 'single' the default backing store in EWebLauncher
        https://bugs.webkit.org/show_bug.cgi?id=51534

        'single' is the simplest backing store and the one intended to be the
        default in the test browser. By mistake the tiled backing store was
        left as default in r72617.

        * EWebLauncher/main.c:
        (browserCreate): ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-23 Dawit Alemayehu <adawit@kde.org>
commit-queue@webkit.org [Thu, 23 Dec 2010 16:23:24 +0000 (16:23 +0000)]
2010-12-23  Dawit Alemayehu  <adawit@kde.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Add a 'hasSelection' function to QWebView and QWebPage.
        https://bugs.webkit.org/show_bug.cgi?id=48722

        This is a convenience API that optimizes the case where checking for
        the presence of selected content and accessing the selected content
        are two separate actions in the client. See comment #12 in the above
        bug report link for details.

        * Api/qwebpage.cpp:
        (QWebPage::hasSelection):
        * Api/qwebpage.h:
        * Api/qwebview.cpp:
        (QWebView::hasSelection):
        * Api/qwebview.h:
        * tests/qwebpage/tst_qwebpage.cpp:
        (tst_QWebPage::textSelection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-23 Jeremy Moskovich <jeremy@chromium.org>
jeremy@chromium.org [Thu, 23 Dec 2010 14:45:45 +0000 (14:45 +0000)]
2010-12-23  Jeremy Moskovich  <jeremy@chromium.org>

        Unreviewed new Chromium baselines and test expectations update.

        * platform/chromium-linux/fast/layers/video-layer-expected.checksum:
        * platform/chromium-linux/fast/layers/video-layer-expected.png:
        * platform/chromium-mac/fast/layers/video-layer-expected.checksum:
        * platform/chromium-mac/fast/layers/video-layer-expected.png:
        * platform/chromium-mac/fast/layers/video-layer-expected.txt:
        * platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
        * platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
        * platform/chromium-win/fast/layers/video-layer-expected.checksum:
        * platform/chromium-win/fast/layers/video-layer-expected.png:
        * platform/chromium-win/fast/layers/video-layer-expected.txt:
        * platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-23 Lucas De Marchi <lucas.demarchi@profusion.mobi>
commit-queue@webkit.org [Thu, 23 Dec 2010 14:41:31 +0000 (14:41 +0000)]
2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>

        Reviewed by Kenneth Rohde Christiansen.

        [EFL] Fix ContextMenu removal
        https://bugs.webkit.org/show_bug.cgi?id=51530

        Fix ContextMenu removal

        In r74207 the support for ContextMenu was removed from EFL while the
        code is being ported to the new CROSS_PLATFORM_MENUS due to build
        breakage.  However there were some missing removals in the shutdown
        logic that introduced a bug, leading to a segmentation fault when
        ContexController was destroyed.

        The best way to effectively disable the ContextMenu is to conditionally
        compile the meaningful stuff by surrounding with "#if
        ENABLE(CONTEXT_MENUS)" and then disabling it in CMake.

        * cmake/OptionsEfl.cmake: Disable ContextMenu and don't pretend we
        implement CROSS_PLATFORM_MENUS yet.
2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>

        Reviewed by Kenneth Rohde Christiansen.

        [EFL] Fix ContextMenu removal
        https://bugs.webkit.org/show_bug.cgi?id=51530

        Fix ContextMenu removal

        In r74207 the support for ContextMenu was removed from EFL while the
        code is being ported to the new CROSS_PLATFORM_MENUS due to build
        breakage.  However there were some missing removals in the shutdown
        logic that introduced a bug, leading to a segmentation fault when
        ContexController was destroyed.

        The best way to effectively disable the ContextMenu is to conditionally
        compile the meaningful stuff by surrounding with "#if
        ENABLE(CONTEXT_MENUS)" and then disabling it in CMake.

        * ewk/ewk_contextmenu.cpp: surround need parts with #if
        ENABLE(CONTEXT_MENUS).
        (ewk_context_menu_destroy): ditto.
        (ewk_context_menu_item_select): ditto.
        * ewk/ewk_private.h: ditto.
        * ewk/ewk_view.cpp: ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-23 Lucas De Marchi <lucas.demarchi@profusion.mobi>
commit-queue@webkit.org [Thu, 23 Dec 2010 14:24:50 +0000 (14:24 +0000)]
2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>

        Reviewed by Kenneth Rohde Christiansen.

        Fix check by undefined macro
        https://bugs.webkit.org/show_bug.cgi?id=51531

        Fix check by undefined macro

        When building EFL port with libsoup, BUILDING_GTK__ is not defined,
        leading to warnings during compile. We actually have to use an #ifdef
        instead of an #if.

        No change in functionality so no new tests.

        * platform/network/soup/cache/webkit/soup-cache.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-23 Lucas De Marchi <lucas.demarchi@profusion.mobi>
commit-queue@webkit.org [Thu, 23 Dec 2010 14:08:31 +0000 (14:08 +0000)]
2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>

        Reviewed by Kenneth Rohde Christiansen.

        [EFL] Clean warnings in Tiled Backing Store
        https://bugs.webkit.org/show_bug.cgi?id=51529

        Tiled backing store in EFL was giving the following warnings that are
        gone now:

        - Static function defined but not used;
        - Comparison between signed and unsigned integer expressions;

        * ewk/ewk_tiled_backing_store.c:
        (_ewk_tiled_backing_store_item_fill):
        (_ewk_tiled_backing_store_smart_calculate):
        * ewk/ewk_tiled_matrix.c:
        (_ewk_tile_matrix_slicer_setup):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-23 Jonathan Dixon <joth@chromium.org>
commit-queue@webkit.org [Thu, 23 Dec 2010 13:49:46 +0000 (13:49 +0000)]
2010-12-23  Jonathan Dixon  <joth@chromium.org>

        Reviewed by Steve Block.

        TouchEvents does not support multi-touch on a page with multiple touch targets
        https://bugs.webkit.org/show_bug.cgi?id=51258

        * fast/events/touch/multi-touch-grouped-targets-expected.txt: Added.
        * fast/events/touch/multi-touch-grouped-targets.html: Added.
        * fast/events/touch/script-tests/multi-touch-grouped-targets.js: Added.
        (declareTouchHandler.return.shouldBe):
        (declareTouchHandler):
        (touchEndHandler):
        Added new test that ensures both test targets receive events when hit by multiple
        touch points from the same platform event.

        * fast/events/touch/script-tests/touch-target-limited.js:
        (declareTouchStart.return.touchStartHandler):
        (declareTouchStart):
        (declareTouchMove.return.touchMoveHandler):
        (declareTouchMove):
        * fast/events/touch/script-tests/touch-target.js:
        (declareTouchStart.return.touchStartHandler):
        (declareTouchStart):
        (declareTouchMove.return.touchMoveHandler):
        (declareTouchMove):
        * fast/events/touch/touch-target-expected.txt:
        * fast/events/touch/touch-target-limited-expected.txt:
        Updated & rebaselined existing tests to reflect new expectations.
2010-12-23  Jonathan Dixon  <joth@chromium.org>

        Reviewed by Steve Block.

        TouchEvents does not support multi-touch on a page with multiple touch targets
        https://bugs.webkit.org/show_bug.cgi?id=51258

        Test: fast/events/touch/multi-touch-grouped-targets.html

        * page/EventHandler.cpp:
        (WebCore::eventNameForTouchPointState):
        (WebCore::EventHandler::handleTouchEvent):
        Redesigned event handler to ensure all event targets involved in a given
        multitouch event get the appropriate event(s) fired.

        * platform/PlatformTouchPoint.h: Added end-stop marker for State enum.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-23 Lucas De Marchi <lucas.demarchi@profusion.mobi>
commit-queue@webkit.org [Thu, 23 Dec 2010 13:23:04 +0000 (13:23 +0000)]
2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>

        Reviewed by Kenneth Rohde Christiansen.

        [EFL] Subject: [webkit 4/4] [EFL] Remove non-sense workaround
        https://bugs.webkit.org/show_bug.cgi?id=51533

        There's no point in concatenating env("HOME") with "blah", so remove
        option from EWebLauncher.

        * EWebLauncher/main.c:
        (main): ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-23 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 23 Dec 2010 13:14:48 +0000 (13:14 +0000)]
2010-12-23  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] media/audio-data-url.html fails since r75504
        https://bugs.webkit.org/show_bug.cgi?id=51525

        Make the GStreamer media-player advertize 3gpp mime-types as
        supported if the 3gp caps are in the typefind factories.

        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::mimeTypeCache):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-23 Jeremy Moskovich <jeremy@chromium.org>
jeremy@chromium.org [Thu, 23 Dec 2010 13:09:42 +0000 (13:09 +0000)]
2010-12-23  Jeremy Moskovich  <jeremy@chromium.org>

        Unreviewed test expectations update.

        Fix duplicate expectation warning for media/video-controls-rendering.html introduced in r74535.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRefactor HTMLInputElement: Move a part of HTMLInputElement::defaultEventHandler()
tkent@chromium.org [Thu, 23 Dec 2010 12:56:55 +0000 (12:56 +0000)]
Refactor HTMLInputElement: Move a part of HTMLInputElement::defaultEventHandler()
to InputTypes.
https://bugs.webkit.org/show_bug.cgi?id=51093

Reviewed by Dimitri Glazkov.

Move BeforeTextInserted and Wheel event handling, event forwarding to
renderers, and the isindex form submission quirk code to InputTypes.
Also, change the return types of InputType event handlers from 'bool'
to 'void'. We use Event::defaultHandled() to decide whether event
handling should be stopped.

No new tests because this is just a refactoring.

* html/BaseButtonInputType.cpp: bool->void changes
(WebCore::BaseButtonInputType::handleKeydownEvent):
(WebCore::BaseButtonInputType::handleKeypressEvent):
(WebCore::BaseButtonInputType::handleKeyupEvent):
* html/BaseButtonInputType.h: ditto.
* html/BaseCheckableInputType.cpp: ditto.
(WebCore::BaseCheckableInputType::handleKeydownEvent):
(WebCore::BaseCheckableInputType::handleKeypressEvent):
* html/BaseCheckableInputType.h: ditto.
* html/BaseDateAndTimeInputType.cpp:
(WebCore::BaseDateAndTimeInputType::handleKeydownEvent): ditto.
(WebCore::BaseDateAndTimeInputType::handleWheelEvent): Just calls handleWheelEventForSpinButton().
* html/BaseDateAndTimeInputType.h: bool->void change and handleWhellEvent() addition.
* html/CheckboxInputType.cpp: bool->void change
(WebCore::CheckboxInputType::handleKeyupEvent):
* html/CheckboxInputType.h: ditto.
* html/FileInputType.cpp: ditto.
(WebCore::FileInputType::handleDOMActivateEvent):
* html/FileInputType.h: ditto.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::defaultEventHandler):
 - Change return-value handling of InputType event handlers
 - Move out beforeTextInserted/wheel event handling and isindex form quirk.
* html/HTMLInputElement.h:
(WebCore::HTMLInputElement::handleBeforeTextInsertedEvent):
 Added so that InputType can call InputElement::handleBeforeTextInsertedEvent().
* html/ImageInputType.cpp: bool->void change
(WebCore::ImageInputType::handleDOMActivateEvent):
* html/ImageInputType.h: ditto.
* html/InputType.cpp: ditto.
(WebCore::InputType::handleClickEvent):
(WebCore::InputType::handleDOMActivateEvent):
(WebCore::InputType::handleKeydownEvent):
(WebCore::InputType::handleKeypressEvent):
(WebCore::InputType::handleKeyupEvent):
(WebCore::InputType::handleBeforeTextInsertedEvent):
(WebCore::InputType::handleWheelEvent): Added default implementation.
(WebCore::InputType::forwardEvent): ditto.
(WebCore::InputType::formForSubmission): ditto.
* html/InputType.h:
* html/IsIndexInputType.cpp:
(WebCore::IsIndexInputType::formForSubmission): Moved from HTMLInputElement.cpp.
* html/IsIndexInputType.h:
* html/NumberInputType.cpp:
(WebCore::isNumberCharacter): Moved from HTMLInputElement.cpp.
(WebCore::NumberInputType::handleKeydownEvent): bool->void change.
(WebCore::NumberInputType::handleBeforeTextInsertedEvent): Moved from HTMInputElement.cpp.
(WebCore::NumberInputType::handleWheelEvent): Added. Just calls handleWheelEventForSpinButton().
* html/NumberInputType.h:
* html/RadioInputType.cpp: bool->void changes.
(WebCore::RadioInputType::handleClickEvent):
(WebCore::RadioInputType::handleKeydownEvent):
(WebCore::RadioInputType::handleKeyupEvent):
* html/RadioInputType.h:
* html/RangeInputType.cpp:
(WebCore::RangeInputType::handleKeydownEvent): ditto.
(WebCore::RangeInputType::forwardEvent): Moved from HTMLInputElement.cpp.
* html/RangeInputType.h:
* html/ResetInputType.cpp: bool->void change.
(WebCore::ResetInputType::handleDOMActivateEvent):
* html/ResetInputType.h: ditto.
* html/SubmitInputType.cpp: ditto.
(WebCore::SubmitInputType::handleDOMActivateEvent):
* html/SubmitInputType.h: ditto.
* html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::handleKeydownEvent): bool->void change.
(WebCore::TextFieldInputType::handleKeydownEventForSpinButton): ditto.
(WebCore::TextFieldInputType::handleWheelEventForSpinButton): Moved from HTMLInputElement.cpp.
(WebCore::TextFieldInputType::forwardEvent): ditto.
* html/TextFieldInputType.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-23 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Thu, 23 Dec 2010 11:12:09 +0000 (11:12 +0000)]
2010-12-23  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Joseph Pecoraro.

        Web Inspector: After scrolling new property value and cancelling, removed property remains active in page style
        https://bugs.webkit.org/show_bug.cgi?id=51390

        * inspector/front-end/StylesSidebarPane.js:
        (WebInspector.StylePropertyTreeElement.prototype):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed. Update Qt specific expected file after r74539.
ossy@webkit.org [Thu, 23 Dec 2010 10:38:19 +0000 (10:38 +0000)]
Unreviewed. Update Qt specific expected file after r74539.

* platform/qt/fast/dom/Window/window-properties-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-23 Benjamin Kalman <kalman@chromium.org>
commit-queue@webkit.org [Thu, 23 Dec 2010 10:20:53 +0000 (10:20 +0000)]
2010-12-23  Benjamin Kalman  <kalman@chromium.org>

        Reviewed by Eric Seidel.

        QT linux has RTL line movement bug that causes editing/selection/extend-to-line-boundary.html to fail
        https://bugs.webkit.org/show_bug.cgi?id=51514

        Add different baseline to editing/selection/extend-to-line-boundary.html for qt-linux that
        takes into account the RTL bug.

        * platform/qt-linux/editing/selection/extend-to-line-boundary-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoNot reviewed.
antti@apple.com [Thu, 23 Dec 2010 09:54:13 +0000 (09:54 +0000)]
Not reviewed.

Another attempt.

* http/tests/local/slow-css-pass.cgi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-23 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Thu, 23 Dec 2010 09:20:42 +0000 (09:20 +0000)]
2010-12-23  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Eric Seidel.

        Web Inspector: chromium: inspector's tests are quite slow especially at windows(Debug).

        Almost all inspector's tests become flaky on chromium Win(dbg) after switching to DRT.
        I just discovered that we have two additional GC runs per each WebViewHost.
        Test_shell had no such calls.
        These gc runs eat 15% of cpu time.

        https://bugs.webkit.org/show_bug.cgi?id=51479

        * DumpRenderTree/chromium/WebViewHost.cpp:
        (WebViewHost::~WebViewHost):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoNot reviewed.
antti@apple.com [Thu, 23 Dec 2010 09:18:03 +0000 (09:18 +0000)]
Not reviewed.

Flaky Test: http/tests/local/stylesheet-and-script-load-order-media-print.html

Try to fix flakiness.

* http/tests/local/slow-css-pass.cgi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-23 Gyuyoung Kim <gyuyoung.kim@samsung.com>
gyuyoung.kim@samsung.com [Thu, 23 Dec 2010 08:17:10 +0000 (08:17 +0000)]
2010-12-23  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Unreviewed build warning fix.

        [EFL] Remove warning messages during the webkit efl compiling
        https://bugs.webkit.org/show_bug.cgi?id=51520

        Remove build warning messages.

        * ewk/ewk_view.cpp:
        (_ewk_view_smart_show):
        (_ewk_view_smart_hide):
        * ewk/ewk_view.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-23 Noel Gordon <noel.gordon@gmail.com>
commit-queue@webkit.org [Thu, 23 Dec 2010 08:00:26 +0000 (08:00 +0000)]
2010-12-23  Noel Gordon  <noel.gordon@gmail.com>

        Reviewed by Adam Barth.

        [chromium] Reduce canvas.toDataURL("image/png") run-time costs 300%
        https://bugs.webkit.org/show_bug.cgi?id=51455

        Chromium uses the libpng compression defaults.  Good compression results,
        but at much larger run-time cost compared to other browsers.  Chrome is 2
        times slower than Mozilla 3.6.12 and 3-4 times slower than Safari 5.0.3.

        libpng has supported alternative compression methods for some time, they
        better meet the dual goals of good compression and run-time cost for the
        on-line case, and are well-documented.  Here use Huffman encoding.  It's
        2-20% faster than other encodings (Z_RLE, Z_FILTERED) and the compressed
        size is within 1% of the Safari 5.0.3 result independent of image size.

        No change in behaviour, so no new tests.

        * platform/image-encoders/skia/PNGImageEncoder.cpp:
        (WebCore::PNGImageEncoder::encode): Apply Huffman image encoding.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Noel Gordon <noel.gordon@gmail.com>
commit-queue@webkit.org [Thu, 23 Dec 2010 07:43:45 +0000 (07:43 +0000)]
2010-12-22  Noel Gordon  <noel.gordon@gmail.com>

        Reviewed by Darin Fisher.

        [chromium] Optimize canvas.toDataURL("image/png") unpremultiplication loop
        https://bugs.webkit.org/show_bug.cgi?id=51321

        Follow on from r73890, unroll the SkUnPreMultiply::PMColorToColor() call for
        the "image/png" encoder case viz., compute the unpremultiplication in-place.
        See https://bugs.webkit.org/show_bug.cgi?id=50804 for reference.

        No new tests: canvas.toDataURL() is covered by existing tests.

        * platform/image-encoders/skia/PNGImageEncoder.cpp:
        (WebCore::preMultipliedBGRAtoRGBA):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Ariya Hidayat <ariya@sencha.com>
ariya@webkit.org [Thu, 23 Dec 2010 06:55:52 +0000 (06:55 +0000)]
2010-12-22  Ariya Hidayat  <ariya@sencha.com>

        Reviewed by Simon Fraser.

        Implement skewX() and skewY() for CSSMatrix.
        https://bugs.webkit.org/show_bug.cgi?id=38335

        * fast/dom/Window/window-properties-expected.txt: Adjusted.
        * transforms/cssmatrix-2d-interface.xhtml: Added tests for skewX() and skewY().
        * transforms/cssmatrix-2d-interface-expected.txt: Adjusted.
2010-12-22  Ariya Hidayat  <ariya@sencha.com>

        Reviewed by Simon Fraser.

        Implement skewX() and skewY() for CSSMatrix.
        https://bugs.webkit.org/show_bug.cgi?id=38335

        * css/WebKitCSSMatrix.cpp:
        (WebCore::WebKitCSSMatrix::skew): Implemented skewX() and skewY().
        * css/WebKitCSSMatrix.h: Added skewX() and skewY().
        * css/WebKitCSSMatrix.idl: Added skewX() and skewY().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 23 Dec 2010 05:45:56 +0000 (05:45 +0000)]
2010-12-22  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Support unprefixed box-shadow property
        https://bugs.webkit.org/show_bug.cgi?id=51448

        Add support for the box-shadow CSS property. We'll currently render this
        similarly to -webkit-box-shadow, but a later fix will adjust the blur radius
        handling to match the spec.

        Test: fast/css/box-shadow.html

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Implement getComputedStyle
        for box-shadow

        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue):
        (WebCore::ShadowParseContext::ShadowParseContext):
        (WebCore::ShadowParseContext::commitValue):
        (WebCore::ShadowParseContext::commitLength):
        (WebCore::ShadowParseContext::commitColor): Support CSSPropertyBoxShadow

        * css/CSSPropertyNames.in: add box-shadow

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applyProperty): Add CSSPropertyBoxShadow, and
        store in the ShadowData if this is -webkit-box-shadow or not. We'll use this
        to adjust radii later.

        * css/SVGCSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applySVGProperty): Add CSSPropertyBoxShadow.

        * page/animation/AnimationBase.cpp:
        (WebCore::blendFunc):
        (WebCore::PropertyWrapperShadow::blend):
        (WebCore::AnimationBase::ensurePropertyMap): Support animations of box-shadow.

        * rendering/style/ShadowData.cpp: Store a flag to say if this is a -webkit-box-shadow.
        (WebCore::ShadowData::ShadowData):
        (WebCore::ShadowData::operator==):
        * rendering/style/ShadowData.h:
        (WebCore::ShadowData::ShadowData):
        (WebCore::ShadowData::isWebkitBoxShadow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Michael Saboff <msaboff@apple.com>
msaboff@apple.com [Thu, 23 Dec 2010 05:39:21 +0000 (05:39 +0000)]
2010-12-22  Michael Saboff  <msaboff@apple.com>

        Reviewed by Sam Weinig.

        REGRESSION: Can't shadow/overwrite window.constructor
        (causes TypeError exception)
        https://bugs.webkit.org/show_bug.cgi?id=48953

        Added code in the javascript code generator to create a setter for
        a constructor if the new extended attribute ReplaceableConstructor
        is present for the interface.

        * bindings/scripts/CodeGeneratorJS.pm:
        * page/DOMWindow.idl:
2010-12-22  Michael Saboff  <msaboff@apple.com>

        Reviewed by Sam Weinig.

        REGRESSION: Can't shadow/overwrite window.constructor
        (causes TypeError exception)
        https://bugs.webkit.org/show_bug.cgi?id=48953

        Changed cross-frame-access-put test results to reflect that setting
        the window constructor will be disallowed due to cross frame security
        checking.
        Added a new test to check that we can change window.constructor.

        * fast/dom/Window/window-constructor-settable-expected.txt: Added.
        * fast/dom/Window/window-constructor-settable.html: Added.
        * http/tests/security/cross-frame-access-put-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Thu, 23 Dec 2010 05:27:15 +0000 (05:27 +0000)]
2010-12-22  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed test expectations update. fast/canvas/fillText-shadow.html
        fails with Skia in the GPU suite too.

        * platform/chromium-gpu/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Steve Lacey <sjl@chromium.org>
commit-queue@webkit.org [Thu, 23 Dec 2010 05:25:36 +0000 (05:25 +0000)]
2010-12-22  Steve Lacey  <sjl@chromium.org>

        Reviewed by David Levin.

        Change css for chromium media controls to deal with the timeline
        not expanding when the current time disappears. This happens when
        the width of the control drops below 240px.

        This change results in a minor pixel difference - the timebar now
        aligns better with the time and when the time is not displayed is
        now perfectly centered. Disabling the affected tests for now
        and will rebaseline.

        https://bugs.webkit.org/show_bug.cgi?id=51500

        * platform/chromium/test_expectations.txt:
2010-12-22  Steve Lacey  <sjl@chromium.org>

        Reviewed by David Levin.

        Change css for chromium media controls to deal with the timeline
        not expanding when the current time disappears. This happens when
        the width of the control drops below 240px.

        This change results in a minor pixel difference - the timebar now
        aligns better with the time and when the time is not displayed is
        now perfectly centered. Disabling the affected tests for now
        and will rebaseline.

        https://bugs.webkit.org/show_bug.cgi?id=51500

        * css/mediaControlsChromium.css:
        (audio::-webkit-media-controls-timeline-container, video::-webkit-media-controls-timeline-container):
        (audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display):
        (audio::-webkit-media-controls-time-remaining-display, video::-webkit-media-controls-time-remaining-display):
        (audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Thu, 23 Dec 2010 05:05:20 +0000 (05:05 +0000)]
2010-12-22  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed test expectations update. fast/canvas/fillText-shadow.html
        fails with Skia.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd Windows-specific (failing) expected results for media/audio-data-url.html in...
jberlin@webkit.org [Thu, 23 Dec 2010 04:01:05 +0000 (04:01 +0000)]
Add Windows-specific (failing) expected results for media/audio-data-url.html in order to get
the Windows 7 Release test bot green again. Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=51518

* platform/win/media/audio-data-url-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Thu, 23 Dec 2010 03:25:35 +0000 (03:25 +0000)]
2010-12-22  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Simon Fraser.

        the shadow direction is negated in canvas context shadowOffsetY.
        https://bugs.webkit.org/show_bug.cgi?id=25619

        Add test to verify that shadowOffsetY is handled correctly.

        * fast/canvas/fillText-shadow-expected.txt: Added.
        * fast/canvas/fillText-shadow.html: Added.
2010-12-22  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Simon Fraser.

        the shadow direction is negated in canvas context shadowOffsetY.
        https://bugs.webkit.org/show_bug.cgi?id=25619

        Invert shadow offset Y direction in 0-blur path in FontMac::drawGlyps
        if we're not transforming shadows (i.e. are rendering in a canvas). Also
        use CG shadows if there's a non-translate/flip transform applied
        (shadow offsets are supposed to ignore transforms, but the naive/simple
        implementation was taking them into account).

        Also does the equivalent changes to FontCGWin.

        Test: fast/canvas/fillText-shadow.html

        * platform/graphics/GraphicsContext.cpp:
        (WebCore::GraphicsContext::shadowsIgnoreTransforms):
        * platform/graphics/GraphicsContext.h:
        * platform/graphics/mac/FontMac.mm:
        (WebCore::Font::drawGlyphs):
        * platform/graphics/win/FontCGWin.cpp:
        (WebCore::Font::drawGlyphs):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 23 Dec 2010 02:59:41 +0000 (02:59 +0000)]
2010-12-22  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Webkit2: WebProcess crashes when Private browsing is turned on on yahoo.com
        https://bugs.webkit.org/show_bug.cgi?id=51516
        <rdar://problem/8766995>

        * WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
        (WebKit::NetscapePlugin::NPP_SetValue):
        Add a null check for NPP_SetValue.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 23 Dec 2010 02:53:44 +0000 (02:53 +0000)]
2010-12-22  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        REGRESSION (WK2): Plugins swallow CMD-W, CMD-Q, and probably other shortcuts
        https://bugs.webkit.org/show_bug.cgi?id=51515
        <rdar://problem/8740926>

        Always return false for keyboard events where the command key is down.

        * WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
        (WebKit::NetscapePlugin::platformHandleKeyboardEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Sheriff Bot <webkit.review.bot@gmail.com>
tonyg@chromium.org [Thu, 23 Dec 2010 02:44:16 +0000 (02:44 +0000)]
2010-12-22  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r74503.
        http://trac.webkit.org/changeset/74503
        https://bugs.webkit.org/show_bug.cgi?id=51513

        breaks chromium mac debug compile (Requested by tonyg-cr on
        #webkit).

        * platform/graphics/chromium/ImageLayerChromium.cpp:
        (WebCore::ImageLayerChromium::updateContentsIfDirty):
        * platform/graphics/skia/GraphicsContext3DSkia.cpp:
        (WebCore::GraphicsContext3D::getImageData):
2010-12-22  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r74503.
        http://trac.webkit.org/changeset/74503
        https://bugs.webkit.org/show_bug.cgi?id=51513

        breaks chromium mac debug compile (Requested by tonyg-cr on
        #webkit).

        * src/GraphicsContext3DChromium.cpp:
        (WebCore::GraphicsContext3DInternal::paintRenderingResultsToCanvas):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebProcess should be terminated if invalid frameIDs are
weinig@apple.com [Thu, 23 Dec 2010 01:57:42 +0000 (01:57 +0000)]
WebProcess should be terminated if invalid frameIDs are
passed to the UIProcess.
https://bugs.webkit.org/show_bug.cgi?id=51508

Reviewed by Darin Adler.

- Introduce a mechanism to mark a messages as invalid due to
  reasons other than in ability to decode the message, eg. an
  invalid frameID is passed in a message.

* Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::Connection):
(CoreIPC::Connection::markCurrentlyDispatchedMessageAsInvalid): Sets
the m_didReceiveInvalidMessage bit so that it can be picked up in
(CoreIPC::Connection::dispatchMessages): Check for m_didReceiveInvalidMessage in
addition to tainted arguments.
* Platform/CoreIPC/Connection.h:
Add base macro for others to extend, that calls markCurrentlyDispatchedMessageAsInvalid()
ASSERTs, and returns.

* UIProcess/WebPageProxy.cpp:
Add Message checks for all WebFrameProxy's gotten from frameIDs passed
over the wire.
* UIProcess/WebProcessProxy.cpp:
(WebKit::isGoodMapKey):
Checks that the key can be inserted safely into a map (eg. not the empty or deleted value).

(WebKit::WebProcessProxy::webFrame):
Return null for bad keys (eg. 0 or -1).

(WebKit::WebProcessProxy::canCreateFrame):
Added. Checks that the ID is good and not in the map yet. Used
as a consistency check before creating frames.

(WebKit::WebProcessProxy::frameCreated):
ASSERT that the key is good, in addition to not in the map yet.

(WebKit::WebProcessProxy::didDestroyFrame):
ASSERT that the key is good.

* UIProcess/WebProcessProxy.h:
Move WebFrameProxy HashMap type into a typedef.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Darin Adler <darin@apple.com>
darin@apple.com [Thu, 23 Dec 2010 01:45:58 +0000 (01:45 +0000)]
2010-12-22  Darin Adler  <darin@apple.com>

        Reviewed by Anders Carlsson.

        WebKit2 needs a way to return the main resource data
        https://bugs.webkit.org/show_bug.cgi?id=51510

        * UIProcess/API/C/WKFrame.cpp:
        (WKFrameGetMainResourceData): Added.
        (callGetMainResourceDataBlockAndDispose): Added.
        (WKFrameGetMainResourceData_b): Added.
        * UIProcess/API/C/WKFrame.h: Added WKFrameGetMainResourceData.

        * UIProcess/WebFrameProxy.cpp:
        (WebKit::WebFrameProxy::getMainResourceData): Added.
        * UIProcess/WebFrameProxy.h: Ditto.

        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::getMainResourceDataOfFrame): Added.
        (WebKit::WebPageProxy::dataCallback): Replaced the individual callbacks
        with just these two.
        (WebKit::WebPageProxy::stringCallback): Ditto.
        * UIProcess/WebPageProxy.h: Ditto.
        * UIProcess/WebPageProxy.messages.in: Ditto.

        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::runJavaScriptInMainFrame): Send the string callback
        message instead of a specific one.
        (WebKit::WebPage::getContentsAsString): Ditto.
        (WebKit::WebPage::getRenderTreeExternalRepresentation): Ditto.
        (WebKit::WebPage::getSelectionOrContentsAsString): Ditto.
        (WebKit::WebPage::getSourceForFrame): Ditto.
        (WebKit::WebPage::getMainResourceDataOfFrame): Added.
        (WebKit::WebPage::getWebArchiveOfFrame): Send the data callback message
        instead of a specific one.
        * WebProcess/WebPage/WebPage.h: Added getMainResourceDataOfFrame.
        * WebProcess/WebPage/WebPage.messages.in: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoReplace runtime checks for hyphenation API availability with compile-time checks.
mitz@apple.com [Thu, 23 Dec 2010 01:35:51 +0000 (01:35 +0000)]
Replace runtime checks for hyphenation API availability with compile-time checks.

Reviewed by Darin Adler.

* platform/text/cf/HyphenationCF.cpp:
(WebCore::::createValueForNullKey): Changed to use CFLocaleCopyCurrent() instead of using the
search locale, which is empty on Windows. On Mac, this is equivalent to using the search locale.
(WebCore::canHyphenate): Added this implementation for when the hyphenation API is not available.
It is identical to the implementation in Hyphenation.cpp.
(WebCore::lastHyphenLocation): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Thu, 23 Dec 2010 01:26:29 +0000 (01:26 +0000)]
2010-12-22  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Ojan Vafai.

        This change splits out the TestRunner class into its own file.
        When we fork the code for message passing, we will create a new
        TestRunner, and this change will allow that to be more modular.

        While we're at it, split out TestInput and ResultSummary into
        their own files, to reduce the size of run_webkit_tests to
        something more managable.

        https://bugs.webkit.org/show_bug.cgi?id=51092

        * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
        * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

 2010-12-22  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Ojan Vafai.

        nrwt multiprocessing - start over, prepare to fork the code

        This code cleans up the signatures and implementation of the
        TestRunner class so we can easily fork it to run either the
        stable implementation or the new, unstable message-passing
        implementation. The two variants will have different
        implementations of the run_tests() method. We will switch
        between the two based on the setting for the '--worker-model'
        switch. We rename the two currently valid values to 'old-inline'
        and 'old-threads'.

        https://bugs.webkit.org/show_bug.cgi?id=51081

        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 23 Dec 2010 01:17:45 +0000 (01:17 +0000)]
2010-12-22  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler.

        Cache snapshots of plug-ins before painting, to avoid script running during painting
        https://bugs.webkit.org/show_bug.cgi?id=51493

        When FrameView is asked to do a flattening paint (e.g. when Safari snapshots,
        or when printing), plug-ins which otherwise use the CA rendering model
        are sent a paint event. Some plug-ins may run script while handling this event,
        or out of process plug-ins may process queued requests at this time. Running
        script while inside layout or painting can have bad consequences, because it
        can result in arbitrary changes to the render tree.

        This patch avoids sending plug-ins paint events inside of painting. Instead,
        we ask the plug-ins to cache a snapshot before we paint, and then the software
        paint simply draws that snapshot.

        Requires manual test, because the bug happens when Safari does
        a page snapshot. It's not possible to tell the Test Netscape Plug-in
        to paint without laying out, making an automated test impossible.

        * manual-tests/plugins/plugin-paint-causes-layout.html: Added.

        * page/FrameView.h:
        * page/FrameView.cpp:
        (WebCore::FrameView::paintContents): Notify all enclosed widgets
        that a flattening paint is going to happen.
        (WebCore::FrameView::notifyWidgetsInAllFrames): Utility method
        that tells the RenderView in all subframes to notify their widgets.

        * platform/Widget.h:
        (WebCore::Widget::notifyWidget): Generic method that can be used
        to send messages to widgets. Current messages are just 'before flattening paint'
        and 'after flattening paint'. Message has no payload.

        * rendering/RenderView.h:
        * rendering/RenderView.cpp:
        (WebCore::RenderView::getRetainedWidgets):
        (WebCore::RenderView::releaseWidgets): Factor code out of updateWidgetPositions(),
        since we use it in two places now.

        (WebCore::RenderView::updateWidgetPositions): Use getRetainedWidgets() etc.
        (WebCore::RenderView::notifyWidgets): Retain all the widgets, then send
        them all the message.

        * rendering/RenderWidget.h:
        * rendering/RenderWidget.cpp:
        (WebCore::RenderWidget::notifyWidget): Pass the message to the widget.

        * Plugins/Hosted/WebHostedNetscapePluginView.mm:
        (-[WebHostedNetscapePluginView drawRect:]): If we have a cached snapshot,
        draw it. Also only send the snapshot message to the plugin proxy if we
        know we're snapshotting, since even if creating the snapshot image failed,
        we still don't want to call to the plug-in.

        * Plugins/WebBaseNetscapePluginView.h: Add a retained NSImage member for the snapshot.
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView cacheSnapshot]): Create an image and draw the snapshot into it.
        (-[WebBaseNetscapePluginView clearCachedSnapshot]): Clear the snapshot.

        * Plugins/WebNetscapePluginView.mm:
        (-[WebNetscapePluginView drawRect:]): If we have a cached snapshot, use it.
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (NetscapePluginWidget::notifyWidget): Implement notifyWidget() and use it
        to cache and clear the snapshots.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Thu, 23 Dec 2010 00:55:07 +0000 (00:55 +0000)]
2010-12-22  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Ojan Vafai.

        nrwt multiprocessing - start over, prepare to fork the code

        This code cleans up the signatures and implementation of the
        TestRunner class so we can easily fork it to run either the
        stable implementation or the new, unstable message-passing
        implementation. The two variants will have different
        implementations of the run_tests() method. We will switch
        between the two based on the setting for the '--worker-model'
        switch. We rename the two currently valid values to 'old-inline'
        and 'old-threads'.

        https://bugs.webkit.org/show_bug.cgi?id=51081

        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago* WebProcess/WebPage/WebPage.cpp: Add #if to try to fix non-Mac builds.
darin@apple.com [Thu, 23 Dec 2010 00:50:06 +0000 (00:50 +0000)]
* WebProcess/WebPage/WebPage.cpp: Add #if to try to fix non-Mac builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Darin Adler <darin@apple.com>
darin@apple.com [Thu, 23 Dec 2010 00:44:56 +0000 (00:44 +0000)]
2010-12-22  Darin Adler  <darin@apple.com>

        Reviewed by Anders Carlsson.

        Make Speech menu items work in WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=51504

        * UIProcess/API/C/WKFrame.cpp:
        (WKFrameGetWebArchive): Updated to use new-named typedef.
        * UIProcess/API/C/WKPage.cpp:
        (WKPageRunJavaScriptInMainFrame): Ditto.
        (WKPageRenderTreeExternalRepresentation): Ditto.
        (WKPageGetSourceForFrame): Ditto.
        (WKPageGetContentsAsString): Ditto.

        * UIProcess/API/mac/WKView.mm:
        (menuItem): Added. Helper function to make it easy to call menu item
        functions on arbitrary user interface items.
        (toolbarItem): Ditto.
        (-[WKView validateUserInterfaceItem:]): Added validation for startSpeaking
        and stopSpeaking commands. Reworked the code to fix a bug where
        toggleContinuousSpellChecking would always be enabled even when it should
        be disabled. Reworked the asynchronous validation code so it works for
        items other than menu items and can also handle more than one item for the
        same command. Added some comments.
        (speakString): Added. Helper function to be used as a callback when we
        get the selection or contents to speak.
        (-[WKView startSpeaking:]): Added. Uses getSelectionOrContentsAsString.
        (-[WKView stopSpeaking:]): Added.
        (-[WKView _setUserInterfaceItemState:enabled:state:]): Reworked to work
        with the changes to validateUserInterfaceItem above.

        * UIProcess/WebFrameProxy.cpp:
        (WebKit::WebFrameProxy::isDisplayingMarkupDocument): Added a FIXME about
        a problem I noticed.
        (WebKit::WebFrameProxy::didCommitLoad): Tweaked argument name.
        (WebKit::WebFrameProxy::getWebArchive): Changed to use new-named typedef.
        * UIProcess/WebFrameProxy.h: Changed WebArchiveCallback to DataCallaback.

        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::close): Invalidate the two callback maps since
        we only have two now.
        (WebKit::WebPageProxy::runJavaScriptInMainFrame): Changed to use merged
        maps and typedefs so we don't need a separate callback map for each function.
        (WebKit::WebPageProxy::getRenderTreeExternalRepresentation): Ditto.
        (WebKit::WebPageProxy::getSourceForFrame): Ditto.
        (WebKit::WebPageProxy::getContentsAsString): Ditto.
        (WebKit::WebPageProxy::getSelectionOrContentsAsString): Added.
        (WebKit::WebPageProxy::getWebArchiveOfFrame): Ditto.
        (WebKit::WebPageProxy::didGetContentsAsString): Ditto.
        (WebKit::WebPageProxy::didGetSelectionOrContentsAsString): Ditto.
        (WebKit::WebPageProxy::didRunJavaScriptInMainFrame): Ditto.
        (WebKit::WebPageProxy::didGetRenderTreeExternalRepresentation): Ditto.
        (WebKit::WebPageProxy::didGetSourceForFrame): Ditto.
        (WebKit::WebPageProxy::didGetWebArchiveOfFrame): Ditto.
        (WebKit::WebPageProxy::processDidCrash): Ditto.

        * UIProcess/WebPageProxy.h: Updated for changes above.

        * UIProcess/WebPageProxy.messages.in: Added DidGetSelectionOrContentsAsString,
        GetIsSpeaking, Speak, and StopSpeaking.

        * UIProcess/mac/WebPageProxyMac.mm:
        (WebKit::WebPageProxy::getIsSpeaking): Added.
        (WebKit::WebPageProxy::speak): Added.
        (WebKit::WebPageProxy::stopSpeaking): Added.

        * WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm:
        (WebKit::WebContextMenuClient::isSpeaking): Call WebPage instead of doing
        the work directly, so it can run in the UI process.
        (WebKit::WebContextMenuClient::speak): Ditto.
        (WebKit::WebContextMenuClient::stopSpeaking): Ditto.
        (WebKit::WebContextMenuClient::searchWithSpotlight): Added FIXME comment and
        changed code to avoid a C-style cast.

        * WebProcess/WebPage/WebFrame.cpp:
        (WebKit::WebFrame::selectionAsString): Added.
        * WebProcess/WebPage/WebFrame.h: Ditto.

        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::changeAcceleratedCompositingMode): Use sendSync in the
        modern way instead of explicitly calling WebProcess.
        (WebKit::WebPage::getSelectionOrContentsAsString): Added.
        (WebKit::WebPage::isSpeaking): Added.
        (WebKit::WebPage::speak): Added.
        (WebKit::WebPage::stopSpeaking): Added.
        * WebProcess/WebPage/WebPage.h: Added functions.

        * WebProcess/WebPage/WebPage.messages.in: Added GetSelectionOrContentsAsString.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Laszlo Gombos <laszlo.1.gombos@nokia.com>
laszlo.1.gombos@nokia.com [Thu, 23 Dec 2010 00:39:13 +0000 (00:39 +0000)]
2010-12-22  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Unreviewed build fix.

        [Symbian] Make sure OSAllocatorSymbian builds

        This patch only addresses the build problem.

        https://bugs.webkit.org/show_bug.cgi?id=51128 tracks the full
        (re)implementation of the Symbian allocator.

        * wtf/OSAllocatorSymbian.cpp:
        (WTF::OSAllocator::reserveUncommitted):
        (WTF::OSAllocator::reserveAndCommit):
        (WTF::OSAllocator::commit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix build.
andersca@apple.com [Thu, 23 Dec 2010 00:36:07 +0000 (00:36 +0000)]
Fix build.

* Platform/mac/MachUtilities.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Adrienne Walker <enne@google.com>
enne@google.com [Thu, 23 Dec 2010 00:27:00 +0000 (00:27 +0000)]
2010-12-22  Adrienne Walker  <enne@google.com>

        Reviewed by Kenneth Russell.

        Fix null pointer deref when restoring a lost WebGL context.
        https://bugs.webkit.org/show_bug.cgi?id=51494

        No new tests, as context restored events are not currently testable.

        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::initializeNewContext):
        (WebCore::WebGLRenderingContext::restoreContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Adam Bergkvist <adam.bergkvist@ericsson.com>
commit-queue@webkit.org [Thu, 23 Dec 2010 00:16:33 +0000 (00:16 +0000)]
2010-12-22  Adam Bergkvist  <adam.bergkvist@ericsson.com>

        Reviewed by Martin Robinson.

        [GTK] Building with Blob support fails again
        https://bugs.webkit.org/show_bug.cgi?id=51392

        Build fix.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 23 Dec 2010 00:15:24 +0000 (00:15 +0000)]
2010-12-22  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin Adler.

        Detect WebProcess crashes sooner, without waiting for ReportCrash to finish
        https://bugs.webkit.org/show_bug.cgi?id=51505

        * Platform/CoreIPC/CoreIPCMessageKinds.h:
        Add SetExceptionPort.

        * Platform/CoreIPC/mac/ConnectionMac.cpp:
        (CoreIPC::Connection::platformInvalidate):
        If we have an exception port, unregister it.

        (CoreIPC::Connection::platformInitialize):
        Set m_exceptionPort to null.

        (CoreIPC::Connection::open):
        If we have an exception port, register an event handler for it and send it over
        to the other side.

        (CoreIPC::Connection::receiveSourceEventHandler):
        Handle the SetExceptionPort message.

        (CoreIPC::Connection::exceptionSourceEventHandler):
        Receive the message, forward it to the real exception handler and call connectionDidClose.

        (CoreIPC::Connection::setShouldCloseConnectionOnMachExceptions):
        Create an exception port.

        * Platform/mac/MachUtilities.cpp:
        (machExceptionPort):
        (setMachExceptionPort):
        * Platform/mac/MachUtilities.h:
        Add helper functions for getting and setting the mach exception port.

        * UIProcess/WebProcessProxy.cpp:
        (WebKit::WebProcessProxy::didFinishLaunching):
        Call setShouldCloseConnectionOnMachExceptions on Mac.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Dan Bernstein <mitz@apple.com>
mitz@apple.com [Thu, 23 Dec 2010 00:13:54 +0000 (00:13 +0000)]
2010-12-22  Dan Bernstein  <mitz@apple.com>

        Reviewed by Anders Carlsson.

        canHyphenate() always returns true for the default locale
        https://bugs.webkit.org/show_bug.cgi?id=51506

        No test, since this change only affects performance.

        * platform/text/cf/HyphenationCF.cpp:
        (WebCore::::createValueForNullKey): Return 0 if hyphenation is not supported for the default locale.
        (WebCore::::createValueForKey): Removed whitespace.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Ariya Hidayat <ariya@sencha.com>
ariya@webkit.org [Wed, 22 Dec 2010 23:58:31 +0000 (23:58 +0000)]
2010-12-22  Ariya Hidayat  <ariya@sencha.com>

        Reviewed by Simon Fraser.

        Transform applied via CSSMatrix does not take full page zoom into account
        https://bugs.webkit.org/show_bug.cgi?id=24808

        The bug has been fixed with r74430 and r74451.
        These two are just the tests.

        * transforms/2d/cssmatrix-2d-zoom-expected.checksum: Added.
        * transforms/2d/cssmatrix-2d-zoom-expected.png: Added.
        * transforms/2d/cssmatrix-2d-zoom-expected.txt: Added.
        * transforms/2d/cssmatrix-2d-zoom.html: Added.
        * transforms/3d/general/cssmatrix-3d-zoom-expected.checksum: Added.
        * transforms/3d/general/cssmatrix-3d-zoom-expected.png: Added.
        * transforms/3d/general/cssmatrix-3d-zoom-expected.txt: Added.
        * transforms/3d/general/cssmatrix-3d-zoom.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Victor Wang <victorw@chromium.org>
victorw@chromium.org [Wed, 22 Dec 2010 23:47:24 +0000 (23:47 +0000)]
2010-12-22  Victor Wang  <victorw@chromium.org>

        Reviewed by Darin Fisher.

        [Chromium] Update chromium archive test result url in rebaseline script.

        https://bugs.webkit.org/show_bug.cgi?id=51503

        * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoTests that File.type returns empty string for file with invalid extension.
jianli@chromium.org [Wed, 22 Dec 2010 23:34:57 +0000 (23:34 +0000)]
Tests that File.type returns empty string for file with invalid extension.
https://bugs.webkit.org/show_bug.cgi?id=51501

Reviewed by David Levin.

* editing/pasteboard/file-input-files-access-expected.txt:
* editing/pasteboard/resources/file.invalidext: Added.
* editing/pasteboard/script-tests/file-input-files-access.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Steve Lacey <sjl@chromium.org>
commit-queue@webkit.org [Wed, 22 Dec 2010 23:32:15 +0000 (23:32 +0000)]
2010-12-22  Steve Lacey  <sjl@chromium.org>

        Reviewed by David Levin.

        [chromium] Rebaseline chromium media/controls-styling layout test and re-enable.
        https://bugs.webkit.org/show_bug.cgi?id=51427

        * platform/chromium-linux/media/controls-styling-expected.checksum: Added.
        * platform/chromium-linux/media/controls-styling-expected.png: Added.
        * platform/chromium-mac/media/controls-styling-expected.checksum: Added.
        * platform/chromium-mac/media/controls-styling-expected.png: Added.
        * platform/chromium-mac/media/controls-styling-expected.txt: Added.
        * platform/chromium-win/media/controls-styling-expected.checksum: Added.
        * platform/chromium-win/media/controls-styling-expected.png: Added.
        * platform/chromium-win/media/controls-styling-expected.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 22 Dec 2010 23:30:36 +0000 (23:30 +0000)]
2010-12-22  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Move Mach message receiving code out into a new function
        https://bugs.webkit.org/show_bug.cgi?id=51502

        * Platform/CoreIPC/mac/ConnectionMac.cpp:
        (CoreIPC::readFromMachPort):
        (CoreIPC::Connection::receiveSourceEventHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Jeff Miller <jeffm@apple.com>
commit-queue@webkit.org [Wed, 22 Dec 2010 23:05:17 +0000 (23:05 +0000)]
2010-12-22  Jeff Miller  <jeffm@apple.com>

        Reviewed by Sam Weinig.

        InjectedBundle methods should  use the relative URL constructor for KURL instead of the ParsedURLStringTag version
        https://bugs.webkit.org/show_bug.cgi?id=51491

        The url passed to various InjectedBundle methods is not from KURL::string(), i.e. it has not already been parsed by KURL,
        so we have to use the relative URL constructor for KURL instead of the ParsedURLStringTag version.

        * WebProcess/InjectedBundle/InjectedBundle.cpp:
        (WebKit::InjectedBundle::addUserScript):
        (WebKit::InjectedBundle::addUserStyleSheet):
        (WebKit::InjectedBundle::removeUserScript):
        (WebKit::InjectedBundle::removeUserStyleSheet):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Wed, 22 Dec 2010 22:39:08 +0000 (22:39 +0000)]
2010-12-22  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Joseph Pecoraro.

        Web Inspector: script name gets parsed as HTML in Call stack panel
        https://bugs.webkit.org/show_bug.cgi?id=51468

        * inspector/front-end/Placard.js:
        (WebInspector.Placard.prototype.set subtitle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Wed, 22 Dec 2010 22:22:20 +0000 (22:22 +0000)]
2010-12-22  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        * configure.ac: bump version to 1.3.9.

WebKit/gtk:

2010-12-22  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        * NEWS: update for 1.3.9 release.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Wed, 22 Dec 2010 22:11:14 +0000 (22:11 +0000)]
2010-12-22  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Darin Adler.

        MediaPlayer should look for MIME type in data: URL
        https://bugs.webkit.org/show_bug.cgi?id=51195

        If no MIME type is passed from the media element for a data: URL, try to get it from
        the URL itself.

        No new tests are possible because the MIME type is just passed to the media engine.

        * platform/graphics/MediaPlayer.cpp:
        (WebCore::MediaPlayer::load):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 W. James MacLean <wjmaclean@chromium.org>
commit-queue@webkit.org [Wed, 22 Dec 2010 22:03:24 +0000 (22:03 +0000)]
2010-12-22  W. James MacLean  <wjmaclean@chromium.org>

        Reviewed by Kenneth Russell.

        [chromium] Add asserts to test for contiguous-pixel Skia bitmaps.
        https://bugs.webkit.org/show_bug.cgi?id=51186

        No new tests. Behaviour not changed, but need the asserts to detect when assumptions violated.

        * platform/graphics/chromium/ImageLayerChromium.cpp:
        (WebCore::ImageLayerChromium::updateContentsIfDirty):
        * platform/graphics/skia/GraphicsContext3DSkia.cpp:
        (WebCore::GraphicsContext3D::getImageData):
2010-12-22  W. James MacLean  <wjmaclean@chromium.org>

        Reviewed by Kenneth Russell.

        [chromium] Add asserts to test for contiguous-pixel Skia bitmaps.
        https://bugs.webkit.org/show_bug.cgi?id=51186

        Add asserts to detect if assumptions (about contiguous pixels in Skia bitmaps) are violated.

        * src/GraphicsContext3DChromium.cpp:
        (WebCore::GraphicsContext3DInternal::paintRenderingResultsToCanvas):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Shane Stephens <shanestephens@google.com>
commit-queue@webkit.org [Wed, 22 Dec 2010 21:42:13 +0000 (21:42 +0000)]
2010-12-22  Shane Stephens  <shanestephens@google.com>

        Reviewed by David Levin.

        [Chromium] SLOW lines in chromium test_expectations.txt for svg tests which are no longer slow.
        https://bugs.webkit.org/show_bug.cgi?id=51429

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore: WAI-ARIA menubar role mapped to AXGroup, should be AXMenuBar
cfleizach@apple.com [Wed, 22 Dec 2010 21:34:01 +0000 (21:34 +0000)]
WebCore: WAI-ARIA menubar role mapped to AXGroup, should be AXMenuBar
https://bugs.webkit.org/show_bug.cgi?id=51488

Reviewed by Darin Adler.

Test: platform/mac/accessibility/aria-menubar.html

* accessibility/AccessibilityObject.cpp:
(WebCore::createARIARoleMap):

LayoutTests: Update fast/canvas/webgl/gl-uniform-arrays.html to bring in sync with Khronos
https://bugs.webkit.org/show_bug.cgi?id=51489

Patch by Kenneth Russell <kbr@google.com> on 2010-12-22
Reviewed by David Levin.

* fast/canvas/webgl/gl-uniform-arrays-expected.txt:
* fast/canvas/webgl/gl-uniform-arrays.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoMove more of WebPageProxy::didCommitLoadForFrame into WebFrameProxy::didCommitLoad.
darin@apple.com [Wed, 22 Dec 2010 21:26:42 +0000 (21:26 +0000)]
Move more of WebPageProxy::didCommitLoadForFrame into WebFrameProxy::didCommitLoad.

Reviewed by Sam Weinig.

* UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::didCommitLoad): Added type and certificate info arguments,
and set m_MIMEType, m_isFrameSet, and m_certificateInfo.
* UIProcess/WebFrameProxy.h: Removed setMIMEType and setCertificateInfo and added
arguments to didCommitLoad.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didCommitLoadForFrame): Removed code that is now inside the
WebFrameProxy::didCommitLoad function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Kenneth Russell <kbr@google.com>
kbr@google.com [Wed, 22 Dec 2010 21:13:58 +0000 (21:13 +0000)]
2010-12-22  Kenneth Russell  <kbr@google.com>

        Reviewed by David Levin.

        Update fast/canvas/webgl/gl-uniform-arrays.html to bring in sync with Khronos
        https://bugs.webkit.org/show_bug.cgi?id=51489

        * fast/canvas/webgl/gl-uniform-arrays-expected.txt:
        * fast/canvas/webgl/gl-uniform-arrays.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Lucas Forschler <lforschler@apple.com>
lforschler@apple.com [Wed, 22 Dec 2010 21:05:15 +0000 (21:05 +0000)]
2010-12-22  Lucas Forschler  <lforschler@apple.com>

        Reviewed by Alice Liu.

        <rdar://problem/8633222> record-memory-win needs to record memory used by the webprocess.
        Verified on Chrome, Safari, and IE.
        With this change, we will record memory from a parent browser window and all child processes.

        * record-memory-win/main.cpp:
        (ProcessArgs):
        (PrintUsage):
        (getMemoryInfo):
        (printProcessInfo):
        (evalProcesses):
        (UseImage):
        (QueryContinuously):
        (ElapsedTime):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Zhenyao Mo <zmo@google.com>
zmo@google.com [Wed, 22 Dec 2010 21:05:01 +0000 (21:05 +0000)]
2010-12-22  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        CopyTex{Sub}Image2D check always if the bound fbo's internal color format is compatible
        https://bugs.webkit.org/show_bug.cgi?id=51423

        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::copyTexImage2D): Remove the isGLES2Compliant flag around format compatibility checking.
        (WebCore::WebGLRenderingContext::copyTexSubImage2D): Ditto.
        (WebCore::WebGLRenderingContext::getBoundFramebufferColorFormat): Helper function to get bound framebuffer's color format; deal with the case of webgl's internal fbo.
        * html/canvas/WebGLRenderingContext.h:
2010-12-22  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        CopyTex{Sub}Image2D check always if the bound fbo's internal color format is compatible
        https://bugs.webkit.org/show_bug.cgi?id=51423

        * fast/canvas/webgl/tex-input-validation-expected.txt: Add test cases for copying from webgl's internal FBO.
        * fast/canvas/webgl/tex-input-validation.html: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Wed, 22 Dec 2010 20:53:56 +0000 (20:53 +0000)]
2010-12-22  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        [GTK] Compilation fixes with GTK+ 2.91.7
        https://bugs.webkit.org/show_bug.cgi?id=51487

        * configure.ac: depend on GTK+ 2.91.7 when using GTK+ 3.x.

WebCore:

2010-12-22  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        [GTK] Compilation fixes with GTK+ 2.91.7
        https://bugs.webkit.org/show_bug.cgi?id=51487

        * platform/gtk/GtkVersioning.h: do not define GDK_DISPLAY for
        backwards compatibility, it's now defined again in GTK+ 3.x.
        * platform/gtk/PasteboardHelper.cpp: do not call GDK functions to
        initialize global static variables (!). These are called when the
        .so is loaded, and they now require GType to be initialized and
        will crash. Initialize them once from the ctor, which is a more
        common pattern anyway.
        (WebCore::initGdkAtoms): new method to initialize static variables.
        (WebCore::PasteboardHelper::PasteboardHelper): call it.
        * plugins/gtk/PluginViewGtk.cpp: do not include gdkconfig.h when
        using GTK+ 3.x, since it's no longer installed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Lucas Forschler <lforschler@apple.com>
lforschler@apple.com [Wed, 22 Dec 2010 20:53:15 +0000 (20:53 +0000)]
2010-12-22  Lucas Forschler  <lforschler@apple.com>

        Unreviewed rollout r74489, because it was missing changelog.

        * record-memory-win/main.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-21 Darin Adler <darin@apple.com>
darin@apple.com [Wed, 22 Dec 2010 20:22:50 +0000 (20:22 +0000)]
2010-12-21  Darin Adler  <darin@apple.com>

        Reviewed by Brady Eidson and Sam Weinig.

        Add a way to get a web archive in WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=51437

        * UIProcess/API/C/WKFrame.cpp:
        (WKFrameGetWebArchive): Added.
        (callGetWebArchiveBlockAndDispose): Added.
        (WKFrameGetWebArchive_b): Added.
        * UIProcess/API/C/WKFrame.h: Added functions above.
        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::close): Clear out m_webArchiveCallbacks.
        (WebKit::WebPageProxy::getWebArchiveOfFrame): Added.
        (WebKit::WebPageProxy::didGetWebArchiveOfFrame): Added.
        (WebKit::WebPageProxy::processDidCrash): Clear out m_webArchiveCallbacks.
        * UIProcess/WebPageProxy.h: Added functions above.
        * UIProcess/WebPageProxy.messages.in: Added DidGetWebArchiveOfFrame.
        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::getWebArchiveOfFrame): Added.
        * WebProcess/WebPage/WebPage.h: Added function above.
        * WebProcess/WebPage/WebPage.messages.in: Added GetWebArchiveOfFrame.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Dirk Schulze <krit@wbekit.org>
krit@webkit.org [Wed, 22 Dec 2010 20:15:51 +0000 (20:15 +0000)]
2010-12-22  Dirk Schulze  <krit@wbekit.org>

        Reviewed by Nikolas Zimmermann.

        Cleanup SVG code according to the webkit style rules 2
        https://bugs.webkit.org/show_bug.cgi?id=51461

        Second patch to fix indention and other style issues according to the WebKit style rules in the SVG code.

        No changes of functionality, so no new tests.

        * svg/SVGFEDisplacementMapElement.cpp:
        (WebCore::SVGFEDisplacementMapElement::stringToChannel):
        * svg/SVGFEDistantLightElement.h:
        * svg/SVGFEFuncAElement.h:
        * svg/SVGFEFuncBElement.h:
        * svg/SVGFEFuncGElement.h:
        * svg/SVGFEFuncRElement.h:
        * svg/SVGFEMergeElement.cpp:
        (WebCore::SVGFEMergeElement::build):
        * svg/SVGFEMorphologyElement.cpp:
        * svg/SVGFEPointLightElement.h:
        * svg/SVGFESpecularLightingElement.cpp:
        (WebCore::SVGFESpecularLightingElement::findLights):
        * svg/SVGFESpotLightElement.h:
        * svg/SVGFitToViewBox.cpp:
        (WebCore::SVGFitToViewBox::parseViewBox):
        (WebCore::SVGFitToViewBox::isKnownAttribute):
        * svg/SVGFontFaceElement.cpp:
        (WebCore::cssPropertyIdForSVGAttributeName):
        * svg/SVGFontFaceElement.h:
        (WebCore::SVGFontFaceElement::associatedFontElement):
        * svg/SVGFontFaceNameElement.h:
        * svg/SVGFontFaceSrcElement.cpp:
        * svg/SVGFontFaceSrcElement.h:
        * svg/SVGFontFaceUriElement.h:
        * svg/SVGForeignObjectElement.h:
        * svg/SVGGlyphElement.cpp:
        (WebCore::parseArabicForm):
        (WebCore::parseOrientation):
        * svg/SVGGlyphElement.h:
        (WebCore::SVGGlyphIdentifier::SVGGlyphIdentifier):
        (WebCore::SVGGlyphIdentifier::inheritedValue):
        (WebCore::SVGGlyphIdentifier::operator==):
        (WebCore::SVGGlyphElement::rendererIsNeeded):
        * svg/SVGGlyphMap.h:
        (WebCore::GlyphMapNode::GlyphMapNode):
        (WebCore::GlyphMapNode::create):
        (WebCore::SVGGlyphMap::SVGGlyphMap):
        (WebCore::SVGGlyphMap::add):
        (WebCore::SVGGlyphMap::compareGlyphPriority):
        (WebCore::SVGGlyphMap::get):
        (WebCore::SVGGlyphMap::clear):
        * svg/SVGGradientElement.cpp:
        * svg/SVGHKernElement.cpp:
        * svg/SVGHKernElement.h:
        (WebCore::SVGHKernElement::rendererIsNeeded):
        * svg/SVGImageElement.h:
        * svg/SVGImageLoader.cpp:
        * svg/SVGImageLoader.h:
        * svg/SVGLangSpace.cpp:
        (WebCore::SVGLangSpace::parseMappedAttribute):
        (WebCore::SVGLangSpace::isKnownAttribute):
        * svg/SVGLangSpace.h:
        (WebCore::SVGLangSpace::xmllang):
        * svg/SVGMetadataElement.h:
        * svg/SVGMissingGlyphElement.h:
        (WebCore::SVGMissingGlyphElement::rendererIsNeeded):
        * svg/SVGPaint.cpp:
        (WebCore::SVGPaint::cssText):
        * svg/SVGPaint.h:
        (WebCore::SVGPaint::create):
        (WebCore::SVGPaint::paintType):
        (WebCore::SVGPaint::isSVGPaint):
        * svg/SVGParserUtilities.cpp:
        * svg/SVGParserUtilities.h:
        (WebCore::isWhitespace):
        (WebCore::skipOptionalSpaces):
        (WebCore::skipOptionalSpacesOrDelimiter):
        * svg/SVGPathElement.cpp:
        * svg/SVGPathParserFactory.h:
        * svg/SVGPathSegList.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAX: WAI-ARIA textbox role needs different AXRole, depending on value of aria-multilin...
cfleizach@apple.com [Wed, 22 Dec 2010 19:51:19 +0000 (19:51 +0000)]
AX: WAI-ARIA textbox role needs different AXRole, depending on value of aria-multiline property
https://bugs.webkit.org/show_bug.cgi?id=51481

WebCore:

Reviewed by Sam Weinig.

Support aria-multiline and use it to change the role of an ARIA "textbox"
from AXTextArea to AXTextField.

Test: platform/mac/accessibility/aria-multiline.html

* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::ariaIsMultiline):
* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::isPasswordField):
(WebCore::AccessibilityObject::isTextControl):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::determineAriaRoleAttribute):
* accessibility/AccessibilityRenderObject.h:
* html/HTMLAttributeNames.in:

LayoutTests:

Reviewed by Sam Weining.

* platform/mac/accessibility/aria-multiline-expected.txt: Added.
* platform/mac/accessibility/aria-multiline.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 22 Dec 2010 19:19:08 +0000 (19:19 +0000)]
2010-12-22  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        CSS 2.1 failure: counter-increment-013 fails
        https://bugs.webkit.org/show_bug.cgi?id=51483

        Clamp the counter-increment property to the valid range of signed
        integers.

        Test: fast/css/counters/counter-increment-overflow.html

        * css/CSSParser.cpp:
        (WebCore::clampToSignedInteger):
        (WebCore::CSSParser::parseCounter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Wed, 22 Dec 2010 19:11:41 +0000 (19:11 +0000)]
2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>

        Adding myself as a reviewer.

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agogit-svn-id: https://svn.webkit.org/repository/webkit/trunk@74489 268f45cc-cd09-0410...
lforschler@apple.com [Wed, 22 Dec 2010 19:10:06 +0000 (19:10 +0000)]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoChanged WebKitTools to Tools.
mitz@apple.com [Wed, 22 Dec 2010 19:03:03 +0000 (19:03 +0000)]
Changed WebKitTools to Tools.

JavaScriptCore:

* JavaScriptCore.vcproj/JavaScriptCore.sln:

WebKit/win:

* WebKit.vcproj/WebKit.sln:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoChanged WebKitTools to Tools in script build phases.
mitz@apple.com [Wed, 22 Dec 2010 18:56:31 +0000 (18:56 +0000)]
Changed WebKitTools to Tools in script build phases.

Rubber-stamped by Mark Rowe.

JavaScriptCore:

* JavaScriptCore.xcodeproj/project.pbxproj:

JavaScriptGlue:

* JavaScriptGlue.xcodeproj/project.pbxproj:

WebCore:

* WebCore.xcodeproj/project.pbxproj:

WebKit:

* WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Chang Shu <chang.shu@nokia.com>
chang.shu@nokia.com [Wed, 22 Dec 2010 18:50:57 +0000 (18:50 +0000)]
2010-12-22  Chang Shu  <chang.shu@nokia.com>

        Unreviewed layout test fix.

        Revert changeset 74481: http://trac.webkit.org/changeset/74481,
        as it causes regression on layout tests.

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Wed, 22 Dec 2010 18:41:21 +0000 (18:41 +0000)]
2010-12-22  Tony Gentilcore  <tonyg@chromium.org>

        Unreviewed build fix.

        [chromium] console-websocket-error sometimes times out
        https://bugs.webkit.org/show_bug.cgi?id=51482

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-21 Vangelis Kokkevis <vangelis@chromium.org>
vangelis@chromium.org [Wed, 22 Dec 2010 18:36:04 +0000 (18:36 +0000)]
2010-12-21  Vangelis Kokkevis  <vangelis@chromium.org>

        Reviewed by Kenneth Russell.

        [chromium] Fixing crash with empty render surfaces.
        https://bugs.webkit.org/show_bug.cgi?id=51432

        Test: platform/chromium/compositing/empty-render-surface-crasher.html

        * platform/graphics/chromium/RenderSurfaceChromium.cpp:
        (WebCore::RenderSurfaceChromium::draw):
2010-12-21  Vangelis Kokkevis  <vangelis@chromium.org>

        Reviewed by Kenneth Russell.

        [chromium] Enabling layout tests in platform/chromium/compositing
        and adding new layout test to check for crash on empty render surfaces.
        https://bugs.webkit.org/show_bug.cgi?id=51432

        * platform/chromium-gpu/test_expectations.txt:
        * platform/chromium/compositing/empty-render-surface-crasher-expected.txt: Added.
        * platform/chromium/compositing/empty-render-surface-crasher.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Andrew Scherkus <scherkus@chromium.org>
scherkus@chromium.org [Wed, 22 Dec 2010 18:16:43 +0000 (18:16 +0000)]
2010-12-22  Andrew Scherkus  <scherkus@chromium.org>

        Unreviewed.  Adding myself to committers.py.

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Ariya Hidayat <ariya@sencha.com>
ariya@webkit.org [Wed, 22 Dec 2010 18:12:26 +0000 (18:12 +0000)]
2010-12-22  Ariya Hidayat  <ariya@sencha.com>

        Reviewed by Kenneth Rohde Christiansen.

        TestNetscapePlugIn should use #if defined
        https://bugs.webkit.org/show_bug.cgi?id=51471

        * DumpRenderTree/TestNetscapePlugIn/main.cpp:
        (NP_Initialize):
        (NPP_New):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Krithigassree Sambamurthy <krithigassree.sambamurthy@nokia.com>
commit-queue@webkit.org [Wed, 22 Dec 2010 16:25:35 +0000 (16:25 +0000)]
2010-12-22  Krithigassree Sambamurthy  <krithigassree.sambamurthy@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] LayoutTests/http/tests/appcache/auth.html failed and skipped
        https://bugs.webkit.org/show_bug.cgi?id=36688

        * platform/qt/Skipped: Unskip auth.html which now passes.
        Using Qt4.7.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Wed, 22 Dec 2010 16:22:58 +0000 (16:22 +0000)]
2010-12-22  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: [chromium] DRT inspector layout tests are flaky in debug.

        DevTools window should be closed explicitly because it has custom deinitialization code.

        https://bugs.webkit.org/show_bug.cgi?id=50722

        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::closeRemainingWindows):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd Windows-specific expected results for fast/js/large-expressions.html in order...
jberlin@webkit.org [Wed, 22 Dec 2010 15:41:28 +0000 (15:41 +0000)]
Add Windows-specific expected results for fast/js/large-expressions.html in order to get
the Windows 7 Release test bot green again. Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=51469

* platform/win/fast/js/large-expressions-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agocheck-webkit-style shouldn't complaint about underscores in variables in objective...
levin@chromium.org [Wed, 22 Dec 2010 15:31:47 +0000 (15:31 +0000)]
check-webkit-style shouldn't complaint about underscores in variables in objective C files.
https://bugs.webkit.org/show_bug.cgi?id=51452

Reviewed by Shinichiro Hamaji.

* Scripts/webkitpy/style/checkers/cpp.py:
(_FileState.__init__): Added the information to determine if a file is C or Objective C.
Using the file extension if possible but falling back to the file contents if we have a header file.
(_FileState.is_objective_c): Determine if we have an Objective C by examining the file contents if needed.
(_FileState.is_c_or_objective_c):
(check_using_std): Changed to using _FileState to determine the file type.
(check_max_min_macros): Ditto.
(check_for_null): Ditto.
(check_style): Changed the parameters to various calls since they now need _FileState
to determine the file type.
(check_language): Added the file_state parameter so it could be passed
to check_identifier_name_in_declaration.
(check_identifier_name_in_declaration): Don't warn about underscores in variables if
this is an Objective C file.
(_process_lines): Added information for the _FileState constructor (and moved the
call to a place that had the information).
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
(CppFunctionsTest.test_is_c_or_objective_c): Changed the tests to use FileState and exercise
its functionality.
(WebKitStyleTest.test_names): Add tests for underscores in Objective C files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-21 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Wed, 22 Dec 2010 14:17:19 +0000 (14:17 +0000)]
2010-12-21  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: persist JavaScript breakpoints in frontend settings.
        https://bugs.webkit.org/show_bug.cgi?id=48434

        * http/tests/inspector/debugger-test2.js:
        (initialize_DebuggerTest.InspectorTest.setBreakpoint):
        * inspector/debugger-breakpoints-not-activated-on-reload.html:
        * inspector/debugger-pause-on-breakpoint.html:
        * inspector/report-protocol-errors-expected.txt:
        * inspector/report-protocol-errors.html:
2010-12-21  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: persist JavaScript breakpoints in frontend settings.
        https://bugs.webkit.org/show_bug.cgi?id=48434

        * bindings/js/ScriptDebugServer.cpp:
        (WebCore::ScriptDebugServer::setBreakpoint):
        (WebCore::ScriptDebugServer::removeBreakpoint):
        * bindings/js/ScriptDebugServer.h:
        * bindings/v8/DebuggerScript.js:
        ():
        * bindings/v8/ScriptDebugServer.cpp:
        (WebCore::ScriptDebugServer::setBreakpoint):
        (WebCore::ScriptDebugServer::removeBreakpoint):
        * bindings/v8/ScriptDebugServer.h:
        * inspector/Inspector.idl:
        * inspector/InspectorBackend.cpp:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::InspectorController):
        (WebCore::InspectorController::enableDebuggerFromFrontend):
        (WebCore::InspectorController::setStickyBreakpoints):
        (WebCore::InspectorController::restoreStickyBreakpoint):
        * inspector/InspectorController.h:
        * inspector/InspectorDebuggerAgent.cpp:
        (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
        (WebCore::InspectorDebuggerAgent::setStickyBreakpoint):
        (WebCore::InspectorDebuggerAgent::setBreakpoint):
        (WebCore::InspectorDebuggerAgent::removeBreakpoint):
        (WebCore::InspectorDebuggerAgent::restoreBreakpoint):
        (WebCore::InspectorDebuggerAgent::clearForPageNavigation):
        (WebCore::InspectorDebuggerAgent::didParseSource):
        * inspector/InspectorDebuggerAgent.h:
        * inspector/front-end/Breakpoint.js:
        (WebInspector.Breakpoint):
        (WebInspector.Breakpoint.prototype.remove):
        * inspector/front-end/BreakpointManager.js:
        (WebInspector.BreakpointManager):
        (WebInspector.DOMBreakpoint.prototype._serializeToJSON):
        (WebInspector.JavaScriptBreakpoint):
        (WebInspector.XHRBreakpoint.prototype._serializeToJSON):
        * inspector/front-end/DebuggerModel.js:
        (WebInspector.DebuggerModel):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype._debuggerPaused):
        * inspector/front-end/SourceFrame.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore: https://bugs.webkit.org/show_bug.cgi?id=51354
antti@apple.com [Wed, 22 Dec 2010 14:00:55 +0000 (14:00 +0000)]
WebCore: https://bugs.webkit.org/show_bug.cgi?id=51354
Don't block rendering and script execution on deferred stylesheets

Reviewed by Alexey Proskuryakov.

- Don't add low priority stylesheets to the document pending sheet count.
- Resolve media attribute fully for the link element stylesheet load.

Test: http/tests/local/stylesheet-and-script-load-order-media-print.html

* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::HTMLLinkElement):
(WebCore::HTMLLinkElement::~HTMLLinkElement):
(WebCore::HTMLLinkElement::setDisabledState):
(WebCore::HTMLLinkElement::process):
(WebCore::HTMLLinkElement::sheetLoaded):
(WebCore::HTMLLinkElement::addPendingSheet):
(WebCore::HTMLLinkElement::removePendingSheet):
* html/HTMLLinkElement.h:

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=51354
Don't block rendering and script execution on deferred stylesheets

Reviewed by Alexey Proskuryakov.

* http/tests/local/link-stylesheet-load-order-expected.txt:
* http/tests/local/link-stylesheet-load-order-preload-expected.txt:
* http/tests/local/resources/check-stylesheet-not-loaded.js: Added.
* http/tests/local/stylesheet-and-script-load-order-media-print-expected.txt: Added.
* http/tests/local/stylesheet-and-script-load-order-media-print.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Sheriff Bot <webkit.review.bot@gmail.com>
podivilov@chromium.org [Wed, 22 Dec 2010 13:34:08 +0000 (13:34 +0000)]
2010-12-22  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r74473.
        http://trac.webkit.org/changeset/74473
        https://bugs.webkit.org/show_bug.cgi?id=51463

        broke compilation on leopard intel release (Requested by
        podivilov on #webkit).

        * http/tests/inspector/debugger-test2.js:
        * inspector/debugger-breakpoints-not-activated-on-reload.html:
        * inspector/debugger-pause-on-breakpoint.html:
        * inspector/report-protocol-errors-expected.txt:
        * inspector/report-protocol-errors.html:
2010-12-22  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r74473.
        http://trac.webkit.org/changeset/74473
        https://bugs.webkit.org/show_bug.cgi?id=51463

        broke compilation on leopard intel release (Requested by
        podivilov on #webkit).

        * bindings/js/ScriptDebugServer.cpp:
        (WebCore::ScriptDebugServer::setBreakpoint):
        (WebCore::ScriptDebugServer::removeBreakpoint):
        * bindings/js/ScriptDebugServer.h:
        * bindings/v8/DebuggerScript.js:
        ():
        * bindings/v8/ScriptDebugServer.cpp:
        (WebCore::ScriptDebugServer::setBreakpoint):
        (WebCore::ScriptDebugServer::removeBreakpoint):
        * bindings/v8/ScriptDebugServer.h:
        * inspector/Inspector.idl:
        * inspector/InspectorBackend.cpp:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::InspectorController):
        (WebCore::InspectorController::enableDebuggerFromFrontend):
        (WebCore::InspectorController::setStickyBreakpoints):
        (WebCore::InspectorController::restoreStickyBreakpoint):
        (WebCore::InspectorController::breakpointsSettingKey):
        (WebCore::InspectorController::loadBreakpoints):
        (WebCore::InspectorController::saveBreakpoints):
        * inspector/InspectorController.h:
        * inspector/InspectorDebuggerAgent.cpp:
        (WebCore::formatBreakpointId):
        (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
        (WebCore::InspectorDebuggerAgent::setBreakpoint):
        (WebCore::InspectorDebuggerAgent::removeBreakpoint):
        (WebCore::InspectorDebuggerAgent::clearForPageNavigation):
        (WebCore::InspectorDebuggerAgent::md5Base16):
        (WebCore::InspectorDebuggerAgent::loadBreakpoints):
        (WebCore::InspectorDebuggerAgent::saveBreakpoints):
        (WebCore::InspectorDebuggerAgent::didParseSource):
        * inspector/InspectorDebuggerAgent.h:
        * inspector/front-end/Breakpoint.js:
        (WebInspector.Breakpoint):
        (WebInspector.Breakpoint.jsBreakpointId):
        (WebInspector.Breakpoint.prototype.set enabled):
        (WebInspector.Breakpoint.prototype.get id):
        (WebInspector.Breakpoint.prototype.set condition):
        (WebInspector.Breakpoint.prototype.remove):
        * inspector/front-end/BreakpointManager.js:
        (WebInspector.BreakpointManager):
        (WebInspector.BreakpointManager.prototype._createDOMBreakpoint):
        (WebInspector.BreakpointManager.prototype._createEventListenerBreakpoint):
        (WebInspector.BreakpointManager.prototype._createXHRBreakpoint):
        (WebInspector.BreakpointManager.prototype._setNativeBreakpoint):
        (WebInspector.BreakpointManager.prototype._setNativeBreakpointEnabled):
        (WebInspector.BreakpointManager.prototype._removeNativeBreakpoint):
        (WebInspector.BreakpointManager.prototype.breakpointViewForEventData):
        (WebInspector.BreakpointManager.prototype._projectChanged):
        (WebInspector.BreakpointManager.prototype.restoreDOMBreakpoints):
        (WebInspector.BreakpointManager.prototype._saveBreakpoints):
        (WebInspector.BreakpointManager.prototype._validateBreakpoints):
        (WebInspector.DOMBreakpoint.prototype._serializeToJSON):
        (WebInspector.EventListenerBreakpoint.prototype._serializeToJSON):
        (WebInspector.XHRBreakpoint.prototype._serializeToJSON):
        (WebInspector.NativeBreakpointView.prototype.set enabled):
        (WebInspector.NativeBreakpointView.prototype.remove):
        * inspector/front-end/DebuggerModel.js:
        (WebInspector.DebuggerModel):
        (WebInspector.DebuggerModel.prototype.setOneTimeBreakpoint):
        (WebInspector.DebuggerModel.prototype.removeOneTimeBreakpoint):
        (WebInspector.DebuggerModel.prototype.setBreakpoint):
        (WebInspector.DebuggerModel.prototype.findBreakpoint):
        (WebInspector.DebuggerModel.prototype.reset):
        (WebInspector.DebuggerModel.prototype._setBreakpoint):
        (WebInspector.DebuggerModel.prototype._breakpointRemoved):
        (WebInspector.DebuggerModel.prototype._setBreakpointOnBackend):
        (WebInspector.DebuggerModel.prototype.breakpointRestored):
        (WebInspector.DebuggerModel.prototype.pausedScript):
        (WebInspector.DebuggerModel.prototype.resumedScript):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype.continueToLine):
        (WebInspector.ScriptsPanel.prototype._debuggerPaused):
        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype._contextMenu.addConditionalBreakpoint.didEditBreakpointCondition):
        (WebInspector.SourceFrame.prototype._contextMenu.addConditionalBreakpoint):
        (WebInspector.SourceFrame.prototype._contextMenu.else.editBreakpointCondition.didEditBreakpointCondition):
        (WebInspector.SourceFrame.prototype._contextMenu.else.editBreakpointCondition):
        (WebInspector.SourceFrame.prototype._contextMenu):
        (WebInspector.SourceFrame.prototype._mouseDown):
        (WebInspector.SourceFrame.prototype._continueToLine):
        (WebInspector.SourceFrame.prototype._setBreakpoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Andrei Popescu <andreip@google.com>
andreip@google.com [Wed, 22 Dec 2010 13:23:11 +0000 (13:23 +0000)]
2010-12-22  Andrei Popescu  <andreip@google.com>

        Unreviewed build fix.

        Fix Chromium Linux shared library build.
        [Chromium] r74431 broke the Chromium Linux shared library build
        https://bugs.webkit.org/show_bug.cgi?id=51462

        * JavaScriptCore.gyp/JavaScriptCore.gyp:
        * JavaScriptCore.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-21 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Wed, 22 Dec 2010 13:13:28 +0000 (13:13 +0000)]
2010-12-21  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: persist JavaScript breakpoints in frontend settings.
        https://bugs.webkit.org/show_bug.cgi?id=48434

        * http/tests/inspector/debugger-test2.js:
        (initialize_DebuggerTest.InspectorTest.setBreakpoint):
        * inspector/debugger-breakpoints-not-activated-on-reload.html:
        * inspector/debugger-pause-on-breakpoint.html:
        * inspector/report-protocol-errors-expected.txt:
        * inspector/report-protocol-errors.html:
2010-12-21  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: persist JavaScript breakpoints in frontend settings.
        https://bugs.webkit.org/show_bug.cgi?id=48434

        * bindings/js/ScriptDebugServer.cpp:
        (WebCore::ScriptDebugServer::setBreakpoint):
        (WebCore::ScriptDebugServer::removeBreakpoint):
        * bindings/js/ScriptDebugServer.h:
        * bindings/v8/DebuggerScript.js:
        ():
        * bindings/v8/ScriptDebugServer.cpp:
        (WebCore::ScriptDebugServer::setBreakpoint):
        (WebCore::ScriptDebugServer::removeBreakpoint):
        * bindings/v8/ScriptDebugServer.h:
        * inspector/Inspector.idl:
        * inspector/InspectorBackend.cpp:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::InspectorController):
        (WebCore::InspectorController::enableDebuggerFromFrontend):
        (WebCore::InspectorController::setStickyBreakpoints):
        (WebCore::InspectorController::restoreStickyBreakpoint):
        * inspector/InspectorController.h:
        * inspector/InspectorDebuggerAgent.cpp:
        (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
        (WebCore::InspectorDebuggerAgent::setStickyBreakpoint):
        (WebCore::InspectorDebuggerAgent::setBreakpoint):
        (WebCore::InspectorDebuggerAgent::removeBreakpoint):
        (WebCore::InspectorDebuggerAgent::restoreBreakpoint):
        (WebCore::InspectorDebuggerAgent::clearForPageNavigation):
        (WebCore::InspectorDebuggerAgent::didParseSource):
        * inspector/InspectorDebuggerAgent.h:
        * inspector/front-end/Breakpoint.js:
        (WebInspector.Breakpoint):
        (WebInspector.Breakpoint.prototype.remove):
        * inspector/front-end/BreakpointManager.js:
        (WebInspector.BreakpointManager):
        (WebInspector.DOMBreakpoint.prototype._serializeToJSON):
        (WebInspector.JavaScriptBreakpoint):
        (WebInspector.XHRBreakpoint.prototype._serializeToJSON):
        * inspector/front-end/DebuggerModel.js:
        (WebInspector.DebuggerModel):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype._debuggerPaused):
        * inspector/front-end/SourceFrame.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Dirk Schulze <krit@wbekit.org>
krit@webkit.org [Wed, 22 Dec 2010 12:25:23 +0000 (12:25 +0000)]
2010-12-22  Dirk Schulze  <krit@wbekit.org>

        Reviewed by Nikolas Zimmermann.

        Cleanup SVG code according to the webkit style rules 1
        https://bugs.webkit.org/show_bug.cgi?id=51411

        First patch to fix indention and other style issues according to the WebKit style rules in the SVG code.

        No change of functionality.

        * svg/ColorDistance.cpp:
        (WebCore::ColorDistance::isZero):
        * svg/ColorDistance.h:
        * svg/ElementTimeControl.h:
        (WebCore::ElementTimeControl::~ElementTimeControl):
        * svg/LinearGradientAttributes.h:
        (WebCore::LinearGradientAttributes::LinearGradientAttributes):
        (WebCore::LinearGradientAttributes::x1):
        (WebCore::LinearGradientAttributes::y1):
        (WebCore::LinearGradientAttributes::x2):
        (WebCore::LinearGradientAttributes::y2):
        (WebCore::LinearGradientAttributes::setX1):
        (WebCore::LinearGradientAttributes::setY1):
        (WebCore::LinearGradientAttributes::setX2):
        (WebCore::LinearGradientAttributes::setY2):
        (WebCore::LinearGradientAttributes::hasX1):
        (WebCore::LinearGradientAttributes::hasY1):
        (WebCore::LinearGradientAttributes::hasX2):
        (WebCore::LinearGradientAttributes::hasY2):
        * svg/RadialGradientAttributes.h:
        (WebCore::RadialGradientAttributes::RadialGradientAttributes):
        (WebCore::RadialGradientAttributes::cx):
        (WebCore::RadialGradientAttributes::cy):
        (WebCore::RadialGradientAttributes::r):
        (WebCore::RadialGradientAttributes::fx):
        (WebCore::RadialGradientAttributes::fy):
        (WebCore::RadialGradientAttributes::setCx):
        (WebCore::RadialGradientAttributes::setCy):
        (WebCore::RadialGradientAttributes::setR):
        (WebCore::RadialGradientAttributes::setFx):
        (WebCore::RadialGradientAttributes::setFy):
        (WebCore::RadialGradientAttributes::hasCx):
        (WebCore::RadialGradientAttributes::hasCy):
        (WebCore::RadialGradientAttributes::hasR):
        (WebCore::RadialGradientAttributes::hasFx):
        (WebCore::RadialGradientAttributes::hasFy):
        * svg/SVGAngle.cpp:
        * svg/SVGAnimateColorElement.h:
        * svg/SVGAnimateElement.cpp:
        (WebCore::SVGAnimateElement::calculateAnimatedValue):
        (WebCore::SVGAnimateElement::calculateDistance):
        * svg/SVGAnimateElement.h:
        * svg/SVGAnimateMotionElement.cpp:
        * svg/SVGAnimateMotionElement.h:
        * svg/SVGAnimatedNumber.h:
        * svg/SVGAnimationElement.cpp:
        (WebCore::parseKeyTimes):
        (WebCore::SVGAnimationElement::currentValuesForValuesAnimation):
        (WebCore::SVGAnimationElement::updateAnimation):
        * svg/SVGClipPathElement.cpp:
        (WebCore::SVGClipPathElement::svgAttributeChanged):
        * svg/SVGColor.h:
        (WebCore::SVGColor::create):
        (WebCore::SVGColor::createCurrentColor):
        (WebCore::SVGColor::colorType):
        (WebCore::SVGColor::setRGBColor):
        (WebCore::SVGColor::color):
        (WebCore::SVGColor::isSVGColor):
        * svg/SVGCursorElement.cpp:
        (WebCore::SVGCursorElement::svgAttributeChanged):
        * svg/SVGCursorElement.h:
        * svg/SVGDescElement.h:
        (WebCore::SVGDescElement::rendererIsNeeded):
        * svg/SVGDocument.cpp:
        * svg/SVGDocument.h:
        (WebCore::SVGDocument::create):
        (WebCore::SVGDocument::isSVGDocument):
        * svg/SVGElement.h:
        (WebCore::SVGElement::isStyled):
        (WebCore::SVGElement::isStyledTransformable):
        (WebCore::SVGElement::isStyledLocatable):
        (WebCore::SVGElement::isSVG):
        (WebCore::SVGElement::isFilterEffect):
        (WebCore::SVGElement::isGradientStop):
        (WebCore::SVGElement::isTextContent):
        (WebCore::SVGElement::isValid):
        (WebCore::SVGElement::svgAttributeChanged):
        (WebCore::SVGElement::synchronizeProperty):
        (WebCore::SVGElement::supplementalTransform):
        (WebCore::SVGElement::invalidateSVGAttributes):
        (WebCore::SVGElement::rendererIsNeeded):
        (WebCore::SVGElement::needsPendingResourceHandling):
        (WebCore::SVGElement::buildPendingResource):
        * svg/SVGElementInstance.h:
        (WebCore::SVGElementInstance::create):
        (WebCore::SVGElementInstance::correspondingElement):
        (WebCore::SVGElementInstance::correspondingUseElement):
        (WebCore::SVGElementInstance::shadowTreeElement):
        (WebCore::SVGElementInstance::parentNode):
        (WebCore::SVGElementInstance::previousSibling):
        (WebCore::SVGElementInstance::nextSibling):
        (WebCore::SVGElementInstance::firstChild):
        (WebCore::SVGElementInstance::lastChild):
        (WebCore::SVGElementInstance::ownerDocument):
        (WebCore::SVGElementInstance::toNode):
        (WebCore::SVGElementInstance::toSVGElementInstance):
        (WebCore::SVGElementInstance::hasChildNodes):
        (WebCore::SVGElementInstance::setFirstChild):
        (WebCore::SVGElementInstance::setLastChild):
        (WebCore::SVGElementInstance::setNextSibling):
        (WebCore::SVGElementInstance::setPreviousSibling):
        (WebCore::SVGElementInstance::refEventTarget):
        (WebCore::SVGElementInstance::derefEventTarget):
        * svg/SVGElementInstanceList.h:
        (WebCore::SVGElementInstanceList::create):
        * svg/SVGException.h:
        (WebCore::SVGException::create):
        (WebCore::SVGException::SVGException):
        * svg/SVGFEColorMatrixElement.cpp:
        (WebCore::SVGFEColorMatrixElement::parseMappedAttribute):
        * svg/SVGFEComponentTransferElement.cpp:
        (WebCore::SVGFEComponentTransferElement::build):
        * svg/SVGFEDiffuseLightingElement.cpp:
        (WebCore::SVGFEDiffuseLightingElement::findLights):
        * svg/SVGFont.cpp:
        (WebCore::convertEmUnitToPixel):
        * svg/SVGUseElement.cpp:
        (WebCore::isDirectReference):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Andrei Popescu <andreip@google.com>
andreip@google.com [Wed, 22 Dec 2010 12:17:38 +0000 (12:17 +0000)]
2010-12-22  Andrei Popescu  <andreip@google.com>

        Unreviewed buildfix.

        [v8] trunk/LayoutTests/fast/js/large-expressions.html fails since r74402
        https://bugs.webkit.org/show_bug.cgi?id=51391

        * platform/chromium-mac/fast/js/large-expressions-expected.txt:
        * platform/chromium-win/fast/js/large-expressions-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Dai Mikurube <dmikurube@google.com>
commit-queue@webkit.org [Wed, 22 Dec 2010 11:38:33 +0000 (11:38 +0000)]
2010-12-22  Dai Mikurube  <dmikurube@google.com>

        Reviewed by Kent Tamura.

        https://bugs.webkit.org/show_bug.cgi?id=51289
        Initial state of checkValidity() and :invalid are incorrect with <select required>

        * fast/css/pseudo-valid-007-expected.txt:
        * fast/css/pseudo-valid-007.html:
        * fast/forms/checkValidity-002-expected.txt:
        * fast/forms/checkValidity-002.html:
2010-12-22  Dai Mikurube  <dmikurube@google.com>

        Reviewed by Kent Tamura.

        https://bugs.webkit.org/show_bug.cgi?id=51289
        Initial state of checkValidity() and :invalid are incorrect with <select required>

        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::childrenChanged): setNeedsValidityCheck() after <select>'s children change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Wed, 22 Dec 2010 11:05:23 +0000 (11:05 +0000)]
2010-12-22  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Joseph Pecoraro.

        Web Inspector: Styles pane fails to display properties from a broken CSS rule correctly
        https://bugs.webkit.org/show_bug.cgi?id=51405

        * inspector/styles-new-API-expected.txt:
        * inspector/styles-new-API.html:
2010-12-22  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Joseph Pecoraro.

        Web Inspector: Styles pane fails to display properties from a broken CSS rule correctly
        https://bugs.webkit.org/show_bug.cgi?id=51405

        Invoke markPropertyStart() after the parser has restored after an error.

        * css/CSSGrammar.y:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Gyuyoung Kim <gyuyoung.kim@samsung.com>
gyuyoung.kim@samsung.com [Wed, 22 Dec 2010 08:50:51 +0000 (08:50 +0000)]
2010-12-22  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Reviewed by Antonio Gomes.

        [EFL] Sets default user agent
        https://bugs.webkit.org/show_bug.cgi?id=47903

        Add macros for WebKit EFL and User Agent.

        * cmake/OptionsEfl.cmake:
        * cmakeconfig.h.cmake:
2010-12-22  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Reviewed by Antonio Gomes.

        [EFL] Sets default user agent
        https://bugs.webkit.org/show_bug.cgi?id=47903

        If applcation(e.g EWebLauncher) doesn't set user agent, WebKit EFL doesn't
        set user agent. However, we need to set user agent by default. Because, some
        web sites send different pages according to user agent.

        * ewk/ewk_private.h:
        * ewk/ewk_settings.cpp:
        (_ewk_settings_webkit_platform):
        (_ewk_settings_webkit_os_version):
        (ewk_settings_default_user_agent_get):
        * ewk/ewk_view.cpp:
        (_ewk_view_priv_new):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Dai Mikurube <dmikurube@google.com>
commit-queue@webkit.org [Wed, 22 Dec 2010 08:37:48 +0000 (08:37 +0000)]
2010-12-22  Dai Mikurube  <dmikurube@google.com>

        Reviewed by Kent Tamura.

        Assertion failure with <select multiple required>
        https://bugs.webkit.org/show_bug.cgi?id=51260

        * fast/forms/resources/select-live-pseudo-selectors.js:
        * fast/forms/select-live-pseudo-selectors-expected.txt:
2010-12-22  Dai Mikurube  <dmikurube@google.com>

        Reviewed by Kent Tamura.

        Assertion failure with <select multiple required>
        https://bugs.webkit.org/show_bug.cgi?id=51260

        Test: fast/css/pseudo-valid-select-click.html

        * dom/SelectElement.cpp: updateValidity() after selecting some options of ListBox-typed <select> elements to update valid() cache.
        (WebCore::SelectElement::updateListBoxSelection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed correction to unreviewed build fix for r74447.
darin@apple.com [Wed, 22 Dec 2010 07:16:32 +0000 (07:16 +0000)]
Unreviewed correction to unreviewed build fix for r74447.

Inappropriate code was left behind in sourceURI function for non-Dashboard platforms.

* html/HTMLImageLoader.cpp:
(WebCore::HTMLImageLoader::sourceURI): Change the logic so all the bug-workaround
logic is inside the #ifdef.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-21 Sheriff Bot <webkit.review.bot@gmail.com>
tonyg@chromium.org [Wed, 22 Dec 2010 06:20:06 +0000 (06:20 +0000)]
2010-12-21  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r74462.
        http://trac.webkit.org/changeset/74462
        https://bugs.webkit.org/show_bug.cgi?id=51449

        broke chromium win (Requested by tonyg-cr on #webkit).

        * JavaScriptCore.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-21 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 22 Dec 2010 05:58:31 +0000 (05:58 +0000)]
2010-12-21  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler.

        Include the shadow color space as part of the GraphicsContext state
        https://bugs.webkit.org/show_bug.cgi?id=51420

        Include the ColorSpace for the shadow color as part of the graphics
        state. This will be used later for a shadow implementation that
        does not rely on platform shadow code.

        * platform/graphics/GraphicsContext.cpp:
        (WebCore::GraphicsContext::setShadow):
        (WebCore::GraphicsContext::clearShadow):
        (WebCore::GraphicsContext::getShadow):
        * platform/graphics/GraphicsContext.h:
        (WebCore::GraphicsContextState::GraphicsContextState):
        * platform/graphics/chromium/FontChromiumWin.cpp:
        (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs):
        (WebCore::Font::drawComplexText):
        * platform/graphics/mac/FontMac.mm:
        (WebCore::Font::drawGlyphs):
        * platform/graphics/skia/SkiaFontWin.cpp:
        (WebCore::windowsCanHandleDrawTextShadow):
        * platform/graphics/win/FontCGWin.cpp:
        (WebCore::drawGDIGlyphs):
        (WebCore::Font::drawGlyphs):
        * platform/graphics/wince/GraphicsContextWinCE.cpp:
        (WebCore::GraphicsContext::fillRoundedRect):
        (WebCore::GraphicsContext::drawText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-21 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Wed, 22 Dec 2010 05:56:00 +0000 (05:56 +0000)]
2010-12-21  Tony Gentilcore  <tonyg@chromium.org>

        Unreviewed build fix.

        [chromium] Build fix after r74431
        https://bugs.webkit.org/show_bug.cgi?id=51447

        * JavaScriptCore.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@74462 268f45cc-cd09-0410-ab3c-d52691b4dbfc