WebKit-https.git
16 years ago Reviewed by Eric.
thatcher [Fri, 15 Sep 2006 22:01:14 +0000 (22:01 +0000)]
    Reviewed by Eric.

        Remove the SVG IDL files from the Copy Resources phase.

        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-09-15 Anders Carlsson <acarlsson@apple.com>
andersca [Fri, 15 Sep 2006 21:52:16 +0000 (21:52 +0000)]
2006-09-15  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Steve.

        Add JavaScriptCore API to the build.
        * API/JSBase.cpp:
        * API/JSCallbackConstructor.cpp:
        * API/JSCallbackFunction.cpp:
        * API/JSCallbackObject.cpp:
        * API/JSClassRef.cpp:
        * API/JSContextRef.cpp:
        * API/JSObjectRef.cpp:
        * API/JSStringRef.cpp:
        * API/JSValueRef.cpp:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * os-win32/stdbool.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago - just layout test result changes
kmccullo [Fri, 15 Sep 2006 18:09:18 +0000 (18:09 +0000)]
    - just layout test result changes

        * fast/dom/Range/range-compareNode-expected.txt:
        * fast/dom/Range/range-intersectsNode-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Eric Siedel
beidson [Fri, 15 Sep 2006 09:38:34 +0000 (09:38 +0000)]
    Reviewed by Eric Siedel

        Dumped the use of CGColorRef and directly use the floating point data from
        WebCore::Color

        This fixes the performance regression found between 16285 and 16286

        * platform/mac/FontMac.mm:
        (WebCore::Font::drawComplexText):
        (WebCore::Font::drawGlyphs):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-09-14 Mark Rowe <opendarwin.org@bdash.net.nz>
bdash [Fri, 15 Sep 2006 06:09:02 +0000 (06:09 +0000)]
2006-09-14  Mark Rowe  <opendarwin.org@bdash.net.nz>

        Reviewed by Adam.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=10838
        Bug 10838: REGRESSION: Leaking of WebScriptObjectPrivate

        FrameMac relies on its cleanupPluginObjects being called to perform cleanup.  The virtual
        Frame::cleanupPluginObjects method is called from Frame's destructor, which results
        in Frame::cleanupPluginObjects being called rather than FrameMac::cleanupPluginObjects.

        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::~FrameMac): Call cancelAndClear to ensure that FrameMac::cleanupPluginObjects
        will be called from Frame::clear
        * page/Frame.cpp:
        (WebCore::Frame::~Frame): Use cancelAndClear.
        (WebCore::Frame::cancelAndClear): Move cancellation and clearing into a separate method that
        FrameMac can use.
        * page/Frame.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Maciej's rubber stamp
beidson [Thu, 14 Sep 2006 23:44:33 +0000 (23:44 +0000)]
    Reviewed by Maciej's rubber stamp

        Exact same fix I just made, but in the other method I horked up
        Also added a reference to the bugzilla in comments

        * page/Frame.cpp:
        (WebCore::Frame::endIfNotLoading):
        (WebCore::Frame::stop):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Maciej
beidson [Thu, 14 Sep 2006 22:58:15 +0000 (22:58 +0000)]
    Reviewed by Maciej

        Fixed a bad iFrame crash, resolving some of the layout test badness

        * page/Frame.cpp:
        (WebCore::Frame::endIfNotLoading):
        - Added a RefPtr to protect the frame itself to prevent its destruction during this method

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
justing [Thu, 14 Sep 2006 19:52:27 +0000 (19:52 +0000)]
LayoutTests:

        Reviewed by harrison

        <rdar://problem/4655880> Up/Down arrows skip over To Do

        * editing/selection/mixed-editability-3-expected.checksum: Added.
        * editing/selection/mixed-editability-3-expected.png: Added.
        * editing/selection/mixed-editability-3-expected.txt: Added.
        * editing/selection/mixed-editability-3.html: Added.
        * editing/selection/mixed-editability-4-expected.checksum: Added.
        * editing/selection/mixed-editability-4-expected.png: Added.
        * editing/selection/mixed-editability-4-expected.txt: Added.
        * editing/selection/mixed-editability-4.html: Added.
        * editing/selection/mixed-editability-5-expected.checksum: Added.
        * editing/selection/mixed-editability-5-expected.png: Added.
        * editing/selection/mixed-editability-5-expected.txt: Added.
        * editing/selection/mixed-editability-5.html: Added.

WebCore:

        Reviewed by harrison

        <rdar://problem/4655880> Up/Down arrows skip over To Do

        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge canDeleteRange:]): Added a FIXME.
        * dom/Node.cpp: Removed the unused inSameRootEditableElement.
        * dom/Node.h:
        * editing/SelectionController.cpp:
        (WebCore::SelectionController::modify): Added documentboundary to granularities in order test a fix.
        * editing/visible_units.cpp:
        (WebCore::previousLinePosition): Use highestEditableRoot so that this function can move from
        editable content into editable content that's embedded in non-editable content.
        (WebCore::nextLinePosition): Ditto.
        (WebCore::startOfEditableContent): Renamed from startOfEditableRoot and use highestEditableRoot.
        This is the behavior that callers desire.  This fixes Command + Up/Down.
        (WebCore::endOfEditableContent): Ditto.
        * editing/visible_units.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-09-14 Karthik Kumar <karthikkumar@gmail.com>
aroben [Thu, 14 Sep 2006 17:07:02 +0000 (17:07 +0000)]
2006-09-14  Karthik Kumar  <karthikkumar@gmail.com>

        Reviewed by timothy. Landed by aroben.

        Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10856
        Windows build fixes after r16360

        * WebCore.vcproj/WebCore/WebCore.vcproj: Add loader\icon to
        AdditionalIncludeDirectories
        * platform/win/TemporaryLinkStubs.cpp: Add link stubs for IconLoader,
        IconDatabase
        (IconLoader::stopLoading):
        (IconLoader::startLoading):
        (IconLoader::createForFrame):
        (IconDatabase::isIconExpiredForIconURL):
        (IconDatabase::hasEntryForIconURL):
        (IconDatabase::sharedIconDatabase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoPart of a build fix - rest will be filling in some temporary link stubs
beidson [Thu, 14 Sep 2006 09:00:39 +0000 (09:00 +0000)]
Part of a build fix - rest will be filling in some temporary link stubs

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-09-14 Graham Dennis <graham.dennis@gmail.com>
bdash [Thu, 14 Sep 2006 08:08:33 +0000 (08:08 +0000)]
2006-09-14  Graham Dennis  <graham.dennis@gmail.com>

        Reviewed by Justin Garcia.

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=10726
          Crash in ApplyStyleCommand::applyRelativeFontStyleChange

        * editing/ApplyStyleCommand.cpp:
        (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): Prevent a crash by
        makeing sure that the 'beyondEnd' node is after the start node.

2006-09-14  Graham Dennis  <graham.dennis@gmail.com>

        Reviewed by Justin Garcia.

        Modified testcase for:
        http://bugzilla.opendarwin.org/show_bug.cgi?id=10726
        Crash in ApplyStyleCommand::applyRelativeFontStyleChange

        * editing/style/table-selection-expected.checksum:
        * editing/style/table-selection-expected.png:
        * editing/style/table-selection-expected.txt:
        * editing/style/table-selection.html:
        This testcase was for 10579, which is very similar to this bug (10726)
        Now the testcase tests both bugs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-09-14 MorganL <morlmor@yahoo.com>
bdash [Thu, 14 Sep 2006 07:29:13 +0000 (07:29 +0000)]
2006-09-14  MorganL  <morlmor@yahoo.com>

        Reviewed by Brady.

        Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10845
        Various bugs/crashes in ResourceLoaderWin with local files.

        * platform/ResourceLoaderInternal.h:
        (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
        * platform/win/ResourceLoaderWin.cpp:
        (WebCore::ResourceLoaderInternal::~ResourceLoaderInternal):
        (WebCore::ResourceLoader::fileLoadTimer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoWebCore:
beidson [Thu, 14 Sep 2006 07:20:47 +0000 (07:20 +0000)]
WebCore:

        Reviewed by Maciej

        Icon loads now take place in WebCore

        * WebCore.xcodeproj/project.pbxproj:
        * bridge/BrowserExtension.h:
        * bridge/mac/BrowserExtensionMac.h:
        * bridge/mac/BrowserExtensionMac.mm:
        - Moved enforcement of a Mozilla Favicon extension elsewhere

        * bridge/mac/FrameMac.h:
        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::originalRequestURL):
        - Added accessor to "original request URL"

        * bridge/mac/WebCoreFrameBridge.h:
        - Removed methods to set the iconURL as all loading is now done in WebCore
        - Added call throughs to notify WebKit an Icon is done loading, and a to get the original request URL

        * html/HTMLLinkElement.cpp:
        (WebCore::HTMLLinkElement::process):
        - Moved enforcement of a Mozilla Favicon extension elsewhere

        * loader/icon/IconDatabase.cpp:
        (WebCore::IconDatabase::setIconURLForPageURL):
        - Changed an ASSERT to correctly handle a sketchy (invalid) situation

        * loader/icon/IconLoader.h: Added.
        * loader/icon/IconLoader.cpp: Added.
        (IconLoader::IconLoader):
        (IconLoader::createForFrame):
        - Static factory method with a private constructor to enforce
          "you MUST have a Frame to create an IconLoader" semantics
        (IconLoader::~IconLoader):
        (IconLoader::startLoading):
        (IconLoader::stopLoading):
        (IconLoader::receivedData):
        - ResourceLoaderClient delegate
        (IconLoader::receivedAllData):
        - Ditto

        * loader/mac/IconLoaderMac.mm: Added.
        (IconLoader::receivedResponse):
        (IconLoader::notifyIconChanged):
        - For now, these are platform specific methods
        - One to get the HTTP response code of an icon load
        - The other to call through to the app when the icon has changed (loaded)

        * page/Frame.h:
        * page/Frame.cpp:
        (WebCore::Frame::iconURL):
        (WebCore::Frame::setIconURL):
        - Frame objects now have an inherent icon URL and a way to calculate/access it
        (WebCore::Frame::endIfNotLoading):
        - This is where we actually kick off the IconLoader
        (WebCore::Frame::stop):
        - Added call to stop loading the icon

        * page/FramePrivate.h:
        (WebCore::FramePrivate::FramePrivate):
        (WebCore::FramePrivate::~FramePrivate):
        - Added the icon URL as a private member
        - Added the IconLoader as a private member, and clean it up on deletion

        * platform/mac/ResourceLoaderMac.mm:
        (WebCore::ResourceLoader::start):  Added a valuable ASSERT

WebKit:

        Reviewed by Maciej

        Add infrastructure to support icon loads taking place in WebCore
        Will remove WebKit icon loaders in a later patch

        * WebCoreSupport/WebFrameBridge.m:
        (-[WebFrameBridge notifyIconChanged:]):
        (-[WebFrameBridge originalRequestURL]):
        - Nuked two old, obsolete methods
        - Added bridge for notifying of an icon change
        - Added bridge for getting the "original request URL" which is still needed
          until that info is available in the WebCore loaders

        * WebView/WebDataSource.m:
        (-[WebDataSource _loadIcon]):
        - Empty body just for now, as it still gets called - next patch will prune all the old impl out

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Fix for 10841, unable to check checkboxes inside labels.
hyatt [Thu, 14 Sep 2006 07:01:48 +0000 (07:01 +0000)]
    Fix for 10841, unable to check checkboxes inside labels.

        Reviewed by xenon, bradee-oh

        * css/html4.css:
        * dom/Element.cpp:
        (WebCore::Element::contains):
        * dom/Element.h:
        * html/HTMLLabelElement.cpp:
        (WebCore::HTMLLabelElement::defaultEventHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-09-13 Mark Rowe <opendarwin.org@bdash.net.nz>
bdash [Thu, 14 Sep 2006 05:03:29 +0000 (05:03 +0000)]
2006-09-13  Mark Rowe  <opendarwin.org@bdash.net.nz>

        Reviewed by Adam.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=10834
        Bug 10834: FileChooser constructor in FileChooserMac appears to overretain m_controller

        * platform/mac/FileChooserMac.mm:
        (WebCore::FileChooser::FileChooser): Don't over-retain the OpenPanelController.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Rubberstamped by hyatt.
aroben [Thu, 14 Sep 2006 04:47:34 +0000 (04:47 +0000)]
    Rubberstamped by hyatt.

        Updating tables results after hyatt landed a fix for
        http://bugzilla.opendarwin.org/show_bug.cgi?id=8126
        Padding must not apply to columns

        * tables/mozilla/bugs/bug139524-2-expected.txt:
        * tables/mozilla/bugs/bug139524-4-expected.txt:
        * tables/mozilla/bugs/bug32841-expected.txt:
        * tables/mozilla/dom/appendCol2-expected.txt:
        * tables/mozilla/dom/deleteCol1-expected.txt:
        * tables/mozilla/dom/deleteCol2-expected.txt:
        * tables/mozilla/dom/deleteCol3-expected.txt:
        * tables/mozilla/dom/deleteColGroup1-expected.txt:
        * tables/mozilla/dom/deleteColGroup2-expected.txt:
        * tables/mozilla/dom/insertColGroups1-expected.txt:
        * tables/mozilla/dom/insertColGroups2-expected.txt:
        * tables/mozilla/dom/insertCols1-expected.txt:
        * tables/mozilla/dom/insertCols2-expected.txt:
        * tables/mozilla/dom/insertCols3-expected.txt:
        * tables/mozilla/dom/insertCols4-expected.txt:
        * tables/mozilla/dom/insertCols5-expected.txt:
        * tables/mozilla/marvin/body_col-expected.txt:
        * tables/mozilla/marvin/x_col_span-expected.txt:
        * tables/mozilla/marvin/x_col_width_px-expected.txt:
        * tables/mozilla/marvin/x_colgroup_span-expected.txt:
        * tables/mozilla/other/body_col-expected.txt:
        * tables/mozilla_expected_failures/bugs/bug1128-expected.txt:
        * tables/mozilla_expected_failures/bugs/bug29058-2-expected.txt:
        * tables/mozilla_expected_failures/bugs/bug45621-expected.txt:
        * tables/mozilla_expected_failures/bugs/bug7243-expected.txt:
        * tables/mozilla_expected_failures/core/cols1-expected.txt:
        * tables/mozilla_expected_failures/dom/appendCol1-expected.txt:
        * tables/mozilla_expected_failures/dom/appendColGroup1-expected.txt:
        * tables/mozilla_expected_failures/other/test4-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-09-13 Mark Rowe <opendarwin.org@bdash.net.nz>
bdash [Thu, 14 Sep 2006 04:41:51 +0000 (04:41 +0000)]
2006-09-13  Mark Rowe  <opendarwin.org@bdash.net.nz>

        Reviewed by Eric.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=10836
        Bug 10836: REGRESSION: Mac implementation of Font::drawGlyphs leaks a CGColorRef

        * platform/mac/FontMac.mm:
        (WebCore::Font::drawComplexText): Release CGColorRef after use.
        (WebCore::Font::drawGlyphs): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-09-14 Anders Carlsson <acarlsson@apple.com>
andersca [Thu, 14 Sep 2006 02:27:13 +0000 (02:27 +0000)]
2006-09-14  Anders Carlsson  <acarlsson@apple.com>

        Try fixing the Win32 build.

        * bridge/win/FrameWin.h:
        * platform/win/TemporaryLinkStubs.cpp:
        (FrameWin::bindingRootObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-09-12 Steve Falkenburg <sfalken@apple.com>
sfalken [Thu, 14 Sep 2006 01:59:26 +0000 (01:59 +0000)]
2006-09-12  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Ada.

        Build tweaks (doing JavaScriptCore now since it doesn't have
        dependencies).

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.vcproj/JavaScriptCore/build-generated-files.sh:
        * JavaScriptCore.vcproj/JavaScriptCore/dstroot-to-sdk.cmd: Added.
        * JavaScriptCore.vcproj/dftables/dftables.vcproj:
        * JavaScriptCore.vcproj/testkjs/testkjs.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-09-14 Anders Carlsson <acarlsson@apple.com>
andersca [Thu, 14 Sep 2006 01:56:44 +0000 (01:56 +0000)]
2006-09-14  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Tim O.

        Add USE defines for the generic JavaScriptCore bindings as well as NPAPI bindings.

        * bindings/js/kjs_binding.cpp:
        (KJS::ScriptInterpreter::createLanguageInstanceForValue):
        * bindings/js/kjs_dom.cpp:
        (KJS::getRuntimeObject):
        * bridge/mac/FrameMac.h:
        * config.h:
        * html/HTMLAppletElement.cpp:
        (WebCore::HTMLAppletElement::~HTMLAppletElement):
        (WebCore::HTMLAppletElement::detach):
        * html/HTMLAppletElement.h:
        * html/HTMLEmbedElement.cpp:
        (WebCore::HTMLEmbedElement::~HTMLEmbedElement):
        (WebCore::HTMLEmbedElement::detach):
        * html/HTMLEmbedElement.h:
        * html/HTMLObjectElement.cpp:
        (WebCore::HTMLObjectElement::~HTMLObjectElement):
        (WebCore::HTMLObjectElement::detach):
        * html/HTMLObjectElement.h:
        * html/HTMLPlugInElement.cpp:
        (WebCore::HTMLPlugInElement::HTMLPlugInElement):
        (WebCore::HTMLPlugInElement::~HTMLPlugInElement):
        (WebCore::HTMLPlugInElement::createNPObject):
        * html/HTMLPlugInElement.h:
        * page/Frame.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Tim O.
thatcher [Wed, 13 Sep 2006 22:18:03 +0000 (22:18 +0000)]
    Reviewed by Tim O.

        <rdar://problem/4726416> obsolete confusing "ADVISORY NOTE" comment in WebHistory.h

        Removed the "ADVISORY NOTE: This method may change for the 1.0 SDK" comments.

        * History/WebHistory.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Clean up the XBL and XSLT ifdefs to be consistent with the SVG
hyatt [Wed, 13 Sep 2006 22:10:25 +0000 (22:10 +0000)]
    Clean up the XBL and XSLT ifdefs to be consistent with the SVG
        and XPath ifdefs.  KHTML_NO_XBL is flipped and is now XBL_SUPPORT.
        KHTML_XSLT is now XSLT_SUPPORT.

        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSXSLTProcessor.cpp:
        * bindings/js/JSXSLTProcessor.h:
        * bindings/js/kjs_window.cpp:
        (KJS::Window::getValueProperty):
        * config.h:
        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
        * css/cssparser.cpp:
        (WebCore::CSSParser::parseValue):
        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):
        * dom/Document.cpp:
        (WebCore::Document::Document):
        (WebCore::Document::~Document):
        (WebCore::Document::recalcStyleSelector):
        * dom/Document.h:
        (WebCore::Document::bindingManager):
        * dom/Node.cpp:
        (WebCore::Node::createRendererIfNeeded):
        * dom/ProcessingInstruction.cpp:
        (WebCore::ProcessingInstruction::ProcessingInstruction):
        (WebCore::ProcessingInstruction::checkStyleSheet):
        (WebCore::ProcessingInstruction::setStyleSheet):
        * dom/ProcessingInstruction.h:
        * dom/XMLTokenizer.cpp:
        (WebCore::XMLTokenizer::processingInstruction):
        (WebCore::XMLTokenizer::insertErrorMessageBlock):
        * dom/XMLTokenizer.h:
        * loader/Cache.cpp:
        (WebCore::Cache::getStatistics):
        * loader/Cache.h:
        * loader/CachedResource.h:
        (WebCore::CachedResource::):
        * loader/CachedResourceClient.h:
        * loader/CachedXBLDocument.cpp:
        * loader/CachedXBLDocument.h:
        * loader/CachedXSLStyleSheet.cpp:
        * loader/CachedXSLStyleSheet.h:
        * loader/DocLoader.cpp:
        * loader/DocLoader.h:
        * rendering/RenderStyle.cpp:
        (WebCore::StyleCSS3NonInheritedData::StyleCSS3NonInheritedData):
        (WebCore::StyleCSS3NonInheritedData::~StyleCSS3NonInheritedData):
        (WebCore::StyleCSS3NonInheritedData::operator==):
        * rendering/RenderStyle.h:
        * xml/XSLImportRule.cpp:
        * xml/XSLImportRule.h:
        * xml/XSLStyleSheet.cpp:
        * xml/XSLStyleSheet.h:
        * xml/XSLTProcessor.cpp:
        * xml/XSLTProcessor.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-09-13 Nikolas Zimmermann <zimmermann@kde.org>
eseidel [Wed, 13 Sep 2006 22:07:23 +0000 (22:07 +0000)]
2006-09-13  Nikolas Zimmermann  <zimmermann@kde.org>

        Reviewed by eseidel.  Landed by eseidel.

        Fix newly introduced memory leaks in SVG.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=10835

        * ksvg2/svg/SVGList.h:
        (WebCore::SVGListBase::~SVGListBase):
        (WebCore::SVGListBase::clearVector):
        (WebCore::SVGListBase::clear):
        (WebCore::SVGList::clearVector):
        (WebCore::):
        * ksvg2/svg/SVGNumberList.cpp: s/float/double/ - forgot that!
        (SVGNumberList::SVGNumberList):
        * ksvg2/svg/SVGNumberList.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-09-13 MorganL <morlmor@yahoo.com>
aroben [Wed, 13 Sep 2006 18:37:25 +0000 (18:37 +0000)]
2006-09-13  MorganL  <morlmor@yahoo.com>

        Reviewed/landed by aroben.

        Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10833
        Windows build needs fixed after move to engine-rendered file upload widget

        * WebCore.vcproj/WebCore/WebCore.vcproj: Add RenderFileUpload files,
        remove RenderFileButton files
        * platform/win/TemporaryLinkStubs.cpp: Add stubs for FileChooser, Icon
        (FileChooser::FileChooser):
        (FileChooser::~FileChooser):
        (FileChooser::openFileChooser):
        (FileChooser::basenameForWidth):
        (FileChooser::uploadControlDetaching):
        (FileChooser::chooseFile):
        (WebCore::fileButtonChooseFileLabel):
        (WebCore::fileButtonNoFileSelectedLabel):
        (Icon::Icon):
        (Icon::~Icon):
        (Icon::newIconForFile):
        (Icon::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-09-13 MorganL <morlmor@yahoo.com>
aroben [Wed, 13 Sep 2006 18:15:19 +0000 (18:15 +0000)]
2006-09-13  MorganL  <morlmor@yahoo.com>

        Reviewed/landed by aroben.

        Fixes http://bugzilla.opendarwin.org/attachment.cgi?id=10537
        Webkit WebCore build fails on Windows

        * WebCore.vcproj/WebCore/build-generated-files.sh: export SOURCE_ROOT
        variable

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoForgot these added files.
thatcher [Wed, 13 Sep 2006 16:16:51 +0000 (16:16 +0000)]
Forgot these added files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Tim H.
thatcher [Wed, 13 Sep 2006 16:12:42 +0000 (16:12 +0000)]
    Reviewed by Tim H.

        Fix Qt/Linux build.

        * CMakeLists.txt: Change SVGZoomEvent.idl location & add RenderFileUploadControl
        * platform/Icon.h: Add wtf/Platform.h include
        * platform/qt/FileChooserQt.cpp: Added as stub. Easy to implement though.
        (WebCore::FileChooser::FileChooser):
        (WebCore::FileChooser::~FileChooser):
        (WebCore::FileChooser::openFileChooser):
        (WebCore::FileChooser::basenameForWidth):
        (WebCore::FileChooser::uploadControlDetaching):
        (WebCore::FileChooser::chooseFile):
        * platform/qt/IconQt.cpp: Added as stub.
        (WebCore::Icon::Icon):
        (WebCore::Icon::~Icon):
        (WebCore::Icon::newIconForFile):
        (WebCore::Icon::paint):
        * platform/qt/TemporaryLinkStubs.cpp: Remove old RenderFileButton code & some new *Labels needed
        (searchableIndexIntroduction):
        (fileButtonChooseFileLabel):
        (fileButtonNoFileSelectedLabel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by eseidel.
aroben [Wed, 13 Sep 2006 07:08:39 +0000 (07:08 +0000)]
    Reviewed by eseidel.

        Switch back to passing relative paths to generate-bindings.pl when
        generating JS bindings.

        * DerivedSources.make: Pass in relative paths to generate-bindings.pl
        * bindings/scripts/CodeGenerator.pm: Make ScanDirectory never call
        chdir and always construct absolute paths instead.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Fix for bug 3244, implement html4 label support.
hyatt [Wed, 13 Sep 2006 06:23:56 +0000 (06:23 +0000)]
    Fix for bug 3244, implement html4 label support.

        Reviewed by mjs, aroben

        Added fast/events/label-focus.html

        * css/html4.css:
        * html/HTMLLabelElement.cpp:
        (WebCore::HTMLLabelElement::formElement):
        (WebCore::HTMLLabelElement::setActive):
        (WebCore::HTMLLabelElement::setHovered):
        (WebCore::HTMLLabelElement::defaultEventHandler):
        * html/HTMLLabelElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoNew label layout test.
hyatt [Wed, 13 Sep 2006 06:20:19 +0000 (06:20 +0000)]
New label layout test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-09-12 Julien Palmas <julien.palmas@gmail.com>
eseidel [Wed, 13 Sep 2006 05:37:00 +0000 (05:37 +0000)]
2006-09-12  Julien Palmas  <julien.palmas@gmail.com>

        Reviewed by darin.  Landed by eseidel.

        * ksvg2/svg/svgpathparser.cpp:
        (WebCore::SVGPolyParser::parsePoints):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
kmccullo [Wed, 13 Sep 2006 01:28:11 +0000 (01:28 +0000)]
LayoutTests:

        Reviewed by Andersca, Maciej, Brady.

        * fast/dom/Range/range-intersectsNode-expected.txt: Added.
        * fast/dom/Range/range-intersectsNode.html: Added.
        * fast/dom/Range/resources/intersectsNode.js: Added.

WebCore:

        Reviewed by Andersca, Maciej, Brady.

        - Implemented intersectsNode in the Range Class
          to be compliant with Mozilla standard

        * dom/Range.cpp:
        (WebCore::Range::intersectsNode):
        * dom/Range.h:
        * dom/Range.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-09-12 Nikolas Zimmermann <zimmermann@kde.org>
eseidel [Wed, 13 Sep 2006 01:18:41 +0000 (01:18 +0000)]
2006-09-12  Nikolas Zimmermann  <zimmermann@kde.org>

        Reviewed by eseidel.  Landed by eseidel.

        Test: svg/W3C-SVG-1.1/struct-dom-01-b.svg (fixed)
Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=10826
        Also finally fixes some long outstanding bugs:
Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=9190
Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=9229
Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=10413
        Enable all JavaScript SVG bindings. Builds on Qt/Linux & OSX.

        * CMakeLists.txt:
        * DerivedSources.make:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/scripts/CodeGenerator.pm:
        * bindings/scripts/CodeGeneratorJS.pm:
        * ksvg2/bindings/js/JSSVGElementWrapperFactory.cpp:
        * ksvg2/svg/SVGAElement.idl: Added.
        * ksvg2/svg/SVGAngle.idl:
        * ksvg2/svg/SVGAnimateColorElement.idl: Added.
        * ksvg2/svg/SVGAnimateElement.idl: Added.
        * ksvg2/svg/SVGAnimateTransformElement.idl: Added.
        * ksvg2/svg/SVGAnimatedLengthList.idl: Added.
        * ksvg2/svg/SVGAnimatedNumberList.idl: Added.
        * ksvg2/svg/SVGAnimatedTransformList.idl: Added.
        * ksvg2/svg/SVGAnimationElement.idl: Added.
        * ksvg2/svg/SVGCircleElement.idl: Added.
        * ksvg2/svg/SVGClipPathElement.idl: Added.
        * ksvg2/svg/SVGColor.idl:
        * ksvg2/svg/SVGComponentTransferFunctionElement.idl: Added.
        * ksvg2/svg/SVGCursorElement.idl: Added.
        * ksvg2/svg/SVGDefsElement.idl: Added.
        * ksvg2/svg/SVGDescElement.idl: Added.
        * ksvg2/svg/SVGEllipseElement.idl: Added.
        * ksvg2/svg/SVGEvent.idl:
        * ksvg2/svg/SVGExternalResourcesRequired.idl: Added.
        * ksvg2/svg/SVGFEBlendElement.idl: Added.
        * ksvg2/svg/SVGFEColorMatrixElement.idl: Added.
        * ksvg2/svg/SVGFEComponentTransferElement.idl: Added.
        * ksvg2/svg/SVGFECompositeElement.idl: Added.
        * ksvg2/svg/SVGFEDiffuseLightingElement.idl: Added.
        * ksvg2/svg/SVGFEDisplacementMapElement.idl: Added.
        * ksvg2/svg/SVGFEDistantLightElement.idl: Added.
        * ksvg2/svg/SVGFEFloodElement.idl: Added.
        * ksvg2/svg/SVGFEFuncAElement.idl: Added.
        * ksvg2/svg/SVGFEFuncBElement.idl: Added.
        * ksvg2/svg/SVGFEFuncGElement.idl: Added.
        * ksvg2/svg/SVGFEFuncRElement.idl: Added.
        * ksvg2/svg/SVGFEGaussianBlurElement.idl: Added.
        * ksvg2/svg/SVGFEImageElement.idl: Added.
        * ksvg2/svg/SVGFEMergeElement.idl: Added.
        * ksvg2/svg/SVGFEMergeNodeElement.idl: Added.
        * ksvg2/svg/SVGFEOffsetElement.idl: Added.
        * ksvg2/svg/SVGFEPointLightElement.idl: Added.
        * ksvg2/svg/SVGFESpecularLightingElement.idl: Added.
        * ksvg2/svg/SVGFESpotLightElement.idl: Added.
        * ksvg2/svg/SVGFETileElement.idl: Added.
        * ksvg2/svg/SVGFETurbulenceElement.idl: Added.
        * ksvg2/svg/SVGFilterElement.idl: Added.
        * ksvg2/svg/SVGFilterPrimitiveStandardAttributes.idl: Added.
        * ksvg2/svg/SVGFitToViewBox.idl: Added.
        * ksvg2/svg/SVGForeignObjectElement.idl: Added.
        * ksvg2/svg/SVGGElement.idl: Added.
        * ksvg2/svg/SVGGradientElement.idl: Added.
        * ksvg2/svg/SVGImageElement.idl: Added.
        * ksvg2/svg/SVGLangSpace.idl: Added.
        * ksvg2/svg/SVGLength.idl:
        * ksvg2/svg/SVGLengthList.idl: Added.
        * ksvg2/svg/SVGLineElement.idl: Added.
        * ksvg2/svg/SVGLinearGradientElement.idl: Added.
        * ksvg2/svg/SVGLocatable.idl: Added.
        * ksvg2/svg/SVGMarkerElement.idl: Added.
        * ksvg2/svg/SVGMaskElement.idl: Added.
        * ksvg2/svg/SVGNumberList.idl: Added.
        * ksvg2/svg/SVGPaint.idl: Added.
        * ksvg2/svg/SVGPathElement.idl:
        * ksvg2/svg/SVGPathSeg.idl:
        * ksvg2/svg/SVGPatternElement.idl: Added.
        * ksvg2/svg/SVGPointList.idl: Added.
        * ksvg2/svg/SVGPolygonElement.idl: Added.
        * ksvg2/svg/SVGPolylineElement.idl: Added.
        * ksvg2/svg/SVGPreserveAspectRatio.idl:
        * ksvg2/svg/SVGRadialGradientElement.idl: Added.
        * ksvg2/svg/SVGRectElement.idl: Added.
        * ksvg2/svg/SVGRenderingIntent.idl: Added.
        * ksvg2/svg/SVGSVGElement.idl:
        * ksvg2/svg/SVGScriptElement.idl: Added.
        * ksvg2/svg/SVGSetElement.idl: Added.
        * ksvg2/svg/SVGStopElement.idl: Added.
        * ksvg2/svg/SVGStringList.idl: Added.
        * ksvg2/svg/SVGStylable.idl: Added.
        * ksvg2/svg/SVGStyleElement.idl: Added.
        * ksvg2/svg/SVGSwitchElement.idl: Added.
        * ksvg2/svg/SVGSymbolElement.idl: Added.
        * ksvg2/svg/SVGTRefElement.idl: Added.
        * ksvg2/svg/SVGTSpanElement.idl: Added.
        * ksvg2/svg/SVGTests.idl: Added.
        * ksvg2/svg/SVGTextContentElement.idl: Added.
        * ksvg2/svg/SVGTextElement.idl: Added.
        * ksvg2/svg/SVGTextPositioningElement.idl: Added.
        * ksvg2/svg/SVGTitleElement.idl: Added.
        * ksvg2/svg/SVGTransform.idl:
        * ksvg2/svg/SVGTransformList.idl: Added.
        * ksvg2/svg/SVGTransformable.idl: Added.
        * ksvg2/svg/SVGURIReference.idl: Added.
        * ksvg2/svg/SVGUnitTypes.idl: Added.
        * ksvg2/svg/SVGUseElement.idl: Added.
        * ksvg2/svg/SVGViewElement.idl: Added.
        * ksvg2/svg/SVGZoomAndPan.idl: Added.
        * ksvg2/svg/SVGZoomEvent.idl: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by timo, ggaren.
aroben [Wed, 13 Sep 2006 00:25:14 +0000 (00:25 +0000)]
    Reviewed by timo, ggaren.

        Make Icon ref-counted.

        * platform/FileChooser.h: Store m_icon as a RefPtr instead of
        auto_ptr.
        * platform/Icon.h: Inherit from Shared<Icon>
        * platform/mac/FileChooserMac.mm:
        (WebCore::FileChooser::chooseFile): Update m_icon usage
        * platform/mac/IconMac.mm:
        (WebCore::Icon::newIconForFile): Return a RefPtr instead of an
        auto_ptr

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoFixing the versioning.
thatcher [Tue, 12 Sep 2006 23:57:26 +0000 (23:57 +0000)]
Fixing the versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoVersioning
thatcher [Tue, 12 Sep 2006 22:26:08 +0000 (22:26 +0000)]
Versioning

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Anders.
rwlbuis [Tue, 12 Sep 2006 21:19:26 +0000 (21:19 +0000)]
    Reviewed by Anders.

        Add exception codes to SVGList functions, adjust all code using it.

        Move SVGPaintType enums from ksvg.h into SVGPaint (needed for js generation)
        Move SVGUnitTypes enums from ksvg.h into it's own file SVGUnitType.h (ditto)
        Move SVGRenderingIntent enums from ksvg.h into it's own file SVGRenderingIntent.h (ditto)
        Move SVGZoomAndPan enums from ksvg.h into SVGSVGElement (ditto)
        Move SVGFE* related enums into their respecitive classes.

        Fix JSSVGNumber to operator on doubles, instead of floats.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Adele Peterson.
sullivan [Tue, 12 Sep 2006 21:11:12 +0000 (21:11 +0000)]
    Reviewed by Adele Peterson.

        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::doTextFieldCommandFromEvent):
        Don't call textField:doCommandBySelector: with a nil selector. This was indirectly causing a
        (valid) assertion failure in some Safari code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by John Sullivan.
harrison [Tue, 12 Sep 2006 21:09:55 +0000 (21:09 +0000)]
    Reviewed by John Sullivan.

        <rdar://problem/4717841> Setting AXFocused to true does not activate the insertion point in text field

        * bridge/mac/WebCoreAXObject.mm:
        (-[WebCoreAXObject accessibilitySetValue:forAttribute:]):
        For AXFocus, use focus() if the node is an element, so that selection is set.
        Matches tabbing behavior in text fields and text areas.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoBuild fix for the the no-svg bot.
thatcher [Tue, 12 Sep 2006 20:59:22 +0000 (20:59 +0000)]
Build fix for the the no-svg bot.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by adele.
aroben [Tue, 12 Sep 2006 20:57:09 +0000 (20:57 +0000)]
    Reviewed by adele.

        Make uploading work with the new file upload control.

        * css/html4.css: Remove unnecessary style (this is already done in
        RenderFileUpload.cpp)
        * html/HTMLInputElement.cpp: Don't get the button text from the value
        attribute for file controls.
        (WebCore::HTMLInputElement::valueWithDefault):
        * platform/mac/FileChooserMac.mm: Call
        RenderFileUploadControl::valueChanged when the user selects a file.
        (WebCore::FileChooser::chooseFile):
        * rendering/RenderFileUploadControl.cpp: Add valueChanged() method to
        update the form and fire the onChange event.
        (WebCore::RenderFileUploadControl::valueChanged):
        (WebCore::RenderFileUploadControl::updateFromElement):
        * rendering/RenderFileUploadControl.h: Add valueChanged() declaration.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Adding rules to html4.css to style the button in file upload controls.
aroben [Tue, 12 Sep 2006 19:59:32 +0000 (19:59 +0000)]
    Adding rules to html4.css to style the button in file upload controls.

        * css/html4.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed many times by darin, hyatt.
aroben [Tue, 12 Sep 2006 19:42:41 +0000 (19:42 +0000)]
    Reviewed many times by darin, hyatt.

        Switch to new engine-based implementation of <input type="file">

        * WebCore.exp: Remove obsolete symbol WebCoreFileButton
        * WebCore.xcodeproj/project.pbxproj: Remove files for old widget-based
        control, add files for new engine-based control
        * css/CSSSelector.cpp: Add support for new
        '-webkit-file-upload-button' pseudo element
        (WebCore::CSSSelector::extractPseudoType):
        * css/CSSSelector.h: Ditto.
        (WebCore::CSSSelector::):
        * css/cssstyleselector.cpp: Ditto.
        (WebCore::CSSStyleSelector::checkOneSelector):
        * html/HTMLInputElement.cpp: Send click events to new control
        (WebCore::HTMLInputElement::select):
        (WebCore::HTMLInputElement::click):
        (WebCore::HTMLInputElement::createRenderer):
        (WebCore::HTMLInputElement::valueWithDefault):
        (WebCore::HTMLInputElement::defaultEventHandler):
        * html/HTMLTextFieldInnerElement.h: Add 'virtual' keyword
        (WebCore::HTMLTextFieldInnerElement::shadowParentNode):
        * platform/FileButton.h: Removed.
        * platform/FileChooser.h: Added. This is the replacement for
        FileButton.h
        (WebCore::FileChooser::filename):
        (WebCore::FileChooser::icon):
        (WebCore::FileChooser::uploadControl):
        (WebCore::FileChooser::document):
        * platform/Icon.h: Added new platform-specific class representing a
        file icon.
        * platform/LocalizedStrings.h:
        * platform/mac/FileButtonMac.mm: Removed.
        * platform/mac/FileChooserMac.mm: Added. This is the replacement for
        FileButtonMac.mm
        (-[OpenPanelController initWithFileChooser:]):
        (-[OpenPanelController fileChooserDetachingSoon]):
        (-[OpenPanelController beginSheet]):
        (-[OpenPanelController chooseFilename:]):
        (-[OpenPanelController cancel]):
        (WebCore::FileChooser::FileChooser):
        (WebCore::FileChooser::~FileChooser):
        (WebCore::FileChooser::openFileChooser):
        (WebCore::FileChooser::basenameForWidth):
        (WebCore::FileChooser::uploadControlDetaching):
        (WebCore::FileChooser::chooseFile):
        * platform/mac/IconMac.mm: Added.
        (WebCore::Icon::Icon):
        (WebCore::Icon::~Icon):
        (WebCore::Icon::newIconForFile):
        (WebCore::Icon::paint):
        * platform/mac/LocalizedStringsMac.mm: Call across bridge to get
        localized strings.
        (WebCore::fileButtonChooseFileLabel):
        (WebCore::fileButtonNoFileSelectedLabel):
        * rendering/RenderButton.cpp: Extract method setText() from
        updateFromElement.
        (WebCore::RenderButton::updateFromElement):
        (WebCore::RenderButton::setText):
        * rendering/RenderButton.h: Add declaration for new setText method.
        * rendering/RenderFileButton.cpp: Removed.
        * rendering/RenderFileButton.h: Removed.
        * rendering/RenderFileUploadControl.cpp: Added. This is the
        replacement for RenderFileButton.cpp.
        (WebCore::RenderFileUploadInnerFileBox::renderName):
        (WebCore::HTMLFileUploadInnerButtonElement::isShadowNode):
        (WebCore::HTMLFileUploadInnerButtonElement::shadowParentNode):
        (WebCore::RenderFileUploadControl::RenderFileUploadControl):
        (WebCore::RenderFileUploadControl::~RenderFileUploadControl):
        (WebCore::RenderFileUploadControl::setStyle):
        (WebCore::RenderFileUploadControl::updateIconAndFilename):
        (WebCore::RenderFileUploadControl::click):
        (WebCore::RenderFileUploadControl::updateFromElement):
        (WebCore::RenderFileUploadControl::maxFilenameWidth):
        (WebCore::RenderFileUploadControl::createButtonStyle):
        (WebCore::RenderFileUploadControl::paintObject):
        (WebCore::RenderFileUploadInnerFileBox::RenderFileUploadInnerFileBox):
        (WebCore::RenderFileUploadInnerFileBox::setStyle):
        (WebCore::RenderFileUploadInnerFileBox::layout):
        (WebCore::RenderFileUploadInnerFileBox::setHasIcon):
        (WebCore::RenderFileUploadInnerFileBox::setFilename):
        (WebCore::RenderFileUploadInnerFileBox::calcMinMaxWidth):
        (WebCore::HTMLFileUploadInnerButtonElement::HTMLFileUploadInnerButtonElement):
        (WebCore::HTMLFileUploadInnerButtonElement::createRenderer):
        * rendering/RenderFileUploadControl.h: Added. This is the replacement
        for RenderFileButton.h.
        (WebCore::RenderFileUploadControl::renderName):
        * rendering/RenderStyle.cpp: Add support for
        -webkit-file-upload-button pseudo element.
        (WebCore::):
        (WebCore::pseudoBit):
        * rendering/RenderStyle.h: Ditto.
        (WebCore::RenderStyle::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-09-12 Anders Carlsson <acarlsson@apple.com>
andersca [Tue, 12 Sep 2006 17:48:45 +0000 (17:48 +0000)]
2006-09-12  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by John Sullivan.

        Do the plugin object cleanup in Frame::clear instead of setView.

        * bridge/mac/FrameMac.h:
        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::setView):
        (WebCore::FrameMac::cleanupPluginObjects):
        * page/Frame.cpp:
        (WebCore::Frame::clear):
        * page/Frame.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-09-12 MorganL <morlmor@yahoo.com>
aroben [Tue, 12 Sep 2006 16:43:13 +0000 (16:43 +0000)]
2006-09-12  MorganL  <morlmor@yahoo.com>

        Reviewed/landed by aroben.

        Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10822
        windows build is busted

        * WebCore.vcproj/WebCore/WebCore.vcproj: Add missing
        JSRangeException.{cpp,h} to project

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoAdd fieldset layout test.
hyatt [Tue, 12 Sep 2006 07:28:34 +0000 (07:28 +0000)]
Add fieldset layout test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Fix fieldsets so that they properly expand to enclose overhanging floats
hyatt [Tue, 12 Sep 2006 07:26:24 +0000 (07:26 +0000)]
    Fix fieldsets so that they properly expand to enclose overhanging floats
        when the fieldset has auto height.  This is a nifty undocumented behavior
        of the fieldset element.  The bug is 3898.

        Reviewed by mjs

        Added fast/forms/fieldset-with-float.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::layoutBlock):
        * rendering/RenderFieldset.h:
        (WebCore::RenderFieldset::renderName):
        (WebCore::RenderFieldset::expandsToEncloseOverhangingFloats):
        * rendering/RenderObject.h:
        (WebCore::RenderObject::expandsToEncloseOverhangingFloats):
        * rendering/RenderTableCell.h:
        (WebCore::RenderTableCell::expandsToEncloseOverhangingFloats):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-09-11 Eric Seidel <eric@eseidel.com>
eseidel [Tue, 12 Sep 2006 07:02:57 +0000 (07:02 +0000)]
2006-09-11  Eric Seidel  <eric@eseidel.com>

        Reviewed by hyatt.

        REGRESSION: When dragging a link on a page, the selected link doesn't display it's name or URL
        http://bugzilla.opendarwin.org/show_bug.cgi?id=10819
        http://bugzilla.opendarwin.org/show_bug.cgi?id=10814

        No test cases were harmed in the coding of the patch.

        * platform/mac/WebCoreTextRenderer.mm:
        (WebCoreDrawTextAtPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-09-11 MorganL <morlmor@yahoo.com>
aroben [Tue, 12 Sep 2006 05:39:08 +0000 (05:39 +0000)]
2006-09-11  MorganL  <morlmor@yahoo.com>

        Reviewed/landed by aroben.

        Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10765
        Windows build busted due to std::copy usage in Vector.h

        * WebKit.vcproj/WebKit.vcproj: Define _SCL_SECURE_NO_DEPRECATE to get
        rid of deprecation warnings on std::copy

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLand updated table test.
hyatt [Tue, 12 Sep 2006 05:06:10 +0000 (05:06 +0000)]
Land updated table test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Fix for bug 8126, column widths apply to the border boxes of cells.
hyatt [Tue, 12 Sep 2006 04:52:50 +0000 (04:52 +0000)]
    Fix for bug 8126, column widths apply to the border boxes of cells.

        Reviewed by aroben

        * rendering/RenderTableCell.cpp:
        (WebCore::RenderTableCell::styleOrColWidth):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoBetter Tiger build fix.
thatcher [Tue, 12 Sep 2006 03:58:44 +0000 (03:58 +0000)]
Better Tiger build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Despite the fact that some people built okay without this change, it sure...
beidson [Tue, 12 Sep 2006 03:53:45 +0000 (03:53 +0000)]
    Despite the fact that some people built okay without this change, it sure was biting me,
        probably because I just wiped my build directory for a fresh build -
        Today's earlier removal of DOMList.h needed to occur in MigrateHeaders.make, as well

        * MigrateHeaders.make: removed DOMList.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Build fix - I think Tim's last checkin wasn't tested on Tiger, possibly....
beidson [Tue, 12 Sep 2006 02:45:45 +0000 (02:45 +0000)]
    Build fix - I think Tim's last checkin wasn't tested on Tiger, possibly.  I simply
        commented out the undefined constants until he can have a chance to make the right call

        * bindings/objc/objc_utility.mm:
        (KJS::Bindings::objcValueTypeForType): Commented out undefined symbols

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoBuild fix. KeyScript is deprecated in Leopard, we need a new solution for this <rdar...
thatcher [Tue, 12 Sep 2006 00:22:53 +0000 (00:22 +0000)]
Build fix. KeyScript is deprecated in Leopard, we need a new solution for this <rdar://problem/4727607>

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Tim O. and Darin.
thatcher [Mon, 11 Sep 2006 23:57:33 +0000 (23:57 +0000)]
    Reviewed by Tim O. and Darin.

        Add support for more method signatures affecting ObjC methods called from JavaScript:
        - Added unsigned types and long long.
        - Allow methods that use const, oneway, bycopy and byref type modifiers.

        * bindings/objc/objc_instance.mm:
        (ObjcInstance::invokeMethod):
        * bindings/objc/objc_utility.h:
        (KJS::Bindings::):
        * bindings/objc/objc_utility.mm:
        (KJS::Bindings::convertValueToObjcValue):
        (KJS::Bindings::convertObjcValueToValue):
        (KJS::Bindings::objcValueTypeForType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Adele.
adele [Mon, 11 Sep 2006 23:11:03 +0000 (23:11 +0000)]
    Reviewed by Adele.

        Fix Qt/Linux build.

        * CMakeLists.txt: Add dom/RangeException.idl to build & fix feature defines.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-09-11 Nikolas Zimmermann <zimmermann@kde.org>
eseidel [Mon, 11 Sep 2006 21:42:22 +0000 (21:42 +0000)]
2006-09-11  Nikolas Zimmermann  <zimmermann@kde.org>

        Reviewed by eseidel.  Landed by eseidel.

Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=10750
        This finally fixes the SVGAnimated* classes JS bindings!

        - Move all SVGAnimated*.idl files from ksvg2/bindings/idl/svg to ksvg2/svg
        - Adjust XCode/Qt build files to generate the new idl files

        - Remove all SVGAnimated* primitives cpp implementations (Angle/Boolean/Color/Enumeration/Integer/Length/
                                                                  LengthList/Number/NumberList/PreserveAspectRatio/
                                                                  Rect/String/TransformList)

        - Remove unneeded methods from CodeGenerator.pm and add new helper function: IsSVGAnimatedType
        - Adjust CodeGeneratorJS.pm to the new SVGAnimated* tear-off concept

        - Add two new macros: ANIMATED_PROPERTY_EMPTY_DECLARATIONS / ANIMATED_PROPERTY_FORWARD_DECLARATIONS.
          This is used to fix multiple-inheritance issues in SVG with properties,
          similar like SVGTests::isValid() was fixed.

        - Rewrote SVGList using WTF::Vector, instead of DeprecatedPtrList and killed DOMList.
          (SVGAnimated*Lists work again now)

        - Adjust macros in SVGElement to create the "*Animated" tear-off classes.

        - Adjust all SVG classes which use the ANIMATED macros to include the ClassName as first param in the header.

        * CMakeLists.txt:
        * DerivedSources.make:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/scripts/CodeGenerator.pm:
        * bindings/scripts/CodeGeneratorJS.pm:
        * kcanvas/RenderSVGImage.cpp:
        (WebCore::RenderSVGImage::adjustRectsForAspectRatio):
        (WebCore::RenderSVGImage::paint):
        * kcanvas/RenderSVGText.cpp:
        (WebCore::RenderSVGText::translationForAttributes):
        * ksvg2/ksvg.h:
        * ksvg2/misc/SVGDocumentExtensions.h:
        (WebCore::FloatRect):
        * ksvg2/svg/SVGAElement.h:
        * ksvg2/svg/SVGAnimateColorElement.cpp:
        * ksvg2/svg/SVGAnimateColorElement.h:
        * ksvg2/svg/SVGAnimateTransformElement.h:
        * ksvg2/svg/SVGAnimatedTemplate.h:
        (WebCore::SVGAnimatedTemplate::~SVGAnimatedTemplate):
        * ksvg2/svg/SVGAnimationElement.h:
        * ksvg2/svg/SVGCircleElement.h:
        * ksvg2/svg/SVGClipPathElement.h:
        * ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
        (SVGComponentTransferFunctionElement::SVGComponentTransferFunctionElement):
        (SVGComponentTransferFunctionElement::transferFunction):
        * ksvg2/svg/SVGComponentTransferFunctionElement.h:
        * ksvg2/svg/SVGCursorElement.h:
        * ksvg2/svg/SVGDefsElement.h:
        * ksvg2/svg/SVGElement.h:
        * ksvg2/svg/SVGElementInstanceList.cpp:
        (WebCore::SVGElementInstanceList::SVGElementInstanceList):
        * ksvg2/svg/SVGElementInstanceList.h:
        * ksvg2/svg/SVGEllipseElement.h:
        * ksvg2/svg/SVGExternalResourcesRequired.h:
        * ksvg2/svg/SVGFEBlendElement.h:
        * ksvg2/svg/SVGFEColorMatrixElement.cpp:
        (SVGFEColorMatrixElement::SVGFEColorMatrixElement):
        (SVGFEColorMatrixElement::parseMappedAttribute):
        (SVGFEColorMatrixElement::filterEffect):
        * ksvg2/svg/SVGFEColorMatrixElement.h:
        * ksvg2/svg/SVGFEComponentTransferElement.h:
        * ksvg2/svg/SVGFECompositeElement.h:
        * ksvg2/svg/SVGFEDiffuseLightingElement.h:
        * ksvg2/svg/SVGFEDisplacementMapElement.h:
        * ksvg2/svg/SVGFEFloodElement.h:
        * ksvg2/svg/SVGFEGaussianBlurElement.h:
        * ksvg2/svg/SVGFEImageElement.h:
        * ksvg2/svg/SVGFELightElement.h:
        * ksvg2/svg/SVGFEMergeNodeElement.h:
        * ksvg2/svg/SVGFEOffsetElement.h:
        * ksvg2/svg/SVGFESpecularLightingElement.h:
        * ksvg2/svg/SVGFETileElement.h:
        * ksvg2/svg/SVGFETurbulenceElement.h:
        * ksvg2/svg/SVGFilterElement.h:
        * ksvg2/svg/SVGFilterPrimitiveStandardAttributes.h:
        * ksvg2/svg/SVGFitToViewBox.cpp:
        (WebCore::SVGFitToViewBox::SVGFitToViewBox):
        (WebCore::SVGFitToViewBox::parseViewBox):
        (WebCore::SVGFitToViewBox::viewBoxToViewTransform):
        * ksvg2/svg/SVGFitToViewBox.h:
        * ksvg2/svg/SVGForeignObjectElement.h:
        * ksvg2/svg/SVGGElement.h:
        * ksvg2/svg/SVGGradientElement.cpp:
        (SVGGradientElement::SVGGradientElement):
        * ksvg2/svg/SVGGradientElement.h:
        * ksvg2/svg/SVGHelper.cpp:
        (WebCore::SVGHelper::PercentageOfViewport):
        * ksvg2/svg/SVGImageElement.h:
        * ksvg2/svg/SVGLength.cpp:
        * ksvg2/svg/SVGLengthList.cpp:
        (WebCore::SVGLengthList::SVGLengthList):
        (WebCore::SVGLengthList::parse):
        * ksvg2/svg/SVGLengthList.h:
        * ksvg2/svg/SVGLineElement.h:
        * ksvg2/svg/SVGLinearGradientElement.h:
        * ksvg2/svg/SVGList.h:
        (WebCore::SVGListBase::SVGListBase):
        (WebCore::SVGListBase::~SVGListBase):
        (WebCore::SVGListBase::numberOfItems):
        (WebCore::SVGListBase::clear):
        (WebCore::SVGListBase::initialize):
        (WebCore::SVGListBase::getFirst):
        (WebCore::SVGListBase::getLast):
        (WebCore::SVGListBase::getItem):
        (WebCore::SVGListBase::insertItemBefore):
        (WebCore::SVGListBase::replaceItem):
        (WebCore::SVGListBase::removeItem):
        (WebCore::SVGListBase::appendItem):
        (WebCore::SVGList::nullItem):
        (WebCore::):
        * ksvg2/svg/SVGLocatable.cpp:
        * ksvg2/svg/SVGMarkerElement.h:
        * ksvg2/svg/SVGMaskElement.h:
        * ksvg2/svg/SVGNumberList.cpp:
        (SVGNumberList::SVGNumberList):
        (SVGNumberList::parse):
        * ksvg2/svg/SVGNumberList.h:
        * ksvg2/svg/SVGPathElement.cpp:
        (WebCore::SVGPathElement::pathSegList):
        * ksvg2/svg/SVGPathElement.h:
        * ksvg2/svg/SVGPathSegList.cpp:
        (WebCore::SVGPathSegList::SVGPathSegList):
        * ksvg2/svg/SVGPathSegList.h:
        * ksvg2/svg/SVGPatternElement.cpp:
        (WebCore::SVGPatternElement::SVGPatternElement):
        * ksvg2/svg/SVGPatternElement.h:
        * ksvg2/svg/SVGPointList.cpp:
        (SVGPointList::SVGPointList):
        * ksvg2/svg/SVGPointList.h:
        * ksvg2/svg/SVGPolyElement.cpp:
        (SVGPolyElement::points):
        (SVGPolyElement::svgPolyTo):
        (SVGPolyElement::notifyAttributeChange):
        * ksvg2/svg/SVGPolyElement.h:
        * ksvg2/svg/SVGPolygonElement.cpp:
        (SVGPolygonElement::toPathData):
        * ksvg2/svg/SVGPolylineElement.cpp:
        (SVGPolylineElement::toPathData):
        * ksvg2/svg/SVGPreserveAspectRatio.h:
        (WebCore::SVGPreserveAspectRatio::):
        * ksvg2/svg/SVGRadialGradientElement.h:
        * ksvg2/svg/SVGRectElement.h:
        * ksvg2/svg/SVGSVGElement.cpp:
        (WebCore::SVGSVGElement::SVGSVGElement):
        (WebCore::SVGSVGElement::parseMappedAttribute):
        (WebCore::SVGSVGElement::createRenderer):
        * ksvg2/svg/SVGSVGElement.h:
        * ksvg2/svg/SVGScriptElement.h:
        * ksvg2/svg/SVGStopElement.h:
        * ksvg2/svg/SVGStringList.cpp:
        (WebCore::SVGStringList::SVGStringList):
        (WebCore::SVGStringList::reset):
        * ksvg2/svg/SVGStringList.h:
        * ksvg2/svg/SVGStyledElement.h:
        * ksvg2/svg/SVGStyledLocatableElement.cpp:
        * ksvg2/svg/SVGStyledTransformableElement.cpp:
        (SVGStyledTransformableElement::SVGStyledTransformableElement):
        * ksvg2/svg/SVGStyledTransformableElement.h:
        * ksvg2/svg/SVGSwitchElement.h:
        * ksvg2/svg/SVGSymbolElement.h:
        * ksvg2/svg/SVGTRefElement.h:
        * ksvg2/svg/SVGTests.cpp:
        (WebCore::SVGTests::isValid):
        * ksvg2/svg/SVGTextContentElement.h:
        * ksvg2/svg/SVGTextElement.cpp:
        (WebCore::SVGTextElement::SVGTextElement):
        * ksvg2/svg/SVGTextElement.h:
        * ksvg2/svg/SVGTextPositioningElement.cpp:
        (SVGTextPositioningElement::SVGTextPositioningElement):
        (SVGTextPositioningElement::parseMappedAttribute):
        * ksvg2/svg/SVGTextPositioningElement.h:
        * ksvg2/svg/SVGTransformList.cpp:
        (SVGTransformList::SVGTransformList):
        (SVGTransformList::createSVGTransformFromMatrix):
        (SVGTransformList::consolidate):
        (SVGTransformList::concatenate):
        * ksvg2/svg/SVGTransformList.h:
        * ksvg2/svg/SVGURIReference.h:
        * ksvg2/svg/SVGUseElement.h:
        * ksvg2/svg/SVGViewElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoBuild fix
kmccullo [Mon, 11 Sep 2006 21:07:34 +0000 (21:07 +0000)]
Build fix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoChangeLog date fix
beidson [Mon, 11 Sep 2006 20:58:09 +0000 (20:58 +0000)]
ChangeLog date fix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Rubberstamped by Adele.
aroben [Mon, 11 Sep 2006 20:48:40 +0000 (20:48 +0000)]
    Rubberstamped by Adele.

        Rename LocalGraphicsContext.{h,mm} to
        LocalCurrentGraphicsContext.{h,mm} to match the class name.

        * WebCore.xcodeproj/project.pbxproj:
        * platform/mac/LocalCurrentGraphicsContext.mm: Added.
        * platform/mac/LocalCurrentGraphicsContext.h: Added.
        * platform/mac/LocalGraphicsContext.h: Removed.
        * platform/mac/LocalGraphicsContext.mm: Removed.
        * rendering/RenderThemeMac.mm: Fix #include to match renamed file

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoConflict marker removed
beidson [Mon, 11 Sep 2006 20:34:15 +0000 (20:34 +0000)]
Conflict marker removed

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Build fix
beidson [Mon, 11 Sep 2006 20:29:20 +0000 (20:29 +0000)]
    Build fix

        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
kmccullo [Mon, 11 Sep 2006 18:46:49 +0000 (18:46 +0000)]
LayoutTests:

        Reviewed by Darin.

        * ChangeLog:
        * fast/dom/Range/range-compareNode-expected.txt: Added.
        * fast/dom/Range/range-compareNode.html: Added.
        * fast/dom/Range/range-comparePoint.html:

WebCore:

        Reviewed by Darin.

        - Implements comparePoint on the Range class

        - Exposes RangeExceptions in JavaScript

        * DerivedSources.make:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/kjs_binding.cpp:
        * bindings/objc/DOMInternal.mm:
        * dom/Range.cpp:
        (WebCore::Range::comparePoint):
        (WebCore::Range::compareNode):
        * dom/Range.h:
        (WebCore::Range::):
        * dom/Range.idl:
        * dom/RangeException.h: Added.
        (WebCore::):
        * dom/RangeException.idl: Added.
        * page/DOMWindow.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by timo.
aroben [Mon, 11 Sep 2006 18:41:54 +0000 (18:41 +0000)]
    Reviewed by timo.

        Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10812
        Move LocalGraphicsContext out of RenderThemeMac

        * WebCore.xcodeproj/project.pbxproj:
        * platform/mac/LocalGraphicsContext.h: Added.
        * platform/mac/LocalGraphicsContext.mm: Added.
        (WebCore::LocalCurrentGraphicsContext::LocalCurrentGraphicsContext):
        (WebCore::LocalCurrentGraphicsContext::~LocalCurrentGraphicsContext):
        * rendering/RenderThemeMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
darin [Mon, 11 Sep 2006 17:38:39 +0000 (17:38 +0000)]
LayoutTests:

        Reviewed by Darin.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=10323
          REGRESSION: javascript: URL containing '\\' gets passed as '//'

        * fast/dom/javascript-backslash-expected.txt: Added.
        * fast/dom/javascript-backslash.html: Added.

WebCore:

        Reviewed by Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=10323
          REGRESSION: javascript: URL containing '\\' gets passed as '//'

        Test: fast/dom/javascript-backslash.html

        * platform/KURL.cpp: (WebCore::KURL::init): Don't do backslash
        substitution in JavaScript URLs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin and Tim H.
weinig [Mon, 11 Sep 2006 17:11:59 +0000 (17:11 +0000)]
    Reviewed by Darin and Tim H.

        Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10792
        Remove the [Exclude=LANGUAGE] idiom from IDL's and code generators
        for something better

        - Replaces [Exclude=LANGUAGE] idiom with preprocessor #if defined(LANGUAGE)
          idiom.

        - Assorted whitespace changes to IDL files.

        * DerivedSources.make:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/objc/DOMEvents.h:
        * bindings/scripts/CodeGenerator.pm:
        * bindings/scripts/CodeGeneratorJS.pm:
        * bindings/scripts/CodeGeneratorObjC.pm:
        * css/CSSRule.idl:
        * css/CSSStyleDeclaration.idl:
        * css/CSSValue.idl:
        * dom/DOMImplementation.idl:
        * dom/Document.idl:
        * dom/Element.idl:
        * dom/Event.idl:
        * dom/KeyboardEvent.idl:
        * dom/MouseEvent.idl:
        * dom/NamedNodeMap.idl:
        * dom/NodeFilter.idl:
        * dom/UIEvent.idl:
        * dom/WheelEvent.idl:
        * html/HTMLAnchorElement.idl:
        * html/HTMLAreaElement.idl:
        * html/HTMLDocument.idl:
        * html/HTMLElement.idl:
        * html/HTMLImageElement.idl:
        * html/HTMLInputElement.idl:
        * html/HTMLLinkElement.idl:
        * html/HTMLOptionsCollection.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago - converted a test to plain text (makes it platform independent; fixes a...
darin [Mon, 11 Sep 2006 14:49:40 +0000 (14:49 +0000)]
    - converted a test to plain text (makes it platform independent; fixes a failure)

        * fast/events/ondragenter-expected.checksum: Removed.
        * fast/events/ondragenter-expected.png: Removed.
        * fast/events/ondragenter-expected.txt:
        * fast/events/ondragenter.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Fix an unwitting victim of the kMin->min change. calcBlockMinMaxWidth
hyatt [Mon, 11 Sep 2006 07:28:03 +0000 (07:28 +0000)]
    Fix an unwitting victim of the kMin->min change.  calcBlockMinMaxWidth
        was accidentally renamed to calcBlominMaxWidth.

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::calcMinMaxWidth):
        (WebCore::RenderBlock::calcBlockMinMaxWidth):
        * rendering/RenderBlock.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Rework the printer font stuff a little bit so that the Font API doesn't
hyatt [Mon, 11 Sep 2006 06:37:18 +0000 (06:37 +0000)]
    Rework the printer font stuff a little bit so that the Font API doesn't
        have to be changed.

        Reviewed by eseidel

        * WebCore.xcodeproj/project.pbxproj:
        * bridge/mac/WebCoreStringTruncator.mm:
        (truncateString):
        (+[WebCoreStringTruncator widthOfString:font:]):
        * platform/Font.cpp:
        (WebCore::Font::drawSimpleText):
        * platform/Font.h:
        * platform/TextStyle.h:
        (WebCore::TextStyle::TextStyle):
        (WebCore::TextStyle::attemptFontSubstitution):
        (WebCore::TextStyle::setRTL):
        * platform/mac/FontMac.mm:
        (WebCore::m_wordSpacing):
        (WebCore::Font::drawGlyphs):
        * platform/mac/ListBoxMac.mm:
        (itemTextRenderer):
        (groupLabelTextRenderer):
        (-[WebCoreTableView drawRow:clipRect:]):
        * platform/mac/PopUpButtonMac.mm:
        (PopUpButton::sizeHint):
        * platform/mac/TextFieldMac.mm:
        (-[NSSearchFieldCell _addStringToRecentSearches:]):
        * platform/mac/WebCoreTextRenderer.mm:
        (WebCoreDrawTextAtPoint):
        (WebCoreTextFloatWidth):
        * rendering/EllipsisBox.cpp:
        (WebCore::EllipsisBox::paint):
        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::paint):
        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::paint):
        * rendering/RenderListMarker.cpp:
        (WebCore::RenderListMarker::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agogit-svn-id: https://svn.webkit.org/repository/webkit/trunk@16295 268f45cc-cd09-0410...
beidson [Mon, 11 Sep 2006 06:16:32 +0000 (06:16 +0000)]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Maciej
beidson [Mon, 11 Sep 2006 05:23:22 +0000 (05:23 +0000)]
    Reviewed by Maciej

        Added specialized HashTraits

        * platform/IntSizeHash.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago - converted a text to plain text (makes it platform independent; fixes a...
darin [Mon, 11 Sep 2006 02:48:56 +0000 (02:48 +0000)]
    - converted a text to plain text (makes it platform independent; fixes a failure)

        * fast/text/plain-text-line-breaks-expected.checksum: Removed.
        * fast/text/plain-text-line-breaks-expected.png: Removed.
        * fast/text/plain-text-line-breaks-expected.txt: Regenerated.
        * fast/text/plain-text-line-breaks.html: Added a call to dumpAsText().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Forgetting header #define protection is BAAAAAD
beidson [Mon, 11 Sep 2006 02:26:10 +0000 (02:26 +0000)]
    Forgetting header #define protection is BAAAAAD
        (and re-alphabatized the project file)

        * WebCore.xcodeproj/project.pbxproj:
        * platform/IntSizeHash.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Maciej
beidson [Mon, 11 Sep 2006 02:13:05 +0000 (02:13 +0000)]
    Reviewed by Maciej

        Moved the custom IntSize hash out of IconDatabase into a more generally useful file

        * WebCore.xcodeproj/project.pbxproj:
        * loader/icon/IconDatabase.h:
        * platform/IntSizeHash.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLand new results.
hyatt [Sun, 10 Sep 2006 23:33:22 +0000 (23:33 +0000)]
Land new results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Fix for bug 10801, form controls that get styled suddenly lose their
hyatt [Sun, 10 Sep 2006 23:27:16 +0000 (23:27 +0000)]
    Fix for bug 10801, form controls that get styled suddenly lose their
        intrinsic margins.  Move the intrinsic margin addition code into
        adjustRenderStyle and get it out of the theme code and the old form control
        code.

        Reviewed by aroben

        * css/cssstyleselector.cpp:
        (WebCore::addIntrinsicMargins):
        (WebCore::CSSStyleSelector::adjustRenderStyle):
        * css/html4.css:
        * rendering/DeprecatedRenderSelect.h:
        (WebCore::DeprecatedRenderSelect::calcReplacedHeight):
        * rendering/DeprecatedSlider.h:
        * rendering/RenderFormElement.cpp:
        (WebCore::RenderFormElement::setStyle):
        * rendering/RenderFormElement.h:
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::resize):
        * rendering/RenderThemeMac.h:
        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::adjustButtonStyle):
        (WebCore::RenderThemeMac::adjustTextFieldStyle):
        (WebCore::RenderThemeMac::adjustTextAreaStyle):
        (WebCore::RenderThemeMac::adjustMenuListStyle):
        (WebCore::RenderThemeMac::adjustMenuListButtonStyle):
        * rendering/RenderThemeWin.cpp:
        (WebCore::RenderThemeWin::adjustButtonStyle):
        (WebCore::RenderThemeWin::adjustTextFieldStyle):
        (WebCore::RenderThemeWin::adjustTextAreaStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Brady.
darin [Sun, 10 Sep 2006 20:22:03 +0000 (20:22 +0000)]
    Reviewed by Brady.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=10547
          REGRESSION: Links that should open in a new window open in the same window,
          while opening another blank window

        * WebView/WebFrame.m:
        (-[WebFrame _continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):
        Changed a mistaken "self" to "frame", which was the cause of the bug. Also
        fixed the method so that it won't crash if createWebViewWithRequest does
        something that has a side effect of releasing this WebView or this frame
        by retaining "self" and "frame" as needed. Also fixed a problem where the
        code to set "opener" was backwards, and would set the opener of the old
        frame to point to the new frame instead of vice versa.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=10547
darin [Sun, 10 Sep 2006 20:21:42 +0000 (20:21 +0000)]
    - test for bugzilla.opendarwin.org/show_bug.cgi?id=10547

        * manual-tests/target-test.html: Added.
        * manual-tests/targeted.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-09-10 Eric Seidel <eric@eseidel.com>
eseidel [Sun, 10 Sep 2006 19:53:41 +0000 (19:53 +0000)]
2006-09-10  Eric Seidel  <eric@eseidel.com>

        Reviewed by darin.

        Remove a bunch more NSGraphicsContext related code.
        Add a LocalCurrentGraphicsContext to simplify methods which need to call up into AppKit controls (and thus depend on the [NSGraphicsContext currentContext] being set correctly)
        Add an "isPrinting" flag to many of the text drawing functions in order to avoid the need for a GraphicsContext::isPrinting() function.

        No tests were harmed in the making of this patch.

        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge drawRect:]):
        * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
        (WebCore::KRenderingDeviceContextQuartz::cgContext):
        (WebCore::KRenderingDeviceQuartz::isBuffered):
        * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
        (WebCore::KRenderingDeviceContextQuartz::KRenderingDeviceContextQuartz):
        (WebCore::KRenderingDeviceContextQuartz::~KRenderingDeviceContextQuartz):
        * kcanvas/device/quartz/QuartzSupport.mm:
        * platform/Font.cpp:
        (WebCore::Font::drawSimpleText):
        (WebCore::Font::drawText):
        * platform/Font.h:
        * platform/GraphicsContext.cpp:
        (WebCore::GraphicsContext::drawText):
        * platform/GraphicsContext.h:
        * platform/mac/FileButtonMac.mm:
        (-[WebFileChooserButton drawRect:]):
        * platform/mac/FontMac.mm:
        (WebCore::ATSULayoutParameters::ATSULayoutParameters):
        (WebCore::ATSULayoutParameters::initialize):
        (WebCore::Font::drawComplexText):
        (WebCore::Font::drawGlyphs):
        * platform/mac/GraphicsContextMac.mm:
        (WebCore::GraphicsContext::drawLineForMisspelling):
        * platform/mac/ListBoxMac.mm:
        (-[WebCoreTableView drawRow:clipRect:]):
        * platform/mac/WebCoreTextRenderer.mm:
        (WebCoreDrawTextAtPoint):
        * rendering/EllipsisBox.cpp:
        (WebCore::EllipsisBox::paint):
        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::paint):
        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::paint):
        * rendering/RenderListMarker.cpp:
        (WebCore::RenderListMarker::paint):
        * rendering/RenderThemeMac.mm:
        (WebCore::WebCoreNSGraphicsContextBridge::WebCoreNSGraphicsContextBridge):
        (WebCore::WebCoreNSGraphicsContextBridge::~WebCoreNSGraphicsContextBridge):
        (WebCore::RenderThemeMac::paintButton):
        (WebCore::RenderThemeMac::paintTextField):
        (WebCore::RenderThemeMac::paintTextArea):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed and landed by ap.
ap [Sun, 10 Sep 2006 18:17:06 +0000 (18:17 +0000)]
    Reviewed and landed by ap.

        Fix QtLauncher - it is supposed to create a FrameView on its own nowadays.

        * QtLauncher/main.cpp:
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-09-09 Steve Falkenburg <sfalken@apple.com>
sfalken [Sun, 10 Sep 2006 07:41:44 +0000 (07:41 +0000)]
2006-09-09  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by aroben.

        Fixes to work with string API changes.

        * platform/cf/ResourceLoaderCFNet.cpp:
        (WebCore::arrayFromFormData):
        (WebCore::ResourceLoader::start):
        * platform/cf/StringCF.cpp:
        * platform/cf/StringImplCF.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-09-09 Steve Falkenburg <sfalken@apple.com>
sfalken [Sun, 10 Sep 2006 07:40:09 +0000 (07:40 +0000)]
2006-09-09  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by aroben.

        Add missing copy command.
        Support finding icu headers in multiple locations.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoAdd test for textarea scrollwidth and height.
hyatt [Sun, 10 Sep 2006 05:52:52 +0000 (05:52 +0000)]
Add test for textarea scrollwidth and height.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoAdd layout test for bug 10719.
hyatt [Sun, 10 Sep 2006 05:47:22 +0000 (05:47 +0000)]
Add layout test for bug 10719.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Fix for Bugzilla bug 5500, scrollLeft/Top/Width/Height properties not supported
hyatt [Sun, 10 Sep 2006 05:37:32 +0000 (05:37 +0000)]
    Fix for Bugzilla bug 5500, scrollLeft/Top/Width/Height properties not supported
        on textarea.  Refactored the DOM getters and setters to go through the renderer
        instead of right to the layer.  The renderer functions are virtual so that the
        text control can subclass and forward to its anonymous div.

        Fix for Bugzilla bug 10719, When positioned objects are sizing using their
        containing block width as a guide, they should not ever use the line width like
        non-positioned objects do.

        Reviewed by aroben

        * WebCore.xcodeproj/project.pbxproj:
        * dom/Element.cpp:
        (WebCore::Element::scrollLeft):
        (WebCore::Element::scrollTop):
        (WebCore::Element::setScrollLeft):
        (WebCore::Element::setScrollTop):
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::containingBlockWidthForPositioned):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::clientWidth):
        (WebCore::RenderObject::clientHeight):
        (WebCore::RenderObject::scrollWidth):
        (WebCore::RenderObject::scrollHeight):
        (WebCore::RenderObject::scrollLeft):
        (WebCore::RenderObject::scrollTop):
        (WebCore::RenderObject::setScrollLeft):
        (WebCore::RenderObject::setScrollTop):
        (WebCore::RenderObject::hasStaticX):
        (WebCore::RenderObject::hasStaticY):
        * rendering/RenderObject.h:
        (WebCore::RenderObject::clientLeft):
        (WebCore::RenderObject::clientTop):
        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::scrollWidth):
        (WebCore::RenderTextControl::scrollHeight):
        (WebCore::RenderTextControl::scrollLeft):
        (WebCore::RenderTextControl::scrollTop):
        (WebCore::RenderTextControl::setScrollLeft):
        (WebCore::RenderTextControl::setScrollTop):
        * rendering/RenderTextControl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Implement support for the WinIE clientLeft and clientTop extensions.
hyatt [Sun, 10 Sep 2006 04:55:03 +0000 (04:55 +0000)]
    Implement support for the WinIE clientLeft and clientTop extensions.

        Reviewed by aroben

        * dom/Element.cpp:
        (WebCore::Element::clientLeft):
        (WebCore::Element::clientTop):
        * dom/Element.h:
        * dom/Element.idl:
        * rendering/RenderObject.h:
        (WebCore::RenderObject::clientLeft):
        (WebCore::RenderObject::clientTop):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoWebCore:
weinig [Sun, 10 Sep 2006 02:36:36 +0000 (02:36 +0000)]
WebCore:

        Reviewed by Eric.

        Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10795
        Auto-generate the Objective-C DOM XPath bindings

        - Auto-generates DOMXPathExpression, DOMXPathNSResolver and DOMXPathResult.

        * DerivedSources.make:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/objc/DOMPrivate.h:
        * bindings/objc/DOMXPath.h:
        * bindings/objc/DOMXPath.mm:
        * bindings/objc/PublicDOMInterfaces.h:
        * xml/XPathExpression.idl:
        * xml/XPathNSResolver.idl:
        * xml/XPathResult.idl:

WebKit:

        Reviewed by Eric.

        Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10795
        Auto-generate the Objective-C DOM XPath bindings

        * MigrateHeaders.make:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoWebCore:
weinig [Sat, 9 Sep 2006 22:05:58 +0000 (22:05 +0000)]
WebCore:

        Reviewed by Eric.

        Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10791
        Even More Objective-C DOM auto-generation cleanup

        - Auto-generate some remaining extension methods for DOMDocument
          and DOMCSSStyleDeclaration.

        - Split DOMHTMLEmbedElement into it's own files.  It can't be
          auto-generated yet because the Objective-C interface is significantly
          different from the implementation interface.  Since HTMLEmbedElement
          is not in the W3C spec, this is somewhat of a gray area.

        - Auto-generate DOMEventListener protocol.

        - Clean up the IDL files by separating the extensions from the
          specified methods and attributes.

        * DerivedSources.make:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/objc/DOM.mm:
        * bindings/objc/DOMCSS.mm:
        * bindings/objc/DOMEventListener.h: Removed.
        * bindings/objc/DOMExtensions.h:
        * bindings/objc/DOMHTML.h:
        * bindings/objc/DOMHTML.mm:
        * bindings/objc/DOMHTMLEmbedElement.h: Added.
        * bindings/objc/DOMHTMLEmbedElement.mm: Added.
        (-[DOMHTMLEmbedElement align]):
        (-[DOMHTMLEmbedElement setAlign:]):
        (-[DOMHTMLEmbedElement height]):
        (-[DOMHTMLEmbedElement setHeight:]):
        (-[DOMHTMLEmbedElement name]):
        (-[DOMHTMLEmbedElement setName:]):
        (-[DOMHTMLEmbedElement src]):
        (-[DOMHTMLEmbedElement setSrc:]):
        (-[DOMHTMLEmbedElement type]):
        (-[DOMHTMLEmbedElement setType:]):
        (-[DOMHTMLEmbedElement width]):
        (-[DOMHTMLEmbedElement setWidth:]):
        * bindings/objc/DOMPrivate.h:
        * bindings/objc/PublicDOMInterfaces.h:
        * css/CSSStyleDeclaration.idl:
        * dom/Document.idl:
        * dom/KeyboardEvent.h:
        * dom/KeyboardEvent.idl:
        * dom/MouseEvent.idl:
        * dom/MutationEvent.idl:
        * dom/OverflowEvent.idl:
        * dom/UIEvent.idl:
        * dom/WheelEvent.idl:
        * html/HTMLEmbedElement.idl: Added.

WebKit:

        Reviewed by Eric.

        Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10791
        Even More Objective-C DOM auto-generation cleanup

        * MigrateHeaders.make:

WebKitTools:

        Reviewed by Eric.

        Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10791
        Even More Objective-C DOM auto-generation cleanup

        - Change to use new, more Objectice-C'ish version of
          DOMKeyboardEvent's initKeyboardEvent.  Fixes an error with
          regression test for fast/events/dblclick-addEventListener.html.

        * DumpRenderTree/EventSendingController.m:
        (-[EventSendingController fireKeyboardEventsToElement:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-09-09 Eric Seidel <eric@eseidel.com>
eseidel [Sat, 9 Sep 2006 20:29:41 +0000 (20:29 +0000)]
2006-09-09  Eric Seidel  <eric@eseidel.com>

        Reviewed by Tim H.

        Remove DeprecatedString usage and fix style.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=10787

        No tests were harmed in the making of this patch.

        * kcanvas/KCanvasFilters.cpp:
        (WebCore::KCanvasFilterEffect::in):
        (WebCore::KCanvasFilterEffect::setIn):
        (WebCore::KCanvasFilterEffect::result):
        (WebCore::KCanvasFilterEffect::setResult):
        (WebCore::KCanvasFEMerge::externalRepresentation):
        * kcanvas/KCanvasFilters.h:
        (WebCore::KCanvasFEBlend::in2):
        (WebCore::KCanvasFEBlend::setIn2):
        (WebCore::KCanvasFEComposite::in2):
        (WebCore::KCanvasFEComposite::setIn2):
        (WebCore::KCanvasFEDisplacementMap::in2):
        (WebCore::KCanvasFEDisplacementMap::setIn2):
        (WebCore::KCanvasFEMerge::mergeInputs):
        (WebCore::KCanvasFEMerge::setMergeInputs):
        * kcanvas/KCanvasResources.cpp:
        (WebCore::KCanvasResource::idInRegistry):
        (WebCore::KCanvasResource::setIdInRegistry):
        (WebCore::getResourceById):
        * kcanvas/KCanvasResources.h:
        * kcanvas/RenderPath.cpp:
        (WebCore::RenderPath::getAbsoluteRepaintRect):
        (WebCore::RenderPath::paint):
        (WebCore::RenderPath::drawMarkersIfNeeded):
        * kcanvas/RenderSVGContainer.cpp:
        (WebCore::RenderSVGContainer::paint):
        (WebCore::RenderSVGContainer::getAbsoluteRepaintRect):
        * kcanvas/RenderSVGImage.cpp:
        (WebCore::RenderSVGImage::paint):
        (WebCore::RenderSVGImage::getAbsoluteRepaintRect):
        * kcanvas/RenderSVGText.cpp:
        (WebCore::RenderSVGText::paint):
        * kcanvas/device/KRenderingPaintServer.h:
        (WebCore::KRenderingPaintServer::idInRegistry):
        (WebCore::KRenderingPaintServer::setIdInRegistry):
        * kcanvas/device/quartz/KCanvasFilterQuartz.h:
        * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
        (WebCore::KCanvasFilterQuartz::imageForName):
        (WebCore::KCanvasFilterQuartz::setImageForName):
        (WebCore::KCanvasFEMergeQuartz::getCIFilter):
        * ksvg2/css/SVGCSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applySVGProperty):
        * ksvg2/css/SVGRenderStyle.cpp:
        * ksvg2/css/SVGRenderStyle.h:
        * ksvg2/css/SVGRenderStyleDefs.h:
        * ksvg2/ecma/GlobalObject.cpp:
        (GlobalObject::get):
        * ksvg2/misc/KSVGTimeScheduler.cpp:
        (WebCore::SVGTimer::notifyAll):
        * ksvg2/svg/SVGDescElement.cpp:
        (WebCore::SVGDescElement::SVGDescElement):
        (WebCore::SVGDescElement::description):
        * ksvg2/svg/SVGDescElement.h:
        * ksvg2/svg/SVGFEBlendElement.cpp:
        (WebCore::SVGFEBlendElement::SVGFEBlendElement):
        (WebCore::SVGFEBlendElement::filterEffect):
        * ksvg2/svg/SVGFEColorMatrixElement.cpp:
        (SVGFEColorMatrixElement::SVGFEColorMatrixElement):
        (SVGFEColorMatrixElement::filterEffect):
        * ksvg2/svg/SVGFEComponentTransferElement.cpp:
        (WebCore::SVGFEComponentTransferElement::SVGFEComponentTransferElement):
        (WebCore::SVGFEComponentTransferElement::filterEffect):
        * ksvg2/svg/SVGFECompositeElement.cpp:
        (SVGFECompositeElement::SVGFECompositeElement):
        (SVGFECompositeElement::filterEffect):
        * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
        (WebCore::SVGFEDiffuseLightingElement::SVGFEDiffuseLightingElement):
        (WebCore::SVGFEDiffuseLightingElement::filterEffect):
        * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
        (SVGFEDisplacementMapElement::SVGFEDisplacementMapElement):
        (SVGFEDisplacementMapElement::filterEffect):
        * ksvg2/svg/SVGFEFloodElement.cpp:
        (WebCore::SVGFEFloodElement::SVGFEFloodElement):
        (WebCore::SVGFEFloodElement::filterEffect):
        * ksvg2/svg/SVGFEGaussianBlurElement.cpp:
        (SVGFEGaussianBlurElement::SVGFEGaussianBlurElement):
        (SVGFEGaussianBlurElement::filterEffect):
        * ksvg2/svg/SVGFELightElement.cpp:
        * ksvg2/svg/SVGFEMergeElement.cpp:
        (SVGFEMergeElement::filterEffect):
        * ksvg2/svg/SVGFEOffsetElement.cpp:
        (SVGFEOffsetElement::SVGFEOffsetElement):
        (SVGFEOffsetElement::filterEffect):
        * ksvg2/svg/SVGFESpecularLightingElement.cpp:
        (SVGFESpecularLightingElement::SVGFESpecularLightingElement):
        (SVGFESpecularLightingElement::filterEffect):
        * ksvg2/svg/SVGFETileElement.cpp:
        (WebCore::SVGFETileElement::SVGFETileElement):
        (WebCore::SVGFETileElement::filterEffect):
        * ksvg2/svg/SVGFETurbulenceElement.cpp:
        (SVGFETurbulenceElement::SVGFETurbulenceElement):
        * ksvg2/svg/SVGFilterPrimitiveStandardAttributes.cpp:
        (SVGFilterPrimitiveStandardAttributes::setStandardAttributes):
        * ksvg2/svg/SVGFitToViewBox.cpp:
        (WebCore::SVGFitToViewBox::parseViewBox):
        (WebCore::SVGFitToViewBox::parseMappedAttribute):
        * ksvg2/svg/SVGFitToViewBox.h:
        * ksvg2/svg/SVGLinearGradientElement.cpp:
        (SVGLinearGradientElement::buildGradient):
        * ksvg2/svg/SVGPatternElement.cpp:
        (WebCore::SVGPatternElement::fillAttributesFromReferencePattern):
        (WebCore::SVGPatternElement::notifyAttributeChange):
        * ksvg2/svg/SVGPreserveAspectRatio.cpp:
        (WebCore::SVGPreserveAspectRatio::SVGPreserveAspectRatio):
        (WebCore::SVGPreserveAspectRatio::parsePreserveAspectRatio):
        (WebCore::SVGPreserveAspectRatio::getCTM):
        * ksvg2/svg/SVGPreserveAspectRatio.h:
        * ksvg2/svg/SVGRadialGradientElement.cpp:
        (WebCore::SVGRadialGradientElement::buildGradient):
        * ksvg2/svg/SVGStyleElement.cpp:
        * ksvg2/svg/SVGStyledTransformableElement.cpp:
        * ksvg2/svg/SVGViewElement.cpp:
        (WebCore::SVGViewElement::SVGViewElement):
        (WebCore::SVGViewElement::parseMappedAttribute):
        * ksvg2/svg/SVGZoomAndPan.cpp:
        (WebCore::SVGZoomAndPan::SVGZoomAndPan):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
thatcher [Sat, 9 Sep 2006 15:35:26 +0000 (15:35 +0000)]
LayoutTests:

        Adds a test for the CSS URL quoting logic.

        * fast/inspector/cssURLQuotes-expected.txt: Added.
        * fast/inspector/cssURLQuotes.html: Added.

WebCore:

        Reviewed by Tim H.

        <rdar://problem/4699166> REGRESSION: Background images in Mail stationery do not load

        Fixes the quoting logic. The previous logic did not account for the
        CSS tokenizer's regex character range between * and ~ as valid in URL types.

        * css/CSSPrimitiveValue.cpp:
        (WebCore::isCSSTokenizerURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin.
ap [Sat, 9 Sep 2006 10:54:57 +0000 (10:54 +0000)]
    Reviewed by Darin.

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=10759
          fast/AppleScript/array.html test failing

WebCore:
        * bridge/mac/WebCoreFrameBridge.mm:
        (aeDescFromJSValue): Convert integer values to typeSInt32 AE descriptors.

LayoutTests:
        * fast/AppleScript/001-expected.txt: Updated results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-09-08 Eric Seidel <eric@eseidel.com>
eseidel [Sat, 9 Sep 2006 01:56:22 +0000 (01:56 +0000)]
2006-09-08  Eric Seidel  <eric@eseidel.com>

        Reviewed by darin.

        Replace incorrect fooBaseValue() calls with foo() calls instead.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=10746

        With the previously broken animation system, we had both base and anim values
        but they were not automatically connected/disconnected when animation started and stopped.
        So the animVals were basically never used (since they were always wrong).
        Now, animVal and baseVal are handled correctly.

        There are only 3 places in the code where we will ever need to use the BaseValue accessor variants.
        1. SVGAnimated* DOM bindings
        2. Animation Code
        3. parseMappedAttribute implementations

        * kcanvas/RenderForeignObject.cpp:
        (WebCore::RenderForeignObject::translationForAttributes):
        * kcanvas/RenderSVGImage.cpp:
        (WebCore::RenderSVGImage::paint):
        (WebCore::RenderSVGImage::relativeBBox):
        (WebCore::RenderSVGImage::getAbsoluteRepaintRect):
        (WebCore::RenderSVGImage::translationForAttributes):
        * kcanvas/RenderSVGText.cpp:
        (WebCore::RenderSVGText::translationForAttributes):
        * ksvg2/misc/SVGImageLoader.cpp:
        (WebCore::SVGImageLoader::updateFromElement):
        * ksvg2/svg/SVGAElement.cpp:
        (WebCore::SVGAElement::defaultEventHandler):
        * ksvg2/svg/SVGCircleElement.cpp:
        (SVGCircleElement::parseMappedAttribute):
        (SVGCircleElement::toPathData):
        (SVGCircleElement::pushAttributeContext):
        (SVGCircleElement::hasPercentageValues):
        * ksvg2/svg/SVGClipPathElement.cpp:
        (SVGClipPathElement::canvasResource):
        * ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
        (SVGComponentTransferFunctionElement::transferFunction):
        * ksvg2/svg/SVGCursorElement.cpp:
        (SVGCursorElement::parseMappedAttribute):
        * ksvg2/svg/SVGEllipseElement.cpp:
        (WebCore::SVGEllipseElement::parseMappedAttribute):
        (WebCore::SVGEllipseElement::toPathData):
        (WebCore::SVGEllipseElement::pushAttributeContext):
        (WebCore::SVGEllipseElement::hasPercentageValues):
        * ksvg2/svg/SVGFEBlendElement.cpp:
        (SVGFEBlendElement::filterEffect):
        * ksvg2/svg/SVGFEColorMatrixElement.cpp:
        (SVGFEColorMatrixElement::filterEffect):
        * ksvg2/svg/SVGFEComponentTransferElement.cpp:
        (SVGFEComponentTransferElement::filterEffect):
        * ksvg2/svg/SVGFECompositeElement.cpp:
        (SVGFECompositeElement::filterEffect):
        * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
        (WebCore::SVGFEDiffuseLightingElement::filterEffect):
        * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
        (SVGFEDisplacementMapElement::filterEffect):
        * ksvg2/svg/SVGFEDistantLightElement.cpp:
        (WebCore::SVGFEDistantLightElement::lightSource):
        * ksvg2/svg/SVGFEFloodElement.cpp:
        (SVGFEFloodElement::filterEffect):
        * ksvg2/svg/SVGFEGaussianBlurElement.cpp:
        (SVGFEGaussianBlurElement::filterEffect):
        * ksvg2/svg/SVGFEImageElement.cpp:
        (SVGFEImageElement::parseMappedAttribute):
        * ksvg2/svg/SVGFEMergeElement.cpp:
        (SVGFEMergeElement::SVGFEMergeElement):
        (SVGFEMergeElement::filterEffect):
        * ksvg2/svg/SVGFEOffsetElement.cpp:
        (SVGFEOffsetElement::filterEffect):
        * ksvg2/svg/SVGFEPointLightElement.cpp:
        (WebCore::SVGFEPointLightElement::SVGFEPointLightElement):
        (WebCore::SVGFEPointLightElement::lightSource):
        * ksvg2/svg/SVGFESpecularLightingElement.cpp:
        (SVGFESpecularLightingElement::filterEffect):
        * ksvg2/svg/SVGFESpotLightElement.cpp:
        (WebCore::SVGFESpotLightElement::lightSource):
        * ksvg2/svg/SVGFETileElement.cpp:
        (SVGFETileElement::filterEffect):
        * ksvg2/svg/SVGFETurbulenceElement.cpp:
        (SVGFETurbulenceElement::filterEffect):
        * ksvg2/svg/SVGFilterElement.cpp:
        (SVGFilterElement::canvasResource):
        * ksvg2/svg/SVGFilterPrimitiveStandardAttributes.cpp:
        (SVGFilterPrimitiveStandardAttributes::setStandardAttributes):
        * ksvg2/svg/SVGGradientElement.cpp:
        (SVGGradientElement::rebuildStops):
        * ksvg2/svg/SVGHelper.cpp:
        (WebCore::SVGHelper::PercentageOfViewport):
        * ksvg2/svg/SVGLineElement.cpp:
        (SVGLineElement::toPathData):
        (SVGLineElement::pushAttributeContext):
        (SVGLineElement::hasPercentageValues):
        * ksvg2/svg/SVGLinearGradientElement.cpp:
        (SVGLinearGradientElement::buildGradient):
        * ksvg2/svg/SVGMarkerElement.cpp:
        (WebCore::SVGMarkerElement::canvasResource):
        * ksvg2/svg/SVGMaskElement.cpp:
        (WebCore::SVGMaskElement::attributeChanged):
        (WebCore::SVGMaskElement::drawMaskerContent):
        * ksvg2/svg/SVGPatternElement.cpp:
        (WebCore::SVGPatternElement::pushAttributeContext):
        (WebCore::SVGPatternElement::fillAttributesFromReferencePattern):
        (WebCore::SVGPatternElement::drawPatternContentIntoTile):
        (WebCore::SVGPatternElement::notifyAttributeChange):
        (WebCore::SVGPatternElement::getCTM):
        * ksvg2/svg/SVGRadialGradientElement.cpp:
        (WebCore::SVGRadialGradientElement::buildGradient):
        * ksvg2/svg/SVGRectElement.cpp:
        (WebCore::SVGRectElement::toPathData):
        (WebCore::SVGRectElement::pushAttributeContext):
        (WebCore::SVGRectElement::hasPercentageValues):
        * ksvg2/svg/SVGSVGElement.cpp:
        (WebCore::SVGSVGElement::viewport):
        (WebCore::SVGSVGElement::parseMappedAttribute):
        (WebCore::SVGSVGElement::getCTM):
        (WebCore::SVGSVGElement::getScreenCTM):
        (WebCore::SVGSVGElement::createRenderer):
        * ksvg2/svg/SVGTRefElement.cpp:
        (SVGTRefElement::updateReferencedText):
        * ksvg2/svg/SVGUseElement.cpp:
        (SVGUseElement::closeRenderer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-09-08 Eric Seidel <eric@eseidel.com>
eseidel [Sat, 9 Sep 2006 01:46:18 +0000 (01:46 +0000)]
2006-09-08  Eric Seidel  <eric@eseidel.com>

        Reviewed by beth.

        Remove the last vestiges of KDOM (KDOMCSSValue and KDOMCSSValueList)
        http://bugzilla.opendarwin.org/show_bug.cgi?id=10778

        * ksvg2/css/SVGCSSParser.cpp:
        (WebCore::CSSParser::parseSVGValue):
        (WebCore::CSSParser::parseSVGStrokeDasharray):
        (WebCore::CSSParser::parseSVGPaint):
        (WebCore::CSSParser::parseSVGColor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Brady Eidson.
tomernic [Sat, 9 Sep 2006 01:35:04 +0000 (01:35 +0000)]
    Reviewed by Brady Eidson.

        Rolled out Maciej's code cleanup from 8/22.  It turns out that keeping the "loading" flag
        is a useful optimization, as it avoids many Objective-C method calls while polling resources
        for their load state.

        This fixes a 3-4% PLT performance regression (as measured on my MacBook Pro).

        * Loader/WebFrameLoader.m:
        (-[WebFrameLoader addPlugInStreamLoader:]):
        (-[WebFrameLoader removePlugInStreamLoader:]):
        (-[WebFrameLoader addSubresourceLoader:]):
        (-[WebFrameLoader removeSubresourceLoader:]):
        * WebView/WebDataSource.m:
        (-[WebDataSourcePrivate dealloc]):
        (-[WebDataSource _prepareForLoadStart]):
        (-[WebDataSource _setLoading:]):
        (-[WebDataSource _updateLoading]):
        (-[WebDataSource _startLoading]):
        (-[WebDataSource _stopLoading]):
        (-[WebDataSource _setPrimaryLoadComplete:]):
        (-[WebDataSource isLoading]):
        * WebView/WebDataSourceInternal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Adel.
kmccullo [Sat, 9 Sep 2006 00:11:01 +0000 (00:11 +0000)]
    Reviewed by Adel.

        - this patch brought to you by the letter 'c'

        * coding/coding-style.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoWebCore:
weinig [Thu, 7 Sep 2006 22:06:21 +0000 (22:06 +0000)]
WebCore:

        Reviewed by Darin and Tim H.

        Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10774
        Auto-generate the Objective-C DOM Traversal bindings

        - Auto-generates DOMNodeIterator and DOMTreeWalker.

        - Splits out DOMNodeFilter into its own file.

        * DerivedSources.make:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/objc/DOM.mm:
        * bindings/objc/DOMNodeFilter.h: Added.
        * bindings/objc/DOMTraversal.h:
        * bindings/objc/PublicDOMInterfaces.h:
        * bindings/scripts/CodeGeneratorObjC.pm:
        * dom/NodeFilter.idl:
        * dom/NodeIterator.idl:
        * dom/Range.idl:
        * dom/TreeWalker.idl:

WebKit:

        Reviewed by Darin and Tim H.

        Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10774
        Auto-generate the Objective-C DOM Traversal bindings

        * MigrateHeaders.make:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-09-07 MorganL <morlmor@yahoo.com>
aroben [Thu, 7 Sep 2006 18:45:10 +0000 (18:45 +0000)]
2006-09-07  MorganL  <morlmor@yahoo.com>

        Reviewed by Darin, landed by Adam.

        Fixes part of bug 10743: Windows build busted.

        * platform/win/FontCacheWin.cpp: Add missing #include, set svn:eol-style to native
        (WebCore::FontCache::getFontLinkInterface):
        (WebCore::FontCache::getFontDataForCharacters):
        * platform/win/FontDataWin.cpp: Ditto.
        (WebCore::FontData::platformWidthForGlyph):
        * platform/win/FontWin.cpp: Add missing #include, band-aid over const problem with GlyphBufferGlyph
        (WebCore::Font::drawGlyphs):
        * platform/win/ResourceLoaderWin.cpp: Add missing #include, change .ascii() to .latin1()
        (WebCore::ResourceLoaderWndProc):
        (WebCore::ResourceLoader::start):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin.
ap [Thu, 7 Sep 2006 17:37:13 +0000 (17:37 +0000)]
    Reviewed by Darin.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=10753
        REGRESSION: The beginning of a CSS file is missing

        Test: http/tests/incremental/slow-utf8-css.pl

        * loader/Decoder.cpp:
        (WebCore::Decoder::checkForCSSCharset): Use the same buffering logic as used for HTML.
        (WebCore::Decoder::decode):
        * loader/Decoder.h: Added a return value and a movedDataToBuffer parameter to
        checkForCSSCharset().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoWebCore:
weinig [Thu, 7 Sep 2006 17:08:48 +0000 (17:08 +0000)]
WebCore:

        Reviewed by Darin.

        Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10766
        Auto-generate the Objective-C DOM Events bindings

        - Auto-generates DOMEvent, DOMKeyboardEvent, DOMMouseEvent, DOMMutationEvent,
          DOMOverflowEvent, DOMUIEvent, and DOMWheelEvent.

        - Splits out DOMEventListener and DOMEventTarget into their own files.

        * DerivedSources.make:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/objc/DOMEventListener.h: Added.
        * bindings/objc/DOMEventTarget.h: Added.
        * bindings/objc/DOMEvents.h:
        * bindings/objc/DOMEvents.mm:
        (-[DOMEvent WebCore::]):
        (-[DOMEvent _initWithEvent:WebCore::]):
        (+[DOMEvent _eventWith:WebCore::]):
        * bindings/objc/DOMEventsNonstandard.mm: Removed.
        * bindings/objc/DOMNode.h:
        * bindings/objc/PublicDOMInterfaces.h:
        * bindings/scripts/CodeGenerator.pm:
        * bindings/scripts/CodeGeneratorObjC.pm:
        * dom/Event.idl:
        * dom/EventListener.idl: Added.
        * dom/EventTarget.idl: Added.
        * dom/KeyboardEvent.idl:
        * dom/MouseEvent.idl:
        * dom/UIEvent.idl:
        * dom/WheelEvent.idl:

WebKit:

        Reviewed by Darin.

        Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10766
        Auto-generate the Objective-C DOM Events bindings

        * MigrateHeaders.make:
        * WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16262 268f45cc-cd09-0410-ab3c-d52691b4dbfc