WebKit-https.git
10 years ago2011-02-26 David Levin <levin@chromium.org>
levin@chromium.org [Sat, 26 Feb 2011 14:45:10 +0000 (14:45 +0000)]
2011-02-26  David Levin  <levin@chromium.org>

        Reviewed by Darin Adler.

        Add style guidelines about comments from the unwritten rules email.
        https://bugs.webkit.org/show_bug.cgi?id=55272

        * coding/coding-style.html: Added the guidelines.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-26 Rik Cabanier <cabanier@adobe.com>
commit-queue@webkit.org [Sat, 26 Feb 2011 14:40:20 +0000 (14:40 +0000)]
2011-02-26  Rik Cabanier  <cabanier@adobe.com>

        Reviewed by David Hyatt.

        Fix that allows fixed length values to be floating point
        https://bugs.webkit.org/show_bug.cgi?id=52699

        Transitions now return matrices in floating point. 2 of the transition tests were failing
        because they expected integer values.

        * transitions/matched-transform-functions.html:
        * transitions/retargetted-transition.html:
2011-02-26  Rik Cabanier  <cabanier@adobe.com>

        Reviewed by David Hyatt.

        Fix that allows fixed length values to be floating point
        https://bugs.webkit.org/show_bug.cgi?id=52699

        Transitions now return matrices in floating point. 2 of the transition tests were failing
        because they expected integer values.

        * WebCore.xcodeproj/project.pbxproj:
        * css/CSSStyleSelector.cpp:
        (WebCore::convertToLength):
        (WebCore::convertToIntLength):
        (WebCore::convertToFloatLength):
        (WebCore::CSSStyleSelector::applyProperty):
        (WebCore::CSSStyleSelector::createTransformOperations):
        * platform/Length.h:
        (WebCore::Length::Length):
        (WebCore::Length::operator==):
        (WebCore::Length::operator!=):
        (WebCore::Length::rawValue):
        (WebCore::Length::type):
        (WebCore::Length::quirk):
        (WebCore::Length::setValue):
        (WebCore::Length::calcFloatValue):
        (WebCore::Length::isZero):
        (WebCore::Length::blend):
        (WebCore::Length::getIntValue):
        (WebCore::Length::getFloatValue):
        * rendering/AutoTableLayout.cpp:
        (WebCore::AutoTableLayout::recalcColumn):
        (WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
        * rendering/FixedTableLayout.cpp:
        (WebCore::FixedTableLayout::calcWidthArray):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-26 Kenneth Rohde Christiansen <kenneth@webkit.org>
kenneth@webkit.org [Sat, 26 Feb 2011 14:39:12 +0000 (14:39 +0000)]
2011-02-26  Kenneth Rohde Christiansen  <kenneth@webkit.org>

        Reviewed by Andreas Kling.

        Make it possible to test the targetdensity-dpi support
        https://bugs.webkit.org/show_bug.cgi?id=55142

        * fast/viewport/viewport-*.html: Update to new JS API.
        * fast/viewport/viewport-91.html: Add new tests.
        * fast/viewport/viewport-92.html:
        * fast/viewport/viewport-93.html:
        * fast/viewport/viewport-94.html:
        * fast/viewport/viewport-95.html:
        * fast/viewport/viewport-96.html:
2011-02-26  Kenneth Rohde Christiansen  <kenneth@webkit.org>

        Reviewed by Andreas Kling.

        Make it possible to test the targetdensity-dpi support
        https://bugs.webkit.org/show_bug.cgi?id=55142

        Test the viewport meta tag feature targetdensity-dpi by
        adding extra arguments to dumpConfigurationForViewport

        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
        (DumpRenderTreeSupportGtk::dumpConfigurationForViewport):
        * WebCoreSupport/DumpRenderTreeSupportGtk.h:
2011-02-26  Kenneth Rohde Christiansen  <kenneth@webkit.org>

        Reviewed by Andreas Kling.

        Make it possible to test the targetdensity-dpi support
        https://bugs.webkit.org/show_bug.cgi?id=55142

        Test the viewport meta tag feature targetdensity-dpi by
        adding extra arguments to dumpConfigurationForViewport

        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
        (DumpRenderTreeSupportQt::viewportAsText):
        * WebCoreSupport/DumpRenderTreeSupportQt.h:
2011-02-26  Kenneth Rohde Christiansen  <kenneth@webkit.org>

        Reviewed by Andreas Kling.

        Make it possible to test the targetdensity-dpi support
        https://bugs.webkit.org/show_bug.cgi?id=55142

        Test the viewport meta tag feature targetdensity-dpi by
        adding extra arguments to dumpConfigurationForViewport

        Add the new arguments to the shared header and all
        implementation.

        * DumpRenderTree/LayoutTestController.cpp:
        (dumpConfigurationForViewportCallback):
        * DumpRenderTree/LayoutTestController.h:
        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::dumpConfigurationForViewport):
        * DumpRenderTree/mac/LayoutTestControllerMac.mm:
        (LayoutTestController::dumpConfigurationForViewport):
        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
        (LayoutTestController::dumpConfigurationForViewport):
        * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
        (LayoutTestController::dumpConfigurationForViewport):
        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::dumpConfigurationForViewport):
        * DumpRenderTree/qt/LayoutTestControllerQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-26 Bill Budge <bbudge@chromium.org>
commit-queue@webkit.org [Sat, 26 Feb 2011 14:26:03 +0000 (14:26 +0000)]
2011-02-26  Bill Budge  <bbudge@chromium.org>

        Reviewed by David Levin.

        WebURLRequest, WebURLResponse properties should be passed to WebCore Layer
        https://bugs.webkit.org/show_bug.cgi?id=54489

        No tests needed. This is already tested by ui_tests, nacl_ui_tests, and nacl_sandbox_tests

        * src/WebURLRequest.cpp:
        (WebKit::WebURLRequestPrivateImpl::WebURLRequestPrivateImpl):
        (WebKit::WebURLRequest::downloadToFile):
        (WebKit::WebURLRequest::setDownloadToFile):
        * src/WebURLRequestPrivate.h:
        (WebKit::WebURLRequestPrivate::WebURLRequestPrivate):
        * src/WebURLResponse.cpp:
        (WebKit::WebURLResponsePrivateImpl::WebURLResponsePrivateImpl):
        (WebKit::WebURLResponse::downloadFilePath):
        (WebKit::WebURLResponse::setDownloadFilePath):
        * src/WebURLResponsePrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-26 Eric Seidel <eric@webkit.org>
eric@webkit.org [Sat, 26 Feb 2011 13:59:36 +0000 (13:59 +0000)]
2011-02-26  Eric Seidel  <eric@webkit.org>

        Reviewed by Maciej Stachowiak.

        malloc in removeChildren shows up on profile of peacekeeper domDynamicCreationCreateElement
        https://bugs.webkit.org/show_bug.cgi?id=55204

        * dom/ContainerNode.cpp:
        (WebCore::ContainerNode::removeChildren):
         - Using an inlineCapacity of 10 for now. We may want to tweak it later.
         - This removes yet another malloc from code which removes nodes (which is rather common).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-26 Eric Seidel <eric@webkit.org>
eric@webkit.org [Sat, 26 Feb 2011 13:47:13 +0000 (13:47 +0000)]
2011-02-26  Eric Seidel  <eric@webkit.org>

        Reviewed by Maciej Stachowiak.

        HashSet<T>::end() creation is expensive and should be avoided
        https://bugs.webkit.org/show_bug.cgi?id=55205

        In the common case, m_ranges is an empty set.  When that's
        the case, we spend all our time in skipEmptyBuckets, walking
        the hash storage skipping over empty buckets.

        This looks to be at least a 5% speedup on (my local version of) peacekeeper's domDynamicCreationCreateElement.

        Before:
        avg 383.6666666666667
        median 386
        stdev 7.152311203768722
        min 360
        max 391

        After:
        avg 366.3333333333333
        median 366
        stdev 2.712112747574399
        min 362
        max 377

        * dom/Document.cpp:
        (WebCore::Document::nodeChildrenChanged):
        (WebCore::Document::nodeChildrenWillBeRemoved):
        (WebCore::Document::nodeWillBeRemoved):
        (WebCore::Document::textInserted):
        (WebCore::Document::textRemoved):
        (WebCore::Document::textNodesMerged):
        (WebCore::Document::textNodeSplit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-26 Sheriff Bot <webkit.review.bot@gmail.com>
rniwa@webkit.org [Sat, 26 Feb 2011 13:15:58 +0000 (13:15 +0000)]
2011-02-26  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r79764.
        http://trac.webkit.org/changeset/79764
        https://bugs.webkit.org/show_bug.cgi?id=55295

        "broke Chromium builds" (Requested by rniwa on #webkit).

        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::resetTestController):
        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (resetDefaultsToConsistentValues):
        * DumpRenderTree/mac/DumpRenderTree.mm:
        (resetWebViewToConsistentStateBeforeTesting):
        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
        * DumpRenderTree/win/DumpRenderTree.cpp:
        (resetWebViewToConsistentStateBeforeTesting):
        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
        (WTR::InjectedBundlePage::reset):
2011-02-26  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r79764.
        http://trac.webkit.org/changeset/79764
        https://bugs.webkit.org/show_bug.cgi?id=55295

        "broke Chromium builds" (Requested by rniwa on #webkit).

        * public/WebFrame.h:
        * src/WebFrameImpl.cpp:
        * src/WebFrameImpl.h:
2011-02-26  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r79764.
        http://trac.webkit.org/changeset/79764
        https://bugs.webkit.org/show_bug.cgi?id=55295

        "broke Chromium builds" (Requested by rniwa on #webkit).

        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
        * WebCoreSupport/DumpRenderTreeSupportQt.h:
2011-02-26  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r79764.
        http://trac.webkit.org/changeset/79764
        https://bugs.webkit.org/show_bug.cgi?id=55295

        "broke Chromium builds" (Requested by rniwa on #webkit).

        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
        * WebCoreSupport/DumpRenderTreeSupportGtk.h:
2011-02-26  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r79764.
        http://trac.webkit.org/changeset/79764
        https://bugs.webkit.org/show_bug.cgi?id=55295

        "broke Chromium builds" (Requested by rniwa on #webkit).

        * Interfaces/IWebFramePrivate.idl:
        * Interfaces/WebKit.idl:
        * WebFrame.cpp:
        * WebFrame.h:
2011-02-26  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r79764.
        http://trac.webkit.org/changeset/79764
        https://bugs.webkit.org/show_bug.cgi?id=55295

        "broke Chromium builds" (Requested by rniwa on #webkit).

        * WebView/WebFrame.mm:
        * WebView/WebFramePrivate.h:
2011-02-26  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r79764.
        http://trac.webkit.org/changeset/79764
        https://bugs.webkit.org/show_bug.cgi?id=55295

        "broke Chromium builds" (Requested by rniwa on #webkit).

        * WebCore.exp.in:
2011-02-26  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r79764.
        http://trac.webkit.org/changeset/79764
        https://bugs.webkit.org/show_bug.cgi?id=55295

        "broke Chromium builds" (Requested by rniwa on #webkit).

        * WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
        * WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-26 Adam Klein <adamk@chromium.org>
commit-queue@webkit.org [Sat, 26 Feb 2011 13:14:04 +0000 (13:14 +0000)]
2011-02-26  Adam Klein  <adamk@chromium.org>

        Reviewed by Adam Barth.

        [fileapi] Implement EntrySync.toURI by moving Entry::toURI to EntryBase
        https://bugs.webkit.org/show_bug.cgi?id=54585

        * fast/filesystem/resources/file-entry-to-uri-sync.js: Added.
        * fast/filesystem/workers/file-entry-to-uri-sync-expected.txt: Added.
        * fast/filesystem/workers/file-entry-to-uri-sync.html: Added.
2011-02-26  Adam Klein  <adamk@chromium.org>

        Reviewed by Adam Barth.

        [fileapi] Implement EntrySync.toURI by moving Entry::toURI to EntryBase
        https://bugs.webkit.org/show_bug.cgi?id=54585

        In order to move toURI to EntryBase, it needed access to
        SecurityOrigin. Most of the changes below were to pass a
        ScriptExecutionContext to DOMFileSystemBase to enable this.

        Test: fast/filesystem/workers/file-entry-to-uri-sync.html

        * WebCore.gypi:
        * WebCore.xcodeproj/project.pbxproj:
        * fileapi/DOMFileSystem.cpp:
        (WebCore::DOMFileSystem::DOMFileSystem):
        * fileapi/DOMFileSystemBase.cpp:
        (WebCore::DOMFileSystemBase::DOMFileSystemBase):
        (WebCore::DOMFileSystemBase::securityOrigin):
        * fileapi/DOMFileSystemBase.h:
        (WebCore::DOMFileSystemBase::create):
        * fileapi/DOMFileSystemSync.cpp:
        (WebCore::DOMFileSystemSync::create):
        (WebCore::DOMFileSystemSync::DOMFileSystemSync):
        * fileapi/DOMFileSystemSync.h:
        (WebCore::DOMFileSystemSync::create):
        * fileapi/Entry.cpp:
        * fileapi/Entry.h:
        * fileapi/EntryBase.cpp: Added.
        (WebCore::EntryBase::EntryBase):
        (WebCore::EntryBase::~EntryBase):
        (WebCore::EntryBase::toURI):
        * fileapi/EntryBase.h:
        * fileapi/EntrySync.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-26 Alice Boxhall <aboxhall@chromium.org>
commit-queue@webkit.org [Sat, 26 Feb 2011 12:12:13 +0000 (12:12 +0000)]
2011-02-26  Alice Boxhall  <aboxhall@chromium.org>

        Reviewed by Ojan Vafai.

        Tests that typing enter in the input element does not fire textInput.
        https://bugs.webkit.org/show_bug.cgi?id=54152

        * fast/forms/textinput-not-fired-on-enter-in-input-expected.txt: Added.
        * fast/forms/textinput-not-fired-on-enter-in-input.html: Added.
2011-02-26  Alice Boxhall  <aboxhall@chromium.org>

        Reviewed by Ojan Vafai.

        typing enter in the input element should not fire textInput
        https://bugs.webkit.org/show_bug.cgi?id=54152

        Stop textInput event propagation in HTMLInputElement::preDispatchEventHandler if the event target should submit implicitly.

        Test: fast/forms/textinput-not-fired-on-enter-in-input.html

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::preDispatchEventHandler): Check m_inputType->shouldSubmitImplicitly for textInputEvents and stop propagation if true.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-26 James Simonsen <simonjam@chromium.org>
simonjam@chromium.org [Sat, 26 Feb 2011 12:04:55 +0000 (12:04 +0000)]
2011-02-26  James Simonsen  <simonjam@chromium.org>

        Reviewed by Tony Gentilcore.

        [Web Timing] loadEvent timing should refer to first load event if there are many
        https://bugs.webkit.org/show_bug.cgi?id=55201

        * fast/dom/script-tests/webtiming-document-open.js:
        (testTimingWithDocumentOpen): Fire via setTimeout to match w3c test and reveal loadEventEnd.
        (finishTest): Fire via setTimeout to match w3c test.
2011-02-26  James Simonsen  <simonjam@chromium.org>

        Reviewed by Tony Gentilcore.

        [Web Timing] loadEvent timing should refer to first load event if there are many
        https://bugs.webkit.org/show_bug.cgi?id=55201

        Test: fast/dom/webtiming-document-open.html

        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::dispatchLoadEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-26 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Sat, 26 Feb 2011 11:20:11 +0000 (11:20 +0000)]
2011-02-26  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Adam Barth.

        Fix isLayoutTimerActive for ports that set a minimumLayoutDelay
        https://bugs.webkit.org/show_bug.cgi?id=54810

        No new tests because no new functionality.

        * dom/Document.cpp:
        (WebCore::Document::isLayoutTimerActive): Moved from HTMLParserScheduler per FIXME. Compare
        minimumLayoutDelay() to m_extraLayoutDelay instead of 0. This spirit of this comparison was
        broken by r52919. The effect would be that ports that set an extra layout delay can't yield
        between tokens. Note: can't be const because minimumLayoutDelay sets a member.
        * dom/Document.h:
        * html/parser/HTMLParserScheduler.cpp:
        (WebCore::HTMLParserScheduler::continueNextChunkTimerFired):
        (WebCore::HTMLParserScheduler::checkForYieldBeforeScript):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-26 David Dorwin <ddorwin@chromium.org>
commit-queue@webkit.org [Sat, 26 Feb 2011 10:17:48 +0000 (10:17 +0000)]
2011-02-26  David Dorwin  <ddorwin@chromium.org>

        Reviewed by Darin Fisher.

        Enable WebKit Full Screen API in Chromium. The element becomes the full size of the window, but the window is not yet full screen. Support is disabled by default.

        fullscreen javascript bindings not implemented for v8
        https://bugs.webkit.org/show_bug.cgi?id=44797

        Tested by the existing fullscreen Layout Tests.

        * WebCore.gyp/WebCore.gyp:
        * WebCore.gypi:
2011-02-26  David Dorwin  <ddorwin@chromium.org>

        Reviewed by Darin Fisher.

        Enable WebKit Full Screen API in Chromium. The element becomes the full size of the window, but the window is not yet full screen. Support is disabled by default.

        fullscreen javascript bindings not implemented for v8
        https://bugs.webkit.org/show_bug.cgi?id=44797

        * features.gypi:
        * public/WebSettings.h:
        * src/ChromeClientImpl.cpp:
        (WebKit::ChromeClientImpl::supportsFullScreenForElement):
        (WebKit::ChromeClientImpl::enterFullScreenForElement):
        (WebKit::ChromeClientImpl::exitFullScreenForElement):
        (WebKit::ChromeClientImpl::fullScreenRendererChanged):
        * src/ChromeClientImpl.h:
        * src/WebSettingsImpl.cpp:
        (WebKit::WebSettingsImpl::setFullScreenEnabled):
        * src/WebSettingsImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-26 Thouraya ANDOLSI <thouraya.andolsi@st.com>
commit-queue@webkit.org [Sat, 26 Feb 2011 10:11:10 +0000 (10:11 +0000)]
2011-02-26  Thouraya ANDOLSI  <thouraya.andolsi@st.com>

        Reviewed by Nikolas Zimmermann.

        SH4 JIT SUPPORT
        https://bugs.webkit.org/show_bug.cgi?id=44329

        Provide an ExecutableAllocater::cacheFlush() implementation for
        Linux/SH4.

        * jit/ExecutableAllocator.h:
        (JSC::ExecutableAllocator::cacheFlush):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-26 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Sat, 26 Feb 2011 09:45:44 +0000 (09:45 +0000)]
2011-02-26  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Adam Barth.

        Prevent parser yields from triggering early dumpAsText()
        https://bugs.webkit.org/show_bug.cgi?id=55187

        DRT's dumpAsText() takes a snapshot when DocumentLoader::isLoadingInAPISense()
        indicates the page is done. isLoadingInAPISense depends on
        HTMLDocumentParser::isProcessingData(), which just checks if the parser is in an
        insert() or append().

        This means that if the parser is pumping in a resumeParsingAfterScriptExecution() or
        resumeParsingAfterYield(), isLoadingInAPISense() may not be blocked. This patch
        fixes that by repurposing m_writeNestingLevel as m_pumpSessionNestingLevel and
        incrementing it in pumpTokenizer().

        When I locally cause the parser to yield after every token, a lot of tests fail
        because DRT snapshots too early. This patch fixes those tests, however I'm having
        trouble writing a test case that reliably reproduces the problem without this patch
        and passes with it (without changing yield constants). This is because it requires
        4,096 tokens in a single pump session to yield and (len('<b>' * 4096 = 12k, which
        doesn't always happen).

        * html/parser/HTMLDocumentParser.cpp:
        (WebCore::HTMLDocumentParser::HTMLDocumentParser):
        (WebCore::HTMLDocumentParser::~HTMLDocumentParser):
        (WebCore::HTMLDocumentParser::processingData):
        (WebCore::HTMLDocumentParser::pumpTokenizer):
        (WebCore::HTMLDocumentParser::insert):
        (WebCore::HTMLDocumentParser::append):
        * html/parser/HTMLDocumentParser.h:
        (WebCore::HTMLDocumentParser::inPumpSession):
        (WebCore::HTMLDocumentParser::shouldDelayEnd):
        * html/parser/HTMLParserScheduler.h:
        (WebCore::PumpSession::PumpSession):
        * html/parser/NestingLevelIncrementer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-26 Yongjun Zhang <yongjun_zhang@apple.com>
commit-queue@webkit.org [Sat, 26 Feb 2011 09:32:19 +0000 (09:32 +0000)]
2011-02-26  Yongjun Zhang  <yongjun_zhang@apple.com>

        Reviewed by David Kilzer.

        https://bugs.webkit.org/show_bug.cgi?id=48781

        Add a resource load delegate method to query if WebCore should paint the default broken image for failed images.

        * fast/images/resources/broken-image-with-invalid-format.png: Added.
        * fast/images/support-broken-image-delegate.html: Added.
        * platform/mac/fast/images/support-broken-image-delegate-expected.txt: Added.
2011-02-26  Yongjun Zhang  <yongjun_zhang@apple.com>

        Reviewed by David Kilzer.

        https://bugs.webkit.org/show_bug.cgi?id=48781

        Add a resource load delegate method to query if WebCore should paint the default broken image for failed images.

        Add a new resource load client method (shouldPaintBrokenImage).  WebKit client can decide if WebCore
        should paint the default broken image when an image fails to load or decode.  The method also passes the
        URL of the failed image.

        Test: fast/images/support-broken-image-delegate.html

        * loader/FrameLoaderClient.h:
        (WebCore::FrameLoaderClient::shouldPaintBrokenImage):
        * loader/cache/CachedImage.cpp:
        (WebCore::CachedImage::CachedImage):
        (WebCore::CachedImage::image):
        (WebCore::CachedImage::checkShouldPaintBrokenImage):
        (WebCore::CachedImage::error):
        * loader/cache/CachedImage.h:
2011-02-26  Yongjun Zhang  <yongjun_zhang@apple.com>

        Reviewed by David Kilzer.

        https://bugs.webkit.org/show_bug.cgi?id=48781

        Add a resource load delegate method to query if WebCore should paint the default broken image for failed images.

        Add a new resource load client method (shouldPaintBrokenImage).  WebKit client can decide if WebCore
        should paint the default broken image when an image fails to load or decode.  The method also passes the
        URL of the failed image.

        * WebCoreSupport/WebFrameLoaderClient.h:
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::shouldPaintBrokenImage):
        * WebView/WebDelegateImplementationCaching.h:
        * WebView/WebDelegateImplementationCaching.mm: Added case for passing one object.
        (CallResourceLoadDelegateReturningBoolean):
        * WebView/WebResourceLoadDelegatePrivate.h:
        * WebView/WebView.mm:
        (-[WebView _cacheResourceLoadDelegateImplementations]):
2011-02-26  Yongjun Zhang  <yongjun_zhang@apple.com>

        Reviewed by David Kilzer.

        https://bugs.webkit.org/show_bug.cgi?id=48781

        Add a resource load delegate method to query if WebCore should paint the default broken image for failed images.

        Add a new resource load client method (shouldPaintBrokenImage).  WebKit client can decide if WebCore
        should paint the default broken image when an image fails to load or decode.

        * DumpRenderTree/LayoutTestController.cpp:
        (LayoutTestController::LayoutTestController):
        (setShouldPaintBrokenImageCallback):
        (LayoutTestController::staticFunctions):
        (LayoutTestController::setShouldPaintBrokenImage):
        * DumpRenderTree/LayoutTestController.h:
        (LayoutTestController::shouldPaintBrokenImage):
        * DumpRenderTree/mac/ResourceLoadDelegate.mm:
        (-[ResourceLoadDelegate webView:shouldPaintBrokenImageForURL:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-26 Eric Seidel <eric@webkit.org>
eric@webkit.org [Sat, 26 Feb 2011 09:24:26 +0000 (09:24 +0000)]
2011-02-26  Eric Seidel  <eric@webkit.org>

        Reviewed by Alexey Proskuryakov.

        Remove disabled xmlhttprequest/web-apps tests
        https://bugs.webkit.org/show_bug.cgi?id=55181

        Per ap's suggestion in:
        https://bugs.webkit.org/show_bug.cgi?id=55164#c15

        I don't think we've ever run these tests.  Some of them
        depend on 10 minute timeouts and another nonsense. :)

        * http/tests/xmlhttprequest/web-apps/006-test.cgi: Removed.
        * http/tests/xmlhttprequest/web-apps/006.html-disabled: Removed.
        * http/tests/xmlhttprequest/web-apps/009-test.cgi: Removed.
        * http/tests/xmlhttprequest/web-apps/009.html-disabled: Removed.
        * http/tests/xmlhttprequest/web-apps/016-test.cgi: Removed.
        * http/tests/xmlhttprequest/web-apps/016.html-disabled: Removed.
        * http/tests/xmlhttprequest/web-apps/017.html-disabled: Removed.
        * http/tests/xmlhttprequest/web-apps/recursion/001.html-disabled: Removed.
        * http/tests/xmlhttprequest/web-apps/recursion/README: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-26 Chris Evans <cevans@chromium.org>
commit-queue@webkit.org [Sat, 26 Feb 2011 09:16:01 +0000 (09:16 +0000)]
2011-02-26  Chris Evans  <cevans@chromium.org>

        Reviewed by Adam Barth.

        Database: Data race: should only touch the transaction queue inside the
        lock.
        https://bugs.webkit.org/show_bug.cgi?id=55031

        * storage/Database.cpp:
        (WebCore::Database::changeVersion): only touch queue inside lock.
        (WebCore::Database::runTransaction): only touch queue inside lock.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-26 Yi Shen <yi.4.shen@nokia.com>
yi.4.shen@nokia.com [Sat, 26 Feb 2011 09:03:34 +0000 (09:03 +0000)]
2011-02-26  Yi Shen  <yi.4.shen@nokia.com>

        Reviewed by Eric Carlson.

        Missing volumechangeEvent in case of mediaPlayerVolumeChanged gets callback
        https://bugs.webkit.org/show_bug.cgi?id=55147

        When HTMLMediaElement::mediaPlayerVolumeChanged() gets callback,
        a volumechangeEvent event should be fired if the volume gets changed.

        Test: media/event-attributes.html

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::setMuted): Remove updateVolume() since it does nothing when m_player is 0.
        (WebCore::HTMLMediaElement::mediaPlayerVolumeChanged): Fire a volumechangeEvent when the volume is changed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-26 John Mellor <johnme@chromium.org>
commit-queue@webkit.org [Sat, 26 Feb 2011 08:59:38 +0000 (08:59 +0000)]
2011-02-26  John Mellor  <johnme@chromium.org>

        Reviewed by Antonio Gomes.

        [chromium] WebFrameImpl::m_totalMatchCount should be an int
        https://bugs.webkit.org/show_bug.cgi?id=55134

        WebFrameImpl::m_totalMatchCount should be an int instead of a size_t since it can be -1.

        * src/WebFrameImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-26 Eric Seidel <eric@webkit.org>
eric@webkit.org [Sat, 26 Feb 2011 08:41:55 +0000 (08:41 +0000)]
2011-02-26  Eric Seidel  <eric@webkit.org>

        Reviewed by Maciej Stachowiak.

        disableRangeMutation quirk for mail slows down peacekeeper domDynamicCreationCreateElement
        https://bugs.webkit.org/show_bug.cgi?id=55127

        Before:
        avg 513.4
        median 515
        stdev 7.234638899074368
        min 490
        max 528

        After:
        avg 508.15
        median 510
        stdev 6.966168243733426
        min 485
        max 515

        Yes, the stdev is a bit high to actually support my conclusions.  But looking
        at the profile, this change makes a lot of sense.  I'll up the iterations
        for future testing.

        * dom/Document.cpp:
        (WebCore::disableRangeMutation):
         - This check should only be compiled in if we're planning to run on Tiger or Leopard.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-26 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 26 Feb 2011 08:35:29 +0000 (08:35 +0000)]
2011-02-26  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Synchronized tests with html5lib
        https://bugs.webkit.org/show_bug.cgi?id=55128

        I didn't copy all of plain-test-unsafe because it confuses pretty-diff.

        * html5lib/resources/pending-spec-changes-plain-text-unsafe.dat:
        * html5lib/resources/pending-spec-changes.dat:
        * html5lib/resources/tests1.dat:
        * html5lib/resources/tests10.dat:
        * html5lib/resources/tests19.dat:
        * html5lib/resources/tests20.dat:
        * html5lib/resources/tests22.dat: Added.
        * html5lib/resources/tests23.dat: Added.
        * html5lib/resources/tests24.dat: Added.
        * html5lib/resources/tests25.dat: Added.
        * html5lib/resources/tests26.dat: Added.
        * html5lib/resources/tests3.dat:
        * html5lib/resources/tests6.dat:
        * html5lib/runner-expected.txt:
        * html5lib/runner.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>
commit-queue@webkit.org [Sat, 26 Feb 2011 08:16:26 +0000 (08:16 +0000)]
2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Pavel Feldman.

        DumpRenderTree should reset frame opener between tests.
        https://bugs.webkit.org/show_bug.cgi?id=54874

        No new tests. (no code affected, just exporting a method for DumpRenderTree use)

        * WebCore.exp.in:
2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Pavel Feldman.

        DumpRenderTree should reset frame opener between tests.
        https://bugs.webkit.org/show_bug.cgi?id=54874

        Added clearOpener method to WebFrame.

        * public/WebFrame.h:
        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::clearOpener):
        * src/WebFrameImpl.h:
2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Pavel Feldman.

        DumpRenderTree should reset frame opener between tests.
        https://bugs.webkit.org/show_bug.cgi?id=54874

        Added clearOpener method to DumpRenderTreeSupportGTK.

        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
        (DumpRenderTreeSupportGtk::clearOpener):
        * WebCoreSupport/DumpRenderTreeSupportGtk.h:
2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Pavel Feldman.

        DumpRenderTree should reset frame opener between tests.
        https://bugs.webkit.org/show_bug.cgi?id=54874

        Added clearOpener method to WebFramePrivate.

        * WebView/WebFrame.mm:
        (-[WebFrame _clearOpener]):
        * WebView/WebFramePrivate.h:
2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Pavel Feldman.

        DumpRenderTree should reset frame opener between tests.
        https://bugs.webkit.org/show_bug.cgi?id=54874

        Added clearOpener method to DumpRenderTreeSupportQT.

        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
        (DumpRenderTreeSupportQt::clearOpener):
        * WebCoreSupport/DumpRenderTreeSupportQt.h:
2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Pavel Feldman.

        DumpRenderTree should reset frame opener between tests.
        https://bugs.webkit.org/show_bug.cgi?id=54874

        Added clearOpener method to IWebFramePrivate.
        Touched WebKit.idl to trigger build scripts.

        * Interfaces/IWebFramePrivate.idl:
        * Interfaces/WebKit.idl:
        * WebFrame.cpp:
        (WebFrame::clearOpener):
        * WebFrame.h:
2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Pavel Feldman.

        DumpRenderTree should reset frame opener between tests.
        https://bugs.webkit.org/show_bug.cgi?id=54874

        Added clearOpener method to WKBundleWebFramePrivate.

        * WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
        (WKBundleFrameClearOpener):
        * WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:
2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Pavel Feldman.

        DumpRenderTree should reset frame opener between tests.
        https://bugs.webkit.org/show_bug.cgi?id=54874

        Added clearOpener() calls between tests.
        Some tests are using window.open() to change current window location.
        This changes window.opener property whose nullity is checked before
        showing xml viewer.

        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::resetTestController):
        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (resetDefaultsToConsistentValues):
        * DumpRenderTree/mac/DumpRenderTree.mm:
        (resetWebViewToConsistentStateBeforeTesting):
        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
        * DumpRenderTree/win/DumpRenderTree.cpp:
        (resetWebViewToConsistentStateBeforeTesting):
        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
        (WTR::InjectedBundlePage::reset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-26 Xianzhu Wang <wangxianzhu@google.com>
commit-queue@webkit.org [Sat, 26 Feb 2011 08:13:30 +0000 (08:13 +0000)]
2011-02-26  Xianzhu Wang  <wangxianzhu@google.com>

        Reviewed by Eric Seidel.

        Fix Chromium test failure http://crbug.com/33358
        https://bugs.webkit.org/show_bug.cgi?id=55125

        * platform/chromium/test_expectations.txt:
        * platform/chromium/fast/dom/Window/window-postmessage-clone-frames-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-26 Chang Shu <chang.shu@nokia.com>
chang.shu@nokia.com [Sat, 26 Feb 2011 08:12:23 +0000 (08:12 +0000)]
2011-02-26  Chang Shu  <chang.shu@nokia.com>

        Reviewed by Antonio Gomes.

        Spatial Navigation: Add support for <select> element in multiple selection mode
        https://bugs.webkit.org/show_bug.cgi?id=49261

        Enhanced existing tests and added new tests for the bug.

        * fast/spatial-navigation/snav-multiple-select-expected.txt:
        * fast/spatial-navigation/snav-multiple-select.html:
        * fast/spatial-navigation/snav-single-select-list-expected.txt: Added.
        * fast/spatial-navigation/snav-single-select-list.html: Added.
2011-02-26  Chang Shu  <chang.shu@nokia.com>

        Reviewed by Antonio Gomes.

        Based on patch by Carlos Garcia Campos  <cgarcia@igalia.com>.

        Spatial Navigation: Add support for <select> element in multiple selection mode
        https://bugs.webkit.org/show_bug.cgi?id=49261

        When spatial navigation is enabled, use space key to toggle select
        items. And the up and down keys should not affect selection but just
        navigate through items, which is indicated visually by a focus ring.

        New Test: fast/spatial-navigation/snav-single-select-list.html
        Enhanced Test: fast/spatial-navigation/snav-multiple-select.html

        * dom/SelectElement.cpp:
        (WebCore::SelectElement::listBoxDefaultEventHandler):
        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::addFocusRingRects):
        * rendering/RenderListBox.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-25 Lukasz Slachciak <l.slachciak@samsung.com>
commit-queue@webkit.org [Sat, 26 Feb 2011 07:55:07 +0000 (07:55 +0000)]
2011-02-25  Lukasz Slachciak  <l.slachciak@samsung.com>

        Reviewed by Kenneth Rohde Christiansen.

        [EFL] Added EWebLauncher command line option to turn on/off frame flattening
        https://bugs.webkit.org/show_bug.cgi?id=54809

        * EWebLauncher/main.c: Handling -f option added.
        (on_key_down):
        (browserCreate):
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-25 Ryosuke Niwa <rniwa@webkit.org>
eric@webkit.org [Sat, 26 Feb 2011 07:33:44 +0000 (07:33 +0000)]
2011-02-25  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        Make positioned elements work with vertical text
        https://bugs.webkit.org/show_bug.cgi?id=46500

        Rebaseline fast/table/fixed-with-auto-with-colspan-vertical.html for r79725.

        * platform/gtk/fast/table/fixed-with-auto-with-colspan-vertical-expected.txt:
        * platform/mac/fast/table/fixed-with-auto-with-colspan-vertical-expected.checksum:
        * platform/mac/fast/table/fixed-with-auto-with-colspan-vertical-expected.png:
        * platform/mac/fast/table/fixed-with-auto-with-colspan-vertical-expected.txt:
        * platform/qt/fast/table/fixed-with-auto-with-colspan-vertical-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-25 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Sat, 26 Feb 2011 05:35:56 +0000 (05:35 +0000)]
2011-02-25  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed Qt build fix; included CSSValueList.h in EditingStyle.cpp.

        * editing/EditingStyle.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-25 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Sat, 26 Feb 2011 05:26:30 +0000 (05:26 +0000)]
2011-02-25  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        Move HTMLEquivalent and its subclasses to EditingStyle
        https://bugs.webkit.org/show_bug.cgi?id=55207

        Moved HTMLEquivalent and its subclasses from ApplyStyleCommand to EditingStyle,
        and renamed HTMLEquivalent, HTMLEquivalentValueList, HTMLAttributeEquivalent,
        and HTMLEquivalentFontSizeAttribute to HTMLElementEquivalent, HTMLTextDecorationEquivalent,
        HTMLAttributeEquivalent, and HTMLFontSizeEquivalent respectively.

        Also extracted the logic to determine which element and attribute are removed
        as conflictsWithImplicitStyleOfElement, conflictsWithImplicitStyleOfAttributes,
        and extractConflictingImplicitStyleOfAttributes.

        * editing/ApplyStyleCommand.cpp:
        (WebCore::ApplyStyleCommand::removeInlineStyleFromElement):
        (WebCore::ApplyStyleCommand::removeImplicitlyStyledElement):
        * editing/ApplyStyleCommand.h:
        * editing/EditingStyle.cpp:
        (WebCore::HTMLElementEquivalent::create): Moved from ApplyStyleCommand.cpp.
        (WebCore::HTMLElementEquivalent::~HTMLElementEquivalent): Ditto.
        (WebCore::HTMLElementEquivalent::matches): Ditto.
        (WebCore::HTMLElementEquivalent::hasAttribute): Ditto.
        (WebCore::HTMLElementEquivalent::propertyExistsInStyle): Ditto.
        (WebCore::HTMLElementEquivalent::HTMLElementEquivalent): Ditto.
        (WebCore::HTMLElementEquivalent::valueIsPresentInStyle): Ditto.
        (WebCore::HTMLElementEquivalent::addToStyle): Ditto.
        (WebCore::HTMLTextDecorationEquivalent::create): Ditto.
        (WebCore::HTMLTextDecorationEquivalent::HTMLTextDecorationEquivalent): Ditto.
        (WebCore::HTMLTextDecorationEquivalent::valueIsPresentInStyle): Ditto.
        (WebCore::HTMLAttributeEquivalent::create): Ditto.
        (WebCore::HTMLAttributeEquivalent::matches): Ditto.
        (WebCore::HTMLAttributeEquivalent::hasAttribute): Ditto.
        (WebCore::HTMLAttributeEquivalent::attributeName): Ditto.
        (WebCore::HTMLAttributeEquivalent::HTMLAttributeEquivalent): Ditto.
        (WebCore::HTMLAttributeEquivalent::valueIsPresentInStyle): Ditto.
        (WebCore::HTMLAttributeEquivalent::addToStyle): Ditto.
        (WebCore::HTMLAttributeEquivalent::attributeValueAsCSSValue): Ditto.
        (WebCore::HTMLFontSizeEquivalent::create): Ditto.
        (WebCore::HTMLFontSizeEquivalent::HTMLFontSizeEquivalent): Ditto.
        (WebCore::HTMLFontSizeEquivalent::attributeValueAsCSSValue): Ditto.
        (WebCore::EditingStyle::conflictsWithImplicitStyleOfElement): Added.
        (WebCore::htmlAttributeEquivalents): Added.
        (WebCore::EditingStyle::conflictsWithImplicitStyleOfAttributes): Added.
        (WebCore::EditingStyle::extractConflictingImplicitStyleOfAttributes): Added.
        * editing/EditingStyle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-25 James Robinson <jamesr@chromium.org>
jamesr@google.com [Sat, 26 Feb 2011 02:49:04 +0000 (02:49 +0000)]
2011-02-25  James Robinson  <jamesr@chromium.org>

        Update chromium expectations and add new chromium and mac-leopard baselines for new tests.

        * platform/chromium-linux/fast/block/positioning/differing-writing-modes-expected.checksum: Added.
        * platform/chromium-linux/fast/block/positioning/differing-writing-modes-expected.png: Added.
        * platform/chromium-linux/fast/block/positioning/differing-writing-modes-replaced-expected.checksum: Added.
        * platform/chromium-linux/fast/block/positioning/differing-writing-modes-replaced-expected.png: Added.
        * platform/chromium-linux/fast/table/table-continuation-outline-paint-crash-expected.checksum: Added.
        * platform/chromium-linux/fast/table/table-continuation-outline-paint-crash-expected.png: Added.
        * platform/chromium-win/fast/block/positioning/differing-writing-modes-expected.checksum: Added.
        * platform/chromium-win/fast/block/positioning/differing-writing-modes-expected.png: Added.
        * platform/chromium-win/fast/block/positioning/differing-writing-modes-expected.txt: Added.
        * platform/chromium-win/fast/block/positioning/differing-writing-modes-replaced-expected.checksum: Added.
        * platform/chromium-win/fast/block/positioning/differing-writing-modes-replaced-expected.png: Added.
        * platform/chromium-win/fast/block/positioning/differing-writing-modes-replaced-expected.txt: Added.
        * platform/chromium-win/fast/table/table-continuation-outline-paint-crash-expected.checksum: Added.
        * platform/chromium-win/fast/table/table-continuation-outline-paint-crash-expected.png: Added.
        * platform/chromium-win/fast/table/table-continuation-outline-paint-crash-expected.txt: Added.
        * platform/chromium/test_expectations.txt:
        * platform/mac-leopard/fast/block/positioning/differing-writing-modes-expected.checksum: Added.
        * platform/mac-leopard/fast/block/positioning/differing-writing-modes-expected.png: Added.
        * platform/mac-leopard/fast/block/positioning/differing-writing-modes-replaced-expected.checksum: Added.
        * platform/mac-leopard/fast/block/positioning/differing-writing-modes-replaced-expected.png: Added.
        * platform/mac-leopard/fast/table/table-continuation-outline-paint-crash-expected.checksum: Added.
        * platform/mac-leopard/fast/table/table-continuation-outline-paint-crash-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoVersioning.
mrowe@apple.com [Sat, 26 Feb 2011 02:45:08 +0000 (02:45 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-25 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Sat, 26 Feb 2011 02:18:03 +0000 (02:18 +0000)]
2011-02-25  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed rebaseline.

        Update mac/ pixel baselines for Snow Leopard (new results match
        chromium-mac and/or chromium-mac-leopard ones, which are known to be
        good).

        * platform/mac/fast/backgrounds/svg-as-background-5-expected.checksum:
        * platform/mac/fast/backgrounds/svg-as-background-5-expected.png:
        * platform/mac/fast/block/margin-collapse/103-expected.checksum:
        * platform/mac/fast/block/margin-collapse/103-expected.png:
        * platform/mac/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum:
        * platform/mac/fast/blockflow/japanese-ruby-vertical-lr-expected.png:
        * platform/mac/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum:
        * platform/mac/fast/blockflow/japanese-ruby-vertical-rl-expected.png:
        * platform/mac/fast/css/empty-pseudo-class-expected.checksum:
        * platform/mac/fast/css/empty-pseudo-class-expected.png:
        * platform/mac/fast/css/first-child-pseudo-class-expected.checksum:
        * platform/mac/fast/css/first-child-pseudo-class-expected.png:
        * platform/mac/fast/css/first-of-type-pseudo-class-expected.checksum:
        * platform/mac/fast/css/first-of-type-pseudo-class-expected.png:
        * platform/mac/fast/css/font-face-default-font-expected.checksum:
        * platform/mac/fast/css/font-face-default-font-expected.png:
        * platform/mac/fast/css/font_property_normal-expected.checksum:
        * platform/mac/fast/css/font_property_normal-expected.png:
        * platform/mac/fast/css/last-child-pseudo-class-expected.checksum:
        * platform/mac/fast/css/last-child-pseudo-class-expected.png:
        * platform/mac/fast/css/last-of-type-pseudo-class-expected.checksum:
        * platform/mac/fast/css/last-of-type-pseudo-class-expected.png:
        * platform/mac/fast/css/line-height-font-order-expected.checksum:
        * platform/mac/fast/css/line-height-font-order-expected.png:
        * platform/mac/fast/css/only-child-pseudo-class-expected.checksum:
        * platform/mac/fast/css/only-child-pseudo-class-expected.png:
        * platform/mac/fast/css/only-of-type-pseudo-class-expected.checksum:
        * platform/mac/fast/css/only-of-type-pseudo-class-expected.png:
        * platform/mac/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.checksum:
        * platform/mac/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.png:
        * platform/mac/fast/dynamic/008-expected.checksum:
        * platform/mac/fast/dynamic/008-expected.png:
        * platform/mac/fast/events/context-no-deselect-expected.checksum:
        * platform/mac/fast/events/context-no-deselect-expected.png:
        * platform/mac/fast/forms/placeholder-position-expected.checksum:
        * platform/mac/fast/forms/placeholder-position-expected.png:
        * platform/mac/fast/html/keygen-expected.checksum:
        * platform/mac/fast/html/keygen-expected.png:
        * platform/mac/fast/lists/dynamic-marker-crash-expected.checksum:
        * platform/mac/fast/lists/dynamic-marker-crash-expected.png:
        * platform/mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.checksum:
        * platform/mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.png:
        * platform/mac/fast/selectors/166-expected.checksum:
        * platform/mac/fast/selectors/166-expected.png:
        * platform/mac/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.checksum:
        * platform/mac/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.png:
        * platform/mac/fast/text/international/bidi-linebreak-001-expected.checksum:
        * platform/mac/fast/text/international/bidi-linebreak-001-expected.png:
        * platform/mac/fast/text/international/bidi-linebreak-002-expected.checksum:
        * platform/mac/fast/text/international/bidi-linebreak-002-expected.png:
        * platform/mac/fast/text/international/bidi-linebreak-003-expected.checksum:
        * platform/mac/fast/text/international/bidi-linebreak-003-expected.png:
        * platform/mac/fast/text/international/bidi-mirror-he-ar-expected.checksum:
        * platform/mac/fast/text/international/bidi-mirror-he-ar-expected.png:
        * platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.checksum:
        * platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.png:
        * platform/mac/fonts/sans-serif-expected.checksum:
        * platform/mac/fonts/sans-serif-expected.png:
        * platform/mac/svg/custom/text-dom-01-f-expected.checksum:
        * platform/mac/svg/custom/text-dom-01-f-expected.png:
        * platform/mac/tables/mozilla/bugs/bug113235-1-expected.checksum:
        * platform/mac/tables/mozilla/bugs/bug113235-1-expected.png:
        * platform/mac/tables/mozilla/bugs/bug113424-expected.checksum:
        * platform/mac/tables/mozilla/bugs/bug113424-expected.png:
        * platform/mac/tables/mozilla/bugs/bug1188-expected.checksum:
        * platform/mac/tables/mozilla/bugs/bug1188-expected.png:
        * platform/mac/tables/mozilla/bugs/bug1318-expected.checksum:
        * platform/mac/tables/mozilla/bugs/bug1318-expected.png:
        * platform/mac/tables/mozilla/bugs/bug16012-expected.checksum:
        * platform/mac/tables/mozilla/bugs/bug16012-expected.png:
        * platform/mac/tables/mozilla/bugs/bug2479-2-expected.checksum:
        * platform/mac/tables/mozilla/bugs/bug2479-2-expected.png:
        * platform/mac/tables/mozilla/bugs/bug8858-expected.checksum:
        * platform/mac/tables/mozilla/bugs/bug8858-expected.png:
        * platform/mac/tables/mozilla/core/bloomberg-expected.checksum:
        * platform/mac/tables/mozilla/core/bloomberg-expected.png:
        * platform/mac/tables/mozilla_expected_failures/bugs/bug89315-expected.checksum:
        * platform/mac/tables/mozilla_expected_failures/bugs/bug89315-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAX: Add Xcode entries back to the navigator list for Accessibility cpp files
cfleizach@apple.com [Sat, 26 Feb 2011 01:46:13 +0000 (01:46 +0000)]
AX: Add Xcode entries back to the navigator list for Accessibility cpp files
https://bugs.webkit.org/show_bug.cgi?id=55280

Reviewed by Anders Carlsson.

* WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-25 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Sat, 26 Feb 2011 01:46:09 +0000 (01:46 +0000)]
2011-02-25  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin Adler.

        Plug-in process crashes when using GuardMalloc
        https://bugs.webkit.org/show_bug.cgi?id=55279
        <rdar://problem/9044618>

        Update m_environmentPointer after copying the environment variables.

        * UIProcess/Launcher/mac/ProcessLauncherMac.mm:
        (WebKit::EnvironmentVariables::copyEnvironmentVariables):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix linking of Chromium Mac build.
bweinstein@apple.com [Sat, 26 Feb 2011 01:40:17 +0000 (01:40 +0000)]
Fix linking of Chromium Mac build.

* libWebKitSystemInterfaceLeopard.a:
* libWebKitSystemInterfaceSnowLeopard.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-25 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Sat, 26 Feb 2011 01:34:40 +0000 (01:34 +0000)]
2011-02-25  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r79627.
        http://trac.webkit.org/changeset/79627
        https://bugs.webkit.org/show_bug.cgi?id=55274

        broke worker tests (Requested by olliej on #webkit).

        * JavaScriptCore.exp:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
        * runtime/Heap.cpp:
        (JSC::Heap::allocate):
        * runtime/Heap.h:
        * runtime/JSCell.h:
        (JSC::JSCell::JSCell::operator new):
        (JSC::JSCell::MarkedSpace::sizeClassFor):
        (JSC::JSCell::MarkedSpace::allocate):
        * runtime/MarkedBlock.h:
        * runtime/MarkedSpace.cpp:
        (JSC::MarkedSpace::MarkedSpace):
        (JSC::MarkedSpace::allocateBlock):
        (JSC::MarkedSpace::reset):
        * runtime/MarkedSpace.h:
        (JSC::MarkedSpace::SizeClass::SizeClass):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-25 Michael Saboff <msaboff@apple.com>
msaboff@apple.com [Sat, 26 Feb 2011 01:27:00 +0000 (01:27 +0000)]
2011-02-25  Michael Saboff  <msaboff@apple.com>

        Reviewed by Darin Adler.

        Leak in JSParser::Scope of ScopeLabelInfo Vector
        https://bugs.webkit.org/show_bug.cgi?id=55249

        Changed m_labels to be an OwnPtr<>.  Added VectorTraits
        and Scope copy constructor to support this change.

        * parser/JSParser.cpp:
        (JSC::JSParser::Scope::~Scope):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
darin@apple.com [Sat, 26 Feb 2011 01:18:50 +0000 (01:18 +0000)]
* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::ProcessLauncher::launchProcess): Fixed backwards logic from last change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
darin@apple.com [Sat, 26 Feb 2011 01:10:42 +0000 (01:10 +0000)]
* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::ProcessLauncher::launchProcess): Fixed performance problem in production
builds by only setting DYLD_FRAMEWORK_PATH in engineering configurations.

Reviewed by Mark Rowe.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/8036034> WebKit2 should work even if DYLD_FRAMEWORK_PATH is not set
darin@apple.com [Sat, 26 Feb 2011 00:47:31 +0000 (00:47 +0000)]
<rdar://problem/8036034> WebKit2 should work even if DYLD_FRAMEWORK_PATH is not set

Reviewed by Anders Carlsson.

* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::EnvironmentVariables::~EnvironmentVariables): Use fastFree, not delete, on
the strings here because they are allocated with fastMalloc, not new.
(WebKit::EnvironmentVariables::set): Use const more.
(WebKit::EnvironmentVariables::get): Ditto.
(WebKit::EnvironmentVariables::appendValue): Ditto.
(WebKit::EnvironmentVariables::valueIfVariableHasName): Ditto. Also fix mistake
where this would match if the name matched only a prefix of the environment variable's
name. We want to match the whole name, so we need to use memcmp, not strncmp.
(WebKit::EnvironmentVariables::createStringForVariable): Use const more.
(WebKit::ProcessLauncher::launchProcess): Use clearer name, frameworkExecutablePath,
for what was called bundlePath before. Append the frameworks path to DYLD_FRAMEWORK_PATH,
ensuring we can pick up other frameworks from the same directory in the web process.
Use a const_cast instead of a C-style cast.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-25 Fumitoshi Ukai <ukai@chromium.org>
abarth@webkit.org [Sat, 26 Feb 2011 00:46:25 +0000 (00:46 +0000)]
2011-02-25  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Adam Barth.

        WebSocket uses insecure random numbers
        https://bugs.webkit.org/show_bug.cgi?id=54714

        * JavaScriptCore.exp: Export WTF::cryptographicallyRandomNumber()
2011-02-25  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Adam Barth.

        WebSocket uses insecure random numbers
        https://bugs.webkit.org/show_bug.cgi?id=54714

        * websockets/WebSocketHandshake.cpp:
        (WebCore::randomNumberLessThan):
        (WebCore::generateSecWebSocketKey):
        (WebCore::generateKey3):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-25 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Sat, 26 Feb 2011 00:37:50 +0000 (00:37 +0000)]
2011-02-25  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Darin Adler.

        Add API to enumerate/delete files downloaded for <audio> and <video>
        https://bugs.webkit.org/show_bug.cgi?id=55267

        Add review changes missed in r79737.

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::clearMediaCacheForSite): Pass string by reference.
        * html/HTMLMediaElement.h:
        * platform/graphics/MediaPlayer.cpp:
        (WebCore::MediaPlayer::clearMediaCacheForSite): Ditto.
        * platform/graphics/MediaPlayer.h:
        * platform/graphics/MediaPlayerPrivate.h:
        (WebCore::MediaPlayerPrivateInterface::clearMediaCacheForSite): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAX: WK2: AXApplication not returning the AXFocusedUIElement within the web area
cfleizach@apple.com [Sat, 26 Feb 2011 00:31:24 +0000 (00:31 +0000)]
AX: WK2: AXApplication not returning the AXFocusedUIElement within the web area
https://bugs.webkit.org/show_bug.cgi?id=55277

Reviewed by Anders Carlsson.

* UIProcess/API/mac/WKView.mm:
(-[WKView accessibilityFocusedUIElement]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Anders Carlsson.
ap@apple.com [Sat, 26 Feb 2011 00:25:40 +0000 (00:25 +0000)]
    Reviewed by Anders Carlsson.

        https://bugs.webkit.org/show_bug.cgi?id=55276
        WebPage::close() accesses "this" after it is destroyed.

        This was making many tests crash with GuardMalloc.

        * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::close): Access "this" before it can be
        destroyed, not after.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-25 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Sat, 26 Feb 2011 00:02:43 +0000 (00:02 +0000)]
2011-02-25  Martin Robinson  <mrobinson@igalia.com>

        Add the final set of missing GTK+ SVG pixel results.

        * platform/gtk/svg/dynamic-updates: Add missing results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-25 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Sat, 26 Feb 2011 00:00:33 +0000 (00:00 +0000)]
2011-02-25  Martin Robinson  <mrobinson@igalia.com>

        Add another set of missing GTK+ SVG pixel results.

        * platform/gtk/svg/dynamic-updates: Add missing pixel results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed.
kbalazs@webkit.org [Fri, 25 Feb 2011 23:58:41 +0000 (23:58 +0000)]
Unreviewed.
Add missing sources to WebKit2API.pri.

* WebKit2API.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-25 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Fri, 25 Feb 2011 23:58:19 +0000 (23:58 +0000)]
2011-02-25  Martin Robinson  <mrobinson@igalia.com>

        Add the next set of missing GTK+ SVG pixel results.

        * platform/gtk/svg/dom/SVGRectElement: Add missing pixel reults.
        * platform/gtk/svg/dynamic-updates: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-25 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Fri, 25 Feb 2011 23:55:59 +0000 (23:55 +0000)]
2011-02-25  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Darin Adler.

        Add API to enumerate/delete files downloaded for <audio> and <video>
        https://bugs.webkit.org/show_bug.cgi?id=55267
        <rdar://problem/9049280>

        No new tests, this is just the plumbing.

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::getSitesInMediaCache): New, call through to MediaPlayer.
        (WebCore::HTMLMediaElement::clearMediaCache): Ditto.
        (WebCore::HTMLMediaElement::clearMediaCacheForSite): Ditto.
        * html/HTMLMediaElement.h:

        * platform/graphics/MediaPlayer.cpp:
        (WebCore::MediaPlayer::getSitesInMediaCache): New, call through to media engine.
        (WebCore::MediaPlayer::clearMediaCache): Ditto.
        (WebCore::MediaPlayer::clearMediaCacheForSite): Ditto.
        * platform/graphics/MediaPlayer.h:

        * platform/graphics/MediaPlayerPrivate.h:
        (WebCore::MediaPlayerPrivateInterface::getSitesInMediaCache): Declare new interface.
        (WebCore::MediaPlayerPrivateInterface::clearMediaCache): Ditto.
        (WebCore::MediaPlayerPrivateInterface::clearMediaCacheForSite): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-25 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Fri, 25 Feb 2011 23:55:20 +0000 (23:55 +0000)]
2011-02-25  Martin Robinson  <mrobinson@igalia.com>

        Add some missing GTK+ SVG pixel results.

        * platform/gtk/svg: Add missing GTK+ SVG pixel results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-25 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Fri, 25 Feb 2011 23:49:41 +0000 (23:49 +0000)]
2011-02-25  Martin Robinson  <mrobinson@igalia.com>

        Update GTK+ SVG pixel results which have changed.

        * platform/gtk/svg: Update SVG pixel resultsj

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-25 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Fri, 25 Feb 2011 23:18:18 +0000 (23:18 +0000)]
2011-02-25  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Dave Hyatt.

        Don't add inline continuation outline to the containing block's
        continuationOutlineTable list if it is not enclosed by an anonymous block.
        https://bugs.webkit.org/show_bug.cgi?id=54690

        We currently don't reconnect inline continuations after a child removal.
        As a result, those merged inlines do not get seperated and hence not get enclosed
        by anonymous blocks. In this case, it is better to bail out and paint it ourself.

        Test: fast/table/table-continuation-outline-paint-crash.html

        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::paint):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::paintsContinuationOutline): helper function to tell
        if this containing block has the continuation flow in its continuations list.
        * rendering/RenderBlock.h: helper function definition.
        * rendering/RenderInline.cpp:
        (WebCore::RenderInline::destroy): debug only code that asserts if we leave
        behind a continuation in the containing block's continuation list when it is
        getting destroyed.
2011-02-25  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Dave Hyatt.

        Ensure that we do not add the inline continuation flow to the table's continuation
        table map for painting. The layout test should not crash on assert and should show
        a solid outline around the inline child.
        https://bugs.webkit.org/show_bug.cgi?id=54690

        * fast/table/table-continuation-outline-paint-crash.html: Added.
        * platform/mac/fast/table/table-continuation-outline-paint-crash-expected.checksum: Added.
        * platform/mac/fast/table/table-continuation-outline-paint-crash-expected.png: Added.
        * platform/mac/fast/table/table-continuation-outline-paint-crash-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=55265, remove the unused "Static" type
hyatt@apple.com [Fri, 25 Feb 2011 22:43:54 +0000 (22:43 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=55265, remove the unused "Static" type
from Length.

Reviewed by Adam Roben.

* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
* platform/Length.h:
(WebCore::Length::isFixed):
* rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::layout):
* rendering/RenderImage.cpp:
(WebCore::RenderImage::isLogicalWidthSpecified):
(WebCore::RenderImage::isLogicalHeightSpecified):
* rendering/RenderObject.h:
(WebCore::RenderObject::markContainingBlocksForLayout):
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::hasStaticX):
(WebCore::InheritedFlags::hasStaticY):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-25 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 25 Feb 2011 22:36:02 +0000 (22:36 +0000)]
2011-02-25  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin Adler.

        A WKView without a window will cause CG errors in the console
        https://bugs.webkit.org/show_bug.cgi?id=55264
        <rdar://problem/9044281>

        Check that the window has a valid window number before trying to get its graphics context.

        * UIProcess/API/mac/PageClientImpl.mm:
        (WebKit::PageClientImpl::containingWindowGraphicsContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-25 James Robinson <jamesr@chromium.org>
jamesr@google.com [Fri, 25 Feb 2011 22:35:36 +0000 (22:35 +0000)]
2011-02-25  James Robinson  <jamesr@chromium.org>

        Update chromium test expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-25 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Fri, 25 Feb 2011 22:28:39 +0000 (22:28 +0000)]
2011-02-25  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r79324.
        http://trac.webkit.org/changeset/79324
        https://bugs.webkit.org/show_bug.cgi?id=55260

        Leopard Debug is once again running out of address space while
        linking (Requested by aroben on #webkit).

        * Scripts/webkitpy/common/net/buildbot/buildbot.py:
        * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWindows build fix.
bweinstein@apple.com [Fri, 25 Feb 2011 22:20:58 +0000 (22:20 +0000)]
Windows build fix.

* platform/network/cf/CookieJarCFNet.cpp:
(WebCore::getHostnamesWithCookies): Add a const_cast.
(WebCore::deleteCookiesForHostname): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-25 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Fri, 25 Feb 2011 22:14:34 +0000 (22:14 +0000)]
2011-02-25  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed Chromium expectations update.

        Fix 16 tests for Chromium Snow Leopard by promoting chromium-mac-leopard
        results to mac-leopard and removing outdated chromium-mac and
        chromium-mac-snowleopard ones.

        * platform/chromium-mac-leopard/svg/batik/masking/maskRegions-expected.checksum: Removed.
        * platform/chromium-mac-leopard/svg/batik/masking/maskRegions-expected.png: Removed.
        * platform/chromium-mac-leopard/svg/batik/masking/maskRegions-expected.txt: Removed.
        * platform/chromium-mac-leopard/svg/custom/absolute-sized-content-with-resources-expected.checksum: Removed.
        * platform/chromium-mac-leopard/svg/custom/absolute-sized-content-with-resources-expected.png: Removed.
        * platform/chromium-mac-leopard/svg/custom/junk-data-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/custom/junk-data-expected.checksum.
        * platform/chromium-mac-leopard/svg/custom/junk-data-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/custom/junk-data-expected.png.
        * platform/chromium-mac-leopard/svg/custom/junk-data-expected.txt: Renamed from LayoutTests/platform/chromium-mac/svg/custom/junk-data-expected.txt.
        * platform/chromium-mac-leopard/svg/custom/missing-xlink-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/custom/missing-xlink-expected.checksum.
        * platform/chromium-mac-leopard/svg/custom/missing-xlink-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/custom/missing-xlink-expected.png.
        * platform/chromium-mac-leopard/svg/custom/missing-xlink-expected.txt: Renamed from LayoutTests/platform/chromium-mac/svg/custom/missing-xlink-expected.txt.
        * platform/chromium-mac-leopard/svg/custom/viewBox-hit-expected.checksum: Removed.
        * platform/chromium-mac-leopard/svg/custom/viewBox-hit-expected.png: Removed.
        * platform/chromium-mac-leopard/svg/filters/filterRes-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/filters/filterRes-expected.checksum.
        * platform/chromium-mac-leopard/tables/mozilla/marvin/x_thead_align_justify-expected.checksum: Removed.
        * platform/chromium-mac-leopard/tables/mozilla/marvin/x_thead_align_justify-expected.png: Removed.
        * platform/chromium-mac/fast/text/justify-ideograph-simple-expected.checksum:
        * platform/chromium-mac/fast/text/justify-ideograph-simple-expected.png:
        * platform/chromium-mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.checksum: Removed.
        * platform/chromium-mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.png: Removed.
        * platform/chromium-mac/svg/batik/masking/maskRegions-expected.checksum: Removed.
        * platform/chromium-mac/svg/batik/masking/maskRegions-expected.png: Removed.
        * platform/chromium-mac/svg/css/text-gradient-shadow-expected.checksum: Removed.
        * platform/chromium-mac/svg/custom/absolute-sized-content-with-resources-expected.checksum: Removed.
        * platform/chromium-mac/svg/custom/absolute-sized-content-with-resources-expected.png: Removed.
        * platform/chromium-mac/svg/custom/viewBox-hit-expected.checksum: Removed.
        * platform/chromium-mac/svg/custom/viewBox-hit-expected.png: Removed.
        * platform/chromium-mac/svg/filters/feComposite-expected.checksum: Removed.
        * platform/chromium-mac/svg/filters/feComposite-expected.png: Removed.
        * platform/chromium-mac/svg/hixie/perf/007-expected.checksum: Removed.
        * platform/chromium-mac/svg/hixie/perf/007-expected.png: Removed.
        * platform/chromium-mac/svg/repaint/filter-repaint-expected.checksum: Removed.
        * platform/chromium-mac/svg/repaint/filter-repaint-expected.png: Removed.
        * platform/chromium-mac/tables/mozilla/bugs/bug23235-expected.checksum: Removed.
        * platform/chromium-mac/tables/mozilla/bugs/bug23235-expected.png: Removed.
        * platform/chromium-mac/tables/mozilla/marvin/x_thead_align_justify-expected.checksum: Removed.
        * platform/chromium-mac/tables/mozilla/marvin/x_thead_align_justify-expected.png: Removed.
        * platform/chromium-mac/tables/mozilla_expected_failures/bugs/97619-expected.checksum: Removed.
        * platform/chromium/test_expectations.txt:
        * platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.checksum.
        * platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png.
        * platform/mac-leopard/svg/W3C-SVG-1.1/text-intro-05-t-expected.checksum:
        * platform/mac-leopard/svg/W3C-SVG-1.1/text-intro-05-t-expected.png:
        * platform/mac-leopard/svg/batik/masking/maskRegions-expected.checksum:
        * platform/mac-leopard/svg/batik/masking/maskRegions-expected.png:
        * platform/mac-leopard/svg/batik/masking/maskRegions-expected.txt: Removed.
        * platform/mac-leopard/svg/custom/absolute-sized-content-with-resources-expected.checksum:
        * platform/mac-leopard/svg/custom/absolute-sized-content-with-resources-expected.png:
        * platform/mac-leopard/svg/custom/viewBox-hit-expected.checksum:
        * platform/mac-leopard/svg/custom/viewBox-hit-expected.png:
        * platform/mac-leopard/tables/mozilla/bugs/bug23235-expected.checksum:
        * platform/mac-leopard/tables/mozilla/bugs/bug23235-expected.png:
        * platform/mac-leopard/tables/mozilla/marvin/x_thead_align_justify-expected.checksum:
        * platform/mac-leopard/tables/mozilla/marvin/x_thead_align_justify-expected.png:
        * platform/mac-leopard/tables/mozilla_expected_failures/bugs/97619-expected.checksum:
        * platform/mac-leopard/tables/mozilla_expected_failures/bugs/97619-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-25 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Fri, 25 Feb 2011 22:01:31 +0000 (22:01 +0000)]
2011-02-25  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Empty Elements panel after closing and reopening Inspector
        https://bugs.webkit.org/show_bug.cgi?id=55248

        Fixing regression real quick. Test to follow.

        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::reset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-25 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Fri, 25 Feb 2011 21:58:38 +0000 (21:58 +0000)]
2011-02-25  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: added missing handle scope into V8InjectedScriptHostCustom.
        https://bugs.webkit.org/show_bug.cgi?id=55256

        * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
        (WebCore::InjectedScriptHost::nodeAsScriptValue):
        (WebCore::V8InjectedScriptHost::currentCallFrameCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with...
hyatt@apple.com [Fri, 25 Feb 2011 21:45:28 +0000 (21:45 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with vertical text.

Reviewed by Sam Weinig.

Make positioned objects work with all possible crazy combinations of mixed writing modes.  Added new helper
functions that flip around the padding box of the containing block and then add in the appropriate border
side to ensure that the offset of the positioned object is actually correctly placed in the containing block's
local coordinate space.

Added two new tests of both replaced and non-replaced positioned elements in mixed writing mode environments.

Source/WebCore:

* rendering/RenderBox.cpp:
(WebCore::computeLogicalLeftPositionedOffset):
(WebCore::RenderBox::computePositionedLogicalWidthUsing):
(WebCore::computeLogicalTopPositionedOffset):
(WebCore::RenderBox::computePositionedLogicalHeightUsing):
(WebCore::RenderBox::computePositionedLogicalWidthReplaced):
(WebCore::RenderBox::computePositionedLogicalHeightReplaced):

LayoutTests:

* fast/block/positioning/differing-writing-modes-replaced.html: Added.
* fast/block/positioning/differing-writing-modes.html: Added.
* platform/mac/fast/block/positioning/differing-writing-modes-expected.checksum: Added.
* platform/mac/fast/block/positioning/differing-writing-modes-expected.png: Added.
* platform/mac/fast/block/positioning/differing-writing-modes-expected.txt: Added.
* platform/mac/fast/block/positioning/differing-writing-modes-replaced-expected.checksum: Added.
* platform/mac/fast/block/positioning/differing-writing-modes-replaced-expected.png: Added.
* platform/mac/fast/block/positioning/differing-writing-modes-replaced-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-25 Tony Chang <tony@chromium.org>
tony@chromium.org [Fri, 25 Feb 2011 21:45:23 +0000 (21:45 +0000)]
2011-02-25  Tony Chang  <tony@chromium.org>

        Reviewed by James Robinson.

        Clean up temp files left by crashing DRTs on chromium-win
        https://bugs.webkit.org/show_bug.cgi?id=55182

        * BuildSlaveSupport/build.webkit.org-config/master.cfg:
        * BuildSlaveSupport/chromium/remove-crash-logs: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Windows 7 Release Tests] http/tests/xmlhttprequest/basic-auth-nouser.html and
jberlin@webkit.org [Fri, 25 Feb 2011 21:39:38 +0000 (21:39 +0000)]
[Windows 7 Release Tests] http/tests/xmlhttprequest/basic-auth-nouser.html and
basic-auth-nopassword.html failing since introduction in r74609
https://bugs.webkit.org/show_bug.cgi?id=51596

Unreviewed. Adding http/tests/xmlhttprequest/basic-auth-nopassword.html to the Skipped list
because it is consistently timing out on the Windows XP Debug bot.

* platform/win-xp/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebKit2: Need a way to manage cookies from the web process
bweinstein@apple.com [Fri, 25 Feb 2011 21:22:58 +0000 (21:22 +0000)]
WebKit2: Need a way to manage cookies from the web process
https://bugs.webkit.org/show_bug.cgi?id=55086

Reviewed by Brady Eidson and looked over by Jessie Berlin.

Source/WebCore:

Implement the functions needed to manage cookies in CookieJar (getHostnamesWithCookies,
deleteCookiesWithHostname, and deleteAllCookies) for Mac and CFNetwork (stub out the rest),
and call them from WebKit2's WebCookieManager.

No change in behavior needing tests.

* WebCore.exp.in: Added needed functions to export.
* platform/CookieJar.h:

* platform/mac/CookieJar.mm:
(WebCore::getHostnamesWithCookies): Gets all hostnames with cookies from NSHTTPCookieStorage.
(WebCore::deleteCookiesForHostname): Deletes all cookies with a given hostname from
    NSHTTPCookieStorage.
(WebCore::deleteAllCookies): Deletes all cookies from NSHTTPCookieStorage.

* platform/network/cf/CookieJarCFNet.cpp:
(WebCore::getHostnamesWithCookies): Implement using CFNetwork cookie APIs.
(WebCore::deleteCookiesForHostname): Ditto.
(WebCore::deleteAllCookies): Ditto.

* platform/efl/CookieJarEfl.cpp: Added stub functions.
* platform/haiku/CookieJarHaiku.cpp: Ditto.
* platform/network/android/CookieJarAndroid.cpp: Ditto.
* platform/network/chromium/CookieJarChromium.cpp: Ditto.
* platform/network/curl/CookieJarCurl.cpp: Ditto.
* platform/network/soup/CookieJarSoup.cpp: Ditto.
* platform/network/win/CookieJarWin.cpp: Ditto.
* platform/qt/CookieJarQt.cpp: Ditto.

Source/WebKit2:

Call through to WebCore::CookieJar in our WebCookieManager functions.

* WebProcess/Cookies/WebCookieManager.cpp:
(WebKit::WebCookieManager::getHostnamesWithCookies):
(WebKit::WebCookieManager::deleteCookiesForHostname):
(WebKit::WebCookieManager::deleteAllCookies):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-25 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Fri, 25 Feb 2011 21:21:57 +0000 (21:21 +0000)]
2011-02-25  Mihai Parparita  <mihaip@chromium.org>

        Fix 10 tests for Chromium Snow Leopard by promoting chromium-mac-leopard
        results to mac-leopard and removing outdated chromium-mac and
        chromium-mac-snowleopard ones.

        * platform/chromium-mac-leopard/fast/blockflow/vertical-baseline-alignment-expected.checksum: Removed.
        * platform/chromium-mac-leopard/fast/blockflow/vertical-baseline-alignment-expected.png: Removed.
        * platform/chromium-mac-leopard/fast/forms/select-baseline-expected.checksum: Removed.
        * platform/chromium-mac-leopard/fast/forms/select-baseline-expected.png: Removed.
        * platform/chromium-mac-snowleopard/fast/text/atsui-negative-spacing-features-expected.checksum: Removed.
        * platform/chromium-mac-snowleopard/fast/text/atsui-negative-spacing-features-expected.png: Removed.
        * platform/chromium-mac-snowleopard/fast/text/atsui-spacing-features-expected.checksum: Removed.
        * platform/chromium-mac-snowleopard/fast/text/atsui-spacing-features-expected.png: Removed.
        * platform/chromium-mac/fast/blockflow/vertical-baseline-alignment-expected.checksum: Removed.
        * platform/chromium-mac/fast/blockflow/vertical-baseline-alignment-expected.png: Removed.
        * platform/chromium-mac/fast/forms/select-baseline-expected.checksum: Removed.
        * platform/chromium-mac/fast/forms/select-baseline-expected.png: Removed.
        * platform/chromium-mac/fast/forms/text-style-color-expected.checksum: Removed.
        * platform/chromium-mac/fast/forms/text-style-color-expected.png: Removed.
        * platform/chromium-mac/fast/multicol/shadow-breaking-expected.checksum: Removed.
        * platform/chromium-mac/fast/multicol/shadow-breaking-expected.png: Removed.
        * platform/chromium-mac/fast/table/028-vertical-expected.checksum: Removed.
        * platform/chromium-mac/fast/table/028-vertical-expected.png: Removed.
        * platform/chromium-mac/fast/text/complex-text-opacity-expected.checksum: Removed.
        * platform/chromium-mac/fast/text/complex-text-opacity-expected.png: Removed.
        * platform/chromium/test_expectations.txt:
        * platform/mac-leopard/fast/blockflow/vertical-baseline-alignment-expected.checksum:
        * platform/mac-leopard/fast/blockflow/vertical-baseline-alignment-expected.png:
        * platform/mac-leopard/fast/dom/isindex-002-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/dom/isindex-002-expected.checksum.
        * platform/mac-leopard/fast/dom/isindex-002-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/dom/isindex-002-expected.png.
        * platform/mac-leopard/fast/dom/replaceChild-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/dom/replaceChild-expected.checksum.
        * platform/mac-leopard/fast/dom/replaceChild-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/dom/replaceChild-expected.png.
        * platform/mac-leopard/fast/forms/select-baseline-expected.checksum:
        * platform/mac-leopard/fast/forms/select-baseline-expected.png:
        * platform/mac-leopard/fast/forms/text-style-color-expected.checksum: Renamed from LayoutTests/platform/chromium-mac-leopard/fast/forms/text-style-color-expected.checksum.
        * platform/mac-leopard/fast/forms/text-style-color-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/fast/forms/text-style-color-expected.png.
        * platform/mac-leopard/fast/multicol/shadow-breaking-expected.checksum: Renamed from LayoutTests/platform/chromium-mac-leopard/fast/multicol/shadow-breaking-expected.checksum.
        * platform/mac-leopard/fast/multicol/shadow-breaking-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/fast/multicol/shadow-breaking-expected.png.
        * platform/mac-leopard/fast/table/028-vertical-expected.checksum:
        * platform/mac-leopard/fast/table/028-vertical-expected.png:
        * platform/mac-leopard/fast/text/atsui-negative-spacing-features-expected.checksum: Renamed from LayoutTests/platform/chromium-mac-leopard/fast/text/atsui-negative-spacing-features-expected.checksum.
        * platform/mac-leopard/fast/text/atsui-negative-spacing-features-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/fast/text/atsui-negative-spacing-features-expected.png.
        * platform/mac-leopard/fast/text/atsui-spacing-features-expected.checksum: Renamed from LayoutTests/platform/chromium-mac-leopard/fast/text/atsui-spacing-features-expected.checksum.
        * platform/mac-leopard/fast/text/atsui-spacing-features-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/fast/text/atsui-spacing-features-expected.png.
        * platform/mac-leopard/fast/text/complex-text-opacity-expected.checksum:
        * platform/mac-leopard/fast/text/complex-text-opacity-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-25 James Robinson <jamesr@chromium.org>
jamesr@google.com [Fri, 25 Feb 2011 21:04:33 +0000 (21:04 +0000)]
2011-02-25  James Robinson  <jamesr@chromium.org>

        Add chromium win/linux baselines for new vertical replaced test and update various expectations.

        * platform/chromium-gpu-win/platform/chromium/compositing/layout-width-change-expected.checksum:
        * platform/chromium-gpu-win/platform/chromium/compositing/layout-width-change-expected.png:
        * platform/chromium-linux/fast/replaced/vertical-lr/absolute-position-percentage-width-expected.checksum: Added.
        * platform/chromium-linux/fast/replaced/vertical-lr/absolute-position-percentage-width-expected.png: Added.
        * platform/chromium-linux/fast/replaced/vertical-lr/absolute-position-with-auto-height-and-top-and-bottom-expected.checksum: Added.
        * platform/chromium-linux/fast/replaced/vertical-lr/absolute-position-with-auto-height-and-top-and-bottom-expected.png: Added.
        * platform/chromium-linux/fast/replaced/vertical-lr/absolute-position-with-auto-width-and-left-and-right-expected.checksum: Added.
        * platform/chromium-linux/fast/replaced/vertical-lr/absolute-position-with-auto-width-and-left-and-right-expected.png: Added.
        * platform/chromium-linux/fast/replaced/vertical-rl/absolute-position-percentage-width-expected.checksum: Added.
        * platform/chromium-linux/fast/replaced/vertical-rl/absolute-position-percentage-width-expected.png: Added.
        * platform/chromium-linux/fast/replaced/vertical-rl/absolute-position-with-auto-height-and-top-and-bottom-expected.checksum: Added.
        * platform/chromium-linux/fast/replaced/vertical-rl/absolute-position-with-auto-height-and-top-and-bottom-expected.png: Added.
        * platform/chromium-linux/fast/replaced/vertical-rl/absolute-position-with-auto-width-and-left-and-right-expected.checksum: Added.
        * platform/chromium-linux/fast/replaced/vertical-rl/absolute-position-with-auto-width-and-left-and-right-expected.png: Added.
        * platform/chromium-win/fast/replaced/vertical-lr/absolute-position-percentage-width-expected.checksum: Added.
        * platform/chromium-win/fast/replaced/vertical-lr/absolute-position-percentage-width-expected.png: Added.
        * platform/chromium-win/fast/replaced/vertical-lr/absolute-position-percentage-width-expected.txt: Added.
        * platform/chromium-win/fast/replaced/vertical-lr/absolute-position-with-auto-height-and-top-and-bottom-expected.checksum: Added.
        * platform/chromium-win/fast/replaced/vertical-lr/absolute-position-with-auto-height-and-top-and-bottom-expected.png: Added.
        * platform/chromium-win/fast/replaced/vertical-lr/absolute-position-with-auto-height-and-top-and-bottom-expected.txt: Added.
        * platform/chromium-win/fast/replaced/vertical-lr/absolute-position-with-auto-width-and-left-and-right-expected.checksum: Added.
        * platform/chromium-win/fast/replaced/vertical-lr/absolute-position-with-auto-width-and-left-and-right-expected.png: Added.
        * platform/chromium-win/fast/replaced/vertical-lr/absolute-position-with-auto-width-and-left-and-right-expected.txt: Added.
        * platform/chromium-win/fast/replaced/vertical-rl/absolute-position-percentage-width-expected.checksum: Added.
        * platform/chromium-win/fast/replaced/vertical-rl/absolute-position-percentage-width-expected.png: Added.
        * platform/chromium-win/fast/replaced/vertical-rl/absolute-position-percentage-width-expected.txt: Added.
        * platform/chromium-win/fast/replaced/vertical-rl/absolute-position-with-auto-height-and-top-and-bottom-expected.checksum: Added.
        * platform/chromium-win/fast/replaced/vertical-rl/absolute-position-with-auto-height-and-top-and-bottom-expected.png: Added.
        * platform/chromium-win/fast/replaced/vertical-rl/absolute-position-with-auto-height-and-top-and-bottom-expected.txt: Added.
        * platform/chromium-win/fast/replaced/vertical-rl/absolute-position-with-auto-width-and-left-and-right-expected.checksum: Added.
        * platform/chromium-win/fast/replaced/vertical-rl/absolute-position-with-auto-width-and-left-and-right-expected.png: Added.
        * platform/chromium-win/fast/replaced/vertical-rl/absolute-position-with-auto-width-and-left-and-right-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-25 Tony Chang <tony@chromium.org>
tony@chromium.org [Fri, 25 Feb 2011 20:30:40 +0000 (20:30 +0000)]
2011-02-25  Tony Chang  <tony@chromium.org>

        Unreviewed, updating chromium linux baselines after changes to
        RGBToHSL code in chromium.

        * platform/chromium-linux/fast/forms/menulist-restrict-line-height-expected.checksum:
        * platform/chromium-linux/fast/forms/menulist-restrict-line-height-expected.png:
        * platform/chromium-linux/fast/forms/menulist-style-color-expected.checksum:
        * platform/chromium-linux/fast/forms/menulist-style-color-expected.png:
        * platform/chromium-linux/fast/forms/select-baseline-expected.checksum:
        * platform/chromium-linux/fast/forms/select-baseline-expected.png:
2011-02-25  Tony Chang  <tony@chromium.org>

        Roll chromium deps to include RBGToHSL fix and ICU update.

        * DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-25 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Fri, 25 Feb 2011 20:20:41 +0000 (20:20 +0000)]
2011-02-25  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Eric Seidel.

        'load' and 'error' events fired for @poster
        https://bugs.webkit.org/show_bug.cgi?id=54908

        * html/HTMLImageLoader.cpp:
        (WebCore::HTMLImageLoader::dispatchLoadEvent): Don't fire events when being used
        by a video element.

2011-02-25  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Eric Seidel.

        'load' and 'error' events fired for @poster
        https://bugs.webkit.org/show_bug.cgi?id=54908

        * media/video-poster.html: Register listeners for 'load' and 'error' events so the test will
        fail if they ever fire.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agomedia/controls-without-preload.html failing on Windows.
jberlin@webkit.org [Fri, 25 Feb 2011 20:01:04 +0000 (20:01 +0000)]
media/controls-without-preload.html failing on Windows.
https://bugs.webkit.org/show_bug.cgi?id=50471

Unreviewed. Add Windows-XP specific (failing?) results to get the bots green.

* platform/win-xp/media/controls-without-preload-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-25 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 25 Feb 2011 19:57:52 +0000 (19:57 +0000)]
2011-02-25  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Option-clicking on links doesn't download them due to sandbox violation
        https://bugs.webkit.org/show_bug.cgi?id=55250
        <rdar://problem/9018359>

        The change to make DecidePolicyForNavigationAction sync didn't handle the case when the
        decided policy was "Download". Fix this by passing along the download ID back to the web process.

        * Platform/CoreIPC/HandleMessage.h:
        (CoreIPC::callMemberFunction):
        Add new overload.

        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::WebPageProxy):
        Initialize m_syncNavigationActionPolicyDownloadID.

        (WebKit::WebPageProxy::receivedPolicyDecision):
        Set m_syncNavigationActionPolicyDownloadID to the download ID.

        (WebKit::WebPageProxy::decidePolicyForNavigationAction):
        Return the m_syncNavigationActionPolicyDownloadID.

        * UIProcess/WebPageProxy.h:
        * UIProcess/WebPageProxy.messages.in:
        Add a DownloadID reply parameter.

        * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
        Don't pass a zero download ID to didReceivePolicyDecision.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-25 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Fri, 25 Feb 2011 19:57:37 +0000 (19:57 +0000)]
2011-02-25  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed Chromium expectations update.

        Add recent Snow Leopard failures.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-25 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Fri, 25 Feb 2011 19:49:39 +0000 (19:49 +0000)]
2011-02-25  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed Chromium expectations update.

        Fix fast/inline/inline-box-background-repeat-x.html, fast/inline/
        inline-box-background-repeat-y.html and fast/inline/
        inline-box-background.html for Chromium Snow Leopard by promoting
        chromium-mac-leopard results to mac-leopard and removing outdated
        chromium-mac ones.

        * platform/chromium-mac/fast/inline/inline-box-background-expected.checksum: Removed.
        * platform/chromium-mac/fast/inline/inline-box-background-expected.png: Removed.
        * platform/chromium-mac/fast/inline/inline-box-background-repeat-x-expected.checksum: Removed.
        * platform/chromium-mac/fast/inline/inline-box-background-repeat-x-expected.png: Removed.
        * platform/chromium-mac/fast/inline/inline-box-background-repeat-y-expected.checksum: Removed.
        * platform/chromium-mac/fast/inline/inline-box-background-repeat-y-expected.png: Removed.
        * platform/chromium/test_expectations.txt:
        * platform/mac-leopard/fast/inline/inline-box-background-expected.checksum: Renamed from LayoutTests/platform/chromium-mac-leopard/fast/inline/inline-box-background-expected.checksum.
        * platform/mac-leopard/fast/inline/inline-box-background-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/fast/inline/inline-box-background-expected.png.
        * platform/mac-leopard/fast/inline/inline-box-background-repeat-x-expected.checksum: Renamed from LayoutTests/platform/chromium-mac-leopard/fast/inline/inline-box-background-repeat-x-expected.checksum.
        * platform/mac-leopard/fast/inline/inline-box-background-repeat-x-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/fast/inline/inline-box-background-repeat-x-expected.png.
        * platform/mac-leopard/fast/inline/inline-box-background-repeat-y-expected.checksum: Renamed from LayoutTests/platform/chromium-mac-leopard/fast/inline/inline-box-background-repeat-y-expected.checksum.
        * platform/mac-leopard/fast/inline/inline-box-background-repeat-y-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/fast/inline/inline-box-background-repeat-y-expected.png.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-25 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Fri, 25 Feb 2011 19:47:38 +0000 (19:47 +0000)]
2011-02-25  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Adam Roben.

        Move timeBeginPeriod into OS(WINDOWS) section
        https://bugs.webkit.org/show_bug.cgi?id=55247

        * jsc.cpp:
        (main): timeBeginPeriod is available on all Windows versions and not compiler specific.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-25 Amruth Raj <amruthraj@motorola.com> and Ravi Phaneendra Kasibhatla ...
alex@webkit.org [Fri, 25 Feb 2011 19:46:10 +0000 (19:46 +0000)]
2011-02-25  Amruth Raj  <amruthraj@motorola.com> and Ravi Phaneendra Kasibhatla  <ravi.kasibhatla@motorola.com> and Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Implement WebContext and NativeKeyboardEvent classes for WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=48510

        * GNUmakefile.am:
        * Shared/NativeWebKeyboardEvent.h: Added the GTK event attribute
        and constructors, in our case we need it because we use a pointer
        and copy the event.
        (WebKit::NativeWebKeyboardEvent::nativeEvent):
        * Shared/gtk/NativeWebKeyboardEventGtk.cpp: Added.
        (WebKit::NativeWebKeyboardEvent::NativeWebKeyboardEvent): We need
        to copy the event in the constructor to avoid two references to
        the same event.
        * Shared/gtk/WebEventFactory.cpp: Changed the prototype of the
        functions to add const, we need it for the NativeWebKeyboardEvent
        constructor.
        (WebKit::modifiersForEvent):
        (WebKit::WebEventFactory::createWebKeyboardEvent):
        * UIProcess/gtk/WebContextGtk.cpp: Added. Stubbed implementation
        for GTK port. Yet to implement.
        (WebKit::WebContext::applicationCacheDirectory):
        (WebKit::WebContext::platformInitializeWebProcess):
        (WebKit::WebContext::platformDefaultDatabaseDirectory):
        * UIProcess/gtk/WebView.cpp:
        (WebKit::WebView::handleKeyboardEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-25 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Fri, 25 Feb 2011 19:41:02 +0000 (19:41 +0000)]
2011-02-25  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed Chromium expectations update.

        Fix fast/dom/34176.html and fast/dom/52776.html for Chromium Snow
        Leopard by promoting chromium-mac-leopard results to mac-leopard and
        removing outdated chromium-mac ones.

        * platform/chromium-mac-leopard/fast/dom/52776-expected.txt: Removed.
        * platform/chromium-mac/fast/dom/52776-expected.txt: Removed.
        * platform/mac-leopard/fast/dom/34176-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/dom/34176-expected.checksum.
        * platform/mac-leopard/fast/dom/34176-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/dom/34176-expected.png.
        * platform/mac-leopard/fast/dom/52776-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/dom/52776-expected.checksum.
        * platform/mac-leopard/fast/dom/52776-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/dom/52776-expected.png.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-25 James Robinson <jamesr@chromium.org>
jamesr@google.com [Fri, 25 Feb 2011 19:38:39 +0000 (19:38 +0000)]
2011-02-25  James Robinson  <jamesr@chromium.org>

        More chromium expectations and baselines.

        * platform/chromium-gpu-linux/platform/chromium/compositing/layout-width-change-expected.checksum: Added.
        * platform/chromium-gpu-linux/platform/chromium/compositing/layout-width-change-expected.png: Added.
        * platform/chromium-gpu-mac/platform/chromium/compositing/layout-width-change-expected.checksum: Added.
        * platform/chromium-gpu-mac/platform/chromium/compositing/layout-width-change-expected.png: Added.
        * platform/chromium-gpu-win/platform/chromium/compositing/layout-width-change-expected.checksum: Added.
        * platform/chromium-gpu-win/platform/chromium/compositing/layout-width-change-expected.png: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-25 James Robinson <jamesr@chromium.org>
jamesr@google.com [Fri, 25 Feb 2011 19:28:23 +0000 (19:28 +0000)]
2011-02-25  James Robinson  <jamesr@chromium.org>

        Fix typo in Chromium test expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-25 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Fri, 25 Feb 2011 19:20:26 +0000 (19:20 +0000)]
2011-02-25  Patrick Gansterer  <paroga@webkit.org>

        Unreviewed WinCE build fix for r79695.

        * jsc.cpp:
        (main): SetErrorMode isn't available on WinCE.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with...
hyatt@apple.com [Fri, 25 Feb 2011 19:18:30 +0000 (19:18 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with vertical text.

Reviewed by Sam Weinig.

Patch computePositionedLogicalHeightReplaced to be writing-mode aware.

Added six new tests in fast/replaced.

Source/WebCore:

* rendering/RenderBox.cpp:
(WebCore::RenderBox::computePositionedLogicalHeightReplaced):

LayoutTests:

* fast/replaced/vertical-lr: Added.
* fast/replaced/vertical-lr/absolute-position-percentage-width.html: Added.
* fast/replaced/vertical-lr/absolute-position-with-auto-height-and-top-and-bottom.html: Added.
* fast/replaced/vertical-lr/absolute-position-with-auto-width-and-left-and-right.html: Added.
* fast/replaced/vertical-rl: Added.
* fast/replaced/vertical-rl/absolute-position-percentage-width.html: Added.
* fast/replaced/vertical-rl/absolute-position-with-auto-height-and-top-and-bottom.html: Added.
* fast/replaced/vertical-rl/absolute-position-with-auto-width-and-left-and-right.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-25 James Robinson <jamesr@chromium.org>
jamesr@google.com [Fri, 25 Feb 2011 19:17:00 +0000 (19:17 +0000)]
2011-02-25  James Robinson  <jamesr@chromium.org>

        Update chromium expectations and baselines for some ruby tests.

        * platform/chromium-mac/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum: Added.
        * platform/chromium-mac/fast/blockflow/Kusa-Makura-background-canvas-expected.png: Added.
        * platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum: Added.
        * platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-lr-expected.png: Added.
        * platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum: Added.
        * platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-rl-expected.png: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-25 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Fri, 25 Feb 2011 19:15:46 +0000 (19:15 +0000)]
2011-02-25  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed Chromium expectations update.

        Fix editing/selection/caret-rtl* for Chromium Snow Leopard. Remove
        outdated chromium-mac baselines (the test will pass on Chromium SL with
        the mac/ baselines). Promote the chromium-mac-leopard baselines to
        mac-leopard (since the Mac port will pass with them on Leopard).

        * platform/chromium-mac/editing/selection/caret-rtl-2-expected.checksum: Removed.
        * platform/chromium-mac/editing/selection/caret-rtl-2-expected.png: Removed.
        * platform/chromium-mac/editing/selection/caret-rtl-2-left-expected.checksum: Removed.
        * platform/chromium-mac/editing/selection/caret-rtl-2-left-expected.png: Removed.
        * platform/chromium-mac/editing/selection/caret-rtl-expected.checksum: Removed.
        * platform/chromium-mac/editing/selection/caret-rtl-expected.png: Removed.
        * platform/chromium-mac/editing/selection/caret-rtl-right-expected.checksum: Removed.
        * platform/chromium-mac/editing/selection/caret-rtl-right-expected.png: Removed.
        * platform/chromium/test_expectations.txt:
        * platform/mac-leopard/editing/selection/caret-rtl-2-expected.checksum: Renamed from LayoutTests/platform/chromium-mac-leopard/editing/selection/caret-rtl-2-expected.checksum.
        * platform/mac-leopard/editing/selection/caret-rtl-2-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/editing/selection/caret-rtl-2-expected.png.
        * platform/mac-leopard/editing/selection/caret-rtl-2-left-expected.checksum: Renamed from LayoutTests/platform/chromium-mac-leopard/editing/selection/caret-rtl-2-left-expected.checksum.
        * platform/mac-leopard/editing/selection/caret-rtl-2-left-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/editing/selection/caret-rtl-2-left-expected.png.
        * platform/mac-leopard/editing/selection/caret-rtl-expected.checksum: Renamed from LayoutTests/platform/chromium-mac-leopard/editing/selection/caret-rtl-expected.checksum.
        * platform/mac-leopard/editing/selection/caret-rtl-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/editing/selection/caret-rtl-expected.png.
        * platform/mac-leopard/editing/selection/caret-rtl-right-expected.checksum: Renamed from LayoutTests/platform/chromium-mac-leopard/editing/selection/caret-rtl-right-expected.checksum.
        * platform/mac-leopard/editing/selection/caret-rtl-right-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/editing/selection/caret-rtl-right-expected.png.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-15 Brett Wilson <brettw@chromium.org>
brettw@chromium.org [Fri, 25 Feb 2011 19:14:15 +0000 (19:14 +0000)]
2011-02-15  Brett Wilson  <brettw@chromium.org>

        Reviewed by Darin Fisher.

        Recover the mouse capture state when we recieve a mouse event where there is no longer a button down.
        https://bugs.webkit.org/show_bug.cgi?id=54503

        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::handleInputEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-25 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 25 Feb 2011 19:08:08 +0000 (19:08 +0000)]
2011-02-25  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Get rid of more old accelerated compositing code
        https://bugs.webkit.org/show_bug.cgi?id=55235

        * Shared/CoreIPCSupport/DrawingAreaProxyMessageKinds.h:
        * UIProcess/ChunkedUpdateDrawingAreaProxy.h:
        * UIProcess/DrawingAreaProxy.h:
        * UIProcess/DrawingAreaProxyImpl.cpp:
        * UIProcess/DrawingAreaProxyImpl.h:
        * WebProcess/WebPage/ChunkedUpdateDrawingArea.h:
        * WebProcess/WebPage/DrawingArea.h:
        * WebProcess/WebPage/DrawingAreaImpl.cpp:
        * WebProcess/WebPage/DrawingAreaImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-25 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Fri, 25 Feb 2011 19:01:51 +0000 (19:01 +0000)]
2011-02-25  Patrick Gansterer  <paroga@webkit.org>

        Unreviewed build fix.

        * platform/text/brew/TextBreakIteratorBrew.cpp:
        (WebCore::acquireLineBreakIterator):
        * platform/text/wince/TextBreakIteratorWinCE.cpp:
        (WebCore::acquireLineBreakIterator):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-25 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Fri, 25 Feb 2011 19:00:57 +0000 (19:00 +0000)]
2011-02-25  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed Chromium expectations update.

        editing/pasteboard/merge-end-list.html was failing on Chromium Snow
        Leopard because it was picking up the .checksum file in chromium-mac/,
        even though it would pass with the mac/ .png/.checksum. Additionally, the
        chromium-mac .checksum had no corresponding .png.

        Fixes things by deleting the lone .checksum in chromium-mac and updating
        the mac-leopard results (which can be used by both the Mac and Chromium
        ports).

        * platform/chromium-mac/editing/pasteboard/merge-end-list-expected.checksum: Removed.
        * platform/chromium/test_expectations.txt:
        * platform/mac-leopard/editing/pasteboard/merge-end-list-expected.checksum:
        * platform/mac-leopard/editing/pasteboard/merge-end-list-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-25 Vangelis Kokkevis <vangelis@chromium.org>
vangelis@chromium.org [Fri, 25 Feb 2011 18:58:39 +0000 (18:58 +0000)]
2011-02-25  Vangelis Kokkevis  <vangelis@chromium.org>

        Reviewed by Simon Fraser.

        [chromium] Adding test to ensure clipping layer gets updated when layout
        width/height change in the page.
        https://bugs.webkit.org/show_bug.cgi?id=55103

        * platform/chromium/compositing/layout-width-change-expected.checksum: Added.
        * platform/chromium/compositing/layout-width-change-expected.png: Added.
        * platform/chromium/compositing/layout-width-change-expected.txt: Added.
        * platform/chromium/compositing/layout-width-change.html: Added.
2011-02-25  Vangelis Kokkevis  <vangelis@chromium.org>

        Reviewed by Simon Fraser.

        Update the clip layer size whenever the root layer's size and position
        is updated. This only affects the accelerated compositing path.
        https://bugs.webkit.org/show_bug.cgi?id=55103

        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::updateRootLayerPosition):

        Test: platform/chromium/compositing/layout-width-change.html

        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::updateRootLayerPosition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDouble-check that modifying the registry worked
aroben@apple.com [Fri, 25 Feb 2011 18:46:33 +0000 (18:46 +0000)]
Double-check that modifying the registry worked

On Windows Vista/7 with UAC enabled, regtool will fail to modify the registry, but it will
still return a successful exit code. So we double-check here that the value we tried to
write to the registry was really written.

Fixes <http://webkit.org/b/55227> old-run-webkit-tests falsely claims to be saving crash
logs on Windows Vista/7

Reviewed by Darin Adler.

* Scripts/old-run-webkit-tests:
(writeRegistryString): After trying to write the string value, check that it was really
written.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSet the 32-bit post-mortem debugger on 64-bit OSes
aroben@apple.com [Fri, 25 Feb 2011 18:46:06 +0000 (18:46 +0000)]
Set the 32-bit post-mortem debugger on 64-bit OSes

The post-mortem debugger is controlled by some registry values in
HKLM\SOFTWARE\Microsoft\Windows NT\CurrentVersion\AeDebug. On 64-bit OSes, you can either
set the values in that key, which will be used for 64-bit apps, or in the equivalent key
under Wow6432Node, which will be used for 32-bit apps. Since DumpRenderTree and
WebKitTestRunner are 32-bit, we want to use the latter location.

Fixes <http://webkit.org/b/55225> old-run-webkit-tests sets the post-mortem debugger for
64-bit apps, but should set it for 32-bit apps instead

Reviewed by Darin Adler.

* Scripts/old-run-webkit-tests:
(readRegistryString):
(writeRegistryString):
Pass --wow32 to regtool so it will get/set values beneath Wow6432Node, which is where
Windows looks for the post-mortem debugger values when a 32-bit app crashes on a 64-bit OS.
Passing --wow32 on a 32-bit OS will not have any effect.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoClean up code to set up crash log saving on Windows
aroben@apple.com [Fri, 25 Feb 2011 18:45:39 +0000 (18:45 +0000)]
Clean up code to set up crash log saving on Windows

Fixes <http://webkit.org/b/55224> old-run-webkit-test's Windows registry code is ugly

Reviewed by David Kilzer.

* Scripts/old-run-webkit-tests:
(readRegistryString):
(writeRegistryString):
Moved code to read strings from and write strings to the registry here...

(setUpWindowsCrashLogSaving): ...from here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWork around Cygwin's crash-suppression behavior
aroben@apple.com [Fri, 25 Feb 2011 18:45:10 +0000 (18:45 +0000)]
Work around Cygwin's crash-suppression behavior

Cygwin calls ::SetErrorMode(SEM_FAILCRITICALERRORS), which any processes it launches will
inherit. This is bad for testing/debugging, as it causes the post-mortem debugger not to be
invoked. (Cygwin does this because it makes crashes more UNIX-y.) We reset the error mode
when our test apps launch to work around Cygwin's behavior.

Fixes <http://webkit.org/b/55222> Test apps crash silently (without invoking post-mortem
debugger) when launched from Cygwin 1.7

Reviewed by Darin Adler.

Source/JavaScriptCore:

* API/tests/testapi.c: Added a now-needed #include.
(main):
* jsc.cpp:
(main):
Call ::SetErrorMode(0) to undo Cygwin's folly.

* JavaScriptCore.vcproj/testapi/testapiCommon.vsprops: Define NOMINMAX like many of our
other projects do so that windows.h won't define min/max macros that interfere with
std::numeric_limits<T>::min/max.

Tools:

* DumpRenderTree/win/DumpRenderTree.cpp:
(main):
* TestWebKitAPI/win/main.cpp:
(main):
* WebKitAPITest/main.cpp:
(main):
* WebKitTestRunner/win/TestControllerWin.cpp:
(WTR::TestController::platformInitialize):
Call ::SetErrorMode(0) to undo Cygwin's folly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMinimize calls to ubrk_setText()
mitz@apple.com [Fri, 25 Feb 2011 18:34:15 +0000 (18:34 +0000)]
Minimize calls to ubrk_setText()
https://bugs.webkit.org/show_bug.cgi?id=54912
<rdar://problem/9032774>

Patch by Ned Holbrook <nholbrook@apple.com> on 2011-02-25
Reviewed by Dan Bernstein.

Avoid calling ubrk_setText() once per call to isBreakable() by using a LazyLineBreakIterator, which defers
break iterator creation until needed. This requires replacing the global line break iterator primitive with a
version that can be nested, since in some cases two iterators may need to be outstanding. In particular,
layoutInlineChildren() may indirectly call computePreferredLogicalWidths() and each may need an iterator.
In a test with a paragraph of Japanese text, this reduced the number of ubrk_setText() calls from 164 to 1.

* platform/text/TextBreakIterator.h: Add LazyLineBreakIterator.
(WebCore::LazyLineBreakIterator::LazyLineBreakIterator):
(WebCore::LazyLineBreakIterator::~LazyLineBreakIterator):
(WebCore::LazyLineBreakIterator::string):
(WebCore::LazyLineBreakIterator::length):
(WebCore::LazyLineBreakIterator::get):
(WebCore::LazyLineBreakIterator::reset):
* platform/text/TextBreakIteratorICU.cpp: Replace lineBreakIterator() primitive with acquireLineBreakIterator()/releaseLineBreakIterator().
(WebCore::acquireLineBreakIterator):
(WebCore::releaseLineBreakIterator):
* platform/text/brew/TextBreakIteratorBrew.cpp: Ditto.
(WebCore::acquireLineBreakIterator):
(WebCore::releaseLineBreakIterator):
* platform/text/gtk/TextBreakIteratorGtk.cpp: Ditto.
(WebCore::acquireLineBreakIterator):
(WebCore::releaseLineBreakIterator):
* platform/text/qt/TextBreakIteratorQt.cpp: Ditto.
(WebCore::acquireLineBreakIterator):
(WebCore::releaseLineBreakIterator):
* platform/text/wince/TextBreakIteratorWinCE.cpp: Ditto.
(WebCore::acquireLineBreakIterator):
(WebCore::releaseLineBreakIterator):
* rendering/RenderBlock.h:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutInlineChildren): Pass a mapping of RenderText to LazyLineBreakIterator from one call of findNextLineBreak() to the next.
(WebCore::RenderBlock::findNextLineBreak): Use said mapping, resetting LazyLineBreakIterator for any newly-encountered RenderText.
* rendering/RenderText.cpp: Use a local LazyLineBreakIterator.
(WebCore::RenderText::computePreferredLogicalWidths):
* rendering/break_lines.cpp: Accept LazyLineBreakIterator rather than UniChar buffer.
(WebCore::nextBreakablePosition):
* rendering/break_lines.h: Accept LazyLineBreakIterator rather than UniChar buffer.
(WebCore::isBreakable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Windows 7 Release Tests] fast/ruby/base-shorter-than-text.html failing since introdu...
jberlin@webkit.org [Fri, 25 Feb 2011 18:28:25 +0000 (18:28 +0000)]
[Windows 7 Release Tests] fast/ruby/base-shorter-than-text.html failing since introduction
in r79629.
https://bugs.webkit.org/show_bug.cgi?id=55230

Add Windows-specific expected results. Unreviewed.

* platform/win/fast/ruby/base-shorter-than-text-expected.checksum: Added.
* platform/win/fast/ruby/base-shorter-than-text-expected.png: Added.
* platform/win/fast/ruby/base-shorter-than-text-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-25 Sergio Villar Senin <svillar@igalia.com>
sergio@webkit.org [Fri, 25 Feb 2011 18:25:48 +0000 (18:25 +0000)]
2011-02-25  Sergio Villar Senin  <svillar@igalia.com>

        Unreviewed.

        Added new GTK+ expectations for new tests.

        * platform/gtk/svg/custom/animate-target-id-changed-expected.checksum: Added.
        * platform/gtk/svg/custom/animate-target-id-changed-expected.png: Added.
        * platform/gtk/svg/custom/animate-target-id-changed-expected.txt: Added.
        * platform/gtk/svg/custom/animate-target-removed-from-document-expected.checksum: Added.
        * platform/gtk/svg/custom/animate-target-removed-from-document-expected.png: Added.
        * platform/gtk/svg/custom/animate-target-removed-from-document-expected.txt: Added.
        * platform/gtk/transitions/default-timing-function-expected.checksum: Added.
        * platform/gtk/transitions/default-timing-function-expected.png: Added.
        * platform/gtk/transitions/default-timing-function-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with...
hyatt@apple.com [Fri, 25 Feb 2011 18:11:59 +0000 (18:11 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with vertical text.

Reviewed by Sam Weinig.

Patch computePositionedLogicalWidthReplaced to be writing-mode aware.  Not testable yet, since the height function overwrites the values
in a vertical text environment.

* rendering/RenderBox.cpp:
(WebCore::RenderBox::computePositionedLogicalWidthReplaced):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-25 Andras Becsi <abecsi@webkit.org>
ossy@webkit.org [Fri, 25 Feb 2011 18:07:02 +0000 (18:07 +0000)]
2011-02-25  Andras Becsi  <abecsi@webkit.org>

        Reviewed by Csaba Osztrogon√°c.

        [Qt] Make the WebKit2 build system less confusing for non-Qt developers
        https://bugs.webkit.org/show_bug.cgi?id=55213

        * QtWebKit.pro: Move the WebKit2 API into a project include file
        in the WebKit2 directory and include the pri file here.
2011-02-25  Andras Becsi  <abecsi@webkit.org>

        Reviewed by Csaba Osztrogon√°c.

        [Qt] Make the WebKit2 build system less confusing for non-Qt developers
        https://bugs.webkit.org/show_bug.cgi?id=55213

        * WebKit2API.pri: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-25 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Fri, 25 Feb 2011 17:51:49 +0000 (17:51 +0000)]
2011-02-25  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Dave Hyatt.

        Tests that we do not crash when removing a text node adjacent to a word break node.
        https://bugs.webkit.org/show_bug.cgi?id=55206

        * fast/text/resources/word-break-next-linebox-not-dirty-crash.html: Added.
        * fast/text/word-break-next-linebox-not-dirty-crash-main-expected.txt: Added.
        * fast/text/word-break-next-linebox-not-dirty-crash-main.html: Added.
2011-02-25  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Dave Hyatt.

        When trying to find which lines to dirty for a changed child, make sure
        that we do test if the adjacent next linebox contains that changed child
        and if yes, dirty it. This can happen in cases when we have a word break
        between text nodes.
        https://bugs.webkit.org/show_bug.cgi?id=55206

        Test: fast/text/word-break-next-linebox-not-dirty-crash-main.html

        * rendering/RenderLineBoxList.cpp:
        (WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-25 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Fri, 25 Feb 2011 17:35:49 +0000 (17:35 +0000)]
2011-02-25  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed Chromium Snow Leopard expectations update. Remove failing
        expectations for tests that pass after r79653. Add one more known
        failure and flake.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed translation file.
christian@webkit.org [Fri, 25 Feb 2011 17:27:29 +0000 (17:27 +0000)]
Unreviewed translation file.

L10N: Webkit translated to Basque (eu) language
https://bugs.webkit.org/show_bug.cgi?id=36588

* eu.po: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed build fix for Intel ICC and MSVC.
kbalazs@webkit.org [Fri, 25 Feb 2011 17:04:29 +0000 (17:04 +0000)]
Unreviewed build fix for Intel ICC and MSVC.

Patch by Alexis Menard <alexis.menard@openbossa.org> on 2011-02-25
* tests/qgraphicswebview/tst_qgraphicswebview.cpp:
(tst_QGraphicsWebView::setPalette):
* tests/qwebview/tst_qwebview.cpp:
(tst_QWebView::setPalette):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-25 Sergio Villar Senin <svillar@igalia.com>
sergio@webkit.org [Fri, 25 Feb 2011 16:56:19 +0000 (16:56 +0000)]
2011-02-25  Sergio Villar Senin  <svillar@igalia.com>

        Unreviewed.

        Added an inspector test that fails on GTK debug bots.

        * platform/gtk/Skipped: inspector/extensions/extensions-events.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Chromium expectations.
antonm@chromium.org [Fri, 25 Feb 2011 16:43:35 +0000 (16:43 +0000)]
Unreviewed.  Chromium expectations.

*    platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79684 268f45cc-cd09-0410-ab3c-d52691b4dbfc