13 years ago2008-07-23 Dean Jackson <dino@apple.com>
dino@apple.com [Thu, 24 Jul 2008 00:33:22 +0000 (00:33 +0000)]
2008-07-23  Dean Jackson  <dino@apple.com>

        Reviewed by Dan Bernstein.

        Update computed style test for transform to reflect that
        we return "none" rather than identity matrix.

        * svg/css/getComputedStyle-basic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agobuild fix.
adele@apple.com [Wed, 23 Jul 2008 23:15:04 +0000 (23:15 +0000)]
build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-23 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Wed, 23 Jul 2008 22:36:39 +0000 (22:36 +0000)]
2008-07-23  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Geoff Garen.

        Sampling tool to analyze cost of instruction execution and identify hot regions of JS code.
        Enable Switches by setting SAMPLING_TOOL_ENABLED in Opcode.h.

        * JavaScriptCore.exp: Export symbols for Shell.cpp.
        * VM/Machine.cpp:     Added sampling hooks.
        * VM/Machine.h:       Machine contains a pointer to a sampler, when sampling.
        * VM/Opcode.cpp:      Tool implementation.
        * VM/Opcode.h:        Tool declaration.
        * kjs/Shell.cpp:      Initialize the sampler, if enabled.
        * kjs/nodes.cpp:      Added sampling hooks.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-23 Sam Weinig <sam@webkit.org>
weinig@apple.com [Wed, 23 Jul 2008 22:32:24 +0000 (22:32 +0000)]
2008-07-23  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Cleanup and pack the member variables in Node.

        * bindings/js/JSNodeCustom.cpp:
        * dom/Attr.cpp:
        * dom/Attr.h:
        * dom/ContainerNode.cpp:
        * dom/Document.cpp:
        * dom/Element.cpp:
        * dom/Element.h:
        * dom/Node.h:
        * html/HTMLAnchorElement.cpp:
        * html/HTMLImageElement.cpp:
        * html/HTMLInputElement.cpp:
        * html/HTMLTableElement.cpp:
        * svg/SVGAElement.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-23 Kevin Calhoun <kcalhoun@apple.com>
adele@apple.com [Wed, 23 Jul 2008 21:45:51 +0000 (21:45 +0000)]
2008-07-23  Kevin Calhoun  <kcalhoun@apple.com>

        Reviewed by Adele.

        Follow-up fix for <rdar://problem/6031039> don't disable track-types when media is in a standalone document

        Associate MovieControllers with Movies to support all of the media types QuickTime is able to play in standalone media documents.

        * platform/graphics/win/QTMovieWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-23 Kevin Calhoun <kcalhoun@apple.com>
adele@apple.com [Wed, 23 Jul 2008 21:40:54 +0000 (21:40 +0000)]
2008-07-23  Kevin Calhoun  <kcalhoun@apple.com>

        Reviewed by Adele.

        Added a debug mode for viewing frames per second for videos.  This is controlled by two
        independent compiler flags DRAW_FRAME_RATE in MediaPlayerPrivateQTKit.h and MediaPlayerPrivateQuickTimeWin.h.
        Unless either flags is turned on there is no change to the code for video frame drawing.

        * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
        * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-23 Adele Peterson <adele@apple.com>
adele@apple.com [Wed, 23 Jul 2008 21:30:42 +0000 (21:30 +0000)]
2008-07-23  Adele Peterson  <adele@apple.com>

        Reviewed by Sam.

        Fix for <rdar://problem/6080634> use lower quality CG interpolation in MediaPlayerPrivateQTKit to improve performance

        * platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::drawImage):
        Call setImageInterpolationQuality(InterpolationNone) instead of setUseLowQualityImageInterpolation(true).
        * platform/graphics/GraphicsContext.h:
        (WebCore::): Added InterpolationQuality enum.
        (WebCore::GraphicsContext::setImageInterpolationQuality): Renamed from setUseLowQualityImageInterpolation.
        The implementation was always setting the quality to "none", and now we want to distinguish between "none" and "low".
        (WebCore::GraphicsContext::imageInterpolationQuality): Renamed from useLowQualityImageInterpolation.
        * platform/graphics/cg/GraphicsContextCG.cpp:
        (WebCore::GraphicsContext::setImageInterpolationQuality): Added.
        (WebCore::GraphicsContext::imageInterpolationQuality): Added.
        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::paint):
        Calls setImageInterpolationQuality(InterpolationLow) which will improve the painting performance without degrading quality too much.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-23 Sam Weinig <sam@webkit.org>
weinig@apple.com [Wed, 23 Jul 2008 21:28:53 +0000 (21:28 +0000)]
2008-07-23  Sam Weinig  <sam@webkit.org>

        Reviewed by Dan Bernstein.

        Remove tiger specific result for toDataURL-supportedTypes.html as it should have the
        same results on all platforms.

        * platform/mac-tiger/fast/canvas: Removed.
        * platform/mac-tiger/fast/canvas/toDataURL-supportedTypes-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-23 Sam Weinig <sam@webkit.org>
weinig@apple.com [Wed, 23 Jul 2008 20:13:04 +0000 (20:13 +0000)]
2008-07-23  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Remove extraneous allocations by using equalIgnoringCase rather than

        * dom/StyledElement.cpp:
        * html/HTMLCollection.cpp:
        * html/HTMLFormCollection.cpp:
        * html/HTMLLinkElement.cpp:
        * html/HTMLObjectElement.cpp:
        * html/PreloadScanner.cpp:
        * loader/FrameLoader.cpp:
        * page/DOMSelection.cpp:
        * rendering/RenderPartObject.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-23 Maxime Britto <britto@apple.com>
britto@apple.com [Wed, 23 Jul 2008 20:12:09 +0000 (20:12 +0000)]
2008-07-23  Maxime Britto  <britto@apple.com>

        Reviewed by Adam Roben.

        <rdar://6092952> "REGRESSION: Crash beneath EventHandler::stopAutoscrollTimer() when closing Gmail"
        Add a check for the m_page member value before asking for page()->mainFrame()

        * page/EventHandler.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-23 Kevin Calhoun <kcalhoun@apple.com>
adele@apple.com [Wed, 23 Jul 2008 18:16:19 +0000 (18:16 +0000)]
2008-07-23  Kevin Calhoun  <kcalhoun@apple.com>

       Reviewed by Adele.

       Fix for <rdar://problem/5710065> QT movies should be inactive when opened

       Implemented deferral of set-up of video rendering on Mac until the ready state is Loaded and
       until after movie tracks of unsupported types have been disabled, to make sure they never draw.

        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-22 Maxime Britto <britto@apple.com>
britto@apple.com [Wed, 23 Jul 2008 16:48:47 +0000 (16:48 +0000)]
2008-07-22  Maxime Britto  <britto@apple.com>

        Reviewed by John Sullivan.

        When pan-scrolling, Back then Forward causes pan-scrolling to start again

        * page/Frame.cpp:
        (WebCore::Frame::clearTimers): Ask to stop the autoscroll timer when we clear the timers from the frame
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::scrollToAnchor): When the link is an anchor we Frame::clearTimers() isn't called since we're only scrolling the page so we need to ask to stop the autoscroll timer here too.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-23 Gabor Loki <loki@inf.u-szeged.hu>
ddkilzer@apple.com [Wed, 23 Jul 2008 15:00:17 +0000 (15:00 +0000)]
2008-07-23  Gabor Loki  <loki@inf.u-szeged.hu>

        Bug 20097: [Qt] 20% Sunspider slow-down


        Reviewed by Simon Hausmann.

        * kjs/jsc.pro: Added missing NDEBUG define for release builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Geoff Garen.
ap@webkit.org [Wed, 23 Jul 2008 10:15:16 +0000 (10:15 +0000)]
    Reviewed by Geoff Garen.

        JSClassRef is created context-free, but gets infatuated with the first context it sees.

        The implicit API contract is that JSClassRef can be used with any context on any thread.
        This no longer worked, because UStrings in the class were turned into per-context
        identifiers, and the cached JSObject prototype was tied to JSGlobalData, too.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Build fix.
ap@webkit.org [Wed, 23 Jul 2008 08:21:20 +0000 (08:21 +0000)]
    Build fix.

        * kjs/ArgList.h: (KJS::ArgList::operator new): removed an extraneous "ArgList::" inside the
        class definition.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
ggaren@apple.com [Wed, 23 Jul 2008 05:10:05 +0000 (05:10 +0000)]

2008-07-22  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt and Sam Weinig.

        Next step toward putting doubles in registers: Prepare the Register class
        and its clients for registers that don't contain JSValue*s.

        This means a few things:

        1. Register::jsValue() clients, including ArgList clients, must now supply
        an ExecState* when accessing an entry in an ArgList, in case the entry
        will need to create a JSValue* on the fly.

        2. Register clients that definitely don't want to create a JSValue* on
        the fly now use different APIs: getJSValue() for clients that know
        the register contains a JSValue*, and v() for clients who just want a

        3. I had to change some headers around in order to resolve dependency
        problems created by using a Register in the ArgList header.

        SunSpider reports no change.


2008-07-22  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt and Sam Weinig.

        Next step toward putting doubles in registers: Prepare the Register class
        and its clients for registers that don't contain JSValue*s.


2008-07-22  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt and Sam Weinig.

        Next step toward putting doubles in registers: Prepare the Register class
        and its clients for registers that don't contain JSValue*s.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
weinig@apple.com [Wed, 23 Jul 2008 03:11:15 +0000 (03:11 +0000)]

2008-07-22  Sam Weinig  <sam@webkit.org>

        Reviewed by Mark Rowe.

        <rdar://problem/5788451> toDataURL not implemented for Windows (need mapping of MIME type to UTI)
        Add additional support for JPEG and GIF for toDataURL encoding canvases.

        * platform/MIMETypeRegistry.cpp:
        * platform/graphics/cg/ImageBufferCG.cpp:


2008-07-22  Sam Weinig  <sam@webkit.org>

        Reviewed by Mark Rowe.

        <rdar://problem/5788451> toDataURL not implemented for Windows (need mapping of MIME type to UTI)
        Add additional support for JPEG and GIF for toDataURL encoding canvases.

        - Turn on and simplify toDataURL-supportedTypes.html to only test for support of mimeTypes and not
          fail due to differences in image encoders.

        * fast/canvas/toDataURL-supportedTypes-expected.txt:
        * fast/canvas/toDataURL-supportedTypes.html: Copied from fast/canvas/toDataURL-supportedTypes.html-disabled.
        * fast/canvas/toDataURL-supportedTypes.html-disabled: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago<rdar://problem/6004877> internal anchors on this page are not showing up in the...
cfleizach@apple.com [Tue, 22 Jul 2008 21:45:53 +0000 (21:45 +0000)]
<rdar://problem/6004877> internal anchors on this page are not showing up in the AXLinkedUIElements

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-22 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 22 Jul 2008 20:23:10 +0000 (20:23 +0000)]
2008-07-22  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam.

        Allocate the empty StringImpl from the heap.

        * platform/text/StringImpl.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-21 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Tue, 22 Jul 2008 17:25:55 +0000 (17:25 +0000)]
2008-07-21  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Tim.

        <rdar://problem/5951532> JSProfiler: Implement heavy (or bottom-up)
        view (19228)
        - Implement UI for Heavy (Bottom Up) view.

        * English.lproj/localizedStrings.js:
        * page/JavaScriptProfile.cpp: Expose the ability to get a heavy/tree
        profile from a profile to the Web Inspector's JavaScript.
        * page/inspector/ProfileView.js: Implement the dropdown for changing
        profile views.
        * page/inspector/inspector.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adam Roben.
ap@webkit.org [Tue, 22 Jul 2008 15:51:34 +0000 (15:51 +0000)]
    Reviewed by Adam Roben.

        <rdar://problem/5955602> WebKit should support charset name x-windows-949

        Test: fast/encoding/char-decoding.html

        * platform/text/TextCodecICU.cpp:
        (WebCore::TextCodecICU::registerExtendedEncodingNames): Added support for this name for
        Firefox compatibility.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
barraclough@apple.com [Tue, 22 Jul 2008 14:26:01 +0000 (14:26 +0000)]

2008-07-22  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Alexey Proskuryakov.

        Prevent integer overflow when reallocating storage vector for arrays.

        Sunspider reports 1.005x as fast (no change expected).

        * kjs/JSArray.cpp:


2008-07-22  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Alexey Proskuryakov.

        New test to check that arrays fail gracefully (throw an out of memory exception)
        when the vector grows to large.

        * manual-tests/array-out-of-memory.html:         Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Dan Bernstein.
ap@webkit.org [Tue, 22 Jul 2008 05:52:09 +0000 (05:52 +0000)]
    Reviewed by Dan Bernstein.

        setBaseAndExtent fails to reverse the current selection

        Test: editing/selection/setBaseAndExtent-revert-selection.html

        * editing/Selection.h: (WebCore::operator==): Compare direction, too.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agowx build fix. Fix pthread linkage under Linux.
kevino@webkit.org [Tue, 22 Jul 2008 04:35:20 +0000 (04:35 +0000)]
wx build fix. Fix pthread linkage under Linux.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
jchaffraix@webkit.org [Tue, 22 Jul 2008 01:43:10 +0000 (01:43 +0000)]

2008-07-21  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Sam Weinig.

        Bug 19919: Add selectors' string parsing in CSSParser

        No functional change.

        * css/CSSGrammar.y: Added entry for parsing only a selector.
        * css/CSSParser.cpp:
        * css/CSSParser.h: Added m_floatingSelector to hold the
        Selector parsed in parseSelector.

        * css/tokenizer.flex: Added "@-webkit-selector" token.
        * dom/Node.cpp:
        (WebCore::Node::querySelectorAll): Switched to parseSelector

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-21 Kevin Calhoun <kcalhoun@apple.com>
adele@apple.com [Tue, 22 Jul 2008 01:19:19 +0000 (01:19 +0000)]
2008-07-21  Kevin Calhoun  <kcalhoun@apple.com>

        Reviewed by Adele.

        Fix for <rdar://problem/6081160> REGRESSION: Hang loading many pages if QuickTime isn't installed

        * platform/graphics/win/QTMovieWin.cpp:
        (initializeSupportedTypes): Do a Quicktime version minimum version check.
        (QTMovieWin::initializeQuickTime): Store the Quicktime version globally so in can be used in initializeSupportedTypes as well.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-21 Kevin Calhoun <kcalhoun@apple.com>
adele@apple.com [Tue, 22 Jul 2008 01:09:09 +0000 (01:09 +0000)]
2008-07-21  Kevin Calhoun  <kcalhoun@apple.com>

        Reviewed by Adele.

        Fix for <rdar://problem/5713336> <video> and <audio> elements that use a autoplay attribute fail to start playing when returning back to page

        * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::willSaveToCache): Reset the ready state to DATA_UNAVAILABLE when saving to the cache
        so that everything starts back up normally when the page is retrieved from the cache.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Mark Rowe.
weinig@apple.com [Tue, 22 Jul 2008 01:06:01 +0000 (01:06 +0000)]
    Reviewed by Mark Rowe.

        Remove unused interface declaration.

        * platform/network/mac/ResourceHandleMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago<rdar://problem/6091287> Revamp the handling of CFBundleShortVersionString to be...
mrowe@apple.com [Tue, 22 Jul 2008 01:05:12 +0000 (01:05 +0000)]
<rdar://problem/6091287> Revamp the handling of CFBundleShortVersionString to be fixed at the major component of the version number.

Reviewed by Sam Weinig.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-21 Kevin Calhoun <kcalhoun@apple.com>
adele@apple.com [Tue, 22 Jul 2008 01:02:13 +0000 (01:02 +0000)]
2008-07-21  Kevin Calhoun  <kcalhoun@apple.com>

        Reviewed by Adele.

        Fix for <rdar://problem/6031039> don't disable track-types when media is in a standalone document

        * platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::inMediaDocument): Added.
        * platform/graphics/MediaPlayer.h:
        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::updateStates):
        * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::updateStates):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-21 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 22 Jul 2008 00:41:02 +0000 (00:41 +0000)]
2008-07-21  Anders Carlsson  <andersca@apple.com>

        Reviewed by Jon.

        Don't allow requests to be made when the document loader is stopping all loaders.

        * plugins/PluginView.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebKit/mac:
andersca@apple.com [Mon, 21 Jul 2008 23:07:30 +0000 (23:07 +0000)]

2008-07-21  Anders Carlsson  <andersca@apple.com>

        Reviewed by Geoff.

        CrashTracer: [USER] 3759 crashes in Safari at FrameLoader::activeDocumentLoader const + 6 while canceling plug-in load

        Don't allow URLs to be loaded in response to an NPP_DestroyStream that happens when tearing down the plug-in.

        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):


2008-07-21  Anders Carlsson  <andersca@apple.com>

        Reviewed by Geoff.

        CrashTracer: [USER] 3759 crashes in Safari at FrameLoader::activeDocumentLoader const + 6 while canceling plug-in load

        * http/tests/plugins/geturlnotify-from-npp-destroystream-expected.txt: Added.
        * http/tests/plugins/geturlnotify-from-npp-destroystream.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-20 Maxime Britto <britto@apple.com>
britto@apple.com [Mon, 21 Jul 2008 20:23:48 +0000 (20:23 +0000)]
2008-07-20  Maxime Britto  <britto@apple.com>

        Reviewed by John Sullivan.

        [PFR] <rdar://problem/6080639> New middle click scrolling speed seems much slower than in FF
        Accelerate and enhance the smoothness of the pan scrollling.

        * page/EventHandler.cpp: Changed the TimerInterval from 0.1 to 0.05. The scrolling is way more fluid like this.
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::panScrollFromPoint): Differentiate the speed within a 200 pixel side square, around the original click location to the speed for farther distances. This way we allow easyier handle when we are close to the center and very fast scrolling when we go far from the original point.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-18 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Mon, 21 Jul 2008 20:16:38 +0000 (20:16 +0000)]
2008-07-18  David Hyatt  <hyatt@apple.com>

        Change the cached clip rects to not assume they should be infinite when the root layer has been
        shifted as the result of a transformation.

        Reviewed by Maciej

        Added fast/transforms/overflow-with-transform.html

        * rendering/RenderLayer.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Mitz.
rwlbuis@webkit.org [Mon, 21 Jul 2008 20:15:08 +0000 (20:15 +0000)]
    Reviewed by Mitz.

        CSS variables crash when using hex notation for colors

        Support hex colors as values for the css variables.

        Test: fast/css/variables/color-hex-test.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUpdate Akismet plugin to 2.1.6.
mrowe@apple.com [Mon, 21 Jul 2008 18:29:24 +0000 (18:29 +0000)]
Update Akismet plugin to 2.1.6.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUpdate to WordPress 2.6.
mrowe@apple.com [Mon, 21 Jul 2008 18:16:22 +0000 (18:16 +0000)]
Update to WordPress 2.6.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Add Vector::find
aroben@apple.com [Mon, 21 Jul 2008 17:43:05 +0000 (17:43 +0000)]
    Add Vector::find

        This is a convenience wrapper around std::find.

        Reviewed by Anders Carlsson.

        * wtf/Vector.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago<rdar://problem/5624143> WebView printing doesn't work correctly in x86_64
mrowe@apple.com [Mon, 21 Jul 2008 15:13:25 +0000 (15:13 +0000)]
<rdar://problem/5624143> WebView printing doesn't work correctly in x86_64

Fix the return type of an NSView method that we override so that the correct data type is used in 64-bit.
This prevents a garbage value being used for the scale factor that the NSView print machinery applies.

Reviewed by Adam Roben.

* WebView/WebHTMLView.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix CallDelegateReturningFloat for x86_64.
mrowe@apple.com [Mon, 21 Jul 2008 15:13:22 +0000 (15:13 +0000)]
Fix CallDelegateReturningFloat for x86_64.

The x86_64 Objective-C runtime only uses objc_msgSend_fpret for
long double return values.  For float return values the standard
objc_msgSend is used, as on ppc and ppc64.

Reviewed by Adam Roben.

* WebView/WebView.mm: Use objc_msgSend_float_return as the name of our version of
objc_msgSend with the correct return type.  We can no longer call it objc_msgSend_fpret
as that method is defined by the Objective-C runtime for x86_64.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoRoll out r35261
barraclough@apple.com [Mon, 21 Jul 2008 14:45:40 +0000 (14:45 +0000)]
Roll out r35261

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-21 Simon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Mon, 21 Jul 2008 13:47:04 +0000 (13:47 +0000)]
2008-07-21  Simon Hausmann  <hausmann@webkit.org>

        Reviewed by Holger.

        Fix drawing of windowless plugins on Windows with the Qt port by
        avoiding the reset of the translation of the HDC to 0, 0.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-21 Simon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Mon, 21 Jul 2008 13:46:45 +0000 (13:46 +0000)]
2008-07-21  Simon Hausmann  <hausmann@webkit.org>

        Reviewed by Holger.

        Fix rendering of transparent windowless netscape plugins by passing
        the right conversion parameter to QPixmap::fromWinHBITMAP when
        converting from HBITMAP to QPixmap.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-21 Simon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Mon, 21 Jul 2008 13:46:23 +0000 (13:46 +0000)]
2008-07-21  Simon Hausmann  <hausmann@webkit.org>

        Reviewed by Holger.

        In the implementation of getValue for NPNVnetscapeWindow treat
        windowHandleForPlatformWidget on the return value of
        containingWindow() to receive the correct HWND for the Qt port.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-21 Simon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Mon, 21 Jul 2008 13:46:03 +0000 (13:46 +0000)]
2008-07-21  Simon Hausmann  <hausmann@webkit.org>

        Reviewed by Holger.

        Fix windowHandleForPlatformWidget to return 0 as HWND if we don't have
        a QWidget. This can happen on page/view destruction for example.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
ddkilzer@apple.com [Mon, 21 Jul 2008 09:34:36 +0000 (09:34 +0000)]

2008-07-21  Anatoli Papirovski  <apapirovski@mac.com>

        Reviewed by Dave Hyatt.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=14346
        Modified the css parser:
        - not to fail when closing braces are not found for
          a declaration at the end of the file
        - not to accept "!important fail" as valid
        - to keep accepting @import when it comes after invalid @ rules
        - not to drop the whole @media block when there's an error before the
          closing brace
        + some other minor css parsing revisions.

        * css/CSSGrammar.y:


2008-07-21  Anatoli Papirovski  <apapirovski@mac.com>

        Reviewed by Dave Hyatt.

        Updated layout CSS2.1 test suite tests related to css parsing:

        * platform/mac/css2.1/t040105-import-01-b-expected.checksum:
        * platform/mac/css2.1/t040105-import-01-b-expected.png:
        * platform/mac/css2.1/t040105-import-01-b-expected.txt:
        * platform/mac/css2.1/t0402-syntax-05-f-expected.checksum:
        * platform/mac/css2.1/t0402-syntax-05-f-expected.png:
        * platform/mac/css2.1/t0402-syntax-05-f-expected.txt:
        * platform/mac/css2.1/t0402-syntax-06-f-expected.checksum:
        * platform/mac/css2.1/t0402-syntax-06-f-expected.png:
        * platform/mac/css2.1/t0402-syntax-06-f-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Touch file to force rebuild for vsprops change.
sfalken@apple.com [Mon, 21 Jul 2008 03:39:12 +0000 (03:39 +0000)]
    Touch file to force rebuild for vsprops change.

        * WebCorePrefix.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Build fix.
sfalken@apple.com [Mon, 21 Jul 2008 03:38:15 +0000 (03:38 +0000)]
    Build fix.

        * win/tools/vsprops/common.vsprops:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWhoops, forgot to commit expected output for this test.
oliver@apple.com [Mon, 21 Jul 2008 01:37:38 +0000 (01:37 +0000)]
Whoops, forgot to commit expected output for this test.

RS=Dan Bernstein

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-20 Sam Weinig <sam@webkit.org>
weinig@apple.com [Sun, 20 Jul 2008 23:39:05 +0000 (23:39 +0000)]
2008-07-20  Sam Weinig  <sam@webkit.org>

        Remove extra space Oliver Hunt left in.

        * page/Console.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBug 19757: Crash when an ondragstart handler hides the element
oliver@apple.com [Sun, 20 Jul 2008 21:31:49 +0000 (21:31 +0000)]
Bug 19757: Crash when an ondragstart handler hides the element

Reviewed by Dan Bernstein.

The solution to this is problem is just to null check the renderer
immediately before launching the system drag, and terminate the
drag if the renderer is gone.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoReviewed by Oliver.
zimmermann@webkit.org [Sun, 20 Jul 2008 20:48:43 +0000 (20:48 +0000)]
Reviewed by Oliver.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=12171
Remove manual SVG property <-> XML attribute synchronization in SVGPolyElement.
Added svg/custom/poly-points-attribute-changes.svg (testcase from Rob)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoReviewed by Oliver.
zimmermann@webkit.org [Sun, 20 Jul 2008 20:40:49 +0000 (20:40 +0000)]
Reviewed by Oliver.
Cleanup JSSVGPODTypeWrapper code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBug 15979: Console logs in a database callback lose line number information
oliver@apple.com [Sun, 20 Jul 2008 12:43:22 +0000 (12:43 +0000)]
Bug 15979: Console logs in a database callback lose line number information

Reviewed by Mark Rowe

The problem was that there were multiple versions of the logic to
log an exception to the console, many of which were incorrect.  We
resolve this by making one single shared reportException method,
which handles the exceptions correctly.

This improves fidelity of callback errors, and ensures that
exceptions thrown in timer callbacks correctly report line numbers,

Test: fast/js/exceptions-thrown-in-callbacks.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoRubber stamped by Oliver.
zimmermann@webkit.org [Sun, 20 Jul 2008 11:46:32 +0000 (11:46 +0000)]
Rubber stamped by Oliver.
Another attempt to fix the win build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by David Kilzer.
ap@webkit.org [Sun, 20 Jul 2008 09:24:02 +0000 (09:24 +0000)]
    Reviewed by David Kilzer.

        Fix high CPU usage on testmyiphone.com.

        - Made the logic for determining when to stop looking for meta charset more strainghtforward.
        Previously, this happened if a tag that's disallowed in HEAD was seen past the first 512
        bytes. Now, the algorithm bails out at the boundary if we are lo longer in HEAD (i.e, an
        offending tag was seen at any point before).

        - The above change made one of our regression tests fail, because it had its <meta>
        declaration past the 512 byte boundary. Fixed it by raising the boundary to 1024 bytes.

        - Made the algorithm bail out quickly if a comment that's not in HEAD crosses the boundary.

        - Moved a check for XML content type out of the loop.

        * loader/TextResourceDecoder.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBug 20104: Exception in tables/mozilla_expected_failures/bugs/bug92868_1.html include...
oliver@apple.com [Sun, 20 Jul 2008 05:29:44 +0000 (05:29 +0000)]
Bug 20104: Exception in tables/mozilla_expected_failures/bugs/bug92868_1.html includes the equals operator in the quoted expression

Reviewed by Cameron Zwarich

To make this correct we make the dot and bracket assign nodes emit the information to indicate
the failure range is the dot/bracket accessor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAttempt to fix windows build.
oliver@apple.com [Sat, 19 Jul 2008 22:05:26 +0000 (22:05 +0000)]
Attempt to fix windows build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoReviewed by Oliver & parts by Eric.
zimmermann@webkit.org [Sat, 19 Jul 2008 15:46:48 +0000 (15:46 +0000)]
Reviewed by Oliver & parts by Eric.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=20051
Rewrite animated property concept without heavy macro usage, replace by a templatified solution.
Fewer virtual function calls, no more usage of the tear-off's within internal code (synchronization needed it before.)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Windows build fix.
sfalken@apple.com [Sat, 19 Jul 2008 04:40:35 +0000 (04:40 +0000)]
    Windows build fix.

        * kjs/JSGlobalObjectFunctions.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Windows build fix.
sfalken@apple.com [Sat, 19 Jul 2008 04:11:13 +0000 (04:11 +0000)]
    Windows build fix.

        * kjs/nodes.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBug 18774: SQUIRRELFISH: print meaningful error messages <https://bugs.webkit.org...
oliver@apple.com [Sat, 19 Jul 2008 01:44:24 +0000 (01:44 +0000)]
Bug 18774: SQUIRRELFISH: print meaningful error messages <https://bugs.webkit.org/show_bug.cgi?id=18774>
<rdar://problem/5769353> SQUIRRELFISH: JavaScript error messages are missing informative text

Reviewed by Cameron Zwarich

Add support for decent error messages in JavaScript.  This patch achieves this by providing
ensuring the common errors and exceptions have messages that provide the text of expression
that trigger the exception.  In addition it attaches a number of properties to the exception
object detailing where in the source the expression came from.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-18 Maxime Britto <britto@apple.com>
britto@apple.com [Sat, 19 Jul 2008 01:36:30 +0000 (01:36 +0000)]
2008-07-18  Maxime Britto  <britto@apple.com>

        Reviewed by Adele.

        Fixed <rdar://problem/6049803>
        Prevent the autoscroll to trigger in WebClips when starting or hovering on an editable field.

        Test: fast/events/autoscroll-with-non-scrollable-parent.html

        * ChangeLog:
        * page/EventHandler.cpp: Edited
        (WebCore::EventHandler::handleMousePressEvent): changed the name of the funtion called to canBeProgramaticallyScrolled()
        (WebCore::EventHandler::handleMouseDraggedEvent): prevent the autoscroll to keep looking for a renderer when it's already triggered
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::scrollRectToVisible): verifies that the top layer can be programmatically scrolled before asking him to make the rect visible
        * rendering/RenderListBox.h:
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::canBeProgramaticallyScrolled): Edited : For the 3rd case we want document's renderer to have scrollbar as it's the top layer
        (WebCore::RenderObject::hasScrollableView): Verifies that the Object has a view with scrollBars
        * rendering/RenderObject.h: Renamed shouldAutosroll() for canBeProgramaticallyScrolled()
        * rendering/RenderTextControl.h:

2008-07-18  Adele Peterson & Maxime Britto  <britto@apple.com>

        Reviewed by Adele.

        Test for <rdar://problem/6049803> Autoscroll triggered on no scrolling iframes

        * ChangeLog:
        * fast/events/autoscroll-with-non-scrollable-parent-expected.txt: Added.
        * fast/events/autoscroll-with-non-scrollable-parent.html: Added.
        * fast/events/resources/big-page-with-input.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-18 Sam Weinig <sam@webkit.org>
weinig@apple.com [Sat, 19 Jul 2008 00:22:21 +0000 (00:22 +0000)]
2008-07-18  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        <rdar://problem/6087283> Add support for uploading files via XMLHttpRequest

        - Overload XMLHttpRequests send() method to accept File tokens.

        * bindings/js/JSXMLHttpRequestCustom.cpp:
        * xml/XMLHttpRequest.cpp:
        * xml/XMLHttpRequest.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
ggaren@apple.com [Fri, 18 Jul 2008 22:18:21 +0000 (22:18 +0000)]

2008-07-18  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Cameron Zwarich.

        Three renames:

        "CallTypeNative" => "CallTypeHost"
        "code" => "byteCode"
        "generatedCode" => "generatedByteCode"


2008-07-18  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Cameron Zwarich.

        Three renames:

        "CallTypeNative" => "CallTypeHost"
        "code" => "byteCode"
        "generatedCode" => "generatedByteCode"

        * ChangeLog:
        * JSObject.cpp:


2008-07-18  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Cameron Zwarich.

        Three renames:

        "CallTypeNative" => "CallTypeHost"
        "code" => "byteCode"
        "generatedCode" => "generatedByteCode"

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-18 Adele Peterson <adele@apple.com>
adele@apple.com [Fri, 18 Jul 2008 22:15:05 +0000 (22:15 +0000)]
2008-07-18  Adele Peterson  <adele@apple.com>

        Reviewed by Dan Bernstein.

        I recently made a change to avoid fading media controls in and out if a video element actually only contains audio,
        which broke the code that did the same thing for audio elements that contain video (but don't actually display that video).
        This change will now check both the media element and the player to decide whether or not to make the controls persistent.

        * rendering/RenderMedia.cpp: (WebCore::RenderMedia::updateControlVisibility):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-18 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 18 Jul 2008 22:04:10 +0000 (22:04 +0000)]
2008-07-18  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by mitz

        Remove braces around single-line conditional.

        * css/CSSComputedStyleDeclaration.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-18 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 18 Jul 2008 21:59:32 +0000 (21:59 +0000)]
2008-07-18  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dave Hyatt

        getComputedStyle() for -webkit-transform should return
        'none' for elements with no renderer, or those with no


        Testcase: LayoutTests/fast/css/computed-style-without-renderer

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-18 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 18 Jul 2008 21:44:39 +0000 (21:44 +0000)]
2008-07-18  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dave Hyatt

        Fix assertion about creating Length values with percentage types
        when blending transforms.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-18 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Fri, 18 Jul 2008 21:25:27 +0000 (21:25 +0000)]
2008-07-18  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Optimized <= for immediate number cases.

        SunSpider reports no overall change, but a 10% speedup on access-nsieve.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix some casts added in a previous build fix to match the style used
mrowe@apple.com [Fri, 18 Jul 2008 21:03:14 +0000 (21:03 +0000)]
Fix some casts added in a previous build fix to match the style used
throughout WebKit.

Rubber-stamped by Sam Weinig.

* VM/Machine.cpp:
* VM/Register.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Update expected results for a recently added test to what is seen when runnin...
ap@webkit.org [Fri, 18 Jul 2008 18:31:59 +0000 (18:31 +0000)]
    Update expected results for a recently added test to what is seen when running the
        full test suite.

        * fast/forms/form-and-frame-interaction-retains-values-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Bug 19975: [OpenBSD] Patches to enable build of WebKit
ddkilzer@apple.com [Fri, 18 Jul 2008 15:31:37 +0000 (15:31 +0000)]
    Bug 19975: [OpenBSD] Patches to enable build of WebKit


2008-07-18  Landry Breuil  <landry@openbsd.org>

        Bug 19975: [OpenBSD] Patches to enable build of WebKit


        Reviewed by David Kilzer.

        Support for OpenBSD, mostly threading and libm tweaks.

        * kjs/collector.cpp: #include <pthread.h>
        (KJS::currentThreadStackBase): use pthread_stackseg_np() to get stack base
        * kjs/config.h: OpenBSD also provides <pthread_np.h>
        * wtf/MathExtras.h: #include <sys/types.h> and <machine/ieee.h>
        (isfinite), (signbit): as long as we don't have those functions provide fallback implementations
        * wtf/Platform.h: Add support for PLATFORM(OPENBSD) and PLATFORM(SPARC64) macro


2008-07-18  Landry Breuil  <landry@openbsd.org>

        Bug 19975: [OpenBSD] Patches to enable build of WebKit


        Reviewed by David Kilzer.

        * DumpRenderTree/DumpRenderTree.h: OpenBSD doesn't support wide characters.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fixed indentation of example code for C++ pointers/references!
ddkilzer@apple.com [Fri, 18 Jul 2008 15:21:24 +0000 (15:21 +0000)]
    Fixed indentation of example code for C++ pointers/references!

        * coding/coding-style.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-18 Robert Blaut <webkit@blaut.biz>
ddkilzer@apple.com [Fri, 18 Jul 2008 15:15:56 +0000 (15:15 +0000)]
2008-07-18  Robert Blaut  <webkit@blaut.biz>

        Reviewed by David Kilzer.

        Fix for <https://bugs.webkit.org/show_bug.cgi?id=12313>
        Added code style guidelines for multi-line boolean expressions

        * coding/coding-style.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-17 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Fri, 18 Jul 2008 04:00:28 +0000 (04:00 +0000)]
2008-07-17  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Next step toward putting doubles in registers: Store constant pool
        entries as registers, not JSValue*s.

        SunSpider reports no change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-17 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Thu, 17 Jul 2008 23:53:39 +0000 (23:53 +0000)]
2008-07-17  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by John Sullivan and Oliver Hunt.

        A tiny bit of tidying in function call register allocation.

        This patch saves one register when invoking a function expression and/or
        a new expression that is stored in a temporary.

        Since it's just one register, I can't make a testcase for it.

        * VM/CodeGenerator.cpp:
        (KJS::CodeGenerator::emitCall): No need to ref the function we're calling
        or its base. We'd like the call frame to overlap with them, if possible.
        op_call will read the function and its base before writing the call frame,
        so this is safe.

        * kjs/nodes.cpp:
        (KJS::NewExprNode::emitCode): No need to ref the function we're new-ing,
        for the same reasons stated above.

        (KJS::FunctionCallValueNode::emitCode): ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-17 Steve Falkenburg <sfalken@apple.com>
sfalken@apple.com [Thu, 17 Jul 2008 22:28:37 +0000 (22:28 +0000)]
2008-07-17  Steve Falkenburg  <sfalken@apple.com>

        Build fix.

        * kjs/InternalFunction.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
ggaren@apple.com [Thu, 17 Jul 2008 21:42:24 +0000 (21:42 +0000)]

2008-07-17  Sam Weinig  <sam@webkit.org>

        Roll out r35199 as it is causing failures on the PPC build.


2008-07-17  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by David Kilzer.

        Test for https://bugs.webkit.org/show_bug.cgi?id=20067
        Support function.name (Firefox extension)

        * fast/js/function-name-expected.txt: Added.
        * fast/js/function-name.html: Added.
        * fast/js/resources/function-name.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-17 Sam Weinig <sam@webkit.org>
weinig@apple.com [Thu, 17 Jul 2008 21:11:04 +0000 (21:11 +0000)]
2008-07-17  Sam Weinig  <sam@webkit.org>

        Roll out r35199 as it is causing failures on the PPC build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
ggaren@apple.com [Thu, 17 Jul 2008 20:39:52 +0000 (20:39 +0000)]

2008-07-17  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Fixed <rdar://problem/6081636> Functions calls use more temporary
        registers than necessary

        Holding a reference to the last statement result register caused each
        successive statement to output its result to an even higher register.

        Happily, statements don't actually need to return a result register
        at all. I hope to make this clearer in a future cleanup patch,
        but this change will fix the major bug for now.

        * kjs/nodes.cpp:


2008-07-17  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Test for <rdar://problem/6081636> Functions calls use more temporary
        registers than necessary

        * fast/js/function-call-register-allocation.html: Added.
        * fast/js/function-call-register-allocation-expected.txt: Added.
        * fast/js/resources/function-call-register-allocation.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by rwlbuis@gmail.com
rwlbuis@webkit.org [Thu, 17 Jul 2008 19:49:52 +0000 (19:49 +0000)]
    Reviewed by rwlbuis@gmail.com


        - Added "@"{ident} rule (below other @-rules) to use flex for longest match
          (if an earlier rule - e.g. @media - also matches then flex chooses that one
           however, if a longer match - e.g. @mediaall matches flex will choose that)
        - Updated grammar to defined ATKEYWORD token and to use that instead of '@'
          in the error recovery grammar.

        Test: css2.1/atrule_longest_match.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-17 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Thu, 17 Jul 2008 19:24:57 +0000 (19:24 +0000)]
2008-07-17  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Sam Weinig.

        Merge pre&post dot nodes to simplify the parse tree.
        Sunspider results show 0.6% progression (no performance change expected).

        * kjs/grammar.y:
        * kjs/nodes.cpp:
        * kjs/nodes.h:
        * kjs/nodes2string.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-17 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Thu, 17 Jul 2008 18:24:32 +0000 (18:24 +0000)]
2008-07-17  David Hyatt  <hyatt@apple.com>

        Make sure the check to see if a frame/iframe is being rendered inside a transparency layer is
        recursive (and checks for transparency layers all the way up the ancestor document chain back to
        the top-level frame).

        Reviewed by Dan

        * rendering/RenderView.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-17 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Thu, 17 Jul 2008 13:25:32 +0000 (13:25 +0000)]
2008-07-17  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Cameron Zwarich.

        Merge pre&post resolve nodes to simplify the parse tree.
        Sunspider results show no performance change.

        * kjs/grammar.y:
        * kjs/nodes.cpp:
        * kjs/nodes.h:
        * kjs/nodes2string.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-17 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Thu, 17 Jul 2008 12:06:13 +0000 (12:06 +0000)]
2008-07-17  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Cameron Zwarich.

        Merge logical nodes to simplify the parse tree.
        Sunspider results show 0.6% progression (no performance change expected).

        * kjs/grammar.y:
        * kjs/nodes.cpp:
        * kjs/nodes.h:
        * kjs/nodes2string.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-17 Ariya Hidayat <ariya.hidayat@trolltech.com>
hausmann@webkit.org [Thu, 17 Jul 2008 12:01:57 +0000 (12:01 +0000)]
2008-07-17  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Reviewed by Simon.

        Fix MinGW build (broken in r35198) and simplify getLocalTime().

        * kjs/DateMath.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago[GTK] WebKit crashes on invalid settings notify callback
christian@webkit.org [Thu, 17 Jul 2008 11:51:00 +0000 (11:51 +0000)]
[GTK] WebKit crashes on invalid settings notify callback


Disconnect in webkit_web_view_finalize

Reviewed by Holger Freyther.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-17 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Thu, 17 Jul 2008 11:44:09 +0000 (11:44 +0000)]
2008-07-17  Gavin Barraclough  <barraclough@apple.com>

        Merge pre&post bracket nodes to simplify the parse tree.
        Sunspider results show no performance change.

        Reviewed by Sam Weinig.

        * kjs/grammar.y:
        * kjs/nodes.cpp:
        * kjs/nodes.h:
        * kjs/nodes2string.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-17 Ariya Hidayat <ariya.hidayat@trolltech.com>
hausmann@webkit.org [Thu, 17 Jul 2008 11:34:22 +0000 (11:34 +0000)]
2008-07-17  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Reviewed by Simon.

        Fix the 32-bit gcc builds, conversion from "long int" to Register is
        ambiguous. Explicitly choose the intptr_t constructor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by mitz.
eric@webkit.org [Thu, 17 Jul 2008 07:18:41 +0000 (07:18 +0000)]
    Reviewed by mitz.

        Attempt to make initializeATSUStyle human-readable by
        splitting it out into better-named static inline functions.

        No functional changes, thus no tests.

        * platform/graphics/mac/FontMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago No review, build fix only.
eric@webkit.org [Thu, 17 Jul 2008 07:17:56 +0000 (07:17 +0000)]
    No review, build fix only.

        Attempt to fix Mac build

        * WebCore.xcodeproj/project.pbxproj: Make TextRun.h a private header.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-16 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Thu, 17 Jul 2008 06:51:00 +0000 (06:51 +0000)]
2008-07-16  Jon Honeycutt  <jhoneycutt@apple.com>

        CygwinDownloader fails to install necessary packages

        Reviewed by Mark Rowe.

        * CygwinDownloader/cygwin-downloader.zip: Rebuilt after two broken
        mirrors removed in r34116. Set MIME type to application/octet-stream.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-16 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Thu, 17 Jul 2008 06:20:23 +0000 (06:20 +0000)]
2008-07-16  Jon Honeycutt  <jhoneycutt@apple.com>

        CygwinDownloader's make-zip.sh script fails

        Reviewed by Mark Rowe.

        * CygwinDownloader/cygwin-downloader.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-16 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Thu, 17 Jul 2008 06:17:27 +0000 (06:17 +0000)]
2008-07-16  Jon Honeycutt  <jhoneycutt@apple.com>

        REGRESSION: Can't create windowless plug-in with Flash 9

        Reviewed by Mark Rowe.

        * plugins/win/PluginPackageWin.cpp:
        (WebCore::PluginPackage::determineQuirks): Reverse argument order;
        PlatformModuleVersion constructor takes leastSig, mostSig.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by mitz.
eric@webkit.org [Thu, 17 Jul 2008 06:13:42 +0000 (06:13 +0000)]
    Reviewed by mitz.

        Make ATSULayoutParameters a real C++ class
        (Give it a destructor to clean up after itself)
        (Also use OwnArrayPtr instead of manual member cleanup)

        * platform/graphics/mac/FontMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by mitz.
eric@webkit.org [Thu, 17 Jul 2008 06:12:41 +0000 (06:12 +0000)]
    Reviewed by mitz.

        Make ownership of copied UChar buffer clearer
        (and more leak-proof) by using a OwnArrayPtr.

        No functional changes, thus no tests.

        * platform/graphics/mac/FontMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix JavaScript in 64-bit by using a pointer-sized integer
mrowe@apple.com [Thu, 17 Jul 2008 05:27:35 +0000 (05:27 +0000)]
Fix JavaScript in 64-bit by using a pointer-sized integer
type in the Register union.  Also includes a rename of
the intType constant to IntType.

Rubber-stamped by Geoff Garen.

* VM/Machine.cpp:
* VM/Register.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Sam.
eric@webkit.org [Thu, 17 Jul 2008 04:04:53 +0000 (04:04 +0000)]
    Reviewed by Sam.

        Split out TextRun into its own header file.
        Re-order members to place all bools together
        (to allow compilers to better pack the struct)

        No functional changes, thus no tests.

        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * platform/graphics/Font.h: Moved TextRun into its own file.
        * platform/graphics/TextRun.h: Split out from Font.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-16 Simon Fraser <simon.fraser@apple.com>
dino@apple.com [Thu, 17 Jul 2008 01:16:30 +0000 (01:16 +0000)]
2008-07-16  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dave Hyatt

        AnimationController needs to adjust z-index in the blended
        style in case opacity or transform were changed by blending.


        Test: transitions/opacity-transition-zindex.html

        * page/AnimationController.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35207 268f45cc-cd09-0410-ab3c-d52691b4dbfc