ggaren [Mon, 5 Nov 2007 21:56:09 +0000 (21:56 +0000)]
Build fix.
* ForwardingHeaders/kjs/value.h: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27450
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp [Mon, 5 Nov 2007 21:35:03 +0000 (21:35 +0000)]
2007-11-05 Alp Toker <alp@atoker.com>
Unreviewed build fix for qmake-based ports.
Someone with a better understanding of qmake still needs to sort out
the INCLUDEPATH/DEPENDPATH mess.
* JavaScriptCore.pri:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27449
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Mon, 5 Nov 2007 21:27:15 +0000 (21:27 +0000)]
JavaScriptCore:
Reviewed by Darin Adler.
http://bugs.webkit.org/show_bug.cgi?id=15835
Switched List implementation from a custom heap allocator to an inline
Vector, for a disappointing .5% SunSpider speedup.
Also renamed List::slice to List::getSlice because "get" is the
conventional prefix for functions returning a value through an out
parameter.
* kjs/array_object.cpp:
(KJS::ArrayProtoFunc::callAsFunction): Removed some redundant function
calls and memory accesses.
* kjs/bool_object.cpp:
(BooleanObjectImp::construct): Removed questionable use of iterator.
* kjs/list.cpp:
* kjs/list.h: New List class, implemented in terms of Vector. Two
interesting differences:
1. The inline capacity is 8, not 5. Many of the Lists constructed
during a SunSpider run are larger than 5; almost none are larger
than 8.
2. The growth factor is 4, not 2. Since we can guarantee that Lists
aren't long-lived, we can grow them more aggressively, to avoid
excessive copying.
* kjs/regexp_object.cpp:
(RegExpObjectImp::construct): Removed redundant function calls.
* kjs/string_object.cpp:
(KJS::StringObjectImp::construct): Removed questionable use of iterator.
* wtf/Vector.h:
(WTF::::uncheckedAppend): Added a fast, unchecked version of append.
WebCore:
Reviewed by Darin Adler.
http://bugs.webkit.org/show_bug.cgi?id=15835
Small adaptations to new KJS::List class.
* bindings/js/kjs_window.cpp:
(KJS::WindowFunc::callAsFunction):
(KJS::ScheduledAction::ScheduledAction):
WebKit:
Reviewed by Darin Adler.
http://bugs.webkit.org/show_bug.cgi?id=15835
Small adaptations to new KJS::List class.
* ForwardingHeaders/kjs/value.h: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27448
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Mon, 5 Nov 2007 21:09:12 +0000 (21:09 +0000)]
2007-11-05 Mark Rowe <mrowe@apple.com>
Reviewed by Alp Toker.
Add DEPENDPATH to JavaScriptCore and pcre to help qmake with dependencies.
* JavaScriptCore.pri:
* pcre/pcre.pri:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27447
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Mon, 5 Nov 2007 18:57:49 +0000 (18:57 +0000)]
Add support on Windows for WEBKIT_TESTFONTS
This environment variable lets you specify where the fonts to be used
by DumpRenderTree reside. The Qt port is already using this, so I'm
just following their lead.
Reviewed by Darin.
* DumpRenderTree/win/DumpRenderTree.cpp:
(exePath): Refactored code out of initialize().
(fontsPath): Returns either $WEBKIT_TESTFONTS or
DumpRenderTree.resources.
(initialize): Use the new fontsPath function.
(main): Use the new exePath function.
* Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
variable to DRT, like Qt does.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27446
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Mon, 5 Nov 2007 18:57:30 +0000 (18:57 +0000)]
Add IWebCache::disabled
This matches the Mac WebCache class.
Reviewed by Sam.
* Interfaces/IWebCache.idl:
* WebCache.cpp:
(WebCache::disabled):
* WebCache.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27445
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Mon, 5 Nov 2007 18:57:10 +0000 (18:57 +0000)]
Add IWebInspector and a way to get one from a WebView
WebCore:
Allow passing a base class pointer to COMPtr::copyRefTo
Reviewed by Sam.
* platform/win/COMPtr.h:
WebKit/win:
Add IWebInspector and a way to get one from a WebView
This API matches the Mac one added in r27266.
Reviewed by Sam.
* Interfaces/IWebInspector.idl: Added.
* Interfaces/IWebViewPrivate.idl: Added a new inspector method to
match Mac.
* WebInspector.cpp: Added.
(WebInspector::createInstance):
(WebInspector::WebInspector):
(WebInspector::~WebInspector):
(WebInspector::webViewClosed):
(WebInspector::QueryInterface):
(WebInspector::AddRef):
(WebInspector::Release):
(WebInspector::show):
(WebInspector::showConsole):
(WebInspector::showTimeline):
(WebInspector::close):
(WebInspector::attach):
(WebInspector::detach):
* WebInspector.h: Added.
* WebKit.vcproj/Interfaces.vcproj: Added IWebInspector.idl.
* WebKit.vcproj/WebKit.vcproj: Added WebInspector.{cpp,h}.
* WebKit.vcproj/WebKitGUID.vcproj: Added IWebInspector_i.c.
* WebView.cpp:
(WebView::close): Notify the WebInspector that we're closing.
(WebView::inspector): Added.
* WebView.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27444
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Mon, 5 Nov 2007 18:56:49 +0000 (18:56 +0000)]
Cache strings that come directly from WebLocalizedString
Reviewed by Steve.
* WebLocalizableStrings.cpp:
(copyLocalizedStringFromBundle): This used to be WebLocalizedString,
but is now just a static helper function.
(findCachedStringInMap): Added static helper.
(findCachedString): Refactored and cleaned up code from
WebLocalizedLPCTSTR.
(cacheString): Ditto.
(WebLocalizedString): Rewrote to use the new helper functions.
(WebLocalizedLPCTSTR): Changed to use the new helper functions.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27443
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Mon, 5 Nov 2007 18:55:46 +0000 (18:55 +0000)]
Only override the default user agent string if we're actually given a custom one
Reviewed by Sam.
* WebView.cpp:
(WebView::setCustomUserAgent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27442
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Mon, 5 Nov 2007 18:52:49 +0000 (18:52 +0000)]
WebCore:
Reviewed by Oliver Hunt.
- fix ASSERTION FAILED: !HashTranslator::equal(KeyTraits::emptyValue(), key) when a class attribute is all-whitespace
Test: fast/dom/class-all-whitespace.html
* dom/StyledElement.cpp:
(WebCore::StyledElement::parseMappedAttribute): Check if there is any
non-whitespace character in the class attribute.
LayoutTests:
Reviewed by Oliver Hunt.
- test that an all-whitespace class attribute does not cause an assertion failure
* fast/dom/class-all-whitespace-expected.txt: Added.
* fast/dom/class-all-whitespace.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27441
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Mon, 5 Nov 2007 18:23:19 +0000 (18:23 +0000)]
Reviewed by Sam
Add transaction blocking to the DatabaseAuthorizer in preparation for the new version
of the sql storage API
* storage/DatabaseAuthorizer.cpp:
(WebCore::DatabaseAuthorizer::allowTransaction):
* storage/DatabaseAuthorizer.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27440
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Mon, 5 Nov 2007 16:34:53 +0000 (16:34 +0000)]
2007-11-05 Mark Rowe <mrowe@apple.com>
Reviewed by Alp Toker.
Have getMIMETypeForExtension return a null string when no MIME type is known
for the extension rather than returning "text/plain". This prevents plugin data
being dumped into object elements when plugins are disabled.
* platform/gtk/MIMETypeRegistryGtk.cpp:
(WebCore::MIMETypeRegistry::getMIMETypeForExtension):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27439
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Mon, 5 Nov 2007 15:01:02 +0000 (15:01 +0000)]
2007-11-05 Mark Rowe <mrowe@apple.com>
Rubber-stamped by Alp Toker.
Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
* GtkLauncher/main.cpp:
(goToURLBarText):
(main):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27438
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Mon, 5 Nov 2007 14:39:42 +0000 (14:39 +0000)]
2007-11-05 Mark Rowe <mrowe@apple.com>
Rubber-stamped by Alp Toker.
Remove unused m_firstData member from FrameLoaderClientGtk.
* WebCoreSupport/FrameLoaderClientGtk.cpp:
* WebCoreSupport/FrameLoaderClientGtk.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27437
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Mon, 5 Nov 2007 14:39:25 +0000 (14:39 +0000)]
2007-11-05 Mark Rowe <mrowe@apple.com>
Reviewed by Alp Toker.
Fix http://bugs.webkit.org/show_bug.cgi?id=15842
Bug 15842: [Gtk] about:blank doesn't work
* WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::finishedLoading): Set the encoding on the frame loader to
get work done that is normally done when the first bit of data is received, even in the
case of a document with no data (like about:blank).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27436
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Mon, 5 Nov 2007 14:30:59 +0000 (14:30 +0000)]
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=15841
fast/dom/Document/early-document-access.html crashes under GuardMalloc
* fast/dom/Document/early-document-access.html: Don't check for open() timeout;
wait for popup window to close as long as it takes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27435
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer [Mon, 5 Nov 2007 06:38:23 +0000 (06:38 +0000)]
bisect-builds doesn't work with nightly build r19992 or newer on Leopard
<http://bugs.webkit.org/show_bug.cgi?id=15830>
Reviewed by Timothy.
Restrict the range of nightly builds used by the bisect-builds script
based on the version of Safari and the version of Mac OS X being used.
Mac OS X 10.4: Safari 2.0: r11976 or newer
Mac OS X 10.4: Safari 3.0: r19992 or newer
Mac OS X 10.5: Safari 2.0: r19594 or newer
Mac OS X 10.5: Safari 3.0: r25124 or newer
* Scripts/bisect-builds:
(findMacOSXVersion): Added.
(makeNightlyList): Added argument to provide version of Mac OS X.
Restrict range of nightly builds based on Safari and Mac OS X versions.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27434
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Mon, 5 Nov 2007 01:37:59 +0000 (01:37 +0000)]
Rubber-stamped by Adam Roben.
Rename SecurityOrigin::allowsAccessFrom to SecurityOrigin::canAccess to
clear up ambiguity.
* bindings/js/kjs_window.cpp:
(KJS::Window::isSafeScript):
* platform/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::canAccess):
* platform/SecurityOrigin.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27433
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Mon, 5 Nov 2007 00:20:55 +0000 (00:20 +0000)]
Land the HTML Editing Toolbar demo from WWDC 2007.
* demos: Added.
* demos/editingToolbar: Added.
* demos/editingToolbar/FancyToolbar.css: Added.
* demos/editingToolbar/FancyToolbar.js: Added.
* demos/editingToolbar/FancyToolbarImages: Added.
* demos/editingToolbar/FancyToolbarImages/button.png: Added.
* demos/editingToolbar/FancyToolbarImages/buttonLeft.png: Added.
* demos/editingToolbar/FancyToolbarImages/buttonMiddle.png: Added.
* demos/editingToolbar/FancyToolbarImages/buttonPressed.png: Added.
* demos/editingToolbar/FancyToolbarImages/buttonPressedLeft.png: Added.
* demos/editingToolbar/FancyToolbarImages/buttonPressedMiddle.png: Added.
* demos/editingToolbar/FancyToolbarImages/buttonPressedRight.png: Added.
* demos/editingToolbar/FancyToolbarImages/buttonRight.png: Added.
* demos/editingToolbar/FancyToolbarImages/camera.png: Added.
* demos/editingToolbar/FancyToolbarImages/link.png: Added.
* demos/editingToolbar/FancyToolbarImages/textAlign.png: Added.
* demos/editingToolbar/FancyToolbarImages/toolbarOutline.png: Added.
* demos/editingToolbar/FancyToolbarImages/toolbarOutlineBottom.png: Added.
* demos/editingToolbar/FancyToolbarImages/toolbarOutlineBottomLeft.png: Added.
* demos/editingToolbar/FancyToolbarImages/toolbarOutlineBottomRight.png: Added.
* demos/editingToolbar/FancyToolbarImages/toolbarOutlineLeft.png: Added.
* demos/editingToolbar/FancyToolbarImages/toolbarOutlineRight.png: Added.
* demos/editingToolbar/FancyToolbarImages/toolbarOutlineTop.png: Added.
* demos/editingToolbar/FancyToolbarImages/toolbarOutlineTopLeft.png: Added.
* demos/editingToolbar/FancyToolbarImages/toolbarOutlineTopRight.png: Added.
* demos/editingToolbar/content.html: Added.
* demos/editingToolbar/images: Added.
* demos/editingToolbar/images/safari.png: Added.
* demos/editingToolbar/index.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27432
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Mon, 5 Nov 2007 00:09:54 +0000 (00:09 +0000)]
Reviewed by Adam.
Bug 15834: There are many subtle bugs in the Styles pane of the Web Inspector
http://bugs.webkit.org/show_bug.cgi?id=15834
- Broke up DocumentPanel and added three SidebarPane sub-classes.
- Fixed many Style pane bugs, including:
* Poor handling of duplicate properties in the same rule. Some of this can't be
fixed since we can't only get the "winning" value for duplicate properties.
So we should only show one entry per unique property name.
* Computed style does not show font shorthand sub-properties if 'font' was used.
* Property priority was broken, the wrong properties were crossed out.
* The 'border' shorthand shows null for the shorthand value.
* Shorthands didn't show their priority (e.g. !important).
* HSL and HTML hex colors didn't have preview swatch blocks.
* Code refactoring, making it easier to reuse for console.log later.
* page/inspector/DocumentPanel.js: Move sidebar pane code to three seperate
classes in new files.
* page/inspector/MetricsSidebarPane.js: Added.
* page/inspector/Panel.js: Remove an InspectorController.log() call.
* page/inspector/PropertiesSection.js: Add the section to the TreeOutline.
So TreeElements can access properties on their section.
* page/inspector/PropertiesSidebarPane.js: Added.
* page/inspector/SidebarPane.js: Remove the explicit asignment of the
onexpand and oncollapse to null. These were hiding prototypes.
* page/inspector/StylesSidebarPane.js: Added.
* page/inspector/inspector.html: Include the new script files.
* page/inspector/treeoutline.js: If a null representedObject is passed
in just use a empty object.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27431
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kmccullo [Sun, 4 Nov 2007 22:36:32 +0000 (22:36 +0000)]
Reviewed by Maciej.
- This patch involves several changes, all of them were noticed that
they were needed by the work being done in WebKit to get Drosera and
WebKit working together on Windows.
- The changes are:
1) Added a debugger console for output messages.
2) Drosera now listens for the WebKit server (before, the server would
have to be running before Drosera was started.)
3) Fixed a bug where the WebView started out as 0x0 pixels.
4) Fixed a bug when there is no scope.
5) Added the HTML, JS, and CSS to the project file to make them easy to
find.
6) Made the ServerConnection functions virtual.
* Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
for the WebKit server.
(DebuggerClient::DebuggerClient):
(DebuggerClient::~DebuggerClient):
(DebuggerClient::didFinishLoadForFrame):
(DebuggerClient::serverConnected):
(DebuggerClient::attemptToCreateServerConnection):
* Drosera/win/DebuggerClient.h: Ditto.
* Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
scope.
(DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
(DebuggerDocument::platformValueForScopeVariableNamed):
* Drosera/win/Drosera.cpp:
(_tWinMain): Added a console in debug for output messages.
(Drosera::Drosera): Listen for server.
(Drosera::initUI): The server now Initializes COM.
(Drosera::serverConnected): Part of the listening for the server.
(Drosera::attemptToCreateServerConnection): Ditto.
* Drosera/win/Drosera.h: New interface for listening for the server.
* Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
files to the VS project.
* Drosera/win/ServerConnection.cpp: Part of listening for the server
connection.
(ServerConnection::ServerConnection):
(ServerConnection::attemptToCreateServerConnection):
* Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
methods.
(ServerConnection::serverConnected):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27430
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Sun, 4 Nov 2007 22:30:20 +0000 (22:30 +0000)]
Add svn:ignore for vcproj temp files under FindSafari.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27429
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Sun, 4 Nov 2007 20:27:16 +0000 (20:27 +0000)]
Reviewed by Maciej.
http://bugs.webkit.org/show_bug.cgi?id=15832
fast/dom/gc-10.html crashes when run alone
Check for !done before using objects that can be already deallocated.
* DumpRenderTree/mac/EditingDelegate.mm:
(-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
(-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
(-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
(-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
(-[EditingDelegate webView:shouldDeleteDOMRange:]):
(-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
(-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
(-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
(-[EditingDelegate webViewDidBeginEditing:]):
(-[EditingDelegate webViewDidChange:]):
(-[EditingDelegate webViewDidEndEditing:]):
(-[EditingDelegate webViewDidChangeTypingStyle:]):
(-[EditingDelegate webViewDidChangeSelection:]):
* DumpRenderTree/mac/FrameLoadDelegate.mm:
(-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
(-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
(-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
(-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
(-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
(-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
(-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
(-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
(-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
(-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
(-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
(-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
(-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
(-[FrameLoadDelegate webView:willCloseFrame:]):
(-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
(-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
* DumpRenderTree/mac/ResourceLoadDelegate.mm:
(-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
(-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
(-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
(-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
(-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
(-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27428
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer [Sun, 4 Nov 2007 16:46:50 +0000 (16:46 +0000)]
Fix build when spaces appear in the WebKit source path.
Reviewed by Mark Rowe.
* bindings/scripts/IDLParser.pm: Use safer open() method which lists
arguments individually and prevents the need to work around spaces
in the path.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27427
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer [Sun, 4 Nov 2007 16:13:24 +0000 (16:13 +0000)]
CIA has changed its hostname from cia.navi.cx to cia.vc
<http://bugs.webkit.org/show_bug.cgi?id=15829>
Reviewed by Mitz.
* contact.html: Updated links to CIA.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27426
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp [Sun, 4 Nov 2007 15:03:13 +0000 (15:03 +0000)]
2007-11-04 Alp Toker <alp@atoker.com>
Reviewed by Alexey Proskuryakov.
Fix a crash when no clipboard text is available
* platform/gtk/PasteboardGtk.cpp:
(WebCore::Pasteboard::plainText):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27425
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Sun, 4 Nov 2007 09:48:02 +0000 (09:48 +0000)]
2007-11-04 Mark Rowe <mrowe@apple.com>
Build fix. Don't use Carbon.h as the prefix header as it triggers
warnings that would otherwise be suppressed due to it being a system header.
* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27424
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Sun, 4 Nov 2007 08:58:15 +0000 (08:58 +0000)]
* hosted/sunspider.html: Tweaked formatting a bit.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27423
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Sun, 4 Nov 2007 08:28:22 +0000 (08:28 +0000)]
Reviewed by Maciej.
- http://bugs.webkit.org/show_bug.cgi?id=15826
optimize opcode loop and case insensitive ASCII compares for a 30% speedup
SunSpider says it's 2.6% faster overall, 32.5% in the regular expression tests.
* pcre/pcre_internal.h: Added OP_ASCII_CHAR and OP_ASCII_LETTER_NC.
* pcre/pcre_compile.c:
(find_fixedlength): Added cases for OP_ASCII_CHAR and OP_ASCII_LETTER_NC. Also
added OP_NOT since there was no reason it should not be in here.
(could_be_empty_branch): Ditto.
(compile_branch): Streamlined all the single-character cases; there was a bit of
duplicate code. Added cases for OP_ASCII_CHAR and OP_ASCII_LETTER_NC as needed.
But in particular, compile to those opcodes when the single character match is
ASCII.
(find_firstassertedchar): Added cases for OP_ASCII_CHAR and OP_ASCII_LETTER_NC.
* pcre/pcre_exec.c: (match): Removed the "min", "minimize", and "op" fields from
the matchframe, after I discovered that none of them needed to be saved and restored
across recursive match calls. Also eliminated the ignored result field from the
matchframe, since I discovered that rrc ("recursive result code") was already the
exact same thing. Moved the handling of opcodes higher than OP_BRA into the default
statement of the switch instead of doing them before the switch. This removes a
branch from each iteration of the opcode interpreter, just as removal of "op"
removed at least one store from each iteration. Last, but not least, add the
OP_ASCII_CHAR and OP_ASCII_LETTER_NC functions. Neither can ever match a
surrogate pair and the letter case can be handled efficiently.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27422
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Sun, 4 Nov 2007 07:54:56 +0000 (07:54 +0000)]
* pcre/pcre_exec.c: (match): Try to fix the Windows build by removing unreachable code.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27421
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Sun, 4 Nov 2007 06:18:31 +0000 (06:18 +0000)]
- fix non-Mac builds; remove some more unused PCRE stuff
* pcre/pcre_compile.c:
(compile_branch): Removed branch chain and some unused ESC values.
(compile_regex): Ditto.
(jsRegExpCompile): Ditto.
* pcre/pcre_exec.c:
(match): Removed unused branch targets. Don't use macros any more.
(jsRegExpExecute): More of the same.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Update for removed files.
* JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
* pcre/pcre.pri: Ditto.
* pcre/MERGING: Removed.
* pcre/pcre_fullinfo.c: Removed.
* pcre/pcre_get.c: Removed.
* pcre/pcre_internal.h:
* pcre/ucp.h: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27420
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Sun, 4 Nov 2007 05:22:44 +0000 (05:22 +0000)]
JavaScriptCore:
Reviewed by Maciej.
- http://bugs.webkit.org/show_bug.cgi?id=15821
remove unused PCRE features for speed
A first step toward removing the PCRE features we don't use.
This gives a 0.8% speedup on SunSpider, and a 6.5% speedup on
the SunSpider regular expression test.
Replaced the public interface with one that doesn't use the
name PCRE. Removed code we don't need for JavaScript and various
configurations we don't use. This is in preparation for still
more changes in the future. We'll probably switch to C++ and
make some even more significant changes to the regexp engine
to get some additional speed.
There's probably additional unused stuff that I haven't
deleted yet.
This does mean that our PCRE is now a fork, but I think that's
not really a big deal.
* JavaScriptCore.exp: Remove the 5 old entry points and add
the 3 new entry points for WebCore's direct use of the regular
expression engine.
* kjs/config.h: Remove the USE(PCRE16) define. I decided to flip
its sense and now there's a USE(POSIX_REGEX) instead, which should
probably not be set by anyone. Maybe later we'll just get rid of it
altogether.
* kjs/regexp.h:
* kjs/regexp.cpp:
(KJS::RegExp::RegExp): Switch to new jsRegExp function names and
defines. Cut down on the number of functions used.
(KJS::RegExp::~RegExp): Ditto.
(KJS::RegExp::match): Ditto.
* pcre/dftables.c: (main): Get rid of ctype_letter and ctype_meta,
which are unused.
* pcre/pcre-config.h: Get rid of EBCIDIC, PCRE_DATA_SCOPE, const,
size_t, HAVE_STRERROR, HAVE_MEMMOVE, HAVE_BCOPY, NEWLINE,
POSIX_MALLOC_THRESHOLD, NO_RECURSE, SUPPORT_UCP, SUPPORT_UTF8,
and JAVASCRIPT. These are all no longer configurable in our copy
of the library.
* pcre/pcre.h: Remove the macro-based kjs prefix hack, the PCRE
version macros, PCRE_UTF16, the code to set up PCRE_DATA_SCOPE,
the include of <stdlib.h>, and most of the constants and
functions defined in this header. Changed the naming scheme to
use a JSRegExp prefix rather than a pcre prefix. In the future,
we'll probably change this to be a C++ header.
* pcre/pcre_compile.c: Removed all unused code branches,
including many whole functions and various byte codes.
Kept changes outside of removal to a minimum.
(check_escape):
(first_significant_code):
(find_fixedlength):
(find_recurse):
(could_be_empty_branch):
(compile_branch):
(compile_regex):
(is_anchored):
(is_startline):
(find_firstassertedchar):
(jsRegExpCompile): Renamed from pcre_compile2 and changed the
parameters around a bit.
(jsRegExpFree): Added.
* pcre/pcre_exec.c: Removed many unused opcodes and variables.
Also started tearing down the NO_RECURSE mechanism since it's
now the default. In some cases there were things in the explicit
frame that could be turned into plain old local variables and
other small like optimizations.
(pchars):
(match_ref):
(match): Changed parameters quite a bit since it's now not used
recursively.
(jsRegExpExecute): Renamed from pcre_exec.
* pcre/pcre_internal.h: Get rid of PCRE_DEFINITION, PCRE_SPTR,
PCRE_IMS, PCRE_ICHANGED, PCRE_NOPARTIAL, PCRE_STUDY_MAPPED,
PUBLIC_OPTIONS, PUBLIC_EXEC_OPTIONS, PUBLIC_DFA_EXEC_OPTIONS,
PUBLIC_STUDY_OPTIONS, MAGIC_NUMBER, 16 of the opcodes,
_pcre_utt, _pcre_utt_size, _pcre_try_flipped, _pcre_ucp_findprop,
and _pcre_valid_utf8. Also moved pcre_malloc and pcre_free here.
* pcre/pcre_maketables.c: Changed to only compile in dftables.
Also got rid of many of the tables that we don't use.
* pcre/pcre_tables.c: Removed the unused Unicode property tables.
* pcre/pcre_ucp_searchfuncs.c: Removed everything except for
_pcre_ucp_othercase.
* pcre/pcre_xclass.c: (_pcre_xclass): Removed uneeded support
for classes based on Unicode properties.
* wtf/FastMallocPCRE.cpp: Removed unused bits. It would be good
to eliminate this completely, but we need the regular expression
code to be C++ first.
* pcre/pcre_fullinfo.c:
* pcre/pcre_get.c:
* pcre/ucp.h:
Files that are no longer needed. I didn't remove them with this
check-in, because I didn't want to modify all the project files.
WebCore:
Reviewed by Maciej.
- WebCore part of http://bugs.webkit.org/show_bug.cgi?id=15821
remove unused PCRE features for speed
* page/Frame.cpp: (WebCore::Frame::matchLabelsAgainstElement):
* page/mac/FrameMac.mm: (WebCore::Frame::matchLabelsAgainstElement):
Remove use of "[[:digit:]]" syntax. This hasn't worked for some time.
Use "\d" instead.
* platform/RegularExpression.h: Remove the unused cap function. We can
add it back later if we find we need it.
* platform/RegularExpression.cpp:
(WebCore::RegularExpression::Private::compile): Update for JavaScriptCore
regular expression entry point changes.
(WebCore::RegularExpression::Private::~Private): Ditto.
(WebCore::RegularExpression::match): Remove the code to set PCRE_NOTBOL.
This means that regular expressions with metacharactesr like ^ in them
won't work any more with non-whole-string searches, but we don't use
any regular expressions like that.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27419
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino [Sun, 4 Nov 2007 05:15:26 +0000 (05:15 +0000)]
Update the link stubs to match the current build, and fix coding style issues.
Reviewed by Mark Rowe.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27418
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Sun, 4 Nov 2007 04:17:58 +0000 (04:17 +0000)]
Build-fix.
* UserObjectImp.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27417
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Sun, 4 Nov 2007 03:37:21 +0000 (03:37 +0000)]
Reviewed by Sam.
- remove NaN check from JSImmediate::fromDouble for 0.5% SunSpider speedup
It turns out that doing this check costs more than it saves.
* kjs/JSImmediate.h:
(KJS::JSImmediate::fromDouble):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27416
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino [Sun, 4 Nov 2007 02:21:09 +0000 (02:21 +0000)]
wx <-> WebKit conversions for IntPoint, IntRect and FloatRect
Reviewed by Mark Rowe.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27415
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino [Sun, 4 Nov 2007 02:05:51 +0000 (02:05 +0000)]
wx <-> WebKit data type conversions for Pen and Color.
Reviewed by Darin Adler.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27414
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Sun, 4 Nov 2007 01:08:04 +0000 (01:08 +0000)]
JavaScriptCore:
Reviewed by Oliver.
Remove dummy variable from ClassInfo reducing the size of the struct by 1 word.
The variable had been kept around for binary compatibility, but since nothing
else is there is no point in continuing to keep it around.
* API/JSCallbackConstructor.cpp:
(KJS::):
* API/JSCallbackFunction.cpp:
(KJS::):
* API/JSCallbackObject.cpp:
(KJS::):
* bindings/objc/objc_runtime.mm:
* bindings/runtime_array.cpp:
* bindings/runtime_object.cpp:
* kjs/array_instance.cpp:
(KJS::):
* kjs/array_object.cpp:
(KJS::):
* kjs/bool_object.cpp:
* kjs/date_object.cpp:
(KJS::):
* kjs/error_object.cpp:
* kjs/function.cpp:
(KJS::):
* kjs/internal.cpp:
(KJS::):
* kjs/lookup.h:
* kjs/math_object.cpp:
* kjs/number_object.cpp:
* kjs/object.h:
* kjs/regexp_object.cpp:
* kjs/string_object.cpp:
(KJS::):
WebCore:
Reviewed by Oliver.
Remove dummy variable from ClassInfo reducing the size of the struct by 1 word.
The variable had been kept around for binary compatibility, but since nothing
else is there is no point in continuing to keep it around.
* bindings/js/JSDOMExceptionConstructor.cpp:
(WebCore::):
* bindings/js/JSHTMLInputElementBase.cpp:
(WebCore::):
* bindings/js/JSNamedNodesCollection.cpp:
(WebCore::):
* bindings/js/JSXMLHttpRequest.cpp:
(KJS::):
* bindings/js/JSXSLTProcessor.cpp:
(KJS::):
* bindings/js/kjs_css.cpp:
(WebCore::):
* bindings/js/kjs_events.cpp:
(WebCore::):
* bindings/js/kjs_navigator.cpp:
(KJS::):
* bindings/js/kjs_window.cpp:
(KJS::):
* bindings/scripts/CodeGeneratorJS.pm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27413
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kmccullo [Sat, 3 Nov 2007 23:52:57 +0000 (23:52 +0000)]
- Updated testkjs results to make the build bots green until we
can fix the tests that are failing. The new failures are in DST.
* tests/mozilla/expected.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27412
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Sat, 3 Nov 2007 22:58:41 +0000 (22:58 +0000)]
Reviewed by Darin.
- Add compare mode and a description of the benchmark to the hosted version.
* hosted/sunspider-results.html: Add compare mode - you can just paste in another results URL.
* hosted/sunspider.html: Added intro text.
* make-hosted: Copy new file.
* resources/sunspider-compare-results.js: Made more reusable by putting the implementation in
a function.
* resources/sunspider-standalone-compare.js: Added. Calls the function in the way standalone mode
expects.
* sunspider-compare-results: Use sunspider-standalone-compare.js.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27411
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Sat, 3 Nov 2007 21:13:36 +0000 (21:13 +0000)]
Reviewed by Adam.
- don't print the var twice for ForInNodes with a var declaration
* kjs/nodes2string.cpp:
(KJS::ForInNode::streamTo):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27410
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Sat, 3 Nov 2007 20:54:57 +0000 (20:54 +0000)]
Rubber stamped by Adam.
- Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27409
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Sat, 3 Nov 2007 16:44:00 +0000 (16:44 +0000)]
* pcre/pcre_compile.c: (check_escape): Windows build fix. Get rid of
C-incompatible declaration.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27408
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Sat, 3 Nov 2007 16:42:26 +0000 (16:42 +0000)]
2007-11-03 Mark Rowe <mrowe@apple.com>
Gtk build fix.
* kjs/nodes.cpp: Add missing include.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27407
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Sat, 3 Nov 2007 16:40:32 +0000 (16:40 +0000)]
JavaScriptCore:
Reviewed by Maciej.
- fix http://bugs.webkit.org/show_bug.cgi?id=15814
<rdar://problem/
5536644> fast/js/kde/encode_decode_uri.html fails
These changes cause us to match the JavaScript specification and pass the
fast/js/kde/encode_decode_uri.html test.
* kjs/function.cpp: (KJS::encode): Call the UTF-8 string conversion in its
new strict mode, throwing an exception if there are malformed UTF-16 surrogate
pairs in the text.
* kjs/ustring.h: Added a strict version of the UTF-8 string conversion.
* kjs/ustring.cpp:
(KJS::decodeUTF8Sequence): Removed code to disallow U+FFFE and U+FFFF; while
those might be illegal in some sense, they aren't supposed to get any special
handling in the place where this function is currently used.
(KJS::UString::UTF8String): Added the strictness.
LayoutTests:
Reviewed by Maciej.
- updates for http://bugs.webkit.org/show_bug.cgi?id=15814
<rdar://problem/
5536644> fast/js/kde/encode_decode_uri.html fails
* fast/js/kde/resources/encode_decode_uri.js: Rewrote the test to cover edges better,
and use the should functions in a way that makes failures easier to understand.
* fast/js/kde/encode_decode_uri-expected.txt: Updated.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27406
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Sat, 3 Nov 2007 16:28:51 +0000 (16:28 +0000)]
Reviewed by Maciej.
- http://bugs.webkit.org/show_bug.cgi?id=15812
some JavaScript tests (from the Mozilla test suite) are failing
Two or three fixes get 7 more of the Mozilla tests passing.
This gets us down from 61 failing tests to 54.
* kjs/interpreter.h: (KJS::Interpreter::builtinRegExp):
Made this inline and gave it a more specific type. Some day we should
probably do that for all of these -- might even get a bit of a speed
boost from it.
* kjs/interpreter.cpp: Removed Interpreter::builtinRegExp now that it's
inline in the header.
* kjs/regexp_object.h:
* kjs/regexp_object.cpp:
(KJS::RegExpProtoFunc::callAsFunction): Moved test and exec out of the
switch statement into the RegExpImp object, so they can be shared with
RegExpImp::callAsFunction.
(KJS::RegExpImp::match): Added. Common code used by both test and exec.
(KJS::RegExpImp::test): Added.
(KJS::RegExpImp::exec): Added.
(KJS::RegExpImp::implementsCall): Added.
(KJS::RegExpImp::callAsFunction): Added.
(KJS::RegExpObjectImpPrivate::RegExpObjectImpPrivate): Initialize
lastInput to null rather than empty string -- we take advantage of the
difference in RegExpImp::match.
(KJS::RegExpObjectImp::input): Added. No reason to go through hash tables
just to get at a field like this.
* pcre/pcre_compile.c: (check_escape): Changed the \u handling to match
the JavaScript specification. If there are not 4 hex digits after the \u,
then it's processed as if it wasn't an escape sequence at all.
* pcre/pcre_internal.h: Added IS_NEWLINE, with the appropriate definition
for JavaScript (4 specific Unicode values).
* pcre/pcre_exec.c:
(match): Changed all call sites to use IS_NEWLINE.
(pcre_exec): Ditto.
* tests/mozilla/expected.html: Updated to expect 7 more successful tests.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27405
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp [Sat, 3 Nov 2007 15:52:08 +0000 (15:52 +0000)]
Reviewed by Mark Rowe.
Restore correct double and triple click behaviour
We ended up ignoring GDK_2BUTTON_PRESS and GDK_3BUTTON_PRESS after
recent refactoring.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27404
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino [Sat, 3 Nov 2007 15:26:58 +0000 (15:26 +0000)]
Build fixes to get wx impls. building on trunk.
Reviewed by Mark Rowe.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27403
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer [Sat, 3 Nov 2007 15:10:51 +0000 (15:10 +0000)]
JavaScriptCore:
Sort files(...); sections of Xcode project files.
Rubber-stamped by Darin.
* JavaScriptCore.xcodeproj/project.pbxproj:
JavaScriptGlue:
Sort files(...); sections of Xcode project files.
Rubber-stamped by Darin.
* JavaScriptGlue.xcodeproj/project.pbxproj:
WebCore:
Sort files(...); sections of Xcode project files.
Rubber-stamped by Darin.
* WebCore.xcodeproj/project.pbxproj:
* manual-tests/NPN_Invoke/NPN_Invoke.xcodeproj/project.pbxproj:
WebKit:
Sort files(...); sections of Xcode project files.
Rubber-stamped by Darin.
* WebKit.xcodeproj/project.pbxproj:
WebKitTools:
Sort files(...); sections of Xcode project files.
Rubber-stamped by Darin.
* DrawTest/DrawTest.xcodeproj/project.pbxproj:
* Drosera/mac/Drosera.xcodeproj/project.pbxproj:
* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
* WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27402
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino [Sat, 3 Nov 2007 14:57:18 +0000 (14:57 +0000)]
Coding style fixes for platform/wx files.
Reviewed by Mark Rowe.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27401
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp [Sat, 3 Nov 2007 14:33:54 +0000 (14:33 +0000)]
Reviewed by Mark Rowe.
Implement platform scrollbar static width/height getters
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27400
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp [Sat, 3 Nov 2007 14:33:41 +0000 (14:33 +0000)]
Reviewed by Mark Rowe.
Cast function pointers to gpointer.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27399
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp [Sat, 3 Nov 2007 14:33:25 +0000 (14:33 +0000)]
Reviewed by Adam Roben.
RenderThemeGtk implementation based on Mozilla's GTK+ style code
There is still work needed to complete this feature.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27398
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp [Sat, 3 Nov 2007 14:33:02 +0000 (14:33 +0000)]
Reviewed by Mark Rowe.
Do not allow scrollbars to handle wheel events
We bubble the wheel event up so the parent can handle it instead.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27397
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp [Sat, 3 Nov 2007 14:32:43 +0000 (14:32 +0000)]
Reviewed by Mark Rowe.
Frame scrolling and invalidation fixes
Make upward scroll events have a positive delta to match other ports.
Fix the invalidation rect offset for frames so that scrolling works properly.
Avoid allocating negative sizes to widgets to avoid GTK+ warnings.
Allow tabbing to all widgets and links.
Fix event returns, improving the focus situation and correcting scroll wheel
behavior.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27396
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer [Sat, 3 Nov 2007 13:35:52 +0000 (13:35 +0000)]
WebCore:
LGPL'ed files contain incorrect FSF address
<http://bugs.webkit.org/show_bug.cgi?id=14885>
Reviewed by NOBODY (follow-up fix).
* bindings/js/JSSVGTransformListCustom.cpp:
* ksvg2/svg/SVGException.idl:
* ksvg2/svg/SVGTextPathElement.cpp:
* ksvg2/svg/SVGTextPathElement.h:
* ksvg2/svg/SVGViewSpec.cpp:
* ksvg2/svg/SVGViewSpec.h:
* platform/mac/FontCustomPlatformData.cpp:
* platform/mac/FontCustomPlatformData.h:
* platform/mac/FontPlatformDataMac.mm:
* platform/win/FontCustomPlatformData.cpp:
* platform/win/FontCustomPlatformData.h:
* rendering/RenderSVGRoot.cpp:
* rendering/RenderSVGRoot.h:
* rendering/RenderSVGTextPath.cpp:
* rendering/RenderSVGTextPath.h:
* rendering/RenderSVGTransformableContainer.h:
* rendering/RenderSVGViewportContainer.cpp:
* rendering/RenderSVGViewportContainer.h:
* rendering/SVGCharacterLayoutInfo.cpp:
* rendering/SVGCharacterLayoutInfo.h:
* rendering/SVGRenderSupport.cpp:
* rendering/SVGRenderSupport.h:
WebKitSite:
LGPL'ed files contain incorrect FSF address
<http://bugs.webkit.org/show_bug.cgi?id=14885>
Reviewed by NOBODY (follow-up fix).
* blog/wp-includes/class-snoopy.php:
* blog/wp-includes/gettext.php:
* blog/wp-includes/streams.php:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27395
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Sat, 3 Nov 2007 10:09:45 +0000 (10:09 +0000)]
Reviewed by Oliver.
- remove VarDeclListNode and simplify VarDeclNode evaluation for 0.4% SunSpider speedup
* kjs/grammar.y:
* kjs/nodes.cpp:
(KJS::VarDeclNode::optimizeVariableAccess):
(KJS::VarDeclNode::getDeclarations):
(KJS::VarDeclNode::handleSlowCase):
(KJS::VarDeclNode::evaluateSingle):
(KJS::VarDeclNode::evaluate):
(KJS::VarStatementNode::execute):
* kjs/nodes.h:
(KJS::VarDeclNode::):
(KJS::VarStatementNode::):
* kjs/nodes2string.cpp:
(KJS::VarDeclNode::streamTo):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27394
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Sat, 3 Nov 2007 08:36:48 +0000 (08:36 +0000)]
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=15800
REGRESSION (r27303): RegExp leaks
* kjs/regexp_object.h:
(KJS::RegExpImp::setRegExp):
(KJS::RegExpImp::regExp):
(KJS::RegExpImp::classInfo):
* kjs/regexp_object.cpp:
(RegExpImp::RegExpImp):
(RegExpImp::~RegExpImp):
Renamed reg member variable to m_regExp, changed it to use OwnPtr.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27393
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Sat, 3 Nov 2007 07:27:50 +0000 (07:27 +0000)]
Versioning.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27392
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer [Sat, 3 Nov 2007 06:58:34 +0000 (06:58 +0000)]
Script to sort "files(...);" sections in Xcode project.pbxproj files.
Rubber-stamped by Darin.
* Scripts/sort-Xcode-project-file: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27391
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti [Sat, 3 Nov 2007 04:17:47 +0000 (04:17 +0000)]
WebCore:
Reviewed by Adam.
Add video width/height DOM and content attributes from latest HTML5 draft.
Test: media/video-width-height.html
* html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::parseMappedAttribute):
(WebCore::HTMLVideoElement::width):
(WebCore::HTMLVideoElement::setWidth):
(WebCore::HTMLVideoElement::height):
(WebCore::HTMLVideoElement::setHeight):
* html/HTMLVideoElement.h:
* html/HTMLVideoElement.idl:
LayoutTests:
Reviewed by Adam.
Test for video width/height DOM and content attributes.
* media/video-width-height-expected.txt: Added.
* media/video-width-height.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27390
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Sat, 3 Nov 2007 03:24:28 +0000 (03:24 +0000)]
Reviewed by Oliver.
- add SourceElements as a typedef for Vector<RefPtr<StatementNode> >.
* kjs/grammar.y:
* kjs/nodes.cpp:
(KJS::statementListPushFIFO):
(KJS::statementListGetDeclarations):
(KJS::statementListInitializeDeclarationStacks):
(KJS::statementListInitializeVariableAccessStack):
(KJS::statementListExecute):
(KJS::BlockNode::BlockNode):
(KJS::FunctionBodyNode::FunctionBodyNode):
(KJS::ProgramNode::ProgramNode):
* kjs/nodes.h:
(KJS::CaseClauseNode::):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27389
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Sat, 3 Nov 2007 00:48:56 +0000 (00:48 +0000)]
Reviewed by Maciej.
* DerivedSources.make: Remove a few explicit filenames from some rules by using
make variables a little more.
* WebCore.LP64.exp: Fix typo, grammar.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27388
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Sat, 3 Nov 2007 00:46:32 +0000 (00:46 +0000)]
Reviewed by Maciej.
- http://bugs.webkit.org/show_bug.cgi?id=15791
change property map data structure for less memory use, better speed
The property map now has an array of indices and a separate array of
property map entries. This slightly slows down lookup because of a second
memory acess, but makes property maps smaller and faster to iterate in
functions like mark().
SunSpider says this is 1.2% faster, although it makes the bitwise-end test
more than 10% slower. To fix that we'll need to optimize global variable lookup.
* kjs/property_map.cpp:
(KJS::PropertyMapEntry::PropertyMapEntry):
(KJS::PropertyMapHashTable::entries):
(KJS::PropertyMapHashTable::allocationSize):
(KJS::SavedProperties::SavedProperties):
(KJS::SavedProperties::~SavedProperties):
(KJS::PropertyMap::checkConsistency):
(KJS::PropertyMap::~PropertyMap):
(KJS::PropertyMap::clear):
(KJS::PropertyMap::get):
(KJS::PropertyMap::getLocation):
(KJS::PropertyMap::put):
(KJS::PropertyMap::insert):
(KJS::PropertyMap::createTable):
(KJS::PropertyMap::rehash):
(KJS::PropertyMap::remove):
(KJS::PropertyMap::mark):
(KJS::comparePropertyMapEntryIndices):
(KJS::PropertyMap::containsGettersOrSetters):
(KJS::PropertyMap::getEnumerablePropertyNames):
(KJS::PropertyMap::save):
(KJS::PropertyMap::restore):
* kjs/property_map.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27387
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti [Sat, 3 Nov 2007 00:39:57 +0000 (00:39 +0000)]
Reviewed by Darin.
Update to add WKQTMovieViewSetDrawSynchronously
* WebKitSystemInterface.h:
* libWebKitSystemInterfaceLeopard.a:
* libWebKitSystemInterfaceTiger.a:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27386
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Sat, 3 Nov 2007 00:30:44 +0000 (00:30 +0000)]
JavaScriptCore:
Reviewed by Maciej.
- http://bugs.webkit.org/show_bug.cgi?id=15807
HashMap needs a take() function that combines get and remove
* wtf/HashMap.h: Added take function. Simplistic implementation for now,
but still does only one hash table lookup.
* kjs/array_instance.cpp: (KJS::ArrayInstance::put): Use take rather than
a find followed by a remove.
WebCore:
Reviewed by Maciej.
- use the new HashMap::take function where appropriate
* bindings/js/kjs_binding.cpp:
(KJS::addWrapper): Made an inline rather than a macro; inlines good, macros bad.
(KJS::removeWrapper): Ditto.
(KJS::removeWrappers): Ditto.
(KJS::ScriptInterpreter::putDOMObject): Use the inline instead of the macro.
(KJS::ScriptInterpreter::forgetDOMObject): Ditto. This involves using take instead
of remove -- in theory ever so slightly less efficient, but I think it's fine.
(KJS::ScriptInterpreter::forgetDOMNodeForDocument): Ditto.
(KJS::ScriptInterpreter::putDOMNodeForDocument): Use the inline instead of the macro.
(KJS::ScriptInterpreter::forgetAllDOMNodesForDocument): Use take instead of find/remove.
(KJS::ScriptInterpreter::updateDOMNodeDocument): Use the inlines instead of the macros.
* bindings/js/kjs_window.cpp: (KJS::Window::clearTimeout): Use take instead of find/remove.
* bridge/mac/AXObjectCacheMac.mm: (WebCore::AXObjectCache::remove): Ditto.
* page/AnimationController.cpp: (WebCore::AnimationControllerPrivate::clear): Ditto.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::~RenderBlock): Ditto.
(WebCore::RenderBlock::setDesiredColumnCountAndWidth): Ditto.
* rendering/RootInlineBox.cpp: Ditto.(WebCore::RootInlineBox::detachEllipsisBox): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27385
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti [Sat, 3 Nov 2007 00:23:43 +0000 (00:23 +0000)]
WebCore:
Reviewed by Darin.
Enable video composition.
* WebCore.base.exp:
* platform/graphics/mac/MoviePrivateQTKit.mm:
(WebCore::MoviePrivate::createQTMovieView):
* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:
WebKit:
Reviewed by Darin.
Add method to enable video composition.
* WebCoreSupport/WebSystemInterface.m:
(InitWebCoreSystemInterface):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27384
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Sat, 3 Nov 2007 00:20:01 +0000 (00:20 +0000)]
SunSpider:
* sunspider: Changed "--base" to "--set-baseline".
WebKitTools:
* Scripts/run-sunspider: Changed "--base" to "--set-baseline".
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27383
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Sat, 3 Nov 2007 00:15:02 +0000 (00:15 +0000)]
SunSpider:
Reviewed by Maciej.
* sunspider: Added a "--base" option that records the current test as a baseline.
Moved the code to find the newest .mshark file into a function (since I needed to use
it in the other script and I prefer to copy/paste a function).
* sunspider-compare-results: Added logic to compare the baseline with the last
run when you don't pass any parameters.
WebKitTools:
Reviewed by Maciej.
* Scripts/run-sunspider: Pass the "--base" option through.
* Scripts/sunspider-compare-results: Don't check the number of parameters; let
the real script do that. Default configuration to Release to match run-sunspider
so we don't end up building Debug just to compare results.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27382
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Fri, 2 Nov 2007 23:16:08 +0000 (23:16 +0000)]
Reviewed by Darin.
Fix compiler warning "warning: suggest parentheses around && within ||"
http://bugs.webkit.org/show_bug.cgi?id=15764
* kjs/value.h: (KJS::JSValue::isNumber): Add parentheses.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27381
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Fri, 2 Nov 2007 23:13:36 +0000 (23:13 +0000)]
WebCore:
Reviewed by Mitz.
- fix http://bugs.webkit.org/show_bug.cgi?id=15806
<rdar://problem/
5561626> ASSERT(element->isRadioButton()) fires destroying form elements
Test: fast/forms/remove-radio-button-assert.html
* html/HTMLGenericFormElement.cpp: (WebCore::HTMLGenericFormElement::removeFromForm):
Added protected function to be used by derived classes that need to do the same sort
of removal from form that's automatically done by the base class in certain circumstances.
* html/HTMLGenericFormElement.h: Added removeFromForm.
* html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::~HTMLInputElement):
Call removeFromForm here so the element is removed before we destroy the HTMLInputElement
part of this object. By the time we get to the base class's destructor it's too late.
The problem is specific to radio buttons so we don't have to worry about other classes
derived from HTMLGenericFormElement.
LayoutTests:
Reviewed by Mitz.
- test for http://bugs.webkit.org/show_bug.cgi?id=15806
<rdar://problem/
5561626> ASSERT(element->isRadioButton()) fires destroying form elements
* fast/forms/remove-radio-button-assert-expected.txt: Added.
* fast/forms/remove-radio-button-assert.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27380
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Fri, 2 Nov 2007 23:11:12 +0000 (23:11 +0000)]
Reviewed by Mitz.
- speculative fix for http://bugs.webkit.org/show_bug.cgi?id=15805
<rdar://problem/
5510779> crashes in isLoadingMultipartContent
* loader/DocumentLoader.cpp: (WebCore::DocumentLoader::isLoadingMultipartContent):
Instead of asserting the frame loader is non-0, return false if it is 0.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27379
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Fri, 2 Nov 2007 23:08:41 +0000 (23:08 +0000)]
WebCore:
Reviewed by Mitz.
- fix <rdar://problem/
5530185> WebKit does not show <object> fallback content when both
URL and MIME type is omitted
Already covered by existing tests (that had incorrect results).
* loader/FrameLoader.cpp: (WebCore::FrameLoader::requestObject): Return false to indicate
failure when both URL and MIME type are empty. The old code would not attempt a load, but
it would indicate success.
* rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::updateWidget): Remove
non-helpful early exit for the case where there is no URL and no type. Returning early
prevents the fallback code from running.
WebKit:
Reviewed by Mitz.
- fix problem I ran into while doing some testing on Mac for
<rdar://problem/
5530185> WebKit does not show <object>
fallback content when both URL and MIME type is omitted
I don't know how to reproduce this failure in DumpRenderTree, so there is no
regression test.
* Plugins/WebNullPluginView.h: Removed some unneeded declarations, including
the didSendError local variable. Instead we just set the error to nil once
we've sent it.
* Plugins/WebNullPluginView.mm:
(-[WebNullPluginView initWithFrame:error:DOMElement:]): Refactored so that
the null plug-in image code is separate from the rest of the function and
so that the whole thing is not inside an if statement. Also don't hold a
reference to the DOM element if there is no error to report.
(-[WebNullPluginView reportFailure]): Added. Does the actual delegate
callback. Happens back at the top level of the run loop so it doesn't
fire deep inside layout. Also wrote this so that it is guaranteed not to
reenter and so that it can handle the case where the delegate destroys
the world (including this object). NOTE: This is not a real, general
solution to the problem of plug-ins that do work inside layout. We will need
a more general fix that works for other plug-ins, and we'll track that with
a separate bug report.
(-[WebNullPluginView viewDidMoveToWindow]): Removed most of the code;
changed so it just does a performSelector:afterDelay:0.
LayoutTests:
Reviewed by Mitz.
- update tests affected by fix for <rdar://problem/
5530185> WebKit does not show
<object> fallback content when both URL and MIME type is omitted
* dom/html/level2/html/AppletsCollection-expected.txt: The text "Nothing here!" renders now.
* fast/dom/HTMLDocument/object-by-name-unknown-child-element-expected.txt: Some blank
space renders now.
* platform/mac/fast/invalid/residual-style-expected.txt: A font element renders now.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27378
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp [Fri, 2 Nov 2007 21:51:49 +0000 (21:51 +0000)]
Reviewed by Darin.
Include Cairo headers properly
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27377
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Fri, 2 Nov 2007 14:07:04 +0000 (14:07 +0000)]
2007-11-02 Mark Rowe <mrowe@apple.com>
Reviewed by Darin Adler.
Fix http://bugs.webkit.org/show_bug.cgi?id=15780
Bug 15780: WebFrameLoaderClient: WebActionElementKey wrong if view is scrolled
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::actionDictionary): Retrieve the mouse event coordinates
in the page coordinate system rather than the client area coordinate system.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27376
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver [Fri, 2 Nov 2007 06:51:15 +0000 (06:51 +0000)]
Make sure we send the correct events for Capslock, Shift, Ctrl, Alt and the Windows key
WebCore:
Reviewed by Alexey.
Make sure we send the correct events for Capslock, Shift, Ctrl, Alt and the Windows key
* platform/win/KeyEventWin.cpp:
(WebCore::keyIdentifierForWindowsKeyCode):
(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
WebKit/win:
Reviewed by Alexey.
Allow Shift, Ctrl, Alt, Meta and Capslock keys to be sent into WebCore.
* WebView.cpp:
(WebView::keyDown):
(WebView::keyUp):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27375
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz [Fri, 2 Nov 2007 06:27:29 +0000 (06:27 +0000)]
Reviewed by Oliver Hunt.
- fix an assertion failure when Command-Tabbing out of Safari
* WebView/WebHTMLView.mm:
(-[WebHTMLView flagsChanged:]): Avoid passing key code 0 down to
webCore.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27374
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Fri, 2 Nov 2007 00:14:04 +0000 (00:14 +0000)]
JavaScriptCore:
Reviewed by Maciej Stachowiak.
In preparation for making List a simple stack-allocated Vector:
Removed all instances of List copying and/or assignment, and made List
inherit from Noncopyable.
Functions that used to return a List by copy now take List& out
parameters.
Layout tests and JS tests pass.
* kjs/list.cpp:
(KJS::List::slice): Replaced copyTail with a more generic slice
alternative. (JavaScriptCore only calls slice(1), but WebCore calls
slice(2)).
WebCore:
Reviewed by Maciej Stachowiak.
In preparation for making List a simple stack-allocated Vector:
Removed all instances of List copying, assignment, and/or storage.
Layout tests and JS tests pass.
* bindings/js/kjs_window.cpp:
(KJS::WindowFunc::callAsFunction): Stores a Vector of protected
JSValue*'s instead of a List now. Converts to List on the fly when
calling the timer function. This is slightly less efficient, but the
common case is 0-2 arguments, so it's no biggie.
(HTML iBench shows no regression. PLT does not use JS timers.)
(KJS::ScheduledAction::execute): Uses the more efficient and non-copying
List::slice now.
(KJS::ScheduledAction::ScheduledAction): ditto
* bindings/objc/WebScriptObject.mm:
(getListFromNSArray): Takes a List out parameter now, to avoid copying.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27373
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver [Thu, 1 Nov 2007 23:30:25 +0000 (23:30 +0000)]
Correct event behaviour on certain control keys
Reviewed by Geoff
Make sure we send the correct keyDown and keyUp events for the
control keys CapsLock, Shift, Ctrl, Alt, and Meta/Command, and
uses Windows key codes for the event keyCode.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27372
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Thu, 1 Nov 2007 23:10:36 +0000 (23:10 +0000)]
Forgot part of the patch for my last change.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27371
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Thu, 1 Nov 2007 23:00:20 +0000 (23:00 +0000)]
Reviewed by Sam.
* page/inspector/inspector.css: Use the white disclosure triangles
when a parent DOM element is sepected.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27370
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Thu, 1 Nov 2007 22:58:47 +0000 (22:58 +0000)]
WebCore:
Reviewed by Oliver Hunt.
<rdar://problem/
5195056> Huge plain text pastes are slow, time spent in ApplyStyleCommand::doApply
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::doApply): No need to match style when pasting
into a plaintext-only region, since when we build the fragment to insert from
plain text, we don't put any style information on it, so it will automatically
match style with no intervention.
* editing/markup.cpp:
(WebCore::createFragmentFromText): Place paragraphs into clones of the
block being inserted into, instead of default paragraph elements,
so that when inserted content will match the surrounding paragraph style.
This was broken before, but I haven't added a layout test yet because
there currently isn't a way to get only plain text onto the pasteboard
in a layout test.
WebKit:
Reviewed by Oliver Hunt.
<rdar://problem/
5195056> Huge plain text pastes are slow, time spent in ApplyStyleCommand::doApply
No need to match style when pasting plain text, since the fragment we build for plain text
won't have any style information on it.
* WebView/WebHTMLView.mm:
(-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]): There's no
longer a need to know whether this function chosePlaintext.
(-[WebHTMLView _pasteWithPasteboard:allowPlainText:]):
(-[WebHTMLView _documentFragmentFromPasteboard:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27369
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kmccullo [Thu, 1 Nov 2007 22:54:11 +0000 (22:54 +0000)]
- Fixed a build failure
* WebEditorClient.cpp:
(WebEditorClient::textWillBeDeletedInTextField):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27368
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Thu, 1 Nov 2007 22:31:34 +0000 (22:31 +0000)]
Reviewed by Adam Roben.
Add a releaseRef method to COMPtr which matches the behavior
of the method by the same name in PassRefPtr. This is in
preparation of adding autogenerated COM DOM bindings.
* platform/win/COMPtr.h:
(COMPtr::releaseRef):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27367
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz [Thu, 1 Nov 2007 22:28:39 +0000 (22:28 +0000)]
WebCore:
wx impl. for DragController and EventHandler interfaces.
Reviewed by Adam Roben.
* page/wx: Added.
* page/wx/DragControllerWx.cpp: Added.
(WebCore::DragController::isCopyKeyDown):
(WebCore::DragController::dragOperation):
(WebCore::DragController::maxDragImageSize):
* page/wx/EventHandlerWx.cpp: Added.
(WebCore::EventHandler::passMousePressEventToSubframe):
(WebCore::EventHandler::passMouseMoveEventToSubframe):
(WebCore::EventHandler::passMouseReleaseEventToSubframe):
(WebCore::EventHandler::passMousePressEventToScrollbar):
(WebCore::EventHandler::passWidgetMouseDownEventToWidget):
(WebCore::EventHandler::focusDocumentView):
(WebCore::EventHandler::eventActivatedView):
(WebCore::EventHandler::createDraggingClipboard):
LayoutTests:
- fix typo in test name
* fast/repaint/layout-state-only-posiitoned.html: Removed.
* fast/repaint/layout-state-only-positioned.html: Copied from fast/repaint/layout-state-only-posiitoned.html.
* platform/mac/fast/repaint/layout-state-only-posiitoned-expected.checksum: Removed.
* platform/mac/fast/repaint/layout-state-only-posiitoned-expected.png: Removed.
* platform/mac/fast/repaint/layout-state-only-posiitoned-expected.txt: Removed.
* platform/mac/fast/repaint/layout-state-only-positioned-expected.checksum: Copied from platform/mac/fast/repaint/layout-state-only-posiitoned-expected.checksum.
* platform/mac/fast/repaint/layout-state-only-positioned-expected.png: Copied from platform/mac/fast/repaint/layout-state-only-posiitoned-expected.png.
* platform/mac/fast/repaint/layout-state-only-positioned-expected.txt: Copied from platform/mac/fast/repaint/layout-state-only-posiitoned-expected.txt.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27366
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino [Thu, 1 Nov 2007 21:43:43 +0000 (21:43 +0000)]
wx impl. for DragController and EventHandler interfaces.
Reviewed by Adam Roben.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27365
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino [Thu, 1 Nov 2007 21:36:00 +0000 (21:36 +0000)]
Adding files for wx impl. of editing interfaces.
Reviewed by Adam Roben.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27364
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Thu, 1 Nov 2007 21:33:33 +0000 (21:33 +0000)]
Reviewed by Adam Roben.
Make implicit conversions from LPCSTRs and BSTRs to WebCore string
types possible in preparation of adding autogenerated COM DOM bindings.
* platform/AtomicString.cpp:
(WebCore::AtomicString::add):
* platform/AtomicString.h:
(WebCore::AtomicString::AtomicString):
* platform/PlatformString.h:
* platform/win/BString.cpp:
(WebCore::BString::BString):
* platform/win/BString.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27363
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Thu, 1 Nov 2007 21:15:22 +0000 (21:15 +0000)]
Reviewed by Anders
Renamed a flag inside of SQLiteTransaction and added an accessor (for future work)
* platform/sql/SQLiteTransaction.cpp:
(WebCore::SQLiteTransaction::SQLiteTransaction):
(WebCore::SQLiteTransaction::~SQLiteTransaction):
(WebCore::SQLiteTransaction::begin):
(WebCore::SQLiteTransaction::commit):
(WebCore::SQLiteTransaction::rollback):
* platform/sql/SQLiteTransaction.h:
(WebCore::SQLiteTransaction::inProgress):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27362
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Thu, 1 Nov 2007 21:01:18 +0000 (21:01 +0000)]
Remove all duplicate xcopy commands from WebCore's post-build step
Also add the /d option to the copy of platform/sql.
Rubberstamped by Sam.
* WebCore.vcproj/WebCore.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27361
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Thu, 1 Nov 2007 21:00:49 +0000 (21:00 +0000)]
Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
Reviewed by Sam.
* Scripts/commit-log-editor: Show all the directories beneath the
source root, instead of just the last one.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27360
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Thu, 1 Nov 2007 20:50:28 +0000 (20:50 +0000)]
JavaScriptCore:
Reviewed by Maciej Stachowiak.
Fixed http://bugs.webkit.org/show_bug.cgi?id=15785
REGRESSION(r27344): Crash on load at finance.yahoo.com
Reverted a small portion of my last check-in. (The speedup and the List
removal are still there, though.)
ActivationImp needs to hold a pointer to its function, and mark that
pointer (rather than accessing its function through its ExecState, and
counting on the active scope to mark its function) because a closure
can cause an ActivationImp to outlive its ExecState along with any
active scope.
* kjs/ExecState.cpp:
(KJS::ExecState::ExecState):
* kjs/function.cpp:
(KJS::FunctionImp::~FunctionImp):
(KJS::ActivationImp::ActivationImp):
* kjs/function.h:
(KJS::ActivationImp::ActivationImpPrivate::ActivationImpPrivate):
Also made HashTable a little more crash-happy in debug builds, so
problems like this will show up earlier:
* wtf/HashTable.h:
(WTF::HashTable::~HashTable):
LayoutTests:
Reviewed by Maciej Stachowiak.
Layout test for http://bugs.webkit.org/show_bug.cgi?id=15785
REGRESSION(r27344): Crash on load at finance.yahoo.com
* fast/js/activation-object-function-lifetime-expected.txt: Added.
* fast/js/activation-object-function-lifetime.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27359
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Thu, 1 Nov 2007 20:35:09 +0000 (20:35 +0000)]
Rubber-stamped by Tim Hatcher.
* misc/DatabaseExample.html: Speed up default close speed to .25s
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27358
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Thu, 1 Nov 2007 20:28:25 +0000 (20:28 +0000)]
Reviewed by Adam Roben.
- Don't show the close button on the notes unless hovering over the note.
- Do transformation and fade when closing a note using the new transition properties.
* misc/DatabaseExample.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27357
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Thu, 1 Nov 2007 20:23:48 +0000 (20:23 +0000)]
Fix the parameter type of WebLocalizedString to match the UI_STRING macro
Reviewed by Sam.
* WebLocalizableStrings.cpp:
(WebLocalizedString):
(WebLocalizedLPCTSTR):
* WebLocalizableStrings.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27356
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Thu, 1 Nov 2007 19:01:09 +0000 (19:01 +0000)]
Reviewed by Maciej.
Add support for the animation of the -webkit-border-raduis properties.
* page/AnimationController.cpp:
(WebCore::blendFunc): Added for IntSize.
(WebCore::ImplicitAnimation::animate): Added cases for border radius properties.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27355
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp [Thu, 1 Nov 2007 18:37:36 +0000 (18:37 +0000)]
2007-11-01 Alp Toker <alp@atoker.com>
Reviewed by Mitz Pettel.
Fix an unbalanced save/restore.
* platform/graphics/cg/ImageCG.cpp:
(WebCore::BitmapImage::draw):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27354
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Thu, 1 Nov 2007 18:28:58 +0000 (18:28 +0000)]
Add support for the animation of the visibility property.
Reviewed by oliver, aroben
* page/AnimationController.cpp:
(WebCore::blendFunc):
(WebCore::ImplicitAnimation::animate):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27353
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kmccullo [Thu, 1 Nov 2007 17:13:59 +0000 (17:13 +0000)]
Reviewed by Adam.
- Made COMPtr be able to be used by certain other templates,
specifically HashSet.
* platform/win/COMPtr.h:
(WTF::):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27352
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz [Thu, 1 Nov 2007 15:30:23 +0000 (15:30 +0000)]
WebCore:
Reviewed by Dave Hyatt.
- fix http://bugs.webkit.org/show_bug.cgi?id=15015
<rdar://problem/
5420308> Most of www.aol.com redraws unnecessarily when headline/photo section changes
Test: fast/repaint/overflow-clip-subtree-layout.html
This patch does not address the bigger issue of doing a full relayout
of inline flows containing floats, but it addresses the problem on
aol.com, where the changes that trigger layout are confined to an
overflow area inside the float.
* page/FrameView.cpp:
(WebCore::FrameView::scheduleRelayoutOfSubtree): If the new and old
layout roots are different but one descends from the other, make (or
keep) the ancestor as the layout root.
* rendering/RenderObject.cpp:
(WebCore::objectIsRelayoutBoundary): Made boxes with overflow
clipping and non-auto width and height relayout boundaries.
LayoutTests:
Reviewed by Dave Hyatt.
- repaint test for http://bugs.webkit.org/show_bug.cgi?id=15015
<rdar://problem/
5420308> Most of www.aol.com redraws unnecessarily when headline/photo section changes
* fast/repaint/overflow-clip-subtree-layout.html: Added.
* platform/mac/fast/repaint/overflow-clip-subtree-layout-expected.checksum: Added.
* platform/mac/fast/repaint/overflow-clip-subtree-layout-expected.png: Added.
* platform/mac/fast/repaint/overflow-clip-subtree-layout-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27351
268f45cc-cd09-0410-ab3c-
d52691b4dbfc