WebKit-https.git
10 years agoFiled more bugs.
rniwa@webkit.org [Wed, 26 Oct 2011 08:52:40 +0000 (08:52 +0000)]
Filed more bugs.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMore Chromium test expectation updates. Filed a bunch of bugs to track real failures
rniwa@webkit.org [Wed, 26 Oct 2011 08:45:09 +0000 (08:45 +0000)]
More Chromium test expectation updates. Filed a bunch of bugs to track real failures
and removed erroneous failing test expectations.

* platform/chromium-cg-mac-leopard/editing/deleting/merge-whitespace-pre-expected.png:
* platform/chromium-mac-leopard/editing/deleting/merge-whitespace-pre-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/deleting/merge-whitespace-pre-expected.png: Added.
* platform/chromium-mac/editing/deleting/merge-whitespace-pre-expected.png: Removed.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt][WK2] Rewrite MiniBrowser in QML
hausmann@webkit.org [Wed, 26 Oct 2011 08:29:48 +0000 (08:29 +0000)]
[Qt][WK2] Rewrite MiniBrowser in QML
https://bugs.webkit.org/show_bug.cgi?id=70315

Add the first QML based implementation of MiniBrowser.

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com>,
         Zeno Albisser <zeno.albisser@nokia.com>

Source/WebKit2:

Patch by Zeno Albisser <zeno.albisser@nokia.com> on 2011-10-26
Reviewed by Tor Arne Vestbø.

* UIProcess/API/qt/qdesktopwebview.cpp:
(QDesktopWebView::mousePressEvent):

 2011-10-20  Zeno Albisser  <zeno.albisser@nokia.com>

[Qt][WK2] Disable Context Menus until we have a proper QML implementation
https://bugs.webkit.org/show_bug.cgi?id=70537

This is just a temporary fix to avoid crashes in QtGui based
MiniBrowser that does not link to QtWidgets.

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com>,
         Zeno Albisser <zeno.albisser@nokia.com>

Reviewed by Simon Hausmann.

* UIProcess/qt/WebContextMenuProxyQt.cpp:
(WebKit::WebContextMenuProxyQt::showContextMenu):
(WebKit::WebContextMenuProxyQt::createContextMenu):

Tools:

Patch by Zeno Albisser <zeno.albisser@nokia.com> on 2011-10-25
Reviewed by Tor Arne Vestbø.

* MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::BrowserWindow):
(BrowserWindow::webView):
(BrowserWindow::load):
(BrowserWindow::keyPressEvent):
(BrowserWindow::~BrowserWindow):
* MiniBrowser/qt/BrowserWindow.h:
* MiniBrowser/qt/MiniBrowser.pro:
* MiniBrowser/qt/MiniBrowser.qrc:
* MiniBrowser/qt/MiniBrowserApplication.cpp:
(MiniBrowserApplication::MiniBrowserApplication):
(MiniBrowserApplication::handleUserOptions):
* MiniBrowser/qt/MiniBrowserApplication.h:
(WindowOptions::WindowOptions):
* MiniBrowser/qt/UrlLoader.cpp:
(UrlLoader::UrlLoader):
* MiniBrowser/qt/icons/next.png: Added.
* MiniBrowser/qt/icons/previous.png: Added.
* MiniBrowser/qt/icons/refresh.png: Added.
* MiniBrowser/qt/icons/stop.png: Added.
* MiniBrowser/qt/main.cpp:
(main):
* MiniBrowser/qt/qml/BrowserWindow.qml: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago 2011-10-20 Zeno Albisser <zeno.albisser@nokia.com>
hausmann@webkit.org [Wed, 26 Oct 2011 08:29:16 +0000 (08:29 +0000)]
 2011-10-20  Zeno Albisser  <zeno.albisser@nokia.com>

[Qt][WK2] Disable Context Menus until we have a proper QML implementation
https://bugs.webkit.org/show_bug.cgi?id=70537

This is just a temporary fix to avoid crashes in QtGui based
MiniBrowser that does not link to QtWidgets.

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com>,
         Zeno Albisser <zeno.albisser@nokia.com>

Reviewed by Simon Hausmann.

* UIProcess/qt/WebContextMenuProxyQt.cpp:
(WebKit::WebContextMenuProxyQt::showContextMenu):
(WebKit::WebContextMenuProxyQt::createContextMenu):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt][WK2] Remove QtWidgets dependency in MiniBrowser
hausmann@webkit.org [Wed, 26 Oct 2011 08:29:00 +0000 (08:29 +0000)]
[Qt][WK2] Remove QtWidgets dependency in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=70529

Remove obsolete code for a new QML based implementation
of MiniBrowser.
Change BrowserWindow to derive from QSGView instead of
QMainWindow. QSGView is used as a top level window that
provides the container for placing QML content.
Make MiniBrowserApplication derive from QGuiApplication
instead of QApplication.

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com>,
         Zeno Albisser <zeno.albisser@nokia.com>

Patch by Zeno Albisser <zeno.albisser@nokia.com> on 2011-10-25
Reviewed by Simon Hausmann.

* MiniBrowser/qt/BrowserView.cpp: Removed.
* MiniBrowser/qt/BrowserView.h: Removed.
* MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::BrowserWindow):
(BrowserWindow::load):
(BrowserWindow::screenshot):
(BrowserWindow::loadURLListFromFile):
(BrowserWindow::updateUserAgentList):
(BrowserWindow::~BrowserWindow):
* MiniBrowser/qt/BrowserWindow.h:
* MiniBrowser/qt/MiniBrowser.pro:
* MiniBrowser/qt/MiniBrowserApplication.cpp:
(MiniBrowserApplication::MiniBrowserApplication):
(MiniBrowserApplication::notify):
* MiniBrowser/qt/MiniBrowserApplication.h:
* MiniBrowser/qt/UrlLoader.cpp:
(UrlLoader::UrlLoader):
* MiniBrowser/qt/main.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt][WK2] Remove QAction from MiniBrowser
hausmann@webkit.org [Wed, 26 Oct 2011 08:28:30 +0000 (08:28 +0000)]
[Qt][WK2] Remove QAction from MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=70525

In order to rewrite MiniBrowser in QML we need a suitable
mechanism for triggering navigation actions.
Due to the QtWidgets dependency of QAction the current
solution is not suitable anymore. Therefore we introduce
invokable methods and export properties in QWebNavigationController.

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com>,
         Zeno Albisser <zeno.albisser@nokia.com>

Patch by Zeno Albisser <zeno.albisser@nokia.com> on 2011-10-25
Reviewed by Simon Hausmann.

Source/WebKit2:

* UIProcess/API/qt/WKView.h:
* UIProcess/API/qt/qdesktopwebview.h:
* UIProcess/API/qt/qtouchwebpage.h:
* UIProcess/API/qt/qwebkittypes.h: Removed.
* UIProcess/API/qt/qwebnavigationcontroller.cpp:
(QWebNavigationController::QWebNavigationController):
(QWebNavigationController::canGoBack):
(QWebNavigationController::canGoForward):
(QWebNavigationController::canStop):
(QWebNavigationController::canReload):
(QWebNavigationController::goBack):
(QWebNavigationController::goForward):
(QWebNavigationController::stop):
(QWebNavigationController::reload):
* UIProcess/API/qt/qwebnavigationcontroller.h:
* UIProcess/API/qt/tests/commonviewtests/tst_commonviewtests.cpp:
(tst_CommonViewTests::backAndForward):
(tst_CommonViewTests::reload):
(tst_CommonViewTests::stop):
* UIProcess/API/qt/tests/commonviewtests/webviewabstraction.cpp:
(WebViewAbstraction::goBack):
(WebViewAbstraction::goForward):
(WebViewAbstraction::stop):
(WebViewAbstraction::reload):
* UIProcess/API/qt/tests/commonviewtests/webviewabstraction.h:
* UIProcess/API/qt/tests/qdesktopwebview/tst_qdesktopwebview.cpp:
(tst_QDesktopWebView::navigationStatusAtStartup):
(LoadStartedCatcher::onLoadStarted):
(tst_QDesktopWebView::stopEnabledAfterLoadStarted):
* UIProcess/API/qt/tests/qtouchwebview/tst_qtouchwebview.cpp:
(tst_QTouchWebView::navigationStatusAtStartup):
* UIProcess/qt/ClientImpl.cpp:
(dispatchLoadSucceeded):
(dispatchLoadFailed):
(qt_wk_didStartProvisionalLoadForFrame):
(qt_wk_didCommitLoadForFrame):
(qt_wk_didSameDocumentNavigationForFrame):
* UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::canGoBack):
(QtWebPageProxy::goBack):
(QtWebPageProxy::canGoForward):
(QtWebPageProxy::goForward):
(QtWebPageProxy::canStop):
(QtWebPageProxy::stop):
(QtWebPageProxy::canReload):
(QtWebPageProxy::reload):
(QtWebPageProxy::navigationStateChanged):
(QtWebPageProxy::didRelaunchProcess):
(QtWebPageProxy::processDidCrash):
* UIProcess/qt/QtWebPageProxy.h:
* WebKit2API.pri:

Tools:

* MiniBrowser/qt/BrowserView.cpp:
* MiniBrowser/qt/BrowserView.h:
* MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::BrowserWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[EFL] Private function _ewk_view_viewport_attributes_compute takes an internal data...
commit-queue@webkit.org [Wed, 26 Oct 2011 08:27:45 +0000 (08:27 +0000)]
[EFL] Private function _ewk_view_viewport_attributes_compute takes an internal data of ewk_view.
https://bugs.webkit.org/show_bug.cgi?id=66366

Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2011-10-26
Reviewed by Ryosuke Niwa.

Passes to _ewk_view_viewport_attributes_compute an internal data of ewk_view instead of the view object.
Adds to ewk_view_viewport_attributes_get NULL checks to avoid unexpected results since this is API.

* ewk/ewk_view.cpp:
(_ewk_view_viewport_attributes_compute):
(ewk_view_viewport_attributes_get):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r98429.
yurys@chromium.org [Wed, 26 Oct 2011 08:24:51 +0000 (08:24 +0000)]
Unreviewed, rolling out r98429.
http://trac.webkit.org/changeset/98429
https://bugs.webkit.org/show_bug.cgi?id=70881

"webkit_gpu_tests fail in Chromium" (Requested by yurys on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-26

Source/WebCore:

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::initialize):
* platform/graphics/chromium/WebGLLayerChromium.cpp:
(WebCore::WebGLLayerChromium::layerRendererContext):
* platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore::CCHeadsUpDisplay::enabled):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::context):
(WebCore::CCLayerTreeHost::setNeedsAnimate):
(WebCore::CCLayerTreeHost::setNeedsCommitThenRedraw):
(WebCore::CCLayerTreeHost::setNeedsRedraw):
(WebCore::CCLayerTreeHost::composite):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCSettings::CCSettings):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::setThread):
* platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

* public/WebLayerTreeView.h:
* src/WebCompositorImpl.cpp:
(WebKit::WebCompositor::setThread):
* src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::Settings::operator CCSettings):
(WebKit::WebLayerTreeView::composite):
* src/WebLayerTreeViewImpl.cpp:
(WebKit::WebLayerTreeViewImpl::createLayerTreeHostContext3D):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
* tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTest::CCLayerTreeHostTest):
(WTF::CCLayerTreeHostTest::runTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[EFL] Unregister viewport,changed signal in EWebLauncher.
gyuyoung.kim@samsung.com [Wed, 26 Oct 2011 08:13:01 +0000 (08:13 +0000)]
[EFL] Unregister viewport,changed signal in EWebLauncher.
https://bugs.webkit.org/show_bug.cgi?id=70478

Reviewed by Eric Seidel.

'viewport,changed' signal was registered by EWebLauncher in order to test viewport meta tag.
However, it sets wrong layout to some web sites which have viewport meta tag. Because, host pc
doesn't support proper DPI value though viewport is using DPI value to compute layout values.
This signal is for mobile device.

* EWebLauncher/main.c:
(browserCreate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCleanup Chromium test expectation. These tests were erroneously marked as timing...
rniwa@webkit.org [Wed, 26 Oct 2011 08:07:28 +0000 (08:07 +0000)]
Cleanup Chromium test expectation. These tests were erroneously marked as timing out intermittently
even though the Chromium issue 66085 was fixed a long time ago.

Remove failing expectations from these tests except http/tests/xmlhttprequest/xmlhttprequest-test-send-flag.html
which is still timing out intermittently on Chromium Linux. Filed the bug 70878 to track the failure.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove temporary hack needed to ease Chromium/WebKit commit.
commit-queue@webkit.org [Wed, 26 Oct 2011 07:57:50 +0000 (07:57 +0000)]
Remove temporary hack needed to ease Chromium/WebKit commit.
https://bugs.webkit.org/show_bug.cgi?id=70791

Patch by Polina Sokolova <polina@chromium.org> on 2011-10-26
Reviewed by Darin Fisher.

* public/WebDocument.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChromium editing test rebaselines and editing test expectations updates.
rniwa@webkit.org [Wed, 26 Oct 2011 07:57:16 +0000 (07:57 +0000)]
Chromium editing test rebaselines and editing test expectations updates.

* platform/chromium-linux/editing/selection/5354455-2-expected.png:
* platform/chromium-mac-leopard/editing/inserting/12882-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/inserting/12882-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/selection/5354455-2-expected.png: Added.
* platform/chromium-mac/editing/inserting/12882-expected.png: Removed.
* platform/chromium-mac/editing/selection/5354455-2-expected.png: Removed.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCanvas drawImage with SourceIn, DestinationIn, SourceOut, DestinationAtop and Copy...
commit-queue@webkit.org [Wed, 26 Oct 2011 07:52:07 +0000 (07:52 +0000)]
Canvas drawImage with SourceIn, DestinationIn, SourceOut, DestinationAtop and Copy have errors
https://bugs.webkit.org/show_bug.cgi?id=66920

Patch by Ben Wells <benwells@chromium.org> on 2011-10-26
Reviewed by James Robinson.

Source/WebCore:

Test: fast/canvas/canvas-composite-image.html

Use the same method as fills to handle composited drawImage calls that will affect the whole
canvas. To do this code used when doing fills has been factored into seperate functions and
used by drawImage. Some functions used to do these types of operations have also been renamed.

* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::isFullCanvasCompositeMode):
(WebCore::CanvasRenderingContext2D::fill):
(WebCore::CanvasRenderingContext2D::fillRect):
(WebCore::CanvasRenderingContext2D::drawImage):
(WebCore::CanvasRenderingContext2D::calculateCompositingBufferRect):
(WebCore::CanvasRenderingContext2D::createCompositingBuffer):
(WebCore::CanvasRenderingContext2D::compositeBuffer):
(WebCore::CanvasRenderingContext2D::fullCanvasCompositedDrawImage):
(WebCore::CanvasRenderingContext2D::fullCanvasCompositedFill):
* html/canvas/CanvasRenderingContext2D.h:

LayoutTests:

* fast/canvas/canvas-composite-image-expected.txt: Added.
* fast/canvas/canvas-composite-image.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChromium Mac rebaseline, trusting the baseline optimizer.
rniwa@webkit.org [Wed, 26 Oct 2011 07:36:06 +0000 (07:36 +0000)]
Chromium Mac rebaseline, trusting the baseline optimizer.

* platform/chromium-cg-mac-snowleopard/editing/pasteboard/copy-standalone-image-expected.txt: Added.
* platform/chromium-cg-mac/editing/pasteboard/copy-standalone-image-expected.txt: Removed.
* platform/chromium-mac-snowleopard/editing/pasteboard/copy-standalone-image-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/pasteboard/copy-standalone-image-expected.txt: Added.
* platform/chromium-mac/editing/pasteboard/copy-standalone-image-expected.png: Removed.
* platform/chromium-mac/editing/pasteboard/copy-standalone-image-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAnother GTK build fix attempt after r98413 and r98416.
rniwa@webkit.org [Wed, 26 Oct 2011 07:07:56 +0000 (07:07 +0000)]
Another GTK build fix attempt after r98413 and r98416.

* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::paint):
(WebKit::PluginProxy::geometryDidChange):
(WebKit::PluginProxy::update):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoC/C++ needs ; after each statement.
rniwa@webkit.org [Wed, 26 Oct 2011 06:57:58 +0000 (06:57 +0000)]
C/C++ needs ; after each statement.

* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::geometryDidChange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMac, Qt, and Windows rebaseline r98407.
rniwa@webkit.org [Wed, 26 Oct 2011 06:56:02 +0000 (06:56 +0000)]
Mac, Qt, and Windows rebaseline r98407.

* platform/mac/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/win/fast/dom/Window/window-property-descriptors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoGTK build fix attempt after r98413 and r98416.
rniwa@webkit.org [Wed, 26 Oct 2011 06:47:12 +0000 (06:47 +0000)]
GTK build fix attempt after r98413 and r98416.

* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::paint):
(WebKit::PluginControllerProxy::geometryDidChange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r98379.
commit-queue@webkit.org [Wed, 26 Oct 2011 06:46:35 +0000 (06:46 +0000)]
Unreviewed, rolling out r98379.
http://trac.webkit.org/changeset/98379
https://bugs.webkit.org/show_bug.cgi?id=70875

Did not pass on JSC ports (Requested by abarth on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-25

Source/WebCore:

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateArgumentsCountCheck):
(GenerateImplementation):
* html/canvas/CanvasRenderingContext2D.idl:
* page/DOMWindow.idl:

LayoutTests:

* fast/canvas/canvas-putImageData-expected.txt:
* fast/canvas/canvas-putImageData.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r98346.
commit-queue@webkit.org [Wed, 26 Oct 2011 06:25:39 +0000 (06:25 +0000)]
Unreviewed, rolling out r98346.
http://trac.webkit.org/changeset/98346
https://bugs.webkit.org/show_bug.cgi?id=70874

Breaks JSC-based bots. (Requested by pfeldman on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-25

Source/WebCore:

* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):

LayoutTests:

* inspector/debugger/error-in-watch-expressions.html:
* inspector/debugger/watch-expressions-panel-switch-expected.txt: Removed.
* inspector/debugger/watch-expressions-panel-switch.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFlaky Test: editing/pasteboard/copy-standalone-image.html
rniwa@webkit.org [Wed, 26 Oct 2011 06:20:40 +0000 (06:20 +0000)]
Flaky Test: editing/pasteboard/copy-standalone-image.html
https://bugs.webkit.org/show_bug.cgi?id=61813

Reviewed by Adam Barth.

The flakiness was caused by the fact test didn't wait until iframe finish loading.

HTML5 section 4.8.2. the iframe element (http://www.whatwg.org/specs/web-apps/current-work/#the-iframe-element):
    When there is an active parser in the iframe, and when anything in the iframe is delaying the load event
    of the iframe's browsing context's active document, the iframe must delay the load event of its document.

Since an image doesn't require an active parser, it does not delay the load event of the document.

* editing/pasteboard/copy-standalone-image.html:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSplit DFGJITCodeGenerator::callOperation methods
barraclough@apple.com [Wed, 26 Oct 2011 05:55:27 +0000 (05:55 +0000)]
Split DFGJITCodeGenerator::callOperation methods
https://bugs.webkit.org/show_bug.cgi?id=70870

Reviewed by Filip Pizlo.

The DFGJITCodeGenerator currently contains two sets of callOperation methods.
One set works with the JSVALUE64 value representation and passes arguments in
registers (suitable for use on x86-64), and one set works with the JSVALUE32_64
value representation and passes arguments in memory  (suitable for use on x86).
By refactoring out the representation and calling convention specific aspects
of the code we can also configure the DFG JIT to operator on platforms that use
the JSVALUE32_64 value representation but pass arguments in registers.

On platforms supported by the JIT, the payload precedes the tag of a value in
argument/result ordering, as such, in order to make the setupResults method
generally applicable to return the results of a function that are returned in
two registers, the ordering of arguments to this function has been reversed -
as is the ordering of augments passed to setupArguments methods, with respect
to the ordering with which they are passed in to callOperation.
This inconsistency will be resolved in a later change when we combine the pairs
of arguments passed into callOperation, such that the function signatures can
be made consistent across the two value representations (the callOperation
methods will be passed a reference to a struct representing the JSValue
temporary, this will consist of two gprs on 32_64 and one on 64).

* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::resetCallArguments):
(JSC::DFG::addCallArgument):
    - moved, removed tag,payload version of this method.
(JSC::DFG::setupArguments):
(JSC::DFG::setupArgumentsExecState):
(JSC::DFG::setupArgumentsWithExecState):
    - Calling convention specific portion of callOperation refactored out into these methods.
(JSC::DFG::callOperation):
    - updated these methods to use setupArguments* methods.
(JSC::DFG::setupResults):
    - setupResults is now passed payload,tag.
(JSC::DFG::appendCallWithExceptionCheckSetResult):
    - Added fpr versions of this function.
(JSC::DFG::appendCallSetResult):
    - Added versions of this function without exception check.
* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::emitCall):
    - setupResults is now passed payload,tag.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDisable editing/selection/move-by-word-visually-inline-block-positioned-element.html...
xji@chromium.org [Wed, 26 Oct 2011 05:17:48 +0000 (05:17 +0000)]
Disable editing/selection/move-by-word-visually-inline-block-positioned-element.html in QT after r98428.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Enable threaded compositing via CCThreadProxy::hasThread only
nduca@chromium.org [Wed, 26 Oct 2011 05:02:41 +0000 (05:02 +0000)]
[chromium] Enable threaded compositing via CCThreadProxy::hasThread only
https://bugs.webkit.org/show_bug.cgi?id=70838

Reviewed by James Robinson.

Source/WebCore:

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::initialize):
* platform/graphics/chromium/WebGLLayerChromium.cpp:
(WebCore::WebGLLayerChromium::layerRendererContext):
* platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore::CCHeadsUpDisplay::enabled):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::context):
(WebCore::CCLayerTreeHost::setNeedsAnimate):
(WebCore::CCLayerTreeHost::setNeedsCommitThenRedraw):
(WebCore::CCLayerTreeHost::setNeedsRedraw):
(WebCore::CCLayerTreeHost::composite):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCSettings::CCSettings):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::hasThread):
* platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

* public/WebLayerTreeView.h:
* src/WebCompositorImpl.cpp:
* src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::Settings::operator CCSettings):
(WebKit::WebLayerTreeView::composite):
* src/WebLayerTreeViewImpl.cpp:
(WebKit::WebLayerTreeViewImpl::createLayerTreeHostContext3D):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago--webkit-visual-word does not work in multi-line
xji@chromium.org [Wed, 26 Oct 2011 04:57:39 +0000 (04:57 +0000)]
--webkit-visual-word does not work in multi-line
https://bugs.webkit.org/show_bug.cgi?id=61344

Reviewed by Ryosuke Niwa.

Source/WebCore:

Get next or previous root inline box (which is not in the same
render object as the current root inline box) by traversing DOM node.

Test: editing/selection/move-by-word-visually-inline-block-positioned-element.html

* editing/visible_units.cpp:
(WebCore::previousRootInlineBox):
(WebCore::nextRootInlineBox):
(WebCore::leftInlineBox):
(WebCore::rightInlineBox):

LayoutTests:

* editing/selection/move-by-word-visually-inline-block-positioned-element-expected.txt: Added.
* editing/selection/move-by-word-visually-inline-block-positioned-element.html: Added.
* editing/selection/move-by-word-visually-multi-line-expected.txt:
* editing/selection/move-by-word-visually-single-space-one-element-expected.txt:
* editing/selection/move-by-word-visually-single-space-one-element.html:
* platform/gtk/editing/selection/move-by-word-visually-multi-line-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoJSEventTarget.cpp has a bunch of unnessary includes
abarth@webkit.org [Wed, 26 Oct 2011 03:06:58 +0000 (03:06 +0000)]
JSEventTarget.cpp has a bunch of unnessary includes
https://bugs.webkit.org/show_bug.cgi?id=70865

Reviewed by Eric Seidel.

In the process of removing these includes, I noticed we had a bunch of
non-autogenerated code in this file, which I've now autogenerated.

* bindings/js/JSEventTarget.cpp:
(WebCore::toEventTarget):
    - One subtly here is the outter static_cast, which is caused by an
      inheritance infelicity in JavaScriptAudioNode, which I've noted
      with a FIXME.  In any case, the extra static_cast shouldn't cause
      any trouble.
* webaudio/JavaScriptAudioNode.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoV8DOMWrapper.cpp has unneeded header includes
abarth@webkit.org [Wed, 26 Oct 2011 02:14:53 +0000 (02:14 +0000)]
V8DOMWrapper.cpp has unneeded header includes
https://bugs.webkit.org/show_bug.cgi?id=70863

Reviewed by Eric Seidel.

* bindings/v8/V8DOMWrapper.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix ad hoc test.
arv@chromium.org [Wed, 26 Oct 2011 02:12:22 +0000 (02:12 +0000)]
Fix ad hoc test.

unreviewed.

* fast/canvas/webgl/gl-teximage.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix occurrence of unpainted tiles while scrolling and zooming.
commit-queue@webkit.org [Wed, 26 Oct 2011 02:11:33 +0000 (02:11 +0000)]
Fix occurrence of unpainted tiles while scrolling and zooming.
https://bugs.webkit.org/show_bug.cgi?id=70711

Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2011-10-25
Reviewed by Adam Barth.

Cast one of operatees to float type when ewk_tiled_backing_store calculate tiles list on viewport.
For the proper calculation to generate a float number, at least one of operatees must be a float type.
But, currently both two operatees to calculate the number of tiles on viewport routine aren't float type,
so it generates smaller result than expected result when it is using ceil API.
As a result, it can lose a line of tiles which should be displayed in viewport area while scrolling and zooming.

* ewk/ewk_tiled_backing_store.cpp:
(_ewk_tiled_backing_store_recalc_renderers):
(ewk_tiled_backing_store_zoom_weak_set):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoResetting baseline for test bindings
mhahnenberg@apple.com [Wed, 26 Oct 2011 01:59:37 +0000 (01:59 +0000)]
Resetting baseline for test bindings

Unreviewed preemptive build fix

No new tests.

* bindings/scripts/test/JS/JSTestObj.cpp:
* bindings/scripts/test/JS/JSTestObj.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove deletePropertyVirtual
mhahnenberg@apple.com [Wed, 26 Oct 2011 01:49:00 +0000 (01:49 +0000)]
Remove deletePropertyVirtual
https://bugs.webkit.org/show_bug.cgi?id=70738

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Removed all declarations and definitions of deletePropertyVirtual.
Also replaced all call sites to deletePropertyVirtual with a
corresponding lookup in the MethodTable.

* API/JSCallbackObject.h:
* API/JSCallbackObjectFunctions.h:
(JSC::::deletePropertyByIndex):
* API/JSObjectRef.cpp:
(JSObjectDeleteProperty):
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::deleteProperty):
* debugger/DebuggerActivation.h:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/Arguments.cpp:
* runtime/Arguments.h:
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncPop):
(JSC::arrayProtoFuncReverse):
(JSC::arrayProtoFuncShift):
(JSC::arrayProtoFuncSplice):
(JSC::arrayProtoFuncUnShift):
* runtime/JSActivation.cpp:
* runtime/JSActivation.h:
* runtime/JSArray.cpp:
(JSC::JSArray::deleteProperty):
(JSC::JSArray::deletePropertyByIndex):
* runtime/JSArray.h:
* runtime/JSCell.cpp:
(JSC::JSCell::deleteProperty):
(JSC::JSCell::deletePropertyByIndex):
* runtime/JSCell.h:
* runtime/JSFunction.cpp:
* runtime/JSFunction.h:
* runtime/JSNotAnObject.cpp:
* runtime/JSNotAnObject.h:
* runtime/JSONObject.cpp:
(JSC::Walker::walk):
* runtime/JSObject.cpp:
(JSC::JSObject::deletePropertyByIndex):
(JSC::JSObject::defineOwnProperty):
* runtime/JSObject.h:
* runtime/JSVariableObject.cpp:
* runtime/JSVariableObject.h:
* runtime/RegExpMatchesArray.h:
* runtime/StrictEvalActivation.cpp:
* runtime/StrictEvalActivation.h:
* runtime/StringObject.cpp:
* runtime/StringObject.h:

Source/WebCore:

No new tests.

Removed all declarations and definitions of deletePropertyVirtual.
Also replaced all call sites to deletePropertyVirtual with a
corresponding lookup in the MethodTable.

* WebCore.exp.in:
* bindings/js/JSDOMStringMapCustom.cpp:
(WebCore::JSDOMStringMap::deleteProperty):
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::deleteProperty):
* bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::deleteProperty):
* bindings/js/JSDOMWindowShell.h:
* bindings/js/JSHistoryCustom.cpp:
(WebCore::JSHistory::deleteProperty):
* bindings/js/JSLocationCustom.cpp:
(WebCore::JSLocation::deleteProperty):
* bindings/js/JSStorageCustom.cpp:
(WebCore::JSStorage::deleteProperty):
* bindings/js/ScriptObject.cpp:
(WebCore::ScriptGlobalObject::remove):
* bindings/objc/WebScriptObject.mm:
(-[WebScriptObject removeWebScriptKey:]):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
* bridge/NP_jsobject.cpp:
(_NPN_RemoveProperty):
* bridge/jni/jni_jsobject.mm:
(JavaJSObject::removeMember):
* bridge/objc/objc_runtime.h:
* bridge/objc/objc_runtime.mm:
* bridge/runtime_array.cpp:
* bridge/runtime_array.h:
* bridge/runtime_object.cpp:
* bridge/runtime_object.h:

Source/WebKit/mac:

Removed all declarations and definitions of deletePropertyVirtual.
Also replaced all call sites to deletePropertyVirtual with a
corresponding lookup in the MethodTable.

* Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::removeProperty):

Source/WebKit2:

Removed all declarations and definitions of deletePropertyVirtual.
Also replaced all call sites to deletePropertyVirtual with a
corresponding lookup in the MethodTable.

* WebProcess/Plugins/Netscape/JSNPObject.cpp:
* WebProcess/Plugins/Netscape/JSNPObject.h:
* WebProcess/Plugins/Netscape/NPJSObject.cpp:
(WebKit::NPJSObject::removeProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAX: WebKit does not expose HTML label for slider elements
cfleizach@apple.com [Wed, 26 Oct 2011 01:45:40 +0000 (01:45 +0000)]
AX: WebKit does not expose HTML label for slider elements
https://bugs.webkit.org/show_bug.cgi?id=70856

Reviewed by Darin Adler.

Source/WebCore:

Test: platform/mac/accessibility/slider-allows-title-ui-element.html

* accessibility/AccessibilitySlider.h:
(WebCore::AccessibilitySlider::isControl):
* accessibility/mac/WebAccessibilityObjectWrapper.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):

LayoutTests:

* platform/mac/accessibility/slider-allows-title-ui-element-expected.txt: Added.
* platform/mac/accessibility/slider-allows-title-ui-element.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed gardening.
jchaffraix@webkit.org [Wed, 26 Oct 2011 01:38:31 +0000 (01:38 +0000)]
Unreviewed gardening.

* platform/chromium/test_expectations.txt:
fast/forms/form-associated-element-crash3.html has
been timing out very regularly on linux debug.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[EFL] Move assignment of some variables out of loop for ewk_tiled_backing_store.
commit-queue@webkit.org [Wed, 26 Oct 2011 01:15:22 +0000 (01:15 +0000)]
[EFL] Move assignment of some variables out of loop for ewk_tiled_backing_store.
https://bugs.webkit.org/show_bug.cgi?id=67588

Some of variables which aren't related with loop count or other variables
inside of loop are moved out of loop.

Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2011-10-25
Reviewed by Adam Barth.

* ewk/ewk_tiled_backing_store.cpp:
(_ewk_tiled_backing_store_view_wrap_up):
(_ewk_tiled_backing_store_view_wrap_down):
(_ewk_tiled_backing_store_view_wrap_left):
(_ewk_tiled_backing_store_view_wrap_right):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[WinCairo] Unreviewed build fix after r97587.
bfulgham@webkit.org [Wed, 26 Oct 2011 01:13:52 +0000 (01:13 +0000)]
[WinCairo] Unreviewed build fix after r97587.

* win/WebKit2CFLite.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Fix expectation.
arv@chromium.org [Wed, 26 Oct 2011 01:01:46 +0000 (01:01 +0000)]
[Chromium] Fix expectation.

unreviewed.

* platform/chromium/fast/js/kde/garbage-n-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCG plug-ins are always given a context with a scale factor of 1, even when the device...
andersca@apple.com [Wed, 26 Oct 2011 01:00:14 +0000 (01:00 +0000)]
CG plug-ins are always given a context with a scale factor of 1, even when the device scale factor is something else
https://bugs.webkit.org/show_bug.cgi?id=67227
<rdar://problem/10048319>

Reviewed by Sam Weinig.

* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::paint):
Apply the scale factor when painting.

* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::paint):
Apply the scale factor when painting.

(WebKit::PluginProxy::geometryDidChange):
Make sure to apply the contents scale factor to the backing store size.

(WebKit::PluginProxy::update):
Apply the scale factor (when painting).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove putVirtual
mhahnenberg@apple.com [Wed, 26 Oct 2011 00:56:55 +0000 (00:56 +0000)]
Remove putVirtual
https://bugs.webkit.org/show_bug.cgi?id=70740

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Removed all declarations and definitions of putVirtual.
Also replaced all call sites to putVirtual with a
corresponding lookup in the MethodTable.

* API/JSCallbackObject.h:
* API/JSCallbackObjectFunctions.h:
* API/JSObjectRef.cpp:
(JSObjectSetProperty):
(JSObjectSetPropertyAtIndex):
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::put):
* debugger/DebuggerActivation.h:
* dfg/DFGOperations.cpp:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
(JSC::Interpreter::privateExecute):
* jsc.cpp:
(GlobalObject::finishCreation):
* runtime/Arguments.cpp:
* runtime/Arguments.h:
* runtime/ArrayPrototype.cpp:
(JSC::putProperty):
(JSC::arrayProtoFuncConcat):
(JSC::arrayProtoFuncPush):
(JSC::arrayProtoFuncReverse):
(JSC::arrayProtoFuncShift):
(JSC::arrayProtoFuncSlice):
(JSC::arrayProtoFuncSort):
(JSC::arrayProtoFuncSplice):
(JSC::arrayProtoFuncUnShift):
(JSC::arrayProtoFuncFilter):
(JSC::arrayProtoFuncMap):
* runtime/JSActivation.cpp:
* runtime/JSActivation.h:
* runtime/JSArray.cpp:
(JSC::JSArray::putSlowCase):
(JSC::JSArray::push):
(JSC::JSArray::shiftCount):
(JSC::JSArray::unshiftCount):
* runtime/JSArray.h:
* runtime/JSByteArray.cpp:
* runtime/JSByteArray.h:
* runtime/JSCell.cpp:
(JSC::JSCell::put):
(JSC::JSCell::putByIndex):
* runtime/JSCell.h:
* runtime/JSFunction.cpp:
* runtime/JSFunction.h:
* runtime/JSGlobalObject.cpp:
* runtime/JSGlobalObject.h:
* runtime/JSNotAnObject.cpp:
* runtime/JSNotAnObject.h:
* runtime/JSONObject.cpp:
(JSC::Walker::walk):
* runtime/JSObject.cpp:
(JSC::JSObject::putByIndex):
(JSC::JSObject::defineOwnProperty):
* runtime/JSObject.h:
(JSC::JSValue::put):
* runtime/JSStaticScopeObject.cpp:
* runtime/JSStaticScopeObject.h:
* runtime/ObjectPrototype.cpp:
* runtime/ObjectPrototype.h:
* runtime/RegExpConstructor.cpp:
* runtime/RegExpConstructor.h:
* runtime/RegExpMatchesArray.h:
* runtime/RegExpObject.cpp:
* runtime/RegExpObject.h:
* runtime/StringObject.cpp:
* runtime/StringObject.h:
* runtime/StringPrototype.cpp:
(JSC::stringProtoFuncSplit):

Source/JavaScriptGlue:

Removed all declarations and definitions of putVirtual.
Also replaced all call sites to putVirtual with a
corresponding lookup in the MethodTable.

* JSValueWrapper.cpp:
(JSValueWrapper::JSObjectSetProperty):
* UserObjectImp.cpp:
* UserObjectImp.h:

Source/WebCore:

No new tests.

Removed all declarations and definitions of putVirtual.
Also replaced all call sites to putVirtual with a
corresponding lookup in the MethodTable.

* WebCore.exp.in:
* bindings/js/JSDOMWindowCustom.cpp:
* bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::put):
* bindings/js/JSDOMWindowShell.h:
* bindings/js/JSPluginElementFunctions.cpp:
(WebCore::runtimeObjectCustomPut):
* bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneDeserializer::putProperty):
* bindings/objc/WebScriptObject.mm:
(-[WebScriptObject setValue:forKey:]):
(-[WebScriptObject setWebScriptValueAtIndex:value:]):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
* bridge/NP_jsobject.cpp:
(_NPN_SetProperty):
* bridge/jni/jni_jsobject.mm:
(JavaJSObject::setMember):
(JavaJSObject::setSlot):
* bridge/objc/objc_runtime.h:
* bridge/objc/objc_runtime.mm:
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::convertQVariantToValue):
* bridge/runtime_array.cpp:
* bridge/runtime_array.h:
* bridge/runtime_object.cpp:
* bridge/runtime_object.h:
* bridge/testqtbindings.cpp:
(main):

Source/WebKit/efl:

Removed all declarations and definitions of putVirtual.
Also replaced all call sites to putVirtual with a
corresponding lookup in the MethodTable.

* ewk/ewk_view.cpp:
(ewk_view_js_object_add):

Source/WebKit/mac:

Removed all declarations and definitions of putVirtual.
Also replaced all call sites to putVirtual with a
corresponding lookup in the MethodTable.

* Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::setProperty):

Source/WebKit/qt:

Removed all declarations and definitions of putVirtual.
Also replaced all call sites to putVirtual with a
corresponding lookup in the MethodTable.

* Api/qwebframe.cpp:
(QWebFrame::addToJavaScriptWindowObject):

Source/WebKit2:

Removed all declarations and definitions of putVirtual.
Also replaced all call sites to putVirtual with a
corresponding lookup in the MethodTable.

* WebProcess/Plugins/Netscape/JSNPObject.cpp:
* WebProcess/Plugins/Netscape/JSNPObject.h:
* WebProcess/Plugins/Netscape/NPJSObject.cpp:
(WebKit::NPJSObject::setProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd radar.
andersca@apple.com [Wed, 26 Oct 2011 00:34:58 +0000 (00:34 +0000)]
Add radar.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoPlug-ins have no way to find out when the device scale factor changes
andersca@apple.com [Wed, 26 Oct 2011 00:30:39 +0000 (00:30 +0000)]
Plug-ins have no way to find out when the device scale factor changes
https://bugs.webkit.org/show_bug.cgi?id=67226

Reviewed by Sam Weinig.

Source/WebKit2:

* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::geometryDidChange):
* PluginProcess/PluginControllerProxy.h:
This now takes the contentsScaleFactor and calls contentsScaleFactorChanged on its plug-in
if the scale factor changes.

* PluginProcess/PluginControllerProxy.messages.in:
GeometryDidChange now takes a contents scale factor parameter.

* WebProcess/Plugins/Netscape/NetscapePlugin.h:
* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::NetscapePlugin::contentsScaleFactorChanged):
Implement contentsScaleFactorChanged and call NPP_SetValue with the new scale factor.

* WebProcess/Plugins/PDF/BuiltInPDFView.cpp:
(WebKit::BuiltInPDFView::contentsScaleFactorChanged):
* WebProcess/Plugins/PDF/BuiltInPDFView.h:
Add stub.

* WebProcess/Plugins/Plugin.h:
Add pure virtual contentsScaleFactorChanged member function.

* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::geometryDidChange):
Add geometryDidChange overload that doesn't take any parameters. Make it send over the
new scale factor to the plug-in process.

(WebKit::PluginProxy::contentsScaleFactorChanged):
Call geometryDidChange.

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::setDeviceScaleFactor):
Call Plugin::contentsScaleFactorChanged.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setDeviceScaleFactor):
Call setDeviceScaleFactor on all registered plug-ins.

Tools:

Keep a cached copy of the contents scale and update it when it changes.

* DumpRenderTree/TestNetscapePlugIn/Tests/mac/ContentsScaleFactor.cpp:
(ContentsScaleFactor::ContentsScaleFactor):
(ContentsScaleFactor::cachedContentsScaleFactor):
(ContentsScaleFactor::ScriptableObject::hasProperty):
(ContentsScaleFactor::ScriptableObject::getProperty):
(ContentsScaleFactor::NPP_New):
(ContentsScaleFactor::NPP_SetValue):

LayoutTests:

Update test to check that the scale factor is updated correctly.

* platform/mac-wk2/plugins/contents-scale-factor.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoEventTargetFactory.in is not sorted
abarth@webkit.org [Tue, 25 Oct 2011 23:43:33 +0000 (23:43 +0000)]
EventTargetFactory.in is not sorted
https://bugs.webkit.org/show_bug.cgi?id=70855

Reviewed by Eric Seidel.

PerformanceTests:

Add a microbenchmark for wrapping event target.

* Bindings: Added.
* Bindings/event-target-wrapper.html: Added.
* Parser/resources/runner.js:
(runLoop):
    - Let the user of the harness get a callback when the test is done.

Source/WebCore:

This patch sorts the file.  I was not able to measure a performance
difference using the microbenchmark included with this patch.

* dom/EventTargetFactory.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMade Table tests for Bug 70678 Platform Independent
fsamuel@chromium.org [Tue, 25 Oct 2011 23:42:57 +0000 (23:42 +0000)]
Made Table tests for Bug 70678 Platform Independent
https://bugs.webkit.org/show_bug.cgi?id=70850

Reviewed by Adam Barth.

* fast/table/table-anonymous-cell-bug-expected.png: Added.
* fast/table/table-anonymous-cell-bug-expected.txt:
* fast/table/table-anonymous-cell-bug.html:
* fast/table/table-anonymous-row-bug-expected.png: Added.
* fast/table/table-anonymous-row-bug-expected.txt:
* fast/table/table-anonymous-row-bug.html:
* fast/table/table-anonymous-section-bug-expected.png: Added.
* fast/table/table-anonymous-section-bug-expected.txt:
* fast/table/table-anonymous-section-bug.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAttempt to fix the Windows build. Windows mashes all these files into
abarth@webkit.org [Tue, 25 Oct 2011 23:39:28 +0000 (23:39 +0000)]
Attempt to fix the Windows build.  Windows mashes all these files into
one, which doesn't respect the compilation unit rules of C++.

* bindings/js/JSEventCustom.cpp:
* bindings/js/JSEventTarget.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd WKBrowsingContextLoadDelegateTest test for a failed load
weinig@apple.com [Tue, 25 Oct 2011 23:19:00 +0000 (23:19 +0000)]
Add WKBrowsingContextLoadDelegateTest test for a failed load
https://bugs.webkit.org/show_bug.cgi?id=70859

Reviewed by Anders Carlsson.

* TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
(TEST_F): Add TEST_F(WKBrowsingContextLoadDelegateTest, SimpleLoadFail).

(-[SimpleLoadFailDelegate browsingContextControllerDidFailProvisionalLoad:withError:]):
Test that we are getting the correct NSError code and domain.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMoving to the start of line should not place the caret outside of the table
rniwa@webkit.org [Tue, 25 Oct 2011 23:17:59 +0000 (23:17 +0000)]
Moving to the start of line should not place the caret outside of the table
https://bugs.webkit.org/show_bug.cgi?id=70757

Reviewed by Chang Shu.

Source/WebCore:

The bug was caused by positionAvoidingFirstPositionInTable. Get rid of the function.

Test: editing/selection/table-lineboundary.html

* editing/visible_units.cpp:
(WebCore::startPositionForLine):

LayoutTests:

Added a test to move the caret to lineboundaries in the first and the last table cell.
The caret should remain inside a table cell.

* editing/selection/table-lineboundary-expected.txt: Added.
* editing/selection/table-lineboundary.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoJS Test Harness: Make successfullyParsed optional
arv@chromium.org [Tue, 25 Oct 2011 23:10:43 +0000 (23:10 +0000)]
JS Test Harness: Make successfullyParsed optional
https://bugs.webkit.org/show_bug.cgi?id=70784

Reviewed by Ojan Vafai.

Tools:

* Scripts/make-new-script-test:
(writeTestFile): Update the template for script tests.

LayoutTests:

This makes "successfullyParsed = true" optional in favor of tracking syntax errors
using window.onerror.

* fast/*: Remove successfullyParsed.
* fast/dom/Window/new-window-opener.html: Cleanup.
* fast/dom/Window/resources/window-appendages-cleared-results.html:
* fast/dom/Window/webkitConvertPoint.html: Ditto.
* fast/dom/Window/webkitConvertPointUpdateLayout.html: Ditto.
* fast/js/kde/evil-n.html: This is now a normal test since it is not supposed to fail.
* fast/js/kde/garbage-n-expected.txt:
* fast/js/kde/garbage-n.html: Use shouldHaveHadError instead of js-test-post-n.js
* fast/js/kde/string-1-n.html: Ditto.
* fast/js/kde/string-2-n.html: Ditto.
* fast/js/resources/js-test-post-async.js: Ensure we didn't get an error.
* fast/js/resources/js-test-post-function.js: Ditto.
* fast/js/resources/js-test-post-n.js: Removed.
* fast/js/resources/js-test-pre.js: Added shouldHaveHadError function that can be used to assert that the
                                    error message is what was expected.
                                    Ensure we didn't get an error in finistJSTest.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=70852
bdakin@apple.com [Tue, 25 Oct 2011 23:10:12 +0000 (23:10 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=70852
Setting up a HiDPI base-level GraphicsContext should be more straightforward for
WebKit2

Reviewed by Dan Bernstein.

Source/WebCore:

This patch removes the old cg-only GraphicsContext::setBaseCTM() api, and adds
platform-independent GraphicsContext::applyDeviceScaleFactor().
* WebCore.exp.in:
* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::platformApplyDeviceScaleFactor):
(WebCore::GraphicsContext::applyDeviceScaleFactor):
* platform/graphics/GraphicsContext.h:
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::platformApplyDeviceScaleFactor):

Since this patch removes GraphicsContext::setBaseCTM(), this code has been
reverted to do what it used to do before that was added; it just calls into
WebCoreSystemInterface directly.
* platform/graphics/cg/ImageCG.cpp:
(WebCore::Image::drawPattern):

Source/WebKit2:

When we need a base-level HiDPI GraphicsContext, call into new GraphicsContext api
GraphicsContext::applyDeviceScaleFactor() rather than manually scaling and
adjusting the base CTM.
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::display):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::snapshotInViewCoordinates):
(WebKit::WebPage::scaledSnapshotInDocumentCoordinates):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSeparate out function linking & exception check data structures.
barraclough@apple.com [Tue, 25 Oct 2011 23:06:13 +0000 (23:06 +0000)]
Separate out function linking & exception check data structures.
https://bugs.webkit.org/show_bug.cgi?id=70858

Reviewed by Oliver Hunt.

This will make it easier to refactor the callOperation methods to spilt the value
representation specific handling from the cpu/calling-convention implementation.

* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::appendCallWithExceptionCheck):
* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::emitCall):
* dfg/DFGJITCodeGenerator64.cpp:
(JSC::DFG::JITCodeGenerator::emitCall):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileBody):
(JSC::DFG::JITCompiler::link):
* dfg/DFGJITCompiler.h:
(JSC::DFG::CallLinkRecord::CallLinkRecord):
(JSC::DFG::CallExceptionRecord::CallExceptionRecord):
(JSC::DFG::JITCompiler::JITCompiler):
(JSC::DFG::JITCompiler::notifyCall):
(JSC::DFG::JITCompiler::appendCall):
(JSC::DFG::JITCompiler::addExceptionCheck):
(JSC::DFG::JITCompiler::addFastExceptionCheck):
* dfg/DFGJITCompiler32_64.cpp:
(JSC::DFG::JITCompiler::compileBody):
(JSC::DFG::JITCompiler::link):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMore gardening.
jchaffraix@webkit.org [Tue, 25 Oct 2011 23:02:53 +0000 (23:02 +0000)]
More gardening.

* platform/chromium/test_expectations.txt: Missed some cases where
video-porter.html times out. Also added zoom-animator-scale-test2.html
that has been timing out for several days.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSource/WebCore: Plug-ins have to use JavaScript to find out the current device scale...
andersca@apple.com [Tue, 25 Oct 2011 23:00:37 +0000 (23:00 +0000)]
Source/WebCore: Plug-ins have to use JavaScript to find out the current device scale factor
https://bugs.webkit.org/show_bug.cgi?id=67225

Reviewed by Darin Adler.

Test: platform/mac-wk2/plugins/contents-scale-factor.html

Add NPNVcontentsScaleFactor, as per https://wiki.mozilla.org/NPAPI:ContentsScaleFactor.

* plugins/npapi.h:

Source/WebKit2: Plug-ins have to use JavaScript to find out the current device scale factor
https://bugs.webkit.org/show_bug.cgi?id=67225
<rdar://problem/10048258>

Reviewed by Darin Adler.

* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::PluginControllerProxy):
Initialize m_contentsScaleFactor.

* PluginProcess/PluginControllerProxy.h:
Add contentsScaleFactor member function and m_contentsScaleFactor member variable.

* PluginProcess/PluginCreationParameters.cpp:
(WebKit::PluginCreationParameters::PluginCreationParameters):
(WebKit::PluginCreationParameters::encode):
(WebKit::PluginCreationParameters::decode):
* PluginProcess/PluginCreationParameters.h:
Add contentsScaleFactor to the creation parameters.

* PluginProcess/mac/PluginControllerProxyMac.mm:
(WebKit::PluginControllerProxy::contentsScaleFactor):
Return the cached m_contentsScaleFactor.

* WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::NPN_GetValue):
Handle getting the scale factor by calling NetscapePlugin::contentsScaleFactor.

* WebProcess/Plugins/Netscape/NetscapePlugin.h:
* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::NetscapePlugin::contentsScaleFactor):
Ask the plug-in controller for the contents scale factor.

* WebProcess/Plugins/PluginController.h:
Add contentsScaleFactor pure virtual member function.

* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::initialize):
Set contentsScaleFactor in the creation parameters.

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::contentsScaleFactor):
Get the device scale factor from the page.

* WebProcess/Plugins/PluginView.h:
Add contentsScaleFactor().

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setDeviceScaleFactor):
Bail if the scale factor didn't change.

Tools: Plug-ins have to use JavaScript to find out the current device scale factor
https://bugs.webkit.org/show_bug.cgi?id=67225
<rdar://problem/10048258>

Reviewed by Darin Adler.

Add a plug-in test for getting the contents scale factor.

* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
* DumpRenderTree/TestNetscapePlugIn/Tests/mac/ContentsScaleFactor.cpp: Added.
(ContentsScaleFactor::ContentsScaleFactor):
(ContentsScaleFactor::contentsScaleFactor):
(ContentsScaleFactor::ScriptableObject::hasProperty):
(ContentsScaleFactor::ScriptableObject::getProperty):
(ContentsScaleFactor::ScriptableObject::pluginTest):
(ContentsScaleFactor::NPP_GetValue):

LayoutTests: Plug-ins have to use JavaScript to find out the current device scale factor
https://bugs.webkit.org/show_bug.cgi?id=67225
<rdar://problem/10048258>

Reviewed by Darin Adler.

Add tests.

* platform/mac-wk2/plugins/contents-scale-factor-expected.txt: Added.
* platform/mac-wk2/plugins/contents-scale-factor.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoForward declare MutationObserverEntry as a struct to fix clang build
adamk@chromium.org [Tue, 25 Oct 2011 22:55:50 +0000 (22:55 +0000)]
Forward declare MutationObserverEntry as a struct to fix clang build
https://bugs.webkit.org/show_bug.cgi?id=70853

Reviewed by Ryosuke Niwa.

Node.h forward declared MutationObserverEntry as a class, and clang
complains if the two declarations don't match.

* dom/Node.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCaret can be positioned or repainted incorrectly in flipped-blocks multi-column blocks
mitz@apple.com [Tue, 25 Oct 2011 22:45:48 +0000 (22:45 +0000)]
Caret can be positioned or repainted incorrectly in flipped-blocks multi-column blocks
https://bugs.webkit.org/show_bug.cgi?id=70851

Reviewed by Dave Hyatt.

* manual-tests/caret-in-columns-flipped.html: Added.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::adjustForColumns): Removed flipped-blocks writing mode considerations
from this function, since not all callers were expecting it to account for flippedness. This makes
it similar to adjustRectForColumns() in not adjusting for flippedness.
* rendering/RenderBox.cpp:
(WebCore::RenderBox::offsetFromContainer): In the columns case, account for flipped-blocks modes
by first mapping the point and the offset to non-flipped, non-columns space, then adjusting for
columns, then flipping.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFlesh out WKBrowsingContextLoadDelegate a bit
weinig@apple.com [Tue, 25 Oct 2011 22:35:52 +0000 (22:35 +0000)]
Flesh out WKBrowsingContextLoadDelegate a bit
https://bugs.webkit.org/show_bug.cgi?id=70846

Source/WebKit2:

Add didReceiveServerRedirectForProvisionalLoad, didFailProvisionalLoad
and didFailLoad.

Reviewed by Anders Carlsson.

Test: WKBrowsingContextLoadDelegateTest

* UIProcess/API/mac/WKBrowsingContextController.mm:
(didReceiveServerRedirectForProvisionalLoadForFrame):
(didFailProvisionalLoadWithErrorForFrame):
(didFailLoadWithErrorForFrame):
(setUpPageLoaderClient):
* UIProcess/API/mac/WKBrowsingContextLoadDelegate.h:

Tools:

Reviewed by Anders Carlsson.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit2ObjC: Added.
* TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm: Added.
(WKBrowsingContextLoadDelegateTest::WKBrowsingContextLoadDelegateTest):
(WKBrowsingContextLoadDelegateTest::SetUp):
(WKBrowsingContextLoadDelegateTest::TearDown):
(-[SimpleLoadDelegate browsingContextControllerDidFinishLoad:]):
(TEST_F):
Add basic testing for WKBrowsingContextLoadDelegate.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTiered compilation may introduce dangling pointers in constant buffers
fpizlo@apple.com [Tue, 25 Oct 2011 21:56:31 +0000 (21:56 +0000)]
Tiered compilation may introduce dangling pointers in constant buffers
https://bugs.webkit.org/show_bug.cgi?id=70854

Reviewed by Oliver Hunt.

Tiered compilation now copies constant buffers, which fixes the regression in
https://bugs.webkit.org/show_bug.cgi?id=70246. No new tests because this
regression relies on a subtle interleaving of optimized compilation and garbage
collection, and cannot be reproduced in a simple test.

This also adds some new debug support, which was used to fix this bug and is
likely to be useful in the future.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::copyDataFrom):
(JSC::CodeBlock::usesOpcode):
* bytecode/CodeBlock.h:
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMore unreviewed gardening.
jchaffraix@webkit.org [Tue, 25 Oct 2011 21:44:05 +0000 (21:44 +0000)]
More unreviewed gardening.

* platform/chromium/test_expectations.txt: Mark another test
as crashing. Moved 2 tests together as they hit the same ASSERT
on the bots.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agomake-script-test-wrappers should not look outside fast/js
ap@apple.com [Tue, 25 Oct 2011 21:16:39 +0000 (21:16 +0000)]
make-script-test-wrappers should not look outside fast/js
https://bugs.webkit.org/show_bug.cgi?id=66357

Reviewed by Maciej Stachowiak.

* Scripts/make-script-test-wrappers: Don't look for template files everywhere, only support
fast/js.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAssertion failure when zooming a PDF in an iframe
andersca@apple.com [Tue, 25 Oct 2011 21:11:00 +0000 (21:11 +0000)]
Assertion failure when zooming a PDF in an iframe
https://bugs.webkit.org/show_bug.cgi?id=70849

Reviewed by Alexey Proskuryakov.

If the plug-in doesn't want window relative coordinates, we shouldn't give the plug-in window relative coordinates.

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::viewGeometryDidChange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix teardown in Web*LayerImpl, and add tests for Web*Layer
commit-queue@webkit.org [Tue, 25 Oct 2011 21:10:12 +0000 (21:10 +0000)]
Fix teardown in Web*LayerImpl, and add tests for Web*Layer
https://bugs.webkit.org/show_bug.cgi?id=70431

Patch by Antoine Labour <piman@chromium.org> on 2011-10-25
Reviewed by James Robinson.

* src/WebContentLayerImpl.cpp:
(WebKit::WebContentLayerImpl::~WebContentLayerImpl):
* src/WebExternalTextureLayerImpl.cpp:
(WebKit::WebExternalTextureLayerImpl::~WebExternalTextureLayerImpl):
* src/WebLayerImpl.cpp:
(WebKit::WebLayerImpl::~WebLayerImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoLayerRendererChromium::setVisible called needlessly without a visibility change
commit-queue@webkit.org [Tue, 25 Oct 2011 20:59:15 +0000 (20:59 +0000)]
LayerRendererChromium::setVisible called needlessly without a visibility change
https://bugs.webkit.org/show_bug.cgi?id=70766

Patch by Michal Mocny <mmocny@google.com> on 2011-10-25
Reviewed by Kenneth Russell.

Check that visibility has actually changed before calling LayerRendererChromium::setVisible

* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::setVisible):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd a --make option to update-webkit to engage the Makefile-based build system
abarth@webkit.org [Tue, 25 Oct 2011 20:54:27 +0000 (20:54 +0000)]
Add a --make option to update-webkit to engage the Makefile-based build system
https://bugs.webkit.org/show_bug.cgi?id=70847

Reviewed by Dimitri Glazkov.

I can never remember what crazy environment variables I'm supposed to
set to tell GYP what to do.

* Scripts/update-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSION(97821): HistoryController::itemsAreClones crashes a lot
andersca@apple.com [Tue, 25 Oct 2011 20:46:14 +0000 (20:46 +0000)]
REGRESSION(97821): HistoryController::itemsAreClones crashes a lot
https://bugs.webkit.org/show_bug.cgi?id=70827
<rdar://problem/10342925>

Reviewed by Adam Barth.

Check that m_currentItem is non-null before passing it to itemsAreClones. While I wasn't
able to make a test case that would reproduce this crash, we do check m_currentItem for null
everywhere else, and the crash log indicates that this would fix the crash.

* loader/HistoryController.cpp:
(WebCore::HistoryController::recursiveUpdateForCommit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoEventTarget.h shouldn't need to know about every feature and ifdef
abarth@webkit.org [Tue, 25 Oct 2011 20:44:03 +0000 (20:44 +0000)]
EventTarget.h shouldn't need to know about every feature and ifdef
https://bugs.webkit.org/show_bug.cgi?id=70659

Reviewed by Darin Adler.

Source/WebCore:

This patch follows the approach of Event.h and introduces an
interfaceName virtual function that returns the name of the DOM
interface for the concrete type of the object.  This function lets us
remove a large number of fake dynamic casts.

* CMakeLists.txt:
* CodeGenerators.pri:
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.gyp/WebCore.gyp:
* WebCore.gyp/scripts/action_makenames.py:
    - Teach action_makenames how to handle the new "in" file.
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSEventTarget.cpp:
(WebCore::toJS):
    - Use the new autogenerated macro to remove a large amount of
      feature-specific code.
* bindings/js/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::initScript):
* bindings/objc/DOM.mm:
(kit):
    - The SVGElementInstance branch was never taken previously because
      SVGElementInstance::toNode returns a non-NULL value. This code
      was introduced in http://trac.webkit.org/changeset/42618 and
      doesn't appear to have ever worked as the author intended.
* bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::convertEventTargetToV8Object):
    - Use the new autogenerated macro to remove a large amount of
      feature-specific code.
* dom/EventNames.cpp:
(WebCore::EventNames::EventNames):
* dom/EventNames.h:
* dom/EventTarget.cpp:
* dom/EventTarget.h:
* dom/EventTargetFactory.in: Added.
    - Add a new "in" file that lists all the EventTargets.
* dom/LocalMediaStream.cpp:
(WebCore::LocalMediaStream::interfaceName):
* dom/LocalMediaStream.h:
* dom/MediaStream.cpp:
(WebCore::MediaStream::interfaceName):
* dom/MediaStream.h:
* dom/MessagePort.cpp:
(WebCore::MessagePort::interfaceName):
* dom/MessagePort.h:
* dom/Node.cpp:
(WebCore::Node::toNode):
(WebCore::Node::interfaceName):
* dom/Node.h:
* dom/make_event_factory.pl:
    - Generalize make_event_factory.pl to be able to generate
      interfaces for different namespaces.
* fileapi/FileReader.cpp:
(WebCore::FileReader::interfaceName):
* fileapi/FileReader.h:
* fileapi/FileWriter.cpp:
(WebCore::FileWriter::interfaceName):
* fileapi/FileWriter.h:
* loader/appcache/DOMApplicationCache.cpp:
(WebCore::DOMApplicationCache::interfaceName):
* loader/appcache/DOMApplicationCache.h:
* notifications/Notification.cpp:
(WebCore::Notification::interfaceName):
* notifications/Notification.h:
(WebCore::Notification::scriptExecutionContext):
* p2p/PeerConnection.cpp:
(WebCore::PeerConnection::interfaceName):
* p2p/PeerConnection.h:
* page/DOMWindow.cpp:
(WebCore::DOMWindow::interfaceName):
(WebCore::DOMWindow::toDOMWindow):
* page/DOMWindow.h:
* page/EventSource.cpp:
(WebCore::EventSource::interfaceName):
* page/EventSource.h:
* storage/IDBDatabase.cpp:
(WebCore::IDBDatabase::interfaceName):
* storage/IDBDatabase.h:
* storage/IDBRequest.cpp:
(WebCore::IDBRequest::interfaceName):
* storage/IDBRequest.h:
* storage/IDBTransaction.cpp:
(WebCore::IDBTransaction::interfaceName):
* storage/IDBTransaction.h:
* storage/IDBVersionChangeRequest.cpp:
(WebCore::IDBVersionChangeRequest::interfaceName):
* storage/IDBVersionChangeRequest.h:
* svg/SVGElementInstance.cpp:
(WebCore::SVGElementInstance::interfaceName):
* svg/SVGElementInstance.h:
(WebCore::SVGElementInstance::toNode):
* webaudio/AudioContext.cpp:
(WebCore::AudioContext::interfaceName):
(WebCore::AudioContext::scriptExecutionContext):
* webaudio/AudioContext.h:
* webaudio/JavaScriptAudioNode.cpp:
(WebCore::JavaScriptAudioNode::interfaceName):
* webaudio/JavaScriptAudioNode.h:
* websockets/WebSocket.cpp:
(WebCore::WebSocket::interfaceName):
* websockets/WebSocket.h:
* workers/DedicatedWorkerContext.cpp:
(WebCore::DedicatedWorkerContext::interfaceName):
* workers/DedicatedWorkerContext.h:
* workers/DefaultSharedWorkerRepository.cpp:
(WebCore::SharedWorkerConnectTask::performTask):
* workers/SharedWorker.cpp:
(WebCore::SharedWorker::interfaceName):
* workers/SharedWorker.h:
* workers/SharedWorkerContext.cpp:
(WebCore::SharedWorkerContext::interfaceName):
* workers/SharedWorkerContext.h:
* workers/Worker.cpp:
(WebCore::Worker::interfaceName):
* workers/Worker.h:
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::interfaceName):
* xml/XMLHttpRequest.h:
* xml/XMLHttpRequestUpload.cpp:
(WebCore::XMLHttpRequestUpload::interfaceName):
* xml/XMLHttpRequestUpload.h:

Source/WebKit/chromium:

This cast isn't needed because dispatchEvent is a virtual function.

* src/WebSharedWorkerImpl.cpp:
(WebKit::WebSharedWorkerImpl::connectTask):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[EFL] DRT: Force layout when sending events.
commit-queue@webkit.org [Tue, 25 Oct 2011 20:42:19 +0000 (20:42 +0000)]
[EFL] DRT: Force layout when sending events.
https://bugs.webkit.org/show_bug.cgi?id=70357

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-10-25
Reviewed by Antonio Gomes.

Some tests such as editing/input/page-up-down-scrolls.html rely on the
scrollbars being properly set up during the onload events.
Document::implicitClose(), however, dispatches the onload events before
calling FrameView::layout(), so these tests usually fail.

We now do the same as the GTK+ and Chromium ports and manually force the
layout when dispatching events.

* DumpRenderTree/efl/EventSender.cpp:
(sendMouseEvent):
(keyDownCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake loadFileURL:restrictToFilesWithin: work, albeit, without the correct
weinig@apple.com [Tue, 25 Oct 2011 20:38:25 +0000 (20:38 +0000)]
Make loadFileURL:restrictToFilesWithin: work, albeit, without the correct
restrictions for now.

Reviewed by Anders Carlsson.

* UIProcess/API/mac/WKBrowsingContextController.mm:
(-[WKBrowsingContextController loadFileURL:restrictToFilesWithin:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix several minor problems in idls.
podivilov@chromium.org [Tue, 25 Oct 2011 20:36:54 +0000 (20:36 +0000)]
Fix several minor problems in idls.
https://bugs.webkit.org/show_bug.cgi?id=70811

Reviewed by Adam Barth.

This patch does not have any effect on generated bindings.

* dom/DataTransferItems.idl:
* page/History.idl:
* storage/IDBIndex.idl:
* xml/XMLHttpRequest.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] WebGraphicsContext3D setVisibilityCHROMIUM extension changed to pure virtual.
commit-queue@webkit.org [Tue, 25 Oct 2011 20:30:24 +0000 (20:30 +0000)]
[chromium] WebGraphicsContext3D setVisibilityCHROMIUM extension changed to pure virtual.
https://bugs.webkit.org/show_bug.cgi?id=70818

Patch by Michal Mocny <mmocny@google.com> on 2011-10-25
Reviewed by Kenneth Russell.

* public/WebGraphicsContext3D.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFixing Windows build after r98367
mhahnenberg@apple.com [Tue, 25 Oct 2011 20:23:56 +0000 (20:23 +0000)]
Fixing Windows build after r98367

Unreviewed build fix

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[EFL] Unreviewed. Add CSS1 pixel baselines.
leandro@webkit.org [Tue, 25 Oct 2011 20:22:58 +0000 (20:22 +0000)]
[EFL] Unreviewed. Add CSS1 pixel baselines.

* platform/efl/css1: [...]

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake it possible to create and dispatch a message event through chromium API
commit-queue@webkit.org [Tue, 25 Oct 2011 20:01:34 +0000 (20:01 +0000)]
Make it possible to create and dispatch a message event through chromium API

Removed messageChannels parameter, since it's hard to get right and I don't need it. Changed message_data->messageData. Reordered includes.

https://bugs.webkit.org/show_bug.cgi?id=69962

Patch by Dave Michael <dmichael@chromium.org> on 2011-10-25
Reviewed by David Levin.

* WebKit.gyp:
* public/WebDOMEvent.h:
* public/WebDOMMessageEvent.h: Added.
* public/WebDocument.h:
* public/WebNode.h:
* src/PlatformMessagePortChannel.cpp:
(WebCore::PlatformMessagePortChannel::hasPendingActivity):
* src/WebDOMEvent.cpp:
(WebKit::WebDOMEvent::operator WTF::PassRefPtr<WebCore::Event>):
* src/WebDOMMessageEvent.cpp: Added.
(WebKit::WebDOMMessageEvent::initMessageEvent):
* src/WebDocument.cpp:
(WebKit::WebDocument::createEvent):
* src/WebNode.cpp:
(WebKit::WebNode::dispatchEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSource/WebCore: Make DocumentThreadableLoader a CachedResourceClient.
japhet@chromium.org [Tue, 25 Oct 2011 19:50:25 +0000 (19:50 +0000)]
Source/WebCore: Make DocumentThreadableLoader a CachedResourceClient.
This will allow us to cache ThreadableLoaderClients as
appropriate in a later patch.
https://bugs.webkit.org/show_bug.cgi?id=61225

Reviewed by Antti Koivisto.

No new tests, no functionality change intended.

* WebCore.gypi:
* loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::notifyFinished): CachedResourceClients don't send separate callbacks
    for didFail() and didFinishLoading(), so we need to differentiate here.
(WebCore::DocumentThreadableLoader::loadRequest): Call CachedResourceLoader::requestRawResource()
    instead of ResourceLoadScheduler::scheduleSubresourceLoad().
* loader/DocumentThreadableLoader.h:
* loader/cache/CachedRawResource.cpp:
(WebCore::CachedRawResource::data): Handle the complexity of some ThreadableLoaderClients setting
    DoNotBufferData in ResoureLoaderOptions. If the DataBufferingPolicy is BufferData, then the
    'data' input parameter will contain all data received so far, and we need to determine the
    incremental data to forward to the clients. If the policy is DoNotBufferData, 'data' is just
    the incremental data.
* loader/cache/CachedRawResource.h:
* loader/cache/CachedResource.cpp:
* loader/cache/CachedResource.h:
(WebCore::CachedResource::preloadResult):
(WebCore::CachedResource::didSendData):
(WebCore::CachedResource::didDownloadData):
(WebCore::CachedResource::setLoadFinishTime):
(WebCore::CachedResource::loadFinishTime):
* loader/cache/CachedResourceClient.h: Add several new callbacks needed by DocumentThreadableLoader.
* loader/cache/CachedResourceRequest.cpp:
(WebCore::CachedResourceRequest::didReceiveResponse): CachedResource::setResponse() can now cancel
    the request, so protect appropriately.
* loader/cache/CachedResourceRequest.h:
* loader/chromium/CachedRawResourceChromium.cpp: Added (plumb didDownloadData() to DocumentThreadableLoader).
* loader/chromium/CachedResourceRequestChromium.cpp: Added (plumb didDownloadData() to DocumentThreadableLoader).
* loader/chromium/DocumentThreadableLoaderChromium.cpp:
* platform/network/BlobResourceHandle.cpp:
(WebCore::BlobResourceHandle::notifyResponse): Protect before setting response, since it might kill us.

LayoutTests: Test update for https://bugs.webkit.org/show_bug.cgi?id=61225.
Due to changes in the implementation of DocumentThreadableLoader (and
therefore XHR), this test will have empty (rather than null) content
if we go over the length limit.

Reviewed by Antti Koivisto.

* http/tests/inspector/network/network-content-replacement-xhr-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoGet rid of optional parameters in the middle in IDLs.
abarth@webkit.org [Tue, 25 Oct 2011 19:48:28 +0000 (19:48 +0000)]
Get rid of optional parameters in the middle in IDLs.
https://bugs.webkit.org/show_bug.cgi?id=70816

Patch by Pavel Podivilov <podivilov@chromium.org> on 2011-10-25
Reviewed by Adam Barth.

Optional parameters in the middle are prohibited by WebIDL spec.

Source/WebCore:

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateArgumentsCountCheck):
(GenerateImplementation):
* html/canvas/CanvasRenderingContext2D.idl:
* page/DOMWindow.idl:

LayoutTests:

* fast/canvas/canvas-putImageData-expected.txt:
* fast/canvas/canvas-putImageData.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[EFL] Add function to get geometry of focused element
commit-queue@webkit.org [Tue, 25 Oct 2011 19:45:27 +0000 (19:45 +0000)]
[EFL] Add function to get geometry of focused element
https://bugs.webkit.org/show_bug.cgi?id=70728

Patch by Ivan Briano <ivan@profusion.mobi> on 2011-10-25
Reviewed by Antonio Gomes.

Added function to ewk_frame to get the geometry of the focused
element within the frame object.

* ewk/ewk_frame.cpp:
(ewk_frame_focused_element_geometry_get): Retrieves the geometry of
the focused element within the given frame object.
* ewk/ewk_frame.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agobuild-webkit --clean should only clean build directory for CMake-based ports
dbates@webkit.org [Tue, 25 Oct 2011 19:37:13 +0000 (19:37 +0000)]
build-webkit --clean should only clean build directory for CMake-based ports
https://bugs.webkit.org/show_bug.cgi?id=70834

Reviewed by Antonio Gomes.

Currently build-webkit --clean both cleans the build directory and builds WebKit for
CMake-based ports. Instead, build-webkit --clean should only clean up the build directory
as per its description in the usage message of build-webkit.

* Scripts/webkitdirs.pm:
(buildCMakeProjectOrExit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[EFL] Add necessary information for callback instropection
commit-queue@webkit.org [Tue, 25 Oct 2011 19:32:31 +0000 (19:32 +0000)]
[EFL] Add necessary information for callback instropection
https://bugs.webkit.org/show_bug.cgi?id=70735

Patch by Ivan Briano <ivan@profusion.mobi> on 2011-10-25
Reviewed by Antonio Gomes.

Provide the information about smart callbacks emitted by the ewk_view
object, so that these can be easily forwarded by other objects or used
by bindings in other languages without having to keep track of all of
them manually.

* ewk/ewk_view.cpp:
(ewk_view_base_smart_set):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed gardening.
jchaffraix@webkit.org [Tue, 25 Oct 2011 19:31:35 +0000 (19:31 +0000)]
Unreviewed gardening.

* platform/chromium/test_expectations.txt: Marking a test as timing
out.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoManage the CSS property array length correctly
cevans@google.com [Tue, 25 Oct 2011 19:28:15 +0000 (19:28 +0000)]
Manage the CSS property array length correctly
https://bugs.webkit.org/show_bug.cgi?id=70783

Reviewed by Adam Barth.

* css/CSSParser.cpp:
(WebCore::CSSParser::addProperty): don't allow max length to get out of sync with the buffer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoavoid unnecessary layouts of flex items during the flex pass
tony@chromium.org [Tue, 25 Oct 2011 19:26:04 +0000 (19:26 +0000)]
avoid unnecessary layouts of flex items during the flex pass
https://bugs.webkit.org/show_bug.cgi?id=70557

Reviewed by Ojan Vafai.

If the preferred size of a flex item is provided, we don't need to
layout the flex item when computing the preferred size.  This allows
us to only call layout on each flex item once in the common case.

No new tests, covered by existing tests.

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::flowAwareLogicalWidthLengthForChild):
(WebCore::RenderFlexibleBox::preferredLogicalContentWidthForFlexItem):
(WebCore::RenderFlexibleBox::computePreferredLogicalWidth):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection):
* rendering/RenderFlexibleBox.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCrash in WebCore::RenderTableSection::addChild due to assert failure
fsamuel@chromium.org [Tue, 25 Oct 2011 19:10:58 +0000 (19:10 +0000)]
Crash in WebCore::RenderTableSection::addChild due to assert failure
https://bugs.webkit.org/show_bug.cgi?id=70678

Reviewed by David Hyatt.

Source/WebCore:

Tests: fast/table/table-anonymous-cell-bug.html
       fast/table/table-anonymous-row-bug.html
       fast/table/table-anonymous-section-bug.html

If the child being added is not a Section/Row/Cell, and the previous sibling is not anonymous,
we need to create a new anonymous Section/Row/Cell respectively, instead of failing an
assert.

* rendering/RenderTable.cpp:
(WebCore::RenderTable::addChild):
* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::addChild):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::addChild):

LayoutTests:

If the child being added is not a Section/Row/Cell, and the previous sibling is not anonymous,
we need to create a new anonymous Section/Row/Cell respectively, instead of failing an
assert.

* fast/table/table-anonymous-cell-bug-expected.txt: Added.
* fast/table/table-anonymous-cell-bug.html: Added.
* fast/table/table-anonymous-row-bug-expected.txt: Added.
* fast/table/table-anonymous-row-bug.html: Added.
* fast/table/table-anonymous-section-bug-expected.txt: Added.
* fast/table/table-anonymous-section-bug.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoPDF SUBFRAMES: Incomplete repaint after pinch to zoom
andersca@apple.com [Tue, 25 Oct 2011 19:01:51 +0000 (19:01 +0000)]
PDF SUBFRAMES: Incomplete repaint after pinch to zoom
https://bugs.webkit.org/show_bug.cgi?id=70821
<rdar://problem/10312733>

Reviewed by Simon Fraser.

Add a new pure virtual member function, Plugin::wantsWindowRelativeCoordinates.
If a plug-in subclass returns true, we'll keep giving the plug-in coordinates that
are relative to the containing window. If a plug-in subclass returns false, we'll give it
coordinates in a much more sane coordinate system, with the origin at the top left corner of the plug-in.

Change BuiltinPDFView to return false so that it'll work correctly with pinch to zoom.

* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::wantsWindowRelativeCoordinates):
Make wantsWindowRelativeCoordinates return true.

* WebProcess/Plugins/PDF/BuiltInPDFView.cpp:
(WebKit::BuiltInPDFView::paint):
Remove translation since the graphics context is already set up in the right way.

(WebKit::BuiltInPDFView::paintContent):
No need to offset by the plug-in view location anymore.

(WebKit::BuiltInPDFView::paintControls):
Account for the scrollbars being children of the parent scroll view here.

(WebKit::BuiltInPDFView::wantsWindowRelativeCoordinates):
Return false.

(WebKit::BuiltInPDFView::convertFromContainingViewToScrollbar):
Implement this so that scrollbar hit testing works correctly.

* WebProcess/Plugins/Plugin.h:
Add wantsWindowRelativeCoordinates.

* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::wantsWindowRelativeCoordinates):
Return true for now.

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::renderer):
Add simple getter.

(WebKit::PluginView::paint):
Handle the case when the plug-in doesn't want window relative coordinates.

(WebKit::PluginView::transformsAffectFrameRect):
Return true here.

(WebKit::PluginView::viewGeometryDidChange):
No need to adjust the bounds to account for the scale factor now, since the frame rect will always be the
same regardless of the transform.

(WebKit::PluginView::clipRectInWindowCoordinates):
Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd missing DFG file entries to the make lists for GTK and Qt ports
commit-queue@webkit.org [Tue, 25 Oct 2011 18:59:42 +0000 (18:59 +0000)]
Add missing DFG file entries to the make lists for GTK and Qt ports
https://bugs.webkit.org/show_bug.cgi?id=70806

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-25
Reviewed by Darin Adler.

* GNUmakefile.list.am:
* JavaScriptCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd getOwnPropertySlot to MethodTable
mhahnenberg@apple.com [Tue, 25 Oct 2011 18:51:49 +0000 (18:51 +0000)]
Add getOwnPropertySlot to MethodTable
https://bugs.webkit.org/show_bug.cgi?id=69807

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

* JavaScriptCore.exp:
* runtime/ClassInfo.h: Added both versions of getOwnPropertySlot to the MethodTable.
* runtime/JSCell.h: Changed getOwnPropertySlot to be protected so other classes can
reference it in their MethodTables.

Source/WebCore:

No new tests.

* bridge/runtime_method.h: Changed getOwnPropertySlot to be protected so
subclasses can reference it in their MethodTables.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd new uri tokenizer tests
zherczeg@webkit.org [Tue, 25 Oct 2011 18:24:04 +0000 (18:24 +0000)]
Add new uri tokenizer tests
https://bugs.webkit.org/show_bug.cgi?id=70807

Reviewed by Darin Adler.

Test more cases!

* fast/css/uri-token-parsing-expected.txt:
* fast/css/uri-token-parsing.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNeed to support marking of multiple nested codeblocks when compiling
oliver@apple.com [Tue, 25 Oct 2011 18:17:37 +0000 (18:17 +0000)]
Need to support marking of multiple nested codeblocks when compiling
https://bugs.webkit.org/show_bug.cgi?id=70832

Reviewed by Gavin Barraclough.

When inlining a function we end up with multiple codeblocks being
compiled at the same time, so we need to support a list of live
codeblocks.

* heap/Heap.cpp:
(JSC::Heap::markRoots):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
* runtime/JSGlobalData.h:
(JSC::JSGlobalData::startedCompiling):
(JSC::JSGlobalData::finishedCompiling):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed gardening.
jchaffraix@webkit.org [Tue, 25 Oct 2011 18:10:38 +0000 (18:10 +0000)]
Unreviewed gardening.

The old rebaseline looked wrong and did not match the other baselines. This is now corrected.

* platform/chromium-cg-mac-leopard/fast/backgrounds/background-leakage-transforms-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed gardening.
jchaffraix@webkit.org [Tue, 25 Oct 2011 18:06:51 +0000 (18:06 +0000)]
Unreviewed gardening.

Partial rebaselining of fast/css/focus-ring-multiline-writingmode-vertical.html as it looks like it progressed
on some platforms.

* platform/chromium-cg-mac-leopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Removed.
* platform/chromium-cg-mac-snowleopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Removed.
* platform/chromium-cg-mac/fast/css/focus-ring-multiline-writingmode-vertical-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Removed.
* platform/chromium-mac/fast/css/focus-ring-multiline-writingmode-vertical-expected.png: Removed.
* platform/chromium/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago"Open with" item missing from PDF context menu in some cases
sullivan@apple.com [Tue, 25 Oct 2011 17:54:35 +0000 (17:54 +0000)]
"Open with" item missing from PDF context menu in some cases
https://bugs.webkit.org/show_bug.cgi?id=70828
<rdar://problem/10034302>

Reviewed by Anders Carlsson.

* UIProcess/API/mac/PDFViewController.mm:
(insertOpenWithDefaultPDFMenuItem):
New helper function, extracted from -menuForEvent:. Identical to original code except
that it inserts the item at a specified index, rather than always at the end.
(-[WKPDFView menuForEvent:]):
Now keeps track of whether the Open With item has been inserted while iterating through
the PDFKit-supplied menu items looking for a "Copy" item. If a "Copy" item is not found,
inserts the Open With item at the top of the context menu.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSION (r88580): Cursor fails to change to pointer on embedded Google maps popups
simon.fraser@apple.com [Tue, 25 Oct 2011 17:54:11 +0000 (17:54 +0000)]
REGRESSION (r88580): Cursor fails to change to pointer on embedded Google maps popups
https://bugs.webkit.org/show_bug.cgi?id=62797

Source/WebCore:

Reviewed by Chris Marrin.

When hit testing through transformed layers, RenderLayer would simply use
the composited bounds of the layer as the localHitTestRect for hit testing sublayers.
However, this broke hit testing on pages that have a composited, non-transformed layer
which falls outside the bounds of its parent, composited-transformed layer, like Google
Maps.

Fix by mapping the hitTestRect through transforms. However this is tricky, because
mapping a rect into the coordinate system of a layer can result in invalid rectangles
when point projection results in a negative w component. Fix TransformationMatrix::projectPoint()
to detect this case and replace X and Y with large values, and add boundsOfProjectedQuad(), which
maps rectangles with possibly-infinite location or bounds into rects which are representable
in an IntRect.

Tests: transforms/3d/hit-testing/composited-hit-test.html
       transforms/3d/hit-testing/rotated-hit-test-with-child.html
       transforms/3d/hit-testing/rotated-hit-test2.html

* platform/graphics/transforms/TransformationMatrix.cpp:
(WebCore::TransformationMatrix::projectPoint):
(WebCore::TransformationMatrix::projectQuad):
(WebCore::clampEdgeValue):
(WebCore::TransformationMatrix::boundsOfProjectedQuad):
* platform/graphics/transforms/TransformationMatrix.h:
* rendering/HitTestingTransformState.cpp:
(WebCore::HitTestingTransformState::boundsOfMappedQuad):
* rendering/HitTestingTransformState.h:
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::hitTestLayer):

LayoutTests:

Reviewed by Chris Marrin.

New tests for hit testing through various configurations of 3D transforms.

* platform/mac/transforms/3d/hit-testing/rotated-hit-test-expected.png: Removed.
* platform/mac/transforms/3d/hit-testing/rotated-hit-test-expected.txt: Removed.
* transforms/3d/hit-testing/composited-hit-test-expected.txt: Added.
* transforms/3d/hit-testing/composited-hit-test.html: Added.
* transforms/3d/hit-testing/resources/hit-test-utils.js: Added.
* transforms/3d/hit-testing/rotated-hit-test-expected.txt: Added.
* transforms/3d/hit-testing/rotated-hit-test-with-child-expected.txt: Added.
* transforms/3d/hit-testing/rotated-hit-test-with-child.html: Added.
* transforms/3d/hit-testing/rotated-hit-test.html:
* transforms/3d/hit-testing/rotated-hit-test2-expected.txt: Added.
* transforms/3d/hit-testing/rotated-hit-test2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Batch up texture uploads so that they can be updated incrementally
enne@google.com [Tue, 25 Oct 2011 17:44:31 +0000 (17:44 +0000)]
[chromium] Batch up texture uploads so that they can be updated incrementally
https://bugs.webkit.org/show_bug.cgi?id=70454

Reviewed by James Robinson.

Because texture uploads can sometimes take more than a frame to
complete, collect all the uploads that need to occur in a
CCTextureUpdater so that we can easily incrementally upload some of
them, interleaving input and drawing so that the compositor thread
continues to appear responsive during a commit.

This change doesn't actually interleave the commits, it just pushes
the infrastructure for doing so up to the CCProxy level so that a
future scheduler can make this decision.

VideoLayerChromium is the only layer type to not use this system. It
needs to be converted to use a texture updater first and it is less of
a priority than the tiled layers.

* WebCore.gypi:
* platform/graphics/chromium/Canvas2DLayerChromium.cpp:
(WebCore::Canvas2DLayerChromium::updateCompositorResources):
* platform/graphics/chromium/Canvas2DLayerChromium.h:
* platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::updateCompositorResources):
* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::updateCompositorResources):
* platform/graphics/chromium/TiledLayerChromium.h:
* platform/graphics/chromium/VideoLayerChromium.cpp:
(WebCore::VideoLayerChromium::updateCompositorResources):
* platform/graphics/chromium/VideoLayerChromium.h:
* platform/graphics/chromium/WebGLLayerChromium.cpp:
(WebCore::WebGLLayerChromium::updateCompositorResources):
* platform/graphics/chromium/WebGLLayerChromium.h:
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::beginCommitOnImplThread):
(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
(WebCore::CCLayerTreeHost::updateCompositorResources):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::setNeedsCommit):
(WebCore::CCSingleThreadProxy::doCommit):
(WebCore::CCSingleThreadProxy::commitIfNeeded):
* platform/graphics/chromium/cc/CCSingleThreadProxy.h:
* platform/graphics/chromium/cc/CCTextureUpdater.cpp: Added.
(WebCore::CCTextureUpdater::CCTextureUpdater):
(WebCore::CCTextureUpdater::~CCTextureUpdater):
(WebCore::CCTextureUpdater::append):
(WebCore::CCTextureUpdater::update):
(WebCore::CCTextureUpdater::clear):
* platform/graphics/chromium/cc/CCTextureUpdater.h: Added.
(WebCore::CCTextureUpdater::allocator):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::commitOnImplThread):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agocompositing/video tests time out on Lion
jer.noble@apple.com [Tue, 25 Oct 2011 17:42:18 +0000 (17:42 +0000)]
compositing/video tests time out on Lion
https://bugs.webkit.org/show_bug.cgi?id=70448

Reviewed by Simon Fraser.

Source/WebCore:

AVFoundation will not begin loading or decoding media until a consumer for that media is present.
For video-only media, this means that an AVPlayerLayer must be created and attached to the
AVPlayer before the load state will ever reach "canPlayThrough". Once the metadata for a media
is loaded, create a AVPlayerLayer if the media has a video track.

* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::updateStates):

LayoutTests:

* compositing/video/video-poster.html: Seek, instead of play, to trigger
    creation of a layer
* http/tests/media/video-load-twice.html: Use waitForEventOnce so that
    canPlayThrough listener is triggered only once.
* media/video-test.js: Add a new function, waitForEventOnce.
(waitForEventOnce):
(waitForEvent._eventCallback):
(waitForEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMerge endOfLine with logicalEndOfLine and startOfLine with logicalStartOfLine
rniwa@webkit.org [Tue, 25 Oct 2011 17:22:50 +0000 (17:22 +0000)]
Merge endOfLine with logicalEndOfLine and startOfLine with logicalStartOfLine
https://bugs.webkit.org/show_bug.cgi?id=70755

Reviewed by Chang Shu.

Merged endOfLine with logicalEndOfLine, and startOfLine with logicalStartOfLine
to reduce the code duplication.

* editing/visible_units.cpp:
(WebCore::startPositionForLine):
(WebCore::startOfLine):
(WebCore::logicalStartOfLine):
(WebCore::endPositionForLine):
(WebCore::inSameLogicalLine):
(WebCore::endOfLine):
(WebCore::logicalEndOfLine):
* editing/visible_units.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRe-enable touch tests (from 66577)
commit-queue@webkit.org [Tue, 25 Oct 2011 17:22:37 +0000 (17:22 +0000)]
Re-enable touch tests (from 66577)
https://bugs.webkit.org/show_bug.cgi?id=70351

Patch by Gene Girard <girard@chromium.org> on 2011-10-25
Reviewed by Adam Barth.

* tests/InnerGestureRecognizerTest.cpp:
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Rolled DEPS.
nduca@chromium.org [Tue, 25 Oct 2011 17:18:38 +0000 (17:18 +0000)]
Unreviewed. Rolled DEPS.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed gardening: fifth chunk of baselines for Chromium-Skia
caryclark@google.com [Tue, 25 Oct 2011 17:17:46 +0000 (17:17 +0000)]
Unreviewed gardening: fifth chunk of baselines for Chromium-Skia
on Leopard.

[Omitting 736 of 742 files for brevity.]

* platform/chromium-mac-leopard/tables/mozilla/bugs/bug2479-2-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug2479-3-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug2479-4-expected.png: Added.
...
* platform/chromium-mac-leopard/transitions: Added.
* platform/chromium-mac-leopard/transitions/default-timing-function-expected.png: Added.
* platform/chromium-mac-leopard/transitions/svg-text-shadow-transition-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoEnable running of track layout tests for Chromium
annacc@chromium.org [Tue, 25 Oct 2011 17:04:05 +0000 (17:04 +0000)]
Enable running of track layout tests for Chromium
https://bugs.webkit.org/show_bug.cgi?id=70803

Reviewed by Adam Barth.

Make DumpRenderTree/TestShell always run with track enabled
(equivalent of --enable-video-track).

* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSource/WebCore: Microdata: itemtype attribute should be space-separated list to allow...
commit-queue@webkit.org [Tue, 25 Oct 2011 16:53:52 +0000 (16:53 +0000)]
Source/WebCore: Microdata: itemtype attribute should be space-separated list to allow multiple types.
https://bugs.webkit.org/show_bug.cgi?id=70501

Patch by Arko Saha <arko@motorola.com> on 2011-10-25
Reviewed by Ryosuke Niwa.

Tests: fast/dom/MicroData/getitems-multiple-itemtypes.html
       fast/dom/MicroData/itemtype-add-remove-tokens.html
       fast/dom/MicroData/itemtype-attribute-test.html

* dom/MicroDataItemList.cpp:
(WebCore::MicroDataItemList::nodeMatches):
* html/DOMSettableTokenList.h:
(WebCore::DOMSettableTokenList::tokens):
* html/HTMLElement.cpp:
(WebCore::HTMLElement::parseMappedAttribute):
(WebCore::HTMLElement::setItemValueText):
(WebCore::HTMLElement::itemType):
(WebCore::HTMLElement::setItemType):
* html/HTMLElement.h:
* html/HTMLElement.idl:

LayoutTests: Microdata: itemtype attribute should be space-separated list to allow multiple types
https://bugs.webkit.org/show_bug.cgi?id=70501

Patch by Arko Saha <arko@motorola.com> on 2011-10-25
Reviewed by Ryosuke Niwa.

* fast/dom/MicroData/006.html:
* fast/dom/MicroData/007.html:
* fast/dom/MicroData/getitems-multiple-itemtypes-expected.txt: Added.
* fast/dom/MicroData/getitems-multiple-itemtypes.html: Added.
* fast/dom/MicroData/itemtype-add-remove-tokens-expected.txt: Added.
* fast/dom/MicroData/itemtype-add-remove-tokens.html: Added.
* fast/dom/MicroData/itemtype-attribute-test-expected.txt: Added.
* fast/dom/MicroData/itemtype-attribute-test.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[GTK] GtkAdjustment watcher updates adjustments too lazily
commit-queue@webkit.org [Tue, 25 Oct 2011 16:52:50 +0000 (16:52 +0000)]
[GTK] GtkAdjustment watcher updates adjustments too lazily
https://bugs.webkit.org/show_bug.cgi?id=70180

Patch by Martin Robinson <mrobinson@igalia.com> on 2011-10-25
Reviewed by Gustavo Noronha Silva.

Increase the priority of the GtkAdjustments update in GtkAdjustmentWatcher. This
means that adjustments will more quickly represent the state of the WebKitWebView
when it scrolls. This fixes out-of-sync scrollbars and some visual artifacts.

* WebCoreSupport/GtkAdjustmentWatcher.cpp:
(WebKit::GtkAdjustmentWatcher::updateAdjustmentsFromScrollbarsLater): Use a timeout
with the default priority.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[WK2]Main window never gets focus using TAB key in WebKit2 GTK+.
commit-queue@webkit.org [Tue, 25 Oct 2011 16:40:29 +0000 (16:40 +0000)]
[WK2]Main window never gets focus using TAB key in WebKit2 GTK+.
https://bugs.webkit.org/show_bug.cgi?id=70603

Patch by Vamshikrishna Yellenki <vamshi@motorola.com> on 2011-10-25
Reviewed by Gustavo Noronha Silva.

* MiniBrowser/gtk/BrowserWindow.c:
(focus):
(unFocus):
(browserWindowUIClientInit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/10337033> DOMRangeOfString:relativeTo:options has problems with ...
mitz@apple.com [Tue, 25 Oct 2011 16:39:23 +0000 (16:39 +0000)]
<rdar://problem/10337033> DOMRangeOfString:relativeTo:options has problems with -webkit-user-select: none

Reviewed by Adam Roben.

Source/WebCore:

Test: added to TestWebKitAPI/Tests/mac/DOMRangeOfString.mm

* page/Page.cpp:
(WebCore::Page::rangeOfString): This function was incorrectly adding the StartInSelection option to
the initial search.

Tools:

* TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed gardening: fourth chunk of baselines for Chromium-Skia
caryclark@google.com [Tue, 25 Oct 2011 16:26:15 +0000 (16:26 +0000)]
Unreviewed gardening: fourth chunk of baselines for Chromium-Skia
on Leopard.

[Omitting 728 of 734 files for brevity.]

* platform/chromium-mac-leopard/fast/lists/ordered-list-with-no-ol-tag-expected.png: Added.
* platform/chromium-mac-leopard/fast/lists/scrolled-marker-paint-expected.png: Added.
* platform/chromium-mac-leopard/fast/media: Added.
...
* platform/chromium-mac-leopard/svg/W3C-SVG-1.1/text-tref-01-b-expected.png: Added.
* platform/chromium-mac-leopard/svg/W3C-SVG-1.1/text-tselect-02-f-expected.png: Added.
* platform/chromium-mac-leopard/svg/W3C-SVG-1.1/text-tspan-01-b-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: redesign workers sidebar pane
yurys@chromium.org [Tue, 25 Oct 2011 15:35:50 +0000 (15:35 +0000)]
Web Inspector: redesign workers sidebar pane
https://bugs.webkit.org/show_bug.cgi?id=70815

Source/WebCore:

Changed workers sidebar pane design.

Now there is a link to worker inspector for each dedicated worker created
by inspected page. The sidebar display a link to a page with list of all
shared workers if there one is supported by the WebKit port. Also there
is a checkbox that allows pause all new workers on first statements.

Reviewed by Pavel Feldman.

* inspector/front-end/Settings.js:
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype._rebuildSectionsForStyleRules):
* inspector/front-end/WorkerManager.js:
(WebInspector.WorkerManager.prototype.openWorkerInspector):
(WebInspector.WorkerManager.prototype._workerInspectorClosing):
* inspector/front-end/WorkersSidebarPane.js:
(WebInspector.WorkerListSidebarPane):
(WebInspector.WorkerListSidebarPane.prototype._workerRemoved):
(WebInspector.WorkerListSidebarPane.prototype._workersCleared):
(WebInspector.WorkerListSidebarPane.prototype._addWorker):
(WebInspector.WorkerListSidebarPane.prototype._workerItemClicked):
(WebInspector.WorkerListSidebarPane.prototype._autoattachToWorkersClicked):
(WebInspector.WorkerListSidebarPane.prototype._createSharedWorkersLink.link.onclick):
(WebInspector.WorkerListSidebarPane.prototype._createSharedWorkersLink):
* inspector/front-end/elementsPanel.css:
* inspector/front-end/inspectorCommon.css:
(.sidebar-separator):
(.sidebar-label):
* inspector/front-end/scriptsPanel.css:
(.dedicated-worker-item):
(#shared-workers-list):
(#pause-workers-checkbox > input):

Source/WebKit/chromium:

Reviewed by Pavel Feldman.

* src/js/DevTools.js: Expose link to shared workers inspection page to WebCore.
():

LayoutTests:

Update tests in accord with change of class name from
styles-sidebar-pane to sidebar-pane.

Reviewed by Pavel Feldman.

* http/tests/inspector/elements-test.js:
(initialize_ElementTest.InspectorTest.dumpSelectedElementStyles):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98348 268f45cc-cd09-0410-ab3c-d52691b4dbfc