WebKit-https.git
10 years ago2010-07-02 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 2 Jul 2010 08:29:43 +0000 (08:29 +0000)]
2010-07-02  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Implement AfterBodyMode for HTML5 tree builder
        https://bugs.webkit.org/show_bug.cgi?id=41500

        Update expected results to show test progression.  Also, add some test
        cases to cover how attributes on </br> tags are handled.

        * html5lib/resources/webkit01.dat:
        * html5lib/runner-expected-html5.txt:
        * html5lib/runner-expected.txt:
        * html5lib/webkit-resumer-expected.txt:
2010-07-02  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Implement AfterBodyMode for HTML5 tree builder
        https://bugs.webkit.org/show_bug.cgi?id=41500

        In the coarse of implementing this state, I ran into an ASSERT in how
        </br> tags where handled, which I fixed.  Technically, that could be a
        separate patch, but it seemed harmless to include it here (with tests).

        * html/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::processStartTag):
        (WebCore::HTMLTreeBuilder::processEndTag):
        (WebCore::HTMLTreeBuilder::processComment):
        (WebCore::HTMLTreeBuilder::processCharacter):
        (WebCore::HTMLTreeBuilder::processEndOfFile):
        (WebCore::HTMLTreeBuilder::insertCommentOnHTMLHtmlElement):
        * html/HTMLTreeBuilder.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-02 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 2 Jul 2010 08:14:56 +0000 (08:14 +0000)]
2010-07-02  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Handle <base> and friends in AfterHeadMode
        https://bugs.webkit.org/show_bug.cgi?id=41502

        See test progression.  Fun game.

        * html5lib/runner-expected-html5.txt:
2010-07-02  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Handle <base> and friends in AfterHeadMode
        https://bugs.webkit.org/show_bug.cgi?id=41502

        Implement notImplemented() per spec.

        * html/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::processStartTag):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChromium build fix.
oliver@apple.com [Fri, 2 Jul 2010 06:47:29 +0000 (06:47 +0000)]
Chromium build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-01 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Fri, 2 Jul 2010 06:31:27 +0000 (06:31 +0000)]
2010-07-01  Oliver Hunt  <oliver@apple.com>

        Reviewed by Maciej Stachowiak.

        Add a FixedArray template to encapsulate fixed length arrays
        https://bugs.webkit.org/show_bug.cgi?id=41506

        This new type is used in place of fixed length C arrays so
        that debug builds can guard against attempts to go beyond
        the end of the array.

        * JavaScriptCore.xcodeproj/project.pbxproj:
        * bytecode/Opcode.cpp:
        (JSC::OpcodeStats::~OpcodeStats):
        * pcre/pcre_compile.cpp:
        (calculateCompiledPatternLength):
        * runtime/Collector.cpp:
        (JSC::Heap::allocateBlock):
        (JSC::Heap::allocate):
        * runtime/Collector.h:
        (JSC::CollectorBitmap::clearAll):
        * runtime/CollectorHeapIterator.h:
        (JSC::CollectorHeapIterator::operator*):
        * runtime/DateInstanceCache.h:
        * runtime/JSString.cpp:
        (JSC::JSString::replaceCharacter):
        * runtime/JSString.h:
        (JSC::RopeBuilder::JSStringFinalizerStruct::):
        * runtime/NumericStrings.h:
        * runtime/RegExpCache.h:
        * runtime/SmallStrings.h:
        (JSC::SmallStrings::singleCharacterStrings):
        * wtf/AVLTree.h:
        * wtf/FixedArray.h: Added.
        (WTF::FixedArray::operator[]):
        (WTF::FixedArray::data):
2010-07-01  Oliver Hunt  <oliver@apple.com>

        Reviewed by Maciej Stachowiak.

        Add a FixedArray template to encapsulate fixed length arrays
        https://bugs.webkit.org/show_bug.cgi?id=41506

        Add forwarding header.

        * ForwardingHeaders/wtf/FixedArray.h: Added.
2010-07-01  Oliver Hunt  <oliver@apple.com>

        Reviewed by Maciej Stachowiak.

        Add a FixedArray template to encapsulate fixed length arrays
        https://bugs.webkit.org/show_bug.cgi?id=41506

        Add forwarding header, and replace a few fixed length arrays
        with the new FixedArray type.

        * ForwardingHeaders/wtf/FixedArray.h: Added.
        * dom/Document.h:
        * platform/graphics/GlyphMetricsMap.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoImprove the main lexer switch by mapping input characters to their type
zherczeg@webkit.org [Fri, 2 Jul 2010 06:17:40 +0000 (06:17 +0000)]
Improve the main lexer switch by mapping input characters to their type
https://bugs.webkit.org/show_bug.cgi?id=41459

Reviewed by Oliver Hunt.

Sunsipder: no change (from 532.9ms to 531.5ms)
SunSpider --parse-only: 1.025x as fast (from 33.1ms to 32.3ms)

* parser/Lexer.cpp:
(JSC::):
(JSC::Lexer::lex):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoProvide a WebView preference to disable DNS prefetching on Windows
sfalken@apple.com [Fri, 2 Jul 2010 06:04:21 +0000 (06:04 +0000)]
Provide a WebView preference to disable DNS prefetching on Windows
https://bugs.webkit.org/show_bug.cgi?id=41504
<rdar://problem/8151939>

Reviewed by Adele Peterson.

* Interfaces/IWebPreferencesPrivate.idl: Added isDNSPrefetchingEnabled, setDNSPrefetchingEnabled.
* Interfaces/WebKit.idl: Touched to force IDL build.
* WebPreferenceKeysPrivate.h: Added WebKitDNSPrefetchingEnabledPreferenceKey.
* WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings): Default prefetch to true.
(WebPreferences::setDNSPrefetchingEnabled): Added.
(WebPreferences::isDNSPrefetchingEnabled): Added.
* WebPreferences.h: Added isDNSPrefetchingEnabled, setDNSPrefetchingEnabled.
* WebView.cpp:
(WebView::notifyPreferencesChanged): Propagate prefetch pref into settings.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-01 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 2 Jul 2010 05:16:42 +0000 (05:16 +0000)]
2010-07-01  Simon Fraser  <simon.fraser@apple.com>

        No review.

        Fix a link warning in 32-bit by not explicitly exporting WebCore::GraphicsLayer::syncCompositingStateForThisLayerOnly().

        * WebCore.AcceleratedCompositing.exp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoEven more Windows build fixing.
sfalken@apple.com [Fri, 2 Jul 2010 05:06:36 +0000 (05:06 +0000)]
Even more Windows build fixing.
Removed bogus post-build event commands.
Removed unnecessary link libraries.

* win/WebKit2.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix Windows while not breaking Qt (didn't realize this was building for Qt).
sfalken@apple.com [Fri, 2 Jul 2010 04:58:34 +0000 (04:58 +0000)]
Fix Windows while not breaking Qt (didn't realize this was building for Qt).

* WebProcess/WebProcess.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-01 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 2 Jul 2010 04:54:08 +0000 (04:54 +0000)]
2010-07-01  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Sam Weinig.

        <rdar://problem/8154047>

        Update WebKitSystemInterface, making some functions used by
        WebKit2 available in 32-bit (for reals this time).

        * libWebKitSystemInterfaceLeopard.a:
        * libWebKitSystemInterfaceSnowLeopard.a:
        * libWebKitSystemInterfaceTiger.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWindows build fix.
sfalken@apple.com [Fri, 2 Jul 2010 04:52:29 +0000 (04:52 +0000)]
Windows build fix.

* win/WebKit2Generated.make:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWindows build fix.
sfalken@apple.com [Fri, 2 Jul 2010 04:31:58 +0000 (04:31 +0000)]
Windows build fix.

* WebProcess/WebProcess.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake WebKit2 compile (though not work) on Leopard.
weinig@apple.com [Fri, 2 Jul 2010 04:21:16 +0000 (04:21 +0000)]
Make WebKit2 compile (though not work) on Leopard.

Reviewed by Jon Honeycutt.

* Platform/WorkQueue.h:
* Platform/mac/WorkQueueMac.cpp:
(WorkQueue::EventSource::EventSource):
(WorkQueue::scheduleWork):
(WorkQueue::registerMachPortEventHandler):
(WorkQueue::unregisterMachPortEventHandler):
(WorkQueue::platformInitialize):
(WorkQueue::platformInvalidate):
* UIProcess/mac/LayerBackedDrawingAreaProxyMac.mm:
(WebKit::LayerBackedDrawingAreaProxy::attachCompositingContext):
* UIProcess/mac/WebProcessProxyMac.mm:
(WebKit::WebProcessProxy::setUpAcceleratedCompositing):
* WebProcess/WebPage/LayerBackedDrawingArea.cpp:
(WebKit::LayerBackedDrawingArea::LayerBackedDrawingArea):
(WebKit::LayerBackedDrawingArea::setNeedsDisplay):
* WebProcess/WebPage/LayerBackedDrawingArea.h:
* WebProcess/WebPage/mac/LayerBackedDrawingAreaMac.mm:
(WebKit::LayerBackedDrawingArea::platformClear):
(WebKit::LayerBackedDrawingArea::attachCompositingContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-01 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Fri, 2 Jul 2010 04:18:47 +0000 (04:18 +0000)]
2010-07-01  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Dimitri Glazkov.

        Add window.performance.navigation namespace
        https://bugs.webkit.org/show_bug.cgi?id=41442

        Adds window.performance.navigation namespace consisting of ".type"
        and ".redirectCount". As part of this change, I renmaed "NavigationTiming"
        to just "Timing" to avoid confusion.

        No new tests because tests will be added in a subsequent patch when
        functionality is added.

        * Android.mk:
        * CMakeLists.txt:
        * DerivedSources.cpp:
        * DerivedSources.make:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pri:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * page/Navigation.cpp: Added.
        (WebCore::Navigation::Navigation):
        (WebCore::Navigation::frame):
        (WebCore::Navigation::disconnectFrame):
        (WebCore::Navigation::type):
        (WebCore::Navigation::redirectCount):
        * page/Navigation.h: Added.
        (WebCore::Navigation::create):
        * page/Navigation.idl: Added.
        * page/NavigationTiming.cpp: Removed.
        * page/NavigationTiming.h: Removed.
        * page/NavigationTiming.idl: Removed.
        * page/Performance.cpp:
        (WebCore::Performance::navigation):
        (WebCore::Performance::timing):
        * page/Performance.h:
        * page/Performance.idl:
        * page/Timing.cpp: Added.
        (WebCore::Timing::Timing):
        (WebCore::Timing::frame):
        (WebCore::Timing::disconnectFrame):
        (WebCore::Timing::navigationStart):
        * page/Timing.h: Added.
        (WebCore::Timing::create):
        * page/Timing.idl: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-01 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 2 Jul 2010 04:16:01 +0000 (04:16 +0000)]
2010-07-01  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Sam Weinig.

        <rdar://problem/8154047>

        Update WebKitSystemInterface, making some functions used by
        WebKit2 available in 32-bit.

        * WebKitSystemInterface.h:
        * libWebKitSystemInterfaceLeopard.a:
        * libWebKitSystemInterfaceSnowLeopard.a:
        * libWebKitSystemInterfaceTiger.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDefine HAVE_HOSTED_CORE_ANIMATION on Snow Leopard.
weinig@apple.com [Fri, 2 Jul 2010 04:15:21 +0000 (04:15 +0000)]
Define HAVE_HOSTED_CORE_ANIMATION on Snow Leopard.

Rubber-stamped by Ander Carlsson.

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-01 Daniel Cheng <dcheng@chromium.org>
commit-queue@webkit.org [Fri, 2 Jul 2010 04:02:49 +0000 (04:02 +0000)]
2010-07-01  Daniel Cheng  <dcheng@chromium.org>

        Reviewed by Jian Li.

        [chromium] Dragging a link triggers an assert when accessing event.dataTransfer.types
        https://bugs.webkit.org/show_bug.cgi?id=41493

        ClipboardChromium::writeURL violates ClipboardChromium's assumption that uriList will always
        be non-empty if url is valid.

        No new tests.

        * platform/chromium/ClipboardChromium.cpp:
        (WebCore::ClipboardChromium::writeURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-01 Andreas Kling <andreas.kling@nokia.com>
commit-queue@webkit.org [Fri, 2 Jul 2010 03:51:27 +0000 (03:51 +0000)]
2010-07-01  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Tor Arne Vestbø.

        [Qt] Clamp color stops passed to QGradient to 1.0
        [https://bugs.webkit.org/show_bug.cgi?id=41484

        Fixes an issue where color stops would be silently dropped from radial gradients.

        * platform/graphics/qt/GradientQt.cpp:
        (WebCore::Gradient::platformGradient):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-01 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 2 Jul 2010 03:15:27 +0000 (03:15 +0000)]
2010-07-01  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        HTMLTokenizer should ASSERT that it never emits a null character
        https://bugs.webkit.org/show_bug.cgi?id=41448

        No functional change, thus no tests.  These ASSERTs would have
        caught the coding error which caused the trouble in bug 41436
        (which was fixed by bug 41439).

        * html/HTMLToken.h:
        (WebCore::HTMLToken::beginStartTag):
        (WebCore::HTMLToken::beginCharacter):
        (WebCore::HTMLToken::beginDOCTYPE):
        (WebCore::HTMLToken::appendToName):
        (WebCore::HTMLToken::appendToComment):
        (WebCore::HTMLToken::appendToAttributeName):
        (WebCore::HTMLToken::appendToAttributeValue):
        (WebCore::HTMLToken::appendToPublicIdentifier):
        (WebCore::HTMLToken::appendToSystemIdentifier):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-01 Sheriff Bot <webkit.review.bot@gmail.com>
levin@chromium.org [Fri, 2 Jul 2010 03:12:58 +0000 (03:12 +0000)]
2010-07-01  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r62349.
        http://trac.webkit.org/changeset/62349
        https://bugs.webkit.org/show_bug.cgi?id=41499

        It broke the chromium Linux build. (Requested by dave_levin on
        #webkit).

        * public/WebNode.h:
        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::registerPasswordListener):
        (WebKit::WebFrameImpl::notifiyPasswordListenerOfAutocomplete):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-01 Andreas Kling <andreas.kling@nokia.com>
commit-queue@webkit.org [Fri, 2 Jul 2010 03:03:37 +0000 (03:03 +0000)]
2010-07-01  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Tor Arne Vestbø.

        Canvas: Don't paint with empty radial gradients
        https://bugs.webkit.org/show_bug.cgi?id=41190

        Unskip canvas/philip/tests/2d.gradient.radial.equal.html for Qt.

        * platform/qt/Skipped:
2010-07-01  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Tor Arne Vestbø.

        Canvas: Don't paint with empty radial gradients
        https://bugs.webkit.org/show_bug.cgi?id=41190

        If a radial gradient has x0==x1 && y0==y1 && r0==r1, don't paint with it.

        * html/canvas/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::fillRect):
        * platform/graphics/Gradient.h:
        (WebCore::Gradient::isZeroSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-01 David Holloway <dhollowa@chromium.org>
commit-queue@webkit.org [Fri, 2 Jul 2010 02:50:38 +0000 (02:50 +0000)]
2010-07-01  David Holloway  <dhollowa@chromium.org>

        Reviewed by Darin Fisher.

        [chromium] Exposes WebNode::unwrap() and WebNode::constUnwrap() for
        use by other code in WebKit/chromium/src.

        Specific use of these methods is made in WebFrameImpl.cpp.  This is
        preferred to the cast operator call that was happening prior to this
        change.

        https://bugs.webkit.org/show_bug.cgi?id=41477

        * public/WebNode.h:
        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::registerPasswordListener):
        (WebKit::WebFrameImpl::notifiyPasswordListenerOfAutocomplete):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-01 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Fri, 2 Jul 2010 02:22:43 +0000 (02:22 +0000)]
2010-07-01  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Adam Barth.

        Add interface for network platform to pass up timing information
        https://bugs.webkit.org/show_bug.cgi?id=41437

        The Web Timing feature requires the network platform to expose detailed
        timing information for the main resource. This patch adds that data to
        the ResourceResponseBase. Since the 82 bytes of information is only
        needed for the main resource, it is a RefPtr to avoid using the memory
        for other resource types.

        No new tests because no new functionality.

        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * platform/network/ResourceLoadTiming.h: Added.
        (WebCore::ResourceLoadTiming::create):
        (WebCore::ResourceLoadTiming::deepCopy):
        (WebCore::ResourceLoadTiming::operator==):
        (WebCore::ResourceLoadTiming::operator!=):
        (WebCore::ResourceLoadTiming::ResourceLoadTiming):
        * platform/network/ResourceResponseBase.cpp:
        (WebCore::ResourceResponseBase::adopt):
        (WebCore::ResourceResponseBase::copyData):
        (WebCore::ResourceResponseBase::resourceLoadTiming):
        (WebCore::ResourceResponseBase::setResourceLoadTiming):
        (WebCore::ResourceResponseBase::compare):
        * platform/network/ResourceResponseBase.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago* platform/chromium/test_expectations.txt: Removed a test
levin@chromium.org [Fri, 2 Jul 2010 01:14:34 +0000 (01:14 +0000)]
* platform/chromium/test_expectations.txt: Removed a test
  that is passing and added a test that is now failing.

Reviewed by NOBODY (trivial test_expectations change).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago* platform/chromium/test_expectations.txt: Upstreamed two
levin@chromium.org [Fri, 2 Jul 2010 00:58:41 +0000 (00:58 +0000)]
* platform/chromium/test_expectations.txt: Upstreamed two
  test expectation issues for flaky tests.

Reviewed by NOBODY (trivial test expectation changes).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-01 Sheriff Bot <webkit.review.bot@gmail.com>
dumi@chromium.org [Fri, 2 Jul 2010 00:19:59 +0000 (00:19 +0000)]
2010-07-01  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r62321.
        http://trac.webkit.org/changeset/62321
        https://bugs.webkit.org/show_bug.cgi?id=41494

        Broke the non-win builds. (Requested by dumi on #webkit).

        * dom/ScriptExecutionContext.cpp:
        (WebCore::ScriptExecutionContext::addOpenDatabase):
        (WebCore::ScriptExecutionContext::removeOpenDatabase):
        (WebCore::ScriptExecutionContext::stopDatabases):
        * dom/ScriptExecutionContext.h:
        * storage/Database.cpp:
        (WebCore::Database::openDatabase):
        (WebCore::Database::Database):
        (WebCore::Database::markAsDeletedAndClose):
        (WebCore::ContextRemoveOpenDatabaseTask::create):
        (WebCore::ContextRemoveOpenDatabaseTask::performTask):
        (WebCore::ContextRemoveOpenDatabaseTask::isCleanupTask):
        (WebCore::ContextRemoveOpenDatabaseTask::ContextRemoveOpenDatabaseTask):
        (WebCore::Database::close):
        (WebCore::Database::closeImmediately):
        (WebCore::Database::stop):
        (WebCore::Database::performPolicyChecks):
        * storage/Database.h:
        (WebCore::Database::):
        (WebCore::Database::stopped):
        * storage/DatabaseTask.cpp:
        (WebCore::DatabaseTask::performTask):
        (WebCore::DatabaseOpenTask::DatabaseOpenTask):
        (WebCore::DatabaseOpenTask::doPerformTask):
        (WebCore::DatabaseOpenTask::debugTaskName):
        (WebCore::DatabaseCloseTask::DatabaseCloseTask):
        (WebCore::DatabaseCloseTask::doPerformTask):
        (WebCore::DatabaseCloseTask::debugTaskName):
        (WebCore::DatabaseTransactionTask::DatabaseTransactionTask):
        (WebCore::DatabaseTransactionTask::~DatabaseTransactionTask):
        (WebCore::DatabaseTransactionTask::doPerformTask):
        (WebCore::DatabaseTransactionTask::debugTaskName):
        (WebCore::DatabaseTableNamesTask::DatabaseTableNamesTask):
        (WebCore::DatabaseTableNamesTask::doPerformTask):
        (WebCore::DatabaseTableNamesTask::debugTaskName):
        * storage/DatabaseTask.h:
        (WebCore::DatabaseOpenTask::create):
        (WebCore::DatabaseCloseTask::create):
        (WebCore::DatabaseTransactionTask::create):
        (WebCore::DatabaseTableNamesTask::create):
        * storage/DatabaseThread.cpp:
        (WebCore::DatabaseThread::databaseThread):
        * storage/DatabaseTracker.cpp:
        (WebCore::DatabaseTracker::addOpenDatabase):
        * storage/SQLTransaction.cpp:
        (WebCore::SQLTransaction::executeSQL):
        (WebCore::SQLTransaction::checkAndHandleClosedDatabase):
2010-07-01  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r62321.
        http://trac.webkit.org/changeset/62321
        https://bugs.webkit.org/show_bug.cgi?id=41494

        Broke the non-win builds. (Requested by dumi on #webkit).

        * storage/open-database-creation-callback.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore:
xan@webkit.org [Thu, 1 Jul 2010 23:52:06 +0000 (23:52 +0000)]
WebCore:

2010-07-01  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        [GTK] Stop using GdkRegion in 3.x mode
        https://bugs.webkit.org/show_bug.cgi?id=41463

        Make us compile without using GdkRegion, since it's gone from GTK+
        3.x.

        * platform/graphics/IntRect.h:
        * platform/graphics/cairo/GraphicsContextCairo.cpp:
        (WebCore::GraphicsContext::drawFocusRing):
        * platform/graphics/gtk/FontGtk.cpp:
        (WebCore::cairo_region_shrink):
        (WebCore::Font::drawComplexText):
        * platform/gtk/GtkPluginWidget.cpp:
        (WebCore::GtkPluginWidget::paint):
        * platform/gtk/RenderThemeGtk.h:
        * platform/gtk/ScrollbarGtk.cpp:
        (ScrollbarGtk::paint):

WebKit/gtk:

2010-07-01  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        [GTK] Stop using GdkRegion in 3.x mode
        https://bugs.webkit.org/show_bug.cgi?id=41463

        Make us compile without using GdkRegion, since it's gone from GTK+
        3.x.

        * WebCoreSupport/ChromeClientGtk.cpp:
        (WebKit::ChromeClient::scroll):
        * webkit/webkitwebview.cpp:
        (webkit_web_view_expose_event):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: DB clean up.
dumi@chromium.org [Thu, 1 Jul 2010 23:33:40 +0000 (23:33 +0000)]
WebCore: DB clean up.
https://bugs.webkit.org/show_bug.cgi?id=41404

Reviewed by Darin Fisher.

1. Made all DatabaseTasks internal classes of Database and made
   the Database methods called by those tasks private.
2. Removed the Database::stop{ed}() methods.
3. Removed the code that kept track of open databases from
   ScriptExecutionContext (no longer needed).
4. Made minor changes to Database::closeImmediately() to make it
   possible for DatabaseThread to call that method instead of
   close().
5. Minor fix to DatabaseTracker: addOpenDatabase() should call
   OriginQuotaManager::addDatabase() if the origin quota manager
   is not tracking this origin.
6. Removed Database::performPolicyChecks(). We already update the
   DB size after each transaction, and we enforce a max size for
   the DB at the beginning of each transaction.

* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::stopDatabases):
* dom/ScriptExecutionContext.h:
(WebCore::ScriptExecutionContext::hasOpenDatabases):
* storage/Database.cpp:
(WebCore::Database::openDatabase):
(WebCore::Database::Database):
(WebCore::Database::markAsDeletedAndClose):
(WebCore::Database::close):
(WebCore::Database::closeImmediately):
* storage/Database.h:
* storage/DatabaseTask.cpp:
(WebCore::DatabaseTask::performTask):
(WebCore::Database::DatabaseOpenTask::DatabaseOpenTask):
(WebCore::Database::DatabaseOpenTask::doPerformTask):
(WebCore::Database::DatabaseOpenTask::debugTaskName):
(WebCore::Database::DatabaseCloseTask::DatabaseCloseTask):
(WebCore::Database::DatabaseCloseTask::doPerformTask):
(WebCore::Database::DatabaseCloseTask::debugTaskName):
(WebCore::Database::DatabaseTransactionTask::DatabaseTransactionTask):
(WebCore::Database::DatabaseTransactionTask::doPerformTask):
(WebCore::Database::DatabaseTransactionTask::debugTaskName):
(WebCore::Database::DatabaseTableNamesTask::DatabaseTableNamesTask):
(WebCore::Database::DatabaseTableNamesTask::doPerformTask):
(WebCore::Database::DatabaseTableNamesTask::debugTaskName):
* storage/DatabaseTask.h:
(WebCore::Database::DatabaseOpenTask::create):
(WebCore::Database::DatabaseCloseTask::create):
(WebCore::Database::DatabaseTransactionTask::create):
(WebCore::Database::DatabaseTableNamesTask::create):
* storage/DatabaseThread.cpp:
(WebCore::DatabaseThread::databaseThread):
* storage/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::addOpenDatabase):
* storage/SQLTransaction.cpp:
(WebCore::SQLTransaction::executeSQL):
(WebCore::SQLTransaction::checkAndHandleClosedDatabase):

LayoutTests: Minor change to a DB test to make it run correctly with run-webkit-tests --iterations N.
https://bugs.webkit.org/show_bug.cgi?id=41404

Reviewed by Darin Fisher.

* storage/open-database-creation-callback.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-01 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 1 Jul 2010 23:26:00 +0000 (23:26 +0000)]
2010-07-01  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Anders Carlsson.

        Get accelerated compositing working with webkit2
        https://bugs.webkit.org/show_bug.cgi?id=41084

        Start up the CA render server in the UI process (currently, at launch time), and
        pass the server port over to the web process for use by the layer-backed drawing area.

        Fix some style issues pointed out by Dan Bernstein.

        Implement the WebChromeClient methods that pass the attach/detach calls through
        to the drawing area.

        * Shared/CoreIPCSupport/WebProcessMessageKinds.h:
        * UIProcess/API/mac/WKView.mm:
        (-[WKView _startAcceleratedCompositing:]):
        * UIProcess/API/mac/WKViewInternal.h:
        * UIProcess/WebProcessProxy.cpp:
        (WebKit::WebProcessProxy::WebProcessProxy):
        (WebKit::WebProcessProxy::setUpAcceleratedCompositing):
        * UIProcess/WebProcessProxy.h:
        * UIProcess/mac/LayerBackedDrawingAreaProxyMac.mm:
        * UIProcess/mac/WebProcessProxyMac.mm: Added.
        (WebKit::WebProcessProxy::setUpAcceleratedCompositing):
        * WebKit2.xcodeproj/project.pbxproj:
        * WebProcess/WebCoreSupport/WebChromeClient.cpp:
        (WebKit::WebChromeClient::attachRootGraphicsLayer):
        (WebKit::WebChromeClient::scheduleCompositingLayerSync):
        * WebProcess/WebPage/mac/LayerBackedDrawingAreaMac.mm:
        (WebKit::LayerBackedDrawingArea::attachCompositingContext):
        * WebProcess/WebProcess.cpp:
        (WebKit::WebProcess::WebProcess):
        (WebKit::WebProcess::didReceiveMessage):
        * WebProcess/WebProcess.h:
        (WebKit::WebProcess::compositingRenderServerPort):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago* platform/chromium/fast/dom/domListEnumeration-expected.txt: Added.
levin@chromium.org [Thu, 1 Jul 2010 23:18:57 +0000 (23:18 +0000)]
* platform/chromium/fast/dom/domListEnumeration-expected.txt: Added.
  Results differ due to a lack of a v8 binding implementation of dataset.
* platform/chromium/test_expectations.txt: Marked the dataset tests as
  failing and referred the corresponding bug for them.

Reviewed by NOBODY (test fix).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-01 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Thu, 1 Jul 2010 23:13:24 +0000 (23:13 +0000)]
2010-07-01  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Fisher.

        [Chromium] Support indeterminate checkbox for Windows
        https://bugs.webkit.org/show_bug.cgi?id=41444

        * rendering/RenderThemeChromiumWin.cpp:
        (WebCore::RenderThemeChromiumWin::determineState):
         Check isIndeterminate() and set an appropriate flag value.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=41491
weinig@apple.com [Thu, 1 Jul 2010 22:57:37 +0000 (22:57 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=41491
Add first stab at back/forward list API.

Reviewed by Anders Carlsson.

* UIProcess/API/C/WKAPICast.h:
* UIProcess/API/C/WKBackForwardList.cpp: Added.
* UIProcess/API/C/WKBackForwardList.h: Added.
* UIProcess/API/C/WKBackForwardListItem.cpp: Added.
* UIProcess/API/C/WKBackForwardListItem.h: Added.
* UIProcess/API/C/WKBase.h:
* UIProcess/API/C/WKPage.cpp:
* UIProcess/API/C/WKPage.h:
* UIProcess/API/C/WebKit2.h:
* UIProcess/WebBackForwardListItem.cpp: Added.
* UIProcess/WebBackForwardListItem.h: Added.
* UIProcess/WebBackForwardListProxy.cpp: Added.
* UIProcess/WebBackForwardListProxy.h: Added.
* UIProcess/WebPageProxy.cpp:
* UIProcess/WebPageProxy.h:
* WebKit2.xcodeproj/project.pbxproj:
* win/WebKit2.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBug 41490 - Add missing operations to MacroAssemblerARMv7
barraclough@apple.com [Thu, 1 Jul 2010 22:56:58 +0000 (22:56 +0000)]
Bug 41490 - Add missing operations to MacroAssemblerARMv7
Also, make single, double, quad register numbers in ARMv7Assembler distinct & strongly typed.

Reviewed by Oliver Hunt.

* assembler/ARMv7Assembler.h:
(JSC::ARMRegisters::):
(JSC::ARMRegisters::asSingle):
(JSC::ARMRegisters::asDouble):
(JSC::VFPImmediate::VFPImmediate):
(JSC::VFPImmediate::isValid):
(JSC::VFPImmediate::value):
(JSC::ARMv7Assembler::singleRegisterMask):
(JSC::ARMv7Assembler::doubleRegisterMask):
(JSC::ARMv7Assembler::):
(JSC::ARMv7Assembler::add_S):
(JSC::ARMv7Assembler::neg):
(JSC::ARMv7Assembler::orr_S):
(JSC::ARMv7Assembler::sub):
(JSC::ARMv7Assembler::sub_S):
(JSC::ARMv7Assembler::vadd_F64):
(JSC::ARMv7Assembler::vcmp_F64):
(JSC::ARMv7Assembler::vcvt_F64_S32):
(JSC::ARMv7Assembler::vcvtr_S32_F64):
(JSC::ARMv7Assembler::vdiv_F64):
(JSC::ARMv7Assembler::vldr):
(JSC::ARMv7Assembler::vmov_F64_0):
(JSC::ARMv7Assembler::vmov):
(JSC::ARMv7Assembler::vmul_F64):
(JSC::ARMv7Assembler::vstr):
(JSC::ARMv7Assembler::vsub_F64):
(JSC::ARMv7Assembler::vcvt):
(JSC::ARMv7Assembler::vmem):
* assembler/AbstractMacroAssembler.h:
* assembler/MacroAssemblerARM.h:
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::fpTempRegisterAsSingle):
(JSC::MacroAssemblerARMv7::neg32):
(JSC::MacroAssemblerARMv7::loadDouble):
(JSC::MacroAssemblerARMv7::divDouble):
(JSC::MacroAssemblerARMv7::convertInt32ToDouble):
(JSC::MacroAssemblerARMv7::branchConvertDoubleToInt32):
(JSC::MacroAssemblerARMv7::zeroDouble):
(JSC::MacroAssemblerARMv7::branchOr32):
(JSC::MacroAssemblerARMv7::set32):
(JSC::MacroAssemblerARMv7::set8):
* assembler/MacroAssemblerMIPS.h:
* assembler/MacroAssemblerX86Common.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake process launching asynchronous
andersca@apple.com [Thu, 1 Jul 2010 22:36:13 +0000 (22:36 +0000)]
Make process launching asynchronous
https://bugs.webkit.org/show_bug.cgi?id=41489

Reviewed by Sam Weinig.

* Platform/CoreIPC/Connection.h:
Make OutgoingMessage public.

* UIProcess/ChunkedUpdateDrawingAreaProxy.cpp:
(WebKit::ChunkedUpdateDrawingAreaProxy::paint):
Don't wait for a paint reply when the process is starting up.

* UIProcess/Launcher/ProcessLauncher.cpp: Added.
Add new ProcessLauncher class.

(WebKit::processLauncherWorkQueue):
Returns the work queue where process launching will happen.

(WebKit::ProcessLauncher::ProcessLauncher):
Schedule launching the process.

(WebKit::ProcessLauncher::didFinishLaunchingProcess):
Call the client method.

(WebKit::ProcessLauncher::invalidate):
Set the client to 0.

* UIProcess/Launcher/ProcessLauncher.h: Added.
* UIProcess/Launcher/WebProcessLauncher.h: Removed.
Rename WebProcessLauncher.h -> ProcessLauncher.h

* UIProcess/Launcher/mac/ProcessLauncherMac.mm: Added.
* UIProcess/Launcher/mac/WebProcessLauncher.mm: Removed.
Rename WebProcessLauncher.mm -> ProcessLauncherMac.mm, update for ProcessLauncher changes.

* UIProcess/Launcher/win/ProcessLauncherWin.cpp: Added.
* UIProcess/Launcher/win/WebProcessLauncher.cpp: Removed.
Rename WebProcessLauncher.cpp -> ProcessLauncherWin.cpp, update for ProcessLauncher changes.

* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::~WebProcessProxy):
Delete any unsent messages.

(WebKit::WebProcessProxy::connect):
Use the new ProcessLauncher.

(WebKit::WebProcessProxy::sendMessage):
If we're waiting for the process to launch, the messages need to be enqueued.

(WebKit::WebProcessProxy::didFinishLaunching):
Send the outgoing messages.

* WebKit2.xcodeproj/project.pbxproj:
* win/WebKit2.vcproj:
Update for renames.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Dan Bernstein.
ap@apple.com [Thu, 1 Jul 2010 22:25:01 +0000 (22:25 +0000)]
    Reviewed by Dan Bernstein.

        https://bugs.webkit.org/show_bug.cgi?id=41488
        <rdar://problem/7487420> Crash in SubresourceLoader::create when load is initiated from plug-in destructor

        Test: plugins/js-from-destroy.html

        * loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create): Null check active
        document loader.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-01 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 1 Jul 2010 22:23:37 +0000 (22:23 +0000)]
2010-07-01  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Anders Carlsson.

        Get accelerated compositing working with webkit2
        https://bugs.webkit.org/show_bug.cgi?id=41084

        Add a new kind of DrawingArea, which is a LayerBackedDrawingArea, which will be used
        when the page goes into accelerated compositing mode. It is not wired up yet.

        * Shared/CoreIPCSupport/DrawingAreaProxyMessageKinds.h: New 'attach' and 'detach' messages
        related to accelerated compositing.

        * UIProcess/API/mac/WKView.mm:
        (-[WKView _startAcceleratedCompositing:]):
        (-[WKView _stopAcceleratedCompositing]):
        * UIProcess/API/mac/WKViewInternal.h:
        Add a subview of the WKView which has layer-backing enabled, and put the drawing area's
        layer inside of that.

        * UIProcess/ChunkedUpdateDrawingAreaProxy.h:
        (WebKit::ChunkedUpdateDrawingAreaProxy::attachCompositingContext):
        (WebKit::ChunkedUpdateDrawingAreaProxy::detachCompositingContext): These methods will never be called
        on the ChunkedUpdateDrawingArea. Stub them out.

        * UIProcess/DrawingAreaProxy.h:
        Add attachCompositingContext() and detachCompositingContext() methods, and a new drawing area
        type to the enum.

        * UIProcess/LayerBackedDrawingAreaProxy.cpp: Added.
        * UIProcess/LayerBackedDrawingAreaProxy.h: Added.
        * UIProcess/mac/LayerBackedDrawingAreaProxyMac.mm: Added.

        * WebKit2.xcodeproj/project.pbxproj: Add LayerBackedDrawingArea files.

        * WebProcess/WebPage/ChunkedUpdateDrawingArea.h: Add virtual methods stubs.

        * WebProcess/WebPage/DrawingArea.cpp:
        (WebKit::DrawingArea::create): Create a LayerBackedDrawingArea if asked.
        * WebProcess/WebPage/DrawingArea.h: New LayerBackedDrawingAreaType type, and new virtual
        methods related to accelerated compositing.

        * WebProcess/WebPage/LayerBackedDrawingArea.cpp: Added.
        * WebProcess/WebPage/LayerBackedDrawingArea.h: Added.
        * WebProcess/WebPage/mac/LayerBackedDrawingAreaMac.mm: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-01 Andy Estes <aestes@apple.com>
aestes@apple.com [Thu, 1 Jul 2010 22:17:03 +0000 (22:17 +0000)]
2010-07-01  Andy Estes  <aestes@apple.com>

        Reviewed by Darin Adler.

        <rdar://problem/8113003> Correctly fire beforeload events for images
        added to the DOM using .innerHTML.
        https://bugs.webkit.org/show_bug.cgi?id=40919

        Test: fast/dom/beforeload/image-before-load-innerHTML.html

        * html/LegacyHTMLDocumentParser.cpp:
        (WebCore::LegacyHTMLDocumentParser::write): Do not fire synchronous
        image beforeload events immediately after parsing a document fragment.
        Let the events fire later, giving the fragment time to potentially be
        inserted into the document.
2010-07-01  Andy Estes  <aestes@apple.com>

        Reviewed by Darin Adler.

        <rdar://problem/8113003> Test that beforeload fires correctly on images
        inserted into the DOM using .innerHTML.
        https://bugs.webkit.org/show_bug.cgi?id=40919

        * fast/dom/beforeload/image-before-load-innerHTML-expected.txt: Added.
        * fast/dom/beforeload/image-before-load-innerHTML.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoImprove reentrancy logic in polymorphic cache stubs
oliver@apple.com [Thu, 1 Jul 2010 22:02:59 +0000 (22:02 +0000)]
Improve reentrancy logic in polymorphic cache stubs
<https://bugs.webkit.org/show_bug.cgi?id=41482>
<rdar://problem/8094380>

Reviewed by Geoff Garen.

JavaScriptCore:

Make the polymorphic cache stubs handle reentrancy
better.

* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
(JSC::getPolymorphicAccessStructureListSlot):

LayoutTests:

Test cases for cache reentry in the cache code.

* fast/js/reentrant-caching-expected.txt: Added.
* fast/js/reentrant-caching.html: Added.
* fast/js/script-tests/reentrant-caching.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-01 Andreas Kling <andreas.kling@nokia.com>
commit-queue@webkit.org [Thu, 1 Jul 2010 21:56:47 +0000 (21:56 +0000)]
2010-07-01  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Tor Arne Vestbø.

        Canvas: bezierCurveTo() and quadraticCurveTo() must ensure subpaths
        https://bugs.webkit.org/show_bug.cgi?id=41192

        Unskipped two tests:
        - canvas/philip/tests/2d.path.bezierCurveTo.ensuresubpath.2.html
        - canvas/philip/tests/2d.path.quadraticCurveTo.ensuresubpath.2.html

        fast/canvas/canvas-modify-emptyPath.html was updated to expect the new behavior.

        Spec links:
        http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-beziercurveto
        http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-quadraticcurveto

        * canvas/philip/tests/2d.path.bezierCurveTo.ensuresubpath.2-expected.txt:
        * canvas/philip/tests/2d.path.quadraticCurveTo.ensuresubpath.2-expected.txt:
        * fast/canvas/canvas-modify-emptyPath-expected.txt:
        * fast/canvas/script-tests/canvas-modify-emptyPath.js:
        * platform/mac/Skipped:
        * platform/qt/Skipped:
2010-07-01  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Tor Arne Vestbø.

        Canvas: bezierCurveTo() and quadraticCurveTo() must ensure subpaths
        https://bugs.webkit.org/show_bug.cgi?id=41192

        If the current path is empty, bezierCurveTo() and quadraticCurveTo() will now
        move to the (first) control point before adding the curve.

        Spec links:
        http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-beziercurveto
        http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-quadraticcurveto

        * html/canvas/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::quadraticCurveTo):
        (WebCore::CanvasRenderingContext2D::bezierCurveTo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-01 Andreas Kling <andreas.kling@nokia.com>
commit-queue@webkit.org [Thu, 1 Jul 2010 21:44:33 +0000 (21:44 +0000)]
2010-07-01  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Darin Adler.

        Add test for checking that canvas elements can't have a negative width or height.
        https://bugs.webkit.org/show_bug.cgi?id=39149

        Unskipped 2 canvas/philip/ tests that now pass.

        Spec link:
        http://www.whatwg.org/specs/web-apps/current-work/#attr-canvas-width

        * canvas/philip/tests/size.attributes.parse.minus-expected.txt:
        * canvas/philip/tests/size.attributes.setAttribute.minus-expected.txt:
        * fast/canvas/canvas-negative-size-expected.txt: Added.
        * fast/canvas/canvas-negative-size.html: Added.
        * fast/canvas/script-tests/canvas-negative-size.js: Added.
        (createFromMarkup):
        (trySettingWidth):
        (trySettingHeight):
        (trySettingWidthAttribute):
        (trySettingHeightAttribute):
        (tryCreatingCanvasWithWidth):
        (tryCreatingCanvasWithHeight):
        (tryWidth):
        (tryHeight):
        (checkDefaultWidth):
        (checkDefaultHeight):
        * platform/mac/Skipped:
        * platform/qt/Skipped:
2010-07-01  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Darin Adler.

        Canvas element cannot have negative width or height (HTML5 spec 4.8.11)
        https://bugs.webkit.org/show_bug.cgi?id=39149

        If assigned a negative value, it should default to 300 for width and 150 for height.

        Spec link:
        http://www.whatwg.org/specs/web-apps/current-work/#attr-canvas-width

        Test: fast/canvas/canvas-negative-size.html

        * html/HTMLCanvasElement.cpp:
        (WebCore::HTMLCanvasElement::reset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Make context menus show up in the right place in QTestBrowser
vestbo@webkit.org [Thu, 1 Jul 2010 21:02:55 +0000 (21:02 +0000)]
[Qt] Make context menus show up in the right place in QTestBrowser

Reviewed by Kenneth Rohde Christiansen.

Context menus were shown at scene-relative coordinates for
QGraphicsWebView while QMenu expects them to be global. The
change to the QWidget case was to get rid of the mapToGlobal.

* QtTestBrowser/webview.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoExport symbols on Linux with GCC, like JSC does.
tonikitoo@webkit.org [Thu, 1 Jul 2010 20:53:22 +0000 (20:53 +0000)]
Export symbols on Linux with GCC, like JSC does.

Rubberstamped by Sam Weinig.
Patch by Kenneth Christiansen <kenneth@webkit.org>

* UIProcess/API/C/WKBase.h:
* WebProcess/InjectedBundle/API/c/WKBundleBase.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-01 Robert Hogan <robert@webkit.org>
robert@webkit.org [Thu, 1 Jul 2010 20:53:12 +0000 (20:53 +0000)]
2010-07-01  Robert Hogan <robert@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] dump frames in ascending alphabetical order of title

        https://bugs.webkit.org/show_bug.cgi?id=41261

        Unskip:
        http/tests/navigation/metaredirect-frames.html
        http/tests/navigation/redirect302-frames.html
        http/tests/navigation/redirect302-subframeload.html
        http/tests/navigation/timerredirect-frames.html

        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
        (DumpRenderTreeSupportQt::getChildHistoryItems):
        * WebCoreSupport/DumpRenderTreeSupportQt.h:
        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        (WebCore::dumpHistoryItem):
        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoInitial WebKit2 implementation https://bugs.webkit.org/show_bug.cgi?id=40233
tonikitoo@webkit.org [Thu, 1 Jul 2010 20:44:53 +0000 (20:44 +0000)]
Initial WebKit2 implementation https://bugs.webkit.org/show_bug.cgi?id=40233

Reviewed by Antti Koivisto.
Patch by Kenneth Christiansen <kenneth@webkit.org>

Add implementation of the UI and loader client for Qt.

* UIProcess/API/qt/qwkpage.cpp:
* UIProcess/API/qt/ClientImpl.cpp: Added.
(toQWKPage):
(qt_wk_didStartProvisionalLoadForFrame):
(qt_wk_didReceiveServerRedirectForProvisionalLoadForFrame):
(qt_wk_didFailProvisionalLoadWithErrorForFrame):
(qt_wk_didCommitLoadForFrame):
(qt_wk_didFinishLoadForFrame):
(qt_wk_didFailLoadWithErrorForFrame):
(qt_wk_didReceiveTitleForFrame):
(qt_wk_didFirstLayoutForFrame):
(qt_wk_didFirstVisuallyNonEmptyLayoutForFrame):
(qt_wk_didStartProgress):
(qt_wk_didChangeProgress):
(qt_wk_didFinishProgress):
(qt_wk_didBecomeUnresponsive):
(qt_wk_didBecomeResponsive):
(qt_wk_createNewPage):
(qt_wk_showPage):
(qt_wk_close):
(qt_wk_runJavaScriptAlert):
* UIProcess/API/qt/ClientImpl.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed more ChangeLog mess up fix caused by bad resolve-ChangeLogs merges.
tonikitoo@webkit.org [Thu, 1 Jul 2010 20:37:17 +0000 (20:37 +0000)]
Unreviewed more ChangeLog mess up fix caused by bad resolve-ChangeLogs merges.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-01 Kinuko Yasuda <kinuko@chromium.org>
kinuko@chromium.org [Thu, 1 Jul 2010 20:21:51 +0000 (20:21 +0000)]
2010-07-01  Kinuko Yasuda  <kinuko@chromium.org>

        Unreviewed. Update chromium tests expectations for flaky tests.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed ChangeLog mess up fix cause by bad resolve-ChangeLogs merges.
tonikitoo@webkit.org [Thu, 1 Jul 2010 20:13:09 +0000 (20:13 +0000)]
Unreviewed ChangeLog mess up fix cause by bad resolve-ChangeLogs merges.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTurn on adoptRef assertion for TreeShared.
darin@apple.com [Thu, 1 Jul 2010 20:10:25 +0000 (20:10 +0000)]
Turn on adoptRef assertion for TreeShared.

Reviewed by Steve Falkenburg.

* platform/TreeShared.h: Remove LOOSE_TREE_SHARED and all the ifdefs.
Actually, I used LOOSE_REF_COUNTED by accident in a few places, but
removing them all now.

* rendering/ShadowElement.cpp:
(WebCore::ShadowBlockElement::create): Added adoptRef. This was a
storage leak before, probably recently introduced r61324.
(WebCore::ShadowInputElement::create): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-01 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 1 Jul 2010 20:04:18 +0000 (20:04 +0000)]
2010-07-01  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Change the CoreIPC connection identifier to be a HANDLE on Windows
        https://bugs.webkit.org/show_bug.cgi?id=41479

        * Platform/CoreIPC/Connection.h:
        * Platform/CoreIPC/win/ConnectionWin.cpp:
        (CoreIPC::Connection::createServerAndClientIdentifiers):
        New function that creates a server and client HANDLE.

        (CoreIPC::Connection::platformInitialize):
        Don't open the connections here.

        (CoreIPC::Connection::readEventHandler):
        (CoreIPC::Connection::open):

        * UIProcess/Launcher/win/WebProcessLauncher.cpp:
        (WebKit::webThreadBody):
        Get the handle from the thread.

        (WebKit::launchWebProcess):
        Mark the client identifier as inheritable and pass it along to the web process.

        * WebProcess/win/WebProcessMain.cpp:
        (WebKit::CommandLine::CommandLine):
        (WebKit::CommandLine::parse):
        (WebKit::CommandLine::operator[]):
        Add simple command line parser.

        (WebKit::WebProcessMain):
        Get the handle identifier from the command line.

        * WebProcess/win/WebProcessMain.h:

* WebKit.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Doc improvements for QDeclarativeWebView
hausmann@webkit.org [Thu, 1 Jul 2010 20:00:42 +0000 (20:00 +0000)]
[Qt] Doc improvements for QDeclarativeWebView

Patch by Bea Lam <bea.lam@nokia.com> on 2010-07-01
Reviewed by Simon Hausmann.

* declarative/qdeclarativewebview.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-01 Kenneth Russell <kbr@google.com>
kbr@google.com [Thu, 1 Jul 2010 19:44:46 +0000 (19:44 +0000)]
2010-07-01  Kenneth Russell  <kbr@google.com>

        Reviewed by Dimitri Glazkov.

        Stop linking against opengl32.lib in Windows Chromium port
        https://bugs.webkit.org/show_bug.cgi?id=41424

        * WebKit.gyp:
        * src/WebGraphicsContext3DDefaultImpl.cpp:
        (WebKit::WebGraphicsContext3DDefaultImpl::~WebGraphicsContext3DDefaultImpl):
        (WebKit::WebGraphicsContext3DDefaultImpl::initialize):
        (WebKit::WebGraphicsContext3DDefaultImpl::makeContextCurrent):
        * src/WebGraphicsContext3DDefaultImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoInitial WebKit2 implementation https://bugs.webkit.org/show_bug.cgi?id=40233
tonikitoo@webkit.org [Thu, 1 Jul 2010 19:44:22 +0000 (19:44 +0000)]
Initial WebKit2 implementation https://bugs.webkit.org/show_bug.cgi?id=40233

Reviewed by Antti Koivisto.
Patch by Kenneth Christiansen <kenneth@webkit.org>

Add initial Qt API for WebKit2

* UIProcess/API/qt/WKView.h: Added.
* UIProcess/API/qt/qgraphicswkview.cpp: Added.
(QGraphicsWKViewPrivate::pageRef):
(QGraphicsWKView::QGraphicsWKView):
(QGraphicsWKView::~QGraphicsWKView):
(QGraphicsWKView::page):
(QGraphicsWKView::paint):
(QGraphicsWKView::setGeometry):
(QGraphicsWKView::load):
(QGraphicsWKView::setUrl):
(QGraphicsWKView::url):
(QGraphicsWKView::title):
(QGraphicsWKView::triggerPageAction):
(QGraphicsWKView::back):
(QGraphicsWKView::forward):
(QGraphicsWKView::reload):
(QGraphicsWKView::stop):
(QGraphicsWKView::itemChange):
(QGraphicsWKView::event):
(QGraphicsWKView::sizeHint):
(QGraphicsWKView::inputMethodQuery):
(QGraphicsWKView::keyPressEvent):
(QGraphicsWKView::keyReleaseEvent):
(QGraphicsWKView::hoverMoveEvent):
(QGraphicsWKView::mouseMoveEvent):
(QGraphicsWKView::mousePressEvent):
(QGraphicsWKView::mouseReleaseEvent):
(QGraphicsWKView::mouseDoubleClickEvent):
(QGraphicsWKView::wheelEvent):
(QGraphicsWKViewPrivate::QGraphicsWKViewPrivate):
(QGraphicsWKView::visibleRect):
* UIProcess/API/qt/qgraphicswkview.h: Added.
* UIProcess/API/qt/qwkpage.cpp: Added.
(QWKPagePrivate::QWKPagePrivate):
(QWKPagePrivate::~QWKPagePrivate):
(QWKPagePrivate::init):
(QWKPagePrivate::toolTipChanged):
(QWKPagePrivate::paint):
(QWKPagePrivate::keyPressEvent):
(QWKPagePrivate::keyReleaseEvent):
(QWKPagePrivate::mouseMoveEvent):
(QWKPagePrivate::mousePressEvent):
(QWKPagePrivate::mouseReleaseEvent):
(QWKPagePrivate::mouseDoubleClickEvent):
(QWKPagePrivate::wheelEvent):
(QWKPagePrivate::updateAction):
(QWKPagePrivate::updateNavigationActions):
(QWKPagePrivate::_q_webActionTriggered):
(QWKPage::QWKPage):
(QWKPage::~QWKPage):
(QWKPage::pageRef):
(QWKPage::setCreateNewPageFunction):
(QWKPage::load):
(QWKPage::setUrl):
(QWKPage::url):
(QWKPage::title):
(QWKPage::setViewportSize):
(QWKPage::requestZoomRect):
(QWKPage::triggerAction):
(QWKPage::action):
* UIProcess/API/qt/qwkpage.h: Added.
* UIProcess/API/qt/qwkpage_p.h: Added.
(QWKPagePrivate::get):
(QWKPagePrivate::processDidExit):
(QWKPagePrivate::processDidRevive):
(QWKPagePrivate::takeFocus):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-01 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 1 Jul 2010 19:38:21 +0000 (19:38 +0000)]
2010-07-01  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler.

        Get accelerated compositing working with webkit2
        https://bugs.webkit.org/show_bug.cgi?id=41084

        Step 2: add a  method, syncCompositingStateForThisLayerOnly(), to GraphicsLayer to commit
        batched changes non-recursively. This allows us to use GraphicsLayer in places where we
        don't want to kick off a recursive commit of the entire tree.

        * platform/graphics/GraphicsLayer.h:
        (WebCore::GraphicsLayer::syncCompositingStateForThisLayerOnly):
        * platform/graphics/mac/GraphicsLayerCA.h:
        * platform/graphics/mac/GraphicsLayerCA.mm:
        (WebCore::GraphicsLayerCA::syncCompositingStateForThisLayerOnly):
        * WebCore.AcceleratedCompositing.exp: Export the new method for use in WebKit2.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-01 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Thu, 1 Jul 2010 19:34:26 +0000 (19:34 +0000)]
2010-07-01  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        Only include the geolocation IDL in the GObject DOM bindings set
        if geolocation is enabled.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoProvide a WebView preference to disable DNS prefetching.
timothy@apple.com [Thu, 1 Jul 2010 19:32:15 +0000 (19:32 +0000)]
Provide a WebView preference to disable DNS prefetching.

https://bugs.webkit.org/show_bug.cgi?id=28825
rdar://problem/7181249

Reviewed by Darin Adler.

WebCore:

* WebCore.base.exp: Added Settings::setDNSPrefetchingEnabled.
* dom/Document.cpp:
(WebCore::Document::initDNSPrefetch): Check settings->dnsPrefetchingEnabled().
* page/Settings.cpp:
(WebCore::Settings::Settings): Set m_dnsPrefetchingEnabled to true.
(WebCore::Settings::setDNSPrefetchingEnabled): Added. Set m_dnsPrefetchingEnabled.
* page/Settings.h:
(WebCore::Settings::dnsPrefetchingEnabled): Added. Return m_dnsPrefetchingEnabled.

WebKit/mac:

* WebView/WebPreferenceKeysPrivate.h: Added WebKitDNSPrefetchingEnabledPreferenceKey.
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]): Set WebKitDNSPrefetchingEnabledPreferenceKey to YES.
(-[WebPreferences isDNSPrefetchingEnabled]): Added. Return WebKitDNSPrefetchingEnabledPreferenceKey's value.
(-[WebPreferences setDNSPrefetchingEnabled:]): Added. Set WebKitDNSPrefetchingEnabledPreferenceKey's value.
* WebView/WebPreferencesPrivate.h: Added isDNSPrefetchingEnabled and setDNSPrefetchingEnabled:.
* WebView/WebView.mm:
(-[WebView _preferencesChangedNotification:]): Call WebCore::Settings::setDNSPrefetchingEnabled.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-01 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 1 Jul 2010 19:30:02 +0000 (19:30 +0000)]
2010-07-01  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Sam Weinig.

        Get accelerated compositing working with webkit2
        https://bugs.webkit.org/show_bug.cgi?id=41084

        Step 1: add a new .exp file for WebCore, which exports symbols only when USE(ACCELERATED_COMPOSITING)
        is defined.

        Also export WebCore::FloatSize::FloatSize(WebCore::IntSize const&) from WebCore.

        * DerivedSources.make:
        * WebCore.AcceleratedCompositing.exp: Added.
        * WebCore.base.exp:
        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-01 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 1 Jul 2010 19:23:28 +0000 (19:23 +0000)]
2010-07-01  Martin Robinson  <mrobinson@igalia.com>

        Unreviewed.

        Fix the GTK+ build after r62278.

        * Scripts/webkitdirs.pm: If the make arguments have already been specified,
        let them override the automatic CPU detection for autotools builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago* mac/WebKit2.exp:
sullivan@apple.com [Thu, 1 Jul 2010 19:14:38 +0000 (19:14 +0000)]
* mac/WebKit2.exp:
Added _WKFramePolicyListenerDownload and _WKFramePolicyListenerIgnore.

Rubber-stamped by Anders Carlsson.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-01 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 1 Jul 2010 19:12:48 +0000 (19:12 +0000)]
2010-07-01  Martin Robinson  <mrobinson@igalia.com>

        Unreviewed.

        Fix the Windows build after r62278.

        * Scripts/num-cpus: Use FindBin to add the Scripts directory to the list of library directories.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore:
ap@apple.com [Thu, 1 Jul 2010 18:47:57 +0000 (18:47 +0000)]
WebCore:
        Reviewed by Darin Adler.

        <rdar://problem/8148656> <https://bugs.webkit.org/show_bug.cgi?id=41431>
        REGRESSION (r49411): Various crashes due to JavaScript execution during plug-in destruction

        Test: plugins/write-xssauditor-from-destroy.html

        Fix specific known cases that also crash in same process case. I don't know if there is
        any rule for when documentLoader should be checked for being null, it looks like a mess.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::referrer):
        * page/XSSAuditor.cpp:
        (WebCore::XSSAuditor::findInRequest):

WebKit:

        <rdar://problem/8148656> <https://bugs.webkit.org/show_bug.cgi?id=41431>
        REGRESSION (r49411): Various crashes due to JavaScript execution during plug-in destruction

        Strengthen m_inDestroy "swipe under the carpet" fix.

        * Plugins/Hosted/NetscapePluginInstanceProxy.h: Added a long comment about m_inDestroy, and
        changed it to static.

        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy): m_inDestroy is now
        static, so we don't initialize it in constructor.
        (WebKit::NetscapePluginInstanceProxy::destroy): Assert that we aren't already destroying
        some plug-in.
        (WebKit::NetscapePluginInstanceProxy::evaluate): This function accidentally lacked an
        m_inDestroy check in r42789.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-01 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 1 Jul 2010 18:42:58 +0000 (18:42 +0000)]
2010-07-01  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] build-webkit does not detect the number of CPUs
        https://bugs.webkit.org/show_bug.cgi?id=41469

        Pass the appropriate -j<#> flag to make when building autotools builds.
        This causes make to spawn that many number of child processes for doing
        parallel builds.

        * Scripts/num-cpus: Use the newly abstracted numberOfCPUs to return the number
        of CPUs. This makes the script work across more platforms.
        * Scripts/webkitdirs.pm: Create a numberOfCPUs/determineNumberOfCPUs to determine the
        number of CPUs across several platforms. Use this new function to determine the appropriate
        arguments to pass to make for doing parallel builds with autotools build files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-01 Andreas Kling <andreas.kling@nokia.com>
commit-queue@webkit.org [Thu, 1 Jul 2010 18:42:55 +0000 (18:42 +0000)]
2010-07-01  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Darin Adler.

        The HTML5 canvas 2d.drawImage.zerocanvas test does not pass
        https://bugs.webkit.org/show_bug.cgi?id=40271

        Unskipped canvas/philip/tests/2d.drawImage.zerocanvas.html

        * canvas/philip/tests/2d.drawImage.zerocanvas-expected.txt:
        * platform/mac/Skipped:
        * platform/qt/Skipped:
2010-07-01  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Darin Adler.

        The HTML5 canvas 2d.drawImage.zerocanvas test does not pass
        https://bugs.webkit.org/show_bug.cgi?id=40271

        Throw INVALID_STATE_ERR when attempting to draw a canvas with zero width or height.

        Spec link:
        http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-drawimage

        * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
        (WebCore::JSCanvasRenderingContext2D::drawImage): Call setDOMException after drawImage(canvas, x, y)
        * html/canvas/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::drawImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-01 Andreas Kling <andreas.kling@nokia.com>
commit-queue@webkit.org [Thu, 1 Jul 2010 18:28:23 +0000 (18:28 +0000)]
2010-07-01  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Oliver Hunt.

        [Qt] Canvas: clip() should use non-zero winding rule
        https://bugs.webkit.org/show_bug.cgi?id=41466

        Use non-zero winding number rule when clipping a GraphicsContext from canvas.
        Fixes appearance of the "pill" in the web inspector.

        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::canvasClip):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-01 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Thu, 1 Jul 2010 17:45:32 +0000 (17:45 +0000)]
2010-07-01  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed. Update Chromium test expectations for svg/W3C-SVG-1.1/filters-conv-01-f.svg
        which is timing out on Linux and Windows.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-01 Sheriff Bot <webkit.review.bot@gmail.com>
yurys@chromium.org [Thu, 1 Jul 2010 17:40:35 +0000 (17:40 +0000)]
2010-07-01  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r62246.
        http://trac.webkit.org/changeset/62246
        https://bugs.webkit.org/show_bug.cgi?id=41470

        "Worker tests are broken in Chromium" (Requested by yurys on
        #webkit).

        * fast/events/popup-blocked-from-fake-user-gesture-expected.txt: Removed.
        * fast/events/popup-blocked-from-fake-user-gesture.html: Removed.
        * http/tests/inspector/change-iframe-src-expected.txt: Removed.
        * http/tests/inspector/change-iframe-src.html: Removed.
2010-07-01  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r62246.
        http://trac.webkit.org/changeset/62246
        https://bugs.webkit.org/show_bug.cgi?id=41470

        "Worker tests are broken in Chromium" (Requested by yurys on
        #webkit).

        * bindings/v8/ScriptController.cpp:
        (WebCore::ScriptController::processingUserGesture):
        * bindings/v8/V8AbstractEventListener.cpp:
        (WebCore::V8AbstractEventListener::invokeEventHandler):
        * bindings/v8/V8HiddenPropertyName.h:
        * bindings/v8/custom/V8DOMWindowCustom.cpp:
        (WebCore::V8DOMWindow::eventAccessorGetter):
        (WebCore::V8DOMWindow::eventAccessorSetter):
2010-07-01  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r62246.
        http://trac.webkit.org/changeset/62246
        https://bugs.webkit.org/show_bug.cgi?id=41470

        "Worker tests are broken in Chromium" (Requested by yurys on
        #webkit).

        * src/WebBindings.cpp:
        (WebKit::getEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-01 Andreas Kling <andreas.kling@nokia.com>
commit-queue@webkit.org [Thu, 1 Jul 2010 17:29:31 +0000 (17:29 +0000)]
2010-07-01  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Tor Arne Vestbø.

        Canvas: Exception erroneously thrown for drawImage() when image.complete=false
        https://bugs.webkit.org/show_bug.cgi?id=33968

        Added a test to verify that CRC2D does nothing when calling drawImage()
        with an incomplete image or video.

        Spec link:
        http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-drawimage

        * fast/canvas/canvas-drawImage-incomplete-expected.txt: Added.
        * fast/canvas/canvas-drawImage-incomplete.html: Added.
        * fast/canvas/script-tests/canvas-drawImage-incomplete.js: Added.
2010-07-01  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Tor Arne Vestbø.

        Canvas: Exception erroneously thrown for drawImage() when image.complete=false
        https://bugs.webkit.org/show_bug.cgi?id=33968

        Do nothing in drawImage() if called with an image whose 'complete'
        attribute is false, or a video whose readyState is either HAVE_NOTHING
        or HAVE_METADATA.

        Spec link:
        http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-drawimage

        Test: fast/canvas/canvas-drawImage-incomplete.html

        * html/canvas/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::drawImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-01 David Holloway <dhollowa@chromium.org>
commit-queue@webkit.org [Thu, 1 Jul 2010 17:14:53 +0000 (17:14 +0000)]
2010-07-01  David Holloway  <dhollowa@chromium.org>

        Reviewed by Darin Fisher.

        [chromium] Consolidates AutoFill and Autocomplete popup menus into a single popup menu.

        This change combines SuggestionsPopupMenuClient, AutoFillPopupMenuClient, and
        AutocompletePopupMenuClient classes into a single consolidated AutoFillPopupMenuClient class.
        Prior to this change the contents of the AutoFill popup menu only included AutoFill
        suggestions and similarly the Autocomplete popup menu only included Autocomplete
        suggestions.  With this consolidation, both AutoFill and Autocomplete suggestions can
        now be displayed in a single menu.

        https://bugs.webkit.org/show_bug.cgi?id=41236

        * WebKit.gyp:
        * public/WebFrame.h:
        * public/WebView.h:
        * src/AutoFillPopupMenuClient.cpp:
        (WebKit::AutoFillPopupMenuClient::AutoFillPopupMenuClient):
        (WebKit::AutoFillPopupMenuClient::~AutoFillPopupMenuClient):
        (WebKit::AutoFillPopupMenuClient::valueChanged):
        (WebKit::AutoFillPopupMenuClient::selectionCleared):
        (WebKit::AutoFillPopupMenuClient::itemText):
        (WebKit::AutoFillPopupMenuClient::itemStyle):
        (WebKit::AutoFillPopupMenuClient::menuStyle):
        (WebKit::AutoFillPopupMenuClient::clientPaddingLeft):
        (WebKit::AutoFillPopupMenuClient::clientPaddingRight):
        (WebKit::AutoFillPopupMenuClient::popupDidHide):
        (WebKit::AutoFillPopupMenuClient::setTextFromItem):
        (WebKit::AutoFillPopupMenuClient::fontSelector):
        (WebKit::AutoFillPopupMenuClient::hostWindow):
        (WebKit::AutoFillPopupMenuClient::createScrollbar):
        (WebKit::AutoFillPopupMenuClient::initialize):
        (WebKit::AutoFillPopupMenuClient::getWebView):
        (WebKit::AutoFillPopupMenuClient::textFieldStyle):
        * src/AutoFillPopupMenuClient.h:
        (WebKit::AutoFillPopupMenuClient::itemToolTip):
        (WebKit::AutoFillPopupMenuClient::itemAccessibilityText):
        (WebKit::AutoFillPopupMenuClient::itemIsEnabled):
        (WebKit::AutoFillPopupMenuClient::clientInsetLeft):
        (WebKit::AutoFillPopupMenuClient::clientInsetRight):
        (WebKit::AutoFillPopupMenuClient::listSize):
        (WebKit::AutoFillPopupMenuClient::selectedIndex):
        (WebKit::AutoFillPopupMenuClient::itemIsLabel):
        (WebKit::AutoFillPopupMenuClient::itemIsSelected):
        (WebKit::AutoFillPopupMenuClient::shouldPopOver):
        (WebKit::AutoFillPopupMenuClient::valueShouldChangeOnHotTrack):
        (WebKit::AutoFillPopupMenuClient::setAutocompleteMode):
        (WebKit::AutoFillPopupMenuClient::getTextField):
        (WebKit::AutoFillPopupMenuClient::getSelectedIndex):
        (WebKit::AutoFillPopupMenuClient::setSelectedIndex):
        * src/AutocompletePopupMenuClient.cpp: Removed.
        * src/AutocompletePopupMenuClient.h: Removed.
        * src/EditorClientImpl.cpp:
        (WebKit::EditorClientImpl::textFieldDidEndEditing):
        (WebKit::EditorClientImpl::doAutofill):
        (WebKit::EditorClientImpl::onAutocompleteSuggestionAccepted):
        * src/SuggestionsPopupMenuClient.cpp: Removed.
        * src/SuggestionsPopupMenuClient.h: Removed.
        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::currentHistoryItem):
        (WebKit::WebFrameImpl::notifiyPasswordListenerOfAutocomplete):
        * src/WebFrameImpl.h:
        * src/WebViewImpl.cpp:
        (WebKit::):
        (WebKit::WebViewImpl::WebViewImpl):
        (WebKit::WebViewImpl::mouseDown):
        (WebKit::WebViewImpl::mouseUp):
        (WebKit::WebViewImpl::selectPopupHandleKeyEvent):
        (WebKit::WebViewImpl::autocompleteHandleKeyEvent):
        (WebKit::WebViewImpl::hideAutoFillPopup):
        (WebKit::WebViewImpl::setFocus):
        (WebKit::WebViewImpl::applyAutoFillSuggestions):
        (WebKit::WebViewImpl::applyAutocompleteSuggestions):
        (WebKit::WebViewImpl::hidePopups):
        (WebKit::WebViewImpl::refreshAutoFillPopup):
        * src/WebViewImpl.h:
        (WebKit::WebViewImpl::autoFillPopupDidHide):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-01 Justin Schuh <jschuh@chromium.org>
jschuh@chromium.org [Thu, 1 Jul 2010 16:55:06 +0000 (16:55 +0000)]
2010-07-01  Justin Schuh  <jschuh@chromium.org>

        Reviewed by Dan Bernstein.

        Prevent crash on counter destruction
        https://bugs.webkit.org/show_bug.cgi?id=40032

        Added counter destruction to RenderWidget::destroy()

        Test: fast/css/counters/destroy-counter-crash.html

        * rendering/RenderWidget.cpp:
        (WebCore::RenderWidget::destroy):
2010-07-01  Justin Schuh  <jschuh@chromium.org>

        Reviewed by Dan Bernstein.

        Prevent crash on counter destruction
        https://bugs.webkit.org/show_bug.cgi?id=40032

        * fast/css/counters/destroy-counter-crash-expected.txt: Added.
        * fast/css/counters/destroy-counter-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-01 Sheriff Bot <webkit.review.bot@gmail.com>
weinig@apple.com [Thu, 1 Jul 2010 16:41:03 +0000 (16:41 +0000)]
2010-07-01  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r62267.
        http://trac.webkit.org/changeset/62267
        https://bugs.webkit.org/show_bug.cgi?id=41468

        broke stuff (Requested by weinig on #webkit).

        * UIProcess/API/C/WKBase.h:
        * WebProcess/InjectedBundle/API/c/WKBundleBase.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-01 Lucas De Marchi <lucas.demarchi@profusion.mobi>
leandro@webkit.org [Thu, 1 Jul 2010 16:26:25 +0000 (16:26 +0000)]
2010-07-01  Lucas De Marchi  <lucas.demarchi@profusion.mobi>

        Unreviewed build fix after r62215.

        No new functionality, so no new tests.

        * CMakeLists.txt: Add missing files and re-sort.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago* mac/WebKit2.exp:
sullivan@apple.com [Thu, 1 Jul 2010 16:25:03 +0000 (16:25 +0000)]
* mac/WebKit2.exp:
Added _WKFramePolicyListenerRelease and _WKFramePolicyListenerRetain.

Rubber-stamped by Sam Weinig.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-01 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
commit-queue@webkit.org [Thu, 1 Jul 2010 16:16:47 +0000 (16:16 +0000)]
2010-07-01  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>

        Reviewed by Antti Koivisto.

        Export symbols on Linux with GCC

        * UIProcess/API/C/WKBase.h:
        * WebProcess/InjectedBundle/API/c/WKBundleBase.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Fix a comment in WebKit.pri.
jocelyn.turcotte@nokia.com [Thu, 1 Jul 2010 16:10:46 +0000 (16:10 +0000)]
[Qt] Fix a comment in WebKit.pri.

Reviewed by Simon Hausmann.

* WebKit.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Remove an unneeded assert.
jocelyn.turcotte@nokia.com [Thu, 1 Jul 2010 16:09:53 +0000 (16:09 +0000)]
[Qt] Remove an unneeded assert.

Reviewed by Kenneth Rohde Christiansen.

This assert is triggered for example while showing the falling leaves demo.
GraphicsLayerQtImpl::toGraphicsLayerQtImpl asserts that its input
pointer is null. Looking at the uses of this method it seems like
it is expected to return null if a null pointer is given to it.

* platform/graphics/qt/GraphicsLayerQt.cpp:
(WebCore::toGraphicsLayerQtImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Fix qmake vcproj generation for QtWebKit.
jocelyn.turcotte@nokia.com [Thu, 1 Jul 2010 16:08:50 +0000 (16:08 +0000)]
[Qt] Fix qmake vcproj generation for QtWebKit.

Reviewed by Simon Hausmann.

qmake use TARGET=/LIBS+= -lTARGET to create dependencies
between projects in a subdir template.

Since when compiling outside of Qt we hijack the target name of
QtWebKit to add the configuration and version suffix to the binary
filename, qmake can't establish the WebCore project as a dependency
to QtTestBrowser.

This patch makes sure that the target is not hijacked on the
first of the three passes where the dependencies are determined.

.:

* WebKit.pri:

WebCore:

* WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-01 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
commit-queue@webkit.org [Thu, 1 Jul 2010 16:04:45 +0000 (16:04 +0000)]
2010-07-01  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>

        Reviewed by Antti Koivisto.

        [Qt] Initial WebKit2 implementation
        https://bugs.webkit.org/show_bug.cgi?id=40233

        Add our event factory for converting Qt events to something WebKit2
        understands.

        * Shared/qt/WebEventFactoryQt.cpp: Added.
        (WebKit::mouseButtonForEvent):
        (WebKit::webEventTypeForEvent):
        (WebKit::modifiersForEvent):
        (WebKit::WebEventFactory::createWebMouseEvent):
        (WebKit::WebEventFactory::createWebWheelEvent):
        (WebKit::WebEventFactory::createWebKeyboardEvent):
        * Shared/qt/WebEventFactoryQt.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-01 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 1 Jul 2010 16:03:05 +0000 (16:03 +0000)]
2010-07-01  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Convert WebKitWebView's private draggingDataObjects member to a pointer
        https://bugs.webkit.org/show_bug.cgi?id=40333

        Convert draggingDataObjects to a pointer. The constructor and destructor of the
        HashMap should be called explicitly. GObject memory allocation does not do this.

        * WebCoreSupport/DragClientGtk.cpp:
        (WebKit::DragClient::startDrag):
        * webkit/webkitprivate.h:
        * webkit/webkitwebview.cpp:
        (webkit_web_view_dispose):
        (webkit_web_view_drag_end):
        (webkit_web_view_drag_data_get):
        (webkit_web_view_init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Initial WebKit2 implementation
antti.j.koivisto@nokia.com [Thu, 1 Jul 2010 15:27:01 +0000 (15:27 +0000)]
[Qt] Initial WebKit2 implementation
https://bugs.webkit.org/show_bug.cgi?id=40233

Reviewed by Kenneth Rohde Christiansen.

Add UpdateChunk. This one is mmap based, using Qt abstractions.

* Shared/qt: Added.
* Shared/qt/UpdateChunk.cpp: Added.
(WebKit::MappedMemory::markUsed):
(WebKit::MappedMemory::markFree):
(WebKit::MappedMemory::isFree):
(WebKit::mapMemory):
(WebKit::mapFile):
(WebKit::UpdateChunk::UpdateChunk):
(WebKit::UpdateChunk::~UpdateChunk):
(WebKit::UpdateChunk::data):
(WebKit::UpdateChunk::encode):
(WebKit::UpdateChunk::decode):
(WebKit::UpdateChunk::createImage):
* Shared/qt/UpdateChunk.h: Added.
(WebKit::UpdateChunk::rect):
(WebKit::UpdateChunk::size):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Initial WebKit2 implementation
antti.j.koivisto@nokia.com [Thu, 1 Jul 2010 14:36:56 +0000 (14:36 +0000)]
[Qt] Initial WebKit2 implementation
https://bugs.webkit.org/show_bug.cgi?id=40233

Reviewed by Kenneth Rohde Christiansen.

Include some stdlib headers to fix linux build.

* Platform/CoreIPC/ArgumentDecoder.cpp:
* Platform/CoreIPC/ArgumentEncoder.cpp:
* UIProcess/WebLoaderClient.cpp:
* UIProcess/WebPageProxy.cpp:
* UIProcess/WebUIClient.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-01 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Thu, 1 Jul 2010 14:25:42 +0000 (14:25 +0000)]
2010-07-01  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        SVGRenderStyle::diff() is missing
        https://bugs.webkit.org/show_bug.cgi?id=41455

        Don't just return StyleDifferenceLayout when two SVGRenderStyle objects differ.
        Figure out when to repaint, and as last resort do a relayout.

        Lively Kernel doesn't do any relayouts anymore, same for lots of demos in the IE9 testcenter.

        * rendering/style/RenderStyle.cpp:
        (WebCore::RenderStyle::diff):
        * rendering/style/SVGRenderStyle.cpp:
        (WebCore::SVGRenderStyle::diff):
        * rendering/style/SVGRenderStyle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-01 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Thu, 1 Jul 2010 14:16:56 +0000 (14:16 +0000)]
2010-07-01  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed. Update Chromium test expectations.

        * platform/chromium-mac/html5lib/runner-expected.txt:
        * platform/chromium-mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.checksum: Added.
        * platform/chromium-mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Initial WebKit2 implementation
antti.j.koivisto@nokia.com [Thu, 1 Jul 2010 13:49:48 +0000 (13:49 +0000)]
[Qt] Initial WebKit2 implementation
https://bugs.webkit.org/show_bug.cgi?id=40233

Reviewed by Kenneth Rohde Christiansen.

Implement CoreIPC::Connection and PlatformProcessIdentifier for Qt. Not built yet.

* Platform/CoreIPC/Connection.h:
* Platform/CoreIPC/qt: Added.
* Platform/CoreIPC/qt/ConnectionQt.cpp: Added.
(CoreIPC::Connection::platformInitialize):
(CoreIPC::Connection::platformInvalidate):
(CoreIPC::Connection::newConnectionHandler):
(CoreIPC::Connection::readyReadHandler):
(CoreIPC::Connection::openConnection):
(CoreIPC::Connection::open):
(CoreIPC::Connection::sendOutgoingMessage):
* Platform/PlatformProcessIdentifier.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Initial WebKit2 implementation
antti.j.koivisto@nokia.com [Thu, 1 Jul 2010 13:18:31 +0000 (13:18 +0000)]
[Qt] Initial WebKit2 implementation
https://bugs.webkit.org/show_bug.cgi?id=40233

Reviewed by Kenneth Rohde Christiansen.

Implement WorkQueue for Qt. Not built yet.

* Platform/WorkQueue.h:
* Platform/qt/WorkQueueQt.cpp: Added.
(WorkQueue::WorkItemQt::WorkItemQt):
(WorkQueue::WorkItemQt::~WorkItemQt):
(WorkQueue::WorkItemQt::execute):
(WorkQueue::WorkItemQt::timerEvent):
(WorkQueue::connectSignal):
(WorkQueue::disconnectSignal):
(WorkQueue::platformInitialize):
(WorkQueue::platformInvalidate):
(WorkQueue::scheduleWork):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-01 Satish Sampath <satish@chromium.org>
yurys@chromium.org [Thu, 1 Jul 2010 13:10:04 +0000 (13:10 +0000)]
2010-07-01  Satish Sampath  <satish@chromium.org>

        Reviewed by Yury Semikhatsky.

        Fix wrong style comment in chromium test expectations file.
        https://bugs.webkit.org/show_bug.cgi?id=41460

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRevert accidental commit.
antti.j.koivisto@nokia.com [Thu, 1 Jul 2010 12:49:27 +0000 (12:49 +0000)]
Revert accidental commit.

JavaScriptCore:

* runtime/Collector.cpp:
(JSC::Heap::allocateBlock):

WebCore:

* platform/network/qt/ResourceRequestQt.cpp:
(WebCore::ResourceRequest::toNetworkRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Initial WebKit2 implementation
antti.j.koivisto@nokia.com [Thu, 1 Jul 2010 12:42:54 +0000 (12:42 +0000)]
[Qt] Initial WebKit2 implementation
https://bugs.webkit.org/show_bug.cgi?id=40233

Reviewed by Kenneth Rohde Christiansen.

Implement RunLoop for Qt. Not built yet.

* Platform/RunLoop.h:
* Platform/qt: Added.
* Platform/qt/RunLoopQt.cpp: Added.
(RunLoop::TimerObject::TimerObject):
(RunLoop::TimerObject::performWork):
(RunLoop::TimerObject::wakeUp):
(RunLoop::TimerObject::timerEvent):
(RunLoop::run):
(RunLoop::stop):
(RunLoop::RunLoop):
(RunLoop::~RunLoop):
(RunLoop::wakeUp):
(RunLoop::TimerBase::timerFired):
(RunLoop::TimerBase::TimerBase):
(RunLoop::TimerBase::~TimerBase):
(RunLoop::TimerBase::start):
(RunLoop::TimerBase::stop):
(RunLoop::TimerBase::isActive):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-01 Patrick Gansterer <paroga@paroga.com>
commit-queue@webkit.org [Thu, 1 Jul 2010 12:28:41 +0000 (12:28 +0000)]
2010-07-01  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Dirk Schulze.

        Buildfix for !ENABLE(FILTERS) after r62238.
        https://bugs.webkit.org/show_bug.cgi?id=41456

        * rendering/SVGRenderSupport.cpp:
        (WebCore::SVGRenderSupport::prepareToRenderSVGContent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-01 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
jocelyn.turcotte@nokia.com [Thu, 1 Jul 2010 12:17:13 +0000 (12:17 +0000)]
2010-07-01  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Create QComboBoxes when clicked and destroy on hide.
        https://bugs.webkit.org/show_bug.cgi?id=41451

        Currently a QComboBox is created for each RenderMenuList and
        it gets destroyed either when the RenderMenuList or the
        QWebView (its Qt parent) is destroyed. This cause a crash
        when the QWebView is destroyed before the render tree (which
        is kept in cache).

        This patch aim to destroy the QComboBox as soon as its popup
        gets hidden, and likewise, create it only when the popup is
        requested to be shown.
        It also removes the unneeded reference to the QGraphicsProxyWidget,
        destroying the QComboBox automatically destroys its bound
        proxywidget.

        * WebCoreSupport/QtFallbackWebPopup.cpp:
        (WebCore::QtFallbackWebPopupCombo::hidePopup):
        (WebCore::QtFallbackWebPopup::QtFallbackWebPopup):
        (WebCore::QtFallbackWebPopup::~QtFallbackWebPopup):
        (WebCore::QtFallbackWebPopup::show):
        (WebCore::QtFallbackWebPopup::hide):
        (WebCore::QtFallbackWebPopup::destroyPopup):
        (WebCore::QtFallbackWebPopup::populate):
        * WebCoreSupport/QtFallbackWebPopup.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-01 MORITA Hajime <morrita@google.com>
morrita@google.com [Thu, 1 Jul 2010 11:39:14 +0000 (11:39 +0000)]
2010-07-01  MORITA Hajime  <morrita@google.com>

        Unreviewed build fix.

        * rendering/RenderInputSpeech.cpp:
        (WebCore::RenderInputSpeech::paintInputFieldSpeechButton):
        * rendering/RenderInputSpeech.h:
        * rendering/RenderTheme.cpp:
        (WebCore::RenderTheme::paintInputFieldSpeechButton):
        * rendering/RenderTheme.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-01 Satish Sampath <satish@chromium.org>
commit-queue@webkit.org [Thu, 1 Jul 2010 11:11:01 +0000 (11:11 +0000)]
2010-07-01  Satish Sampath  <satish@chromium.org>

        Reviewed by Kent Tamura.

        Rendering the speech button in input elements.
        https://bugs.webkit.org/show_bug.cgi?id=40984

        input-appearance-speechbutton.html checks the appearances of various sizes of speech buttons.
        input-appearance-searchandspeech.html checks input type='search' field with speech button.
        input-appearance-numberandspeech.html checks input type='number' field with speech button.

        * fast/forms/input-appearance-numberandspeech-expected.txt: Added.
        * fast/forms/input-appearance-numberandspeech.html: Added.
        * fast/forms/input-appearance-searchandspeech-expected.txt: Added.
        * fast/forms/input-appearance-searchandspeech.html: Added.
        * fast/forms/input-appearance-speechbutton-expected.txt: Added.
        * fast/forms/input-appearance-speechbutton.html: Added.
        * platform/chromium/test_expectations.txt: Skipped all these new tests as the speech input feature is disabled by default.
        * platform/gtk/Skipped:
        * platform/mac/fast/forms/input-appearance-numberandspeech-expected.checksum: Added.
        * platform/mac/fast/forms/input-appearance-numberandspeech-expected.png: Added.
        * platform/mac/fast/forms/input-appearance-searchandspeech-expected.checksum: Added.
        * platform/mac/fast/forms/input-appearance-searchandspeech-expected.png: Added.
        * platform/mac/fast/forms/input-appearance-speechbutton-expected.checksum: Added.
        * platform/mac/fast/forms/input-appearance-speechbutton-expected.png: Added.
        * platform/mac/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:
2010-07-01  Satish Sampath  <satish@chromium.org>

        Reviewed by Kent Tamura.

        Rendering the speech button in input elements.
        https://bugs.webkit.org/show_bug.cgi?id=40984

        The button currently has only one state and rendered as an image on all platforms. Subsequent
        patches will add user input handling and more states + rendering code to the button. The
        button's appearance can be customized by individual ports in their RenderTheme implementation
        if required.

        Tests: platform/mac/fast/forms/input-appearance-numberandspeech.html
               platform/mac/fast/forms/input-appearance-searchandspeech.html
               platform/mac/fast/forms/input-appearance-speechbutton.html

        * GNUmakefile.am:
        * Resources/inputSpeech.png: Added.
        * Resources/inputSpeech.tiff: Added. Used by the Mac implementation.
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.qrc:
        * WebCore.xcodeproj/project.pbxproj:
        * platform/graphics/qt/ImageQt.cpp:
        (loadResourcePixmap): Load the speech button images for Qt port.
        * rendering/RenderInputSpeech.cpp: Added.
        (WebCore::RenderInputSpeech::adjustInputFieldSpeechButtonStyle): Sets the button's dimensions.
        (WebCore::RenderInputSpeech::paintInputFieldSpeechButton):
        * rendering/RenderInputSpeech.h: Added.
        * rendering/RenderTextControlSingleLine.cpp:
        (WebCore::RenderTextControlSingleLine::layout):
        (WebCore::RenderTextControlSingleLine::forwardEvent):
        (WebCore::RenderTextControlSingleLine::createSubtreeIfNeeded): Create the speech button.
        (WebCore::RenderTextControlSingleLine::createInnerBlockStyle):
        * rendering/RenderTheme.cpp:
        (WebCore::RenderTheme::adjustStyle):
        (WebCore::RenderTheme::paint):
        (WebCore::RenderTheme::adjustInputFieldSpeechButtonStyle):
        (WebCore::RenderTheme::paintInputFieldSpeechButton):
        * rendering/RenderTheme.h:
        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::paintSearchFieldCancelButton): Get cancel button to render to the left of
        speech button when enabled.
2010-07-01  Satish Sampath  <satish@chromium.org>

        Reviewed by Kent Tamura.

        Rendering the speech button in input elements.
        https://bugs.webkit.org/show_bug.cgi?id=40984

        * Api/qwebsettings.cpp:
        (graphics):
        * Api/qwebsettings.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-01 Mario Sanchez Prada <msanchez@igalia.com>
commit-queue@webkit.org [Thu, 1 Jul 2010 10:50:33 +0000 (10:50 +0000)]
2010-07-01  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Extra nullcheck needed at SelectionControllerGtk.cpp
        https://bugs.webkit.org/show_bug.cgi?id=41447

        Extra null check added.

        * editing/gtk/SelectionControllerGtk.cpp:
        (WebCore::SelectionController::notifyAccessibilityForSelectionChange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt][Symbian] Bumped up the maximum heap size to 96MB
hausmann@webkit.org [Thu, 1 Jul 2010 10:39:13 +0000 (10:39 +0000)]
[Qt][Symbian] Bumped up the maximum heap size to 96MB

Rubber-stamped by Laszlo Gombos.

.:

* WebKit.pri:

WebKitTools:

* QtTestBrowser/QtTestBrowser.pro: Removed explicit heap size declaration
and use the one from WebKit.pri instead.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-01 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Thu, 1 Jul 2010 10:05:27 +0000 (10:05 +0000)]
2010-07-01  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Adam Barth.

        [v8] Web Inspector: inspected page crashes on attempt to change iframe's src attribute
        https://bugs.webkit.org/show_bug.cgi?id=41350

        * fast/events/popup-blocked-from-fake-user-gesture-expected.txt: Added.
        * fast/events/popup-blocked-from-fake-user-gesture.html: Added.
        * http/tests/inspector/change-iframe-src-expected.txt: Added.
        * http/tests/inspector/change-iframe-src.html: Added.
2010-07-01  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Adam Barth.

        [v8] Web Inspector: inspected page crashes on attempt to change iframe's src attribute
        https://bugs.webkit.org/show_bug.cgi?id=41350

        Tests: fast/events/popup-blocked-from-fake-user-gesture.html
               http/tests/inspector/change-iframe-src.html

        * bindings/v8/ScriptController.cpp:
        (WebCore::ScriptController::processingUserGesture): use V8Proxy from the ScriptController instead of one
        from the call stack. Get event directly from hidden property to avoid unnecessary checks.
        * bindings/v8/V8AbstractEventListener.cpp:
        (WebCore::V8AbstractEventListener::invokeEventHandler):
        * bindings/v8/V8HiddenPropertyName.h:
        * bindings/v8/custom/V8DOMWindowCustom.cpp:
        (WebCore::V8DOMWindow::eventAccessorGetter):
        (WebCore::V8DOMWindow::eventAccessorSetter):
2010-07-01  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Adam Barth.

        [v8] Web Inspector: inspected page crashes on attempt to change iframe's src attribute
        https://bugs.webkit.org/show_bug.cgi?id=41350

        * src/WebBindings.cpp:
        (WebKit::getEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-01 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 1 Jul 2010 09:55:39 +0000 (09:55 +0000)]
2010-07-01  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Promote webkit-patch land-safely to main help
        https://bugs.webkit.org/show_bug.cgi?id=41446

        I've been using this command a bunch and recommending it to folks.  We
        should show it in main help as it's past the experimental phase.

        * Scripts/webkitpy/tool/commands/upload.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-01 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Thu, 1 Jul 2010 09:47:01 +0000 (09:47 +0000)]
2010-07-01  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        RenderSVGContainer/RenderSVGRoot report wrong strokeBoundingBox()
        https://bugs.webkit.org/show_bug.cgi?id=41450

        strokeBoundingBox() was reporting the repaintRectInLocalCoordinates() for children of a container,
        instead of the actual strokeBoundingBox(). Only visible in WebInspector when looking at a container
        which has a resource applied and contains a children which also has a resource applied.

        Doesn't affect any test results.

        * rendering/RenderSVGContainer.cpp:
        (WebCore::RenderSVGContainer::objectBoundingBox):
        (WebCore::RenderSVGContainer::strokeBoundingBox):
        (WebCore::RenderSVGContainer::repaintRectInLocalCoordinates):
        * rendering/RenderSVGRoot.cpp:
        (WebCore::RenderSVGRoot::objectBoundingBox): Deinlined this functions, it's virtual so there's no gain.
        (WebCore::RenderSVGRoot::strokeBoundingBox): Ditto.
        (WebCore::RenderSVGRoot::repaintRectInLocalCoordinates):
        * rendering/RenderSVGRoot.h:
        * rendering/SVGRenderSupport.cpp:
        (WebCore::SVGRenderSupport::computeContainerBoundingBox):
        * rendering/SVGRenderSupport.h: Add enum controlling the mode of container bounding box mode calculation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: Implementing feConvolveMatrix svg filter
zherczeg@webkit.org [Thu, 1 Jul 2010 09:45:31 +0000 (09:45 +0000)]
WebCore: Implementing feConvolveMatrix svg filter
https://bugs.webkit.org/show_bug.cgi?id=5861

Reviewed by Nikolas Zimmermann.

The implementation is optimized for speed, and uses
multiple algorithms for different parts of the image.
See SVGFEConvolveMatrixElement.cpp for a detailed
description.

* svg/SVGFEConvolveMatrixElement.cpp:
(WebCore::SVGFEConvolveMatrixElement::build):
* svg/graphics/filters/SVGFEConvolveMatrix.cpp:
(WebCore::clampRGBAValue):
(WebCore::FEConvolveMatrix::fastSetInteriorPixels):
(WebCore::FEConvolveMatrix::getPixelValue):
(WebCore::FEConvolveMatrix::fastSetOuterPixels):
(WebCore::FEConvolveMatrix::setInteriorPixels):
(WebCore::FEConvolveMatrix::setOuterPixels):
(WebCore::FEConvolveMatrix::apply):
* svg/graphics/filters/SVGFEConvolveMatrix.h:
(WebCore::FEConvolveMatrix::uniteChildEffectSubregions):

LayoutTests: Updating expected values for feConvolveMatrix
https://bugs.webkit.org/show_bug.cgi?id=5861

Reviewed by Nikolas Zimmermann.

* platform/mac-leopard/svg/W3C-SVG-1.1/filters-conv-01-f-expected.checksum:
* platform/mac-leopard/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-01 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 1 Jul 2010 09:41:55 +0000 (09:41 +0000)]
2010-07-01  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Abstract 'a'-'z' checks into a function
        https://bugs.webkit.org/show_bug.cgi?id=41438

        Hopefully this version is more readable.

        * html/HTMLTokenizer.cpp:
        (WebCore::HTMLTokenizer::nextToken):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-01 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 1 Jul 2010 09:29:20 +0000 (09:29 +0000)]
2010-07-01  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Parameter names in frame src URLs parsed incorrectly if resembles HTML entity code followed by underscore
        https://bugs.webkit.org/show_bug.cgi?id=41345

        Add some more HTML entity test coverage for when the trailing semicolon
        character is required.

        * html5lib/resources/entities02.dat:
2010-07-01  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Parameter names in frame src URLs parsed incorrectly if resembles HTML entity code followed by underscore
        https://bugs.webkit.org/show_bug.cgi?id=41345

        Apparently whether an HTML entity requires a trailing semicolon varies
        depending on the entity.  The full table is in the spec:

        http://www.whatwg.org/specs/web-apps/current-work/multipage/named-character-references.html#named-character-references

        I believe branch added in this patch is accurate.  At some point, I'll
        add a full test suite for all the named entities.

        * html/HTMLEntityParser.cpp:
        (WebCore::consumeHTMLEntity):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-01 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Thu, 1 Jul 2010 09:06:32 +0000 (09:06 +0000)]
2010-07-01  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed. Update Chromium test expectations.

        * platform/chromium-mac/html5lib/runner-expected.txt:
        * platform/chromium-win/html5lib/runner-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-01 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 1 Jul 2010 08:36:54 +0000 (08:36 +0000)]
2010-07-01  Eric Seidel  <eric@webkit.org>

        Unreviewed.  Fix paste-o in Gtk build file.

        Split out HTMLFormattingElementList into its own file
        https://bugs.webkit.org/show_bug.cgi?id=41440

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@62239 268f45cc-cd09-0410-ab3c-d52691b4dbfc