WebKit-https.git
14 years agoReviewed by Simon Hausmann.
aroben [Thu, 21 Jun 2007 07:00:09 +0000 (07:00 +0000)]
Reviewed by Simon Hausmann.

More Gdk build fixing.

* WebKit.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoSpeculative Gdk build fix.
aroben [Thu, 21 Jun 2007 06:51:35 +0000 (06:51 +0000)]
Speculative Gdk build fix.

* WebCore.pro: Don't try to build WebKitQt/Plugins on Gdk.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWindows build fix.
aroben [Thu, 21 Jun 2007 06:11:13 +0000 (06:11 +0000)]
Windows build fix.

* WebCore.vcproj/WebCore.vcproj: Include ForwardingHeaders after
everything but $WebKitLibrariesDir so that we will pick up
JavaScriptCore headers directly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoadd missing symbol
staikos [Thu, 21 Jun 2007 05:46:29 +0000 (05:46 +0000)]
add missing symbol

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoMore missing files for building with Qt
staikos [Thu, 21 Jun 2007 05:42:00 +0000 (05:42 +0000)]
More missing files for building with Qt

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoMerge fix from r23692.
sfalken [Thu, 21 Jun 2007 05:32:57 +0000 (05:32 +0000)]
Merge fix from r23692.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoPatch from Adam Treat to add ICO support to the Qt build.
staikos [Thu, 21 Jun 2007 05:01:53 +0000 (05:01 +0000)]
Patch from Adam Treat to add ICO support to the Qt build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Anders.
ap [Thu, 21 Jun 2007 04:55:19 +0000 (04:55 +0000)]
    Reviewed by Anders.

        One more test for XHR header injection.

        * http/tests/xmlhttprequest/inject-header-expected.txt: Added.
        * http/tests/xmlhttprequest/inject-header.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoOne last build fix - now it runs again
staikos [Thu, 21 Jun 2007 04:43:41 +0000 (04:43 +0000)]
One last build fix - now it runs again

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoRepair the Qt build
staikos [Thu, 21 Jun 2007 04:31:39 +0000 (04:31 +0000)]
Repair the Qt build

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
aroben [Thu, 21 Jun 2007 03:38:05 +0000 (03:38 +0000)]
WebCore:

        More speculative Qt/Gdk build fixes.

        * WebCore.pro: Add new files.

WebKitQt:

        More speculative Qt build fixes.

        Add a stub implementation of InspectorClientQt.

        * WebCoreSupport/InspectorClientQt.cpp: Added.
        (WebCore::InspectorClientQt::inspectorDestroyed):
        (WebCore::InspectorClientQt::createPage):
        (WebCore::InspectorClientQt::showWindow):
        (WebCore::InspectorClientQt::closeWindow):
        (WebCore::InspectorClientQt::attachWindow):
        (WebCore::InspectorClientQt::detachWindow):
        (WebCore::InspectorClientQt::highlight):
        (WebCore::InspectorClientQt::hideHighlight):
        * WebCoreSupport/InspectorClientQt.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoSpeculative Qt/Gdk build fix.
aroben [Thu, 21 Jun 2007 03:21:28 +0000 (03:21 +0000)]
Speculative Qt/Gdk build fix.

Added forwarding headers for JavaScriptCore. We may eventually move
InspectorController off of the JSC API, but for now this is the
quickest way to a working build.

* ForwardingHeaders/JavaScriptCore/JSBase.h: Added.
* ForwardingHeaders/JavaScriptCore/JSContextRef.h: Added.
* ForwardingHeaders/JavaScriptCore/JSObjectRef.h: Added.
* ForwardingHeaders/JavaScriptCore/JSStringRef.h: Added.
* ForwardingHeaders/JavaScriptCore/JSStringRefCF.h: Added.
* ForwardingHeaders/JavaScriptCore/JSValueRef.h: Added.
* ForwardingHeaders/JavaScriptCore/JavaScriptCore.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Rubber stamped by Adam Roben.
weinig [Thu, 21 Jun 2007 03:18:09 +0000 (03:18 +0000)]
    Rubber stamped by Adam Roben.

        Add licenses.

        * page/inspector/ConsolePanel.js:
        * page/inspector/NetworkPanel.js:
        * page/inspector/Resource.js:
        * page/inspector/ResourceCategory.js:
        * page/inspector/ResourcePanel.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdd Bugzilla info to ChangeLog entry.
bdash [Thu, 21 Jun 2007 03:17:22 +0000 (03:17 +0000)]
Add Bugzilla info to ChangeLog entry.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-06-20 Mark Rowe <mrowe@apple.com>
bdash [Thu, 21 Jun 2007 03:11:30 +0000 (03:11 +0000)]
2007-06-20  Mark Rowe  <mrowe@apple.com>

        Reviewed by Adam.

        Reinstate the WebInspector class so WebKit clients that currently depend on it
        will build and run correctly.

        * WebInspector/WebInspector.h: Added.
        * WebInspector/WebInspector.mm: Added.
        (+[WebInspector webInspector]):
        (-[WebInspector dealloc]):
        (-[WebInspector setWebFrame:]):
        (-[WebInspector showWindow:]):
        * WebKit.exp:
        * WebKit.xcodeproj/project.pbxproj:

2007-06-20  Mark Rowe  <mrowe@apple.com>

        Reviewed by Adam.

        * WebCore.exp: Export InspectorController::inspect so WebKit can see it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAddressed some of Geoff's comments.
aroben [Thu, 21 Jun 2007 02:59:17 +0000 (02:59 +0000)]
Addressed some of Geoff's comments.

* page/ContextMenuController.cpp:
(WebCore::ContextMenuController::handleContextMenuEvent): Added a
FIXME.
* platform/ContextMenu.cpp:
(WebCore::ContextMenu::addInspectElementItem): Null-check
frame->page().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
ggaren [Thu, 21 Jun 2007 02:46:18 +0000 (02:46 +0000)]
WebCore:

        Reviewed by Adele Peterson, Oliver Hunt, Anders Carlsson.

        Fixed <rdar://problem/5222911> Leopard9A446 : VitalSource Bookshelf 4.5:
        Crashes when you click on sign in (stringByEvaluatingJavaScriptFromString
        returning nil instead of "")

        I'm basically rolling out the change for <rdar://problem/4782422> because
        my testing shows that it was backwards.

        * html/HTMLElement.cpp:
        (dumpInnerHTML): New debug-only function to work around gdb being
        perpetually suck-tastic.

        * page/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]):

        Return "", not nil. This function never used to return nil, so let's not
        start now. I've filed <rdar://problem/5283271> to cover the documentation bug,

WebKitTools:

        Reviewed by Adele Peterson, Oliver Hunt, Anders Carlsson.

        Added tests for stringByEvaluatingJavaScriptFromString.

        * DumpRenderTree/DumpRenderTree.m:
        (testStringByEvaluatingJavaScriptFromString):
        (dumpRenderTree):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix crash in fast/dom/dir-no-body.html
aroben [Thu, 21 Jun 2007 02:34:16 +0000 (02:34 +0000)]
Fix crash in fast/dom/dir-no-body.html

Reviewed by Mark.

* html/HTMLDocument.cpp:
(WebCore::HTMLDocument::createTokenizer): Don't assume we have a
Frame, since we won't if someone creates an HTMLDocument from JS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Geoff.
andersca [Thu, 21 Jun 2007 01:57:37 +0000 (01:57 +0000)]
    Reviewed by Geoff.

Make sure that the test case tests '\n' and '\r' too.

        * fast/dom/xmlhttprequest-invalid-values.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLand the new Inspector.
aroben [Thu, 21 Jun 2007 01:37:24 +0000 (01:37 +0000)]
Land the new Inspector.

WebCore:

        Land the new Inspector.

        Co-written with Tim Hatcher.

        Reviewed by Anders, Adele, Hyatt, and Sam.

        No regression tests possible.

        Add a new InspectorController that is in charge of the Inspector. It
        has an InspectorClient that controls the Inspector's window and node
        highlight.

        * page/InspectorClient.h: Added.
        (WebCore::InspectorClient::~InspectorClient):
        * page/InspectorController.cpp: Added.
        (WebCore::ConsoleMessage::ConsoleMessage):
        (WebCore::InspectorResource::): Represents a single resource that the
        Inspector knows about.
        (WebCore::InspectorResource::InspectorResource):
        (WebCore::InspectorResource::~InspectorResource):
        (WebCore::InspectorResource::type):
        (WebCore::InspectorResource::setScriptObject):
        (WebCore::addSourceToFrame): Callback available from JS.
        (WebCore::getResourceDocumentNode): Ditto.
        (WebCore::highlightDOMNode): Ditto.
        (WebCore::hideDOMNodeHighlight): Ditto.
        (WebCore::loaded): Ditto.
        (WebCore::unloading): Ditto.
        (WebCore::attach): Ditto.
        (WebCore::detach): Ditto.
        (WebCore::log): Ditto.
        (WebCore::search): Ditto.
        (WebCore::inspectedWindow): Ditto.
        (WebCore::InspectorController::InspectorController):
        (WebCore::InspectorController::~InspectorController):
        (WebCore::InspectorController::inspect): Called by
        ContextMenuController to inspect a node.
        (WebCore::InspectorController::focusNode):
        (WebCore::InspectorController::highlight):
        (WebCore::InspectorController::hideHighlight):
        (WebCore::InspectorController::windowVisible):
        (WebCore::InspectorController::setWindowVisible):
        (WebCore::InspectorController::addMessageToConsole):
        (WebCore::InspectorController::attachWindow):
        (WebCore::InspectorController::detachWindow):
        (WebCore::InspectorController::windowScriptObjectAvailable):
        (WebCore::InspectorController::scriptObjectReady):
        (WebCore::InspectorController::windowUnloading):
        (WebCore::addHeaders): Static helper function.
        (WebCore::objectForRequest): Ditto.
        (WebCore::objectForResponse): Ditto.
        (WebCore::InspectorController::addScriptResource):
        (WebCore::InspectorController::addAndUpdateScriptResource):
        (WebCore::InspectorController::removeScriptResource):
        (WebCore::InspectorController::updateScriptResource):
        (WebCore::InspectorController::populateScriptResources):
        (WebCore::InspectorController::addScriptConsoleMessage):
        (WebCore::callClearFunction): Static helper function.
        (WebCore::InspectorController::clearScriptResources):
        (WebCore::InspectorController::clearScriptConsoleMessages):
        (WebCore::InspectorController::clearNetworkTimeline):
        (WebCore::InspectorController::pruneResources):
        (WebCore::InspectorController::didCommitLoad): Callback from
        FrameLoader.
        (WebCore::InspectorController::frameDetachedFromParent): Ditto.
        (WebCore::InspectorController::addResource): Ditto.
        (WebCore::InspectorController::removeResource): Ditto.
        (WebCore::InspectorController::didLoadResourceFromMemoryCache): Ditto.
        (WebCore::InspectorController::identifierForInitialRequest): Ditto.
        (WebCore::InspectorController::willSendRequest): Ditto.
        (WebCore::InspectorController::didReceiveResponse): Ditto.
        (WebCore::InspectorController::didReceiveContentLength): Ditto.
        (WebCore::InspectorController::didFinishLoading): Ditto.
        (WebCore::InspectorController::didFailLoading): Ditto.
        * page/InspectorController.h: Added.
        (WebCore::InspectorController::inspectedPage):
        (WebCore::InspectorController::scriptContext):
        (WebCore::InspectorController::setScriptContext):
        (WebCore::InspectorController::resources):
        (WebCore::InspectorController::removeAllResources):

        Add the JavaScript that defines most of the behavior of the Inspector.

        * page/inspector/ConsolePanel.js: Added.
        * page/inspector/NetworkPanel.js: Added.
        * page/inspector/Resource.js: Added.
        * page/inspector/ResourceCategory.js: Added.
        * page/inspector/ResourcePanel.js: Added.
        * page/inspector/inspector.js: Added.
        * page/inspector/treeoutline.js: Renamed from WebKit/WebInspector/webInspector/treeoutline.js.
        * page/inspector/utilities.js: Added.

        Add the Inspector's CSS and HTML.

        * page/inspector/inspector.css: Added.
        * page/inspector/inspector.html: Added.

        Hang the InspectorController off of Page. We only create an
        InspectorController if an InspectorClient is given to the Page.

        * page/Page.cpp:
        (WebCore::Page::Page):
        * page/Page.h:
        (WebCore::Page::inspectorController):

        Use FrameLoader to notify the InspectorController of resource loads.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::begin):
        (WebCore::FrameLoader::transitionToCommitted):
        (WebCore::FrameLoader::continueLoadAfterWillSubmitForm):
        (WebCore::FrameLoader::detachFromParent):
        (WebCore::FrameLoader::assignIdentifierToInitialRequest):
        (WebCore::FrameLoader::willSendRequest):
        (WebCore::FrameLoader::didReceiveResponse):
        (WebCore::FrameLoader::didReceiveData):
        (WebCore::FrameLoader::sendRemainingDelegateMessages):
        (WebCore::FrameLoader::requestFromDelegate):
        (WebCore::FrameLoader::didFinishLoad):
        (WebCore::FrameLoader::dispatchWindowObjectAvailable):
        (WebCore::FrameLoader::dispatchDidCommitLoad):
        (WebCore::FrameLoader::dispatchAssignIdentifierToInitialRequest):
        (WebCore::FrameLoader::dispatchWillSendRequest):
        (WebCore::FrameLoader::dispatchDidReceiveResponse):
        (WebCore::FrameLoader::dispatchDidReceiveContentLength):
        (WebCore::FrameLoader::dispatchDidFinishLoading):
        (WebCore::FrameLoader::dispatchDidLoadResourceFromMemoryCache):
        * loader/FrameLoader.h:

        Send console messages to the InspectorController.

        * page/Chrome.cpp:
        (WebCore::Chrome::addMessageToConsole): Send all console messages to
        the InspectorController.
        * page/Chrome.h: Add a new MessageLevel and MessageSource that are
        used in the Inspector JS.

        Report HTML errors when the Inspector window is open.
        We don't report errors when the window is closed because we don't want
        to slow down the HTMLTokenizer.

        * html/HTMLDocument.cpp:
        (WebCore::HTMLDocument::createTokenizer):
        * html/HTMLParser.cpp:
        (WebCore::HTMLParser::HTMLParser):
        * html/HTMLParser.h:
        * html/HTMLTokenizer.cpp:
        (WebCore::HTMLTokenizer::HTMLTokenizer):
        * html/HTMLTokenizer.h:

        Append the "Inspect Element" context menu item after passing the
        context menu to the ContextMenuClient. This work used to be done in
        WebKit.

        * page/ContextMenuClient.h:
        * page/ContextMenuController.cpp:
        (WebCore::ContextMenuController::handleContextMenuEvent): Add the
        "Inspect Element" item.
        (WebCore::ContextMenuController::contextMenuItemSelected): Handle the
        "Inspect Element" item.
        * platform/ContextMenu.cpp:
        (WebCore::ContextMenu::addInspectElementItem):
        (WebCore::ContextMenu::checkOrEnableIfNeeded): Updated for "Inspect
        Element" item.
        * platform/ContextMenu.h:
        * platform/ContextMenuItem.h:
        (WebCore::): Add ContextMenuItemTagInspectElement.
        * platform/graphics/svg/SVGImageEmptyClients.h:
        * page/mac/WebCoreViewFactory.h: Add the "Inspect Element" localized
        string.
        * platform/LocalizedStrings.h: Ditto.
        * platform/mac/LocalizedStringsMac.mm:
        (WebCore::contextMenuItemTagInspectElement): Ditto.

        Miscellaneous changes:

        * css/view-source.css: Add message bubble styles.
        * loader/DocumentLoader.h: Add a frame getter.
        * platform/win/ScrollViewWin.cpp:
        (WebCore::ScrollView::updateScrollbars): Respect
        Frame::prohibitsScrolling.

        Add new images needed for the Inspector.

        * page/inspector/Images/attachedShadow.png: Added.
        * page/inspector/Images/bottomShadow.png: Added.
        * page/inspector/Images/breadcrumbBackground.png: Added.
        * page/inspector/Images/checker.png: Added.
        * page/inspector/Images/console.png: Added.
        * page/inspector/Images/darkShadow.png: Added.
        * page/inspector/Images/disclosureDownPressed.png: Added.
        * page/inspector/Images/disclosureRightDown.png: Added.
        * page/inspector/Images/disclosureRightPressed.png: Added.
        * page/inspector/Images/document.png: Added.
        * page/inspector/Images/domViewButton.png: Added.
        * page/inspector/Images/domViewButtonSelected.png: Added.
        * page/inspector/Images/downTriangle.png: Added.
        * page/inspector/Images/errorIcon.png: Added.
        * page/inspector/Images/errorMediumIcon.png: Added.
        * page/inspector/Images/folder.png: Added.
        * page/inspector/Images/goArrow.png: Added.
        * page/inspector/Images/gradient.png: Added.
        * page/inspector/Images/gradientHighlight.png: Added.
        * page/inspector/Images/gradientHighlightBottom.png: Added.
        * page/inspector/Images/hideStatusWidget.png: Added.
        * page/inspector/Images/hideStatusWidgetPressed.png: Added.
        * page/inspector/Images/network.png: Added.
        * page/inspector/Images/paneBottomGrow.png: Added.
        * page/inspector/Images/paneBottomGrowActive.png: Added.
        * page/inspector/Images/paneGrowHandleLine.png: Added.
        * page/inspector/Images/paneHeader.png: Added.
        * page/inspector/Images/paneHeaderActive.png: Added.
        * page/inspector/Images/plainDocument.png: Added.
        * page/inspector/Images/popupArrows.png: Added.
        * page/inspector/Images/rightTriangle.png: Added.
        * page/inspector/Images/segment.png: Added.
        * page/inspector/Images/segmentEnd.png: Added.
        * page/inspector/Images/segmentHover.png: Added.
        * page/inspector/Images/segmentHoverEnd.png: Added.
        * page/inspector/Images/segmentSelected.png: Added.
        * page/inspector/Images/segmentSelectedEnd.png: Added.
        * page/inspector/Images/showStatusWidget.png: Added.
        * page/inspector/Images/showStatusWidgetPressed.png: Added.
        * page/inspector/Images/sidbarItemBackground.png: Added.
        * page/inspector/Images/sidebarActionWidget.png: Added.
        * page/inspector/Images/sidebarActionWidgetPressed.png: Added.
        * page/inspector/Images/sidebarAttachWidget.png: Added.
        * page/inspector/Images/sidebarAttachWidgetPressed.png: Added.
        * page/inspector/Images/sidebarDetachWidget.png: Added.
        * page/inspector/Images/sidebarDetachWidgetPressed.png: Added.
        * page/inspector/Images/sidebarResizeWidget.png: Added.
        * page/inspector/Images/sidebarSelection.png: Added.
        * page/inspector/Images/sidebarSelectionBlurred.png: Added.
        * page/inspector/Images/sidebarSelectionBlurredTall.png: Added.
        * page/inspector/Images/sidebarSelectionGray.png: Added.
        * page/inspector/Images/sidebarSelectionGrayTall.png: Added.
        * page/inspector/Images/sidebarSelectionTall.png: Added.
        * page/inspector/Images/sidebarStatusAreaBackground.png: Added.
        * page/inspector/Images/sourceViewButton.png: Added.
        * page/inspector/Images/sourceViewButtonSelected.png: Added.
        * page/inspector/Images/splitviewDimple.png: Added.
        * page/inspector/Images/splitviewDividerBackground.png: Added.
        * page/inspector/Images/tab.png: Added.
        * page/inspector/Images/tabSelected.png: Added.
        * page/inspector/Images/timelinePillBlue.png: Added.
        * page/inspector/Images/timelinePillGray.png: Added.
        * page/inspector/Images/timelinePillGreen.png: Added.
        * page/inspector/Images/timelinePillOrange.png: Added.
        * page/inspector/Images/timelinePillPurple.png: Added.
        * page/inspector/Images/timelinePillRed.png: Added.
        * page/inspector/Images/timelinePillYellow.png: Added.
        * page/inspector/Images/tipBalloon.png: Added.
        * page/inspector/Images/tipBalloonBottom.png: Added.
        * page/inspector/Images/tipIcon.png: Added.
        * page/inspector/Images/tipIconPressed.png: Added.
        * page/inspector/Images/toggleDown.png: Added.
        * page/inspector/Images/toggleUp.png: Added.
        * page/inspector/Images/toolbarBackground.png: Added.
        * page/inspector/Images/toolbarBackgroundInactive.png: Added.
        * page/inspector/Images/toolbarButton.png: Added.
        * page/inspector/Images/toolbarButtonInactive.png: Added.
        * page/inspector/Images/toolbarButtonPressed.png: Added.
        * page/inspector/Images/toolbarButtonPressedInactive.png: Added.
        * page/inspector/Images/toolbarSplitButtonDivider.png: Added.
        * page/inspector/Images/toolbarSplitButtonDividerInactive.png: Added.
        * page/inspector/Images/treeDownTriangleBlack.png: Added.
        * page/inspector/Images/treeDownTriangleWhite.png: Added.
        * page/inspector/Images/treeLeftTriangleBlack.png: Added.
        * page/inspector/Images/treeRightTriangleBlack.png: Added.
        * page/inspector/Images/treeRightTriangleWhite.png: Added.
        * page/inspector/Images/warningIcon.png: Added.
        * page/inspector/Images/warningMediumIcon.png: Added.
        * page/inspector/Images/warningsErrors.png: Added.

        Build-fu:

        * WebCore.exp: Added new symbols.
        * WebCore.xcodeproj/project.pbxproj: Added new source files and
        resources.
        * WebCore.vcproj/WebCore.vcproj: Ditto, and copy the resources to
        $WebKitOutputDir.

        Windows build fixes:

        * history/HistoryItem.h: ResourceRequest is a struct.
        * loader/FrameLoaderClient.h: Ditto.

WebKit:

        Land the new Inspector.

        Co-written with Tim Hatcher.

        Reviewed by Anders, Adele, Hyatt, and Sam.

        Implement the InspectorClient interface.

        * WebCoreSupport/WebInspectorClient.h: Added.
        * WebCoreSupport/WebInspectorClient.mm: Added.
        (WebInspectorClient::WebInspectorClient):
        (WebInspectorClient::inspectorDestroyed):
        (WebInspectorClient::createPage):
        (WebInspectorClient::showWindow):
        (WebInspectorClient::closeWindow):
        (WebInspectorClient::attachWindow):
        (WebInspectorClient::detachWindow):
        (WebInspectorClient::highlight):
        (WebInspectorClient::hideHighlight):
        (WebInspectorClient::inspectedURLChanged):
        (WebInspectorClient::updateWindowTitle):
        (-[WebInspectorWindowController init]):
        (-[WebInspectorWindowController initWithInspectedWebView:]):
        (-[WebInspectorWindowController dealloc]):
        (-[WebInspectorWindowController inspectorVisible]):
        (-[WebInspectorWindowController webView]):
        (-[WebInspectorWindowController window]):
        (-[WebInspectorWindowController windowShouldClose:]):
        (-[WebInspectorWindowController close]):
        (-[WebInspectorWindowController showWindow:]):
        (-[WebInspectorWindowController attach]):
        (-[WebInspectorWindowController detach]):
        (-[WebInspectorWindowController highlightAndScrollToNode:]):
        (-[WebInspectorWindowController highlightNode:]):
        (-[WebInspectorWindowController hideHighlight]):
        (-[WebInspectorWindowController animationDidEnd:]):

        Add an easier-to-see highlight.

        * Misc/WebNSViewExtras.h:
        * Misc/WebNSViewExtras.m:
        (-[NSView _web_convertRect:toView:]):
        * WebInspector/WebNodeHighlight.h:
        * WebInspector/WebNodeHighlight.m:
        (-[WebNodeHighlightFadeInAnimation setCurrentProgress:]):
        (-[WebNodeHighlight initWithTargetView:]):
        (-[WebNodeHighlight setHighlightedNode:]):
        (-[WebNodeHighlight highlightedNode]):
        (-[WebNodeHighlight dealloc]):
        (-[WebNodeHighlight attachHighlight]):
        (-[WebNodeHighlight delegate]):
        (-[WebNodeHighlight detachHighlight]):
        (-[WebNodeHighlight show]):
        (-[WebNodeHighlight hide]):
        (-[WebNodeHighlight animationDidEnd:]):
        (-[WebNodeHighlight ignoresMouseEvents]):
        (-[WebNodeHighlight highlightView]):
        (-[WebNodeHighlight setDelegate:]):
        (-[WebNodeHighlight setHolesNeedUpdateInTargetViewRect:]):
        (-[WebNodeHighlight setIgnoresMouseEvents:]):
        (-[WebNodeHighlight targetView]):
        (-[WebNodeHighlight _computeHighlightWindowFrame]):
        (-[WebNodeHighlight _repositionHighlightWindow]):
        * WebInspector/WebNodeHighlightView.h:
        * WebInspector/WebNodeHighlightView.m:
        (-[WebNodeHighlightView initWithWebNodeHighlight:]):
        (-[WebNodeHighlightView dealloc]):
        (-[WebNodeHighlightView detachFromWebNodeHighlight]):
        (-[WebNodeHighlightView drawRect:]):
        (-[WebNodeHighlightView webNodeHighlight]):
        (-[WebNodeHighlightView fractionFadedIn]):
        (-[WebNodeHighlightView setFractionFadedIn:]):
        (-[WebNodeHighlightView setHolesNeedUpdateInRect:]):
        (-[WebNodeHighlightView _holes]):

        WebView changes needed for the new Inspector.

        * WebView/WebView.mm: Remove the old _inspectElement method now that
        this is handled by WebCore.
        (-[WebView _isClosed]): Added.
        (-[WebView initWithFrame]): Give each Page an InspectorClient to
        enable the Inspector.
        * WebView/WebViewPrivate.h:

        Updates needed for WebCore changes.

        * WebCoreSupport/WebContextMenuClient.h:
        * WebCoreSupport/WebContextMenuClient.mm:
        * WebCoreSupport/WebViewFactory.mm:
        (-[WebViewFactory contextMenuItemTagInspectElement]):
        * WebView/WebUIDelegatePrivate.h:

        Remove old Inspector code.

        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
        (WebFrameLoaderClient::assignIdentifierToInitialRequest):
        (WebFrameLoaderClient::dispatchDidFinishLoading):
        * WebInspector/WebInspector.m: Removed.
        * WebInspector/WebInspectorPanel.h: Removed.
        * WebInspector/WebInspectorPanel.m: Removed.
        * WebInspector/webInspector/Images/button.png: Removed.
        * WebInspector/webInspector/Images/buttonDivider.png: Removed.
        * WebInspector/webInspector/Images/buttonPressed.png: Removed.
        * WebInspector/webInspector/Images/close.png: Removed.
        * WebInspector/webInspector/Images/closePressed.png: Removed.
        * WebInspector/webInspector/Images/downTriangle.png: Removed.
        * WebInspector/webInspector/Images/menu.png: Removed.
        * WebInspector/webInspector/Images/menuPressed.png: Removed.
        * WebInspector/webInspector/Images/popup.png: Removed.
        * WebInspector/webInspector/Images/popupPressed.png: Removed.
        * WebInspector/webInspector/Images/resize.png: Removed.
        * WebInspector/webInspector/Images/rightTriangle.png: Removed.
        * WebInspector/webInspector/Images/scrollThumbBottom.png: Removed.
        * WebInspector/webInspector/Images/scrollThumbMiddle.png: Removed.
        * WebInspector/webInspector/Images/scrollTrackBottom.png: Removed.
        * WebInspector/webInspector/Images/upTriangle.png: Removed.
        * WebInspector/webInspector/inspector.css: Removed.
        * WebInspector/webInspector/inspector.html: Removed.
        * WebInspector/webInspector/inspector.js: Removed.
        * WebInspector/webInspector/scrollarea.js: Removed.
        * WebInspector/webInspector/scrollbar.js: Removed.
        * WebInspector/webInspector/utilities.js: Removed.
        * WebView/WebFrame.mm:
        (-[WebFramePrivate dealloc]):
        * WebView/WebFrameInternal.h:
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView menuForEvent:]):

        Build-fu:

        * WebKit.exp:
        * WebKit.xcodeproj/project.pbxproj:

WebKit/win:

        Land the new Inspector.

        Co-written with Tim Hatcher.

        Reviewed by Anders, Adele, Hyatt, and Sam.

        Implement the InspectorClient interface.

        * WebInspectorClient.cpp: Added.
        (WebInspectorClient::WebInspectorClient):
        (WebInspectorClient::~WebInspectorClient):
        (WebInspectorClient::inspectorDestroyed):
        (WebInspectorClient::createPage):
        (WebInspectorClient::showWindow):
        (WebInspectorClient::closeWindow):
        (WebInspectorClient::windowVisible):
        (WebInspectorClient::attachWindow):
        (WebInspectorClient::detachWindow):
        (WebInspectorClient::highlight):
        (WebInspectorClient::hideHighlight):
        (WebInspectorClient::inspectedURLChanged):
        (WebInspectorClient::updateWindowTitle):
        (WebInspectorClient::onSize):
        (WebInspectorClient::onClose):
        (WebInspectorClient::onWebViewWindowPosChanging):
        (WebInspectorWndProc):
        (SubclassedWebViewWndProc):
        (registerWindowClass):
        * WebInspectorClient.h: Added.

        Add an easier-to-see highlight.

        * WebNodeHighlight.cpp: Added.
        (WebNodeHighlight::WebNodeHighlight):
        (WebNodeHighlight::~WebNodeHighlight):
        (WebNodeHighlight::highlight):
        (WebNodeHighlight::hide):
        (WebNodeHighlight::visible):
        (WebNodeHighlight::updateWindow):
        (WebNodeHighlight::removeSubclass):
        (registerOverlayClass):
        (OverlayWndProc):
        (SubclassedWndProc):
        * WebNodeHighlight.h: Added.

        WebView changes needed for the new Inspector.

        * WebView.cpp: Removed old inspectElement method now that this is
        handled by WebCore.
        (WebView::WebView):
        (WebView::close):
        (WebView::performContextMenuAction): Removed handling of the Inspect
        Element context menu item.
        (WebView::initWithFrame): Give each Page an InspectorClient to enable
        the Inspector.
        (WebView::setProhibitsMainFrameScrolling): Added.
        * WebView.h:

        Updates needed for WebCore changes.

        * Interfaces/IWebUIDelegate.idl:
        * WebContextMenuClient.cpp:
        (WebContextMenuClient::getCustomMenuFromDefaultItems):
        * WebContextMenuClient.h:
        * WebCoreLocalizedStrings.cpp:

        Remove old Inspector code.

        * WebFrame.cpp:
        * WebFrame.h:
        * WebInspector/WebInspector.cpp: Removed.
        * WebInspector/WebInspector.h: Removed.
        * WebInspector/webInspector/Images/button.png: Removed.
        * WebInspector/webInspector/Images/buttonDivider.png: Removed.
        * WebInspector/webInspector/Images/buttonPressed.png: Removed.
        * WebInspector/webInspector/Images/close.png: Removed.
        * WebInspector/webInspector/Images/closePressed.png: Removed.
        * WebInspector/webInspector/Images/downTriangle.png: Removed.
        * WebInspector/webInspector/Images/menu.png: Removed.
        * WebInspector/webInspector/Images/menuPressed.png: Removed.
        * WebInspector/webInspector/Images/popup.png: Removed.
        * WebInspector/webInspector/Images/popupPressed.png: Removed.
        * WebInspector/webInspector/Images/resize.png: Removed.
        * WebInspector/webInspector/Images/rightTriangle.png: Removed.
        * WebInspector/webInspector/Images/scrollThumbBottom.png: Removed.
        * WebInspector/webInspector/Images/scrollThumbMiddle.png: Removed.
        * WebInspector/webInspector/Images/scrollTrackMiddle.png: Removed.
        * WebInspector/webInspector/Images/upTriangle.png: Removed.
        * WebInspector/webInspector/inspector.css: Removed.
        * WebInspector/webInspector/inspector.html: Removed.
        * WebInspector/webInspector/inspector.js: Removed.
        * WebInspector/webInspector/scrollarea.js: Removed.
        * WebInspector/webInspector/scrollbar.js: Removed.
        * WebInspector/webInspector/treeoutline.js: Removed.
        * WebInspector/webInspector/utilities.js: Removed.

        Build-fu:

        * WebKit.vcproj/WebKit.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-06-20 Mitz Pettel <mitz@webkit.org>
bdash [Thu, 21 Jun 2007 00:09:48 +0000 (00:09 +0000)]
2007-06-20  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Beth.

        - fix http://bugs.webkit.org/show_bug.cgi?id=14056
          REGRESSION (r21113-21143): TR background not repainted via style class change

        Test: fast/repaint/table-row.html

        * rendering/RenderTableRow.cpp:
        (WebCore::RenderTableRow::layout): Added a repaint to make up for the case where the
        table row also needs layout, so it doesn't get a repaint in setStyle().

2007-06-20  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Beth.

        - repaint test for http://bugs.webkit.org/show_bug.cgi?id=14056
          REGRESSION (r21113-21143): TR background not repainted via style class change

        * fast/repaint/table-row-expected.checksum: Added.
        * fast/repaint/table-row-expected.png: Added.
        * fast/repaint/table-row-expected.txt: Added.
        * fast/repaint/table-row.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-06-20 Mark Rowe <mrowe@apple.com>
bdash [Thu, 21 Jun 2007 00:00:12 +0000 (00:00 +0000)]
2007-06-20  Mark Rowe  <mrowe@apple.com>

        Reviewed by Mitz.

        Fix http://bugs.webkit.org/show_bug.cgi?id=14244
        Bug 14244: Data corruption when using a replace() callback function with data containing "$"

        * kjs/string_object.cpp:
        (KJS::replace):  When 'replacement' is a function, do not replace $n placeholders in its return value.
        This matches the behaviour described in ECMA 262 3rd Ed section 15.5.4.1, and as implemented in Firefox.

2007-06-20  Mark Rowe  <mrowe@apple.com>

        Reviewed by Mitz.

        Test for http://bugs.webkit.org/show_bug.cgi?id=14244
        Bug 14244: Data corruption when using a replace() callback function with data containing "$"

        * fast/js/resources/string-replace-2.js: Update to test with 'replaceValue' being a function returning strings with "$n" placeholders.
        * fast/js/string-replace-2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
adele [Wed, 20 Jun 2007 21:56:02 +0000 (21:56 +0000)]
LayoutTests:

        Reviewed by Adele.

        - pixel test for http://bugs.webkit.org/show_bug.cgi?id=14040
          Top and bottom border images flipped when using -webkit-border-image when border end up tiled

        * fast/borders/border-image-01-expected.checksum: Added.
        * fast/borders/border-image-01-expected.png: Added.
        * fast/borders/border-image-01-expected.txt: Added.
        * fast/borders/border-image-01.html: Added.
        * fast/borders/resources/border-image.png: Added.

WebCore:

        Reviewed by Adele.

        - fix http://bugs.webkit.org/show_bug.cgi?id=14040
          Top and bottom border images flipped when using -webkit-border-image when border end up tiled

        Test: fast/borders/border-image-01.html

        Correctly account for the fact that "pattern space" is flipped.

        * platform/graphics/Image.cpp: (WebCore::Image::drawTiled):
        * platform/graphics/cg/ImageCG.cpp:
        (WebCore::Image::drawPatternCallback):
        (WebCore::Image::drawPattern):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
andersca [Wed, 20 Jun 2007 21:29:49 +0000 (21:29 +0000)]
    Reviewed by Darin.

        <rdar://problem/5245555> REGRESSION: HTTP header injection in XMLHttpRequest.setRequestHeader

        Check for either '\r' or '\n' in the header value.

        * xml/xmlhttprequest.cpp:
        (WebCore::isValidHeaderValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
justing [Wed, 20 Jun 2007 21:16:26 +0000 (21:16 +0000)]
    Reviewed by Darin.

        <rdar://problem/5263541> REGRESSION (Safari 3 Beta 1): Pressing Delete doesn't delete an HTML message in Mail

        Mail wasn't receiving the keyDown event because WebFrameView was blocking it.
        It blocks the event and moves back/forward on Delete/Shift+Delete if the
        back/forward list is enabled.

        * WebView/WebFrameView.mm:
        (-[WebFrameView keyDown:]): Check to see if the BackForwardList is
        enabled.  It always exists.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago<rdar://problem/4882527> VO should speak URL of image links that lack tags
pyeh [Wed, 20 Jun 2007 20:56:12 +0000 (20:56 +0000)]
<rdar://problem/4882527> VO should speak URL of image links that lack tags
        Add additional change from review

        * bridge/mac/WebCoreAXObject.mm:
        (-[WebCoreAXObject accessibilityAttributeValue:]):
        Check if the element has imgTag before asking for its url

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago<rdar://problem/4882527> VO should speak URL of image links that lack tags
pyeh [Wed, 20 Jun 2007 20:08:24 +0000 (20:08 +0000)]
<rdar://problem/4882527> VO should speak URL of image links that lack tags

        * bridge/mac/WebCoreAXObject.mm:
        (-[WebCoreAXObject accessibilityAttributeNames]):
        (-[WebCoreAXObject accessibilityAttributeValue:]):
        Return the url of images.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Remove the XPath tests, they all pass now.
andersca [Wed, 20 Jun 2007 16:07:28 +0000 (16:07 +0000)]
Remove the XPath tests, they all pass now.

        * win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
andersca [Wed, 20 Jun 2007 00:23:48 +0000 (00:23 +0000)]
WebCore:

        Reviewed by Kevin Decker.

        <rdar://problem/5266289> REGRESSION (Safari 3 Beta 1): Incoming iChat messages are delayed

        Add a new m_deferMainResourceDataLoad that can be used to control whether a data load should be deferred using a timer or not.

        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::DocumentLoader):
        * loader/DocumentLoader.h:
        (WebCore::DocumentLoader::deferMainResourceDataLoad):
        * loader/MainResourceLoader.cpp:
        (WebCore::MainResourceLoader::handleDataLoadSoon):
        (WebCore::MainResourceLoader::loadNow):
        (WebCore::MainResourceLoader::setDefersLoading):

WebKit:

        Reviewed by Kevin Decker.

        <rdar://problem/5266289> REGRESSION (Safari 3 Beta 1): Incoming iChat messages are delayed

        * WebView/WebDocumentLoaderMac.mm:
        (needsAppKitWorkaround):
        New function which checks if the frame load delegate belongs to AppKit.

        (WebDocumentLoaderMac::setDataSource):
        If the frame load delegate belongs to AppKit, set m_deferMainResourceDataLoad to false.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Mark Rowe.
andrew [Wed, 20 Jun 2007 00:00:37 +0000 (00:00 +0000)]
    Reviewed by Mark Rowe.

        Support applications with spaces or special characters in their names

        * Scripts/run-webkit-app:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdd support to Windows for Backspace back/forward navigation and for Ctrl+arrow key...
hyatt [Tue, 19 Jun 2007 23:22:32 +0000 (23:22 +0000)]
Add support to Windows for Backspace back/forward navigation and for Ctrl+arrow key back/forward navigation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Sam Weinig.
ggaren [Tue, 19 Jun 2007 22:21:16 +0000 (22:21 +0000)]
    Reviewed by Sam Weinig.

        Fixed up these tests because they broke the bot.

        - Removed reliance on suppressConsoleMessages because I never checked
        that in and I decided it would just be a headache on other platforms.
        - Removed call to frames[0].stop() because it was nonsense.
        - Added console messages to results.

        * http/tests/security/cross-frame-access-expected.txt:
        * http/tests/security/cross-frame-access-first-time-expected.txt:
        * http/tests/security/cross-frame-access-first-time.html:
        * http/tests/security/cross-frame-access.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago<rdar://problem/5237325> Incorrect AXLeftLineTextMarkerRangeForTextMarker/AXPreviousL...
pyeh [Tue, 19 Jun 2007 21:18:38 +0000 (21:18 +0000)]
<rdar://problem/5237325> Incorrect AXLeftLineTextMarkerRangeForTextMarker/AXPreviousLineStartTextMarkerForTextMarker for non-editable text

        * editing/visible_units.cpp:
        (WebCore::startPositionForLine):
        (WebCore::startOfLine):
        (WebCore::endPositionForLine):
        (WebCore::endOfLine):
        Break down the line routines to allow another try to ask for start/end of line if the returned position is not valid.
        An example would be when lineStart/lineEnd at different line than the input position.
        This can happen if the input position is before the space character at the end of a soft-wrapped non-editable line,
        specifically a line without webkit-line-break:after-white-space style.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago<rdar://problem/3992645> VO view bounds misplaced when reading text after a line...
pyeh [Tue, 19 Jun 2007 20:54:32 +0000 (20:54 +0000)]
<rdar://problem/3992645> VO view bounds misplaced when reading text after a line wrap

        * bridge/mac/WebCoreAXObject.mm:
        (-[WebCoreAXObject doAXBoundsForTextMarkerRange:]):
        Improve the accuracy of the bounds for a given range

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
andersca [Tue, 19 Jun 2007 20:45:59 +0000 (20:45 +0000)]
    Reviewed by Darin.

        <rdar://problem/5130630>
        XPath fails LayoutTests on Windows

        * xml/XPathPredicate.cpp:
        Include MathExtras.h here so we get a version of fmod that works around a bug in the Microsoft CRT.

        * xml/XPathValue.cpp:
        (WebCore::XPath::Value::toNumber):
        Instead of using NAN, which isn't really the NaN value on Windows, use numeric_limits.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
ggaren [Tue, 19 Jun 2007 19:28:14 +0000 (19:28 +0000)]
LayoutTests:

        Reviewed by Darin Adler.

        Tests for cross-frame access. <rdar://problem/5251309>.

        * http/tests/security/cross-frame-access-expected.txt: Added.
        * http/tests/security/cross-frame-access-first-time-expected.txt: Added.
        * http/tests/security/cross-frame-access-first-time.html: Added.
        * http/tests/security/cross-frame-access.html: Added.
        * http/tests/security/resources/cross-frame-iframe.html: Added.

WebCore:

        Reviewed by Darin Adler.

        Fixed cross-frame access. <rdar://problem/5251309>.

        * bindings/js/kjs_window.cpp:
        (KJS::Window::getValueProperty):
        * bindings/scripts/CodeGeneratorJS.pm:
        * page/DOMWindow.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Build fix.
andersca [Tue, 19 Jun 2007 18:18:30 +0000 (18:18 +0000)]
    Build fix.

        * platform/win/PopupMenuWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdd https support
staikos [Tue, 19 Jun 2007 17:13:58 +0000 (17:13 +0000)]
Add https support

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Tim Hatcher
sullivan [Tue, 19 Jun 2007 16:07:01 +0000 (16:07 +0000)]
    Reviewed by Tim Hatcher

        - fixed <rdar://problem/5272011> Hole for find-on-page match in subframe isn't clipped by frame bounds

        * WebView/WebView.mm:
        (-[WebView rectsForTextMatches]):
        intersect the HTMLView's computed rect with the visible rect for that view

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoImplement these methods correctly.
lars [Tue, 19 Jun 2007 10:13:09 +0000 (10:13 +0000)]
Implement these methods correctly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Geoff.
weinig [Tue, 19 Jun 2007 08:00:13 +0000 (08:00 +0000)]
    Reviewed by Geoff.

        Patch for http://bugs.webkit.org/show_bug.cgi?id=14226
        Move the History object out of the JS bindings

        - Autogenerate JSHistory.

        * DerivedSources.make:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/kjs_window.cpp:
        (KJS::WindowPrivate::WindowPrivate):
        (KJS::Window::mark):
        (KJS::Window::getValueProperty):
        (KJS::Window::clearHelperObjectProperties):
        (KJS::Window::disconnectFrame):
        * bindings/js/kjs_window.h:
        (KJS::Window::):
        * bridge/GlobalHistory.h: Copied from WebCore/bridge/History.h.
        * bridge/History.h: Removed.
        * bridge/mac/GlobalHistoryMac.mm: Copied from WebCore/bridge/mac/HistoryMac.mm.
        * bridge/mac/HistoryMac.mm: Removed.
        * bridge/win/GlobalHistoryWin.cpp: Copied from WebCore/bridge/win/HistoryWin.cpp.
        * bridge/win/HistoryWin.cpp: Removed.
        * css/cssstyleselector.cpp:
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::disconnectFrame):
        (WebCore::DOMWindow::history):
        * page/DOMWindow.h:
        * page/DOMWindow.idl:
        * page/History.cpp: Added.
        (WebCore::History::History):
        (WebCore::History::frame):
        (WebCore::History::disconnectFrame):
        (WebCore::History::length):
        (WebCore::History::back):
        (WebCore::History::forward):
        (WebCore::History::go):
        * page/History.h: Added.
        * page/History.idl: Added.
        * platform/gdk/TemporaryLinkStubs.cpp:
        * platform/qt/TemporaryLinkStubs.cpp:
        * platform/wx/TemporaryLinkStubs.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Kevin Decker
kdecker [Tue, 19 Jun 2007 04:56:27 +0000 (04:56 +0000)]
    Reviewed by Kevin Decker

        * Carbon/HIWebView.m:
        (WindowHandler): HIObjectIsOfClass requires non-NULL input on Tiger. Reworked Kevin Decker's patch to remove the conditional compilation for Tiger, yet still avoid crashing BBEdit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Qt build fix.
weinig [Tue, 19 Jun 2007 02:12:00 +0000 (02:12 +0000)]
    Qt build fix.

        * platform/qt/PlatformScreenQt.cpp:
        (WebCore::screenDepth):
        (WebCore::screenDepthPerComponent):
        (WebCore::screenIsMonochrome):
        (WebCore::screenRect):
        (WebCore::screenAvailableRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
weinig [Tue, 19 Jun 2007 02:03:22 +0000 (02:03 +0000)]
WebCore:

        Reviewed by Beth.

        Fix build and update licenses.

        * WebCore.xcodeproj/project.pbxproj:
        * page/BarInfo.cpp:
        * page/BarInfo.h:
        * page/BarInfo.idl:
        * page/Screen.cpp:
        (WebCore::Screen::height):
        (WebCore::Screen::width):
        (WebCore::Screen::colorDepth):
        (WebCore::Screen::pixelDepth):
        (WebCore::Screen::availLeft):
        (WebCore::Screen::availTop):
        (WebCore::Screen::availHeight):
        (WebCore::Screen::availWidth):
        * page/Screen.h:
        * page/Screen.idl:

WebKit:

        Reviewed by Beth.

        Build fix.

        * WebCoreSupport/WebChromeClient.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-06-18 Kevin Decker <kdecker@apple.com>
kdecker [Tue, 19 Jun 2007 01:30:57 +0000 (01:30 +0000)]
2007-06-18  Kevin Decker <kdecker@apple.com>

        * Carbon/HIWebView.m:
        (WindowHandler): Fixed the Tiger build; ControlKind wasn't defined.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
andersca [Tue, 19 Jun 2007 01:14:50 +0000 (01:14 +0000)]
LayoutTests:

        Reviewed by John Sullivan.

        Update result, we shouldn't call didFinishLoadForFrame if the URL isn't valid.

        * http/tests/loading/bad-scheme-subframe-expected.txt:

WebCore:

        Reviewed by John Sullivan.

        <rdar://problem/5277008> Assertion in [LocationChangeHandler finishedLoadingFrame:]

        Don't send any frame load callbacks if the document load hasn't been
        committed for real.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::checkLoadCompleteForThisFrame):

WebKitTools:

        Reviewed by John Sullivan.

        Assert that the frame has a dataSource.

        * DumpRenderTree/FrameLoadDelegate.m:
        (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
weinig [Tue, 19 Jun 2007 00:08:29 +0000 (00:08 +0000)]
LayoutTests:

        Reviewed by Geoff.

        Updates tests for http://bugs.webkit.org/show_bug.cgi?id=14193
        Move the Screen object out of the JS bindings

        * fast/dom/Window/window-appendages-cleared-expected.txt:
        * fast/dom/Window/window-properties-expected.txt:

WebCore:

        Reviewed by Geoff.

        Patch for http://bugs.webkit.org/show_bug.cgi?id=14193
        Move the Screen object out of the JS bindings

        - Renames Screen.h to PlatformScreen.h to accommodate new class.
        - Autogenerates JSScreen.

        * DerivedSources.make:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/kjs_window.cpp:
        (KJS::WindowPrivate::WindowPrivate):
        (KJS::Window::mark):
        (KJS::Window::getValueProperty):
        (KJS::Window::clearHelperObjectProperties):
        * bindings/js/kjs_window.h:
        (KJS::Window::):
        * css/MediaQueryEvaluator.cpp:
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::DOMWindow):
        (WebCore::DOMWindow::~DOMWindow):
        (WebCore::DOMWindow::frame):
        (WebCore::DOMWindow::disconnectFrame):
        (WebCore::DOMWindow::screen):
        * page/DOMWindow.h:
        * page/DOMWindow.idl:
        * page/Screen.cpp: Added.
        (WebCore::Screen::Screen):
        (WebCore::Screen::disconnectFrame):
        (WebCore::Screen::height):
        (WebCore::Screen::width):
        (WebCore::Screen::colorDepth):
        (WebCore::Screen::pixelDepth):
        (WebCore::Screen::availLeft):
        (WebCore::Screen::availTop):
        (WebCore::Screen::availHeight):
        (WebCore::Screen::availWidth):
        * page/Screen.h: Added.
        * page/Screen.idl: Added.
        * page/mac/WebCoreFrameBridge.mm:
        * platform/PlatformScreen.h: Copied from WebCore/platform/Screen.h.
        * platform/Screen.h: Removed.
        * platform/gdk/PlatformScreenGdk.cpp: Copied from WebCore/platform/gdk/ScreenGdk.cpp.
        * platform/gdk/ScreenGdk.cpp: Removed.
        * platform/mac/PlatformMouseEventMac.mm:
        * platform/mac/PlatformScreenMac.mm: Copied from WebCore/platform/mac/ScreenMac.mm.
        * platform/mac/ScreenMac.mm: Removed.
        * platform/qt/PlatformScreenQt.cpp: Added.
        (WebCore::WebCore::screenDepth):
        (WebCore::WebCore::screenDepthPerComponent):
        (WebCore::WebCore::screenIsMonochrome):
        (WebCore::WebCore::screenRect):
        (WebCore::WebCore::screenAvailableRect):
        * platform/qt/TemporaryLinkStubs.cpp:
        * platform/win/PlatformScreenWin.cpp: Copied from WebCore/platform/win/ScreenWin.cpp.
        * platform/win/ScreenWin.cpp: Removed.
        * rendering/RenderObject.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Tim Hatcher.
kdecker [Tue, 19 Jun 2007 00:01:37 +0000 (00:01 +0000)]
    Reviewed by Tim Hatcher.

        Fixed: <rdar://problem/5276135> With Safari 3 Tiger Beta installed, a crash occurs in BBEdit while mousing down and dragging outside of HTML preview window

        * Carbon/HIWebView.m:
        (WindowHandler): Because the fix for 5051616 causes Tiger to crash in HIToolbox (but not on Leopard), I reverted back to using GetControlKind
        on Tiger only, instead of HIObjectIsOfClass.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Geoff.
weinig [Mon, 18 Jun 2007 23:04:07 +0000 (23:04 +0000)]
    Reviewed by Geoff.

        Patch for http://bugs.webkit.org/show_bug.cgi?id=14211
        Move the BarInfo object out of the JS bindings

        * DerivedSources.make:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/kjs_window.cpp:
        (KJS::WindowPrivate::WindowPrivate):
        (KJS::Window::mark):
        (KJS::Window::getValueProperty):
        (KJS::Window::clearHelperObjectProperties):
        (KJS::Window::disconnectFrame):
        * bindings/js/kjs_window.h:
        (KJS::Window::):
        * page/BarInfo.cpp: Added.
        (WebCore::BarInfo::BarInfo):
        (WebCore::BarInfo::disconnectFrame):
        (WebCore::BarInfo::visible):
        * page/BarInfo.h: Added.
        (WebCore::BarInfo::):
        * page/BarInfo.idl: Added.
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::~DOMWindow):
        (WebCore::DOMWindow::disconnectFrame):
        (WebCore::DOMWindow::locationbar):
        (WebCore::DOMWindow::menubar):
        (WebCore::DOMWindow::personalbar):
        (WebCore::DOMWindow::scrollbars):
        (WebCore::DOMWindow::statusbar):
        (WebCore::DOMWindow::toolbar):
        * page/DOMWindow.h:
        * page/DOMWindow.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoReflect the library name change for WebKitQt in the perl scripts. Patch from
staikos [Mon, 18 Jun 2007 22:04:54 +0000 (22:04 +0000)]
Reflect the library name change for WebKitQt in the perl scripts.  Patch from
Adam Treat

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoGroundwork for Ctrl+Enter URL bar support.
hyatt [Mon, 18 Jun 2007 20:11:31 +0000 (20:11 +0000)]
Groundwork for Ctrl+Enter URL bar support.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
weinig [Mon, 18 Jun 2007 17:15:07 +0000 (17:15 +0000)]
LayoutTests:

        Reviewed by Darin.

        Update tests now that window.frames points to window and not FrameArray
        (which has been removed).

        * fast/dom/Window/resources/window-appendages-cleared-results.html:
        * fast/dom/Window/window-appendages-cleared-expected.txt:
        * fast/dom/Window/window-appendages-cleared.html:
        * fast/dom/Window/window-properties-expected.txt:
        * fast/js/toString-and-valueOf-override-expected.txt:
        * fast/js/toString-and-valueOf-override.html:

WebCore:

        Reviewed by Darin.

        Remove the FrameArray class and instead make window.frames another
        self-reference for window (like window.window, window.self, etc).
        This is what Firefox and what the HTML5 dictates.

        * bindings/js/kjs_window.cpp:
        (KJS::WindowPrivate::WindowPrivate):
        (KJS::Window::mark):
        (KJS::Window::getValueProperty):
        (KJS::Window::clearHelperObjectProperties):
        (KJS::Window::disconnectFrame):
        * bindings/js/kjs_window.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-06-18 Jake Helfert <jake@jakeonthenet.com>
bdash [Mon, 18 Jun 2007 16:58:33 +0000 (16:58 +0000)]
2007-06-18  Jake Helfert  <jake@jakeonthenet.com>

        Reviewed by Adam.

        - fix http://bugs.webkit.org/show_bug.cgi?id=14154
          Spinneret doesn't build against the new Win32 port.

        * Spinneret/Spinneret/Spinneret.cpp:
        (_tWinMain):
            -Changed IWebViewExt to IWebViewPrivate
            -Changed Co[Un]initialize to Ole[Un]initialize because WebKit now calls
             the WIN32 function RegisterDragDrop which requires the Ole* calls.
        * Spinneret/Spinneret/Spinneret.h:
        (SpinneretWebHost::didReceiveIcon): Updated method signature.
        (SpinneretWebHost::willPerformClientRedirectToURL): Updated method signature.
        (SpinneretWebHost::windowScriptObjectAvailable): Updated method signature.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-06-18 Mitz Pettel <mitz@webkit.org>
bdash [Mon, 18 Jun 2007 16:55:20 +0000 (16:55 +0000)]
2007-06-18  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Adele.

        - fix http://bugs.webkit.org/show_bug.cgi?id=13413
          Failed assertion in RenderTextControl::setSelectionRange in Google Spreadsheets

        Test: fast/forms/input-zero-height-focus.html

        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::setSelectionRange): Avoid setting the
        selection in a zero-height text control.

2007-06-18  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Adele.

        - test for http://bugs.webkit.org/show_bug.cgi?id=13413
          Failed assertion in RenderTextControl::setSelectionRange in Google Spreadsheets

        * fast/forms/input-zero-height-focus-expected.txt: Added.
        * fast/forms/input-zero-height-focus.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-06-18 Alp Toker <alp.toker@collabora.co.uk>
bdash [Mon, 18 Jun 2007 16:49:55 +0000 (16:49 +0000)]
2007-06-18  Alp Toker  <alp.toker@collabora.co.uk>

        Reviewed by Sam Weinig.

        http://bugs.webkit.org/show_bug.cgi?id=14052
        Implement SoundGdk

        * WebCore.pro:
        * platform/gdk/SoundGdk.cpp: Added.
        (WebCore::systemBeep):
        * platform/gdk/TemporaryLinkStubs.cpp:
        (WebCore::systemBeep):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdd support for horizontal mouse wheeling (WebKit part).
hyatt [Mon, 18 Jun 2007 07:16:24 +0000 (07:16 +0000)]
Add support for horizontal mouse wheeling (WebKit part).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdd support for horizontal mouse wheeling (WebCore part).
hyatt [Mon, 18 Jun 2007 07:14:46 +0000 (07:14 +0000)]
Add support for horizontal mouse wheeling (WebCore part).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdd support for Ctrl+Mouse Wheel to do text zooming on Win32.
hyatt [Mon, 18 Jun 2007 06:40:31 +0000 (06:40 +0000)]
Add support for Ctrl+Mouse Wheel to do text zooming on Win32.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Win32 build fix.
weinig [Sun, 17 Jun 2007 20:20:42 +0000 (20:20 +0000)]
    Win32 build fix.

        * WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Back out fix for 13972. Quicktime will no longer clip correctly. :(
hyatt [Sun, 17 Jun 2007 05:51:15 +0000 (05:51 +0000)]
    Back out fix for 13972.  Quicktime will no longer clip correctly. :(
        Too many regressions in Mail caused by inserting an extra view into the
        hierarchy.  Can revisit later.

        Reviewed by olliej

        * Plugins/WebPluginController.mm:
        (-[WebPluginController destroyPlugin:]):
        (-[WebPluginController destroyAllPlugins]):
        * WebCoreSupport/WebFrameBridge.mm:
        (-[WebFrameBridge pluginViewWithPackage:attributeNames:attributeValues:baseURL:DOMElement:loadManually:]):
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView addSubview:]):
        (-[WebHTMLView willRemoveSubview:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fix for bugzilla bugs 14183 and 14184, 'repeat' regressed in border-image
hyatt [Sat, 16 Jun 2007 03:14:56 +0000 (03:14 +0000)]
    Fix for bugzilla bugs 14183 and 14184, 'repeat' regressed in border-image
        because of a botched 'round' support removal.  Also update for a change in
        the spec that has the second stretch/round/repeat keyword match the first
        if omitted.

        Reviewed by olliej

        * css/cssparser.cpp:
        (WebCore::BorderImageParseContext::commitBorderImage):
        * platform/graphics/Image.cpp:
        (WebCore::Image::drawTiled):
        * platform/graphics/Image.h:
        (WebCore::Image::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
weinig [Sat, 16 Jun 2007 01:47:23 +0000 (01:47 +0000)]
LayoutTests:

        Reviewed by Darin.

        Update test for http://bugs.webkit.org/show_bug.cgi?id=14053
        Autogenerate JS binding for Rect

        * fast/dom/Window/window-properties-expected.txt:

WebCore:

        Reviewed by Darin.

        Patch for http://bugs.webkit.org/show_bug.cgi?id=14053
        Autogenerate JS binding for Rect

        - Renames RectImpl to Rect, DOMStyleSheetList to JSStyleSheetList
          and DOMRGBColor to JSRGBColor
        - Moves JSStyleSheetList and JSRGBColor into the WebCore namespace.

        * DerivedSources.make:
        * WebCore.pro:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/kjs_css.cpp:
        (WebCore::):
        (WebCore::JSStyleSheetList::JSStyleSheetList):
        (WebCore::JSStyleSheetList::~JSStyleSheetList):
        (WebCore::JSStyleSheetList::getValueProperty):
        (WebCore::JSStyleSheetList::indexGetter):
        (WebCore::JSStyleSheetList::nameGetter):
        (WebCore::JSStyleSheetList::getOwnPropertySlot):
        (WebCore::toJS):
        (WebCore::JSStyleSheetListFunc::callAsFunction):
        (WebCore::JSRGBColor::JSRGBColor):
        (WebCore::JSRGBColor::~JSRGBColor):
        (WebCore::JSRGBColor::getOwnPropertySlot):
        (WebCore::JSRGBColor::getValueProperty):
        (WebCore::getJSRGBColor):
        * bindings/js/kjs_css.h:
        (WebCore::JSStyleSheetList::classInfo):
        (WebCore::JSStyleSheetList::):
        (WebCore::JSStyleSheetList::impl):
        (WebCore::JSRGBColor::classInfo):
        (WebCore::JSRGBColor::):
        (WebCore::JSRGBColor::impl):
        * bindings/objc/DOMUtility.mm:
        (KJS::createDOMWrapper):
        * bindings/scripts/CodeGeneratorJS.pm:
        * bindings/scripts/CodeGeneratorObjC.pm:
        * css/CSSBorderImageValue.cpp:
        (WebCore::CSSBorderImageValue::CSSBorderImageValue):
        * css/CSSBorderImageValue.h:
        * css/CSSPrimitiveValue.cpp:
        (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
        (WebCore::CSSPrimitiveValue::cssText):
        * css/CSSPrimitiveValue.h:
        (WebCore::CSSPrimitiveValue::getRectValue):
        (WebCore::CSSPrimitiveValue::):
        * css/DashboardRegion.h:
        * css/Rect.h: Copied from css/RectImpl.h.
        (WebCore::Rect::~Rect):
        (WebCore::Rect::top):
        (WebCore::Rect::right):
        (WebCore::Rect::bottom):
        (WebCore::Rect::left):
        (WebCore::Rect::setTop):
        (WebCore::Rect::setRight):
        (WebCore::Rect::setBottom):
        (WebCore::Rect::setLeft):
        * css/Rect.idl:
        * css/RectImpl.h: Removed.
        * css/cssparser.cpp:
        (WebCore::CSSParser::parseShape):
        (WebCore::BorderImageParseContext::commitBorderImage):
        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):
        * page/DOMWindow.idl:

WebKit:

        Reviewed by Darin.

        Patch for http://bugs.webkit.org/show_bug.cgi?id=14053
        Autogenerate JS binding for Rect

        - Fix conflicts by using ::Rect instead of Rect.

        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
        (-[WebBaseNetscapePluginView sendEvent:]):
        (-[WebBaseNetscapePluginView tellQuickTimeToChill]):
        (-[WebBaseNetscapePluginView invalidateRegion:]):
        (-[WebBaseNetscapePluginView _printedPluginBitmap]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Kevin.
andersca [Fri, 15 Jun 2007 22:07:55 +0000 (22:07 +0000)]
    Reviewed by Kevin.

        A better fix for <rdar://problem/5271774>. Only try to access the element if the
        view has an associated window. This also works with GC. (Fix suggested by Kevin.)

        * Plugins/WebKitPluginContainerView.mm:
        (-[WebKitPluginContainerView dealloc]):
        (-[WebKitPluginContainerView visibleRect]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Kevin.
andersca [Fri, 15 Jun 2007 21:17:47 +0000 (21:17 +0000)]
    Reviewed by Kevin.

        <rdar://problem/5271774> REGRESSION: A crash occurs when closing a window that contains a QT movie

        In some cases, calling [super dealloc] might end up calling visibleRect, so make sure to
        set _element to 0 so we won't send a message to a freed object and crash.

        * Plugins/WebKitPluginContainerView.mm:
        (-[WebKitPluginContainerView dealloc]):
        (-[WebKitPluginContainerView visibleRect]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdd evaluateJavaScript() method
staikos [Fri, 15 Jun 2007 02:51:14 +0000 (02:51 +0000)]
Add evaluateJavaScript() method

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdd quite a bit of keyboard handling in editing and non-editing mode for
staikos [Fri, 15 Jun 2007 02:31:55 +0000 (02:31 +0000)]
Add quite a bit of keyboard handling in editing and non-editing mode for
QtWebKit, as well as some focus fixes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fix Windows build.
andersca [Thu, 14 Jun 2007 22:15:04 +0000 (22:15 +0000)]
    Fix Windows build.

        * bindings/runtime_object.cpp:
        (RuntimeObjectImp::canPut):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix for missing text in non-English Windows installs.
hyatt [Thu, 14 Jun 2007 21:58:39 +0000 (21:58 +0000)]
Fix for missing text in non-English Windows installs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
andersca [Thu, 14 Jun 2007 21:43:03 +0000 (21:43 +0000)]
JavaScriptCore:

        Reviewed by Darin.

        <rdar://problem/5103077>
        Crash at _NPN_ReleaseObject when quitting page at http://eshop.macsales.com/shop/ModBook

        <rdar://problem/5183692>
        http://bugs.webkit.org/show_bug.cgi?id=13547
        REGRESSION: Crash in _NPN_ReleaseObject when closing Safari on nba.com (13547)

        <rdar://problem/5261499>
        CrashTracer: [USER] 75 crashes in Safari at com.apple.JavaScriptCore: KJS::Bindings::CInstance::~CInstance + 40

        Have the root object track all live instances of RuntimeObjectImp. When invalidating
        the root object, also invalidate all live runtime objects by zeroing out their instance ivar.
        This prevents instances from outliving their plug-ins which lead to crashes.

        * bindings/c/c_utility.cpp:
        (KJS::Bindings::convertValueToNPVariant):
        * bindings/jni/jni_jsobject.cpp:
        (JavaJSObject::convertValueToJObject):
        * bindings/jni/jni_utility.cpp:
        (KJS::Bindings::convertValueToJValue):
        * bindings/objc/objc_runtime.mm:
        (ObjcFallbackObjectImp::callAsFunction):
        * bindings/runtime_array.cpp:
        (RuntimeArray::RuntimeArray):
        * bindings/runtime_array.h:
        (KJS::RuntimeArray::getConcreteArray):
        * bindings/runtime_method.cpp:
        (RuntimeMethod::callAsFunction):
        * bindings/runtime_method.h:
        * bindings/runtime_object.cpp:
        (RuntimeObjectImp::RuntimeObjectImp):
        (RuntimeObjectImp::~RuntimeObjectImp):
        (RuntimeObjectImp::invalidate):
        (RuntimeObjectImp::fallbackObjectGetter):
        (RuntimeObjectImp::fieldGetter):
        (RuntimeObjectImp::methodGetter):
        (RuntimeObjectImp::getOwnPropertySlot):
        (RuntimeObjectImp::put):
        (RuntimeObjectImp::canPut):
        (RuntimeObjectImp::defaultValue):
        (RuntimeObjectImp::implementsCall):
        (RuntimeObjectImp::callAsFunction):
        (RuntimeObjectImp::getPropertyNames):
        (RuntimeObjectImp::throwInvalidAccessError):
        * bindings/runtime_object.h:
        * bindings/runtime_root.cpp:
        (KJS::Bindings::RootObject::invalidate):
        (KJS::Bindings::RootObject::addRuntimeObject):
        (KJS::Bindings::RootObject::removeRuntimeObject):
        * bindings/runtime_root.h:

LayoutTests:

        Reviewed by Darin.

        Add test that manipulates plug-in script objects after the plug-in has been destroyed.

        * plugins/netscape-destroy-plugin-script-objects-expected.txt: Added.
        * plugins/netscape-destroy-plugin-script-objects.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Brady.
weinig [Thu, 14 Jun 2007 21:42:56 +0000 (21:42 +0000)]
    Reviewed by Brady.

        Update set of files to download for cygwin to include
        diffutils and regenerate the zip file.  This should fix
        an issue on vista where svn-create-patch doesn't work.

        * CygwinDownloader/cygwin-downloader.py:
        * CygwinDownloader/cygwin-downloader.zip:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Geoff.
andersca [Thu, 14 Jun 2007 21:08:07 +0000 (21:08 +0000)]
    Reviewed by Geoff.

        Add Frame::cleanupScriptObjectsForPlugin which will invalidate the root object
        for a given plug-in.

        * WebCore.exp:
        * page/Frame.cpp:
        (WebCore::Frame::cleanupScriptObjectsForPlugin):
        * page/Frame.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Geoff.
andersca [Thu, 14 Jun 2007 21:06:24 +0000 (21:06 +0000)]
    Reviewed by Geoff.

        Call cleanupScriptObjectsForPlugin on the frame after destroying the plug-in.

        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView _destroyPlugin]):
        * Plugins/WebPluginController.mm:
        (-[WebPluginController destroyPlugin:]):
        (-[WebPluginController destroyAllPlugins]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-06-14 Mark Rowe <mrowe@apple.com>
bdash [Thu, 14 Jun 2007 18:33:59 +0000 (18:33 +0000)]
2007-06-14  Mark Rowe  <mrowe@apple.com>

        Update script to match new nightly.webkit.org infrastructure.

        * BuildSlaveSupport/build-launcher-dmg:  Upload to the live web server, not the caching proxy.  Let the server know it's a Mac build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Geoff.
andersca [Thu, 14 Jun 2007 17:21:04 +0000 (17:21 +0000)]
    Reviewed by Geoff.

        <rdar://problem/5211677>
        -[WebPreferences setJavaEnabled:] only disables java inside <applet>, not <object>

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::requestObject):
        If the object is a Java MIME type and Java is disabled, don't load the plug-in.

        * platform/MimeTypeRegistry.cpp:
        (WebCore::MimeTypeRegistry::isJavaAppletMIMEType):
        Clean this up and add another applet MIME type.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoImplement the javascript dialogs and file chooser dialog, along with some
staikos [Thu, 14 Jun 2007 17:13:54 +0000 (17:13 +0000)]
Implement the javascript dialogs and file chooser dialog, along with some
cleanups.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdd missing null-init of pointer (will fix an upcoming crash)
staikos [Thu, 14 Jun 2007 16:47:58 +0000 (16:47 +0000)]
Add missing null-init of pointer (will fix an upcoming crash)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
andersca [Thu, 14 Jun 2007 16:13:09 +0000 (16:13 +0000)]
JavaScriptCore:

        Reviewed by Mitz.

        <rdar://problem/5244948>
        Safari keeps on complaining about slow script playing NBC TV video (14133)

        http://bugs.webkit.org/show_bug.cgi?id=14133
        Runaway JavaScript timer fires when spinning around in Google Maps street view

        Make sure to start and stop the timeout checker around calls to JS.

        * bindings/NP_jsobject.cpp:
        (_NPN_InvokeDefault):
        (_NPN_Invoke):
        (_NPN_Evaluate):
        * bindings/jni/jni_jsobject.cpp:
        (JavaJSObject::call):
        (JavaJSObject::eval):

WebCore:

        Reviewed by Mitz.

        <rdar://problem/5244948>
        Safari keeps on complaining about slow script playing NBC TV video (14133)

        http://bugs.webkit.org/show_bug.cgi?id=14133
        Runaway JavaScript timer fires when spinning around in Google Maps street view

        Make sure to start and stop the timeout checker around calls to JS.

        * bindings/objc/WebScriptObject.mm:
        (-[WebScriptObject callWebScriptMethod:withArguments:]):
        (-[WebScriptObject evaluateWebScript:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoRemoved QWebHistoryItem::parent() as it is not implemented and WebCore's
hausmann [Thu, 14 Jun 2007 11:41:01 +0000 (11:41 +0000)]
Removed QWebHistoryItem::parent() as it is not implemented and WebCore's

HistoryItem itself doesn't seem to have a parent pointer either.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoMake it possible to copy QWebHistoryItem objects.
hausmann [Thu, 14 Jun 2007 11:40:02 +0000 (11:40 +0000)]
Make it possible to copy QWebHistoryItem objects.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix mod-by-zero crash when typeahead is triggered on an empty select.
staikos [Thu, 14 Jun 2007 06:59:23 +0000 (06:59 +0000)]
Fix mod-by-zero crash when typeahead is triggered on an empty select.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
darin [Thu, 14 Jun 2007 04:58:04 +0000 (04:58 +0000)]
JavaScriptCore:

        Reviewed by Mark Rowe.

        - fix http://bugs.webkit.org/show_bug.cgi?id=14132
          array sort with > 10000 elements sets elements > 10000 undefined

        Test: fast/js/sort-large-array.html

        * kjs/array_instance.h: Replaced pushUndefinedObjectsToEnd with
        compactForSorting, and removed ExecState parameters.

        * kjs/array_object.cpp:
        (ArrayInstance::sort): Changed to call compactForSorting.
        (ArrayInstance::compactForSorting): Do the get and delete of the
        properties directly on the property map instead of using public
        calls from JSObject. The public calls would just read the undefined
        values from the compacted sort results array!

LayoutTests:

        Reviewed by Mark Rowe.

        - test for http://bugs.webkit.org/show_bug.cgi?id=14132
          array sort with > 10000 elements sets elements > 10000 undefined

        * fast/js/resources/sort-large-array.js: Added.
        * fast/js/sort-large-array-expected.txt: Added.
        * fast/js/sort-large-array.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fix a crash when a request from the plugin resulted
lars [Thu, 14 Jun 2007 04:25:16 +0000 (04:25 +0000)]
    Fix a crash when a request from the plugin resulted
        in a HTTP redirect.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Work around a bug in Qt's QHttp implementation and
lars [Thu, 14 Jun 2007 03:28:36 +0000 (03:28 +0000)]
    Work around a bug in Qt's QHttp implementation and
        get web pages to load again.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix Mac OS X build
staikos [Thu, 14 Jun 2007 02:48:12 +0000 (02:48 +0000)]
Fix Mac OS X build

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agomissed this in my last checkin - obsolete line
staikos [Thu, 14 Jun 2007 02:32:12 +0000 (02:32 +0000)]
missed this in my last checkin - obsolete line

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoCompile without trying to link ourself.
staikos [Thu, 14 Jun 2007 02:24:08 +0000 (02:24 +0000)]
Compile without trying to link ourself.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Disable FastMalloc for the Qt build and make sure we
lars [Thu, 14 Jun 2007 02:23:29 +0000 (02:23 +0000)]
    Disable FastMalloc for the Qt build and make sure we
        don't reimplement the global new/delete operators
        when using the system malloc.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Kevin Decker.
darin [Thu, 14 Jun 2007 01:11:30 +0000 (01:11 +0000)]
    Reviewed by Kevin Decker.

        - fix <rdar://problem/5264923> Safari frequently "stalls" beneath
          +[NSFont fontWithName:size:] while loading a web page (searching on disk for the font)

        * platform/mac/WebFontCache.mm:
        (+[WebFontCache internalFontWithFamily:traits:size:]): Renamed from fontWithFamily.
        Took out the auto-activation code.
        (+[WebFontCache fontWithFamily:traits:size:]): Added. Calls internalFontWithFamily,
        then calls NSFont to trigger activation if that returned nil, then calls
        internalFontWithFamily again.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
andersca [Thu, 14 Jun 2007 00:10:38 +0000 (00:10 +0000)]
JavaScriptCore:

        Reviewed by Geoff.

        Make sure that bindings instances get correct root objects.

        * JavaScriptCore.exp:
        * bindings/NP_jsobject.cpp:
        (listFromVariantArgs):
        (_NPN_InvokeDefault):
        (_NPN_Invoke):
        (_NPN_SetProperty):
        * bindings/c/c_instance.cpp:
        (KJS::Bindings::CInstance::invokeMethod):
        (KJS::Bindings::CInstance::invokeDefaultMethod):
        * bindings/c/c_runtime.cpp:
        (KJS::Bindings::CField::valueFromInstance):
        * bindings/c/c_utility.cpp:
        (KJS::Bindings::convertNPVariantToValue):
        * bindings/c/c_utility.h:
        * bindings/objc/objc_instance.mm:
        (ObjcInstance::invokeMethod):
        (ObjcInstance::invokeDefaultMethod):
        (ObjcInstance::getValueOfUndefinedField):
        * bindings/objc/objc_runtime.mm:
        (ObjcField::valueFromInstance):
        (ObjcArray::valueAt):
        * bindings/objc/objc_utility.h:
        * bindings/objc/objc_utility.mm:
        (KJS::Bindings::convertObjcValueToValue):
        * bindings/runtime.h:

WebCore:

        Reviewed by Geoff.

        Pass the root object to methods that end up creating new ObjcInstance objects.

        * bindings/objc/WebScriptObject.mm:
        (listFromNSArray):
        (-[WebScriptObject callWebScriptMethod:withArguments:]):
        (-[WebScriptObject evaluateWebScript:]):
        (-[WebScriptObject setValue:forKey:]):
        (-[WebScriptObject valueForKey:]):
        (-[WebScriptObject removeWebScriptKey:]):
        (-[WebScriptObject setWebScriptValueAtIndex:value:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
andersca [Wed, 13 Jun 2007 23:31:36 +0000 (23:31 +0000)]
    Reviewed by Darin.

        <rdar://problem/5267992>
        Make sure an alert doesn't allow loading to continue inside a script.

        Make sure to defer all loads where it's possible for a second main loop to be running.

        * page/Chrome.cpp:
        (WebCore::Chrome::runModal):
        (WebCore::Chrome::runBeforeUnloadConfirmPanel):
        (WebCore::Chrome::runJavaScriptAlert):
        (WebCore::Chrome::runJavaScriptConfirm):
        (WebCore::Chrome::runJavaScriptPrompt):
        (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
        (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):

        * platform/network/cf/ResourceHandleCFNet.cpp:
        (WebCore::ResourceHandle::setDefersLoading):
        Implement this.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adele Peterson
sullivan [Wed, 13 Jun 2007 22:26:03 +0000 (22:26 +0000)]
    Reviewed by Adele Peterson

        - fixed <rdar://problem/5267607> Clicking the "Save to Downloads" button in
          PDF overlay too soon results in corrupt file

        * WebView/WebPDFView.mm:
        (-[WebPDFView PDFViewSavePDFToDownloadFolder:]):
        Just beep if the document isn't available yet, since trying to save it as a file
        really isn't a good idea.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-06-13 Alp Toker <alp.toker@collabora.co.uk>
bdash [Wed, 13 Jun 2007 20:39:42 +0000 (20:39 +0000)]
2007-06-13  Alp Toker  <alp.toker@collabora.co.uk>

        Reviewed by Rob.

        http://bugs.webkit.org/show_bug.cgi?id=14060
        Cairo SVG support

        * WebCore.pro: Add new files to the build.
        * platform/graphics/svg/SVGPaintServerPattern.h:
        * platform/graphics/svg/SVGPaintServerSolid.h:
        * platform/graphics/svg/cairo: Added.
        * platform/graphics/svg/cairo/RenderPathCairo.cpp: Added.
        (WebCore::RenderPath::strokeContains):
        (WebCore::RenderPath::strokeBBox):
        * platform/graphics/svg/cairo/SVGPaintServerCairo.cpp: Added.
        (WebCore::SVGPaintServer::draw):
        (WebCore::SVGPaintServer::teardown):
        (WebCore::SVGPaintServer::renderPath):
        * platform/graphics/svg/cairo/SVGPaintServerGradientCairo.cpp: Added.
        (WebCore::SVGPaintServerGradient::setup):
        * platform/graphics/svg/cairo/SVGPaintServerPatternCairo.cpp: Added.
        (WebCore::SVGPaintServerPattern::setup):
        * platform/graphics/svg/cairo/SVGPaintServerSolidCairo.cpp: Added.
        (WebCore::SVGPaintServerSolid::setup):
        * platform/graphics/svg/cairo/SVGResourceClipperCairo.cpp: Added.
        (WebCore::SVGResourceClipper::applyClip):
        * platform/graphics/svg/cairo/SVGResourceMaskerCairo.cpp: Added.
        (WebCore::SVGResourceMasker::applyMask):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix the build: WebKitQt is now called QtWebKit
hausmann [Wed, 13 Jun 2007 15:01:28 +0000 (15:01 +0000)]
Fix the build: WebKitQt is now called QtWebKit

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdded a make install target that installs the Qt port and renamed
hausmann [Wed, 13 Jun 2007 14:38:36 +0000 (14:38 +0000)]
Added a make install target that installs the Qt port and renamed
WebKitQt to QtWebKit

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdded httpHeaderField setter/getter to QWebNetworkRequest for convenience.
hausmann [Wed, 13 Jun 2007 13:05:27 +0000 (13:05 +0000)]
Added httpHeaderField setter/getter to QWebNetworkRequest for convenience.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoChanged QWebObjectPluginConnector::requestUrl to take a QWebNetworkRequest as argument.
hausmann [Wed, 13 Jun 2007 13:05:16 +0000 (13:05 +0000)]
Changed QWebObjectPluginConnector::requestUrl to take a QWebNetworkRequest as argument.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdded a QWebNetworkRequest convenience constructor.
hausmann [Wed, 13 Jun 2007 13:05:01 +0000 (13:05 +0000)]
Added a QWebNetworkRequest convenience constructor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoChanged the QWebPage::open(const QUrl &url, const QHttpRequestHeader &httpHeader...
hausmann [Wed, 13 Jun 2007 13:04:50 +0000 (13:04 +0000)]
Changed the QWebPage::open(const QUrl &url, const QHttpRequestHeader &httpHeader, const QByteArray &postData)
overload to take a QWebNetworkRequest instead.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoIn QWebPage::open(const QUrl &, const QHttpRequestHeader &, ...) don't make the popul...
hausmann [Wed, 13 Jun 2007 13:04:40 +0000 (13:04 +0000)]
In QWebPage::open(const QUrl &, const QHttpRequestHeader &, ...) don't make the population
of the WebCore::ResourceRequest depend on the validity of the QHttpRequestHeader but just
pick the individual fields if we can use them.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoMinor QWebNetworkRequet API fixlet
hausmann [Wed, 13 Jun 2007 13:04:29 +0000 (13:04 +0000)]
Minor QWebNetworkRequet API fixlet

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23495 268f45cc-cd09-0410-ab3c-d52691b4dbfc