mjs [Thu, 6 Sep 2007 10:09:13 +0000 (10:09 +0000)]
Not reviewed - copy of WebKitDetect script from wiki
* misc/WebKitDetect.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25384
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Thu, 6 Sep 2007 09:25:06 +0000 (09:25 +0000)]
Reviewed by Oliver Hunt.
- fixed <rdar://problem/
5455457> REGRESSION (9A527-9A535): Colloquy crash on launch in WebCoreScriptDebugger initWithDelegate (with announce.js plug-in installed)
* page/mac/FrameMac.mm:
(WebCore::Frame::windowScriptObject): Ensure that -[WebView
windowScriptObject] and -[WebFrame windowObject] return null until
the windowScriptObjectAvailable: delegate method is sent.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25383
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver [Thu, 6 Sep 2007 04:34:16 +0000 (04:34 +0000)]
Reviewed by Stephanie.
Moved a number of tests from platform/mac that are not currently cross-platform,
but should eventually be updated to work across all platforms.
* editing/deleting/
5300379-expected.checksum: Copied from platform/mac/editing/deleting/
5300379-expected.checksum.
* editing/deleting/
5300379-expected.png: Copied from platform/mac/editing/deleting/
5300379-expected.png.
* editing/deleting/
5300379-expected.txt: Copied from platform/mac/editing/deleting/
5300379-expected.txt.
* editing/deleting/
5300379.html: Copied from platform/mac/editing/deleting/
5300379.html.
* editing/deleting/delete-to-end-of-paragraph-expected.checksum: Copied from platform/mac/editing/deleting/delete-to-end-of-paragraph-expected.checksum.
* editing/deleting/delete-to-end-of-paragraph-expected.png: Copied from platform/mac/editing/deleting/delete-to-end-of-paragraph-expected.png.
* editing/deleting/delete-to-end-of-paragraph-expected.txt: Copied from platform/mac/editing/deleting/delete-to-end-of-paragraph-expected.txt.
* editing/deleting/delete-to-end-of-paragraph.html: Copied from platform/mac/editing/deleting/delete-to-end-of-paragraph.html.
* editing/deleting/smart-delete-003-expected.checksum: Copied from platform/mac/editing/deleting/smart-delete-003-expected.checksum.
* editing/deleting/smart-delete-003-expected.png: Copied from platform/mac/editing/deleting/smart-delete-003-expected.png.
* editing/deleting/smart-delete-003-expected.txt: Copied from platform/mac/editing/deleting/smart-delete-003-expected.txt.
* editing/deleting/smart-delete-003.html: Copied from platform/mac/editing/deleting/smart-delete-003.html.
* editing/deleting/smart-delete-004-expected.checksum: Copied from platform/mac/editing/deleting/smart-delete-004-expected.checksum.
* editing/deleting/smart-delete-004-expected.png: Copied from platform/mac/editing/deleting/smart-delete-004-expected.png.
* editing/deleting/smart-delete-004-expected.txt: Copied from platform/mac/editing/deleting/smart-delete-004-expected.txt.
* editing/deleting/smart-delete-004.html: Copied from platform/mac/editing/deleting/smart-delete-004.html.
* editing/execCommand/nsresponder-indent-expected.checksum: Copied from platform/mac/editing/execCommand/nsresponder-indent-expected.checksum.
* editing/execCommand/nsresponder-indent-expected.png: Copied from platform/mac/editing/execCommand/nsresponder-indent-expected.png.
* editing/execCommand/nsresponder-indent-expected.txt: Copied from platform/mac/editing/execCommand/nsresponder-indent-expected.txt.
* editing/execCommand/nsresponder-indent.html: Copied from platform/mac/editing/execCommand/nsresponder-indent.html.
* editing/execCommand/nsresponder-outdent-expected.checksum: Copied from platform/mac/editing/execCommand/nsresponder-outdent-expected.checksum.
* editing/execCommand/nsresponder-outdent-expected.png: Copied from platform/mac/editing/execCommand/nsresponder-outdent-expected.png.
* editing/execCommand/nsresponder-outdent-expected.txt: Copied from platform/mac/editing/execCommand/nsresponder-outdent-expected.txt.
* editing/execCommand/nsresponder-outdent.html: Copied from platform/mac/editing/execCommand/nsresponder-outdent.html.
* editing/selection/
4947387-expected.checksum: Copied from platform/mac/editing/selection/
4947387-expected.checksum.
* editing/selection/
4947387-expected.png: Copied from platform/mac/editing/selection/
4947387-expected.png.
* editing/selection/
4947387-expected.txt: Copied from platform/mac/editing/selection/
4947387-expected.txt.
* editing/selection/
4947387.html: Copied from platform/mac/editing/selection/
4947387.html.
* editing/selection/
5195166-1-expected.checksum: Copied from platform/mac/editing/selection/
5195166-1-expected.checksum.
* editing/selection/
5195166-1-expected.png: Copied from platform/mac/editing/selection/
5195166-1-expected.png.
* editing/selection/
5195166-1-expected.txt: Copied from platform/mac/editing/selection/
5195166-1-expected.txt.
* editing/selection/
5195166-1.html: Copied from platform/mac/editing/selection/
5195166-1.html.
* editing/selection/
5195166-2-expected.checksum: Copied from platform/mac/editing/selection/
5195166-2-expected.checksum.
* editing/selection/
5195166-2-expected.png: Copied from platform/mac/editing/selection/
5195166-2-expected.png.
* editing/selection/
5195166-2-expected.txt: Copied from platform/mac/editing/selection/
5195166-2-expected.txt.
* editing/selection/
5195166-2.html: Copied from platform/mac/editing/selection/
5195166-2.html.
* editing/selection/select-line-expected.txt: Copied from platform/mac/editing/selection/select-line-expected.txt.
* editing/selection/select-line.html: Copied from platform/mac/editing/selection/select-line.html.
* editing/selection/selection-actions-expected.checksum: Copied from platform/mac/editing/selection/selection-actions-expected.checksum.
* editing/selection/selection-actions-expected.png: Copied from platform/mac/editing/selection/selection-actions-expected.png.
* editing/selection/selection-actions-expected.txt: Copied from platform/mac/editing/selection/selection-actions-expected.txt.
* editing/selection/selection-actions.html: Copied from platform/mac/editing/selection/selection-actions.html.
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25382
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
harrison [Thu, 6 Sep 2007 01:47:30 +0000 (01:47 +0000)]
Updated results for:
<rdar://problem/
5306171> Mail: The first return after an attachment in multipart/mixed message is lost
* http/tests/security/dataURL/xss-DENIED-from-data-url-to-data-url-expected.txt:
* http/tests/security/javascriptURL/xss-ALLOWED-from-javascript-url-sub-frame-2-level-expected.txt:
* http/tests/security/javascriptURL/xss-ALLOWED-from-javascript-url-to-javscript-url-expected.txt:
* http/tests/security/javascriptURL/xss-ALLOWED-to-javascript-url-sub-frame-2-level-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25381
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Thu, 6 Sep 2007 00:32:36 +0000 (00:32 +0000)]
Reviewed by Kevin McCullough.
Use correct part of the test for cross-platform testing.
* plugins/bindings-test-expected.txt:
* plugins/bindings-test.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25380
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Wed, 5 Sep 2007 23:57:03 +0000 (23:57 +0000)]
Reviewed by Geoff Garen.
Split out mac specific tests from plugins/bindings-test.html into its own test.
* platform/mac/plugins/bindings-test-objc-expected.txt: Added.
* platform/mac/plugins/bindings-test-objc.html: Copied from plugins/bindings-test.html.
* platform/win/Skipped:
* plugins/bindings-test-expected.txt:
* plugins/bindings-test.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25379
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver [Wed, 5 Sep 2007 23:39:55 +0000 (23:39 +0000)]
Reviewed by Adam and Niko.
Force run-webkit-tests to not run the tests in platform/mac
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25378
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Wed, 5 Sep 2007 23:02:38 +0000 (23:02 +0000)]
Fix ALT+key combos so that they go into the DOM.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25377
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Wed, 5 Sep 2007 22:39:32 +0000 (22:39 +0000)]
Reviewed by Geoff Garen.
Don't log DumpRenderTree injected properties in fast/dom/Window/window-properties.html. This change makes
it pass on Windows so it can be removed from the Skipped list.
* fast/dom/Window/window-properties-expected.txt:
* fast/dom/Window/window-properties.html:
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25376
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Wed, 5 Sep 2007 20:58:28 +0000 (20:58 +0000)]
Reviewed by Oliver.
Fix many layout test failures caused by r25364.
Set text size to standand size at the begining of each test matching the mac.
* DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
(runTest):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25374
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
harrison [Wed, 5 Sep 2007 20:46:41 +0000 (20:46 +0000)]
WebCore:
Reviewed by Kevin Decker.
<rdar://problem/
5306171> Mail: The first return after an attachment in multipart/mixed message is lost
Test added: editing/selection/toString-1.html
Source changes:
* editing/TextIterator.cpp:
(WebCore::TextIterator::shouldRepresentNodeOffsetZero):
- Remove outdated and erroneous check for m_lastTextNode.
- Fix VisiblePosition check to look for line diff. Simple position diff gives the
wrong answer when the start is table/0 and the current is the first position
inside the content of the table.
LayoutTests:
Reviewed by Kevin Decker.
Testcase for:
<rdar://problem/
5306171> Mail: The first return after an attachment in multipart/mixed message is lost
* editing/selection/toString-1-expected.txt: Added.
* editing/selection/toString-1.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25373
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Wed, 5 Sep 2007 14:24:37 +0000 (14:24 +0000)]
2007-09-05 Mark Rowe <mrowe@apple.com>
Unreviewed Qt build fix.
* wtf/unicode/qt4/UnicodeQt4.h: Fix the constness of the src argument to toUpper to prevent build failures.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25369
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Wed, 5 Sep 2007 06:10:54 +0000 (06:10 +0000)]
2007-09-04 Marvin Decker <marv.decker@gmail.com>
Reviewed by Maciej Stachowiak.
http://bugs.webkit.org/show_bug.cgi?id=15072
Bug 15072: Fix ImageDecoder.cpp to not copy incoming data
Change ImageDecoder::setData to take a SharedBuffer*.
* platform/graphics/cairo/ImageSourceCairo.cpp:
(WebCore::ImageSource::setData):
* platform/image-decoders/ImageDecoder.h:
(WebCore::RGBA32Buffer::bytes):
(WebCore::RGBA32Buffer::height):
(WebCore::ImageDecoder::setData):
* platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::setData):
(WebCore::GIFImageDecoder::frameCount):
(WebCore::GIFImageDecoder::decode):
(WebCore::GIFImageDecoder::decodingHalted):
(WebCore::GIFImageDecoder::initFrameBuffer):
* platform/image-decoders/gif/GIFImageDecoder.h:
* platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
(WebCore::JPEGImageDecoder::setData):
(WebCore::JPEGImageDecoder::decode):
* platform/image-decoders/jpeg/JPEGImageDecoder.h:
* platform/image-decoders/png/PNGImageDecoder.cpp:
(WebCore::PNGImageDecoder::setData):
(WebCore::PNGImageDecoder::decode):
(WebCore::PNGImageDecoder::headerAvailable):
(WebCore::PNGImageDecoder::rowAvailable):
* platform/image-decoders/png/PNGImageDecoder.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25368
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver [Wed, 5 Sep 2007 05:16:53 +0000 (05:16 +0000)]
RS=Adam
Moving a number of mac specific tests into LayoutTests/platform/mac so that they
don't need to be in the windows Skiplist.
This includes most of the tests that used textInputController as it is a test
of the mac-specific NSTextInput API.
* editing/deleting/
5300379-expected.checksum: Removed.
* editing/deleting/
5300379-expected.png: Removed.
* editing/deleting/
5300379-expected.txt: Removed.
* editing/deleting/
5300379.html: Removed.
* editing/deleting/delete-to-end-of-paragraph-expected.checksum: Removed.
* editing/deleting/delete-to-end-of-paragraph-expected.png: Removed.
* editing/deleting/delete-to-end-of-paragraph-expected.txt: Removed.
* editing/deleting/delete-to-end-of-paragraph.html: Removed.
* editing/deleting/smart-delete-003-expected.checksum: Removed.
* editing/deleting/smart-delete-003-expected.png: Removed.
* editing/deleting/smart-delete-003-expected.txt: Removed.
* editing/deleting/smart-delete-003.html: Removed.
* editing/deleting/smart-delete-004-expected.checksum: Removed.
* editing/deleting/smart-delete-004-expected.png: Removed.
* editing/deleting/smart-delete-004-expected.txt: Removed.
* editing/deleting/smart-delete-004.html: Removed.
* editing/execCommand/nsresponder-indent-expected.checksum: Removed.
* editing/execCommand/nsresponder-indent-expected.png: Removed.
* editing/execCommand/nsresponder-indent-expected.txt: Removed.
* editing/execCommand/nsresponder-indent.html: Removed.
* editing/execCommand/nsresponder-outdent-expected.checksum: Removed.
* editing/execCommand/nsresponder-outdent-expected.png: Removed.
* editing/execCommand/nsresponder-outdent-expected.txt: Removed.
* editing/execCommand/nsresponder-outdent.html: Removed.
* editing/input/firstrectforcharacterrange-plain-expected.txt: Removed.
* editing/input/firstrectforcharacterrange-plain.html: Removed.
* editing/input/firstrectforcharacterrange-styled-expected.txt: Removed.
* editing/input/firstrectforcharacterrange-styled.html: Removed.
* editing/input/mac: Removed.
* editing/input/mac/hangul-enter-confirms-and-sends-keypress-expected.txt: Removed.
* editing/input/mac/hangul-enter-confirms-and-sends-keypress.html: Removed.
* editing/input/mac/hangul.js: Removed.
* editing/input/mac/kotoeri-enter-to-confirm-and-newline-expected.txt: Removed.
* editing/input/mac/kotoeri-enter-to-confirm-and-newline.html: Removed.
* editing/input/mac/kotoeri.js: Removed.
* editing/input/mac/logger.js: Removed.
* editing/input/range-for-empty-document-expected.txt: Removed.
* editing/input/range-for-empty-document.html: Removed.
* editing/input/replace-invalid-range-expected.txt: Removed.
* editing/input/replace-invalid-range.html: Removed.
* editing/input/text-input-controller-expected.txt: Removed.
* editing/input/text-input-controller.html: Removed.
* editing/input/wrapped-line-char-rect-expected.txt: Removed.
* editing/input/wrapped-line-char-rect.html: Removed.
* editing/selection/
4947387-expected.checksum: Removed.
* editing/selection/
4947387-expected.png: Removed.
* editing/selection/
4947387-expected.txt: Removed.
* editing/selection/
4947387.html: Removed.
* editing/selection/
5195166-1-expected.checksum: Removed.
* editing/selection/
5195166-1-expected.png: Removed.
* editing/selection/
5195166-1-expected.txt: Removed.
* editing/selection/
5195166-1.html: Removed.
* editing/selection/
5195166-2-expected.checksum: Removed.
* editing/selection/
5195166-2-expected.png: Removed.
* editing/selection/
5195166-2-expected.txt: Removed.
* editing/selection/
5195166-2.html: Removed.
* editing/selection/select-line-expected.txt: Removed.
* editing/selection/select-line.html: Removed.
* editing/selection/selection-actions-expected.checksum: Removed.
* editing/selection/selection-actions-expected.png: Removed.
* editing/selection/selection-actions-expected.txt: Removed.
* editing/selection/selection-actions.html: Removed.
* fast/AppleScript: Removed.
* fast/AppleScript/001-expected.txt: Removed.
* fast/AppleScript/001.html: Removed.
* fast/AppleScript/array-expected.txt: Removed.
* fast/AppleScript/array.html: Removed.
* fast/AppleScript/date-expected.txt: Removed.
* fast/AppleScript/date.html: Removed.
* fast/dom/character-index-for-point-expected.txt: Removed.
* fast/dom/character-index-for-point.html: Removed.
* fast/dom/wrapper-identity-expected.txt: Removed.
* fast/dom/wrapper-identity.html: Removed.
* fast/dom/wrapper-round-tripping-expected.txt: Removed.
* fast/dom/wrapper-round-tripping.html: Removed.
* fast/encoding/char-decoding-mac-expected.txt: Removed.
* fast/encoding/char-decoding-mac.html: Removed.
* fast/forms/attributed-strings-expected.txt: Removed.
* fast/forms/attributed-strings.html: Removed.
* fast/objc: Removed.
* fast/objc/longlongTest-expected.txt: Removed.
* fast/objc/longlongTest.html: Removed.
* fast/text/attributed-substring-from-range-001-expected.txt: Removed.
* fast/text/attributed-substring-from-range-001.html: Removed.
* fast/text/attributed-substring-from-range-expected.txt: Removed.
* fast/text/attributed-substring-from-range-in-textfield-expected.txt: Removed.
* fast/text/attributed-substring-from-range-in-textfield.html: Removed.
* fast/text/attributed-substring-from-range.html: Removed.
* fast/text/justified-text-rect-expected.checksum: Removed.
* fast/text/justified-text-rect-expected.png: Removed.
* fast/text/justified-text-rect-expected.txt: Removed.
* fast/text/justified-text-rect.html: Removed.
* platform/mac/editing/deleting/
5300379-expected.checksum: Copied from editing/deleting/
5300379-expected.checksum.
* platform/mac/editing/deleting/
5300379-expected.png: Copied from editing/deleting/
5300379-expected.png.
* platform/mac/editing/deleting/
5300379-expected.txt: Copied from editing/deleting/
5300379-expected.txt.
* platform/mac/editing/deleting/
5300379.html: Copied from editing/deleting/
5300379.html.
* platform/mac/editing/deleting/delete-to-end-of-paragraph-expected.checksum: Copied from editing/deleting/delete-to-end-of-paragraph-expected.checksum.
* platform/mac/editing/deleting/delete-to-end-of-paragraph-expected.png: Copied from editing/deleting/delete-to-end-of-paragraph-expected.png.
* platform/mac/editing/deleting/delete-to-end-of-paragraph-expected.txt: Copied from editing/deleting/delete-to-end-of-paragraph-expected.txt.
* platform/mac/editing/deleting/delete-to-end-of-paragraph.html: Copied from editing/deleting/delete-to-end-of-paragraph.html.
* platform/mac/editing/deleting/smart-delete-003-expected.checksum: Copied from editing/deleting/smart-delete-003-expected.checksum.
* platform/mac/editing/deleting/smart-delete-003-expected.png: Copied from editing/deleting/smart-delete-003-expected.png.
* platform/mac/editing/deleting/smart-delete-003-expected.txt: Copied from editing/deleting/smart-delete-003-expected.txt.
* platform/mac/editing/deleting/smart-delete-003.html: Copied from editing/deleting/smart-delete-003.html.
* platform/mac/editing/deleting/smart-delete-004-expected.checksum: Copied from editing/deleting/smart-delete-004-expected.checksum.
* platform/mac/editing/deleting/smart-delete-004-expected.png: Copied from editing/deleting/smart-delete-004-expected.png.
* platform/mac/editing/deleting/smart-delete-004-expected.txt: Copied from editing/deleting/smart-delete-004-expected.txt.
* platform/mac/editing/deleting/smart-delete-004.html: Copied from editing/deleting/smart-delete-004.html.
* platform/mac/editing/execCommand/nsresponder-indent-expected.checksum: Copied from editing/execCommand/nsresponder-indent-expected.checksum.
* platform/mac/editing/execCommand/nsresponder-indent-expected.png: Copied from editing/execCommand/nsresponder-indent-expected.png.
* platform/mac/editing/execCommand/nsresponder-indent-expected.txt: Copied from editing/execCommand/nsresponder-indent-expected.txt.
* platform/mac/editing/execCommand/nsresponder-indent.html: Copied from editing/execCommand/nsresponder-indent.html.
* platform/mac/editing/execCommand/nsresponder-outdent-expected.checksum: Copied from editing/execCommand/nsresponder-outdent-expected.checksum.
* platform/mac/editing/execCommand/nsresponder-outdent-expected.png: Copied from editing/execCommand/nsresponder-outdent-expected.png.
* platform/mac/editing/execCommand/nsresponder-outdent-expected.txt: Copied from editing/execCommand/nsresponder-outdent-expected.txt.
* platform/mac/editing/execCommand/nsresponder-outdent.html: Copied from editing/execCommand/nsresponder-outdent.html.
* platform/mac/editing/input: Copied from editing/input/mac.
* platform/mac/editing/input/firstrectforcharacterrange-plain-expected.txt: Copied from editing/input/firstrectforcharacterrange-plain-expected.txt.
* platform/mac/editing/input/firstrectforcharacterrange-plain.html: Copied from editing/input/firstrectforcharacterrange-plain.html.
* platform/mac/editing/input/firstrectforcharacterrange-styled-expected.txt: Copied from editing/input/firstrectforcharacterrange-styled-expected.txt.
* platform/mac/editing/input/firstrectforcharacterrange-styled.html: Copied from editing/input/firstrectforcharacterrange-styled.html.
* platform/mac/editing/input/range-for-empty-document-expected.txt: Copied from editing/input/range-for-empty-document-expected.txt.
* platform/mac/editing/input/range-for-empty-document.html: Copied from editing/input/range-for-empty-document.html.
* platform/mac/editing/input/replace-invalid-range-expected.txt: Copied from editing/input/replace-invalid-range-expected.txt.
* platform/mac/editing/input/replace-invalid-range.html: Copied from editing/input/replace-invalid-range.html.
* platform/mac/editing/input/text-input-controller-expected.txt: Copied from editing/input/text-input-controller-expected.txt.
* platform/mac/editing/input/text-input-controller.html: Copied from editing/input/text-input-controller.html.
* platform/mac/editing/input/wrapped-line-char-rect-expected.txt: Copied from editing/input/wrapped-line-char-rect-expected.txt.
* platform/mac/editing/input/wrapped-line-char-rect.html: Copied from editing/input/wrapped-line-char-rect.html.
* platform/mac/editing/selection/
4947387-expected.checksum: Copied from editing/selection/
4947387-expected.checksum.
* platform/mac/editing/selection/
4947387-expected.png: Copied from editing/selection/
4947387-expected.png.
* platform/mac/editing/selection/
4947387-expected.txt: Copied from editing/selection/
4947387-expected.txt.
* platform/mac/editing/selection/
4947387.html: Copied from editing/selection/
4947387.html.
* platform/mac/editing/selection/
5195166-1-expected.checksum: Copied from editing/selection/
5195166-1-expected.checksum.
* platform/mac/editing/selection/
5195166-1-expected.png: Copied from editing/selection/
5195166-1-expected.png.
* platform/mac/editing/selection/
5195166-1-expected.txt: Copied from editing/selection/
5195166-1-expected.txt.
* platform/mac/editing/selection/
5195166-1.html: Copied from editing/selection/
5195166-1.html.
* platform/mac/editing/selection/
5195166-2-expected.checksum: Copied from editing/selection/
5195166-2-expected.checksum.
* platform/mac/editing/selection/
5195166-2-expected.png: Copied from editing/selection/
5195166-2-expected.png.
* platform/mac/editing/selection/
5195166-2-expected.txt: Copied from editing/selection/
5195166-2-expected.txt.
* platform/mac/editing/selection/
5195166-2.html: Copied from editing/selection/
5195166-2.html.
* platform/mac/editing/selection/select-line-expected.txt: Copied from editing/selection/select-line-expected.txt.
* platform/mac/editing/selection/select-line.html: Copied from editing/selection/select-line.html.
* platform/mac/editing/selection/selection-actions-expected.checksum: Copied from editing/selection/selection-actions-expected.checksum.
* platform/mac/editing/selection/selection-actions-expected.png: Copied from editing/selection/selection-actions-expected.png.
* platform/mac/editing/selection/selection-actions-expected.txt: Copied from editing/selection/selection-actions-expected.txt.
* platform/mac/editing/selection/selection-actions.html: Copied from editing/selection/selection-actions.html.
* platform/mac/fast/AppleScript: Copied from fast/AppleScript.
* platform/mac/fast/dom: Added.
* platform/mac/fast/dom/character-index-for-point-expected.txt: Copied from fast/dom/character-index-for-point-expected.txt.
* platform/mac/fast/dom/character-index-for-point.html: Copied from fast/dom/character-index-for-point.html.
* platform/mac/fast/dom/wrapper-identity-expected.txt: Copied from fast/dom/wrapper-identity-expected.txt.
* platform/mac/fast/dom/wrapper-identity.html: Copied from fast/dom/wrapper-identity.html.
* platform/mac/fast/dom/wrapper-round-tripping-expected.txt: Copied from fast/dom/wrapper-round-tripping-expected.txt.
* platform/mac/fast/dom/wrapper-round-tripping.html: Copied from fast/dom/wrapper-round-tripping.html.
* platform/mac/fast/encoding: Added.
* platform/mac/fast/encoding/char-decoding-mac-expected.txt: Copied from fast/encoding/char-decoding-mac-expected.txt.
* platform/mac/fast/encoding/char-decoding-mac.html: Copied from fast/encoding/char-decoding-mac.html.
* platform/mac/fast/forms: Added.
* platform/mac/fast/forms/attributed-strings-expected.txt: Copied from fast/forms/attributed-strings-expected.txt.
* platform/mac/fast/forms/attributed-strings.html: Copied from fast/forms/attributed-strings.html.
* platform/mac/fast/objc: Copied from fast/objc.
* platform/mac/fast/text: Added.
* platform/mac/fast/text/attributed-substring-from-range-001-expected.txt: Copied from fast/text/attributed-substring-from-range-001-expected.txt.
* platform/mac/fast/text/attributed-substring-from-range-001.html: Copied from fast/text/attributed-substring-from-range-001.html.
* platform/mac/fast/text/attributed-substring-from-range-expected.txt: Copied from fast/text/attributed-substring-from-range-expected.txt.
* platform/mac/fast/text/attributed-substring-from-range-in-textfield-expected.txt: Copied from fast/text/attributed-substring-from-range-in-textfield-expected.txt.
* platform/mac/fast/text/attributed-substring-from-range-in-textfield.html: Copied from fast/text/attributed-substring-from-range-in-textfield.html.
* platform/mac/fast/text/attributed-substring-from-range.html: Copied from fast/text/attributed-substring-from-range.html.
* platform/mac/fast/text/justified-text-rect-expected.checksum: Copied from fast/text/justified-text-rect-expected.checksum.
* platform/mac/fast/text/justified-text-rect-expected.png: Copied from fast/text/justified-text-rect-expected.png.
* platform/mac/fast/text/justified-text-rect-expected.txt: Copied from fast/text/justified-text-rect-expected.txt.
* platform/mac/fast/text/justified-text-rect.html: Copied from fast/text/justified-text-rect.html.
* platform/mac/plugins: Added.
* platform/mac/plugins/pluginDocumentView-deallocated-dataSource-expected.txt: Copied from plugins/pluginDocumentView-deallocated-dataSource-expected.txt.
* platform/mac/plugins/pluginDocumentView-deallocated-dataSource.html: Copied from plugins/pluginDocumentView-deallocated-dataSource.html.
* platform/win/Skipped:
* plugins/pluginDocumentView-deallocated-dataSource-expected.txt: Removed.
* plugins/pluginDocumentView-deallocated-dataSource.html: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25367
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Wed, 5 Sep 2007 05:15:06 +0000 (05:15 +0000)]
Back out accidentally committed change.
* JavaScriptCore.xcodeproj/project.pbxproj:
* kjs/collector.cpp:
(KJS::Collector::registerThread):
* wtf/FastMalloc.cpp:
(WTF::fastMallocSetIsMultiThreaded):
(WTF::TCMalloc_ThreadCache::GetCache):
(WTF::TCMalloc_ThreadCache::GetCacheIfPresent):
(WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary):
(WTF::do_malloc):
* wtf/FastMallocInternal.h: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25366
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Wed, 5 Sep 2007 05:01:03 +0000 (05:01 +0000)]
Reviewed by Darin.
- Added Vector::appendRange(), which appends to a vector based on a given start and end iterator
- Added keys() and values() functions to HashMap iterators, which give keys-only and values-only iterators
Together, these allow easy copying of a set, or the keys or values of a map, into a Vector. Examples:
HashMap<int, int> map;
HashSet<int> set;
Vector<int> vec;
// ...
vec.appendRange(set.begin(), set.end());
vec.appendRange(map.begin().keys(), map.end().keys());
vec.appendRange(map.begin().values(), map.end().values());
This also allows for a slightly nicer syntax when iterating a map. Instead of saying
(*it)->first, you can say *it.values(). Similarly for keys. Example:
HashMap<int, int>::const_iterator end = map.end();
for (HashMap<int, int>::const_iterator it = map.begin(); it != end; ++it)
printf(" [%d => %d]", *it.keys(), *it.values());
* JavaScriptCore.xcodeproj/project.pbxproj:
* wtf/HashIterators.h: Added.
(WTF::):
(WTF::HashTableConstKeysIterator::HashTableConstKeysIterator):
(WTF::HashTableConstKeysIterator::get):
(WTF::HashTableConstKeysIterator::operator*):
(WTF::HashTableConstKeysIterator::operator->):
(WTF::HashTableConstKeysIterator::operator++):
(WTF::HashTableConstValuesIterator::HashTableConstValuesIterator):
(WTF::HashTableConstValuesIterator::get):
(WTF::HashTableConstValuesIterator::operator*):
(WTF::HashTableConstValuesIterator::operator->):
(WTF::HashTableConstValuesIterator::operator++):
(WTF::HashTableKeysIterator::HashTableKeysIterator):
(WTF::HashTableKeysIterator::get):
(WTF::HashTableKeysIterator::operator*):
(WTF::HashTableKeysIterator::operator->):
(WTF::HashTableKeysIterator::operator++):
(WTF::HashTableKeysIterator::operator HashTableConstKeysIterator<HashTableType, KeyType, MappedType>):
(WTF::HashTableValuesIterator::HashTableValuesIterator):
(WTF::HashTableValuesIterator::get):
(WTF::HashTableValuesIterator::operator*):
(WTF::HashTableValuesIterator::operator->):
(WTF::HashTableValuesIterator::operator++):
(WTF::HashTableValuesIterator::operator HashTableConstValuesIterator<HashTableType, KeyType, MappedType>):
(WTF::operator==):
(WTF::operator!=):
* wtf/HashTable.h:
* wtf/Vector.h:
(WTF::::appendRange):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25365
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Wed, 5 Sep 2007 03:58:16 +0000 (03:58 +0000)]
WebKitTools:
Reviewed by Adam.
Fix for <rdar://problem/
5382277>
Implement eventSender.textZoomIn and eventSender.textZoomOut for windows DRT.
* DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp:
(textZoomInCallback):
(textZoomOutCallback):
LayoutTests:
Reviewed by Adam.
Fix for <rdar://problem/
5382277>
Remove fast/css/ignore-text-zoom.html from skip list now that
eventSender.textZoomIn is supported.
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25364
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Wed, 5 Sep 2007 00:25:31 +0000 (00:25 +0000)]
Reviewed by Darin.
<rdar://problem/
5452908> NIBs saved in the Pre-10.2 format while Safari 3 installed do not work without Safari 3
This happened because we encoded a new field that the old WebKit does not know how to read.
And NSCoder throws an exception if initWithCoder finishes while there is still unread data in the archive.
The WebViewVersion is now 4 to distinguish that we do not encode/decode allowsUndo.
* WebView/WebView.mm:
(-[WebView initWithCoder:]): Only try to read allowsUndo if the version is 3.
(-[WebView encodeWithCoder:]): No longer encode allowsUndo.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25363
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Wed, 5 Sep 2007 00:16:38 +0000 (00:16 +0000)]
Build fix.
* WebKit.vcproj/WebKit.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25362
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Tue, 4 Sep 2007 23:23:36 +0000 (23:23 +0000)]
Fix build bustage.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25361
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Tue, 4 Sep 2007 22:58:27 +0000 (22:58 +0000)]
WebCore:
Fix for <rdar://problem/
5271213>, resizing iChat window is slower than in
Tiger. This patch implements a fast scaling mode that can be used by
WebViews, e.g., during window resizing.
Reviewed by John Sullivan
* WebCore.exp:
* WebCore.xcodeproj/project.pbxproj:
* page/Frame.cpp:
(WebCore::FramePrivate::FramePrivate):
* page/Page.cpp:
(WebCore::Page::Page):
(WebCore::Page::inLowQualityImageInterpolationMode):
(WebCore::Page::setInLowQualityImageInterpolationMode):
* page/Page.h:
* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::drawImage):
* platform/graphics/GraphicsContext.h:
(WebCore::GraphicsContext::setUseLowQualityImageInterpolation):
(WebCore::GraphicsContext::useLowQualityImageInterpolation):
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::setUseLowQualityImageInterpolation):
(WebCore::GraphicsContext::useLowQualityImageInterpolation):
* rendering/RenderImage.cpp:
(WebCore::RenderImage::paint):
WebKit:
Fix for <rdar://problem/
5271213>, resizing iChat window is slower than in
Tiger. This patch implements a fast scaling mode that can be used by
WebViews, e.g., during window resizing.
Reviewed by John Sullivan
* WebView/WebView.mm:
(-[WebView _setUseFastImageScalingMode:]):
(-[WebView _inFastImageScalingMode]):
* WebView/WebViewPrivate.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25360
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Tue, 4 Sep 2007 22:47:51 +0000 (22:47 +0000)]
Reviewed by Hyatt.
* WebView/WebView.mm:
(-[WebView _loadBackForwardListFromOtherView:]): Added missing null check.
(-[WebView _setInitiatedDrag:]): Ditto.
(-[WebView _clearUndoRedoOperations]): Ditto.
(-[WebView encodeWithCoder:]): Ditto.
(-[WebView backForwardList]): Ditto.
(-[WebView setMaintainsBackForwardList:]): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25359
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Tue, 4 Sep 2007 22:14:49 +0000 (22:14 +0000)]
Updated test for <rdar://problem/
5279521>. The old test didn't crash before the fix.
* editing/style/
5279521.html:
* editing/style/
5279521-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25358
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Tue, 4 Sep 2007 21:56:31 +0000 (21:56 +0000)]
Blind attempt at fixing Windows debug build
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25357
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Tue, 4 Sep 2007 20:32:22 +0000 (20:32 +0000)]
Reviewed by Adam
Some SQLite tweaks for debugging
-In debug builds, track the thread that opened the database and enforce that any statements
that operate on the SQLDatabase do so from the thread that opened it
-Track whether or not a transaction is in progress for the SQLDatabase to find cases where
someone opens a new transaction while there is still one outstanding (a SQLite logic error)
* loader/icon/SQLDatabase.cpp:
(WebCore::SQLDatabase::SQLDatabase):
(WebCore::SQLDatabase::open): Track the opening thread. Also, return false if the DB failed to
open instead of trying to run a PRAGMA on it!
(WebCore::SQLDatabase::close): Reset the opening thread
* loader/icon/SQLDatabase.h:
(WebCore::SQLDatabase::transactionInProgress):
(WebCore::SQLDatabase::sqlite3Handle): For access to the raw sqlite3* handle to do a thread
safety check
* loader/icon/SQLStatement.cpp:
(WebCore::SQLStatement::prepare): Use the new sqlite3Handle accessor
(WebCore::SQLStatement::step): Ditto
* loader/icon/SQLTransaction.cpp:
(WebCore::SQLTransaction::SQLTransaction): Removed the c'tor form that could automatically
begin the transaction - never used and shouldn't be in practice!
(WebCore::SQLTransaction::begin): Maintain the transaction-in-progress flag on the DB
(WebCore::SQLTransaction::commit): Ditto
(WebCore::SQLTransaction::rollback): Ditto
* loader/icon/SQLTransaction.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25356
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tristan [Tue, 4 Sep 2007 19:50:56 +0000 (19:50 +0000)]
Reviewed by John Sullivan.
<rdar://problem/
5454935> Can't reply to this message in Mail -- -[DOMRange webArchive] is throwing an exception
* WebView/WebArchiver.mm:
(+[WebArchiver _archiveWithMarkupString:fromFrame:nodes:]):
Guard the creation of WebResource by ensuring that the passed in
responseURL is never nil.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25355
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
harrison [Tue, 4 Sep 2007 16:55:42 +0000 (16:55 +0000)]
WebCore:
Reviewed by Maciej and John.
<rdar://problem/
5452675> CrashTracer: [USER] 10 crashes in Mail at com.apple.WebCore: WebCore::Node::nodeIndex const + 6
* editing/InsertParagraphSeparatorCommand.cpp:
(WebCore::InsertParagraphSeparatorCommand::doApply):
Adjust pos to pos.downstream() after the refNode is calculated, but before the insertion. Doing it earlier
undid the logic of positionAvoidingSpecialElementBoundary(). The downstream is still needed just to set the
ending selection.
LayoutTests:
Reviewed by Maciej and John.
Testcase for:
<rdar://problem/
5452675> CrashTracer: [USER] 10 crashes in Mail at com.apple.WebCore: WebCore::Node::nodeIndex const + 6
* editing/inserting/insert-paragraph-05.html: Added.
* platform/mac/editing/inserting/insert-paragraph-05-expected.checksum: Added.
* platform/mac/editing/inserting/insert-paragraph-05-expected.png: Added.
* platform/mac/editing/inserting/insert-paragraph-05-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25354
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti [Tue, 4 Sep 2007 14:50:03 +0000 (14:50 +0000)]
WebCore:
Reviewed by Maciej.
Fix <rdar://problem/
5452112>
REGRESSION: Initially focused textfield on www.mac.com login page has no insertion point, and doesn't accept typed characters
Use updateLayoutIgnorePendingStylesheets() instead of updateLayout(). We need to have rendering to set input focus.
Test: fast/forms/focus-style-pending.html
* dom/Element.cpp:
(WebCore::Element::focus):
LayoutTests:
Reviewed by Maciej.
Test for <rdar://problem/
5452112>
REGRESSION: Initially focused textfield on www.mac.com login page has no insertion point, and doesn't accept typed characters
* fast/forms/focus-style-pending-expected.txt: Added.
* fast/forms/focus-style-pending.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25353
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann [Tue, 4 Sep 2007 13:02:04 +0000 (13:02 +0000)]
Fixed Qt build on Windows
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25352
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
harrison [Mon, 3 Sep 2007 16:31:20 +0000 (16:31 +0000)]
Reviewed by Kevin Decker.
<rdar://problem/
5456785> REGRESSION (r15963-r15970): Heading text not placed in VoiceOver Item Chooser (15132)
* bridge/mac/WebCoreAXObject.mm:
(-[WebCoreAXObject title]):
For headings, return the text under the element instead of nil.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25351
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zecke [Mon, 3 Sep 2007 13:48:57 +0000 (13:48 +0000)]
2007-08-20 Oleg Sukhodolsky <son.two@gmail.com>
Reviewed by Mark.
WebKitQt/WebCoreSupport should not be added to INCLUDEPATH for gdk-port
* WebCore.pro:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25350
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Mon, 3 Sep 2007 09:56:30 +0000 (09:56 +0000)]
2007-09-03 Mark Rowe <mrowe@apple.com>
Reviewed by Tim Hatcher.
<rdar://problem/
5452164> Production build with in symbols directory has no debug info
Enable debug symbol generation on all build configurations. Production builds are stripped
of symbols by Xcode during deployment post-processing.
* Configurations/Base.xcconfig:
* JavaScriptCore.xcodeproj/project.pbxproj:
2007-09-03 Mark Rowe <mrowe@apple.com>
Reviewed by Tim Hatcher.
<rdar://problem/
5452164> Production build with in symbols directory has no debug info
Enable debug symbol generation on all build configurations. Production builds are stripped
of symbols by Xcode during deployment post-processing.
* Configurations/Base.xcconfig:
* JavaScriptGlue.xcodeproj/project.pbxproj:
2007-09-03 Mark Rowe <mrowe@apple.com>
Reviewed by Tim Hatcher.
<rdar://problem/
5452164> Production build with in symbols directory has no debug info
Enable debug symbol generation on all build configurations. Production builds are stripped
of symbols by Xcode during deployment post-processing.
* Configurations/Base.xcconfig:
* WebCore.xcodeproj/project.pbxproj:
2007-09-03 Mark Rowe <mrowe@apple.com>
Reviewed by Tim Hatcher.
<rdar://problem/
5452164> Production build with in symbols directory has no debug info
Enable debug symbol generation on all build configurations. Production builds are stripped
of symbols by Xcode during deployment post-processing.
* Configurations/Base.xcconfig:
* WebKit.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25349
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Mon, 3 Sep 2007 01:37:26 +0000 (01:37 +0000)]
WebCore:
Reviewed by John Sullivan and Mark Rowe
Groundwork for support for monitoring IconDatabase in-memory statistics
* WebCore.exp:
* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::pageURLMappingCount): Stub for now
(WebCore::IconDatabase::retainedPageURLCount): Ditto
(WebCore::IconDatabase::iconRecordCount): Ditto
(WebCore::IconDatabase::iconRecordCountWithData): Ditto
* loader/icon/IconDatabase.h:
WebKit:
Reviewed by John Sullivan and Mark Rowe
Groundwork for support for monitoring IconDatabase in-memory statistics
* Misc/WebCoreStatistics.h:
* Misc/WebCoreStatistics.mm:
(+[WebCoreStatistics iconPageURLMappingCount]):
(+[WebCoreStatistics iconRetainedPageURLCount]):
(+[WebCoreStatistics iconRecordCount]):
(+[WebCoreStatistics iconsWithDataCount]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25348
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Mon, 3 Sep 2007 01:17:36 +0000 (01:17 +0000)]
2007-09-02 Mark Rowe <mrowe@apple.com>
Reviewed by Antti.
<rdar://problem/
5454704> WebKit seems to get too-narrow widths for "Monotype Corsiva", so lays out incorrectly
* platform/mac/FontDataMac.mm:
(WebCore::FontData::determinePitch): Work around NSFont incorrectly reporting Monotype Corsiva as fixed pitch.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25347
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sun, 2 Sep 2007 04:44:04 +0000 (04:44 +0000)]
WebCore:
- rolled out fix for bug 12988 because it broke getElementById in a layout test
I'm working on a new fix.
* dom/Document.cpp: Rolled out.
LayoutTests:
- rolled out the test case for 12988 until we re-fix it
* fast/dom/duplicate-ids-document-order.html: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25346
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver [Sat, 1 Sep 2007 23:04:59 +0000 (23:04 +0000)]
gtk:
Reviewed by Sam.
<rdar://problem/
5344848> IME is incorrectly used for key events when on non-editable regions
EditorClient::setInputMethodState stub
* WebCoreSupport/EditorClientGtk.cpp:
(WebKit::EditorClient::setInputMethodState):
* WebCoreSupport/EditorClientGtk.h:
WebCore:
Reviewed by Sam.
<rdar://problem/
5344848> IME is incorrectly used for key events when on non-editable regions
Adding a new EditorClient method so it is possible to inform WebKit of focus changes.
Also added new virtual method Node::shouldUseInputMethod to allow us to trivially check
whether an input method should be used when processing input for the currently focused
Node.
* bridge/EditorClient.h:
* dom/Node.cpp:
(WebCore::Node::shouldUseInputMethod):
* dom/Node.h:
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::shouldUseInputMethod):
* html/HTMLInputElement.h:
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::shouldUseInputMethod):
* html/HTMLTextAreaElement.h:
* page/FocusController.cpp:
(WebCore::FocusController::setFocusedNode):
* platform/graphics/svg/SVGImageEmptyClients.h:
(WebCore::SVGEmptyEditorClient::setInputMethodState):
WebKit:
Reviewed by Sam.
<rdar://problem/
5344848> IME is incorrectly used for key events when on non-editable regions
EditorClient::setInputMethodState stub
* WebCoreSupport/WebEditorClient.h:
* WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::setInputMethodState):
WebKitQt:
Reviewed by Sam.
<rdar://problem/
5344848> IME is incorrectly used for key events when on non-editable regions
EditorClient::setInputMethodState stub
* WebCoreSupport/EditorClientQt.cpp:
(WebCore::EditorClientQt::setInputMethodState):
* WebCoreSupport/EditorClientQt.h:
win:
Reviewed by Sam.
<rdar://problem/
5344848> IME is incorrectly used for key events when on non-editable regions
When focusing a password field or a non-editable element we disassociate any IME that may have
been active, and reassociate should a non-password editable element is focused.
This makes password input with an IME active simpler, and brings our IME behaviour in line with
IE.
* WebEditorClient.cpp:
(WebEditorClient::setInputMethodState):
* WebEditorClient.h:
* WebView.cpp:
(IMMDict::IMMDict):
(WebView::setInputMethodState):
* WebView.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25345
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis [Sat, 1 Sep 2007 08:08:33 +0000 (08:08 +0000)]
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=12988
First element (in document order) is not returned when other duplicate ID-ed elements were created first
Reset the element id cache when id's are added or removed and there
are duplicates for that id.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25341
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis [Sat, 1 Sep 2007 07:43:31 +0000 (07:43 +0000)]
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=15083
Some symbols in WebKit do not need to be exported
Do not export these symbols.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25340
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken [Sat, 1 Sep 2007 05:44:27 +0000 (05:44 +0000)]
<rdar://problem/
5432594> Safari quits when hovering over mailto links on a webpage
In addition to substituting %@ with %s, we also need to substitute %{1-9}$@ with %{1-9}$s.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25339
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken [Sat, 1 Sep 2007 00:56:07 +0000 (00:56 +0000)]
Bump version for submit
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25336
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aliceli1 [Fri, 31 Aug 2007 23:02:33 +0000 (23:02 +0000)]
WebCore:
Reviewed by Tim Hatcher.
Fixed <rdar://problem/
5420682> Mail crashes at WebCore::InsertLineBreakCommand::doApply() after dropping a selected image over container's close box
* editing/DeleteButtonController.cpp:
(WebCore::DeleteButtonController::show):
Factored out the code in ::show() that created and styled the elements of the Deletion UI
(WebCore::DeleteButtonController::createDeletionUI):
Neglecting to move the append of the deletionUI elements into the same clause that handles the creation
of them ended up creating multiple elements at were repeatedly appended to the target, resulting in a
bloated table deletion UI which was slow to show and hide.
* editing/DeleteButtonController.h:
(WebCore::DeleteButtonController::enabled):
Restore this function to how it used to be pre-r25305, sans asserts
* editing/EditCommand.cpp:
Add disable/enable sandwich when undoing/redoing commands too
(WebCore::EditCommand::unapply):
(WebCore::EditCommand::reapply):
LayoutTests:
Reviewed by Tim Hatcher.
Test for <rdar://problem/
5420682> Mail crashes at WebCore::InsertLineBreakCommand::doApply() after dropping a selected image over container's close box
* editing/deleting/deletionUI-single-instance.html: Added.
* platform/mac/editing/deleting/deletionUI-single-instance-expected.checksum: Added.
* platform/mac/editing/deleting/deletionUI-single-instance-expected.png: Added.
* platform/mac/editing/deleting/deletionUI-single-instance-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25335
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti [Fri, 31 Aug 2007 22:09:03 +0000 (22:09 +0000)]
Reviewed by Anders.
Fix <rdar://problem/
5452943>
REGRESSION (r25283): Reproducible crash in HTMLObjectElement::getInstance under guard malloc
Calling updateLayoutIgnorePendingStylesheets() may do arbitrary things to render tree so
no RenderObjects can be cached over it.
* html/HTMLEmbedElement.cpp:
(WebCore::findWidgetRenderer):
(WebCore::HTMLEmbedElement::getInstance):
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::getInstance):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25334
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Fri, 31 Aug 2007 21:57:44 +0000 (21:57 +0000)]
Reviewed by Mitz.
<rdar://problem/
5443936>
Crash after QT movie completes playback at apple.com/imac
If the plug-in or one of its children have focus, set it to NULL to prevent the web view window from getting the focus,
which can cause a layout to happen while in HTMLObjectElement::detach. (This is what we do on the Mac).
* plugins/win/PluginViewWin.cpp:
(WebCore::PluginViewWin::setParent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25333
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Fri, 31 Aug 2007 18:51:05 +0000 (18:51 +0000)]
WebCore:
Reviewed by Justin.
Fix for <rdar://problem/
5450600> REGRESSION: can't paste in textfield if its in a body that has user-select:none set (affects widgets)
Test: editing/pasteboard/paste-plaintext-user-select-none.html
* editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::insertFragmentForTestRendering):
Copy the user-select style from the current selection node and apply it so it is considered during the test rendering.
This is important since we recently changed user-select to be inherited. When we consider valid VisiblePositions for the test rendering,
we need to have the correct user-select value that will actually be used for the real insertion.
LayoutTests:
Reviewed by Justin.
Test for <rdar://problem/
5450600> REGRESSION: can't paste in textfield if its in a body that has user-select:none set (affects widgets)
* editing/pasteboard/paste-plaintext-user-select-none-expected.txt: Added.
* editing/pasteboard/paste-plaintext-user-select-none.html: Added.
* fast/forms/textarea-paste-newline.html: Updated to escape '\n' in failure description.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25332
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Fri, 31 Aug 2007 18:16:54 +0000 (18:16 +0000)]
Reviewed by Oliver.
<rdar://problem/
5423939>
http://bugs.webkit.org/show_bug.cgi?id=15013
ASSERTION FAILED !m_inDestructor in WebCore::Shared<WebCore::PluginStreamWin>::ref() on Windows
Protect the stream in case it's destroyed by the plug-in.
* plugins/win/PluginStreamWin.cpp:
(WebCore::PluginStreamWin::didReceiveData):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25331
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Fri, 31 Aug 2007 16:13:54 +0000 (16:13 +0000)]
Reviewed by Anders.
- http://bugs.webkit.org/show_bug.cgi?id=15122
* editing/htmlediting.cpp: (WebCore::avoidIntersectionWithNode):
Change assertion so that it only fires when actually modifying the selection.
This isn't nearly as helpful, because the old assertion could catch potential
problems in more cases, but it's not obvious how to do better.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25330
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver [Fri, 31 Aug 2007 04:33:05 +0000 (04:33 +0000)]
WebCore:
Reviewed by Adam.
<rdar://problem/
5430772> REGRESSION(303-310A5) list items do not show with mouse over on istweb.apple.com/quack.apple.com
VC++ treats bitfields as signed members, so Node::m_styleChange would be
sign extended if it was assigned the value FullStyleChange. This caused
style recalculation to stop propagating.
We work around this VC++ oddity by storing the enum as an unsigned, and
casting back to StyleChangeType in the getter.
Test: fast/css/hover-affects-child.html
* dom/Node.h:
(WebCore::Node::styleChangeType):
LayoutTests:
Reviewed by Adam.
Simple test case to ensure that hover affects are correctly propagated
* fast/css/hover-affects-child-expected.txt: Added.
* fast/css/hover-affects-child.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25329
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Fri, 31 Aug 2007 01:40:25 +0000 (01:40 +0000)]
Fixing comma placement.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25328
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Fri, 31 Aug 2007 01:36:55 +0000 (01:36 +0000)]
WebCore:
Reviewed by Darin.
<rdar://problem/
5368833>
REGRESSION: Pasting a triple-clicked line of quoted text at the top of a message adds an extra, quoted line
* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::insertParagraphSeparator): Added an option for
using a plain div to hold the new paragraph, instead of a clone of the previous
block.
* editing/CompositeEditCommand.h:
* editing/InsertParagraphSeparatorCommand.cpp: Ditto.
(WebCore::InsertParagraphSeparatorCommand::InsertParagraphSeparatorCommand): Ditto.
(WebCore::InsertParagraphSeparatorCommand::doApply): Ditto.
* editing/InsertParagraphSeparatorCommand.h:
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::doApply): Use a default block element when creating
new paragraphs, so that empty paragraphs don't contain the block style of the previous
one.
Don't expand collapsed brs at the end of inserted content, this was the root of the bug.
We'd copy <blockquote>hello<br></blockquote><br class="Apple-interchange-newline">
and get an extra paragraph. The removed code used to make sure that if the copied
selection ends with a paragraph break that is represented in the copied markup by a
regular br (not an interchange newline br), that that paragraph break appears in the
pasted content, but shouldMergeEnd, which was introduced after this code was written,
now takes care of that.
(WebCore::ReplaceSelectionCommand::shouldRemoveEndBR): Inserted content should always
displace placeholder brs, even if that inserted content ends with a br.
* editing/markup.cpp:
(WebCore::needInterchangeNewlineAfter): This code failed to add an interchange newline
if the user copied <div>hello</div><br>, only don't add an interchange newline when
copying ^hello<br>^<br>, because then the copied paragraph break will already be
represented in the copied markup by a br.
(WebCore::createMarkup):
LayoutTests:
Reviewed by Darin.
<rdar://problem/
5368833>
REGRESSION: Pasting a triple-clicked line of quoted text at the top of a message adds an extra, quoted line
Tested for behavior that we no longer want to have:
* editing/pasteboard/quirks-mode-br-2-expected.checksum: Removed.
* editing/pasteboard/quirks-mode-br-2-expected.png: Removed.
* editing/pasteboard/quirks-mode-br-2-expected.txt: Removed.
* editing/pasteboard/quirks-mode-br-2.html: Removed.
* platform/mac/editing/pasteboard: Added.
Demonstrates bug:
* editing/pasteboard/
5368833.html: Added.
* platform/mac/editing/pasteboard/
5368833-expected.checksum: Added.
* platform/mac/editing/pasteboard/
5368833-expected.png: Added.
* platform/mac/editing/pasteboard/
5368833-expected.txt: Added.
Regenerated these expected results to reflect new behavior:
* editing/pasteboard/paste-text-012-expected.checksum: Removed.
* editing/pasteboard/paste-text-012-expected.png: Removed.
* editing/pasteboard/paste-text-012-expected.txt: Removed.
* editing/pasteboard/paste-text-013-expected.checksum: Removed.
* editing/pasteboard/paste-text-016-expected.checksum: Removed.
* editing/pasteboard/paste-text-016-expected.png: Removed.
* editing/pasteboard/paste-text-016-expected.txt: Removed.
* platform/mac/editing/pasteboard/paste-text-012-expected.checksum: Added.
* platform/mac/editing/pasteboard/paste-text-012-expected.png: Added.
* platform/mac/editing/pasteboard/paste-text-012-expected.txt: Added.
* platform/mac/editing/pasteboard/paste-text-013-expected.checksum: Added.
* platform/mac/editing/pasteboard/paste-text-013-expected.png: Added.
* platform/mac/editing/pasteboard/paste-text-013-expected.txt: Added.
* platform/mac/editing/pasteboard/paste-text-016-expected.checksum: Added.
* platform/mac/editing/pasteboard/paste-text-016-expected.png: Added.
* platform/mac/editing/pasteboard/paste-text-016-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25327
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Fri, 31 Aug 2007 00:58:57 +0000 (00:58 +0000)]
Versioning.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25325
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
harrison [Fri, 31 Aug 2007 00:10:48 +0000 (00:10 +0000)]
Reviewed by Darin.
<rdar://problem/
5423900> Seed: safari crashes on submit feedback page in -[WebCoreAXObject isAttachment]
* bridge/mac/WebCoreAXObject.mm:
(-[WebCoreAXObject isAttachment]):
Add nil check since element could be detached.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25323
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Thu, 30 Aug 2007 22:38:20 +0000 (22:38 +0000)]
2007-08-30 Mitz Pettel <mitz@webkit.org>
Reviewed by Dave Hyatt.
- fix http://bugs.webkit.org/show_bug.cgi?id=13282
<rdar://problem/
5126392> REGRESSION (NativePopUp): Rightmost character cut off in pop-up menu
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::updateOptionsWidth): When measuring option text, use
the same WebCore run rounding behavior that is used to draw it in the popup button.
2007-08-30 Mitz Pettel <mitz@webkit.org>
Reviewed by Dave Hyatt.
- updated test results for http://bugs.webkit.org/show_bug.cgi?id=13282
<rdar://problem/
5126392> REGRESSION (NativePopUp): Rightmost character cut off in pop-up menu
* editing/pasteboard/
4641033-expected.checksum:
* editing/pasteboard/
4641033-expected.png:
* editing/pasteboard/
4641033-expected.txt:
* fast/forms/HTMLOptionElement_label02-expected.checksum:
* fast/forms/HTMLOptionElement_label02-expected.png:
* fast/forms/HTMLOptionElement_label02-expected.txt:
* fast/forms/HTMLOptionElement_label03-expected.checksum:
* fast/forms/HTMLOptionElement_label03-expected.png:
* fast/forms/HTMLOptionElement_label03-expected.txt:
* fast/forms/control-restrict-line-height-expected.checksum:
* fast/forms/control-restrict-line-height-expected.png:
* fast/forms/control-restrict-line-height-expected.txt:
* fast/forms/menulist-restrict-line-height-expected.checksum:
* fast/forms/menulist-restrict-line-height-expected.png:
* fast/forms/menulist-restrict-line-height-expected.txt:
* fast/forms/menulist-width-change-expected.checksum:
* fast/forms/menulist-width-change-expected.png:
* fast/forms/menulist-width-change-expected.txt:
* fast/forms/select-change-listbox-to-popup-expected.checksum:
* fast/forms/select-change-listbox-to-popup-expected.png:
* fast/forms/select-change-listbox-to-popup-expected.txt:
* fast/forms/select-disabled-appearance-expected.checksum:
* fast/forms/select-disabled-appearance-expected.png:
* fast/forms/select-disabled-appearance-expected.txt:
* fast/forms/stuff-on-my-optgroup-expected.checksum:
* fast/forms/stuff-on-my-optgroup-expected.png:
* fast/forms/stuff-on-my-optgroup-expected.txt:
* fast/parser/document-write-option-expected.checksum:
* fast/parser/document-write-option-expected.png:
* fast/parser/document-write-option-expected.txt:
* http/tests/navigation/anchor-basic-expected.txt:
* http/tests/navigation/anchor-frames-expected.txt:
* http/tests/navigation/anchor-goback-expected.checksum:
* http/tests/navigation/anchor-goback-expected.png:
* http/tests/navigation/anchor-goback-expected.txt:
* http/tests/navigation/anchor-subframeload-expected.txt:
* http/tests/navigation/javascriptlink-basic-expected.checksum:
* http/tests/navigation/javascriptlink-basic-expected.png:
* http/tests/navigation/javascriptlink-basic-expected.txt:
* http/tests/navigation/javascriptlink-frames-expected.txt:
* http/tests/navigation/javascriptlink-goback-expected.checksum:
* http/tests/navigation/javascriptlink-goback-expected.png:
* http/tests/navigation/javascriptlink-goback-expected.txt:
* http/tests/navigation/javascriptlink-subframeload-expected.txt:
* http/tests/navigation/metaredirect-basic-expected.checksum:
* http/tests/navigation/metaredirect-basic-expected.png:
* http/tests/navigation/metaredirect-basic-expected.txt:
* http/tests/navigation/metaredirect-frames-expected.txt:
* http/tests/navigation/metaredirect-goback-expected.checksum:
* http/tests/navigation/metaredirect-goback-expected.png:
* http/tests/navigation/metaredirect-goback-expected.txt:
* http/tests/navigation/metaredirect-subframeload-expected.txt:
* http/tests/navigation/post-goback2-expected.checksum:
* http/tests/navigation/post-goback2-expected.png:
* http/tests/navigation/post-goback2-expected.txt:
* http/tests/navigation/postredirect-goback2-expected.checksum:
* http/tests/navigation/postredirect-goback2-expected.png:
* http/tests/navigation/postredirect-goback2-expected.txt:
* http/tests/navigation/redirect302-basic-expected.checksum:
* http/tests/navigation/redirect302-basic-expected.png:
* http/tests/navigation/redirect302-basic-expected.txt:
* http/tests/navigation/redirect302-frames-expected.txt:
* http/tests/navigation/redirect302-goback-expected.checksum:
* http/tests/navigation/redirect302-goback-expected.png:
* http/tests/navigation/redirect302-goback-expected.txt:
* http/tests/navigation/redirect302-subframeload-expected.txt:
* http/tests/navigation/relativeanchor-basic-expected.txt:
* http/tests/navigation/relativeanchor-frames-expected.txt:
* http/tests/navigation/relativeanchor-goback-expected.txt:
* http/tests/navigation/slowmetaredirect-basic-expected.checksum:
* http/tests/navigation/slowmetaredirect-basic-expected.png:
* http/tests/navigation/slowmetaredirect-basic-expected.txt:
* http/tests/navigation/slowtimerredirect-basic-expected.checksum:
* http/tests/navigation/slowtimerredirect-basic-expected.png:
* http/tests/navigation/slowtimerredirect-basic-expected.txt:
* http/tests/navigation/success200-basic-expected.checksum:
* http/tests/navigation/success200-basic-expected.png:
* http/tests/navigation/success200-basic-expected.txt:
* http/tests/navigation/success200-frames-expected.txt:
* http/tests/navigation/success200-frames-loadsame-expected.txt:
* http/tests/navigation/success200-goback-expected.checksum:
* http/tests/navigation/success200-goback-expected.png:
* http/tests/navigation/success200-goback-expected.txt:
* http/tests/navigation/success200-loadsame-expected.checksum:
* http/tests/navigation/success200-loadsame-expected.png:
* http/tests/navigation/success200-loadsame-expected.txt:
* http/tests/navigation/success200-reload-expected.checksum:
* http/tests/navigation/success200-reload-expected.png:
* http/tests/navigation/success200-reload-expected.txt:
* http/tests/navigation/success200-subframeload-expected.txt:
* http/tests/navigation/timerredirect-basic-expected.checksum:
* http/tests/navigation/timerredirect-basic-expected.png:
* http/tests/navigation/timerredirect-basic-expected.txt:
* http/tests/navigation/timerredirect-frames-expected.txt:
* http/tests/navigation/timerredirect-goback-expected.checksum:
* http/tests/navigation/timerredirect-goback-expected.png:
* http/tests/navigation/timerredirect-goback-expected.txt:
* http/tests/navigation/timerredirect-subframeload-expected.txt:
* tables/mozilla/bugs/bug33855-expected.checksum:
* tables/mozilla/bugs/bug33855-expected.png:
* tables/mozilla/bugs/bug33855-expected.txt:
* tables/mozilla/dom/tableDom-expected.checksum:
* tables/mozilla/dom/tableDom-expected.png:
* tables/mozilla/dom/tableDom-expected.txt:
* tables/mozilla_expected_failures/bugs/bug2479-5-expected.checksum:
* tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:
* tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25322
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Thu, 30 Aug 2007 22:33:39 +0000 (22:33 +0000)]
2007-08-30 Riku Voipio <riku.voipio@iki.fi>
Reviewed by Dave Kilzer.
Better ARM defines.
* kjs/ustring.h: Update comments to reflect the change and update test
to fit changes to Platform.h.
* wtf/Platform.h: Forced packing is only needed on oldabi ARM.
Set middle-endian floats only for little-endian oldabi ARM.
Set big-endian define for big-endian ARM.
2007-08-30 Riku Voipio <riku.voipio@iki.fi>
Reviewed by Dave Kilzer.
Better ARM defines.
* platform/DeprecatedString.h: Update comments to reflect the
change and update test to fit changes to Platform.h.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25321
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Thu, 30 Aug 2007 21:14:08 +0000 (21:14 +0000)]
Reviewed by Tim.
<rdar://problem/
5439953> REGRESSION: Cannot load feeds in widgets in Dashcode due to change in WebKit delegate methods
* WebView/WebFrame.mm:
(-[WebFrame _attachScriptDebugger]): Don't create the debugger object if the frame has not yet
created its script interpreter, to avoid premature dispatch of windowScriptObjectAvailable/Cleared
delegate methods. The script debugger will be created in any case when the window object does appear.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25320
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Thu, 30 Aug 2007 18:06:06 +0000 (18:06 +0000)]
Reviewed by Tim Hatcher.
- fix http://bugs.webkig.org/show_bug.cgi?id=14981
DEBUG builds of WebKit hang videwing Yahoo! Mail messages
with ~5 MB text attachment
* rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::checkConsistency):
* rendering/RenderFlow.cpp: (WebCore::RenderFlow::checkConsistency):
* rendering/RenderText.cpp: (WebCore::RenderText::checkConsistency):
Put the actual consistency check inside an ifdef. If you need it you can
turn it on. There's still some function call overhead in builds that don't
have NDEBUG defined, but that's worth it so we can turn this on and off
without recompiling the world.
- small code style improvement to recently changed function
* editing/TextIterator.cpp: (WebCore::plainTextToMallocAllocatedBuffer):
Use a typedef and make_pair to make the code dealing with the pair simpler to read.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25319
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann [Thu, 30 Aug 2007 14:44:54 +0000 (14:44 +0000)]
Use QKeySequence::StandardKey for the page wise scrolling shortcuts.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25318
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann [Thu, 30 Aug 2007 14:44:52 +0000 (14:44 +0000)]
When scrolling with the keyboard don't call update() on the entire widget.
The scrollbar/scrollview implementation is already smart enough to scroll with bitblt
on a value change.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25317
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann [Thu, 30 Aug 2007 14:44:49 +0000 (14:44 +0000)]
Fix scrolling with the keyboard if only one of the two scrollbars is visible.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25316
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann [Thu, 30 Aug 2007 14:26:02 +0000 (14:26 +0000)]
Fix Qt/Gdk build.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25315
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti [Thu, 30 Aug 2007 13:12:46 +0000 (13:12 +0000)]
Reviewed by Antti.
- fix <rdar://problem/
5423270> CrashTracer: [USER] 1 crash in Safari at com.apple.WebCore:
WebCore::plainTextToMallocAllocatedBuffer + 762
* editing/TextIterator.cpp: (WebCore::plainTextToMallocAllocatedBuffer):
Check for a malloc failure and exit the function if it failed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25314
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Thu, 30 Aug 2007 01:32:14 +0000 (01:32 +0000)]
Reviewed by Oliver.
<rdar://problem/
5404329>
Plugin content starves WM_TIMER events on UI thread (affects idle behavior of app) on http://www.vincent-vella.com/, http://www.sagmeister.com/
Add a tiny delay to invalidation timer to prevent it from starving other timers.
* plugins/win/PluginViewWin.cpp:
(WebCore::PluginViewWin::invalidateRect):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25313
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Thu, 30 Aug 2007 00:45:52 +0000 (00:45 +0000)]
Reviewed by Tim Hatcher.
- fix <rdar://problem/
4582212> WebKit inappropriately adds +initialize to
NSPasteboard via a category, prevents AppKit initialize
http://bugs.webkit.org/show_bug.cgi?id=9417
* Misc/WebNSPasteboardExtras.h: Got rid of the global data objects and replaced
them with global functions.
* Misc/WebNSPasteboardExtras.mm:
(initializePasteboardTypes): Changed the initialize method to be this function.
(WebURLPasteboardType): Added, calls the initialize function and then returns
the value of the global.
(WebURLNamePasteboardType): Ditto.
(+[NSPasteboard _web_writableTypesForURL]): Changed to call the new function instead
of getting at the global directly.
(+[NSPasteboard _web_dragTypesForURL]): Ditto.
(-[NSPasteboard _web_writeURL:andTitle:types:]): Ditto.
* WebCoreSupport/WebPasteboardHelper.mm:
(WebPasteboardHelper::urlFromPasteboard): Ditto.
* WebView/WebHTMLView.mm:
(-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]): Ditto.
* WebView/WebView.mm:
(+[WebView initialize]): Added a call to one of the functions to take advantage
of the side effect that initializes the globals; this is to help out old versions
of Safari.
(+[WebView URLTitleFromPasteboard:]): Changed to call the new function instead
of getting at the global directly.
* WebKit.exp: Add exports of the new functions.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25312
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Thu, 30 Aug 2007 00:32:10 +0000 (00:32 +0000)]
Reviewed by Adele.
* editing/htmlediting.cpp: (WebCore::avoidIntersectionWithNode):
Fix an assert that was firing for me all the time when doing editing operations.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25311
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Thu, 30 Aug 2007 00:23:37 +0000 (00:23 +0000)]
Reviewed by Adam.
<rdar://problem/
5386098>
Repro hang with some Flash plugin content (http://dougmccune.com/blog/2007/07/25/coming-to-flexcamp-at-adobe/)
In some cases, Flash ends up starving the main loop by sending a lot of WM_USER + 1 messages. Throttle these
messages so they won't end up hanging the web browser.
* plugins/win/PluginViewWin.cpp:
(WebCore::PluginMessageThrottlerWin::PluginMessageThrottlerWin):
(WebCore::PluginMessageThrottlerWin::~PluginMessageThrottlerWin):
(WebCore::PluginMessageThrottlerWin::appendMessage):
(WebCore::PluginMessageThrottlerWin::messageThrottleTimerFired):
(WebCore::PluginMessageThrottlerWin::allocateMessage):
(WebCore::PluginMessageThrottlerWin::isInlineMessage):
(WebCore::PluginMessageThrottlerWin::freeMessage):
(WebCore::PluginViewWndProc):
(WebCore::PluginViewWin::wndProc):
(WebCore::PluginViewWin::determineQuirks):
* plugins/win/PluginViewWin.h:
(WebCore::):
(WebCore::PluginViewWin::pluginWndProc):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25310
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin [Wed, 29 Aug 2007 23:15:08 +0000 (23:15 +0000)]
Reviewed by Hyatt.
Fix for <rdar://problem/
5436800> REGRESSION: PLT is 1.5% slower due
to r24593 and r25098
In r25098, we only called setCreatedByParser for XML! This patch
calls it for HTML too, and takes care of the performance
regression.
* html/HTMLElementFactory.cpp:
(WebCore::styleConstructor):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25309
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti [Wed, 29 Aug 2007 22:46:41 +0000 (22:46 +0000)]
WebCore:
Reviewed by Mitz.
Fix <rdar://problem/
5425951>
REGRESSION: change to updateLayoutIgnorePendingStylesheets causes SAP Portal page to render wrong
If new nodes have been added or style recalc has been done with style sheets still pending, some nodes
may not have had their real style calculated yet. Normally this state gets cleaned when style sheets arrive
but in updateLayoutIgnorePendingStylesheets() we need to do full style recalc to get up-to-date style immediatly.
Added a document flag to track if there are any nodes that did not have their real style calculated due to
pending stylesheets.
Test: fast/dynamic/style-access-late-stylesheet-load.html
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::styleForElement):
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::recalcStyle):
(WebCore::Document::updateLayoutIgnorePendingStylesheets):
* dom/Document.h:
(WebCore::Document::setHasNodesWithPlaceholderStyle):
LayoutTests:
Reviewed by Mitz.
Test for <rdar://problem/
5425951>
REGRESSION: change to updateLayoutIgnorePendingStylesheets causes SAP Portal page to render wrong
* fast/dynamic/style-access-late-stylesheet-load-expected.txt: Added.
* fast/dynamic/style-access-late-stylesheet-load.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25308
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Wed, 29 Aug 2007 22:05:24 +0000 (22:05 +0000)]
Reviewed by Darin.
Fix for http://bugs.webkit.org/show_bug.cgi?id=15098
<rdar://problem/
5440319> REGRESSION (9A530-9A534): Double scroll bar on pdfs
* WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::makeDocumentView):
Don't suppress scrollbars before the view creation if we're making the view for a non-html view
* WebView/WebFrameViewInternal.h: Make _scrollView return a WebDynamicScrollBarsView since so many clients were relying on it being that type anyway.
* WebView/WebFrameView.mm:
(-[WebFrameView _setDocumentView:]):
(-[WebFrameView _scrollView]):
(-[WebFrameView setAllowsScrolling:]):
(-[WebFrameView allowsScrolling]):
* WebView/WebView.mm:
(-[WebView setAlwaysShowVerticalScroller:]):
(-[WebView alwaysShowVerticalScroller]):
(-[WebView setAlwaysShowHorizontalScroller:]):
(-[WebView alwaysShowHorizontalScroller]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25307
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aliceli1 [Wed, 29 Aug 2007 21:29:26 +0000 (21:29 +0000)]
Reviewed by Maciej.
We disable the DeleteButton UI before applying any editing commands.
This patch simply moves those disable/enable calls to a more correct place, closer to the actual application of the editing command.
* editing/EditCommand.cpp:
(WebCore::EditCommand::apply):
(WebCore::applyCommand):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25306
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aliceli1 [Wed, 29 Aug 2007 21:27:42 +0000 (21:27 +0000)]
fixed <rdar://problem/
5420682> Mail crashes at WebCore::InsertLineBreakCommand::doApply()
after dropping a selected image over container's close box
Reviewed by Darin and Maciej.
* editing/DeleteButtonController.cpp:
(WebCore::DeleteButtonController::show):
(WebCore::DeleteButtonController::hide):
* editing/DeleteButtonController.h:
(WebCore::DeleteButtonController::enabled):
General changes made to DeleteButtonController: when hiding, it's not necessary to clear out
the m_containerElement and m_target, especially since to fix this bug we need to keep
their values around. It's sufficient to just detach the container from target.
* editing/EditCommand.cpp:
(WebCore::EditCommand::EditCommand):
Move the selection out of the deletion UI since we don't want to expose the deletion UI to any editing.
* editing/Editor.cpp:
(WebCore::Editor::rangeForPoint):
Move the range out of the deletion UI since we don't want to expose the deletion UI to any editing.
* editing/htmlediting.cpp:
* editing/htmlediting.h:
(WebCore::avoidIntersectionWithNode):
Moved function that operates on Range from markup.cpp to here
Added new implementation for function that operates on Selection
* editing/markup.cpp:
(WebCore::createMarkup):
Moved function out of this file to htmlediting.cpp, and renamed to avoidIntersectionWithNode
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25305
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Wed, 29 Aug 2007 21:27:27 +0000 (21:27 +0000)]
Tiger build fix.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25304
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Wed, 29 Aug 2007 21:25:10 +0000 (21:25 +0000)]
Tiger build fix.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25303
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer [Wed, 29 Aug 2007 21:25:00 +0000 (21:25 +0000)]
WebKitTools:
Reviewed by Adam.
Added case-insensitivity to checks for adding regression tests.
* Scripts/prepare-ChangeLog:
(generateFileList):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25302
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Wed, 29 Aug 2007 21:17:25 +0000 (21:17 +0000)]
The method that was swizzled to fix
5441281 does not exist on Tiger.
Tiger has to do a double swizzle instead (of resetCursorRects and NSCursor's
set method) in order to roughly achieve the same effect.
Reviewed by darin
* WebView/WebHTMLView.mm:
(resetCursorRects):
(setCursor):
(+[WebHTMLViewPrivate initialize]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25301
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Wed, 29 Aug 2007 20:39:03 +0000 (20:39 +0000)]
Fix 64-bit build.
* WebCoreSupport/WebFrameBridge.mm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25300
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adachan [Wed, 29 Aug 2007 19:58:22 +0000 (19:58 +0000)]
<rdar://problem/
5074612> Added SPI to retrieve certificate info from a WebError.
Reviewed by Steve.
* Interfaces/IWebErrorPrivate.idl: Added IWebErrorPrivate
* WebError.cpp:
(WebError::QueryInterface): WebError now also implements IWebErrorPrivate
(WebError::sslPeerCertificate): retrieves certificate info from CFError's user info.
* WebError.h:
* WebKit.vcproj/WebKitGUID.vcproj: Added IWebErrorPrivate_i.c
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25299
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Wed, 29 Aug 2007 19:48:51 +0000 (19:48 +0000)]
WebCore:
Fix for
5441281, remove our dependency on cursor rects and drag margins
in AppKit for a large performance boost on the PLT and iBench.
Reviewed by darin
* platform/mac/WidgetMac.mm:
(WebCore::safeRemoveFromSuperview):
(WebCore::Widget::addToSuperview):
Suppress the resetting of drag margins when views are added and removed.
(WebCore::Widget::setCursor):
Just use NSCursor's set method to immediately set the cursor. We no longer
rely on NSScrollView/NSClipView setDocumentCursor, since that is implemented
using cursor rects.
WebKit:
Fix for
5441281, remove our dependency on cursor rects and drag margins
in AppKit for a large performance boost on the PLT and iBench.
Reviewed by darin
* Plugins/WebBaseNetscapePluginView.h:
* Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView sendNullEvent]):
(-[WebBaseNetscapePluginView mouseEntered:]):
(-[WebBaseNetscapePluginView mouseExited:]):
(-[WebBaseNetscapePluginView stop]):
Clean up cursor setting from Netscape plugins. Don't unconditionally mutate
the cursor when a plugin stops.
* WebView/WebFrameView.mm:
(-[WebFrameView _setDocumentView:]):
Suppress the resetting of drag margins while the new document view is being
added to the view hierarchy.
* WebView/WebHTMLView.mm:
(-[NSWindow _web_borderView]):
Expose the border view of the NSWindow so that it can be hit tested.
(setCursorForMouseLocation):
Apply a method swizzle to override the private AppKit method, _setCursorForMouseLocation.
We have to do this to suppress the cursor rect invalidation handling from resetting
the cursor for no reason.
The swizzle will do a hit test and allow the cursor set to occur if the mouse ends up
being over a plugin or over a view other than a WebHTMLView.
(+[WebHTMLViewPrivate initialize]):
The swizzle for setCursorForMouseLocation is set up here.
(-[WebHTMLView _frameOrBoundsChanged]):
Add a 100ms delay to the fake mouse moved event that fires when the view moves
under the mouse (without the mouse moving). This happens on iBench when the
pages get scrolled. By adding a delay we ensure that even with the mouse inside
the window, we don't experience cursor thrashing when pages are updating and
scrolling rapidly.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25298
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Wed, 29 Aug 2007 17:39:03 +0000 (17:39 +0000)]
2007-08-29 Rick <rick@writhe.org.uk>
Reviewed by Tim Hatcher.
Fix http://bugs.webkit.org/show_bug.cgi?id=14853
Bug 14853: Incorrect implementation of ArrayImpl's equality operator
* platform/ArrayImpl.cpp:
(WebCore::ArrayImpl::operator==):
Fixed typo so that correct variable is used in equality comparison.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25297
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Wed, 29 Aug 2007 17:35:50 +0000 (17:35 +0000)]
2007-08-29 Ryan Leavengood <leavengood@gmail.com>
Reviewed by Maciej.
http://bugs.webkit.org/show_bug.cgi?id=15043
- posix_memalign takes a void** as its first parameter. My port makes use of this function call.
* kjs/collector.cpp:
(KJS::allocateBlock):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25296
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Wed, 29 Aug 2007 17:34:01 +0000 (17:34 +0000)]
2007-08-29 Peter Kasting <zerodpx@gmail.com>
Reviewed by Maciej.
- fix http://bugs.webkit.org/show_bug.cgi?id=15096
Move the GIF frame duration minimum check into the various
ImageSource*.cpp backends and use the same values as
ImageSourceCG.cpp.
* platform/graphics/cairo/ImageSourceCairo.cpp:
(WebCore::ImageSource::frameDurationAtIndex):
* platform/graphics/qt/ImageSourceQt.cpp:
(WebCore::ImageSource::frameDurationAtIndex):
* platform/image-decoders/gif/GIFImageReader.cpp:
(GIFImageReader::read):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25295
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Wed, 29 Aug 2007 17:31:22 +0000 (17:31 +0000)]
2007-08-29 Peter Kasting <zerodpx@gmail.com>
Reviewed by Maciej.
- fix http://bugs.webkit.org/show_bug.cgi?id=15097
Make PNGImageDecoder.cpp size its frame buffer vector in its
constructor, so it never throws decoded image data away no matter
what order its functions are called in.
* platform/image-decoders/png/PNGImageDecoder.cpp:
(WebCore::PNGImageDecoder::PNGImageDecoder):
(WebCore::PNGImageDecoder::frameBufferAtIndex):
(WebCore::PNGImageDecoder::decode):
(WebCore::PNGImageDecoder::rowAvailable):
(WebCore::PNGImageDecoder::pngComplete):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25294
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Wed, 29 Aug 2007 17:29:56 +0000 (17:29 +0000)]
2007-08-29 Peter Kasting <zerodpx@gmail.com>
Reviewed by Maciej.
- fix http://bugs.webkit.org/show_bug.cgi?id=15104
Don't double-compensate for sizeof(unsigned) when making a buffer
overflow check in the GIF decoder. Now interlaced GIFs don't
sometimes get nothing/garbage in some of the bottom rows.
* platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::haveDecodedRow):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25293
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken [Wed, 29 Aug 2007 15:53:54 +0000 (15:53 +0000)]
Bump version for submit
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25291
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken [Wed, 29 Aug 2007 08:32:12 +0000 (08:32 +0000)]
Fix build.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25290
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann [Wed, 29 Aug 2007 07:56:58 +0000 (07:56 +0000)]
Fix compilation
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25289
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken [Wed, 29 Aug 2007 07:46:03 +0000 (07:46 +0000)]
<rdar://problem/
5079253> Cannot set different margins for the page
Added support for setting margins via page setup for Windows printing.
Reviewed by Adam.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25288
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Wed, 29 Aug 2007 07:04:11 +0000 (07:04 +0000)]
2007-08-28 Mark Rowe <mrowe@apple.com>
Reviewed by Maciej Stachowiak.
Fix fallout from the fix for <rdar://problem/
5437983> (Loading history containing 100,000 entries adds 20s to Safari's startup)
in r25275. The array of entries for each day was being maintained in the reverse of the order that was expected.
* History/WebHistory.mm:
(-[WebHistoryPrivate insertItem:forDateKey:]): Maintain the array of entries in descending order.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25287
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer [Wed, 29 Aug 2007 02:51:38 +0000 (02:51 +0000)]
Removed test files in /resources/ subdirectories.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25286
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer [Wed, 29 Aug 2007 02:49:48 +0000 (02:49 +0000)]
WebKitTools:
Reviewed by Maciej.
Ignore files in /resources/ subdirectories when creating a list of added tests.
* Scripts/prepare-ChangeLog:
(generateFileList):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25285
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Wed, 29 Aug 2007 00:32:53 +0000 (00:32 +0000)]
WebCore:
Reviewed by Darin.
Update fix landed in r25249 to account for XMLHttpRequest, which can also be EventTargets.
Tests: http/tests/security/listener/resources/childWithXMLHttpRequest.html
http/tests/security/listener/resources/targetChild-XMLHttpRequest-addEventListener.html
http/tests/security/listener/resources/targetChild-XMLHttpRequest-shortcut.html
http/tests/security/listener/xss-XMLHttpRequest-addEventListener.html
http/tests/security/listener/xss-XMLHttpRequest-shortcut.html
* bindings/js/JSXMLHttpRequest.cpp:
(KJS::JSXMLHttpRequest::putValueProperty): Use the Window object associated with document's frame, not the active Window.
(KJS::JSXMLHttpRequestPrototypeFunction::callAsFunction): ditto
* xml/XMLHttpRequest.h:
(WebCore::XMLHttpRequest::document): Expose Document member so bindings can access the correct frame.
LayoutTests:
Reviewed by Darin.
Additional tests for <rdar://problem/
5426142>
* http/tests/security/listener/resources/childWithXMLHttpRequest.html: Added.
* http/tests/security/listener/resources/targetChild-XMLHttpRequest-addEventListener.html: Added.
* http/tests/security/listener/resources/targetChild-XMLHttpRequest-shortcut.html: Added.
* http/tests/security/listener/xss-XMLHttpRequest-addEventListener-expected.txt: Added.
* http/tests/security/listener/xss-XMLHttpRequest-addEventListener.html: Added.
* http/tests/security/listener/xss-XMLHttpRequest-shortcut-expected.txt: Added.
* http/tests/security/listener/xss-XMLHttpRequest-shortcut.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25284
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Wed, 29 Aug 2007 00:15:36 +0000 (00:15 +0000)]
WebCore:
Reviewed by Darin.
<rdar://problem/
5424866> Bottom portion of any Web Clip widget appears transparent
Restore the previous behavior, creating plug-ins on attach, for WebKit plug-ins. Netscape plug-ins
are still created during the first layout.
* html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::getInstance):
Only call layout if the renderer doesn't have a widget.
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::getInstance):
Likewise.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::shouldUsePlugin):
Update for enum change.
* loader/FrameLoaderTypes.h:
Add ObjectContentNetscapePlugin and ObjectContentOtherPlugin.
* page/mac/WebCoreFrameBridge.h:
Get rid of the enum here, we can use the one in FrameLoaderTypes.h
* rendering/RenderPartObject.cpp:
(WebCore::RenderPartObject::updateWidget):
Only create the plug-in if it's not a Netscape plug-in.
(WebCore::RenderPartObject::layout):
Fix indentation.
WebKit:
Reviewed by Darin.
<rdar://problem/
5424866> Bottom portion of any Web Clip widget appears transparent
* WebCoreSupport/WebFrameBridge.mm:
Use the enum from FrameLoaderTypes.h.
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::objectContentType):
Return ObjectContentNetscapePlugin and ObjectContentOtherPlugin depending on the plug-in type.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25283
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
honeycutt [Tue, 28 Aug 2007 23:36:07 +0000 (23:36 +0000)]
2007-08-28 Jon Honeycutt <jhoneycutt@apple.com>
Reviewed by Adam.
<rdar://problem/
5444457>: Content is cut when page orientation changed
in print preview
Fix: Don't return WebFrame::m_pageRects if it exists; let
computePageRectsForFrame clear and rewrite it.
* WebFrame.cpp:
(WebFrame::computePageRects): Removed an early-return case. Added a
space.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25282
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
harrison [Tue, 28 Aug 2007 22:08:06 +0000 (22:08 +0000)]
Reviewed by Darin.
<rdar://problem/
5415006> Command Left in a To Do causes caret to disappear
* editing/selection/mixed-editability-8.html: Added.
* editing/selection/mixed-editability-9.html: Added.
* platform/mac/editing/selection: Added.
* platform/mac/editing/selection/mixed-editability-8-expected.checksum: Added.
* platform/mac/editing/selection/mixed-editability-8-expected.png: Added.
* platform/mac/editing/selection/mixed-editability-8-expected.txt: Added.
* platform/mac/editing/selection/mixed-editability-9-expected.checksum: Added.
* platform/mac/editing/selection/mixed-editability-9-expected.png: Added.
* platform/mac/editing/selection/mixed-editability-9-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25281
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
harrison [Tue, 28 Aug 2007 22:06:52 +0000 (22:06 +0000)]
Reviewed by Darin.
<rdar://problem/
5415006> Command Left in a To Do causes caret to disappear
The selection was ending up inside non-editable content at the To Do Options
arrow image, rather then at the editable position just to the left of that image.
The problem was that startPositionForLine looked only at line boxes, and there
is no linebox for the editable position at the far left of a To Do, which is
a table. Addressed by having startPositionForLine use table offset 0 instead
of the first VisiblePosition inside the table.
Found and fixed the similar case with option-left (move by word position).
Test cases:
* editing/selection/mixed-editability-8.html: Added.
* editing/selection/mixed-editability-9.html: Added.
Source changes:
* editing/SelectionController.cpp:
(WebCore::SelectionController::modifyMovingLeftBackward):
* editing/VisiblePosition.cpp:
(WebCore::VisiblePosition::next):
(WebCore::VisiblePosition::previous):
(WebCore::VisiblePosition::stayInEditableContentLeft):
(WebCore::VisiblePosition::stayInEditableContentRight):
Factored stayInEditableContentLeft() and stayInEditableContentRight()
out of previous() and next().
* editing/VisiblePosition.h:
Declare stayInEditableContentLeft() and stayInEditableContentRight().
* editing/visible_units.cpp:
(WebCore::previousWordPosition):
(WebCore::nextWordPosition):
(WebCore::startOfLine):
(WebCore::endOfLine):
(WebCore::previousSentencePosition):
(WebCore::nextSentencePosition):
Call stayInEditableContentLeft() or stayInEditableContentRight(), as
appropriate, so prevent crossing from editable content into
uneditable content.
(WebCore::startPositionForLine):
Use table offset 0 instead of the first VisiblePosition in the table.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25280
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Tue, 28 Aug 2007 20:24:26 +0000 (20:24 +0000)]
2007-08-28 Mark Rowe <mrowe@apple.com>
Fix the buildbot build.
* History/WebHistory.mm:
(timeIntervalForBeginningOfDay): Explicitly cast to silence compiler warning.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25279
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Tue, 28 Aug 2007 20:12:29 +0000 (20:12 +0000)]
2007-08-28 Mark Rowe <mrowe@apple.com>
Reviewed by Darin Adler.
<rdar://problem/
5443453> Decreasing history expiration time from 1 year to 1 week can lead to long hang while icon database syncs
Perform the sync inside a SQLite transaction. This drops the time taken for the sync from over 90s to under half a second in the
extreme case of over 90,000 URLs being pruned.
* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::syncDatabase):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25278
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Tue, 28 Aug 2007 20:06:26 +0000 (20:06 +0000)]
Use the correct test paths.
* platform/mac-leopard/Skipped:
* platform/mac-tiger/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25277
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Tue, 28 Aug 2007 19:55:43 +0000 (19:55 +0000)]
Put ChangeLog back to UTF-8 after FileMerge went and mangled it for my last commit.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25276
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Tue, 28 Aug 2007 19:48:17 +0000 (19:48 +0000)]
2007-08-28 Mark Rowe <mrowe@apple.com>
Reviewed by Darin Adler.
<rdar://problem/
5437983> Loading history containing 100,000 entries adds 20s to Safari's startup
Move WebHistoryItemPrivate from using a sorted array of NSCalendarDate's that map to a sorted array of arrays
of WebHistoryItem's over to using a HashMap of NSTimeIntervals and arrays of WebHistoryItems. NSTimeInterval
uses less memory and is substantially cheaper during comparisons than NSCalendarDate. The use of the HashMap
avoids the needs to repeatedly search within an array to locate the array that corresponds to the given days
history items.
The result of these changes is that loading 100,000 history items drops from around 25s to 1.6s. Loading
100 items drops from 0.003s to 0.002s.
* History/WebHistory.mm:
(-[WebHistoryPrivate init]):
(-[WebHistoryPrivate dealloc]):
(timeIntervalForBeginningOfDay): Return the NSTimeInterval representing the beginning of the specified day.
(-[WebHistoryPrivate findKey:forDay:]):
(-[WebHistoryPrivate insertItem:forDateKey:]): Perform a binary search within the day's history items rather than a linear search.
(-[WebHistoryPrivate _removeItemFromDateCaches:]):
(-[WebHistoryPrivate _addItemToDateCaches:]):
(-[WebHistoryPrivate removeAllItems]):
(-[WebHistoryPrivate orderedLastVisitedDays]): Generate and cache the sorted NSArray of NSCalendarDate's exposed in the API.
This cache is invalidated by _removeItemFromDateCaches: and _addItemToDateCaches: when needed.
(-[WebHistoryPrivate orderedItemsLastVisitedOnDay:]):
(-[WebHistoryPrivate arrayRepresentation]):
(-[WebHistoryPrivate _loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]): Use an autorelease pool to keep the
number of live autoreleased objects generated to a reasonable level.
* History/WebHistoryItem.mm:
(-[WebHistoryItem initWithURLString:title:displayTitle:lastVisitedTimeInterval:]):
(-[WebHistoryItem initFromDictionaryRepresentation:]): Use the new HistoryItem constructor that accepts the alternate title
rather than setting it after construction. This prevents a modification notification from being sent for each WebHistoryItem that is loaded.
* History/WebHistoryItemInternal.h:
* History/WebHistoryPrivate.h:
* Misc/WebNSCalendarDateExtras.h: Removed as _webkit_compareDay: is no longer used.
* Misc/WebNSCalendarDateExtras.m: Removed.
* WebKit.xcodeproj/project.pbxproj:
2007-08-28 Mark Rowe <mrowe@apple.com>
Reviewed by Darin Adler.
<rdar://problem/
5437983> Loading history containing 100,000 entries adds 20s to Safari's startup
Add a new constructor for HistoryItem that initializes the alternate title. This prevents WebHistoryItem
in WebKit from having explicitly set the display title, which triggers a history item changed notification
to be posted, for each history item loaded.
* WebCore.exp:
* history/HistoryItem.cpp:
(WebCore::HistoryItem::HistoryItem):
* history/HistoryItem.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25275
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Tue, 28 Aug 2007 19:05:56 +0000 (19:05 +0000)]
WebCore:
Reviewed by Darin.
<rdar://problem/
5298296> XMLHttpRequest readyState 3 & responseText buffer issues
Add a shouldContentSniff flag to ResourceLoader and ResourceHandle and have XMLHttpRequest
pass in false when creating its subresource loader.
* WebCore.exp:
* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::MainResourceLoader):
(WebCore::MainResourceLoader::loadNow):
* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::ResourceLoader):
(WebCore::ResourceLoader::load):
* loader/ResourceLoader.h:
* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::SubresourceLoader):
(WebCore::SubresourceLoader::create):
* loader/SubresourceLoader.h:
* loader/mac/NetscapePlugInStreamLoaderMac.mm:
(WebCore::NetscapePlugInStreamLoader::NetscapePlugInStreamLoader):
* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:
* platform/network/ResourceHandle.cpp:
(WebCore::ResourceHandle::ResourceHandle):
(WebCore::ResourceHandle::create):
* platform/network/ResourceHandle.h:
* platform/network/ResourceHandleInternal.h:
(WebCore::ResourceHandleInternal::ResourceHandleInternal):
* platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::start):
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::send):
WebKit:
Reviewed by Darin.
<rdar://problem/
5298296> XMLHttpRequest readyState 3 & responseText buffer issues
Expose WKSetNSURLRequestShouldContentSniff to WebCore.
* WebCoreSupport/WebSystemInterface.m:
(InitWebCoreSystemInterface):
LayoutTests:
Reviewed by Darin.
<rdar://problem/
5298296> XMLHttpRequest readyState 3 & responseText buffer issues
* http/tests/xmlhttprequest/resources/small-chunks.cgi: Added.
* http/tests/xmlhttprequest/small-chunks-response-text-expected.txt: Added.
* http/tests/xmlhttprequest/small-chunks-response-text.html: Added.
* platform/mac-leopard/Skipped:
* platform/mac-tiger/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25274
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Tue, 28 Aug 2007 19:03:40 +0000 (19:03 +0000)]
Add WKSetNSURLRequestShouldContentSniff.
* WebKitSystemInterface.h:
* libWebKitSystemInterface.a:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25273
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
git://git.webkit.org / WebKit-https.git / log