WebKit-https.git
15 years agofix make clean in the qt build to remove all generated files
hausmann [Thu, 18 Jan 2007 13:00:27 +0000 (13:00 +0000)]
fix make clean in the qt build to remove all generated files

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoImplementing some load progress tracking in the Qt port.
zack [Thu, 18 Jan 2007 10:04:38 +0000 (10:04 +0000)]
Implementing some load progress tracking in the Qt port.
Reviewed by Lars.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
aliceli1 [Thu, 18 Jan 2007 07:47:03 +0000 (07:47 +0000)]
WebCore:

        Reviewed by Harrison.

        Fix for <rdar://problem/4894155> REGRESSION: Extra line break is pasted with content into message body after choosing File - Paste

        Migration of some editing code from WebHTMView to WebCore::Editor
        resulted in not calling pasteboardTypesForSelection, which Mail was
        overriding for the special purpose of adding a type to the
        pasteboard after WebKit did.  This patch adds 2 separate code paths
        for Tiger and Leopard.  On Tiger we give in and call the WebView's
        pasteboardTypesForSelection.  On Leopard we call a delegate after
        the pasteboard types are set.

        * bridge/EditorClient.h:
        * editing/Editor.h:
        * platform/Pasteboard.h:
        * platform/graphics/svg/SVGImageEmptyClients.h:
        (WebCore::SVGEmptyEditorClient::didSetSelectionTypesForPasteboard):
        (WebCore::SVGEmptyEditorClient::pasteboardTypesForSelection):
        * platform/mac/PasteboardMac.mm:
        (WebCore::Pasteboard::Pasteboard):
        (WebCore::Pasteboard::clear):
        (WebCore::Pasteboard::writeSelection):
        (WebCore::Pasteboard::writeURL):
        (WebCore::Pasteboard::plainText):
        (WebCore::Pasteboard::documentFragment):

WebKit:

        Reviewed by Harrison.

        Fix for <rdar://problem/4894155> REGRESSION: Extra line break is pasted with content into message body after choosing File - Paste

        Migration of some editing code from WebHTMView to WebCore::Editor
        resulted in not calling pasteboardTypesForSelection, which Mail was
        overriding for the special purpose of adding a type to the
        pasteboard after WebKit did.  This patch adds 2 separate code paths
        for Tiger and Leopard.  On Tiger we give in and call the WebView's
        pasteboardTypesForSelection.  On Leopard we call a delegate after
        the pasteboard types are set.

        * DefaultDelegates/WebDefaultEditingDelegate.m:
        (-[WebDefaultEditingDelegate webView:didSetSelectionTypesForPasteboard:]):
        * WebCoreSupport/WebEditorClient.h:
        * WebCoreSupport/WebEditorClient.mm:
        (WebEditorClient::didSetSelectionTypesForPasteboard):
        (WebEditorClient::pasteboardTypesForSelection):
        * WebView/WebEditingDelegate.h:

WebKitQt:

        Added these stubs to keep the Qt build from failing.

        * WebCoreSupport/EditorClientQt.cpp:
        (WebCore::EditorClientQt::didSetSelectionTypesForPasteboard):
        * WebCoreSupport/EditorClientQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
sullivan [Thu, 18 Jan 2007 04:32:33 +0000 (04:32 +0000)]
WebCore:

        Reviewed by Darin

        - WebCore part of fix for <rdar://problem/4462420> REGRESSION: Mail hangs during
          Replace All if the replacement string contains the search string

        * page/Frame.h:
        * page/Frame.cpp:
        (WebCore::Frame::findString):
        new startInSelection parameter -- if true, search starts looking in selection; if false,
        search starts looking after the selection

        * page/mac/WebCoreFrameBridge.h:
        * page/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge searchFor:direction:caseSensitive:wrap:startInSelection:]):
        new startInSelection parameter, passed through to Frame::findString()

        * editing/JSEditor.cpp:
        pass false for new findString parameter, to match old behavior

WebKit:

        Reviewed by Darin

        - WebKit part of fix for <rdar://problem/4462420> REGRESSION: Mail hangs during
          Replace All if the replacement string contains the search string

        * Misc/WebKitVersionChecks.h:
        Added extern "C" so this can be used from .mm files. I don't need this change anymore for
        this fix, but it's still worth fixing now so it doesn't bite anyone later.

        * WebView/WebDocumentPrivate.h:
        Invented new private protocol WebDocumentIncrementalSearching, that has one method. The one
        method is just like the one WebDocumentSearching method, but with an additional parameter.
        We hope to eliminate this dependence on protocols someday, but adding another one as SPI
        seems like it won't make anything worse.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView searchFor:direction:caseSensitive:wrap:]):
        now calls through to new method that has one additional parameter, passing NO to match old behavior
        (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]):
        pass new parameter to bridge

        * WebView/WebPDFView.h:
        Declare conformance to WebDocumentIncrementalSearching protocol

        * WebView/WebPDFView.mm:
        (-[WebPDFView searchFor:direction:caseSensitive:wrap:]):
        now calls through to new method that has one additional parameter, passing NO to match old behavior
        (-[WebPDFView searchFor:direction:caseSensitive:wrap:startInSelection:]):
        new method, former guts of searchFor:direction:caseSensitive:wrap: but now handles startInSelection
        parameter

        * WebView/WebViewPrivate.h:
        Declare new searchFor:direction:caseSensitive:wrap:startInSelection: method, just like existing
        method but with one additional parameter

        * WebView/WebView.mm:
        (-[WebView searchFor:direction:caseSensitive:wrap:]):
        now calls through to new method that has one additional parameter, passing NO to match old behavior
        (-[WebView searchFor:direction:caseSensitive:wrap:startInSelection:]):
        new method, former guts of searchFor:direction:caseSensitive:wrap: but now handles startInSelection
        parameter

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoRemoved an internal change I had I wasn't supposed to commit. *sigh*
beidson [Thu, 18 Jan 2007 04:00:35 +0000 (04:00 +0000)]
Removed an internal change I had I wasn't supposed to commit.  *sigh*

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Deth Bakin and Brian Dash
beidson [Thu, 18 Jan 2007 03:58:11 +0000 (03:58 +0000)]
    Reviewed by Deth Bakin and Brian Dash

        Drop Panther Support (?!?) and change the comment explaining some SPI forward decls

        * Misc/WebDownload.m:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoAdding comment.
bdakin [Thu, 18 Jan 2007 02:32:32 +0000 (02:32 +0000)]
Adding comment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
justing [Thu, 18 Jan 2007 02:30:54 +0000 (02:30 +0000)]
LayoutTests:

        Reviewed by darin

        <rdar://problem/4920488>
        REGRESSION: A crash occurs at WebCore::Range::processContents () when removing formatting from selected text (that contains a link)

        * editing/execCommand/4920488-expected.checksum: Added.
        * editing/execCommand/4920488-expected.png: Added.
        * editing/execCommand/4920488-expected.txt: Added.
        * editing/execCommand/4920488.html: Added.
        * fast/dom/Range/compareBoundaryPoints-1-expected.txt: Added.
        * fast/dom/Range/compareBoundaryPoints-1.html: Added.

WebCore:

        Reviewed by darin

        <rdar://problem/4920488>
        REGRESSION: A crash occurs at WebCore::Range::processContents () when removing formatting from selected text (that contains a link)

        * dom/Range.cpp:
        (WebCore::Range::commonAncestorContainer): Return null if the nodes
        don't have a common ancestor.  As a side effect, the public
        commonAncestorContainer now sets an exception if the Range starts
        in one document and ends in another, or starts or ends in a tree
        that's been removed from the document.  The spec doesn't cover
        this and there is no precedent in other browsers for this case because
        they don't allow invalid Ranges (you can create one with WebCore
        by removing a node that contains the start/end of a Range).
        (WebCore::Range::compareBoundaryPoints): If the the two positions
        are in nodes that have no common ancestor, return null.  This doesn't
        change the behavior of the public compareBoundaryPoints: it already
        throws an exception if the two positions are in nodes that don't have
        a common ancestor.  This follows the spec.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago The one word was typed by me, but only after debugging for a long time with...
sullivan [Thu, 18 Jan 2007 01:49:30 +0000 (01:49 +0000)]
    The one word was typed by me, but only after debugging for a long time with Darin.

        - fixed <rdar://problem/4912002> REGRESSION: Series of words marked as a single misspelled word

        * editing/TextIterator.cpp:
        (WebCore::WordAwareIterator::WordAwareIterator):
        We were creating a TextIterator with the default kind, but WordAwareIterator is designed to work
        in concert with CharacterIterator, so they need to use the same kind. CharacterIterator uses
        kind RUNFINDER, so WordAwareIterator needs to do so also.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Brady.
adele [Thu, 18 Jan 2007 01:09:24 +0000 (01:09 +0000)]
    Reviewed by Brady.

        Fix for <rdar://problem/4900895> REGRESSION: onChange doesn't always fire for popups that have had value changed by JS

        No test case since you need to open up the menu to fire onChange.

        * html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setSelectedIndex):
          Keep track of m_lastOnChangeIndex even when we're not firing onChange.  Since
          the selected index has changed, we still want the m_lastOnChangeIndex to be up to date when we compare
          it later.  This matches our behavior in Safari 2.0.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin and John.
adele [Thu, 18 Jan 2007 00:15:10 +0000 (00:15 +0000)]
    Reviewed by Darin and John.

        - Fix for <rdar://problem/4816550> REGRESSION: autoscrolling doesn't work after double-click

        * page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent): Set swallowEvent bool instead
          of returning early for double and triple clicks.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-01-17 Eric Seidel <eric@webkit.org>
eseidel [Wed, 17 Jan 2007 23:17:41 +0000 (23:17 +0000)]
2007-01-17  Eric Seidel  <eric@webkit.org>

        Reviewed by Brady.

        Update results after SVG container hit testing changes.

        * svg/custom/pointer-events-text-expected.checksum:
        * svg/custom/pointer-events-text-expected.png:
        * svg/custom/pointer-events-text-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Hyatt.
darin [Wed, 17 Jan 2007 23:13:48 +0000 (23:13 +0000)]
    Reviewed by Hyatt.

        * rendering/RenderObject.h: Removed unused nextEditable and previousEditable.
        * rendering/RenderObject.cpp: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
darin [Wed, 17 Jan 2007 22:50:58 +0000 (22:50 +0000)]
WebCore:

        Reviewed by Maciej.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12278
          <rdar://problem/4928705> REGRESSION(r13070): Dragged image size includes padding (12278)

        * WebCore.exp: Added HitTestResult::imageRect,
        removed HitTestResult::boundingBox.

        * rendering/HitTestResult.h:
        * rendering/HitTestResult.cpp: (WebCore::HitTestResult::imageRect):
        Added. Returns the content rectangle of the image.

        * rendering/RenderObject.h:
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::absolutePosition): Made const.
        (WebCore::RenderObject::contentBox): Added.
        (WebCore::RenderObject::absoluteContentBox): Added.

        * rendering/RenderBox.h:
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::absolutePosition): Made const.

        * rendering/RenderTableCell.h:
        * rendering/RenderTableCell.cpp:
        (WebCore::RenderTableCell::absolutePosition): Made const.

        * rendering/RenderView.h:
        * rendering/RenderView.cpp:
        (WebCore::RenderView::absolutePosition): Made const.

WebKit:

        Reviewed by Maciej.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12278
          <rdar://problem/4928705> REGRESSION(r13070): Dragged image size includes padding (12278)

        * Misc/WebElementDictionary.mm: (-[WebElementDictionary _imageRect]):
        Call HitTestResult::imageRect, not HitTestResult::boundingBox.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix my last commit to actually work in all cases.
lars [Wed, 17 Jan 2007 22:15:31 +0000 (22:15 +0000)]
Fix my last commit to actually work in all cases.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Mitz.
adele [Wed, 17 Jan 2007 22:05:31 +0000 (22:05 +0000)]
    Reviewed by Mitz.

        Updating this new layout test so that it actually crashes before the last fix.

        * fast/css/pseudostyle-anonymous-text.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
adele [Wed, 17 Jan 2007 21:50:42 +0000 (21:50 +0000)]
LayoutTests:

        Reviewed by Beth.

        Test for http://bugs.webkit.org/show_bug.cgi?id=10139
        <rdar://problem/4823028> REGRESSION: Reproducible crash when selecting a popup/button with ::selection pseudostyle

        * fast/css/pseudostyle-anonymous-text-expected.txt: Added.
        * fast/css/pseudostyle-anonymous-text.html: Added.

WebCore:

        Reviewed by Beth.

        Fix for  http://bugs.webkit.org/show_bug.cgi?id=10139
        <rdar://problem/4823028> REGRESSION: Reproducible crash when selecting a popup/button with ::selection pseudostyle

        Test: fast/css/pseudostyle-anonymous-text.html

        * rendering/RenderObject.cpp: (WebCore::RenderObject::getPseudoStyle): Nil check the node.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej
lars [Wed, 17 Jan 2007 21:19:21 +0000 (21:19 +0000)]
    Reviewed by Maciej

        Make sure DumpRenderTree exits when run-webkit-tests
        is done.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
adele [Wed, 17 Jan 2007 21:01:34 +0000 (21:01 +0000)]
LayoutTests:

        Reviewed by Anders and John.

        Test for http://bugs.webkit.org/show_bug.cgi?id=11278
        <rdar://problem/4826875> REGRESSION: Popup width doesn't change to accommodate dynamic changes to options

        * fast/forms/menulist-width-change-expected.checksum: Added.
        * fast/forms/menulist-width-change-expected.png: Added.
        * fast/forms/menulist-width-change-expected.txt: Added.
        * fast/forms/menulist-width-change.html: Added.

WebCore:

        Reviewed by Anders and John.

        Fix for http://bugs.webkit.org/show_bug.cgi?id=11278
        <rdar://problem/4826875> REGRESSION: Popup width doesn't change to accommodate dynamic changes to options

        Test: fast/forms/menulist-width-change.html

        * rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::updateFromElement):
          When the options change, call setNeedsLayoutAndMinMaxRecalc.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej.
ap [Wed, 17 Jan 2007 19:34:43 +0000 (19:34 +0000)]
    Reviewed by Maciej.

        http://bugs.webkit.org/show_bug.cgi?id=12268
        Give object prototypes their own names

JavaScriptCore:
        * kjs/lookup.h: Append "Prototype" to ClassName in KJS_IMPLEMENT_PROTOTYPE.

WebCore:
        * bindings/scripts/CodeGeneratorJS.pm: Append "Proto" to interface name for the prototype's ClassInfo.

        * bindings/js/JSHTMLInputElementBase.cpp:
        (WebCore::JSHTMLInputElementBasePrototypeFunction::callAsFunction):
        (WebCore::JSHTMLInputElementBase::JSHTMLInputElementBase):
        * bindings/js/JSHTMLInputElementBase.h:
        * bindings/js/JSXMLHttpRequest.cpp:
        (KJS::JSXMLHttpRequestConstructorImp::JSXMLHttpRequestConstructorImp):
        (KJS::JSXMLHttpRequest::JSXMLHttpRequest):
        (KJS::JSXMLHttpRequestPrototypeFunction::callAsFunction):
        * bindings/js/JSXMLHttpRequest.h:
        * bindings/js/JSXSLTProcessor.cpp:
        (KJS::JSXSLTProcessor::JSXSLTProcessor):
        (KJS::XSLTProcessorPrototypeFunction::callAsFunction):
        (KJS::XSLTProcessorConstructorImp::XSLTProcessorConstructorImp):
        * bindings/js/kjs_css.cpp:
        (KJS::DOMCSSStyleDeclaration::DOMCSSStyleDeclaration):
        (KJS::DOMCSSStyleDeclarationPrototypeFunction::callAsFunction):
        (KJS::DOMMediaList::DOMMediaList):
        (KJS::KJS::DOMMediaListPrototypeFunction::callAsFunction):
        (KJS::DOMCSSStyleSheet::DOMCSSStyleSheet):
        (KJS::DOMCSSStyleSheetPrototypeFunction::callAsFunction):
        (KJS::DOMCSSValue::DOMCSSValue):
        (KJS::DOMCSSValuePrototypeFunction::callAsFunction):
        * bindings/js/kjs_css.h:
        * bindings/js/kjs_dom.cpp:
        (KJS::DOMNode::DOMNode):
        (KJS::DOMNodePrototypeFunction::callAsFunction):
        (KJS::DOMEventTargetNode::DOMEventTargetNode):
        (KJS::DOMEventTargetNodePrototypeFunction::callAsFunction):
        (KJS::DOMNamedNodeMap::DOMNamedNodeMap):
        (KJS::DOMNamedNodeMapPrototypeFunction::callAsFunction):
        * bindings/js/kjs_dom.h:
        * bindings/js/kjs_domnode.h:
        * bindings/js/kjs_events.cpp:
        (KJS::DOMEvent::DOMEvent):
        (KJS::DOMEventPrototypeFunction::callAsFunction):
        (KJS::Clipboard::Clipboard):
        (KJS::ClipboardPrototypeFunction::callAsFunction):
        * bindings/js/kjs_events.h:
        * bindings/js/kjs_html.cpp:
        (KJS::JSHTMLDocumentPrototypeFunction::callAsFunction):
        (KJS::):
        (KJS::JSHTMLDocument::JSHTMLDocument):
        (KJS::JSHTMLElementPrototypeFunction::callAsFunction):
        (KJS::JSHTMLElement::JSHTMLElement):
        (KJS::JSHTMLCollection::JSHTMLCollection):
        (KJS::JSHTMLCollectionPrototypeFunction::callAsFunction):
        * bindings/js/kjs_html.h:
        * bindings/js/kjs_navigator.cpp:
        * bindings/js/kjs_traversal.cpp:
        (KJS::DOMNodeFilter::DOMNodeFilter):
        (KJS::DOMNodeFilterPrototypeFunction::callAsFunction):
        * bindings/js/kjs_window.cpp:
        (KJS::Window::clear):
        Changed Proto to Prototype, and ProtoFunc to PrototypeFunction.

LayoutTests:
        * fast/dom/Window/window-properties-expected.txt:
        * fast/dom/prototype-chain-expected.txt:
        * fast/events/event-view-toString-expected.txt:
        * fast/events/mouseclick-target-and-positioning-expected.txt:
        * fast/tokenizer/external-script-document-write-expected.checksum:
        * fast/tokenizer/external-script-document-write-expected.png:
        * fast/tokenizer/external-script-document-write-expected.txt:
        Updated the results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Zack and Darin
lars [Wed, 17 Jan 2007 19:04:39 +0000 (19:04 +0000)]
    Reviewed by Zack and Darin

        Fix the Qt build again after the latest Image changes.
        Also make some of the methods implemented in ImageCG
        crossplatform.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by John Sullivan.
andersca [Wed, 17 Jan 2007 18:45:57 +0000 (18:45 +0000)]
    Reviewed by John Sullivan.

        Move all code in WebNetscapePluginEmbeddedView down to WebBaseNetscapePluginView.

        * Plugins/WebBaseNetscapePluginView.h:
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:DOMElement:]):
        (-[WebBaseNetscapePluginView didStart]):
        (-[WebBaseNetscapePluginView dataSource]):
        (-[WebBaseNetscapePluginView dealloc]):
        (-[WebBaseNetscapePluginView pluginView:receivedResponse:]):
        (-[WebBaseNetscapePluginView pluginView:receivedData:]):
        (-[WebBaseNetscapePluginView pluginView:receivedError:]):
        (-[WebBaseNetscapePluginView pluginViewFinishedLoading:]):
        (-[WebBaseNetscapePluginView _redeliverStream]):
        * Plugins/WebNetscapePluginEmbeddedView.h:
        * Plugins/WebNetscapePluginEmbeddedView.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - quick attempt to fix the Qt build
darin [Wed, 17 Jan 2007 17:08:05 +0000 (17:08 +0000)]
    - quick attempt to fix the Qt build

        * platform/graphics/qt/ImageQt.cpp: (WebCore::BitmapImage::drawTiled):
        Remove obsolete parameters from this stub.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-01-17 Eric Seidel <eric@webkit.org>
eseidel [Wed, 17 Jan 2007 14:59:18 +0000 (14:59 +0000)]
2007-01-17  Eric Seidel  <eric@webkit.org>

        Reviewed by rwlbuis.

        Test: svg/custom/inner-svg-hit-test.svg

        * rendering/RenderSVGContainer.cpp:
        (WebCore::RenderSVGContainer::nodeAtPoint): never allow containers to be hit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Zack
lars [Wed, 17 Jan 2007 13:18:33 +0000 (13:18 +0000)]
    Reviewed by Zack

        Don't call receivedResponse twice for file: URLs.
        Never call back into the ResourceHandleClient once
        cancel() has been called on the ResourceHandle.

        Remove the inheritance from Shared<XxxClient> in the
        client classes.

        Answer asynchronously to most of the Policy checking methods
        in FrameLoaderClientQt to avoid some crashes in the loader.

        Small fixes in DumpRenderTree, so we don't by
        accident dump twice for the same test.

        Exclude one more test as it currently causes DumpRenderTree to
        hang forever.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-01-17 Eric Seidel <eric@webkit.org>
eseidel [Wed, 17 Jan 2007 12:21:12 +0000 (12:21 +0000)]
2007-01-17  Eric Seidel  <eric@webkit.org>

        No review, build fix only.

        * platform/graphics/cg/ImageCG.cpp: correct drawPatternCombined to drawPattern
        (WebCore::Image::drawPattern):
        (WebCore::Image::drawTiled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-01-17 Eric Seidel <eric@webkit.org>
eseidel [Wed, 17 Jan 2007 12:10:06 +0000 (12:10 +0000)]
2007-01-17  Eric Seidel  <eric@webkit.org>

        Reviewed by mitz and rwlbuis.

        SVGs do not work as background images:
        http://bugs.webkit.org/show_bug.cgi?id=12096

        Tests updated:
        - fast/images/svg-as-background.svg: now passes
        - fast/images/svg-as-tiled-background.svg: now passes

        * platform/graphics/BitmapImage.h:
        (WebCore::BitmapImage::nativeImageForCurrentFrame):
        (WebCore::BitmapImage::mayFillWithSolidColor):
        (WebCore::BitmapImage::solidColor):
        * platform/graphics/Image.h:
        (WebCore::Image::mayFillWithSolidColor):
        (WebCore::Image::solidColor):
        (WebCore::Image::nativeImageForCurrentFrame):
        (WebCore::Image::startAnimation):
        * platform/graphics/cg/ImageCG.cpp:
        (WebCore::Image::drawPatternCallback):
        (WebCore::Image::drawPatternCombined):
        (WebCore::caculatePatternScale):
        (WebCore::Image::drawTiled):
        * platform/graphics/cg/PDFDocumentImage.cpp:
        * platform/graphics/cg/PDFDocumentImage.h:
        * platform/graphics/svg/SVGImage.cpp:
        (WebCore::SVGImage::nativeImageForCurrentFrame):
        * platform/graphics/svg/SVGImage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Eric.
mjs [Wed, 17 Jan 2007 10:11:50 +0000 (10:11 +0000)]
    Reviewed by Eric.

        <rdar://problem/4887781> Seed: Repro Safari crash in -[WebHTMLRepresentation receivedData:withDataSource:] (music.aol.com)

        * WebView/WebDataSource.mm:
        (-[WebDataSource _receivedData:]): Protect self against destruction partway through this method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Eric
rwlbuis [Wed, 17 Jan 2007 09:58:20 +0000 (09:58 +0000)]
    Reviewed by Eric

        Add proper condition for rx attribute negative check.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Add a message handler to DumpRenderTree that will
lars [Wed, 17 Jan 2007 09:14:51 +0000 (09:14 +0000)]
    Add a message handler to DumpRenderTree that will
        suppress all debug output coming from qDebug() statements.
        Like this we can get rid of all the noise coming
        from the notImplemented() macro when running the
        layout tests. You can get it back by adding -v to
        DumpRenderTree's command line.

        Changed run-webkit-tests slightly, so we by default
        don't fail anymore when our output differs from what
        is generated on the Mac. Added a --strict option, so
        that we can still see this cases and fix them one by one.

        change all notImplemented() macros to use qDebug
        instead of fprintf(stder, ...)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
beidson [Wed, 17 Jan 2007 08:13:36 +0000 (08:13 +0000)]
WebCore:
        Reviewed by Oliver

        A few enhancements to the HTTP Auth architecture

        * platform/network/ProtectionSpace.cpp:
        (WebCore::ProtectionSpace::isProxy):
        (WebCore::ProtectionSpace::receivesCredentialSecurely):
        * platform/network/ProtectionSpace.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
aliceli1 [Wed, 17 Jan 2007 04:37:25 +0000 (04:37 +0000)]
WebCore:

        Reviewed by harrison.

        Fixed <rdar://problem/4921134> WebKit needs extensible cut/copy to allow additional types to be written to pasteboard

        * WebCore.xcodeproj/project.pbxproj:
        * bridge/EditorClient.h:
        * editing/Editor.cpp:
        (WebCore::Editor::copy):
        (WebCore::Editor::didWriteSelectionToPasteboard):
        * editing/Editor.h:
        * platform/graphics/svg/SVGImageEmptyClients.h:
        (WebCore::SVGEmptyEditorClient::didWriteSelectionToPasteboard):

WebKit:

        Reviewed by harrison.

        Fixed <rdar://problem/4921134> WebKit needs extensible cut/copy to allow additional types to be written to pasteboard

        * DefaultDelegates/WebDefaultEditingDelegate.m:
        (-[WebDefaultEditingDelegate webView:didWriteSelectionToPasteboard:]):
        * WebCoreSupport/WebEditorClient.h:
        * WebCoreSupport/WebEditorClient.mm:
        (WebEditorClient::didWriteSelectionToPasteboard):
        * WebKit.xcodeproj/project.pbxproj:
        * WebView/WebEditingDelegate.h:

WebKitQt:

        Added these stubs to keep the Qt build from failing.

        * WebCoreSupport/EditorClientQt.cpp:
        (WebCore::EditorClientQt::didWriteSelectionToPasteboard):
        * WebCoreSupport/EditorClientQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
justing [Wed, 17 Jan 2007 01:10:30 +0000 (01:10 +0000)]
LayoutTests:

        Reviewed by harrison

        <rdar://problem/4747450>
        Gmail Editor: Caret doesn't always position itself after list marker
        <rdar://problem/4917055>
        GMail Editor: A hang can occur when attempting to apply list styling to selected indented text

        Added:
        * editing/execCommand/4747450-expected.checksum: Added.
        * editing/execCommand/4747450-expected.png: Added.
        * editing/execCommand/4747450-expected.txt: Added.
        * editing/execCommand/4747450.html: Added.
        * editing/execCommand/4917055-expected.txt: Added.
        * editing/execCommand/4917055.html: Added.
        Fixed:
        * editing/execCommand/create-list-with-hr-expected.checksum:
        * editing/execCommand/create-list-with-hr-expected.png:
        * editing/execCommand/create-list-with-hr-expected.txt:

WebCore:

        Reviewed by harrison

        <rdar://problem/4747450>
        Gmail Editor: Caret doesn't always position itself after list marker
        <rdar://problem/4917055>
        GMail Editor: A hang can occur when attempting to apply list styling to selected indented text

        * editing/TextIterator.cpp:
        (WebCore::TextIterator::rangeFromLocationAndLength): Use VisiblePositions
        to compute the end of a run for emitted '\n's, because it's often wrong
        in that case.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - quick lame attempt to get Qt compiling again
darin [Wed, 17 Jan 2007 00:40:28 +0000 (00:40 +0000)]
    - quick lame attempt to get Qt compiling again

        * platform/qt/ContextMenuQt.cpp: Removed show() function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-01-17 Nicholas Shanks <contact@nickshanks.com>
bdash [Wed, 17 Jan 2007 00:07:55 +0000 (00:07 +0000)]
2007-01-17  Nicholas Shanks  <contact@nickshanks.com>

        Reviewed by Darin.

        * platform/network/ResourceRequest.h:
        (WebCore::ResourceRequest::setHTTPAccept): Correct argument name.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoClean up merge conflict spew.
bdakin [Tue, 16 Jan 2007 21:55:42 +0000 (21:55 +0000)]
Clean up merge conflict spew.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam.
bdakin [Tue, 16 Jan 2007 21:40:54 +0000 (21:40 +0000)]
    Reviewed by Adam.

        Get rid of show() and hide() since they don't do anything.

        * page/ContextMenuController.cpp:
        (WebCore::ContextMenuController::handleContextMenuEvent):
        * platform/ContextMenu.h:
        * platform/mac/ContextMenuMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin Adler.
ggaren [Tue, 16 Jan 2007 21:07:54 +0000 (21:07 +0000)]
    Reviewed by Darin Adler.

        Added re-entrency checking to GC allocation and collection. It is an error
        to allocate or collect from within a collection. We've had at least one
        case of each bug in the past.

        Added a comment to the API header, explaining that API clients must not
        make this mistake, either.

        Layout tests and JS tests pass.

        * API/JSObjectRef.h:
        * kjs/collector.cpp:
        (KJS::GCLock::GCLock):
        (KJS::GCLock::~GCLock):
        (KJS::Collector::allocate):
        (KJS::Collector::collect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - updated one more test results affected by Rob's coordinates patch
darin [Tue, 16 Jan 2007 15:38:28 +0000 (15:38 +0000)]
    - updated one more test results affected by Rob's coordinates patch

        * svg/W3C-SVG-1.1/coords-units-03-b-expected.checksum: Regenerated.
        * svg/W3C-SVG-1.1/coords-units-03-b-expected.png: Ditto.
        * svg/W3C-SVG-1.1/coords-units-03-b-expected.txt: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Added the start of a public API to the Qt build
lars [Tue, 16 Jan 2007 15:03:44 +0000 (15:03 +0000)]
    Added the start of a public API to the Qt build
        of WebKit. Currently we have QWebPage and QWebFrame
        with a few small methods.

        Converted the QtLauncher and DumpRenderTree
        to use the new public API.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Zack
lars [Tue, 16 Jan 2007 12:25:39 +0000 (12:25 +0000)]
    Reviewed by Zack

        Looks like ResourceHandle _has_ to do everything
        asynchronously if we don't want to run into
        lots of trouble in the loader.

        Implement support data: URLs.

        Remove some unused Qt only code in ResourceHandleClient.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-01-16 Eric Seidel <eric@webkit.org>
eseidel [Tue, 16 Jan 2007 11:40:10 +0000 (11:40 +0000)]
2007-01-16  Eric Seidel  <eric@webkit.org>

        Reviewed by mitz.

        Refactor drawTiled implementations in preparation for combining them.
        Removed unused RoundTile code path.

        * platform/graphics/cg/ImageCG.cpp:
        (WebCore::drawPattern):
        (WebCore::BitmapImage::drawTiled):
        (WebCore::caculatePatternScale):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Mark Rowe.
darin [Tue, 16 Jan 2007 08:14:29 +0000 (08:14 +0000)]
    Reviewed by Mark Rowe.

        - removed unused field from loader

        * loader/loader.cpp:
        (WebCore::Loader::numRequests):
        (WebCore::Loader::cancelRequests):
        * loader/loader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Eric.
rwlbuis [Tue, 16 Jan 2007 07:50:20 +0000 (07:50 +0000)]
    Reviewed by Eric.

        http://bugs.webkit.org/show_bug.cgi?id=12272
        SVG picture is clipped (edges not visible)

        Expose css dpi constant and use it for svg, making
        1in amount to 96 pixels like for html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej
beidson [Tue, 16 Jan 2007 07:23:27 +0000 (07:23 +0000)]
    Reviewed by Maciej

        * coding/coding-style.html: Added switch/case indentation rules

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
beidson [Tue, 16 Jan 2007 06:39:59 +0000 (06:39 +0000)]
WebCore:
        Reviewed by Adam

        CFNet additions

        * platform/network/AuthenticationChallenge.cpp:
        (WebCore::operator==):
        * platform/network/AuthenticationChallenge.h:
        (WebCore::AuthenticationChallenge::sourceHandle):
        (WebCore::AuthenticationChallenge::cfURLAuthChallengeRef):
        * platform/network/ResourceError.h:
        * platform/network/ResourceHandle.h:
        * platform/network/ResourceHandleInternal.h:
        (WebCore::ResourceHandleInternal::ResourceHandleInternal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-01-15 Eric Seidel <eric@webkit.org>
eseidel [Tue, 16 Jan 2007 05:25:48 +0000 (05:25 +0000)]
2007-01-15  Eric Seidel  <eric@webkit.org>

        Reviewed by hyatt.

        Don't map attributes in namespaces other than null to CSS properties.

        Test: svg/custom/attribute-namespace-check.svg

        * ksvg2/svg/SVGStyledElement.cpp:
        (WebCore::SVGStyledElement::cssPropertyIdForSVGAttributeName):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
darin [Tue, 16 Jan 2007 04:46:59 +0000 (04:46 +0000)]
    Reviewed by Darin.

        - http://bugs.webkit.org/show_bug.cgi?id=11112
          add a drop shadow to the hand cursor used for links

        * Resources/linkCursor.png: Added a drop shadow.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
darin [Tue, 16 Jan 2007 04:43:39 +0000 (04:43 +0000)]
LayoutTests:

        - test for http://bugs.webkit.org/show_bug.cgi?id=12190
          REGRESSION: Placeholder text does not reflect dynamic updates

        * fast/forms/placeholder-set-attribute-expected.checksum: Added.
        * fast/forms/placeholder-set-attribute-expected.png: Added.
        * fast/forms/placeholder-set-attribute-expected.txt: Added.
        * fast/forms/placeholder-set-attribute.html: Added.

WebCore:

        Reviewed by Adam.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12190
          REGRESSION: Placeholder text does not reflect dynamic updates

        Test: fast/forms/placeholder-set-attribute.html

        * html/HTMLTextFieldInnerElement.cpp:
        (WebCore::HTMLSearchFieldCancelButtonElement::defaultEventHandler):
        Call onSearch on the element since I removed it from the renderer.

        * rendering/RenderTextControl.h: Added explicit virtual keywords for overrides
        of virtual functions. Removed the unneeded onSearch function. Made the inheritance
        from PopupMenuClient be private, and made the overrides all private. Replaced the
        showPlaceholderIfNeeded and hidePlaceholderIfNeeded functions with updatePlaceholder.
        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::createResultsButtonStyle): Added an assertion.
        (WebCore::RenderTextControl::updatePlaceholder): Added. Replaces the two
        functions, showPlaceholderIfNeeded and hidePlaceholderIfNeeded.
        (WebCore::RenderTextControl::updateFromElement): Added call to
        updatePlaceholder before updating the value. Also improved the structure
        of the function and corrected incorrect use of copy and replace.
        (WebCore::RenderTextControl::updateCancelButtonVisibility): Added an
        assertion and removed an unneeded local variable.
        (WebCore::RenderTextControl::subtreeHasChanged): Removed an unneeded
        null check and virtual function calls.
        (WebCore::RenderTextControl::forwardEvent): Replaced calls to the old
        functions with calls to updatePlaceholder.
        (WebCore::RenderTextControl::selectionChanged): Changed code to dispatch
        the select event directly -- I plan to remove the onSelect function, which
        was only called here.
        (WebCore::RenderTextControl::autosaveName): Removed too-specific cast and
        local variable.
        (WebCore::RenderTextControl::addSearchResult): Added assertion and changed
        variable name for clarity.
        (WebCore::RenderTextControl::valueChanged): Changed code to check for empty
        autosave name instead of null for consistency with other call sites that
        manage the autosave name. Also changed the code that dispatches an event
        to call onSearch on the input element so we don't need our own function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-01-15 Eric Seidel <eric@webkit.org>
eseidel [Tue, 16 Jan 2007 04:01:57 +0000 (04:01 +0000)]
2007-01-15  Eric Seidel  <eric@webkit.org>

        Reviewed by hyatt.

        Fix SVGStyledElement::parseMappedAttribute to only map SVG-allowed CSS properties
        (i.e. width is no longer mapped to CSS for SVG)
        Add SVGStyledElement::mapToEntry to allow RenderStyle-sharing
        http://bugs.webkit.org/show_bug.cgi?id=12060

        * dom/MappedAttributeEntry.h:
        (WebCore::):
        * ksvg2/svg/SVGStyledElement.cpp:
        (WebCore::cssPropertyIdForName): new helper
        (WebCore::mapAttributeToCSSProperty): new helper
        (WebCore::SVGStyledElement::cssPropertyIdForSVGAttributeName): new helper
        (WebCore::SVGStyledElement::mapToEntry): added.
        (WebCore::SVGStyledElement::parseMappedAttribute): use cssPropertyIdForSVGAttributeName
        * ksvg2/svg/SVGStyledElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
justing [Tue, 16 Jan 2007 00:53:51 +0000 (00:53 +0000)]
LayoutTests:

        Reviewed by mjs

        <rdar://problem/4810960>
        Gmail Editor: window.focus() called on keyDown (9640)

        * editing/input/attributed-substring-from-range-lines.html-disabled:
        * fast/events/keydown-1-expected.checksum: Added.
        * fast/events/keydown-1-expected.png: Added.
        * fast/events/keydown-1-expected.txt: Added.
        * fast/events/keydown-1.html: Added.

WebKit:

        Reviewed by mjs

        <rdar://problem/4810960>
        Gmail Editor: window.focus() called on keyDown (9640)

        The window's keydown event handler was being called
        instead of the editable subframe's if there was a key binding
        for the key event.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView performKeyEquivalent:]): Don't send the event
        to WebCore unless this WebHTMLView is the firstResponder.

WebKitTools:

        Reviewed by mjs

        <rdar://problem/4810960>
        Gmail Editor: window.focus() called on keyDown (9640)

        * DumpRenderTree/EventSendingController.m: Send the keyDown event
        to the firstResponder, not the event's locationInWindow.  A
        key press's locationInWindow is meaningless and just a dummy
        coordinate.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-01-15 Eric Seidel <eric@webkit.org>
eseidel [Tue, 16 Jan 2007 00:49:43 +0000 (00:49 +0000)]
2007-01-15  Eric Seidel  <eric@webkit.org>

        Reviewed by bdash.

        Update header guards to follow new style guidelines using new clean-header-guards script.

        * bindings/js/JSHTMLElementWrapperFactory.h:
        * bindings/js/JSHTMLInputElementBase.h:
        * bindings/js/JSHTMLOptionElementConstructor.h:
        * bindings/js/JSSVGElementWrapperFactory.h:
        * bindings/js/JSSVGPODTypeWrapper.h:
        * bindings/js/JSXMLHttpRequest.h:
        * bindings/js/JSXSLTProcessor.h:
        * bindings/js/kjs_binding.h:
        * bindings/js/kjs_css.h:
        * bindings/js/kjs_dom.h:
        * bindings/js/kjs_domnode.h:
        * bindings/js/kjs_events.h:
        * bindings/js/kjs_html.h:
        * bindings/js/kjs_navigator.h:
        * bindings/js/kjs_proxy.h:
        * bindings/js/kjs_traversal.h:
        * bindings/js/kjs_window.h:
        * bridge/EditorClient.h:
        * bridge/History.h:
        * css/CSSStyleSheet.h:
        * css/CSSValue.h:
        * css/CSSValueList.h:
        * css/DashboardRegion.h:
        * css/FontFamilyValue.h:
        * css/FontValue.h:
        * css/MediaFeatureNames.h:
        * css/MediaList.h:
        * css/Pair.h:
        * css/RectImpl.h:
        * css/ShadowValue.h:
        * css/StyleBase.h:
        * css/StyleList.h:
        * css/StyleSheet.h:
        * css/StyleSheetList.h:
        * css/cssstyleselector.h:
        * dom/BeforeTextInsertedEvent.h:
        * dom/CDATASection.h:
        * dom/CharacterData.h:
        * dom/ChildNodeList.h:
        * dom/Comment.h:
        * dom/DOMImplementation.h:
        * dom/DocPtr.h:
        * dom/Document.h:
        * dom/DocumentFragment.h:
        * dom/DocumentMarker.h:
        * dom/DocumentType.h:
        * dom/EditingText.h:
        * dom/Entity.h:
        * dom/EntityReference.h:
        * dom/EventNames.h:
        * dom/EventTargetNode.h:
        * dom/NameNodeList.h:
        * dom/NamedNodeMap.h:
        * dom/Node.h:
        * dom/NodeList.h:
        * dom/Notation.h:
        * dom/Position.h:
        * dom/ProcessingInstruction.h:
        * dom/Range.h:
        * dom/StyleElement.h:
        * dom/Text.h:
        * editing/AppendNodeCommand.h:
        * editing/ApplyStyleCommand.h:
        * editing/BreakBlockquoteCommand.h:
        * editing/CommandByName.h:
        * editing/CompositeEditCommand.h:
        * editing/DeleteButton.h:
        * editing/DeleteButtonController.h:
        * editing/DeleteFromTextNodeCommand.h:
        * editing/DeleteSelectionCommand.h:
        * editing/InsertIntoTextNodeCommand.h:
        * editing/InsertLineBreakCommand.h:
        * editing/InsertNodeBeforeCommand.h:
        * editing/InsertParagraphSeparatorCommand.h:
        * editing/InsertTextCommand.h:
        * editing/JoinTextNodesCommand.h:
        * editing/MergeIdenticalElementsCommand.h:
        * editing/ModifySelectionListLevel.h:
        * editing/MoveSelectionCommand.h:
        * editing/RemoveCSSPropertyCommand.h:
        * editing/RemoveNodeAttributeCommand.h:
        * editing/RemoveNodeCommand.h:
        * editing/RemoveNodePreservingChildrenCommand.h:
        * editing/ReplaceSelectionCommand.h:
        * editing/SetNodeAttributeCommand.h:
        * editing/SplitElementCommand.h:
        * editing/SplitTextNodeCommand.h:
        * editing/SplitTextNodeContainingElementCommand.h:
        * editing/TextGranularity.h:
        * editing/TypingCommand.h:
        * editing/WrapContentsInDummySpanCommand.h:
        * history/BackForwardList.h:
        * history/HistoryItem.h:
        * history/HistoryItemTimer.h:
        * history/PageCache.h:
        * html/CanvasGradient.h:
        * html/CanvasPattern.h:
        * html/CanvasRenderingContext2D.h:
        * html/CanvasStyle.h:
        * html/FormDataList.h:
        * html/HTMLAnchorElement.h:
        * html/HTMLAppletElement.h:
        * html/HTMLAreaElement.h:
        * html/HTMLBRElement.h:
        * html/HTMLBaseElement.h:
        * html/HTMLBaseFontElement.h:
        * html/HTMLBlockquoteElement.h:
        * html/HTMLBodyElement.h:
        * html/HTMLButtonElement.h:
        * html/HTMLCanvasElement.h:
        * html/HTMLCollection.h:
        * html/HTMLDListElement.h:
        * html/HTMLDirectoryElement.h:
        * html/HTMLDivElement.h:
        * html/HTMLElement.h:
        * html/HTMLElementFactory.h:
        * html/HTMLEmbedElement.h:
        * html/HTMLFieldSetElement.h:
        * html/HTMLFontElement.h:
        * html/HTMLFormCollection.h:
        * html/HTMLFormElement.h:
        * html/HTMLFrameSetElement.h:
        * html/HTMLGenericFormElement.h:
        * html/HTMLHRElement.h:
        * html/HTMLHeadElement.h:
        * html/HTMLHeadingElement.h:
        * html/HTMLHtmlElement.h:
        * html/HTMLImageElement.h:
        * html/HTMLImageLoader.h:
        * html/HTMLInputElement.h:
        * html/HTMLIsIndexElement.h:
        * html/HTMLKeygenElement.h:
        * html/HTMLLIElement.h:
        * html/HTMLLabelElement.h:
        * html/HTMLLegendElement.h:
        * html/HTMLLinkElement.h:
        * html/HTMLMapElement.h:
        * html/HTMLMarqueeElement.h:
        * html/HTMLMenuElement.h:
        * html/HTMLMetaElement.h:
        * html/HTMLModElement.h:
        * html/HTMLNameCollection.h:
        * html/HTMLOListElement.h:
        * html/HTMLObjectElement.h:
        * html/HTMLOptGroupElement.h:
        * html/HTMLOptionElement.h:
        * html/HTMLOptionsCollection.h:
        * html/HTMLParagraphElement.h:
        * html/HTMLParamElement.h:
        * html/HTMLParser.h:
        * html/HTMLPlugInElement.h:
        * html/HTMLPreElement.h:
        * html/HTMLQuoteElement.h:
        * html/HTMLScriptElement.h:
        * html/HTMLSelectElement.h:
        * html/HTMLStyleElement.h:
        * html/HTMLTableCaptionElement.h:
        * html/HTMLTableCellElement.h:
        * html/HTMLTableColElement.h:
        * html/HTMLTableElement.h:
        * html/HTMLTablePartElement.h:
        * html/HTMLTableRowElement.h:
        * html/HTMLTableSectionElement.h:
        * html/HTMLTextAreaElement.h:
        * html/HTMLTextFieldInnerElement.h:
        * html/HTMLTitleElement.h:
        * html/HTMLUListElement.h:
        * ksvg2/css/SVGRenderStyle.h:
        * ksvg2/css/SVGRenderStyleDefs.h:
        * ksvg2/events/JSSVGLazyEventListener.h:
        * ksvg2/events/SVGZoomEvent.h:
        * ksvg2/misc/KCanvasRenderingStyle.h:
        * ksvg2/misc/PointerEventsHitRules.h:
        * ksvg2/misc/SVGDocumentExtensions.h:
        * ksvg2/misc/SVGImageLoader.h:
        * ksvg2/misc/TimeScheduler.h:
        * ksvg2/svg/GradientAttributes.h:
        * ksvg2/svg/LinearGradientAttributes.h:
        * ksvg2/svg/PatternAttributes.h:
        * ksvg2/svg/RadialGradientAttributes.h:
        * ksvg2/svg/SVGAElement.h:
        * ksvg2/svg/SVGAngle.h:
        * ksvg2/svg/SVGAnimateColorElement.h:
        * ksvg2/svg/SVGAnimateElement.h:
        * ksvg2/svg/SVGAnimateMotionElement.h:
        * ksvg2/svg/SVGAnimateTransformElement.h:
        * ksvg2/svg/SVGAnimatedPathData.h:
        * ksvg2/svg/SVGAnimatedPoints.h:
        * ksvg2/svg/SVGAnimatedTemplate.h:
        * ksvg2/svg/SVGAnimationElement.h:
        * ksvg2/svg/SVGCircleElement.h:
        * ksvg2/svg/SVGClipPathElement.h:
        * ksvg2/svg/SVGColor.h:
        * ksvg2/svg/SVGComponentTransferFunctionElement.h:
        * ksvg2/svg/SVGCursorElement.h:
        * ksvg2/svg/SVGDOMImplementation.h:
        * ksvg2/svg/SVGDefsElement.h:
        * ksvg2/svg/SVGDescElement.h:
        * ksvg2/svg/SVGDocument.h:
        * ksvg2/svg/SVGElement.h:
        * ksvg2/svg/SVGElementInstance.h:
        * ksvg2/svg/SVGElementInstanceList.h:
        * ksvg2/svg/SVGEllipseElement.h:
        * ksvg2/svg/SVGExternalResourcesRequired.h:
        * ksvg2/svg/SVGFEBlendElement.h:
        * ksvg2/svg/SVGFEColorMatrixElement.h:
        * ksvg2/svg/SVGFEComponentTransferElement.h:
        * ksvg2/svg/SVGFECompositeElement.h:
        * ksvg2/svg/SVGFEDiffuseLightingElement.h:
        * ksvg2/svg/SVGFEDisplacementMapElement.h:
        * ksvg2/svg/SVGFEDistantLightElement.h:
        * ksvg2/svg/SVGFEFloodElement.h:
        * ksvg2/svg/SVGFEFuncAElement.h:
        * ksvg2/svg/SVGFEFuncBElement.h:
        * ksvg2/svg/SVGFEFuncGElement.h:
        * ksvg2/svg/SVGFEFuncRElement.h:
        * ksvg2/svg/SVGFEGaussianBlurElement.h:
        * ksvg2/svg/SVGFEImageElement.h:
        * ksvg2/svg/SVGFELightElement.h:
        * ksvg2/svg/SVGFEMergeElement.h:
        * ksvg2/svg/SVGFEMergeNodeElement.h:
        * ksvg2/svg/SVGFEOffsetElement.h:
        * ksvg2/svg/SVGFEPointLightElement.h:
        * ksvg2/svg/SVGFESpecularLightingElement.h:
        * ksvg2/svg/SVGFESpotLightElement.h:
        * ksvg2/svg/SVGFETileElement.h:
        * ksvg2/svg/SVGFETurbulenceElement.h:
        * ksvg2/svg/SVGFilterElement.h:
        * ksvg2/svg/SVGFilterPrimitiveStandardAttributes.h:
        * ksvg2/svg/SVGFitToViewBox.h:
        * ksvg2/svg/SVGForeignObjectElement.h:
        * ksvg2/svg/SVGGElement.h:
        * ksvg2/svg/SVGGradientElement.h:
        * ksvg2/svg/SVGImageElement.h:
        * ksvg2/svg/SVGLangSpace.h:
        * ksvg2/svg/SVGLength.h:
        * ksvg2/svg/SVGLengthList.h:
        * ksvg2/svg/SVGLineElement.h:
        * ksvg2/svg/SVGLinearGradientElement.h:
        * ksvg2/svg/SVGList.h:
        * ksvg2/svg/SVGListTraits.h:
        * ksvg2/svg/SVGLocatable.h:
        * ksvg2/svg/SVGMarkerElement.h:
        * ksvg2/svg/SVGMaskElement.h:
        * ksvg2/svg/SVGMetadataElement.h:
        * ksvg2/svg/SVGNumberList.h:
        * ksvg2/svg/SVGPaint.h:
        * ksvg2/svg/SVGParserUtilities.h:
        * ksvg2/svg/SVGPathElement.h:
        * ksvg2/svg/SVGPathSeg.h:
        * ksvg2/svg/SVGPathSegArc.h:
        * ksvg2/svg/SVGPathSegClosePath.h:
        * ksvg2/svg/SVGPathSegCurvetoCubic.h:
        * ksvg2/svg/SVGPathSegCurvetoCubicSmooth.h:
        * ksvg2/svg/SVGPathSegCurvetoQuadratic.h:
        * ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.h:
        * ksvg2/svg/SVGPathSegLineto.h:
        * ksvg2/svg/SVGPathSegLinetoHorizontal.h:
        * ksvg2/svg/SVGPathSegLinetoVertical.h:
        * ksvg2/svg/SVGPathSegList.h:
        * ksvg2/svg/SVGPathSegMoveto.h:
        * ksvg2/svg/SVGPatternElement.h:
        * ksvg2/svg/SVGPointList.h:
        * ksvg2/svg/SVGPolyElement.h:
        * ksvg2/svg/SVGPolygonElement.h:
        * ksvg2/svg/SVGPolylineElement.h:
        * ksvg2/svg/SVGPreserveAspectRatio.h:
        * ksvg2/svg/SVGRadialGradientElement.h:
        * ksvg2/svg/SVGRectElement.h:
        * ksvg2/svg/SVGRenderingIntent.h:
        * ksvg2/svg/SVGSVGElement.h:
        * ksvg2/svg/SVGScriptElement.h:
        * ksvg2/svg/SVGSetElement.h:
        * ksvg2/svg/SVGStopElement.h:
        * ksvg2/svg/SVGStringList.h:
        * ksvg2/svg/SVGStylable.h:
        * ksvg2/svg/SVGStyleElement.h:
        * ksvg2/svg/SVGStyledElement.h:
        * ksvg2/svg/SVGStyledLocatableElement.h:
        * ksvg2/svg/SVGStyledTransformableElement.h:
        * ksvg2/svg/SVGSwitchElement.h:
        * ksvg2/svg/SVGSymbolElement.h:
        * ksvg2/svg/SVGTRefElement.h:
        * ksvg2/svg/SVGTSpanElement.h:
        * ksvg2/svg/SVGTests.h:
        * ksvg2/svg/SVGTextContentElement.h:
        * ksvg2/svg/SVGTextElement.h:
        * ksvg2/svg/SVGTextPositioningElement.h:
        * ksvg2/svg/SVGTitleElement.h:
        * ksvg2/svg/SVGTransform.h:
        * ksvg2/svg/SVGTransformList.h:
        * ksvg2/svg/SVGTransformable.h:
        * ksvg2/svg/SVGURIReference.h:
        * ksvg2/svg/SVGUnitTypes.h:
        * ksvg2/svg/SVGUseElement.h:
        * ksvg2/svg/SVGViewElement.h:
        * ksvg2/svg/SVGZoomAndPan.h:
        * loader/CachedCSSStyleSheet.h:
        * loader/CachedImage.h:
        * loader/CachedXSLStyleSheet.h:
        * loader/DocumentLoader.h:
        * loader/Request.h:
        * loader/SubresourceLoader.h:
        * loader/icon/IconDataCache.h:
        * loader/icon/IconDatabase.h:
        * loader/icon/IconLoader.h:
        * loader/icon/SQLDatabase.h:
        * loader/icon/SQLStatement.h:
        * loader/icon/SQLTransaction.h:
        * page/Frame.h:
        * page/FrameLoadRequest.h:
        * page/FrameTree.h:
        * page/FrameView.h:
        * page/PageState.h:
        * page/Plugin.h:
        * page/qt/FrameQt.h:
        * page/qt/FrameQtClient.h:
        * platform/Arena.h:
        * platform/ArrayImpl.h:
        * platform/Cursor.h:
        * platform/DeprecatedArray.h:
        * platform/DeprecatedCString.h:
        * platform/FileChooser.h:
        * platform/Font.h:
        * platform/FontCache.h:
        * platform/FontData.h:
        * platform/FontDescription.h:
        * platform/FontFamily.h:
        * platform/GlyphBuffer.h:
        * platform/GlyphMap.h:
        * platform/GlyphWidthMap.h:
        * platform/Logging.h:
        * platform/Pasteboard.h:
        * platform/PlatformString.h:
        * platform/PlugInInfoStore.h:
        * platform/PopupMenu.h:
        * platform/PopupMenuClient.h:
        * platform/ScrollBar.h:
        * platform/ScrollView.h:
        * platform/SearchPopupMenu.h:
        * platform/Shared.h:
        * platform/Sound.h:
        * platform/SystemTime.h:
        * platform/Timer.h:
        * platform/Widget.h:
        * platform/cf/RetainPtr.h:
        * platform/gdk/ChromeClientGdk.h:
        * platform/gdk/FontPlatformData.h:
        * platform/gdk/FrameGdk.h:
        * platform/gdk/KeyboardCodes.h:
        * platform/gdk/RenderPopupMenuGdk.h:
        * platform/gdk/RenderThemeGdk.h:
        * platform/graphics/BitmapImage.h:
        * platform/graphics/Color.h:
        * platform/graphics/FloatPoint.h:
        * platform/graphics/FloatPoint3D.h:
        * platform/graphics/FloatRect.h:
        * platform/graphics/Icon.h:
        * platform/graphics/Image.h:
        * platform/graphics/ImageAnimationObserver.h:
        * platform/graphics/ImageBuffer.h:
        * platform/graphics/ImageSource.h:
        * platform/graphics/IntPoint.h:
        * platform/graphics/IntRect.h:
        * platform/graphics/IntSize.h:
        * platform/graphics/IntSizeHash.h:
        * platform/graphics/PathTraversalState.h:
        * platform/graphics/Pen.h:
        * platform/graphics/qt/ImageDecoderQt.h:
        * platform/graphics/svg/SVGImage.h:
        * platform/graphics/svg/SVGImageEmptyClients.h:
        * platform/graphics/svg/SVGPaintServer.h:
        * platform/graphics/svg/SVGPaintServerGradient.h:
        * platform/graphics/svg/SVGPaintServerLinearGradient.h:
        * platform/graphics/svg/SVGPaintServerPattern.h:
        * platform/graphics/svg/SVGPaintServerRadialGradient.h:
        * platform/graphics/svg/SVGPaintServerSolid.h:
        * platform/graphics/svg/SVGResource.h:
        * platform/graphics/svg/SVGResourceClipper.h:
        * platform/graphics/svg/SVGResourceFilter.h:
        * platform/graphics/svg/SVGResourceMarker.h:
        * platform/graphics/svg/SVGResourceMasker.h:
        * platform/graphics/svg/cg/CgSupport.h:
        * platform/graphics/svg/filters/SVGDistantLightSource.h:
        * platform/graphics/svg/filters/SVGFEBlend.h:
        * platform/graphics/svg/filters/SVGFEColorMatrix.h:
        * platform/graphics/svg/filters/SVGFEComponentTransfer.h:
        * platform/graphics/svg/filters/SVGFEComposite.h:
        * platform/graphics/svg/filters/SVGFEConvolveMatrix.h:
        * platform/graphics/svg/filters/SVGFEDiffuseLighting.h:
        * platform/graphics/svg/filters/SVGFEDisplacementMap.h:
        * platform/graphics/svg/filters/SVGFEFlood.h:
        * platform/graphics/svg/filters/SVGFEGaussianBlur.h:
        * platform/graphics/svg/filters/SVGFEImage.h:
        * platform/graphics/svg/filters/SVGFEMerge.h:
        * platform/graphics/svg/filters/SVGFEMorphology.h:
        * platform/graphics/svg/filters/SVGFEOffset.h:
        * platform/graphics/svg/filters/SVGFESpecularLighting.h:
        * platform/graphics/svg/filters/SVGFETile.h:
        * platform/graphics/svg/filters/SVGFETurbulence.h:
        * platform/graphics/svg/filters/SVGFilterEffect.h:
        * platform/graphics/svg/filters/SVGLightSource.h:
        * platform/graphics/svg/filters/SVGPointLightSource.h:
        * platform/graphics/svg/filters/SVGSpotLightSource.h:
        * platform/mac/FontPlatformData.h:
        * platform/mac/PlatformScrollBar.h:
        * platform/network/AuthenticationChallenge.h:
        * platform/network/Credential.h:
        * platform/network/HTTPHeaderMap.h:
        * platform/network/ProtectionSpace.h:
        * platform/network/ResourceError.h:
        * platform/network/ResourceRequest.h:
        * platform/network/ResourceResponse.h:
        * platform/network/cf/FormDataStreamCFNet.h:
        * platform/network/cf/ResourceRequestCFNet.h:
        * platform/network/cf/ResourceResponseCFNet.h:
        * platform/network/gdk/ResourceHandleManager.h:
        * platform/network/mac/AuthenticationMac.h:
        * platform/network/mac/FormDataStreamMac.h:
        * platform/network/qt/ResourceHandleManagerKDE.h:
        * platform/network/qt/ResourceHandleManagerQt.h:
        * platform/network/win/ResourceHandleWin.h:
        * platform/qt/FontPlatformData.h:
        * platform/qt/KeyboardCodes.h:
        * platform/qt/PlatformScrollBar.h:
        * platform/qt/ScrollViewCanvasQt.h:
        * platform/qt/SharedTimerQt.h:
        * platform/win/FontPlatformData.h:
        * platform/win/PlatformScrollBar.h:
        * rendering/AutoTableLayout.h:
        * rendering/HitTestRequest.h:
        * rendering/HitTestResult.h:
        * rendering/InlineBox.h:
        * rendering/InlineFlowBox.h:
        * rendering/Length.h:
        * rendering/ListMarkerBox.h:
        * rendering/RenderBox.h:
        * rendering/RenderMenuList.h:
        * rendering/RenderPart.h:
        * rendering/RenderPartObject.h:
        * rendering/RenderPath.h:
        * rendering/RenderReplaced.h:
        * rendering/RenderSVGContainer.h:
        * rendering/RenderSVGImage.h:
        * rendering/RenderSVGInline.h:
        * rendering/RenderSVGInlineText.h:
        * rendering/RenderSVGTSpan.h:
        * rendering/RenderSVGText.h:
        * rendering/RenderStyle.h:
        * rendering/RenderTableCol.h:
        * rendering/RenderThemeWin.h:
        * rendering/bidi.h:
        * xml/DOMParser.h:
        * xml/XPathEvaluator.h:
        * xml/XPathExpression.h:
        * xml/XPathExpressionNode.h:
        * xml/XPathFunctions.h:
        * xml/XPathNSResolver.h:
        * xml/XPathNamespace.h:
        * xml/XPathParser.h:
        * xml/XPathPath.h:
        * xml/XPathPredicate.h:
        * xml/XPathResult.h:
        * xml/XPathStep.h:
        * xml/XPathUtil.h:
        * xml/XPathValue.h:
        * xml/XPathVariableReference.h:
        * xml/XSLImportRule.h:
        * xml/XSLStyleSheet.h:
        * xml/XSLTProcessor.h:
        * xml/xmlhttprequest.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-01-15 Eric Seidel <eric@webkit.org>
eseidel [Tue, 16 Jan 2007 00:47:02 +0000 (00:47 +0000)]
2007-01-15  Eric Seidel  <eric@webkit.org>

        Reviewed by bdash.

        Add a script to keep our header guards squeaky clean.

        * Scripts/clean-header-guards: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-01-15 Eric Seidel <eric@webkit.org>
eseidel [Tue, 16 Jan 2007 00:46:38 +0000 (00:46 +0000)]
2007-01-15  Eric Seidel  <eric@webkit.org>

        Reviewed by bdash.

        * coding/coding-style.html: update to include style for header guards

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Build fix.
andersca [Mon, 15 Jan 2007 23:22:56 +0000 (23:22 +0000)]
    Build fix.

        * loader/ProgressTracker.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoCompile and link the ProgressTracker into the Qt build.
lars [Mon, 15 Jan 2007 22:13:55 +0000 (22:13 +0000)]
Compile and link the ProgressTracker into the Qt build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
andersca [Mon, 15 Jan 2007 22:07:21 +0000 (22:07 +0000)]
    Reviewed by Darin.

        * loader/ProgressTracker.cpp:
        Set finalProgressValue to its value explicitly instead of calculating it
        (which causes a global initializer to be generated).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
andersca [Mon, 15 Jan 2007 21:55:00 +0000 (21:55 +0000)]
WebCore:

        Reviewed by Darin and Adam.

        Move progress tracking down to WebCore.

        * WebCore.exp:
        Add ProgressTracker::estimatedProgress() to be used by WebKit.

        * WebCore.xcodeproj/project.pbxproj:
        Add ProgressTracker.[cpp|h]

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::prepareForLoadStart):
        (WebCore::FrameLoader::clearProvisionalLoad):
        (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
        (WebCore::FrameLoader::startLoading):
        (WebCore::FrameLoader::didReceiveResponse):
        (WebCore::FrameLoader::didReceiveData):
        (WebCore::FrameLoader::didFailToLoad):
        (WebCore::FrameLoader::requestFromDelegate):
        (WebCore::FrameLoader::didFinishLoad):
        Call directly to the progress tracker instead of through the frame loader client.

        * loader/FrameLoaderClient.h:
        Get rid of the old methods and add new methods for tracking progress.

        * loader/ProgressTracker.cpp: Added.
        (WebCore::ProgressItem::ProgressItem):
        (WebCore::ProgressTracker::ProgressTracker):
        (WebCore::ProgressTracker::~ProgressTracker):
        (WebCore::ProgressTracker::estimatedProgress):
        (WebCore::ProgressTracker::reset):
        (WebCore::ProgressTracker::progressStarted):
        (WebCore::ProgressTracker::progressCompleted):
        (WebCore::ProgressTracker::finalProgressComplete):
        (WebCore::ProgressTracker::incrementProgress):
        (WebCore::ProgressTracker::completeProgress):
        (WebCore::ProgressTracker::createUniqueIdentifier):
        * loader/ProgressTracker.h: Added.
        New per page class which tracks progress.

        * loader/ResourceLoader.cpp:
        (WebCore::ResourceLoader::willSendRequest):
        * page/Page.cpp:
        (WebCore::Page::Page):
        * page/Page.h:
        (WebCore::Page::progress):
        Move createUniqueIdentifier to ProgressTracker, add ProgressTracker object to Page.

        * platform/graphics/svg/SVGImageEmptyClients.h:
        (WebCore::SVGEmptyFrameLoaderClient::willChangeEstimatedProgress):
        (WebCore::SVGEmptyFrameLoaderClient::didChangeEstimatedProgress):
        (WebCore::SVGEmptyFrameLoaderClient::postProgressStartedNotification):
        (WebCore::SVGEmptyFrameLoaderClient::postProgressEstimateChangedNotification):
        (WebCore::SVGEmptyFrameLoaderClient::postProgressFinishedNotification):
        Add new methods, get rid of the old ones.

WebKit:

        Reviewed by Darin.

        Update to match WebCore.

        * WebCoreSupport/WebFrameLoaderClient.h:
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::willChangeEstimatedProgress):
        (WebFrameLoaderClient::didChangeEstimatedProgress):
        (WebFrameLoaderClient::postProgressStartedNotification):
        (WebFrameLoaderClient::postProgressEstimateChangedNotification):
        (WebFrameLoaderClient::postProgressFinishedNotification):
        Post the correct notifications.

        * WebView/WebView.mm:
        (-[WebViewPrivate init]):
        (-[WebViewPrivate dealloc]):
        Get rid of all progress tracking code.

        (-[WebView estimatedProgress]):
        Call ProgressTracker::estimatedProgress()

WebKitQt:

        Fix build.

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::postProgressStartedNotification):
        (WebCore::FrameLoaderClientQt::postProgressEstimateChangedNotification):
        (WebCore::FrameLoaderClientQt::postProgressFinishedNotification):
        * WebCoreSupport/FrameLoaderClientQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
aroben [Mon, 15 Jan 2007 20:57:21 +0000 (20:57 +0000)]
LayoutTests:

        Reviewed by Anders.

        Fix: http://bugs.webkit.org/show_bug.cgi?id=12288
        fast/tokenizer/004 needs new results

        * fast/tokenizer/004.html: Changed to dump as text, changed tabs to
        spaces.
        * fast/tokenizer/004-expected.txt: Updated results.
        * fast/tokenizer/004-expected.checksum: Removed.
        * fast/tokenizer/004-expected.png: Removed.

WebCore:

        Reviewed by Anders.

        Fix comment.

        * html/HTMLScriptElement.cpp:
        (WebCore::HTMLScriptElement::shouldExecuteAsJavaScript):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago * platform/ContextMenu.cpp:
sullivan [Mon, 15 Jan 2007 19:39:20 +0000 (19:39 +0000)]
    * platform/ContextMenu.cpp:
        (WebCore::ContextMenu::checkOrEnableIfNeeded):
        Leopard build fix; don't declare one of the case values twice

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-01-15 Mitz Pettel <mitz@webkit.org>
ap [Mon, 15 Jan 2007 18:40:08 +0000 (18:40 +0000)]
2007-01-15  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=8604
          rowspan does not work when set through javascript

WebCore:
        * rendering/RenderTableCell.cpp:
        (WebCore::RenderTableCell::updateFromElement): Mark the section for grid recalc
        if row span or column span change.

LayoutTests:
        * fast/dom/HTMLTableElement/colSpan-expected.checksum: Updated.
        * fast/dom/HTMLTableElement/colSpan-expected.png: Updated.
        * fast/dom/HTMLTableElement/colSpan-expected.txt: Updated.
        * fast/dom/HTMLTableElement/colSpan.html: Removed comment about expected
        failure.
        * tables/mozilla/bugs/bug22246-2-expected.checksum: Added.
        * tables/mozilla/bugs/bug22246-2-expected.png: Added.
        * tables/mozilla/bugs/bug22246-2-expected.txt: Added.
        * tables/mozilla/bugs/bug22246-2a-expected.checksum: Added.
        * tables/mozilla/bugs/bug22246-2a-expected.png: Added.
        * tables/mozilla/bugs/bug22246-2a-expected.txt: Added.
        * tables/mozilla/bugs/bug22246-3-expected.checksum: Added.
        * tables/mozilla/bugs/bug22246-3-expected.png: Added.
        * tables/mozilla/bugs/bug22246-3-expected.txt: Added.
        * tables/mozilla/bugs/bug22246-3a-expected.checksum: Added.
        * tables/mozilla/bugs/bug22246-3a-expected.png: Added.
        * tables/mozilla/bugs/bug22246-3a-expected.txt: Added.
        * tables/mozilla_expected_failures/bugs/bug22246-2-expected.checksum: Removed.
        * tables/mozilla_expected_failures/bugs/bug22246-2-expected.png: Removed.
        * tables/mozilla_expected_failures/bugs/bug22246-2-expected.txt: Removed.
        * tables/mozilla_expected_failures/bugs/bug22246-2.html: Moved to mozilla/ since it
        no longer fails.
        * tables/mozilla_expected_failures/bugs/bug22246-2a-expected.checksum: Removed.
        * tables/mozilla_expected_failures/bugs/bug22246-2a-expected.png: Removed.
        * tables/mozilla_expected_failures/bugs/bug22246-2a-expected.txt: Removed.
        * tables/mozilla_expected_failures/bugs/bug22246-2a.html: Moved to mozilla/ since it
        no longer fails.
        * tables/mozilla_expected_failures/bugs/bug22246-3-expected.checksum: Removed.
        * tables/mozilla_expected_failures/bugs/bug22246-3-expected.png: Removed.
        * tables/mozilla_expected_failures/bugs/bug22246-3-expected.txt: Removed.
        * tables/mozilla_expected_failures/bugs/bug22246-3.html: Moved to mozilla/ since it
        no longer fails.
        * tables/mozilla_expected_failures/bugs/bug22246-3a-expected.checksum: Removed.
        * tables/mozilla_expected_failures/bugs/bug22246-3a-expected.png: Removed.
        * tables/mozilla_expected_failures/bugs/bug22246-3a-expected.txt: Removed.
        * tables/mozilla_expected_failures/bugs/bug22246-3a.html: Moved to mozilla/ since it
        no longer fails.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
aroben [Mon, 15 Jan 2007 18:30:12 +0000 (18:30 +0000)]
WebCore:

        Reviewed by Darin.

        Small context menu fixes.

        * platform/ContextMenu.cpp:
        (WebCore::ContextMenu::populate): Fix typo.
        (WebCore::ContextMenu::checkOrEnableIfNeeded): Disabled "No Guesses
        Found", and added all enum values explicitly.

WebKit:

        Reviewed by Darin.

        Fix: http://bugs.webkit.org/show_bug.cgi?id=12134
        REGRESSION: Assertion failure and crash when right clicking selection
        in forms

        * WebCoreSupport/WebContextMenuClient.mm:
        (fixMenusFromOldApps): Static helper to fix up menus from applications
        compiled against Tiger WebKit.
        (WebContextMenuClient::getCustomMenuFromDefaultItems): Call helper to
        fix menus.
        * WebView/WebUIDelegatePrivate.h: Fixed typo.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
ap [Mon, 15 Jan 2007 18:00:30 +0000 (18:00 +0000)]
    Reviewed by Darin.

        http://bugs.webkit.org/show_bug.cgi?id=6272
        XMLHttpRequest freezes on getting a missing document with overridden Content-Length

        http://bugs.webkit.org/show_bug.cgi?id=6212
        Investigate disallowing some XMLHttpRequest headers from being set via setRequestHeader.

        Tests:
        - http/tests/xmlhttprequest/connection-error-sync.html
        - http/tests/xmlhttprequest/set-dangerous-headers.html

        * bindings/js/kjs_binding.cpp:
        (KJS::):
        (KJS::setDOMException): Added support for NETWORK_ERR. Changed the temporary
        PERMISSION_DENIED error into a special case.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::loadResourceSynchronously):
        * loader/FrameLoader.h:
        Return the error object to the caller. Removed an extra local variable for error,
        which shadowed the one from enclosing block.

        * dom/XMLTokenizer.cpp:
        (WebCore::openFunc):
        * xml/XSLTProcessor.cpp:
        (WebCore::docLoaderFunc):
        Updated to pass an error object (currently ignored).

        * xml/xmlhttprequest.cpp:
        (WebCore::canSetRequestHeader): Added. The headers to block include the ones from
        the current XMLHttpRequest draft plus "Via", which is blocked by Firefox.
        (WebCore::XMLHttpRequest::send): Raise an exception if a sync request results in
        an error.
        (WebCore::XMLHttpRequest::setRequestHeader): Call canSetRequestHeader().
        * xml/xmlhttprequest.h:
        (WebCore::): Added NETWORK_ERR and a comment about PERMISSION_DENIED.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoOptimizing rendering on the Qt platform. Mainly switch to QPixmap
zack [Mon, 15 Jan 2007 17:19:24 +0000 (17:19 +0000)]
Optimizing rendering on the Qt platform. Mainly switch to QPixmap
from client-side QImage. Also clean up nasty hacks in ScrollViewCanvasQt

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Zack
lars [Mon, 15 Jan 2007 16:01:21 +0000 (16:01 +0000)]
    Reviewed by Zack

        Fix weird crashes when running the layout tests. The
        reason was that I used KURL (and thus DeprecatedString)
        in a thread. Unfortunately that class is not threadsafe
        at all.

DumpRenderTree: Fix a few smaller issues in there, and update
our list of skipped tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-01-15 Eric Seidel <eric@webkit.org>
eseidel [Mon, 15 Jan 2007 15:35:09 +0000 (15:35 +0000)]
2007-01-15  Eric Seidel  <eric@webkit.org>

        Reviewed by rwlbuis.

        Make isValid check not malloc 3 SVGStringLists for every element.

        No test possible, performance fix only.

        * ksvg2/svg/SVGTests.cpp:
        (WebCore::SVGTests::isValid):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Eric.
rwlbuis [Mon, 15 Jan 2007 15:04:33 +0000 (15:04 +0000)]
    Reviewed by Eric.

        Remove unused member var.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Eric.
rwlbuis [Mon, 15 Jan 2007 11:58:30 +0000 (11:58 +0000)]
    Reviewed by Eric.

        http://bugs.webkit.org/show_bug.cgi?id=12069
        Hit detection fails under some viewbox constraints

        Do not take viewBox into account when hit testing svg container.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix for 12275, negative margins confuse page breaks.
hyatt [Mon, 15 Jan 2007 10:10:49 +0000 (10:10 +0000)]
    Fix  for 12275, negative margins confuse page breaks.

        Reviewed by Eric

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::paintChildren):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-01-15 Eric Seidel <eric@eseidel.com>
eseidel [Mon, 15 Jan 2007 09:19:28 +0000 (09:19 +0000)]
2007-01-15  Eric Seidel  <eric@eseidel.com>

        Reviewed by mjs.

        SVG gradients do not notice stop additions
        http://bugs.webkit.org/show_bug.cgi?id=12192

        Test: svg/custom/gradient-add-stops.svg

        * ksvg2/svg/SVGGradientElement.cpp:
        (WebCore::SVGGradientElement::childrenChanged):
        * ksvg2/svg/SVGGradientElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix for bug 10356, positioning doesn't work with <svg> elements in XHTML...
hyatt [Mon, 15 Jan 2007 07:49:04 +0000 (07:49 +0000)]
    Fix for bug 10356, positioning doesn't work with <svg> elements in XHTML.  Change the requiresLayer
        check to use the DOM, since the old check would fail if the parent block had no element.

        Reviewed by Eric

        Added svg/custom/relative-positioning.html (absolute/fixed too)

        * rendering/RenderSVGContainer.cpp:
        (WebCore::RenderSVGContainer::requiresLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-01-14 Eric Seidel <eric@webkit.org>
eseidel [Mon, 15 Jan 2007 06:52:35 +0000 (06:52 +0000)]
2007-01-14  Eric Seidel  <eric@webkit.org>

        Reviewed by hyatt.

        SVG does not correctly handle float: left
        http://bugs.webkit.org/show_bug.cgi?id=12210

        Test: svg/custom/svg-float-border-padding.xml

        * rendering/RenderSVGContainer.cpp:
        (WebCore::RenderSVGContainer::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoAdd layout test for select line breaking.
hyatt [Mon, 15 Jan 2007 01:29:25 +0000 (01:29 +0000)]
Add layout test for select line breaking.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago More work to fix 10145, regression where form elements don't break properly...
hyatt [Mon, 15 Jan 2007 01:28:23 +0000 (01:28 +0000)]
    More work to fix 10145, regression where form elements don't break properly.  Make sure to really use
        the parent of the replaced element's whitespace value everywhere.

        Reviewed by olliej

        fast/replaced/three-selects-break.html

        * rendering/bidi.cpp:
        (WebCore::RenderBlock::findNextLineBreak):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin and then by Mitz.
weinig [Mon, 15 Jan 2007 01:08:44 +0000 (01:08 +0000)]
    Reviewed by Darin and then by Mitz.

        Patch for http://bugs.webkit.org/show_bug.cgi?id=12228
        Cleanup assorted CSS classes

        * css/CSSBorderImageValue.cpp:
        (WebCore::CSSBorderImageValue::CSSBorderImageValue):
        (WebCore::CSSBorderImageValue::cssText):
        * css/CSSBorderImageValue.h:
        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::valueForLength):
        (WebCore::valueForBorderStyle):
        (WebCore::valueForTextAlign):
        (WebCore::valueForShadow):
        (WebCore::getPositionOffsetValue):
        (WebCore::CSSComputedStyleDeclaration::cssText):
        (WebCore::primitiveValueFromLength):
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
        (WebCore::CSSComputedStyleDeclaration::getPropertyPriority):
        (WebCore::CSSComputedStyleDeclaration::removeProperty):
        (WebCore::CSSComputedStyleDeclaration::setProperty):
        (WebCore::CSSComputedStyleDeclaration::length):
        (WebCore::CSSComputedStyleDeclaration::item):
        * css/CSSComputedStyleDeclaration.h:
        * css/CSSCursorImageValue.cpp:
        (WebCore::CSSCursorImageValue::CSSCursorImageValue):
        * css/CSSCursorImageValue.h:
        * css/CSSGrammar.y:
        * css/CSSImageValue.cpp:
        * css/CSSImageValue.h:
        * css/CSSInheritedValue.cpp:
        * css/CSSInheritedValue.h:
        * css/CSSInitialValue.cpp:
        * css/CSSInitialValue.h:
        * css/CSSMutableStyleDeclaration.cpp:
        (WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
        (WebCore::CSSMutableStyleDeclaration::operator=):
        (WebCore::CSSMutableStyleDeclaration::getPropertyValue):
        (WebCore::CSSMutableStyleDeclaration::get4Values):
        (WebCore::CSSMutableStyleDeclaration::getShorthandValue):
        (WebCore::CSSMutableStyleDeclaration::getPropertyCSSValue):
        (WebCore::CSSMutableStyleDeclaration::removeProperty):
        (WebCore::CSSMutableStyleDeclaration::setChanged):
        (WebCore::CSSMutableStyleDeclaration::getPropertyPriority):
        (WebCore::CSSMutableStyleDeclaration::getPropertyShorthand):
        (WebCore::CSSMutableStyleDeclaration::isPropertyImplicit):
        (WebCore::CSSMutableStyleDeclaration::setProperty):
        (WebCore::CSSMutableStyleDeclaration::setImageProperty):
        (WebCore::CSSMutableStyleDeclaration::parseDeclaration):
        (WebCore::CSSMutableStyleDeclaration::addParsedProperties):
        (WebCore::CSSMutableStyleDeclaration::setLengthProperty):
        (WebCore::CSSMutableStyleDeclaration::cssText):
        (WebCore::CSSMutableStyleDeclaration::merge):
        (WebCore::CSSMutableStyleDeclaration::removePropertiesInSet):
        * css/CSSMutableStyleDeclaration.h:
        (WebCore::CSSMutableStyleDeclaration::setProperty):
        (WebCore::CSSMutableStyleDeclaration::removeProperty):
        * css/CSSNamespace.h:
        (WebCore::CSSNamespace::CSSNamespace):
        * css/CSSPrimitiveValue.cpp:
        (WebCore::isCSSTokenizerIdentifier):
        (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
        (WebCore::CSSPrimitiveValue::cleanup):
        (WebCore::CSSPrimitiveValue::computeLengthInt):
        (WebCore::CSSPrimitiveValue::computeLengthIntForLength):
        (WebCore::CSSPrimitiveValue::computeLengthShort):
        (WebCore::CSSPrimitiveValue::computeLengthFloat):
        (WebCore::CSSPrimitiveValue::setFloatValue):
        (WebCore::scaleFactorForConversion):
        (WebCore::CSSPrimitiveValue::getFloatValue):
        (WebCore::CSSPrimitiveValue::setStringValue):
        (WebCore::CSSPrimitiveValue::getStringValue):
        (WebCore::CSSPrimitiveValue::parseString):
        (WebCore::CSSPrimitiveValue::getIdent):
        (WebCore::CSSPrimitiveValue::cssText):
        * css/CSSPrimitiveValue.h:
        (WebCore::CSSPrimitiveValue::getCounterValue):
        (WebCore::CSSPrimitiveValue::getRectValue):
        (WebCore::CSSPrimitiveValue::getRGBColorValue):
        (WebCore::CSSPrimitiveValue::getPairValue):
        (WebCore::CSSPrimitiveValue::getDashboardRegionValue):
        * css/CSSProperty.cpp:
        (WebCore::operator==):
        * css/CSSProperty.h:
        (WebCore::CSSProperty::operator=):
        * css/CSSQuirkPrimitiveValue.h:
        (WebCore::CSSQuirkPrimitiveValue::CSSQuirkPrimitiveValue):
        * css/CSSRuleList.cpp:
        (WebCore::CSSRuleList::CSSRuleList):
        (WebCore::CSSRuleList::deleteRule):
        (WebCore::CSSRuleList::insertRule):
        * css/CSSRuleList.h:
        (WebCore::CSSRuleList::item):
        * css/CSSSelector.cpp:
        (WebCore::CSSSelector::print):
        (WebCore::CSSSelector::specificity):
        (WebCore::CSSSelector::extractPseudoType):
        (WebCore::CSSSelector::operator==):
        (WebCore::CSSSelector::selectorText):
        * css/CSSSelector.h:
        (WebCore::CSSSelector::CSSSelector):
        (WebCore::CSSSelector::~CSSSelector):
        (WebCore::CSSSelector::append):
        (WebCore::CSSSelector::next):
        (WebCore::CSSSelector::pseudoType):
        (WebCore::CSSSelector::hasTag):
        (WebCore::CSSSelector::hasAttribute):
        * css/CSSStyleDeclaration.cpp:
        (WebCore::propertyID):
        (WebCore::CSSStyleDeclaration::getPropertyPriority):
        (WebCore::CSSStyleDeclaration::getPropertyShorthand):
        (WebCore::CSSStyleDeclaration::isPropertyImplicit):
        (WebCore::CSSStyleDeclaration::setProperty):
        (WebCore::CSSStyleDeclaration::isPropertyName):
        (WebCore::CSSStyleDeclaration::parentRule):
        (WebCore::CSSStyleDeclaration::diff):
        (WebCore::CSSStyleDeclaration::copyPropertiesInSet):
        * css/CSSStyleDeclaration.h:
        * css/Counter.h:
        (WebCore::Counter::Counter):
        (WebCore::Counter::listStyleNumber):
        * css/csshelper.cpp:
        (WebCore::parseURL):
        * css/csshelper.h:
        * css/cssparser.h:
        (WebCore::domString):
        (WebCore::atomicString):
        (WebCore::CSSParser::operator|):
        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::matchRulesForList):
        (WebCore::CSSStyleSelector::checkSelector):
        (WebCore::CSSStyleSelector::checkOneSelector):
        (WebCore::CSSRuleSet::addRule):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-01-14 Mark Rowe <mrowe@apple.com>
bdash [Mon, 15 Jan 2007 00:53:11 +0000 (00:53 +0000)]
2007-01-14  Mark Rowe  <mrowe@apple.com>

        Reviewed by Adam.

        <rdar://problem/4908909> Need to create Leopard nightly build

        * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj: Always use the 10.4 Universal SDK.  The disk images don't mount pre-10.4 so we aren't losing anything here.
        * WebKitLauncher/WebKitNightlyEnabler.m:
        (poseAsWebKitApp): Simplify CoreFoundation-related hackery by using _CFGetProcessPath instead of walking the mach-o symbol tables.  The smaller timeframe where the
        CFProcessPath environment variable is set allows this to work correctly on Leopard where the old code failed.
        (enableWebKitNightlyBehaviour):
        * WebKitLauncher/main.m:
        (main): Pass executable path as WebKitAppPath rather than CFProcessPath to prevent it being picked up too early by CoreFoundation.
        * Drosera/launcher.m:
        (main): Ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
ddkilzer [Mon, 15 Jan 2007 00:39:47 +0000 (00:39 +0000)]
LayoutTests:

        Reviewed by Adam.  Patch by Mitz.

        - test for http://bugs.webkit.org/show_bug.cgi?id=12264
          REGRESSION (r18843): Webkit crashes on 43Folders.com home page

        * fast/tokenizer/ignore-tags-in-iframe-expected.txt: Added.
        * fast/tokenizer/ignore-tags-in-iframe.html: Added.

WebCore:

        Reviewed by Adam.  Patch by Mitz.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12264
          REGRESSION (r18843): Webkit crashes on 43Folders.com home page

        Test: fast/tokenizer/ignore-tags-in-iframe.html

        * html/HTMLParser.cpp:
        (WebCore::HTMLParser::reset): Removed unused inSelect member variable.
        (WebCore::HTMLParser::selectCreateErrorCheck): Ditto.
        (WebCore::HTMLParser::processCloseTag): Ditto.
        * html/HTMLParser.h: Ditto.
        * html/HTMLTokenizer.cpp:
        (WebCore::HTMLTokenizer::parseTag): Changed not to process <pre>, <listing>,
        <script>, <style>, <title>, <textarea> and <xmp> if the parser is in skip mode
        (waiting for a close tag of an element whose contents are not parsed,
        such as iframe).
        * html/HTMLTokenizer.h:
        (WebCore::HTMLTokenizer::State::setInStyle): Removed unused bit.
        (WebCore::HTMLTokenizer::State::): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebKit:
ddkilzer [Sun, 14 Jan 2007 21:45:40 +0000 (21:45 +0000)]
WebKit:

        Reviewed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12251
          REGRESSION (r18822-r18823): Assertion failure opening document with non-existent resources
          (dom/xhtml/level2/html/HTMLIFrameElement11.xhtml)

        * WebView/WebView.mm:
        (-[WebView _objectForIdentifier:]): Removed assertion.
        (-[WebView _removeObjectForIdentifier:]): Removed assertion.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Mitz.
ap [Sun, 14 Jan 2007 18:46:03 +0000 (18:46 +0000)]
    Reviewed by Mitz.

        * fast/multicol/float-multicol.html: Fixed an URL not to point to a
        remote resource (we already have a local copy).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
ap [Sun, 14 Jan 2007 18:08:59 +0000 (18:08 +0000)]
    Reviewed by Darin.

        http://bugs.webkit.org/show_bug.cgi?id=12258
        fast/tokenizer/002 test broken

WebCore:
        * loader/FrameLoader.h: Added a flush parameter to write().
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::write): Ditto.
        (WebCore::FrameLoader::endIfNotLoading): Instead of poorly duplicating the logic in write(),
        call it directly.

LayoutTests:
        * editing/selection/designmode-no-caret-expected.txt:
        * fast/dom/HTMLHeadElement/textInHead4-expected.txt:
        * fast/parser/broken-comments-vs-parsing-mode-expected.txt:
        * fast/parser/tabs-in-scripts-expected.txt:
        * fast/tokenizer/external-script-document-write-expected.txt:
        * fast/tokenizer/missing-title-end-tag-1-expected.txt:
        * tables/mozilla/images/adforce_imgis_com-expected.txt:
        * tables/mozilla_expected_failures/images/adforce_imgis_com-expected.txt:
        Updated the results (inconsequential changes only).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
aroben [Sun, 14 Jan 2007 10:04:21 +0000 (10:04 +0000)]
LayoutTests:

        Reviewed by Maciej.

        * editing/deleting/4845371.html: Removed bogus "Javascript" type.
        * editing/selection/4397952.html: Ditto.
        * fast/html/script-allowed-types-languages-expected.txt: Added.
        * fast/html/script-allowed-types-languages.html: Added. Tests
        type/language whitelisting.

WebCore:

        Reviewed by Maciej.

        Make sure our whitelisting of the type and language attributes of the
        <script> element is enforced in all HTMLTokenizer/HTMLScriptElement
        code paths.

        All layout tests pass.

        * html/HTMLScriptElement.cpp:
        (WebCore::HTMLScriptElement::shouldExecuteAsJavaScript): New method to
        determine whether the script should be executed, given its type and
        language attributes.
        (WebCore::HTMLScriptElement::evaluateScript): Check type/language
        before executing.
        * html/HTMLScriptElement.h: Added new declarations.
        * html/HTMLTokenizer.cpp:
        (WebCore::HTMLTokenizer::begin): Made scriptSrc a String.
        (WebCore::HTMLTokenizer::scriptHandler): Check
        shouldExecuteAsJavaScript before executing.
        (WebCore::HTMLTokenizer::notifyFinished): Ditto.
        (WebCore::HTMLTokenizer::parseTag): Moved type/language checking from
        here to HTMLScriptElement::shouldExecuteAsJavaScript.
        * html/HTMLTokenizer.h: Made scriptSrc a String, and removed the
        javascript member.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoAdd a second breaking test for replaced and text mixtures.
hyatt [Sun, 14 Jan 2007 09:48:24 +0000 (09:48 +0000)]
Add a second breaking test for replaced and text mixtures.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoAdd multicol float avoidance test.
hyatt [Sun, 14 Jan 2007 09:21:09 +0000 (09:21 +0000)]
Add multicol float avoidance test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Make sure floats are avoided if you have non-auto column property values...
hyatt [Sun, 14 Jan 2007 09:16:51 +0000 (09:16 +0000)]
    Make sure floats are avoided if you have non-auto column property values.  Fixes the crazy layout
        on http://weblogs.mozillazine.org/roc.

        Reviewed by mitz

        Added fast/multicol/float-avoidance.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::avoidsFloats):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoAdd layout test for replaced breaking.
hyatt [Sun, 14 Jan 2007 08:25:22 +0000 (08:25 +0000)]
Add layout test for replaced breaking.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix for 10145, regression where line breaks are not being honored between...
hyatt [Sun, 14 Jan 2007 08:22:08 +0000 (08:22 +0000)]
    Fix for 10145, regression where line breaks are not being honored between adjacent replaced elements.
        When checking for break opportunities where replaced elements are involved, we ignore their white-space
        values and use their parents' instead.  The assumption/idea behind this change is that because the element
        is replaced, its white-space value is irrelevant except as a means of applying style to its interior.

        The CSS spec does not cover this situation, so we're implementing this based off what other browsers seem to
        do.

        Reviewed by aroben

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
        * css/CSSValueKeywords.in:
        * css/cssparser.cpp:
        (WebCore::CSSParser::parseValue):
        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):
        * page/EventHandler.cpp:
        (WebCore::EventHandler::EventHandler):
        (WebCore::EventHandler::clear):
        (WebCore::EventHandler::handleWheelEvent):
        * page/EventHandler.h:
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::calcHeight):
        * rendering/RenderLayer.cpp:
        (WebCore::Marquee::Marquee):
        (WebCore::Marquee::start):
        (WebCore::Marquee::updateMarqueePosition):
        (WebCore::Marquee::updateMarqueeStyle):
        (WebCore::Marquee::timerFired):
        * rendering/RenderLayer.h:
        * rendering/RenderPartObject.cpp:
        (WebCore::RenderPartObject::viewCleared):
        * rendering/RenderStyle.h:
        (WebCore::):
        * rendering/bidi.cpp:
        (WebCore::RenderBlock::findNextLineBreak):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-01-14 Mark Rowe <mrowe@apple.com>
bdash [Sun, 14 Jan 2007 07:53:38 +0000 (07:53 +0000)]
2007-01-14  Mark Rowe  <mrowe@apple.com>

        Reviewed by Mitz.

        Minor fixes to JavaScript pretty-printing.

        * JavaScriptCore.exp:
        * kjs/Parser.cpp:
        (KJS::Parser::prettyPrint): Return line number and error message if parsing fails.
        * kjs/Parser.h:
        * kjs/nodes2string.cpp:
        (ElementNode::streamTo): Include comma delimiters in array literals.
        (PropertyNameNode::streamTo): Quote property names in object literals to handle the case when the property name is not a valid identifier.
        * kjs/testkjs.cpp:
        (doIt): Print any errors encountered while pretty-printing.

2007-01-14  Mark Rowe  <mrowe@apple.com>

        Reviewed by Mitz.

        Layout tests for fixes to JavaScript pretty-printing.

        * fast/js/pretty-print-expected.txt:
        * fast/js/resources/pretty-print.js: Test handling of object literal with non-identifier property name, and of array literals.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago While optimizing form controls and fixing their clipping, I caused this text...
hyatt [Sat, 13 Jan 2007 21:07:13 +0000 (21:07 +0000)]
    While optimizing form controls and fixing their clipping, I caused this text zoom regression.  The layout
        of text is necessary because it needs to recalc minmaxwidth.  This is still a really unfortunate
        bit of code... since a lot of properties don't apply to text (e.g., borders), we're marking text renderers
        as dirty when we don't have to.

        Reviewed by mitz

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::setStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Alexey
lars [Sat, 13 Jan 2007 20:01:37 +0000 (20:01 +0000)]
    Reviewed by Alexey

        String::format() was relying on undefined behaviour, which
        happened to work on lots of systems (Mac and 32bit Linux at least)
        but broke badly on 64bit Linux.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix for bug 11924: WebCore would crash on any HTML content
lars [Sat, 13 Jan 2007 18:48:29 +0000 (18:48 +0000)]
    Fix for bug 11924: WebCore would crash on any HTML content
        with a non-empty <table> tag in it on a 64-bit machine. The
        size_t (64bit) vs int (32bit) cast is now fixed in ensureRows,
        and the clients of this function have been updated to check
        for a false return code.

        Reviewed by Darin

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
ap [Sat, 13 Jan 2007 16:33:35 +0000 (16:33 +0000)]
    Reviewed by Darin.

        http://bugs.webkit.org/show_bug.cgi?id=12165
        REGRESSION: text encoding problem at jn.sapo.pt

        Test: fast/encoding/script-in-head.html

        * loader/TextResourceDecoder.cpp:
        (WebCore::TextResourceDecoder::checkForHeadCharset):
        Ignore tags within <script> elements in head, just like we do for <title>.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej
lars [Sat, 13 Jan 2007 11:21:23 +0000 (11:21 +0000)]
    Reviewed by Maciej

        Don't crash when constructing a GraphicsContext with a 0
        PlatformGraphicsContext and don't do anything if painting
        is disabled.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoMake the Qt port compile again.
lars [Sat, 13 Jan 2007 11:02:14 +0000 (11:02 +0000)]
Make the Qt port compile again.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-01-13 Eric Seidel <eric@eseidel.com>
eseidel [Sat, 13 Jan 2007 09:49:14 +0000 (09:49 +0000)]
2007-01-13  Eric Seidel  <eric@eseidel.com>

        Reviewed by hyatt.

        RichDraw demo does not live-update in Safari
        (SVG elements should ignore CSS position)
        http://bugs.webkit.org/show_bug.cgi?id=10364

        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::adjustRenderStyle): ignore position for everything but <svg>
        * ksvg2/svg/SVGStyledElement.cpp:
        (WebCore::SVGStyledElement::rebuildRenderer): move path generation into layout()
        * rendering/RenderContainer.cpp:
        (WebCore::RenderContainer::layout): ASSERT kids marked as having completed layout
        * rendering/RenderPath.cpp:
        (WebCore::RenderPath::layout): move path generation into layout()
        * rendering/RenderSVGContainer.cpp:
        (WebCore::RenderSVGContainer::layout): ASSERT kids marked as having completed layout

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix leak of column vector.
hyatt [Sat, 13 Jan 2007 08:16:36 +0000 (08:16 +0000)]
Fix leak of column vector.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoAdd layout test for column rules.
hyatt [Sat, 13 Jan 2007 07:11:13 +0000 (07:11 +0000)]
Add layout test for column rules.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Add support for column rules.
hyatt [Sat, 13 Jan 2007 07:08:01 +0000 (07:08 +0000)]
    Add support for column rules.

        Reviewed by bdash

        fast/multicol/column-rules.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::paintColumns):
        * rendering/RenderStyle.h:
        (WebCore::RenderStyle::columnRuleIsTransparent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Make multicolumn layout work with floats.
hyatt [Sat, 13 Jan 2007 05:32:41 +0000 (05:32 +0000)]
    Make multicolumn layout work with floats.

        Reviewed by andersca

        Added fast/multicol/float-multicol.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::layoutBlock):
        (WebCore::RenderBlock::paintColumns):
        (WebCore::RenderBlock::paintObject):
        * rendering/RenderBlock.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoNew fancy float multicol test (thanks Mozilla!)
hyatt [Sat, 13 Jan 2007 05:31:55 +0000 (05:31 +0000)]
New fancy float multicol test (thanks Mozilla!)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
ddkilzer [Sat, 13 Jan 2007 04:22:02 +0000 (04:22 +0000)]
LayoutTests:

        Reviewed by Maciej.

        - test for fast/css/line-height.html
          REGRESSION (r18816-r18818): Assertion failure in
          WebCore::Length::Length[in-charge](int, WebCore::LengthType, bool)

        * fast/css/line-height-expected.checksum: Added.
        * fast/css/line-height-expected.png: Added.
        * fast/css/line-height-expected.txt: Added.
        * fast/css/line-height.html: Added.

WebCore:

        Reviewed by Maciej.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12239
          REGRESSION (r18816-r18818): Assertion failure in
          WebCore::Length::Length[in-charge](int, WebCore::LengthType, bool)

        Test: fast/css/line-height.html

        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::createInnerTextStyle): Use a float to create a percent Length.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18824 268f45cc-cd09-0410-ab3c-d52691b4dbfc