WebKit-https.git
12 years agoFixing bug number for last ChangeLog entry; thanks to Ariya for
kov@webkit.org [Tue, 3 Mar 2009 17:31:07 +0000 (17:31 +0000)]
Fixing bug number for last ChangeLog entry; thanks to Ariya for
catching this problem.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-03 Onne Gorter <onne.gorter@avinity.net>
kov@webkit.org [Tue, 3 Mar 2009 17:26:57 +0000 (17:26 +0000)]
2009-03-03  Onne Gorter  <onne.gorter@avinity.net>

        Reviewed by Anders Carlsson.

        https://bugs.webkit.org/show_bug.cgi?id=27385
        resizing plugins does not work, because the plugin never gets informed

        Make gtk plugins resize correctly, by sending them the setwindow event
        correctly. Also ensure that all plugin eventing is done with correct
        locking/calling. Mostly copied from mac implementation.

        manual test: manual-tests/gtk/plugin-resize-scroll.html

        * plugins/PluginView.h:
        * plugins/gtk/PluginViewGtk.cpp:
        (WebCore::PluginView::dispatchNPEvent):
        ensure locking/calling for NPEvents
        (WebCore::PluginView::updatePluginWidget):
        if something changed, let setNPWindowIfNeeded handle it
        (WebCore::PluginView::paint):
        (WebCore::PluginView::handleKeyboardEvent):
        (WebCore::PluginView::handleMouseEvent):
        ensure calling conventions
        (WebCore::PluginView::setNPWindowRect):
        just pass control to setNPWindowIfNeeded
        (WebCore::PluginView::setNPWindowIfNeeded):
        event the plugin correctly of new window
        (WebCore::PluginView::init):
        init through the new setup

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Adam Roben.
ap@webkit.org [Tue, 3 Mar 2009 16:45:54 +0000 (16:45 +0000)]
    Reviewed by Adam Roben.

        https://bugs.webkit.org/show_bug.cgi?id=4343
        XMLHttpRequest doesn't work in a JavaScript-created window

        The problem was fixed a while ago (r34506), just adding a test.

        * http/tests/xmlhttprequest/request-from-popup-expected.txt: Added.
        * http/tests/xmlhttprequest/request-from-popup.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdding bug URL and title to ChangeLog for a recent check-in.
ap@webkit.org [Tue, 3 Mar 2009 16:44:39 +0000 (16:44 +0000)]
Adding bug URL and title to ChangeLog for a recent check-in.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-03 Mike Belshe <mike@belshe.com>
darin@chromium.org [Tue, 3 Mar 2009 16:06:15 +0000 (16:06 +0000)]
2009-03-03  Mike Belshe  <mike@belshe.com>

        Reviewed by Darin Fisher.

        * dom/Document.idl:
        * html/HTMLCanvasElement.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-02 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 3 Mar 2009 06:15:51 +0000 (06:15 +0000)]
2009-03-02  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Adele Peterson

        https://bugs.webkit.org/show_bug.cgi?id=24313

        If RenderTextControlSingleLine::nodeAtPoint() pokes a node into the
        HitTestResult, then it had better well return |true|. And m_innerBlock
        could never have been set as the hit node by the superclass, because
        the superclass knows nothing about m_innerBlock.

        Test: fast/forms/input-hit-test-border.html

        * rendering/RenderTextControlSingleLine.cpp:
        (WebCore::RenderTextControlSingleLine::nodeAtPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJavaScriptCore:
weinig@apple.com [Tue, 3 Mar 2009 02:24:55 +0000 (02:24 +0000)]
JavaScriptCore:

2009-03-02  Sam Weinig  <sam@webkit.org>

        Reviewed by Mark Rowe.

        Enable Geolocation (except on Tiger and Leopard).

        * Configurations/JavaScriptCore.xcconfig:

WebCore:

2009-03-02  Sam Weinig  <sam@webkit.org>

        Reviewed by Mark Rowe.

        Enable Geolocation (except on Tiger and Leopard).

        * Configurations/WebCore.xcconfig:

WebKit/mac:

2009-03-02  Sam Weinig  <sam@webkit.org>

        Reviewed by Mark Rowe.

        Enable Geolocation (except on Tiger and Leopard).

        * Configurations/WebKit.xcconfig:

WebKitTools:

2009-03-02  Sam Weinig  <sam@webkit.org>

        Reviewed by Mark Rowe.

        Enable Geolocation (except on Tiger and Leopard).

        * Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-02 Ojan Vafai <ojan@chromium.org>
eric@webkit.org [Tue, 3 Mar 2009 02:12:49 +0000 (02:12 +0000)]
2009-03-02  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adele Peterson.

        Fix https://bugs.webkit.org/show_bug.cgi?id=24307
        Null out m_highlightedNode on hideHighlight().
        Ran WebCore/manual-tests/inspector/highlight-nodes.html.

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::hideHighlight):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-02 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 3 Mar 2009 01:51:51 +0000 (01:51 +0000)]
2009-03-02  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        WebKit part of <rdar://problem/6638658>.

        * Plugins/Hosted/NetscapePluginHostManager.h:
        * Plugins/Hosted/NetscapePluginHostManager.mm:
        (WebKit::NetscapePluginHostManager::createPropertyListFile):
        Spawn the plug-in host and wait for it to create the property list.

        * Plugins/WebBasePluginPackage.mm:
        (-[WebBasePluginPackage createPropertyListFile]):
        Factor code out into a new method.

        (-[WebBasePluginPackage pListForPath:createFile:]):
        Call the newly added createPropertyListFile method.

        * Plugins/WebNetscapePluginPackage.mm:
        (-[WebNetscapePluginPackage createPropertyListFile]):
        Tell the plug-in host manager to create a property list file for us.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
weinig@apple.com [Tue, 3 Mar 2009 01:47:14 +0000 (01:47 +0000)]
WebCore:

2009-03-02  Sam Weinig  <sam@webkit.org>

        Reviewed by Geoffrey Garen.

        Fix for <rdar://problem/6507404> Add Geolocation support.

        This is not yet turned on for any Mac platform.

        * WebCore.xcodeproj/project.pbxproj:
        * page/Chrome.cpp:
        (WebCore::Chrome::shouldAllowGeolocationForFrame):
        * page/Chrome.h:
        * page/ChromeClient.h:
        (WebCore::ChromeClient::shouldAllowGeolocationForFrame):
        * page/Geolocation.cpp:
        (WebCore::Geolocation::Geolocation):
        (WebCore::Geolocation::disconnectFrame): Remove call to setUsingGeolocation as the document
        will not be alive at this point.
        (WebCore::Geolocation::getCurrentPosition): Check if the embedding app allows geolocation and
        return a PERMISSION_DENIED if not.
        (WebCore::Geolocation::watchPosition): Ditto.
        (WebCore::Geolocation::shouldAllowGeolocation): Perform request to embedding layer of whether
        to allow geolocation and cache the result.
        * page/Geolocation.h:
        (WebCore::Geolocation::):
        * platform/GeolocationService.cpp:
        * platform/GeolocationService.h:
        (WebCore::GeolocationService::~GeolocationService):
        (WebCore::GeolocationService::stopUpdating):
        * platform/mac/GeolocationServiceMac.h: Added.
        (WebCore::GeolocationServiceMac::lastPosition):
        (WebCore::GeolocationServiceMac::lastError):
        * platform/mac/GeolocationServiceMac.mm: Added.
        (WebCore::GeolocationService::create):
        (WebCore::GeolocationServiceMac::GeolocationServiceMac):
        (WebCore::GeolocationServiceMac::~GeolocationServiceMac):
        (WebCore::GeolocationServiceMac::startUpdating):
        (WebCore::GeolocationServiceMac::stopUpdating):
        (WebCore::GeolocationServiceMac::suspend):
        (WebCore::GeolocationServiceMac::resume):
        (WebCore::GeolocationServiceMac::positionChanged):
        (WebCore::GeolocationServiceMac::errorOccurred):
        (-[WebCoreCoreLocationObserver initWithCallback:]):
        (-[WebCoreCoreLocationObserver locationManager:didUpdateToLocation:fromLocation:]):
        (-[WebCoreCoreLocationObserver locationManager:didFailWithError:]):

WebKit/mac:

2009-03-02  Sam Weinig  <sam@webkit.org>

        Reviewed by Geoffrey Garen.

        Fix for <rdar://problem/6507404> Add Geolocation support.

        This is not yet turned on for any Mac platform.

        Add SPI to ask the embedding application whether to allow
        Geolocation for an origin.

        * WebCoreSupport/WebChromeClient.h:
        * WebCoreSupport/WebChromeClient.mm:
        (WebChromeClient::shouldAllowGeolocationForFrame):
        * WebView/WebUIDelegatePrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-02 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 3 Mar 2009 01:36:51 +0000 (01:36 +0000)]
2009-03-02  Anders Carlsson  <andersca@apple.com>

        Fix PowerPC build.

        * Plugins/WebNetscapePluginPackage.mm:
        (-[WebNetscapePluginPackage _tryLoad]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix tyop
andersca@apple.com [Tue, 3 Mar 2009 00:20:08 +0000 (00:20 +0000)]
Fix tyop

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-02 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 3 Mar 2009 00:14:45 +0000 (00:14 +0000)]
2009-03-02  Anders Carlsson  <andersca@apple.com>

        Reviewed by John Sullivan, Ada Chan.

        Factor loading code out into its own method and get rid of a bunch of goots.

        * Plugins/WebNetscapePluginPackage.mm:
        (-[WebNetscapePluginPackage _tryLoad]):
        (-[WebNetscapePluginPackage load]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-02 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 3 Mar 2009 00:00:46 +0000 (00:00 +0000)]
2009-03-02  Anders Carlsson  <andersca@apple.com>

        Build fix.

        * Plugins/WebNetscapeDeprecatedFunctions.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-02 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 2 Mar 2009 23:58:35 +0000 (23:58 +0000)]
2009-03-02  Anders Carlsson  <andersca@apple.com>

        WebNetscapePluginPackage.mm is an Objective-C++ file.

        * WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebKit:
andersca@apple.com [Mon, 2 Mar 2009 23:53:50 +0000 (23:53 +0000)]
WebKit:

2009-03-02  Anders Carlsson  <andersca@apple.com>

        Reviewed by John Sullivan.

        Rename WebNetscapePluginPackage.m to WebNetscapePluginPackage.mm

        * WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

2009-03-02  Anders Carlsson  <andersca@apple.com>

        Reviewed by John Sullivan.

        Rename WebNetscapePluginPackage.m to WebNetscapePluginPackage.mm

        * Plugins/WebNetscapePluginPackage.m: Removed.
        * Plugins/WebNetscapePluginPackage.mm: Copied from mac/Plugins/WebNetscapePluginPackage.m.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBuild fixes for wxWidgets Mac trunk build.
kevino@webkit.org [Mon, 2 Mar 2009 23:29:23 +0000 (23:29 +0000)]
Build fixes for wxWidgets Mac trunk build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agowxGTK missing header build fix.
kevino@webkit.org [Mon, 2 Mar 2009 23:25:33 +0000 (23:25 +0000)]
wxGTK missing header build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Adam Roben.
mitz@apple.com [Mon, 2 Mar 2009 21:55:51 +0000 (21:55 +0000)]
    Reviewed by Adam Roben.

        - fix https://bugs.webkit.org/show_bug.cgi?id=21811
          REGRESSION: Windows Build Not Selecting Proper Font

        * platform/graphics/win/FontCacheWin.cpp:
        (WebCore::createGDIFont): Added back code to verify that the created
        HFONT has the requested face name.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fixes a regression caused by splitting the input and output of console commands.
timothy@apple.com [Mon, 2 Mar 2009 21:38:39 +0000 (21:38 +0000)]
    Fixes a regression caused by splitting the input and output of console commands.

        https://bugs.webkit.org/show_bug.cgi?id=24293

        Reviewed by Kevin McCullough.

        * inspector/front-end/Console.js:
        (WebInspector.Console.prototype.addMessage): Don't treat ConsoleCommandResult as a
        normal ConsoleMessage when appending. This prevents resetting repeatCounts incorrectly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Make exception messages and logged Error objects display consistently.
timothy@apple.com [Mon, 2 Mar 2009 21:38:25 +0000 (21:38 +0000)]
    Make exception messages and logged Error objects display consistently.

        https://bugs.webkit.org/show_bug.cgi?id=18983

        Reviewed by Adam Roben.

        * English.lproj/localizedStrings.js: Remove a string for line numbers.
        * inspector/front-end/Console.js:
        (WebInspector.Console.prototype._enterKeyPressed): Pass the exception
        boolean to the ConsoleCommandResult constructor and don't pass level.
        (WebInspector.Console.prototype._formatnode): Fix a className typo.
        (WebInspector.Console.prototype._formaterror): Add an error-message
        classed span around the message to show in red and remove the
        console-message-url class from the link so it doesn't float right.
        Instead enclose the link in parentheses and use displayNameForURL
        to shorten the URL in the link.
        (WebInspector.ConsoleMessage.prototype.toMessageElement): Simplify
        how line numbers are shown since link underlining a string with
        parentheses looks bad.
        (WebInspector.ConsoleCommandResult): Take an exception boolean flag
        instead of a level and get line and URL based on that flag.
        * inspector/front-end/inspector.css: Tweaks to the styles.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Allow for multiline quoted text in JavaScript files when looking for function...
timothy@apple.com [Mon, 2 Mar 2009 21:38:11 +0000 (21:38 +0000)]
    Allow for multiline quoted text in JavaScript files when looking for function names.

        https://bugs.webkit.org/show_bug.cgi?id=24296

        Reviewed by David Kilzer.

        * Scripts/prepare-ChangeLog:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-02 Ojan Vafai <ojan@chromium.org>
levin@chromium.org [Mon, 2 Mar 2009 19:16:01 +0000 (19:16 +0000)]
2009-03-02  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adele Peterson.

        Bug 24048: extra windows button padding doesn't apply when there's no appearance
        <https://bugs.webkit.org/show_bug.cgi?id=24048>

        Replace adjustButtonInnerStyle with buttonInternalPaddingLeft/Right/Top/Bottom.

        No tests added as existing tests already cover this behavior.

        * rendering/RenderButton.cpp:
        (WebCore::RenderButton::setupInnerStyle):
        * rendering/RenderTheme.cpp:
        * rendering/RenderTheme.h:
        (WebCore::RenderTheme::buttonInternalPaddingLeft):
        (WebCore::RenderTheme::buttonInternalPaddingRight):
        (WebCore::RenderTheme::buttonInternalPaddingTop):
        * rendering/RenderThemeChromiumGtk.cpp:
        (WebCore::RenderThemeWin::buttonInternalPaddingLeft):
        (WebCore::RenderThemeWin::buttonInternalPaddingRight):
        (WebCore::RenderThemeWin::buttonInternalPaddingTop):
        (WebCore::RenderThemeWin::buttonInternalPaddingBottom):
        * rendering/RenderThemeChromiumGtk.h:
        * rendering/RenderThemeChromiumWin.cpp:
        (WebCore::RenderThemeChromiumWin::buttonInternalPaddingLeft):
        (WebCore::RenderThemeChromiumWin::buttonInternalPaddingRight):
        (WebCore::RenderThemeChromiumWin::buttonInternalPaddingTop):
        (WebCore::RenderThemeChromiumWin::buttonInternalPaddingBottom):
        * rendering/RenderThemeChromiumWin.h:
        * rendering/RenderThemeWin.cpp:
        (WebCore::RenderThemeWin::buttonInternalPaddingLeft):
        (WebCore::RenderThemeWin::buttonInternalPaddingRight):
        (WebCore::RenderThemeWin::buttonInternalPaddingTop):
        (WebCore::RenderThemeWin::buttonInternalPaddingBottom):
        * rendering/RenderThemeWin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-02 Adam Treat <adam.treat@torchmobile.com>
treat@webkit.org [Mon, 2 Mar 2009 18:26:55 +0000 (18:26 +0000)]
2009-03-02  Adam Treat  <adam.treat@torchmobile.com>

        Reviewed by Eric Seidel.

        Add three new drt helper functions that enable all of the tests in
        LayoutTests/animation/* and LayoutTests/transitions/* to now pass.

        * Api/qwebframe.cpp:
        (qt_drt_pauseAnimation):
        (qt_drt_pauseTransitionOfProperty):
        (qt_drt_numberOfActiveAnimations):

        * DumpRenderTree/qt/jsobjects.cpp:
        (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
        (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
        (LayoutTestController::numberOfActiveAnimations):
        * DumpRenderTree/qt/jsobjects.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-02 Benjamin C Meyer <benjamin.meyer@torchmobile.com>
treat@webkit.org [Mon, 2 Mar 2009 16:55:35 +0000 (16:55 +0000)]
2009-03-02  Benjamin C Meyer  <benjamin.meyer@torchmobile.com>

        Reviewed by George Staikos.

        https://bugs.webkit.org/show_bug.cgi?id=21230
        On X11 match the behavior of Firefox and also copy the url to the
        clipboard selection when the action Copy Link Location is executed.

        * Api/qwebpage.cpp:
        (QWebPage::triggerAction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-02 Adam Treat <adam.treat@torchmobile.com>
treat@webkit.org [Mon, 2 Mar 2009 16:30:57 +0000 (16:30 +0000)]
2009-03-02  Adam Treat  <adam.treat@torchmobile.com>

        Build fix for Qt port.  Remove unnecessary assert.

        * platform/graphics/qt/ImageBufferQt.cpp:
        (WebCore::ImageBuffer::putImageData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-02 Adam Treat <adam.treat@torchmobile.com>
treat@webkit.org [Mon, 2 Mar 2009 15:37:02 +0000 (15:37 +0000)]
2009-03-02  Adam Treat  <adam.treat@torchmobile.com>

        Reviewed by Adam Roben and previously by Eric Seidel and Simon Fraser.

        https://bugs.webkit.org/show_bug.cgi?id=24227
        Ensure that the checkForSolidColor() optimization is correctly triggered
        for all cases of drawPattern.  Currently, the optimization was not triggered
        when the check had not been previously performed via a request for the
        image's NativeImagePtr.

        Implement the Qt version of the checkForSolidColor() method.  Combined with
        the bug fix this reduces the time it takes to draw a repeating background
        of a 1x1 image from ~50msecs to ~0msecs on my machine.

        * platform/graphics/BitmapImage.cpp:
        (WebCore::BitmapImage::BitmapImage):
        * platform/graphics/BitmapImage.h:
        (WebCore::BitmapImage::mayFillWithSolidColor):
        * platform/graphics/Image.h:
        (WebCore::Image::mayFillWithSolidColor):
        * platform/graphics/cairo/ImageCairo.cpp:
        (WebCore::BitmapImage::BitmapImage):
        (WebCore::BitmapImage::checkForSolidColor):
        * platform/graphics/cg/ImageCG.cpp:
        (WebCore::BitmapImage::BitmapImage):
        (WebCore::BitmapImage::checkForSolidColor):
        * platform/graphics/qt/ImageQt.cpp:
        (WebCore::BitmapImage::checkForSolidColor):
        * platform/graphics/skia/ImageSkia.cpp:
        (WebCore::BitmapImage::checkForSolidColor):
        * platform/graphics/wx/ImageWx.cpp:
        (WebCore::BitmapImage::checkForSolidColor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-02 Gustavo Noronha Silva <gns@gnome.org>
kov@webkit.org [Mon, 2 Mar 2009 14:56:41 +0000 (14:56 +0000)]
2009-03-02  Gustavo Noronha Silva  <gns@gnome.org>

        Unreviewed build fix; adding missing files to EXTRA_DIST, so that
        they show up in the tarball.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-02 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Mon, 2 Mar 2009 14:38:19 +0000 (14:38 +0000)]
2009-03-02  Dirk Schulze  <krit@webkit.org>

        Just a correction of the ChangeLog. Removed Ariya Hidayat
        from the reviewing process.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-02 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Mon, 2 Mar 2009 14:22:08 +0000 (14:22 +0000)]
2009-03-02  Dirk Schulze  <krit@webkit.org>

        Reviewed by Holger Freyther, rubber-stamped by Ariya Hidayat.

        Added putImageData to Qt.

        [Qt] lacks putImageData support in Canvas
        https://bugs.webkit.org/show_bug.cgi?id=22186

        * platform/graphics/qt/ImageBufferQt.cpp:
        (WebCore::ImageBuffer::putImageData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Windows build fix after r41349
aroben@apple.com [Mon, 2 Mar 2009 13:26:59 +0000 (13:26 +0000)]
    Windows build fix after r41349

        * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
        (AccessibilityUIElement::getChildrenWithRange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Show exception messages again when evaluating bad expressions in the
timothy@apple.com [Mon, 2 Mar 2009 08:22:27 +0000 (08:22 +0000)]
    Show exception messages again when evaluating bad expressions in the
        Web Inspector's console.

        https://bugs.webkit.org/show_bug.cgi?id=19890

        Reviewed by Oliver Hunt.

        * bindings/js/JSQuarantinedObjectWrapper.cpp:
        (WebCore::JSQuarantinedObjectWrapper::transferExceptionToExecState):
        Fix the order in which the exception is set and cleared now that the
        exception is stored in the shared GlobalData, not per ExecState.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Make input in the Web Inspector console print before any output
timothy@apple.com [Mon, 2 Mar 2009 08:22:13 +0000 (08:22 +0000)]
    Make input in the Web Inspector console print before any output
        that might be added by the called function.

        https://bugs.webkit.org/show_bug.cgi?id=19931

        Reviewed by Oliver Hunt.

        * inspector/front-end/Console.js:
        (WebInspector.Console.prototype._enterKeyPressed): Add the command
        message before evaluating the result. Associate the originating
        command to the result, so if they are adjacent there is no divider.
        (WebInspector.ConsoleCommand): No longer take a result.
        (WebInspector.ConsoleCommand.prototype.toMessageElement): Result
        code removed since it isn't used now.
        (WebInspector.ConsoleCommandResult): Subclass ConsoleMessage.
        (WebInspector.ConsoleCommandResult.prototype.toMessageElement):
        Call the ConsoleMessage toMessageElement and add a style class.
        * inspector/front-end/inspector.css: Add a new style class for
        adjacent results to hide the divider. Also tweak the position of
        the disclosure triangle for objects to not use the left margin.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix the Mac build.
timothy@apple.com [Mon, 2 Mar 2009 05:46:04 +0000 (05:46 +0000)]
Fix the Mac build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago <rdar://problem/6635688> Move HAVE_DTRACE check to Base.xcconfig
ddkilzer@apple.com [Mon, 2 Mar 2009 04:18:55 +0000 (04:18 +0000)]
    <rdar://problem/6635688> Move HAVE_DTRACE check to Base.xcconfig

        Reviewed by Mark Rowe.

        * Configurations/Base.xcconfig: Set HAVE_DTRACE Xcode variable
        based on PLATFORM_NAME and MAC_OS_X_VERSION_MAJOR.  Also define
        it as a preprocessor macro by modifying
        GCC_PREPROCESSOR_DEFINITIONS.
        * JavaScriptCore.xcodeproj/project.pbxproj: Changed "Generate
        DTrace header" script phase to check for HAVE_DTRACE instead of
        MACOSX_DEPLOYMENT_TARGET.
        * wtf/Platform.h: Removed definition of HAVE_DTRACE macro since
        it's defined in Base.xcconfig now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBug 24282: AX Palindrome error when asking for a specific index of the AXChildren...
cfleizach@apple.com [Mon, 2 Mar 2009 02:55:08 +0000 (02:55 +0000)]
Bug 24282: AX Palindrome error when asking for a specific index of the AXChildren array
<https://bugs.webkit.org/show_bug.cgi?id=24282>

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-01 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 2 Mar 2009 00:45:40 +0000 (00:45 +0000)]
2009-03-01  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        WebKit side of <rdar://problem/6449689>

        Pass the visible name to the plug-in host.

        * Plugins/Hosted/NetscapePluginHostManager.mm:
        (WebKit::NetscapePluginHostManager::spawnPluginHost):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-01 Ojan Vafai <ojan@chromium.org>
levin@chromium.org [Mon, 2 Mar 2009 00:41:53 +0000 (00:41 +0000)]
2009-03-01  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Eric Seidel.

        Bug 24251: Cleanup: replace positionForCoordinates with positionForPoint
        <https://bugs.webkit.org/show_bug.cgi?id=24251>

        Make RenderObject::positionForCoordinate non-virtual and
        RenderObject::positionForPoint virtual in preparation for
        removing positionFor* from RenderObject/RenderText.

        * page/Frame.cpp:
        (WebCore::Frame::visiblePositionForPoint):
        * rendering/RenderBR.cpp:
        (WebCore::RenderBR::positionForPoint):
        * rendering/RenderBR.h:
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::positionForPoint):
        * rendering/RenderBlock.h:
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::positionForPoint):
        * rendering/RenderBox.h:
        * rendering/RenderInline.cpp:
        (WebCore::RenderInline::positionForPoint):
        * rendering/RenderInline.h:
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::positionForCoordinates):
        (WebCore::RenderObject::positionForPoint):
        * rendering/RenderObject.h:
        * rendering/RenderReplaced.cpp:
        (WebCore::RenderReplaced::positionForPoint):
        * rendering/RenderReplaced.h:
        * rendering/RenderSVGInlineText.cpp:
        (WebCore::RenderSVGInlineText::positionForPoint):
        * rendering/RenderSVGInlineText.h:
        * rendering/RenderText.cpp:
        (WebCore::RenderText::positionForPoint):
        * rendering/RenderText.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-01 Larry Ewing <lewing@novell.com>
levin@chromium.org [Mon, 2 Mar 2009 00:41:37 +0000 (00:41 +0000)]
2009-03-01  Larry Ewing  <lewing@novell.com>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=24080
        NPN_GetValue casting to the wrong type and writing outside bounds

        Make sure to cast the value to the correct type so that only
        memory owned by the value is written to.

        * plugins/gtk/PluginViewGtk.cpp (PluginView::getValueStatic):
        * plugins/qt/PluginViewQt.cpp (PluginView::getValueStatic):
        * plugins/mac/PluginViewMac.cpp (PluginView::getValueStatic):
        (PluginView::getValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-01 Jeremy Moskovich <jeremy@chromium.org>
levin@chromium.org [Mon, 2 Mar 2009 00:41:23 +0000 (00:41 +0000)]
2009-03-01  Jeremy Moskovich  <jeremy@chromium.org>

        Reviewed by Simon Fraser.

        https://bugs.webkit.org/show_bug.cgi?id=24197 and
        https://bugs.webkit.org/show_bug.cgi?id=23512

        The Windows version of cgColor() is conditionally compiled using
        !PLATFORM(MAC) change this to PLATFORM(WIN_OS) so that Chrome
        can use the OS X version instead of the Windows version.

        Also rename cgColor() -> createCGColor()

        No observable change in behavior, so no test.

        * platform/graphics/Color.h:
        * platform/graphics/cg/ColorCG.cpp:
        (WebCore::createCGColor):
        * platform/graphics/cg/GraphicsContextCG.cpp:
        (WebCore::GraphicsContext::setPlatformShadow):
        * platform/graphics/mac/ColorMac.mm:
        (WebCore::createCGColor):
        * platform/graphics/mac/GraphicsContextMac.mm:
        (WebCore::GraphicsContext::drawFocusRing):
        * platform/graphics/mac/GraphicsLayerCA.mm:
        (WebCore::setLayerBorderColor):
        (WebCore::setLayerBackgroundColor):
        (WebCore::GraphicsLayerCA::setBackgroundColor):
        * platform/graphics/win/GraphicsContextCGWin.cpp:
        (WebCore::GraphicsContext::drawFocusRing):
        * svg/graphics/filters/cg/SVGFEHelpersCg.mm:
        (WebCore::ciColor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
levin@chromium.org [Sun, 1 Mar 2009 21:09:29 +0000 (21:09 +0000)]
WebCore:

2009-03-01  David Levin  <levin@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Bug 24271: XMLHttpRequest needs js bindings for Workers.
        <https://bugs.webkit.org/show_bug.cgi?id=24271>

        Tests: http/tests/xmlhttprequest/workers/methods-async.html
               http/tests/xmlhttprequest/workers/methods.html

        * bindings/js/JSWorkerContextBase.cpp:
        (WebCore::JSWorkerContextBase::getOwnPropertySlot):
        (jsWorkerContextBaseXMLHttpRequest):
        (setJSWorkerContextBaseXMLHttpRequest):
        Expose XMLHttpRequest to Workers.

        * bindings/js/JSWorkerContextBase.h:

        * bindings/js/JSXMLHttpRequestConstructor.cpp:
        (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor):
        (WebCore::constructXMLHttpRequest):
        (WebCore::JSXMLHttpRequestConstructor::mark):
        Removed the dependencies on Document.

        * bindings/js/JSXMLHttpRequestConstructor.h:
        (WebCore::JSXMLHttpRequestConstructor::scriptExecutionContext):
        * dom/EventException.idl:
        * dom/EventListener.idl:
        Chnage to have the NoStaticTables attribute since they are used from XHR.

        * loader/WorkerThreadableLoader.cpp:
        (WebCore::workerContextDidFinishLoading):
        (WebCore::WorkerThreadableLoader::MainThreadBridge::didFinishLoading):
        Fixed identifier to be unsigned long.

        * loader/WorkerThreadableLoader.h:
        * workers/WorkerThread.cpp:
        (WebCore::WorkerThread::workerThread):
        Stop active objects when the thread is getting shutdown so that xhr gets properly shutdown.

        * xml/XMLHttpRequestUpload.cpp:

        * xml/XMLHttpRequest.idl:
        * xml/XMLHttpRequestException.idl:
        * xml/XMLHttpRequestProgressEvent.idl:
        * xml/XMLHttpRequestUpload.idl:
        Chnage to have the NoStaticTables attribute since they are used from XHR.

LayoutTests:

2009-03-01  David Levin  <levin@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Bug 24271: XMLHttpRequest needs js bindings for Workers.
        <https://bugs.webkit.org/show_bug.cgi?id=24271>

        Some sanity checks for xhr done from workers. These are the same as
        tests done for normal workers.

        * http/tests/xmlhttprequest/workers/methods-async-expected.txt: Added.
        * http/tests/xmlhttprequest/workers/methods-async.html: Added.
        * http/tests/xmlhttprequest/workers/methods-expected.txt: Added.
        * http/tests/xmlhttprequest/workers/methods.html: Added.
        * http/tests/xmlhttprequest/workers/resources/methods-async.js: Added.
        (onmessage):
        (log):
        (done):
        (onReqAbort):
        (onSyncReqError):
        (start):
        (processStateChange):
        * http/tests/xmlhttprequest/workers/resources/methods.cgi: Copied from LayoutTests/http/tests/xmlhttprequest/methods.cgi.
        * http/tests/xmlhttprequest/workers/resources/methods.js: Added.
        (log):
        (done):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBuild fix. Add isBlock() back since there was a new client since the patch was made.
timothy@apple.com [Sun, 1 Mar 2009 20:14:44 +0000 (20:14 +0000)]
Build fix. Add isBlock() back since there was a new client since the patch was made.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJavaScriptCore:
timothy@apple.com [Sun, 1 Mar 2009 19:35:47 +0000 (19:35 +0000)]
JavaScriptCore:

2009-03-01  Horia Olaru  <olaru@adobe.com>

        By looking in grammar.y there are only a few types of statement nodes
        on which the debugger should stop.

        Removed isBlock and isLoop virtual calls. No need to emit debug hooks in
        the "statementListEmitCode" method as long as the necessary hooks can be
        added in each "emitCode".

        https://bugs.webkit.org/show_bug.cgi?id=21073

        Reviewed by Kevin McCullough.

        * parser/Nodes.cpp:
        (JSC::ConstStatementNode::emitBytecode):
        (JSC::statementListEmitCode):
        (JSC::EmptyStatementNode::emitBytecode):
        (JSC::ExprStatementNode::emitBytecode):
        (JSC::VarStatementNode::emitBytecode):
        (JSC::IfNode::emitBytecode):
        (JSC::IfElseNode::emitBytecode):
        (JSC::DoWhileNode::emitBytecode):
        (JSC::WhileNode::emitBytecode):
        (JSC::ForNode::emitBytecode):
        (JSC::ForInNode::emitBytecode):
        (JSC::ContinueNode::emitBytecode):
        (JSC::BreakNode::emitBytecode):
        (JSC::ReturnNode::emitBytecode):
        (JSC::WithNode::emitBytecode):
        (JSC::SwitchNode::emitBytecode):
        (JSC::LabelNode::emitBytecode):
        (JSC::ThrowNode::emitBytecode):
        (JSC::TryNode::emitBytecode):
        * parser/Nodes.h:

WebCore:

2009-03-01  Horia Olaru  <olaru@adobe.com>

        Adding manual debugger test cases for bug.

        https://bugs.webkit.org/show_bug.cgi?id=21073

        Reviewed by Kevin McCullough.

        * manual-tests/inspector/debugger-step-on-do-while-statements.html: Added.
        * manual-tests/inspector/debugger-step-on-for-in-statements.html: Added.
        * manual-tests/inspector/debugger-step-on-for-statements.html: Added.
        * manual-tests/inspector/debugger-step-on-while-statements.html: Added.
        * manual-tests/inspector/resources/loop-statements.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-01 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Sun, 1 Mar 2009 19:22:13 +0000 (19:22 +0000)]
2009-03-01  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Holger Freyther.

         [Gtk] get the HTTP layout tests going
         https://bugs.webkit.org/show_bug.cgi?id=24259

        Added API to get the response mime type from a frame. We need this
        so we can decide if we need to dump the frame as text or its
        render tree

        * webkit/webkitprivate.h:
        * webkit/webkitwebframe.cpp:

2009-03-01  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Holger Freyther.

         [Gtk] get the HTTP layout tests going
         https://bugs.webkit.org/show_bug.cgi?id=24259

        Determine the frame's response and decide whether to dump as text
        or the render tree

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (dump):

2009-02-28  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Holger Freyther.

        [Gtk] get the HTTP layout tests going
        https://bugs.webkit.org/show_bug.cgi?id=24259

        Enable http tests, excluding tests/folders that fail or untested

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-01 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Sun, 1 Mar 2009 19:21:48 +0000 (19:21 +0000)]
2009-03-01  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Holger Freyther.

        [Gtk] get the HTTP layout tests going
        https://bugs.webkit.org/show_bug.cgi?id=24259

         Implement dumping of WebKitWebBackForwardList and its history
         items.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (compareHistoryItems):
        (dumpHistoryItem):
        (dumpBackForwardListForWebView):
        (dump):
        (runTest):
        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::clearBackForwardList):
        * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
        (BackForwardItem::invoke):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-01 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Sun, 1 Mar 2009 19:21:34 +0000 (19:21 +0000)]
2009-03-01  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Holger Freyther.

        [Gtk] get the HTTP layout tests going
        https://bugs.webkit.org/show_bug.cgi?id=24259

        Create a WebKitWebHistoryItem for each WebCore::HistoryItem when
        necessary.
        Add necessary API additions for us to be able to dump a WebKitWebHistoryItem

        * webkit/webkitprivate.h:
        * webkit/webkitwebbackforwardlist.cpp:
        (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_forward_list_with_limit):
        (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_back_list_with_limit):
        * webkit/webkitwebhistoryitem.cpp:
        (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new_with_core_item):
        (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new):
        (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new_with_data):
        (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_target):
        (_WebKitWebHistoryItemPrivate::webkit_web_history_item_is_target_item):
        (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_children):
        (WebKit::core):
        (WebKit::kit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
mitz@apple.com [Sun, 1 Mar 2009 19:02:08 +0000 (19:02 +0000)]
WebCore:

        Reviewed by Darin Adler.

        - fix <rdar://problem/6634768> Reproducible crash in RenderLayer::updateScrollCornerStyle() using full-page zoom at MobileMe Contacts

        Test: fast/events/scroll-during-zoom-change.html

        * dom/Document.cpp:
        (WebCore::Document::recalcStyle): Pause scheduled events during style
        reclaculation. Changes to the zoom property result in scroll events
        being generated during style recalc, and those events need to be
        deferred until the render tree is consistent.
        * page/FrameView.cpp:
        (WebCore::FrameView::layout): Changed to account for a case in which the
        post-layout tasks trigger a nested layout, which reactivates the
        post-layout task timer.

LayoutTests:

        Reviewed by Darin Adler.

        - test for <rdar://problem/6634768> Reproducible crash in RenderLayer::updateScrollCornerStyle() using full-page zoom at MobileMe Contacts

        * fast/events/scroll-during-zoom-change-expected.txt: Added.
        * fast/events/scroll-during-zoom-change.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-01 Christian Dywan <christian@twotoasts.de>
christian@webkit.org [Sun, 1 Mar 2009 19:00:20 +0000 (19:00 +0000)]
2009-03-01  Christian Dywan  <christian@twotoasts.de>

        Reviewed by Holger Freyther.

        * webkit/webkitprivate.h:
        * webkit/webkitwebview.cpp:
        (webkit_web_view_get_encoding):
        * webkit/webkitwebview.h: Implement 'encoding' and 'custom-encoding'
        properties as well as webkit_web_view_get_encoding.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-28 Zan Dobersek <zandobersek@gmail.com>
christian@webkit.org [Sun, 1 Mar 2009 18:47:14 +0000 (18:47 +0000)]
2009-02-28  Zan Dobersek  <zandobersek@gmail.com>

         Reviewed by Holger Freyther.

         Set the resolution for the default screen to 72.0.
         This way, setting font sizes results in expected values.

         * DumpRenderTree/gtk/DumpRenderTree.cpp:
         (setDefaultsToConsistentStateValuesForTesting):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Alphabetically sort scripts in the Script's panel file popup menu.
timothy@apple.com [Sun, 1 Mar 2009 16:53:35 +0000 (16:53 +0000)]
    Alphabetically sort scripts in the Script's panel file popup menu.

        https://bugs.webkit.org/show_bug.cgi?id=23395

        Reviewed by Timothy Hatcher.

        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu):
        * inspector/front-end/utilities.js:
        (insertionIndexForObjectInListSortedByFunction):
        (indexOfObjectInListSortedByFunction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Pass securityOrigin->host() instead of securityOrigin->domain() to WebInspector
timothy@apple.com [Sun, 1 Mar 2009 16:42:26 +0000 (16:42 +0000)]
    Pass securityOrigin->host() instead of securityOrigin->domain() to WebInspector
        when creating databases, localStorage or sessionStorage. Changing document.domain
        should have no affect on databases, localStorage and sessionStorage in Web Inspector.

        https://bugs.webkit.org/show_bug.cgi?id=23844

        Reviewed by Timothy Hatcher.

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::addDOMStorageScriptResource):
        (WebCore::InspectorController::didUseDOMStorage):
        * storage/Database.cpp:
        (WebCore::Database::openDatabase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-01 Gustavo Noronha Silva <gns@gnome.org>
kov@webkit.org [Sun, 1 Mar 2009 16:22:15 +0000 (16:22 +0000)]
2009-03-01  Gustavo Noronha Silva  <gns@gnome.org>

        Reviewed by Holger Freyther.

        Avoid leaking errors when reporting GIO errors.

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::readCallback):
        (WebCore::openCallback):
        (WebCore::queryInfoCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-01 Gustavo Noronha Silva <gns@gnome.org>
kov@webkit.org [Sun, 1 Mar 2009 16:21:35 +0000 (16:21 +0000)]
2009-03-01  Gustavo Noronha Silva  <gns@gnome.org>

        Reviewed by Holger Freyther.

        Fixes crash when the GIO backend is given the URI for a directory.

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::networkErrorForFile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSimple wording fix for the NEWS file.
kov@webkit.org [Sun, 1 Mar 2009 16:04:58 +0000 (16:04 +0000)]
Simple wording fix for the NEWS file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-01 Christian Dywan <christian@twotoasts.de>
christian@webkit.org [Sun, 1 Mar 2009 15:39:27 +0000 (15:39 +0000)]
2009-03-01  Christian Dywan  <christian@twotoasts.de>

        * configure.ac: Bump GTK port version to 1.1.1.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-01 Xan Lopez <xan@gnome.org>
kov@webkit.org [Sun, 1 Mar 2009 15:38:10 +0000 (15:38 +0000)]
2009-03-01  Xan Lopez  <xan@gnome.org>

        Add NEWS file to track progress between releases.

        * NEWS: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-28 Gustavo Noronha Silva <gns@gnome.org>
kov@webkit.org [Sun, 1 Mar 2009 15:29:56 +0000 (15:29 +0000)]
2009-02-28 Gustavo Noronha Silva <gns@gnome.org>

        Reviewed by Holger Freyther.

        Adds a WebKitMakeArguments environment variable to enable passing
        of arguments such as '-j2' to make for the autotools build.

        * Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-28 Gustavo Noronha Silva <gns@gnome.org>
kov@webkit.org [Sun, 1 Mar 2009 15:28:41 +0000 (15:28 +0000)]
2009-02-28 Gustavo Noronha Silva <gns@gnome.org>

        Reviewed by Holger Freyther.

        Add a GTK+-only option to enable GNOME Keyring when building.

        * Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-28 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Sun, 1 Mar 2009 06:21:22 +0000 (06:21 +0000)]
2009-02-28  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Holger Freyther.

        [Gtk] webkitdirs.pm modify path in when detecting 3D transforms and accelerated compositing
        https://bugs.webkit.org/show_bug.cgi?id=24076

        Refactor gtk lib detection and put it in builtDylibPathForName

        * Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-28 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Sun, 1 Mar 2009 05:28:31 +0000 (05:28 +0000)]
2009-02-28  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Fisher.

        https://bugs.webkit.org/show_bug.cgi?id=24261
        Fix V8 custom binding scrubbing error.

        Test: fast/dom/TreeWalker/TreeWalker-currentNode.html
        Test: traversal/exception-forwarding.html
        TesT: traversal/stay-within-root.html

        * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
        * bindings/v8/custom/V8NodeIteratorCustom.cpp:
        (WebCore::toV8): Replace v8::Undefined() return value with v8::Null().
        * bindings/v8/custom/V8TreeWalkerCustom.cpp:
        (WebCore::toV8): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-28 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Sun, 1 Mar 2009 04:27:50 +0000 (04:27 +0000)]
2009-02-28  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Fisher.

        https://bugs.webkit.org/show_bug.cgi?id=24261
        Fix V8 custom binding scrubbing error.

        Test: fast/dom/CSSStyleDeclaration/css-properties-case-sensitive.html

        * WebCore.xcodeproj/project.pbxproj:
        * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
        (WebCore::cssPropertyName):  Remove dubious checks, left over from
            incomplete conversion of parameter from pointer to pass-by-ref.
        (WebCore::NAMED_PROPERTY_GETTER): Initialize parameter.
        (WebCore::NAMED_PROPERTY_SETTER): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago - correct a color profile mismatch in expected pixel results
mitz@apple.com [Sun, 1 Mar 2009 02:47:50 +0000 (02:47 +0000)]
    - correct a color profile mismatch in expected pixel results

        * platform/mac/fast/gradients/background-clipped-expected.checksum:
        * platform/mac/fast/gradients/background-clipped-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd a ref to the ResourceHandle in startHttp so we can keep it
christian@webkit.org [Sat, 28 Feb 2009 20:29:50 +0000 (20:29 +0000)]
Add a ref to the ResourceHandle in startHttp so we can keep it
alive untill all callbacks have been executed, and unref it when
soup tells us it's done with the SoupMessage (in
finishedCallback). Fixes a number of crashes when calling
didReceiveData whould crash because of the handle dying.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUse the new webkit_web_view_load_uri to open URIs.
christian@webkit.org [Sat, 28 Feb 2009 20:12:57 +0000 (20:12 +0000)]
Use the new webkit_web_view_load_uri to open URIs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago* webkit/webkitwebview.cpp: Let webkit_web_view_open add file:// if a
christian@webkit.org [Sat, 28 Feb 2009 20:04:25 +0000 (20:04 +0000)]
* webkit/webkitwebview.cpp: Let webkit_web_view_open add file:// if a
locale path is passed for compatibility, since we used to support that.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-28 Adam Bergkvist <adam.bergkvist@ericsson.com>
kov@webkit.org [Sat, 28 Feb 2009 14:43:19 +0000 (14:43 +0000)]
2009-02-28  Adam Bergkvist <adam.bergkvist@ericsson.com>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=24226
        [SOUP] HTTP status text is never set

        Set HTTP status text to SoupMessage reason_phrase.

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::fillResponseFromMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago - fix malformed project file
mitz@apple.com [Sat, 28 Feb 2009 10:01:20 +0000 (10:01 +0000)]
    - fix malformed project file

        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
mitz@apple.com [Sat, 28 Feb 2009 09:44:45 +0000 (09:44 +0000)]
WebCore:

        Reviewed by Oliver Hunt.

        - fix https://bugs.webkit.org/show_bug.cgi?id=23848
          <rdar://problem/6573250> REGRESSION: Crash when mouse cursor moves over a link on www.opportuno.de

        Test: fast/layers/inline-dirty-z-order-lists.html

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::styleWillChange): Moved the code that dirties a
        layer's and its stacking context's z-order lists when the layer's
        z-index or visibility change from here...
        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::styleWillChange): ...to here, so that
        it will apply to RenderInline too.

LayoutTests:

        Reviewed by Oliver Hunt.

        - test for https://bugs.webkit.org/show_bug.cgi?id=23848
          <rdar://problem/6573250> REGRESSION: Crash when mouse cursor moves over a link on www.opportuno.de

        * fast/layers/inline-dirty-z-order-lists.html: Added.
        * platform/mac/fast/layers/inline-dirty-z-order-lists-expected.checksum: Added.
        * platform/mac/fast/layers/inline-dirty-z-order-lists-expected.png: Added.
        * platform/mac/fast/layers/inline-dirty-z-order-lists-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-27 Alice Liu <alice.liu@apple.com>
alice.liu@apple.com [Sat, 28 Feb 2009 08:45:43 +0000 (08:45 +0000)]
2009-02-27  Alice Liu  <alice.liu@apple.com>

        Fix <rdar://problem/6531265> REGRESSION (r39185): adding ".jpeg"
        extension to images that already have .jpg extension

        Reviewed by Oliver Hunt.

        * WebView/WebHTMLView.mm:
        (-[NSString matchesExtensionEquivalent:]):
        (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
        Relax the check for the proper extension to allow for known
        equivalents, special-cased in matchesExtensionEquivalent function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by David Hyatt.
ap@webkit.org [Sat, 28 Feb 2009 08:06:32 +0000 (08:06 +0000)]
    Reviewed by David Hyatt.

        Don't include TextResourceDecoder.h in Document.h

        This undoes inlining of Document::displayStringModifiedByEncoding() to avoid world rebuilds
        when TextResourceDecoder.h is modified. Performance impact is expected to be negligible.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-27 Gustavo Noronha Silva <gns@gnome.org>
kov@webkit.org [Sat, 28 Feb 2009 03:44:42 +0000 (03:44 +0000)]
2009-02-27  Gustavo Noronha Silva  <gns@gnome.org>

        Unreviewed build fix. Adding the WebKit/gtk/webkitmarshal.list
        file to EXTRA_DIST to fix make dist.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-27 Gustavo Noronha Silva <gns@gnome.org>
kov@webkit.org [Sat, 28 Feb 2009 02:21:11 +0000 (02:21 +0000)]
2009-02-27  Gustavo Noronha Silva  <gns@gnome.org>

        Reviewed by David Hyatt.

        Automatically ignore empty requests to avoid crashing. This fixes
        the crash in fast/loader/empty-embed-src-attribute.html.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::dispatchDecidePolicyForMIMEType):
        (WebKit::FrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
        (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
levin@chromium.org [Sat, 28 Feb 2009 01:28:46 +0000 (01:28 +0000)]
WebCore:

2009-02-27  Matt Pennig  <pennig@apple.com>

        Reviewed by David Hyatt.

        Resolves: https://bugs.webkit.org/show_bug.cgi?id=24107
        "Fixed elements have 0 as an offsetLeft property"

        Code also brings offsetLeft/Top in full conformance with the spec.
        Added two tests, one for fixed-position elements, and one for <html>.

        Tests: fast/dom/Element/fixed-position-offset-parent.html
               fast/dom/Element/offsetLeft-offsetTop-html.html

        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::offsetLeft):
        (WebCore::RenderBoxModelObject::offsetTop):

LayoutTests:

2009-02-27  Matt Pennig  <pennig@apple.com>

        Reviewed by David Hyatt.

        Added two tests:
            1. Tests offsetParent, offsetLeft and offsetTop on fixed-position elements.
            2. Tests offsetLeft and offsetTop on static and positioned <html> elements.

        * fast/dom/Element/fixed-position-offset-parent-expected.txt: Added.
        * fast/dom/Element/fixed-position-offset-parent.html: Added.
        * fast/dom/Element/offsetLeft-offsetTop-html-expected.txt: Added.
        * fast/dom/Element/offsetLeft-offsetTop-html.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-27 Dean Jackson <dino@apple.com>
dino@apple.com [Sat, 28 Feb 2009 01:13:07 +0000 (01:13 +0000)]
2009-02-27  Dean Jackson  <dino@apple.com>

        Reviewed by Simon Fraser

        Pixel tests for previous commit
        https://bugs.webkit.org/show_bug.cgi?id=24252

        * platform/mac/transforms/no_transform_hit_testing-expected.checksum: Added.
        * platform/mac/transforms/no_transform_hit_testing-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoForgot -expected file from last commit :(
dino@apple.com [Sat, 28 Feb 2009 01:07:31 +0000 (01:07 +0000)]
Forgot -expected file from last commit :(

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-27 Dean Jackson <dino@apple.com>
dino@apple.com [Sat, 28 Feb 2009 01:05:54 +0000 (01:05 +0000)]
2009-02-27  Dean Jackson  <dino@apple.com>

        Reviewed by Simon Fraser.

        renderer()->hasTransform() returns true for elements
        with perspective, but no transform, so test for transform
        when hit testing. This fixes ASSERT from
        https://bugs.webkit.org/show_bug.cgi?id=24252

        Test: transforms/no_transform_hit_testing.html

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::hitTestLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-27 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Sat, 28 Feb 2009 00:01:19 +0000 (00:01 +0000)]
2009-02-27  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Fisher.

        Fix scrubbing error -- a reversed condition.

        * bindings/v8/ScriptValue.h:
        (WebCore::ScriptValue::clear): Change early exit for empty value, not the opposite.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-27 Jian Li <jianli@chromium.org>
levin@chromium.org [Fri, 27 Feb 2009 23:29:30 +0000 (23:29 +0000)]
2009-02-27  Jian Li  <jianli@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Add confirmMessageFromWorkerObject to WorkerObjectProxy.
        https://bugs.webkit.org/show_bug.cgi?id=24152

        * workers/WorkerMessagingProxy.cpp:
        (WebCore::MessageWorkerContextTask::performTask):
        (WebCore::WorkerMessagingProxy::confirmMessageFromWorkerObject):
        * workers/WorkerMessagingProxy.h:
        * workers/WorkerObjectProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-27 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 27 Feb 2009 22:46:25 +0000 (22:46 +0000)]
2009-02-27  Anders Carlsson  <andersca@apple.com>

        Reviewed by David Hyatt.

        Revert r41295, the fix for https://bugs.webkit.org/show_bug.cgi?id=24227
        because it leads to assertion failures in the Mac port.

        * platform/graphics/BitmapImage.cpp:
        (WebCore::BitmapImage::BitmapImage):
        * platform/graphics/BitmapImage.h:
        (WebCore::BitmapImage::mayFillWithSolidColor):
        * platform/graphics/Image.h:
        (WebCore::Image::mayFillWithSolidColor):
        * platform/graphics/cairo/ImageCairo.cpp:
        (WebCore::BitmapImage::BitmapImage):
        * platform/graphics/cg/ImageCG.cpp:
        (WebCore::BitmapImage::BitmapImage):
        (WebCore::BitmapImage::checkForSolidColor):
        * platform/graphics/qt/ImageQt.cpp:
        (WebCore::BitmapImage::checkForSolidColor):
        * platform/graphics/skia/ImageSkia.cpp:
        (WebCore::BitmapImage::checkForSolidColor):
        * platform/graphics/wx/ImageWx.cpp:
        (WebCore::BitmapImage::checkForSolidColor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-27 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 27 Feb 2009 22:37:22 +0000 (22:37 +0000)]
2009-02-27  Anders Carlsson  <andersca@apple.com>

        Reviewed by Geoffrey Garen.

        <rdar://problem/6631436>
        CrashTracer: [USER] 1 crash in Safari at com.apple.WebKit • WebKit::NetscapePluginInstanceProxy::addValueToArray + 55

        Port the NPN_Evaluate code over from WebCore instead of using the frame loader.

        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::evaluate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRemove mysterious @ sign to fix Windows build.
abarth@webkit.org [Fri, 27 Feb 2009 22:24:40 +0000 (22:24 +0000)]
Remove mysterious @ sign to fix Windows build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAttempt to fix Windows build.
abarth@webkit.org [Fri, 27 Feb 2009 22:15:53 +0000 (22:15 +0000)]
Attempt to fix Windows build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-27 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 27 Feb 2009 21:58:34 +0000 (21:58 +0000)]
2009-02-27  Anders Carlsson  <andersca@apple.com>

        Reviewed by Geoffrey Garen.

        WebKit side of <rdar://problem/6626814>.

        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WKPCInvokeDefault):
        Make InvokeDefault async.

        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::addValueToArray):
        Handle passing NPObjects back to the plug-in host.

        * Plugins/Hosted/ProxyInstance.h:
        (WebKit::ProxyInstance::objectID):
        Add objectID getter.

        * Plugins/Hosted/WebKitPluginClient.defs:
        Make InvokeDefault a simpleroutine.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fixes an exception by null checking the WebResource before adding it to
timothy@apple.com [Fri, 27 Feb 2009 21:53:33 +0000 (21:53 +0000)]
    Fixes an exception by null checking the WebResource before adding it to
        the subresources array.

        <rdar://problem/5950769> Bug in [WebDataSource subresources] can throw an exception

        Reviewed by Geoff Garen and Anders Carlsson.

        * WebView/WebDataSource.mm:
        (-[WebDataSource subresources]): Null check the WebResource before adding it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Adds a workaround for Automator creating a WebView from a secondary thread.
timothy@apple.com [Fri, 27 Feb 2009 21:01:02 +0000 (21:01 +0000)]
    Adds a workaround for Automator creating a WebView from a secondary thread.

        <rdar://problem/6631951> REGRESSION (Safari 4 Beta): Automator crash on
        secondary thread beneath -[WebView initWithFrame:frameName:groupName:]

        Reviewed by Geoff Garen.

        * WebView/WebView.mm:
        (needsWebViewInitThreadWorkaround): Check for com.apple.Automator.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
abarth@webkit.org [Fri, 27 Feb 2009 20:52:55 +0000 (20:52 +0000)]
WebCore:

2009-02-27  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=20249

        Add a preference to allow universal access from local URLs to mitigate
        some attacks.  Some clients still want to allow this access, so we
        expose this as a preference.

        * WebCore.base.exp:
        * dom/Document.cpp:
        (WebCore::Document::initSecurityContext):
        * page/SecurityOrigin.cpp:
        (WebCore::SecurityOrigin::SecurityOrigin):
        * page/Settings.cpp:
        (WebCore::Settings::Settings):
        (WebCore::Settings::setAllowUniversalAccessFromFileUrls):
        * page/Settings.h:
        (WebCore::Settings::allowUniversalAccessFromFileUrls):

WebKit/mac:

2009-02-27  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add a preference to reduce the power of file:// URLs.

        * WebView/WebPreferenceKeysPrivate.h:
        * WebView/WebPreferences.mm:
        (+[WebPreferences initialize]):
        (-[WebPreferences allowUniversalAccessFromFileUrls]):
        (-[WebPreferences setAllowUniversalAccessFromFileUrls:]):
        * WebView/WebPreferencesPrivate.h:
        * WebView/WebView.mm:
        (-[WebView _preferencesChangedNotification:]):

WebKit/win:

2009-02-27  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add a preference to reduce the power of file:// URLs.

        * Interfaces/IWebPreferencesPrivate.idl:
        * WebPreferenceKeysPrivate.h:
        * WebPreferences.cpp:
        (WebPreferences::initializeDefaultSettings):
        (WebPreferences::allowUniversalAccessFromFileUrls):
        (WebPreferences::setAllowUniversalAccessFromFileUrls):
        * WebPreferences.h:
        * WebView.cpp:
        (WebView::notifyPreferencesChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-27 Adam Treat <adam.treat@torchmobile.com>
treat@webkit.org [Fri, 27 Feb 2009 20:47:04 +0000 (20:47 +0000)]
2009-02-27  Adam Treat  <adam.treat@torchmobile.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=24229
        If an image has no alpha channel there is no reason to use SourceOver.

        * platform/graphics/qt/ImageQt.cpp:
        (WebCore::Image::drawPattern):
        (WebCore::BitmapImage::draw):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-27 Adam Treat <adam.treat@torchmobile.com>
treat@webkit.org [Fri, 27 Feb 2009 20:42:51 +0000 (20:42 +0000)]
2009-02-27  Adam Treat  <adam.treat@torchmobile.com>

        Reviewed by Eric Seidel and Simon Fraser.

        https://bugs.webkit.org/show_bug.cgi?id=24227
        Ensure that the checkForSolidColor() optimization is correctly triggered
        for all cases of drawPattern.  Currently, the optimization was not triggered
        when the check had not been previously performed via a request for the
        image's NativeImagePtr.

        Implement the Qt version of the checkForSolidColor() method.  Combined with
        the bug fix this reduces the time it takes to draw a repeating background
        of a 1x1 image from ~50msecs to ~0msecs on my machine.

        * platform/graphics/BitmapImage.cpp:
        (WebCore::BitmapImage::BitmapImage):
        * platform/graphics/BitmapImage.h:
        (WebCore::BitmapImage::mayFillWithSolidColor):
        * platform/graphics/Image.h:
        (WebCore::Image::mayFillWithSolidColor):
        * platform/graphics/cairo/ImageCairo.cpp:
        (WebCore::BitmapImage::BitmapImage):
        * platform/graphics/cg/ImageCG.cpp:
        (WebCore::BitmapImage::BitmapImage):
        (WebCore::BitmapImage::checkForSolidColor):
        * platform/graphics/qt/ImageQt.cpp:
        (WebCore::BitmapImage::checkForSolidColor):
        * platform/graphics/skia/ImageSkia.cpp:
        (WebCore::BitmapImage::checkForSolidColor):
        * platform/graphics/wx/ImageWx.cpp:
        (WebCore::BitmapImage::checkForSolidColor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-27 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Fri, 27 Feb 2009 20:35:04 +0000 (20:35 +0000)]
2009-02-27  Dirk Schulze  <krit@webkit.org>

        Reviewed by Zack Rusin.

        Added support for gradients and pattern on Fonts for Qt.

        [Qt] gradients and patterns for FontQt
        https://bugs.webkit.org/show_bug.cgi?id=24243

        * platform/graphics/qt/FontQt.cpp:
        (WebCore::Font::drawComplexText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-27 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 27 Feb 2009 20:02:43 +0000 (20:02 +0000)]
2009-02-27  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Anders Carlsson

        https://bugs.webkit.org/show_bug.cgi?id=24242

        setCursor(), and resetCursorRects() on Tiger, were using global, not local
        coordinates for elementAtPoint:

        * WebView/WebHTMLView.mm:
        (resetCursorRects):
        (setCursor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-27 David Levin <levin@chromium.org>
levin@chromium.org [Fri, 27 Feb 2009 19:50:14 +0000 (19:50 +0000)]
2009-02-27  David Levin  <levin@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Bug 24213: Web Worker: Worker4 test: onmessage will never be called
        <https://bugs.webkit.org/show_bug.cgi?id=24213>

        * fast/workers/worker-terminate-expected.txt:
        * fast/workers/worker-terminate.html:
        Added a log entry to the onmessage handler for worker4 to make it visible that
        the handler was called and removed the terminate call that happened outside of onmessage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-27 Jian Li <jianli@chromium.org>
levin@chromium.org [Fri, 27 Feb 2009 19:50:03 +0000 (19:50 +0000)]
2009-02-27  Jian Li  <jianli@chromium.org>

        Reviewed by Alexey Proskuryakov.

        WorkerContextProxy::create in WorkerMessagingProxy.cpp should only be provided for non-Chromium platform.
        https://bugs.webkit.org/show_bug.cgi?id=24113

        * workers/WorkerMessagingProxy.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoCommit a missing file.
timothy@apple.com [Fri, 27 Feb 2009 19:29:24 +0000 (19:29 +0000)]
Commit a missing file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Added a refresh button to storage views.
timothy@apple.com [Fri, 27 Feb 2009 18:56:06 +0000 (18:56 +0000)]
    Added a refresh button to storage views.

        https://bugs.webkit.org/show_bug.cgi?id=24040

        Reviewed by Timothy Hatcher.

        * inspector/front-end/DOMStorageItemsView.js:
        (WebInspector.DOMStorageItemsView):
        (WebInspector.DOMStorageItemsView.prototype.get statusBarItems):
        (WebInspector.DOMStorageItemsView.prototype.update):
        (WebInspector.DOMStorageItemsView.prototype._refreshButtonClicked):
        * inspector/front-end/DatabaseTableView.js:
        (WebInspector.DatabaseTableView):
        (WebInspector.DatabaseTableView.prototype.get statusBarItems):
        (WebInspector.DatabaseTableView.prototype._refreshButtonClicked):
        * inspector/front-end/DatabasesPanel.js:
        (WebInspector.DatabasesPanel):
        (WebInspector.DatabasesPanel.prototype.get statusBarItems):
        (WebInspector.DatabasesPanel.prototype.reset):
        (WebInspector.DatabasesPanel.prototype.showDatabase):
        (WebInspector.DatabasesPanel.prototype.showDOMStorage):
        (WebInspector.DatabasesPanel.prototype._updateSidebarWidth):
        * inspector/front-end/inspector.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Added support for editing/deleting localStorage and sessionStorage items
timothy@apple.com [Fri, 27 Feb 2009 18:28:37 +0000 (18:28 +0000)]
    Added support for editing/deleting localStorage and sessionStorage items
        directly from Web Inspector.

        https://bugs.webkit.org/show_bug.cgi?id=23866.

        Reviewed by Timothy Hatcher.

        * WebCore.vcproj/WebCore.vcproj:
        * inspector/front-end/DOMStorageDataGrid.js: Added.
        (WebInspector.DOMStorageDataGrid):
        (WebInspector.DOMStorageDataGrid.prototype._ondblclick):
        (WebInspector.DOMStorageDataGrid.prototype._startEditing):
        (WebInspector.DOMStorageDataGrid.prototype._editingCommitted):
        (WebInspector.DOMStorageDataGrid.prototype._editingCancelled):
        (WebInspector.DOMStorageDataGrid.prototype.deleteSelectedRow):
        * inspector/front-end/DOMStorageItemsView.js:
        (WebInspector.DOMStorageItemsView):
        (WebInspector.DOMStorageItemsView.prototype.get statusBarItems):
        (WebInspector.DOMStorageItemsView.prototype.hide):
        (WebInspector.DOMStorageItemsView.prototype.update):
        (WebInspector.DOMStorageItemsView.prototype._deleteButtonClicked):
        * inspector/front-end/DatabasesPanel.js:
        (WebInspector.DatabasesPanel):
        (WebInspector.DatabasesPanel.prototype.get statusBarItems):
        (WebInspector.DatabasesPanel.prototype.reset):
        (WebInspector.DatabasesPanel.prototype.showDOMStorage):
        (WebInspector.DatabasesPanel.prototype.dataGridForDOMStorage):
        (WebInspector.DatabasesPanel.prototype._updateSidebarWidth):
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.css:
        * inspector/front-end/inspector.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix Windows transparency for the Chromium port. Implement a helper
brettw@chromium.org [Fri, 27 Feb 2009 17:42:21 +0000 (17:42 +0000)]
Fix Windows transparency for the Chromium port. Implement a helper
class for handling transparency on Windows. It allows semitransparent
ClearType and semitransparent form controls by making new layers in the
background.

It also replaces the "ThemeHelper" which allows better
scaling and transforms on Windows form controls. In addition to the
functionality that the ThemeHelper did, but additionally handles the
antialiasing properly so that the form controls aren't composited on a
white square.

https://bugs.webkit.org/show_bug.cgi?id=24101

Reviewed by Eric Seidel.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-27 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Fri, 27 Feb 2009 16:23:38 +0000 (16:23 +0000)]
2009-02-27  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=24211
        Add ScheduledAction for V8.

        * bindings/v8/ScheduledAction.cpp: Added.
        (WebCore::ScheduledAction::ScheduledAction):
        (WebCore::ScheduledAction::~ScheduledAction):
        (WebCore::ScheduledAction::execute):
        * bindings/v8/ScheduledAction.h: Added.
        (WebCore::ScheduledAction::ScheduledAction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-27 Zack Rusin <zack@kde.org>
treat@webkit.org [Fri, 27 Feb 2009 14:59:26 +0000 (14:59 +0000)]
2009-02-27  Zack Rusin  <zack@kde.org>

        Reviewed by Nikolas Zimmermann.

        Qt: be more reasonable about scrolled lines

        cMouseWheelPixelsPerLineStep is currently a constant set to 13.3. it doesn't
        match our metrics meaning that Qt scrolls by ~2 lines by default which is quite
        irritating. so lets scroll vertically by the Qt set number of lines * Qt default
        single step scroll

        * platform/qt/WheelEventQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-27 Xan Lopez <xan@gnome.org>
jmalonzo@webkit.org [Fri, 27 Feb 2009 11:30:07 +0000 (11:30 +0000)]
2009-02-27  Xan Lopez  <xan@gnome.org>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=24221
        [GTK] Do not emit load-finished when being disposed

        webkit_web_view_stop_load() is called from dispose() on
        WebKitWebView. This eventually calls postProgressFinishedNotification
        in FrameLoaderClientGtk, which emits load-finished. Add
        a 'disposing' flag to WebView that we can check here, so
        we avoid emitting signals on objects on their way to be
        destroyed.  This fixes a bunch of critical warnings when
        closing a loading WebView.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::postProgressFinishedNotification):
        * webkit/webkitprivate.h:
        * webkit/webkitwebview.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-27 Xan Lopez <xan@gnome.org>
jmalonzo@webkit.org [Fri, 27 Feb 2009 11:18:21 +0000 (11:18 +0000)]
2009-02-27  Xan Lopez  <xan@gnome.org>

        Rubber-stamped by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=24222
        [GTK] Remove checks for old glib versions

        libsoup, which is a hard dependency, needs at least glib 2.15.3,
        so remove all glib checks for versions older than that.

        * platform/gtk/ContextMenuGtk.cpp:
        (WebCore::ContextMenu::ContextMenu):
        * platform/gtk/ContextMenuItemGtk.cpp:
        (WebCore::ContextMenuItem::setSubMenu):
        * platform/gtk/PopupMenuGtk.cpp:
        (WebCore::PopupMenu::show):
        * platform/gtk/WidgetGtk.cpp:
        (WebCore::Widget::retainPlatformWidget):
        * platform/network/soup/ResourceHandleSoup.cpp:

WebKit/gtk:

2009-02-27  Xan Lopez  <xan@gnome.org>

        Rubber-stamped by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=24222
        [GTK] Remove checks for old glib versions

        libsoup, which is a hard dependency, needs at least glib 2.15.3,
        so remove all glib checks for versions older than that.

        * webkit/webkitwebview.cpp:

WebKitTools:

2009-02-27  Xan Lopez  <xan@gnome.org>

        Rubber-stamped by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=24222
        [GTK] Remove checks for old glib versions

        libsoup, which is a hard dependency, needs at least glib 2.15.3,
        so remove all glib checks for versions older than that.

        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::setWaitToDump):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41283 268f45cc-cd09-0410-ab3c-d52691b4dbfc