15 years ago Reviewed by Tim Hatcher.
adele [Fri, 26 Oct 2007 20:28:24 +0000 (20:28 +0000)]
    Reviewed by Tim Hatcher.

        Updating header too for WKDrawCapsLockIndicator.

        * WebKitSystemInterface.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
adele [Fri, 26 Oct 2007 19:52:42 +0000 (19:52 +0000)]

        Reviewed by Oliver.

        Adding WebKitSystemInterface support for the caps lock indicator

        * platform/mac/WebCoreSystemInterface.h:
        * platform/mac/WebCoreSystemInterface.mm:


        Reviewed by Oliver.

        Adding WebKitSystemInterface support for the caps lock indicator

        * WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):


        Reviewed by Oliver.

        Adding wkDrawCapsLockIndicator in preparation for fixing the caps lock indicator.

        * libWebKitSystemInterfaceLeopard.a:
        * libWebKitSystemInterfaceTiger.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
tristan [Fri, 26 Oct 2007 19:22:11 +0000 (19:22 +0000)]

        Reviewed by Darin Adler.

        <rdar://problem/5555053> REGRESSION:9A581: Window disappears when opening http://research.microsoft.com/users/darkok/
        The problem was caused by checkin r24654. This change moved explicit bounds checking into adjustWindowRect
        but failed to account for bounds checking (instead replaced with bounds clipping).  This caused issues
        when NaN was used. This patch goes one step further and does NaN checking to prevent the possibility of
        setting window bounds to NaN before an update occurs.

        Test: fast/dom/Window/window-resize-nan.html

        * bindings/js/kjs_window.cpp:
        Added a new parameter, pendingChanges, which takes pending changes to the window
        rect, and if they are valid (not NaN) sets them on window.

        Adjusted uses of adjustWindowRect to take new update parameter.


        Reviewed by Darin Adler.

        Added new test cases to handle non-number input to window adjusting
        functions like resizeTo, resizeBy, moveTo, and moveBy for

        * fast/dom/Window/window-resize-nan-expected.txt: Added.
        * fast/dom/Window/window-resize-nan.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Tim Hatcher.
weinig [Fri, 26 Oct 2007 18:39:43 +0000 (18:39 +0000)]
    Reviewed by Tim Hatcher.

        Fix for http://bugs.webkit.org/show_bug.cgi?id=15175
        Cannot copy text of errors from Web Inspector from Console view

        * page/inspector/inspector.css: add -webkit-user-select: text for console messages.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Tim Hatcher.
weinig [Fri, 26 Oct 2007 18:17:04 +0000 (18:17 +0000)]
    Reviewed by Tim Hatcher.

        Fix for http://bugs.webkit.org/show_bug.cgi?id=15446
        Web Inspector find window is not resizable

        - Adds ability to resize the find window.
        - Fixes bug that messed up the find window when resizing the left sidebar.

        * page/inspector/inspector.css:
        * page/inspector/inspector.html:
        * page/inspector/inspector.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Update m_current index after we've removed an item:
adachan [Fri, 26 Oct 2007 16:34:53 +0000 (16:34 +0000)]
    Update m_current index after we've removed an item:
        - if item removed is before m_current, decrement m_current
        - if the current item is removed, make sure m_current is within bounds.

        Reviewed by Darin.

        * history/BackForwardList.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
ddkilzer [Fri, 26 Oct 2007 15:38:48 +0000 (15:38 +0000)]
    prepare-ChangeLog and update-webkit create needless ChangeLog conflicts

        Reviewed by Darin.

        The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
        a patch of the local changes and applying it with a fuzz level of 3 to the new file.
        If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
        file.  Note that it may also be used as a stand-alone script.

        * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
        * Scripts/resolve-ChangeLogs: Added.
        * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoRestore the semicolon.
mrowe@apple.com [Fri, 26 Oct 2007 13:34:39 +0000 (13:34 +0000)]
Restore the semicolon.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-10-26 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Fri, 26 Oct 2007 13:31:15 +0000 (13:31 +0000)]
2007-10-26  Mark Rowe  <mrowe@apple.com>

        Windows build fix.

        * kjs/collector.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-10-26 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Fri, 26 Oct 2007 12:22:37 +0000 (12:22 +0000)]
2007-10-26  Mark Rowe  <mrowe@apple.com>

        Build fix.  Add missing #include of Platform.h.

        * Api/qwebhistoryinterface.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-10-26 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Fri, 26 Oct 2007 12:07:39 +0000 (12:07 +0000)]
2007-10-26  Mark Rowe  <mrowe@apple.com>

        Debug build fix.

        * bindings/js/kjs_proxy.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoMake the JSC GC use a separate heap for JSNumbers to get a 0.7-1.4% progression in...
oliver [Fri, 26 Oct 2007 12:06:33 +0000 (12:06 +0000)]
Make the JSC GC use a separate heap for JSNumbers to get a 0.7-1.4% progression in SunSpider.

Reviewed by Maciej

        * kjs/CollectorHeapIntrospector.cpp:
        * kjs/CollectorHeapIntrospector.h:
        * kjs/collector.cpp:
        * kjs/collector.h:
        * kjs/internal.h:
        (KJS::NumberImp::operator new):
          Force numbers to be allocated in the secondary heap.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago No review, build fix.
mjs [Fri, 26 Oct 2007 11:53:15 +0000 (11:53 +0000)]
    No review, build fix.

        * bindings/objc/WebScriptObject.mm:
        (+[WebScriptObject throwException:]):
        (-[WebScriptObject setException:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Rubber Stamped by Mark.
mjs [Fri, 26 Oct 2007 11:50:21 +0000 (11:50 +0000)]
    Rubber Stamped by Mark.

        - fix build

        * bridge/mac/WebCoreScriptDebugger.mm:
        (-[WebCoreScriptCallFrame scopeChain]):
        (-[WebCoreScriptCallFrame functionName]):
        (-[WebCoreScriptCallFrame evaluateWebScript:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Rubber Stamped by Oliver.
mjs [Fri, 26 Oct 2007 11:48:08 +0000 (11:48 +0000)]
    Rubber Stamped by Oliver.

        - fix build

        * bridge/mac/WebCoreScriptDebugger.mm:
        (-[WebCoreScriptCallFrame scopeChain]):
        (-[WebCoreScriptCallFrame functionName]):
        (-[WebCoreScriptCallFrame evaluateWebScript:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Oliver.
mjs [Fri, 26 Oct 2007 11:46:13 +0000 (11:46 +0000)]
    Reviewed by Oliver.

        - encourage GCC a little harder to inline a few hot functions for 1.5% improvement on SunSpider.

        * kjs/value.h:
        * wtf/PassRefPtr.h:
        * wtf/RefPtr.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix ChangeLog ordering.
mrowe@apple.com [Fri, 26 Oct 2007 10:45:37 +0000 (10:45 +0000)]
Fix ChangeLog ordering.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-10-26 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Fri, 26 Oct 2007 10:44:24 +0000 (10:44 +0000)]
2007-10-26  Mark Rowe  <mrowe@apple.com>

        Gtk build fix.

        * kjs/ExecState.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Windows build fix.
mjs [Fri, 26 Oct 2007 10:36:45 +0000 (10:36 +0000)]
    Windows build fix.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-10-26 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Fri, 26 Oct 2007 09:38:51 +0000 (09:38 +0000)]
2007-10-26  Mark Rowe  <mrowe@apple.com>

        Windows build fix.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-10-26 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Fri, 26 Oct 2007 09:38:31 +0000 (09:38 +0000)]
2007-10-26  Mark Rowe  <mrowe@apple.com>

        Gtk build fix.

        * JavaScriptCore.pri:
        * kjs/ExecState.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoJavaScriptCore:
mjs [Fri, 26 Oct 2007 08:32:40 +0000 (08:32 +0000)]

        Reviewed by Oliver.

        - moved Context class into ExecState.{h,cpp} in preparation for merging
        ExecState and Context classes.

        * kjs/ExecState.h: Moved CodeType enum and Context class here in
        preparation for merging ExecState and Context.
        * kjs/ExecState.cpp: Moved Context class here from Context.cpp.
        * kjs/context.h: Removed.
        * kjs/Context.cpp: Removed.
        * kjs/function.h: Removed CodeType enum.
        * kjs/LabelStack.h: Added. Pulled LabelStack class out of internal.h.
        * kjs/internal.h: Removed LabelStack.
        * JavaScriptCore.xcodeproj/project.pbxproj: Added new file, removed ones that are gone.
        * kjs/collector.cpp: Fixed includes.
        * kjs/function.cpp: ditto
        * kjs/internal.cpp: ditto
        * kjs/interpreter.cpp: ditto
        * kjs/lookup.h: ditto
        * kjs/nodes.cpp: ditto


        Reviewed by Oliver.

        - update for JavaScriptCore header changes

        * bindings/objc/WebScriptObject.mm:
        * bridge/mac/WebCoreScriptDebugger.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-10-26 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Fri, 26 Oct 2007 08:13:26 +0000 (08:13 +0000)]
2007-10-26  Mark Rowe  <mrowe@apple.com>

        Windows build fix.

        * kjs/string_object.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoJavaScriptCore:
darin [Fri, 26 Oct 2007 07:51:25 +0000 (07:51 +0000)]

        Reviewed by Maciej.

        - http://bugs.webkit.org/show_bug.cgi?id=15703
          fix numeric functions -- improve correctness and speed

        Gives about 1% gain on SunSpider.

        * kjs/value.h: Added toIntegerPreserveNan, removed toUInt16.
        (KJS::JSValue::toInt32): Changed to call getTruncatedInt32 in a way that works
        with both immediate and number values.
        (KJS::JSValue::toUInt32): Ditto.
        * kjs/value.cpp:
        (KJS::JSValue::toInteger): Moved the logic from roundValue here, with a couple
        differences. One is that it now correctly returns 0 for NaN, and another is that
        there's no special case for 0 or infinity, since the general case already handles
        those correctly.
        (KJS::JSValue::toIntegerPreserveNaN): Added. Like toInteger, but without the
        check for NaN.
        (KJS::JSValue::toInt32SlowCase): Call toNumber instead of roundValue. The
        truncation done by the typecast already does the necessary truncation that
        roundValue was doing.
        (KJS::JSValue::toUInt32SlowCase): Ditto.
        (KJS::JSValue::toUInt16): Removed.

        * kjs/internal.h: Removed roundValue.
        * kjs/internal.cpp: Ditto.

        * kjs/array_object.cpp: (KJS::ArrayProtoFunc::callAsFunction): Remove unneeded
        code to handle NaN in Array.slice; toInteger now never returns NaN as specified.

        * kjs/date_object.cpp:
        (KJS::fillStructuresUsingTimeArgs): Replaced call to roundValue with a call to
        toNumber as specified.
        (KJS::DateProtoFunc::callAsFunction): In SetTime case, replaced call to roundValue
        with a call to toNumber and timeClip as specified.
        (KJS::DateObjectImp::construct): Removed unnecessary checks of numArgs in cases
        where the default behavior of toInt32 (returning 0) was already correct. Replaced
        call to roundValue with a call to toNumber as specified.
        (KJS::DateObjectFuncImp::callAsFunction): Ditto.

        * kjs/math_object.cpp: (MathFuncImp::callAsFunction): Removed unnecessary special
        cases for the pow function that the library already handles correctly.

        * kjs/number_object.cpp: (NumberProtoFunc::callAsFunction): Changed ToString to
        call toIntegerPreserveNaN, so we can continue to handle the NaN case differently.
        The real toInteger now returns 0 for NaN. Took out unneeded special case in
        ToFixed for undefined; was only needed because our toInteger was wrong. Same
        thing in ToExponential. Changed ToPrecision to call toIntegerPreserveNaN.

        * kjs/string_object.cpp:
        (KJS::StringProtoFunc::callAsFunction): Took out CharAt and CharCodeAt special
        cases for undefined that were only needed because toInteger was wrong. Same in
        IndexOf, and was able to remove some special cases. In LastIndexOf, used
        toIntegerPreserveNaN, but was able to remove some special cases there too.
        Changed Substr implementation to preserve correct behavior with the change
        to toInteger and match the specification. Also made sure we weren't converting
        an out of range double to an int.
        (KJS::StringObjectFuncImp::callAsFunction): Changed constructor to just use
        toUInt32, because truncating toUInt32 to 16 bits is the same thing and there's
        no reason to have toUInt16 as a second, less-optimized function that's only
        called at this one call site.

        * wtf/MathExtras.h: Added trunc function for Windows.


        Reviewed by Maciej.

        - test changes for http://bugs.webkit.org/show_bug.cgi?id=15703
          fix numeric functions -- improve correctness and speed

        * fast/js/resources/char-at.js: Updated test to expect that we get the first
        character if we pass NaN to charAt and charCodeAt; it's what the specification
        asks for and matches other browsers too.
        * fast/js/char-at-expected.txt: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-10-26 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Fri, 26 Oct 2007 06:58:35 +0000 (06:58 +0000)]
2007-10-26  Mark Rowe  <mrowe@apple.com>

        Update expected results.

        * platform/mac/fast/overflow/clip-rects-fixed-ancestor-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej Stachowiak.
ggaren [Fri, 26 Oct 2007 06:55:36 +0000 (06:55 +0000)]
    Reviewed by Maciej Stachowiak.

        Tweaked the inner hashtable lookup loop to remove a branch in the "not
        found" case. .5% speedup on SunSpider.

        * JavaScriptCore.xcodeproj/project.pbxproj:
        * wtf/HashTable.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-10-26 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Fri, 26 Oct 2007 06:55:16 +0000 (06:55 +0000)]
2007-10-26  Mark Rowe  <mrowe@apple.com>

        Qt build fix.  r27084 added a destructor implementation for LayoutTestController
        to the Qt port on the assumption that it was an implementation of the cross-platform
        LayoutTestController class.  It is not, so it did not need to be changed.

        * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-10-25 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Fri, 26 Oct 2007 06:36:35 +0000 (06:36 +0000)]
2007-10-25  Mark Rowe  <mrowe@apple.com>

        Reviewed by Maciej.

        Fix builds with code coverage enabled.

        * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Mark Rowe.
darin [Fri, 26 Oct 2007 06:19:07 +0000 (06:19 +0000)]
    Reviewed by Mark Rowe.

        * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
        * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agobuild Fix
slewis [Fri, 26 Oct 2007 05:01:12 +0000 (05:01 +0000)]
build Fix

        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Oliver.
mjs [Fri, 26 Oct 2007 03:58:18 +0000 (03:58 +0000)]
    Reviewed by Oliver.

        - fold together toPrimitive() and toNumber() conversions for 0.5% gain on SunSpider

        * kjs/nodes.cpp:
        (KJS::SubNode::evaluate): Subtract directly, since toPrimitive() is not
        adding any value over toNumber() here.
        (KJS::valueForReadModifyAssignment): Ditto.
        (KJS::lessThan): Use new getPrimitiveNumber() method to avoid some virtual calls
        and branches.
        (KJS::lessThanEq): Ditto.
        * JavaScriptCore.exp: Export new functions as needed.
        * kjs/value.h:
        (KJS::JSValue::toPrimitive): Fixed formatting.
        (KJS::JSValue::getPrimitiveNumber): New method - this simultaneously converts
        to number and tells you whether a toPrimitive() conversion with a Number hint
        would have given a string.
        * kjs/internal.cpp:
        (KJS::StringImp::getPrimitiveNumber): Implemented.
        (KJS::NumberImp::getPrimitiveNumber): ditto
        (KJS::GetterSetterImp::getPrimitiveNumber): ditto
        (KJS::StringImp::toPrimitive): Fixed formatting.
        (KJS::NumberImp::toPrimitive): ditto
        (KJS::GetterSetterImp::toPrimitive): ditto
        * kjs/internal.h:
        * kjs/object.cpp:
        (KJS::JSObject::getPrimitiveNumber): Implemented.
        * kjs/object.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWeak link against WebCore so DumpRenderTree can be bundled with production roots.
slewis [Fri, 26 Oct 2007 03:42:35 +0000 (03:42 +0000)]
Weak link against WebCore so DumpRenderTree can be bundled with production roots.

        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam.
aliceli1 [Fri, 26 Oct 2007 03:09:18 +0000 (03:09 +0000)]
    Reviewed by Adam.

        Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows

        Moving destructor into platform-specific files
        * DumpRenderTree/LayoutTestController.cpp:
        * DumpRenderTree/mac/LayoutTestControllerMac.mm:
        * DumpRenderTree/qt/jsobjects.cpp:

        LayoutTestController wasn't being destroyed
        * DumpRenderTree/win/DumpRenderTree.cpp:

        Added declspec
        * DumpRenderTree/win/EditingDelegate.h:

        Reset certain values on the webview (or related delegate) that might
        have changed while running a test
        * DumpRenderTree/win/LayoutTestControllerWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-10-26 Alp Toker <alp@atoker.com>
alp [Fri, 26 Oct 2007 02:46:56 +0000 (02:46 +0000)]
2007-10-26  Alp Toker  <alp@atoker.com>

        Reviewed by Mark Rowe.

        [GTK] Paging does not work when widget is added to a GtkScrolledWindow

        Eliminate MagicGtkScrollConstant in favour of the same calculations as
        GtkTextView for step and page increments. This also makes paging work,
        as the page increment was previously always 0.

        * platform/gtk/ScrollViewGtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix the windows build for real
weinig [Fri, 26 Oct 2007 01:44:40 +0000 (01:44 +0000)]
Fix the windows build for real

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam Roben.
weinig [Fri, 26 Oct 2007 01:11:27 +0000 (01:11 +0000)]
    Reviewed by Adam Roben.

        Make debug builds run again.

        * WebView.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Add wkSetPatternBaseCTM.
aroben [Fri, 26 Oct 2007 01:09:08 +0000 (01:09 +0000)]
    Add wkSetPatternBaseCTM.

        Reviewed by NOBODY.

        * win/include/WebKitSystemInterface/WebKitSystemInterface.h:
        * win/lib/WebKitSystemInterface.lib:
        * win/lib/WebKitSystemInterface_debug.lib:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoJavaScriptCore:
weinig [Fri, 26 Oct 2007 01:09:00 +0000 (01:09 +0000)]

        Reviewed by Adam Roben.

        Remove JSStringRefCFHack from windows as it is no longer needed.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:


        Reviewed by Adam Roben.

        Remove JSStringRefCFHack.

        * WebKit.vcproj/WebKit.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Steve Falkenburg.
weinig [Fri, 26 Oct 2007 00:10:07 +0000 (00:10 +0000)]
    Reviewed by Steve Falkenburg.

        Fix for <rdar://problem/5463608>
        Port WebKit cache model code (Windows needs a big disk cache, smarter memory cache)

        * Interfaces/IWebPreferences.idl:
        Deprecate pageCacheSize and objectCacheSize and add cacheModel/setCacheModel.

        * Interfaces/IWebPreferencesPrivate.idl:
        Add automaticallyDetectsCacheModel/setAutomaticallyDetectsCacheModel

        * WebFrame.cpp:
        Implement based on the mac version.

        * WebKit.vcproj/WebKit.vcproj:
        * WebKitSystemBits.cpp: Added.
        (WebMemorySize): Moved and renamed from WebPreferences.cpp
        (WebVolumeFreeSize): Added.
        * WebKitSystemBits.h: Added.
        * WebPreferenceKeysPrivate.h: Added WebKitCacheModelPreferenceKey.

        * WebPreferences.cpp:
        (WebPreferences::initializeDefaultSettings): Added default for cacheModel.
        (WebPreferences::initWithIdentifier): Post a preferences change notification.
        (WebPreferences::pageCacheSize): Deprecated.
        (WebPreferences::objectCacheSize): Deprecated.
        (WebPreferences::cacheModel): Added.
        (WebPreferences::setCacheModel): Added.
        (WebPreferences::setAutomaticallyDetectsCacheModel): Added.
        (WebPreferences::automaticallyDetectsCacheModel): Added.
        (WebPreferences::willAddToWebView): Added.
        (WebPreferences::didRemoveFromWebView): Added.
        * WebPreferences.h:

        * WebView.cpp:
        This singleton class updates static properties for all webviews when
        preferenceChange or preferenceRemoved notifications are fired for
        any WebPreference.
        * WebView.h:
        Match the macs behavior by using explicit postings of notifications to
        update the preferences.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Make sunspider-compare-results work with relative paths
aroben [Thu, 25 Oct 2007 23:38:21 +0000 (23:38 +0000)]
    Make sunspider-compare-results work with relative paths

        Reviewed by Sam.

        * Scripts/sunspider-compare-results: Convert arguments to absolute
        paths before we chdir.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix unbalanced save/restore on Leopard only.
hyatt [Thu, 25 Oct 2007 23:33:41 +0000 (23:33 +0000)]
Fix unbalanced save/restore on Leopard only.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Strip carriage returns from results
aroben [Thu, 25 Oct 2007 23:23:28 +0000 (23:23 +0000)]
    Strip carriage returns from results

        Carriage returns were screwing up sunspider-compare-results on

        Rubberstamped by Oliver.

        * sunspider:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Dave Hyatt and Sam Weinig.
mitz [Thu, 25 Oct 2007 23:17:48 +0000 (23:17 +0000)]
    Reviewed by Dave Hyatt and Sam Weinig.

        Build fix

        * platform/graphics/cg/ImageCG.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix the windows build.
weinig [Thu, 25 Oct 2007 23:16:45 +0000 (23:16 +0000)]
    Fix the windows build.

        * win/lib/WebKitSystemInterface.lib:
        * win/lib/WebKitSystemInterface_debug.lib:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Oliver Hunt.
ggaren [Thu, 25 Oct 2007 22:29:55 +0000 (22:29 +0000)]
    Reviewed by Oliver Hunt.

        Rolled out my last patch. It turns out that I needed 2 words, not 1,
        so it didn't help.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Add WKSetPatternBaseCTM.
thatcher [Thu, 25 Oct 2007 22:23:54 +0000 (22:23 +0000)]
    Add WKSetPatternBaseCTM.

        * WebKitSystemInterface.h:
        * libWebKitSystemInterfaceLeopard.a:
        * libWebKitSystemInterfaceTiger.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoRemove the empty WebKitQt folders.
thatcher [Thu, 25 Oct 2007 22:13:41 +0000 (22:13 +0000)]
Remove the empty WebKitQt folders.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-10-23 Jan Michael Alonzo <jmalonzo@unpluggable.com>
alp [Thu, 25 Oct 2007 21:56:17 +0000 (21:56 +0000)]
2007-10-23  Jan Michael Alonzo  <jmalonzo@unpluggable.com>

        Reviewed by Alp.

        [GTK] Implement WebCore::Widget::isEnabled/setEnabled

        * platform/gtk/WidgetGtk.cpp:
        (WebCore::Widget::setEnabled): Implemented.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Oliver Hunt.
ggaren [Thu, 25 Oct 2007 21:37:45 +0000 (21:37 +0000)]
    Reviewed by Oliver Hunt.

        Fixed http://bugs.webkit.org/show_bug.cgi?id=15694
        Shrink the size of an activation object by 1 word

        This is in preparation for adding a symbol table to the activation

        The basic strategy here is to rely on the mutual exclusion between
        the arguments object pointer and the function pointer (you only need
        the latter in order to create the former), and store them in the same
        place. The LazyArgumentsObject class encapsulates this strategy.

        Also inlined the ArgumentsImp constructor, for good measure.

        SunSpider reports no regression. Regression tests pass.

        * JavaScriptCore.xcodeproj/project.pbxproj:
        * kjs/Context.cpp:
        * kjs/function.cpp:
        * kjs/function.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWeinig also reviewed this patch, and wanted Changelog credit for it
beidson [Thu, 25 Oct 2007 21:32:01 +0000 (21:32 +0000)]
Weinig also reviewed this patch, and wanted Changelog credit for it

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Sam.
kmccullo [Thu, 25 Oct 2007 21:26:48 +0000 (21:26 +0000)]
    Reviewed by Sam.

        - Implemented server calls now the WebScriptDebugServer exists.
        - Also removed no longer needed call to initialize CG.

        * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
        automatically now.
        * Drosera/win/ServerConnection.cpp: Now uses the COM class.
        * Drosera/win/ServerConnection.h: Now uses the COM class.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoAdd border image transforms test.
hyatt [Thu, 25 Oct 2007 21:12:20 +0000 (21:12 +0000)]
Add border image transforms test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoAdd border image transforms test.
hyatt [Thu, 25 Oct 2007 21:11:59 +0000 (21:11 +0000)]
Add border image transforms test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoAdd background transform test.
hyatt [Thu, 25 Oct 2007 21:09:08 +0000 (21:09 +0000)]
Add background transform test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoAdd background transform test.
hyatt [Thu, 25 Oct 2007 21:08:42 +0000 (21:08 +0000)]
Add background transform test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix some JavaScriptCore build issues
aroben [Thu, 25 Oct 2007 21:03:52 +0000 (21:03 +0000)]
Fix some JavaScriptCore build issues


        Change JavaScriptCore.vcproj to use DerivedSources.make

        We were trying to emulate the logic of make in
        build-generated-files.sh, but we got it wrong. We now use a
        build-generated-files very much like the one that WebCore uses to
        invoke make.

        We also now only have a Debug configuration of dftables which we build
        even when doing a Release build of JavaScriptCore. dftables also no
        longer has the "_debug" name suffix.

        Changes mostly made by Darin, reviewed by me.

        * DerivedSources.make: Add a variable to set the extension used for
        the dftables executable.
        * JavaScriptCore.vcproj/JavaScriptCore.sln: Updated to use Debug
        dftables in Release configurations.
        * JavaScriptCore.vcproj/JavaScriptCoreSubmit.sln: Ditto.
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
           - Updated include path to point to the new location of the derived
           - Modified pre-build event to pass the right arguments to
             build-generated-files.sh and not call dftables directly.
           - Added the derived source files to the project.
           - Removed grammarWrapper.cpp, which isn't needed now that we're
             compiling grammar.cpp directly.
        * JavaScriptCore.vcproj/JavaScriptCore/build-generated-files.sh:
        Slightly modified from the WebCore version.
        * JavaScriptCore.vcproj/JavaScriptCore/grammarWrapper.cpp: Removed.
        * JavaScriptCore.vcproj/dftables/dftables.vcproj:
            - Changed the output location to match Mac.
            - Removed the Release configuration.
            - Removed the _debug suffix.


        Update WebKit.sln for the removal of Release dftables

        Reviewed by NOBODY.

        * WebKit.vcproj/WebKit.sln:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
hyatt [Thu, 25 Oct 2007 21:03:41 +0000 (21:03 +0000)]

        Fix for bug 15672, background images don't tile properly inside transforms.  This patch fixes background
        tiling to work in the presence of transforms and fixes bugs in both SVG and CSS transforms.

        Reviewed by aroben and mitz

        * WebCore.base.exp:
        * platform/graphics/Image.cpp:
        * platform/graphics/cg/ImageCG.cpp:
        * platform/graphics/mac/GraphicsContextMac.mm:
        * platform/mac/WebCoreSystemInterface.h:
        * platform/mac/WebCoreSystemInterface.mm:


        Fix for bug 15672, backgrounds don't tile properly inside transforms.  This patch fixes tiling
        of backgrounds inside CSS transforms and also of HTML content with background images inside SVG

        Reviewed by aroben and mmitz

        * WebCoreSupport/WebSystemInterface.m:
        * WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Tim Hatcher
sullivan [Thu, 25 Oct 2007 20:46:40 +0000 (20:46 +0000)]
    Reviewed by Tim Hatcher

        Removed the support for toggling whether WebKit uses the 10.5 PDFKit improvements. Now it
        always does, when available.

        * WebView/WebPreferencesPrivate.h:
        removed _usePDFPreviewView and _setUsePDFPreviewView:. Note that these were guarded with
        a comment that says that they can be removed when no longer needed. That time is now.

        * WebView/WebPreferences.m:
        (+[WebPreferences initialize]):
        removed WebKitUsePDFPreviewViewPreferenceKey
        (-[WebPreferences _usePDFPreviewView]):
        (-[WebPreferences _setUsePDFPreviewView:]):

        * WebView/WebPDFView.mm:
        (-[WebPDFView initWithFrame:]):
        don't check _usePDFPreviewView

        * WebView/WebPreferenceKeysPrivate.h:
        removed WebKitUsePDFPreviewViewPreferenceKey

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Rubber stamped by Geoff.
kmccullo [Thu, 25 Oct 2007 20:37:42 +0000 (20:37 +0000)]
    Rubber stamped by Geoff.

        - Stubbed out the WebScriptDebugServer methods to give Drosera something
        to connect to and now the signature of the interface matches the mac.

        * Interfaces/IWebScriptDebugServer.idl:
        * WebScriptDebugServer.cpp:
        * WebScriptDebugServer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam.
thatcher [Thu, 25 Oct 2007 20:17:09 +0000 (20:17 +0000)]
    Reviewed by Adam.

        Update the Leopard WebKitSystemInterface to be 4-way univeral to include 64-bit.

        * libWebKitSystemInterfaceLeopard.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Blind build fix attempt
beidson [Thu, 25 Oct 2007 19:37:02 +0000 (19:37 +0000)]
    Blind build fix attempt

        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Added wrapper for getting the foundation cache directory.
weinig [Thu, 25 Oct 2007 19:26:30 +0000 (19:26 +0000)]
    Added wrapper for getting the foundation cache directory.

        Reviewed by Adam Roben.

        * win/include/WebKitSystemInterface/WebKitSystemInterface.h:
        * win/lib/WebKitSystemInterface.lib:
        * win/lib/WebKitSystemInterface_debug.lib:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Anders
beidson [Thu, 25 Oct 2007 19:26:15 +0000 (19:26 +0000)]
    Reviewed by Anders

        Bulk rename of platform/sql/SQL* to platform/sql/SQLite*

        This is more accurate in that there is no realistic "SQL" abstraction, the classes are obviously
        tied extremely close to SQLite, and is necessitated by the introduction of "SQLTransaction" in
        the HTML5 database API which we are adopting.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
kmccullo [Thu, 25 Oct 2007 18:47:34 +0000 (18:47 +0000)]
    Reviewed by Darin.

        - Renamed WebDebugProgram to WebScriptDebugServer to match the naming
        scheme on the mac.

        * Interfaces/IWebDebugProgram.idl: Removed.
        * Interfaces/IWebScriptDebugServer.idl: Copied from win/Interfaces/IWebDebugProgram.idl.
        * Interfaces/WebKit.idl:
        * WebDebugProgram.cpp: Removed.
        * WebDebugProgram.h: Removed.
        * WebKit.vcproj/Interfaces.vcproj:
        * WebKit.vcproj/WebKit.vcproj:
        * WebKit.vcproj/WebKitGUID.vcproj:
        * WebKitClassFactory.cpp:
        * WebKitDLL.cpp:
        * WebScriptDebugServer.cpp: Copied from win/WebDebugProgram.cpp.
        * WebScriptDebugServer.h: Copied from win/WebDebugProgram.h.
        * WebView.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
ap [Thu, 25 Oct 2007 18:31:32 +0000 (18:31 +0000)]
    Reviewed by Darin.

        XML attribute nodes are not importable

        Tests: fast/dom/import-attribute-node.html

        * dom/Document.cpp:
        (WebCore::Document::importNode): Implemented for Attribute and DocumentFragment nodes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
mitz [Thu, 25 Oct 2007 18:23:01 +0000 (18:23 +0000)]

        Reviewed by Dave Hyatt.

        - fix http://bugs.webkit.org/show_bug.cgi?id=15362
          <rdar://problem/5558715> Safari Crashes when opening a JS TreeGrid widget

        Test: fast/dynamic/insert-before-table-part-in-continuation.html

        * rendering/RenderFlow.cpp:
        (WebCore::RenderFlow::addChildWithContinuation): If beforeChild's
        parent is an anonymous table part, let the table figure out where to
        insert the new child.


        Reviewed by Dave Hyatt.

        - test for http://bugs.webkit.org/show_bug.cgi?id=15362
          <rdar://problem/5558715> Safari Crashes when opening a JS TreeGrid widget

        * fast/dynamic/insert-before-table-part-in-continuation.html: Added.
        * platform/mac/fast/dynamic/insert-before-table-part-in-continuation-expected.checksum: Added.
        * platform/mac/fast/dynamic/insert-before-table-part-in-continuation-expected.png: Added.
        * platform/mac/fast/dynamic/insert-before-table-part-in-continuation-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-10-25 Alp Toker <alp@atoker.com>
alp [Thu, 25 Oct 2007 18:21:17 +0000 (18:21 +0000)]
2007-10-25  Alp Toker  <alp@atoker.com>

        Reviewed by Brady.

        GtkLauncher aborts on launch due to uninitialized threading subsystem

        Re-enable database support in the GTK+ port, with a fix.

        Initialize GLib threading as early as possible.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-10-25 Jon Honeycutt <jhoneycutt@apple.com>
honeycutt [Thu, 25 Oct 2007 17:35:18 +0000 (17:35 +0000)]
2007-10-25  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by Steve.

        <rdar://5548217>: [NTS] Java 6 update 3 crashes Safari when loading a
        java page

        Previous patch erroneously compared a path and a
        path-including-filename. This corrects that. It also caches the result
        of safariPluginsPath() and uses shell API funcs for determining filename
        and parent directory from a full path.

        * ChangeLog:
        * plugins/win/PluginDatabaseWin.cpp:
        (WebCore::safariPluginsPath): Cache return value. Use API functions to
        build the path
        (WebCore::PluginDatabaseWin::pluginForMIMEType): Compare again plugin's
        parent directory, not full path
        (WebCore::PluginDatabaseWin::pluginForExtension): Same
        * plugins/win/PluginPackageWin.cpp:
        (WebCore::PluginPackageWin::PluginPackageWin): Store parent directory
        * plugins/win/PluginPackageWin.h:
        * plugins/win/PluginStreamWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-10-25 Alp Toker <alp@atoker.com>
alp [Thu, 25 Oct 2007 15:00:55 +0000 (15:00 +0000)]
2007-10-25  Alp Toker  <alp@atoker.com>

        Unreviewed fix to make the GTK+ port run.

        GtkLauncher aborts on launch due to uninitialized threading subsystem

        [GTK] Make it possible to disable database support

        Disable database support until #15686 is fixed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFixed a crash in the Qt 4.4 based text iterators when they're called with a null...
hausmann [Thu, 25 Oct 2007 13:44:02 +0000 (13:44 +0000)]
Fixed a crash in the Qt 4.4 based text iterators when they're called with a null string.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago* We need to set a != 0 status code for the fast/loader/xmlhttprequest-missing-file...
hausmann [Thu, 25 Oct 2007 13:41:42 +0000 (13:41 +0000)]
* We need to set a != 0 status code for the fast/loader/xmlhttprequest-missing-file-exception.html
* libxml2 has the semantic that when writing an empty string and finishing it will report an error. For QXmlStreamReader this is valid.
* This is causing some regressions...

Signed-off-by: Simon Hausmann <hausmann@kde.org>
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago* Make fast/loader/xmlhttprequest-bad-mimetype.html pass. We use QHttp to download...
hausmann [Thu, 25 Oct 2007 13:41:33 +0000 (13:41 +0000)]
* Make fast/loader/xmlhttprequest-bad-mimetype.html pass. We use QHttp to download local files but we may not set the HTTP result code on the ResourceResponse.
* We can use the cross-platform result now. QWebNetworkInterface/Manager behaves the same as mac for local files.

Signed-off-by: Simon Hausmann <hausmann@kde.org>
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago* fast/dom/onerror-img.html regressed due checking the JobStates because in case...
hausmann [Thu, 25 Oct 2007 13:41:25 +0000 (13:41 +0000)]
* fast/dom/onerror-img.html regressed due checking the JobStates because in case of error (e.g. not being able to connect) the job will no be started.
* Use the error message from Qt. It might or might not be translated.

Signed-off-by: Simon Hausmann <hausmann@kde.org>
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago* Use the JobStatus to make sure to not deliver finished/data before the job has...
hausmann [Thu, 25 Oct 2007 13:41:16 +0000 (13:41 +0000)]
* Use the JobStatus to make sure to not deliver finished/data before the job has started. This is the case with the fast/dom/onerror-img.html test case.
* We have no idea if any data will come so we can still finish and then get pending data. This luckily can't happen for the local file case.

Signed-off-by: Simon Hausmann <hausmann@kde.org>
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago* No need to initialize values in the QWebNetworkJob c'tor
hausmann [Thu, 25 Oct 2007 13:41:08 +0000 (13:41 +0000)]
* No need to initialize values in the QWebNetworkJob c'tor
* Add a JobStatus to QWebNetworkJob and verify that the jobs are handled in the way we expect them to be handled. This means no data after the job has finished, not finishing a job before it has been started.

Signed-off-by: Simon Hausmann <hausmann@kde.org>
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago* Consistency: Always name the jobs job.
hausmann [Thu, 25 Oct 2007 13:41:01 +0000 (13:41 +0000)]
* Consistency: Always name the jobs job.

Signed-off-by: Simon Hausmann <hausmann@kde.org>
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago* Implement our own queuing of network jobs to allow special handling of synchronous...
hausmann [Thu, 25 Oct 2007 13:40:53 +0000 (13:40 +0000)]
* Implement our own queuing of network jobs to allow special handling of synchronous jobs. This makes us pass the fast/dom/xmlhttprequest-html-response-encoding.html test without a crash. Sync jobs will get a special treatment over the normals ones and in theory more than one sync job is supported.
* This should be thread-safe besides QWebNetworkJob::{ref,deref}

Signed-off-by: Simon Hausmann <hausmann@kde.org>
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago* Do the percent replacement only when we are not base64. With base64 we should not...
hausmann [Thu, 25 Oct 2007 13:40:42 +0000 (13:40 +0000)]
* Do the percent replacement only when we are not base64. With base64 we should not have any % in it anyway.
* Have a custom decodePercentEncoding method that works without doing any charset conversion. With converting back to latin1() we lost some information.
* We pass the char-decoding.html test now

Signed-off-by: Simon Hausmann <hausmann@kde.org>
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-10-25 Alp Toker <alp@atoker.com>
alp [Thu, 25 Oct 2007 12:36:54 +0000 (12:36 +0000)]
2007-10-25  Alp Toker  <alp@atoker.com>

        Reviewed by Mark Rowe.

        Add support for list box theme colors and styled menu list buttons.

        Remove obsolete FIXMEs.

        * platform/gtk/RenderThemeGtk.cpp:
        * platform/gtk/RenderThemeGtk.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoCorrected ChangeLog entry.
ap [Thu, 25 Oct 2007 11:55:17 +0000 (11:55 +0000)]
Corrected ChangeLog entry.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Rubber-stamped by Mark Rowe.
ap [Thu, 25 Oct 2007 11:53:59 +0000 (11:53 +0000)]
    Rubber-stamped by Mark Rowe.

        * images/download.png: Updated to say "Nightly builds" instead of
       "Nightly (6 MB)" - the Mac version is ~17 MB now, and this isn't a direct
       download link anyway.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoRoll out r27033 as it broke the JavaScriptCore tests.
mrowe@apple.com [Thu, 25 Oct 2007 11:36:25 +0000 (11:36 +0000)]
Roll out r27033 as it broke the JavaScriptCore tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoHackTop [30311:JavaScriptCore]% less ChangeLog ...
eseidel [Thu, 25 Oct 2007 09:59:10 +0000 (09:59 +0000)]
HackTop [30311:JavaScriptCore]% less ChangeLog                                        [/Stuff/Projects/WebKit/JavaScriptCore]
2007-10-25  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Roben.

        Start work on long-running-mode from the perl-script side of things.
        jsDriver.pl will likely be removed (and replaced by something better)
        But for now, I'm just hacking it down to something smaller.

        * tests/mozilla/jsDriver.pl: Remove lots of unused code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Eric Seidel.
ggaren [Thu, 25 Oct 2007 09:25:17 +0000 (09:25 +0000)]
    Reviewed by Eric Seidel.

        Slightly elaborated the differences between declaration procesing in
        Function Code and Program Code.

        .3% speedup on SunSpider.

        * kjs/nodes.cpp:
        (KJS::FunctionBodyNode::processDeclarationsProgramCode): Store a
        minimum set of attributes instead of recomputing all the time. Also,
        ignore m_parameters, since programs don't have arguments.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-10-25 Eric Seidel <eric@webkit.org>
eseidel [Thu, 25 Oct 2007 09:08:51 +0000 (09:08 +0000)]
2007-10-25  Eric Seidel  <eric@webkit.org>

        Reviewed by Maciej.

        More preparation work before adding long-running mode to testkjs.

        * kjs/testkjs.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoForgot to check in this file in r27019
aroben [Thu, 25 Oct 2007 08:53:15 +0000 (08:53 +0000)]
Forgot to check in this file in r27019

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-10-25 Eric Seidel <eric@webkit.org>
eseidel [Thu, 25 Oct 2007 08:37:23 +0000 (08:37 +0000)]
2007-10-25  Eric Seidel  <eric@webkit.org>

        Reviewed by Maciej.

        Bring testkjs code out of the dark ages in preparation for more
        radical improvements (like long-running testing support!)

        * kjs/testkjs.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej Stachowiak.
ggaren [Thu, 25 Oct 2007 08:11:31 +0000 (08:11 +0000)]
    Reviewed by Maciej Stachowiak.

        Make a fast path for declaration processing inside Function Code.

        Lifted declaration processing code up from individual declaration nodes
        and into processDeclarations.

        Broke out processDeclarations into two cases, depending on the type of
        code. This eliminates 2 branches, and facilitates more radical
        divergeance in the future.

        2.5% SunSpider speedup.

        * JavaScriptCore.xcodeproj/project.pbxproj:
        * kjs/nodes.cpp:
        * kjs/nodes.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam.
mjs [Thu, 25 Oct 2007 07:16:49 +0000 (07:16 +0000)]
    Reviewed by Adam.

        - add header includes needed on platforms that don't use AllInOneFile.cpp

        * API/JSCallbackObject.cpp:
        * kjs/Context.cpp:
        * kjs/ExecState.cpp:
        * kjs/array_instance.cpp:
        * kjs/function_object.cpp:
        * kjs/interpreter.cpp:
        * kjs/nodes.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-10-25 Eric Seidel <eric@webkit.org>
eseidel [Thu, 25 Oct 2007 07:14:59 +0000 (07:14 +0000)]
2007-10-25  Eric Seidel  <eric@webkit.org>

        Reviewed by Geoff.

        * JavaScriptCore.xcodeproj/project.pbxproj: re-mark JSGlobalObject.h as private

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoJavaScriptCore:
ggaren [Thu, 25 Oct 2007 07:09:44 +0000 (07:09 +0000)]

        Reviewed by Maciej Stachowiak.

        Fixed http://bugs.webkit.org/show_bug.cgi?id=15683
        Re-order declaration initialization to avoid calling hasProperty inside

        .7% speedup on SunSpider.

        * kjs/function.h:
        * kjs/function.cpp: Merged parameter processing into FunctionBodyNode's
        other processing of declared symbols, so the order of execution could

        * kjs/nodes.cpp:
        (KJS::VarDeclNode::getDeclarations): Added special case for the
        "arguments" property name, explained in the comment.

        (KJS::VarDeclNode::processDeclaration): Removed call to hasProperty
        in the case of function code, since we know the declared symbol
        management will resolve conflicts between symbols. Yay!

        (KJS::VarDeclListNode::getDeclarations): Now that VarDeclNode's
        implementation of getDeclarations is non-trivial, we can't take a
        short-cut here any longer -- we need to put the VarDecl node on the
        stack so it gets processed normally.

        (KJS::FunctionBodyNode::processDeclarations): Changed the order of
        processing to enforce mutual exclusion rules.

        * kjs/nodes.h:
        (KJS::DeclarationStacks::DeclarationStacks): Structure includes an
        ExecState now, for fast access to the "arguments" property name.


        Layout tests for bugs that might result from changes like

        * fast/js/vardecl-preserve-parameters-expected.txt: Added.
        * fast/js/vardecl-preserve-parameters.html: Added.
        * fast/js/vardecl-preserve-vardecl-expected.txt: Added.
        * fast/js/vardecl-preserve-vardecl.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27025 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-10-25 Eric Seidel <eric@webkit.org>
eseidel [Thu, 25 Oct 2007 07:08:38 +0000 (07:08 +0000)]
2007-10-25  Eric Seidel  <eric@webkit.org>

        Reviewed by Geoff.

        * bindings/js/kjs_window.h: fix bogus comment, s/DOMNode/DOMObject/

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-10-25 Eric Seidel <eric@webkit.org>
eseidel [Thu, 25 Oct 2007 07:07:06 +0000 (07:07 +0000)]
2007-10-25  Eric Seidel  <eric@webkit.org>

        Reviewed by Geoff.

        Make JSG build again after JSGlobalObject change.

        * JSRun.cpp:
        * JSRun.h:
        * JSUtils.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-10-24 Eric Seidel <eric@webkit.org>
eseidel [Thu, 25 Oct 2007 06:38:35 +0000 (06:38 +0000)]
2007-10-24  Eric Seidel  <eric@webkit.org>

        Reviewed by Maciej.

        Add a JSGlobalObject class and remove the InterpreterMap

        This required making JSCallbackObject a template class to allow for
        JSGlobalObjects with JSCallbackObject functionality.

        SunSpider claims this was a 0.5% speedup.

        * API/JSCallbackObject.cpp:
        * API/JSCallbackObject.h:
        * API/JSCallbackObjectFunctions.h: Copied from API/JSCallbackObject.cpp.
        * API/JSClassRef.cpp:
        * API/JSContextRef.cpp:
        * API/JSObjectRef.cpp:
        * API/JSValueRef.cpp:
        * JavaScriptCore.exp:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * bindings/c/c_utility.cpp:
        * bindings/jni/jni_jsobject.cpp:
        * bindings/objc/objc_utility.mm:
        * kjs/Context.cpp:
        * kjs/ExecState.cpp:
        * kjs/JSGlobalObject.h: Added.
        * kjs/array_instance.cpp:
        * kjs/context.h:
        * kjs/function.cpp:
        * kjs/interpreter.cpp:
        * kjs/interpreter.h:
        * kjs/lookup.h:
        * kjs/object.h:
        * kjs/testkjs.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agounbreak Qt build
staikos [Thu, 25 Oct 2007 05:33:22 +0000 (05:33 +0000)]
unbreak Qt build

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix <rdar://5549919> Add font database initialization code to WebCore and call it...
aroben [Thu, 25 Oct 2007 05:23:20 +0000 (05:23 +0000)]
 Fix <rdar://5549919> Add font database initialization code to WebCore and call it from WebKit


         Add font database initialization code to WebCore

         Reviewed by Ada.

         * WebCore.vcproj/WebCore.vcproj: Added FontDatabase.{cpp,h}.
         * platform/win/FontDatabase.cpp: Added.
         (WebCore::populateFontDatabase): This is the only function callable
         from outside this file. It populates the font database once, either
         from the fonts plist, or from the filesystem (and then saves a new
         fonts plist).
         * platform/win/FontDatabase.h: Added.


         Remove now-unnecessary call to InitializeCoreGraphics

         WebKit takes care of this now.

         Reviewed by Ada.

         * DumpRenderTree/win/DumpRenderTree.cpp:


         Fix <rdar://5549919> Initialize the font database before any font code is invoked

         We initialize the database in two places:
            1. When instantiating WebKitClassFactory, which is guaranteed to
            happen before any WebView is instantiated.
            2. When making a WebCore::Font in WebKitGraphics.

         This ensures that the font database will be populated before any font
         code is invoked. We rely on WebCore to only populate the database

         Reviewed by Ada.

         * WebKitClassFactory.cpp:
         (WebKitClassFactory::WebKitClassFactory): Populate the font database.
         * WebKitGraphics.cpp:
         (makeFont): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Add [I]WebTextRenderer
aroben [Thu, 25 Oct 2007 05:22:56 +0000 (05:22 +0000)]
 Add [I]WebTextRenderer


         Use WebTextRenderer in DRT

         Reviewed by Ada.

         * DumpRenderTree/win/DumpRenderTree.cpp:
         (initialize): Use WebTextRenderer instead of using


         Add [I]WebTextRenderer

         Right now this class can only be used to add private fonts for use by
         the running process, but will eventually be the home of the
         WebKitGraphics functions.

         Reviewed by Ada.

         * ForEachCoClass.h: Added WebTextRenderer.
         * Interfaces/WebKit.idl: Ditto.
         * WebKit.vcproj/Interfaces.vcproj: Ditto.
         * WebKit.vcproj/WebKit.vcproj: Ditto.
         * WebKit.vcproj/WebKitGUID.vcproj: Ditto.
         * WebKitClassFactory.cpp: Ditto.
         * WebTextRenderer.cpp: Added.
         * WebTextRenderer.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Use FOR_EACH_COCLASS in WebKitClassFactory
aroben [Thu, 25 Oct 2007 05:22:30 +0000 (05:22 +0000)]
     Use FOR_EACH_COCLASS in WebKitClassFactory

         Reviewed by Ada.

         * WebError.cpp:
         (WebError::createInstance): Added an overload that takes no arguments
         to make the macro used in WebKitClassFactory work.
         * WebError.h:
         * WebKitClassFactory.cpp:
         (WebKitClassFactory::CreateInstance): Use FOR_EACH_COCLASS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Put FOR_EACH_COCLASS macro into its own file and export it
aroben [Thu, 25 Oct 2007 05:22:03 +0000 (05:22 +0000)]
     Put FOR_EACH_COCLASS macro into its own file and export it

         The macro used to be called FOR_EACH_CLASS and lived in WebKitDLL.cpp.
         This way we will be able to use the macro in more places that care
         about all WebKit's COM classes.

         Reviewed by Ada.

         * ForEachCoClass.h: Added.
         * WebKit.vcproj/WebKit.vcproj: Copy ForEachCoClass.h to
         WebKitOutputDir, and added it to the project.
         * WebKitDLL.cpp: Updated for macro rename, and changed to #undef the
         macros we pass to FOR_EACH_COCLASS after we're done with them.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Added some font-related functions needed for <rdar://5549919>
aroben [Thu, 25 Oct 2007 05:20:32 +0000 (05:20 +0000)]
     Added some font-related functions needed for <rdar://5549919>

         Reviewed by Ada.

         * win/include/WebKitSystemInterface/WebKitSystemInterface.h:
         * win/lib/WebKitSystemInterface.lib:
         * win/lib/WebKitSystemInterface_debug.lib:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27016 268f45cc-cd09-0410-ab3c-d52691b4dbfc