WebKit-https.git
13 years ago2009-04-02 Pamela Greene <pam@chromium.org>
pam@chromium.org [Thu, 2 Apr 2009 21:58:19 +0000 (21:58 +0000)]
2009-04-02  Pamela Greene  <pam@chromium.org>

        Reviewed by Darin Adler.

        Split no-port test case into separate file, since its result may
        depend on the behavior of a DNS proxy on some systems.
        https://bugs.webkit.org/show_bug.cgi?id=21530

        * platform/mac-tiger/security/block-test-expected.txt: updated
        * platform/mac-tiger/security/block-test-no-port-expected.txt: Added.
        * platform/mac/security/block-test-expected.txt: updated
        * platform/mac/security/block-test-no-port-expected.txt: Added.
        * security/block-test-no-port.html: Added.
        * security/block-test.html: removed no-port test case

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-04-02 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 2 Apr 2009 21:48:16 +0000 (21:48 +0000)]
2009-04-02  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Timothy Hatcher.

        https://bugs.webkit.org/show_bug.cgi?id=25010
        Refactor InspectorController to replace all JS function invocations with
        ScriptFunctionCall.

        * bindings/js/ScriptFunctionCall.cpp:
        (WebCore::ScriptFunctionCall::appendArgument): Added int, UString,
            and JSValuePtr methods.
        (WebCore::ScriptFunctionCall::call): Added simplified, exception-eating
            method.
        * bindings/js/ScriptFunctionCall.h: Decls for above.
        * bindings/js/ScriptObjectQuarantine.cpp: Added helper for Node and DOMWindow.
        (WebCore::getQuarantinedScriptObject):
        * bindings/js/ScriptObjectQuarantine.h: Decls for above.
        * inspector/InspectorController.cpp:
        (WebCore::callSimpleFunction): Made into a static.
        (WebCore::InspectorController::focusNode): Refactored to use ScriptFunctionCall.
        (WebCore::InspectorController::toggleRecordButton): Ditto.
        (WebCore::InspectorController::startGroup): Ditto.
        (WebCore::InspectorController::setAttachedWindow): Ditto.
        (WebCore::InspectorController::inspectedWindowScriptObjectCleared): Ditto.
        (WebCore::InspectorController::addScriptProfile): Ditto.
        (WebCore::InspectorController::didParseSource): Ditto.
        (WebCore::InspectorController::failedToParseSource): Ditto.
        (WebCore::InspectorController::didPause): Ditto.
        * inspector/InspectorController.h: Removed callFunction and callSimpleFunction
            decls.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-04-02 Jian Li <jianli@chromium.org>
dimich@chromium.org [Thu, 2 Apr 2009 21:30:01 +0000 (21:30 +0000)]
2009-04-02  Jian Li  <jianli@chromium.org>

        Reviewed by Darin Fisher.

        Upstream changes to V8WorkerContextEventListener for V8 bindings.
        https://bugs.webkit.org/show_bug.cgi?id=25007

        * bindings/v8/V8ObjectEventListener.h:
        * bindings/v8/V8WorkerContextEventListener.h:
        * bindings/v8/V8WorkerContextEventListener.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-04-02 Jian Li <jianli@chromium.org>
dimich@chromium.org [Thu, 2 Apr 2009 21:29:52 +0000 (21:29 +0000)]
2009-04-02  Jian Li  <jianli@chromium.org>

        Reviewed by Darin Fisher.

        Upstream V8WorkerContextObjectEventListener for V8 bindings.
        https://bugs.webkit.org/show_bug.cgi?id=25005

        * bindings/v8/V8WorkerContextObjectEventListener.cpp: Added.
        * bindings/v8/V8WorkerContextObjectEventListener.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-04-02 Jian Li <jianli@chromium.org>
dimich@chromium.org [Thu, 2 Apr 2009 21:29:44 +0000 (21:29 +0000)]
2009-04-02  Jian Li  <jianli@chromium.org>

        Reviewed by Darin Fisher.

        Upstream V8EventListenerList for V8 bindings.
        https://bugs.webkit.org/show_bug.cgi?id=25004

        * bindings/v8/V8EventListenerList.cpp: Added.
        * bindings/v8/V8EventListenerList.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Build fix for Windows machines that don't have WebKitTools/Scipts in their...
aroben@apple.com [Thu, 2 Apr 2009 20:45:56 +0000 (20:45 +0000)]
    Build fix for Windows machines that don't have WebKitTools/Scipts in their PATH

        * Scripts/pdevenv: Add WebKitTools/Scripts to PATH when launching
        Visual Studio/VC++ Express.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Use pdevenv when building .vcproj files via our scripts
aroben@apple.com [Thu, 2 Apr 2009 20:31:58 +0000 (20:31 +0000)]
    Use pdevenv when building .vcproj files via our scripts

        Reviewed by Mark Rowe.

        * Scripts/webkitdirs.pm:
        (sub buildVisualStudioProject): Use pdevenv instead of invoking Visual
        Studio/VC++ Express directly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix release build bustage.
hyatt@apple.com [Thu, 2 Apr 2009 20:22:26 +0000 (20:22 +0000)]
Fix release build bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-04-02 Michael Nordman <michaeln@google.com>
darin@chromium.org [Thu, 2 Apr 2009 20:00:15 +0000 (20:00 +0000)]
2009-04-02  Michael Nordman  <michaeln@google.com>

        Reviewed by Darin Fisher.

        Chromium's ResourceRequest and ResourceResponse structs need some new data members.
        https://bugs.webkit.org/show_bug.cgi?id=24897

        These fields are needed to facilitate Chromium's implementation of the HTML5
        ApplicationCache feature. We need to know what frame (or context) is doing the
        requesting, and from what cache the resulting resource was retrieved.

        No change in functionality, so no tests.

        * platform/network/chromium/ResourceRequest.h:
        (WebCore::ResourceRequest::ResourceRequest):
        (WebCore::ResourceRequest::appCacheContextID):
        (WebCore::ResourceRequest::setAppCacheContextID):
        * platform/network/chromium/ResourceResponse.h:
        (WebCore::ResourceResponse::ResourceResponse):
        (WebCore::ResourceResponse::getAppCacheID):
        (WebCore::ResourceResponse::setAppCacheID):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
hyatt@apple.com [Thu, 2 Apr 2009 19:57:47 +0000 (19:57 +0000)]
WebCore:

2009-04-02  David Hyatt  <hyatt@apple.com>

        Reviewed by Darin Adler

        Fix for https://bugs.webkit.org/show_bug.cgi?id=24643.

        Make sure images just ignore HTTP error codes and keep loading anyway.  Only <object> checks http error codes and falls back.  Everyone
        else just ignores it and displays the image anyway.

        Added http/tests/misc/image-error.html

        * html/HTMLImageLoader.cpp:
        (WebCore::HTMLImageLoader::notifyFinished):
        * loader/CachedImage.cpp:
        (WebCore::CachedImage::CachedImage):
        * loader/CachedImage.h:
        (WebCore::CachedImage::httpStatusCodeError):
        (WebCore::CachedImage::httpStatusCodeErrorOccurred):
        * loader/CachedResource.h:
        (WebCore::CachedResource::httpStatusCodeError):
        * loader/loader.cpp:
        (WebCore::Loader::Host::didReceiveData):

LayoutTests:

2009-04-02  David Hyatt  <hyatt@apple.com>

        Reviewed by Darin Adler

        Add test for https://bugs.webkit.org/show_bug.cgi?id=24643

        * http/tests/misc/image-error-expected.txt: Added.
        * http/tests/misc/image-error.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-04-02 Jian Li <jianli@chromium.org>
dimich@chromium.org [Thu, 2 Apr 2009 18:42:28 +0000 (18:42 +0000)]
2009-04-02  Jian Li  <jianli@chromium.org>

        Reviewed by Dimitri Glazkov.

        Add XHR constructor in WorkerContext.idl for V8 bindings.
        https://bugs.webkit.org/show_bug.cgi?id=24962

        * workers/WorkerContext.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-04-02 Pamela Greene <pam@chromium.org>
pam@chromium.org [Thu, 2 Apr 2009 18:22:22 +0000 (18:22 +0000)]
2009-04-02  Pamela Greene  <pam@chromium.org>

        Reviewed by Darin Adler.

        Split long-running regexp out of the main regexp-overflow test file
        so VMs (such as V8) that don't limit execution time can still run
        the rest of the test cases.
        https://bugs.webkit.org/show_bug.cgi?id=18327

        * fast/js/regexp-overflow-expected.txt: updated
        * fast/js/regexp-overflow-too-big-expected.txt: Added.
        * fast/js/regexp-overflow-too-big.html: Added.
        * fast/js/resources/regexp-overflow-too-big.js: Added.
        * fast/js/resources/regexp-overflow.js: removed one test case

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-04-02 Pamela Greene <pam@chromium.org>
pam@chromium.org [Thu, 2 Apr 2009 18:18:40 +0000 (18:18 +0000)]
2009-04-02  Pamela Greene  <pam@chromium.org>

        Reviewed by Darin Adler.

        Minor cleanup: remove unneeded "toLower" on typeof.

        * fast/dom/Window/window-lookup-precedence.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-04-01 Ben Murdoch <benm@google.com>
aroben@apple.com [Thu, 2 Apr 2009 17:30:21 +0000 (17:30 +0000)]
2009-04-01  Ben Murdoch  <benm@google.com>

        Fix Bug 19743: Release build fails on 32-bit Windows

        <https://bugs.webkit.org/show_bug.cgi?id=19743>

        Combines all the HTML element cpp files into one to help reduce the
        size of WebCore.lib so we can build in release mode on 32bit Windows.

        Reviewed by Adam Roben.

        * WebCore.vcproj/WebCore.vcproj: Excluded all the separate
        HTML*Element.cpp files from the build. Added HTMLElementsAllInOne.cpp
        to the build.
        * html/HTMLElementsAllInOne.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-04-02 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 2 Apr 2009 16:47:38 +0000 (16:47 +0000)]
2009-04-02  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler

        https://bugs.webkit.org/show_bug.cgi?id=24999

        Optimize hit testing with transforms.

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::mapLocalToContainer):
        (WebCore::RenderBox::mapAbsoluteToLocalPoint):
        getTransformFromContainer() change to return the matrix by reference.

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::update3DTransformedDescendantStatus):
        The method failed to set m_3DTransformedDescendantStatusDirty to false,
        so did the work every time.

        (WebCore::RenderLayer::createLocalTransformState):
        Only call the expensive getTransformFromContainer() if there is a transform,
        otherwise we just have a translation.

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::getTransformFromContainer):
        * rendering/RenderObject.h:
        Change transformFromContainer() to getTransformFromContainer(), and return
        the matrix by reference to reduce copying.
        New enum values for arguments for readability.

        * rendering/TransformState.cpp:
        (WebCore::TransformState::move):
        (WebCore::TransformState::applyTransform):
        (WebCore::HitTestingTransformState::translate):
        New method that adds a translation to the accumulated matrix, optionally
        without flattening. Cheaper than applyTransform().

        (WebCore::HitTestingTransformState::applyTransform):
        (WebCore::HitTestingTransformState::flatten):
        (WebCore::HitTestingTransformState::flattenWithTransform):
        Add flattenWithTransform(), which is a helper that allows us to
        avoid doing the inverse() twice.

        * rendering/TransformState.h:
        (WebCore::TransformState::):
        (WebCore::TransformState::move):
        (WebCore::HitTestingTransformState::):
        New method on HitTestingTransformState that adds a translation to the
        accumulated matrix, optionally without flattening. Cheaper than applyTransform().
        New enum values for arguments for readability.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-04-02 Darin Adler <darin@apple.com>
darin@apple.com [Thu, 2 Apr 2009 16:35:15 +0000 (16:35 +0000)]
2009-04-02  Darin Adler  <darin@apple.com>

        Reviewed by Kevin Decker.

        <rdar://problem/6744471> crash in GC due to uninitialized callFunction pointer

        * runtime/JSGlobalObject.h:
        (JSC::JSGlobalObject::JSGlobalObjectData::JSGlobalObjectData): Initialize
        callFunction as we do the other data members that are used in the mark function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42173 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-04-02 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 2 Apr 2009 16:25:18 +0000 (16:25 +0000)]
2009-04-02  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein

        https://bugs.webkit.org/show_bug.cgi?id=24648

        Optimize common code paths in TransformationMatrix.

        * platform/graphics/transforms/TransformationMatrix.cpp:
        (WebCore::TransformationMatrix::translate):
        (WebCore::TransformationMatrix::translate3d):
        Optimize to avoid matrix copy.

        (WebCore::TransformationMatrix::isInvertible):
        Test for identity and translation matrices before computing
        the determinant.

        (WebCore::TransformationMatrix::inverse):
        Optimize for identity matrix and translations.

        * platform/graphics/transforms/TransformationMatrix.h:
        (WebCore::TransformationMatrix::isIdentityOrTranslation):
        Utility method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-04-02 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Thu, 2 Apr 2009 16:01:14 +0000 (16:01 +0000)]
2009-04-02  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=24930
        [Gtk] ISO files content is displayed inside the webview instead of being downloaded

        Also sniff content of types declared as text/plain. This is
        justified by the fact that it is common to have Apache HTTP
        servers configured to send text/plain as Content-Type by default.

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::gotHeadersCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-04-02 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Thu, 2 Apr 2009 16:00:55 +0000 (16:00 +0000)]
2009-04-02  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Alexey Proskuryakov.

        Protect the handle when notifying the client that the response was
        received also in gotChunkCallback, or we crash in didReceiveData
        when the load is cancelled in didReceiveResponse.

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::gotChunkCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-04-02 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Thu, 2 Apr 2009 15:50:37 +0000 (15:50 +0000)]
2009-04-02  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Alexey  Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=24844
        Unit test WebKitDownload

        Extra checks to avoid crashing and a critical message when
        property accessor functions are called before the download is
        started.

        * webkit/webkitdownload.cpp:
        (_WebKitDownloadPrivate::webkit_download_get_progress):
        (_WebKitDownloadPrivate::webkit_download_get_elapsed_time):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-04-02 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Thu, 2 Apr 2009 15:42:28 +0000 (15:42 +0000)]
2009-04-02  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=25001
        Crash when content type parameters have no value

        Handle the case where a Content-Type header parameter has no
        value (i.e. no = character), to work-around a bug in libsoup.

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::fillResponseFromMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
hausmann@webkit.org [Thu, 2 Apr 2009 10:29:24 +0000 (10:29 +0000)]
JavaScriptCore:
    2009-04-02  Yael Aharon  <yael.aharon@nokia.com>

            Reviewed by Simon Hausmann

            https://bugs.webkit.org/show_bug.cgi?id=24490

            Implement WTF::ThreadSpecific in the Qt build using
            QThreadStorage.
WebCore:

    2009-04-02  Yael Aharon  <yael.aharon@nokia.com>

            Reviewed by Simon Hausmann.

            https://bugs.webkit.org/show_bug.cgi?id=24490

            Enable web workers in Qt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix the Qt build
hausmann@webkit.org [Thu, 2 Apr 2009 07:54:58 +0000 (07:54 +0000)]
Fix the Qt build

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-04-02 Takumi Asaki <takumi.asaki@nokia.com>
hausmann@webkit.org [Thu, 2 Apr 2009 07:54:48 +0000 (07:54 +0000)]
2009-04-02  Takumi Asaki <takumi.asaki@nokia.com>

        Reviewed by Simon Hausmann.

        Fix pre-edit handling of text fields with input methods.

        The input method sends an empty preeditString() if all characters of
        the preedit should be deleted. So inputMethodEvent() has to use
        preeditString() if it's empty.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin Adler. Based on work of Julien Chaffraix.
ap@webkit.org [Thu, 2 Apr 2009 07:12:22 +0000 (07:12 +0000)]
    Reviewed by Darin Adler. Based on work of Julien Chaffraix.

        https://bugs.webkit.org/show_bug.cgi?id=22475
        REGRESSION: Async XMLHttpRequest never finishes on nonexistent files anymore

        https://bugs.webkit.org/show_bug.cgi?id=24886
        XHR requests opened when offline never return

WebCore:
        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::callReadyStateChangeListener): Only dispatch load event if this
        wasn't an error.
        (WebCore::XMLHttpRequest::abort): Fixed formatting.
        (WebCore::XMLHttpRequest::genericError): Change state to DONE and dispatch readystatechange.
        The comment saying that this doesn't match Firefox was added in r33559 without explanation
        or tests, and I don't think that it's accurate. Also, Firefox and Safari 3 both change state
        to HEADERS_RECEIVED before DONE on error - this doesn't match the spec, and I doubt
        that any code depends on this, so I went with the spec here.

LayoutTests:
        * fast/loader/xmlhttprequest-missing-file-exception-expected.txt: Removed.
        * fast/loader/xmlhttprequest-missing-file-exception.html: Removed.
        * http/tests/xmlhttprequest/state-after-network-error-expected.txt: Added.
        * http/tests/xmlhttprequest/state-after-network-error.html: Added.
        Added tests for these issues.

        * http/tests/xmlhttprequest/frame-load-cancelled-abort-expected.txt: As with other errors,
        the request now reaches DONE state now. This makes the results closer to Firefox again
        (they changed multiple times recently).
        * http/tests/xmlhttprequest/resources/frame-load-to-cancel.html: Firefox dispatches
        cancellation events at a later point, when window.parent is already undefined. Changed
        the test to log all events, making the difference with Firefox less confusing.

        * http/tests/xmlhttprequest/simple-cross-origin-progress-events.html: Fixed a mistake in
        the test, which could call a non-existent function in some code paths.

        * http/tests/xmlhttprequest/xmlhttprequest-unsafe-redirect-expected.txt: State now reaches
        DONE on cross-origin check failure, as it should per the spec. This matches Firefox in async
        case (and in sync case, it simply doesn't dispatch any onreadystatechange events, not sure why).

        * fast/dom/null-document-xmlhttprequest-open-expected.txt: Removed.
        * fast/dom/null-document-xmlhttprequest-open.html: Removed.
        * fast/dom/resources/1251.html: Removed.
        * fast/dom/resources/xmlhttprequest-get-data.xml: Removed.
        * fast/dom/xmlhttprequest-gc-expected.txt: Removed.
        * fast/dom/xmlhttprequest-gc.html: Removed.
        * fast/dom/xmlhttprequest-get-expected.txt: Removed.
        * fast/dom/xmlhttprequest-get.xhtml: Removed.
        * fast/dom/xmlhttprequest-html-response-encoding-expected.txt: Removed.
        * fast/dom/xmlhttprequest-html-response-encoding.html: Removed.
        * fast/dom/xmlhttprequest-invalid-values-expected.txt: Removed.
        * fast/dom/xmlhttprequest-invalid-values.html: Removed.
        * fast/loader/resources/plist.app: Removed.
        * fast/loader/xmlhttprequest-bad-mimetype-expected.txt: Removed.
        * fast/loader/xmlhttprequest-bad-mimetype.html: Removed.
        * fast/xmlhttprequest: Added.
        * fast/xmlhttprequest/null-document-xmlhttprequest-open-expected.txt: Copied from LayoutTests/fast/dom/null-document-xmlhttprequest-open-expected.txt.
        * fast/xmlhttprequest/null-document-xmlhttprequest-open.html: Copied from LayoutTests/fast/dom/null-document-xmlhttprequest-open.html.
        * fast/xmlhttprequest/resources: Added.
        * fast/xmlhttprequest/resources/1251.html: Copied from LayoutTests/fast/dom/resources/1251.html.
        * fast/xmlhttprequest/resources/plist.app: Copied from LayoutTests/fast/loader/resources/plist.app.
        * fast/xmlhttprequest/resources/xmlhttprequest-get-data.xml: Copied from LayoutTests/fast/dom/resources/xmlhttprequest-get-data.xml.
        * fast/xmlhttprequest/xmlhttprequest-bad-mimetype-expected.txt: Copied from LayoutTests/fast/loader/xmlhttprequest-bad-mimetype-expected.txt.
        * fast/xmlhttprequest/xmlhttprequest-bad-mimetype.html: Copied from LayoutTests/fast/loader/xmlhttprequest-bad-mimetype.html.
        * fast/xmlhttprequest/xmlhttprequest-gc-expected.txt: Copied from LayoutTests/fast/dom/xmlhttprequest-gc-expected.txt.
        * fast/xmlhttprequest/xmlhttprequest-gc.html: Copied from LayoutTests/fast/dom/xmlhttprequest-gc.html.
        * fast/xmlhttprequest/xmlhttprequest-get-expected.txt: Copied from LayoutTests/fast/dom/xmlhttprequest-get-expected.txt.
        * fast/xmlhttprequest/xmlhttprequest-get.xhtml: Copied from LayoutTests/fast/dom/xmlhttprequest-get.xhtml.
        * fast/xmlhttprequest/xmlhttprequest-html-response-encoding-expected.txt: Copied from LayoutTests/fast/dom/xmlhttprequest-html-response-encoding-expected.txt.
        * fast/xmlhttprequest/xmlhttprequest-html-response-encoding.html: Copied from LayoutTests/fast/dom/xmlhttprequest-html-response-encoding.html.
        * fast/xmlhttprequest/xmlhttprequest-invalid-values-expected.txt: Copied from LayoutTests/fast/dom/xmlhttprequest-invalid-values-expected.txt.
        * fast/xmlhttprequest/xmlhttprequest-invalid-values.html: Copied from LayoutTests/fast/dom/xmlhttprequest-invalid-values.html.
        * fast/xmlhttprequest/xmlhttprequest-missing-file-exception-expected.txt: Copied from LayoutTests/fast/loader/xmlhttprequest-missing-file-exception-expected.txt.
        * fast/xmlhttprequest/xmlhttprequest-missing-file-exception.html: Copied from LayoutTests/fast/loader/xmlhttprequest-missing-file-exception.html.
        * fast/xmlhttprequest/xmlhttprequest-nonexistent-file-expected.txt: Added.
        * fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html: Added.
        * platform/gtk/Skipped:
        Moved non-HTTP XMLHttpRequest tests to fast/xmlhttprequest.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago https://bugs.webkit.org/show_bug.cgi?id=24997
sfalken@apple.com [Thu, 2 Apr 2009 04:51:53 +0000 (04:51 +0000)]
    https://bugs.webkit.org/show_bug.cgi?id=24997
        Race conditions in icon database threading code

        m_syncThreadRunning set was mistakenly eliminated in r27717.
        This reintroduces it.

        Reviewed by Oliver Hunt.

        * loader/icon/IconDatabase.cpp:
        (WebCore::IconDatabase::open): Set m_syncThreadRunning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWindows support for built-product-archive.
mrowe@apple.com [Thu, 2 Apr 2009 02:58:14 +0000 (02:58 +0000)]
Windows support for built-product-archive.

* BuildSlaveSupport/built-product-archive:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-04-01 Antti Koivisto <antti@apple.com>
antti@apple.com [Thu, 2 Apr 2009 01:20:01 +0000 (01:20 +0000)]
2009-04-01  Antti Koivisto  <antti@apple.com>

        Reviewed by Darin Adler.

        <rdar://problem/6748609> Use ActiveDOMObject to suspend marquees

        Make marquees ActiveDOMObjects, get rid of the special suspension code.

        * html/HTMLMarqueeElement.cpp:
        (WebCore::HTMLMarqueeElement::HTMLMarqueeElement):
        (WebCore::HTMLMarqueeElement::canSuspend):
        (WebCore::HTMLMarqueeElement::suspend):
        (WebCore::HTMLMarqueeElement::resume):
        * html/HTMLMarqueeElement.h:
        * page/Frame.cpp:
        (WebCore::Frame::clearTimers):
        * rendering/RenderLayer.cpp:
        * rendering/RenderLayer.h:
        (WebCore::RenderLayer::marquee):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42161 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-04-01 Dean Jackson <dino@apple.com>
dino@apple.com [Thu, 2 Apr 2009 01:10:32 +0000 (01:10 +0000)]
2009-04-01  Dean Jackson  <dino@apple.com>

        Reviewed by Darin Adler

        Make constant values static in previous commit, as suggested
        by Darin.

        * rendering/RenderVideo.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-04-01 Dean Jackson <dino@apple.com>
dino@apple.com [Thu, 2 Apr 2009 00:57:29 +0000 (00:57 +0000)]
2009-04-01  Dean Jackson  <dino@apple.com>

        Reviewed by Simon Fraser

        https://bugs.webkit.org/show_bug.cgi?id=24993

        Standalone media should have a smaller instrinsic
        height.

        * rendering/RenderVideo.cpp:
        (WebCore::RenderVideo::RenderVideo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
darin@apple.com [Thu, 2 Apr 2009 00:30:50 +0000 (00:30 +0000)]
WebCore:

2009-04-01  Darin Adler  <darin@apple.com>

        Reviewed by Geoff Garen.

        Bug 22378: Crash submitting a form when parsing an XHTML document
        https://bugs.webkit.org/show_bug.cgi?id=22378
        rdar://problem/6388377

        Tests: fast/loader/submit-form-while-parsing-1.xhtml
               fast/loader/submit-form-while-parsing-2.html

        * WebCore.base.exp: Updated.

        * history/HistoryItem.cpp:
        (WebCore::HistoryItem::HistoryItem): Renamed m_subItems to m_children.
        Used uncheckedAppend because we reserveInitialCapacity.
        (WebCore::HistoryItem::addChildItem): Renamed m_subItems to m_children.
        Added an assertion that this is only used to add items that don't have
        duplicate frame names.
        (WebCore::HistoryItem::setChildItem): Added. Replaces an existing item
        if any, preserving the isTargetItem flag.
        (WebCore::HistoryItem::childItemWithTarget): Renamed from childItemWithName
        for consistency with the other functions here that all call the frame name the
        "target". Also updated for rename of m_subItems to m_children.
        (WebCore::HistoryItem::findTargetItem): Renamed from recurseToFindTargetItem.
        Removed unneeded size check.
        (WebCore::HistoryItem::targetItem): Changed to always return the top item
        if no item has the isTargetItem flag set. The old version would instead return
        0 in some cases, but return the top item if it had no children.
        (WebCore::HistoryItem::children): Renamed m_subItems to m_children.
        (WebCore::HistoryItem::hasChildren): Ditto.
        (WebCore::HistoryItem::showTreeWithIndent): Ditto.

        * history/HistoryItem.h: Name changes.

        * html/HTMLFormElement.cpp:
        (WebCore::HTMLFormElement::submit): Create and pass a FormState instead of
        attaching "recorded form values" and "form about to be submitted" to the frame
        loader. Parameter work fine for this; there's no need to store state on the
        FrameLoader.

        * loader/FormState.cpp:
        (WebCore::FormState::FormState): Adopt a vector instead of copying a hash map.
        (WebCore::FormState::create): Ditto.
        * loader/FormState.h: Update to use a vector that we adopt instead of hash map
        that we copy for auto-fill text field values.

        * loader/FrameLoader.cpp:
        (WebCore::ScheduledRedirection::ScheduledRedirection): Added a new case for
        form submissions and turned the "wasDuringLoad" state into a separate boolean
        instead of using a special redirection type to track it.
        (WebCore::FrameLoader::createWindow): Updated for name and argument change of
        loadFrameRequest.
        (WebCore::FrameLoader::urlSelected): Ditto.
        (WebCore::FrameLoader::submitForm): Removed the "deferred form submission"
        machinery, replacing it with the "scheduled redirection" mechanism, shared
        with other kinds of redirection and navigation. Moved frame targeting here
        so we can schedule the redirection on the right frame. Moved the multiple
        form submission protection here. Moved the code to implement the rule that
        m_navigationDuringLoad was used for here too.
        (WebCore::FrameLoader::didOpenURL): Use the new wasDuringLoad flag instead
        of the locationChangeDuringLoad type to detect location change during a load.
        (WebCore::FrameLoader::executeScript): Removed call to now-obsolete function,
        submitFormAgain.
        (WebCore::FrameLoader::scheduleLocationChange): Moved the code to stop loading
        out of this function into scheduleRedirection, so it can be shared with the
        new scheduleFormSubmission function.
        (WebCore::FrameLoader::scheduleFormSubmission): Added. Almost the same as
        scheduleLocationChange, but with the arguments for a form submission.
        (WebCore::FrameLoader::scheduleRefresh): Updated for the change to the
        duringLoad flag.
        (WebCore::FrameLoader::isLocationChange): Added case for formSubmission
        and removed case for locationChangeDuringLoad.
        (WebCore::FrameLoader::redirectionTimerFired): Ditto. Also removed unneeded
        completeURL call and just use KURL constructor to match the other cases.
        (WebCore::FrameLoader::provisionalLoadStarted): Removed the code to set up
        the m_navigationDuringLoad, which is no longer needed. The new version of
        this is in the submitForm function and sets the lockHistory boolean.
        (WebCore::FrameLoader::scheduleRedirection): Moved the code to stop a load
        in here that used to be in scheduleLocationChange.
        (WebCore::FrameLoader::startRedirectionTimer): Added case for formSubmission
        and removed case for locationChangeDuringLoad.
        (WebCore::FrameLoader::stopRedirectionTimer): Ditto.
        (WebCore::FrameLoader::completed): Removed call to now-obsolete function,
        submitFormAgain.
        (WebCore::FrameLoader::loadFrameRequest): Renamed from
        loadFrameRequestWithFormAndValues. Replaced form element and form values
        argument with a single FormState argument. Changed frame targeting code
        to use the source frame in the case of a form submission to better match
        the actual target frame.
        (WebCore::FrameLoader::loadURL): Don't search for existing frames in the
        form submission case since we already did that in the submitForm function.
        (WebCore::FrameLoader::clientRedirected): Changed to work with the
        m_isExecutingJavaScriptFormAction data member directly instead of taking
        it as a function parameter.
        (WebCore::FrameLoader::loadPostRequest): Don't search for existing frames
        in the form submission case since we already did that in the submitForm
        function.
        (WebCore::FrameLoader::addBackForwardItemClippedAtTarget): Moved comment
        in here that was misplaced elsewhere in the file.
        (WebCore::FrameLoader::findFrameForNavigation): Changed to use the early
        return idiom.
        (WebCore::FrameLoader::recursiveGoToItem): Updated for HistoryItem changes.
        (WebCore::FrameLoader::childFramesMatchItem): Ditto.
        (WebCore::FrameLoader::updateHistoryForStandardLoad): Removed the
        m_navigationDuringLoad logic; that's now handled by setting lockHistory
        to true in the submitForm function.
        (WebCore::FrameLoader::updateHistoryForRedirectWithLockedBackForwardList):
        Use the new setChildItem function so we don't get multiple items for the
        same frame name in the history item tree in the back/forward list.

        * loader/FrameLoader.h: Renamed loadFrameRequestWithFormAndValues to
        loadFrameRequest and made it take a form state object instead of the
        form element and form values. Removed the unused functions
        loadEmptyDocumentSynchronously, provisionalDocumentLoader,
        notifyIconChnaged, and updateBaseURLForEmptyDocument. Changed the
        submitForm function to take a form state argument. Eliminated the
        clearRecordedFormValues, setFormAboutToBeSubmitted, and recordFormValue
        functions, which are replaced by the form state arguments to submitForm
        and loadFrameRequest. Removed the isJavaScriptFormAction argument from
        the clientRedirected function; instead it looks at a data member directly.
        Eliminated the submitFormAgain and overload of the submitForm function;
        these are now subsumed into the remaining submitForm function and the
        scheduleFormSubmission function. Removed unused and obsolete data
        members m_navigationDuringLoad, m_deferredFormSubmission,
        m_formAboutToBeSubmitted and m_formValuesAboutToBeSubmitted.

        * page/ContextMenuController.cpp:
        (WebCore::ContextMenuController::contextMenuItemSelected):
        Updated for name and argument change of loadFrameRequest.

        * page/Frame.cpp:
        (WebCore::Frame::~Frame): Removed call to the now-unneeded
        clearRecordedFormValues function.

WebKit/mac:

2009-04-01  Darin Adler  <darin@apple.com>

        Reviewed by Geoff Garen.

        Bug 22378: Crash submitting a form when parsing an XHTML document
        https://bugs.webkit.org/show_bug.cgi?id=22378
        rdar://problem/6388377

        * History/WebHistoryItem.mm:
        (-[WebHistoryItem targetItem]): Call targetItem directly instead of callling
        isTargetItem, hasChildren, and recurseToFindTargetItem.

        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::dispatchWillSubmitForm): Updated for the new
        textFieldValues function in FormState.

        * WebView/WebPDFView.mm:
        (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Updated for name and
        argument change of loadFrameRequest.

WebKit/win:

2009-04-01  Darin Adler  <darin@apple.com>

        Reviewed by Geoff Garen.

        Bug 22378: Crash submitting a form when parsing an XHTML document
        https://bugs.webkit.org/show_bug.cgi?id=22378
        rdar://problem/6388377

        * WebFrame.cpp:
        (WebFrame::dispatchWillSubmitForm): Updated for the new
        textFieldValues function in FormState.

LayoutTests:

2009-04-01  Darin Adler  <darin@apple.com>

        Reviewed by Geoff Garen.

        Bug 22378: Crash submitting a form when parsing an XHTML document
        https://bugs.webkit.org/show_bug.cgi?id=22378
        rdar://problem/6388377

        * fast/loader/onunload-form-submit-crash-2-expected.txt: Updated for change to the test.
        * fast/loader/onunload-form-submit-crash-2.html: Updated test to expect the form submission
        during the onunload handler to be ineffective.
        * fast/loader/onunload-form-submit-crash-expected.txt: Updated for change to the test.
        * fast/loader/onunload-form-submit-crash.html: Updated test to expect the form submission
        during the onunload handler to be ineffective.

        * fast/loader/resources/onunload-form-submit-crash2.html: Removed.
        * fast/loader/resources/onunload-form-submit-failure.html: Copied from
        LayoutTests/fast/loader/resources/onunload-form-submit-crash2.html.
        * fast/loader/resources/onunload-form-submit-success.html: Copied from
        LayoutTests/fast/loader/resources/onunload-form-submit-crash2.html.

        * fast/loader/resources/submit-form-while-parsing-subframe.html: Added.
        * fast/loader/resources/submit-form-while-parsing-success.html: Added.
        * fast/loader/submit-form-while-parsing-1-expected.txt: Added.
        * fast/loader/submit-form-while-parsing-1.xhtml: Added.
        * fast/loader/submit-form-while-parsing-2-expected.txt: Added.
        * fast/loader/submit-form-while-parsing-2.html: Added.

        * platform/mac/http/tests/navigation/success200-frames-loadsame-expected.txt: Updated
        to expect proper results, without the duplicate history items for the same frame name
        that were present before.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-04-01 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Wed, 1 Apr 2009 23:49:57 +0000 (23:49 +0000)]
2009-04-01  Dimitri Glazkov  <dglazkov@chromium.org>

        Unreviewed, fixing previous commit.

        https://bugs.webkit.org/show_bug.cgi?id=24994
        Revert V8DOMMap.cpp change which accidentally snuck into the previous
        commit.

        * bindings/v8/V8DOMMap.cpp: Revert change in previous commit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-04-01 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Wed, 1 Apr 2009 23:43:41 +0000 (23:43 +0000)]
2009-04-01  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Fisher.

        https://bugs.webkit.org/show_bug.cgi?id=24994
        Fix miscellaneous merge/upstreaming divergencies in Chromium port.

        * bindings/v8/V8Collection.h: Added an include.
        * platform/KURLGoogle.cpp:
        (WebCore::KURL::baseAsString): Added to match KURL.cpp.
        * platform/chromium/ClipboardChromium.cpp: Added an include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-04-01 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Wed, 1 Apr 2009 22:47:55 +0000 (22:47 +0000)]
2009-04-01  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Timothy Hatcher.

        https://bugs.webkit.org/show_bug.cgi?id=24989
        Refactor InspectorResource to use ScriptObject/FunctionCall.

        * bindings/js/JSInspectorControllerCustom.cpp:
        (WebCore::JSInspectorController::addResourceSourceToFrame): Tweaked to use
            a more appropriate type conversion.
        (WebCore::JSInspectorController::getResourceDocumentNode): Tweaked to
            accommodate for InspectorResource refactoring.
        * bindings/js/ScriptFunctionCall.cpp:
        (WebCore::ScriptFunctionCall::appendArgument): Added long long type to match
            existing jsNumber call signature.
        * bindings/js/ScriptFunctionCall.h: Declaration for above.
        * bindings/js/ScriptObject.cpp:
        (WebCore::createEmptyObject): Added.
        (WebCore::ScriptObject::ScriptObject):
        (WebCore::ScriptObject::set): Added a bunch of property setters.
        * bindings/js/ScriptObject.h: Declarations for above.
        * inspector/InspectorController.cpp: Moved all InspectorResource-managing code
            to InspectorResource.cpp
        (WebCore::InspectorController::populateScriptObjects): Changed to use
            refactored InspectorResource.
        (WebCore::InspectorController::resetScriptObjects): Ditto.
        (WebCore::InspectorController::pruneResources): Ditto.
        (WebCore::InspectorController::didCommitLoad): Ditto.
        (WebCore::InspectorController::addResource): Ditto.
        (WebCore::InspectorController::removeResource): Ditto.
        (WebCore::InspectorController::didLoadResourceFromMemoryCache): Ditto.
        (WebCore::InspectorController::identifierForInitialRequest): Ditto.
        (WebCore::InspectorController::willSendRequest): Ditto.
        (WebCore::InspectorController::didReceiveResponse): Ditto.
        (WebCore::InspectorController::didReceiveContentLength): Ditto.
        (WebCore::InspectorController::didFinishLoading): Ditto.
        (WebCore::InspectorController::didFailLoading): Ditto,
        (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest): Ditto.
        (WebCore::InspectorController::scriptImported): Ditto.
        * inspector/InspectorController.h: Removed InspectorResource-managing code decls
            and tweaked some signatures to use ScriptString and long long for identifier.
        * inspector/InspectorController.idl: Changed to use long long for identifier.
        * inspector/InspectorResource.cpp: Refactored to use ScriptObject/FunctionCall.
        (WebCore::InspectorResource::InspectorResource): Ditto.
        (WebCore::InspectorResource::~InspectorResource): Ditto.
        (WebCore::InspectorResource::createCached): Added.
        (WebCore::InspectorResource::updateRequest): Added.
        (WebCore::InspectorResource::updateResponse): Added.
        (WebCore::createHeadersObject): Added.
        (WebCore::InspectorResource::createScriptObject): Added.
        (WebCore::InspectorResource::updateScriptObject): Added.
        (WebCore::InspectorResource::releaseScriptObject): Added.
        (WebCore::InspectorResource::type): Tweaked to use ScriptString.
        (WebCore::InspectorResource::setXMLHttpResponseText): Added.
        (WebCore::InspectorResource::sourceString): Tweaked to use ScriptString.
        (WebCore::InspectorResource::startTiming): Added.
        (WebCore::InspectorResource::markResponseReceivedTime): Added.
        (WebCore::InspectorResource::endTiming): Added.
        (WebCore::InspectorResource::markFailed): Added.
        (WebCore::InspectorResource::addLength): Added.
        * inspector/InspectorResource.h: Added decls for newly refactored-in methods.
        (WebCore::InspectorResource::create): Added.
        (WebCore::InspectorResource::isSameLoader): Added.
        (WebCore::InspectorResource::markMainResource): Added.
        (WebCore::InspectorResource::identifier): Added.
        (WebCore::InspectorResource::requestURL): Added.
        (WebCore::InspectorResource::frame): Added.
        (WebCore::InspectorResource::mimeType): Added.
        (WebCore::InspectorResource::Changes::Changes): Added new class to track
            resource changes.
        (WebCore::InspectorResource::Changes::hasChange): Added.
        (WebCore::InspectorResource::Changes::set): Added.
        (WebCore::InspectorResource::Changes::clear): Added.
        (WebCore::InspectorResource::Changes::setAll): Added.
        (WebCore::InspectorResource::Changes::clearAll): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-04-01 Tony Chang <tony@chromium.org>
darin@chromium.org [Wed, 1 Apr 2009 21:17:30 +0000 (21:17 +0000)]
2009-04-01  Tony Chang  <tony@chromium.org>

        Reviewed by Darin Fisher.

        Ensure the right click doesn't deselect text under it.  This was
        happening in the Chromium and GTK+ ports because they don't select
        the text under the cursor on right click.

        This was regressed in r41715, https://bugs.webkit.org/show_bug.cgi?id=19737

        https://bugs.webkit.org/show_bug.cgi?id=24946

        Test: fast/events/context-no-deselect.html

        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleMouseReleaseEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-04-01 Christian Dywan <christian@twotoasts.de>
christian@webkit.org [Wed, 1 Apr 2009 19:48:20 +0000 (19:48 +0000)]
2009-04-01  Christian Dywan  <christian@twotoasts.de>

        Reviewed by Holger Freyther.

        Unit test WebKitDownload
        http://bugs.webkit.org/show_bug.cgi?id=24844

        * GNUmakefile.am: Add a unit test for downloading.

2009-04-01  Christian Dywan  <christian@twotoasts.de>

        Reviewed by Holger Freyther.

        * tests/testdownload.c: Added.
        (test_webkit_download_create):
        (main): Add an initial unit test for downloading.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-04-01 Greg Bolsinga <bolsinga@apple.com>
bolsinga@apple.com [Wed, 1 Apr 2009 19:32:41 +0000 (19:32 +0000)]
2009-04-01  Greg Bolsinga  <bolsinga@apple.com>

        Reviewed by Mark Rowe.

        https://bugs.webkit.org/show_bug.cgi?id=24990
        Put SECTORDER_FLAGS into xcconfig files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-04-01 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 1 Apr 2009 19:26:58 +0000 (19:26 +0000)]
2009-04-01  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dave Hyatt

        https://bugs.webkit.org/show_bug.cgi?id=24991

        Need to use toRenderBoxModelObject(), not toRenderBox(), to test for layer()
        when getting the transform.

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::transformFromContainer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-04-01 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Wed, 1 Apr 2009 16:55:00 +0000 (16:55 +0000)]
2009-04-01  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Unreviewed typo fixes, and naming normalization in the
        documentation.

        * docs/webkitenvironment.xml:
        * webkit/webkitwebview.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42150 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-04-01 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Wed, 1 Apr 2009 16:37:52 +0000 (16:37 +0000)]
2009-04-01  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Unreviewed build fix. Fix make distcheck, after the gtk-doc
        integration.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-03-31 Darin Adler <darin@apple.com>
darin@apple.com [Wed, 1 Apr 2009 06:43:07 +0000 (06:43 +0000)]
2009-03-31  Darin Adler  <darin@apple.com>

        Rolled out that last change until I can investigate the regression test failures it seems
        to have caused.

        * dom/PositionIterator.cpp:
        (WebCore::PositionIterator::decrement):
        * dom/PositionIterator.h:
        (WebCore::PositionIterator::PositionIterator):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-03-31 Darin Adler <darin@apple.com>
darin@apple.com [Wed, 1 Apr 2009 04:41:34 +0000 (04:41 +0000)]
2009-03-31  Darin Adler  <darin@apple.com>

        Reviewed by Eric Seidel.

        Bug 24621: PositionIterator doesn't iterate "after last child" positions when going backwards
        https://bugs.webkit.org/show_bug.cgi?id=24621

        * dom/PositionIterator.cpp:
        (WebCore::PositionIterator::decrement): Make sure that when the parent has no children, we
        don't ever use Position::uncheckedPreviousOffset. This is consistent with the forward
        iterator, but also should never arise because of the fix below.
        * dom/PositionIterator.h:
        (WebCore::PositionIterator::PositionIterator): Fixed so m_offset will always be 0 when
        the passed-in node has no children. Like the change above, this is consistent with the rest
        of the class, although in the long run I think it's a bit strange to treat a <p> element
        with no children differently than a <p> element with children.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Make resolve-ChangeLogs -f work when the working tree has spaces in its path
aroben@apple.com [Wed, 1 Apr 2009 00:13:03 +0000 (00:13 +0000)]
    Make resolve-ChangeLogs -f work when the working tree has spaces in its path

        Reviewed by Mark Rowe and David Kilzer.

        * Scripts/resolve-ChangeLogs:
        (sub fixMergedChangeLogs): Quote the path to resolve-ChangeLogs in
        case it contains spaces.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-03-31 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 31 Mar 2009 22:57:51 +0000 (22:57 +0000)]
2009-03-31  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam Roben.

        WebKit side of <rdar://problem/6500266>.

        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::wheelEvent):
        Send the event.

        * Plugins/Hosted/WebHostedNetscapePluginView.mm:
        (-[WebHostedNetscapePluginView scrollWheel:]):
        Call NetscapePluginInstanceProxy::wheelEvent. If the plug-in processed the event, don't
        call super.

        * Plugins/Hosted/WebKitPluginHost.defs:
        Add definition.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-03-31 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Tue, 31 Mar 2009 22:13:30 +0000 (22:13 +0000)]
2009-03-31  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Simon Fraser.

        https://bugs.webkit.org/show_bug.cgi?id=24965
        Bug 24965: HTMLMediaElement: network state changes can be missed

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::setNetworkState): Always update m_networkState when the
        state changes, even when no event needs to be fired.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-03-31 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Tue, 31 Mar 2009 21:55:53 +0000 (21:55 +0000)]
2009-03-31  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=24964
        Bug 24964: HTMLMediaElement: 'waiting' event may fire twice

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::setReadyState): Only fire 'waiting' event once when ready state
        drops below HAVE_FUTURE_DATA.

2009-03-31  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=24964
        Bug 24964: HTMLMediaElement: 'waiting' event may fire twice

        * http/tests/media/video-play-stall.html: Fail if 'waiting' fires more than once.
        * media/video-test.js: Fix a typo.
        (failTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin Adler.
ap@webkit.org [Tue, 31 Mar 2009 21:39:31 +0000 (21:39 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=24777
        WebKit tools are broken on Tiger

        * Scripts/webkitdirs.pm: Don't use arch command with options on Tiger.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-03-31 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Tue, 31 Mar 2009 21:26:34 +0000 (21:26 +0000)]
2009-03-31  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=24846
        Bug 24846: HTMLMediaElement should implement 'autobuffer' attribute

        Add 'autobuffer' attrubute to media element. 'autobuffer' is a hint that
        the author recommends downloading the entire resource optimistically, so the
        attribute is made available to the media engine to use if it is able.

        Test: media/video-dom-autobuffer.html

        * html/HTMLAttributeNames.in: Add autobuffer.

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::parseMappedAttribute): New.
        (WebCore::HTMLMediaElement::autobuffer): Ditto.
        (WebCore::HTMLMediaElement::setAutobuffer): Ditto.

        * html/HTMLMediaElement.h: Declare autobuffer and setAutobuffer.

        * html/HTMLMediaElement.idl: Add autobuffer.

        * platform/graphics/MediaPlayer.cpp:
        (WebCore::MediaPlayer::MediaPlayer): Initialize m_autobuffer.
        (WebCore::MediaPlayer::autobuffer): New.
        (WebCore::MediaPlayer::setAutobuffer): Ditto.
        * platform/graphics/MediaPlayer.h: Declare m_autobuffer, autobuffer and setAutobuffer

        * platform/graphics/MediaPlayerPrivate.h:
        (WebCore::MediaPlayerPrivateInterface::setAutobuffer): Declare setAutobuffer.

2009-03-31  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=24846
        Bug 24846: HTMLMediaElement should implement 'autobuffer' attribute

        * media/video-dom-autobuffer-expected.txt: Added.
        * media/video-dom-autobuffer.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42141 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-03-31 Darin Adler <darin@apple.com>
darin@apple.com [Tue, 31 Mar 2009 20:24:49 +0000 (20:24 +0000)]
2009-03-31  Darin Adler  <darin@apple.com>

        Reviewed by Adele Peterson.

        <rdar://problem/6740581> REGRESSION (r41793): Page Down and Page Up don’t work in Leopard Mail

        * WebView/WebHTMLView.mm:
        (-[WebResponderChainSink tryToPerform:with:]): Added. Without this we would think we had
        handled an event when we actually hadn't. Specifically, when -[WebFrameView scrollPageDown:]
        calls tryToPerform on the next responder.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-03-31 Craig Schlenter <craig.schlenter@gmail.com>
dimich@chromium.org [Tue, 31 Mar 2009 20:23:12 +0000 (20:23 +0000)]
2009-03-31  Craig Schlenter  <craig.schlenter@gmail.com>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=24550
        Check return value of vasprintf. This should keep gcc 4.3.3
        happy rather than have it complain about attribute warn_unused_result.

        * dom/XMLTokenizerLibxml2.cpp:
        (WebCore::XMLTokenizer::error):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-03-31 Dean Jackson <dino@apple.com>
dino@apple.com [Tue, 31 Mar 2009 20:11:27 +0000 (20:11 +0000)]
2009-03-31  Dean Jackson  <dino@apple.com>

        Style guide violation!

        * loader/MediaDocument.cpp:
        (WebCore::MediaDocument::defaultEventHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-03-31 Dean Jackson <dino@apple.com>
dino@apple.com [Tue, 31 Mar 2009 20:05:06 +0000 (20:05 +0000)]
2009-03-31  Dean Jackson  <dino@apple.com>

        Fix Tiger build.

        * loader/MediaDocument.cpp:
        (WebCore::MediaDocument::defaultEventHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFixing previous commit - forgot to 'git add' new files.
dimich@chromium.org [Tue, 31 Mar 2009 19:56:51 +0000 (19:56 +0000)]
Fixing previous commit - forgot to 'git add' new files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-03-31 Jian Li <jianli@chromium.org>
dimich@chromium.org [Tue, 31 Mar 2009 19:55:26 +0000 (19:55 +0000)]
2009-03-31  Jian Li  <jianli@chromium.org>

        Reviewed by Darin Fisher.

        Upstream V8DOMMap for v8 bindings.
        https://bugs.webkit.org/show_bug.cgi?id=24951

        * bindings/v8/V8DOMMap.cpp: Added.
        * bindings/v8/V8DOMMap.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-03-31 Dean Jackson <dino@apple.com>
dino@apple.com [Tue, 31 Mar 2009 19:50:56 +0000 (19:50 +0000)]
2009-03-31  Dean Jackson  <dino@apple.com>

        Reviewed by Simon Fraser.

        https://bugs.webkit.org/show_bug.cgi?id=24955

        Spacebar didn't play/pause in standalone MediaDocument

        * loader/MediaDocument.cpp:
        (WebCore::MediaDocument::defaultEventHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-03-31 Alpha Lam <hclam@chromium.org>
dimich@chromium.org [Tue, 31 Mar 2009 19:10:03 +0000 (19:10 +0000)]
2009-03-31  Alpha Lam  <hclam@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=24901
        Added the following methods to MediaPlayerPrivate for Chromium port.
        void sizeChanged();
        void rateChanged();
        void durationChanged();

        The above changes are to reflect changes in MediaPlayer.cpp.
        More details can be found in the original changeset.
        http://trac.webkit.org/changeset/41907

        * platform/graphics/chromium/MediaPlayerPrivateChromium.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-03-31 Darin Adler <darin@apple.com>
darin@apple.com [Tue, 31 Mar 2009 16:54:29 +0000 (16:54 +0000)]
2009-03-31  Darin Adler  <darin@apple.com>

        * Scripts/add-include: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-03-31 Rafael Weinstein <rafaelw@chromium.org>
darin@chromium.org [Tue, 31 Mar 2009 16:46:32 +0000 (16:46 +0000)]
2009-03-31  Rafael Weinstein  <rafaelw@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=24947

        Special-case drawing text-shadow on win32, to let GDI draw in cases
        when both fill & shadow color are opaque and the shadow has no blur.

        * platform/graphics/chromium/FontChromiumWin.cpp:
        (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs):
        (WebCore::Font::drawComplexText):
        * platform/graphics/skia/SkiaFontWin.cpp:
        (WebCore::windowsCanHandleDrawTextShadow):
        (WebCore::windowsCanHandleTextDrawing):
        * platform/graphics/skia/SkiaFontWin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-03-31 Jeremy Moskovich <jeremy@chromium.org>
darin@chromium.org [Tue, 31 Mar 2009 16:21:22 +0000 (16:21 +0000)]
2009-03-31  Jeremy Moskovich  <jeremy@chromium.org>

        Reviewed by Darin Fisher.

        r42055 removed some functions in FrameLoader used by Chrome,
        this CL backs out some of those changes to unbreak the Chrome build.

        https://bugs.webkit.org/show_bug.cgi?id=24949

        * WebCore.base.exp:
        * loader/FrameLoader.cpp:
        * loader/FrameLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-03-31 Jeremy Moskovich <jeremy@chromium.org>
darin@chromium.org [Tue, 31 Mar 2009 16:13:29 +0000 (16:13 +0000)]
2009-03-31  Jeremy Moskovich  <jeremy@chromium.org>

        Reviewed by Darin Adler.

        Build fixes for Chromium.

        https://bugs.webkit.org/show_bug.cgi?id=24945

        * dom/Document.h:
        * platform/chromium/ClipboardChromium.cpp:
        (WebCore::imageToMarkup):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-03-31 Simon Hausmann <simon.hausmann@nokia.com>
hausmann@webkit.org [Tue, 31 Mar 2009 10:26:46 +0000 (10:26 +0000)]
2009-03-31  Simon Hausmann  <simon.hausmann@nokia.com>

        Fix the Qt build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix use of incorrect constant.
mrowe@apple.com [Tue, 31 Mar 2009 07:02:59 +0000 (07:02 +0000)]
Fix use of incorrect constant.

* BuildSlaveSupport/built-product-archive:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd a script in support of the new build.webkit.org configuration.
mrowe@apple.com [Tue, 31 Mar 2009 06:29:22 +0000 (06:29 +0000)]
Add a script in support of the new build.webkit.org configuration.

Rubber-stamped by Stephanie Lewis.

* BuildSlaveSupport/built-product-archive: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-03-31 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Tue, 31 Mar 2009 03:21:29 +0000 (03:21 +0000)]
2009-03-31  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Holger Freyther.

        Updated gtk-doc configuration files for the 1.1.1, 1.1.2, 1.1.3,
        and 1.1.4 versions of WebKitGTK+.

        * docs/webkitgtk-docs.sgml:
        * docs/webkitgtk-sections.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-03-31 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Tue, 31 Mar 2009 03:16:33 +0000 (03:16 +0000)]
2009-03-31  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Holger Freyther.

        https://bugs.webkit.org/show_bug.cgi?id=17045
        [GTK] Documentation

        Added header documentation for WebKitWebNavigationAction and
        WebKitWebPolicyDecision.

        Added missing documentation pieces for WebKitSoupAuthDialog,
        WebKitDownload and WebKitWebPolicyDecision.

        Wrote a section about using the WEBKIT_DEBUG environment variable.

        * docs/GNUmakefile.am:
        * docs/webkitenvironment.xml: Added.
        * docs/webkitgtk-docs.sgml:
        * webkit/webkitdownload.cpp:
        * webkit/webkitsoupauthdialog.c:
        * webkit/webkitwebnavigationaction.cpp:
        * webkit/webkitwebpolicydecision.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-03-30 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Tue, 31 Mar 2009 02:41:46 +0000 (02:41 +0000)]
2009-03-30  Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

        Reviewed by Holger Freyther.

        Integrate gtk-doc into the Gtk+ buildsystem.

        Based on original work by Holger Freyther.

        Integrate gtk-doc into our buildsystem. We are forced to
        use recursive make for gtk-doc itself as the to be installed
        gtk-doc.make (done by gtkdocize) is not working in a non
        recursive environment.

        The documentation can only be generated when srcdir == builddir.
        In all other cases the generated files will not be found. This
        limitation can be found in pango and gtk+ as well. There is no
        easy way around. The resulting html documentation will be saved
        in the srcdir as well.

        * docs/GNUmakefile.am: Added.
        * docs/version.xml.in: Added.
        * docs/webkitgtk-docs.sgml:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoReviewed by Kevin Ollivier.
kevino@webkit.org [Tue, 31 Mar 2009 02:37:12 +0000 (02:37 +0000)]
Reviewed by Kevin Ollivier.

Add events to allow apps to override handling for JS prompts and
window object cleared events.

https://bugs.webkit.org/show_bug.cgi?id=24948

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Don't create CFDataRef with a fixed size.
sfalken@apple.com [Tue, 31 Mar 2009 02:29:40 +0000 (02:29 +0000)]
    Don't create CFDataRef with a fixed size.
        Fixes synchronous XMLHTTPRequests on Windows.

        Reviewed by Ada Chan.

        * platform/network/cf/ResourceHandleCFNet.cpp:
        (WebCore::WebCoreSynchronousLoader::didReceiveData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
darin@apple.com [Tue, 31 Mar 2009 00:19:02 +0000 (00:19 +0000)]
WebCore:

2009-03-30  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Bug 24594: PolicyDelegate NavigationAction is WebNavigationTypeOther instead of WebNavigationTypeReload
        https://bugs.webkit.org/show_bug.cgi?id=24594
        rdar://problem/6682110

        Test: fast/loader/reload-policy-delegate.html

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::loadWithDocumentLoader): Set the triggering action here where we know it's
        the policy loader and can use m_policyLoadType rather than letting it get set inside
        checkNavigationPolicy.

LayoutTests:

2009-03-30  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Bug 24594: PolicyDelegate NavigationAction is WebNavigationTypeOther instead of WebNavigationTypeReload
        https://bugs.webkit.org/show_bug.cgi?id=24594
        rdar://problem/6682110

        * fast/frames/resources/iframe-focus.html: Removed bogus but harmless "layoutTestController.loadCount"
        code.

        * fast/loader/reload-policy-delegate-expected.txt: Added.
        * fast/loader/reload-policy-delegate.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-03-30 Darin Adler <darin@apple.com>
darin@apple.com [Tue, 31 Mar 2009 00:17:07 +0000 (00:17 +0000)]
2009-03-30  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Make policy-delegate logging work even for local files by processing the URLs as we
        do for other delegates.

        * DumpRenderTree/mac/PolicyDelegate.mm:
        (-[PolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
        Use _drt_descriptionSuitableForTestResult on the URL.

        * DumpRenderTree/win/PolicyDelegate.cpp:
        (PolicyDelegate::decidePolicyForNavigationAction): Use urlSuitableForTestResult on the URL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago <rdar://problem/5838871> CrashTracer: 1483 crashes Quicklooking
timothy@apple.com [Mon, 30 Mar 2009 22:49:11 +0000 (22:49 +0000)]
    <rdar://problem/5838871> CrashTracer: 1483 crashes Quicklooking
        in Finder (painting without up to date layout)

        Reviewed by Dan Bernstein.

        * page/FrameView.cpp:
        (WebCore::FrameView::paintContents): Add an early return when
        painting is attempted when layout is needed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-03-30 Greg Bolsinga <bolsinga@apple.com>
bolsinga@apple.com [Mon, 30 Mar 2009 19:59:47 +0000 (19:59 +0000)]
2009-03-30  Greg Bolsinga  <bolsinga@apple.com>

        Reviewed by Simon Fraser.

        https://bugs.webkit.org/show_bug.cgi?id=24938

        Sort alphabetically.

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-03-30 Greg Bolsinga <bolsinga@apple.com>
bolsinga@apple.com [Mon, 30 Mar 2009 18:33:40 +0000 (18:33 +0000)]
2009-03-30  Greg Bolsinga  <bolsinga@apple.com>

        Reviewed by Simon Fraser.

        https://bugs.webkit.org/show_bug.cgi?id=24938

        Build fixes for building --3d-rendering and --no-svg

        * rendering/RenderLayerBacking.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-03-30 Steve Falkenburg <sfalken@apple.com>
sfalken@apple.com [Mon, 30 Mar 2009 18:27:45 +0000 (18:27 +0000)]
2009-03-30  Steve Falkenburg  <sfalken@apple.com>

        Bump version to 530.

        * win/tools/scripts/VERSION:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-03-30 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Mon, 30 Mar 2009 18:21:16 +0000 (18:21 +0000)]
2009-03-30  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Unreviewed. Documenting what changed since the 1.1.3 release, in
        the GTK+ port.

        * NEWS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-03-30 Greg Bolsinga <bolsinga@apple.com>
bolsinga@apple.com [Mon, 30 Mar 2009 18:04:35 +0000 (18:04 +0000)]
2009-03-30  Greg Bolsinga  <bolsinga@apple.com>

        Reviewed by Simon Fraser.

        https://bugs.webkit.org/show_bug.cgi?id=24938

        Build fixes when building --no-svg

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Add missing CSS properties
        * css/CSSCursorImageValue.cpp:
        (WebCore::CSSCursorImageValue::updateIfSVGCursorIsUsed): Handle unused param
        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue): Add missing CSS properties
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applyProperty): Add missing CSS properties
        * dom/Node.cpp:
        (WebCore::updateSVGElementInstancesAfterEventListenerChange): Handle unused param
        * platform/graphics/Font.cpp:
        (WebCore::Font::floatWidth): Handle unused param
        * platform/graphics/SimpleFontData.cpp:
        (WebCore::SimpleFontData::SimpleFontData): Handle unused param

2009-03-30  Greg Bolsinga  <bolsinga@apple.com>

        Reviewed by Simon Fraser.

        https://bugs.webkit.org/show_bug.cgi?id=24938

        Build fixes when building --no-svg

        DOMHTMLFrameElementPrivate.h and DOMHTMLIFrameElementPrivate.h are only available with ENABLE_SVG.

        * MigrateHeaders.make:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-03-30 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Mon, 30 Mar 2009 17:46:11 +0000 (17:46 +0000)]
2009-03-30  Xan Lopez  <xlopez@igalia.com>

        Unreviewed: bump version to 1.1.4 for release.

        * configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-03-30 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Mon, 30 Mar 2009 17:41:19 +0000 (17:41 +0000)]
2009-03-30  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Unreviewed. Add information on the bug-fix-only 1.1.3 release.

        * NEWS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Windows build fix
aroben@apple.com [Mon, 30 Mar 2009 17:37:42 +0000 (17:37 +0000)]
    Windows build fix

        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
        (LayoutTestController::waitForPolicyDelegate): Added this empty stub.

        * DumpRenderTree/win/WorkQueueItemWin.cpp:
        (LoadItem::invoke):
        (ScriptItem::invoke):
        Changed to use data members instead of removed member functions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-03-30 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 30 Mar 2009 17:26:16 +0000 (17:26 +0000)]
2009-03-30  Darin Adler  <darin@apple.com>

        Reviewed by Adam Roben.

        Bug 24916: REGRESSION: NavigationAction policy dispatch broken
        https://bugs.webkit.org/show_bug.cgi?id=24916

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::loadURL): Rearrange the code so that the "event" PassRefPtr
        is not used twice. This also optimizes the case where a frame name is specified,
        but it's the name of the frame being loaded. Also called release in all the final
        uses of FormState.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-03-30 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 30 Mar 2009 17:22:35 +0000 (17:22 +0000)]
2009-03-30  Darin Adler  <darin@apple.com>

        Reviewed by Adam Roben.

        Bug 24937: NamedNodeMap and NamedAttrMap should not be separate classes
        https://bugs.webkit.org/show_bug.cgi?id=24937

        Also should fix the Windows COM bindings build.

        * bindings/scripts/CodeGeneratorJS.pm: Removed special case for NamedNodeMap.
        * bindings/scripts/CodeGeneratorObjC.pm: Ditto.

        * dom/NamedAttrMap.h: Renamed class from NamedAttrMap to
        NamedNodeMap and removed NamedNodeMap base class. Made the NamedNodeMap
        functions all public and non-virtual. Removed virtualLength.

        * dom/NamedNodeMap.h: Replaced file with just an include
        of NamedAttrMap.h. As a follow up we will rename the NamedAttrMap
        files and remove this file.

        * bindings/js/JSNamedNodesCollection.cpp: Renamed from NamedAttrMap to NamedNodeMap.
        * dom/Attr.h: Ditto.
        * dom/Attribute.h: Ditto.
        * dom/Document.cpp:
        (WebCore::Document::importNode): Ditto.
        * dom/Element.cpp:
        (WebCore::Element::attributes): Ditto.
        (WebCore::Element::setAttributeMap): Ditto.
        (WebCore::Element::createAttributeMap): Ditto.
        (WebCore::Element::insertedIntoDocument): Ditto.
        (WebCore::Element::removedFromDocument): Ditto.
        (WebCore::Element::openTagStartToString): Ditto.
        (WebCore::Element::removeAttributeNode): Ditto.
        (WebCore::Element::getAttributeNode): Ditto.
        (WebCore::Element::getAttributeNodeNS): Ditto.
        (WebCore::Element::hasAttribute): Ditto.
        (WebCore::Element::hasAttributeNS): Ditto.
        (WebCore::Element::normalizeAttributes): Ditto.
        * dom/Element.h: Ditto.
        * dom/NamedAttrMap.cpp:
        (WebCore::NamedNodeMap::detachAttributesFromElement): Ditto.
        (WebCore::NamedNodeMap::~NamedNodeMap): Ditto.
        (WebCore::NamedNodeMap::isMappedAttributeMap): Ditto.
        (WebCore::NamedNodeMap::getNamedItem): Ditto.
        (WebCore::NamedNodeMap::getNamedItemNS): Ditto.
        (WebCore::NamedNodeMap::removeNamedItem): Ditto.
        (WebCore::NamedNodeMap::removeNamedItemNS): Ditto.
        (WebCore::NamedNodeMap::setNamedItem): Ditto.
        (WebCore::NamedNodeMap::item): Ditto.
        (WebCore::NamedNodeMap::getAttributeItem): Ditto.
        (WebCore::NamedNodeMap::clearAttributes): Ditto.
        (WebCore::NamedNodeMap::detachFromElement): Ditto.
        (WebCore::NamedNodeMap::setAttributes): Ditto.
        (WebCore::NamedNodeMap::addAttribute): Ditto.
        (WebCore::NamedNodeMap::removeAttribute): Ditto.
        (WebCore::NamedNodeMap::mapsEquivalent): Ditto.
        * dom/NamedMappedAttrMap.cpp:
        (WebCore::NamedMappedAttrMap::clearAttributes): Ditto.
        * dom/NamedMappedAttrMap.h:
        (WebCore::NamedMappedAttrMap::NamedMappedAttrMap): Ditto.
        * dom/Node.cpp:
        (WebCore::Node::dumpStatistics): Ditto.
        (WebCore::Node::isEqualNode): Ditto.
        (WebCore::Node::isDefaultNamespace): Ditto.
        (WebCore::Node::lookupNamespaceURI): Ditto.
        (WebCore::Node::lookupNamespacePrefix): Ditto.
        (WebCore::Node::compareDocumentPosition): Ditto.
        * dom/Node.h: Ditto.
        * dom/XMLTokenizerLibxml2.cpp:
        (WebCore::XMLTokenizer::XMLTokenizer): Ditto.
        * editing/ApplyStyleCommand.cpp:
        (WebCore::isSpanWithoutAttributesOrUnstyleStyleSpan): Ditto.
        (WebCore::isEmptyFontTag): Ditto.
        (WebCore::areIdenticalElements): Ditto.
        * editing/markup.cpp:
        (WebCore::appendStartMarkup): Ditto.
        (WebCore::completeURLs): Ditto.
        * html/HTMLParser.cpp:
        (WebCore::HTMLParser::handleError): Ditto.
        * rendering/RenderPartObject.cpp:
        (WebCore::RenderPartObject::updateWidget): Ditto.
        * svg/SVGAnimatedProperty.h:
        (WebCore::synchronizeProperty): Ditto.
        * xml/XPathFunctions.cpp:
        (WebCore::XPath::FunLang::evaluate): Ditto.
        * xml/XPathStep.cpp:
        (WebCore::XPath::Step::nodesInAxis): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-03-30 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Mon, 30 Mar 2009 16:35:10 +0000 (16:35 +0000)]
2009-03-30  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Holger Freyther.

        https://bugs.webkit.org/show_bug.cgi?id=24750
        [GTK] requests download instead of displaying page

        Use soup facilities to append parameters to the content type, to
        make that more robust;

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::fillResponseFromMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago <rdar://problem/6735683> Move SECTORDER_FLAGS from Xcode project to WebCore...
ddkilzer@apple.com [Mon, 30 Mar 2009 16:24:19 +0000 (16:24 +0000)]
    <rdar://problem/6735683> Move SECTORDER_FLAGS from Xcode project to WebCore.xcconfig

        Reviewed by Timothy Hatcher, Mark Rowe and Darin Adler.

        * Configurations/Base.xcconfig: Moved Production definition of
        SECTORDER_FLAGS to here from Xcode project file.
        * Configurations/DebugRelease.xcconfig: Override SECTORDER_FLAGS
        in Base.xcconfig to the empty string since it is not used for
        Debug and Release configurations.
        * WebCore.xcodeproj/project.pbxproj: Removed SECTORDER_FLAGS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Build fixes after recent FrameLoader changes
aroben@apple.com [Mon, 30 Mar 2009 15:58:58 +0000 (15:58 +0000)]
    Build fixes after recent FrameLoader changes

        * WebCoreSupport/WebContextMenuClient.cpp:
        (WebContextMenuClient::searchWithGoogle): Updated to match
        urlSelected's current signature. We pass true for the userGesture
        parameter, since the user must have selected this item from the
        context menu.

        * WebCoreSupport/WebFrameLoaderClient.cpp: Removed
        loadURLIntoChildFrame.
        (WebFrameLoaderClient::createFrame): Changed to call
        FrameLoader::loadURLIntoChildFrame. This probably should have been
        done way back around r31281 when that function was added.

        * WebCoreSupport/WebFrameLoaderClient.h: Removed
        loadURLIntoChildFrame.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Windows build fix after recent Node.idl changes
aroben@apple.com [Mon, 30 Mar 2009 15:58:38 +0000 (15:58 +0000)]
    Windows build fix after recent Node.idl changes

        * bindings/scripts/CodeGeneratorCOM.pm: Touched this to force sources
        of classes that derive from Node to rebuild.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-03-30 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Mon, 30 Mar 2009 15:48:30 +0000 (15:48 +0000)]
2009-03-30  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Holger Freyther.

        https://bugs.webkit.org/show_bug.cgi?id=24878
        [GTK] Use GtkBinding system to handle key events in WebView

        Use GtkBinding system for key events in WebKitWebView. Allows the
        user to reconfigure the bindings and fixes a bunch of bugs along
        the way (we were not checking modifier keys in most actions).

        * webkit/webkitwebview.cpp:
        (webkit_web_view_move_cursor):
        * webkit/webkitwebview.h:
        * webkitmarshal.list:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Windows build fix
aroben@apple.com [Mon, 30 Mar 2009 15:22:37 +0000 (15:22 +0000)]
    Windows build fix

        * svg/graphics/SVGImage.cpp: Added a missing #include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-03-30 Mads Ager <ager@chromium.org>
dglazkov@chromium.org [Mon, 30 Mar 2009 14:49:39 +0000 (14:49 +0000)]
2009-03-30  Mads Ager  <ager@chromium.org>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=24879
        Add frame accessor to Screen, Console, and BarInfo objects. Add type
        accessor to BarInfo objects.

        In the V8 JavaScript bindings, we need access to the frame and
        type for already created Screen, Console, and BarInfo objects in
        order to keep their wrappers alive across GCs.

        * page/BarInfo.cpp:
        (WebCore::BarInfo::frame): Added.
        (WebCore::BarInfo::type): Added.
        * page/BarInfo.h:
        * page/Console.cpp:
        (WebCore::Console::frame): Added.
        * page/Console.h:
        * page/Screen.cpp:
        (WebCore::Screen::frame): Added.
        * page/Screen.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoDocument that setHtml/setContent loads only the html/data immediately, not external...
hausmann@webkit.org [Mon, 30 Mar 2009 09:25:34 +0000 (09:25 +0000)]
Document that setHtml/setContent loads only the html/data immediately, not external objects.
2009-03-30  Simon Hausmann  <simon.hausmann@nokia.com>

        Rubber-stamped by Tor Arne Vestbø.

        Document that setHtml/setContent loads only the html/data immediately, not external objects.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-03-30 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Mon, 30 Mar 2009 09:13:41 +0000 (09:13 +0000)]
2009-03-30  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Gtk DRT build fix per changeset
        http://trac.webkit.org/changeset/42082. Not reviewed.

        * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
        (LoadItem::invoke):
        (ScriptItem::invoke):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-03-29 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 30 Mar 2009 02:49:37 +0000 (02:49 +0000)]
2009-03-29  Darin Adler  <darin@apple.com>

        Requested by Antti Koivisto.

        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::subresource): Tweaked code to be a little clearer and added
        a better comment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
darin@apple.com [Mon, 30 Mar 2009 02:21:26 +0000 (02:21 +0000)]
WebCore:

2009-03-29  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        Bug 23445: Copying certain hidden text causes a crash
        https://bugs.webkit.org/show_bug.cgi?id=23445
        rdar://problem/6512520

        Test: editing/pasteboard/copy-display-none.html

        * editing/markup.cpp:
        (WebCore::createMarkup): Added a check for the case where adjusting the start node moves
        the start of the selection past the end of the range entirely. If we try to iterate we'll
        never hit the end of the range and will probably crash iterating the rest of the document.

LayoutTests:

2009-03-29  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        Bug 23445: Copying certain hidden text causes a crash
        https://bugs.webkit.org/show_bug.cgi?id=23445
        rdar://problem/6512520

        * editing/pasteboard/copy-display-none-expected.txt: Added.
        * editing/pasteboard/copy-display-none.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-03-29 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 30 Mar 2009 01:59:29 +0000 (01:59 +0000)]
2009-03-29  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        Bug 24672: ASSERTION FAILURE: !m_purgeableData in WebCore::CachedResource::data() saving a WebArchive
        https://bugs.webkit.org/show_bug.cgi?id=24672
        rdar://problem/6574263

        I couldn't create a test case for this. In fact, the case in the bug doesn't exist any more,
        but there is an Apple-internal website I was able to use to reproduce and fix.

        * loader/CachedResource.h: Made makePurgeable public.
        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::subresource): Call makePurgeable to make the resource non-purgeable
        so we can get its data if it hasn't yet been purged.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-03-29 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 30 Mar 2009 00:06:45 +0000 (00:06 +0000)]
2009-03-29  Darin Adler  <darin@apple.com>

        Fix build again.

        * loader/EmptyClients.h: Fix typo in name of FormState.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-03-29 Darin Adler <darin@apple.com>
darin@apple.com [Sun, 29 Mar 2009 23:53:48 +0000 (23:53 +0000)]
2009-03-29  Darin Adler  <darin@apple.com>

        Try to fix the release build.

        * history/CachedPage.cpp: Make include unconditional, not debug-only.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUndo the previous build fix.
bolsinga@apple.com [Sun, 29 Mar 2009 23:51:29 +0000 (23:51 +0000)]
Undo the previous build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix build break.
bolsinga@apple.com [Sun, 29 Mar 2009 23:44:18 +0000 (23:44 +0000)]
Fix build break.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix ChangeLog.
darin@apple.com [Sun, 29 Mar 2009 23:29:46 +0000 (23:29 +0000)]
Fix ChangeLog.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-03-29 Dmitry Titov <dimich@chromium.org>
darin@apple.com [Sun, 29 Mar 2009 23:29:24 +0000 (23:29 +0000)]
2009-03-29  Dmitry Titov  <dimich@chromium.org>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=24926
        Fix Chromium build break.

        * bindings/v8/custom/V8DOMWindowCustom.cpp:
        (WebCore::CALLBACK_FUNC_DECL(DOMWindowShowModalDialog)): renamed 'features' into 'windowFeatures'.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-03-29 Dmitry Titov <dimich@chromium.org>
dimich@chromium.org [Sun, 29 Mar 2009 23:26:45 +0000 (23:26 +0000)]
2009-03-29  Dmitry Titov  <dimich@chromium.org>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=24926
        Fix Chromium build break.

        * bindings/v8/custom/V8DOMWindowCustom.cpp:
        (WebCore::CALLBACK_FUNC_DECL(DOMWindowShowModalDialog)): renamed 'features' into 'windowFeatures'.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42088 268f45cc-cd09-0410-ab3c-d52691b4dbfc