dglazkov@chromium.org [Thu, 5 Feb 2009 23:36:10 +0000 (23:36 +0000)]
2009-02-05 Scott Violet <sky@google.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=23687
Wires up Skia'a ImageBuffer::toDataURL to support pngs.
This helps Chromium pass a couple of layout tests.
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::toDataURL):
* platform/image-encoders: Added.
* platform/image-encoders/skia: Added.
* platform/image-encoders/skia/PNGImageEncoder.cpp: Added.
(WebCore::):
(WebCore::PngEncoderState::EncoderWriteCallback):
(WebCore::PngEncoderState::ConvertBGRAtoRGB):
(WebCore::PngEncoderState::PngWriteStructDestroyer::PngWriteStructDestroyer):
(WebCore::PngEncoderState::PngWriteStructDestroyer::~PngWriteStructDestroyer):
(WebCore::PNGImageEncoder::encode):
* platform/image-encoders/skia/PNGImageEncoder.h: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40692
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Thu, 5 Feb 2009 23:34:31 +0000 (23:34 +0000)]
2009-02-05 Sam Weinig <sam@webkit.org>
Reviewed by Darin Adler.
Fix missing checked cast.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::containingBlock):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40691
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Thu, 5 Feb 2009 23:31:09 +0000 (23:31 +0000)]
Not reviewed. Fix WML enabled builds.
FrameLoader::load() got an additional 'lockHistory' parameter, pass 'false'.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40690
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Thu, 5 Feb 2009 23:28:27 +0000 (23:28 +0000)]
2009-02-05 Scott Violet <sky@google.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=23625
Additional fix: Skia platform doesn't render text to a canvas or support clipping to an image buffer
Fixes three bugs in PlatformContextSkia:
* When a new layer was started clipped to an image we used the
assignment operator to copy the SkBitmap. If the SkBitmap owns it's
pixels, this is not the right thing to do. Instead we need to create
a copy of the image.
* State holds an SkBitmap by value. State's copy constructor does a
memcpy. This is confusing and subtle, I've converted to use a member
initializer list which I think is clearer and less error prone.
* When creating a new layer there is no need to copy the clip image.
* platform/graphics/skia/PlatformContextSkia.cpp:
(PlatformContextSkia::State::State):
(PlatformContextSkia::save):
(PlatformContextSkia::beginLayerClippedToImage):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40689
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Thu, 5 Feb 2009 23:24:54 +0000 (23:24 +0000)]
2009-02-05 Scott Violet <sky@google.com>
Reviewed by George Staikos.
https://bugs.webkit.org/show_bug.cgi?id=23462
Changes call from setFillColor to setStrokeColor.
* html/CanvasStyle.cpp:
(WebCore::CanvasStyle::applyStrokeColor):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40688
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Thu, 5 Feb 2009 23:12:11 +0000 (23:12 +0000)]
2009-02-05 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=23767
Add custom V8 bindings for HTML5 database.
* bindings/v8/custom/V8CustomSQLStatementCallback.cpp: Added.
(WebCore::V8CustomSQLStatementCallback::V8CustomSQLStatementCallback):
(WebCore::V8CustomSQLStatementCallback::~V8CustomSQLStatementCallback):
(WebCore::V8CustomSQLStatementCallback::handleEvent):
* bindings/v8/custom/V8CustomSQLStatementCallback.h: Added.
(WebCore::V8CustomSQLStatementCallback::create):
* bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp: Added.
(WebCore::V8CustomSQLStatementErrorCallback::V8CustomSQLStatementErrorCallback):
(WebCore::V8CustomSQLStatementErrorCallback::~V8CustomSQLStatementErrorCallback):
(WebCore::V8CustomSQLStatementErrorCallback::handleEvent):
* bindings/v8/custom/V8CustomSQLStatementErrorCallback.h: Added.
(WebCore::V8CustomSQLStatementErrorCallback::create):
* bindings/v8/custom/V8CustomSQLTransactionCallback.cpp: Added.
(WebCore::V8CustomSQLTransactionCallback::V8CustomSQLTransactionCallback):
(WebCore::V8CustomSQLTransactionCallback::~V8CustomSQLTransactionCallback):
(WebCore::V8CustomSQLTransactionCallback::handleEvent):
* bindings/v8/custom/V8CustomSQLTransactionCallback.h: Added.
(WebCore::V8CustomSQLTransactionCallback::create):
* bindings/v8/custom/V8CustomSQLTransactionErrorCallback.cpp: Added.
(WebCore::V8CustomSQLTransactionErrorCallback::V8CustomSQLTransactionErrorCallback):
(WebCore::V8CustomSQLTransactionErrorCallback::~V8CustomSQLTransactionErrorCallback):
(WebCore::V8CustomSQLTransactionErrorCallback::handleEvent):
* bindings/v8/custom/V8CustomSQLTransactionErrorCallback.h: Added.
(WebCore::V8CustomSQLTransactionErrorCallback::create):
* bindings/v8/custom/V8CustomVoidCallback.cpp: Added.
(WebCore::V8CustomVoidCallback::V8CustomVoidCallback):
(WebCore::V8CustomVoidCallback::~V8CustomVoidCallback):
(WebCore::V8CustomVoidCallback::handleEvent):
(WebCore::invokeCallback):
* bindings/v8/custom/V8CustomVoidCallback.h: Added.
(WebCore::V8CustomVoidCallback::create):
* bindings/v8/custom/V8DatabaseCustom.cpp: Added.
(WebCore::CALLBACK_FUNC_DECL):
* bindings/v8/custom/V8SQLResultSetRowListCustom.cpp: Added.
(WebCore::CALLBACK_FUNC_DECL):
* bindings/v8/custom/V8SQLTransactionCustom.cpp: Added.
(WebCore::CALLBACK_FUNC_DECL):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40687
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Thu, 5 Feb 2009 23:10:25 +0000 (23:10 +0000)]
2009-02-05 David Hyatt <hyatt@apple.com>
Fix crash on svg custom stop test. A virtual function didn't get patched properly.
Reviewed by Sam Weinig
* rendering/RenderObject.cpp:
(WebCore::RenderObject::clippedOverflowRectForRepaint):
* rendering/RenderSVGGradientStop.h:
(WebCore::RenderSVGGradientStop::clippedOverflowRectForRepaint):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40686
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Thu, 5 Feb 2009 23:08:22 +0000 (23:08 +0000)]
2009-02-05 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dave Hyatt
https://bugs.webkit.org/show_bug.cgi?id=23765
Add toRenderBoxModelObject() so that we can cast objects that
can have layers.
Fix getComputedStyle to return the current value of style
properties that are undergoing accelerated animations, by
asking the AnimationController if the property has accelerated
animations, and, if so, asking it to generate an appropriate
style.
Tightened up some type safety (CSSPropertyID), and code clarity
(replace bool with enum).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40685
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Thu, 5 Feb 2009 23:03:27 +0000 (23:03 +0000)]
JavaScriptCore:
2009-02-05 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=23747
Add Chromium threading-related files.
* wtf/MainThread.cpp: Added platform guard to initializeMainThread.
* wtf/chromium/ChromiumThreading.h: Added.
* wtf/chromium/MainThreadChromium.cpp: Added.
(WTF::initializeMainThread):
(WTF::scheduleDispatchFunctionsOnMainThread):
WebCore:
2009-02-05 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=23747
Add Chromium threading-related files.
* platform/chromium/TemporaryLinkStubs.cpp: Removed theading-related stubs.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40684
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Thu, 5 Feb 2009 23:01:44 +0000 (23:01 +0000)]
Fix whitespace in the ChangeLog
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40683
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Thu, 5 Feb 2009 22:45:28 +0000 (22:45 +0000)]
- build fix
* WebView/WebScriptDebugger.mm:
(WebScriptDebugger::initGlobalCallFrame):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40682
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Thu, 5 Feb 2009 22:43:19 +0000 (22:43 +0000)]
2009-02-05 Sam Weinig <sam@webkit.org>
Reviewed by Adam Roben.
Add toRenderButton methods for casting RenderObjects to RenderButtons. The methods will assert if the object
is not a RenderButton. Also add a toRenderButton method that takes a RenderButton but returns void and that
is unimplemented. This method will catch anyone trying to do a cast when the object is already a RenderButton.
* rendering/RenderButton.h:
(WebCore::RenderButton::isRenderButton):
(WebCore::toRenderButton):
* rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::paintObject):
* rendering/RenderObject.h:
(WebCore::RenderObject::isRenderButton):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40681
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin@apple.com [Thu, 5 Feb 2009 22:37:32 +0000 (22:37 +0000)]
2009-02-05 Beth Dakin <bdakin@apple.com>
Reviewed by John Sullivan and Brady Eidson.
Fix for <rdar://problem/
6557595> REGRESSION: In Mail, selecting a
mail note message doesn't display it in Mail's preview pane
This was failing because revision 36962 removed a version of
setVerticalScrollingMode that mail calls. This patch simply adds
that method back.
* WebView/WebDynamicScrollBarsView.m:
(-[WebDynamicScrollBarsView setVerticalScrollingMode:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40680
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Thu, 5 Feb 2009 22:26:53 +0000 (22:26 +0000)]
2009-02-05 David Hyatt <hyatt@apple.com>
Move the m_layer member variable of RenderBox up into RenderBoxModelObject. Refactor styleDidChange'
of RenderObject, RenderBoxModelObject and RenderBox to get more of the code in the correct subclass.
In order to set the various RenderObject bits properly prior to the test for whether a layer is
required, I added an additional method, updateBoxModelInfoAfterStyleChange, that is responsible
for setting all of the bits.
Eliminate hasStaticX/Y, staticX/Y, and setStaticX/Y from the render tree. Move hasStaticX/Y to
RenderStyle, and just use the corresponding layer() methods for the
staticX/Y getters/setters.
Reviewed by Sam Weinig
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::adjustPositionedBlock):
(WebCore::RenderBlock::layoutOnlyPositionedObjects):
(WebCore::RenderBlock::layoutPositionedObjects):
(WebCore::RenderBlock::paintObject):
(WebCore::RenderBlock::nodeAtPoint):
(WebCore::RenderBlock::offsetForContents):
(WebCore::RenderBlock::calcPrefWidths):
(WebCore::RenderBlock::baselinePosition):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::RenderBox):
(WebCore::RenderBox::destroy):
(WebCore::RenderBox::styleWillChange):
(WebCore::RenderBox::styleDidChange):
(WebCore::RenderBox::updateBoxModelInfoFromStyle):
(WebCore::RenderBox::scrollWidth):
(WebCore::RenderBox::scrollHeight):
(WebCore::RenderBox::scrollLeft):
(WebCore::RenderBox::scrollTop):
(WebCore::RenderBox::setScrollLeft):
(WebCore::RenderBox::setScrollTop):
(WebCore::RenderBox::getOverflowClipRect):
(WebCore::RenderBox::localToAbsolute):
(WebCore::RenderBox::absoluteToLocal):
(WebCore::RenderBox::localToContainerQuad):
(WebCore::RenderBox::position):
(WebCore::RenderBox::computeRectForRepaint):
(WebCore::RenderBox::calcAbsoluteHorizontal):
(WebCore::RenderBox::calcAbsoluteVertical):
(WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
(WebCore::RenderBox::calcAbsoluteVerticalReplaced):
* rendering/RenderBox.h:
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::RenderBoxModelObject):
(WebCore::RenderBoxModelObject::destroy):
(WebCore::RenderBoxModelObject::styleWillChange):
(WebCore::RenderBoxModelObject::styleDidChange):
(WebCore::RenderBoxModelObject::updateBoxModelInfoFromStyle):
* rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::layer):
(WebCore::RenderBoxModelObject::requiresLayer):
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::RenderFlexibleBox::layoutHorizontalBox):
(WebCore::RenderFlexibleBox::layoutVerticalBox):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::updateBoxModelInfoFromStyle):
(WebCore::RenderInline::styleDidChange):
(WebCore::RenderInline::relativePositionedInlineOffset):
* rendering/RenderInline.h:
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::setStaticY):
(WebCore::RenderLayer::updateLayerPosition):
* rendering/RenderLayer.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::setStyle):
(WebCore::RenderObject::styleDidChange):
* rendering/RenderObject.h:
(WebCore::RenderObject::markContainingBlocksForLayout):
* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::paint):
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::destroy):
* rendering/bidi.cpp:
(WebCore::appendRunsForObject):
(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::skipTrailingWhitespace):
(WebCore::RenderBlock::skipLeadingWhitespace):
(WebCore::RenderBlock::findNextLineBreak):
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::hasStaticX):
(WebCore::InheritedFlags::hasStaticY):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40679
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Thu, 5 Feb 2009 22:07:35 +0000 (22:07 +0000)]
2009-02-05 David Levin <levin@chromium.org>
Reviewed by Darin Adler.
Bug 23713: COMPILE_ASSERTS should be moved out of TypeTraits.h and into .cpp file
<https://bugs.webkit.org/show_bug.cgi?id=23713>
* GNUmakefile.am:
* JavaScriptCore.pri:
* JavaScriptCore.scons:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* JavaScriptCoreSources.bkl:
* wtf/HashTraits.h:
Remove unnecessary header file that I missed when moving out the type traits form this file.
* wtf/TypeTraits.cpp: Added.
(WTF::):
* wtf/TypeTraits.h:
Moved the compile asserts into TypeTraits.cpp file.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40678
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Thu, 5 Feb 2009 21:18:16 +0000 (21:18 +0000)]
2009-02-05 Sam Weinig <sam@webkit.org>
Fix the windows build.
* bindings/scripts/CodeGeneratorCOM.pm:
* dom/Node.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40677
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 5 Feb 2009 20:58:34 +0000 (20:58 +0000)]
2009-02-05 Anders Carlsson <andersca@apple.com>
Reviewed by Kevin Decker.
Update to match Gecko.
* bridge/npapi.h:
* plugins/npfunctions.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40676
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Thu, 5 Feb 2009 20:35:53 +0000 (20:35 +0000)]
2009-02-05 Sam Weinig <sam@webkit.org>
Reviewed by Darin Adler.
Finish merging EventTargetNode up into Node.
This also fixes a small recently introduced issue where EventListeners
would not be removed from the document if they were attached to comment
nodes outside of the documentElement.
* GNUmakefile.am:
* WebCore.pro:
* WebCore.scons:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* WebCoreSources.bkl:
* bindings/js/JSEventTargetNodeCustom.cpp: Removed.
* bindings/js/JSNodeCustom.cpp:
(WebCore::JSNode::addEventListener):
(WebCore::JSNode::removeEventListener):
(WebCore::JSNode::pushEventHandlerScope):
* bindings/scripts/CodeGenerator.pm:
* dom/CharacterData.cpp:
(WebCore::CharacterData::CharacterData):
(WebCore::CharacterData::rendererIsNeeded):
* dom/CharacterData.h:
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::willRemove):
(WebCore::ContainerNode::attach):
(WebCore::ContainerNode::detach):
(WebCore::ContainerNode::insertedIntoDocument):
(WebCore::ContainerNode::removedFromDocument):
(WebCore::ContainerNode::setFocus):
(WebCore::ContainerNode::setActive):
(WebCore::ContainerNode::setHovered):
(WebCore::dispatchChildInsertionEvents):
(WebCore::dispatchChildRemovalEvents):
* dom/ContainerNode.h:
(WebCore::ContainerNode::ContainerNode):
* dom/Document.cpp:
(WebCore::Document::removeAllEventListenersFromAllNodes):
(WebCore::Document::removeAllDisconnectedNodeEventListeners):
(WebCore::Document::setFocusedNode):
* dom/EventTargetNode.cpp: Removed.
* dom/EventTargetNode.h: Removed.
* dom/Node.cpp:
(WebCore::Node::scriptExecutionContext):
(WebCore::Node::eventListeners):
(WebCore::Node::insertedIntoDocument):
(WebCore::Node::removedFromDocument):
(WebCore::Node::willMoveToNewOwnerDocument):
(WebCore::Node::didMoveToNewOwnerDocument):
(WebCore::updateSVGElementInstancesAfterEventListenerChange):
(WebCore::Node::addEventListener):
(WebCore::Node::removeEventListener):
(WebCore::Node::removeAllEventListenersSlowCase):
(WebCore::Node::handleLocalEvents):
(WebCore::eventTargetAsSVGElementInstance):
(WebCore::eventTargetRespectingSVGTargetRules):
(WebCore::Node::dispatchEvent):
(WebCore::Node::dispatchGenericEvent):
(WebCore::Node::dispatchSubtreeModifiedEvent):
(WebCore::Node::dispatchWindowEvent):
(WebCore::Node::dispatchUIEvent):
(WebCore::Node::dispatchKeyEvent):
(WebCore::Node::dispatchMouseEvent):
(WebCore::Node::dispatchSimulatedMouseEvent):
(WebCore::Node::dispatchSimulatedClick):
(WebCore::Node::dispatchWheelEvent):
(WebCore::Node::dispatchWebKitAnimationEvent):
(WebCore::Node::dispatchWebKitTransitionEvent):
(WebCore::Node::dispatchFocusEvent):
(WebCore::Node::dispatchBlurEvent):
(WebCore::Node::dispatchEventForType):
(WebCore::Node::dispatchProgressEvent):
(WebCore::Node::dispatchStorageEvent):
(WebCore::Node::removeInlineEventListenerForType):
(WebCore::Node::setInlineEventListenerForType):
(WebCore::Node::setInlineEventListenerForTypeAndAttribute):
(WebCore::Node::inlineEventListenerForType):
(WebCore::Node::disabled):
(WebCore::Node::defaultEventHandler):
(WebCore::Node::onabort):
(WebCore::Node::setOnabort):
(WebCore::Node::onblur):
(WebCore::Node::setOnblur):
(WebCore::Node::onchange):
(WebCore::Node::setOnchange):
(WebCore::Node::onclick):
(WebCore::Node::setOnclick):
(WebCore::Node::oncontextmenu):
(WebCore::Node::setOncontextmenu):
(WebCore::Node::ondblclick):
(WebCore::Node::setOndblclick):
(WebCore::Node::onerror):
(WebCore::Node::setOnerror):
(WebCore::Node::onfocus):
(WebCore::Node::setOnfocus):
(WebCore::Node::oninput):
(WebCore::Node::setOninput):
(WebCore::Node::onkeydown):
(WebCore::Node::setOnkeydown):
(WebCore::Node::onkeypress):
(WebCore::Node::setOnkeypress):
(WebCore::Node::onkeyup):
(WebCore::Node::setOnkeyup):
(WebCore::Node::onload):
(WebCore::Node::setOnload):
(WebCore::Node::onmousedown):
(WebCore::Node::setOnmousedown):
(WebCore::Node::onmousemove):
(WebCore::Node::setOnmousemove):
(WebCore::Node::onmouseout):
(WebCore::Node::setOnmouseout):
(WebCore::Node::onmouseover):
(WebCore::Node::setOnmouseover):
(WebCore::Node::onmouseup):
(WebCore::Node::setOnmouseup):
(WebCore::Node::onmousewheel):
(WebCore::Node::setOnmousewheel):
(WebCore::Node::onbeforecut):
(WebCore::Node::setOnbeforecut):
(WebCore::Node::oncut):
(WebCore::Node::setOncut):
(WebCore::Node::onbeforecopy):
(WebCore::Node::setOnbeforecopy):
(WebCore::Node::oncopy):
(WebCore::Node::setOncopy):
(WebCore::Node::onbeforepaste):
(WebCore::Node::setOnbeforepaste):
(WebCore::Node::onpaste):
(WebCore::Node::setOnpaste):
(WebCore::Node::ondragenter):
(WebCore::Node::setOndragenter):
(WebCore::Node::ondragover):
(WebCore::Node::setOndragover):
(WebCore::Node::ondragleave):
(WebCore::Node::setOndragleave):
(WebCore::Node::ondrop):
(WebCore::Node::setOndrop):
(WebCore::Node::ondragstart):
(WebCore::Node::setOndragstart):
(WebCore::Node::ondrag):
(WebCore::Node::setOndrag):
(WebCore::Node::ondragend):
(WebCore::Node::setOndragend):
(WebCore::Node::onreset):
(WebCore::Node::setOnreset):
(WebCore::Node::onresize):
(WebCore::Node::setOnresize):
(WebCore::Node::onscroll):
(WebCore::Node::setOnscroll):
(WebCore::Node::onsearch):
(WebCore::Node::setOnsearch):
(WebCore::Node::onselect):
(WebCore::Node::setOnselect):
(WebCore::Node::onselectstart):
(WebCore::Node::setOnselectstart):
(WebCore::Node::onsubmit):
(WebCore::Node::setOnsubmit):
(WebCore::Node::onunload):
(WebCore::Node::setOnunload):
* dom/Node.h:
* editing/Editor.cpp:
(WebCore::Editor::dispatchCPPEvent):
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::handleLocalEvents):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::defaultEventHandler):
* html/HTMLTokenizer.cpp:
(WebCore::HTMLTokenizer::notifyFinished):
* loader/MediaDocument.cpp:
(WebCore::MediaDocument::defaultEventHandler):
* page/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::mouseButtonListener):
* page/EventHandler.cpp:
(WebCore::EventHandler::dispatchDragEvent):
(WebCore::EventHandler::updateMouseEventTargetNode):
(WebCore::EventHandler::dispatchMouseEvent):
(WebCore::EventHandler::handleWheelEvent):
(WebCore::EventHandler::canMouseDownStartSelect):
(WebCore::EventHandler::canMouseDragExtendSelect):
(WebCore::eventTargetNodeForDocument):
(WebCore::EventHandler::keyEvent):
* page/FrameView.cpp:
(WebCore::FrameView::scheduleEvent):
(WebCore::FrameView::updateOverflowStatus):
* page/FrameView.h:
* page/Page.cpp:
(WebCore::networkStateChanged):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollToOffset):
(WebCore::RenderLayer::updateOverflowStatus):
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::valueChanged):
* rendering/RenderMedia.h:
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::selectionChanged):
* svg/SVGElementInstance.h:
(WebCore::SVGElementInstance::toNode):
* xml/XPathExpression.cpp:
(WebCore::XPathExpression::evaluate):
* xml/XPathResult.cpp:
(WebCore::XPathResult::XPathResult):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40675
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
treat@webkit.org [Thu, 5 Feb 2009 20:25:51 +0000 (20:25 +0000)]
2009-02-05 Adam Treat <adam.treat@torchmobile.com>
Fix the Qt build now that EventTargetNode.idl was removed in r40672.
* WebCore.pro:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40674
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@chromium.org [Thu, 5 Feb 2009 20:14:24 +0000 (20:14 +0000)]
2009-02-05 Scott Violet <sky@google.com>
Reviewed by Sam Weinig.
Bug 23462: Add RGB -> CMYK conversion algorithm
<https://bugs.webkit.org/show_bug.cgi?id=23462>
Adds an RGB -> CMYK converter. This isn't perfect, but better than
nothing.
* html/CanvasStyle.cpp:
(WebCore::CanvasStyle::applyStrokeColor):
(WebCore::CanvasStyle::applyFillColor):
(WebCore::CanvasStyle::cmykToRGB):
* html/CanvasStyle.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40673
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Thu, 5 Feb 2009 18:38:32 +0000 (18:38 +0000)]
WebCore:
2009-02-04 Sam Weinig <sam@webkit.org>
Reviewed by Darin Adler.
First stage of merging EventTargetNode up into Node. The intent of this change
is to both simplify the inheritance hierarchy (at the same time making it more
closely match the spec which states that all Nodes are EventTargets) and save
4 bytes per Node that the polymorphic multiple-inheritance was costing us.
This does the bare minimum to get things compiling, the next patch will clean
* DerivedSources.make:
* WebCore.base.exp:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSDocumentCustom.cpp:
(WebCore::JSDocument::mark):
* bindings/js/JSEventListener.cpp:
(WebCore::JSLazyEventListener::parseCode):
* bindings/js/JSEventTarget.cpp:
(WebCore::toEventTarget):
* bindings/js/JSEventTarget.h:
* bindings/js/JSEventTargetNodeCustom.cpp:
(WebCore::JSNode::addEventListener):
(WebCore::JSNode::removeEventListener):
(WebCore::JSNode::pushEventHandlerScope):
* bindings/js/JSStyleSheetCustom.cpp:
* bindings/scripts/CodeGeneratorJS.pm:
* bindings/scripts/CodeGeneratorObjC.pm:
* dom/Attr.idl:
* dom/CharacterData.h:
* dom/CharacterData.idl:
* dom/Document.idl:
* dom/DocumentFragment.idl:
* dom/Element.idl:
* dom/EventTarget.cpp:
(WebCore::EventTarget::toNode):
* dom/EventTarget.h:
* dom/EventTarget.idl:
* dom/EventTargetNode.cpp:
(WebCore::Node::scriptExecutionContext):
(WebCore::Node::eventListeners):
(WebCore::Node::insertedIntoDocument):
(WebCore::Node::removedFromDocument):
(WebCore::Node::willMoveToNewOwnerDocument):
(WebCore::Node::didMoveToNewOwnerDocument):
(WebCore::Node::addEventListener):
(WebCore::Node::removeEventListener):
(WebCore::Node::removeAllEventListenersSlowCase):
(WebCore::Node::handleLocalEvents):
(WebCore::Node::dispatchEvent):
(WebCore::Node::dispatchGenericEvent):
(WebCore::Node::dispatchSubtreeModifiedEvent):
(WebCore::Node::dispatchWindowEvent):
(WebCore::Node::dispatchUIEvent):
(WebCore::Node::dispatchKeyEvent):
(WebCore::Node::dispatchMouseEvent):
(WebCore::Node::dispatchSimulatedMouseEvent):
(WebCore::Node::dispatchSimulatedClick):
(WebCore::Node::dispatchWheelEvent):
(WebCore::Node::dispatchWebKitAnimationEvent):
(WebCore::Node::dispatchWebKitTransitionEvent):
(WebCore::Node::dispatchFocusEvent):
(WebCore::Node::dispatchBlurEvent):
(WebCore::Node::dispatchEventForType):
(WebCore::Node::dispatchProgressEvent):
(WebCore::Node::dispatchStorageEvent):
(WebCore::Node::removeInlineEventListenerForType):
(WebCore::Node::setInlineEventListenerForType):
(WebCore::Node::setInlineEventListenerForTypeAndAttribute):
(WebCore::Node::inlineEventListenerForType):
(WebCore::Node::disabled):
(WebCore::Node::defaultEventHandler):
(WebCore::Node::onabort):
(WebCore::Node::setOnabort):
(WebCore::Node::onblur):
(WebCore::Node::setOnblur):
(WebCore::Node::onchange):
(WebCore::Node::setOnchange):
(WebCore::Node::onclick):
(WebCore::Node::setOnclick):
(WebCore::Node::oncontextmenu):
(WebCore::Node::setOncontextmenu):
(WebCore::Node::ondblclick):
(WebCore::Node::setOndblclick):
(WebCore::Node::onerror):
(WebCore::Node::setOnerror):
(WebCore::Node::onfocus):
(WebCore::Node::setOnfocus):
(WebCore::Node::oninput):
(WebCore::Node::setOninput):
(WebCore::Node::onkeydown):
(WebCore::Node::setOnkeydown):
(WebCore::Node::onkeypress):
(WebCore::Node::setOnkeypress):
(WebCore::Node::onkeyup):
(WebCore::Node::setOnkeyup):
(WebCore::Node::onload):
(WebCore::Node::setOnload):
(WebCore::Node::onmousedown):
(WebCore::Node::setOnmousedown):
(WebCore::Node::onmousemove):
(WebCore::Node::setOnmousemove):
(WebCore::Node::onmouseout):
(WebCore::Node::setOnmouseout):
(WebCore::Node::onmouseover):
(WebCore::Node::setOnmouseover):
(WebCore::Node::onmouseup):
(WebCore::Node::setOnmouseup):
(WebCore::Node::onmousewheel):
(WebCore::Node::setOnmousewheel):
(WebCore::Node::onbeforecut):
(WebCore::Node::setOnbeforecut):
(WebCore::Node::oncut):
(WebCore::Node::setOncut):
(WebCore::Node::onbeforecopy):
(WebCore::Node::setOnbeforecopy):
(WebCore::Node::oncopy):
(WebCore::Node::setOncopy):
(WebCore::Node::onbeforepaste):
(WebCore::Node::setOnbeforepaste):
(WebCore::Node::onpaste):
(WebCore::Node::setOnpaste):
(WebCore::Node::ondragenter):
(WebCore::Node::setOndragenter):
(WebCore::Node::ondragover):
(WebCore::Node::setOndragover):
(WebCore::Node::ondragleave):
(WebCore::Node::setOndragleave):
(WebCore::Node::ondrop):
(WebCore::Node::setOndrop):
(WebCore::Node::ondragstart):
(WebCore::Node::setOndragstart):
(WebCore::Node::ondrag):
(WebCore::Node::setOndrag):
(WebCore::Node::ondragend):
(WebCore::Node::setOndragend):
(WebCore::Node::onreset):
(WebCore::Node::setOnreset):
(WebCore::Node::onresize):
(WebCore::Node::setOnresize):
(WebCore::Node::onscroll):
(WebCore::Node::setOnscroll):
(WebCore::Node::onsearch):
(WebCore::Node::setOnsearch):
(WebCore::Node::onselect):
(WebCore::Node::setOnselect):
(WebCore::Node::onselectstart):
(WebCore::Node::setOnselectstart):
(WebCore::Node::onsubmit):
(WebCore::Node::setOnsubmit):
(WebCore::Node::onunload):
(WebCore::Node::setOnunload):
* dom/EventTargetNode.h:
(WebCore::toEventTargetNode):
(WebCore::EventTargetNodeCast):
* dom/EventTargetNode.idl: Removed.
* dom/MouseEvent.cpp:
(WebCore::MouseEvent::MouseEvent):
(WebCore::MouseEvent::initMouseEvent):
(WebCore::MouseEvent::toElement):
(WebCore::MouseEvent::fromElement):
* dom/MouseEvent.h:
(WebCore::MouseEvent::create):
(WebCore::MouseEvent::relatedTarget):
* dom/Node.cpp:
(WebCore::Node::~Node):
* dom/Node.h:
(WebCore::Node::isEventTargetNode):
(WebCore::Node::toNode):
(WebCore::Node::removeAllEventListeners):
(WebCore::Node::refEventTarget):
(WebCore::Node::derefEventTarget):
* dom/Node.idl:
* page/EventHandler.h:
* page/FrameView.h:
* xml/XPathResult.h:
(WebCore::XPathResult::create):
LayoutTests:
2009-02-05 Sam Weinig <sam@webkit.org>
Reviewed by Darin Layer.
Fix after merging EventTargetNode up into Node.
* fast/dom/Window/window-properties-expected.txt:
* fast/dom/prototype-chain-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40672
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Thu, 5 Feb 2009 17:24:00 +0000 (17:24 +0000)]
2009-02-04 David Hyatt <hyatt@apple.com>
Convert RenderLayer from having a RenderBox* m_renderer to having a RenderBoxModelObject*. The
container-relative repaint methods all had to be changed as a result to use RenderBoxModelObject* also.
All of RenderLayer.cpp now uses what will be the new style for dealing with an object that can be a block
or an inline flow. x()/y()/width()/height() can't be queried on an inline flow, nor can many other
properties (like scrollWidth() / scrollHeight()), so the code has to be tightened up to convert to RenderBox
under the right conditions.
There was a bogus subtraction of renderer()->y() in localBounding box for RenderInlines. Since y was always
0, this subtraction wasn't necessary. It has been removed.
Reviewed by Adam Roben
* page/animation/AnimationBase.cpp:
* rendering/RenderBR.h:
(WebCore::RenderBR::selectionRectForRepaint):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::selectionGapRectsForRepaint):
(WebCore::RenderBlock::rectWithOutlineForRepaint):
* rendering/RenderBlock.h:
(WebCore::RenderBlock::selectionRectForRepaint):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::outlineBoundsForRepaint):
(WebCore::RenderBox::localToContainerQuad):
(WebCore::RenderBox::clippedOverflowRectForRepaint):
(WebCore::RenderBox::computeRectForRepaint):
* rendering/RenderBox.h:
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::relativePositionOffsetX):
(WebCore::RenderBoxModelObject::relativePositionOffsetY):
* rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::relativePositionOffset):
* rendering/RenderForeignObject.cpp:
(WebCore::RenderForeignObject::computeRectForRepaint):
* rendering/RenderForeignObject.h:
* rendering/RenderInline.cpp:
(WebCore::RenderInline::clippedOverflowRectForRepaint):
(WebCore::RenderInline::rectWithOutlineForRepaint):
* rendering/RenderInline.h:
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::updateLayerPositions):
(WebCore::RenderLayer::updateTransform):
(WebCore::RenderLayer::setHasVisibleContent):
(WebCore::RenderLayer::updateLayerPosition):
(WebCore::RenderLayer::scrollToOffset):
(WebCore::RenderLayer::scrollRectToVisible):
(WebCore::resizerCornerRect):
(WebCore::RenderLayer::scrollbarCornerPresent):
(WebCore::RenderLayer::invalidateScrollbarRect):
(WebCore::RenderLayer::positionOverflowControls):
(WebCore::RenderLayer::computeScrollDimensions):
(WebCore::RenderLayer::updateScrollInfoAfterLayout):
(WebCore::RenderLayer::paintScrollCorner):
(WebCore::RenderLayer::paintResizer):
(WebCore::RenderLayer::isPointInResizeControl):
(WebCore::RenderLayer::hitTestOverflowControls):
(WebCore::RenderLayer::paintLayer):
(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::localBoundingBox):
* rendering/RenderLayer.h:
(WebCore::RenderLayer::renderer):
(WebCore::RenderLayer::renderBox):
(WebCore::RenderLayer::renderBoxX):
(WebCore::RenderLayer::renderBoxY):
* rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::selectionRectForRepaint):
* rendering/RenderListMarker.h:
* rendering/RenderMarquee.cpp:
(WebCore::RenderMarquee::computePosition):
(WebCore::RenderMarquee::timerFired):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::containerForRepaint):
(WebCore::RenderObject::repaintUsingContainer):
(WebCore::RenderObject::repaint):
(WebCore::RenderObject::repaintRectangle):
(WebCore::RenderObject::repaintAfterLayoutIfNeeded):
(WebCore::RenderObject::rectWithOutlineForRepaint):
(WebCore::RenderObject::clippedOverflowRectForRepaint):
(WebCore::RenderObject::computeRectForRepaint):
(WebCore::RenderObject::localToContainerQuad):
* rendering/RenderObject.h:
(WebCore::RenderObject::selectionRectForRepaint):
(WebCore::RenderObject::outlineBoundsForRepaint):
* rendering/RenderPath.cpp:
(WebCore::RenderPath::clippedOverflowRectForRepaint):
(WebCore::RenderPath::outlineBoundsForRepaint):
* rendering/RenderPath.h:
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::selectionRectForRepaint):
(WebCore::RenderReplaced::clippedOverflowRectForRepaint):
* rendering/RenderReplaced.h:
* rendering/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::clippedOverflowRectForRepaint):
(WebCore::RenderSVGContainer::outlineBoundsForRepaint):
* rendering/RenderSVGContainer.h:
* rendering/RenderSVGHiddenContainer.cpp:
(WebCore::RenderSVGHiddenContainer::clippedOverflowRectForRepaint):
* rendering/RenderSVGHiddenContainer.h:
* rendering/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::clippedOverflowRectForRepaint):
* rendering/RenderSVGImage.h:
* rendering/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::selectionRectForRepaint):
(WebCore::RenderSVGInlineText::computeRepaintRectForRange):
* rendering/RenderSVGInlineText.h:
* rendering/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::clippedOverflowRectForRepaint):
* rendering/RenderSVGRoot.h:
* rendering/RenderSVGText.cpp:
(WebCore::RenderSVGText::clippedOverflowRectForRepaint):
* rendering/RenderSVGText.h:
* rendering/RenderSelectionInfo.h:
(WebCore::RenderSelectionInfoBase::repaintContainer):
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::clippedOverflowRectForRepaint):
(WebCore::RenderTableCell::computeRectForRepaint):
(WebCore::RenderTableCell::localToContainerQuad):
* rendering/RenderTableCell.h:
* rendering/RenderTableCol.cpp:
(WebCore::RenderTableCol::clippedOverflowRectForRepaint):
* rendering/RenderTableCol.h:
* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::clippedOverflowRectForRepaint):
* rendering/RenderTableRow.h:
* rendering/RenderText.cpp:
(WebCore::RenderText::clippedOverflowRectForRepaint):
(WebCore::RenderText::selectionRectForRepaint):
* rendering/RenderText.h:
* rendering/RenderTreeAsText.cpp:
(WebCore::write):
* rendering/RenderView.cpp:
(WebCore::RenderView::localToContainerQuad):
(WebCore::RenderView::computeRectForRepaint):
* rendering/RenderView.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40671
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Thu, 5 Feb 2009 14:38:39 +0000 (14:38 +0000)]
Build fix.
* page/animation/KeyframeAnimation.h: A function prototype had two "fromStyle" arguments.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40670
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Thu, 5 Feb 2009 14:34:28 +0000 (14:34 +0000)]
2009-02-05 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Alexey Proskuryakov.
Landed by Simon Hausmann.
https://bugs.webkit.org/show_bug.cgi?id=23733
Use a 2 arguments constructor for KURL to avoid ASSERT failure.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40669
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Thu, 5 Feb 2009 07:27:34 +0000 (07:27 +0000)]
2009-02-04 Feng Qian <feng@chromium.org>
Reviewed by Darin Adler.
Add Android-specific files to WebCore/editing directory.
https://bugs.webkit.org/show_bug.cgi?id=23294
* editing/android: Added.
* editing/android/EditorAndroid.cpp: Added.
(WebCore::Editor::newGeneralClipboard):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40668
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Thu, 5 Feb 2009 07:23:55 +0000 (07:23 +0000)]
WebCore:
2009-02-04 Dean Jackson <dino@apple.com>
Reviewed by Darin Adler.
Remove -webkit-animation-play-state
The AnimationController still has the code to execute the property, but
it is no longer parsed or recorded.
https://bugs.webkit.org/show_bug.cgi?id=22907
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseAnimationProperty):
* css/CSSParser.h:
* css/CSSPropertyNames.in:
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
* css/CSSStyleSelector.h:
* platform/animation/Animation.h:
* rendering/style/RenderStyleConstants.h:
LayoutTests:
2009-02-04 Dean Jackson <dino@apple.com>
Reviewed by Darin Adler.
Remove animation-play-state from expected properties.
https://bugs.webkit.org/show_bug.cgi?id=22907
* animations/computed-style-expected.txt:
* animations/computed-style.html:
* fast/css/computed-style-display-none-expected.txt:
* fast/css/computed-style-expected.txt:
* fast/css/computed-style-without-renderer-expected.txt:
* fast/css/computed-style-without-renderer.html:
* svg/css/getComputedStyle-basic-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40667
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Thu, 5 Feb 2009 06:41:19 +0000 (06:41 +0000)]
WebCore:
2009-02-04 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Darin Adler.
Make sure we don't load on removing the media element from the document
https://bugs.webkit.org/show_bug.cgi?id=22105
Test: media/remove-from-document-no-load.html
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::removedFromDocument):
LayoutTests:
2009-02-04 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Darin Adler.
Make sure we don't load on removing the media element from the document
https://bugs.webkit.org/show_bug.cgi?id=22105.
* media/remove-from-document-no-load-expected.txt: Added.
* media/remove-from-document-no-load.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40666
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Thu, 5 Feb 2009 06:15:11 +0000 (06:15 +0000)]
2009-02-04 David Hyatt <hyatt@apple.com>
Add a new RenderBoxModelObject class that will eventually act as the direct base class for RenderInlines. For
now just adding the class and putting it in between RenderObject and RenderBox in the hierarchy. RenderInline remains
derived from RenderBox for now.
Reviewed by Sam Weinig
* WebCore.xcodeproj/project.pbxproj:
* rendering/RenderBox.cpp:
(WebCore::RenderBox::RenderBox):
(WebCore::RenderBox::destroy):
(WebCore::RenderBox::styleWillChange):
(WebCore::RenderBox::styleDidChange):
(WebCore::RenderBox::computeRectForRepaint):
* rendering/RenderBox.h:
* rendering/RenderBoxModelObject.cpp: Added.
(WebCore::RenderBoxModelObject::RenderBoxModelObject):
(WebCore::RenderBoxModelObject::~RenderBoxModelObject):
* rendering/RenderBoxModelObject.h: Added.
* rendering/RenderObject.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40665
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Thu, 5 Feb 2009 06:07:27 +0000 (06:07 +0000)]
2009-02-04 Chris Marrin <cmarrin@apple.com>
Reviewed by Dave Hyatt
Added accelerated animation support to AnimationController and friends. The primary
changes are:
* accelerated animations get their start time from the compositing engine, so we
wait for a callback (notifyAnimationStarted()) in order to get the start time.
* if software and accelerated animations start in the same cycle, they all need
to use the same start time, which is that of the accelerated animations.
Added AnimationControllerPrivate to preserve the encapsulation under
AnimationController.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40664
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Thu, 5 Feb 2009 05:31:40 +0000 (05:31 +0000)]
2009-02-04 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver 'the nun' Hunt.
Add -e switch to jsc to enable evaluation of scripts passed on the command line.
* jsc.cpp:
(Script::Script):
(runWithScripts):
(printUsageStatement):
(parseArguments):
(jscmain):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40663
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Thu, 5 Feb 2009 04:18:29 +0000 (04:18 +0000)]
2009-02-04 Dimitri Glazkov <dglazkov@chromium.org>
Not reviewed, build fix.
Remove duplicate definition of msSans in FontCache::alternateFamilyName.
* platform/graphics/FontCache.cpp:
(WebCore::alternateFamilyName):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40662
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Thu, 5 Feb 2009 04:07:17 +0000 (04:07 +0000)]
2009-02-04 Dmitry Titov <dimich@chromium.org>
Not reviewed, build fix.
https://bugs.webkit.org/show_bug.cgi?id=22806
Reverting the test that should not yet be landed since it depends on
changes in DRT which were not yet landed.
* fast/dom/Window/cached-timeout-stopped-on-close-expected.txt: Removed.
* fast/dom/Window/cached-timeout-stopped-on-close.html: Removed.
* fast/dom/Window/resources/cached-timeout-page-1.html: Removed.
* fast/dom/Window/resources/cached-timeout-page-2.html: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40661
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Thu, 5 Feb 2009 03:40:39 +0000 (03:40 +0000)]
2009-02-04 Gavin Barraclough <barraclough@apple.com>
Rubber stamped by Sam 'Big Mac' Weinig.
* assembler/AbstractMacroAssembler.h: Copied from assembler/MacroAssembler.h.
* assembler/MacroAssemblerX86.h: Copied from assembler/MacroAssembler.h.
* assembler/MacroAssemblerX86Common.h: Copied from assembler/MacroAssembler.h.
* assembler/MacroAssemblerX86_64.h: Copied from assembler/MacroAssembler.h.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40660
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Thu, 5 Feb 2009 02:01:25 +0000 (02:01 +0000)]
2009-02-04 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
This patch tidies up the MacroAssembler, cleaning up the code and refactoring out the
platform-specific parts. The MacroAssembler gets split up like a beef burger, with the
platform-agnostic data types being the lower bun (in the form of the class AbstractMacroAssembler),
the plaform-specific code generation forming a big meaty patty of methods like 'add32',
'branch32', etc (MacroAssemblerX86), and finally topped off with the bun-lid of the
MacroAssembler class itself, providing covenience methods such as the stack peek & poke,
and backwards branch methods, all of which can be described in a platform independent
way using methods from the base class. The AbstractMacroAssembler is templated on the
type of the assembler class that will be used for code generation, and the three layers
are held together with the cocktail stick of inheritance.
The above description is a slight simplification since the MacroAssemblerX86 is actually
formed from two layers (in effect giving us a kind on bacon double cheeseburger) - with the
bulk of methods that are common between x86 & x86-64 implemented in MacroAssemblerX86Common,
which forms a base class for MacroAssemblerX86 and MacroAssemblerX86_64 (which add the methods
specific to the given platform).
I'm landing these changes first without splitting the classes across multiple files,
I will follow up with a second patch to split up the file MacroAssembler.h.
* assembler/MacroAssembler.h:
(JSC::AbstractMacroAssembler::):
(JSC::AbstractMacroAssembler::DataLabelPtr::DataLabelPtr):
(JSC::AbstractMacroAssembler::DataLabelPtr::patch):
(JSC::AbstractMacroAssembler::DataLabel32::DataLabel32):
(JSC::AbstractMacroAssembler::DataLabel32::patch):
(JSC::AbstractMacroAssembler::Label::Label):
(JSC::AbstractMacroAssembler::Jump::Jump):
(JSC::AbstractMacroAssembler::Jump::link):
(JSC::AbstractMacroAssembler::Jump::linkTo):
(JSC::AbstractMacroAssembler::Jump::patch):
(JSC::AbstractMacroAssembler::JumpList::link):
(JSC::AbstractMacroAssembler::JumpList::linkTo):
(JSC::AbstractMacroAssembler::PatchBuffer::link):
(JSC::AbstractMacroAssembler::PatchBuffer::addressOf):
(JSC::AbstractMacroAssembler::PatchBuffer::setPtr):
(JSC::AbstractMacroAssembler::size):
(JSC::AbstractMacroAssembler::copyCode):
(JSC::AbstractMacroAssembler::label):
(JSC::AbstractMacroAssembler::align):
(JSC::AbstractMacroAssembler::differenceBetween):
(JSC::MacroAssemblerX86Common::xor32):
(JSC::MacroAssemblerX86Common::load32WithAddressOffsetPatch):
(JSC::MacroAssemblerX86Common::store32WithAddressOffsetPatch):
(JSC::MacroAssemblerX86Common::move):
(JSC::MacroAssemblerX86Common::swap):
(JSC::MacroAssemblerX86Common::signExtend32ToPtr):
(JSC::MacroAssemblerX86Common::zeroExtend32ToPtr):
(JSC::MacroAssemblerX86Common::branch32):
(JSC::MacroAssemblerX86Common::jump):
(JSC::MacroAssemblerX86_64::add32):
(JSC::MacroAssemblerX86_64::sub32):
(JSC::MacroAssemblerX86_64::load32):
(JSC::MacroAssemblerX86_64::store32):
(JSC::MacroAssemblerX86_64::addPtr):
(JSC::MacroAssemblerX86_64::andPtr):
(JSC::MacroAssemblerX86_64::orPtr):
(JSC::MacroAssemblerX86_64::rshiftPtr):
(JSC::MacroAssemblerX86_64::subPtr):
(JSC::MacroAssemblerX86_64::xorPtr):
(JSC::MacroAssemblerX86_64::loadPtr):
(JSC::MacroAssemblerX86_64::loadPtrWithAddressOffsetPatch):
(JSC::MacroAssemblerX86_64::storePtr):
(JSC::MacroAssemblerX86_64::storePtrWithAddressOffsetPatch):
(JSC::MacroAssemblerX86_64::branchPtr):
(JSC::MacroAssemblerX86_64::branchTestPtr):
(JSC::MacroAssemblerX86_64::branchAddPtr):
(JSC::MacroAssemblerX86_64::branchSubPtr):
(JSC::MacroAssemblerX86_64::branchPtrWithPatch):
(JSC::MacroAssemblerX86_64::storePtrWithPatch):
(JSC::MacroAssemblerX86::add32):
(JSC::MacroAssemblerX86::sub32):
(JSC::MacroAssemblerX86::load32):
(JSC::MacroAssemblerX86::store32):
(JSC::MacroAssemblerX86::branch32):
(JSC::MacroAssemblerX86::branchPtrWithPatch):
(JSC::MacroAssemblerX86::storePtrWithPatch):
(JSC::MacroAssembler::pop):
(JSC::MacroAssembler::peek):
(JSC::MacroAssembler::poke):
(JSC::MacroAssembler::branchPtr):
(JSC::MacroAssembler::branch32):
(JSC::MacroAssembler::branch16):
(JSC::MacroAssembler::branchTestPtr):
(JSC::MacroAssembler::addPtr):
(JSC::MacroAssembler::andPtr):
(JSC::MacroAssembler::orPtr):
(JSC::MacroAssembler::rshiftPtr):
(JSC::MacroAssembler::subPtr):
(JSC::MacroAssembler::xorPtr):
(JSC::MacroAssembler::loadPtr):
(JSC::MacroAssembler::loadPtrWithAddressOffsetPatch):
(JSC::MacroAssembler::storePtr):
(JSC::MacroAssembler::storePtrWithAddressOffsetPatch):
(JSC::MacroAssembler::branchAddPtr):
(JSC::MacroAssembler::branchSubPtr):
* jit/JITArithmetic.cpp:
(JSC::JIT::compileBinaryArithOp):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40656
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 5 Feb 2009 01:49:49 +0000 (01:49 +0000)]
2009-02-04 Anders Carlsson <andersca@apple.com>
Build fix fix.
* WebView/WebScriptDebugger.mm:
(WebScriptDebugger::initGlobalCallFrame):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40655
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 5 Feb 2009 01:26:15 +0000 (01:26 +0000)]
Reviewed by George Staikos.
Reverse the meaning of the if check so that Android
(dpad devices) do not scroll on focus and normal platforms do
http://trac.webkit.org/changeset/40647
This was caught by George Staikos, and I wrote the patch.
* dom/Element.cpp:
(WebCore::Element::updateFocusAppearance):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40654
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 5 Feb 2009 01:18:34 +0000 (01:18 +0000)]
2009-02-04 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Change PCHasProperty, PCHasMethod and PCGetProperty into simpleroutines.
Rename PHEvaluateReply to PHBooleanAndDataReply and add PHBooleanReply.
* Plugins/Hosted/NetscapePluginHostProxy.mm:
(WKPCEvaluate):
(WKPCInvoke):
(WKPCGetProperty):
(WKPCHasProperty):
(WKPCHasMethod):
* Plugins/Hosted/WebKitPluginClient.defs:
* Plugins/Hosted/WebKitPluginHost.defs:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40653
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Thu, 5 Feb 2009 01:02:58 +0000 (01:02 +0000)]
2009-02-04 Geoffrey Garen <ggaren@apple.com>
Build fix.
* WebHistory.cpp:
(WebHistory::visitedURL):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40652
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Thu, 5 Feb 2009 00:53:38 +0000 (00:53 +0000)]
2009-02-04 David Hyatt <hyatt@apple.com>
Eliminate RenderContainer.
Reviewed by Sam and Anders
* GNUmakefile.am:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* WebCoreSources.bkl:
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::RenderBlock):
(WebCore::RenderBlock::destroy):
(WebCore::RenderBlock::styleWillChange):
(WebCore::RenderBlock::styleDidChange):
(WebCore::RenderBlock::addChild):
(WebCore::RenderBlock::dirtyLineBoxes):
(WebCore::RenderBlock::createInlineBox):
(WebCore::RenderBlock::removeChild):
(WebCore::RenderBlock::setSelectionState):
(WebCore::RenderBlock::avoidsFloats):
(WebCore::RenderBlock::positionForCoordinates):
(WebCore::RenderBlock::calcInlinePrefWidths):
(WebCore::RenderBlock::baselinePosition):
(WebCore::RenderBlock::getBaselineOfFirstLineBox):
(WebCore::RenderBlock::getBaselineOfLastLineBox):
(WebCore::RenderBlock::rectWithOutlineForRepaint):
(WebCore::RenderBlock::hoverAncestor):
(WebCore::RenderBlock::updateDragState):
(WebCore::RenderBlock::localCaretRect):
* rendering/RenderBlock.h:
(WebCore::RenderBlock::virtualChildren):
(WebCore::RenderBlock::children):
* rendering/RenderContainer.cpp: Removed.
* rendering/RenderContainer.h: Removed.
* rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::RenderFrameSet):
(WebCore::RenderFrameSet::nodeAtPoint):
(WebCore::RenderFrameSet::layout):
* rendering/RenderFrameSet.h:
(WebCore::RenderFrameSet::virtualChildren):
(WebCore::RenderFrameSet::children):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::RenderInline):
(WebCore::RenderInline::destroy):
(WebCore::RenderInline::styleDidChange):
(WebCore::nextContinuation):
(WebCore::RenderInline::continuationBefore):
(WebCore::RenderInline::addChildIgnoringContinuation):
(WebCore::RenderInline::splitInlines):
(WebCore::RenderInline::splitFlow):
(WebCore::RenderInline::addChildToContinuation):
(WebCore::RenderInline::offsetLeft):
(WebCore::RenderInline::offsetTop):
(WebCore::RenderInline::positionForCoordinates):
(WebCore::RenderInline::clippedOverflowRectForRepaint):
(WebCore::RenderInline::rectWithOutlineForRepaint):
(WebCore::RenderInline::updateDragState):
(WebCore::RenderInline::childBecameNonInline):
* rendering/RenderInline.h:
(WebCore::RenderInline::virtualChildren):
(WebCore::RenderInline::children):
(WebCore::RenderInline::continuation):
(WebCore::RenderInline::setContinuation):
* rendering/RenderLineBoxList.h:
* rendering/RenderObject.h:
* rendering/RenderObjectChildList.h:
* rendering/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::computeRepaintRectForRange):
* rendering/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::RenderSVGRoot):
(WebCore::RenderSVGRoot::applyContentTransforms):
(WebCore::RenderSVGRoot::paint):
(WebCore::RenderSVGRoot::absoluteTransform):
(WebCore::RenderSVGRoot::nodeAtPoint):
(WebCore::RenderSVGRoot::position):
* rendering/RenderSVGRoot.h:
(WebCore::RenderSVGRoot::virtualChildren):
(WebCore::RenderSVGRoot::children):
* rendering/RenderSVGText.cpp:
(WebCore::RenderSVGText::absoluteRects):
(WebCore::RenderSVGText::absoluteQuads):
* rendering/RenderTable.cpp:
(WebCore::RenderTable::addChild):
(WebCore::RenderTable::removeChild):
* rendering/RenderTableCol.cpp:
(WebCore::RenderTableCol::RenderTableCol):
* rendering/RenderTableCol.h:
(WebCore::RenderTableCol::virtualChildren):
(WebCore::RenderTableCol::children):
* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::RenderTableRow):
(WebCore::RenderTableRow::destroy):
(WebCore::RenderTableRow::styleWillChange):
(WebCore::RenderTableRow::addChild):
* rendering/RenderTableRow.h:
(WebCore::RenderTableRow::virtualChildren):
(WebCore::RenderTableRow::children):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::RenderTableSection):
(WebCore::RenderTableSection::destroy):
(WebCore::RenderTableSection::addChild):
(WebCore::RenderTableSection::removeChild):
(WebCore::RenderTableSection::lowestPosition):
(WebCore::RenderTableSection::rightmostPosition):
(WebCore::RenderTableSection::leftmostPosition):
* rendering/RenderTableSection.h:
(WebCore::RenderTableSection::virtualChildren):
(WebCore::RenderTableSection::children):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40651
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Thu, 5 Feb 2009 00:49:11 +0000 (00:49 +0000)]
2009-02-04 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Eric Seidel.
Rename layout test result to the correct name.
* storage/transaction-callback-exception-crash-expected.txt: Renamed from LayoutTests/storage/transaction-callback-exception-crash.txt.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40650
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 5 Feb 2009 00:40:30 +0000 (00:40 +0000)]
2009-02-04 Anders Carlsson <andersca@apple.com>
Reviewed by Mark Rowe.
Fix 64-bit build.
* WebView/WebScriptDebugger.mm:
(WebScriptDebugger::initGlobalCallFrame):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40649
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 5 Feb 2009 00:40:13 +0000 (00:40 +0000)]
2009-02-04 Mads Adger <mad@chromium.org>
Reviewed by Antti Koivisto.
Bug 23180 Reading freed memory at DocumentLoader::checkForPendingPreloads
https://bugs.webkit.org/show_bug.cgi?id=23180
Added a protector for the document potentially holding on the last reference to the loader we are interating with.
* loader/loader.cpp:
(WebCore::Loader::Host::didFinishLoading):
(WebCore::Loader::Host::didFail):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40648
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 5 Feb 2009 00:35:17 +0000 (00:35 +0000)]
2009-02-04 Cary Clark <caryclark@google.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=23163
Don't scroll to show current focus on devices that use
directional pads for navigation.
* dom/Element.cpp:
(WebCore::Element::updateFocusAppearance):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40647
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 5 Feb 2009 00:31:21 +0000 (00:31 +0000)]
2009-02-04 Cary Clark <caryclark@google.com>
Reviewed by Darin Adler.
Change RenderBlock::columnGap() access permissions from protected to
public. ANDROID creates an array of focus rectangles for navigation
with a trackball or directional pad, and needs access to the column gap
to implement this logic.
Android has no testing harness @ webkit.org, thus no tests.
* rendering/RenderBlock.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40646
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 5 Feb 2009 00:27:35 +0000 (00:27 +0000)]
2009-02-04 Cary Clark <caryclark@google.com>
Reviewed by Eric Seidel.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=22917
Add ENABLE_ON_FIRST_TEXTAREA_FOCUS_SELECT_ALL to permit the ANDROID
platform to select all when focusing on a textarea. This matches
the user interface guidelines other applications on the platform.
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::updateFocusAppearance):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40645
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin@apple.com [Thu, 5 Feb 2009 00:19:31 +0000 (00:19 +0000)]
2009-02-04 Beth Dakin <bdakin@apple.com>
Reviewed by Dave Hyatt.
Fix for <rdar://problem/
6386112> Some inline-elements are not
becoming proper dashboard-regions
RenderInline needs its own implementation of addDashboardRegions
because otherwise all of the coordinate calculations are
inaccurate.
* rendering/RenderInline.cpp:
(WebCore::RenderInline::addDashboardRegions):
* rendering/RenderInline.h:
* rendering/RenderObject.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40644
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Thu, 5 Feb 2009 00:12:52 +0000 (00:12 +0000)]
2009-02-04 David Hyatt <hyatt@apple.com>
Move addChild/removeChild from RenderContainer to RenderObject.
Reviewed by Sam Weinig
* rendering/RenderContainer.cpp:
* rendering/RenderContainer.h:
* rendering/RenderObject.cpp:
(WebCore::updateListMarkerNumbers):
(WebCore::RenderObject::addChild):
(WebCore::RenderObject::removeChild):
* rendering/RenderObject.h:
(WebCore::RenderObject::addChildIgnoringContinuation):
* rendering/RenderSVGContainer.cpp:
* rendering/RenderSVGContainer.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40643
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Thu, 5 Feb 2009 00:05:39 +0000 (00:05 +0000)]
2009-02-04 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig
<rdar://problem/
3541409> - Further HistoryItem / BF cache cleanup
* history/CachedFrame.cpp:
(WebCore::CachedFrame::CachedFrame):
(WebCore::CachedFrame::restore):
* history/CachedFrame.h:
* history/CachedPage.cpp:
(WebCore::CachedPage::restore):
* history/CachedPage.h:
(WebCore::CachedPage::mainFrameView):
* history/HistoryItem.cpp:
(WebCore::HistoryItem::HistoryItem):
(WebCore::HistoryItem::~HistoryItem):
* history/HistoryItem.h:
(WebCore::HistoryItem::isInPageCache):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::open):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40642
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pkasting@chromium.org [Thu, 5 Feb 2009 00:00:18 +0000 (00:00 +0000)]
2009-02-04 Peter Kasting <pkasting@google.com>
Reviewed by David Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=23743
Fix memory corruption with open-source GIF decoders.
* platform/image-decoders/ImageDecoder.h:
(WebCore::RGBA32Buffer::clear):
* platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::clearFrameBufferCache):
* platform/image-decoders/skia/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::clearFrameBufferCache):
(WebCore::GIFImageDecoder::initFrameBuffer):
* platform/image-decoders/skia/ImageDecoder.h:
(WebCore::RGBA32Buffer::clear):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40641
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Wed, 4 Feb 2009 23:56:55 +0000 (23:56 +0000)]
2009-02-04 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dave Hyatt
https://bugs.webkit.org/show_bug.cgi?id=23360
When using accelerated compositing, make repaints use the correct
repaint container. Hook up the RenderLayerCompositor in RenderView,
and add to RenderView a method that repaints both the view
contents, and any intersecting composited layers.
Make enclosingCompositingLayer() a method on RenderObject, and update
the compositor to use that. Add a helper method on the compositor to
get the non-self compositing ancestor: ancestorCompositingLayer().
Call repaintRectangleInViewAndCompositedLayers() in places that don't do
container-relative repainting: selection redraw on focus change, caret,
and widget updates.
Fix a bug in RenderLayerCompositor where the m_compositingLayersNeedUpdate flag
would get cleared for partial updates, thus preventing subsequent full updates.
Fix a bug in RenderLayer::ensureBacking() that made new backing every time.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40640
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Wed, 4 Feb 2009 23:55:56 +0000 (23:55 +0000)]
2009-02-04 Dmitry Titov <dimich@chromium.org>
Reviewed by Darin Adler.
Regression test for https://bugs.webkit.org/show_bug.cgi?id=22753
* fast/dom/Window/cached-timeout-stopped-on-close-expected.txt: Added.
* fast/dom/Window/cached-timeout-stopped-on-close.html: Added.
* fast/dom/Window/resources/cached-timeout-page-1.html: Added.
* fast/dom/Window/resources/cached-timeout-page-2.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40639
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Wed, 4 Feb 2009 23:44:14 +0000 (23:44 +0000)]
2009-02-04 Sam Weinig <sam@webkit.org>
Reviewed by David Hyatt.
Add toRenderImage methods for casting RenderObjects to RenderImages. The methods will assert if the object
is not a RenderImage. Also add a toRenderImage method that takes a RenderImage but returns void and that
is unimplemented. This method will catch anyone trying to do a cast when the object is already a RenderImage.
* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::defaultEventHandler):
* html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::attach):
* html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::parseMappedAttribute):
(WebCore::HTMLImageElement::attach):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::parseMappedAttribute):
(WebCore::HTMLInputElement::attach):
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::attach):
* html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::attach):
* loader/ImageLoader.cpp:
(WebCore::ImageLoader::setImage):
(WebCore::ImageLoader::updateFromElement):
(WebCore::ImageLoader::notifyFinished):
* page/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::addChildren):
* page/DragController.cpp:
(WebCore::getCachedImage):
(WebCore::getImage):
* platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::writeImage):
* rendering/RenderImage.h:
(WebCore::toRenderImage):
* wml/WMLImageElement.cpp:
(WebCore::WMLImageElement::parseMappedAttribute):
(WebCore::WMLImageElement::attach):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40638
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Wed, 4 Feb 2009 23:28:11 +0000 (23:28 +0000)]
WebKit/mac:
2009-02-04 Geoffrey Garen <ggaren@apple.com>
Reviewed by Mark Rowe.
Part I of <rdar://problem/
6552272>.
Clear the redirectURLs entry when first visiting a site, so sites that
only redirect you the first time you visit them can later learn that
they don't redirect.
* History/WebHistory.mm:
(-[WebHistory _visitedURL:withTitle:method:wasFailure:serverRedirectURL:isClientRedirect:]):
WebKit/win:
2009-02-04 Geoffrey Garen <ggaren@apple.com>
Reviewed by Mark Rowe.
Part I of <rdar://problem/
6552272>.
Clear the redirectURLs entry when first visiting a site, so sites that
only redirect you the first time you visit them can later learn that
they don't redirect.
* WebHistory.cpp:
(WebHistory::visitedURL):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40637
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Wed, 4 Feb 2009 23:25:46 +0000 (23:25 +0000)]
2009-02-04 Jungshik Shin <jshin@chromium.org>
Reviewed by Eric Seidel and Dave Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=20531
Make alternateFamilyName customized for Windows and Chromium.
* platform/graphics/FontCache.cpp:
(WebCore::alternateFamilyName):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40636
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Wed, 4 Feb 2009 23:22:51 +0000 (23:22 +0000)]
2009-02-04 Jungshik Shin <jshin@chromium.org>
Reviewed by Eric Seidel.
This comes from Chromium patch (http://codereview.chromium.org/17624).
Add m_disableFontFallback to UniscriberHelper class and set it
to true when filling up glyph pages for non-BMP code points.
When it's set true, UniscriberHelper does not do its own font
fallback. Neither does it do glyph placement. Font fallback
will be taken care of in the simple script font path and glyph
placement is not necessary for simple scripts.
Layout test is missing at the moment due to the lack of freely
distributable font covering a non-BMP code page. A test page
is available at http://i18nl10n.com/webkit/nonbmp2.html
See also https://bugs.webkit.org/show_bug.cgi?id=23602
* platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp:
(WebCore::fillNonBMPGlyphs):
* platform/graphics/chromium/UniscribeHelper.cpp:
(WebCore::UniscribeHelper::UniscribeHelper):
(WebCore::UniscribeHelper::shape):
(WebCore::UniscribeHelper::fillShapes):
* platform/graphics/chromium/UniscribeHelper.h:
(WebCore::UniscribeHelper::setDisableFontFallback):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40635
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Wed, 4 Feb 2009 23:20:07 +0000 (23:20 +0000)]
2009-02-04 Sam Weinig <sam@webkit.org>
Reviewed by David Hyatt.
Remove some unnecessary #includes of RenderStyle.h
* css/CSSPrimitiveValueMappings.h:
* css/SVGCSSComputedStyleDeclaration.cpp:
* dom/Node.h:
* rendering/PointerEventsHitRules.h:
* rendering/RenderImageGeneratedContent.h:
* rendering/RenderMarquee.h:
* rendering/RenderScrollbar.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40634
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Wed, 4 Feb 2009 22:59:41 +0000 (22:59 +0000)]
2009-02-04 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=23657
Clean up WebCore/storage IDLs.
* storage/SQLError.idl: Changed to match spec.
* storage/SQLResultSet.idl: Changed to match spec.
* storage/SQLStatementCallback.idl: Removed.
* storage/SQLStatementErrorCallback.idl: Removed.
* storage/SQLTransactionCallback.idl: Removed.
* storage/SQLTransactionErrorCallback.idl: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40633
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Wed, 4 Feb 2009 22:52:49 +0000 (22:52 +0000)]
2009-02-04 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=23655
Clean up storage layout tests a bit.
* storage/close-during-stress-test.html: Moved brace to new line.
* storage/empty-statement.html: Moved brace to new line.
* storage/execute-sql-args.html: Moved brace to new line.
* storage/quota-tracking.html: Moved brace to new line.
* storage/success-callback.html: Moved brace to new line, removed erroneous callback argument.
* storage/transaction-callback-exception-crash.html: Added.
* storage/transaction-callback-exception-crash.txt: Renamed from LayoutTests/storage/transaction_callback_exception_crash-expected.txt.
* storage/transaction_callback_exception_crash.html: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40632
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Wed, 4 Feb 2009 22:34:25 +0000 (22:34 +0000)]
Change the WebSourceId typedef from int to intptr_t now that <rdar://problem/
6263297> is fixed.
<rdar://problem/
6263293> WebScriptDebugDelegate should use intptr_t for sourceId, not int
Reviewed by Oliver Hunt.
* WebView/WebScriptDebugDelegate.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40631
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Wed, 4 Feb 2009 22:34:14 +0000 (22:34 +0000)]
Switched over from using the WebSafeForwarder for the Script Debug delegate and added high performance CallScriptDebugDelegate functions.
WebKit:
2009-02-04 Timothy Hatcher <timothy@apple.com>
Removed the WebDefaultScriptDebugDelegate now that we have CallScriptDebugDelegate.
<rdar://problem/
6508457> Launching widget in Dashcode debugger is
super-slow due forwardInvocation: calling debug delegate
Reviewed by Oliver Hunt.
* WebKit.xcodeproj/project.pbxproj:
WebKit/mac:
2009-02-04 Timothy Hatcher <timothy@apple.com>
Switched over from using the WebSafeForwarder for the Script Debug
delegate and added high performance CallScriptDebugDelegate functions.
<rdar://problem/
6508457> Launching widget in Dashcode debugger is
super-slow due forwardInvocation: calling debug delegate
Reviewed by Oliver Hunt.
* DefaultDelegates/WebDefaultScriptDebugDelegate.h: Removed.
* DefaultDelegates/WebDefaultScriptDebugDelegate.m: Removed.
* WebView/WebScriptDebugger.mm:
(WebScriptDebugger::initGlobalCallFrame): Use CallScriptDebugDelegate.
(WebScriptDebugger::sourceParsed): Ditto.
(WebScriptDebugger::callEvent): Ditto.
(WebScriptDebugger::atStatement): Ditto.
(WebScriptDebugger::returnEvent): Ditto.
(WebScriptDebugger::exception): Ditto.
* WebView/WebView.mm:
(-[WebViewPrivate dealloc]): Removed scriptDebugDelegateForwarder.
(-[WebView _cacheScriptDebugDelegateImplementations]): Added. Gets the
method implementations for the script debug delegate. Also caches what
didParseSource method to use.
(WebViewGetScriptDebugDelegateImplementations): Added. Returns the
WebScriptDebugDelegateImplementations structure.
(-[WebView setScriptDebugDelegate:]): Call _cacheScriptDebugDelegateImplementations.
(CallDelegate): Added more overloaded versions that take different arguments.
(CallScriptDebugDelegate): Added overloaded versions that take different arguments.
* WebView/WebViewInternal.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40630
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Wed, 4 Feb 2009 22:29:04 +0000 (22:29 +0000)]
2009-02-04 David Hyatt <hyatt@apple.com>
Fix for https://bugs.webkit.org/show_bug.cgi?id=23734, blank content on blogs.msdn.com.
Add debugging code that will catch the incorrect dirtying of a table section immediately if it happens
during calcRowHeight or layoutRows. This should make it possible to discover future bugs where table sections don't
paint.
The bug in blogs.msdn.com, which was caused by a bad setNeedsLayout in RenderLayer::updateScrollInfoAtferLayout. Make
sure to do only a local setNeedsLayout inside that function.
Reviewed by Beth Dakin
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateScrollInfoAfterLayout):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::RenderObject):
* rendering/RenderObject.h:
(WebCore::RenderObject::isSetNeedsLayoutForbidden):
(WebCore::RenderObject::setNeedsLayoutIsForbidden):
(WebCore::RenderObject::setNeedsLayout):
(WebCore::RenderObject::setChildNeedsLayout):
(WebCore::RenderObject::markContainingBlocksForLayout):
* rendering/RenderTable.cpp:
(WebCore::RenderTable::layout):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::calcRowHeight):
(WebCore::RenderTableSection::layoutRows):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40629
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Wed, 4 Feb 2009 22:27:50 +0000 (22:27 +0000)]
2009-02-04 Sam Weinig <sam@webkit.org>
Reviewed by David Hyatt.
Rename RenderStyle::Diff to StyleDifference and move it to
RenderStyleConstants.h.
* rendering/RenderBR.cpp:
(WebCore::RenderBR::styleDidChange):
* rendering/RenderBR.h:
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::styleWillChange):
(WebCore::RenderBlock::styleDidChange):
* rendering/RenderBlock.h:
* rendering/RenderBox.cpp:
(WebCore::RenderBox::styleWillChange):
(WebCore::RenderBox::styleDidChange):
* rendering/RenderBox.h:
* rendering/RenderButton.cpp:
(WebCore::RenderButton::styleWillChange):
(WebCore::RenderButton::styleDidChange):
* rendering/RenderButton.h:
* rendering/RenderFieldset.cpp:
(WebCore::RenderFieldset::styleDidChange):
* rendering/RenderFieldset.h:
* rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::styleDidChange):
* rendering/RenderFileUploadControl.h:
* rendering/RenderInline.cpp:
(WebCore::RenderInline::styleDidChange):
* rendering/RenderInline.h:
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::styleChanged):
* rendering/RenderLayer.h:
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateLayerCompositingState):
(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
* rendering/RenderLayerCompositor.h:
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::styleDidChange):
* rendering/RenderListBox.h:
* rendering/RenderListItem.cpp:
(WebCore::RenderListItem::styleDidChange):
* rendering/RenderListItem.h:
* rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::styleWillChange):
(WebCore::RenderListMarker::styleDidChange):
* rendering/RenderListMarker.h:
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::styleDidChange):
* rendering/RenderMenuList.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::setStyle):
(WebCore::RenderObject::styleWillChange):
(WebCore::RenderObject::styleDidChange):
* rendering/RenderObject.h:
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::styleDidChange):
* rendering/RenderReplaced.h:
* rendering/RenderSVGGradientStop.cpp:
(WebCore::RenderSVGGradientStop::styleDidChange):
* rendering/RenderSVGGradientStop.h:
* rendering/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::styleDidChange):
* rendering/RenderSVGInlineText.h:
* rendering/RenderScrollbarPart.cpp:
(WebCore::RenderScrollbarPart::styleWillChange):
(WebCore::RenderScrollbarPart::styleDidChange):
* rendering/RenderScrollbarPart.h:
* rendering/RenderSlider.cpp:
(WebCore::RenderSlider::styleDidChange):
* rendering/RenderSlider.h:
* rendering/RenderTable.cpp:
(WebCore::RenderTable::styleDidChange):
* rendering/RenderTable.h:
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::styleWillChange):
(WebCore::RenderTableCell::styleDidChange):
* rendering/RenderTableCell.h:
* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::styleWillChange):
* rendering/RenderTableRow.h:
* rendering/RenderText.cpp:
(WebCore::RenderText::styleDidChange):
* rendering/RenderText.h:
(WebCore::RenderText::styleWillChange):
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::styleDidChange):
* rendering/RenderTextControl.h:
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::styleDidChange):
* rendering/RenderTextControlSingleLine.h:
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::styleDidChange):
* rendering/RenderWidget.h:
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff):
(WebCore::RenderStyle::setClip):
* rendering/style/RenderStyle.h:
* rendering/style/RenderStyleConstants.h:
(WebCore::):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40628
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Wed, 4 Feb 2009 21:02:02 +0000 (21:02 +0000)]
2009-02-03 Sam Weinig <sam@webkit.org>
Reviewed by David Hyatt.
Move PseudoId enum out of RenderStyle and into RenderStyleConstants.h
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::matchRulesForList):
(WebCore::CSSStyleSelector::initForStyleResolve):
(WebCore::CSSStyleSelector::SelectorChecker::SelectorChecker):
(WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
(WebCore::CSSStyleSelector::styleForElement):
(WebCore::CSSStyleSelector::pseudoStyleForElement):
(WebCore::CSSStyleSelector::checkSelector):
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
(WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
(WebCore::CSSStyleSelector::applyProperty):
* css/CSSStyleSelector.h:
* dom/Node.cpp:
(WebCore::Node::diff):
* page/FrameView.cpp:
(WebCore::FrameView::createScrollbar):
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paint):
* rendering/MediaControlElements.cpp:
(WebCore::MediaTextDisplayElement::MediaTextDisplayElement):
(WebCore::MediaTimeDisplayElement::MediaTimeDisplayElement):
(WebCore::MediaControlInputElement::MediaControlInputElement):
(WebCore::MediaControlMuteButtonElement::MediaControlMuteButtonElement):
(WebCore::MediaControlPlayButtonElement::MediaControlPlayButtonElement):
(WebCore::MediaControlSeekButtonElement::MediaControlSeekButtonElement):
(WebCore::MediaControlTimelineElement::MediaControlTimelineElement):
(WebCore::MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement):
* rendering/MediaControlElements.h:
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::styleDidChange):
(WebCore::RenderBlock::updateBeforeAfterContent):
(WebCore::RenderBlock::firstLineBlock):
(WebCore::RenderBlock::updateFirstLetter):
* rendering/RenderBlock.h:
* rendering/RenderBox.cpp:
(WebCore::RenderBox::isAfterContent):
* rendering/RenderButton.cpp:
(WebCore::RenderButton::updateBeforeAfterContent):
* rendering/RenderButton.h:
* rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::createButtonStyle):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::styleDidChange):
(WebCore::isAfterContent):
(WebCore::RenderInline::addChildIgnoringContinuation):
(WebCore::RenderInline::splitInlines):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::createScrollbar):
(WebCore::RenderLayer::updateScrollCornerStyle):
(WebCore::RenderLayer::updateResizerStyle):
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::createScrollbar):
* rendering/RenderMedia.cpp:
(WebCore::RenderMedia::createPanel):
(WebCore::RenderMedia::createTimelineContainer):
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::createScrollbar):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::selectionBackgroundColor):
(WebCore::RenderObject::selectionForegroundColor):
(WebCore::RenderObject::firstLineStyleSlowCase):
(WebCore::RenderObject::getCachedPseudoStyle):
(WebCore::RenderObject::getUncachedPseudoStyle):
* rendering/RenderObject.h:
(WebCore::RenderObject::isAnonymousBlock):
* rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::destroyLeftoverChildren):
(WebCore::beforeAfterContainer):
(WebCore::RenderObjectChildList::invalidateCounters):
(WebCore::RenderObjectChildList::updateBeforeAfterContent):
* rendering/RenderObjectChildList.h:
* rendering/RenderScrollbar.cpp:
(WebCore::RenderScrollbar::getScrollbarPseudoStyle):
(WebCore::pseudoForScrollbarPart):
* rendering/RenderScrollbar.h:
* rendering/RenderSlider.cpp:
(WebCore::RenderSlider::createThumbStyle):
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::createInnerTextStyle):
(WebCore::RenderTextControlSingleLine::createResultsButtonStyle):
(WebCore::RenderTextControlSingleLine::createCancelButtonStyle):
(WebCore::RenderTextControlSingleLine::createScrollbar):
* rendering/style/RenderStyle.cpp:
(WebCore::pseudoBit):
* rendering/style/RenderStyle.h:
(WebCore::):
* rendering/style/RenderStyleConstants.h:
(WebCore::):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40625
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer@apple.com [Wed, 4 Feb 2009 19:56:21 +0000 (19:56 +0000)]
CrashTracer: [REGRESSION] 53 crashes in Safari at com.apple.WebCore: WebCore::LegacyWebArchive::create + 2706
<rdar://problem/
6509514>
Reviewed by Mark Rowe.
* loader/archive/cf/LegacyWebArchive.cpp:
(WebCore::LegacyWebArchive::create): Fix it correctly this time.
Check for the value returned from WebCore::IconDatabase::iconForPageURL(),
not WebCore::Image::data().
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40623
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Wed, 4 Feb 2009 19:44:19 +0000 (19:44 +0000)]
2009-02-04 David Hyatt <hyatt@apple.com>
Rename removeFromObjectLists and move it into RenderBox, since it only applies to boxes.
Reviewed by Adam Roben
* rendering/RenderBox.cpp:
(WebCore::RenderBox::removeFloatingOrPositionedChildFromBlockLists):
(WebCore::RenderBox::styleWillChange):
* rendering/RenderBox.h:
* rendering/RenderContainer.cpp:
(WebCore::RenderContainer::removeChild):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::styleWillChange):
* rendering/RenderObject.h:
* rendering/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::removeChild):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40622
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Wed, 4 Feb 2009 19:43:13 +0000 (19:43 +0000)]
Fix WebCore/ChangeLog date discrepancy.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40621
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Wed, 4 Feb 2009 19:41:10 +0000 (19:41 +0000)]
WebCore:
2009-02-04 Jeremy Moskovich <jeremy@chromium.org>
Reviewed by Dave Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=23471
Fix text-overflow:ellipsis; for RTL case.
Test: fast/css/text-overflow-ellipses.html
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::placeEllipsisBox): Add support for rtl placement.
(WebCore::InlineTextBox::paintDecoration): Correctly draw decorations
for rtl truncation.
LayoutTests:
2009-02-04 Jeremy Moskovich <jeremy@chromium.org>
Reviewed by Dave Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=23471
Fix text-overflow:ellipsis; for RTL case.
Rebaseline LayoutTests/editing/spelling/inline_spelling_markers.html to reflect correct behavior.
* fast/css/text-overflow-ellipses.html: Added.
* platform/mac/editing/spelling/inline_spelling_markers-expected.checksum:
* platform/mac/editing/spelling/inline_spelling_markers-expected.png:
* platform/mac/fast/css/text-overflow-ellipses-expected.checksum: Added.
* platform/mac/fast/css/text-overflow-ellipses-expected.png: Added.
* platform/mac/fast/css/text-overflow-ellipses-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40620
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Wed, 4 Feb 2009 19:06:37 +0000 (19:06 +0000)]
2009-02-02 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=23700
Upstream local changes to due to unforking of SimpleFontData
(corresponds to Chromium check-in http://src.chromium.org/viewvc/chrome?view=rev&revision=8646).
* platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp:
(WebCore::fillBMPGlyphs): Removed extra checks for ZWS chars.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40619
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Wed, 4 Feb 2009 18:25:14 +0000 (18:25 +0000)]
2009-02-04 David Hyatt <hyatt@apple.com>
<rdar://problem/
6554115> REGRESSION (r40475): World leak (JS global object) after viewing a photo on Facebook
Fix a ginormous leak. (GINORMOUS!) Make sure to disconnect the event listeners attached to the Document,
because, like, they point to a lot of stuff... like ... everything...
Reviewed by Darin Adler
* dom/Document.cpp:
(WebCore::Document::removeAllEventListenersFromAllNodes):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40618
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@chromium.org [Wed, 4 Feb 2009 18:11:07 +0000 (18:11 +0000)]
2009-02-04 Darin Fisher <darin@chromium.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=23731
Add JSCCustom and V8Custom as extended IDL attributes
This helps avoid having to add #ifdefs to the IDL files to support V8 bindings.
* bindings/scripts/CodeGeneratorJS.pm:
* dom/Document.idl:
* dom/Node.idl:
* svg/SVGPathSegList.idl:
* svg/SVGPointList.idl:
* svg/SVGTransformList.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40617
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Wed, 4 Feb 2009 18:03:57 +0000 (18:03 +0000)]
- build fix
* rendering/RenderImageGeneratedContent.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40616
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino@webkit.org [Wed, 4 Feb 2009 18:01:18 +0000 (18:01 +0000)]
Reviewed by Kevin Ollivier.
Switch to using a ref-counted wxFont pointer for FontPlatformData to fix a crash
with assigning to uninitialized HashTable buckets.
https://bugs.webkit.org/show_bug.cgi?id=23669
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40615
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Wed, 4 Feb 2009 17:39:48 +0000 (17:39 +0000)]
2009-02-04 David Hyatt <hyatt@apple.com>
Fix a crash in generated content when a generated image with an already-cached background image gets
created. It's not completely clear how to reproduce this crash.
Reviewed by Adam Roben
* rendering/RenderImageGeneratedContent.h:
(WebCore::RenderImageGeneratedContent::imagePtr):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40614
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Wed, 4 Feb 2009 14:56:24 +0000 (14:56 +0000)]
2009-02-04 Simon Hausmann <simon.hausmann@nokia.com>
Unreviewed Qt build fix.
Changed ASSERT(image) to ASSERT(!image.isNull()).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40613
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Wed, 4 Feb 2009 14:23:55 +0000 (14:23 +0000)]
2009-02-04 Trenton Schulz <trenton.schulz@nokia.com>
Reviewed by Simon Hausmann.
Fix implementation of PluginViewMac::invalidateRect to update only the
specified rect, not the entire browser window.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40612
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zecke@webkit.org [Wed, 4 Feb 2009 14:04:04 +0000 (14:04 +0000)]
2009-02-04 Holger Hans Peter Freyther <zecke@selfish.org>
Rubber stamped by Mark Rowe.
FramePrivate was removed in r40024 remove the forward
declaration as well.
* page/Frame.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40611
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zecke@webkit.org [Wed, 4 Feb 2009 13:37:52 +0000 (13:37 +0000)]
Make isFrameSet virtual and by default return false, reimplement it in HTMLDocument.
https://bugs.webkit.org/show_bug.cgi?id=23426
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40610
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Wed, 4 Feb 2009 09:34:37 +0000 (09:34 +0000)]
2009-02-04 David Boddie <dboddie@trolltech.com>
Reviewed by Simon Hausmann.
Doc: Documented the return value of the evaluateJavaScript() function.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40609
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Wed, 4 Feb 2009 08:55:28 +0000 (08:55 +0000)]
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=23681
Worker tests crash in debug builds if run --singly
The crash happened because worker threads continued running while debug-only static objects
were already being destroyed on main thread.
* runtime/Structure.cpp: Create static debug-only sets in heap, so that they don't get
destroyed.
* wtf/ThreadingPthreads.cpp: Changed assertions to conventional form.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40608
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Wed, 4 Feb 2009 05:24:44 +0000 (05:24 +0000)]
<rdar://problem/
6554092> Slow script dialog starts coming up over and over again
Reviewed by John Sullivan.
Work around <rdar://problem/
6554067> by consuming any exceptions that are
thrown by _web_localizedDescription
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40607
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Wed, 4 Feb 2009 05:06:19 +0000 (05:06 +0000)]
2009-02-03 David Hyatt <hyatt@apple.com>
Move the isRenderInline checks for clientWidth/Height and scrollWidth/Height to the DOM element
versions of the functions. Since internal render tree usage doesn't ever (incorrectly) call these
functions on RenderInlines, this manages to get virtual function calls out of contentWidth/Height and
availableWidth/Height.
Reviewed by Mark Rowe
* dom/Element.cpp:
(WebCore::Element::clientWidth):
(WebCore::Element::clientHeight):
(WebCore::Element::scrollWidth):
(WebCore::Element::scrollHeight):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::clientWidth):
(WebCore::RenderBox::clientHeight):
(WebCore::RenderBox::scrollWidth):
(WebCore::RenderBox::scrollHeight):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40606
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Wed, 4 Feb 2009 04:59:39 +0000 (04:59 +0000)]
2009-02-03 Brad Garcia <bgarcia@google.com>
Remove call to canResize when trying to determine if pointer
is within a frame.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40605
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Wed, 4 Feb 2009 04:26:08 +0000 (04:26 +0000)]
2009-02-03 David Hyatt <hyatt@apple.com>
Reduce the number of calls to virtualChildren (indirectly made via RenderObject::firstChild()).
This is a small gain on the PLT.
Reviewed by Mark Rowe
* rendering/bidi.cpp:
(WebCore::inlineWidth):
(WebCore::bidiNext):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40604
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Wed, 4 Feb 2009 02:45:10 +0000 (02:45 +0000)]
Fix typo in Changelog
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40565
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Wed, 4 Feb 2009 02:41:38 +0000 (02:41 +0000)]
2009-02-03 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dave Hyatt
https://bugs.webkit.org/show_bug.cgi?id=23628
Fix selection repainting to do container-relative repaints. RenderView now
repaints the seleciton using the containerForRepaint() for each RenderSelectionInfo.
selectionRect() is now a wrapper for selectionRectForRepaint() with no container.
Pull SelectionInfo out of RenderObject.h, and BlockSelectionInfo out
of RenderBlock.h and move them into RenderSelectionInfo.h, with some
sharing and refactoring.
RenderBlock::selectionGapRectsForRepaint() is not yet container-aware.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40564
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Wed, 4 Feb 2009 02:06:42 +0000 (02:06 +0000)]
2009-02-03 David Hyatt <hyatt@apple.com>
Add inline capacity back to CSSMutableStyleDeclaration now that the bug in Vector has been fixed.
Reviewed by Darin Adler & Sam Weinig
* css/CSSMutableStyleDeclaration.cpp:
(WebCore::CSSMutableStyleDeclaration::removePropertiesInSet):
* css/CSSMutableStyleDeclaration.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40563
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Wed, 4 Feb 2009 02:02:32 +0000 (02:02 +0000)]
2009-02-03 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
https://bugs.webkit.org/show_bug.cgi?id=23715
Simplify MacroAssembler interface, by combining comparison methods.
Seprate operations are combined as follows:
jz32/jnz32/jzPtr/jnzPtr -> branchTest32/branchTestPtr,
j*(Add|Mul|Sub)32/j*(Add|Mul|Sub)Ptr -> branch(Add|Mul|Sub)32/branch(Add|Mul|Sub)Ptr
j*32/j*Ptr (all other two op combparisons) -> branch32/brnachPtr
set*32 -> set32
Also, represent the Scale of BaseIndex addresses as a plain enum (0,1,2,3),
instead of as multiplicands (1,2,4,8).
This patch singificantly reduces replication of code, and increases functionality supported
by the MacroAssembler. No performance impact.
* assembler/MacroAssembler.h:
(JSC::MacroAssembler::):
(JSC::MacroAssembler::branchPtr):
(JSC::MacroAssembler::branchPtrWithPatch):
(JSC::MacroAssembler::branch32):
(JSC::MacroAssembler::branch16):
(JSC::MacroAssembler::branchTestPtr):
(JSC::MacroAssembler::branchTest32):
(JSC::MacroAssembler::branchAddPtr):
(JSC::MacroAssembler::branchAdd32):
(JSC::MacroAssembler::branchMul32):
(JSC::MacroAssembler::branchSubPtr):
(JSC::MacroAssembler::branchSub32):
(JSC::MacroAssembler::set32):
(JSC::MacroAssembler::setTest32):
* assembler/X86Assembler.h:
(JSC::X86Assembler::):
(JSC::X86Assembler::jccRel32):
(JSC::X86Assembler::setccOpcode):
(JSC::X86Assembler::cmpq_mr):
(JSC::X86Assembler::setcc_r):
(JSC::X86Assembler::sete_r):
(JSC::X86Assembler::setne_r):
(JSC::X86Assembler::jne):
(JSC::X86Assembler::je):
(JSC::X86Assembler::jl):
(JSC::X86Assembler::jb):
(JSC::X86Assembler::jle):
(JSC::X86Assembler::jbe):
(JSC::X86Assembler::jge):
(JSC::X86Assembler::jg):
(JSC::X86Assembler::ja):
(JSC::X86Assembler::jae):
(JSC::X86Assembler::jo):
(JSC::X86Assembler::jp):
(JSC::X86Assembler::js):
(JSC::X86Assembler::jcc):
(JSC::X86Assembler::X86InstructionFormatter::putModRmSib):
* jit/JIT.cpp:
(JSC::JIT::compileOpStrictEq):
(JSC::JIT::emitSlowScriptCheck):
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::privateCompile):
(JSC::JIT::privateCompileCTIMachineTrampolines):
* jit/JITArithmetic.cpp:
(JSC::JIT::compileFastArith_op_lshift):
(JSC::JIT::compileFastArith_op_mod):
(JSC::JIT::compileFastArith_op_post_inc):
(JSC::JIT::compileFastArith_op_post_dec):
(JSC::JIT::compileFastArith_op_pre_inc):
(JSC::JIT::compileFastArith_op_pre_dec):
(JSC::JIT::compileBinaryArithOp):
(JSC::JIT::compileFastArith_op_add):
(JSC::JIT::compileFastArith_op_mul):
* jit/JITCall.cpp:
(JSC::JIT::compileOpCall):
(JSC::JIT::compileOpCallSlowCase):
* jit/JITInlineMethods.h:
(JSC::JIT::checkStructure):
(JSC::JIT::emitJumpIfJSCell):
(JSC::JIT::emitJumpIfNotJSCell):
(JSC::JIT::emitJumpIfImmediateNumber):
(JSC::JIT::emitJumpIfNotImmediateNumber):
(JSC::JIT::emitJumpIfImmediateInteger):
(JSC::JIT::emitJumpIfNotImmediateInteger):
(JSC::JIT::emitFastArithDeTagImmediateJumpIfZero):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::compilePutByIdHotPath):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
* runtime/RegExp.cpp:
(JSC::RegExp::match):
* wrec/WRECGenerator.cpp:
(JSC::WREC::Generator::generateEnter):
(JSC::WREC::Generator::generateIncrementIndex):
(JSC::WREC::Generator::generateLoadCharacter):
(JSC::WREC::Generator::generateJumpIfNotEndOfInput):
(JSC::WREC::Generator::generateBackreferenceQuantifier):
(JSC::WREC::Generator::generateNonGreedyQuantifier):
(JSC::WREC::Generator::generateGreedyQuantifier):
(JSC::WREC::Generator::generatePatternCharacterPair):
(JSC::WREC::Generator::generatePatternCharacter):
(JSC::WREC::Generator::generateCharacterClassInvertedRange):
(JSC::WREC::Generator::generateCharacterClassInverted):
(JSC::WREC::Generator::generateAssertionBOL):
(JSC::WREC::Generator::generateAssertionEOL):
(JSC::WREC::Generator::generateAssertionWordBoundary):
(JSC::WREC::Generator::generateBackreference):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40562
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Wed, 4 Feb 2009 01:52:34 +0000 (01:52 +0000)]
2009-02-03 David Hyatt <hyatt@apple.com>
Fix a bug in Vector's shrinkCapacity method. It did not properly copy elements into the inline buffer
when shrinking down from a size that was greater than the inline capacity.
Reviewed by Maciej
* wtf/Vector.h:
(WTF::VectorBuffer::VectorBuffer):
(WTF::VectorBuffer::allocateBuffer):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40561
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justin.garcia@apple.com [Wed, 4 Feb 2009 01:18:18 +0000 (01:18 +0000)]
WebCore:
2009-02-03 Justin Garcia <justin.garcia@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=13490
Implement execCommand("styleWithCSS", ...)
Determine whether or not to use HTML formatting tags for styling on the new
boolean on Editor instead of whether or not the document is quirks mode.
* editing/ApplyStyleCommand.cpp:
(WebCore::StyleChange::StyleChange):
(WebCore::StyleChange::init):
(WebCore::ApplyStyleCommand::applyBlockStyle):
(WebCore::ApplyStyleCommand::applyTextDecorationStyle):
(WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
* editing/Editor.cpp:
(WebCore::Editor::Editor):
(WebCore::Editor::clear):
* editing/Editor.h:
(WebCore::Editor::setShouldStyleWithCSS):
(WebCore::Editor::shouldStyleWithCSS):
* editing/EditorCommand.cpp:
(WebCore::executeStyleWithCSS):
(WebCore::stateStyleWithCSS):
(WebCore::CommandEntry::):
LayoutTests:
2009-02-03 Justin Garcia <justin.garcia@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=13490
Implement execCommand("styleWithCSS", ...)
* editing/execCommand/
5685604-1-expected.txt: Added.
* editing/execCommand/
5685604-1.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40560
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
krit@webkit.org [Wed, 4 Feb 2009 01:05:44 +0000 (01:05 +0000)]
2009-02-03 Dirk Schulze <krit@webkit.org>
Reviewed by Sam Weinig.
This is a follow up of r40546. Call toImage() once speeds up ImageBuffer::getImageData()
* platform/graphics/qt/ImageBufferQt.cpp:
(WebCore::ImageBuffer::getImageData):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40559
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 4 Feb 2009 00:55:17 +0000 (00:55 +0000)]
2009-02-03 Anders Carlsson <andersca@apple.com>
Reviewed by Kevin Decker.
- Fix for <rdar://problem/
6549743>
On Tiger, create an autorelease pool before creating the NSGraphicsContext and drain it immediately
after the call to -[NSView displayRectIgnoringOpacity:inContext:].
* platform/mac/WidgetMac.mm:
(WebCore::Widget::paint):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40558
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino@webkit.org [Wed, 4 Feb 2009 00:46:23 +0000 (00:46 +0000)]
ChangeLog date fix.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40557
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino@webkit.org [Wed, 4 Feb 2009 00:39:11 +0000 (00:39 +0000)]
Reviewed by Darin Adler.
Change the way wxWidgets build gets arguments.
Change "checkForArgumentAndRemoveFromARGV" in build-webkit to check if the
argument passed matches one in ARGV exactly (allows, ie, --wx-args not to be
removed when --wx is checked for).
https://bugs.webkit.org/show_bug.cgi?id=23701
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40556
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Wed, 4 Feb 2009 00:31:19 +0000 (00:31 +0000)]
2009-02-03 David Hyatt <hyatt@apple.com>
Back this change out since it is causing layout tests to crash. There is something subtle going on
here.
Reviewed by Darin Adler
* css/CSSMutableStyleDeclaration.cpp:
(WebCore::CSSMutableStyleDeclaration::removePropertiesInSet):
* css/CSSMutableStyleDeclaration.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40555
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Tue, 3 Feb 2009 23:57:53 +0000 (23:57 +0000)]
2009-02-03 David Hyatt <hyatt@apple.com>
Give the properties vector of mutable style declarations an initial inline capacity to reduce malloc churn.
Reviewed by Sam Weinig
* css/CSSMutableStyleDeclaration.cpp:
(WebCore::CSSMutableStyleDeclaration::removePropertiesInSet):
* css/CSSMutableStyleDeclaration.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40554
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Tue, 3 Feb 2009 23:56:06 +0000 (23:56 +0000)]
2009-02-03 David Hyatt <hyatt@apple.com>
Avoid creating extra copies of NSURLRequests for non-HTTP URLs. Only mark platform requests
as needing updating when HTTP fields change if the scheme of the URL is actually HTTP or HTTPS.
Thus cuts down significantly on the number of copied NSURLRequests and is about a 1% gain on the PLT.
Reviewed by Darin Adler
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::addExtraFieldsToRequest):
* platform/KURL.cpp:
(WebCore::KURL::invalidate):
(WebCore::KURL::KURL):
* platform/KURL.h:
(WebCore::KURL::isHTTPOrHTTPS):
* platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::setCachePolicy):
(WebCore::ResourceRequestBase::setTimeoutInterval):
(WebCore::ResourceRequestBase::setMainDocumentURL):
(WebCore::ResourceRequestBase::setHTTPMethod):
(WebCore::ResourceRequestBase::setHTTPHeaderField):
(WebCore::ResourceRequestBase::setResponseContentDispositionEncodingFallbackArray):
(WebCore::ResourceRequestBase::setHTTPBody):
(WebCore::ResourceRequestBase::setAllowHTTPCookies):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40553
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Tue, 3 Feb 2009 23:53:20 +0000 (23:53 +0000)]
Commit test cases for https://bugs.webkit.org/show_bug.cgi?id=23178.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40552
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zecke@webkit.org [Tue, 3 Feb 2009 23:25:52 +0000 (23:25 +0000)]
2009-02-03 Xan Lopez <xan@gnome.org>
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=23711
Add manual test for floating divs with scrollbars.
* manual-tests/gtk/floatingdiv.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40551
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zecke@webkit.org [Tue, 3 Feb 2009 23:25:37 +0000 (23:25 +0000)]
2009-02-03 Xan Lopez <xan@gnome.org>
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=23711
There's no need to hold an extra ref to the scrollbar, calling
setPlatformWidget takes ownership of it.
Also do not disconnect the signals when destroying the widget,
it's superfluous.
* platform/gtk/ScrollbarGtk.cpp:
(ScrollbarGtk::ScrollbarGtk):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40550
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zecke@webkit.org [Tue, 3 Feb 2009 23:25:24 +0000 (23:25 +0000)]
2009-02-03 Xan Lopez <xan@gnome.org>
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=23711
Declare scrollBar as GtkWidget* to avoid needless
casting.
* platform/gtk/ScrollbarGtk.cpp:
(ScrollbarGtk::ScrollbarGtk):
(ScrollbarGtk::~ScrollbarGtk):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40549
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
git://git.webkit.org / WebKit-https.git / log