WebKit-https.git
17 years ago Added regexp_object.lut.h build phase from JavaScriptCore
ggaren [Tue, 11 Oct 2005 22:26:37 +0000 (22:26 +0000)]
    Added regexp_object.lut.h build phase from JavaScriptCore
        to JavaScriptCore+SVG.

        Reviewed by mitz.

        * JavaScriptCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Fixed build bustage from last checkin (stray characters
ggaren [Tue, 11 Oct 2005 22:01:42 +0000 (22:01 +0000)]
    Fixed build bustage from last checkin (stray characters
        in the project file).

        Reviewed by mitz.

        * JavaScriptCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago New JavaScriptCore test results to reflect the last change.
ggaren [Tue, 11 Oct 2005 21:49:37 +0000 (21:49 +0000)]
    New JavaScriptCore test results to reflect the last change.

        * tests/mozilla/expected.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoSmall fixup to last Changelog entry.
ggaren [Tue, 11 Oct 2005 21:00:13 +0000 (21:00 +0000)]
Small fixup to last Changelog entry.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Added a layout test for the new special properties of the global RegExp object.
ggaren [Tue, 11 Oct 2005 20:57:39 +0000 (20:57 +0000)]
    Added a layout test for the new special properties of the global RegExp object.
        (See JavaSriptCore changelog.)

        * fast/js/regexp-caching-expected.txt: Added.
        * fast/js/regexp-caching.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago - Implemented caching of match state inside the global RegExp object
ggaren [Tue, 11 Oct 2005 20:43:49 +0000 (20:43 +0000)]
    - Implemented caching of match state inside the global RegExp object
          (lastParen, leftContext, rightContext, lastMatch, input).

          exec(), test(), match(), search(), and replace() now dipatch regular
          expression matching through the RegExp object's performMatch function,
          to facilitate caching. This replaces registerRegexp and
          setSubPatterns.

        - Implemented the special '$' aliases (e.g. RegExp.input aliases to
          RegExp.$_).

        - Moved support for backreferences into the new static hash table
          used for other special RegExp properties. Truncated backreferences
          at $9 to match IE, FF, and the "What's New in Netscape 1.2?" doc.
          (String.replace still supports double-digit backreferences.)

        - Tweaked RegExp.prototype.exec to handle ginormous values in lastIndex.

        Fixes 11 -- count em, 11 -- JavaScriptCore tests.

        Reviewed by NOBODY (OOPS!).

        * JavaScriptCore.xcodeproj/project.pbxproj: Added regexp_object.lut.h
        * kjs/create_hash_table: Tweaked to allow for more exotic characters.
                                 We now rely on the compiler to catch illegal
                                 identifiers.
        * kjs/regexp.cpp:
        (KJS::RegExp::RegExp):
        * kjs/regexp_object.cpp:
        (RegExpProtoFuncImp::callAsFunction):
        (RegExpObjectImp::RegExpObjectImp):
        (RegExpObjectImp::performMatch):
        (RegExpObjectImp::arrayOfMatches):
        (RegExpObjectImp::backrefGetter):
        (RegExpObjectImp::getLastMatch):
        (RegExpObjectImp::getLastParen):
        (RegExpObjectImp::getLeftContext):
        (RegExpObjectImp::getRightContext):
        (RegExpObjectImp::getOwnPropertySlot):
        (RegExpObjectImp::getValueProperty):
        (RegExpObjectImp::put):
        (RegExpObjectImp::putValueProperty):
        * kjs/regexp_object.h:
        (KJS::RegExpObjectImp::):
        * kjs/string_object.cpp:
        (substituteBackreferences):
        (replace):
        (StringProtoFuncImp::callAsFunction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by eric
justing [Tue, 11 Oct 2005 20:33:00 +0000 (20:33 +0000)]
    Reviewed by eric

        <rdar://problem/4283218> M-JPEG / Server Push and JavaScript

        Ignore multipart loads in numRequests, call checkCompleted() after each section is complete.

        * khtml/misc/loader.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoLayoutTests:
adele [Tue, 11 Oct 2005 19:16:45 +0000 (19:16 +0000)]
LayoutTests:

        Rolling out Darin's previous change.

        * fast/clip/014-expected.checksum: Updated.
        * fast/clip/014-expected.png: Updated.

WebCore:

        Rolling out fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=5195
        since it caused:

        REGRESSION text areas draw focus ring around each glyph, no caret in text fields
        http://bugzilla.opendarwin.org/show_bug.cgi?id=5335

        And updated expected results.
        * fast/clip/014-expected.checksum: Updated.
        * fast/clip/014-expected.png: Updated.

        * kwq/KWQTextArea.h:
        * kwq/KWQTextArea.mm:
        (-[KWQTextAreaTextView displayRectIgnoringOpacity:]):
        (-[KWQTextAreaTextView textView:shouldDrawInsertionPointInRect:color:turnedOn:]):
        * kwq/KWQTextField.h:
        * kwq/KWQTextField.mm:
        (-[KWQTextFieldController setInDrawingMachinery:]):
        (-[KWQTextFieldController textView:shouldDrawInsertionPointInRect:color:turnedOn:]):
        (-[KWQTextField displayRectIgnoringOpacity:]):
        (-[KWQSecureTextField displayRectIgnoringOpacity:]):
        (-[KWQSearchField displayRectIgnoringOpacity:]):
        * kwq/KWQWidget.h:
        * kwq/KWQWidget.mm:
        (QWidget::QWidget):
        (QWidget::~QWidget):
        (QWidget::paint):
        (QWidget::setDeferFirstResponderChanges):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoBug #: none
eseidel [Tue, 11 Oct 2005 09:33:29 +0000 (09:33 +0000)]
Bug #: none
Submitted by: eseidel
Reviewed by: hyatt
        Checks for leaks in ImageDiff too.

        * Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoBug #: 5278
eseidel [Tue, 11 Oct 2005 09:19:23 +0000 (09:19 +0000)]
Bug #: 5278
Submitted by: Rob Buis  <rwlbuis@xs4all.nl>
Reviewed by: eseidel
        Fix SVGSymbolElementImpl to not warn when inheriting viewbox.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=5278

        * ksvg2/svg/SVGUseElementImpl.cpp:
        (SVGUseElementImpl::close):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoBug #: 5301
eseidel [Tue, 11 Oct 2005 09:11:49 +0000 (09:11 +0000)]
Bug #: 5301
Submitted by: Julien Palmas <julien.palmas@mac.com>
Reviewed by: eseidel
        Fixes WebCore+SVG build under gcc 3.3
        http://bugzilla.opendarwin.org/show_bug.cgi?id=5301

        * WebCore+SVG/DrawCanvasItem.mm:
        * WebCore+SVG/DrawView.mm:
        (-[DrawDocument drawRect:initWithDrawView:]):
        * kwq/KWQSlot.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago - Fixed <rdar://problem/4245682> Regression: CrashTracer: 923 crashes
ggaren [Tue, 11 Oct 2005 06:55:29 +0000 (06:55 +0000)]
    - Fixed <rdar://problem/4245682> Regression: CrashTracer: 923 crashes
          in Safari at com.apple.WebCore: KJS::Window::clear + 132

        Reviewed by mjs.

        No test case because this crash isn't reliably reproducible.

        * khtml/ecma/kjs_window.cpp:
        (KJS::Window::Window): Initialize m_returnValueSlot to 0, so that we
        know not to write to it until it's explicitly set to a valid address.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago - updated expected results due to fix for http://bugzilla.opendarwin.org...
darin [Tue, 11 Oct 2005 03:45:15 +0000 (03:45 +0000)]
    - updated expected results due to fix for bugzilla.opendarwin.org/show_bug.cgi?id=5195

        The old results were incorrectly clipped. This always worked fine in the
        browser, but didn't draw correctly in DumpRenderTree until the bug was fixed.

        * fast/clip/014-expected.checksum: Updated.
        * fast/clip/014-expected.png: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Maciej.
darin [Tue, 11 Oct 2005 02:49:35 +0000 (02:49 +0000)]
    Reviewed by Maciej.

        - finished fixing http://bugzilla.opendarwin.org/show_bug.cgi?id=5195
          Would like API to flush rendering of pending DOM changes

        The first half of the fix alone broke DumpRenderTree. Better now.

        * kwq/KWQWidget.h: Made paint non-virtual (it had no reason to be virtual in KWQ) and
        added an isPainting function.
        * kwq/KWQWidget.mm:
        (QWidget::QWidget): Added painting boolean (actually a count).
        (QWidget::~QWidget): Check that painting is 0 when the widget is destroyed.
        (QWidget::paint): Use SPI to draw in a way that works no matter what context we are in.
        (QWidget::isPainting): Return true if inside the paint function.

        * kwq/KWQTextArea.h: Remove inDrawingMachinery field since we can use isPainting now.
        * kwq/KWQTextArea.mm:
        (-[KWQTextAreaTextView textView:shouldDrawInsertionPointInRect:color:turnedOn:]):
        Use isPainting() instead of inDrawingMachinery. inDrawingMachinery required that we
        use displayRectIgnoringOpacity: to paint, which we no longer do.
        * kwq/KWQTextField.h: More of the same.
        * kwq/KWQTextField.mm:
        (-[KWQTextFieldController textView:shouldDrawInsertionPointInRect:color:turnedOn:]):
        Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoBug #: 5320
eseidel [Mon, 10 Oct 2005 23:48:55 +0000 (23:48 +0000)]
Bug #: 5320
Submitted by: darin
Reviewed by: eseidel
        Mem leak fixes in xslt code.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=5320

        * khtml/xml/dom_docimpl.cpp:
        (DocumentImpl::applyXSLTransform):
        (DocumentImpl::setTransformSourceDocument):
        * khtml/xml/xml_tokenizer.cpp:
        (khtml::parseXMLDocumentFragment):
        * khtml/xsl/xslt_processorimpl.cpp:
        (DOM::XSLTProcessorImpl::XSLTProcessorImpl):
        (DOM::XSLTProcessorImpl::~XSLTProcessorImpl):
        (DOM::stylesheetLoadFunc):
        (DOM::XSLTProcessorImpl::transformDocument):
        (DOM::XSLTProcessorImpl::documentFromXMLDocPtr):
        * khtml/xsl/xslt_processorimpl.h:
        (DOM::XSLTProcessorImpl::stylesheet):
        (DOM::XSLTProcessorImpl::sourceDocument):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoBug #:
hyatt [Mon, 10 Oct 2005 07:16:23 +0000 (07:16 +0000)]
Bug #:
Submitted by:
Reviewed by:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago * Scripts/check-dom-results: Dump ".xhtml" for tests in the xhtml directory.
darin [Mon, 10 Oct 2005 06:35:12 +0000 (06:35 +0000)]
    * Scripts/check-dom-results: Dump ".xhtml" for tests in the xhtml directory.
        * Scripts/cvs-apply: Handle added/deleted files in the current directory.
        * Scripts/cvs-unapply: Ditto.
        * Scripts/run-webkit-tests: Add a few more false-positive leaks.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Land fix for bugzilla bug 4974, make sure to only move below floats in line layout...
hyatt [Mon, 10 Oct 2005 03:50:22 +0000 (03:50 +0000)]
Land fix for bugzilla bug 4974, make sure to only move below floats in line layout if white-space is normal.
One case was using !isPre and including nowrap incorrectly as a result.  Patch from koivisto.

        Reviewed by hyatt

        * khtml/rendering/bidi.cpp:
        (khtml::RenderBlock::findNextLineBreak):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Maciej.
darin [Mon, 10 Oct 2005 01:28:59 +0000 (01:28 +0000)]
    Reviewed by Maciej.

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=5195
          Would like API to flush rendering of pending DOM changes

        This was actually a Tiger regression. When AppKit added a new code path for rendering
        NSView, our special hack for doing layout when we draw didn't work any more. So we
        were able to fix this without adding any API.

        * WebView.subproj/WebHTMLView.m:
        (-[WebHTMLView _recursiveDisplayRectIgnoringOpacity:inContext:topView:]): Added.
        Does the same thing that other _recursiveDisplay methods do.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoFixes the following build error when building Deployment:
thatcher [Sun, 9 Oct 2005 23:15:32 +0000 (23:15 +0000)]
Fixes the following build error when building Deployment:
DumpRenderTree/TextInputController.m: In function '-[TextInputController textInput]':
DumpRenderTree/TextInputController.m:87: warning: class 'NSView <WebDocumentView>' does not implement the 'NSTextInput' protocol

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoUpdated change log to mention one more bug fixed.
darin [Sun, 9 Oct 2005 22:57:59 +0000 (22:57 +0000)]
Updated change log to mention one more bug fixed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoJavaScriptCore:
darin [Sun, 9 Oct 2005 22:56:30 +0000 (22:56 +0000)]
JavaScriptCore:

        Reviewed by Maciej; some changes done after review.

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=5280
          Date.setMonth fails with negative values
        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=5154
          JSC should switch to _r variants of unix time/date functions
        - fixed a few possible overflow cases

        Retested all tests to be sure nothing broke; added layout test for bug 5280.

        * kjs/config.h: Removed TIME_WITH_SYS_TIME define. Also set HAVE_SYS_TIMEB_H
        for the __APPLE__ case (the latter is accurate but irrelevant).

        * kjs/date_object.h: Reformatted. Removed unnecessary include of "function_object.h".
        Moved declarations of helper classes and functions into the cpp file.

        * kjs/date_object.cpp: Removed code at top to define macros to use CoreFoundation instead of
        POSIX date functions.
        (KJS::styleFromArgString): Tweaked to return early instead of using a variable.
        (KJS::formatLocaleDate): Tweaked to check for undefined rather than checking argument count.
        (KJS::formatDate): Made parameter const.
        (KJS::formatDateUTCVariant): Ditto.
        (KJS::formatTime): Ditto.
        (KJS::DateProtoFuncImp::callAsFunction): Use gmtime_r and localtime_r instead of gmtime and
        localtime.
        (KJS::DateObjectImp::callAsFunction): Use localtime_r instead of localtime.
        (KJS::ymdhmsToSeconds): Renamed from ymdhms_to_seconds. Changed computation to avoid possible
        overflow if year is an extremely large or small number.
        (KJS::makeTime): Removed code to move large month numbers from tm_mon to tm_year; this was
        to accomodate CFGregorianDate, which is no longer used (and didn't handle negative values).
        (KJS::parseDate): Renamed from KRFCDate_parseDate; changed to return a value in milliseconds
        rather than in seconds. Reformatted the code. Changed to use UTF8String() instead of ascii(),
        since ascii() is not thread safe. Changed some variables back from int to long to avoid
        trouble if the result of strtol does not fit in an int (64-bit issue only).

LayoutTests:

        - added a test for http://bugzilla.opendarwin.org/show_bug.cgi?id=5280
          Date.setMonth fails with negative values

        * fast/js/date-negative-setmonth-expected.txt: Added.
        * fast/js/date-negative-setmonth.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoJavaScriptCore:
darin [Sun, 9 Oct 2005 04:45:29 +0000 (04:45 +0000)]
JavaScriptCore:

        Reviewed by Geoff.
        Tweaked and landed by Darin.

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=5266
          Support parenthesized comments in Date.parse()

        * kjs/date_object.cpp:
        (KJS::skipSpacesAndComments): Take a pointer, and advance it past spaces,
        and also past anything enclosed in parentheses.
        (KJS::KRFCDate_parseDate): Use skipSpacesAndComments wherever we formerly had
        code to skip spaces.

LayoutTests:

        - added a test for http://bugzilla.opendarwin.org/show_bug.cgi?id=5266
          Support parenthesized comments in Date.parse()

        * fast/js/date-parse-comments-test-expected.txt: Added.
        * fast/js/date-parse-comments-test.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago - added a test case for XSLT charset support
darin [Sun, 9 Oct 2005 04:36:58 +0000 (04:36 +0000)]
    - added a test case for XSLT charset support
          http://bugzilla.opendarwin.org/show_bug.cgi?id=5244

        * fast/xsl/xslt-entity-enc.xml: Added.
        * fast/xsl/resources/xslt-entity-enc.xsl: Added.
        * fast/xsl/xslt-entity-enc-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed, tweaked, and landed by Darin.
darin [Sun, 9 Oct 2005 04:25:00 +0000 (04:25 +0000)]
    Reviewed, tweaked, and landed by Darin.

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=5189
          pcre_exec.c fails to compile using MSVC
        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=5190
          KJS config.h adjustment for Win32

        * kjs/config.h: Make sure HAVE_MMAP and HAVE_SBRK are off for Win32.
        Turn HAVE_ERRNO_H on for Mac OS X. Sort defines so they are easy to compare
        with each other. Remove #undef of DEBUG_COLLECTOR.
        * pcre/pcre_exec.c: (match): Work around strange MSVC complaint by splitting
        the definition of a local variable into a separate declaration and
        initialization.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoWebCore:
darin [Sun, 9 Oct 2005 04:17:42 +0000 (04:17 +0000)]
WebCore:

        Reviewed by Maciej.

        - support for WebKit fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=5187
          UTF-8 in long text files breaks at some point

        No layout test added: only affects plain text view and requires loading the
        file in multiple chunks.

        * WebCore.exp: Added WebCoreTextDecoder.
        * kwq/WebCoreTextDecoder.h: Added.
        * kwq/WebCoreTextDecoder.mm: Added.
        * WebCore.xcodeproj/project.pbxproj: Added files, made header private (SPI).

WebKit:

        Reviewed by Maciej.

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=5187
          UTF-8 in long text files breaks at some point

        * WebView.subproj/WebTextRepresentation.m:
        (-[WebTextRepresentation finishedLoadingWithDataSource:]):
        Call flushReceivedData on the WebTextView so it can decode any final bytes.

        * WebView.subproj/WebTextView.h: Added WebCoreTextDecoder field and flushReceivedData method.
        * WebView.subproj/WebTextView.m:
        (-[WebTextView dealloc]): Release WebCoreTextDecoder.
        (-[WebTextView appendReceivedData:fromDataSource:]): Create a WebCoreTextDecoder to decode
        the text; use the textEncodingName from the data source. Use it to decode instead of the
        data source's stringWithData.
        (-[WebTextView flushReceivedData]): Call flush on the decoder and append any last bytes to
        the text view.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Hyatt.
darin [Sun, 9 Oct 2005 03:50:13 +0000 (03:50 +0000)]
    Reviewed by Hyatt.

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=5148
          Rendering regressions in the Acid2 test cannot be detected

        * fast/css/acid2-pixel-expected.checksum: Added.
        * fast/css/acid2-pixel-expected.png: Added.
        * fast/css/acid2-pixel-expected.txt: Added.
        * fast/css/acid2-pixel.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Geoff Garen.
darin [Sun, 9 Oct 2005 03:37:08 +0000 (03:37 +0000)]
    Reviewed by Geoff Garen.

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=5061
          date-big-setmonth test is not timezone-independent

        * fast/js/date-big-setmonth.html: Changed to compare expected result with a Date value rather
        than with a constant. Also write out final result as a date rather than as a constant.
        * fast/js/date-big-setmonth-expected.txt: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoLayoutTests:
darin [Sun, 9 Oct 2005 03:31:11 +0000 (03:31 +0000)]
LayoutTests:

        - Added a test for http://bugzilla.opendarwin.org/show_bug.cgi?id=4821
          Text in submitted forms should be entity-encoded if the current encoding doesn't support it

        * fast/forms/form-data-encoding-expected.txt: Added.
        * fast/forms/form-data-encoding.html: Added.

WebCore:

        Reviewed by Maciej.

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4821
          Text in submitted forms should be entity-encoded if the current encoding doesn't support it

        Added one layout test.

        * khtml/html/html_formimpl.cpp:
        (DOM::HTMLFormElementImpl::formData): Pass true to the fromUnicode function to request entity encoding.
        (DOM::FormDataList::appendString): Ditto.

        * kwq/KWQTextCodec.h: Add boolean parameter to request entity-style encoding for characters that can't
        be expressed in the desired encoding.
        * kwq/KWQTextCodec.mm: (QTextCodec::fromUnicode): Added code to entity-encode characters that can't be
        expressed in the desired encoding.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoLayoutTests:
darin [Sun, 9 Oct 2005 02:57:21 +0000 (02:57 +0000)]
LayoutTests:

        Reviewed by Darin.

        - Added a test for http://bugzilla.opendarwin.org/show_bug.cgi?id=4707
          Need a way to automatically test for regressions in NSTextInput implementation

        * editing/input/text-input-controller-expected.txt: Added.
        * editing/input/text-input-controller.html: Added.

WebKitTools:

        Reviewed, rearranged and landed by Darin.

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4707
          Need a way to automatically test for regressions in NSTextInput implementation

        * DumpRenderTree/DumpRenderTree.m:
        (-[WaitUntilDoneDelegate webView:windowScriptObjectAvailable:]):
        Create a text input controller and put it in a property of the window object.

        * DumpRenderTree/TextInputController.h: Added.
        * DumpRenderTree/TextInputController.m: Added.
        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Darin.
darin [Sun, 9 Oct 2005 02:36:14 +0000 (02:36 +0000)]
    Reviewed by Darin.

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=3852
          typeahead doesn't work in multiple row select boxes.

        * kwq/KWQListBox.mm:
        (KWQTableViewTypeSelectCallback): Added.
        (-[KWQTableView finalize]): Deallocate the UCTypeSelect object.
        (-[KWQTableView dealloc]): Ditto.
        (-[KWQTableView keyUp:]): If character typed is a graphic character, pass it along to
        the UCTypeSelect object and use it to type select, otherwise flush the object.

        * manual-tests/select-element-type-select.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoLayoutTests:
darin [Sun, 9 Oct 2005 02:14:07 +0000 (02:14 +0000)]
LayoutTests:

        - Updated test results for fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=3245
          Support the 'bdo' element

        * fast/dom/HTMLElement/bdo.html: Updated test, no longer says to expect failure.
        * fast/dom/HTMLElement/bdo-expected.checksum: Correct results.
        * fast/dom/HTMLElement/bdo-expected.png: Ditto.
        * fast/dom/HTMLElement/bdo-expected.txt: Ditto.

        * fast/text/international/bidi-LDB-2-HTML-expected.checksum: Updated to expect correct
        results for the section done with <bdo>.
        * fast/text/international/bidi-LDB-2-HTML-expected.png: Ditto.
        * fast/text/international/bidi-LDB-2-HTML-expected.txt: Ditto.

WebCore:

        Reviewed by Darin.

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=3245
          Support the 'bdo' element

        Fixes the results of some existing layout tests.

        * khtml/xml/dom_elementimpl.h: Add eBDO to the list of entry types so there's a way to
        keep <bdo> dir attribute mappings separate from those of other elements.

        * khtml/html/html_elementimpl.cpp:
        (HTMLElementImpl::mapToEntry): Add special case to use eBDO for the dir attribute on
        elements with the <bdo> tag.
        (HTMLElementImpl::parseMappedAttribute): Use bidi-override for the unicode-bidi CSS property
        when setting it based on the dir attribute on a <bdo> tag. Along with the change above this
        obviates the need for an HTMLElementImpl subclass for <bdo>, but we could refactor it that
        way later if we decide there's an advantage to doing it that way.

        * khtml/css/html4.css: Remove the rules about <bdo>. They are insufficient, and now
        they are also unnecessary with the changes above.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoLayoutTests:
darin [Sun, 9 Oct 2005 01:46:17 +0000 (01:46 +0000)]
LayoutTests:

        Test cases for http://bugzilla.opendarwin.org/show_bug.cgi?id=4898
        (Failures in dbaron's bidi ordering tests).

        * fast/dom/HTMLElement/bdo-expected.txt: Updated for differently-breaking text runs.
        * fast/text/international/bidi-override-expected.txt: Updated because override characters no
        longer show up in the render tree.

        * fast/text/international/bidi-LDB-2-CSS-expected.checksum: Added.
        * fast/text/international/bidi-LDB-2-CSS-expected.png: Added.
        * fast/text/international/bidi-LDB-2-CSS-expected.txt: Added.
        * fast/text/international/bidi-LDB-2-CSS.html: Added.

        * fast/text/international/bidi-LDB-2-HTML-expected.checksum: Added.
        * fast/text/international/bidi-LDB-2-HTML-expected.png: Added.
        * fast/text/international/bidi-LDB-2-HTML-expected.txt: Added.
        * fast/text/international/bidi-LDB-2-HTML.html: Added.

        * fast/text/international/bidi-LDB-2-formatting-characters-expected.checksum: Added.
        * fast/text/international/bidi-LDB-2-formatting-characters-expected.png: Added.
        * fast/text/international/bidi-LDB-2-formatting-characters-expected.txt: Added.
        * fast/text/international/bidi-LDB-2-formatting-characters.html: Added.

        * fast/text/international/bidi-explicit-embedding-expected.checksum: Updated to now-correct results.
        * fast/text/international/bidi-explicit-embedding-expected.png: Ditto.
        * fast/text/international/bidi-explicit-embedding-expected.txt: Ditto.

WebCore:

        Reviewed by Darin.

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4898
          Failures in dbaron's bidi ordering tests

        Added 3 dbaron bidi ordering tests to LayoutTests.

        * khtml/rendering/bidi.cpp:
        (khtml::deleteBidiRuns):
        (khtml::Bidinext):
        (khtml::appendRunsForObject):
        (khtml::embed):
        (khtml::RenderBlock::bidiReorderLine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoBug #: 5240
eseidel [Sat, 8 Oct 2005 10:45:06 +0000 (10:45 +0000)]
Bug #: 5240
Submitted by: Rob Buis  <rwlbuis@xs4all.nl>
Reviewed by: eseidel
        Almost forgot the layout test for the last commit. ;)
        http://bugzilla.opendarwin.org/show_bug.cgi?id=5240

        * svg-tests/custom/use-forward-refs-expected.checksum: Added.
        * svg-tests/custom/use-forward-refs-expected.png: Added.
        * svg-tests/custom/use-forward-refs-expected.txt: Added.
        * svg-tests/custom/use-forward-refs.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoBug #: 5240
eseidel [Sat, 8 Oct 2005 09:18:15 +0000 (09:18 +0000)]
Bug #: 5240
Submitted by: Rob Buis  <rwlbuis@xs4all.nl>
Reviewed by: eseidel
        Fix to handle forward referencing <use> elements.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=5240

        * ksvg2/svg/SVGDocumentImpl.cpp:
        (SVGDocumentImpl::executeScripts): delayed close.
        (SVGDocumentImpl::addForwardReference): new function.
        * ksvg2/svg/SVGDocumentImpl.h:
        * ksvg2/svg/SVGUseElementImpl.cpp:
        (SVGUseElementImpl::close): delay close, if missing reference.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Justin.
harrison [Sat, 8 Oct 2005 00:51:25 +0000 (00:51 +0000)]
    Reviewed by Justin.

        Adjusted expected results after fixing position code in
        <rdar://problem/4064017> "Safari crashes at -[WebCoreBridge firstRectForDOMRange:] + 92"

        * editing/deleting/delete-at-paragraph-boundaries-002-expected.txt:
        * editing/deleting/delete-at-paragraph-boundaries-004-expected.txt:
        * editing/deleting/delete-at-paragraph-boundaries-005-expected.txt:
        * editing/selection/3690703-expected.txt:
        * editing/selection/3690719-expected.txt:
        * editing/selection/select-all-004-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Justin.
harrison [Sat, 8 Oct 2005 00:50:30 +0000 (00:50 +0000)]
    Reviewed by Justin.

        "<rdar://problem/4064017> Safari crashes at -[WebCoreBridge firstRectForDOMRange:] + 92"

        * khtml/editing/delete_selection_command.cpp:
        (khtml::DeleteSelectionCommand::insertPlaceholderForAncestorBlockContent):
        Do not insert placeholder if selection ends at a BR.

        (khtml::DeleteSelectionCommand::handleGeneralDelete):
        No need to preserve starting BR because insertPlaceholderForAncestorBlockContent already did.

        * khtml/xml/dom_position.cpp:
        (DOM::Position::upstream):
        (DOM::Position::downstream):
        Fixed to return original position instead of invisible position when no suitable position found upstream.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Hyatt.
vicki [Fri, 7 Oct 2005 18:38:46 +0000 (18:38 +0000)]
    Reviewed by Hyatt.

- pass the current form to the isindex constructor, so that isindex doesn't malfunction in the
case of a misnested form

        * khtml/html/htmlparser.cpp:
        (HTMLParser::handleIsindex):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Tim Omernick.
sullivan [Fri, 7 Oct 2005 18:31:50 +0000 (18:31 +0000)]
    Reviewed by Tim Omernick.

        WebKit support for allowing clients to know which frame originated a particular JavaScript alert/dialog.

        * WebView.subproj/WebUIDelegatePrivate.h:
        New optional delegate methods for the three JavaScript alert/dialogs. These are just like the existing
        ones in WebUIDelegate.h except that each adds a parameter specifying the frame that the JavaScript was
        running in. Eventually we'll deprecate the old three methods in favor of these in the public API.

        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge runJavaScriptAlertPanelWithMessage:]):
        Call version of the delegate method that has the frame parameter if the delegate supports it.
        (-[WebBridge runJavaScriptConfirmPanelWithMessage:]):
        ditto
        (-[WebBridge runJavaScriptTextInputPanelWithPrompt:defaultText:returningText:]):
        ditto

        * WebView.subproj/WebDefaultUIDelegate.m:
        (-[WebDefaultUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
        Now implements the new version of the delegate method that includes the frame parameter. (Still
        doesn't do anything though.)
        (-[WebDefaultUIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]):
        Now implements the new version of the delegate method that includes the frame parameter. (Still
        doesn't do anything though.)
        (-[WebDefaultUIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
        Now implements the new version of the delegate method that includes the frame parameter. Doesn't
        actually use the frame parameter here yet though.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoTweaked my ChangeLog entry.
justing [Fri, 7 Oct 2005 02:58:04 +0000 (02:58 +0000)]
Tweaked my ChangeLog entry.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by harrison
justing [Fri, 7 Oct 2005 01:32:51 +0000 (01:32 +0000)]
    Reviewed by harrison

        Test cases for:

        <rdar://problem/4073133> Tabbing between editable elements leads to loss of keyboard focus
        <rdar://problem/3690719> "Select All" when in an editable area selects the whole containing document
        <rdar://problem/3690703> selection is allowed to span editable area and rest of document

        * editing/selection/3690703-2-expected.checksum: Added.
        * editing/selection/3690703-2-expected.png: Added.
        * editing/selection/3690703-2-expected.txt: Added.
        * editing/selection/3690703-2.html: Added.
        * editing/selection/3690703-expected.checksum: Added.
        * editing/selection/3690703-expected.png: Added.
        * editing/selection/3690703-expected.txt: Added.
        * editing/selection/3690703.html: Added.
        * editing/selection/3690719-expected.checksum: Added.
        * editing/selection/3690719-expected.png: Added.
        * editing/selection/3690719-expected.txt: Added.
        * editing/selection/3690719.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by harrison
justing [Fri, 7 Oct 2005 01:21:47 +0000 (01:21 +0000)]
    Reviewed by harrison

        <rdar://problem/4073133> Tabbing between editable elements leads to loss of keyboard focus
        <rdar://problem/3690719> "Select All" when in an editable area selects the whole containing document
        <rdar://problem/3690703> selection is allowed to span editable area and rest of document

        * khtml/editing/SelectionController.cpp:
        (khtml::SelectionController::adjustExtentForEditableContent):
        Added, ensures that a selection cannot cross an editable/non-editable boundry.
        (khtml::SelectionController::validate):
        * khtml/editing/SelectionController.h:
        * khtml/editing/visible_position.h:
        * khtml/khtml_part.cpp:
        (KHTMLPart::setSelection):
        (KHTMLPart::setFocusNodeIfNeeded):
        (KHTMLPart::selectAll):
        Select only the contents of the rootEditableElement, if it exists.  Also now calls the shouldChangeSelection delegate method.
        * khtml/xml/dom_nodeimpl.cpp:
        (DOM::ContainerNodeImpl::setFocus): Clicking on an editable element used to change the selection twice.
        * kwq/KWQKHTMLPart.mm:
        (KWQKHTMLPart::nextKeyViewInFrame): Select All when tabbing to an editable element, to match <textarea>s

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago - updated layout tests for <rdar://problem/4288307> <form> element is
vicki [Fri, 7 Oct 2005 00:50:53 +0000 (00:50 +0000)]
- updated layout tests for <rdar://problem/4288307> <form> element is
created for <isindex> outside <form>; that's not correct (4828)

        * dom/html/level2/html/HTMLIsIndexElement02-expected.txt: update this result,
since we now pass this test

        * fast/dom/isindex-002-expected.checksum: Added.
        * fast/dom/isindex-002-expected.png: Added.
        * fast/dom/isindex-002-expected.txt: Added.
        * fast/dom/isindex-002.html: Added.

- renamed this test
        * fast/dom/isindex-alone-expected.checksum: Removed.
        * fast/dom/isindex-alone-expected.png: Removed.
        * fast/dom/isindex-alone-expected.txt: Removed.
        * fast/dom/isindex-alone.html: Removed.
        * fast/dom/isindex-001-expected.checksum: Added.
        * fast/dom/isindex-001-expected.png: Added.
        * fast/dom/isindex-001-expected.txt: Added.
        * fast/dom/isindex-001.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Beth Dakin.
vicki [Fri, 7 Oct 2005 00:46:49 +0000 (00:46 +0000)]
    Reviewed by Beth Dakin.

- fix <rdar://problem/4288307> <form> element is created for <isindex> outside <form>; that's not correct (4828)

        * khtml/html/htmlparser.cpp:
        (HTMLParser::handleIsindex): if there's no current form, don't create one

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago*** empty log message ***
bdakin [Thu, 6 Oct 2005 22:45:46 +0000 (22:45 +0000)]
*** empty log message ***

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Beth Dakin.
sullivan [Thu, 6 Oct 2005 22:06:49 +0000 (22:06 +0000)]
    Reviewed by Beth Dakin.

        No test cases added because this does not affect layout.

        * kwq/KWQTextArea.mm:
        (-[KWQTextAreaTextView setLineHeight:]):
        Don't call [textView didChangeText] here, because the text itself did not change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoBug #:
bdakin [Thu, 6 Oct 2005 21:48:09 +0000 (21:48 +0000)]
Bug #:
Submitted by:
Reviewed by:
Bug #:
Submitted by:
Reviewed by:
Bug #:
Submitted by:
Reviewed by:
Bug #:
Submitted by:
Reviewed by:
Bug #:
Submitted by:
Reviewed by:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago - fixed compiling on Deployment
darin [Thu, 6 Oct 2005 21:19:47 +0000 (21:19 +0000)]
    - fixed compiling on Deployment

        * WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer initWithFont:]):
        Put initialFont inside !LOG_DISABLED.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Eric.
darin [Thu, 6 Oct 2005 21:14:23 +0000 (21:14 +0000)]
    Reviewed by Eric.

        - tweaked formatting

        * WebCoreSupport.subproj/WebTextRenderer.m: Changed function names to remove underscores;
        fixed formatting to match our coding guidelines, other related tweaks.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Eric.
darin [Thu, 6 Oct 2005 21:00:38 +0000 (21:00 +0000)]
    Reviewed by Eric.

        - fixed regression in drawing of text in non-flipped contexts from my last check-in

        * WebCoreSupport.subproj/WebTextRenderer.m:
        (drawGlyphs): Only flip the matrix if the NSGraphicsContext is flipped.
        (-[WebTextRenderer _ATSU_drawRun:style:geometry:]): Use -[NSGraphicsContext isFlipped]
        instead of [[NSView focusView] isFlipped].

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoBug #:
bdakin [Thu, 6 Oct 2005 20:46:41 +0000 (20:46 +0000)]
Bug #:
Submitted by:
Reviewed by:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoBug #:
bdakin [Thu, 6 Oct 2005 19:16:13 +0000 (19:16 +0000)]
Bug #:
Submitted by:
Reviewed by:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by hyatt.
harrison [Thu, 6 Oct 2005 18:37:42 +0000 (18:37 +0000)]
    Reviewed by hyatt.

        No test cases added or changed because this patch does not address a bug.

        Fix two detach/destroy renames I missed yesterday.

        * khtml/rendering/bidi.cpp:
        (khtml::BidiRun::destroy):
        (khtml::BidiRun::operator delete):
        Renamed inBidiRunDetach to inBidiRunDestroy.

        * khtml/rendering/render_layer.cpp:
        (khtml::RenderLayer::operator delete):
        (khtml::RenderLayer::destroy):
        Renamed inRenderLayerDetach to inRenderLayerDestroy.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoLayoutTests:
darin [Thu, 6 Oct 2005 15:46:16 +0000 (15:46 +0000)]
LayoutTests:

        - updated test result for synthetic bold

        * editing/pasteboard/paste-text-011-expected.checksum: Regenerated.
        * editing/pasteboard/paste-text-011-expected.png: Ditto.
        * editing/pasteboard/paste-text-011-expected.txt: Ditto.

        - updated test result that was incorrect

        * fast/dom/namednodemap-namelookup-expected.txt: Added trailing newlines

WebCore:

        Reviewed by Hyatt.

        - fixed <rdar://problem/3217793> Monaco bold comes out as Helvetica bold, very bad if you choose Monaco as your fixed-width font
        - fixed <rdar://problem/3256269> CSS1: bold/italic font styles not programmatically created if font doesn't include them (3231)
          also <http://bugzilla.opendarwin.org/show_bug.cgi?id=3231>

        * kwq/WebCoreTextRendererFactory.h: Added WebCoreFont structure, and made this header work for
        non-Objective-C compiles. Changed all the methods to take and return WebCoreFont instead of
        NSFont *.
        * kwq/WebCoreTextRendererFactory.mm:
        (WebCoreInitializeFont): Added.
        (-[WebCoreTextRendererFactory fontWithFamilies:traits:size:]): Updated to use ERROR so we notice
        cases where the subclass does not override these methods.
        (-[WebCoreTextRendererFactory isFontFixedPitch:]): Ditto.
        (-[WebCoreTextRendererFactory rendererWithFont:]): Ditto.

        * WebCore.exp: Added WebCoreInititalizeFont.

        * kwq/KWQFont.h: Added WebCoreFont support.
        * kwq/KWQFont.mm:
        (QFont::QFont): Change to use WebCoreFont.
        (QFont::~QFont): Ditto.
        (QFont::operator=): Ditto.
        (QFont::setFamily): Ditto.
        (QFont::setFirstFamily): Ditto.
        (QFont::setPixelSize): Ditto.
        (QFont::setWeight): Ditto.
        (QFont::setItalic): Ditto.
        (QFont::determinePitch): Ditto.
        (QFont::getWebCoreFont): Added.

        * kwq/KWQComboBox.mm: (QComboBox::sizeHint): Pass in WebCoreFont when creating text renderer.
        * kwq/KWQFontMetrics.mm: (QFontMetricsPrivate::getRenderer): Ditto.
        * kwq/KWQLineEdit.mm: (QLineEdit::sizeForCharacterWidth): Ditto.
        * kwq/KWQListBox.mm:
        (itemTextRenderer): Ditto.
        (groupLabelTextRenderer): Ditto.
        (QListBox::sizeForNumberOfLines): Changed non-system-font case to use QFont rather than NSFont
        to add boldness, so that group label fonts are bolded even if it's synthesiized bold.
        (-[KWQTableView drawRow:clipRect:]): Ditto.
        * kwq/KWQPainter.mm: (QPainter::_updateRenderer): Pass in WebCoreFont when creating text renderer.

WebKit:

        Reviewed by Hyatt.

        - fixed <rdar://problem/3217793> Monaco bold comes out as Helvetica bold, very bad if you choose Monaco as your fixed-width font
        - fixed <rdar://problem/3256269> CSS1: bold/italic font styles not programmatically created if font doesn't include them (3231)
          also <http://bugzilla.opendarwin.org/show_bug.cgi?id=3231>

        * WebCoreSupport.subproj/WebTextRenderer.h: Removed public declarations of private structures that are not
        used in the header. Removed the separate 16-bit character map; the difference in code size is only a few
        bytes per page and there's no measurable performance difference by always using the 32-bit character version.
        Removed substitute font width maps altogether, since we now use the width map in the substitute font's renderer.
        Also removed a few more now-unused fields and methods. Changed initWithFont to take WebCoreFont. Changed
        the setAlwaysUseATSU: method to remove the underscore prefix.

        * WebCoreSupport.subproj/WebTextRenderer.m:
        (getUncachedWidth): Get font from WebCoreFont directly instead of taking a parameter, since we now use only
        one NSFont per WebTextRenderer.
        (widthFromMap): Removed NSFont parameter for same reason as above; simplified.
        (widthForGlyph): Ditto.
        (overrideLayoutOperation): Updated for change to WebCoreFont.
        (-[WebTextRenderer initWithFont:]): Changed to use WebCoreFont. Removed code to deal with substitute font maps.
        Changed lineGap computation to use floats instead of doubles. Added code to compute a synthetic bold offset.
        Currently this is the font size divided by 24 and then rounded up to an integer.
        (-[WebTextRenderer dealloc]): Updated for change to WebCoreFont and other related changes.
        (-[WebTextRenderer finalize]): Ditto.
        (-[WebTextRenderer xHeight]): Ditto.
        (-[WebTextRenderer drawRun:style:geometry:]): Remove small caps case here; no longer needed. Also updated as above.
        (-[WebTextRenderer floatWidthForRun:style:widths:]): Ditto.
        (-[WebTextRenderer drawHighlightForRun:style:geometry:]): Ditto.
        (-[WebTextRenderer pointToOffset:style:position:reversed:includePartialGlyphs:]): Ditto.
        (+[WebTextRenderer setAlwaysUseATSU:]): Renamed to remove underscore prefix.
        (-[WebTextRenderer smallCapsRenderer]): Ditto. Changed to create a renderer for the smaller sized font.
        (-[WebTextRenderer _substituteFontForString:families:]): Reorganized this to be more readable and to call
        the new rendererForAlternateFont method.
        (-[WebTextRenderer rendererForAlternateFont:]): Added. Used to select an alternate font taking into account
        bold and italic synthesis.
        (-[WebTextRenderer substituteRendererForCharacters:length:families:]): Renamed to remove underscore prefix.
        Updated to use rendererForAlternateFont.
        (-[WebTextRenderer _computeWidthForSpace]): Updated for name changes and to remove unnecessary parameters.
        (-[WebTextRenderer setUpFont]): Renamed to remove underscore prefix. Added code to get printer or screen
        font as specified by WebCoreFont so calers don't need to do this.
        (drawGlyphs): Renamed to remove underscore prefix. Added code for synthetic oblique (14 degree slant), and
        synthetic bold (add offset and draw text a second time).
        (-[WebTextRenderer _CG_drawRun:style:geometry:]): Keep an array of substitute renderers instead of fonts.
        Changed around the loop to reverse the run to be a single loop instead of 3.
        (-[WebTextRenderer floatWidthForRun:style:widths:substituteRenderers:glyphs:startPosition:numGlyphs:]):
        Renamed to remove the underscore prefix.
        (-[WebTextRenderer _CG_floatWidthForRun:style:widths:substituteRenderers:glyphs:startPosition:numGlyphs:]):
        Changed to use subsitute renderers rather than fonts.
        (-[WebTextRenderer updateGlyphEntryForCharacter:glyphID:substituteRenderer:]): Renamed to remove underscore
        prefix and changed to use a substitute renderer rather than a substitute NSFont.
        (-[WebTextRenderer extendCharacterToGlyphMapToInclude:]): Updated to work with all characters, both ones
        that fit into 16-bit and ones that don't.
        (-[WebTextRenderer _extendGlyphToWidthMapToInclude:]): Removed NSFont parameter and simplified. This fixes
        a bug where numberOfGlyphs was accidentally used from the main font instead of "subFont".
        (glyphForCharacter): Changed to use subsitute renderers instead of substitute fonts.
        (widthForNextCharacter): Ditto. Also removed small caps code no longer needed here and replaced it with
        simpler small caps code that no longer assumes glyphs match.
        (shouldUseATSU): Changed the code to check ranges in order to slightly reduce the number of cases and
        to create earlier exit for lower character codes.

        * WebCoreSupport.subproj/WebTextRendererFactory.h: Added caches for synthesized font and oblique
        variants so we can still use the NSFont as the dictionary key. Removed coalesceTextDrawing methods.
        Changed methods to use WebCoreFont as the parameters and results instead of NSFont.
        * WebCoreSupport.subproj/WebTextRendererFactory.m:
        (-[WebTextRendererFactory clearCaches]): Clear all 8 caches.
        (-[WebTextRendererFactory isFontFixedPitch:]): Changed code slightly so there's only one call to
        the CFDictionarySetValue function.
        (-[WebTextRendererFactory init]): Create all 8 caches.
        (-[WebTextRendererFactory dealloc]): Release all 8 caches.
        (-[WebTextRendererFactory rendererWithFont:]): Select the appropriate cache based on 3 booleans:
        synthetic bold, synthetic oblique, and printer. Use WebCoreFont instead of NSFont.
        (-[WebTextRendererFactory fontWithFamilies:traits:size:]): Set the synthetic bold and oblique flags
        when returning a WebCoreFont based on requested traits that are not present in the NSFont.
        (acceptableChoice): Ignore the synthesizable traits when deciding if a chosen font is acceptable.
        (betterChoice): Rather than assuming that every font has all the desired traits, implement a rule
        that says a font with an unwanted trait loses out over a font that does not have an unwanted trait.
        This lets us chose a bold font over a non-bold font that could use synthesized bold but treat both
        as candidates.

        * WebCoreSupport.subproj/WebGlyphBuffer.h: Removed.
        * WebCoreSupport.subproj/WebGlyphBuffer.m: Removed.
        * WebKit.xcodeproj/project.pbxproj: Removed WebGlyphBuffer source files.

        * Misc.subproj/WebKitNSStringExtras.m:
        (-[NSString _web_drawAtPoint:font:textColor:]): Update to use WebCoreFont.
        (-[NSString _web_widthWithFont:]): Ditto.
        * Misc.subproj/WebStringTruncator.m:
        (truncateString): Ditto.
        (+[WebStringTruncator widthOfString:font:]): Ditto.

        * WebView.subproj/WebHTMLView.m: (-[WebHTMLView drawRect:]): Removed text drawing coalesce method calls.
        * WebView.subproj/WebTextView.m: (-[WebTextView setFixedWidthFont]): Updated to use cachedFontFromFamily
        method, which we still have, rather than fontWithFamilies method which we don't (since it now uses WebCoreFont).
        * WebView.subproj/WebView.m: (+[WebView _setAlwaysUseATSU:]): Updated for name change to underlying method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago * Scripts/cvs-apply: Fixed merge option to work better when not all directories
darin [Thu, 6 Oct 2005 15:44:59 +0000 (15:44 +0000)]
    * Scripts/cvs-apply: Fixed merge option to work better when not all directories
        are controlled by cvs, or when changes cross multiple repositories.
        * Scripts/update-webkit: Don't print messages if the "quiet" flag is set.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Test cases for <rdar://problem/4288829> repro crash on isIndex tag with no attributes
vicki [Thu, 6 Oct 2005 06:38:25 +0000 (06:38 +0000)]
Test cases for <rdar://problem/4288829> repro crash on isIndex tag with no attributes

This test case will have to be updated once <rdar://problem/4288839> (isindex tag alone in
document doesn't end up in the DOM) is fixed

        * fast/dom/isindex-alone-expected.checksum: Added.
        * fast/dom/isindex-alone-expected.png: Added.
        * fast/dom/isindex-alone-expected.txt: Added.
        * fast/dom/isindex-alone.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Maciej.
vicki [Thu, 6 Oct 2005 06:31:35 +0000 (06:31 +0000)]
    Reviewed by Maciej.

- fix <rdar://problem/4288829> repro crash on isIndex tag with no attributes

        * khtml/html/htmlparser.cpp:
        (HTMLParser::handleIsindex): only deref attributes if they exist

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Test cases for <rdar://problem/3798746> hang in JavaScript getting at URL...
mjs [Thu, 6 Oct 2005 06:22:37 +0000 (06:22 +0000)]
    Test cases for <rdar://problem/3798746> hang in JavaScript getting at URL from frame; isc.fraunhofer.de (works in IE and Firefox)

        * ChangeLog:
        * fast/dom/early-frame-url-expected.txt: Added.
        * fast/dom/early-frame-url.html: Added.
        * fast/dom/resources/a.html: Added.
        * fast/dom/resources/b.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Eric.
mjs [Thu, 6 Oct 2005 04:13:12 +0000 (04:13 +0000)]
    Reviewed by Eric.

<rdar://problem/4150976> Safari crashes in HTMLImageLoader::dispatchLoadEvent() on particular page (archive attached)

I couldn't figure out how to make an automated test for this; even once I got DumpRenderTree
to mouse in and out it did not crash.

        * khtml/html/html_imageimpl.cpp:
        (HTMLImageLoader::dispatchLoadEvent): Check if CachedImage is null before using it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago - Darin and I rewrote our implementation of the SimpleNumber class
ggaren [Thu, 6 Oct 2005 01:13:18 +0000 (01:13 +0000)]
    - Darin and I rewrote our implementation of the SimpleNumber class
          to store number bit patterns in their floating point formats.

        My tweaks reviewed by Darin.

        ~1% speedup on JS iBench.

        * kjs/internal.h: removed obsolete jsNumber declarations.
        * kjs/math_object.cpp:
        (MathFuncImp::callAsFunction): changed KJS::isNaN to isNaN
        * kjs/nodes.cpp:
        (PostfixResolveNode::evaluate): removed obsolete knownToBeInteger
        (PostfixBracketNode::evaluate): ditto
        (PostfixDotNode::evaluate): ditto
        (PrefixResolveNode::evaluate): ditto
        (PrefixBracketNode::evaluate): ditto
        (PrefixDotNode::evaluate): ditto
        (NegateNode::evaluate): ditto
        (valueForReadModifyAssignment): ditto
        * kjs/number_object.cpp: removed obsolete comment
        * kjs/operations.cpp:
        (KJS::equal): removed unnecessary isNaN checks
        (KJS::strictEqual): ditto
        (KJS::add): removed obsolete knownToBeInteger
        (KJS::mult): ditto
        * kjs/operations.h: removed include of "value.h" to prevent circular reference
        * kjs/simple_number.h: removed unnecessary #includes
        (KJS::SimpleNumber::make): see above
        (KJS::SimpleNumber::is): ditto
        (KJS::SimpleNumber::value): ditto
        * kjs/string_object.cpp:
        (StringProtoFuncImp::callAsFunction): changed KJS::isNaN to isNaN
        * kjs/ustring.cpp: removed unnecessary isNaN check
        (KJS::UString::toUInt32): ditto
        * kjs/value.cpp:
        (KJS::jsNumber): removed obsolete jsNumber definitions
        (KJS::ConstantValues::init): NaN is no longer a ConstantValue
        (KJS::ConstantValues::clear): ditto
        (KJS::ConstantValues::mark): ditto
        * kjs/value.h: removed obsolete knownToBeInteger
        (KJS::jsNaN): now returns a SimpleNumber
        (KJS::ValueImp::getUInt32): changed to account for NaN being a SimpleNumber
        (KJS::ValueImp::toBoolean): ditto
        (KJS::ValueImp::toString): changed to account for +/- 0.0
        (KJS::jsZero): changed to reflect that SimpleNumber::make takes a double
        (KJS::jsOne): ditto
        (KJS::jsTwo): ditto
        (KJS::Number): removed obsolete non-double constructor declarations

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Darin.
harrison [Thu, 6 Oct 2005 00:54:06 +0000 (00:54 +0000)]
    Reviewed by Darin.

        No test cases added or changed because this patch does not address a bug.

        For clarity, renamed the "detach()" function to "destroy()" in the following classes:
        RenderObject (and subclasses),  BidiRun, ClipRects, InlineBox (and subclasses).

        * khtml/rendering/bidi.cpp:
        (khtml::BidiRun::destroy):
        (khtml::BidiRun::operator delete):
        (khtml::deleteBidiRuns):
        * khtml/rendering/bidi.h:
        * khtml/rendering/render_block.cpp:
        (khtml::RenderBlock::removeChild):
        (khtml::RenderBlock::updateFirstLetter):
        * khtml/rendering/render_box.cpp:
        (RenderBox::destroy):
        (RenderBox::dirtyLineBoxes):
        (RenderBox::position):
        (RenderBox::deleteLineBoxWrapper):
        * khtml/rendering/render_box.h:
        * khtml/rendering/render_container.cpp:
        (RenderContainer::destroy):
        (RenderContainer::updatePseudoChild):
        (RenderContainer::removeLeftoverAnonymousBoxes):
        * khtml/rendering/render_container.h:
        * khtml/rendering/render_flow.cpp:
        (RenderFlow::deleteLineBoxes):
        (RenderFlow::destroy):
        * khtml/rendering/render_flow.h:
        * khtml/rendering/render_form.cpp:
        (RenderTextArea::destroy):
        * khtml/rendering/render_form.h:
        * khtml/rendering/render_layer.cpp:
        (khtml::ClipRects::operator delete):
        (khtml::ClipRects::destroy):
        (khtml::RenderLayer::operator delete):
        (khtml::RenderLayer::destroy):
        (khtml::RenderLayer::removeOnlyThisLayer):
        * khtml/rendering/render_layer.h:
        (khtml::ClipRects::deref):
        * khtml/rendering/render_line.cpp:
        (khtml::InlineBox::destroy):
        (khtml::InlineBox::operator delete):
        (khtml::InlineBox::deleteLine):
        (khtml::InlineFlowBox::deleteLine):
        (khtml::RootInlineBox::destroy):
        (khtml::RootInlineBox::detachEllipsisBox):
        * khtml/rendering/render_line.h:
        * khtml/rendering/render_list.cpp:
        (RenderListItem::setStyle):
        (RenderListItem::destroy):
        * khtml/rendering/render_list.h:
        * khtml/rendering/render_object.cpp:
        (RenderObject::operator delete):
        (RenderObject::destroy):
        * khtml/rendering/render_object.h:
        * khtml/rendering/render_replaced.cpp:
        (RenderWidget::destroy):
        * khtml/rendering/render_replaced.h:
        * khtml/rendering/render_style.cpp:
        (RenderStyle::operator delete):
        * khtml/rendering/render_table.cpp:
        (RenderTableSection::destroy):
        (RenderTableRow::destroy):
        (RenderTableRow::removeChildNode):
        (RenderTableCell::destroy):
        * khtml/rendering/render_table.h:
        * khtml/rendering/render_text.cpp:
        (InlineTextBox::destroy):
        (InlineTextBox::operator delete):
        (InlineTextBox::deleteLine):
        (RenderText::destroy):
        (RenderText::deleteTextBoxes):
        (RenderText::position):
        * khtml/rendering/render_text.h:
        * khtml/xml/dom_docimpl.cpp:
        (DocumentImpl::detach):
        * khtml/xml/dom_nodeimpl.cpp:
        (DOM::NodeImpl::detach):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Eric.
mjs [Wed, 5 Oct 2005 21:07:33 +0000 (21:07 +0000)]
    Reviewed by Eric.

<rdar://problem/4158439> Safari appears to hang when sending synchronous XMLHttpRequest that gets no server response

No testcase - not testable w/o network.

        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge syncLoadResourceWithURL:customHeaders:postData:finalURL:responseHeaders:statusCode:]): Set a timeout of 10.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by beth
justing [Wed, 5 Oct 2005 20:54:33 +0000 (20:54 +0000)]
    Reviewed by beth

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=5245>
        Adding missing pixel results for test cases checked in recently.

        * editing/inserting/4278698-expected.checksum: Added.
        * editing/inserting/4278698-expected.png: Added.
        * editing/pasteboard/4076267-2-expected.checksum: Added.
        * editing/pasteboard/4076267-2-expected.png: Added.
        * editing/pasteboard/4076267-3-expected.checksum: Added.
        * editing/pasteboard/4076267-3-expected.png: Added.
        * editing/pasteboard/4076267-expected.checksum: Added.
        * editing/pasteboard/4076267-expected.png: Added.
        * editing/undo/4063751-expected.checksum: Added.
        * editing/undo/4063751-expected.png: Added.
        * fast/css/imageTileOpacity-expected.checksum: Added.
        * fast/css/imageTileOpacity-expected.png: Added.
        * fast/forms/textAreaLineHeight-expected.checksum: Added.
        * fast/forms/textAreaLineHeight-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Eric.
mjs [Wed, 5 Oct 2005 10:31:12 +0000 (10:31 +0000)]
    Reviewed by Eric.

- fixed <rdar://problem/3798746> hang in JavaScript getting at URL from frame; isc.fraunhofer.de (works in IE and Firefox)

* khtml/xml/dom_docimpl.h:
        (DOM::DocumentImpl::URL): if the URL is empty, return "about:blank", the JS DOM
at least counts on this, so we may as well do it for other languages too.
        (DOM::DocumentImpl::baseURL): base it on URL(), not m_url

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoBug #: none
eseidel [Wed, 5 Oct 2005 08:21:36 +0000 (08:21 +0000)]
Bug #: none
Submitted by: eseidel
Reviewed by: mjs
        Improves dependency checking so that SVG JavaScript wrapper files
        regenerate when the perl scripts change.

        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoBug #: 5175
eseidel [Wed, 5 Oct 2005 08:18:26 +0000 (08:18 +0000)]
Bug #: 5175
Submitted by: eseidel
Reviewed by: mjs
        Makes <object> tags not use image mode for svg content:
        http://bugzilla.opendarwin.org/show_bug.cgi?id=5175

        * khtml/html/html_objectimpl.cpp:
        (DOM::HTMLObjectElementImpl::isImageType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoJavaScriptCore:
mjs [Wed, 5 Oct 2005 08:05:44 +0000 (08:05 +0000)]
JavaScriptCore:

        Reviewed by Eric.

- fixed <rdar://problem/4260481> Remove Reference type from JavaScriptCore

Also fixed some bugs with for..in enumeration while I was at it. object
properties now come before prototype properties and duplicates
between object and prototype are listed only once.

        * JavaScriptCore.xcodeproj/project.pbxproj:
        * kjs/IdentifierSequencedSet.cpp: Added.
        (KJS::IdentifierSequencedSet::IdentifierSequencedSet):
        (KJS::IdentifierSequencedSet::deallocateVector):
        (KJS::IdentifierSequencedSet::~IdentifierSequencedSet):
        (KJS::IdentifierSequencedSet::insert):
        * kjs/IdentifierSequencedSet.h: Added.
        (KJS::IdentifierSequencedSetIterator::IdentifierSequencedSetIterator):
        (KJS::IdentifierSequencedSetIterator::operator*):
        (KJS::IdentifierSequencedSetIterator::operator->):
        (KJS::IdentifierSequencedSetIterator::operator++):
        (KJS::IdentifierSequencedSetIterator::operator==):
        (KJS::IdentifierSequencedSetIterator::operator!=):
        (KJS::IdentifierSequencedSet::begin):
        (KJS::IdentifierSequencedSet::end):
        (KJS::IdentifierSequencedSet::size):
        * kjs/array_instance.h:
        * kjs/array_object.cpp:
        (ArrayInstanceImp::getPropertyNames):
        (ArrayInstanceImp::setLength):
        (ArrayInstanceImp::pushUndefinedObjectsToEnd):
        * kjs/nodes.cpp:
        (ForInNode::execute):
        * kjs/nodes.h:
        * kjs/object.cpp:
        (KJS::ObjectImp::getPropertyNames):
        * kjs/object.h:
        * kjs/property_map.cpp:
        (KJS::PropertyMap::getEnumerablePropertyNames):
        (KJS::PropertyMap::getSparseArrayPropertyNames):
        * kjs/property_map.h:
        * kjs/protect.h:
        * kjs/protected_reference.h: Removed.
        * kjs/reference.cpp: Removed.
        * kjs/reference.h: Removed.
        * kjs/reference_list.cpp: Removed.
        * kjs/reference_list.h: Removed.
        * kjs/ustring.h:
        (KJS::UString::impl):
        * kxmlcore/HashSet.h:

LayoutTests:

        Reviewed by Eric.

        - test case for some fixes I made to for..in enumeration. object
properties now come before prototype properties and duplicates
between object and prototype are listed only once.

        * fast/js/for-in-expected.txt: Added.
        * fast/js/for-in.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Maciej.
mjs [Wed, 5 Oct 2005 07:50:44 +0000 (07:50 +0000)]
    Reviewed by Maciej.

        * khtml/ecma/kjs_dom.cpp:
        (KJS::DOMNodeProtoFunc::callAsFunction):
        * khtml/ecma/kjs_dom.h:
Add JS binding for isSameNode.

        (KJS::DOMNode::):
        * khtml/xml/dom_nodeimpl.h:
Implement isSameNode.

        (DOM::NodeImpl::isSameNode):
        * kwq/DOM.mm:
        (-[DOMNode isSameNode:]):
Add ObjC binding for isSameNode.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago2005-10-05 Anders Carlsson <andersca@mac.com>
andersca [Wed, 5 Oct 2005 07:26:47 +0000 (07:26 +0000)]
2005-10-05  Anders Carlsson  <andersca@mac.com>

        Reviewed by Maciej.

        * khtml/ecma/kjs_dom.cpp:
        (KJS::DOMNodeProtoFunc::callAsFunction):
        * khtml/ecma/kjs_dom.h:
Add JS binding for isSameNode.

        (KJS::DOMNode::):
        * khtml/xml/dom_nodeimpl.h:
Implement isSameNode.

        (DOM::NodeImpl::isSameNode):
        * kwq/DOM.mm:
        (-[DOMNode isSameNode:]):
Add ObjC binding for isSameNode.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Eric.
mjs [Wed, 5 Oct 2005 07:14:06 +0000 (07:14 +0000)]
    Reviewed by Eric.

- fixed a random crasher that happens because the HTMLParser accidentally was refing
the document.

I couldn't figure out how to make a reproducible test case for this. The failure is
random memory trashing.

        * khtml/html/htmlparser.cpp:
        (HTMLStackElem::HTMLStackElem):
        (HTMLStackElem::~HTMLStackElem):
        (HTMLParser::popNestedHeaderTag):
        (HTMLParser::handleResidualStyleCloseTagAcrossBlocks):
        (HTMLParser::popOneBlock):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago2005-10-05 Anders Carlsson <andersca@mac.com>
andersca [Wed, 5 Oct 2005 07:11:38 +0000 (07:11 +0000)]
2005-10-05  Anders Carlsson  <andersca@mac.com>

        Reviewed by Maciej.

        * dom/xhtml/level3/core/nodeissamenode01-expected.txt:
        * dom/xhtml/level3/core/nodeissamenode02-expected.txt:
        * dom/xhtml/level3/core/nodeissamenode03-expected.txt:
        * dom/xhtml/level3/core/nodeissamenode04-expected.txt:
        * dom/xhtml/level3/core/nodeissamenode05-expected.txt:
        * dom/xhtml/level3/core/nodeissamenode06-expected.txt:
        * dom/xhtml/level3/core/nodeissamenode10-expected.txt:
These tests pass now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Eric.
mjs [Wed, 5 Oct 2005 07:01:49 +0000 (07:01 +0000)]
    Reviewed by Eric.

<rdar://problem/4285236> Denver Regression: crash repeatedly reloading www.supermanhomepage.com

I couldn't figure out how to make a reproducible test case for this. The failure is
random memory trashing.

        * khtml/ecma/kjs_events.cpp:
        (KJS::JSAbstractEventListener::handleEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoBug #: 4285884
eseidel [Wed, 5 Oct 2005 06:09:12 +0000 (06:09 +0000)]
Bug #: 4285884
Submitted by: eseidel
Reviewed by: mjs
        Test direct name lookup in DOMNamedNodeMap, like FireFox/IE.
        <rdar://problem/4285884> Gap.com throws exception "Undefined value" because of Safari doesn't support indexing into a named node map by name

        * fast/dom/namednodemap-namelookup-expected.txt: Added.
        * fast/dom/namednodemap-namelookup.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoBug #: 4285884
eseidel [Wed, 5 Oct 2005 06:08:08 +0000 (06:08 +0000)]
Bug #: 4285884
Submitted by: eseidel
Reviewed by: mjs
        Support direct named attribute lookkup, like FireFox,IE.
        This was causing a JavaScript exception for gap.com
        <rdar://problem/4285884> Gap.com throws exception "Undefined value" because of Safari doesn't support indexing into a named node map by name

        * khtml/ecma/kjs_dom.cpp:
        (KJS::DOMNodeList::getOwnPropertySlot): if cleanup
        (KJS::DOMNamedNodeMap::nameGetter):
        (KJS::DOMNamedNodeMap::getOwnPropertySlot):
        * khtml/ecma/kjs_dom.h: added nameGetter

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoBug #: 5254
eseidel [Wed, 5 Oct 2005 05:36:55 +0000 (05:36 +0000)]
Bug #: 5254
Submitted by: eseidel
Reviewed by: none needed, build fix only.
        Fix to include "config.h" in every file.
        Necessary to support fastMalloc.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=5254

        * WebCore+SVG/DrawCanvasItem.mm:
        * WebCore+SVG/DrawDocument.mm:
        * WebCore+SVG/DrawView.mm:
        * WebCore+SVG/dom_kdomdocumentwrapper.cpp:
        * WebCore+SVG/dom_kdomnodetreewrapper.cpp:
        * WebCore+SVG/render_kcanvaswrapper.cpp:
        * WebCore+SVG/xml_kdomtokenizer.cpp:
        * kcanvas/KCanvas.cpp:
        * kcanvas/KCanvasContainer.cpp:
        * kcanvas/KCanvasCreator.cpp:
        * kcanvas/KCanvasFilters.cpp:
        * kcanvas/KCanvasImage.cpp:
        * kcanvas/KCanvasItem.cpp:
        * kcanvas/KCanvasMatrix.cpp:
        * kcanvas/KCanvasPath.cpp:
        * kcanvas/KCanvasRegistry.cpp:
        * kcanvas/KCanvasResources.cpp:
        * kcanvas/KCanvasTreeDebug.cpp:
        * kcanvas/KCanvasView.cpp:
        * kcanvas/device/KRenderingDevice.cpp:
        * kcanvas/device/KRenderingDeviceFactory.cpp:
        * kcanvas/device/KRenderingFillPainter.cpp:
        * kcanvas/device/KRenderingPaintServerGradient.cpp:
        * kcanvas/device/KRenderingPaintServerImage.cpp:
        * kcanvas/device/KRenderingPaintServerPattern.cpp:
        * kcanvas/device/KRenderingPaintServerSolid.cpp:
        * kcanvas/device/KRenderingStrokePainter.cpp:
        * kcanvas/device/KRenderingStyle.cpp:
        * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
        * kcanvas/device/quartz/KCanvasItemQuartz.mm:
        * kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
        * kcanvas/device/quartz/KCanvasViewQuartz.mm:
        * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
        * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
        * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
        * kcanvas/device/quartz/QuartzSupport.mm:
        * kdom/DOMString.cpp:
        * kdom/Helper.cpp:
        * kdom/KDOMPart.cpp:
        * kdom/KDOMSettings.cpp:
        * kdom/KDOMView.cpp:
        * kdom/Shared.cpp:
        * kdom/backends/libxml/LibXMLParser.cpp:
        * kdom/bindings/IDLCodeGeneratorEcmaInterface.pm:
        * kdom/bindings/IDLCodeGeneratorJs.pm:
        * kdom/cache/ImageSource.cpp:
        * kdom/cache/KDOMCache.cpp:
        * kdom/cache/KDOMCachedDocument.cpp:
        * kdom/cache/KDOMCachedImage.cpp:
        * kdom/cache/KDOMCachedObject.cpp:
        * kdom/cache/KDOMCachedScript.cpp:
        * kdom/cache/KDOMCachedStyleSheet.cpp:
        * kdom/cache/KDOMLoader.cpp:
        * kdom/core/AttrImpl.cpp:
        * kdom/core/CDATASectionImpl.cpp:
        * kdom/core/CDFInterface.cpp:
        * kdom/core/CharacterDataImpl.cpp:
        * kdom/core/CommentImpl.cpp:
        * kdom/core/DOMConfigurationImpl.cpp:
        * kdom/core/DOMErrorHandlerImpl.cpp:
        * kdom/core/DOMErrorImpl.cpp:
        * kdom/core/DOMExceptionImpl.cpp:
        * kdom/core/DOMImplementationImpl.cpp:
        * kdom/core/DOMLocatorImpl.cpp:
        * kdom/core/DOMObjectImpl.cpp:
        * kdom/core/DOMStringImpl.cpp:
        * kdom/core/DOMStringListImpl.cpp:
        * kdom/core/DOMUserDataImpl.cpp:
        * kdom/core/DocumentFragmentImpl.cpp:
        * kdom/core/DocumentImpl.cpp:
        * kdom/core/DocumentTypeImpl.cpp:
        * kdom/core/ElementImpl.cpp:
        * kdom/core/EntityImpl.cpp:
        * kdom/core/EntityReferenceImpl.cpp:
        * kdom/core/NamedAttrMapImpl.cpp:
        * kdom/core/NamedNodeMapImpl.cpp:
        * kdom/core/NodeImpl.cpp:
        * kdom/core/NodeListImpl.cpp:
        * kdom/core/NotationImpl.cpp:
        * kdom/core/ProcessingInstructionImpl.cpp:
        * kdom/core/TagNodeListImpl.cpp:
        * kdom/core/TextImpl.cpp:
        * kdom/core/TypeInfoImpl.cpp:
        * kdom/core/XMLElementImpl.cpp:
        * kdom/css/CSSCharsetRuleImpl.cpp:
        * kdom/css/CSSFontFaceRuleImpl.cpp:
        * kdom/css/CSSImageValueImpl.cpp:
        * kdom/css/CSSImportRuleImpl.cpp:
        * kdom/css/CSSMediaRuleImpl.cpp:
        * kdom/css/CSSPageRuleImpl.cpp:
        * kdom/css/CSSPrimitiveValueImpl.cpp:
        * kdom/css/CSSRuleImpl.cpp:
        * kdom/css/CSSRuleListImpl.cpp:
        * kdom/css/CSSStyleDeclarationImpl.cpp:
        * kdom/css/CSSStyleRuleImpl.cpp:
        * kdom/css/CSSStyleSelector.cpp:
        * kdom/css/CSSStyleSheetImpl.cpp:
        * kdom/css/CSSUnknownRuleImpl.cpp:
        * kdom/css/CSSValueImpl.cpp:
        * kdom/css/CSSValueListImpl.cpp:
        * kdom/css/CounterImpl.cpp:
        * kdom/css/DocumentCSSImpl.cpp:
        * kdom/css/DocumentStyleImpl.cpp:
        * kdom/css/KDOMCSSParser.cpp:
        * kdom/css/LinkStyleImpl.cpp:
        * kdom/css/MediaListImpl.cpp:
        * kdom/css/RGBColorImpl.cpp:
        * kdom/css/RectImpl.cpp:
        * kdom/css/RenderStyle.cpp:
        * kdom/css/RenderStyleDefs.cpp:
        * kdom/css/StyleBaseImpl.cpp:
        * kdom/css/StyleSheetImpl.cpp:
        * kdom/css/StyleSheetListImpl.cpp:
        * kdom/css/kdomparsercss.y:
        * kdom/ecma/Ecma.cpp:
        * kdom/ecma/GlobalObject.cpp:
        * kdom/ecma/Helper.cpp:
        * kdom/ecma/ScriptInterpreter.cpp:
        * kdom/events/DocumentEventImpl.cpp:
        * kdom/events/EventExceptionImpl.cpp:
        * kdom/events/EventImpl.cpp:
        * kdom/events/EventListenerImpl.cpp:
        * kdom/events/EventTargetImpl.cpp:
        * kdom/events/KeyboardEventImpl.cpp:
        * kdom/events/MouseEventImpl.cpp:
        * kdom/events/MutationEventImpl.cpp:
        * kdom/events/RegisteredEventListener.cpp:
        * kdom/events/UIEventImpl.cpp:
        * kdom/ls/DOMImplementationLSImpl.cpp:
        * kdom/ls/LSExceptionImpl.cpp:
        * kdom/ls/LSInputImpl.cpp:
        * kdom/ls/LSOutputImpl.cpp:
        * kdom/ls/LSParserFilterImpl.cpp:
        * kdom/ls/LSParserImpl.cpp:
        * kdom/ls/LSResourceResolverImpl.cpp:
        * kdom/ls/LSSerializerFilterImpl.cpp:
        * kdom/ls/LSSerializerImpl.cpp:
        * kdom/parser/KDOMDocumentBuilder.cpp:
        * kdom/parser/KDOMParser.cpp:
        * kdom/range/DocumentRangeImpl.cpp:
        * kdom/range/RangeExceptionImpl.cpp:
        * kdom/range/RangeImpl.cpp:
        * kdom/traversal/DocumentTraversalImpl.cpp:
        * kdom/traversal/NodeFilterImpl.cpp:
        * kdom/traversal/NodeIteratorImpl.cpp:
        * kdom/traversal/TraversalImpl.cpp:
        * kdom/traversal/TreeWalkerImpl.cpp:
        * kdom/views/AbstractViewImpl.cpp:
        * kdom/views/DocumentViewImpl.cpp:
        * kdom/xpath/XPathEvaluatorImpl.cpp:
        * kdom/xpath/XPathExceptionImpl.cpp:
        * kdom/xpath/XPathExpressionImpl.cpp:
        * kdom/xpath/XPathNSResolverImpl.cpp:
        * kdom/xpath/XPathNamespaceImpl.cpp:
        * kdom/xpath/XPathResultImpl.cpp:
        * kdom/xpath/impl/expression.cpp:
        * kdom/xpath/impl/functions.cpp:
        * kdom/xpath/impl/parsedstatement.cpp:
        * kdom/xpath/impl/path.cpp:
        * kdom/xpath/impl/predicate.cpp:
        * kdom/xpath/impl/step.cpp:
        * kdom/xpath/impl/tokenizer.cpp:
        * kdom/xpath/impl/util.cpp:
        * kdom/xpath/impl/variablereference.cpp:
        * kdom/xpath/impl/xpath.y:
        * kdom/xpointer/ElementSchemeImpl.cpp:
        * kdom/xpointer/NBCImpl.cpp:
        * kdom/xpointer/PointerPartImpl.cpp:
        * kdom/xpointer/ShortHandImpl.cpp:
        * kdom/xpointer/XMLNSSchemeImpl.cpp:
        * kdom/xpointer/XPath1SchemeImpl.cpp:
        * kdom/xpointer/XPointerEvaluatorImpl.cpp:
        * kdom/xpointer/XPointerExceptionImpl.cpp:
        * kdom/xpointer/XPointerExpressionImpl.cpp:
        * kdom/xpointer/XPointerHelper.cpp:
        * kdom/xpointer/XPointerResultImpl.cpp:
        * kdom/xpointer/XPointerSchemeImpl.cpp:
        * ksvg2/KSVGFactory.cpp:
        * ksvg2/KSVGSettings.cpp:
        * ksvg2/KWQKSVGPart.mm:
        * ksvg2/KWQKSVGView.mm:
        * ksvg2/css/KSVGCSSParser.cpp:
        * ksvg2/css/SVGCSSStyleDeclarationImpl.cpp:
        * ksvg2/css/SVGCSSStyleSelector.cpp:
        * ksvg2/css/SVGCSSStyleSheetImpl.cpp:
        * ksvg2/css/SVGRenderStyle.cpp:
        * ksvg2/css/SVGRenderStyleDefs.cpp:
        * ksvg2/ecma/Ecma.cpp:
        * ksvg2/ecma/GlobalObject.cpp:
        * ksvg2/events/SVGEventImpl.cpp:
        * ksvg2/events/SVGZoomEventImpl.cpp:
        * ksvg2/misc/KCanvasRenderingStyle.cpp:
        * ksvg2/misc/KSVGDocumentBuilder.cpp:
        * ksvg2/misc/KSVGTimeScheduler.cpp:
        * ksvg2/svg/CDFInterface.cpp:
        * ksvg2/svg/SVGAElementImpl.cpp:
        * ksvg2/svg/SVGAngleImpl.cpp:
        * ksvg2/svg/SVGAnimateColorElementImpl.cpp:
        * ksvg2/svg/SVGAnimateElementImpl.cpp:
        * ksvg2/svg/SVGAnimateTransformElementImpl.cpp:
        * ksvg2/svg/SVGAnimatedAngleImpl.cpp:
        * ksvg2/svg/SVGAnimatedBooleanImpl.cpp:
        * ksvg2/svg/SVGAnimatedEnumerationImpl.cpp:
        * ksvg2/svg/SVGAnimatedIntegerImpl.cpp:
        * ksvg2/svg/SVGAnimatedLengthImpl.cpp:
        * ksvg2/svg/SVGAnimatedLengthListImpl.cpp:
        * ksvg2/svg/SVGAnimatedNumberImpl.cpp:
        * ksvg2/svg/SVGAnimatedNumberListImpl.cpp:
        * ksvg2/svg/SVGAnimatedPathDataImpl.cpp:
        * ksvg2/svg/SVGAnimatedPointsImpl.cpp:
        * ksvg2/svg/SVGAnimatedPreserveAspectRatioImpl.cpp:
        * ksvg2/svg/SVGAnimatedRectImpl.cpp:
        * ksvg2/svg/SVGAnimatedStringImpl.cpp:
        * ksvg2/svg/SVGAnimatedTransformListImpl.cpp:
        * ksvg2/svg/SVGAnimationElementImpl.cpp:
        * ksvg2/svg/SVGCircleElementImpl.cpp:
        * ksvg2/svg/SVGClipPathElementImpl.cpp:
        * ksvg2/svg/SVGColorImpl.cpp:
        * ksvg2/svg/SVGComponentTransferFunctionElementImpl.cpp:
        * ksvg2/svg/SVGCursorElementImpl.cpp:
        * ksvg2/svg/SVGDOMImplementationImpl.cpp:
        * ksvg2/svg/SVGDefsElementImpl.cpp:
        * ksvg2/svg/SVGDescElementImpl.cpp:
        * ksvg2/svg/SVGDocumentImpl.cpp:
        * ksvg2/svg/SVGElementImpl.cpp:
        * ksvg2/svg/SVGElementInstanceImpl.cpp:
        * ksvg2/svg/SVGElementInstanceListImpl.cpp:
        * ksvg2/svg/SVGEllipseElementImpl.cpp:
        * ksvg2/svg/SVGExceptionImpl.cpp:
        * ksvg2/svg/SVGExternalResourcesRequiredImpl.cpp:
        * ksvg2/svg/SVGFEBlendElementImpl.cpp:
        * ksvg2/svg/SVGFEColorMatrixElementImpl.cpp:
        * ksvg2/svg/SVGFEComponentTransferElementImpl.cpp:
        * ksvg2/svg/SVGFECompositeElementImpl.cpp:
        * ksvg2/svg/SVGFEFloodElementImpl.cpp:
        * ksvg2/svg/SVGFEFuncAElementImpl.cpp:
        * ksvg2/svg/SVGFEFuncBElementImpl.cpp:
        * ksvg2/svg/SVGFEFuncGElementImpl.cpp:
        * ksvg2/svg/SVGFEFuncRElementImpl.cpp:
        * ksvg2/svg/SVGFEGaussianBlurElementImpl.cpp:
        * ksvg2/svg/SVGFEImageElementImpl.cpp:
        * ksvg2/svg/SVGFEMergeElementImpl.cpp:
        * ksvg2/svg/SVGFEMergeNodeElementImpl.cpp:
        * ksvg2/svg/SVGFEOffsetElementImpl.cpp:
        * ksvg2/svg/SVGFETileElementImpl.cpp:
        * ksvg2/svg/SVGFETurbulenceElementImpl.cpp:
        * ksvg2/svg/SVGFilterElementImpl.cpp:
        * ksvg2/svg/SVGFilterPrimitiveStandardAttributesImpl.cpp:
        * ksvg2/svg/SVGFitToViewBoxImpl.cpp:
        * ksvg2/svg/SVGGElementImpl.cpp:
        * ksvg2/svg/SVGGradientElementImpl.cpp:
        * ksvg2/svg/SVGHelper.cpp:
        * ksvg2/svg/SVGImageElementImpl.cpp:
        * ksvg2/svg/SVGLangSpaceImpl.cpp:
        * ksvg2/svg/SVGLengthImpl.cpp:
        * ksvg2/svg/SVGLengthListImpl.cpp:
        * ksvg2/svg/SVGLineElementImpl.cpp:
        * ksvg2/svg/SVGLinearGradientElementImpl.cpp:
        * ksvg2/svg/SVGLocatableImpl.cpp:
        * ksvg2/svg/SVGMarkerElementImpl.cpp:
        * ksvg2/svg/SVGMatrixImpl.cpp:
        * ksvg2/svg/SVGNumberImpl.cpp:
        * ksvg2/svg/SVGNumberListImpl.cpp:
        * ksvg2/svg/SVGPaintImpl.cpp:
        * ksvg2/svg/SVGPathElementImpl.cpp:
        * ksvg2/svg/SVGPathSegArcImpl.cpp:
        * ksvg2/svg/SVGPathSegClosePathImpl.cpp:
        * ksvg2/svg/SVGPathSegCurvetoCubicImpl.cpp:
        * ksvg2/svg/SVGPathSegCurvetoCubicSmoothImpl.cpp:
        * ksvg2/svg/SVGPathSegCurvetoQuadraticImpl.cpp:
        * ksvg2/svg/SVGPathSegCurvetoQuadraticSmoothImpl.cpp:
        * ksvg2/svg/SVGPathSegImpl.cpp:
        * ksvg2/svg/SVGPathSegLinetoHorizontalImpl.cpp:
        * ksvg2/svg/SVGPathSegLinetoImpl.cpp:
        * ksvg2/svg/SVGPathSegLinetoVerticalImpl.cpp:
        * ksvg2/svg/SVGPathSegListImpl.cpp:
        * ksvg2/svg/SVGPathSegMovetoImpl.cpp:
        * ksvg2/svg/SVGPatternElementImpl.cpp:
        * ksvg2/svg/SVGPointImpl.cpp:
        * ksvg2/svg/SVGPointListImpl.cpp:
        * ksvg2/svg/SVGPolyElementImpl.cpp:
        * ksvg2/svg/SVGPolygonElementImpl.cpp:
        * ksvg2/svg/SVGPolylineElementImpl.cpp:
        * ksvg2/svg/SVGPreserveAspectRatioImpl.cpp:
        * ksvg2/svg/SVGRadialGradientElementImpl.cpp:
        * ksvg2/svg/SVGRectElementImpl.cpp:
        * ksvg2/svg/SVGRectImpl.cpp:
        * ksvg2/svg/SVGSVGElementImpl.cpp:
        * ksvg2/svg/SVGScriptElementImpl.cpp:
        * ksvg2/svg/SVGSetElementImpl.cpp:
        * ksvg2/svg/SVGStopElementImpl.cpp:
        * ksvg2/svg/SVGStringListImpl.cpp:
        * ksvg2/svg/SVGStylableImpl.cpp:
        * ksvg2/svg/SVGStyleElementImpl.cpp:
        * ksvg2/svg/SVGStyledElementImpl.cpp:
        * ksvg2/svg/SVGSwitchElementImpl.cpp:
        * ksvg2/svg/SVGSymbolElementImpl.cpp:
        * ksvg2/svg/SVGTSpanElementImpl.cpp:
        * ksvg2/svg/SVGTestsImpl.cpp:
        * ksvg2/svg/SVGTextContentElementImpl.cpp:
        * ksvg2/svg/SVGTextElementImpl.cpp:
        * ksvg2/svg/SVGTextPositioningElementImpl.cpp:
        * ksvg2/svg/SVGTitleElementImpl.cpp:
        * ksvg2/svg/SVGTransformImpl.cpp:
        * ksvg2/svg/SVGTransformListImpl.cpp:
        * ksvg2/svg/SVGTransformableImpl.cpp:
        * ksvg2/svg/SVGURIReferenceImpl.cpp:
        * ksvg2/svg/SVGUseElementImpl.cpp:
        * ksvg2/svg/SVGViewElementImpl.cpp:
        * ksvg2/svg/SVGZoomAndPanImpl.cpp:
        * ksvg2/svg/svgpathparser.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago - updated
mjs [Wed, 5 Oct 2005 04:16:25 +0000 (04:16 +0000)]
    - updated

        * WebKitSystemInterface.h:
        * libWebKitSystemInterface.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago*** empty log message ***
bdakin [Tue, 4 Oct 2005 20:24:00 +0000 (20:24 +0000)]
*** empty log message ***

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoBug #: none
eseidel [Tue, 4 Oct 2005 09:33:33 +0000 (09:33 +0000)]
Bug #: none
Submitted by: eseidel
Reviewed by: mjs
        Code cleanup, which resulted in a small win on iBench.

        * kjs/object.cpp:
        (KJS::tryGetAndCallProperty): new static inline
        (KJS::ObjectImp::defaultValue): code cleanup

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoBug #: 4233558
eseidel [Tue, 4 Oct 2005 06:14:37 +0000 (06:14 +0000)]
Bug #: 4233558
Submitted by: eseidel
Reviewed by: mjs
        Test case for event.view.toString()
        <rdar://problem/4233558> toString on event.view Object fails with "No Default Value" in console

        * fast/events/event-view-toString-expected.txt: Added.
        * fast/events/event-view-toString.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoBug #: none
eseidel [Tue, 4 Oct 2005 06:13:35 +0000 (06:13 +0000)]
Bug #: none
Submitted by: eseidel
Reviewed by: mjs
        Make mouseDown and mouseUp force layout before acting.
        This is used by a new test case for 4233558.

        * DumpRenderTree/DumpRenderTree.m:
        (-[EventSendingController mouseDown]): force layout
        (-[EventSendingController mouseUp]): force layout

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoBug #: 4233538
eseidel [Tue, 4 Oct 2005 06:11:36 +0000 (06:11 +0000)]
Bug #: 4233538
Submitted by: eseidel
Reviewed by: mjs
        Fixed AbstractView toString(), by giving it a prototype.
        <rdar://problem/4233558> toString on event.view Object fails with "No Default Value" in console

        * khtml/ecma/kjs_views.cpp:
        (KJS::DOMAbstractView::DOMAbstractView): sets prototype
        (KJS::DOMAbstractView::getOwnPropertySlot): now getStaticValue
        (KJS::DOMAbstractViewProtoFunc::callAsFunction): renamed
        * khtml/ecma/kjs_views.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Patch from George Staikos <staikos@kde.org>, reviewed and tweaked a bit by me.
mjs [Tue, 4 Oct 2005 05:57:13 +0000 (05:57 +0000)]
    Patch from George Staikos <staikos@kde.org>, reviewed and tweaked a bit by me.

- more Linux build fixes

        * kjs/operations.cpp:
        * kxmlcore/FastMalloc.h:
        * kxmlcore/TCSystemAlloc.cpp:
        (TCMalloc_SystemAlloc):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Fix regression caused by variable->auto change. Accidentally removed a line of...
hyatt [Tue, 4 Oct 2005 05:42:35 +0000 (05:42 +0000)]
Fix regression caused by variable->auto change.  Accidentally removed a line of code from calcWidthUsing.

        Reviewed by mjs

        * khtml/rendering/render_box.cpp:
        (RenderBox::calcWidthUsing):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Darin.
mjs [Tue, 4 Oct 2005 04:08:04 +0000 (04:08 +0000)]
    Reviewed by Darin.

Test cases for:

http://bugzilla.opendarwin.org/show_bug.cgi?id=5180
event.stopPropagation() prevents the default action - it shouldn't

        * fast/events/stopPropagation-checkbox-expected.txt: Added.
        * fast/events/stopPropagation-checkbox.html: Added.
        * fast/events/stopPropagation-submit-expected.txt: Added.
        * fast/events/stopPropagation-submit.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by darin
justing [Tue, 4 Oct 2005 01:59:55 +0000 (01:59 +0000)]
    Reviewed by darin

        <rdar://problem/4060947> Safari crashes trying to save PDF file as web archive (NULL KHTMLPart)

        * kwq/WebCoreBridge.mm:
        (+[WebCoreBridge bridgeForDOMDocument:]):
        Added a check for a null part.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Patch from George Staikos <staikos@kde.org>, reviewed and tweaked a bit by me.
mjs [Tue, 4 Oct 2005 01:43:58 +0000 (01:43 +0000)]
    Patch from George Staikos <staikos@kde.org>, reviewed and tweaked a bit by me.

http://bugzilla.opendarwin.org/show_bug.cgi?id=5174
Add support for compiling on Linux (likely to help for other POSIX systems too)

        * kjs/collector.cpp:
        (KJS::Collector::markCurrentThreadConservatively):
        (KJS::Collector::markOtherThreadConservatively):
        * kjs/config.h:
        * kjs/date_object.cpp:
        (KJS::formatDate):
        (KJS::formatDateUTCVariant):
        (KJS::formatTime):
        (KJS::timeZoneOffset):
        (KJS::DateProtoFuncImp::callAsFunction):
        (KJS::DateObjectImp::construct):
        (KJS::DateObjectImp::callAsFunction):
        (KJS::makeTime):
        * kjs/identifier.cpp:
        * kjs/internal.cpp:
        (KJS::initializeInterpreterLock):
        (KJS::lockInterpreter):
        (KJS::unlockInterpreter):
        (KJS::UndefinedImp::toPrimitive):
        (KJS::UndefinedImp::toBoolean):
        (KJS::UndefinedImp::toNumber):
        (KJS::UndefinedImp::toString):
        (KJS::NullImp::toPrimitive):
        (KJS::NullImp::toBoolean):
        (KJS::NullImp::toNumber):
        (KJS::NullImp::toString):
        (KJS::BooleanImp::toPrimitive):
        (KJS::BooleanImp::toBoolean):
        (KJS::BooleanImp::toNumber):
        (KJS::BooleanImp::toString):
        (KJS::StringImp::toPrimitive):
        (KJS::StringImp::toBoolean):
        (KJS::StringImp::toNumber):
        (KJS::StringImp::toString):
        * kjs/internal.h:
        * kjs/protected_values.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by John Sullivan, Maciej Stachowiak.
tomernic [Tue, 4 Oct 2005 01:31:52 +0000 (01:31 +0000)]
    Reviewed by John Sullivan, Maciej Stachowiak.

<rdar://problem/4281095> Denver regression: Seed: Safari HTML 4.01 <object ...> tag problem

        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge determineObjectFromMIMEType:URL:]):
If no view class is registered to handle the MIME type, check to see if there is a plugin registered which can handle it.
This check is required because the Java plugin does not register an NSView class, so that Java files are downloaded when
not embedded.

Prior to this fix, -determineObjectFromMIMEType:URL: would always return ObjectElementNone for Java applets (MIME type
"application/x-java-applet"), which would cause Java applets embedded in <OBJECT> elements to not be loaded.

This broke on 05-03-2005, when we changed how we handle fallback content for <OBJECT> elements so that we could pass the
Acid2 test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agodarin tweaked my previous commit
justing [Mon, 3 Oct 2005 23:12:30 +0000 (23:12 +0000)]
darin tweaked my previous commit

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by geoff, darin
justing [Mon, 3 Oct 2005 23:11:13 +0000 (23:11 +0000)]
    Reviewed by geoff, darin

        * khtml/khtml_part.cpp:
        (KHTMLPart::handleFallbackContent):
        Don't handle fallback content for <embed> tags.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago - add missing config.h
mjs [Mon, 3 Oct 2005 23:00:43 +0000 (23:00 +0000)]
    - add missing config.h

        * khtml/config.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago - fix Development build after last checkin
mjs [Mon, 3 Oct 2005 22:42:28 +0000 (22:42 +0000)]
    - fix Development build after last checkin

        * kxmlcore/FastMalloc.cpp:
        (KXMLCore::fastMallocRegisterThread):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Darin.
mjs [Mon, 3 Oct 2005 21:34:48 +0000 (21:34 +0000)]
    Reviewed by Darin.

http://bugzilla.opendarwin.org/show_bug.cgi?id=5180
event.stopPropagation() prevents the default action - it shouldn't

Amusingly this bug existed in 3 different places.

        * khtml/ecma/kjs_events.cpp:
        (KJS::DOMEventProtoFunc::callAsFunction): Don't let stopPropagation fall through
to preventDefault.
        * khtml/html/html_formimpl.cpp:
        (DOM::HTMLInputElementImpl::postDispatchEventHandler): Only consider preventDefault
for purposes of reverting checkbox/radiobutton state change, not stopPropagation.
        * khtml/xml/dom_nodeimpl.cpp:
        (DOM::NodeImpl::dispatchGenericEvent): Don't let stopPropagation prevent calling
default event handlers; only preventDefault does that.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoJavaScriptCore:
mjs [Mon, 3 Oct 2005 21:13:12 +0000 (21:13 +0000)]
JavaScriptCore:

        Reviewed by Darin.

<rdar://problem/4283967> REGRESSION: 3% regression on PLT from new FastMalloc
http://bugzilla.opendarwin.org/show_bug.cgi?id=5243

A number of optimizations to the new threadsafe malloc that make it actually as fast
as dlmalloc (I measured wrong before) and as memory-efficient as the system malloc.

- use fastMalloc for everything - it now gets applied to all new/delete allocations
via a private inline operator new that is now included into every file via config.h.

- tweaked some of the numeric parameters for size classes and amount of wasted memory
allowed per allocation - this saves on memory use and consequently improves speed.

- so long as the allocator is not being used on background threads, get the per-thread
cache from a global variable instead of from pthread_getspecific, since the latter is slow.

- inline more functions, and force the ones GCC refuses to inline with
attribute(always_inline), nearly all of these have one call site so inlining them has
to be a win.

- use some tricks to calculate allocation size more efficiently and fewer times for small
allocations, to avoid hitting the huge size table array.

- avoid hitting the per-thread cache on code paths that don't need it.

- implement inline assembly version of spinlock for PowerPC (was already done for x86)

        * bindings/NP_jsobject.cpp:
        * bindings/c/c_class.cpp:
        * bindings/c/c_instance.cpp:
        * bindings/c/c_runtime.cpp:
        * bindings/c/c_utility.cpp:
        * bindings/jni/jni_class.cpp:
        * bindings/jni/jni_instance.cpp:
        * bindings/jni/jni_jsobject.cpp:
        * bindings/jni/jni_objc.mm:
        * bindings/jni/jni_runtime.cpp:
        * bindings/jni/jni_utility.cpp:
        * bindings/npruntime.cpp:
        * bindings/objc/WebScriptObject.mm:
        * bindings/objc/objc_class.mm:
        * bindings/objc/objc_instance.mm:
        * bindings/objc/objc_runtime.mm:
        * bindings/objc/objc_utility.mm:
        * bindings/runtime.cpp:
        * bindings/runtime_array.cpp:
        * bindings/runtime_method.cpp:
        * bindings/runtime_object.cpp:
        * bindings/runtime_root.cpp:
        * bindings/testbindings.cpp:
        * bindings/testbindings.mm:
        * kjs/array_object.cpp:
        (ArrayInstanceImp::ArrayInstanceImp):
        (ArrayInstanceImp::~ArrayInstanceImp):
        (ArrayInstanceImp::resizeStorage):
        * kjs/bool_object.cpp:
        * kjs/collector.cpp:
        (KJS::Collector::registerThread):
        * kjs/config.h:
        * kjs/debugger.cpp:
        * kjs/error_object.cpp:
        * kjs/function.cpp:
        * kjs/function_object.cpp:
        * kjs/identifier.cpp:
        (KJS::Identifier::rehash):
        * kjs/internal.cpp:
        (KJS::Parser::saveNewNode):
        (KJS::clearNewNodes):
        * kjs/interpreter.cpp:
        * kjs/lexer.cpp:
        (Lexer::doneParsing):
        (Lexer::makeIdentifier):
        (Lexer::makeUString):
        * kjs/list.cpp:
        * kjs/math_object.cpp:
        * kjs/nodes.cpp:
        * kjs/nodes.h:
        * kjs/nodes2string.cpp:
        * kjs/number_object.cpp:
        (integer_part_noexp):
        (char_sequence):
        * kjs/object.cpp:
        * kjs/object_object.cpp:
        * kjs/property_map.cpp:
        * kjs/property_slot.cpp:
        * kjs/protected_values.cpp:
        (KJS::ProtectedValues::rehash):
        * kjs/reference.cpp:
        * kjs/reference_list.cpp:
        * kjs/regexp.cpp:
        * kjs/regexp_object.cpp:
        * kjs/scope_chain.cpp:
        * kjs/scope_chain.h:
        * kjs/string_object.cpp:
        * kjs/testkjs.cpp:
        * kjs/ustring.h:
        * kjs/value.cpp:
        * kxmlcore/Assertions.mm:
        * kxmlcore/FastMalloc.cpp:
        (KXMLCore::InitSizeClasses):
        (KXMLCore::DLL_IsEmpty):
        (KXMLCore::DLL_Prepend):
        (KXMLCore::TCMalloc_Central_FreeList::Insert):
        (KXMLCore::TCMalloc_Central_FreeList::Remove):
        (KXMLCore::TCMalloc_Central_FreeList::Populate):
        (KXMLCore::TCMalloc_ThreadCache::Allocate):
        (KXMLCore::TCMalloc_ThreadCache::FetchFromCentralCache):
        (KXMLCore::fastMallocRegisterThread):
        (KXMLCore::TCMalloc_ThreadCache::GetCache):
        (KXMLCore::TCMalloc_ThreadCache::GetCacheIfPresent):
        (KXMLCore::TCMalloc_ThreadCache::CreateCacheIfNecessary):
        (KXMLCore::do_malloc):
        (KXMLCore::do_free):
        (KXMLCore::realloc):
        * kxmlcore/FastMalloc.h:
        (operator new):
        (operator delete):
        (operator new[]):
        (operator delete[]):
        * kxmlcore/HashTable.cpp:
        * kxmlcore/TCSpinLock.h:
        (TCMalloc_SpinLock::Lock):
        (TCMalloc_SpinLock::Unlock):
        (TCMalloc_SlowLock):
        * kxmlcore/TCSystemAlloc.cpp:

WebCore:

        Reviewed by Darin.

<rdar://problem/4283967> REGRESSION: 3% regression on PLT from new FastMalloc
http://bugzilla.opendarwin.org/show_bug.cgi?id=5243

- use fastMalloc for everything - it now gets applied to all new/delete allocations
        via a private inline operator new that is now included into every file via config.h

        * WebCore.xcodeproj/project.pbxproj:
        * WebCorePrefix.h:
        * khtml/css/css_base.cpp:
        * khtml/css/css_base.h:
        * khtml/css/css_computedstyle.cpp:
        * khtml/css/css_ruleimpl.cpp:
        * khtml/css/css_stylesheetimpl.cpp:
        * khtml/css/css_valueimpl.cpp:
        * khtml/css/css_valueimpl.h:
        * khtml/css/csshelper.cpp:
        * khtml/css/cssparser.cpp:
        (ValueList::ValueList):
        (ValueList::~ValueList):
        (ValueList::addValue):
        (CSSParser::CSSParser):
        (CSSParser::~CSSParser):
        (CSSParser::setupParser):
        (CSSParser::addProperty):
        * khtml/css/cssstyleselector.cpp:
        * khtml/css/cssstyleselector.h:
        * khtml/dom/dom2_events.cpp:
        * khtml/dom/dom2_traversal.cpp:
        * khtml/dom/dom_misc.cpp:
        * khtml/dom/dom_string.cpp:
        * khtml/ecma/domparser.cpp:
        * khtml/ecma/kjs_binding.cpp:
        * khtml/ecma/kjs_css.cpp:
        * khtml/ecma/kjs_dom.cpp:
        * khtml/ecma/kjs_events.cpp:
        * khtml/ecma/kjs_html.cpp:
        (KJS::KJS::Context2DFunction::callAsFunction):
        (KJS::Gradient::~Gradient):
        (KJS::Gradient::addColorStop):
        (KJS::Gradient::colorStops):
        * khtml/ecma/kjs_navigator.cpp:
        * khtml/ecma/kjs_proxy.cpp:
        * khtml/ecma/kjs_range.cpp:
        * khtml/ecma/kjs_traversal.cpp:
        * khtml/ecma/kjs_views.cpp:
        * khtml/ecma/kjs_window.cpp:
        * khtml/ecma/xmlhttprequest.cpp:
        * khtml/ecma/xmlserializer.cpp:
        * khtml/editing/SelectionController.cpp:
        * khtml/editing/append_node_command.cpp:
        * khtml/editing/apply_style_command.cpp:
        * khtml/editing/break_blockquote_command.cpp:
        * khtml/editing/composite_edit_command.cpp:
        * khtml/editing/delete_from_text_node_command.cpp:
        * khtml/editing/delete_selection_command.cpp:
        * khtml/editing/edit_command.cpp:
        * khtml/editing/html_interchange.cpp:
        * khtml/editing/htmlediting.cpp:
        * khtml/editing/insert_into_text_node_command.cpp:
        * khtml/editing/insert_line_break_command.cpp:
        * khtml/editing/insert_node_before_command.cpp:
        * khtml/editing/insert_paragraph_separator_command.cpp:
        * khtml/editing/insert_text_command.cpp:
        * khtml/editing/join_text_nodes_command.cpp:
        * khtml/editing/jsediting.cpp:
        * khtml/editing/markup.cpp:
        * khtml/editing/merge_identical_elements_command.cpp:
        * khtml/editing/move_selection_command.cpp:
        * khtml/editing/rebalance_whitespace_command.cpp:
        * khtml/editing/remove_css_property_command.cpp:
        * khtml/editing/remove_node_attribute_command.cpp:
        * khtml/editing/remove_node_command.cpp:
        * khtml/editing/remove_node_preserving_children_command.cpp:
        * khtml/editing/replace_selection_command.cpp:
        * khtml/editing/set_node_attribute_command.cpp:
        * khtml/editing/split_element_command.cpp:
        * khtml/editing/split_text_node_command.cpp:
        * khtml/editing/split_text_node_containing_element.cpp:
        * khtml/editing/typing_command.cpp:
        * khtml/editing/visible_position.cpp:
        * khtml/editing/visible_range.cpp:
        * khtml/editing/visible_text.cpp:
        (khtml::CircularSearchBuffer::~CircularSearchBuffer):
        (khtml::CircularSearchBuffer::CircularSearchBuffer):
        * khtml/editing/visible_units.cpp:
        * khtml/editing/wrap_contents_in_dummy_span_command.cpp:
        * khtml/html/html_baseimpl.cpp:
        * khtml/html/html_blockimpl.cpp:
        * khtml/html/html_canvasimpl.cpp:
        * khtml/html/html_documentimpl.cpp:
        * khtml/html/html_elementimpl.cpp:
        * khtml/html/html_formimpl.cpp:
        * khtml/html/html_headimpl.cpp:
        * khtml/html/html_imageimpl.cpp:
        * khtml/html/html_inlineimpl.cpp:
        * khtml/html/html_listimpl.cpp:
        * khtml/html/html_miscimpl.cpp:
        * khtml/html/html_objectimpl.cpp:
        * khtml/html/html_tableimpl.cpp:
        * khtml/html/htmlfactory.cpp:
        * khtml/html/htmlnames.cpp:
        * khtml/html/htmlparser.cpp:
        * khtml/html/htmltokenizer.cpp:
        (khtml::HTMLTokenizer::enlargeBuffer):
        (khtml::HTMLTokenizer::enlargeScriptBuffer):
        * khtml/khtml_events.cpp:
        * khtml/khtml_part.cpp:
        * khtml/khtmlview.cpp:
        * khtml/misc/arena.cpp:
        * khtml/misc/arena.h:
        * khtml/misc/decoder.cpp:
        * khtml/misc/formdata.cpp:
        * khtml/misc/helper.cpp:
        * khtml/misc/loader.cpp:
        * khtml/misc/stringit.cpp:
        * khtml/rendering/bidi.cpp:
        * khtml/rendering/break_lines.cpp:
        * khtml/rendering/font.cpp:
        * khtml/rendering/render_arena.cpp:
        * khtml/rendering/render_block.cpp:
        * khtml/rendering/render_box.cpp:
        * khtml/rendering/render_br.cpp:
        * khtml/rendering/render_canvas.cpp:
        * khtml/rendering/render_canvasimage.cpp:
        (RenderCanvasImage::~RenderCanvasImage):
        (RenderCanvasImage::createDrawingContext):
        * khtml/rendering/render_container.cpp:
        * khtml/rendering/render_flexbox.cpp:
        * khtml/rendering/render_flow.cpp:
        * khtml/rendering/render_form.cpp:
        * khtml/rendering/render_frames.cpp:
        * khtml/rendering/render_image.cpp:
        * khtml/rendering/render_inline.cpp:
        * khtml/rendering/render_layer.cpp:
        * khtml/rendering/render_line.cpp:
        * khtml/rendering/render_list.cpp:
        * khtml/rendering/render_object.cpp:
        * khtml/rendering/render_replaced.cpp:
        * khtml/rendering/render_style.cpp:
        * khtml/rendering/render_style.h:
        * khtml/rendering/render_table.cpp:
        * khtml/rendering/render_text.cpp:
        * khtml/rendering/render_theme.cpp:
        * khtml/rendering/render_theme_mac.mm:
        * khtml/rendering/table_layout.cpp:
        * khtml/xbl/xbl_binding.cpp:
        * khtml/xbl/xbl_binding_manager.cpp:
        * khtml/xbl/xbl_docimpl.cpp:
        * khtml/xbl/xbl_protobinding.cpp:
        * khtml/xbl/xbl_protohandler.cpp:
        * khtml/xbl/xbl_protoimplementation.cpp:
        * khtml/xbl/xbl_tokenizer.cpp:
        * khtml/xml/EventNames.cpp:
        * khtml/xml/dom2_eventsimpl.cpp:
        * khtml/xml/dom2_eventsimpl.h:
        * khtml/xml/dom2_rangeimpl.cpp:
        * khtml/xml/dom2_rangeimpl.h:
        * khtml/xml/dom2_traversalimpl.cpp:
        * khtml/xml/dom2_traversalimpl.h:
        * khtml/xml/dom2_viewsimpl.cpp:
        * khtml/xml/dom2_viewsimpl.h:
        * khtml/xml/dom_atomicstring.cpp:
        * khtml/xml/dom_docimpl.cpp:
        * khtml/xml/dom_docimpl.h:
        * khtml/xml/dom_elementimpl.cpp:
        * khtml/xml/dom_elementimpl.h:
        * khtml/xml/dom_nodeimpl.cpp:
        * khtml/xml/dom_nodeimpl.h:
        * khtml/xml/dom_position.cpp:
        * khtml/xml/dom_qname.cpp:
        * khtml/xml/dom_stringimpl.cpp:
        * khtml/xml/dom_stringimpl.h:
        * khtml/xml/dom_textimpl.cpp:
        * khtml/xml/dom_xmlimpl.cpp:
        * khtml/xml/xml_tokenizer.cpp:
        * khtml/xsl/xsl_stylesheetimpl.cpp:
        * khtml/xsl/xslt_processorimpl.cpp:
        * kwq/DOM-CSS.mm:
        * kwq/DOM.mm:
        * kwq/DOMEvents.mm:
        * kwq/DOMHTML.mm:
        * kwq/DOMInternal.mm:
        (DOMString::DOMString):
        * kwq/DOMUtility.mm:
        * kwq/DOMViews.mm:
        * kwq/KWQAccObject.mm:
        * kwq/KWQAccObjectCache.mm:
        * kwq/KWQApplication.mm:
        * kwq/KWQArrayImpl.h:
        * kwq/KWQArrayImpl.mm:
        * kwq/KWQBuffer.mm:
        * kwq/KWQButton.mm:
        * kwq/KWQCString.mm:
        * kwq/KWQCharsets.mm:
        * kwq/KWQClipboard.mm:
        * kwq/KWQCollection.mm:
        * kwq/KWQColor.mm:
        * kwq/KWQComboBox.mm:
        * kwq/KWQCursor.mm:
        * kwq/KWQDateTime.mm:
        * kwq/KWQDictImpl.mm:
        * kwq/KWQEditCommand.mm:
        * kwq/KWQEvent.mm:
        * kwq/KWQExceptions.mm:
        * kwq/KWQFile.mm:
        * kwq/KWQFileButton.mm:
        * kwq/KWQFont.mm:
        * kwq/KWQFontFamily.h:
        * kwq/KWQFontFamily.mm:
        * kwq/KWQFontMetrics.mm:
        * kwq/KWQFormData.mm:
        * kwq/KWQFrame.mm:
        * kwq/KWQGlobal.mm:
        * kwq/KWQGuardedPtr.mm:
        * kwq/KWQKCharsets.mm:
        * kwq/KWQKConfigBase.mm:
        * kwq/KWQKCookieJar.mm:
        * kwq/KWQKCursor.mm:
        * kwq/KWQKGlobal.mm:
        * kwq/KWQKGlobalSettings.mm:
        * kwq/KWQKHTMLFactory.mm:
        * kwq/KWQKHTMLPart.cpp:
        * kwq/KWQKHTMLPart.mm:
        * kwq/KWQKHTMLPartBrowserExtension.mm:
        * kwq/KWQKHTMLView.mm:
        * kwq/KWQKHistoryProvider.mm:
        * kwq/KWQKJavaAppletWidget.mm:
        * kwq/KWQKJob.mm:
        * kwq/KWQKJobClasses.mm:
        * kwq/KWQKLocale.mm:
        * kwq/KWQKPartsBrowserInterface.mm:
        * kwq/KWQKPartsEvent.mm:
        * kwq/KWQKPartsPart.mm:
        * kwq/KWQKSSLKeyGen.mm:
        * kwq/KWQKStandardDirs.mm:
        * kwq/KWQKStringHandler.mm:
        * kwq/KWQKURL.mm:
        (KURL::KURL):
        (KURL::decode_string):
        (KURL::parse):
        (KURL::encode_string):
        (encodeRelativeString):
        * kwq/KWQKWin.mm:
        * kwq/KWQKWinModule.mm:
        * kwq/KWQLabel.mm:
        * kwq/KWQLineEdit.mm:
        * kwq/KWQListBox.mm:
        * kwq/KWQListImpl.mm:
        * kwq/KWQLoader.mm:
        (KWQIsResponseURLEqualToURL):
        * kwq/KWQMapImpl.h:
        * kwq/KWQMapImpl.mm:
        * kwq/KWQMovie.mm:
        * kwq/KWQObject.mm:
        * kwq/KWQPageState.mm:
        * kwq/KWQPaintDeviceMetrics.mm:
        * kwq/KWQPainter.mm:
        * kwq/KWQPalette.mm:
        * kwq/KWQPen.mm:
        * kwq/KWQPixmap.mm:
        * kwq/KWQPoint.mm:
        * kwq/KWQPointArray.mm:
        * kwq/KWQPtrDictImpl.mm:
        * kwq/KWQPushButton.mm:
        * kwq/KWQRect.mm:
        * kwq/KWQRegExp.mm:
        * kwq/KWQRegion.mm:
        * kwq/KWQRenderTreeDebug.cpp:
        * kwq/KWQResourceLoader.mm:
        * kwq/KWQScrollBar.mm:
        * kwq/KWQScrollView.mm:
        * kwq/KWQSignal.mm:
        * kwq/KWQSignalStubs.mm:
        * kwq/KWQSize.mm:
        * kwq/KWQSlider.mm:
        * kwq/KWQSlot.mm:
        * kwq/KWQString.h:
        * kwq/KWQString.mm:
        (ALLOC_CHAR):
        (REALLOC_CHAR):
        (DELETE_CHAR):
        (ALLOC_QCHAR):
        (REALLOC_QCHAR):
        (DELETE_QCHAR):
        (_printQStringAllocationStatistics):
        (allocateHandle):
        (KWQStringData::operator new):
        (KWQStringData::operator delete):
        (freeHandle):
        * kwq/KWQStringList.mm:
        * kwq/KWQStyle.mm:
        * kwq/KWQTextArea.mm:
        * kwq/KWQTextCodec.mm:
        * kwq/KWQTextEdit.mm:
        * kwq/KWQTextField.mm:
        * kwq/KWQTextStream.mm:
        * kwq/KWQTextUtilities.mm:
        * kwq/KWQTimer.mm:
        * kwq/KWQValueListImpl.h:
        * kwq/KWQValueListImpl.mm:
        * kwq/KWQVariant.mm:
        * kwq/KWQVectorImpl.mm:
        (KWQVectorImpl::KWQVectorImpl):
        (KWQVectorImpl::~KWQVectorImpl):
        (KWQVectorImpl::clear):
        (KWQVectorImpl::resize):
        (KWQVectorImpl::assign):
        * kwq/KWQWMatrix.mm:
        * kwq/KWQWidget.mm:
        * kwq/KWQWindowWidget.mm:
        * kwq/WebCoreBridge.mm:
        * kwq/WebCoreCache.mm:
        * kwq/WebCoreEncodings.mm:
        * kwq/WebCoreJavaScript.mm:
        * kwq/WebCoreScriptDebugger.mm:
        * kwq/WebCoreSettings.mm:
        * kwq/WebCoreTextRendererFactory.mm:
        * kwq/can-convert.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago*** empty log message ***
bdakin [Mon, 3 Oct 2005 20:55:04 +0000 (20:55 +0000)]
*** empty log message ***

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoBug #: 5239
eseidel [Mon, 3 Oct 2005 08:55:24 +0000 (08:55 +0000)]
Bug #: 5239
Submitted by: Rob Buis  <rwlbuis@xs4all.nl>
Reviewed by: eseidel
        Fixes hang, caused by path parser spinning forever.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=5239

        * ksvg2/svg/svgpathparser.cpp:
        (SVGPathParser::parseSVG):
        * svg-tests/custom/path-bad-data-expected.checksum: Added.
        * svg-tests/custom/path-bad-data-expected.png: Added.
        * svg-tests/custom/path-bad-data-expected.txt: Added.
        * svg-tests/custom/path-bad-data.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoBug #: 5209
eseidel [Mon, 3 Oct 2005 06:21:41 +0000 (06:21 +0000)]
Bug #: 5209
Submitted by: eseidel
Reviewed by: darin
       Closes large memory leak in KSVG.
       http://bugzilla.opendarwin.org/show_bug.cgi?id=5209

       * ksvg2/svg/SVGStyledElementImpl.cpp:
        (SVGStyledElementImpl::attach): delete orphans unless PatternImpl

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoBug #: 5132
eseidel [Mon, 3 Oct 2005 06:15:08 +0000 (06:15 +0000)]
Bug #: 5132
Submitted by: eseidel
Reviewed by: mjs
        Fixes SVG animation support in Safari/WebKit.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=5132

        * WebCore+SVG/dom_kdomnodetreewrapper.cpp:
        (KDOMNodeTreeWrapperImpl::attach): setup kcanvasviewquartz
        (KDOMNodeTreeWrapperImpl::detach): tear down kcanvasviewquartz
        * WebCore+SVG/dom_kdomnodetreewrapper.h:
        * kcanvas/device/quartz/KCanvasViewQuartz.h:
        * kcanvas/device/quartz/KCanvasViewQuartz.mm: fix spaces
        (KCanvasViewQuartz::KCanvasViewQuartz):
        (KCanvasViewQuartz::~KCanvasViewQuartz):
        (KCanvasViewQuartz::view):
        (KCanvasViewQuartz::setView):
        (KCanvasViewQuartz::renderObject): alternative to view
        (KCanvasViewQuartz::setRenderObject):
        (KCanvasViewQuartz::invalidateCanvasRect):
        (KCanvasViewQuartz::viewToCanvasMatrix):
        (KCanvasViewQuartz::canvasSizeChanged):
        (KCanvasViewQuartz::viewHeight):
        (KCanvasViewQuartz::viewWidth):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoBug #: 5219
eseidel [Mon, 3 Oct 2005 06:08:54 +0000 (06:08 +0000)]
Bug #: 5219
Submitted by: Alexey Proskuryakov  <ap@nypop.com>
Reviewed by: eseidel
        http://bugzilla.opendarwin.org/show_bug.cgi?id=5219

        * fast/xsl/xslt-url-expected.txt: Added.
        * fast/xsl/xslt-url.xml: Added.
        * fast/xsl/xslt-url.xsl: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoBug #: 5219
eseidel [Mon, 3 Oct 2005 06:02:35 +0000 (06:02 +0000)]
Bug #: 5219
Submitted by: Alexey Proskuryakov  <ap@nypop.com>
Reviewed by: eseidel
        Fix XSLT to preserve document.URL.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=5219

        * khtml/xsl/xslt_processorimpl.cpp:
        (DOM::XSLTProcessorImpl::documentFromXMLDocPtr):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoBug #: 5238
eseidel [Mon, 3 Oct 2005 05:21:57 +0000 (05:21 +0000)]
Bug #: 5238
Submitted by: eseidel
Reviewed by: mjs
        Fix crash when encountering XML processing directives w/ KDOM:
        http://bugzilla.opendarwin.org/show_bug.cgi?id=5238

        * ksvg2/svg/SVGDocumentImpl.cpp:
        (SVGDocumentImpl::recalcStyleSelector): null check.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10693 268f45cc-cd09-0410-ab3c-d52691b4dbfc