WebKit-https.git
11 years ago2011-05-19 Evan Martin <evan@chromium.org>
evan@chromium.org [Fri, 20 May 2011 17:20:53 +0000 (17:20 +0000)]
2011-05-19  Evan Martin  <evan@chromium.org>

        Reviewed by Tony Chang.

        [chromium] remove <(library) variable
        https://bugs.webkit.org/show_bug.cgi?id=61158

        This was for a build experiment; we can just use the correct value now.

        * JavaScriptCore.gyp/JavaScriptCore.gyp:
2011-05-19  Evan Martin  <evan@chromium.org>

        Reviewed by Tony Chang.

        [chromium] remove <(library) variable
        https://bugs.webkit.org/show_bug.cgi?id=61158

        This was for a build experiment; we can just use the correct value now.

        * glu/glu.gyp:
        * gyp/test/library/src/library.gyp:
2011-05-19  Evan Martin  <evan@chromium.org>

        Reviewed by Tony Chang.

        [chromium] remove <(library) variable
        https://bugs.webkit.org/show_bug.cgi?id=61158

        This was for a build experiment; we can just use the correct value now.

        * WebCore.gyp/WebCore.gyp:
2011-05-19  Evan Martin  <evan@chromium.org>

        Reviewed by Tony Chang.

        [chromium] remove <(library) variable
        https://bugs.webkit.org/show_bug.cgi?id=61158

        This was for a build experiment; we can just use the correct value now.

        * WebKit.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-20 Andrew Scherkus <scherkus@chromium.org>
scherkus@chromium.org [Fri, 20 May 2011 16:36:40 +0000 (16:36 +0000)]
2011-05-20  Andrew Scherkus  <scherkus@chromium.org>

        Unreviewed, updating media/event-attributes.html as passing for Chromium.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-20 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Fri, 20 May 2011 16:25:31 +0000 (16:25 +0000)]
2011-05-20  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: breakpoints disappear from ui after navigation.
        https://bugs.webkit.org/show_bug.cgi?id=61133

        * inspector/front-end/DebuggerPresentationModel.js:
        (WebInspector.DebuggerPresentationModel.prototype._debuggerWasEnabled):
        (WebInspector.DebuggerPresentationModel.prototype._saveBreakpoints):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Windows] fast/dom/HTMLFormElement/associated-elements-after-index-assertion-fail1...
tkent@chromium.org [Fri, 20 May 2011 16:20:24 +0000 (16:20 +0000)]
[Windows] fast/dom/HTMLFormElement/associated-elements-after-index-assertion-fail1.html failing since r86936
https://bugs.webkit.org/show_bug.cgi?id=61190

* platform/win/Skipped: Skip it because the test uses <progress> and
  Windows doesn't have <progress> support.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-20 Sheriff Bot <webkit.review.bot@gmail.com>
podivilov@chromium.org [Fri, 20 May 2011 16:20:13 +0000 (16:20 +0000)]
2011-05-20  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r86958.
        http://trac.webkit.org/changeset/86958
        https://bugs.webkit.org/show_bug.cgi?id=61195

        broke breakpoints persisting (Requested by podivilov on
        #webkit).

        * inspector/front-end/DebuggerPresentationModel.js:
        (WebInspector.DebuggerPresentationModel.prototype._debuggerWasEnabled):
        (WebInspector.DebuggerPresentationModel.prototype._saveBreakpoints):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-20 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Fri, 20 May 2011 16:19:38 +0000 (16:19 +0000)]
2011-05-20  Oliver Hunt  <oliver@apple.com>

        Reviewed by Sam Weinig.

        Interpreter uses wrong bytecode offset for determining exception handler
        https://bugs.webkit.org/show_bug.cgi?id=61191

        The bytecode offset given for the returnPC from the JIT is
        actually the offset for the start of the instruction triggering
        the call, whereas in the interpreter it is the actual return
        VPC.  This means if the next instruction following a call was
        in an exception region we would incorrectly redirect to its
        handler.  Long term we want to completely redo how exceptions
        are handled anyway so the simplest and lowest risk fix here is
        to simply subtract one from the return vPC so that we have an
        offset in the triggering instruction.

        It turns out this is caught by a couple of tests already.

        * interpreter/Interpreter.cpp:
        (JSC::Interpreter::unwindCallFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-19 Sergey Vorobyev <sergeyvorobyev@google.com>
yurys@chromium.org [Fri, 20 May 2011 16:15:08 +0000 (16:15 +0000)]
2011-05-19  Sergey Vorobyev  <sergeyvorobyev@google.com>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Background network events collection - add GUI to Inspector.
        https://bugs.webkit.org/show_bug.cgi?id=58652

        Move reopenFrontend() to inspector-test.js
        Add first test for background events collection.

        * http/tests/inspector/inspector-test.js:
        ():
        * http/tests/inspector/network-test.js: Added.
        (initialize_NetworkTest.InspectorTest.enableBackgroundEventCollection):
        (initialize_NetworkTest.InspectorTest.disableBackgroundEventCollection):
        * http/tests/inspector/network/network-clear-after-disabled-expected.txt: Added.
        * http/tests/inspector/network/network-clear-after-disabled.html: Added.
        * http/tests/inspector/network/network-close-load-open-expected.txt: Added.
        * http/tests/inspector/network/network-close-load-open.html: Added.
        * http/tests/inspector/network/network-open-load-reopen-expected.txt: Added.
        * http/tests/inspector/network/network-open-load-reopen.html: Added.
        * inspector/debugger/open-close-open-expected.txt:
        * inspector/debugger/open-close-open.html:
        * platform/qt/Skipped:
2011-05-19  Sergey Vorobyev  <sergeyvorobyev@google.com>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Background network events collection - add GUI to Inspector.
        https://bugs.webkit.org/show_bug.cgi?id=58652

        Now in WebInspector Network panel avalaible new checkbox item in context menu:
        "Background events collection". It allows to save all network events when inspector
        frontend closed. Events that occur before collection enabling are not preserved after
        frontend reopening. Property unique for each page. Disabled by default.

        Tests: http/tests/inspector/network/network-clear-after-disabled.html
               http/tests/inspector/network/network-close-load-open.html
               http/tests/inspector/network/network-open-load-reopen.html

        * inspector/EventsCollector.cpp:
        (WebCore::EventsCollector::clear):
        * inspector/EventsCollector.h:
        * inspector/Inspector.json:
        * inspector/InspectorFrontendProxy.cpp:
        (WebCore::InspectorFrontendProxy::inspectorFrontendChannel):
        * inspector/InspectorFrontendProxy.h:
        * inspector/InspectorResourceAgent.cpp:
        (WebCore::InspectorResourceAgent::setFrontend):
        (WebCore::InspectorResourceAgent::clearFrontend):
        (WebCore::InspectorResourceAgent::isBackgroundEventsCollectionEnabled):
        (WebCore::InspectorResourceAgent::setBackgroundEventsCollectionEnabled):
        (WebCore::InspectorResourceAgent::initializeBackgroundCollection):
        (WebCore::InspectorResourceAgent::InspectorResourceAgent):
        * inspector/InspectorResourceAgent.h:
        * inspector/front-end/NetworkPanel.js:
        (WebInspector.NetworkPanel):
        (WebInspector.NetworkPanel.prototype._contextMenu):
        (WebInspector.NetworkPanel.prototype._toggleBackgroundEventsCollection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-20 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Fri, 20 May 2011 16:11:42 +0000 (16:11 +0000)]
2011-05-20  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: breakpoints disappear from ui after navigation.
        https://bugs.webkit.org/show_bug.cgi?id=61133

        * inspector/front-end/DebuggerPresentationModel.js:
        (WebInspector.DebuggerPresentationModel.prototype._debuggerWasEnabled):
        (WebInspector.DebuggerPresentationModel.prototype._saveBreakpoints):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-20 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Fri, 20 May 2011 15:55:16 +0000 (15:55 +0000)]
2011-05-20  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Oliver Hunt.

        JIT requires VM overcommit (particularly on x86-64), Linux does not by default support this without swap?
        https://bugs.webkit.org/show_bug.cgi?id=42756

        Use the MAP_NORESERVE flag for mmap on Linux to skip the kernel
        check of the available memory. This should give us an
        overcommit-like behavior in most systems, which is what we want.

        * wtf/OSAllocatorPosix.cpp:
        (WTF::OSAllocator::reserveAndCommit): pass MAP_NORSERVE to mmap.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-20 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Fri, 20 May 2011 15:50:55 +0000 (15:50 +0000)]
2011-05-20  Jer Noble  <jer.noble@apple.com>

        Reviewed by Maciej Stachowiak.

        Win: non-full-screen content is briefly seen when entering full-screen mode (and vice versa)
        https://bugs.webkit.org/show_bug.cgi?id=61108

        Instead of repainting the full- and non-full-screen windows in WebCore, delegate that
        responsibility to the FullScreenControllerClient.  Because the repaint operation may
        be asynchronous, add a new method for clients to use to indicate repainting has completed.

        * platform/graphics/win/FullScreenController.cpp:
        (FullScreenController::Private::Private): Added new ivars.
        (FullScreenController::enterFullScreen): Split into two functions (pre-and post repaint)
        (FullScreenController::enterFullScreenRepaintCompleted): Ditto.
        (FullScreenController::exitFullScreen): Ditto.
        (FullScreenController::exitFullScreenRepaintCompleted): Ditto.
        (FullScreenController::repaintCompleted): Call the appropriated repaint completed function.
        * platform/graphics/win/FullScreenController.h:
        * platform/graphics/win/FullScreenControllerClient.h:
2011-05-20  Jer Noble  <jer.noble@apple.com>

        Reviewed by Maciej Stachowiak.

        Win: non-full-screen content is briefly seen when entering full-screen mode (and vice versa)
        https://bugs.webkit.org/show_bug.cgi?id=61108

        * WebView.cpp:
        (WebView::fullScreenClientForceRepaint): Repaint the view and immediately notify the
            full screen controller.
        * WebView.h:
2011-05-20  Jer Noble  <jer.noble@apple.com>

        Reviewed by Maciej Stachowiak.

        Win: non-full-screen content is briefly seen when entering full-screen mode (and vice versa)
        https://bugs.webkit.org/show_bug.cgi?id=61108

        When the fullScreenController asks us to repaint, make an async repaint request, and when the
        callback is fired, notify the fullScreenController that repaint has completed.

        * UIProcess/win/WebView.cpp:
        (WebKit::fullScreenClientForceRepaintCompleted): Added.
        (WebKit::WebView::fullScreenClientForceRepaint): Added.
        * UIProcess/win/WebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-20 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Fri, 20 May 2011 15:18:40 +0000 (15:18 +0000)]
2011-05-20  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: use RefPtr instead of OwnPtr to store InspectorBackendDispatcher
        https://bugs.webkit.org/show_bug.cgi?id=61188

        * inspector/WorkerInspectorController.cpp:
        (WebCore::WorkerInspectorController::connectFrontend):
        (WebCore::WorkerInspectorController::disconnectFrontend):
        * inspector/WorkerInspectorController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Skip failing tests.
ossy@webkit.org [Fri, 20 May 2011 15:04:32 +0000 (15:04 +0000)]
[Qt] Skip failing tests.

* platform/qt-arm/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-20 Csaba Osztrogonác <ossy@webkit.org>
ossy@webkit.org [Fri, 20 May 2011 14:29:17 +0000 (14:29 +0000)]
2011-05-20  Csaba Osztrogonác  <ossy@webkit.org>

        Reviewed by Benjamin Poulain.

        [Qt] tst_QWebElement::style() fails because QWebElement::InlineStyle doesn't work as expected
        https://bugs.webkit.org/show_bug.cgi?id=60372

        * tests/qwebelement/tst_qwebelement.cpp: Mark failing test case as expected fail.
        (tst_QWebElement::style):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-20 Csaba Osztrogonác <ossy@webkit.org>
ossy@webkit.org [Fri, 20 May 2011 14:27:43 +0000 (14:27 +0000)]
2011-05-20  Csaba Osztrogonác  <ossy@webkit.org>

        Reviewed by Benjamin Poulain.

        [Qt] Fix tst_QDeclarativeWebView::basicProperties() and historyNav() autotests
        https://bugs.webkit.org/show_bug.cgi?id=61042

        * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp: Mark failing test cases as expected fails.
        (tst_QDeclarativeWebView::basicProperties):
        (tst_QDeclarativeWebView::historyNav):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Fix tst_QWebPage::testOptionalJSObjects() autotest
ossy@webkit.org [Fri, 20 May 2011 14:19:21 +0000 (14:19 +0000)]
[Qt] Fix tst_QWebPage::testOptionalJSObjects() autotest
https://bugs.webkit.org/show_bug.cgi?id=61045

Reviewed by Benjamin Poulain.

* tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::testOptionalJSObjects): Mark failing test cases as expected fails.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-20 Tonis Tiigi <tonistiigi@gmail.com>
commit-queue@webkit.org [Fri, 20 May 2011 14:03:05 +0000 (14:03 +0000)]
2011-05-20  Tonis Tiigi  <tonistiigi@gmail.com>

        Reviewed by Pavel Feldman.

        Web Inspector: Network panel should only show pointer cursor over valid resources
        https://bugs.webkit.org/show_bug.cgi?id=55240

        Cursor style removed from filler area.

        * inspector/front-end/networkPanel.css:
        (.network-sidebar .data-grid tr:not(.filler) td.name-column):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-20 Peter Varga <pvarga@webkit.org>
pvarga@webkit.org [Fri, 20 May 2011 13:57:48 +0000 (13:57 +0000)]
2011-05-20  Peter Varga  <pvarga@webkit.org>

        Reviewed by Simon Hausmann.

        [Qt][V8] Use qtscript-staging's shipped version of V8 when building with --v8
        https://bugs.webkit.org/show_bug.cgi?id=56649

        Use the provided V8 and functionality of
        http://qt.gitorious.org/+qt-developers/qt/qtscript-staging to build QtWebKit+V8.
        Based on the original patch of Andras Becsi <abecsi@webkit.org>.

        No new tests needed.

        * CodeGenerators.pri: Add generating of DebuggerScriptSource.h
        * WebCore.pri: Fix the options for V8 build.
        * WebCore.pro: Ditto.
        * bindings/v8/NPV8Object.cpp:
        (WebCore::npObjectTypeInfo): Add missing initializer.
        * bindings/v8/ScriptController.cpp:
        (WebCore::ScriptController::disableEval): Temporarily disable
        unsupported feature on Qt.
        * bindings/v8/ScriptControllerQt.cpp:
        (WebCore::ScriptController::qtScriptEngine): use the QtScriptEngine
        constructor of qtscript-staging.
        * bindings/v8/custom/V8HTMLAudioElementConstructor.cpp: Add missing
        initializer.
        * bindings/v8/custom/V8HTMLImageElementConstructor.cpp: Ditto.
        * bindings/v8/custom/V8HTMLOptionElementConstructor.cpp: Ditto.
        * loader/appcache/ApplicationCacheGroup.cpp: Add missing header.
        * loader/cache/CachedResourceRequest.cpp: Ditto.
        * page/PageSerializer.cpp: Ditto.
        * page/qt/FrameQt.cpp: Ditto.
        * storage/StorageEventDispatcher.cpp: Ditto.
2011-05-20  Peter Varga  <pvarga@webkit.org>

        Reviewed by Simon Hausmann.

        [Qt][V8] Use qtscript-staging's shipped version of V8 when building with --v8
        https://bugs.webkit.org/show_bug.cgi?id=56649

        Use the provided V8 and functionality of
        http://qt.gitorious.org/+qt-developers/qt/qtscript-staging to build QtWebKit+V8.
        Based on the original patch of Andras Becsi <abecsi@webkit.org>.

        * Api/qwebframe.cpp:
        (QWebFrame::addToJavaScriptWindowObject): Fix QString deprecated
        warning.
        * QtWebKit.pro: Adding the V8 library should happen in the final build
        step.
        * WebCoreSupport/ChromeClientQt.cpp: Add missing head.
        * WebCoreSupport/DumpRenderTreeSupportQt.cpp: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-20 Tonis Tiigi <tonistiigi@gmail.com>
commit-queue@webkit.org [Fri, 20 May 2011 13:49:54 +0000 (13:49 +0000)]
2011-05-20  Tonis Tiigi  <tonistiigi@gmail.com>

        Reviewed by Pavel Feldman.

        Web Inspector: console.log(XMLDocument) should be case preserving
        https://bugs.webkit.org/show_bug.cgi?id=60765

        Changes the XML document checking from base documents MIME type
        to xmlVersion parameter.

        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::buildObjectForNode):
        * inspector/front-end/DOMAgent.js:
        (WebInspector.DOMNode):
        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeOutline.prototype.set rootDOMNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-20 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Fri, 20 May 2011 13:46:03 +0000 (13:46 +0000)]
2011-05-20  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: [Chromium] Use bottom-up CPU profile tree built in VM,
        instead of building it on Inspector's side.
        https://bugs.webkit.org/show_bug.cgi?id=61185

        * bindings/js/ScriptProfile.cpp:
        (WebCore::ScriptProfile::bottomUpHead):
        (WebCore::ScriptProfile::buildInspectorObjectForBottomUpHead):
        * bindings/js/ScriptProfile.h:
        * bindings/v8/ScriptProfile.cpp:
        (WebCore::ScriptProfile::bottomUpHead):
        (WebCore::ScriptProfile::buildInspectorObjectForBottomUpHead):
        * bindings/v8/ScriptProfile.h:
        * inspector/InspectorProfilerAgent.cpp:
        (WebCore::InspectorProfilerAgent::getProfile):
        * inspector/front-end/ProfileView.js:
        (WebInspector.CPUProfileView.prototype.get bottomUpProfileDataGridTree):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-20 Csaba Osztrogonác <ossy@webkit.org>
ossy@webkit.org [Fri, 20 May 2011 13:32:03 +0000 (13:32 +0000)]
2011-05-20  Csaba Osztrogonác  <ossy@webkit.org>

        Reviewed by Benjamin Poulain.

        [Qt]Fix tst_QWebFrame::setUrlToInvalid() autotest after r84762
        https://bugs.webkit.org/show_bug.cgi?id=59345

        * tests/qwebframe/tst_qwebframe.cpp:
        (tst_QWebFrame::setUrlToInvalid): Mark failing test cases as expected fails.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoDon't try to process DownloadProxy messages twice (and robustify code that runs if...
aroben@apple.com [Fri, 20 May 2011 13:24:29 +0000 (13:24 +0000)]
Don't try to process DownloadProxy messages twice (and robustify code that runs if we do)

Fixes <http://webkit.org/b/61142> <rdar://problem/9471680> REGRESSION (r86812): Crash
(preceded by assertion) in fastMalloc when downloading a file

Reviewed by Darin Adler.

Source/WebKit2:

* Platform/CoreIPC/ArgumentDecoder.cpp:
(CoreIPC::alignedBufferIsLargeEnoughToContain): Added. This helper function checks that the
given buffer is large enough to hold |size| bytes (and correctly handles the case where
we're already at the end or beyond the end of the buffer).

(CoreIPC::ArgumentDecoder::alignBufferPosition):
(CoreIPC::ArgumentDecoder::bufferIsLargeEnoughToContain):
Replaced old code that was vulnerable to underflow with the new helper function.

* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didReceiveSyncMessage): Added back an early return that was
mistakenly removed in r86812 so that we don't mistakenly pass DownloadProxy messages on to
a WebPageProxy after we've already handled them.

Tools:

Test that the WebKit2 UI process doesn't crash when starting a download

* TestWebKitAPI/Tests/WebKit2/18-characters.html: Added.

* TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp: Added.
(TestWebKitAPI::decidePolicyForNavigationAction): Start a download.
(TestWebKitAPI::decideDestinationWithSuggestedFilename): Record that the download was
started, cancel the download, and return a bogus string.

(TestWebKitAPI::setContextDownloadClient):
(TestWebKitAPI::setPagePolicyClient):
Simple helper functions.

(TestWebKitAPI::TEST): Load 18-characters.html, which should trigger a download thanks to
our policy client, and run until we know that the download was started. If we haven't
crashed, we win!

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/win/TestWebKitAPI.vcproj:
* TestWebKitAPI/win/copy-resources.cmd:
Added new files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoMac build fix after r86936
aroben@apple.com [Fri, 20 May 2011 12:52:51 +0000 (12:52 +0000)]
Mac build fix after r86936

* WebCore.xcodeproj/project.pbxproj: Added preprocessor.pm like the
other .pm files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-20 Vitaly Repeshko <vitalyr@chromium.org>
vitalyr@chromium.org [Fri, 20 May 2011 12:44:50 +0000 (12:44 +0000)]
2011-05-20  Vitaly Repeshko  <vitalyr@chromium.org>

        Unreviewed.

        [chromium] Updating chromium DEPS.

        * DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt][Mac] Skip one more plugins test after r86938.
ossy@webkit.org [Fri, 20 May 2011 12:43:02 +0000 (12:43 +0000)]
[Qt][Mac] Skip one more plugins test after r86938.

* platform/qt-mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-20 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Fri, 20 May 2011 12:26:47 +0000 (12:26 +0000)]
2011-05-20  Kent Tamura  <tkent@chromium.org>

        Try to fix Windows CE build.
        Touch html.css to kick UA style sheet generation.

        * css/html.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-20 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Fri, 20 May 2011 12:18:44 +0000 (12:18 +0000)]
2011-05-20  Kent Tamura  <tkent@chromium.org>

        Try to fix Windows CE build.

        * CMakeLists.txt: Add --preprocessor flag.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-20 Robert Hogan <robert@webkit.org>
robert@webkit.org [Fri, 20 May 2011 11:45:22 +0000 (11:45 +0000)]
2011-05-20  Robert Hogan  <robert@webkit.org>

        Rubber-stamped by Csaba Osztrogonác.

        [Qt-mac] Skip two plugins test

        Unskipped in platform/qt/ so need to skip in qt-mac as the build
        does not support plugins (?)

        * platform/qt-mac/Skipped: plugins/get-url-with-javascript-url.html
                                   plugins/windowless_plugin_paint_test.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-20 Robert Hogan <robert@webkit.org>
robert@webkit.org [Fri, 20 May 2011 11:35:24 +0000 (11:35 +0000)]
2011-05-20  Robert Hogan  <robert@webkit.org>

        Rubber-stamped by Csaba Osztrogonác.

        [Qt] plugins/keyboard-events.html fails after r72717

        https://bugs.webkit.org/show_bug.cgi?id=50050

        keyboard-events.html now passes thanks to the buildbot
        upgrades. It was blocked by a bug in Xvfb on xorg-server
        1.4.2.

       * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Unreviewed. Remove unnecessary Qt specific expected files.
ossy@webkit.org [Fri, 20 May 2011 11:29:24 +0000 (11:29 +0000)]
[Qt] Unreviewed. Remove unnecessary Qt specific expected files.

* platform/qt/editing/execCommand/5062376-expected.txt: Removed.
* platform/qt/editing/execCommand/insert-list-with-id-expected.txt: Removed.
* platform/qt/editing/inserting/insert-before-link-1-expected.txt: Removed.
* platform/qt/editing/pasteboard/4840662-expected.txt: Removed.
* platform/qt/editing/pasteboard/5245519-expected.txt: Removed.
* platform/qt/editing/pasteboard/copy-in-password-field-expected.txt: Removed.
* platform/qt/editing/pasteboard/page-zoom-expected.txt: Removed.
* platform/qt/editing/undo/redo-style-expected.txt: Removed.
* platform/qt/fast/css/getComputedStyle/computed-style-expected.txt: Removed.
* platform/qt/fast/dom/frame-loading-via-document-write-expected.txt: Removed.
* platform/qt/fast/dom/wrapper-classes-expected.txt: Removed.
* platform/qt/fast/dynamic/dirty-float-in-clean-line-expected.txt: Removed.
* platform/qt/fast/dynamic/float-at-line-break-expected.txt: Removed.
* platform/qt/fast/dynamic/unicode-bidi-expected.txt: Removed.
* platform/qt/fast/encoding/preload-encoding-expected.txt: Removed.
* platform/qt/fast/lists/alpha-list-wrap-expected.txt: Removed.
* platform/qt/fast/lists/decimal-leading-zero-expected.txt: Removed.
* platform/qt/fast/lists/li-values-expected.txt: Removed.
* platform/qt/fast/lists/list-style-type-dynamic-change-expected.txt: Removed.
* platform/qt/fast/repaint/svg-layout-root-style-attr-update-expected.txt: Removed.
* platform/qt/fast/text/bidi-embedding-pop-and-push-same-2-expected.txt: Removed.
* platform/qt/fast/text/justify-nbsp-expected.txt: Removed.
* platform/qt/fast/text/setData-dirty-lines-expected.txt: Removed.
* platform/qt/fast/text/splitText-dirty-lines-expected.txt: Removed.
* platform/qt/http/tests/security/cross-frame-access-call-expected.txt: Removed.
* platform/qt/http/tests/security/cross-frame-access-get-expected.txt: Removed.
* platform/qt/plugins/document-open-expected.txt: Removed.
* platform/qt/plugins/resize-from-plugin-expected.txt: Removed.
* platform/qt/svg/custom/animation-currentColor-expected.txt: Removed.
* platform/qt/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.txt: Removed.
* platform/qt/svg/custom/text-zoom-expected.txt: Removed.
* platform/qt/svg/custom/transformedMaskFails-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-20 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Fri, 20 May 2011 10:47:56 +0000 (10:47 +0000)]
2011-05-20  Kent Tamura  <tkent@chromium.org>

        Reviewed by Hajime Morita.

        Apply feature flags to user-agent style sheets
        https://bugs.webkit.org/show_bug.cgi?id=52612

        A user-agent style sheet should not have style definitions for disabled
        features because such definitions makes feature detection harder and
        causes incorrect behavior (See Bug 52214).

        We have handled such feature-dependent style definitions by providing
        separated CSS files and selecting them in build files. Adding such style
        definition was hard because we need to update each of build files. This
        change simplifies the process to add such style definitions by applying
        preprocessor to the CSS files.

        Implementation:
        make-css-file-arrays.pl invokes a preprocessor if it has --defines
        option. Otherwise, it just remove lines beginning with #.
        In this change, we pass --defines on Mac, Windows, Chromium, GTK, and
        CMake platforms. Qt and Android have no behavior change.

        * CMakeLists.txt:
          - IDL handling depends on preprocessor.pm.
          - Pass --defines option to make-css-file-arrays.pl
          - Add WebCore/bindings/scripts to @INC for make-css-file-arrays.pl
        * CodeGenerators.pri: IDL handling depends on preprocessor.pm.
        * DerivedSources.make: ditto.
        * GNUmakefile.am: ditto.
        * WebCore.gyp/WebCore.gyp: ditto.
        * WebCore.gyp/scripts/action_useragentstylesheets.py:
          Change parameter order to support perl modules and options.
          Many code is taken from rule_bindings.py.
        * WebCore.vcproj/MigrateScripts: Handles preprocessor.pm.
        * bindings/scripts/IDLParser.pm:
          Move the preprocessor code to preprocessor.pm.
        * bindings/scripts/preprocessor.pm:
          Added. The code was moved from IDLParser.pm
        * css/html.css: Enclose some style definitions with #if-#endif.
        * css/make-css-file-arrays.pl:
          - Add --defines and --preprocessor options.
          - Invoke a preprocessor if --defines is specified.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-20 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Fri, 20 May 2011 10:16:44 +0000 (10:16 +0000)]
2011-05-20  Dirk Schulze  <krit@webkit.org>

        Rubber-stamped by Nikolas Zimmermann.

        Remove unnecessary class Path inlcude from PathTraversalState.

        * platform/graphics/PathTraversalState.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-20 Sergio Villar Senin <svillar@igalia.com>
sergio@webkit.org [Fri, 20 May 2011 09:56:35 +0000 (09:56 +0000)]
2011-05-20  Sergio Villar Senin  <svillar@igalia.com>

        Unreviewed, new GTK+ test results.

        * platform/gtk/fast/html/details-add-details-child-1-expected.png: Added.
        * platform/gtk/fast/html/details-add-details-child-1-expected.txt: Added.
        * platform/gtk/fast/html/details-nested-1-expected.png: Added.
        * platform/gtk/fast/html/details-nested-1-expected.txt: Added.
        * platform/gtk/fast/html/details-nested-2-expected.png: Added.
        * platform/gtk/fast/html/details-nested-2-expected.txt: Added.
        * platform/gtk/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.png: Added.
        * platform/gtk/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt: Added.
        * platform/gtk/svg/custom/painting-marker-07-f-inherit-expected.png: Added.
        * platform/gtk/svg/custom/painting-marker-07-f-inherit-expected.txt: Added.
        * platform/gtk/svg/custom/small-rect-scale-expected.png: Added.
        * platform/gtk/svg/custom/small-rect-scale-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-20 Sergio Villar Senin <svillar@igalia.com>
sergio@webkit.org [Fri, 20 May 2011 09:33:22 +0000 (09:33 +0000)]
2011-05-20  Sergio Villar Senin  <svillar@igalia.com>

        Unreviewed, new GTK+ test expectations after r86920.

        * platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-19 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Fri, 20 May 2011 09:32:52 +0000 (09:32 +0000)]
2011-05-19  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: ctrl+s should not switch source frame to read only mode.
        https://bugs.webkit.org/show_bug.cgi?id=61125

        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype.commitEditing.didEditContent):
        (WebInspector.SourceFrame.prototype.commitEditing):
        * inspector/front-end/inspector.js:
        (WebInspector.documentKeyDown):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-20 Piroska András <Piroska.Andras@stud.u-szeged.hu>
loki@webkit.org [Fri, 20 May 2011 08:53:05 +0000 (08:53 +0000)]
2011-05-20  Piroska András  <Piroska.Andras@stud.u-szeged.hu>

        Reviewed by Nikolas Zimmermann.

        Apply the ParallelJobs support to FEConvolveMatrix
        https://bugs.webkit.org/show_bug.cgi?id=61171

        The FEConvolveMatrix filter of SVG can consume lots of resources if it is
        applied to a large area. The computation can be distributed to multiple
        cores if the architecture supports.
        The average performance progression is 20-30% on dual-core machines.

        Developed in cooperation with Gabor Loki.

        * platform/graphics/filters/FEConvolveMatrix.cpp:
        (WebCore::FEConvolveMatrix::fastSetInteriorPixels):
        (WebCore::FEConvolveMatrix::setInteriorPixels):
        (WebCore::FEConvolveMatrix::setInteriorPixelsWorker):
        (WebCore::FEConvolveMatrix::apply):
        * platform/graphics/filters/FEConvolveMatrix.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-20 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Fri, 20 May 2011 08:48:12 +0000 (08:48 +0000)]
2011-05-20  Kent Tamura  <tkent@chromium.org>

        Reviewed by Ryosuke Niwa.

        Fix style errors in DumpRenderTree/chromium/.
        https://bugs.webkit.org/show_bug.cgi?id=61172

        * DumpRenderTree/chromium/CppBoundClass.cpp:
        (CppBoundClass::getAsCppVariant):
        (CppBoundClass::bindToJavascript):
        * DumpRenderTree/chromium/CppBoundClass.h:
        (CppBoundClass::GetterCallback::~GetterCallback):
        (CppBoundClass::CppBoundClass):
        (CppBoundClass::Callback::~Callback):
        (CppBoundClass::MemberCallback::MemberCallback):
        (CppBoundClass::MemberCallback::~MemberCallback):
        (CppBoundClass::MemberGetterCallback::MemberGetterCallback):
        (CppBoundClass::MemberGetterCallback::~MemberGetterCallback):
        * DumpRenderTree/chromium/CppVariant.h:
        * DumpRenderTree/chromium/DRTDevToolsAgent.h:
        (DRTDevToolsAgent::~DRTDevToolsAgent):
        * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
        (DRTDevToolsClient::sendFrontendLoaded):
        * DumpRenderTree/chromium/DRTDevToolsClient.h:
        * DumpRenderTree/chromium/DumpRenderTree.cpp:
        (main):
        * DumpRenderTree/chromium/EventSender.cpp:
        (SavedEvent::SavedEvent):
        (EventSender::EventSender):
        (EventSender::keyDown):
        * DumpRenderTree/chromium/EventSender.h:
        * DumpRenderTree/chromium/ImageDiff.cpp:
        (Image::Image):
        * DumpRenderTree/chromium/LayoutTestController.cpp:
        (LayoutTestController::LayoutTestController):
        (LayoutTestController::WorkQueue::reset):
        (WorkItemBackForward::WorkItemBackForward):
        (WorkItemLoadingScript::WorkItemLoadingScript):
        (WorkItemNonLoadingScript::WorkItemNonLoadingScript):
        (WorkItemLoad::WorkItemLoad):
        (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
        (LayoutTestController::pathToLocalResource):
        * DumpRenderTree/chromium/LayoutTestController.h:
        (LayoutTestController::WorkItem::~WorkItem):
        (LayoutTestController::WorkQueue::WorkQueue):
        * DumpRenderTree/chromium/MockSpellCheck.cpp:
        (MockSpellCheck::MockSpellCheck):
        (MockSpellCheck::~MockSpellCheck):
        * DumpRenderTree/chromium/MockSpellCheck.h:
        * DumpRenderTree/chromium/NotificationPresenter.h:
        (NotificationPresenter::NotificationPresenter):
        * DumpRenderTree/chromium/Task.cpp:
        (WebTask::WebTask):
        * DumpRenderTree/chromium/Task.h:
        (TaskList::TaskList):
        * DumpRenderTree/chromium/TestEventPrinter.cpp:
        (DRTPrinter::DRTPrinter):
        (TestShellPrinter::TestShellPrinter):
        * DumpRenderTree/chromium/TestNavigationController.cpp:
        (TestNavigationEntry::TestNavigationEntry):
        (TestNavigationEntry::~TestNavigationEntry):
        (TestNavigationController::TestNavigationController):
        (TestNavigationController::reload):
        (TestNavigationController::loadEntry):
        (TestNavigationController::didNavigateToEntry):
        * DumpRenderTree/chromium/TestNavigationController.h:
        (TestShellExtraData::TestShellExtraData):
        * DumpRenderTree/chromium/TestShell.cpp:
        (dumpHistoryItem):
        * DumpRenderTree/chromium/TestShell.h:
        (TestParams::TestParams):
        * DumpRenderTree/chromium/TestShellWin.cpp:
        (TestShell::waitTestFinished):
        * DumpRenderTree/chromium/TestWebWorker.h:
        (TestWebWorker::startWorkerContext):
        (TestWebWorker::terminateWorkerContext):
        (TestWebWorker::postMessageToWorkerContext):
        (TestWebWorker::clientDestroyed):
        (TestWebWorker::postMessageToWorkerObject):
        (TestWebWorker::postExceptionToWorkerObject):
        (TestWebWorker::postConsoleMessageToWorkerObject):
        (TestWebWorker::confirmMessageFromWorkerObject):
        (TestWebWorker::reportPendingActivity):
        (TestWebWorker::workerContextClosed):
        (TestWebWorker::~TestWebWorker):
        * DumpRenderTree/chromium/TextInputController.cpp:
        * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
        * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
        * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
        (WebThemeEngineDRTWin::paintButton):
        (WebThemeEngineDRTWin::paintMenuList):
        (WebThemeEngineDRTWin::paintTrackbar):
        * DumpRenderTree/chromium/WebThemeEngineDRTWin.h:
        (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
        * DumpRenderTree/chromium/WebViewHost.cpp:
        (WebViewHost::navigate):
        (WebViewHost::updateSessionHistory):
        (WebViewHost::paintInvalidatedRegion):
        * DumpRenderTree/chromium/WebViewHost.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-20 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Fri, 20 May 2011 08:14:09 +0000 (08:14 +0000)]
2011-05-20  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r86920.
        http://trac.webkit.org/changeset/86920
        https://bugs.webkit.org/show_bug.cgi?id=61173

        It cause compile error on some buildbot in chromium. e.g.
        http://build.chromium.org/p/chromium.memory/builders/Chromium%20Mac%20Builder%20%28valgrind%29/builds/12336/steps/compile/logs/stdio#error1
        (Requested by ukai_ on #webkit).

        * css3/images/optimize-contrast-canvas-expected.png: Removed.
        * css3/images/optimize-contrast-canvas-expected.txt: Removed.
        * css3/images/optimize-contrast-canvas.html: Removed.
        * css3/images/optimize-contrast-image-expected.png: Removed.
        * css3/images/optimize-contrast-image-expected.txt: Removed.
        * css3/images/optimize-contrast-image.html: Removed.
        * fast/css/getComputedStyle/computed-style-expected.txt:
        * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
        * platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
        * platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
        * svg/css/getComputedStyle-basic-expected.txt:
2011-05-20  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r86920.
        http://trac.webkit.org/changeset/86920
        https://bugs.webkit.org/show_bug.cgi?id=61173

        It cause compile error on some buildbot in chromium. e.g.
        http://build.chromium.org/p/chromium.memory/builders/Chromium%20Mac%20Builder%20%28valgrind%29/builds/12336/steps/compile/logs/stdio#error1
        (Requested by ukai_ on #webkit).

        * WebCore.xcodeproj/project.pbxproj:
        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue):
        * css/CSSPrimitiveValueMappings.h:
        (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
        (WebCore::CSSPrimitiveValue::operator EImageRendering):
        * css/CSSPropertyNames.in:
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):
        * css/CSSValueKeywords.in:
        * css/SVGCSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):
        * css/SVGCSSPropertyNames.in:
        * css/SVGCSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applySVGProperty):
        * css/SVGCSSValueKeywords.in:
        * html/HTMLCanvasElement.cpp:
        (WebCore::HTMLCanvasElement::paint):
        * html/HTMLCanvasElement.h:
        * platform/graphics/ImageRenderingMode.h: Removed.
        * rendering/RenderBoxModelObject.cpp:
        (WebCore::ImageQualityController::shouldPaintAtLowQuality):
        * rendering/RenderHTMLCanvas.cpp:
        (WebCore::RenderHTMLCanvas::paintReplaced):
        * rendering/style/RenderStyle.cpp:
        (WebCore::RenderStyle::diff):
        * rendering/style/RenderStyle.h:
        * rendering/style/RenderStyleConstants.h:
        * rendering/style/SVGRenderStyle.cpp:
        (WebCore::SVGRenderStyle::diff):
        * rendering/style/SVGRenderStyle.h:
        (WebCore::SVGRenderStyle::initialImageRendering):
        (WebCore::SVGRenderStyle::setImageRendering):
        (WebCore::SVGRenderStyle::imageRendering):
        (WebCore::SVGRenderStyle::InheritedFlags::operator==):
        (WebCore::SVGRenderStyle::setBitDefaults):
        * rendering/style/SVGRenderStyleDefs.h:
        * rendering/style/StyleRareInheritedData.cpp:
        (WebCore::StyleRareInheritedData::StyleRareInheritedData):
        (WebCore::StyleRareInheritedData::operator==):
        * rendering/style/StyleRareInheritedData.h:
        * rendering/svg/SVGRenderTreeAsText.cpp:
        (WebCore::writeStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-20 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Fri, 20 May 2011 08:01:19 +0000 (08:01 +0000)]
2011-05-20  Dirk Schulze  <krit@webkit.org>

        Reviewed by Eric Seidel.

        SVG Large curve path segment OOM crash
        https://bugs.webkit.org/show_bug.cgi?id=42079

        Limit the depth of repeatedly splitting a segment on length calculation to 20. The limitation
        is necessary for very big segments that would be splitter into millions of parts otherwise.
        The limitation just cause a less accurate approximation.
        At the moment the limit is fixed to 20. This is comparable with splitting the segment into
        ~1 million parts as a worst case. We might want to be more flexible later.

        Test: svg/custom/path-getTotalLength-on-big-segment-crash.svg

        * platform/graphics/PathTraversalState.cpp:
        (WebCore::midPoint):
        (WebCore::curveLength):
        (WebCore::PathTraversalState::PathTraversalState):
        (WebCore::PathTraversalState::moveTo):
        (WebCore::PathTraversalState::quadraticBezierTo):
        (WebCore::PathTraversalState::cubicBezierTo):
        * platform/graphics/PathTraversalState.h:
2011-05-20  Dirk Schulze  <krit@webkit.org>

        Reviewed by Eric Seidel.

        SVG Large curve path segment OOM crash
        https://bugs.webkit.org/show_bug.cgi?id=42079

        Added a test to verify, that the browser does not crash on calculating the total length on big segments.
        It makes no sense to add the result of getTotalLength(), since they differ a lot bewteen platforms.
        This is caused by the platform graphic libraries. See comment #9 on the bug.

        * svg/custom/path-getTotalLength-on-big-segment-crash-expected.txt: Added.
        * svg/custom/path-getTotalLength-on-big-segment-crash.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-20 Leo Yang <leo.yang@torchmobile.com.cn>
leo.yang@torchmobile.com.cn [Fri, 20 May 2011 07:56:57 +0000 (07:56 +0000)]
2011-05-20  Leo Yang  <leo.yang@torchmobile.com.cn>

        Reviewed by Nikolas Zimmermann.

        SVGRootInlineBox triggers calculateBoundaries twice in layout
        https://bugs.webkit.org/show_bug.cgi?id=60979

        SVGRootInlineBox was calculating boundaries for children twice
        in computePerCharacterLayoutInformation(). The first time of
        calculation was in layoutChildBoxes() which is called by
        computePerCharacterLayoutInformation(), and the second time of
        calculation was in layoutRootBox() following layoutChildBoxes().

        This patch calculates rectangle of children in layoutChildBoxes()
        and then uses the rectange in layoutRootBox() to reduce a pass
        of calculating child boundaries.

        No functionality change, no new tests.

        * rendering/svg/SVGRootInlineBox.cpp:
        (WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation):
        (WebCore::SVGRootInlineBox::layoutChildBoxes):
        (WebCore::SVGRootInlineBox::layoutRootBox):
        * rendering/svg/SVGRootInlineBox.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-19 Naoki Takano <takano.naoki@gmail.com>
commit-queue@webkit.org [Fri, 20 May 2011 06:37:01 +0000 (06:37 +0000)]
2011-05-19  Naoki Takano  <takano.naoki@gmail.com>

        Reviewed by Kent Tamura.

        Fix a problem that updating HTMLInputElement::value sets the cursor to a wrong position.
        https://bugs.webkit.org/show_bug.cgi?id=61163

        Manual test input-number-localization.html.
        Because we can't assume any number formats in various WebKit ports.

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::setValue): The cursor must be the last position of visibleValue(), not m_value.
        * manual-tests/input-number-localization.html: Added manual test to check the cursor correctly moved to the last poisition of the input.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed.
ukai@chromium.org [Fri, 20 May 2011 06:25:39 +0000 (06:25 +0000)]
Unreviewed.

Chromium expectations update.

* platform/chromium/test_expectations.txt: add BUGWK61169

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-19 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Fri, 20 May 2011 05:31:07 +0000 (05:31 +0000)]
2011-05-19  Jer Noble  <jer.noble@apple.com>

        Reviewed by Maciej Stachowiak.

        WebKit2: Flashing when entering and exiting full screen mode
        https://bugs.webkit.org/show_bug.cgi?id=56957

        Guard against the parameter of setAnimating() matching the ivar value it's
        setting, thus avoiding tearing down the renderer's layer backing.

        * rendering/RenderFullScreen.cpp:
        (RenderFullScreen::setAnimating):
2011-05-19  Jer Noble  <jer.noble@apple.com>

        Reviewed by Maciej Stachowiak.

        WebKit2: Flashing when entering and exiting full screen mode
        https://bugs.webkit.org/show_bug.cgi?id=56957

        In the WKFullscreenWindowController, when exiting accelerated compositing mode,
        force a repaint, and don't actually remove the animation layer until the repaint
        completes.  Also, move back to parenting the WebView in a layer-backed view, and
        work around the SnowLeopard bug which causes a crash in those situations.  We no
        longer need to do a bunch of work in finishedEnterFullScreenAnimation, because
        the animation layer is "hiding" all the drawing happening in the webView underneath.

        In the WebFullScreenManagerMac, when asked to tear down the root layer, instead
        remove all its children, and set its contents to a flattened image of the full
        screen element and its children.  This helps patch over the time where everything
        is re-rendering and helps give the appearance of continuousness in the animation.

        * UIProcess/mac/WKFullScreenWindowController.mm:
        (-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]):
        (-[WKFullScreenWindowController beganExitFullScreenAnimation]):
        (-[WKFullScreenWindowController enterAcceleratedCompositingMode:WebKit::]):
        (-[WKFullScreenWindowController exitAcceleratedCompositingMode]):
        (-[WKFullScreenWindowController exitCompositedModeRepaintCompleted]):
        (exitCompositedModeRepaintCompleted):
        (-[WKFullScreenWindowController _page]):
        (-[WKFullScreenWindowController _manager]):
        (-[WKFullScreenWindow initWithContentRect:styleMask:backing:defer:]):
        * WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm:
        (WebKit::WebFullScreenManagerMac::setRootFullScreenLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix ARM build after r86919
loki@webkit.org [Fri, 20 May 2011 05:27:48 +0000 (05:27 +0000)]
Fix ARM build after r86919

* assembler/ARMAssembler.h:
(JSC::ARMAssembler::nop):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-19 Dmitry Lomov <dslomov@google.com>
commit-queue@webkit.org [Fri, 20 May 2011 04:10:49 +0000 (04:10 +0000)]
2011-05-19  Dmitry Lomov  <dslomov@google.com>

        Reviewed by Adam Roben.

        Detect hangs in run-api-tests
        https://bugs.webkit.org/show_bug.cgi?id=48043

        * Scripts/run-api-tests: Added test timeouts

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-19 Julien Chaffraix <jchaffraix@codeaurora.org>
commit-queue@webkit.org [Fri, 20 May 2011 02:39:21 +0000 (02:39 +0000)]
2011-05-19  Julien Chaffraix  <jchaffraix@codeaurora.org>

        Reviewed by Adam Barth.

        Remove Node::deprecatedParserAddChild
        https://bugs.webkit.org/show_bug.cgi?id=60818

        Refactoring only so no new tests.

        This patch fails short of one instance of deprecatedParserAddChild which will
        require a refactoring of <input> shadow DOM to be removed.

        * dom/XMLDocumentParser.cpp:
        (WebCore::XMLDocumentParser::pushCurrentNode): Updated to use a ContainerNode.
        (WebCore::XMLDocumentParser::clearCurrentNodeStack): We now need to clear
        up m_leafTextNode too.

        (WebCore::XMLDocumentParser::enterText):
        (WebCore::XMLDocumentParser::exitText):
        Those methods were updated to use m_leafTextNode instead of m_currentNode.

        * dom/XMLDocumentParser.h:
        Changed the currentNode logic to use ContainerNode. Also fixed the style of the
        forward declarations.

        * dom/XMLDocumentParserLibxml2.cpp:
        (WebCore::XMLDocumentParser::startElementNs):
        (WebCore::XMLDocumentParser::endElementNs):
        (WebCore::XMLDocumentParser::characters):
        (WebCore::XMLDocumentParser::processingInstruction):
        (WebCore::XMLDocumentParser::cdataBlock):
        (WebCore::XMLDocumentParser::comment):
        * dom/XMLDocumentParserQt.cpp:
        (WebCore::XMLDocumentParser::parse):
        (WebCore::XMLDocumentParser::parseStartElement):
        (WebCore::XMLDocumentParser::parseEndElement):
        (WebCore::XMLDocumentParser::parseCharacters):
        (WebCore::XMLDocumentParser::parseProcessingInstruction):
        (WebCore::XMLDocumentParser::parseCdata):
        (WebCore::XMLDocumentParser::parseComment):
        Removed the calls to deprecatedParserAddChild, changed the code to use
        m_leafTextNode when it made sense and used ContainerNode instead of
        Node for m_currentNode.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-19 Mike Lawther <mikelawther@chromium.org>
commit-queue@webkit.org [Fri, 20 May 2011 02:01:05 +0000 (02:01 +0000)]
2011-05-19  Mike Lawther  <mikelawther@chromium.org>

        Reviewed by Simon Fraser.

        implement image-rendering: optimize-contrast (with a vendor prefix) as defined in CSS3 image values
        https://bugs.webkit.org/show_bug.cgi?id=56627

        * css3/images/optimize-contrast-canvas-expected.checksum: Added.
        * css3/images/optimize-contrast-canvas-expected.png: Added.
        * css3/images/optimize-contrast-canvas-expected.txt: Added.
        * css3/images/optimize-contrast-canvas.html: Added.
        * css3/images/optimize-contrast-image-expected.checksum: Added.
        * css3/images/optimize-contrast-image-expected.png: Added.
        * css3/images/optimize-contrast-image-expected.txt: Added.
        * css3/images/optimize-contrast-image.html: Added.
2011-05-19  Mike Lawther  <mikelawther@chromium.org>

        Reviewed by Simon Fraser.

        implement image-rendering: optimize-contrast (with a vendor prefix) as defined in CSS3 image values
        https://bugs.webkit.org/show_bug.cgi?id=56627

        Tests: css3/images/optimize-contrast-canvas.html
               css3/images/optimize-contrast-image.html

        * WebCore.xcodeproj/project.pbxproj:
        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue):
        * css/CSSPrimitiveValueMappings.h:
        (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
        (WebCore::CSSPrimitiveValue::operator EImageRendering):
        * css/CSSPropertyNames.in:
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):
        * css/CSSValueKeywords.in:
        * css/SVGCSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):
        * css/SVGCSSPropertyNames.in:
        * css/SVGCSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applySVGProperty):
        * css/SVGCSSValueKeywords.in:
        * html/HTMLCanvasElement.cpp:
        (WebCore::HTMLCanvasElement::paint):
        * html/HTMLCanvasElement.h:
        * platform/graphics/ImageRenderingMode.h: Added.
        * rendering/RenderBoxModelObject.cpp:
        (WebCore::ImageQualityController::shouldPaintAtLowQuality):
        * rendering/RenderHTMLCanvas.cpp:
        (WebCore::RenderHTMLCanvas::paintReplaced):
        * rendering/style/RenderStyle.cpp:
        (WebCore::RenderStyle::diff):
        * rendering/style/RenderStyle.h:
        (WebCore::InheritedFlags::imageRendering):
        (WebCore::InheritedFlags::setImageRendering):
        (WebCore::InheritedFlags::initialImageRendering):
        * rendering/style/RenderStyleConstants.h:
        * rendering/style/SVGRenderStyle.cpp:
        (WebCore::SVGRenderStyle::diff):
        * rendering/style/SVGRenderStyle.h:
        (WebCore::SVGRenderStyle::InheritedFlags::operator==):
        (WebCore::SVGRenderStyle::setBitDefaults):
        * rendering/style/SVGRenderStyleDefs.h:
        * rendering/svg/SVGRenderTreeAsText.cpp:
        (WebCore::writeStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-19 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Fri, 20 May 2011 01:33:46 +0000 (01:33 +0000)]
2011-05-19  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Randomise code starting location a little
        https://bugs.webkit.org/show_bug.cgi?id=61161

        Add a nop() function to the Assemblers so that we
        can randomise code offsets slightly at no real cost.

        * assembler/ARMAssembler.h:
        (JSC::ARMAssembler::nop):
        * assembler/ARMv7Assembler.h:
        (JSC::ARMv7Assembler::nop):
        * assembler/MacroAssemblerARM.h:
        (JSC::MacroAssemblerARM::nop):
        * assembler/MacroAssemblerARMv7.h:
        (JSC::MacroAssemblerARMv7::nop):
        * assembler/MacroAssemblerMIPS.h:
        (JSC::MacroAssemblerMIPS::nop):
        * assembler/MacroAssemblerSH4.h:
        (JSC::MacroAssemblerSH4::nop):
        * assembler/MacroAssemblerX86Common.h:
        (JSC::MacroAssemblerX86Common::nop):
        * assembler/X86Assembler.h:
        (JSC::X86Assembler::nop):
        * jit/JIT.cpp:
        (JSC::JIT::JIT):
        (JSC::JIT::privateCompile):
        * jit/JIT.h:
        * runtime/WeakRandom.h:
        (JSC::WeakRandom::getUint32):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-19 Justin Schuh <jschuh@chromium.org>
jschuh@chromium.org [Fri, 20 May 2011 01:13:36 +0000 (01:13 +0000)]
2011-05-19  Justin Schuh  <jschuh@chromium.org>

        Unreviewed.

        Chromium expectations update.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed; added new test to gtk Skipped list.
jer.noble@apple.com [Fri, 20 May 2011 01:03:13 +0000 (01:03 +0000)]
Unreviewed; added new test to gtk Skipped list.

* platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix windows build.
oliver@apple.com [Fri, 20 May 2011 00:20:11 +0000 (00:20 +0000)]
Fix windows build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-19 Dmitry Lomov <dslomov@google.com>
commit-queue@webkit.org [Fri, 20 May 2011 00:12:31 +0000 (00:12 +0000)]
2011-05-19  Dmitry Lomov  <dslomov@google.com>

        Reviewed by Adam Roben.

        run-api-tests should run one test per process
        https://bugs.webkit.org/show_bug.cgi?id=61088

        * Scripts/run-api-tests: Resurrecting the previous revison of this file, with fixes to system call under Windows,
        return code, and parsing GTest output format.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-19 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Thu, 19 May 2011 23:46:16 +0000 (23:46 +0000)]
2011-05-19  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Add guard pages to each end of the memory region used by the fixedvm allocator
        https://bugs.webkit.org/show_bug.cgi?id=61150

        Add mechanism to notify the OSAllocator that pages at either end of an
        allocation should be considered guard pages.  Update PageReservation,
        PageAllocation, etc to handle this.

        * JavaScriptCore.exp:
        * jit/ExecutableAllocatorFixedVMPool.cpp:
        (JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):
        * wtf/OSAllocator.h:
        * wtf/OSAllocatorPosix.cpp:
        (WTF::OSAllocator::reserveUncommitted):
        (WTF::OSAllocator::reserveAndCommit):
        * wtf/PageAllocation.h:
        (WTF::PageAllocation::PageAllocation):
        * wtf/PageAllocationAligned.h:
        (WTF::PageAllocationAligned::PageAllocationAligned):
        * wtf/PageBlock.h:
        (WTF::PageBlock::PageBlock):
        * wtf/PageReservation.h:
        (WTF::PageReservation::reserve):
        (WTF::PageReservation::reserveWithGuardPages):
            Add a new function to make a reservation that will add guard
            pages to the ends of an allocation.
        (WTF::PageReservation::PageReservation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-18 Kenneth Russell <kbr@google.com>
kbr@google.com [Thu, 19 May 2011 23:43:51 +0000 (23:43 +0000)]
2011-05-18  Kenneth Russell  <kbr@google.com>

        Reviewed by James Robinson.

        [chromium] Disable blending in compositor for WebGL layers with alpha=false
        https://bugs.webkit.org/show_bug.cgi?id=61091

        * compositing/webgl/webgl-no-alpha.html: Added.
        * platform/chromium-gpu/compositing/webgl/webgl-no-alpha-expected.png: Added.
        * platform/chromium-gpu/compositing/webgl/webgl-no-alpha-expected.txt: Added.
        * platform/mac-wk2/Skipped:
        * platform/mac/compositing/webgl/webgl-no-alpha-expected.png: Added.
        * platform/mac/compositing/webgl/webgl-no-alpha-expected.txt: Added.
2011-05-18  Kenneth Russell  <kbr@google.com>

        Reviewed by James Robinson.

        [chromium] Disable blending in compositor for WebGL layers with alpha=false
        https://bugs.webkit.org/show_bug.cgi?id=61091

        Test: compositing/webgl/webgl-no-alpha.html

        * platform/graphics/chromium/CanvasLayerChromium.cpp:
        (WebCore::CanvasLayerChromium::CanvasLayerChromium):
        (WebCore::CanvasLayerChromium::pushPropertiesTo):
        * platform/graphics/chromium/CanvasLayerChromium.h:
        * platform/graphics/chromium/WebGLLayerChromium.cpp:
        (WebCore::WebGLLayerChromium::setContext):
        * platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp:
        (WebCore::CCCanvasLayerImpl::CCCanvasLayerImpl):
        (WebCore::CCCanvasLayerImpl::draw):
        * platform/graphics/chromium/cc/CCCanvasLayerImpl.h:
        (WebCore::CCCanvasLayerImpl::setHasAlpha):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-18 Jeremy Noble <jer.noble@apple.com>
jer.noble@apple.com [Thu, 19 May 2011 23:17:00 +0000 (23:17 +0000)]
2011-05-18  Jeremy Noble  <jer.noble@apple.com>

        Reviewed by Darin Adler.

        Poster is not shown in Safari for video element with no playable source elements.
        https://bugs.webkit.org/show_bug.cgi?id=61109

        * media/video-src-invalid-poster-expected.txt: Added.
        * media/video-src-invalid-poster.html: Added.
2011-05-18  Jeremy Noble  <jer.noble@apple.com>

        Reviewed by Darin Adler.

        Poster is not shown in Safari for video element with no playable source elements.
        https://bugs.webkit.org/show_bug.cgi?id=61109

        Test: media/video-src-invalid-poster.html

        In the case where no video sources are playable, update the display state and
        renderer, allowing the poster image to display.

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::waitForSourceChange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-19 Andrew Wilson <atwilson@chromium.org>
atwilson@chromium.org [Thu, 19 May 2011 22:29:24 +0000 (22:29 +0000)]
2011-05-19  Andrew Wilson  <atwilson@chromium.org>

        Reviewed by Darin Adler.

        MessagePortArray cloning code needs to verify source before copying
        https://bugs.webkit.org/show_bug.cgi?id=61130

        * fast/events/message-port-multi-expected.txt:
        * fast/events/resources/message-port-multi.js:
        Added test for "passing an array with an item at a really large index" to postMessage().
2011-05-19  Andrew Wilson  <atwilson@chromium.org>

        Reviewed by Darin Adler.

        MessagePortArray cloning code needs to verify source before copying.
        https://bugs.webkit.org/show_bug.cgi?id=61130

        * bindings/js/JSMessagePortCustom.cpp:
        (WebCore::fillMessagePortArray):
        Changed code to not pre-allocate the destination array.
        * bindings/v8/custom/V8MessagePortCustom.cpp:
        (WebCore::getMessagePortArray):
        Changed code to not pre-allocate the destination array.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAddress a review comment by Sam Weinig.
andersca@apple.com [Thu, 19 May 2011 22:13:58 +0000 (22:13 +0000)]
Address a review comment by Sam Weinig.

* UIProcess/WebContext.cpp:
(WebKit::WebContext::didUpdateHistoryTitle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-19 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 19 May 2011 22:10:29 +0000 (22:10 +0000)]
2011-05-19  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Hang UI appears when WebProcess isn't running
        https://bugs.webkit.org/show_bug.cgi?id=61147
        <rdar://problem/9413683>

        This fixes two bugs:

        1. The HistoryClient related message handlers in WebContext could get invoked for pages that have been closed,
           and thus didn't have any subframes. Since we have a MESSAGE_CHECK that checks that the frame exists, we'd
           mark the currently dispatched message as invalid, which would end up calling Connection::Client::didReceiveInvalidMessage.
           Fix this by checking that the page exists first.

        2. In the call to WebProcessProxy::didReceiveInvalidMessage we'd first invalidate the CoreIPC connection to make sure
           that we won't get any further messages from this connection. We'd then go ahead and terminate the web process,
           but because we've already invalidated the CoreIPC connection we would never get the Connection::Client::didClose
           callback that would call WebPageProxy::processDidCrash. Fix this by explicitly calling WebProcessProxy::didClose.
           Also, add logging when we receive an invalid message

        * UIProcess/WebContext.cpp:
        (WebKit::WebContext::didNavigateWithNavigationData):
        (WebKit::WebContext::didPerformClientRedirect):
        (WebKit::WebContext::didPerformServerRedirect):
        (WebKit::WebContext::didUpdateHistoryTitle):
        * UIProcess/WebProcessProxy.cpp:
        (WebKit::WebProcessProxy::didReceiveInvalidMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoCrash when detaching Web Inspector when parent is in process of closing.
bweinstein@apple.com [Thu, 19 May 2011 22:06:23 +0000 (22:06 +0000)]
Crash when detaching Web Inspector when parent is in process of closing.
https://bugs.webkit.org/show_bug.cgi?id=61141
<rdar://problem/9470027>

Reviewed by Adam Roben.

We were trying to send a WM_SIZE to a window that was in the process of closing. Switch
to using PostMessage, so the window will finish closing, and then it won't need to
process the WM_SIZE message anymore.

* UIProcess/win/WebInspectorProxyWin.cpp:
(WebKit::WebInspectorProxy::platformAttach): Call PostMessage instead of SendMessage.
(WebKit::WebInspectorProxy::platformDetach): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoVersioning.
lforschler@apple.com [Thu, 19 May 2011 22:00:23 +0000 (22:00 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-19 Justin Schuh <jschuh@chromium.org>
jschuh@chromium.org [Thu, 19 May 2011 21:18:23 +0000 (21:18 +0000)]
2011-05-19  Justin Schuh  <jschuh@chromium.org>

        Unreviewed.

        Chromium expectations update.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-15 Robert Hogan <robert@webkit.org>
robert@webkit.org [Thu, 19 May 2011 20:39:10 +0000 (20:39 +0000)]
2011-05-15  Robert Hogan  <robert@webkit.org>

        Reviewed by Antonio Gomes.

        [Qt][GTK] plugins/get-url-with-javascript-url.html fails
        https://bugs.webkit.org/show_bug.cgi?id=60834
        Fix unix test plugin for plugins/get-url-with-javascript-url.html

        * platform/qt/Skipped:
2011-05-15  Robert Hogan  <robert@webkit.org>

        Reviewed by Antonio Gomes.

        [Qt][GTK] plugins/get-url-with-javascript-url.html fails
        https://bugs.webkit.org/show_bug.cgi?id=60834
        Fix unix test plugin for plugins/get-url-with-javascript-url.html

        * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
        (webkit_test_plugin_new_stream):
        (webkit_test_plugin_write_ready):
        (webkit_test_plugin_write):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-19 Justin Schuh <jschuh@chromium.org>
jschuh@chromium.org [Thu, 19 May 2011 20:36:01 +0000 (20:36 +0000)]
2011-05-19  Justin Schuh  <jschuh@chromium.org>

        Unreviewed.

        Chromium expectations update.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-19 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Thu, 19 May 2011 20:18:39 +0000 (20:18 +0000)]
2011-05-19  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoffrey Garen.

        Make Executables release their JIT code as soon as they become dead
        https://bugs.webkit.org/show_bug.cgi?id=61134

        Add an ability to clear an Executable's jit code without requiring
        it to be destroyed, and then call that from a finalizer.

        * heap/Weak.h:
        (JSC::Weak::Weak):
        (JSC::Weak::leak):
        * jit/JITCode.h:
        (JSC::JITCode::clear):
        * runtime/Executable.cpp:
        (JSC::ExecutableFinalizer::finalize):
        (JSC::ExecutableBase::executableFinalizer):
        * runtime/Executable.h:
        (JSC::ExecutableBase::ExecutableBase):
        (JSC::ExecutableBase::clearExecutableCode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-19 Justin Schuh <jschuh@chromium.org>
jschuh@chromium.org [Thu, 19 May 2011 20:18:26 +0000 (20:18 +0000)]
2011-05-19  Justin Schuh  <jschuh@chromium.org>

        Unreviewed.

        Chromium gradient expectations update.

        * platform/chromium-linux-x86/fast/gradients: Added.
        * platform/chromium-linux-x86/fast/gradients/css3-linear-right-angle-gradients-expected.png: Added.
        * platform/chromium-linux/fast/gradients/css3-linear-right-angle-gradients-expected.png: Added.
        * platform/chromium-mac-leopard/fast/gradients/css3-linear-right-angle-gradients-expected.png: Added.
        * platform/chromium-win-vista/fast/gradients/css3-linear-right-angle-gradients-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-19 Sheriff Bot <webkit.review.bot@gmail.com>
dglazkov@chromium.org [Thu, 19 May 2011 20:10:06 +0000 (20:10 +0000)]
2011-05-19  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r86869, r86873, r86875, and r86877.
        http://trac.webkit.org/changeset/86869
        http://trac.webkit.org/changeset/86873
        http://trac.webkit.org/changeset/86875
        http://trac.webkit.org/changeset/86877
        https://bugs.webkit.org/show_bug.cgi?id=61139

        broke builds and debug DRT (Requested by rniwa on #webkit).

        * fast/dom/Window/script-tests/window-property-descriptors.js:
        * fast/dom/Window/window-properties.html:
        * fast/dom/script-tests/prototype-inheritance-2.js:
        * fast/dom/script-tests/prototype-inheritance.js:
        * fast/harness/internals-object-expected.txt: Removed.
        * fast/harness/internals-object.html: Removed.
        * platform/gtk/Skipped:
        * platform/mac-wk2/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:
2011-05-19  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r86869, r86873, r86875, and r86877.
        http://trac.webkit.org/changeset/86869
        http://trac.webkit.org/changeset/86873
        http://trac.webkit.org/changeset/86875
        http://trac.webkit.org/changeset/86877
        https://bugs.webkit.org/show_bug.cgi?id=61139

        broke builds and debug DRT (Requested by rniwa on #webkit).

        * DerivedSources.make:
        * WebCore.exp.in:
        * WebCore.gyp/WebCore.gyp:
        * WebCore.gypi:
        * WebCore.xcodeproj/project.pbxproj:
        * testing/Internals.cpp: Removed.
        * testing/Internals.h: Removed.
        * testing/Internals.idl: Removed.
        * testing/js/WebCoreTestSupport.cpp: Removed.
        * testing/js/WebCoreTestSupport.h: Removed.
        * testing/v8/WebCoreTestSupport.cpp: Removed.
        * testing/v8/WebCoreTestSupport.h: Removed.
2011-05-19  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r86869, r86873, r86875, and r86877.
        http://trac.webkit.org/changeset/86869
        http://trac.webkit.org/changeset/86873
        http://trac.webkit.org/changeset/86875
        http://trac.webkit.org/changeset/86877
        https://bugs.webkit.org/show_bug.cgi?id=61139

        broke builds and debug DRT (Requested by rniwa on #webkit).

        * WebKit.gyp:
        * public/WebTestingSupport.h: Removed.
        * src/WebTestingSupport.cpp: Removed.
2011-05-19  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r86869, r86873, r86875, and r86877.
        http://trac.webkit.org/changeset/86869
        http://trac.webkit.org/changeset/86873
        http://trac.webkit.org/changeset/86875
        http://trac.webkit.org/changeset/86877
        https://bugs.webkit.org/show_bug.cgi?id=61139

        broke builds and debug DRT (Requested by rniwa on #webkit).

        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::bindJSObjectsToWindow):
        * DumpRenderTree/mac/FrameLoadDelegate.mm:
        (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-19 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 19 May 2011 20:01:06 +0000 (20:01 +0000)]
2011-05-19  Dimitri Glazkov  <dglazkov@chromium.org>

        One more fix after r86869.

        * WebCore.exp.in: Made __ZN7WebCore12JSDOMWrapperD2Ev only export for debug builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd two more symbols needed by the window.internals library.
andersca@apple.com [Thu, 19 May 2011 19:45:50 +0000 (19:45 +0000)]
Add two more symbols needed by the window.internals library.

* WebCore.exp.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-19 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 19 May 2011 19:26:56 +0000 (19:26 +0000)]
2011-05-19  Dimitri Glazkov  <dglazkov@chromium.org>

        Fix Leopard build after r86869.

        * WebCore.exp.in: Moved now-always-used exported symbols out of the conditional guard.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-19 Justin Schuh <jschuh@chromium.org>
jschuh@chromium.org [Thu, 19 May 2011 19:24:18 +0000 (19:24 +0000)]
2011-05-19  Justin Schuh  <jschuh@chromium.org>

        Unreviewed.

        Chromium expectations update.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-19 Robert Hogan <robert@webkit.org>
robert@webkit.org [Thu, 19 May 2011 18:59:30 +0000 (18:59 +0000)]
2011-05-19  Robert Hogan  <robert@webkit.org>

        Reviewed by Andreas Kling.

        [Qt] Fix plugins/windowless_plugin_paint_test.html
        https://bugs.webkit.org/show_bug.cgi?id=60992

        * platform/qt/Skipped:
2011-05-19  Robert Hogan  <robert@webkit.org>

        Reviewed by Andreas Kling.

        [Qt] Fix plugins/windowless_plugin_paint_test.html
        https://bugs.webkit.org/show_bug.cgi?id=60992

        Call gdk_init_check before gdk_display_get_default().
        If we don't do this, gdk_display_get_default() will hang
        the next time it's called.

        * plugins/qt/PluginViewQt.cpp:
        (WebCore::getPluginDisplay):
2011-05-19  Robert Hogan  <robert@webkit.org>

        Reviewed by Andreas Kling.

        [Qt] Fix plugins/windowless_plugin_paint_test.html

        Call gdk_init_check before gdk_display_get_default().
        If we don't do this, gdk_display_get_default() will hang
        the next time it's called.

        * WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
        (WebKit::getPluginDisplay):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-18 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 19 May 2011 18:54:23 +0000 (18:54 +0000)]
2011-05-18  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Adler.

        Add build logistics and plumbing for window.internals object.
        https://bugs.webkit.org/show_bug.cgi?id=60313

        * fast/dom/Window/script-tests/window-property-descriptors.js: Added internals object to list of properties to skip.
        * fast/dom/Window/window-properties.html: Ditto.
        * fast/dom/script-tests/prototype-inheritance-2.js: Ditto.
        * fast/dom/script-tests/prototype-inheritance.js: Ditto.
        * fast/harness/internals-object-expected.txt: Added.
        * fast/harness/internals-object.html: Added.
        * platform/gtk/Skipped: Skipped the newly added test until platform supports window.internals.
        * platform/mac-wk2/Skipped: Ditto.
        * platform/qt/Skipped: Ditto.
        * platform/win/Skipped: Ditto.
2011-05-18  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Adler.

        Add build logistics and plumbing for window.internals object.
        https://bugs.webkit.org/show_bug.cgi?id=60313

        Test: fast/harness/internals-object.html

        * DerivedSources.make: Added support for generating from Internals.idl.
        * WebCore.gyp/WebCore.gyp: Added new webcore_test_support library.
        * WebCore.gypi: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Added WebCoreTestSupport library.
        * testing/Internals.cpp: Added.
        * testing/Internals.h: Added.
        * testing/Internals.idl: Added.
        * testing/js/WebCoreTestSupport.cpp: Added.
        * testing/js/WebCoreTestSupport.h: Added.
        * testing/v8/WebCoreTestSupport.cpp: Added.
        * testing/v8/WebCoreTestSupport.h: Added.
2011-05-18  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Adler.

        Add build logistics and plumbing for window.internals object.
        https://bugs.webkit.org/show_bug.cgi?id=60313

        * WebKit.gyp: Added linking new webkit_test_support library.
        * public/WebTestingSupport.h: Added.
        * src/WebTestingSupport.cpp: Added.
2011-05-18  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Adler.

        Add build logistics and plumbing for window.internals object.
        https://bugs.webkit.org/show_bug.cgi?id=60313

        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::bindJSObjectsToWindow): Added injection code.
        * DumpRenderTree/mac/FrameLoadDelegate.mm:
        (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-19 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 19 May 2011 18:40:21 +0000 (18:40 +0000)]
2011-05-19  Dimitri Glazkov  <dglazkov@chromium.org>

        Accept XCode's decisions to keep modifying WebCore.xcodeproj.

        * WebCore.xcodeproj/project.pbxproj: Opened in XCode then closed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-19 Andrew Wason <rectalogic@rectalogic.com>
commit-queue@webkit.org [Thu, 19 May 2011 18:39:14 +0000 (18:39 +0000)]
2011-05-19  Andrew Wason  <rectalogic@rectalogic.com>

        Reviewed by Darin Adler.

        Fix GraphicsContext3DQt.cpp compile error
        https://bugs.webkit.org/show_bug.cgi?id=61128

        * platform/graphics/qt/GraphicsContext3DQt.cpp:
        (WebCore::GraphicsContext3D::GraphicsContext3D):
         clear() m_internal OwnPtr.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-19 Tonis Tiigi <tonistiigi@gmail.com>
commit-queue@webkit.org [Thu, 19 May 2011 18:14:58 +0000 (18:14 +0000)]
2011-05-19  Tonis Tiigi  <tonistiigi@gmail.com>

        Reviewed by Pavel Feldman.

        Web Inspector: Resizing columns in the network panel is weird
        https://bugs.webkit.org/show_bug.cgi?id=55238

        Makes network panel column resizing more usable by adding "first only" and "last only"
        resizing methods to WebInspector.DataGrid. Current behavior is named "nearest" and
        remains default. Network panels datagrid is set to use method "last".

        * inspector/front-end/DataGrid.js:
        (WebInspector.DataGrid.prototype.get resizeMethod):
        (WebInspector.DataGrid.prototype.set resizeMethod):
        (WebInspector.DataGrid.prototype._resizerDragging):
        * inspector/front-end/NetworkPanel.js:
        (WebInspector.NetworkPanel.prototype._createTable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-19 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 19 May 2011 17:46:09 +0000 (17:46 +0000)]
2011-05-19  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        JoinTextNodesCommand is never used
        https://bugs.webkit.org/show_bug.cgi?id=61089

        Deleted JoinTextNodesCommand because it's never used.

        * CMakeLists.txt:
        * GNUmakefile.list.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * editing/CompositeEditCommand.cpp:
        * editing/CompositeEditCommand.h:
        * editing/EditingAllInOne.cpp:
        * editing/JoinTextNodesCommand.cpp: Removed.
        * editing/JoinTextNodesCommand.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-19 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 19 May 2011 17:27:27 +0000 (17:27 +0000)]
2011-05-19  Ryosuke Niwa  <rniwa@webkit.org>

        Make Mac Leopard bot happy after r81176.

        * platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-19 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 19 May 2011 17:22:24 +0000 (17:22 +0000)]
2011-05-19  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        REGRESSION (r83322): Many crashes in Mail.app in WebCore::Node::nodeIndex
        https://bugs.webkit.org/show_bug.cgi?id=61012

        Added a test to ensure WebKit does not crash when inserting a content immediately after
        a styled element inside a Mail blockquote. Regrettably the expected result is incorrect,
        but it matches the behavior of WebKit before r83322.

        * editing/pasteboard/5065605-expected.txt: Reintroduced redundant style spans.
        * editing/pasteboard/paste-text-011-expected.txt: Ditto.
        * platform/chromium-win/editing/pasteboard/paste-text-011-expected.txt: Ditto.
        * editing/pasteboard/paste-after-inline-style-element-expected.txt: Added.
        * editing/pasteboard/paste-after-inline-style-element.html: Added.
2011-05-19  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        REGRESSION (r83322): Many crashes in Mail.app in WebCore::Node::nodeIndex
        https://bugs.webkit.org/show_bug.cgi?id=61012

        The crash was caused by ReplaceSelectionCommand's inserting content into a middle of the paragraph
        being moved when the insertion position's container node is the node to split to. Fixed the crash
        by not changing the insertion position in such a case.

        Unfortunately, this fix caused markup to bloat in some tests but we'll take this regression since
        it's much better than crashing.

        Test: editing/pasteboard/paste-after-inline-style-element.html

        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::doApply):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-18 Chris Marrin <cmarrin@apple.com>
cmarrin@apple.com [Thu, 19 May 2011 17:17:18 +0000 (17:17 +0000)]
2011-05-18  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Anders Carlsson.

        Plug-ins at YouTube, cnn.com, nytimes vanish when their top/left is scrolled out of view when zoomed
        https://bugs.webkit.org/show_bug.cgi?id=61101

        Scale both bounding boxes sent to m_plugin->geometryDidChange(), not just the frameRect. This fools
        the plugin into thinking it is drawing into an unscaled box with an unscaled view even when scaled.

        * WebProcess/Plugins/PluginView.cpp:
        (WebKit::PluginView::frame):Made this const so it can be used in clipRectInWindowCoordinates()
        (WebKit::PluginView::viewGeometryDidChange):Used IntRect::scale() rather than scaling by hand
        (WebKit::PluginView::clipRectInWindowCoordinates):Added scale of clipRect.
        * WebProcess/Plugins/PluginView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRemove a redundant and broken data export
aroben@apple.com [Thu, 19 May 2011 17:15:51 +0000 (17:15 +0000)]
Remove a redundant and broken data export

Data can't be exported from JavaScriptCore.dll by listing it in the .def file. The
JS_EXPORTDATA macro must be used instead. (In this case it was already being used, leading
to a linker warning about multiple definitions.)

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Removed JSGlobalData::s_info.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-19 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Thu, 19 May 2011 16:51:09 +0000 (16:51 +0000)]
2011-05-19  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Anders Carlsson.

        Fix build with ENABLE_PLUGIN_PROCESS=1 for non-mac platforms after r86578
        https://bugs.webkit.org/show_bug.cgi?id=61113

        * PluginProcess/PluginControllerProxy.cpp:
        (WebKit::PluginControllerProxy::tryToShortCircuitInvoke):
        (WebKit::PluginControllerProxy::tryToShortCircuitEvaluate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoTry to fix SUPPORT_AUTOCORRECTION_PANEL build.
beidson@apple.com [Thu, 19 May 2011 16:33:32 +0000 (16:33 +0000)]
Try to fix SUPPORT_AUTOCORRECTION_PANEL build.

* editing/SpellingCorrectionController.cpp:
(WebCore::SpellingCorrectionController::recordSpellcheckerResponseForModifiedCorrection):
(WebCore::SpellingCorrectionController::processMarkersOnTextToBeReplacedByResult):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Skip failing test after r86841.
ossy@webkit.org [Thu, 19 May 2011 16:28:02 +0000 (16:28 +0000)]
[Qt] Skip failing test after r86841.

* platform/qt-arm/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoTry to fix SUPPORT_AUTOCORRECTION_PANEL build.
darin@apple.com [Thu, 19 May 2011 16:22:11 +0000 (16:22 +0000)]
Try to fix SUPPORT_AUTOCORRECTION_PANEL build.

* editing/SpellingCorrectionController.cpp:
(WebCore::markersHaveIdenticalDescription): Call description() function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Skip failing tests after r86834.
ossy@webkit.org [Thu, 19 May 2011 15:12:05 +0000 (15:12 +0000)]
[Qt] Skip failing tests after r86834.

* platform/qt-arm/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-19 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 19 May 2011 13:08:46 +0000 (13:08 +0000)]
2011-05-19  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, skip 2 failing tests on GTK.

        * platform/gtk/Skipped: Skip http/tests/appcache/interrupted-update.html
        and http/tests/navigation/post-307-response.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-19 Andrey Adaikin <aandrey@google.com>
commit-queue@webkit.org [Thu, 19 May 2011 12:44:39 +0000 (12:44 +0000)]
2011-05-19  Andrey Adaikin  <aandrey@google.com>

        Reviewed by Pavel Feldman.

        Web Inspector: switch to Scripts panel is too slow
        https://bugs.webkit.org/show_bug.cgi?id=61030

        - It is very expensive to listen to the DOM mutation events, thus we remove the listeners whenever we do any internal
        DOM manipulations (such as expand/collapse line rows) and set the listeners back when we are finished.
        - Also, when we switch to the Scripts panel that have a non-zero scrollTop offset, we would do the rendering work twice.

        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype.show):
        * inspector/front-end/TextViewer.js:
        (WebInspector.TextEditorMainPanel):
        (WebInspector.TextEditorMainPanel.prototype.beginDomUpdates):
        (WebInspector.TextEditorMainPanel.prototype.endDomUpdates):
        (WebInspector.TextEditorMainPanel.prototype._enableDOMNodeRemovedListener):
        (WebInspector.TextEditorMainChunk):
        (WebInspector.TextEditorMainChunk.prototype.set expanded):
        (WebInspector.TextEditorMainChunk.prototype._createRow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Implement eventSender.scalePageBy
ossy@webkit.org [Thu, 19 May 2011 12:39:43 +0000 (12:39 +0000)]
[Qt] Implement eventSender.scalePageBy
https://bugs.webkit.org/show_bug.cgi?id=60015

Patch by Zsolt Fehér <h490267@stud.u-szeged.hu> on 2011-05-19
Reviewed by Csaba Osztrogonác.

Source/WebKit/qt:

* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::scalePageBy):
* WebCoreSupport/DumpRenderTreeSupportQt.h:

Tools:

* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
* DumpRenderTree/qt/EventSenderQt.cpp:
(EventSender::scalePageBy):
* DumpRenderTree/qt/EventSenderQt.h:

LayoutTests:

* platform/qt/Skipped: Unskip fast/transforms/selection-bounds-in-transformed-view.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Skip failing tests after r86834.
ossy@webkit.org [Thu, 19 May 2011 12:35:40 +0000 (12:35 +0000)]
[Qt] Skip failing tests after r86834.

* platform/qt-mac/Skipped:
* platform/qt-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-19 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Thu, 19 May 2011 12:13:16 +0000 (12:13 +0000)]
2011-05-19  Pavel Feldman  <pfeldman@google.com>

        Not reviewed: inspector protocol tests fixed.

        * inspector/InjectedScriptSource.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-19 David Grogan <dgrogan@chromium.org>
commit-queue@webkit.org [Thu, 19 May 2011 12:03:58 +0000 (12:03 +0000)]
2011-05-19  David Grogan  <dgrogan@chromium.org>

        Reviewed by David Levin.

        Make EventQueue post a Task to the task queue for each asynchronous event
        https://bugs.webkit.org/show_bug.cgi?id=60790

        Currently EventQueue queues up events to be fired asynchronously and
        fires each of them when a single DOMTimer goes off.  In the words of
        dimich, "Having 2 queues will sooner or later cause problems with
        ordering of tasks, termination, suspension and other things that all
        require some control on how queues operate."

        No new tests; this is just a refactoring to avoid potential future
        problems.

        * dom/EventQueue.cpp:
        (WebCore::EventQueue::EventQueue):
        (WebCore::EventQueue::EventDispatcherTask::create):
        (WebCore::EventQueue::EventDispatcherTask::dispatchEvent):
        (WebCore::EventQueue::EventDispatcherTask::performTask):
        (WebCore::EventQueue::EventDispatcherTask::cancel):
        (WebCore::EventQueue::EventDispatcherTask::EventDispatcherTask):
        (WebCore::EventQueue::removeEvent):
        (WebCore::EventQueue::enqueueEvent):
        (WebCore::EventQueue::enqueueOrDispatchScrollEvent):
        (WebCore::EventQueue::cancelEvent):
        (WebCore::EventQueue::cancelQueuedEvents):
        * dom/EventQueue.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-18 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Thu, 19 May 2011 11:47:02 +0000 (11:47 +0000)]
2011-05-18  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        InjectedScriptSource.js - "Don't be eval()."
        https://bugs.webkit.org/show_bug.cgi?id=60800

        * inspector/console/console-eval-blocked-expected.txt: Added.
        * inspector/console/console-eval-blocked.html: Added.
2011-05-18  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        InjectedScriptSource.js - "Don't be eval()."
        https://bugs.webkit.org/show_bug.cgi?id=60800

        Thanks to Adam Barth for providing JSC implementation!

        InjectedScriptHost.evaluate is used to perform script evaluations for
        inspector needs. This method is not affected by CSP and should fix inspector
        on pages with CSP restrictions.

        Test: inspector/console/console-eval-blocked.html

        * bindings/js/JSInjectedScriptHostCustom.cpp:
        (WebCore::JSInjectedScriptHost::evaluate):
        * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
        (WebCore::V8InjectedScriptHost::evaluateCallback):
        (WebCore::V8InjectedScriptHost::inspectedNodeCallback):
        * inspector/InjectedScriptHost.idl:
        * inspector/InjectedScriptSource.js:
        (.):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-19 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Thu, 19 May 2011 11:10:45 +0000 (11:10 +0000)]
2011-05-19  Pavel Feldman  <pfeldman@google.com>

        Reviewed by Yury Semikhatsky.

        Web Inspector: expose object class name as a part of RemoteObject mirror.
        https://bugs.webkit.org/show_bug.cgi?id=61067

        * inspector/InjectedScriptSource.js:
        * inspector/Inspector.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-19 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Thu, 19 May 2011 11:09:24 +0000 (11:09 +0000)]
2011-05-19  Pavel Feldman  <pfeldman@google.com>

        Reviewed by Yury Semikhatsky.

        Web Inspector: make "this" a part of callFrame, not scope in the protocol.
        https://bugs.webkit.org/show_bug.cgi?id=61057

        * inspector/InjectedScriptSource.js:
        * inspector/Inspector.json:
        * inspector/front-end/ScopeChainSidebarPane.js:
        (WebInspector.ScopeChainSidebarPane.prototype.update):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-19 Chang Shu <cshu@webkit.org>
commit-queue@webkit.org [Thu, 19 May 2011 11:04:13 +0000 (11:04 +0000)]
2011-05-19  Chang Shu  <cshu@webkit.org>

        Reviewed by Csaba Osztrogonác.

        [Qt] Rebaseline editing/style tests that are working
        https://bugs.webkit.org/show_bug.cgi?id=61075

        Also based on digging of Zsolt Fehér.

        * platform/qt/Skipped:
        * platform/qt/editing/style/5046875-1-expected.png: Added.
        * platform/qt/editing/style/5046875-1-expected.txt:
        * platform/qt/editing/style/5046875-2-expected.png: Added.
        * platform/qt/editing/style/5046875-2-expected.txt:
        * platform/qt/editing/style/5065910-expected.png: Added.
        * platform/qt/editing/style/5065910-expected.txt:
        * platform/qt/editing/style/5084241-expected.png: Added.
        * platform/qt/editing/style/5084241-expected.txt:
        * platform/qt/editing/style/5279521-expected.png: Added.
        * platform/qt/editing/style/5279521-expected.txt:
        * platform/qt/editing/style/block-style-004-expected.png: Added.
        * platform/qt/editing/style/block-style-005-expected.png: Added.
        * platform/qt/editing/style/block-style-006-expected.png: Added.
        * platform/qt/editing/style/create-block-for-style-001-expected.png: Added.
        * platform/qt/editing/style/create-block-for-style-001-expected.txt:
        * platform/qt/editing/style/create-block-for-style-002-expected.png: Added.
        * platform/qt/editing/style/create-block-for-style-002-expected.txt:
        * platform/qt/editing/style/create-block-for-style-003-expected.png: Added.
        * platform/qt/editing/style/create-block-for-style-003-expected.txt:
        * platform/qt/editing/style/create-block-for-style-004-expected.png: Added.
        * platform/qt/editing/style/create-block-for-style-004-expected.txt:
        * platform/qt/editing/style/create-block-for-style-005-expected.png: Added.
        * platform/qt/editing/style/create-block-for-style-005-expected.txt:
        * platform/qt/editing/style/create-block-for-style-006-expected.png: Added.
        * platform/qt/editing/style/create-block-for-style-006-expected.txt:
        * platform/qt/editing/style/create-block-for-style-007-expected.png: Added.
        * platform/qt/editing/style/create-block-for-style-007-expected.txt:
        * platform/qt/editing/style/create-block-for-style-008-expected.png: Added.
        * platform/qt/editing/style/create-block-for-style-008-expected.txt:
        * platform/qt/editing/style/create-block-for-style-009-expected.png: Added.
        * platform/qt/editing/style/create-block-for-style-009-expected.txt:
        * platform/qt/editing/style/create-block-for-style-010-expected.png: Added.
        * platform/qt/editing/style/create-block-for-style-010-expected.txt:
        * platform/qt/editing/style/create-block-for-style-011-expected.png: Added.
        * platform/qt/editing/style/create-block-for-style-011-expected.txt:
        * platform/qt/editing/style/create-block-for-style-012-expected.png: Added.
        * platform/qt/editing/style/create-block-for-style-012-expected.txt:
        * platform/qt/editing/style/create-block-for-style-013-expected.png: Added.
        * platform/qt/editing/style/create-block-for-style-013-expected.txt:
        * platform/qt/editing/style/font-family-with-space-expected.png: Added.
        * platform/qt/editing/style/font-family-with-space-expected.txt:
        * platform/qt/editing/style/fontsize-1-expected.png: Added.
        * platform/qt/editing/style/non-inheritable-styles-expected.png: Added.
        * platform/qt/editing/style/non-inheritable-styles-expected.txt:
        * platform/qt/editing/style/relative-font-size-change-001-expected.png: Added.
        * platform/qt/editing/style/relative-font-size-change-001-expected.txt:
        * platform/qt/editing/style/relative-font-size-change-002-expected.png: Added.
        * platform/qt/editing/style/relative-font-size-change-002-expected.txt:
        * platform/qt/editing/style/relative-font-size-change-003-expected.png: Added.
        * platform/qt/editing/style/relative-font-size-change-003-expected.txt:
        * platform/qt/editing/style/relative-font-size-change-004-expected.png: Added.
        * platform/qt/editing/style/relative-font-size-change-004-expected.txt:
        * platform/qt/editing/style/smoosh-styles-001-expected.png: Added.
        * platform/qt/editing/style/smoosh-styles-001-expected.txt:
        * platform/qt/editing/style/smoosh-styles-003-expected.png: Added.
        * platform/qt/editing/style/smoosh-styles-003-expected.txt:
        * platform/qt/editing/style/style-3690704-fix-expected.png: Added.
        * platform/qt/editing/style/style-3998892-fix-expected.png: Added.
        * platform/qt/editing/style/style-3998892-fix-expected.txt:
        * platform/qt/editing/style/style-boundary-001-expected.png: Added.
        * platform/qt/editing/style/style-boundary-001-expected.txt:
        * platform/qt/editing/style/style-boundary-004-expected.png: Added.
        * platform/qt/editing/style/style-boundary-004-expected.txt:
        * platform/qt/editing/style/table-selection-expected.png: Added.
        * platform/qt/editing/style/table-selection-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-19 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 19 May 2011 10:23:07 +0000 (10:23 +0000)]
2011-05-19  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, skip failing GTK fullscreen test

        https://bugs.webkit.org/show_bug.cgi?id=61118

        * platform/gtk/Skipped: Skip fullscreen/full-screen-keyboard-enabled.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-19 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Thu, 19 May 2011 09:50:07 +0000 (09:50 +0000)]
2011-05-19  Kent Tamura  <tkent@chromium.org>

        Reviewed by Hajime Morita.

        tooLong validity should not be true for a value set by a script
        https://bugs.webkit.org/show_bug.cgi?id=60948

        Update existing tests for the new behavior.

        * fast/forms/ValidityState-tooLong-input-expected.txt:
        * fast/forms/ValidityState-tooLong-textarea-expected.txt:
        * fast/forms/resources/textarea-live-pseudo-selectors.js:
        * fast/forms/script-tests/ValidityState-tooLong-input.js:
        * fast/forms/script-tests/ValidityState-tooLong-textarea.js:
2011-05-19  Kent Tamura  <tkent@chromium.org>

        Reviewed by Hajime Morita.

        tooLong validity should not be true for a value set by a script
        https://bugs.webkit.org/show_bug.cgi?id=60948

        The specification has been updated so that tooLong should be true only
        for user-edit values.

        Introduce m_wasModifiedByUser flag to HTMLInputElement and
        HTMLTextAreaElemnt. It is set to true when a renderer updates the
        value, and is cleared when the value is updated by others.

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::HTMLInputElement):
          Initialize m_wasModifiedByUser.
        (WebCore::HTMLInputElement::tooLong):
          Skip the check if m_wasModifiedByUser is false.
        (WebCore::HTMLInputElement::updateType): Clear m_wasModifiedByUser.
        (WebCore::HTMLInputElement::copyNonAttributeProperties):
        (WebCore::HTMLInputElement::setValue): If sendChange is true,
          m_wasModifiedByUser should be true because sendChange is set in a case
          of form auto-fill.  We assume a value set by form auto-fill is a kind
          of user-edit.
        (WebCore::HTMLInputElement::setValueFromRenderer):
          m_wasModifiedByUser should be true for the update by a renderer.
        * html/HTMLInputElement.h: Declare m_wasModifiedByUser.
        * html/HTMLTextAreaElement.cpp:
        (WebCore::HTMLTextAreaElement::HTMLTextAreaElement):
          Initialize m_wasModifiedByUser.
        (WebCore::HTMLTextAreaElement::updateValue):
          m_wasModifiedByUser should be true for the update by a renderer.
        (WebCore::HTMLTextAreaElement::setValueCommon): Clear m_wasModifiedByUser.
        (WebCore::HTMLTextAreaElement::tooLong):
          Skip the check if m_wasModifiedByUser is false.
        * html/HTMLTextAreaElement.h: Declare m_wasModifiedByUser.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-19 Yuzo Fujishima <yuzo@google.com>
yuzo@google.com [Thu, 19 May 2011 09:47:53 +0000 (09:47 +0000)]
2011-05-19  Yuzo Fujishima  <yuzo@google.com>

        Unreviewed Chromium test expectation change.

        svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr.html needs new reference image on Leopard.

        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-19 David Barr <davidbarr@chromium.org>
commit-queue@webkit.org [Thu, 19 May 2011 09:45:53 +0000 (09:45 +0000)]
2011-05-19  David Barr  <davidbarr@chromium.org>

        Reviewed by Simon Fraser.

        CSS3: We fail 'border radius sum of radii' test
        https://bugs.webkit.org/show_bug.cgi?id=38788

        * fast/css/border-radius-non-negative-expected.txt: Added.
        * fast/css/border-radius-non-negative.html: Added.
        * platform/mac/fast/css/border-radius-non-negative-expected.png: Added.
2011-05-19  David Barr  <davidbarr@chromium.org>

        Reviewed by Simon Fraser.

        CSS3: We fail 'border radius sum of radii' test
        https://bugs.webkit.org/show_bug.cgi?id=38788

        Ignore border-radius properties with negative values.

        Test: fast/css/border-radius-non-negative.html

        * WebCore.xcodeproj/project.pbxproj:
        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue):
        (WebCore::CSSParser::parseBorderRadius):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-19 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Thu, 19 May 2011 09:33:12 +0000 (09:33 +0000)]
2011-05-19  Yuta Kitamura  <yutak@chromium.org>

        Reviewed by Kent Tamura.

        WebSocket: Use ScriptContext::Task to hold pending events of ThreadableWebSocketChannelClientWrapper
        https://bugs.webkit.org/show_bug.cgi?id=61034

        Refactoring only. No new tests.

        * websockets/ThreadableWebSocketChannelClientWrapper.cpp:
        (WebCore::ThreadableWebSocketChannelClientWrapper::ThreadableWebSocketChannelClientWrapper):
        (WebCore::ThreadableWebSocketChannelClientWrapper::didConnect):
        (WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessage):
        (WebCore::ThreadableWebSocketChannelClientWrapper::didClose):
        (WebCore::ThreadableWebSocketChannelClientWrapper::resume):
        (WebCore::ThreadableWebSocketChannelClientWrapper::processPendingTasks):
        (WebCore::ThreadableWebSocketChannelClientWrapper::didConnectCallback):
        (WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessageCallback):
        (WebCore::ThreadableWebSocketChannelClientWrapper::didCloseCallback):
        * websockets/ThreadableWebSocketChannelClientWrapper.h:
        Remove m_pendingConnected, m_pendingMessages and m_pendingClosed, and use ScriptContext::Task
        to hold these pending events.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-05-19 Kenichi Ishibashi <bashi@chromium.org>
commit-queue@webkit.org [Thu, 19 May 2011 09:22:47 +0000 (09:22 +0000)]
2011-05-19  Kenichi Ishibashi  <bashi@chromium.org>

        Reviewed by Kent Tamura.

        [Chromium] IME candidate window appears wrong position in an iframe
        https://bugs.webkit.org/show_bug.cgi?id=61023

        Added a test which ensures the IME candidate position is located
        at suitable position.

        * platform/chromium-mac/editing/input/ime-candidate-window-position-expected.txt: Added.
        * platform/chromium-mac/editing/input/ime-candidate-window-position.html: Added.
        * platform/chromium-mac/editing/resources/ime-candidate-window-position-iframe.html: Added.
2011-05-19  Kenichi Ishibashi  <bashi@chromium.org>

        Reviewed by Kent Tamura.

        [Chromium] IME candidate window appears wrong position in an iframe
        https://bugs.webkit.org/show_bug.cgi?id=61023

        Always adjusts the range to window relative coordinates.

        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::firstRectForCharacterRange): Removed condition
        which excludes editable selectionRoot from adjusting.
2011-05-19  Kenichi Ishibashi  <bashi@chromium.org>

        Reviewed by Kent Tamura.

        [Chromium] IME candidate window appears wrong position in an iframe
        https://bugs.webkit.org/show_bug.cgi?id=61023

        Call the focused frame's firstRectForCharacterRange() instead of the
        main frame so that DRT behaves as the same as Chromium.

        * DumpRenderTree/chromium/TextInputController.cpp:
        (TextInputController::firstRectForCharacterRange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86828 268f45cc-cd09-0410-ab3c-d52691b4dbfc