WebKit-https.git
10 years agoSource/WebCore: Background Does Not Scale Correctly with Page
fsamuel@chromium.org [Thu, 4 Aug 2011 22:00:19 +0000 (22:00 +0000)]
Source/WebCore: Background Does Not Scale Correctly with Page
https://bugs.webkit.org/show_bug.cgi?id=65690

Reviewed by Simon Fraser.

Test: fast/repaint/background-scaling.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::paintRootBoxFillLayers):
* rendering/RenderView.cpp:
(WebCore::RenderView::unscaledDocumentRect):
(WebCore::RenderView::documentRect):
* rendering/RenderView.h:

LayoutTests: Background Does Not Scale Correctly with Page

Scaling is applied twice to the background (the paint area is doubly scaled).
This patch fixes this issue by passing the unscaled document rect to paintFillLayers
in paintRootBoxFillLayers.

https://bugs.webkit.org/show_bug.cgi?id=65690

Reviewed by Simon Fraser.

* fast/repaint/background-scaling-expected.png: Added.
* fast/repaint/background-scaling-expected.txt: Added.
* fast/repaint/background-scaling.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] 69 tests failing after http://trac.webkit.org/changeset/92375
yael.aharon@nokia.com [Thu, 4 Aug 2011 21:50:51 +0000 (21:50 +0000)]
[Qt] 69 tests failing after trac.webkit.org/changeset/92375
https://bugs.webkit.org/show_bug.cgi?id=65721

Unreviewed.

Skipping tests until rebaseline.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoIntroduce a new ResourceRequest::TargetType for XHRs
jochen@chromium.org [Thu, 4 Aug 2011 21:50:03 +0000 (21:50 +0000)]
Introduce a new ResourceRequest::TargetType for XHRs
https://bugs.webkit.org/show_bug.cgi?id=65544

Reviewed by Darin Fisher.

Source/WebCore:

* platform/network/chromium/ResourceRequest.h:
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::createRequest):

Source/WebKit/chromium:

* public/WebURLRequest.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd support for setting and getting whether AVFoundation is enabled to IWebPreferences
jeffm@apple.com [Thu, 4 Aug 2011 21:40:42 +0000 (21:40 +0000)]
Add support for setting and getting whether AVFoundation is enabled to IWebPreferences
https://bugs.webkit.org/show_bug.cgi?id=65718

Reviewed by Adam Roben.

* Interfaces/IWebPreferences.idl: Added setAVFoundationEnabled() and avFoundationEnabled().

* WebPreferenceKeysPrivate.h: Added WebKitAVFoundationEnabledPreferenceKey.

* WebPreferences.cpp:
(WebPreferences::avFoundationEnabled): Added.
(WebPreferences::setAVFoundationEnabled): Added.

* WebPreferences.h: Added setAVFoundationEnabled() and avFoundationEnabled().

* WebView.cpp:
(WebView::notifyPreferencesChanged): Keep settings for AVFoundation being enabled in sync.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix integer overflow in custom bindings for WebGLRenderingContext
commit-queue@webkit.org [Thu, 4 Aug 2011 21:37:03 +0000 (21:37 +0000)]
Fix integer overflow in custom bindings for WebGLRenderingContext
https://bugs.webkit.org/show_bug.cgi?id=65646

Patch by Sergey Glazunov <serg.glazunov@gmail.com> on 2011-08-04
Reviewed by Kenneth Russell.

Source/WebCore:

Test: fast/canvas/webgl/uniform-array-length-overflow.html

* bindings/js/JSWebGLRenderingContextCustom.cpp:
(WebCore::toVector): Don't crash if allocation fails.
* bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::jsArrayToFloatArray):
(WebCore::jsArrayToIntArray):

LayoutTests:

* fast/canvas/webgl/resources/floatArrayUniformShader.vert: Added.
* fast/canvas/webgl/resources/intArrayUniformShader2.vert: Added.
* fast/canvas/webgl/uniform-array-length-overflow-expected.txt: Added.
* fast/canvas/webgl/uniform-array-length-overflow.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoImplement CERTIFICATE_CREDENTIALS_SUPPORTED for CFNetwork
psolanki@apple.com [Thu, 4 Aug 2011 21:12:38 +0000 (21:12 +0000)]
Implement CERTIFICATE_CREDENTIALS_SUPPORTED for CFNetwork
https://bugs.webkit.org/show_bug.cgi?id=65704
<rdar://problem/9877734>

Reviewed by Oliver Hunt.

Implement support for client side certificate authentication in the CFNetwork based loader.

* platform/network/cf/AuthenticationCF.cpp:
(WebCore::createCF):
(WebCore::core): Also fix leak of password string.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRefine some test expectations to account for flakiness.
abarth@webkit.org [Thu, 4 Aug 2011 21:11:11 +0000 (21:11 +0000)]
Refine some test expectations to account for flakiness.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake sure that AudioArray is 16-byte aligned
crogers@google.com [Thu, 4 Aug 2011 21:07:22 +0000 (21:07 +0000)]
Make sure that AudioArray is 16-byte aligned
https://bugs.webkit.org/show_bug.cgi?id=65651

Reviewed by Kenneth Russell.

No new tests - this does not change JavaScript API.

* platform/audio/AudioArray.h:
(WebCore::AudioArray::AudioArray):
(WebCore::AudioArray::~AudioArray):
(WebCore::AudioArray::allocate):
(WebCore::AudioArray::data):
(WebCore::AudioArray::size):
(WebCore::AudioArray::at):
(WebCore::AudioArray::operator[]):
(WebCore::AudioArray::alignedAddress):
* platform/audio/Biquad.cpp:
(WebCore::Biquad::Biquad):
* platform/audio/ReverbConvolverStage.cpp:
(WebCore::ReverbConvolverStage::ReverbConvolverStage):
* webaudio/DelayDSPKernel.cpp:
(WebCore::DelayDSPKernel::DelayDSPKernel):
* webaudio/RealtimeAnalyser.cpp:
(WebCore::RealtimeAnalyser::setFftSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMore logging to help debug the "no SVN rev on Chromium Windows bots"
abarth@webkit.org [Thu, 4 Aug 2011 20:38:37 +0000 (20:38 +0000)]
More logging to help debug the "no SVN rev on Chromium Windows bots"
bug.  My current theory is that we're trying to detect the SCM system
in the wrong directory.

* Scripts/webkitpy/layout_tests/port/base.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/9882581>, <rdar://problem/9868015>, and https://bugs.webkit.org/show_...
beidson@apple.com [Thu, 4 Aug 2011 20:14:37 +0000 (20:14 +0000)]
<rdar://problem/9882581>, <rdar://problem/9868015>, and https://bugs.webkit.org/show_bug.cgi?id=65712
REGRESSION (91931) - Two LocalStorage threads started, thread unsafe operations can cause crash or other problems later.

Reviewed by Darin Adler.

* storage/StorageTracker.cpp:
(WebCore::StorageTracker::internalInitialize): Set the "needs initialization" flag before doing a
  whole bunch of stuff that might need to check it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake fast/css/import-and-insert-rule-no-update.html less flaky
andersca@apple.com [Thu, 4 Aug 2011 20:09:18 +0000 (20:09 +0000)]
Make fast/css/import-and-insert-rule-no-update.html less flaky
https://bugs.webkit.org/show_bug.cgi?id=65713

Reviewed by Dan Bernstein.

Wait until the @imported style sheet has finished loading before running the test.

* fast/css/import-and-insert-rule-no-update.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdopt AVCF media back end on Windows
jeffm@apple.com [Thu, 4 Aug 2011 20:06:48 +0000 (20:06 +0000)]
Adopt AVCF media back end on Windows
https://bugs.webkit.org/show_bug.cgi?id=65400
<rdar://problem/9894105>

First cut at implementation in MediaPlayerPrivateAVFoundationCF.cpp/.h, based on
work by Eric Carlson. Note that use of AVFoundation is determined at runtime, and
defaults to off.

Reviewed by Darin Adler.

No new tests, uses existing media tests.

* config.h: Turn on WTF_USE_AVFOUNDATION on Windows if AVFoundationCF is available.

* platform/graphics/MediaPlayer.cpp:
(WebCore::installedMediaEngines): Register MediaPlayerPrivateAVFoundationCF on Windows.
* platform/graphics/MediaPlayer.h: Add support for an AVCFPlayer.

* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::setPreload): Workaround an AVCF limitation that prevents an AVCFPlayer from being created without an AVCFItem.
(WebCore::MediaPlayerPrivateAVFoundation::dispatchNotification): Added support for ContentsNeedsDisplay notification.

* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
(WebCore::MediaPlayerPrivateAVFoundation::contentsNeedsDisplay): Added support for ContentsNeedsDisplay notification.

* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp: Added implementation.
(WebCore::AVFWrapper::caVideoLayer):
(WebCore::AVFWrapper::videoLayerWrapper):
(WebCore::AVFWrapper::videoLayer):
(WebCore::AVFWrapper::avPlayer):
(WebCore::AVFWrapper::avAsset):
(WebCore::AVFWrapper::avPlayerItem):
(WebCore::AVFWrapper::timeObserver):
(WebCore::AVFWrapper::imageGenerator):
(WebCore::AVFWrapper::dispatchQueue):
(WebCore::LayerClient::LayerClient):
(WebCore::LayerClient::~LayerClient):
(WebCore::LayerClient::platformCALayerRespondsToLayoutChanges):
(WebCore::LayerClient::platformCALayerAnimationStarted):
(WebCore::LayerClient::platformCALayerContentsOrientation):
(WebCore::LayerClient::platformCALayerPaintContents):
(WebCore::LayerClient::platformCALayerShowDebugBorders):
(WebCore::LayerClient::platformCALayerShowRepaintCounter):
(WebCore::LayerClient::platformCALayerIncrementRepaintCount):
(WebCore::LayerClient::platformCALayerContentsOpaque):
(WebCore::LayerClient::platformCALayerDrawsContent):
(WebCore::LayerClient::platformCALayerLayerDidDisplay):
(WebCore::boolString):
(WebCore::metadataKeyNames):
(WebCore::CMTimeRangeStartKey):
(WebCore::CMTimeRangeDurationKey):
(WebCore::CACFContextNeedsFlushNotification):
(WebCore::videoLayer):
(WebCore::avPlayer):
(WebCore::avAsset):
(WebCore::avPlayerItem):
(WebCore::imageGenerator):
(WebCore::MediaPlayerPrivateAVFoundationCF::create):
(WebCore::MediaPlayerPrivateAVFoundationCF::registerMediaEngine):
(WebCore::MediaPlayerPrivateAVFoundationCF::MediaPlayerPrivateAVFoundationCF):
(WebCore::MediaPlayerPrivateAVFoundationCF::~MediaPlayerPrivateAVFoundationCF):
(WebCore::MediaPlayerPrivateAVFoundationCF::cancelLoad):
(WebCore::MediaPlayerPrivateAVFoundationCF::hasLayerRenderer):
(WebCore::MediaPlayerPrivateAVFoundationCF::hasContextRenderer):
(WebCore::MediaPlayerPrivateAVFoundationCF::createContextVideoRenderer):
(WebCore::MediaPlayerPrivateAVFoundationCF::destroyContextVideoRenderer):
(WebCore::MediaPlayerPrivateAVFoundationCF::createVideoLayer):
(WebCore::MediaPlayerPrivateAVFoundationCF::destroyVideoLayer):
(WebCore::MediaPlayerPrivateAVFoundationCF::hasAvailableVideoFrame):
(WebCore::MediaPlayerPrivateAVFoundationCF::createAVPlayer):
(WebCore::MediaPlayerPrivateAVFoundationCF::createAVPlayerItem):
(WebCore::MediaPlayerPrivateAVFoundationCF::createAVAssetForURL):
(WebCore::MediaPlayerPrivateAVFoundationCF::checkPlayability):
(WebCore::MediaPlayerPrivateAVFoundationCF::beginLoadingMetadata):
(WebCore::MediaPlayerPrivateAVFoundationCF::playerItemStatus):
(WebCore::MediaPlayerPrivateAVFoundationCF::platformMedia):
(WebCore::MediaPlayerPrivateAVFoundationCF::platformLayer):
(WebCore::MediaPlayerPrivateAVFoundationCF::platformSetVisible):
(WebCore::MediaPlayerPrivateAVFoundationCF::platformPlay):
(WebCore::MediaPlayerPrivateAVFoundationCF::platformPause):
(WebCore::MediaPlayerPrivateAVFoundationCF::updateRate):
(WebCore::MediaPlayerPrivateAVFoundationCF::platformDuration):
(WebCore::MediaPlayerPrivateAVFoundationCF::currentTime):
(WebCore::MediaPlayerPrivateAVFoundationCF::seekToTime):
(WebCore::MediaPlayerPrivateAVFoundationCF::setVolume):
(WebCore::MediaPlayerPrivateAVFoundationCF::setClosedCaptionsVisible):
(WebCore::MediaPlayerPrivateAVFoundationCF::rate):
(WebCore::timeRangeIsValidAndNotEmpty):
(WebCore::MediaPlayerPrivateAVFoundationCF::platformBufferedTimeRanges):
(WebCore::MediaPlayerPrivateAVFoundationCF::platformMaxTimeSeekable):
(WebCore::MediaPlayerPrivateAVFoundationCF::platformMaxTimeLoaded):
(WebCore::MediaPlayerPrivateAVFoundationCF::totalBytes):
(WebCore::MediaPlayerPrivateAVFoundationCF::assetStatus):
(WebCore::MediaPlayerPrivateAVFoundationCF::paintCurrentFrameInContext):
(WebCore::MediaPlayerPrivateAVFoundationCF::paint):
(WebCore::mimeTypeCache):
(WebCore::MediaPlayerPrivateAVFoundationCF::getSupportedTypes):
(WebCore::MediaPlayerPrivateAVFoundationCF::supportsType):
(WebCore::MediaPlayerPrivateAVFoundationCF::isAvailable):
(WebCore::MediaPlayerPrivateAVFoundationCF::mediaTimeForTimeValue):
(WebCore::MediaPlayerPrivateAVFoundationCF::tracksChanged):
(WebCore::MediaPlayerPrivateAVFoundationCF::sizeChanged):
(WebCore::MediaPlayerPrivateAVFoundationCF::contentsNeedsDisplay):
(WebCore::AVFWrapper::AVFWrapper):
(WebCore::AVFWrapper::~AVFWrapper):
(WebCore::AVFWrapper::scheduleDisconnectAndDelete):
(WebCore::AVFWrapper::disconnectAndDeleteAVFWrapper):
(WebCore::AVFWrapper::deleteAVFWrapper):
(WebCore::AVFWrapper::createAssetForURL):
(WebCore::AVFWrapper::createPlayer):
(WebCore::AVFWrapper::createPlayerItem):
(WebCore::AVFWrapper::periodicTimeObserverCallback):
(WebCore::AVFWrapper::notificationCallback):
(WebCore::AVFWrapper::loadPlayableCompletionCallback):
(WebCore::AVFWrapper::checkPlayability):
(WebCore::AVFWrapper::loadMetadataCompletionCallback):
(WebCore::AVFWrapper::beginLoadingMetadata):
(WebCore::AVFWrapper::seekCompletedCallback):
(WebCore::AVFWrapper::seekToTime):
(WebCore::AVFWrapper::setAsset):
(WebCore::AVFWrapper::platformLayer):
(WebCore::AVFWrapper::createAVCFVideoLayer):
(WebCore::AVFWrapper::destroyVideoLayer):
(WebCore::AVFWrapper::setVideoLayerNeedsCommit):
(WebCore::AVFWrapper::setVideoLayerHidden):
(WebCore::AVFWrapper::createImageGenerator):
(WebCore::AVFWrapper::destroyImageGenerator):
(WebCore::AVFWrapper::createImageForTimeInRect):
(WebCore::LayerClient::platformCALayerLayoutSublayersOfLayer):

* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.h: Added implementation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSpeed up webkit-patch optimize-expectations significantly by not collecting test...
dglazkov@chromium.org [Thu, 4 Aug 2011 20:04:03 +0000 (20:04 +0000)]
Speed up webkit-patch optimize-expectations significantly by not collecting test files.
https://bugs.webkit.org/show_bug.cgi?id=65697

I neglected to realize that collecting test names is not necessary for this operation.

Reviewed by Adam Barth.

* Scripts/webkitpy/tool/commands/expectations.py: Changed to pass an empty list of test files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoGet rid of ResourceRequestBase::m_targetType. Move it to chromium's ResourceRequest.
jochen@chromium.org [Thu, 4 Aug 2011 19:23:27 +0000 (19:23 +0000)]
Get rid of ResourceRequestBase::m_targetType. Move it to chromium's ResourceRequest.
https://bugs.webkit.org/show_bug.cgi?id=48483

Reviewed by Alexey Proskuryakov.

Source/WebCore:

* loader/PingLoader.cpp:
(WebCore::PingLoader::loadImage):
(WebCore::PingLoader::sendPing):
(WebCore::PingLoader::reportContentSecurityPolicyViolation):
* loader/cache/CachedResourceRequest.cpp:
(WebCore::CachedResourceRequest::load):
* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webKitWebSrcStart):
* platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::adopt):
(WebCore::ResourceRequestBase::copyData):
* platform/network/ResourceRequestBase.h:
(WebCore::ResourceRequestBase::ResourceRequestBase):
* platform/network/chromium/ResourceRequest.cpp:
(WebCore::ResourceRequest::doPlatformCopyData):
(WebCore::ResourceRequest::doPlatformAdopt):
* platform/network/chromium/ResourceRequest.h:
(WebCore::ResourceRequest::ResourceRequest):
(WebCore::ResourceRequest::targetType):
(WebCore::ResourceRequest::setTargetType):
* workers/DefaultSharedWorkerRepository.cpp:
(WebCore::SharedWorkerScriptLoader::load):
* workers/Worker.cpp:
(WebCore::Worker::create):
* workers/WorkerContext.cpp:
(WebCore::WorkerContext::importScripts):
* workers/WorkerScriptLoader.cpp:
(WebCore::WorkerScriptLoader::WorkerScriptLoader):
(WebCore::WorkerScriptLoader::createResourceRequest):
* workers/WorkerScriptLoader.h:
(WebCore::WorkerScriptLoader::create):
(WebCore::WorkerScriptLoader::setTargetType):

Source/WebKit/chromium:

* src/SharedWorkerRepository.cpp:
(WebCore::SharedWorkerScriptLoader::SharedWorkerScriptLoader):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix WinCE build after r92308.
jeffm@apple.com [Thu, 4 Aug 2011 19:21:55 +0000 (19:21 +0000)]
Fix WinCE build after r92308.

* config.h: Don't try to include WebCoreHeaderDetection.h for WinCE.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd more failing tests to the skipped list.
andersca@apple.com [Thu, 4 Aug 2011 19:20:18 +0000 (19:20 +0000)]
Add more failing tests to the skipped list.

* platform/mac-lion/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agocheckout_unittest.js should have better coverage of checkout.js
abarth@webkit.org [Thu, 4 Aug 2011 19:19:23 +0000 (19:19 +0000)]
checkout_unittest.js should have better coverage of checkout.js
https://bugs.webkit.org/show_bug.cgi?id=65671

Reviewed by Dimitri Glazkov.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
    - Remove unused functions.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js:
    - Test remaining public functions in the checkout module.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoInterpreter can potentially GC in the middle of initializing a structure chain
commit-queue@webkit.org [Thu, 4 Aug 2011 18:26:30 +0000 (18:26 +0000)]
Interpreter can potentially GC in the middle of initializing a structure chain
https://bugs.webkit.org/show_bug.cgi?id=65638

Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-08-04
Reviewed by Oliver Hunt.

Moved the allocation of a prototype StructureChain before the initialization of
the structure chain within the interpreter that was causing intermittent GC crashes.

* interpreter/Interpreter.cpp:
(JSC::Interpreter::tryCachePutByID):
* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agowebkitRequestAnimationFrame's element argument needs to be marked optional
darin@chromium.org [Thu, 4 Aug 2011 18:19:43 +0000 (18:19 +0000)]
webkitRequestAnimationFrame's element argument needs to be marked optional
https://bugs.webkit.org/show_bug.cgi?id=65698

Reviewed by James Robinson.

* page/DOMWindow.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago https://bugs.webkit.org/show_bug.cgi?id=65706
dslomov@google.com [Thu, 4 Aug 2011 18:17:11 +0000 (18:17 +0000)]
    https://bugs.webkit.org/show_bug.cgi?id=65706
        Run run-unit-tests on release mode test bots.
        Reenabling after 61812 is fixed.

        Reviewed by Adam Roben.

        * BuildSlaveSupport/build.webkit.org-config/master.cfg:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDelete some unused code from platform/graphics/win
aroben@apple.com [Thu, 4 Aug 2011 18:11:57 +0000 (18:11 +0000)]
Delete some unused code from platform/graphics/win

MediaPlayerPrivateQuickTimeWin has been unused since r72117, and the GraphicsLayer-related
classes have been unused since r75262.

Fixes <http://webkit.org/b/65689> platform/graphics/win has a bunch of unused code

Reviewed by Eric Carlson.

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
Removed now-deleted files.

* platform/graphics/win/GraphicsLayerCACF.cpp: Removed.
* platform/graphics/win/GraphicsLayerCACF.h: Removed.
* platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: Removed.
* platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h: Removed.
* platform/graphics/win/WebLayer.cpp: Removed.
* platform/graphics/win/WebLayer.h: Removed.
* platform/graphics/win/WebTiledLayer.cpp: Removed.
* platform/graphics/win/WebTiledLayer.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDetect and handle overflow in PlatformCALayerWinInternal::constrainedSize
aroben@apple.com [Thu, 4 Aug 2011 18:11:22 +0000 (18:11 +0000)]
Detect and handle overflow in PlatformCALayerWinInternal::constrainedSize

Google Maps sometimes requests very large (i.e., 2^50 pixels or greater) layers when
zooming. PlatformCALayerWinInternal has code to limit tiled layers to 2^27 pixels, but it
was not correctly handling overflow. In some cases, this would lead to creating a tiled
layer with 0 tiles, which was the cause of this crash.

Fixes <http://webkit.org/b/65637> <rdar://problem/9784849> Crash beneath
PlatformCALayerWinInternal::updateTiles when zooming on Google Maps

Reviewed by Sam Weinig.

Source/WebCore:

* platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:
(PlatformCALayerWinInternal::constrainedSize): Check for overflow before seeing if the
number of required tiles is larger than the maximum number of allowed tiles.
(PlatformCALayerWinInternal::updateTiles): Added an assertion to catch cases where we have a
non-empty tiled layer that contains 0 tiles, which would cause the crash in this bug report.

LayoutTests:

Test that a 2^25x2^25 pixel layer doesn't cause a crash

* compositing/tiling/crash-huge-layer-expected.txt: Added.
* compositing/tiling/crash-huge-layer.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSet graphics context current before canvas.toDataURL().
senorblanco@chromium.org [Thu, 4 Aug 2011 18:00:41 +0000 (18:00 +0000)]
Set graphics context current before canvas.toDataURL().
https://bugs.webkit.org/show_bug.cgi?id=65700

Reviewed by James Robinson.

No new tests, unfortunately.  The test infrastucture doesn't seem
to be conducive to writing multiple-context tests.

* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::toDataURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago https://bugs.webkit.org/show_bug.cgi?id=61812
dslomov@google.com [Thu, 4 Aug 2011 17:52:20 +0000 (17:52 +0000)]
    https://bugs.webkit.org/show_bug.cgi?id=61812
        TestWebKitApi breaks in release mode due to gtest incompatibility with fast malloc

        Disable fast malloc for offending class (::std::strstream) in gtest.
        This looks like the most non-intrusive solution.

        Reviewed by David Levin.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoEval handling attempts literal parsing even when the eval
fpizlo@apple.com [Thu, 4 Aug 2011 17:48:40 +0000 (17:48 +0000)]
Eval handling attempts literal parsing even when the eval
string is in the cache
https://bugs.webkit.org/show_bug.cgi?id=65675

Reviewed by Oliver Hunt.

This is a 25% speed-up on date-format-tofte and a 1.5% speed-up overall
in SunSpider.  It's neutral on V8.

* bytecode/EvalCodeCache.h:
(JSC::EvalCodeCache::tryGet):
(JSC::EvalCodeCache::getSlow):
(JSC::EvalCodeCache::get):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::callEval):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, mark gain.html as flaky on Linux chromium.
jianli@chromium.org [Thu, 4 Aug 2011 17:48:06 +0000 (17:48 +0000)]
Unreviewed, mark gain.html as flaky on Linux chromium.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSource/WebCore: WebKit2: Web Inspector always starts in undocked mode
bweinstein@apple.com [Thu, 4 Aug 2011 17:45:31 +0000 (17:45 +0000)]
Source/WebCore: WebKit2: Web Inspector always starts in undocked mode
https://bugs.webkit.org/show_bug.cgi?id=65493
<rdar://problem/9353114>

Reviewed by Adam Roben.

Expose some methods on InspectorFrontendClient through the InspectorController so WebKit2
can request the inspector be docked, or ask whether or not it can be docked.

* WebCore.exp.in: Export needed methods.
* inspector/InspectorController.cpp:
(WebCore::InspectorController::requestAttachWindow): Call through to InspectorFrontendClient.
(WebCore::InspectorController::canAttachWindow): Ditto.
* inspector/InspectorController.h:
* inspector/InspectorFrontendClient.h:
* inspector/InspectorFrontendClientLocal.h:

Source/WebKit/chromium: WebKit2: Web Inspector always starts in undocked mode
https://bugs.webkit.org/show_bug.cgi?id=65493
<rdar://problem/9353114>

Reviewed by Adam Roben.

Add a stub method for Chromium.

* src/InspectorFrontendClientImpl.cpp:
(WebKit::InspectorFrontendClientImpl::canAttachWindow):
* src/InspectorFrontendClientImpl.h:

Source/WebKit2: WebKit2: Web Inspector always starts in undocked mode
https://bugs.webkit.org/show_bug.cgi?id=65493
<rdar://problem/9353114>

Reviewed by Adam Roben.

When opening the inspector, the web process tells the UI process that the inspector page has loaded,
but now will pass another bit of data, whether the inspector can start attached, so the UI process
doesn't need to ask the web process to do another calculation on whether or not it can be attached.

If the user prefers the inspector to start docked (this defaults to true), and there is room for the
window, we send a message to the web process to try and attach the inspector. This makes sure that the
inspector knows it is docked (in the web process).

* UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::attach): Update the user's docked/undocked preference if the inspector is visible
    when it was attached.
(WebKit::WebInspectorProxy::detach): Ditto (but when it was detached).
(WebKit::WebInspectorProxy::didLoadInspectorPage): If we can start docked, and the user prefers to start docked,
    then request the inspector be attached to the window.
* UIProcess/WebInspectorProxy.h:

* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformOpen): Only show the window if we are going to start undocked.
* UIProcess/win/WebInspectorProxyWin.cpp:
(WebKit::WebInspectorProxy::platformOpen): Ditto.

* WebProcess/WebPage/WebInspector.cpp:
(WebKit::WebInspector::didLoadInspectorPage): Pass whether or not we can attach the window.
(WebKit::WebInspector::requestAttachWindow): Call through to the InspectorController to attach the inspector.
(WebKit::WebInspector::canAttachWindow): Ask the InspectorController if we can attach the inspector.
* WebProcess/WebPage/WebInspector.h:

* Shared/WebPreferencesStore.h: Add a new preference for whether or not the inspector should
    start attached.

* UIProcess/WebInspectorProxy.messages.in: When the inspector page is loaded, tell the UI Process whether
    we can attach the inspector without needing another message.
* WebProcess/WebPage/WebInspector.messages.in: Add a new message for RequestAttachWindow

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Unreviewed, skip 2 crashing tests on GTK. See bug 65699 and 65702.
philn@webkit.org [Thu, 4 Aug 2011 17:25:02 +0000 (17:25 +0000)]
    Unreviewed, skip 2 crashing tests on GTK. See bug 65699 and 65702.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agobuilders.js needs unit tests
abarth@webkit.org [Thu, 4 Aug 2011 16:51:48 +0000 (16:51 +0000)]
builders.js needs unit tests
https://bugs.webkit.org/show_bug.cgi?id=65670

Reviewed by Dimitri Glazkov.

This test requires somewhat large test fixtures, but using real
examples seemed better than trimming them down too much.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
    - Note: trac_unittests.js doesn't exist (yet!).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Unreviewed, skip some svg tests on GTK, likely affected by bug 39022.
philn@webkit.org [Thu, 4 Aug 2011 16:41:23 +0000 (16:41 +0000)]
    Unreviewed, skip some svg tests on GTK, likely affected by bug 39022.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Unreviewed, GTK rebaseline and test_expectations update (2 tests
philn@webkit.org [Thu, 4 Aug 2011 16:33:05 +0000 (16:33 +0000)]
    Unreviewed, GTK rebaseline and test_expectations update (2 tests
        now passing).

        * platform/gtk/fast/text/international/unicode-bidi-plaintext-expected.txt:
        * platform/gtk/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt:
        * platform/gtk/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Normalize test_expectations.txt file.
dglazkov@chromium.org [Thu, 4 Aug 2011 16:22:56 +0000 (16:22 +0000)]
[Chromium] Normalize test_expectations.txt file.

* platform/chromium/test_expectations.txt: Ran webkit-path optimize-expectations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSupport cast between CSSPrimitiveValue and EborderFit, use in CSSStyleSelector.
macpherson@chromium.org [Thu, 4 Aug 2011 16:10:06 +0000 (16:10 +0000)]
Support cast between CSSPrimitiveValue and EborderFit, use in CSSStyleSelector.
https://bugs.webkit.org/show_bug.cgi?id=65665

Reviewed by Simon Fraser.

No new tests / refactoring only.

* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
Support cast from EBorderFit.
(WebCore::CSSPrimitiveValue::operator EBorderFit):
Support cast to EBorderFit.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
Use new cast to allow use of appropriate macro.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: rename sendResultByValue to returnByValue in Runtime agent.
pfeldman@chromium.org [Thu, 4 Aug 2011 16:09:00 +0000 (16:09 +0000)]
Web Inspector: rename sendResultByValue to returnByValue in Runtime agent.
https://bugs.webkit.org/show_bug.cgi?id=65687

Reviewed by Yury Semikhatsky.

* inspector/InjectedScript.cpp:
(WebCore::InjectedScript::evaluate):
(WebCore::InjectedScript::callFunctionOn):
* inspector/InjectedScript.h:
* inspector/InjectedScriptSource.js:
* inspector/Inspector.json:
* inspector/InspectorRuntimeAgent.cpp:
(WebCore::InspectorRuntimeAgent::evaluate):
(WebCore::InspectorRuntimeAgent::callFunctionOn):
* inspector/InspectorRuntimeAgent.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt][WK2] Create scene graph nodes for tiles in QTouchWebView instead of using impera...
jocelyn.turcotte@nokia.com [Thu, 4 Aug 2011 15:41:49 +0000 (15:41 +0000)]
[Qt][WK2] Create scene graph nodes for tiles in QTouchWebView instead of using imperative painting.
https://bugs.webkit.org/show_bug.cgi?id=65528

Reviewed by Benjamin Poulain.

Converts QTouchWebPage from QSGPaintedItem to a straight QSGItem.
- A SGTileNode is created and added to the scene graph for each tile,
  positioning them relatively to the page.
  It's basically a QSGSimpleTextureNode with support for specifying a
  source rect plus for owning the QSGTexture for proper destruction on
  shutdown by the rendering thread.
- Scale nodes are used as parent of tile nodes to revert the scaling set on the
  QTouchWebPage and allow us to keep using integer coordinates.
- The SGAgent class is introduced to carry scene graph update request up to the
  updatePaintNode call of the item, which may be on the scene graph rendering thread.

* UIProcess/API/qt/qtouchwebpage.cpp:
(QTouchWebPage::QTouchWebPage):
(QTouchWebPage::updatePaintNode):
Delegate scene graph updates to the SGAgent which received update requests from the tiled drawing area.
(QTouchWebPage::event):
(QTouchWebPage::geometryChanged):
(QTouchWebPagePrivate::QTouchWebPagePrivate):
* UIProcess/API/qt/qtouchwebpage.h:
* UIProcess/API/qt/qtouchwebpage_p.h:
* UIProcess/TiledDrawingAreaProxy.cpp:
Manage the scale node in the TileSet, it will be the parent node of Tile nodes.
(WebKit::TiledDrawingAreaTileSet::sgNodeID):
(WebKit::TiledDrawingAreaTileSet::TiledDrawingAreaTileSet):
(WebKit::TiledDrawingAreaTileSet::~TiledDrawingAreaTileSet):
(WebKit::TiledDrawingAreaProxy::TiledDrawingAreaProxy):
(WebKit::TiledDrawingAreaProxy::setContentsScale):
(WebKit::TiledDrawingAreaProxy::createTiles):
(WebKit::TiledDrawingAreaProxy::removeAllTiles):
* UIProcess/TiledDrawingAreaTile.h:
(WebKit::TiledDrawingAreaTile::create):
* UIProcess/qt/SGAgent.cpp: Added.
* UIProcess/qt/SGAgent.h: Added.
* UIProcess/qt/SGTileNode.cpp: Added.
* UIProcess/qt/SGTileNode.h: Added.
* UIProcess/qt/TiledDrawingAreaProxyQt.cpp:
Disable the paint call and update the scene graph on incorporateUpdate through the SGAgent.
(WebKit::TiledDrawingAreaProxy::updateWebView):
* UIProcess/qt/TiledDrawingAreaTileQt.cpp:
(WebKit::TiledDrawingAreaTile::TiledDrawingAreaTile):
(WebKit::TiledDrawingAreaTile::~TiledDrawingAreaTile):
(WebKit::TiledDrawingAreaTile::isReadyToPaint):
(WebKit::TiledDrawingAreaTile::swapBackBufferToFront):
(WebKit::TiledDrawingAreaTile::paint):
(WebKit::TiledDrawingAreaTile::incorporateUpdate):
(WebKit::TiledDrawingAreaTile::disableUpdates):
(WebKit::TiledDrawingAreaTile::setParentNodeID):
* UIProcess/qt/TouchViewInterface.cpp:
(WebKit::TouchViewInterface::sceneGraphAgent):
(WebKit::TouchViewInterface::setViewNeedsDisplay):
* UIProcess/qt/TouchViewInterface.h:
* WebKit2.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUse -webkit-locale for font selection.
commit-queue@webkit.org [Thu, 4 Aug 2011 15:22:05 +0000 (15:22 +0000)]
Use -webkit-locale for font selection.
https://bugs.webkit.org/show_bug.cgi?id=10874

Patch by Matt Falkenhagen <falken@chromium.org> on 2011-08-04
Reviewed by Dan Bernstein.

Infer a script from -webkit-locale to use to choose a font for generic
font families and the default unstyled font.  The font is retrieved
from per-script font settings (see bug 20797).  Since these settings
have not changed there should be no visible effect yet.

* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSFontSelector.cpp: Use script when getting font from Settings
(WebCore::fontDataForGenericFamily):
(WebCore::CSSFontSelector::getFontData):
* css/CSSPropertyNames.in: Increase priority of -webkit-locale since it affects font
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::styleForDocument):
(WebCore::CSSStyleSelector::applyDeclarations):
(WebCore::CSSStyleSelector::applyProperty): Set script in font based on -webkit-locale
* page/Settings.cpp:
(WebCore::getGenericFontFamilyForScript): Fallback to USCRIPT_COMMON
* platform/graphics/FontDescription.h: Add m_script
(WebCore::FontDescription::FontDescription):
(WebCore::FontDescription::script):
(WebCore::FontDescription::setScript):
(WebCore::FontDescription::operator==):
* platform/text/LocaleToScriptMapping.h: Added.
* platform/text/LocaleToScriptMappingDefault.cpp: Added.
(WebCore::localeToScriptCodeForFontSelection):
(WebCore::LocaleScript::if):
(WebCore::LocaleScript::while):
* platform/text/LocaleToScriptMappingICU.cpp: Added.
(WebCore::scriptCodeForFontSelection):
(WebCore::localeToScriptCodeForFontSelection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Unreviewed, GTK new baselines for new tests.
philn@webkit.org [Thu, 4 Aug 2011 15:04:20 +0000 (15:04 +0000)]
    Unreviewed, GTK new baselines for new tests.

        * platform/gtk/accessibility/aria-labelledby-overrides-aria-label-expected.txt: Added.
        * platform/gtk/fast/block/float/intruding-float-add-in-sibling-block-on-static-position-expected.png: Added.
        * platform/gtk/fast/block/float/intruding-float-add-in-sibling-block-on-static-position-expected.txt: Added.
        * platform/gtk/fast/block/float/intruding-float-add-in-sibling-block-on-static-position2-expected.png: Added.
        * platform/gtk/fast/block/float/intruding-float-add-in-sibling-block-on-static-position2-expected.txt: Added.
        * platform/gtk/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position-expected.png: Added.
        * platform/gtk/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position-expected.txt: Added.
        * platform/gtk/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position2-expected.png: Added.
        * platform/gtk/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position2-expected.txt: Added.
        * platform/gtk/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position-expected.png: Added.
        * platform/gtk/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position-expected.txt: Added.
        * platform/gtk/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position2-expected.png: Added.
        * platform/gtk/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position2-expected.txt: Added.
        * platform/gtk/fast/block/float/overhanging-float-add-in-static-position-block-expected.png: Added.
        * platform/gtk/fast/block/float/overhanging-float-add-in-static-position-block-expected.txt: Added.
        * platform/gtk/fast/block/float/overhanging-float-add-in-static-position-block2-expected.png: Added.
        * platform/gtk/fast/block/float/overhanging-float-add-in-static-position-block2-expected.txt: Added.
        * platform/gtk/fast/block/float/overhanging-float-remove-from-absolute-position-block-expected.png: Added.
        * platform/gtk/fast/block/float/overhanging-float-remove-from-absolute-position-block-expected.txt: Added.
        * platform/gtk/fast/block/float/overhanging-float-remove-from-absolute-position-block2-expected.png: Added.
        * platform/gtk/fast/block/float/overhanging-float-remove-from-absolute-position-block2-expected.txt: Added.
        * platform/gtk/fast/block/float/overhanging-float-remove-from-fixed-position-block-expected.png: Added.
        * platform/gtk/fast/block/float/overhanging-float-remove-from-fixed-position-block-expected.txt: Added.
        * platform/gtk/fast/block/float/overhanging-float-remove-from-fixed-position-block2-expected.png: Added.
        * platform/gtk/fast/block/float/overhanging-float-remove-from-fixed-position-block2-expected.txt: Added.
        * platform/gtk/fast/blockflow/broken-ideograph-small-caps-expected.png: Added.
        * platform/gtk/fast/blockflow/broken-ideographic-font-expected.png: Added.
        * platform/gtk/fast/borders/only-one-border-with-width-expected.png: Added.
        * platform/gtk/fast/borders/only-one-border-with-width-expected.txt: Added.
        * platform/gtk/fast/css/color-leakage-expected.png: Added.
        * platform/gtk/fast/css/color-leakage-expected.txt: Added.
        * platform/gtk/fast/css/font-family-pictograph-expected.png: Added.
        * platform/gtk/fast/css/font-family-pictograph-expected.txt: Added.
        * platform/gtk/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.png: Added.
        * platform/gtk/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.txt: Added.
        * platform/gtk/fast/forms/input-appearance-number-rtl-expected.png: Added.
        * platform/gtk/fast/forms/input-appearance-number-rtl-expected.txt: Added.
        * platform/gtk/fast/forms/textarea-placeholder-wrapping-expected.png: Added.
        * platform/gtk/fast/forms/textarea-placeholder-wrapping-expected.txt: Added.
        * platform/gtk/fast/forms/textfield-overflow-by-value-update-expected.png: Added.
        * platform/gtk/fast/forms/textfield-overflow-by-value-update-expected.txt: Added.
        * platform/gtk/fast/multicol/span/span-as-nested-inline-block-child-expected.png: Added.
        * platform/gtk/fast/multicol/span/span-as-nested-inline-block-child-expected.txt: Added.
        * platform/gtk/fast/text/international/unicode-bidi-plaintext-expected.png: Added.
        * platform/gtk/fast/text/international/unicode-bidi-plaintext-expected.txt: Added.
        * platform/gtk/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png: Added.
        * platform/gtk/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt: Added.
        * platform/gtk/fast/text/midword-break-before-surrogate-pair-expected.png: Added.
        * platform/gtk/fast/text/midword-break-before-surrogate-pair-expected.txt: Added.
        * platform/gtk/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.png: Added.
        * platform/gtk/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt: Added.
        * platform/gtk/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png: Added.
        * platform/gtk/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt: Added.
        * platform/gtk/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.png: Added.
        * platform/gtk/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt: Added.
        * platform/gtk/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.png: Added.
        * platform/gtk/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.txt: Added.
        * platform/gtk/svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.png: Added.
        * platform/gtk/svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.txt: Added.
        * platform/gtk/svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.png: Added.
        * platform/gtk/svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.txt: Added.
        * platform/gtk/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.png: Added.
        * platform/gtk/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.txt: Added.
        * platform/gtk/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.png: Added.
        * platform/gtk/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.txt: Added.
        * platform/gtk/svg/as-border-image/svg-as-border-image-expected.png: Added.
        * platform/gtk/svg/as-border-image/svg-as-border-image-expected.txt: Added.
        * platform/gtk/svg/custom/absolute-root-position-masking-expected.png: Added.
        * platform/gtk/svg/custom/absolute-root-position-masking-expected.txt: Added.
        * platform/gtk/svg/custom/linking-uri-01-b-expected.png: Added.
        * platform/gtk/svg/custom/linking-uri-01-b-expected.txt: Added.
        * platform/gtk/svg/custom/repaint-shadow-expected.png: Added.
        * platform/gtk/svg/custom/repaint-shadow-expected.txt: Added.
        * platform/gtk/svg/custom/svg-fonts-fallback-expected.png: Added.
        * platform/gtk/svg/custom/svg-fonts-fallback-expected.txt: Added.
        * platform/gtk/svg/custom/svg-fonts-segmented-expected.png: Added.
        * platform/gtk/svg/custom/svg-fonts-segmented-expected.txt: Added.
        * platform/gtk/svg/custom/svg-fonts-word-spacing-expected.png: Added.
        * platform/gtk/svg/custom/svg-fonts-word-spacing-expected.txt: Added.
        * platform/gtk/svg/custom/text-tref-03-b-change-href-dom-expected.png: Added.
        * platform/gtk/svg/custom/text-tref-03-b-change-href-dom-expected.txt: Added.
        * platform/gtk/svg/custom/text-tref-03-b-change-href-expected.png: Added.
        * platform/gtk/svg/custom/text-tref-03-b-change-href-expected.txt: Added.
        * platform/gtk/svg/custom/text-tref-03-b-referenced-element-removal-expected.png: Added.
        * platform/gtk/svg/custom/text-tref-03-b-referenced-element-removal-expected.txt: Added.
        * platform/gtk/svg/custom/text-tref-03-b-tref-removal-expected.png: Added.
        * platform/gtk/svg/custom/text-tref-03-b-tref-removal-expected.txt: Added.
        * platform/gtk/svg/custom/tref-own-content-removal-expected.png: Added.
        * platform/gtk/svg/custom/tref-own-content-removal-expected.txt: Added.
        * platform/gtk/svg/text/text-overflow-ellipsis-svgfont-expected.png: Added.
        * platform/gtk/svg/text/text-overflow-ellipsis-svgfont-expected.txt: Added.
        * platform/gtk/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png: Added.
        * platform/gtk/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Make navigation actions properly usable in QML.
alexis.menard@openbossa.org [Thu, 4 Aug 2011 14:57:04 +0000 (14:57 +0000)]
[Qt] Make navigation actions properly usable in QML.
https://bugs.webkit.org/show_bug.cgi?id=65624

Source/WebKit2:

Add a new class that is exposed in QML to control the navigation
like reload/stop/back/forward. Enums are not very QML friendly,
it not possible to use enums that are not declared in the same class
than the object exposed in QML, therefore it makes hard the sharing
between the desktop and the touch views. In addition namespaced enums are
even harder to support in QML. QWebNavigationController is
not really meant to be used in C++ but it is exported for convenience
reason (tests and MiniBrowser) so its API is not meant to be public but
exposed in QML through properties and convenience slots. The QML code to use
the navigation action in QML will look like "desktopView.navigation.reload();"
or "if (desktopView.navigation.reloadAction.enabled) ...".

Reviewed by Benjamin Poulain.

* UIProcess/API/qt/WKView.h: To get the forward header generated
* UIProcess/API/qt/qdesktopwebview.cpp:
(QDesktopWebViewPrivate::QDesktopWebViewPrivate):
(QDesktopWebView::navigationController):
* UIProcess/API/qt/qdesktopwebview.h:
* UIProcess/API/qt/qdesktopwebview_p.h:
* UIProcess/API/qt/qmlplugin/plugin.cpp:
(WebKit2QmlPlugin::registerTypes):
* UIProcess/API/qt/qtouchwebpage.cpp:
(QTouchWebPage::navigationController):
(QTouchWebPagePrivate::QTouchWebPagePrivate):
* UIProcess/API/qt/qtouchwebpage.h:
* UIProcess/API/qt/qtouchwebpage_p.h:
* UIProcess/API/qt/qwebnavigationcontroller.cpp: Added.
(QWebNavigationControllerPrivate::QWebNavigationControllerPrivate):
(QWebNavigationController::QWebNavigationController):
(QWebNavigationController::~QWebNavigationController):
(QWebNavigationController::backAction):
(QWebNavigationController::forwardAction):
(QWebNavigationController::stopAction):
(QWebNavigationController::reloadAction):
(QWebNavigationController::navigationAction):
(QWebNavigationController::back):
(QWebNavigationController::forward):
(QWebNavigationController::stop):
(QWebNavigationController::reload):
* UIProcess/API/qt/qwebnavigationcontroller.h: Added.
* UIProcess/API/qt/tests/commonviewtests/webviewabstraction.cpp:
(WebViewAbstraction::triggerNavigationAction):
* UIProcess/API/qt/tests/qdesktopwebview/tst_qdesktopwebview.cpp:
(tst_QDesktopWebView::navigationActionsStatusAtStartup):
(LoadStartedCatcher::onLoadStarted):
(tst_QDesktopWebView::stopActionEnabledAfterLoadStarted):
* UIProcess/API/qt/tests/qtouchwebview/tst_qtouchwebview.cpp:
(tst_QTouchWebView::navigationActionsStatusAtStartup):
* WebKit2API.pri:

Tools:

Fix compilation after the introduction of QWebNavigationController.

Reviewed by Benjamin Poulain.

* MiniBrowser/qt/BrowserView.cpp:
(BrowserView::navigationAction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: Pretty print JSONP in network panel preview tab.
vsevik@chromium.org [Thu, 4 Aug 2011 14:39:16 +0000 (14:39 +0000)]
Web Inspector: Pretty print JSONP in network panel preview tab.
https://bugs.webkit.org/show_bug.cgi?id=65559

Reviewed by Pavel Feldman.

Source/WebCore:

Test: http/tests/inspector/network/network-preview-json.html

* inspector/front-end/ResourceJSONView.js:
(WebInspector.ResourceJSONView.parseJSON.WebInspector.ResourceJSONView.parseJSONP):
(WebInspector.ResourceJSONView.parseJSON.WebInspector.ResourceJSONView.prototype._initialize):
(WebInspector.ResourceJSONView.parseJSON.WebInspector.ParsedJSON):
* inspector/front-end/ResourcePreviewView.js:
(WebInspector.ResourcePreviewView.prototype._createPreviewView):

LayoutTests:

* http/tests/inspector/network/network-preview-json-expected.txt: Added.
* http/tests/inspector/network/network-preview-json.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: replace isRegex with urlRegex in setBreakpointByUrl
pfeldman@chromium.org [Thu, 4 Aug 2011 13:54:18 +0000 (13:54 +0000)]
Web Inspector: replace isRegex with urlRegex in setBreakpointByUrl
https://bugs.webkit.org/show_bug.cgi?id=65684

Reviewed by Yury Semikhatsky.

Source/WebCore:

* inspector/Inspector.json:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
* inspector/InspectorDebuggerAgent.h:
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype.setBreakpoint):

LayoutTests:

* inspector/debugger/debugger-set-breakpoint-regex-expected.txt:
* inspector/debugger/debugger-set-breakpoint-regex.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago [GTK] fullscreen/video-controls-override.html fails
philn@webkit.org [Thu, 4 Aug 2011 13:42:54 +0000 (13:42 +0000)]
    [GTK] fullscreen/video-controls-override.html fails
        https://bugs.webkit.org/show_bug.cgi?id=65618

        Reviewed by Martin Robinson.

        Implement extraFullScreenStyleSheet() and provide the QuickTime
        stylesheet for now, later we might want our own stylesheet.

        * GNUmakefile.am:
        * platform/gtk/RenderThemeGtk.cpp:
        (WebCore::RenderThemeGtk::extraFullScreenStyleSheet):
        * platform/gtk/RenderThemeGtk.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: Rename sourceId -> scriptId in the protocol and the source code.
pfeldman@chromium.org [Thu, 4 Aug 2011 13:07:29 +0000 (13:07 +0000)]
Web Inspector: Rename sourceId -> scriptId in the protocol and the source code.
https://bugs.webkit.org/show_bug.cgi?id=65682

Reviewed by Yury Semikhatsky.

Source/WebCore:

* inspector/InjectedScriptSource.js:
():
* inspector/Inspector.json:
* inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::addMessageToConsole):
* inspector/InspectorConsoleAgent.h:
* inspector/InspectorConsoleInstrumentation.h:
(WebCore::InspectorInstrumentation::addMessageToConsole):
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::buildObjectForEventListener):
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::parseLocation):
(WebCore::InspectorDebuggerAgent::setBreakpoint):
(WebCore::InspectorDebuggerAgent::continueToLocation):
(WebCore::InspectorDebuggerAgent::resolveBreakpoint):
(WebCore::InspectorDebuggerAgent::setScriptSource):
(WebCore::InspectorDebuggerAgent::getScriptSource):
(WebCore::InspectorDebuggerAgent::didParseSource):
* inspector/InspectorDebuggerAgent.h:
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::addMessageToConsoleImpl):
* inspector/InspectorInstrumentation.h:
* inspector/ScriptDebugListener.h:
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype.scriptForSourceID):
(WebInspector.DebuggerModel.prototype.queryScripts):
(WebInspector.DebuggerModel.prototype.setScriptSource):
(WebInspector.DebuggerModel.prototype._didEditScriptSource):
(WebInspector.DebuggerModel.prototype._parsedScriptSource):
(WebInspector.DebuggerDispatcher.prototype.scriptParsed):
(WebInspector.DebuggerDispatcher.prototype.breakpointResolved):
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.registerAnchor):
(WebInspector.DebuggerPresentationModel.prototype._updateAnchor):
(WebInspector.DebuggerPresentationModel.prototype.setScriptSource.didReceiveSource):
(WebInspector.DebuggerPresentationModel.prototype.setScriptSource):
(WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger.didGetScriptLocation):
(WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger):
(WebInspector.DebuggerPresentationModel.prototype._breakpointAdded):
(WebInspector.DebuggerPresentationModel.prototype.set _debuggerPaused):
(WebInspector.DebuggerPresentationModel.prototype._sourceFileForScript):
(WebInspector.DebuggerPresentationModel.prototype._scriptForSourceFileId):
(WebInspector.DebuggerPresentationModel.prototype._createSourceFileId):
(WebInspector.PresenationCallFrame):
(WebInspector.PresenationCallFrame.prototype.sourceLine):
* inspector/front-end/EventListenersSidebarPane.js:
(.):
():
* inspector/front-end/Script.js:
(WebInspector.Script):
(WebInspector.Script.prototype.requestSource):
(WebInspector.Script.prototype.editSource):
* inspector/front-end/SourceFile.js:
(WebInspector.RawSourceCode.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.prototype.forceLoadContent):
(WebInspector.RawSourceCode.prototype._concatenateScriptsContent):

LayoutTests:

* http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest):
* inspector/debugger/source-file.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Unreviewed, GTK rebaseline.
philn@webkit.org [Thu, 4 Aug 2011 12:43:31 +0000 (12:43 +0000)]
    Unreviewed, GTK rebaseline.

        * platform/gtk/fast/dom/Range/getBoundingClientRect-expected.txt:
        * platform/gtk/fast/dom/Range/getClientRects-expected.txt:
        * platform/gtk/fast/dom/Window/window-postmessage-clone-expected.txt:
        * platform/gtk/fast/dom/Window/window-properties-expected.txt:
        * platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt: Added.
        * platform/gtk/fast/dom/prototype-inheritance-2-expected.txt: Added.
        * platform/gtk/fast/dom/prototype-inheritance-expected.txt: Added.
        * platform/gtk/fast/js/global-constructors-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Needs eventSender.scalePageBy()
hamaji@chromium.org [Thu, 4 Aug 2011 11:24:36 +0000 (11:24 +0000)]
[Chromium] Needs eventSender.scalePageBy()
https://bugs.webkit.org/show_bug.cgi?id=58013

Unreviewed chromium test_expectations.txt update

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMediaStream API: Rename StreamEvent to MediaStreamEvent
commit-queue@webkit.org [Thu, 4 Aug 2011 10:07:10 +0000 (10:07 +0000)]
MediaStream API: Rename StreamEvent to MediaStreamEvent
https://bugs.webkit.org/show_bug.cgi?id=65669

Patch by Tommy Widenflycht <tommyw@google.com> on 2011-08-04
Reviewed by Tony Gentilcore.

* CMakeLists.txt:
* CodeGenerators.pri:
* DerivedSources.cpp:
* DerivedSources.make:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSEventCustom.cpp:
(WebCore::toJS):
* bindings/v8/custom/V8EventCustom.cpp:
(WebCore::toV8):
* dom/DOMAllInOne.cpp:
* dom/Event.cpp:
(WebCore::Event::isMediaStreamEvent):
* dom/Event.h:
* p2p/MediaStreamEvent.cpp: Renamed from Source/WebCore/dom/StreamEvent.cpp.
(WebCore::MediaStreamEvent::create):
(WebCore::MediaStreamEvent::MediaStreamEvent):
(WebCore::MediaStreamEvent::~MediaStreamEvent):
(WebCore::MediaStreamEvent::initMediaStreamEvent):
(WebCore::MediaStreamEvent::stream):
* p2p/MediaStreamEvent.h: Renamed from Source/WebCore/dom/StreamEvent.h.
(WebCore::MediaStreamEvent::isMediaStreamEvent):
* p2p/MediaStreamEvent.idl: Renamed from Source/WebCore/dom/StreamEvent.idl.
* p2p/PeerConnection.cpp:
(WebCore::PeerConnection::dispatchStreamEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoIndexedDB: Fix index data invalidation bugs.
hans@chromium.org [Thu, 4 Aug 2011 09:32:25 +0000 (09:32 +0000)]
IndexedDB: Fix index data invalidation bugs.
https://bugs.webkit.org/show_bug.cgi?id=65547

Reviewed by Tony Chang.

Source/WebCore:

The function that checks whether a key exists in an index failed
to check whether that key was still valid or not.

Deleting a record from an object store must also delete its exists
entry, thus invalidating index keys pointing to that record.

Test: storage/indexeddb/index-unique.html

* storage/IDBLevelDBBackingStore.cpp:
(WebCore::IDBLevelDBBackingStore::deleteObjectStoreRecord):
(WebCore::findKeyInIndex):
(WebCore::IDBLevelDBBackingStore::getPrimaryKeyViaIndex):
(WebCore::IDBLevelDBBackingStore::keyExistsInIndex):
(WebCore::CursorOptions::IndexKeyCursorImpl::loadCurrentRow):

LayoutTests:

Add layout test to verify that update object store data causes old
index data to be invalidated.

* storage/indexeddb/index-unique.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMove PODIntervalTree to Source/WebCore/platform
commit-queue@webkit.org [Thu, 4 Aug 2011 09:10:31 +0000 (09:10 +0000)]
Move PODIntervalTree to Source/WebCore/platform
https://bugs.webkit.org/show_bug.cgi?id=65667

It seems the files were not part of any project, so no project files were modified.

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-08-04
Reviewed by Adam Barth.

No new tests, just moving files from one folder to the other.

* platform/PODArena.h: Renamed from Source/WebCore/platform/graphics/gpu/PODArena.h.
(WebCore::PODArena::Allocator::~Allocator):
(WebCore::PODArena::FastMallocAllocator::create):
(WebCore::PODArena::FastMallocAllocator::allocate):
(WebCore::PODArena::FastMallocAllocator::free):
(WebCore::PODArena::FastMallocAllocator::FastMallocAllocator):
(WebCore::PODArena::create):
(WebCore::PODArena::allocateObject):
(WebCore::PODArena::~PODArena):
(WebCore::PODArena::PODArena):
(WebCore::PODArena::minAlignment):
(WebCore::PODArena::allocateBase):
(WebCore::PODArena::roundUp):
(WebCore::PODArena::Chunk::Chunk):
(WebCore::PODArena::Chunk::~Chunk):
(WebCore::PODArena::Chunk::allocate):
* platform/PODInterval.h: Renamed from Source/WebCore/platform/graphics/gpu/PODInterval.h.
(WebCore::PODInterval::PODInterval):
(WebCore::PODInterval::low):
(WebCore::PODInterval::high):
(WebCore::PODInterval::data):
(WebCore::PODInterval::overlaps):
(WebCore::PODInterval::operator<):
(WebCore::PODInterval::operator==):
(WebCore::PODInterval::maxHigh):
(WebCore::PODInterval::setMaxHigh):
(WebCore::PODInterval::toString):
* platform/PODIntervalTree.h: Renamed from Source/WebCore/platform/graphics/gpu/PODIntervalTree.h.
(WebCore::PODIntervalTree::PODIntervalTree):
(WebCore::PODIntervalTree::allOverlaps):
(WebCore::PODIntervalTree::createInterval):
(WebCore::PODIntervalTree::checkInvariants):
(WebCore::PODIntervalTree::init):
(WebCore::PODIntervalTree::searchForOverlapsFrom):
(WebCore::PODIntervalTree::updateNode):
(WebCore::PODIntervalTree::checkInvariantsFromNode):
* platform/PODRedBlackTree.h: Renamed from Source/WebCore/platform/graphics/gpu/PODRedBlackTree.h.
(WebCore::PODRedBlackTree::Visitor::~Visitor):
(WebCore::PODRedBlackTree::PODRedBlackTree):
(WebCore::PODRedBlackTree::~PODRedBlackTree):
(WebCore::PODRedBlackTree::add):
(WebCore::PODRedBlackTree::remove):
(WebCore::PODRedBlackTree::contains):
(WebCore::PODRedBlackTree::visitInorder):
(WebCore::PODRedBlackTree::size):
(WebCore::PODRedBlackTree::setNeedsFullOrderingComparisons):
(WebCore::PODRedBlackTree::checkInvariants):
(WebCore::PODRedBlackTree::dump):
(WebCore::PODRedBlackTree::setVerboseDebugging):
(WebCore::PODRedBlackTree::Node::Node):
(WebCore::PODRedBlackTree::Node::~Node):
(WebCore::PODRedBlackTree::Node::color):
(WebCore::PODRedBlackTree::Node::setColor):
(WebCore::PODRedBlackTree::Node::data):
(WebCore::PODRedBlackTree::Node::copyFrom):
(WebCore::PODRedBlackTree::Node::left):
(WebCore::PODRedBlackTree::Node::setLeft):
(WebCore::PODRedBlackTree::Node::right):
(WebCore::PODRedBlackTree::Node::setRight):
(WebCore::PODRedBlackTree::Node::parent):
(WebCore::PODRedBlackTree::Node::setParent):
(WebCore::PODRedBlackTree::root):
(WebCore::PODRedBlackTree::updateNode):
(WebCore::PODRedBlackTree::treeSearch):
(WebCore::PODRedBlackTree::treeSearchNormal):
(WebCore::PODRedBlackTree::treeSearchFullComparisons):
(WebCore::PODRedBlackTree::treeInsert):
(WebCore::PODRedBlackTree::treeSuccessor):
(WebCore::PODRedBlackTree::treeMinimum):
(WebCore::PODRedBlackTree::propagateUpdates):
(WebCore::PODRedBlackTree::leftRotate):
(WebCore::PODRedBlackTree::rightRotate):
(WebCore::PODRedBlackTree::insertNode):
(WebCore::PODRedBlackTree::deleteFixup):
(WebCore::PODRedBlackTree::deleteNode):
(WebCore::PODRedBlackTree::visitInorderImpl):
(WebCore::PODRedBlackTree::Counter::Counter):
(WebCore::PODRedBlackTree::Counter::visit):
(WebCore::PODRedBlackTree::Counter::count):
(WebCore::PODRedBlackTree::checkInvariantsFromNode):
(WebCore::PODRedBlackTree::logIfVerbose):
(WebCore::PODRedBlackTree::dumpFromNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoLayout Test fast/box-shadow/box-shadow-clipped-slices.html is failing
hamaji@chromium.org [Thu, 4 Aug 2011 08:52:58 +0000 (08:52 +0000)]
Layout Test fast/box-shadow/box-shadow-clipped-slices.html is failing
https://bugs.webkit.org/show_bug.cgi?id=65666

Chromium test_expectations.txt update

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Needs eventSender.scalePageBy()
hamaji@chromium.org [Thu, 4 Aug 2011 08:39:30 +0000 (08:39 +0000)]
[Chromium] Needs eventSender.scalePageBy()
https://bugs.webkit.org/show_bug.cgi?id=58013

Chromium test rebaselining

* platform/chromium-gpu-win/compositing/scaling/tiled-layer-recursion-expected.png: Added.
* platform/chromium-mac-leopard/compositing/scaling/tiled-layer-recursion-expected.png: Added.
* platform/chromium-mac/compositing/scaling/tiled-layer-recursion-expected.png: Added.
* platform/chromium-win/compositing/scaling/tiled-layer-recursion-expected.png: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAnother subtle bug due to lack of testing in main.js. :(
abarth@webkit.org [Thu, 4 Aug 2011 07:56:34 +0000 (07:56 +0000)]
Another subtle bug due to lack of testing in main.js.  :(

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTest progression after <http://trac.webkit.org/changeset/92341>.
abarth@webkit.org [Thu, 4 Aug 2011 07:52:12 +0000 (07:52 +0000)]
Test progression after <trac.webkit.org/changeset/92341>.

* platform/chromium-mac/fast/dom/Element/scale-page-client-rects-expected.txt:
* platform/chromium-mac/fast/dom/Range/scale-page-client-rects-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdate baselines after <http://trac.webkit.org/changeset/92340>.
abarth@webkit.org [Thu, 4 Aug 2011 07:49:12 +0000 (07:49 +0000)]
Update baselines after <trac.webkit.org/changeset/92340>.

* platform/chromium-mac/fast/box-shadow/inset-box-shadows-expected.png:
* platform/chromium-mac/fast/repaint/shadow-multiple-horizontal-expected.png:
* platform/chromium-mac/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
* platform/chromium-mac/fast/repaint/shadow-multiple-strict-vertical-expected.png:
* platform/chromium-mac/fast/repaint/shadow-multiple-vertical-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix types. Sadly, main.js has no test coverage. (I need to think
abarth@webkit.org [Thu, 4 Aug 2011 07:41:57 +0000 (07:41 +0000)]
Fix types.  Sadly, main.js has no test coverage.  (I need to think
about how to test this part of the code.)

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agobugzilla.js is missing unit tests
abarth@webkit.org [Thu, 4 Aug 2011 07:14:58 +0000 (07:14 +0000)]
bugzilla.js is missing unit tests
https://bugs.webkit.org/show_bug.cgi?id=65656

Reviewed by Adam Roben.

Testing makes perfect.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/bugzilla_unittests.js: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js:
(NetworkSimulator.prototype.runTest.get if):
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd missing license blocks to garden-o-matic
abarth@webkit.org [Thu, 4 Aug 2011 07:14:24 +0000 (07:14 +0000)]
Add missing license blocks to garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=65654

Reviewed by Dimitri Glazkov.

This patch is entirely boilerplate.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agogarden-o-matic needs a way to mock out the network
abarth@webkit.org [Thu, 4 Aug 2011 07:13:56 +0000 (07:13 +0000)]
garden-o-matic needs a way to mock out the network
https://bugs.webkit.org/show_bug.cgi?id=65653

Reviewed by Dimitri Glazkov.

This patch introduces the net module, which is a useful mock point for
abstracting away the network.  Future patches will use this
infrastructure to test some currently untested code.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net.js: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js: Added.
(NetworkSimulator):
(NetworkSimulator.prototype.scheduleCallback):
(NetworkSimulator.prototype.runTest):
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
* Scripts/webkitpy/tool/servers/gardeningserver.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoThis test triggers a crasher on some ports. The crasher is filed already.
abarth@webkit.org [Thu, 4 Aug 2011 07:10:25 +0000 (07:10 +0000)]
This test triggers a crasher on some ports.  The crasher is filed already.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAn element with role=textbox should have settable AXValue unless read-only
commit-queue@webkit.org [Thu, 4 Aug 2011 06:35:56 +0000 (06:35 +0000)]
An element with role=textbox should have settable AXValue unless read-only
https://bugs.webkit.org/show_bug.cgi?id=65664

Patch by Alice Boxhall <aboxhall@chromium.org> on 2011-08-03
Reviewed by Chris Fleizach.

Source/WebCore:

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::canSetValueAttribute):
Return true for non-native text field with aria-readonly not set.

LayoutTests:

* accessibility/aria-readonly-expected.txt:
* accessibility/aria-readonly.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUse failureInfo more pervasively in garden-o-matic
abarth@webkit.org [Thu, 4 Aug 2011 06:08:47 +0000 (06:08 +0000)]
Use failureInfo more pervasively in garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=65650

Reviewed by Dimitri Glazkov.

These three variable appears in concert together many places.  This
patch unifies the remaining uses into being failureInfo objects, which
saves some marshalling.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Windows] Fix build without ENABLE_VIDEO.
tkent@chromium.org [Thu, 4 Aug 2011 05:34:55 +0000 (05:34 +0000)]
[Windows] Fix build without ENABLE_VIDEO.

* WebView.cpp:
(WebView::enterFullscreenForNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoClean up value clamping in CSSStyleSelector.
macpherson@chromium.org [Thu, 4 Aug 2011 04:40:11 +0000 (04:40 +0000)]
Clean up value clamping in CSSStyleSelector.
https://bugs.webkit.org/show_bug.cgi?id=65588

Reviewed by Darin Adler.

No new tests / trivial code cleanup only.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
Replace (unsigned int)primitiveValue->getDoubleValue() with primtiveValue->getValue<unsigned>() for correct clamping.
Replace clampToInteger(primitiveValue->getDoubleValue()) with primitiveValue->getIntValue().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agogarden-o-matic should be able to update expecations from the details pane
abarth@webkit.org [Thu, 4 Aug 2011 04:38:32 +0000 (04:38 +0000)]
garden-o-matic should be able to update expecations from the details pane
https://bugs.webkit.org/show_bug.cgi?id=65648

Reviewed by Dimitri Glazkov.

The new button queues up the updates, which get executed all at once.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix incorrect checks for HTMLMediaElement
tkent@chromium.org [Thu, 4 Aug 2011 04:38:01 +0000 (04:38 +0000)]
Fix incorrect checks for HTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=65590

Reviewed by Dimitri Glazkov.

<video> and <audio> can be an HTMLElement instance instead of
HTMLMediaElement if MediaPlayer::isAvailable() returns false or
the media feature is disabled at runtime.

Source/WebCore:

* html/HTMLSourceElement.cpp:
(WebCore::HTMLSourceElement::insertedIntoTree):
(WebCore::HTMLSourceElement::willRemove):
* html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::insertedIntoTree):
(WebCore::HTMLTrackElement::willRemove):
* html/shadow/MediaControlElements.cpp:
(WebCore::toParentMediaElement):
* page/FrameView.cpp:
(WebCore::FrameView::updateWidget):
* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::paintMediaMuteButton):
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::getMediaElementFromRenderObject):
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintMediaSliderTrack):
* rendering/RenderThemeWinCE.cpp:
(WebCore::mediaElementParent):

Source/WebKit/mac:

* WebView/WebFullScreenController.mm:
(-[WebFullScreenController _isAnyMoviePlaying]):

Source/WebKit/win:

* WebView.cpp:
(WebView::enterFullscreenForNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd UI to garden-o-matic for updating expectations
abarth@webkit.org [Thu, 4 Aug 2011 04:16:47 +0000 (04:16 +0000)]
Add UI to garden-o-matic for updating expectations
https://bugs.webkit.org/show_bug.cgi?id=65644

Reviewed by Dimitri Glazkov.

The patch plumbs the UI back to the gardening server, but the gardening
server endpoint is just a stub at this point.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
* Scripts/webkitpy/tool/servers/gardeningserver.py:
* Scripts/webkitpy/tool/servers/reflectionhandler.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUse of AVFoundation should default to off on Windows
jeffm@apple.com [Thu, 4 Aug 2011 03:54:57 +0000 (03:54 +0000)]
Use of AVFoundation should default to off on Windows
https://bugs.webkit.org/show_bug.cgi?id=65660

Reviewed by Darin Adler.

* Shared/WebPreferencesStore.h: Change default value for AVFoundationEnabled to false on Windows, it's still true on other platforms.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agogarden-o-matic details view should queue rebaselines for later execution
abarth@webkit.org [Thu, 4 Aug 2011 03:02:54 +0000 (03:02 +0000)]
garden-o-matic details view should queue rebaselines for later execution
https://bugs.webkit.org/show_bug.cgi?id=65636

Reviewed by Dimitri Glazkov.

This patch doesn't contain any confirmation UI, but we'll probably want
that at some point.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChromium Mac: Make ScrollbarOverlayUtilitiesChromiumMac.h c++ compatible
commit-queue@webkit.org [Thu, 4 Aug 2011 02:35:41 +0000 (02:35 +0000)]
Chromium Mac: Make ScrollbarOverlayUtilitiesChromiumMac.h c++ compatible
https://bugs.webkit.org/show_bug.cgi?id=65659

Patch by Sailesh Agrawal <sail@chromium.org> on 2011-08-03
Reviewed by James Robinson.

ScrollbarOverlayUtilitiesChromiumMac.h couldn't be included from pure c++ code because it used NSInteger. I fixed this by checking for __OBJC__ before using NSInteger.

Currently no pure c++ files are including ScrollbarOverlayUtilitiesChromiumMac.h but this will change in future patches from jam@chromium.org.

* platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h:
* platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm:
(wkScrollbarPainterControllerStyle):
(wkSetScrollbarPainterControllerStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSupport cast between CSSPrimitiveValue and EBoxSizing, use in CSSStyleSelector.
macpherson@chromium.org [Thu, 4 Aug 2011 02:09:19 +0000 (02:09 +0000)]
Support cast between CSSPrimitiveValue and EBoxSizing, use in CSSStyleSelector.
https://bugs.webkit.org/show_bug.cgi?id=65657

Reviewed by Simon Fraser.

No new tests / refactoring only.

* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
Implement cast from EBoxSizing.
(WebCore::CSSPrimitiveValue::operator EBoxSizing):
Implement cast to EBoxSizing.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
Use appropriate macro to simplify code using cast.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoImplement EventSender.scalePageBy()
commit-queue@webkit.org [Thu, 4 Aug 2011 02:01:31 +0000 (02:01 +0000)]
Implement EventSender.scalePageBy()
https://bugs.webkit.org/show_bug.cgi?id=58013

Patch by Kentaro Hara <haraken@google.com> on 2011-08-03
Reviewed by Darin Fisher.

Implemented EventSender.scalePageBy(f, x, y), which scales a page by a factor of f
and then sets a scroll position to (x, y). Enabled the tests that had been waiting
for the implementation of EventSender.scalePageBy(f, x, y).

Source/WebKit/chromium:

Tests: compositing/scaling/tiled-layer-recursion.html
       fast/repaint/scale-page-shrink.html
       fast/dom/Element/scale-page-client-rects.html
       fast/dom/Range/scale-page-client-rects.html
       fast/events/scroll-in-scaled-page-with-overflow-hidden.html
       fast/dom/Element/scale-page-bounding-client-rect.html
       fast/dom/Range/scale-page-bounding-client-rect.html

* public/WebView.h:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::scalePage): A wrapper method for scalePage() in WebCore.
* src/WebViewImpl.h:

Tools:

Tests: compositing/scaling/tiled-layer-recursion.html
       fast/repaint/scale-page-shrink.html
       fast/dom/Element/scale-page-client-rects.html
       fast/dom/Range/scale-page-client-rects.html
       fast/events/scroll-in-scaled-page-with-overflow-hidden.html
       fast/dom/Element/scale-page-bounding-client-rect.html
       fast/dom/Range/scale-page-bounding-client-rect.html

* DumpRenderTree/chromium/EventSender.cpp:
(EventSender::EventSender): Added bindings for scalePageBy().
(EventSender::scalePageBy): A wrapper method for scalePage() in WebView.
* DumpRenderTree/chromium/EventSender.h:
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::resetTestController): Resets the scale factor to 1.

LayoutTests:

* platform/chromium-linux/compositing/scaling/tiled-layer-recursion-expected.png: Added.
* platform/chromium-linux/fast/repaint/scale-page-shrink-expected.png: Added.
* platform/chromium-linux/fast/repaint/scale-page-shrink-expected.txt: Added.
* platform/chromium-mac/fast/dom/Element/scale-page-bounding-client-rect-expected.txt: Removed.
* platform/chromium-mac/fast/dom/Range/scale-page-bounding-client-rect-expected.txt: Removed.
* platform/chromium-win/fast/dom/Element/scale-page-bounding-client-rect-expected.txt: Removed.
* platform/chromium-win/fast/dom/Element/scale-page-client-rects-expected.txt: Removed.
* platform/chromium-win/fast/dom/Range/scale-page-bounding-client-rect-expected.txt: Removed.
* platform/chromium-win/fast/dom/Range/scale-page-client-rects-expected.txt: Removed.
* platform/chromium/test_expectations.txt: Enabled one test. Enabled two tests for chromium-linux.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<http://webkit.org/b/65006> Draw rectangular box shadow for elements with border...
joepeck@webkit.org [Thu, 4 Aug 2011 01:51:07 +0000 (01:51 +0000)]
<webkit.org/b/65006> Draw rectangular box shadow for elements with border-radius if no corners are visible

Patch by Ian Henderson <ianh@apple.com> on 2011-08-03
Reviewed by Simon Fraser.

Source/WebCore:

Change "unroundClippedCorners" to "allCornersClippedOut" and use it to
determine when the corners' influence affects the blurred shadow in
the current drawing region.

Test: fast/box-shadow/box-shadow-clipped-slices.html

* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::paintBoxShadow): Pass PaintInfo through to
RenderBoxModelObject::paintBoxShadow.
(WebCore::InlineFlowBox::paintBoxDecorations): Ditto.
* rendering/InlineFlowBox.h:
* rendering/RenderBox.cpp:
(WebCore::RenderBox::paintBoxDecorations): Ditto.
* rendering/RenderBoxModelObject.cpp:
(WebCore::allCornersClippedOut): Determines whether the bounding rects
for any of the given rounded rect's corners intersects the clip rect.
(WebCore::RenderBoxModelObject::paintBorder): Instead of "unrounding"
any corner outside the clip rect, unround all corners at once, and
only if they are all outside the clip rect.
(WebCore::RenderBoxModelObject::paintBoxShadow): Determine whether any
corner will influence shadow drawing using allCornersClippedOut on the
influenceRect, whose corners extend past the fillRect's corners by the
blur radius and inside the fillRect's corners by the blur radius.
* rendering/RenderBoxModelObject.h:
* rendering/RenderFieldset.cpp:
(WebCore::RenderFieldset::paintBoxDecorations): Pass PaintInfo into
RenderBoxModelObject::paintBoxShadow.
* rendering/RenderTable.cpp:
(WebCore::RenderTable::paintBoxDecorations): Ditto.
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::paintBoxDecorations): Ditto.

LayoutTests:

* fast/box-shadow/box-shadow-clipped-slices.html: Added.
* platform/mac/fast/box-shadow/box-shadow-clipped-slices-expected.png: Added.
* platform/mac/fast/box-shadow/box-shadow-clipped-slices-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] fast/dom/resource-locations-in-created-html-document.html fails on win32
commit-queue@webkit.org [Thu, 4 Aug 2011 01:44:14 +0000 (01:44 +0000)]
[Chromium] fast/dom/resource-locations-in-created-html-document.html fails on win32
https://bugs.webkit.org/show_bug.cgi?id=65521

Patch by Noel Gordon <noel.gordon@gmail.com> on 2011-08-03
Reviewed by Adam Barth.

file: scheme URI paths on Windows include the disk drive reference (C: for example).
Refer to http://blogs.msdn.com/b/ie/archive/2006/12/06/file-uris-in-windows.aspx.

* fast/dom/resource-locations-in-created-html-document.html:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRevert an erroneous rebaseline from r92315.
rniwa@webkit.org [Thu, 4 Aug 2011 01:41:29 +0000 (01:41 +0000)]
Revert an erroneous rebaseline from r92315.

* fast/dom/navigator-detached-no-crash-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt][Texmap][REGRESSION] http://webkit.org/blog-files/transform-style.html doesn...
noam.rosenthal@nokia.com [Thu, 4 Aug 2011 00:22:21 +0000 (00:22 +0000)]
[Qt][Texmap][REGRESSION] webkit.org/blog-files/transform-style.html doesn't show composited content
https://bugs.webkit.org/show_bug.cgi?id=65629

Reviewed by Benjamin Poulain.

Some non-ES2 initialization was wrongfully #ifdefed in CPU(X86) and thus compiled-out.
When put it in the correct #ifdef, composited layers which require an intermediate buffer
work again.

No new tests. Existing opacity tests in LayoutTests/compositing test this.

* platform/graphics/opengl/TextureMapperGL.cpp:
(WebCore::BitmapTextureGL::bind):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChromium Windows and Linux rebaselines after r92330.
rniwa@webkit.org [Thu, 4 Aug 2011 00:16:43 +0000 (00:16 +0000)]
Chromium Windows and Linux rebaselines after r92330.

* platform/chromium-win/editing/pasteboard/paste-pre-001-expected.txt: Removed.
* platform/chromium-win/editing/pasteboard/paste-pre-002-expected.txt: Removed.
* platform/chromium-win/editing/pasteboard/paste-text-011-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRename WEBKIT_API to WEBKIT_EXPORT in check-webkit-style.
levin@chromium.org [Wed, 3 Aug 2011 23:53:54 +0000 (23:53 +0000)]
Rename WEBKIT_API to WEBKIT_EXPORT in check-webkit-style.
https://bugs.webkit.org/show_bug.cgi?id=65652

Reviewed by Adam Barth.

* Scripts/webkitpy/style/checkers/cpp.py:
* Scripts/webkitpy/style/checkers/cpp_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBring some order to FeatureDefines.xcconfig to make it easier to follow.
mrowe@apple.com [Wed, 3 Aug 2011 23:51:03 +0000 (23:51 +0000)]
Bring some order to FeatureDefines.xcconfig to make it easier to follow.

Reviewed by Sam Weinig.

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoClean up FeatureDefines.xcconfig to remove some unnecessary conditional settings
mrowe@apple.com [Wed, 3 Aug 2011 23:50:50 +0000 (23:50 +0000)]
Clean up FeatureDefines.xcconfig to remove some unnecessary conditional settings

Reviewed by Dave Kilzer.

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Fix issue where switching composited tabs evicts root textures
enne@google.com [Wed, 3 Aug 2011 23:43:15 +0000 (23:43 +0000)]
[chromium] Fix issue where switching composited tabs evicts root textures
https://bugs.webkit.org/show_bug.cgi?id=65562

Reviewed by James Robinson.

LayerTilerChromium::protectTileTextures was hard-coding texture sizes
and texture formats. Because this didn't always match textures' actual
sizes and formats, they weren't getting protected during eviction.

* platform/graphics/chromium/LayerTilerChromium.cpp:
(WebCore::LayerTilerChromium::protectTileTextures):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoselect-all, copy, paste of specialAncestorElements (e.g. pre, h1, etc) nests the...
rniwa@webkit.org [Wed, 3 Aug 2011 23:42:25 +0000 (23:42 +0000)]
select-all, copy, paste of specialAncestorElements (e.g. pre, h1, etc) nests the element inside itself
https://bugs.webkit.org/show_bug.cgi?id=26483

Reviewed by Enrica Casucci.

Source/WebCore:

The bug was caused by WebKit serializing pre, h1, etc... to retain structure and appearance when copying
rich content and pasting did not remove such nodes wrapping the copied contents.

Fixed the bug by extending r81887 and r83322 to remove those elements from where WebKit pastes into.

Test: editing/pasteboard/copy-paste-text-in-h1.html

* editing/ReplaceSelectionCommand.cpp:
(WebCore::nodeHasAttributesToPreserve): Extracted from isInlineNodeWithStyle.
(WebCore::isInlineNodeWithStyle): Calls nodeHasAttributesToPreserve.
(WebCore::ReplaceSelectionCommand::doApply): Calls ancestorToRetainStructureAndAppearance.
Remove nodes copied by ancestorToRetainStructureAndAppearance at insertionPos before pasting the fragment.
* editing/markup.cpp:
(WebCore::ancestorToRetainStructureAndAppearance): Takes ShouldIncludeParagraphSeparators.
* editing/markup.h:

LayoutTests:

* editing/pasteboard/5065605-expected.txt:
* editing/pasteboard/copy-paste-text-in-h1-expected.txt: Added.
* editing/pasteboard/copy-paste-text-in-h1.html: Added.
* editing/pasteboard/display-block-on-spans-expected.txt:
* editing/pasteboard/paste-pre-001-expected.txt:
* editing/pasteboard/paste-pre-002-expected.txt:
* editing/pasteboard/paste-text-011-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoJSC GC heap size improvement breaks build on some platforms due to
fpizlo@apple.com [Wed, 3 Aug 2011 23:35:03 +0000 (23:35 +0000)]
JSC GC heap size improvement breaks build on some platforms due to
unused parameter
https://bugs.webkit.org/show_bug.cgi?id=65641

Reviewed by Darin Adler.

Fix build on non-x86 platforms, by ensuring that the relevant
parameter always appears to be used even when it isn't.

* heap/Heap.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove LegacyDefaultOptionalArguments flag from Console.idl
commit-queue@webkit.org [Wed, 3 Aug 2011 23:31:50 +0000 (23:31 +0000)]
Remove LegacyDefaultOptionalArguments flag from Console.idl
https://bugs.webkit.org/show_bug.cgi?id=65569

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-03
Reviewed by Adam Barth.

No new tests, all existing tests pass.

* page/Console.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove LegacyDefaultOptionalArguments flag from HTML DOM IDL files
commit-queue@webkit.org [Wed, 3 Aug 2011 23:20:58 +0000 (23:20 +0000)]
Remove LegacyDefaultOptionalArguments flag from HTML DOM IDL files
https://bugs.webkit.org/show_bug.cgi?id=65338

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-03
Reviewed by Adam Barth.

Source/WebCore:

* html/DOMFormData.idl:
* html/DOMTokenList.idl:
* html/DOMURL.idl:
* html/HTMLAllCollection.idl:
* html/HTMLAnchorElement.idl:
* html/HTMLAudioElement.idl:
* html/HTMLButtonElement.idl:
* html/HTMLCanvasElement.idl:
* html/HTMLCollection.idl:
* html/HTMLDivElement.idl:
* html/HTMLDocument.idl:
* html/HTMLElement.idl:
* html/HTMLFieldSetElement.idl:
* html/HTMLInputElement.idl:
* html/HTMLKeygenElement.idl:
* html/HTMLMediaElement.idl:
* html/HTMLObjectElement.idl:
* html/HTMLOptionsCollection.idl:
* html/HTMLOutputElement.idl:
* html/HTMLSelectElement.idl:
* html/HTMLTableElement.idl:
* html/HTMLTableRowElement.idl:
* html/HTMLTableSectionElement.idl:
* html/HTMLTextAreaElement.idl:
* html/HTMLVideoElement.idl:
* html/TimeRanges.idl:

LayoutTests:

* fast/files/create-blob-url-crash-expected.txt:
* fast/files/create-blob-url-crash.html:
* fast/files/revoke-blob-url-expected.txt:
* fast/files/revoke-blob-url.html:
* fast/forms/ValidityState-customError-expected.txt:
* fast/forms/ValidityState-customError.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdding Filip Pizlo to committer list.
fpizlo@apple.com [Wed, 3 Aug 2011 23:19:41 +0000 (23:19 +0000)]
Adding Filip Pizlo to committer list.

Unreviewed.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake atomic XML token
jpfau@apple.com [Wed, 3 Aug 2011 23:18:42 +0000 (23:18 +0000)]
Make atomic XML token
https://bugs.webkit.org/show_bug.cgi?id=65639

Reviewed by Adam Barth.

Create a shared AtomicMarkupTokenBase that is shared by AtomicHTMLToken and the new AtomicXMLToken

* html/parser/HTMLToken.h:
(WebCore::HTMLToken::setForceQuirks):
(WebCore::AtomicHTMLToken::AtomicHTMLToken):
(WebCore::AtomicHTMLToken::forceQuirks):
* html/parser/HTMLTokenizer.cpp:
(WebCore::::nameForAttribute):
(WebCore::::usesName):
(WebCore::::usesAttributes):
* xml/parser/MarkupTokenBase.h:
(WebCore::AtomicMarkupTokenBase::AtomicMarkupTokenBase):
(WebCore::AtomicMarkupTokenBase::type):
(WebCore::AtomicMarkupTokenBase::name):
(WebCore::AtomicMarkupTokenBase::setName):
(WebCore::AtomicMarkupTokenBase::selfClosing):
(WebCore::AtomicMarkupTokenBase::getAttributeItem):
(WebCore::AtomicMarkupTokenBase::attributes):
(WebCore::AtomicMarkupTokenBase::takeAtributes):
(WebCore::AtomicMarkupTokenBase::characters):
(WebCore::AtomicMarkupTokenBase::comment):
(WebCore::AtomicMarkupTokenBase::publicIdentifier):
(WebCore::AtomicMarkupTokenBase::systemIdentifier):
(WebCore::::initializeAttributes):
* xml/parser/XMLToken.h:
(WebCore::AtomicXMLToken::AtomicXMLToken):
(WebCore::AtomicXMLToken::prefix):
(WebCore::AtomicXMLToken::target):
(WebCore::AtomicXMLToken::data):
(WebCore::AtomicXMLToken::xmlVersion):
(WebCore::AtomicXMLToken::xmlStandalone):
* xml/parser/XMLTokenizer.cpp:
(WebCore::::nameForAttribute):
(WebCore::::usesName):
(WebCore::::usesAttributes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd "optimize-expectations" command to webkit-patch.
dglazkov@chromium.org [Wed, 3 Aug 2011 23:03:32 +0000 (23:03 +0000)]
Add "optimize-expectations" command to webkit-patch.
https://bugs.webkit.org/show_bug.cgi?id=65633

For now, only operates on Chromium test_expectations.txt and does not report errors/warnings.

Reviewed by Adam Barth.

* Scripts/webkitpy/tool/commands/__init__.py: Added command.
* Scripts/webkitpy/tool/commands/expectations.py: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove LegacyDefaultOptionalArguments flag from geolocation IDL files
commit-queue@webkit.org [Wed, 3 Aug 2011 23:01:45 +0000 (23:01 +0000)]
Remove LegacyDefaultOptionalArguments flag from geolocation IDL files
https://bugs.webkit.org/show_bug.cgi?id=65355

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-03
Reviewed by Adam Barth.

No new tests, all existing tests pass.

* page/Geolocation.idl:
* page/PositionCallback.idl:
* page/PositionErrorCallback.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-08-03 Darin Fisher <darin@chromium.org>
darin@chromium.org [Wed, 3 Aug 2011 22:59:33 +0000 (22:59 +0000)]
2011-08-03  Darin Fisher  <darin@chromium.org>

        [Chromium] Rename WEBKIT_API to WEBKIT_EXPORT.
        https://bugs.webkit.org/show_bug.cgi?id=65649

        Reviewed by Adam Barth.

        * README:
        * public/WebAccessibilityCache.h:
        * public/WebAccessibilityObject.h:
        * public/WebArrayBufferView.h:
        * public/WebAttribute.h:
        * public/WebAudioBus.h:
        * public/WebBindings.h:
        * public/WebBlobData.h:
        * public/WebBlobRegistry.h:
        * public/WebCString.h:
        * public/WebCache.h:
        * public/WebColor.h:
        * public/WebCommon.h:
        * public/WebCrossOriginPreflightResultCache.h:
        * public/WebDOMEvent.h:
        * public/WebDOMEventListener.h:
        * public/WebDOMMouseEvent.h:
        * public/WebDOMMutationEvent.h:
        * public/WebDOMStringList.h:
        * public/WebData.h:
        * public/WebDatabase.h:
        * public/WebDevToolsAgent.h:
        * public/WebDevToolsFrontend.h:
        * public/WebDeviceOrientationClientMock.h:
        * public/WebDeviceOrientationController.h:
        * public/WebDocument.h:
        * public/WebDocumentType.h:
        * public/WebDragData.h:
        * public/WebElement.h:
        * public/WebFont.h:
        * public/WebFontCache.h:
        * public/WebFormControlElement.h:
        * public/WebFormElement.h:
        * public/WebFrame.h:
        * public/WebGeolocationClientMock.h:
        * public/WebGeolocationController.h:
        * public/WebGeolocationError.h:
        * public/WebGeolocationPermissionRequest.h:
        * public/WebGeolocationPermissionRequestManager.h:
        * public/WebGeolocationPosition.h:
        * public/WebGlyphCache.h:
        * public/WebHTTPBody.h:
        * public/WebHTTPLoadInfo.h:
        * public/WebHistoryItem.h:
        * public/WebIDBDatabaseError.h:
        * public/WebIDBFactory.h:
        * public/WebIDBKey.h:
        * public/WebIDBKeyPath.h:
        * public/WebIDBKeyRange.h:
        * public/WebImage.h:
        * public/WebImageDecoder.h:
        * public/WebInputElement.h:
        * public/WebInputEvent.h:
        * public/WebKit.h:
        * public/WebLabelElement.h:
        * public/WebMediaElement.h:
        * public/WebNamedNodeMap.h:
        * public/WebNetworkStateNotifier.h:
        * public/WebNode.h:
        * public/WebNodeCollection.h:
        * public/WebNodeList.h:
        * public/WebNotification.h:
        * public/WebOptionElement.h:
        * public/WebPageSerializer.h:
        * public/WebPasswordFormData.h:
        * public/WebPerformance.h:
        * public/WebPluginDocument.h:
        * public/WebPopupMenu.h:
        * public/WebRange.h:
        * public/WebRegularExpression.h:
        * public/WebRuntimeFeatures.h:
        * public/WebScriptController.h:
        * public/WebScrollbar.h:
        * public/WebSearchableFormData.h:
        * public/WebSecurityOrigin.h:
        * public/WebSecurityPolicy.h:
        * public/WebSelectElement.h:
        * public/WebSerializedScriptValue.h:
        * public/WebSharedWorker.h:
        * public/WebSpeechInputControllerMock.h:
        * public/WebSpeechInputResult.h:
        * public/WebStorageEventDispatcher.h:
        * public/WebStorageNamespace.h:
        * public/WebString.h:
        * public/WebTestingSupport.h:
        * public/WebThreadSafeData.h:
        * public/WebURLLoadTiming.h:
        * public/WebURLRequest.h:
        * public/WebURLResponse.h:
        * public/WebView.h:
        * public/WebWorker.h:
        * public/gtk/WebFontInfo.h:
        * public/gtk/WebInputEventFactory.h:
        * public/linux/WebFontRenderStyle.h:
        * public/linux/WebFontRendering.h:
        * public/linux/WebRenderTheme.h:
        * public/mac/WebInputEventFactory.h:
        * public/mac/WebScreenInfoFactory.h:
        * public/mac/WebSubstringUtil.h:
        * public/win/WebInputEventFactory.h:
        * public/win/WebScreenInfoFactory.h:
        * public/x11/WebScreenInfoFactory.h:
        * tests/WebUnitTests.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove LegacyDefaultOptionalArguments flag from DOMSelection.idl
commit-queue@webkit.org [Wed, 3 Aug 2011 22:50:20 +0000 (22:50 +0000)]
Remove LegacyDefaultOptionalArguments flag from DOMSelection.idl
https://bugs.webkit.org/show_bug.cgi?id=65566

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-03
Reviewed by Adam Barth.

No new tests, all existing tests pass.

* page/DOMSelection.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove LegacyDefaultOptionalArguments flag from Location.idl
commit-queue@webkit.org [Wed, 3 Aug 2011 22:47:37 +0000 (22:47 +0000)]
Remove LegacyDefaultOptionalArguments flag from Location.idl
https://bugs.webkit.org/show_bug.cgi?id=65565

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-03
Reviewed by Darin Adler.

No new tests, all existing tests pass.

* page/Location.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChromium Mac: Fix position of search tickmarks
commit-queue@webkit.org [Wed, 3 Aug 2011 22:42:46 +0000 (22:42 +0000)]
Chromium Mac: Fix position of search tickmarks
https://bugs.webkit.org/show_bug.cgi?id=65575

This change adjusts the position of search tickmarks so that they are correctly centered.

Also, insetting the tickmark rect by 5 pixels caused tickmarks on the overlay scrollbar to look very small. I changed this to inset by 4 pixels instead. The tickmark is the same width as the overlay scrollbar which looks much better.

Patch by Sailesh Agrawal <sail@chromium.org> on 2011-08-03
Reviewed by James Robinson.

* platform/chromium/ScrollbarThemeChromiumMac.mm:
(WebCore::ScrollbarThemeChromiumMac::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Minor cleanup, remove a deprecated method.
michaeln@google.com [Wed, 3 Aug 2011 22:36:35 +0000 (22:36 +0000)]
[Chromium] Minor cleanup, remove a deprecated method.
The old WebDatabase::updateDatabaseSize method has been replaced with
updateDatabaseSize, updateSpaceAvailable, and resetSpaceAvailable.
https://bugs.webkit.org/show_bug.cgi?id=65553

Reviewed by Adam Barth.

* public/WebDatabase.h:
* src/WebDatabase.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAllow multiple bug identifiers in test expectations.
dglazkov@chromium.org [Wed, 3 Aug 2011 22:34:28 +0000 (22:34 +0000)]
Allow multiple bug identifiers in test expectations.
https://bugs.webkit.org/show_bug.cgi?id=65642

Reviewed by Adam Barth.

* Scripts/webkitpy/layout_tests/models/test_expectations.py: Tweaked to allow multiple bug ids.
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChromium Mac: Make sure scrollbars flash when web page loads
commit-queue@webkit.org [Wed, 3 Aug 2011 22:24:13 +0000 (22:24 +0000)]
Chromium Mac: Make sure scrollbars flash when web page loads
https://bugs.webkit.org/show_bug.cgi?id=65586

On slow web pages scrollbars wouldn't flash when the page was done loading. The problem was that we were flashing the scrollbar 0.1 second after the load operation had started. If the page was slow to load then we might not have scrollbars to flash. To work around this I added an extra check to make sure that we had indeed finished loading the page before flashing the scrollbars.

Patch by Sailesh Agrawal <sail@chromium.org> on 2011-08-03
Reviewed by James Robinson.

* platform/chromium/ScrollAnimatorChromiumMac.mm:
(WebCore::ScrollAnimatorChromiumMac::initialScrollbarPaintTimerFired):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove LegacyDefaultOptionalArguments flag from navigator IDL files
commit-queue@webkit.org [Wed, 3 Aug 2011 21:58:44 +0000 (21:58 +0000)]
Remove LegacyDefaultOptionalArguments flag from navigator IDL files
https://bugs.webkit.org/show_bug.cgi?id=65370

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-03
Reviewed by Adam Barth.

Source/WebCore:

* page/Navigator.idl:
* page/NavigatorUserMediaErrorCallback.idl:
* page/NavigatorUserMediaSuccessCallback.idl:

LayoutTests:

* fast/dom/navigator-detached-no-crash-expected.txt:
* platform/chromium/fast/dom/navigator-detached-no-crash-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agowebarchive/loading/missing-data.html is failing on Mac
andersca@apple.com [Wed, 3 Aug 2011 21:53:16 +0000 (21:53 +0000)]
webarchive/loading/missing-data.html is failing on Mac
https://bugs.webkit.org/show_bug.cgi?id=63507

Reviewed by Adam Barth.

When loading a main resource from a web archive, make sure that the working URL is actually
the URL of the resource, and not the URL of the web archive itself.

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::receivedFirstData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove LegacyDefaultOptionalArguments flag from DOMWindow.idl
commit-queue@webkit.org [Wed, 3 Aug 2011 21:50:48 +0000 (21:50 +0000)]
Remove LegacyDefaultOptionalArguments flag from DOMWindow.idl
https://bugs.webkit.org/show_bug.cgi?id=65353

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-03
Reviewed by Adam Barth.

No new tests, all existing tests pass.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateFunctionCallback):
* page/DOMWindow.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix Chromimum and Qt builds after r92308.
jeffm@apple.com [Wed, 3 Aug 2011 20:52:32 +0000 (20:52 +0000)]
Fix Chromimum and Qt builds after r92308.

* config.h: Don't try to include WebCoreHeaderDetection.h for Chromimum and Qt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoGenerate WebCoreHeaderDetection.h on Windows to define HAVE_AVCF
jeffm@apple.com [Wed, 3 Aug 2011 20:15:53 +0000 (20:15 +0000)]
Generate WebCoreHeaderDetection.h on Windows to define HAVE_AVCF
https://bugs.webkit.org/show_bug.cgi?id=65634

AVFoundation support on Windows will (eventually) be predicated on the
availability of AVFoundationCF headers and libraries in the WebKit Support
Libraries, so we test for the existence of one of the header files (AVCFBase.h)
to determine whether to AVCF is available.

For now, even if AVFoundationCF is available, leave WTF_USE_AVFOUNDATION off, since
it's not ready to be turned on yet (which is covered by http://webkit.org/b/65400).

Ideally, we would generate WebCoreHeaderDetection.h on all platforms so we could
include it unconditionally in WebCore's config.h, but unfortunately the Mac-only file
ExportFileGenerator.cpp depends on WTF_USE_AVFOUNDATION being set correctly, and since this
.cpp file is also generated it doesn't have access to WebCoreHeaderDetection.h.

Reviewed by Adam Roben.

No change in functionality, so new tests.

* DerivedSources.make: Add rule to generate WebCoreHeaderDetection.h to set HAVE_AVCF on Windows.
* config.h: Include WebCoreHeaderDetection.h on Windows, check for HAVE(AVCF) but always leave WTF_USE_AVFOUNDATION off on Windows for now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, fix an error in test_expectations.txt.
zmo@google.com [Wed, 3 Aug 2011 20:13:59 +0000 (20:13 +0000)]
Unreviewed, fix an error in test_expectations.txt.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, skip fast/loader/reload-zero-byte-plugin.html for now, gardener stuff.
zmo@google.com [Wed, 3 Aug 2011 19:57:34 +0000 (19:57 +0000)]
Unreviewed, skip fast/loader/reload-zero-byte-plugin.html for now, gardener stuff.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92306 268f45cc-cd09-0410-ab3c-d52691b4dbfc