timothy_horton@apple.com [Tue, 2 Dec 2014 01:49:49 +0000 (01:49 +0000)]
Try to fix the Mac build.
* WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView _close]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176618
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy_horton@apple.com [Tue, 2 Dec 2014 01:29:43 +0000 (01:29 +0000)]
Null deref under TextIndicator::createWithSelectionInFrame using find-in-page on bugzilla
https://bugs.webkit.org/show_bug.cgi?id=139164
<rdar://problem/
19107247>
Reviewed by Beth Dakin.
* page/TextIndicator.cpp:
(WebCore::TextIndicator::createWithSelectionInFrame):
Null-check the ImageBuffer in addition to the Image.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176617
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Tue, 2 Dec 2014 01:16:04 +0000 (01:16 +0000)]
Fix non-mac builds.
* wtf/IndexedIterator.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176616
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Tue, 2 Dec 2014 01:12:27 +0000 (01:12 +0000)]
[iOS] Unskip LayoutTests/dom tests
* platform/ios-simulator/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176615
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 2 Dec 2014 00:55:48 +0000 (00:55 +0000)]
Remove IWebCookieManager on Windows
https://bugs.webkit.org/show_bug.cgi?id=139144
Reviewed by Sam Weinig.
Source/WebCore:
Remove code that handles overriding the cookie storage.
* platform/network/NetworkStorageSession.h:
* platform/network/cf/NetworkStorageSessionCFNet.cpp:
(WebCore::cookieStorageOverride): Deleted.
(WebCore::overrideCookieStorage): Deleted.
(WebCore::overridenCookieStorage): Deleted.
* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::ResourceHandle::createCFURLConnection):
Source/WebKit:
Remove files.
* WebKit.vcxproj/Interfaces/Interfaces.vcxproj:
* WebKit.vcxproj/Interfaces/Interfaces.vcxproj.filters:
* WebKit.vcxproj/WebKit/WebKit.vcxproj:
* WebKit.vcxproj/WebKit/WebKit.vcxproj.filters:
Source/WebKit/win:
Remove WebCookieManager.
* ForEachCoClass.h:
* Interfaces/IWebCookieManager.idl: Removed.
* Interfaces/WebKit.idl:
* WebCookieManager.cpp: Removed.
* WebCookieManager.h: Removed.
* WebCookieManagerCFNet.cpp: Removed.
* WebCookieManagerCurl.cpp: Removed.
* WebKitClassFactory.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176614
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
conrad_shultz@apple.com [Tue, 2 Dec 2014 00:49:49 +0000 (00:49 +0000)]
Clients need a way to explicitly set the title of a page preview
https://bugs.webkit.org/show_bug.cgi?id=139161
Reviewed by Beth Dakin.
This implicitly assumes that only one page preview can be associate with a given WKView at a time.
* UIProcess/API/Cocoa/WKViewPrivate.h:
* UIProcess/API/mac/WKView.mm:
(-[WKView _setPreviewTitle:]):
Wrap -[WKActionMenuController setPreviewTitle:]
* UIProcess/mac/WKActionMenuController.h:
* UIProcess/mac/WKActionMenuController.mm:
Add ivars for the title and the title text field (previously not independently exposed).
(-[WKPagePreviewViewController previewTitle]):
Accessor.
(-[WKPagePreviewViewController setPreviewTitle:]):
Accessor; set the text field's string value.
(-[WKPagePreviewViewController loadView]):
Adopt the _titleTextField ivar; assume that if a client has explicitly set the previewTitle then we don't
need to ask for it again.
(-[WKActionMenuController setPreviewTitle:]):
Wrap -[WKPagePreviewViewController setPreviewTitle:].
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176613
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dino@apple.com [Tue, 2 Dec 2014 00:18:33 +0000 (00:18 +0000)]
[iOS Media] Slider knob should not have a border
https://bugs.webkit.org/show_bug.cgi?id=139160
<rdar://problem/
19075185>
Reviewed by Jer Noble.
The change in r175715 required adding !important to a bunch
of rules for pseudo elements. The border width of slider knobs
for media controls should be zero, so add an !important there.
* Modules/mediacontrols/mediaControlsiOS.css:
(audio::-webkit-media-controls-timeline::-webkit-slider-thumb): Change
border to border-width and force it to zero.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176612
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 2 Dec 2014 00:10:04 +0000 (00:10 +0000)]
Make WebKit2 work slightly better with garbage collection
https://bugs.webkit.org/show_bug.cgi?id=139159
<rdar://problem/
19108390>
Reviewed by Dan Bernstein.
* Shared/Cocoa/APIObject.mm:
(API::Object::ref):
(API::Object::deref):
Call CFRetain/CFRelease to prevent the memory from being collected.
(API::Object::newObject):
Call CFRetain under GC so we'll prevent memory from being collected prematurely.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176611
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
benjamin@webkit.org [Tue, 2 Dec 2014 00:10:03 +0000 (00:10 +0000)]
Web Inspector: add more :not() and :matches() awesomeness
https://bugs.webkit.org/show_bug.cgi?id=138997
Reviewed by Joseph Pecoraro.
Simplify the Inspector's CSS when possible.
* UserInterface/Views/DatabaseContentView.css:
(:matches(.database-user-query, .database-query-prompt, .database-query-result)::before):
(.database-user-query::before, .database-query-prompt::before, .database-query-result::before): Deleted.
* UserInterface/Views/GradientSlider.css:
(.gradient-slider-knob > :matches(img, div)):
(.gradient-slider-knob > div): Deleted.
* UserInterface/Views/HoverMenu.css:
(.hover-menu > svg > :matches(path, rect)):
(.hover-menu > svg > rect): Deleted.
* UserInterface/Views/LayerTreeDetailsSidebarPanel.css:
(.panel.details.layer-tree .name-column :matches(.pseudo-element, .reflection)):
(.panel.details.layer-tree tr.selected .name-column :matches(.pseudo-element, .reflection)):
(.panel.details.layer-tree .name-column .reflection): Deleted.
(.panel.details.layer-tree tr.selected .name-column .reflection): Deleted.
* UserInterface/Views/ProbeDetailsSidebarPanel.css:
(.details-section.probe-set .options > :matches(.probe-remove, .probe-clear-samples, .probe-add)):
(.details-section.probe-set .options > .probe-add): Deleted.
* UserInterface/Views/ResourceSidebarPanel.css:
(.sidebar > .panel.navigation.resource > :matches(.content, .empty-content-placeholder)):
(body.mac-platform.legacy .sidebar > .panel.navigation.resource > :matches(.content, .empty-content-placeholder)):
(.sidebar > .panel.navigation.resource > .empty-content-placeholder): Deleted.
(body.mac-platform.legacy .sidebar > .panel.navigation.resource > .empty-content-placeholder): Deleted.
* UserInterface/Views/ScopeBar.css:
(.scope-bar > li:matches(.selected, :active)):
(.scope-bar > li:active): Deleted.
* UserInterface/Views/SyntaxHighlightingDefaultTheme.css:
(.syntax-highlighted :matches(.css-comment, .javascript-comment, .html-comment)):
(.syntax-highlighted :matches(.css-keyword, .css-tag, .css-at-rule, .css-important, .javascript-keyword, .html-tag)):
(.syntax-highlighted :matches(.css-number, .javascript-number)):
(.syntax-highlighted :matches(.css-property, .css-selector, .javascript-ident)):
(.syntax-highlighted :matches(.css-string, .javascript-string, .javascript-regexp, .html-attribute-value)):
(.syntax-highlighted :matches(.html-doctype, .html-processing-instruction)):
(.syntax-highlighted .html-comment): Deleted.
(.syntax-highlighted .html-tag): Deleted.
(.syntax-highlighted .javascript-number): Deleted.
(.syntax-highlighted .javascript-ident): Deleted.
(.syntax-highlighted .html-attribute-value): Deleted.
(.syntax-highlighted .html-processing-instruction): Deleted.
It looks like ".cm-tag.cm-bracket" was there only to override the rule below.
From basic testing, it looks like "cm-tag" and "cm-bracket" always appear together. I removed the "cm-bracket" rule
from the second rule, and simplified the first rule.
* UserInterface/Views/TimelineSidebarPanel.css:
(body.mac-platform.legacy .sidebar > .panel.navigation.timeline > :matches(.content, .empty-content-placeholder)):
(body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .empty-content-placeholder): Deleted.
* UserInterface/Views/Toolbar.css:
(body.mac-platform:not(.legacy, .docked) .toolbar):
(body.mac-platform:not(.legacy, .docked) .toolbar.icon-and-label-vertical):
(body.mac-platform:not(.legacy, .docked) .toolbar.icon-and-label-vertical.small-size):
(body.mac-platform:not(.legacy, .docked) .toolbar:matches(.icon-and-label-horizontal, .icon-only)):
(body.mac-platform:not(.legacy, .docked) .toolbar:matches(.icon-and-label-horizontal.small-size, .icon-only.small-size, .label-only)):
(.toolbar:matches(.icon-and-label-horizontal.small-size, .icon-only.small-size, .label-only) .control-section):
(body.mac-platform:not(.legacy):not(.docked) .toolbar): Deleted.
(body.mac-platform:not(.legacy):not(.docked) .toolbar.icon-and-label-vertical): Deleted.
(body.mac-platform:not(.legacy):not(.docked) .toolbar.icon-and-label-vertical.small-size): Deleted.
(body.mac-platform:not(.legacy):not(.docked) .toolbar.icon-only): Deleted.
(body.mac-platform:not(.legacy):not(.docked) .toolbar.label-only): Deleted.
(.toolbar.label-only .control-section): Deleted.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176610
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cdumez@apple.com [Tue, 2 Dec 2014 00:09:56 +0000 (00:09 +0000)]
Take into consideration canvas drawing for throttling DOM timers
https://bugs.webkit.org/show_bug.cgi?id=139140
<rdar://problem/
19102218>
Reviewed by Andreas Kling.
Source/WebCore:
Take into consideration canvas drawing for throttling DOM timers so
that:
- Timers drawing on a visible canvas can no longer get throttled.
This fixes the following sites:
- http://hint.fm/wind/
- http://radar.weather.gov/Conus/full_loop.php
- Timers that are drawing on a canvas that is not user observable
now get throttled, thus using less CPU. As an example, on
http://hint.fm/wind/, CPU usage is at 110% when the canvas is
inside the viewport on my machine. CPU usage would remain at
110% when scrolling the canvas outside the viewport before this
patch. After this patch, the CPU usage goes down to 5% when
the canvas is outside the viewport.
Tests: fast/canvas/canvas-inside-viewport-timer-throttling.html
fast/canvas/canvas-outside-viewport-timer-throttling.html
* bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::JSCSSStyleDeclaration::putDelegate):
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::notifyObserversCanvasChanged):
* page/DOMTimer.cpp:
(WebCore::DOMTimerFireState::setScriptMadeNonUserObservableChangesToElement):
(WebCore::DOMTimer::scriptDidCauseElementRepaint):
(WebCore::DOMTimerFireState::setScriptMadeNonUserObservableChangesToElementStyle): Deleted.
(WebCore::DOMTimer::scriptDidUpdateStyleOfElement): Deleted.
* page/DOMTimer.h:
LayoutTests:
Add layout tests to test that we take into consideration canvas drawing
when considering if we should throttle DOM timers.
* fast/canvas/canvas-inside-viewport-timer-throttling-expected.txt: Added.
* fast/canvas/canvas-inside-viewport-timer-throttling.html: Added.
* fast/canvas/canvas-outside-viewport-timer-throttling-expected.txt: Added.
* fast/canvas/canvas-outside-viewport-timer-throttling.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176609
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy_horton@apple.com [Mon, 1 Dec 2014 23:56:14 +0000 (23:56 +0000)]
Fix the iOS build.
* WebView/WebActionMenuController.h:
* WebView/WebActionMenuController.mm:
* WebView/WebHTMLView.mm:
(-[WebHTMLView scrollWheel:scrollWheel:]):
(-[WebHTMLView mouseDown:mouseDown:]):
* WebView/WebView.mm:
* WebView/WebViewData.h:
* WebView/WebViewData.mm:
(-[WebViewPrivate dealloc]):
* WebView/WebViewInternal.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176608
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mmaxfield@apple.com [Mon, 1 Dec 2014 23:54:51 +0000 (23:54 +0000)]
Crash in Font::dashesForIntersectionsWithRect() due to underlining SVG fonts
https://bugs.webkit.org/show_bug.cgi?id=139158
Reviewed by Simon Fraser.
Source/WebCore:
RenderingContexts are only created if the primary SimpleFontData is an SVG font,
but dashesForIntersectionWithRect() uses the first character's SimpleFontData.
One might be an SVG font but the other might not be.
Note that this brittle design will be fixed with the SVG -> OTF translator.
Test: fast/css3-text/css3-text-decoration/text-decoration-skip/decoration-skip-crash-fallback-svg.html
* platform/graphics/mac/FontMac.mm:
(WebCore::Font::dashesForIntersectionsWithRect):
LayoutTests:
Test for no crashes when the primary SimpleFontData and the first character's
SimpleFontData differ in their SVG-ness.
* fast/css3-text/css3-text-decoration/text-decoration-skip/decoration-skip-crash-fallback-svg-expected.html: Added.
* fast/css3-text/css3-text-decoration/text-decoration-skip/decoration-skip-crash-fallback-svg.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176607
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Mon, 1 Dec 2014 23:40:09 +0000 (23:40 +0000)]
[iOS] Update expected results for LayoutTests/crypto
* platform/ios-simulator/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176606
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Mon, 1 Dec 2014 23:37:45 +0000 (23:37 +0000)]
[iOS] Skip some animation tests that time out in iOS WebKit2
* platform/ios-simulator-wk2/TestExpectations: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176605
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 1 Dec 2014 22:04:30 +0000 (22:04 +0000)]
[MSE] Fix not always calling mediaPlayer seek.
https://bugs.webkit.org/show_bug.cgi?id=139139
Patch by Bartlomiej Gajda <b.gajda@samsung.com> on 2014-12-01
Reviewed by Jer Noble.
Original comment states that media source shall always be notified of seek if it's not closed.
No new tests needed.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::seekTimerFired):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176604
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Mon, 1 Dec 2014 21:49:00 +0000 (21:49 +0000)]
Fix 32-bit build.
* wtf/IndexedIterator.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176603
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Mon, 1 Dec 2014 21:15:42 +0000 (21:15 +0000)]
http tests should not use shared temporary files, part 3
https://bugs.webkit.org/show_bug.cgi?id=139135
Reviewed by Tim Horton.
Fix ping tests, using the same techniques as before.
* http/tests/navigation/image-load-in-unload-handler.html:
* http/tests/navigation/ping-cross-origin-from-https.html:
* http/tests/navigation/resources/check-ping.php:
* http/tests/navigation/resources/delete-ping.php:
* http/tests/navigation/resources/image-load-in-unload-handler-2.html: Copied from LayoutTests/http/tests/navigation/resources/ping-redirect.html.
* http/tests/navigation/resources/ping-file-path.php: Copied from LayoutTests/http/tests/security/contentSecurityPolicy/resources/report-file-path.php.
* http/tests/navigation/resources/ping-redirect.html: Removed.
* http/tests/navigation/resources/save-Ping.php:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176602
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Mon, 1 Dec 2014 21:14:35 +0000 (21:14 +0000)]
Several JavaScriptCore date tests are flaky, because they expect time to be frozen during execution
https://bugs.webkit.org/show_bug.cgi?id=139138
Reviewed by Mark Lam.
Merged a fix by Bob Clary.
* tests/mozilla/ecma/Date/15.9.1.1-1.js:
* tests/mozilla/ecma/Date/15.9.1.1-2.js:
* tests/mozilla/ecma/Date/15.9.2.1.js:
* tests/mozilla/ecma/Date/15.9.2.2-1.js:
* tests/mozilla/ecma/Date/15.9.2.2-2.js:
* tests/mozilla/ecma/Date/15.9.2.2-3.js:
* tests/mozilla/ecma/Date/15.9.2.2-4.js:
* tests/mozilla/ecma/Date/15.9.2.2-5.js:
* tests/mozilla/ecma/Date/15.9.2.2-6.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176601
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Mon, 1 Dec 2014 21:10:34 +0000 (21:10 +0000)]
<rdar://problem/
11358748> http/tests/multipart/multipart-wait-before-boundary.html fails on ML as of r115745
Looks like it no longer fails.
* platform/mac/TestExpectations:
* platform/wk2/TestExpectations:
Removed it from test expectations.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176600
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy_horton@apple.com [Mon, 1 Dec 2014 20:48:39 +0000 (20:48 +0000)]
Implement yellow highlight for WebKit1 data detectors
https://bugs.webkit.org/show_bug.cgi?id=138956
<rdar://problem/
18992185>
Reviewed by Beth Dakin.
* page/TextIndicator.cpp:
(WebCore::TextIndicator::createWithSelectionInFrame):
(WebCore::TextIndicator::TextIndicator):
* page/TextIndicator.h:
(WebCore::TextIndicator::selectionRectInScreenCoordinates):
(WebCore::TextIndicator::textBoundingRectInScreenCoordinates):
(WebCore::TextIndicator::selectionRectInWindowCoordinates): Deleted.
(WebCore::TextIndicator::textBoundingRectInWindowCoordinates): Deleted.
Store TextIndicator rects in screen coordinates, since that's what we
want anyway, and this makes it easier to share this code between the WebKits.
* page/mac/TextIndicatorWindow.mm:
(-[WebTextIndicatorView initWithFrame:textIndicator:margin:]):
(WebCore::TextIndicatorWindow::setTextIndicator):
Avoid some rect conversion because the TextIndicator rects are already in screen coordinates.
* WebView/WebActionMenuController.h:
* WebView/WebActionMenuController.mm:
(-[WebActionMenuController webView:willHandleMouseDown:]):
(-[WebActionMenuController webView:didHandleScrollWheel:]):
(-[WebActionMenuController prepareForMenu:withEvent:]):
(-[WebActionMenuController didCloseMenu:withEvent:]):
(-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
(-[WebActionMenuController _showTextIndicator]):
(-[WebActionMenuController _hideTextIndicator]):
(-[WebActionMenuController _dismissActionMenuPopovers]):
Copy the WebKit2 WKActionMenuController TextIndicator implementation
into WebActionMenuController. The only significant difference is
that we build the TextIndicator right at menu construction time
instead of in the Web process.
* WebView/WebHTMLView.mm:
(-[WebHTMLView scrollWheel:]):
Let the WebActionMenuController know that we're handling a scroll.
(-[WebHTMLView mouseDown:]):
Let the WebActionMenuController know that we're handling a mouseDown.
* WebView/WebView.mm:
(-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
(-[WebView _clearTextIndicator]):
(-[WebView _actionMenuController]):
(-[WebView _convertRectFromRootView:]): Deleted.
* WebView/WebViewData.h:
* WebView/WebViewData.mm:
* WebView/WebViewInternal.h:
Keep a TextIndicatorWindow on WebView, just like WKView does.
Expose the WebActionMenuController on WebView (internally).
* Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<TextIndicatorData>::encode):
(IPC::ArgumentCoder<TextIndicatorData>::decode):
* WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::updateFindIndicator):
(WebKit::FindController::drawRect):
Adjust to the fact that TextIndicator keeps screen-relative rects.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176599
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Mon, 1 Dec 2014 20:18:33 +0000 (20:18 +0000)]
Remove old site specific quirks code that was added in 2009
https://bugs.webkit.org/show_bug.cgi?id=139141
Reviewed by Antti Koivisto.
Source/WebCore:
* platform/network/NetworkingContext.h:
* platform/network/ResourceHandleInternal.h:
(WebCore::ResourceHandleInternal::ResourceHandleInternal):
* platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::start):
Source/WebKit/mac:
* WebCoreSupport/WebFrameNetworkingContext.h:
* WebCoreSupport/WebFrameNetworkingContext.mm:
(WebFrameNetworkingContext::needsSiteSpecificQuirks): Deleted.
Source/WebKit2:
* NetworkProcess/RemoteNetworkingContext.h:
* NetworkProcess/mac/RemoteNetworkingContext.mm:
(WebKit::RemoteNetworkingContext::needsSiteSpecificQuirks): Deleted.
* WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h:
* WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
(WebKit::WebFrameNetworkingContext::needsSiteSpecificQuirks): Deleted.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176598
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 1 Dec 2014 19:59:50 +0000 (19:59 +0000)]
Web Inspector: Crash in WebInspectorClient::hideHighlight when page is destroyed
https://bugs.webkit.org/show_bug.cgi?id=139136
Patch by Joseph Pecoraro <pecoraro@apple.com> on 2014-12-01
Reviewed by Simon Fraser.
* WebProcess/WebCoreSupport/WebInspectorClient.cpp:
(WebKit::WebInspectorClient::hideHighlight):
Speculatively fix by null-checking the main frame which
can be null during page destruction.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176596
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
joepeck@webkit.org [Mon, 1 Dec 2014 19:11:11 +0000 (19:11 +0000)]
Web Inspector: DOMExceptions do not show the error message string in Pause Reason section
https://bugs.webkit.org/show_bug.cgi?id=138988
Reviewed by Timothy Hatcher.
Source/WebCore:
* inspector/WebInjectedScriptHost.cpp:
(WebCore::WebInjectedScriptHost::type):
Give all DOM Exception types the "error" RemoteObject subtype.
LayoutTests:
* inspector/debugger/command-line-api-exception-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176595
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 1 Dec 2014 19:01:50 +0000 (19:01 +0000)]
[MSE] Unset timestamps of trackbuffers during Reset Parser State algorithm.
https://bugs.webkit.org/show_bug.cgi?id=139075.
Patch by Bartlomiej Gajda <b.gajda@samsung.com> on 2014-12-01
Reviewed by Jer Noble.
Source/WebCore:
Specification requires from us to unset timestamps for trackBuffers
during abort() method.
Test: media/media-source/media-source-append-nonsync-sample-after-abort.html
* Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::resetParserState):
(WebCore::SourceBuffer::abort):
* Modules/mediasource/SourceBuffer.h:
LayoutTests:
Specification requires from us to unset timestamps for trackBuffers during abort() method.
Tests appendBuffer() with first sync sample, then aborts after a few more samples, and emits
a few more non-sync samples, so they should be dropped, as trackBuffer will have
needRandomAccessFlag set.
* media/media-source/media-source-append-nonsync-sample-after-abort-expected.txt: Added.
* media/media-source/media-source-append-nonsync-sample-after-abort.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176594
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cdumez@apple.com [Mon, 1 Dec 2014 18:42:52 +0000 (18:42 +0000)]
Transform StyleBuilderCustom into a class and mark it as a friend of RenderStyle
https://bugs.webkit.org/show_bug.cgi?id=138999
Reviewed by Sam Weinig.
Transform StyleBuilderCustom into a class and mark it as a friend of
RenderStyle. This is needed because some of the StyleBuilderCustom
functions need to access RenderStyle's private API.
No new tests, no behavior change.
* css/StyleBuilderCustom.h:
Move functions from StyleBuilderFunctions namespace to
StyleBuilderCustom class.
* css/makeprop.pl:
Use StyleBuilderCustom scope instead of StyleBuilderFunctions for
custom implementation.
* rendering/style/RenderStyle.h:
Mark StyleBuilderCustom class as a friend, similarly to what was
already done for DeprecatedStyleBuilder and StyleResolver.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176593
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Mon, 1 Dec 2014 17:50:35 +0000 (17:50 +0000)]
Make sure range based iteration of Vector<> still receives bounds checking
https://bugs.webkit.org/show_bug.cgi?id=138821
Reviewed by Mark Lam.
Source/JavaScriptCore:
There are a few uses of begin()/end() that explicitly require pointers,
so we use getPtr() to extract the underlying pointer generically.
* bytecode/UnlinkedCodeBlock.cpp:
(JSC::UnlinkedCodeBlock::visitChildren):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitComplexPopScopes):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::emitSwitchIntJump):
* ftl/FTLAbbreviations.h:
(JSC::FTL::mdNode):
(JSC::FTL::buildCall):
* llint/LLIntData.cpp:
(JSC::LLInt::Data::performAssertions):
* parser/Parser.h:
(JSC::Scope::Scope):
* profiler/ProfileNode.cpp:
(JSC::ProfileNode::debugPrintRecursively):
* runtime/JSArray.cpp:
(JSC::JSArray::setLengthWithArrayStorage):
(JSC::JSArray::sortCompactedVector):
* tools/ProfileTreeNode.h:
(JSC::ProfileTreeNode::dumpInternal):
* yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::matchCharacterClass):
Source/WebCore:
There are a few uses of begin()/end() that explicitly require pointers,
so we use getPtr() to extract the underlying pointer generically.
* bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneDeserializer::deserializeString):
* editing/TextIterator.cpp:
(WebCore::SearchBuffer::isBadMatch):
* page/mac/ServicesOverlayController.mm:
(WebCore::ServicesOverlayController::buildSelectionHighlight):
* platform/graphics/SegmentedFontData.cpp:
(WebCore::SegmentedFontData::fontDataForCharacter):
(WebCore::SegmentedFontData::containsCharacter):
(WebCore::SegmentedFontData::isLoading):
* platform/graphics/WOFFFileFormat.cpp:
(WebCore::convertWOFFToSfnt):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::paintFillLayers):
* rendering/style/GridResolvedPosition.cpp:
(WebCore::firstNamedGridLineBeforePosition):
(WebCore::GridResolvedPosition::resolveRowEndColumnEndNamedGridLinePositionAgainstOppositePosition):
* svg/SVGFontElement.cpp:
(WebCore::kerningForPairOfStringsAndGlyphs):
* svg/SVGPathByteStream.h:
(WebCore::SVGPathByteStream::append):
* xml/XPathNodeSet.h:
(WebCore::XPath::NodeSet::begin):
(WebCore::XPath::NodeSet::end):
Source/WTF:
Add a new IndexedIterator struct to WTF that wraps a
Vector type and index to provide pointer like semantics
while still performing runtime bounds checking, even in
release builds. We store a simple index into the vector
which means that this iterator allows vector resizing
during iteration. If the vector is resized such that the
iterator is out of bounds, then any attempt to dereference
the iterator will crash safely. Any other errors, including
overflows, and over extending the iterator will likewise
crash.
For the purpose of retaining semantically equivalent
behaviour, the iterator can be moved to m_index == size()
as that is the standard "end" terminator for these types.
Attempting to dereference at that point will still crash
rather than perform an unsafe memory operation.
In order to maintain the validity of all the bounds checking,
we perform full integer range checking prior to any mutation
of the iterator location. If we detect an arithmetic overflow
we will crash rather than attempting to carry on.
By necessity there are many overrides for operator + and - as
we otherwise hit many different type promotion ambiguities when
performing arithmetic with iterators. These ambiguities are also
different for 32- vs. 64-bit, so duplicating the functions
and then forwarding to the core implementations that performed
the bounds checking and mutation seemed like the right call.
* WTF.xcodeproj/project.pbxproj:
* wtf/IndexedIterator.h: Added.
(WTF::IndexedIterator::IndexedIterator):
(WTF::IndexedIterator::operator->):
(WTF::IndexedIterator::operator*):
(WTF::IndexedIterator::get):
(WTF::IndexedIterator::operator++):
(WTF::IndexedIterator::operator--):
(WTF::IndexedIterator::operator UnspecifiedBoolType):
(WTF::IndexedIterator::operator+=):
(WTF::IndexedIterator::operator-=):
(WTF::IndexedIterator::operator+):
(WTF::IndexedIterator::operator-):
(WTF::IndexedIterator::operator=):
(WTF::IndexedIterator::operator==):
(WTF::IndexedIterator::operator!=):
(WTF::IndexedIterator::operator<):
(WTF::IndexedIterator::operator<=):
(WTF::IndexedIterator::operator>):
(WTF::IndexedIterator::operator>=):
(WTF::IndexedIterator::operator const_iterator):
(WTF::IndexedIterator::isSafeToCompare):
(WTF::IndexedIterator::unsafeGet):
(WTF::getPtr):
(WTF::operator-):
(WTF::operator==):
(WTF::operator!=):
(WTF::operator<=):
(WTF::operator>=):
(WTF::operator<):
(WTF::operator>):
(WTF::IndexedIteratorSelector::makeIterator):
(WTF::IndexedIteratorSelector::makeConstIterator):
* wtf/RefCountedArray.h:
(WTF::RefCountedArray::RefCountedArray):
* wtf/Vector.h:
(WTF::Vector::Vector):
(WTF::Vector::begin):
(WTF::Vector::end):
(WTF::OverflowHandler>::Vector):
(WTF::=):
(WTF::OverflowHandler>::fill):
(WTF::OverflowHandler>::expandCapacity):
(WTF::OverflowHandler>::tryExpandCapacity):
(WTF::OverflowHandler>::resize):
(WTF::OverflowHandler>::shrink):
(WTF::OverflowHandler>::grow):
(WTF::OverflowHandler>::reserveCapacity):
(WTF::OverflowHandler>::tryReserveCapacity):
(WTF::OverflowHandler>::shrinkCapacity):
(WTF::OverflowHandler>::append):
(WTF::OverflowHandler>::tryAppend):
(WTF::OverflowHandler>::appendSlowCase):
(WTF::OverflowHandler>::uncheckedAppend):
(WTF::OverflowHandler>::appendVector):
(WTF::OverflowHandler>::insert):
(WTF::OverflowHandler>::insertVector):
(WTF::OverflowHandler>::remove):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176592
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 1 Dec 2014 14:48:34 +0000 (14:48 +0000)]
Unreviewed, rolling out r176566.
https://bugs.webkit.org/show_bug.cgi?id=139124
It broke the GTK performance tests. (Requested by clopez on
#webkit).
Reverted changeset:
"[GTK] Use GMainLoopSource in WebKitTestRunner"
https://bugs.webkit.org/show_bug.cgi?id=138831
http://trac.webkit.org/changeset/176566
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176591
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ljaehun.lim@samsung.com [Mon, 1 Dec 2014 07:36:45 +0000 (07:36 +0000)]
[EFL] Add eldbus to the library list
https://bugs.webkit.org/show_bug.cgi?id=139120
Reviewed by Gyuyoung Kim.
Fix undefined reference errors for eldbus APIs.
* PlatformEfl.cmake:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176590
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ryuan.choi@navercorp.com [Mon, 1 Dec 2014 03:48:30 +0000 (03:48 +0000)]
[EFL] Drop support for the EFL 1.7
https://bugs.webkit.org/show_bug.cgi?id=139114
Reviewed by Gyuyoung Kim.
.:
* Source/cmake/EFLHelpers.cmake: Removed.
* Source/cmake/FindEcore.cmake: Removed.
* Source/cmake/FindEdje.cmake: Removed.
* Source/cmake/FindEet.cmake: Removed.
* Source/cmake/FindEeze.cmake: Removed.
* Source/cmake/FindEfreet.cmake: Removed.
* Source/cmake/FindEina.cmake: Removed.
* Source/cmake/FindElementary.cmake: Removed.
* Source/cmake/FindEvas.cmake: Removed.
* Source/cmake/OptionsEfl.cmake:
Source/WTF:
* wtf/efl/EflTypedefs.h: Removed old definitions which EFL 1.7 used.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176589
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Mon, 1 Dec 2014 00:20:34 +0000 (00:20 +0000)]
Fix a test failure.
* History/WebHistory.mm:
(+[WebHistory _setVisitedLinkTrackingEnabled:]):
Call through to the visited link store.
(+[WebHistory _removeAllVisitedLinks]):
Ditto.
* WebCoreSupport/WebVisitedLinkStore.mm:
(WebVisitedLinkStore::isLinkVisited):
Make sure to populate visited links.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176588
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Sun, 30 Nov 2014 22:48:30 +0000 (22:48 +0000)]
Switch over to the visited link store from the WebViewGroup
https://bugs.webkit.org/show_bug.cgi?id=139112
Reviewed by Sam Weinig.
* WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView setGroupName:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176587
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Sun, 30 Nov 2014 22:45:19 +0000 (22:45 +0000)]
Add WebVisitedLinkStore::removeVisitedLink and use it on iOS
https://bugs.webkit.org/show_bug.cgi?id=139111
Reviewed by Sam Weinig.
* WebCoreSupport/WebVisitedLinkStore.h:
* WebCoreSupport/WebVisitedLinkStore.mm:
(WebVisitedLinkStore::removeVisitedLink):
* WebView/WebView.mm:
(-[WebView removeVisitedLink:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176586
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
gyuyoung.kim@samsung.com [Sun, 30 Nov 2014 02:36:26 +0000 (02:36 +0000)]
Fix a build warning when CSS_SCROLL_SNAP is enabled
https://bugs.webkit.org/show_bug.cgi?id=139084
Reviewed by Andrei Bucur.
Fix a build warning. Copy constructor of StyleScrollSnapPoints should initialize its base class.
* rendering/style/StyleScrollSnapPoints.cpp:
(WebCore::StyleScrollSnapPoints::StyleScrollSnapPoints): Call RefCounted().
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176585
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sun, 30 Nov 2014 00:39:14 +0000 (00:39 +0000)]
Move the '-webkit-locale', '-webkit-text-orientation', '-webkit-writing-mode', '-webkit-justify-self' and '-webkit-perspective' CSS properties to the new StyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=139104
Patch by Sam Weinig <sam@webkit.org> on 2014-11-29
Reviewed by Anders Carlsson.
* css/CSSPropertyNames.in:
* css/StyleBuilderCustom.h:
(WebCore::StyleBuilderFunctions::applyValueWebkitLocale):
(WebCore::StyleBuilderFunctions::applyValueWebkitWritingMode):
(WebCore::StyleBuilderFunctions::applyValueWebkitTextOrientation):
(WebCore::StyleBuilderFunctions::applyValueWebkitJustifySelf):
(WebCore::StyleBuilderFunctions::applyValueWebkitPerspective):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176584
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
akling@apple.com [Sun, 30 Nov 2014 00:06:58 +0000 (00:06 +0000)]
PropertyTable keys should be AtomicStringImpl.
<https://webkit.org/b/139096>
Reviewed by Sam Weinig.
Since PropertyTable keys are really always Identifiers, switch the key
type from StringImpl* to AtomicStringImpl*.
We have code in the GetByVal opcode implementations that assumes things
about this, so this change adds confidence to those algorithms.
* bytecode/ComplexGetStatus.cpp:
(JSC::ComplexGetStatus::computeFor):
* bytecode/ComplexGetStatus.h:
* bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeFromLLInt):
(JSC::GetByIdStatus::computeFor):
(JSC::GetByIdStatus::computeForStubInfo):
* bytecode/GetByIdStatus.h:
* bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeFromLLInt):
(JSC::PutByIdStatus::computeFor):
(JSC::PutByIdStatus::computeForStubInfo):
* bytecode/PutByIdStatus.h:
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
* dfg/DFGDesiredIdentifiers.cpp:
(JSC::DFG::DesiredIdentifiers::addLazily):
(JSC::DFG::DesiredIdentifiers::at):
* dfg/DFGDesiredIdentifiers.h:
(JSC::DFG::DesiredIdentifiers::operator[]):
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::isStringPrototypeMethodSane):
* runtime/Identifier.h:
(JSC::Identifier::impl):
* runtime/IntendedStructureChain.cpp:
(JSC::IntendedStructureChain::mayInterceptStoreTo):
* runtime/IntendedStructureChain.h:
* runtime/PropertyMapHashTable.h:
* runtime/Structure.cpp:
(JSC::StructureTransitionTable::contains):
(JSC::StructureTransitionTable::get):
(JSC::Structure::addPropertyTransitionToExistingStructureImpl):
(JSC::Structure::addPropertyTransitionToExistingStructureConcurrently):
(JSC::Structure::getConcurrently):
(JSC::Structure::add):
(JSC::Structure::remove):
* runtime/Structure.h:
(JSC::PropertyMapEntry::PropertyMapEntry):
* runtime/StructureInlines.h:
(JSC::Structure::getConcurrently):
* runtime/StructureTransitionTable.h:
(JSC::StructureTransitionTable::Hash::hash):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176583
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Sat, 29 Nov 2014 23:40:30 +0000 (23:40 +0000)]
Switch over to using WebVisitedLinkStore on Windows
https://bugs.webkit.org/show_bug.cgi?id=139103
Reviewed by Antti Koivisto.
* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::populateVisitedLinks):
* WebHistory.cpp:
(WebHistory::setOptionalSharedHistory):
(WebHistory::removeAllItems):
(WebHistory::setVisitedLinkTrackingEnabled):
(WebHistory::removeAllVisitedLinks):
(WebHistory::removeItemForURLString):
(WebHistory::addVisitedLinksToVisitedLinkStore):
(WebHistory::addVisitedLinksToPageGroup): Deleted.
* WebHistory.h:
* WebView.cpp:
(WebView::initWithFrame):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176582
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Sat, 29 Nov 2014 22:52:58 +0000 (22:52 +0000)]
Another build fix.
* WebHistory.cpp:
(WebHistory::addVisitedLinksToVisitedLinkStore):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176581
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Sat, 29 Nov 2014 22:48:41 +0000 (22:48 +0000)]
Another build fix.
* WebHistory.cpp:
(WebHistory::addVisitedLinksToVisitedLinkStore):
(WebHistory::removeAllVisitedLinks): Deleted.
(WebHistory::setHistoryItemLimit): Deleted.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176580
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Sat, 29 Nov 2014 22:43:41 +0000 (22:43 +0000)]
Try to fix build.
* WebHistory.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176579
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Sat, 29 Nov 2014 22:23:36 +0000 (22:23 +0000)]
Stub out more of WebVisitedLinkStore on Windows
https://bugs.webkit.org/show_bug.cgi?id=139098
Reviewed by Sam Weinig.
* WebCoreSupport/WebVisitedLinkStore.cpp:
(WebVisitedLinkStore::WebVisitedLinkStore):
Initialize m_visitedLinksPopulated to false.
(WebVisitedLinkStore::setShouldTrackVisitedLinks):
Update s_shouldTrackVisitedLinks and remove all visited links if needed.
(WebVisitedLinkStore::removeAllVisitedLinks):
Remove all hashes from our shared link store.
(WebVisitedLinkStore::addVisitedLink):
Compute the visited link hash and add it to the store.
(WebVisitedLinkStore::isLinkVisited):
Populate visited links and then look up the hash in our hash map.
(WebVisitedLinkStore::populateVisitedLinksIfNeeded):
Call out to the history delegate or populate visited links from shared history.
(WebVisitedLinkStore::addVisitedLinkHash):
Add the hash if we're tracking hashes.
(WebVisitedLinkStore::removeVisitedLinkHashes):
Clear the map.
* WebCoreSupport/WebVisitedLinkStore.h:
Add members.
* WebHistory.cpp:
(WebHistory::addVisitedLinksToVisitedLinkStore):
New function that adds visited links from the history to a given store.
* WebHistory.h:
Add new member.
* WebView.cpp:
(WebView::addVisitedLinks):
Add links to the visited link store as well.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176578
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Sat, 29 Nov 2014 22:17:07 +0000 (22:17 +0000)]
Add an EmptyVisitedLinkStore implementation
https://bugs.webkit.org/show_bug.cgi?id=139102
Reviewed by Sam Weinig.
* loader/EmptyClients.cpp:
(WebCore::fillWithEmptyClients):
* loader/EmptyClients.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176577
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Sat, 29 Nov 2014 22:11:08 +0000 (22:11 +0000)]
Populate visited links
https://bugs.webkit.org/show_bug.cgi?id=139101
Reviewed by Sam Weinig.
* History/WebHistory.mm:
(-[WebHistoryPrivate addVisitedLinksToVisitedLinkStore:]):
Helper function that adds all visited link to the given store.
(-[WebHistory _addVisitedLinksToVisitedLinkStore:]):
Call the private method.
* History/WebHistoryInternal.h:
* WebCoreSupport/WebVisitedLinkStore.h:
Add new members.
* WebCoreSupport/WebVisitedLinkStore.mm:
(WebVisitedLinkStore::addVisitedLink):
Get the characters from the URL string and hash them, then call addVisitedLinkHash.
(WebVisitedLinkStore::populateVisitedLinksIfNeeded):
Implement this. First try the delegate, then try the shared history.
(WebVisitedLinkStore::addVisitedLinkHash):
Factor code that adds the link to the hash table into a separate function.
* WebView/WebView.mm:
(-[WebView addVisitedLinks:]):
Add the visited links to the store.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176576
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Sat, 29 Nov 2014 21:49:40 +0000 (21:49 +0000)]
More work on the legacy WebKit visited link store
https://bugs.webkit.org/show_bug.cgi?id=139100
Reviewed by Sam Weinig.
* History/WebHistory.mm:
(+[WebHistory setOptionalSharedHistory:]):
Call WebVisitedLinkStore::setShouldTrackVisitedLinks and WebVisitedLinkStore::removeAllVisitedLinks.
* WebCoreSupport/WebVisitedLinkStore.h:
* WebCoreSupport/WebVisitedLinkStore.mm:
(visitedLinkStores):
(WebVisitedLinkStore::WebVisitedLinkStore):
(WebVisitedLinkStore::~WebVisitedLinkStore):
Keep track of live visited link stores.
(WebVisitedLinkStore::setShouldTrackVisitedLinks):
Update s_shouldTrackVisitedLinks and call removeAllVisitedLinks if necessary.
(WebVisitedLinkStore::removeAllVisitedLinks):
Iterate over all live link stores and remove their links.
(WebVisitedLinkStore::isLinkVisited):
Populate visited links and check if our hash table contains the link.
(WebVisitedLinkStore::addVisitedLink):
Add the link hash to the table.
(WebVisitedLinkStore::populateVisitedLinksIfNeeded):
Add stub.
(WebVisitedLinkStore::removeVisitedLinkHashes):
Clear out the hash table.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176575
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Sat, 29 Nov 2014 21:12:55 +0000 (21:12 +0000)]
Crash when calling WKPageClose on the originated page from within createNewPage callback
https://bugs.webkit.org/show_bug.cgi?id=139099
<rdar://problem/
19052564>
Reviewed by Sam Weinig.
Source/WebKit2:
Null check the namespace ID.
* UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::cloneSessionStorageNamespaceInternal):
Tools:
Add a test.
* TestWebKitAPI/PlatformWebView.h:
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp: Added.
(TestWebKitAPI::runJavaScriptAlert):
(TestWebKitAPI::createNewPage):
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WebKit2/close-from-within-create-page.html: Added.
* TestWebKitAPI/mac/PlatformWebViewMac.mm:
(TestWebKitAPI::PlatformWebView::PlatformWebView):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176574
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Sat, 29 Nov 2014 17:47:35 +0000 (17:47 +0000)]
Add a stubbed out WebVisitedLinkStore class on Windows
https://bugs.webkit.org/show_bug.cgi?id=139078
Reviewed by Sam Weinig.
Source/WebKit:
* WebKit.vcxproj/WebKit/WebKit.vcxproj:
Source/WebKit/win:
* WebCoreSupport/WebVisitedLinkStore.cpp: Added.
(WebVisitedLinkStore::shared):
(WebVisitedLinkStore::WebVisitedLinkStore):
(WebVisitedLinkStore::~WebVisitedLinkStore):
(WebVisitedLinkStore::isLinkVisited):
(WebVisitedLinkStore::addVisitedLink):
* WebCoreSupport/WebVisitedLinkStore.h: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176573
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
gyuyoung.kim@samsung.com [Sat, 29 Nov 2014 07:11:50 +0000 (07:11 +0000)]
Use std::unique_ptr<>|make_unique<> in ftl, bytecode of JSC
https://bugs.webkit.org/show_bug.cgi?id=139063
Reviewed by Andreas Kling.
Clean up OwnPtr and PassOwnPtr in JSC.
* bytecode/StructureStubClearingWatchpoint.cpp:
(JSC::StructureStubClearingWatchpoint::push):
* bytecode/StructureStubClearingWatchpoint.h:
(JSC::StructureStubClearingWatchpoint::StructureStubClearingWatchpoint):
* ftl/FTLCompile.cpp:
(JSC::FTL::mmAllocateDataSection):
* ftl/FTLJITFinalizer.h:
* ftl/FTLLink.cpp:
(JSC::FTL::link):
* parser/SourceProviderCacheItem.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176572
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 29 Nov 2014 06:20:25 +0000 (06:20 +0000)]
Move the '-webkit-initial-letter', '-webkit-line-box-contain' and '-webkit-text-stroke-width' CSS properties to the new StyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=139053
Patch by Sam Weinig <sam@webkit.org> on 2014-11-28
Reviewed by Andreas Kling.
* css/CSSPropertyNames.in:
* css/StyleBuilderConverter.h:
(WebCore::StyleBuilderConverter::convertInitialLetter):
(WebCore::StyleBuilderConverter::convertTextStrokeWidth):
(WebCore::StyleBuilderConverter::convertLineBoxContain):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176571
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy_horton@apple.com [Fri, 28 Nov 2014 22:10:24 +0000 (22:10 +0000)]
Stale userData is handed to WKView _actionMenuItemsForHitTestResult under prepareForMenu
https://bugs.webkit.org/show_bug.cgi?id=139069
<rdar://problem/
19075587>
Reviewed by Sam Weinig.
* UIProcess/mac/WKActionMenuController.mm:
(-[WKActionMenuController wkView:willHandleMouseDown:]):
(-[WKActionMenuController didCloseMenu:withEvent:]):
(-[WKActionMenuController _clearActionMenuState]):
Previously, _userData was not being cleared in didCloseMenu, so a subsequent
action menu invocation would end up sending stale userData to _actionMenuItemsForHitTestResult.
Additionally, factor all of the cleanup code out into _clearActionMenuState,
and call it from both wkView:willHandleMouseDown: and didCloseMenu:withEvent:.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176570
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy_horton@apple.com [Fri, 28 Nov 2014 22:09:01 +0000 (22:09 +0000)]
DataDetectors PageOverlay callbacks are never called
https://bugs.webkit.org/show_bug.cgi?id=139067
<rdar://problem/
19086676>
Reviewed by Anders Carlsson.
* Shared/mac/ActionMenuHitTestResult.mm:
(WebKit::ActionMenuHitTestResult::encode):
(WebKit::ActionMenuHitTestResult::decode):
Encode/decode the PageOverlay ID.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176569
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Fri, 28 Nov 2014 18:39:13 +0000 (18:39 +0000)]
Allow clients of the WKRenderLayerRef C SPI to connect layer trees across frame boundaries
https://bugs.webkit.org/show_bug.cgi?id=139021
Reviewed by Dan Bernstein.
Add WKRenderLayerGetFrameContentsLayer which returns a WKRenderLayerRef for
the content document of a RenderWidget, if its has one (e.g. frames, iframes
and <object> with document contents).
* Shared/API/c/WKRenderLayer.cpp:
(WKRenderLayerGetFrameContentsLayer):
* Shared/API/c/WKRenderLayer.h:
* Shared/UserMessageCoders.h:
(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):
* Shared/WebRenderLayer.cpp:
(WebKit::WebRenderLayer::create):
(WebKit::WebRenderLayer::WebRenderLayer):
* Shared/WebRenderLayer.h:
(WebKit::WebRenderLayer::frameContentsLayer):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176568
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 28 Nov 2014 17:05:45 +0000 (17:05 +0000)]
Unreviewed, rolling out r176564.
https://bugs.webkit.org/show_bug.cgi?id=139093
massive failures on release test bot (Requested by philn on
#webkit).
Reverted changeset:
"[GStreamer] Bump internal jhbuild versions to 1.4.4"
https://bugs.webkit.org/show_bug.cgi?id=138866
http://trac.webkit.org/changeset/176564
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176567
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Fri, 28 Nov 2014 16:39:36 +0000 (16:39 +0000)]
[GTK] Use GMainLoopSource in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=138831
Reviewed by Sergio Villar Senin.
* WebKitTestRunner/InjectedBundle/TestRunner.h:
* WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
(WTR::TestRunner::platformInitialize):
(WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
(WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
(WTR::waitToDumpWatchdogTimerCallback): Deleted.
* WebKitTestRunner/gtk/TestControllerGtk.cpp:
(WTR::TestController::notifyDone):
(WTR::TestController::platformRunUntil):
(WTR::cancelTimeout): Deleted.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176566
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Fri, 28 Nov 2014 15:27:47 +0000 (15:27 +0000)]
[CMake] Build failure against GStreamer git master
https://bugs.webkit.org/show_bug.cgi?id=138872
Reviewed by Csaba Osztrogon.
* Source/cmake/FindGStreamer.cmake: Simplified the
FIND_GSTREAMER_COMPONENT macro. Trust pkg-config for include
headers lookup, there's no need to do this manually. Also
explicitely check the version specified in GStreamer_FIND_VERSION.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176565
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Fri, 28 Nov 2014 14:42:50 +0000 (14:42 +0000)]
[GStreamer] Bump internal jhbuild versions to 1.4.4
https://bugs.webkit.org/show_bug.cgi?id=138866
Reviewed by Carlos Garcia Campos.
* gtk/jhbuild.modules:
* gtk/patches/gst-events-arent-gstobjects.patch: Removed.
* gtk/patches/gst-plugins-base-fix-build-gcc-4.9-x86.patch: Removed.
* gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176564
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Fri, 28 Nov 2014 14:29:26 +0000 (14:29 +0000)]
[GTK] Use custom JavaScript instead of DBus to implement WebProcess tests
https://bugs.webkit.org/show_bug.cgi?id=138834
Reviewed by Sergio Villar Senin.
It makes everyting simpler and the tests run faster too, since we
don't need to spawn the private bus and wait until the DBus name
is registered. The web extension registers a new JavaSCript class
with a status method to run the tests, similar to the DBus
method. In the UI process side, tests use webkit_web_view_run_java_script()
instead of sending a DBus message.
* TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
* TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:
(WebKitDOMNodeFilterTest::create):
(WebKitDOMNodeFilterTest::testTreeWalker):
(WebKitDOMNodeFilterTest::testNodeIterator):
(WebKitDOMNodeFilterTest::webPageFromArgs): Deleted.
(WebKitDOMNodeFilterTest::runTest): Deleted.
* TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
(WebKitDOMNodeTest::create):
(WebKitDOMNodeTest::testHierarchyNavigation):
(WebKitDOMNodeTest::testInsertion):
(WebKitDOMNodeTest::testTagNames):
(WebKitDOMNodeTest::webPageFromArgs): Deleted.
(WebKitDOMNodeTest::runTest): Deleted.
* TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp:
(WebKitDOMXPathNSResolverTest::create):
(WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
(WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
(WebKitDOMXPathNSResolverTest::webPageFromArgs): Deleted.
(WebKitDOMXPathNSResolverTest::runTest): Deleted.
* TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp:
(WebKitFrameTest::create):
(WebKitFrameTest::testMainFrame):
(WebKitFrameTest::testURI):
(WebKitFrameTest::testJavaScriptContext):
(WebKitFrameTest::webPageFromArgs): Deleted.
(WebKitFrameTest::runTest): Deleted.
* TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
(testWebKitDOMNodeHierarchyNavigation):
(testWebKitDOMNodeInsertion):
(testWebKitDOMNodeTagNames):
(beforeAll):
(afterAll):
* TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNodeFilter.cpp:
(runTest):
(beforeAll):
(afterAll):
* TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp:
(testWebKitDOMXPathNSResolverNative):
(testWebKitDOMXPathNSResolverCustom):
(beforeAll):
(afterAll):
(runTest): Deleted.
* TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp:
(webkitFrameTestRun):
(beforeAll):
(afterAll):
* TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
(testsMap):
(WebProcessTest::add):
(WebProcessTest::create):
(runTest):
(windowObjectClearedCallback):
(webkit_web_extension_initialize):
(methodCallCallback): Deleted.
(webkit_web_extension_initialize_with_user_data): Deleted.
* TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
* TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.cpp: Removed.
* TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.h: Removed.
* TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
(WebViewTest::runWebProcessTest):
* TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176563
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Fri, 28 Nov 2014 13:41:46 +0000 (13:41 +0000)]
[EFL] libseccomp should pick up CC environment variable to be conform to other jhbuild modules
https://bugs.webkit.org/show_bug.cgi?id=139086
Reviewed by Gyuyoung Kim.
* efl/jhbuild.modules:
* efl/patches/libseccomp-pick-up-CC.patch: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176562
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Fri, 28 Nov 2014 11:05:11 +0000 (11:05 +0000)]
[GStreamer] HTTP source element lacks SCHEDULING query support
https://bugs.webkit.org/show_bug.cgi?id=139064
Reviewed by Carlos Garcia Campos.
No new tests, covered by http/tests/media/hls.
* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webKitWebSrcQueryWithParent): Make the element handle SCHEDULING
queries with the BANDWIDTH_LIMITED flag. This helps uridecodebin
to configure itself for adaptive streaming playback scenarios.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176561
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 28 Nov 2014 09:50:18 +0000 (09:50 +0000)]
[EFL] Add warning if CMake version is too old for building with ninja.
https://bugs.webkit.org/show_bug.cgi?id=139055
Patch by Bartlomiej Gajda <b.gajda@samsung.com> on 2014-11-28
Reviewed by Gyuyoung Kim.
CMake need to be >= 2.8.10 to build WebKit using ninja, some repos don't have
that version in their repositories.
* efl/install-dependencies:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176560
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Fri, 28 Nov 2014 09:10:41 +0000 (09:10 +0000)]
[WK2] SecComp buildfix after r176452
https://bugs.webkit.org/show_bug.cgi?id=139081
Reviewed by Antti Koivisto.
* Shared/linux/SeccompFilters/SeccompBroker.cpp:
(WebKit::SeccompBrokerClient::dispatch):
(WebKit::SeccompBroker::runLoop):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176559
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Fri, 28 Nov 2014 09:09:44 +0000 (09:09 +0000)]
Fix -Wc++11-narrowing error in SeccompFilters.cpp
https://bugs.webkit.org/show_bug.cgi?id=139079
Reviewed by Carlos Garcia Campos.
* Shared/linux/SeccompFilters/SeccompFilters.cpp:
(WebKit::SeccompFilters::addRule):
* Shared/linux/SeccompFilters/SeccompFilters.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176558
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Fri, 28 Nov 2014 09:04:21 +0000 (09:04 +0000)]
[WK2] SecComp buildfix after r168605 and r168999
https://bugs.webkit.org/show_bug.cgi?id=139080
Reviewed by Carlos Garcia Campos.
* Shared/linux/SeccompFilters/SyscallPolicy.cpp:
(WebKit::SyscallPolicy::addDefaultWebProcessPolicy):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176557
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 28 Nov 2014 09:00:54 +0000 (09:00 +0000)]
[ATK] Allowing the use of AccessibilityUIElement::columnHeaders method for table.
https://bugs.webkit.org/show_bug.cgi?id=139044
Patch by Andrzej Badowski <a.badowski@samsung.com> on 2014-11-28
Reviewed by Chris Fleizach.
ATK method AccessibilityUIElement::columnHeaders currently focused only on the object table cell.
The proposed solution will enable the use of this method for the object table.
Existing test shows the result.
Tools:
* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::columnHeaders):
LayoutTests:
* accessibility/table-column-headers-with-captions.html: Updated for ATK platform.
* platform/efl/accessibility/table-column-headers-with-captions-expected.txt: Added.
* platform/gtk/TestExpectations: Updated for GTK.
* platform/gtk/accessibility/table-column-headers-with-captions-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176556
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ryuan.choi@navercorp.com [Fri, 28 Nov 2014 07:04:09 +0000 (07:04 +0000)]
[EFL] Remove E_Dbus dependency
https://bugs.webkit.org/show_bug.cgi?id=136355
Reviewed by Gyuyoung Kim.
.:
* Source/cmake/FindE_DBus.cmake: Removed.
* Source/cmake/OptionsEfl.cmake:
Source/WebCore:
E_Dbus is the simple wrapper of Dbus but it has not been maintained since EFL 1.8.
Instead, EFL introduced Eldbus, which is almost similar with E_Dbus but provides more dbus like interface.
This patch replaces E_Dbus implementation to Eldbus.
* PlatformEfl.cmake:
* platform/efl/BatteryProviderEfl.cpp:
(WebCore::BatteryProviderEfl::BatteryProviderEfl):
(WebCore::BatteryProviderEfl::~BatteryProviderEfl):
(WebCore::BatteryProviderEfl::stopUpdating):
(WebCore::batteryProperties):
(WebCore::batteryPropertiesChanged):
(WebCore::BatteryProviderEfl::deviceTypeCallback):
(WebCore::BatteryProviderEfl::enumerateDevices):
(WebCore::BatteryProviderEfl::startUpdating):
(WebCore::BatteryProviderEfl::setBatteryStatus):
(WebCore::BatteryProviderEfl::timerFired): Deleted.
(WebCore::BatteryProviderEfl::getBatteryStatus): Deleted.
(WebCore::BatteryProviderEfl::setBatteryClient): Deleted.
* platform/efl/BatteryProviderEfl.h:
(WebCore::BatteryProviderEfl::connection):
(WebCore::BatteryProviderEfl::setSignalHandler):
(WebCore::BatteryProviderEfl::~BatteryProviderEfl): Deleted.
Source/WebKit2:
* UIProcess/API/efl/ewk_main.cpp: Added init/shutdown for eldbus.
(WebKit::EwkMain::initialize):
(WebKit::EwkMain::finalize):
(WebKit::EwkMain::shutdownInitializedEFLModules):
Tools:
* MiniBrowser/efl/CMakeLists.txt: Removed E_DBUS includes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176555
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Fri, 28 Nov 2014 01:40:01 +0000 (01:40 +0000)]
CrashTracer: com.apple.WebKit.WebContent at com.apple.WebCore: WebCore::HTMLPlugInImageElement::updateSnapshot + 108
https://bugs.webkit.org/show_bug.cgi?id=139057
Reviewed by Anders Carlsson.
No test, don't know how to repro.
* html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::updateSnapshot): Null check the renderer.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176554
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
gyuyoung.kim@samsung.com [Fri, 28 Nov 2014 00:51:32 +0000 (00:51 +0000)]
Use std::unique_ptr instead of OwnPtr in JSC classes
https://bugs.webkit.org/show_bug.cgi?id=139009
Reviewed by Filip Pizlo.
As a step of using std::unique_ptr<>, this patch replaces OwnPtr with
std::unique_ptr<>|std::make_unique<>.
* bytecode/DFGExitProfile.cpp:
(JSC::DFG::ExitProfile::add):
* bytecode/DFGExitProfile.h:
* bytecode/LazyOperandValueProfile.cpp:
(JSC::CompressedLazyOperandValueProfileHolder::add):
* bytecode/LazyOperandValueProfile.h:
* heap/MarkedBlock.cpp:
(JSC::MarkedBlock::specializedSweep):
(JSC::MarkedBlock::stopAllocating):
* heap/MarkedBlock.h:
(JSC::MarkedBlock::clearNewlyAllocated):
* inspector/ContentSearchUtilities.cpp:
(Inspector::ContentSearchUtilities::findMagicComment):
* runtime/RegExp.cpp:
(JSC::RegExp::invalidateCode):
* runtime/RegExp.h:
* yarr/RegularExpression.cpp:
(JSC::Yarr::RegularExpression::Private::compile):
(JSC::Yarr::RegularExpression::isValid):
* yarr/YarrInterpreter.cpp:
(JSC::Yarr::ByteCompiler::compile):
(JSC::Yarr::ByteCompiler::regexBegin):
(JSC::Yarr::byteCompile):
* yarr/YarrInterpreter.h:
(JSC::Yarr::BytecodePattern::BytecodePattern):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176553
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jdiggs@igalia.com [Fri, 28 Nov 2014 00:24:43 +0000 (00:24 +0000)]
AX: [ATK] Meter and Option elements do not expose their id attribute
https://bugs.webkit.org/show_bug.cgi?id=139017
Reviewed by Mario Sanchez Prada.
Source/WebCore:
The options in a collapsed select element lack a node, so get the id
attribute from the associated action element. In the case of a meter,
the meter element itself is not exposed; its RenderMeter is instead.
So associate the meter element's id with the exposed RenderMeter.
No new tests. Instead, updated existing expectations to reflect the fix.
* accessibility/AccessibilityObject.h:
* accessibility/AccessibilityProgressIndicator.cpp:
(WebCore::AccessibilityProgressIndicator::element):
* accessibility/AccessibilityProgressIndicator.h:
* accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(webkitAccessibleGetAttributes):
LayoutTests:
* accessibility/roles-exposed.html: Unskipped the meter element test.
* platform/efl/accessibility/roles-exposed-expected.txt: Updated to reflect fixes.
* platform/gtk/accessibility/roles-exposed-expected.txt: Updated to reflect fixes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176552
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 27 Nov 2014 18:00:10 +0000 (18:00 +0000)]
Add a stubbed out WebVisitedLinkStore to WebViewGroup
https://bugs.webkit.org/show_bug.cgi?id=139066
Reviewed by Antti Koivisto.
Source/WebKit:
* WebKit.xcodeproj/project.pbxproj:
Source/WebKit/mac:
* WebCoreSupport/WebViewGroup.h:
(WebViewGroup::visitedLinkStore):
* WebCoreSupport/WebViewGroup.mm:
(WebViewGroup::WebViewGroup):
* WebCoreSupport/WebVisitedLinkStore.h: Copied from Source/WebKit/mac/WebCoreSupport/WebViewGroup.h.
* WebCoreSupport/WebVisitedLinkStore.mm: Copied from Source/WebKit/mac/WebCoreSupport/WebViewGroup.h.
(WebVisitedLinkStore::create):
(WebVisitedLinkStore::WebVisitedLinkStore):
(WebVisitedLinkStore::~WebVisitedLinkStore):
(WebVisitedLinkStore::isLinkVisited):
(WebVisitedLinkStore::addVisitedLink):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176551
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 27 Nov 2014 17:58:41 +0000 (17:58 +0000)]
Add a Page::setVisitedLinkStore member function
https://bugs.webkit.org/show_bug.cgi?id=139065
Reviewed by Antti Koivisto.
This will be used in a subsequent commit.
* WebCore.exp.in:
* page/Page.cpp:
(WebCore::Page::setVisitedLinkStore):
* page/Page.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176550
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 27 Nov 2014 12:04:51 +0000 (12:04 +0000)]
[GTK] Unreviewed GTK gardening.
https://bugs.webkit.org/show_bug.cgi?id=139061
rebaseline after r176354.
Patch by Hunseop Jeong <hs85.jeong@samsung.com> on 2014-11-27
* platform/gtk/fast/multicol/tall-image-behavior-expected.png: Added.
* platform/gtk/fast/multicol/tall-image-behavior-expected.txt: Added.
* platform/gtk/fast/multicol/tall-image-behavior-lr-expected.png: Added.
* platform/gtk/fast/multicol/tall-image-behavior-lr-expected.txt: Added.
* platform/gtk/fast/multicol/tall-image-behavior-rl-expected.png: Added.
* platform/gtk/fast/multicol/tall-image-behavior-rl-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176549
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
agomez@igalia.com [Thu, 27 Nov 2014 11:39:33 +0000 (11:39 +0000)]
Web Inspector: Update NavigationItemProbes icon for the GTK+ port
https://bugs.webkit.org/show_bug.cgi?id=139074
Reviewed by Carlos Garcia Campos.
NavigationItemProbes was updated for the Mac port and we are now
having a similar ideogram in GTK+.
* UserInterface/Images/gtk/NavigationItemProbes.svg: Updated.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176548
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 26 Nov 2014 13:39:20 +0000 (13:39 +0000)]
[EFL] Unreviewed EFL gardening after r176354.
https://bugs.webkit.org/show_bug.cgi?id=139060
rebaseline after r176354.
Patch by Hunseop Jeong <hs85.jeong@samsung.com> on 2014-11-26
* platform/efl/fast/multicol/tall-image-behavior-expected.png: Added.
* platform/efl/fast/multicol/tall-image-behavior-expected.txt: Added.
* platform/efl/fast/multicol/tall-image-behavior-lr-expected.png: Added.
* platform/efl/fast/multicol/tall-image-behavior-lr-expected.txt: Added.
* platform/efl/fast/multicol/tall-image-behavior-rl-expected.png: Added.
* platform/efl/fast/multicol/tall-image-behavior-rl-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176547
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 26 Nov 2014 08:08:17 +0000 (08:08 +0000)]
[EFL][GTK] Bump up FDE relocation fixing patch to version accepted to LLVM trunk.
https://bugs.webkit.org/show_bug.cgi?id=139047
Patch by Akos Kiss <akiss@inf.u-szeged.hu> on 2014-11-26
Reviewed by Carlos Garcia Campos.
* efl/jhbuild.modules:
* efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Added.
* efl/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Removed.
* gtk/jhbuild-optional.modules:
* gtk/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Added.
* gtk/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176546
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 26 Nov 2014 00:27:52 +0000 (00:27 +0000)]
Add parsing for :dir()
https://bugs.webkit.org/show_bug.cgi?id=138932
Patch by Sukolsak Sakshuwong <sukolsak@gmail.com> on 2014-11-25
Reviewed by Benjamin Poulain.
Source/WebCore:
Add support for parsing :dir() pseudo class. The implementation of selector
matching will be in a follow-up patch.
* css/CSSGrammar.y.in:
* css/CSSParser.cpp:
(WebCore::CSSParser::detectFunctionTypeToken):
* css/CSSSelector.cpp:
(WebCore::appendPseudoClassFunctionTail):
(WebCore::CSSSelector::selectorText):
* css/CSSSelector.h:
* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne):
* css/SelectorPseudoClassAndCompatibilityElementMap.in:
* cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::addPseudoClassType):
LayoutTests:
* fast/css/css-selector-text-expected.txt:
* fast/css/css-selector-text.html:
* fast/css/css-set-selector-text-expected.txt:
* fast/css/css-set-selector-text.html:
* fast/selectors/invalid-functional-pseudo-class-expected.txt:
* fast/selectors/invalid-functional-pseudo-class.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176545
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 25 Nov 2014 19:50:45 +0000 (19:50 +0000)]
Remove user content handling from PageGroup
https://bugs.webkit.org/show_bug.cgi?id=139051
Reviewed by Antti Koivisto.
Source/WebCore:
Remove m_userContentController from PageGroup and the related functions and symbol exports.
* WebCore.exp.in:
* page/PageGroup.cpp:
(WebCore::PageGroup::PageGroup):
(WebCore::PageGroup::~PageGroup):
(WebCore::PageGroup::addPage):
(WebCore::PageGroup::removePage):
(WebCore::PageGroup::addUserScriptToWorld): Deleted.
(WebCore::PageGroup::addUserStyleSheetToWorld): Deleted.
(WebCore::PageGroup::removeUserScriptFromWorld): Deleted.
(WebCore::PageGroup::removeUserStyleSheetFromWorld): Deleted.
(WebCore::PageGroup::removeUserScriptsFromWorld): Deleted.
(WebCore::PageGroup::removeUserStyleSheetsFromWorld): Deleted.
(WebCore::PageGroup::removeAllUserContent): Deleted.
* page/PageGroup.h:
Source/WebKit/mac:
Use the user content controller in the web view group.
* WebView/WebView.mm:
(-[WebView _injectOutlookQuirksScript]):
Source/WebKit2:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::addUserScript):
(WebKit::InjectedBundle::addUserStyleSheet):
(WebKit::InjectedBundle::removeUserScript):
(WebKit::InjectedBundle::removeUserStyleSheet):
(WebKit::InjectedBundle::removeUserScripts):
(WebKit::InjectedBundle::removeUserStyleSheets):
(WebKit::InjectedBundle::removeAllUserContent):
Talk to the user content controller from the passed in WebPageGroupProxy.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
Create the WebPageGroupProxy before creating the page so we can get its user content controller and
pass it to the page configuration if necessary.
* WebProcess/WebPage/WebPageGroupProxy.cpp:
(WebKit::WebPageGroupProxy::userContentController):
New function that lazily creates a user content controller. We don't want to create this eagerly since
it's not used with the modern API.
(WebKit::WebPageGroupProxy::addUserStyleSheet):
(WebKit::WebPageGroupProxy::addUserScript):
(WebKit::WebPageGroupProxy::removeAllUserStyleSheets):
(WebKit::WebPageGroupProxy::removeAllUserScripts):
(WebKit::WebPageGroupProxy::removeAllUserContent):
Call through to the user content controller.
* WebProcess/WebPage/WebPageGroupProxy.h:
Add an m_userContentController member.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176544
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alex@webkit.org [Tue, 25 Nov 2014 18:05:39 +0000 (18:05 +0000)]
Unreviewed, upload two missing test files in the commit r174677.
* mathml/presentation/mo-stretch-update-expected.html: Added.
* mathml/presentation/mo-stretch-update.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176543
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 25 Nov 2014 16:16:15 +0000 (16:16 +0000)]
Add a user content controller to WebViewGroup and use it for user content
https://bugs.webkit.org/show_bug.cgi?id=139043
Reviewed by Antti Koivisto.
Source/WebCore:
* WebCore.exp.in:
Export symbols.
* page/Page.cpp:
(WebCore::Page::setUserContentController):
Invalidate the injected style cache when setting a new user content controller.
Source/WebKit/mac:
This is another tiny step towards getting rid of user content handling inside PageGroup.
* WebCoreSupport/WebViewGroup.h:
(WebViewGroup::userContentController):
Add a UserContentController member and getter.
* WebCoreSupport/WebViewGroup.mm:
(WebViewGroup::get):
Helper function that returns a WebViewGroup by its name (or null if it doesn't exist).
(WebViewGroup::WebViewGroup):
Create a user content controller.
* WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
Instead of calling -[WebView setGroupName:], create a WebViewGroup before creating the page, that way we can
set its user content controller in the PageConfiguration.
(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
Ditto.
(+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
(+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
(+[WebView _removeUserScriptFromGroup:world:url:]):
(+[WebView _removeUserStyleSheetFromGroup:world:url:]):
(+[WebView _removeUserScriptsFromGroup:world:]):
(+[WebView _removeUserStyleSheetsFromGroup:world:]):
(+[WebView _removeAllUserContentFromGroup:]):
Instead of calling into the PageGroup, get the WebViewGroup's user content controller and call into that.
(-[WebView setGroupName:]):
Set the user content controller to the new WebViewGroup's user content controller.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176542
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Tue, 25 Nov 2014 14:49:30 +0000 (14:49 +0000)]
[GStreamer] gstmpegts is not initialized
https://bugs.webkit.org/show_bug.cgi?id=139039
Reviewed by Carlos Garcia Campos.
* platform/graphics/gstreamer/GStreamerUtilities.cpp:
(WebCore::initializeGStreamer): Initialize the gstmpegts library.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176541
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
berto@igalia.com [Tue, 25 Nov 2014 14:29:09 +0000 (14:29 +0000)]
[GTK] Use LD_LIBRARY_PATH to make g-ir-scanner use the newly-built
version of libraries when running the temporary executable
https://bugs.webkit.org/show_bug.cgi?id=138833
Patch by Ting-Wei Lan <lantw44@gmail.com> on 2014-11-25
Reviewed by Carlos Garcia Campos.
This patch modifies LD_LIBRARY_PATH to make sure the dynamic linker
find the correct version of libraries when running the temporary
executable to generate the .gir file.
* PlatformGTK.cmake:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176540
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 25 Nov 2014 13:48:04 +0000 (13:48 +0000)]
[GTK] Minibrowser: Add support for zoom using Control Key + Mouse scroll
https://bugs.webkit.org/show_bug.cgi?id=138090
Patch by Tanay C <tanay.c@samsung.com> on 2014-11-25
Reviewed by Carlos Garcia Campos.
* MiniBrowser/gtk/BrowserWindow.c: Implementing zoom using Cntrl + Mouse scroll
(browserWindowZoomIn): Added.
(browserWindowZoomOut): Added.
(scrollEventCallback): Added.
(zoomInCallback): Modified.
(zoomOutCallback): Modified.
(browserWindowConstructed): Modified.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176539
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Tue, 25 Nov 2014 09:59:38 +0000 (09:59 +0000)]
[EFL] REGRESSION(r176514): It made performance tests fail
https://bugs.webkit.org/show_bug.cgi?id=139037
Reviewed by Gyuyoung Kim.
Source/WebKit2:
* WebProcess/efl/WebProcessMainEfl.cpp: Don't try to load/shutdown eail if eailLibraryPath() is empty.
Tools:
* Scripts/webkitpy/port/efl.py:
(EflPort.setup_environ_for_server): Pass ACCESSIBILITY_EAIL_LIBRARY_PATH environment variable to WTR.
* efl/jhbuildrc: Set ACCESSIBILITY_EAIL_LIBRARY_PATH to point to DependenciesEFL/lib/libeail.so
only if ACCESSIBILITY_EAIL_LIBRARY_PATH isn't already set and DependenciesEFL/lib/libeail.so exists.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176538
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
evab.u-szeged@partner.samsung.com [Tue, 25 Nov 2014 07:41:27 +0000 (07:41 +0000)]
Fix unused variable warning in Biquad.cpp
https://bugs.webkit.org/show_bug.cgi?id=139031
Reviewed by Andreas Kling.
No new tests needed.
* platform/audio/Biquad.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176537
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
evab.u-szeged@partner.samsung.com [Tue, 25 Nov 2014 07:39:07 +0000 (07:39 +0000)]
Remove Qt cruft related to tap higlighting
https://bugs.webkit.org/show_bug.cgi?id=139030
Reviewed by Andreas Kling.
Source/WebCore:
No new tests needed.
* CMakeLists.txt:
* page/GestureTapHighlighter.cpp: Removed.
* page/GestureTapHighlighter.h: Removed.
Source/WebKit2:
* CMakeLists.txt:
* WebProcess/WebPage/TapHighlightController.cpp: Removed.
* WebProcess/WebPage/TapHighlightController.h: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176536
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 25 Nov 2014 05:26:27 +0000 (05:26 +0000)]
Fix the parsing and re-serialization of :lang pseudo class selector when it has multiple arguments with same value
https://bugs.webkit.org/show_bug.cgi?id=139013
Patch by Dhi Aurrahman <diorahman@rockybars.com> on 2014-11-24
Reviewed by Benjamin Poulain.
Source/WebCore:
Fix the parsing and re-serialization of :lang pseudo class selector when
it has multiple arguments with same value e.g. :lang(en, en, en). Previously,
given :lang(en, en, en) selector, it was parsed and reserialized
as :lang(enenen) instead of :lang(en, en, en)
Related test on parsing and re-serialization of css selectors is updated.
* css/CSSSelector.cpp:
(WebCore::appendArgumentList):
LayoutTests:
Updated tests to verify the parsing and serialization of :lang pseudo class
selector when it has multiple arguments with same value.
* fast/css/css-selector-text-expected.txt: Updated to cover fix.
* fast/css/css-selector-text.html: Updated to cover fix.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176535
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zalan@apple.com [Tue, 25 Nov 2014 03:47:57 +0000 (03:47 +0000)]
Fix r176527. Iterate through the text renderers.
https://bugs.webkit.org/show_bug.cgi?id=139007
Reviewed by Antti Koivisto.
* rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::canUseFor):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176534
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
gyuyoung.kim@samsung.com [Tue, 25 Nov 2014 02:40:06 +0000 (02:40 +0000)]
Clean up OwnPtr and PassOwnPtr in JSC - bytecode, jit, inspector, and interpreter
https://bugs.webkit.org/show_bug.cgi?id=139022
Reviewed by Filip Pizlo.
As a step of using std::unique_ptr<>, this patch replaces OwnPtr with
std::unique_ptr<>|std::make_unique<>.
* bytecode/DFGExitProfile.cpp:
(JSC::DFG::ExitProfile::add):
* bytecode/DFGExitProfile.h:
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::linkFunction):
* dfg/DFGJITFinalizer.cpp:
(JSC::DFG::JITFinalizer::JITFinalizer):
* dfg/DFGJITFinalizer.h:
* heap/IncrementalSweeper.h:
* inspector/ContentSearchUtilities.cpp:
(Inspector::ContentSearchUtilities::findMagicComment):
* inspector/agents/InspectorDebuggerAgent.h:
* inspector/agents/JSGlobalObjectRuntimeAgent.h:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::enableSampler):
* interpreter/Interpreter.h:
* jit/ExecutableAllocator.cpp:
(JSC::ExecutableAllocator::ExecutableAllocator):
* jit/ExecutableAllocator.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176533
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
gyuyoung.kim@samsung.com [Tue, 25 Nov 2014 01:37:39 +0000 (01:37 +0000)]
Unreviewed, EFL build fix since r176530.
* UIProcess/CoordinatedGraphics/WebView.cpp: Replace pointer with reference.
(WebKit::WebView::processDidExit):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176532
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zalan@apple.com [Tue, 25 Nov 2014 01:00:57 +0000 (01:00 +0000)]
Simple line layout: Rename TextFragment::mustBreak to TextFragment::isLineBreak
https://bugs.webkit.org/show_bug.cgi?id=139035
Reviewed by Antti Koivisto.
Move new line logic to FlowContents class.
This is in preparation to support <br>.
No change in functionality.
* rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::TextFragment::TextFragment):
(WebCore::SimpleLineLayout::removeTrailingWhitespace):
(WebCore::SimpleLineLayout::nextFragment):
(WebCore::SimpleLineLayout::createLineRuns):
* rendering/SimpleLineLayoutFlowContents.h:
(WebCore::SimpleLineLayout::FlowContents::isNewline):
(WebCore::SimpleLineLayout::FlowContents::isNewlineCharacter): Deleted.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176531
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
benjamin@webkit.org [Tue, 25 Nov 2014 00:26:35 +0000 (00:26 +0000)]
[WK2] Remove some bad stuff from WebPageProxy
https://bugs.webkit.org/show_bug.cgi?id=138896
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-11-24
Reviewed by Sam Weinig.
The state loadStateAtProcessExit does not seem to be used anywhere.
The state urlAtProcessExit only exists to forward the url from
WebPageProxy::resetStateAfterProcessExited() to the coordinated graphics code
WebView::processDidExit().
* UIProcess/CoordinatedGraphics/WebView.cpp:
(WebKit::WebView::processDidExit):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::resetStateAfterProcessExited):
* UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::urlAtProcessExit): Deleted.
(WebKit::WebPageProxy::loadStateAtProcessExit): Deleted.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176530
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
benjamin@webkit.org [Tue, 25 Nov 2014 00:20:35 +0000 (00:20 +0000)]
Move :placeholder-shown out of experimental
https://bugs.webkit.org/show_bug.cgi?id=138998
Reviewed by Andreas Kling.
The pseudo class :placeholder-shown is used by the inspector, disabling it breaks
the sidebar.
The implementation has been stable for a while, we can move it to stable.
* css/CSSSelector.cpp:
(WebCore::CSSSelector::selectorText):
* css/CSSSelector.h:
* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne):
* css/SelectorPseudoClassAndCompatibilityElementMap.in:
* cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::addPseudoClassType):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementMatching):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementHasPlaceholderShown):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176529
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Tue, 25 Nov 2014 00:15:46 +0000 (00:15 +0000)]
Avoid String concatenation with line break iterator
https://bugs.webkit.org/show_bug.cgi?id=139034
Reviewed by Zalan Bujtas.
Source/WebCore:
Test: fast/text/simple-lines-multiple-renderers-break.html
* rendering/SimpleLineLayoutFlowContents.cpp:
(WebCore::SimpleLineLayout::initializeSegments):
Include String too so it doesn't need to be fetched from the renderer.
(WebCore::SimpleLineLayout::FlowContents::FlowContents):
(WebCore::SimpleLineLayout::FlowContents::findNextBreakablePosition):
Make this iterative instead of recursive.
Uset setPriorContext to provide previous characters instead of concatenating
the string from all the previous segments.
(WebCore::SimpleLineLayout::findNextNonWhitespace):
(WebCore::SimpleLineLayout::FlowContents::findNextNonWhitespacePosition):
Search using segments instead of the concatenated string.
(WebCore::SimpleLineLayout::FlowContents::textWidth):
(WebCore::SimpleLineLayout::FlowContents::segmentIndexForPositionSlow):
(WebCore::SimpleLineLayout::FlowContents::runWidth):
(WebCore::SimpleLineLayout::FlowContents::segmentForPositionSlow): Deleted.
(WebCore::SimpleLineLayout::FlowContents::appendNextRendererContentIfNeeded): Deleted.
(WebCore::SimpleLineLayout::FlowContents::nextNonWhitespacePosition): Deleted.
* rendering/SimpleLineLayoutFlowContents.h:
(WebCore::SimpleLineLayout::FlowContents::characterAt):
(WebCore::SimpleLineLayout::FlowContents::isNewlineCharacter):
(WebCore::SimpleLineLayout::FlowContents::segmentIndexForPosition):
(WebCore::SimpleLineLayout::FlowContents::segmentForPosition):
LayoutTests:
Test that there is no implicit break point between Text nodes.
* fast/text/simple-lines-multiple-renderers-break-expected.html: Added.
* fast/text/simple-lines-multiple-renderers-break.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176528
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zalan@apple.com [Tue, 25 Nov 2014 00:10:17 +0000 (00:10 +0000)]
SimpleLineLayout::canUseFor() should iterate through RenderTexts to check if their content is eligible for simple line layout.
https://bugs.webkit.org/show_bug.cgi?id=139007
Reviewed by Antti Koivisto.
Source/WebCore:
Tests: fast/text/simple-line-layout-multiple-renderers-non-breaking-space.html
fast/text/simple-line-layout-multiple-renderers-with-float.html
* rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::canUseFor):
LayoutTests:
* fast/text/simple-line-layout-multiple-renderers-non-breaking-space-expected.html: Added.
* fast/text/simple-line-layout-multiple-renderers-non-breaking-space.html: Added.
* fast/text/simple-line-layout-multiple-renderers-with-float-expected.html: Added.
* fast/text/simple-line-layout-multiple-renderers-with-float.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176527
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 25 Nov 2014 00:05:27 +0000 (00:05 +0000)]
[GTK] update-webkitgtk-libs fails to build fontconfig
https://bugs.webkit.org/show_bug.cgi?id=139032
Patch by Michael Catanzaro <mcatanzaro@igalia.com> on 2014-11-24
Reviewed by Martin Robinson.
On Fedora, if docbook-utils is installed but docbook-utils-pdf is not,
fontconfig will try to generate documentation and fail.
* gtk/install-dependencies:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176526
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zalan@apple.com [Mon, 24 Nov 2014 23:56:37 +0000 (23:56 +0000)]
Simple line layout: fast/text/simple-lines-multiple-renderers test has the wrong content.
https://bugs.webkit.org/show_bug.cgi?id=139036
Swap simple-lines-multiple-renderers.html and simple-lines-multiple-renderers-expected.html
* fast/text/simple-lines-multiple-renderers-expected.html:
* fast/text/simple-lines-multiple-renderers.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176525
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Mon, 24 Nov 2014 22:12:53 +0000 (22:12 +0000)]
Move the '-webkit-box-reflext' CSS property to the new StyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=139008
Reviewed by Anders Carlsson.
* css/CSSPropertyNames.in:
* css/StyleBuilderConverter.h:
(WebCore::StyleBuilderConverter::convertReflection):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176524
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Mon, 24 Nov 2014 22:09:06 +0000 (22:09 +0000)]
Stub out user content WebView member functions on Windows
https://bugs.webkit.org/show_bug.cgi?id=139033
Reviewed by Sam Weinig.
These functions aren't used by any clients and hinder getting rid of PageGroup.
If it turns out they're still needed we can copy the user content controller code from Mac Legacy WebKit.
* WebView.cpp:
(WebView::addUserScriptToGroup):
(WebView::addUserStyleSheetToGroup):
(WebView::removeUserScriptFromGroup):
(WebView::removeUserStyleSheetFromGroup):
(WebView::removeUserScriptsFromGroup):
(WebView::removeUserStyleSheetsFromGroup):
(WebView::removeAllUserContentFromGroup):
(toStringVector): Deleted.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176523
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ryuan.choi@navercorp.com [Mon, 24 Nov 2014 20:48:49 +0000 (20:48 +0000)]
[EFL] REGRESSION(176066): It made all performance tests fail
https://bugs.webkit.org/show_bug.cgi?id=138865
Reviewed by Csaba Osztrogonác.
Since r176066, there are crash because evas_gl_surface is destroyed with
invalid evas_gl instance after evas_gl is destroyed.
* UIProcess/API/efl/EwkView.cpp:
(EwkView::~EwkView):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176522
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Mon, 24 Nov 2014 18:07:13 +0000 (18:07 +0000)]
Remove unused Style struct from SimpleLineLayout.cpp
https://bugs.webkit.org/show_bug.cgi?id=139027
Reviewed by Sam Weinig.
It was moved to FlowContents.
* rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::Style::Style): Deleted.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176521
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 24 Nov 2014 17:02:25 +0000 (17:02 +0000)]
[Curl] Compile error in ResourceHandleManager.cpp.
https://bugs.webkit.org/show_bug.cgi?id=139026
Patch by peavo@outlook.com <peavo@outlook.com> on 2014-11-24
Reviewed by Brent Fulgham.
The parameter types of the constructor of the Timer class has changed.
* platform/network/curl/ResourceHandleManager.cpp:
(WebCore::ResourceHandleManager::ResourceHandleManager):
(WebCore::ResourceHandleManager::downloadTimerCallback):
* platform/network/curl/ResourceHandleManager.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176520
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
berto@igalia.com [Mon, 24 Nov 2014 14:49:39 +0000 (14:49 +0000)]
Webkit2 doesnt build on powerpc 32 bits
https://bugs.webkit.org/show_bug.cgi?id=130837
Reviewed by Carlos Garcia Campos.
Check if libatomic is needed in order to use std::atomic, and add
it to the list of WebKit2 libraries.
* PlatformGTK.cmake:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176519
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Mon, 24 Nov 2014 12:45:13 +0000 (12:45 +0000)]
.:
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.7.1 release.
* Source/cmake/OptionsGTK.cmake: Bump version numbers.
Source/WebKit2:
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.7.2 release.
* gtk/NEWS: Add release notes for 2.7.2.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176517
268f45cc-cd09-0410-ab3c-
d52691b4dbfc