WebKit-https.git
10 years agoCSS Exclusions polygon shape arguments should be comma separated
commit-queue@webkit.org [Fri, 6 Apr 2012 01:18:10 +0000 (01:18 +0000)]
CSS Exclusions polygon shape arguments should be comma separated
https://bugs.webkit.org/show_bug.cgi?id=82368

Patch by Hans Muller <hmuller@adobe.com> on 2012-04-05
Reviewed by Ryosuke Niwa.

Source/WebCore:

Changed the CSS Parser to accept a conventional comma separated argument list for the
polygon exclusion shape. The syntax had used spaces to separate x,y coordinates, like:
polygon(10px,20px 30px,40px).  Now commas separate points: polygon(10px 20px, 30px 40px).
This change is per the draft exclusions spec, http://dev.w3.org/csswg/css3-exclusions.
Additional relevant information about CSS argument list syntax can be found
here: http://dev.w3.org/csswg/css3-values/#component-whitespace.

Factored comma recognition idiom in CSSParser.cpp into isComma() utility function.

The existing tests have been updated.

* css/CSSParser.cpp:
(WebCore::isComma)
(WebCore::CSSParser::parseFillPosition)
(WebCore::CSSParser::parseFillRepeat)
(WebCore::CSSParser::parseFillProperty)
(WebCore::CSSParser::parseCubicBezierTimingFunctionValue)
(WebCore::CSSParser::parseAnimationTimingFunction)
(WebCore::CSSParser::parseAnimationProperty)
(WebCore::CSSParser::parseExclusionShapePolygon)
(WebCore::CSSParser::parseDeprecatedGradient)
(WebCore::CSSParser::parseRadialGradient)
(WebCore::CSSParser::parseGradientColorStops)
(WebCore::CSSParser::parseImageSet)
(WebCore::filterInfoForName)
(WebCore::CSSParser::parseCustomFilter)
(WebCore::CSSParser::parseFontFeatureSettings)

* css/CSSWrapShapes.cpp:
(WebCore::CSSWrapShapePolygon::cssText):

LayoutTests:

Updated the tests to match the polygon syntax defined by the draft exclusions
spec - http://dev.w3.org/csswg/css3-exclusions.

* fast/exclusions/parsing-wrap-shape-inside-expected.txt:
* fast/exclusions/parsing-wrap-shape-outside-expected.txt:
* fast/exclusions/script-tests/parsing-wrap-shape-inside.js:
* fast/exclusions/script-tests/parsing-wrap-shape-outside.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agonrwt is failing to upload test results on the chromium-mac-leopard bots
dpranke@chromium.org [Fri, 6 Apr 2012 01:14:05 +0000 (01:14 +0000)]
nrwt is failing to upload test results on the chromium-mac-leopard bots
https://bugs.webkit.org/show_bug.cgi?id=83230

Reviewed by Ojan Vafai.

This should fix things properly; FileUploader() was setting the
socket default timeout value, and apparently that doesn't work
properly with urllib. Also, the class had a bad try/finally
block that was causing the exceptions to be swallowed :(.

* Scripts/webkitpy/common/net/file_uploader.py:
(FileUploader.__init__):
(FileUploader._upload_data.callback):
(FileUploader):
(FileUploader._upload_data):
* Scripts/webkitpy/common/net/networktransaction.py:
(NetworkTimeout.__str__):
(NetworkTransaction.run):
* Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
(JSONResultsGeneratorBase.upload_json_files):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCrash when switching to a tab with plug-ins
andersca@apple.com [Fri, 6 Apr 2012 01:06:57 +0000 (01:06 +0000)]
Crash when switching to a tab with plug-ins
https://bugs.webkit.org/show_bug.cgi?id=83339
<rdar://problem/11183338>

Reviewed by Oliver Hunt.

Add an additional check so we don't try to call into plug-ins that haven't yet been initialized.

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::setLayerHostingMode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttp/tests/media/media-can-load-when-hidden.html doesn't need to be an HTTP test...
fischman@chromium.org [Fri, 6 Apr 2012 00:56:04 +0000 (00:56 +0000)]
http/tests/media/media-can-load-when-hidden.html doesn't need to be an HTTP test, and is racy
https://bugs.webkit.org/show_bug.cgi?id=83296

Reviewed by Eric Carlson.

* media/media-can-load-when-hidden-expected.txt: Renamed from LayoutTests/http/tests/media/media-can-load-when-hidden-expected.txt.
* media/media-can-load-when-hidden.html: Renamed from LayoutTests/http/tests/media/media-can-load-when-hidden.html.
* platform/chromium/test_expectations.txt:
* platform/efl/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSpeed up the conversion from JSValue to String for bulk operations
benjamin@webkit.org [Fri, 6 Apr 2012 00:12:25 +0000 (00:12 +0000)]
Speed up the conversion from JSValue to String for bulk operations
https://bugs.webkit.org/show_bug.cgi?id=83243

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-04-05
Reviewed by Geoffrey Garen.

When making operations on primitive types, we loose some time converting
values to JSString in order to extract the string.

This patch speeds up some basic Array operations by avoiding the creation
of intermediary JSString when possible.

For the cases where we need to convert a lot of JSValue in a tight loop,
an inline conversion is used.

* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncToString):
(JSC::arrayProtoFuncToLocaleString):
(JSC::arrayProtoFuncJoin):
(JSC::arrayProtoFuncPush):
(JSC::arrayProtoFuncSort):
* runtime/CommonIdentifiers.h:
* runtime/JSArray.cpp:
(JSC::JSArray::sort):
* runtime/JSString.h:
(JSC::JSValue::toUString):
(JSC):
(JSC::inlineJSValueNotStringtoUString):
(JSC::JSValue::toUStringInline):
* runtime/JSValue.cpp:
(JSC::JSValue::toUStringSlowCase):
(JSC):
* runtime/JSValue.h:
(JSValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoIndexedDB: Support string.length in keyPaths
jsbell@chromium.org [Thu, 5 Apr 2012 23:54:06 +0000 (23:54 +0000)]
IndexedDB: Support string.length in keyPaths
https://bugs.webkit.org/show_bug.cgi?id=83221

Source/WebCore:

Special case in the IDB spec - keyPaths can reference the |length| property
of string values. Other instrinsic properties (|length| of Array, etc) are
handled automagically. Relevant section of the updated spec is:
http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#key-path-construct

Reviewed by Kentaro Hara.

Test: storage/indexeddb/keypath-intrinsic-properties.html

* bindings/v8/IDBBindingUtilities.cpp:
(WebCore):

LayoutTests:

Reviewed by Kentaro Hara.

* storage/indexeddb/keypath-intrinsic-properties-expected.txt: Added.
* storage/indexeddb/keypath-intrinsic-properties.html: Added.
* storage/indexeddb/resources/keypath-intrinsic-properties.js: Added.
(test.request.onsuccess):
(test):
(openSuccess.request.onsuccess):
(openSuccess):
(testKeyPaths.checkStringLengths.request.onsuccess):
(testKeyPaths.checkStringLengths):
(testKeyPaths.checkArrayLengths.request.onsuccess):
(testKeyPaths.checkArrayLengths):
(testKeyPaths):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Unreviewed gardening. Remove some tests that are passing consistently.
tony@chromium.org [Thu, 5 Apr 2012 23:40:48 +0000 (23:40 +0000)]
[chromium] Unreviewed gardening.  Remove some tests that are passing consistently.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Unreviewed gardening.
tony@chromium.org [Thu, 5 Apr 2012 23:20:31 +0000 (23:20 +0000)]
[chromium] Unreviewed gardening.
fast/js/cross-global-object-inline-global-var.html is flakey on win debug and
fast/forms/select-style.html is consistently passing.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUse QuickSort when sorting primitive values by string representation
benjamin@webkit.org [Thu, 5 Apr 2012 23:08:13 +0000 (23:08 +0000)]
Use QuickSort when sorting primitive values by string representation
https://bugs.webkit.org/show_bug.cgi?id=83312

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-04-05
Reviewed by Gavin Barraclough.

When the value we are sorting are all primitive values, we do not need to
ensure a stable sort as two values with equal string representation are
indistinguishable from JavaScript.

This gives about 16% performance increase when sorting primitive values.

* runtime/JSArray.cpp:
(JSC::JSArray::sort):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[BlackBerry] Update the InstrumentedPlatformCanvas after rebasing Skia
commit-queue@webkit.org [Thu, 5 Apr 2012 23:00:16 +0000 (23:00 +0000)]
[BlackBerry] Update the InstrumentedPlatformCanvas after rebasing Skia
https://bugs.webkit.org/show_bug.cgi?id=83314

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-04-05
Reviewed by George Staikos.

RIM PR: 143771
One new virtual method was added to the SkCanvas, to draw a nine piece
image. Override it and mark output as not being a solid color anymore.

* platform/graphics/blackberry/InstrumentedPlatformCanvas.h:
(WebCore::InstrumentedPlatformCanvas::drawBitmapNine):
(InstrumentedPlatformCanvas):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSIGILL in JavaScriptCore on a Geode processor
oliver@apple.com [Thu, 5 Apr 2012 22:51:01 +0000 (22:51 +0000)]
SIGILL in JavaScriptCore on a Geode processor
https://bugs.webkit.org/show_bug.cgi?id=82496

Reviewed by Gavin Barraclough.

Don't attempt to use the DFG when SSE2 is not available.

* dfg/DFGCapabilities.cpp:
(JSC::DFG::canCompileOpcodes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[mac] requestAnimationFrame sometimes stuck when page loads in a background tab
dino@apple.com [Thu, 5 Apr 2012 22:42:30 +0000 (22:42 +0000)]
[mac] requestAnimationFrame sometimes stuck when page loads in a background tab
https://bugs.webkit.org/show_bug.cgi?id=76105

Unreviewed build fix for Windows. windowIsVisible() is PLATFORM(MAC) only.
This means a Page might start requestAnimationFrame-based animations
even when it isn't visible. This should only happen when a Page is
opened in the background though. The regular hide and show should still
pause animations.

* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::resumePainting):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake WebCore use jsCast rather than static_cast for casting JSC objects
oliver@apple.com [Thu, 5 Apr 2012 22:33:19 +0000 (22:33 +0000)]
Make WebCore use jsCast rather than static_cast for casting JSC objects
https://bugs.webkit.org/show_bug.cgi?id=83320

Reviewed by Stephanie Lewis.

Mechanically replace static_cast with jsCast where ever we can.

* WebCore.exp.in:
* bindings/js/DOMWrapperWorld.cpp:
(WebCore::JSStringOwner::finalize):
* bindings/js/DOMWrapperWorld.h:
(WebCore::currentWorld):
* bindings/js/JSArrayBufferCustom.cpp:
(WebCore::JSArrayBufferConstructor::constructJSArrayBuffer):
* bindings/js/JSAudioContextCustom.cpp:
(WebCore::JSAudioContextConstructor::constructJSAudioContext):
* bindings/js/JSCSSRuleListCustom.cpp:
(WebCore::JSCSSRuleListOwner::isReachableFromOpaqueRoots):
* bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::cssPropertyGetterPixelOrPosPrefixCallback):
(WebCore::cssPropertyGetterCallback):
* bindings/js/JSCSSValueCustom.cpp:
(WebCore::JSCSSValueOwner::isReachableFromOpaqueRoots):
(WebCore::JSCSSValueOwner::finalize):
* bindings/js/JSDOMBinding.cpp:
(WebCore::reportException):
* bindings/js/JSDOMBinding.h:
(WebCore::deprecatedGlobalObjectForPrototype):
(WebCore::getDOMPrototype):
* bindings/js/JSDOMFormDataCustom.cpp:
(WebCore::toHTMLFormElement):
(WebCore::JSDOMFormDataConstructor::constructJSDOMFormData):
* bindings/js/JSDOMMimeTypeArrayCustom.cpp:
(WebCore::JSDOMMimeTypeArray::nameGetter):
* bindings/js/JSDOMPluginArrayCustom.cpp:
(WebCore::JSDOMPluginArray::nameGetter):
* bindings/js/JSDOMPluginCustom.cpp:
(WebCore::JSDOMPlugin::nameGetter):
* bindings/js/JSDOMStringMapCustom.cpp:
(WebCore::JSDOMStringMap::nameGetter):
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::toJSDOMWindow):
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::childFrameGetter):
(WebCore::indexGetter):
(WebCore::namedItemGetter):
(WebCore::toDOMWindow):
* bindings/js/JSDOMWindowCustom.h:
(WebCore::asJSDOMWindow):
* bindings/js/JSDOMWindowShell.h:
(WebCore::JSDOMWindowShell::window):
* bindings/js/JSDOMWrapper.h:
(WebCore::JSDOMWrapper::globalObject):
* bindings/js/JSDataViewCustom.cpp:
(WebCore::JSDataViewConstructor::constructJSDataView):
* bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::handleEvent):
* bindings/js/JSEventTarget.cpp:
(WebCore):
(WebCore::toEventTarget):
* bindings/js/JSFloat32ArrayCustom.cpp:
(WebCore::JSFloat32ArrayConstructor::constructJSFloat32Array):
* bindings/js/JSFloat64ArrayCustom.cpp:
(WebCore::JSFloat64ArrayConstructor::constructJSFloat64Array):
* bindings/js/JSGeolocationCustom.cpp:
(WebCore::JSGeolocation::getCurrentPosition):
(WebCore::JSGeolocation::watchPosition):
* bindings/js/JSHTMLAllCollectionCustom.cpp:
(WebCore::callHTMLAllCollection):
(WebCore::JSHTMLAllCollection::nameGetter):
* bindings/js/JSHTMLCollectionCustom.cpp:
(WebCore::JSHTMLCollection::nameGetter):
* bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::nameGetter):
* bindings/js/JSHTMLFormElementCustom.cpp:
(WebCore::JSHTMLFormElement::nameGetter):
* bindings/js/JSHTMLFrameSetElementCustom.cpp:
(WebCore::JSHTMLFrameSetElement::nameGetter):
* bindings/js/JSHTMLOptionsCollectionCustom.cpp:
(WebCore::JSHTMLOptionsCollection::remove):
* bindings/js/JSImageConstructor.cpp:
(WebCore::constructImage):
* bindings/js/JSInjectedScriptManager.cpp:
(WebCore::InjectedScriptManager::createInjectedScript):
(WebCore::InjectedScriptManager::discardInjectedScript):
(WebCore::InjectedScriptManager::injectedScriptFor):
* bindings/js/JSInt16ArrayCustom.cpp:
(WebCore::JSInt16ArrayConstructor::constructJSInt16Array):
* bindings/js/JSInt32ArrayCustom.cpp:
(WebCore::JSInt32ArrayConstructor::constructJSInt32Array):
* bindings/js/JSInt8ArrayCustom.cpp:
(WebCore::JSInt8ArrayConstructor::constructJSInt8Array):
* bindings/js/JSLazyEventListener.cpp:
(WebCore::JSLazyEventListener::initializeJSFunction):
* bindings/js/JSNamedNodeMapCustom.cpp:
(WebCore::JSNamedNodeMap::nameGetter):
* bindings/js/JSNodeCustom.cpp:
(WebCore::JSNodeOwner::isReachableFromOpaqueRoots):
(WebCore::JSNodeOwner::finalize):
* bindings/js/JSNodeCustom.h:
(WebCore::toJS):
* bindings/js/JSNodeFilterCustom.cpp:
(WebCore::toNodeFilter):
* bindings/js/JSNodeListCustom.cpp:
(WebCore::JSNodeListOwner::isReachableFromOpaqueRoots):
(WebCore::JSNodeList::nameGetter):
* bindings/js/JSPluginElementFunctions.cpp:
(WebCore::runtimeObjectPropertyGetter):
(WebCore::callPlugin):
* bindings/js/JSPopStateEventCustom.cpp:
(WebCore::JSPopStateEvent::state):
* bindings/js/JSSQLTransactionCustom.cpp:
(WebCore::JSSQLTransaction::executeSql):
* bindings/js/JSSharedWorkerCustom.cpp:
(WebCore::JSSharedWorkerConstructor::constructJSSharedWorker):
* bindings/js/JSStorageCustom.cpp:
(WebCore::JSStorage::nameGetter):
* bindings/js/JSStyleSheetListCustom.cpp:
(WebCore::JSStyleSheetList::nameGetter):
* bindings/js/JSTextTrackCueCustom.cpp:
(WebCore::JSTextTrackCueOwner::isReachableFromOpaqueRoots):
* bindings/js/JSTextTrackCustom.cpp:
(WebCore::JSTextTrackOwner::isReachableFromOpaqueRoots):
* bindings/js/JSTextTrackListCustom.cpp:
(WebCore::JSTextTrackListOwner::isReachableFromOpaqueRoots):
* bindings/js/JSTrackCustom.cpp:
(WebCore::toTrack):
* bindings/js/JSUint16ArrayCustom.cpp:
(WebCore::JSUint16ArrayConstructor::constructJSUint16Array):
* bindings/js/JSUint32ArrayCustom.cpp:
(WebCore::JSUint32ArrayConstructor::constructJSUint32Array):
* bindings/js/JSUint8ArrayCustom.cpp:
(WebCore::JSUint8ArrayConstructor::constructJSUint8Array):
* bindings/js/JSUint8ClampedArrayCustom.cpp:
(WebCore::JSUint8ClampedArrayConstructor::constructJSUint8ClampedArray):
* bindings/js/JSWebKitMutationObserverCustom.cpp:
(WebCore::JSWebKitMutationObserverConstructor::constructJSWebKitMutationObserver):
* bindings/js/JSWebKitPointCustom.cpp:
(WebCore::JSWebKitPointConstructor::constructJSWebKitPoint):
* bindings/js/JSWebSocketCustom.cpp:
(WebCore::JSWebSocketConstructor::constructJSWebSocket):
* bindings/js/JSWorkerContextBase.cpp:
(WebCore::toJSDedicatedWorkerContext):
(WebCore::toJSSharedWorkerContext):
* bindings/js/JSWorkerCustom.cpp:
(WebCore::JSWorkerConstructor::constructJSWorker):
* bindings/js/JSXSLTProcessorCustom.cpp:
(WebCore::JSXSLTProcessor::importStylesheet):
(WebCore::JSXSLTProcessor::transformToFragment):
(WebCore::JSXSLTProcessor::transformToDocument):
* bindings/js/ScriptCallStackFactory.cpp:
(WebCore::createScriptCallStackForInspector):
* bindings/js/ScriptControllerMac.mm:
(WebCore::updateStyleIfNeededForBindings):
* bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::dispatchDidPause):
* bindings/js/ScriptObject.cpp:
(WebCore::ScriptGlobalObject::set):
* bindings/js/ScriptState.cpp:
(WebCore::domWindowFromScriptState):
(WebCore::scriptExecutionContextFromScriptState):
* bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneSerializer::fillTransferMap):
(WebCore::CloneSerializer::dumpArrayBufferView):
(WebCore::CloneDeserializer::getJSValue):
(WebCore::CloneDeserializer::readTerminal):
* bindings/objc/WebScriptObject.mm:
(-[WebScriptObject _isSafeScript]):
(+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateGetOwnPropertySlotBody):
(GenerateGetOwnPropertyDescriptorBody):
(GenerateImplementation):
(GenerateCallWith):
(NativeToJSValue):
(GenerateConstructorDefinition):
* bridge/jni/jni_jsobject.h:
* bridge/jni/jni_jsobject.mm:
(JavaJSObject::convertJObjectToValue):
* bridge/jni/jsc/JavaInstanceJSC.cpp:
(JavaInstance::invokeMethod):
* bridge/objc/objc_utility.mm:
(JSC::Bindings::convertValueToObjcValue):
* bridge/runtime_method.cpp:
(JSC::callRuntimeMethod):
* bridge/runtime_object.cpp:
(JSC::Bindings::callRuntimeConstructor):
* testing/js/WebCoreTestSupport.cpp:
(WebCoreTestSupport::injectInternalsObject):
(WebCoreTestSupport::resetInternalsObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[GTK] Scrolling some iframes that are partially out of the viewport leads to repaint...
commit-queue@webkit.org [Thu, 5 Apr 2012 22:18:35 +0000 (22:18 +0000)]
[GTK] Scrolling some iframes that are partially out of the viewport leads to repaint errors
https://bugs.webkit.org/show_bug.cgi?id=83309

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-04-05
Reviewed by Gustavo Noronha Silva.

Source/WebCore:

Test: platform/gtk/fast/frames/scrolling-iframe-out-of-viewport.html

The X11 backing store was not properly trimming the scroll region when it
was only a portion of the screen. This was hidden by subsequent repaints.

* platform/gtk/GtkWidgetBackingStoreX11.cpp:
(WebCore::WidgetBackingStore::scroll): Fix the calculation of the scrolling region.

Source/WebKit/gtk:

Instead of only updating scrollRect - preservedRegion, update
scrollRect - (preservedRegion - offscreenPreservedRegion). This ensures that
when part of the scroll rect is moved onscreen from offscreen that part is
queued for a redraw.

* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::scroll): Properly calculate the area to repaint.

LayoutTests:

Added a pixel test for this issue.

* platform/gtk/fast/frames/resources/scrolling-iframe-out-of-viewport-interior.html: Added.
* platform/gtk/fast/frames/scrolling-iframe-out-of-viewport-expected.png: Added.
* platform/gtk/fast/frames/scrolling-iframe-out-of-viewport-expected.txt: Added.
* platform/gtk/fast/frames/scrolling-iframe-out-of-viewport.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r113299.
commit-queue@webkit.org [Thu, 5 Apr 2012 22:07:18 +0000 (22:07 +0000)]
Unreviewed, rolling out r113299.
http://trac.webkit.org/changeset/113299
https://bugs.webkit.org/show_bug.cgi?id=83297

The patch broke 11 tests on Lion. (Requested by jonlee on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-05

Source/WebCore:

* xml/parser/XMLDocumentParser.h:
(XMLDocumentParser):
* xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::XMLDocumentParser):
(WebCore::XMLDocumentParser::startElementNs):
(WebCore::XMLDocumentParser::endElementNs):
(WebCore::getEntityHandler):
(WebCore::XMLDocumentParser::initializeParserContext):

LayoutTests:

* platform/mac-lion/Skipped:
* platform/mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png:
* platform/mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt:
* platform/mac/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.png:
* platform/mac/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt:
* platform/mac/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
* platform/mac/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt:
* platform/mac/svg/custom/preserve-aspect-ratio-syntax-expected.png:
* platform/mac/svg/custom/preserve-aspect-ratio-syntax-expected.txt:
* platform/mac/svg/custom/viewbox-syntax-expected.png:
* platform/mac/svg/custom/viewbox-syntax-expected.txt:
* platform/mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png:
* platform/mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
* platform/mac/svg/zoom/text/zoom-coords-viewattr-01-b-expected.png:
* platform/mac/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Correct misleading trace event names in Canvas2DLayerChromium
commit-queue@webkit.org [Thu, 5 Apr 2012 22:01:58 +0000 (22:01 +0000)]
[Chromium] Correct misleading trace event names in Canvas2DLayerChromium
https://bugs.webkit.org/show_bug.cgi?id=83310

Patch by Justin Novosad <junov@chromium.org> on 2012-04-05
Reviewed by Adrienne Walker.

* platform/graphics/chromium/Canvas2DLayerChromium.cpp:
(WebCore::Canvas2DLayerChromium::paintContentsIfDirty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Unreviewed, fast/js/keywords-and-reserved_words.html is
tony@chromium.org [Thu, 5 Apr 2012 21:32:37 +0000 (21:32 +0000)]
[chromium] Unreviewed, fast/js/keywords-and-reserved_words.html is
passing again after r113352.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[mac] requestAnimationFrame sometimes stuck when page loads in a background tab https...
dino@apple.com [Thu, 5 Apr 2012 21:29:38 +0000 (21:29 +0000)]
[mac] requestAnimationFrame sometimes stuck when page loads in a background tab https://bugs.webkit.org/show_bug.cgi?id=76105

Reviewed by Simon Fraser.

Source/WebCore:

Fix three issues with requestAnimationFrame:
- It's possible for the call to rAF to come to the document before there
  is a page associated. Added a guard for this.
- A page may try to suspend the scripted animations before the
  ScriptedAnimationController exists, in which case we need to
  suspend it immediately after it is created. Do this by keeping
  track of the state in Page. Otherwise rAF would be busy looping
  on hidden pages until they are brought to the front and hidden again.
- A page created in the background (from WebKit1) does not get
  informed it is not visible. This can mean that resume() is called
  more times than suspend() and we get into a state where the number
  of suspensions becomes -1, and thus fails truthiness tests. Clamp it
  to values >= 0.

No new tests, since this is not automatically testable. The most reliable test
is to open a page with rAF in a background tab within Safari.

* dom/Document.cpp:
(WebCore::Document::webkitRequestAnimationFrame):
* dom/ScriptedAnimationController.cpp:
(WebCore::ScriptedAnimationController::resume):
* page/Page.cpp:
(WebCore::Page::Page):
(WebCore::Page::suspendScriptedAnimations):
(WebCore::Page::resumeScriptedAnimations):
* page/Page.h:
(WebCore::Page::scriptedAnimationsSuspended):
(Page):

Source/WebKit2:

When we are resuming painting only start the scripted animations
if we're a visible window. This can happen when tabs are opened
in the background.

* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::resumePainting):

LayoutTests:

Add fast/animation/request-animation-frame-during-modal.html
to the skipped list. This patch will ensure that non-visible windows
do not get a requestAnimationFrame callback, so the test will timeout.
See https://bugs.webkit.org/show_bug.cgi?id=83239 to re-enable.

* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Unreviewed, moving linux result from 32-bit directory to 64 and 32 bit...
tony@chromium.org [Thu, 5 Apr 2012 21:18:22 +0000 (21:18 +0000)]
[chromium] Unreviewed, moving linux result from 32-bit directory to 64 and 32 bit directory.

* platform/chromium-linux/svg/clip-path/clip-path-tspan-and-stroke-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/svg/clip-path/clip-path-tspan-and-stroke-expected.png.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/9359029> and https://bugs.webkit.org/show_bug.cgi?id=83311 Crashes...
beidson@apple.com [Thu, 5 Apr 2012 21:15:01 +0000 (21:15 +0000)]
<rdar://problem/9359029> and https://bugs.webkit.org/show_bug.cgi?id=83311 Crashes in WebProcess at WebCore::HistoryController::recursiveSetProvisionalItem when restoring previous session

Reviewed by Sam Weinig.

It's possible to hit a race condition between the UIProcess and the WebProcess where the UIProcess records for a
page have been cleared out but the WebProcess is still trying to perform a history navigation within that page.

In this situation HistoryController code that expects there to always be a current history item in the back/forward
controller is wrong.

No new tests. (The race conditions involved have proven making a test impractical)

* loader/HistoryController.cpp:
(WebCore::HistoryController::recursiveSetProvisionalItem): Don't ASSERT the fromItem. We now know there might not be one.
(WebCore::HistoryController::recursiveGoToItem): Ditto
(WebCore::HistoryController::itemsAreClones): Always return false if either item is null, as a null item and a non-null
  item cannot possible be clones of each other.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCrash in MutationObservers due to an invalid HashSet iterator
adamk@chromium.org [Thu, 5 Apr 2012 21:11:28 +0000 (21:11 +0000)]
Crash in MutationObservers due to an invalid HashSet iterator
https://bugs.webkit.org/show_bug.cgi?id=83304

Reviewed by Ojan Vafai.

Source/WebCore:

If the observed node has been GCed when we clear transient observers
from it, the HashSet iterator in WebKitMutationObserver::deliver would
be invalidated. This patch fixes that behavior by copying the relevant
registrations into a seperate vector first and operating on the copy.

This patch also fixes a bug: transient observers should be cleared
after every microtask, not just when delivering.

Tests: fast/mutation/clear-transient-without-delivery.html
       fast/mutation/transient-gc-crash.html

* dom/MutationObserverRegistration.cpp:
(WebCore::MutationObserverRegistration::observedSubtreeNodeWillDetach):
Notify the observer that it has a transient registration so it can be properly cleared.
* dom/MutationObserverRegistration.h:
(WebCore::MutationObserverRegistration::hasTransientRegistrations):
Add an accessor for use when deliver() creates its vector of registrations.
* dom/WebKitMutationObserver.cpp:
(WebCore::WebKitMutationObserver::setHasTransientRegistration): Add this to the active observer set
to allow transient registrations to be cleared appropriately.
(WebCore::WebKitMutationObserver::deliver): Avoid modifying m_registrations while iterating over it.
Clear registrations before checking for a lack of records to deliver.
* dom/WebKitMutationObserver.h:

LayoutTests:

* fast/mutation/clear-transient-without-delivery-expected.txt: Added.
* fast/mutation/clear-transient-without-delivery.html: Added.
* fast/mutation/transient-gc-crash-expected.txt: Added.
* fast/mutation/transient-gc-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Unreviewed, update expectation for
tony@chromium.org [Thu, 5 Apr 2012 21:04:19 +0000 (21:04 +0000)]
[chromium] Unreviewed, update expectation for
media/nodesFromRect-shadowContent.html since it moved in r113371.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdded takeRecords to WebKitMutationObserver properties list, to fix mac.
rafaelw@chromium.org [Thu, 5 Apr 2012 20:53:42 +0000 (20:53 +0000)]
Added takeRecords to WebKitMutationObserver properties list, to fix mac.

* platform/mac/fast/dom/Window/window-properties-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, fix lint errors in GTK+ test_expectations.txt file.
tony@chromium.org [Thu, 5 Apr 2012 20:52:02 +0000 (20:52 +0000)]
Unreviewed, fix lint errors in GTK+ test_expectations.txt file.

* platform/gtk/test_expectations.txt:
http/tests/security/cross-origin-xsl-redirect-BLOCKED.html had 2 entries
and css3/flexbox/inline-flexbox.html doesn't exist anymore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRebaseline binding tests after r113272.
adamk@chromium.org [Thu, 5 Apr 2012 20:45:16 +0000 (20:45 +0000)]
Rebaseline binding tests after r113272.

* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::V8TestInterface::constructorCallback):
* bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructorConstructorCallback):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::V8TestObj::constructorCallback):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::V8TestSerializedScriptValueInterface::constructorCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Drawing an accelerated canvas onto itself is slow.
senorblanco@chromium.org [Thu, 5 Apr 2012 20:44:11 +0000 (20:44 +0000)]
[chromium] Drawing an accelerated canvas onto itself is slow.
https://bugs.webkit.org/show_bug.cgi?id=83295

Fixed by using a GPU-side deepCopy() in skia, so we don't trigger a
readback and re-upload.

Reviewed by James Robinson.

Correctness is covered by existing tests. Performance is covered
by the test case attached to the bug.

* platform/graphics/skia/ImageSkia.cpp:
(WebCore::BitmapImageSingleFrameSkia::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Record the number of tiles paint-culled instead of the incorrect number...
commit-queue@webkit.org [Thu, 5 Apr 2012 20:35:09 +0000 (20:35 +0000)]
[chromium] Record the number of tiles paint-culled instead of the incorrect number of pixels
https://bugs.webkit.org/show_bug.cgi?id=82423

Patch by Dana Jansens <danakj@chromium.org> on 2012-04-05
Reviewed by Adrienne Walker.

Source/WebCore:

We currently attempt to record the number of pixels we save from uploading,
however the number is wrong in two ways.
1) An early-out if everything is culled results in nothing being reported.
2) With threaded-compositor, the number of pixels uploaded in one tile can be
changed by culling in another tile, making the number far too difficult to
compute to be worthwhile. If a tile was going to be partial-updated, but is
culled, now a new tile gets to be partial-updated instead, which affects the
numbers.

This patch breaks up CCOverdrawMetrics to make the methods/variables less
overloaded and more clear. This way they don't have to mirror each other
so closely on paint/draw sides.

Then we record the number of tiles for which we prevented upload via paint
culling. This will still over-report (a dirty culled tile stays dirty and
will be culled again each commit), but it seems more reasonable as it
clearly does not try to mimic a performance metric in the way that a pixel
count does, but still gives a rough estimation of the amount of paint
culling going on in a page.

Covered by existing tests, modified where needed.

* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::prepareToUpdateTiles):
* platform/graphics/chromium/cc/CCOverdrawMetrics.cpp:
(WebCore::CCOverdrawMetrics::CCOverdrawMetrics):
(WebCore::CCOverdrawMetrics::didCullTileForUpload):
(WebCore):
(WebCore::CCOverdrawMetrics::didUpload):
(WebCore::CCOverdrawMetrics::didCullForDrawing):
(WebCore::CCOverdrawMetrics::recordMetrics):
(WebCore::CCOverdrawMetrics::recordMetricsInternal):
* platform/graphics/chromium/cc/CCOverdrawMetrics.h:
(CCOverdrawMetrics):
(WebCore::CCOverdrawMetrics::pixelsCulledForDrawing):
(WebCore::CCOverdrawMetrics::pixelsUploadedOpaque):
(WebCore::CCOverdrawMetrics::pixelsUploadedTranslucent):
(WebCore::CCOverdrawMetrics::tilesCulledForUpload):
* platform/graphics/chromium/cc/CCQuadCuller.cpp:
(WebCore::CCQuadCuller::append):

Source/WebKit/chromium:

* tests/CCQuadCullerTest.cpp:
(WebCore::TEST):
* tests/TiledLayerChromiumTest.cpp:
(WTF::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2012-04-05 Antonio Gomes <agomes@rim.com>
tonikitoo@webkit.org [Thu, 5 Apr 2012 20:34:07 +0000 (20:34 +0000)]
2012-04-05  Antonio Gomes  <agomes@rim.com>

        Move nodesFromRect-shadowContent test from fast/dom to media, where the
        helper .js files are able to work properly.
        https://bugs.webkit.org/show_bug.cgi?id=80847 (PART III)

        Reviewed by Eric Carlson.

        * media/nodesFromRect-shadowContent-expected.txt: Renamed from LayoutTests/fast/dom/nodesFromRect-shadowContent-expected.txt.
        * media/nodesFromRect-shadowContent.html: Renamed from LayoutTests/fast/dom/nodesFromRect-shadowContent.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Unreviewed, update baselines for tests with 'let' after r113352.
tony@chromium.org [Thu, 5 Apr 2012 20:32:05 +0000 (20:32 +0000)]
[chromium] Unreviewed, update baselines for tests with 'let' after r113352.

* platform/chromium/fast/js/reserved-words-as-property-expected.txt:
* platform/chromium/fast/js/reserved-words-strict-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoProvide a separate editing command to cleanup of redundant markup.
enrica@apple.com [Thu, 5 Apr 2012 20:31:52 +0000 (20:31 +0000)]
Provide a separate editing command to cleanup of redundant markup.
https://bugs.webkit.org/show_bug.cgi?id=83240

Reviewed by Ryosuke Niwa.

This patch moves the logic originally performed by the private
method removeRedundantMarkup inside ReplaceSelectionCommand into
a separate command. This way the markup cleanup can be exposed as
a separate command, independent from ReplaceSelectionCommand.

No new tests. No change in functionality.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
Added new file to project files.
* editing/EditorAllInOne.cpp: Added SimplifyMarkupCommand.
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::doApply): Now uses SimplifyMarkupCommand.
* editing/ReplaceSelectionCommand.h:
(ReplaceSelectionCommand): Removed removeRedundantMarkup.
* editing/SimplifyMarkupCommand.cpp: Added.
(WebCore::SimplifyMarkupCommand::SimplifyMarkupCommand):
(WebCore::SimplifyMarkupCommand::doApply):
* editing/SimplifyMarkupCommand.h: Added.
(WebCore::SimplifyMarkupCommand::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRebaseline text results
schenney@chromium.org [Thu, 5 Apr 2012 20:28:12 +0000 (20:28 +0000)]
Rebaseline text results
https://bugs.webkit.org/show_bug.cgi?id=74928

Unreviewed text expectations update.

Patch by Philip Rogers <pdr@google.com> on 2012-04-05

* platform/chromium-mac-leopard/svg/text/textPathBoundsBug-expected.png: Removed.
* platform/chromium-mac-leopard/svg/text/textPathBoundsBug-expected.txt: Removed.
* platform/chromium-mac-snowleopard/svg/text/textPathBoundsBug-expected.txt: Removed.
* platform/chromium-win-xp/svg/zoom/page: Removed.
* platform/chromium-win/fast/repaint/reflection-redraw-expected.png:
* platform/chromium-win/printing/width-overflow-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-60-t-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-62-t-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-07-b-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/text-align-04-b-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/text-align-06-b-expected.png:
* platform/chromium-win/svg/as-background-image/svg-as-background-4-expected.png:
* platform/chromium-win/svg/as-image/animated-svg-as-image-expected.png:
* platform/chromium-win/svg/as-image/animated-svg-as-image-same-image-expected.png:
* platform/chromium-win/svg/carto.net/textbox-expected.png:
* platform/chromium-win/svg/css/text-shadow-multiple-expected.png:
* platform/chromium-win/svg/custom/js-late-clipPath-creation-expected.png:
* platform/chromium-win/svg/text/scaling-font-with-geometric-precision-expected.png:
* platform/chromium-win/svg/text/text-align-05-b-expected.png:
* platform/chromium-win/svg/text/textPathBoundsBug-expected.png:
* platform/chromium/test_expectations.txt:
* platform/efl/svg/as-background-image/svg-as-background-4-expected.txt: Removed.
* svg/as-background-image/svg-as-background-4-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Layout test failure svg/clip-path/clip-path-tspan-and-stroke.xhtml
schenney@chromium.org [Thu, 5 Apr 2012 20:24:57 +0000 (20:24 +0000)]
[Chromium] Layout test failure svg/clip-path/clip-path-tspan-and-stroke.xhtml
https://bugs.webkit.org/show_bug.cgi?id=83308

Unreviewed Chromium test expectations update.

Also removing some expectations that are no longer needed.

* platform/chromium-linux-x86/svg/clip-path: Added.
* platform/chromium-linux-x86/svg/clip-path/clip-path-tspan-and-stroke-expected.png: Added.
* platform/chromium-win/svg/clip-path/clip-path-tspan-and-stroke-expected.png: Added.
* platform/chromium-win/svg/clip-path/clip-path-tspan-and-stroke-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix 32-bit build.
oliver@apple.com [Thu, 5 Apr 2012 20:21:15 +0000 (20:21 +0000)]
Fix 32-bit build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Need to clip to homogeneous w=0 plane when applying transforms.
shawnsingh@chromium.org [Thu, 5 Apr 2012 20:14:18 +0000 (20:14 +0000)]
[chromium] Need to clip to homogeneous w=0 plane when applying transforms.
https://bugs.webkit.org/show_bug.cgi?id=80806

Reviewed by Adrienne Walker.

Source/WebCore:

Unit tests added to CCLayerTreeHostCommon. This change is also
covered by other existing unit tests and layout tests.

WebCore TransformationMatrix mapRect / mapQuad / projectQuad do
not properly handle the case where a surface is oriented partially
behind the camera, with a perspective projection. In this case,
projected points may appear to be valid in cartesian coordinates,
but they are indeed not valid, and this problem can only be
detected in homogeneous coordinates after applying the transform,
before the divide-by-w step.

The correct solution is to clip geometry where w < 0. This patch
makes this change local to chromium only, to fix rendering bugs
that arise from this problem. The primary fix is to correct
calculateVisibleLayerRect(), but other ancillary locations are
also fixed, in particular, the antialiasing code path is simply
skipped when this case arises.

Eventually this math needs to be merged into TransformationMatrix,
to fix hit-testing bugs that occur in both Chromium and Safari.

* WebCore.gypi:
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::findTileProgramUniforms):
(WebCore::LayerRendererChromium::drawTileQuad):
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::CCLayerTreeHostCommon::calculateVisibleRect):
(WebCore::isScaleOrTranslation):
(WebCore::calculateDrawTransformsAndVisibilityInternal):
* platform/graphics/chromium/cc/CCMathUtil.cpp: Added.
(WebCore):
(WebCore::HomogeneousCoordinate::HomogeneousCoordinate):
(HomogeneousCoordinate):
(WebCore::HomogeneousCoordinate::shouldBeClipped):
(WebCore::HomogeneousCoordinate::cartesianPoint2d):
(WebCore::projectPoint):
(WebCore::mapPoint):
(WebCore::computeClippedPointForEdge):
(WebCore::expandBoundsToIncludePoint):
(WebCore::computeEnclosingRectOfClippedQuad):
(WebCore::computeEnclosingRect):
(WebCore::CCMathUtil::mapClippedRect):
(WebCore::CCMathUtil::projectClippedRect):
(WebCore::CCMathUtil::mapQuad):
(WebCore::CCMathUtil::projectQuad):
* platform/graphics/chromium/cc/CCMathUtil.h: Added.
(WebCore):
(CCMathUtil):
* platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
(WebCore::computeUnoccludedContentRect):

Source/WebKit/chromium:

* tests/CCLayerTreeHostCommonTest.cpp:
(WebKitTests::TEST):
(WebKitTests):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoReplace static_cast with jsCast when casting JSCell subclasses in JSC
oliver@apple.com [Thu, 5 Apr 2012 20:09:33 +0000 (20:09 +0000)]
Replace static_cast with jsCast when casting JSCell subclasses in JSC
https://bugs.webkit.org/show_bug.cgi?id=83307

Reviewed by Gavin Barraclough.

Replace all usage of static_cast<JSCell subtype*> with jsCast<> in JavaScriptCore.
This results in assertions when unsafe casts are performed, but simply leaves
a static_cast<> in release builds.

* API/APICast.h:
(toJS):
* API/JSCallbackConstructor.cpp:
(JSC::constructJSCallback):
* API/JSCallbackFunction.cpp:
(JSC::JSCallbackFunction::call):
* API/JSCallbackObjectFunctions.h:
(JSC::::asCallbackObject):
(JSC::::finishCreation):
(JSC::::construct):
(JSC::::call):
* API/JSObjectRef.cpp:
(JSObjectGetPrivate):
(JSObjectSetPrivate):
(JSObjectGetPrivateProperty):
(JSObjectSetPrivateProperty):
(JSObjectDeletePrivateProperty):
* API/JSValueRef.cpp:
(JSValueIsObjectOfClass):
* API/JSWeakObjectMapRefPrivate.cpp:
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::resolve):
(JSC::BytecodeGenerator::resolveConstDecl):
* debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::finishCreation):
* dfg/DFGOperations.cpp:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
(JSC::Interpreter::privateExecute):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/Executable.h:
(JSC::isHostFunction):
* runtime/JSActivation.h:
(JSC::asActivation):
* runtime/JSArray.cpp:
(JSC::JSArray::defineOwnProperty):
* runtime/JSArray.h:
(JSC::asArray):
* runtime/JSBoundFunction.cpp:
(JSC::boundFunctionCall):
(JSC::boundFunctionConstruct):
* runtime/JSByteArray.h:
(JSC::asByteArray):
* runtime/JSCell.cpp:
(JSC::JSCell::toObject):
* runtime/JSCell.h:
(JSC::jsCast):
* runtime/JSGlobalObject.h:
(JSC::asGlobalObject):
* runtime/JSGlobalObjectFunctions.cpp:
(JSC::globalFuncEval):
* runtime/JSObject.cpp:
(JSC::JSObject::setPrototypeWithCycleCheck):
(JSC::JSObject::allowsAccessFrom):
(JSC::JSObject::toThisObject):
(JSC::JSObject::unwrappedObject):
* runtime/JSObject.h:
(JSC::asObject):
* runtime/JSPropertyNameIterator.h:
(JSC::Register::propertyNameIterator):
* runtime/JSString.h:
(JSC::asString):
(JSC::JSValue::toString):
* runtime/StringPrototype.cpp:
(JSC::stringProtoFuncSubstr):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Layout Test svg/as-object/nested-embedded-svg-size-changes.html times out
schenney@chromium.org [Thu, 5 Apr 2012 20:03:24 +0000 (20:03 +0000)]
[Chromium] Layout Test svg/as-object/nested-embedded-svg-size-changes.html times out
https://bugs.webkit.org/show_bug.cgi?id=77183

Unreviewed Chromium test expectations update.

Somehow this test slipped thorugh the crack of rebaselining.

* platform/chromium-linux-x86/svg/as-object/nested-embedded-svg-size-changes-expected.png: Removed.
* platform/chromium-linux/svg/as-object/nested-embedded-svg-size-changes-expected.png:
* platform/chromium-mac-leopard/svg/as-object/nested-embedded-svg-size-changes-expected.png:
* platform/chromium-mac-snowleopard/svg/as-object/nested-embedded-svg-size-changes-expected.png: Added.
* platform/chromium-mac/svg/as-object/nested-embedded-svg-size-changes-expected.png: Modified property svn:mime-type.
* platform/chromium-win-vista/svg/as-object/nested-embedded-svg-size-changes-expected.png: Removed.
* platform/chromium-win-xp/svg/as-object/nested-embedded-svg-size-changes-expected.png: Removed.
* platform/chromium-win/svg/as-object/nested-embedded-svg-size-changes-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Correct <wtf/*.h> include paths.
paroga@webkit.org [Thu, 5 Apr 2012 20:01:38 +0000 (20:01 +0000)]
[Qt] Correct <wtf/*.h> include paths.
https://bugs.webkit.org/show_bug.cgi?id=83270

Reviewed by Eric Seidel.

Modify the #include declerations so that the
wtf types are included using the full path.

Source/WebCore:

* platform/graphics/TiledBackingStoreBackend.h:

Source/WebKit/qt:

* Api/qwebpage.cpp:
* WebCoreSupport/ContextMenuClientQt.h:
* WebCoreSupport/EditorClientQt.h:
* WebCoreSupport/FrameLoaderClientQt.h:
* WebCoreSupport/InspectorServerQt.cpp:

Source/WebKit2:

* Shared/qt/QtNetworkReplyData.cpp:
* UIProcess/WebLayerTreeRenderer.cpp:
* UIProcess/qt/LayerBackingStore.h:
* UIProcess/qt/QtViewportInteractionEngine.cpp:
* UIProcess/qt/QtViewportInteractionEngine.h:
* UIProcess/qt/QtWebPageSGNode.h:
* WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

Tools:

* WebKitTestRunner/qt/TestInvocationQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSwitch svg/custom tests to repaint harness
schenney@chromium.org [Thu, 5 Apr 2012 19:49:47 +0000 (19:49 +0000)]
Switch svg/custom tests to repaint harness
https://bugs.webkit.org/show_bug.cgi?id=78115

Unreviewed Chromium expectations update.

Somehow this file was not correctly rebaselined when the original change was made.

* platform/chromium-linux/svg/custom/repaint-on-constant-size-change-expected.png: Removed.
* platform/chromium-win/svg/custom/repaint-on-constant-size-change-expected.png: Modified property svn:mime-type.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2012-04-05 Antonio Gomes <agomes@rim.com>
tonikitoo@webkit.org [Thu, 5 Apr 2012 19:38:07 +0000 (19:38 +0000)]
2012-04-05  Antonio Gomes  <agomes@rim.com>

        Unreviewed bit left over from rebasing the origin patch before landing it.

        Complementary to r113329.

        * rendering/HitTestResult.cpp:
        (WebCore::HitTestResult::operator=):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Cleanup test, redundant code in CCSchedulerTest.NoBeginFrameWhenDrawFails
commit-queue@webkit.org [Thu, 5 Apr 2012 19:32:29 +0000 (19:32 +0000)]
[chromium] Cleanup test, redundant code in CCSchedulerTest.NoBeginFrameWhenDrawFails
https://bugs.webkit.org/show_bug.cgi?id=83300

Patch by Dana Jansens <danakj@chromium.org> on 2012-04-05
Reviewed by Adrienne Walker.

* tests/CCSchedulerTest.cpp:
(WebKitTests::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoperf-o-matic should include unit in runs JSON responses
rniwa@webkit.org [Thu, 5 Apr 2012 19:32:27 +0000 (19:32 +0000)]
perf-o-matic should include unit in runs JSON responses
https://bugs.webkit.org/show_bug.cgi?id=83294

Reviewed by Tony Chang.

This is a follow up to r112829. Report the unit in /api/test/runs so that the frontend can show it.
Fixed a bug in Test.update_or_insert that it didn't store the unit when it first created the Test object.

Also increment perf-o-matic's version to 18.

* Websites/webkit-perf.appspot.com/app.yaml: Incremented the version.
* Websites/webkit-perf.appspot.com/models.py:
(Test.update_or_insert.execute): Store unit when creating a test.
(Runs.to_json): Include unit.
* Websites/webkit-perf.appspot.com/models_unittest.py: Added tests.
(TestModelTests.test_update_or_insert_with_unit):
(RunsTest.test_to_json_without_results):
(RunsTest.test_to_json_with_results):
(RunsTest.test_to_json_with_unit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake something faster than JSStringBuilder for joining an array of JSValue
benjamin@webkit.org [Thu, 5 Apr 2012 19:30:13 +0000 (19:30 +0000)]
Make something faster than JSStringBuilder for joining an array of JSValue
https://bugs.webkit.org/show_bug.cgi?id=83180

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-04-05
Reviewed by Geoffrey Garen.

This patch add the class JSStringJoiner optimized for join() operations.

This class makes stricter constraints than JSStringBuilder in order avoid
memory allocations.

In the best case, the class allocate memory only twice:
-Allocate an array to keep a list of UString to join.
-Allocate the final string.

We also avoid the conversion from 8bits strings to 16bits strings since
they are costly and unlikly to help for subsequent calls.

* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* Target.pri:
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncToLocaleString):
(JSC::arrayProtoFuncJoin):
* runtime/JSStringJoiner.cpp: Added.
(JSC):
(JSC::appendStringToData):
(JSC::joinStrings):
(JSC::JSStringJoiner::build):
* runtime/JSStringJoiner.h: Added.
(JSC):
(JSStringJoiner):
(JSC::JSStringJoiner::JSStringJoiner):
(JSC::JSStringJoiner::append):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Unreviewed, widen the suppression for
tony@chromium.org [Thu, 5 Apr 2012 19:25:36 +0000 (19:25 +0000)]
[chromium] Unreviewed, widen the suppression for
http/tests/multipart/policy-ignore-crash.php-- it is flakey on win debug too.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] LayoutTest failures/flaky for svg/as-background-image
schenney@chromium.org [Thu, 5 Apr 2012 19:23:13 +0000 (19:23 +0000)]
[Chromium] LayoutTest failures/flaky for svg/as-background-image
https://bugs.webkit.org/show_bug.cgi?id=83303

Unreviewed Chromium test expectations rationalization.

Apparently the efl port results match Chromium.

* platform/chromium-win-vista/svg/as-background-image: Removed.
* platform/chromium-win-vista/svg/as-background-image/svg-as-background-1-expected.png: Removed.
* platform/chromium-win-vista/svg/as-background-image/svg-as-background-3-expected.png: Removed.
* platform/chromium-win/svg/as-background-image/svg-as-background-1-expected.png:
* platform/chromium-win/svg/as-background-image/svg-as-background-3-expected.png:
* platform/chromium/test_expectations.txt:
* platform/efl/svg/as-background-image/svg-as-background-1-expected.txt: Removed.
* platform/efl/svg/as-background-image/svg-as-background-3-expected.txt: Removed.
* svg/as-background-image/svg-as-background-1-expected.txt: Added.
* svg/as-background-image/svg-as-background-3-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=77293
barraclough@apple.com [Thu, 5 Apr 2012 19:09:40 +0000 (19:09 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=77293
[Un]Reserve 'let'

Rubber stamped by Oliver Hunt.

Revert r106198.
This does break the web - e.g. https://bvi.bnc.ca/index/bnc/indexen.html
If we're going to reserve let, we're going to have to do so in a more
circumspect fashion.

Source/JavaScriptCore:

* parser/Keywords.table:

LayoutTests:

* fast/js/keywords-and-reserved_words-expected.txt:
* fast/js/reserved-words-as-property-expected.txt:
* fast/js/reserved-words-strict-expected.txt:
* fast/js/script-tests/keywords-and-reserved_words.js:
* fast/js/script-tests/reserved-words-as-property.js:
* fast/js/script-tests/reserved-words-strict.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoHTMLSelectElement does not have a getter for namedItem. This fixes the invalid test
arv@chromium.org [Thu, 5 Apr 2012 19:08:30 +0000 (19:08 +0000)]
HTMLSelectElement does not have a getter for namedItem. This fixes the invalid test
https://bugs.webkit.org/show_bug.cgi?id=83289

Reviewed by Ryosuke Niwa.

http://www.whatwg.org/specs/web-apps/current-work/multipage/the-button-element.html#the-select-element

* fast/dom/HTMLSelectElement/named-options-expected.txt:
* fast/dom/HTMLSelectElement/script-tests/named-options.js:
* platform/chromium-mac/fast/dom/HTMLSelectElement/named-options-expected.txt: Removed.
* platform/chromium-win/fast/dom/HTMLSelectElement/named-options-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r113241.
zmo@google.com [Thu, 5 Apr 2012 19:07:29 +0000 (19:07 +0000)]
Unreviewed, rolling out r113241.
http://trac.webkit.org/changeset/113241
https://bugs.webkit.org/show_bug.cgi?id=83293

Requested by sievers@chromium.org (Requested by zhenyao on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-05

Source/WebCore:

* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::canDraw):
(WebCore::CCLayerTreeHostImpl::prepareToDraw):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(CCLayerTreeHostImpl):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::scheduledActionDrawAndSwapInternal):

Source/WebKit/chromium:

* tests/CCLayerTreeHostImplTest.cpp:
(WebKitTests::TEST_F):
* tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTest::doBeginTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Fixed incorrect expectations for fonts/cursive.html.
dglazkov@chromium.org [Thu, 5 Apr 2012 19:05:55 +0000 (19:05 +0000)]
[Chromium] Fixed incorrect expectations for fonts/cursive.html.

* platform/chromium/test_expectations.txt: Fixed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFixing build failure on SnowLeopard caused by changeset 113340.
jpu@apple.com [Thu, 5 Apr 2012 19:04:18 +0000 (19:04 +0000)]
Fixing build failure on SnowLeopard caused by changeset 113340.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r113341.
shawnsingh@chromium.org [Thu, 5 Apr 2012 19:00:16 +0000 (19:00 +0000)]
Unreviewed, rolling out r113341.
http://trac.webkit.org/changeset/113341
https://bugs.webkit.org/show_bug.cgi?id=83299

bots caught some build errors (Requested by shawnsingh on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-05

Source/WebCore:

* WebCore.gypi:
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::findTileProgramUniforms):
(WebCore::LayerRendererChromium::drawTileQuad):
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::CCLayerTreeHostCommon::calculateVisibleRect):
(WebCore::isScaleOrTranslation):
(WebCore::calculateDrawTransformsAndVisibilityInternal):
* platform/graphics/chromium/cc/CCMathUtil.cpp: Removed.
* platform/graphics/chromium/cc/CCMathUtil.h: Removed.
* platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
(WebCore::projectQuad):
(WebCore):
(WebCore::computeUnoccludedContentRect):

Source/WebKit/chromium:

* tests/CCLayerTreeHostCommonTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Race condition in CCLayerTreeHostTestSynchronizeAnimationStartTimes
commit-queue@webkit.org [Thu, 5 Apr 2012 18:57:57 +0000 (18:57 +0000)]
[chromium] Race condition in CCLayerTreeHostTestSynchronizeAnimationStartTimes
https://bugs.webkit.org/show_bug.cgi?id=83179

Patch by Ian Vollick <vollick@chromium.org> on 2012-04-05
Reviewed by James Robinson.

* tests/CCLayerTreeHostTest.cpp:
(WTF::TestHooks::willAnimateLayers):
(WTF::MockLayerTreeHostImpl::animateLayers):
(WTF::CCLayerTreeHostTestSynchronizeAnimationStartTimes::CCLayerTreeHostTestSynchronizeAnimationStartTimes):
(CCLayerTreeHostTestSynchronizeAnimationStartTimes):
(WTF::CCLayerTreeHostTestSynchronizeAnimationStartTimes::willAnimateLayers):
(WTF::CCLayerTreeHostTestSynchronizeAnimationStartTimes::notifyAnimationStarted):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] With the skia port, setting LCD text filtering is causing
commit-queue@webkit.org [Thu, 5 Apr 2012 18:49:13 +0000 (18:49 +0000)]
[Chromium] With the skia port, setting LCD text filtering is causing
texture cache invalidations of gpu canvas backing store
https://bugs.webkit.org/show_bug.cgi?id=74183

Patch by Justin Novosad <junov@chromium.org> on 2012-04-05
Reviewed by Stephen White.

Source/WebCore:

Replacing unnecessary usage of SkCanvas::LayerIter with calls to
SkCanvas::isDrawingToLayer(). Same results, lower overhead, and no
GPU texture invalidation.

* platform/graphics/chromium/FontChromiumWin.cpp:
(WebCore):
(WebCore::TransparencyAwareFontPainter::initializeForGDI):
* platform/graphics/harfbuzz/FontHarfBuzz.cpp:
(WebCore):
(WebCore::adjustTextRenderMode):
* platform/graphics/skia/FontSkia.cpp:
(WebCore):
(WebCore::adjustTextRenderMode):
* platform/graphics/skia/SkiaFontWin.cpp:
(WebCore):
(WebCore::disableTextLCD):
* rendering/RenderThemeChromiumWin.cpp:
(WebCore):

Source/WebKit/chromium:

Replacing unnecessary usage of SkCanvas::LayerIter with call to
SkCanvas::isDrawingToLayer(). Same results, lower overhead, and no
GPU texture invalidation.

* src/WebFontImpl.cpp:
(WebKit::WebFontImpl::drawText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Properly align members in WebInputEvent and subclasses to make Valgrind...
commit-queue@webkit.org [Thu, 5 Apr 2012 18:47:43 +0000 (18:47 +0000)]
[Chromium] Properly align members in WebInputEvent and subclasses to make Valgrind happy.
https://bugs.webkit.org/show_bug.cgi?id=81570

Patch by Lei Zhang <thestig@chromium.org> on 2012-04-05
Reviewed by Darin Fisher.

* public/WebInputEvent.h:
(WebKit):
(WebKit::WebInputEvent::WebInputEvent):
(WebKeyboardEvent):
(WebKit::WebTouchEvent::WebTouchEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agomedia/track/track-webvtt-tc004-magic-header.html flakily times out
commit-queue@webkit.org [Thu, 5 Apr 2012 18:32:22 +0000 (18:32 +0000)]
media/track/track-webvtt-tc004-magic-header.html flakily times out
https://bugs.webkit.org/show_bug.cgi?id=72279

Source/WebCore:

Patch by Zan Dobersek <zandobersek@gmail.com> on 2012-04-05
Reviewed by Eric Carlson.

Move all the checking for the WebVTT file identifier from TextTrackLoader
to WebVTTParser, notifying the parser clients of parsing failures through
a new method. Remove the WebVTTParser::fileIdentifierMaximumLength method
and make WebVTTParser::hasRequiredFileIdentifier private. The latter now
operates on a vector holding the identifier data to which data is added
until there's enough of it to possibly hold the optional BOM character
and the required WEBVTT character sequence.

No new tests. Fixes an existing test.

* html/track/WebVTTParser.cpp: Fix a typo throughout the file:
fileIdentiferLength -> fileIdentifierLength
(WebCore):
(WebCore::WebVTTParser::parseBytes): Only continue with searcing for
the WEBVTT identifier if there's enough data to possibly contain the
identifier. Report that the file failed to parse if the identifier
was then not found.
(WebCore::WebVTTParser::hasRequiredFileIdentifier): Refactor to operate
on the vector containing identifier data and merge with the
hasLongWebVTTIdentifier function.
* html/track/WebVTTParser.h:
(WebVTTParserClient): Add a new method.
(WebVTTParser):
* loader/TextTrackLoader.cpp:
(WebCore::TextTrackLoader::processNewCueData): Parser is now created
immediately regardless of the mime type the response holds.
(WebCore::TextTrackLoader::fileFailedToParse): Log the error, set the
state to failed, start the cue load timer and cancel the load if the file
was not parsed successfully.
(WebCore):
* loader/TextTrackLoader.h:
(TextTrackLoader):

LayoutTests:

Remove the test from test expectations file as it should now pass.

Patch by Zan Dobersek <zandobersek@gmail.com> on 2012-04-05
Reviewed by Eric Carlson.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Need to clip to homogeneous w=0 plane when applying transforms.
shawnsingh@chromium.org [Thu, 5 Apr 2012 18:24:16 +0000 (18:24 +0000)]
[chromium] Need to clip to homogeneous w=0 plane when applying transforms.
https://bugs.webkit.org/show_bug.cgi?id=80806

Reviewed by Adrienne Walker.

Source/WebCore:

Unit tests added to CCLayerTreeHostCommon. This change is also
covered by other existing unit tests and layout tests.

WebCore TransformationMatrix mapRect / mapQuad / projectQuad do
not properly handle the case where a surface is oriented partially
behind the camera, with a perspective projection. In this case,
projected points may appear to be valid in cartesian coordinates,
but they are indeed not valid, and this problem can only be
detected in homogeneous coordinates after applying the transform,
before the divide-by-w step.

The correct solution is to clip geometry where w < 0. This patch
makes this change local to chromium only, to fix rendering bugs
that arise from this problem. The primary fix is to correct
calculateVisibleLayerRect(), but other ancillary locations are
also fixed, in particular, the antialiasing code path is simply
skipped when this case arises.

Eventually this math needs to be merged into TransformationMatrix,
to fix hit-testing bugs that occur in both Chromium and Safari.

* WebCore.gypi:
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::findTileProgramUniforms):
(WebCore::LayerRendererChromium::drawTileQuad):
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::CCLayerTreeHostCommon::calculateVisibleRect):
(WebCore::isScaleOrTranslation):
(WebCore::calculateDrawTransformsAndVisibilityInternal):
* platform/graphics/chromium/cc/CCMathUtil.cpp: Added.
(WebCore):
(WebCore::HomogeneousCoordinate::HomogeneousCoordinate):
(HomogeneousCoordinate):
(WebCore::HomogeneousCoordinate::shouldBeClipped):
(WebCore::HomogeneousCoordinate::cartesianPoint2d):
(WebCore::projectPoint):
(WebCore::mapPoint):
(WebCore::computeClippedPointForEdge):
(WebCore::expandBoundsToIncludePoint):
(WebCore::computeEnclosingRectOfClippedQuad):
(WebCore::computeEnclosingRect):
(WebCore::CCMathUtil::mapClippedRect):
(WebCore::CCMathUtil::projectClippedRect):
(WebCore::CCMathUtil::mapQuad):
(WebCore::CCMathUtil::projectQuad):
* platform/graphics/chromium/cc/CCMathUtil.h: Added.
(WebCore):
(CCMathUtil):
* platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
(WebCore::computeUnoccludedContentRect):

Source/WebKit/chromium:

* tests/CCLayerTreeHostCommonTest.cpp:
(WebKitTests::TEST):
(WebKitTests):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2012-04-05 Jia Pu <jpu@apple.com>
jpu@apple.com [Thu, 5 Apr 2012 18:16:25 +0000 (18:16 +0000)]
2012-04-05  Jia Pu  <jpu@apple.com>

        Move correction panel related functions from EditorClient into separated AlternativeTextClient class.
        https://bugs.webkit.org/show_bug.cgi?id=82970

        Reviewed by Enrica Casucci.

        Move correction panel related functions from WebEditorClient to the new WebAlternativeTextClient.
        See WebCore/ChangeLog for details.

        * UIProcess/API/gtk/PageClientImpl.cpp:
        * UIProcess/API/mac/PageClientImpl.h:
        (PageClientImpl):
        * UIProcess/API/mac/PageClientImpl.mm:
        (WebKit::PageClientImpl::recordAutocorrectionResponse):
        * UIProcess/API/qt/qquickwebview.cpp:
        * UIProcess/PageClient.h:
        (PageClient):
        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::recordAutocorrectionResponse):
        * UIProcess/mac/CorrectionPanel.h:
        * UIProcess/mac/CorrectionPanel.mm:
        * WebKit2.xcodeproj/project.pbxproj:
        * WebProcess/WebCoreSupport/mac/WebAlternativeTextClient.cpp: Added.
        (WebKit):
        (WebKit::WebAlternativeTextClient::WebAlternativeTextClient):
        (WebKit::WebAlternativeTextClient::~WebAlternativeTextClient):
        (WebKit::WebAlternativeTextClient::showCorrectionAlternative):
        (WebKit::WebAlternativeTextClient::dismissAlternative):
        (WebKit::WebAlternativeTextClient::dismissAlternativeSoon):
        (WebKit::WebAlternativeTextClient::recordAutocorrectionResponse):
        * WebProcess/WebCoreSupport/WebAlternativeTextClient.h: Added.
        (WebKit):
        (WebAlternativeTextClient):
        * WebProcess/WebCoreSupport/WebEditorClient.h:
        * WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
        (WebKit):
        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::WebPage):

2012-04-05  Jia Pu  <jpu@apple.com>

        Move correction panel related functions from EditorClient into separated AlternativeTextClient class.
        https://bugs.webkit.org/show_bug.cgi?id=82970

        Reviewed by Enrica Casucci.

        Move correction panel related functions from WebEditorClient to the new WebAlternativeTextClient.
        See WebCore/ChangeLog for details.

        * WebCoreSupport/CorrectionPanel.h:
        * WebCoreSupport/CorrectionPanel.mm:
        * WebCoreSupport/WebAlternativeTextClient.h: Added.
        (WebAlternativeTextClient):
        * WebCoreSupport/WebAlternativeTextClient.mm: Added.
        (WebAlternativeTextClient::WebAlternativeTextClient):
        (WebAlternativeTextClient::~WebAlternativeTextClient):
        (WebAlternativeTextClient::showCorrectionAlternative):
        (WebAlternativeTextClient::dismissAlternative):
        (WebAlternativeTextClient::dismissAlternativeSoon):
        (WebAlternativeTextClient::recordAutocorrectionResponse):
        * WebCoreSupport/WebEditorClient.h:
        * WebCoreSupport/WebEditorClient.mm:
        (WebEditorClient::~WebEditorClient):
        * WebView/WebView.mm:
        (-[WebView _commonInitializationWithFrameName:groupName:]):

2012-04-05  Jia Pu  <jpu@apple.com>

        Move correction panel related functions from EditorClient into separated AlternativeTextClient class.
        https://bugs.webkit.org/show_bug.cgi?id=82970

        Reviewed by Enrica Casucci.

        See WebCore/ChangeLog for details.

        * WebKit.xcodeproj/project.pbxproj:

2012-04-05  Jia Pu  <jpu@apple.com>

        Move correction panel related functions from EditorClient into separated AlternativeTextClient class.
        https://bugs.webkit.org/show_bug.cgi?id=82970

        Reviewed by Enrica Casucci.

        No new tests, since there's no change of functionality.

        The existing correction panel related functions in EditorClient are currently used only by OS X.
        We'd like to move them into separate AlternativeTextClient class to avoid using #ifdef's. This
        new client class will also hold dictation alternative related interface that we will add soon for
        bug 82503.

        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * editing/AlternativeTextController.cpp: Changes in this file are all for calling functions in
          AlternativeTextClient instead of those in EditoClient.
        (WebCore::AlternativeTextController::show):
        (WebCore::AlternativeTextController::dismiss):
        (WebCore::AlternativeTextController::dismissSoon):
        (WebCore::AlternativeTextController::respondToUnappliedSpellCorrection):
        (WebCore::AlternativeTextController::timerFired):
        (WebCore::AlternativeTextController::isAutomaticSpellingCorrectionEnabled):
        (WebCore::AlternativeTextController::alternativeTextClient):
        (WebCore):
        (WebCore::AlternativeTextController::editorClient):
        (WebCore::AlternativeTextController::textChecker):
        (WebCore::AlternativeTextController::recordAutocorrectionResponseReversed):
        (WebCore::AlternativeTextController::recordSpellcheckerResponseForModifiedCorrection):
        * editing/AlternativeTextController.h:
        (WebCore):
        (AlternativeTextController):
        * editing/TextCheckingHelper.h:
        (WebCore):
        * loader/EmptyClients.h:
        (EmptyEditorClient):
        * page/AlternativeTextClient.h: Added.
        (WebCore):
        (AlternativeTextClient):
        (WebCore::AlternativeTextClient::~AlternativeTextClient):
        * page/EditorClient.h:
        (EditorClient):
        * page/Page.cpp:
        (WebCore::Page::Page):
        (WebCore::Page::PageClients::PageClients):
        * page/Page.h:
        (WebCore):
        (PageClients):
        (Page):
        (WebCore::Page::alternativeTextClient):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agogtk_unittest.GtkPortTest.test_get_crash_log failing on windows
commit-queue@webkit.org [Thu, 5 Apr 2012 18:15:59 +0000 (18:15 +0000)]
gtk_unittest.GtkPortTest.test_get_crash_log failing on windows
https://bugs.webkit.org/show_bug.cgi?id=83176

Patch by Philippe Normand <pnormand@igalia.com> on 2012-04-05
Reviewed by Tony Chang.

Refactored the test to use os.path.join() to specify the
core_pattern value of the empty crash log mock.

* Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
(GtkPortTest):
(GtkPortTest.assertLinesEqual):
(GtkPortTest.test_get_crash_log):
(_mock_gdb_output):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMarked storage/indexeddb/basics-workers.html as flaky across all platforms in DEBUG
dglazkov@chromium.org [Thu, 5 Apr 2012 18:01:07 +0000 (18:01 +0000)]
Marked storage/indexeddb/basics-workers.html as flaky across all platforms in DEBUG

* platform/chromium/test_expectations.txt: Marked.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix fullscreen video button for android
commit-queue@webkit.org [Thu, 5 Apr 2012 17:54:48 +0000 (17:54 +0000)]
Fix fullscreen video button for android
https://bugs.webkit.org/show_bug.cgi?id=83087

Patch by Min Qin <qinmin@google.com> on 2012-04-05
Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=70437 changed css keyword for fullscreen video button.
It is changed from media-fullscreen-button to media-enter-fullscreen-button.
However, it does not change the value in mediaControlChromiumAndroid.css.
No behavior change.

* css/mediaControlsChromiumAndroid.css:
(video::-webkit-media-controls-fullscreen-button):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: CSS file revisions are not restored upon front-end reopen.
pfeldman@chromium.org [Thu, 5 Apr 2012 17:46:27 +0000 (17:46 +0000)]
Web Inspector: CSS file revisions are not restored upon front-end reopen.
https://bugs.webkit.org/show_bug.cgi?id=83292

Reviewed by Yury Semikhatsky.

Populating suggestions before the panel creation now.

* inspector/front-end/inspector.js:
(WebInspector._doLoadedDoneWithCapabilities.get if):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd assertions to check for mutation of RenderLayer z-order lists during enumeration
simon.fraser@apple.com [Thu, 5 Apr 2012 17:44:13 +0000 (17:44 +0000)]
Add assertions to check for mutation of RenderLayer z-order lists during enumeration
https://bugs.webkit.org/show_bug.cgi?id=83242

Reviewed by James Robinson.

Add debug-only code that detects whether RenderLayer's z-order and
normal flow lists are being cleared or otherwise mutated while we're
enumerating over them.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::paintList):
(WebCore::RenderLayer::calculateLayerBounds):
(WebCore::RenderLayer::dirtyZOrderLists):
(WebCore::RenderLayer::dirtyNormalFlowList):
(WebCore::RenderLayer::updateZOrderListsSlowCase):
(WebCore::RenderLayer::updateNormalFlowList):
* rendering/RenderLayer.h:
(RenderLayer):
(WebCore::RenderLayer::layerListMutationAllowed):
(WebCore::RenderLayer::setLayerListMutationAllowed):
(WebCore):
(LayerListMutationDetector):
(WebCore::LayerListMutationDetector::LayerListMutationDetector):
(WebCore::LayerListMutationDetector::~LayerListMutationDetector):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::hasVisibleNonCompositingDescendantLayers):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::addToOverlapMapRecursive):
(WebCore::RenderLayerCompositor::computeCompositingRequirements):
(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
(WebCore::RenderLayerCompositor::updateLayerTreeGeometry):
(WebCore::RenderLayerCompositor::updateCompositingDescendantGeometry):
(WebCore::RenderLayerCompositor::recursiveRepaintLayerRect):
(WebCore::RenderLayerCompositor::layerHas3DContent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r113254.
zmo@google.com [Thu, 5 Apr 2012 17:27:16 +0000 (17:27 +0000)]
Unreviewed, rolling out r113254.
http://trac.webkit.org/changeset/113254
https://bugs.webkit.org/show_bug.cgi?id=83291

Requested by sievers@chromium.org (Requested by zhenyao on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-05

* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::canDraw):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRolling out http://trac.webkit.org/changeset/113262.
msaboff@apple.com [Thu, 5 Apr 2012 17:18:22 +0000 (17:18 +0000)]
Rolling out trac.webkit.org/changeset/113262.
Original code was fine.

Rubber-stamped by Oliver Hunt.

* assembler/MacroAssembler.h:
(JSC::MacroAssembler::additionBlindedConstant):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r113307.
zmo@google.com [Thu, 5 Apr 2012 17:11:41 +0000 (17:11 +0000)]
Unreviewed, rolling out r113307.
http://trac.webkit.org/changeset/113307
https://bugs.webkit.org/show_bug.cgi?id=83288

Requested by sievers@chromium.org (Requested by zhenyao on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-05

Source/WebCore:

* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::canDraw):

Source/WebKit/chromium:

* tests/CCLayerTreeHostTest.cpp:
(WTF::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Unreviewed gardening.
tony@chromium.org [Thu, 5 Apr 2012 16:56:02 +0000 (16:56 +0000)]
[chromium] Unreviewed gardening.
fast/events/click-focus-anchor.html is flakey in debug
fast/filesystem/file-writer-abort-continue.html is hitting an assert.

* platform/chromium-mac-leopard/svg/css/getComputedStyle-basic-expected.txt:
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt: Removed.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Fix includes after QtDeclarative -> QtQML renaming
ossy@webkit.org [Thu, 5 Apr 2012 16:50:32 +0000 (16:50 +0000)]
[Qt] Fix includes after QtDeclarative -> QtQML renaming
https://bugs.webkit.org/show_bug.cgi?id=82195

Relanding r112651, because Qt5 is updated everywhere.

Source/WebKit/qt:

* declarative/experimental/plugin.cpp:
* declarative/plugin.cpp:
(WebKitQmlPlugin::initializeEngine):

Source/WebKit2:

* UIProcess/API/qt/qquicknetworkreply_p.h:
* UIProcess/API/qt/qquicknetworkrequest_p.h:
* UIProcess/API/qt/qquickwebview.cpp:
* UIProcess/API/qt/qquickwebview_p.h:
* UIProcess/API/qt/qwebiconimageprovider_p.h:
* UIProcess/API/qt/qwebnavigationhistory.cpp:
* UIProcess/API/qt/qwebnavigationhistory_p.h:
* UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:
* UIProcess/qt/QtDialogRunner.cpp:
(QtDialogRunner::initForAlert):
(QtDialogRunner::initForConfirm):
(QtDialogRunner::initForPrompt):
(QtDialogRunner::initForAuthentication):
(QtDialogRunner::initForProxyAuthentication):
(QtDialogRunner::initForCertificateVerification):
(QtDialogRunner::initForFilePicker):
(QtDialogRunner::initForDatabaseQuotaDialog):
(QtDialogRunner::createDialog):
* UIProcess/qt/WebPopupMenuProxyQt.cpp:
(WebKit::WebPopupMenuProxyQt::createItem):
(WebKit::WebPopupMenuProxyQt::createContext):

Tools:

* MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::updateVisualMockTouchPoints):
* MiniBrowser/qt/main.cpp:
* WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::WrapperWindow::handleStatusChanged):
* qmake/mkspecs/features/unix/default_post.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoExtend HitTestResult to support not "discarding" shadow content in favor of its DOM...
tonikitoo@webkit.org [Thu, 5 Apr 2012 16:46:22 +0000 (16:46 +0000)]
Extend HitTestResult to support not "discarding" shadow content in favor of its DOM ancestor
https://bugs.webkit.org/show_bug.cgi?id=80847

Reviewed by David Hyatt.
Patch by Antonio Gomes <agomes@rim.com>

.:

Exporting Internals::nodesFromRect symbols for the Gtk build.

* Source/autotools/symbols.filter:

Source/WebCore:

In order to improve touch precision on shadow tree content, patch
extends the rect-hittest'ing system to allow shadow content
to be stored as the rect-hittest result node list.

Primary use cases are for this extension is making it easier to
improve the clickability of default controls of <video> and <audio>
elements.

For the callee site, the use is simple: if shadow content in the rect-hittest
result is desired, just add an extra 'AllowShadowContent' parameter at the creation
of the HitTestResult object.

Test: fast/dom/nodesFromRect-shadowContent.html

* dom/Document.cpp:
(WebCore::Document::nodesFromRect):
* dom/Document.h:
(Document):
* page/EventHandler.cpp:
(WebCore::EventHandler::hitTestResultAtPoint):
* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::HitTestResult):
(WebCore::HitTestResult::addNodeToRectBasedTestResult):
* rendering/HitTestResult.h:
(HitTestResult):
(WebCore::HitTestResult::shadowContentFilterPolicy):
* rendering/RenderImage.cpp:
(WebCore::RenderImage::nodeAtPoint):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::hitTestList):
* testing/Internals.cpp:
(WebCore::Internals::nodesFromRect):
* testing/Internals.h:
(Internals):
* testing/Internals.idl:

LayoutTests:

Adds a test that rect-hittest's a element known to have a shadow
tree (<video> with built-in controls), and check if its return type
contains its clickable shadow nodes.

* fast/dom/nodesFromRect-shadowContent-expected.txt: Added.
* fast/dom/nodesFromRect-shadowContent.html: Added.
* fast/dom/resources/nodesFromRect.js:
(check):
(checkShadowContent):

Conflicts:

Source/WebCore/page/FrameView.cpp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRename CSS Exclusions "rect" value to "rectangle"
commit-queue@webkit.org [Thu, 5 Apr 2012 16:41:51 +0000 (16:41 +0000)]
Rename CSS Exclusions "rect" value to "rectangle"
https://bugs.webkit.org/show_bug.cgi?id=82367

Patch by Hans Muller <hmuller@adobe.com> on 2012-04-05
Reviewed by Ryosuke Niwa.

Changed the CSS exclusion shape called "rect" to "rectangle" to match
the current draft spec - http://dev.w3.org/csswg/css3-exclusions.

Source/WebCore:

The meeting minutes where the decision to rename the exclusion "rect" function
to "rectangle" are: http://lists.w3.org/Archives/Public/www-style/2012Feb/0325.html

No new tests were created; just updated the existing ones.

* css/CSSParser.cpp:
(WebCore::CSSParser::parseWrapShapeRectangle):
(WebCore::CSSParser::parseWrapShape):
* css/CSSParser.h:
* css/CSSWrapShapes.cpp:
(WebCore::CSSWrapShapeRectangle::cssText):
* css/CSSWrapShapes.h:
(WebCore::CSSWrapShapeRectangle::create):
(WebCore::CSSWrapShapeRectangle::type):
(WebCore::CSSWrapShapeRectangle::CSSWrapShapeRectangle):

LayoutTests:

* fast/exclusions/parsing-wrap-shape-inside-expected.txt:
* fast/exclusions/parsing-wrap-shape-outside-expected.txt:
* fast/exclusions/script-tests/parsing-wrap-shape-inside.js:
* fast/exclusions/script-tests/parsing-wrap-shape-outside.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Marked fast/filesystem/file-writer-abort-continue.html as flaky crash
dglazkov@chromium.org [Thu, 5 Apr 2012 16:39:54 +0000 (16:39 +0000)]
[Chromium] Marked fast/filesystem/file-writer-abort-continue.html as flaky crash
https://bugs.webkit.org/show_bug.cgi?id=83286

* platform/chromium/test_expectations.txt: Marked.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[BlackBerry] Disable paintingGoesToWindow() for the root layer when forced compositin...
commit-queue@webkit.org [Thu, 5 Apr 2012 16:10:40 +0000 (16:10 +0000)]
[BlackBerry] Disable paintingGoesToWindow() for the root layer when forced compositing mode is active
https://bugs.webkit.org/show_bug.cgi?id=83127

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-04-05
Reviewed by Rob Buis.

RIM PR: 136381
The BlackBerry port will use accelerated compositing code path to
render the root layer in some situations.

The plan is to do this by activating the "force compositing mode"
setting, but that in itself doesn't get us all the way, since painting
will still go to window for the root layer.

Fixed by adding a special clause in
RenderLayerBacking::paintingGoesToWindow() for PLATFORM(BLACKBERRY).

No new tests, this is currently not testable with the BlackBerry WebKit
testing infrastructure.

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::paintingGoesToWindow):
* rendering/RenderLayerCompositor.h:
(RenderLayerCompositor):
(WebCore::RenderLayerCompositor::inForcedCompositingMode): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[BlackBerry] Force compositing mode when backing store is not active
commit-queue@webkit.org [Thu, 5 Apr 2012 15:57:12 +0000 (15:57 +0000)]
[BlackBerry] Force compositing mode when backing store is not active
https://bugs.webkit.org/show_bug.cgi?id=83131

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-04-05
Reviewed by George Staikos.

RIM PR: 136381
Normally, the BlackBerry WebKit port resorts to direct rendering when
the backing store is not active. However, direct rendering is broken
with the OpenGL code path. This prevented multiple web pages from being
displayed at once with the new WebPageCompositor API.

Fixed by using accelerated compositing layer to render the root layer
instead of backing store. This will give us a tiled layer backing the
root layer, which for some use cases is even better than direct
rendering.

Reviewed internally by Filip Spacek.

* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::shouldDirectRenderingToWindow):
(BlackBerry::WebKit::BackingStorePrivate::blitContents):
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::setLoadState):
(BlackBerry::WebKit::WebPage::setVisible):
(BlackBerry::WebKit::WebPagePrivate::suspendBackingStore):
(BlackBerry::WebKit::WebPagePrivate::resumeBackingStore):
(BlackBerry::WebKit::WebPagePrivate::compositorDrawsRootLayer):
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::setCompositorDrawsRootLayer):
(BlackBerry::WebKit::WebPagePrivate::drawLayersOnCommit):
(BlackBerry::WebKit::WebPagePrivate::scheduleRootLayerCommit):
(BlackBerry::WebKit::WebPagePrivate::commitRootLayer):
(BlackBerry::WebKit::WebPagePrivate::commitRootLayerIfNeeded):
(BlackBerry::WebKit::WebPagePrivate::rootLayerCommitTimerFired):
(BlackBerry::WebKit::WebPagePrivate::setRootLayerCompositingThread):
(BlackBerry::WebKit::WebPagePrivate::createCompositor):
(BlackBerry::WebKit::WebPagePrivate::suspendRootLayerCommit):
(BlackBerry::WebKit::WebPagePrivate::setNeedsOneShotDrawingSynchronization):
* Api/WebPageCompositor.cpp:
(BlackBerry::WebKit::WebPageCompositorPrivate::WebPageCompositorPrivate):
(BlackBerry::WebKit::WebPageCompositorPrivate::drawsRootLayer):
(WebKit):
(BlackBerry::WebKit::WebPageCompositorPrivate::drawLayers):
* Api/WebPageCompositor_p.h:
(BlackBerry::WebKit::WebPageCompositorPrivate::rootLayer):
(WebPageCompositorPrivate):
(BlackBerry::WebKit::WebPageCompositorPrivate::setDrawsRootLayer):
* Api/WebPage_p.h:
(WebPagePrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[EFL][DRT] Gardening 30 missing expectations
rakuco@webkit.org [Thu, 5 Apr 2012 15:51:41 +0000 (15:51 +0000)]
[EFL][DRT] Gardening 30 missing expectations
https://bugs.webkit.org/show_bug.cgi?id=83266

Unreviewed EFL gardening.

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-05

* platform/efl/fast/repaint/transform-rotate-and-remove-expected.txt: Added.
* platform/efl/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.txt: Added.
* platform/efl/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.txt: Added.
* platform/efl/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.txt: Added.
* platform/efl/svg/as-background-image/svg-as-background-1-expected.png: Added.
* platform/efl/svg/as-background-image/svg-as-background-1-expected.txt: Added.
* platform/efl/svg/as-background-image/svg-as-background-3-expected.png: Added.
* platform/efl/svg/as-background-image/svg-as-background-3-expected.txt: Added.
* platform/efl/svg/as-background-image/svg-as-background-4-expected.png: Added.
* platform/efl/svg/as-background-image/svg-as-background-4-expected.txt: Added.
* platform/efl/svg/foreignObject/fO-display-none-expected.txt: Added.
* platform/efl/svg/foreignObject/fO-display-none-with-relative-pos-content-expected.txt: Added.
* platform/efl/svg/foreignObject/fO-parent-display-changes-expected.txt: Added.
* platform/efl/svg/foreignObject/fO-parent-display-none-expected.txt: Added.
* platform/efl/svg/foreignObject/fO-parent-display-none-with-relative-pos-content-expected.txt: Added.
* platform/efl/svg/foreignObject/fO-parent-of-parent-display-none-expected.txt: Added.
* platform/efl/svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content-expected.txt: Added.
* platform/efl/svg/repaint/repainting-after-animation-element-removal-expected.txt: Added.
* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSION(99539): Infinite repaint loop with SVGImage and deferred repaint timers
schenney@chromium.org [Thu, 5 Apr 2012 15:51:24 +0000 (15:51 +0000)]
REGRESSION(99539): Infinite repaint loop with SVGImage and deferred repaint timers
https://bugs.webkit.org/show_bug.cgi?id=78315

Reviewed by Dimitri Glazkov.

The existing fix for this issue was failing to check if the frameView object
was currently _in_ layout, in addition to whether it needs layout. Calling the
redraw method while in layout leads to a debug assertion and potential infinite
layout loops. Now we check whether we need layout or are in layout. We also add
a check when the repaint timer fires to ensure we do not call redraw during layout
at that point.

This patch was tested with tens of thousands of runs on layout test cases that
previously crashed at a rate of about 1 in 25. Now we see no crashes and no test
failures.

No new tests, as this exists to fix flaky existing tests.

* svg/graphics/SVGImageCache.cpp:
(WebCore::SVGImageCache::imageContentChanged):
(WebCore::SVGImageCache::redrawTimerFired):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRebaseline after 73643
schenney@chromium.org [Thu, 5 Apr 2012 15:35:49 +0000 (15:35 +0000)]
Rebaseline after 73643
https://bugs.webkit.org/show_bug.cgi?id=73643

Unreviewed update of test expectations.

Patch by Philip Rogers <pdr@google.com> on 2012-04-05

* platform/chromium-linux/svg/clip-path/clipper-placement-issue-expected.png: Removed.
* platform/chromium-linux/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.txt: Removed.
* platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
* platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
* platform/chromium-mac-leopard/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.png:
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/filters-color-01-b-expected.png: Removed.
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png: Removed.
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/filters-example-01-b-expected.png: Removed.
* platform/chromium-mac-snowleopard/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.png:
* platform/chromium-mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.png: Added.
* platform/chromium-mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png: Added.
* platform/chromium-mac/svg/W3C-SVG-1.1/masking-path-01-b-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/svg/clip-path/clipper-placement-issue-expected.png: Added.
* platform/chromium-mac/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.png: Added.
* platform/chromium-mac/svg/filters/feDropShadow-expected.png: Modified property svn:mime-type.
* platform/chromium-win/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/masking-path-01-b-expected.png:
* platform/chromium-win/svg/clip-path/clipper-placement-issue-expected.png: Added.
* platform/chromium-win/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.png: Added.
* platform/chromium-win/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.txt: Added.
* platform/chromium-win/svg/filters/feDropShadow-expected.png: Modified property svn:mime-type.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] WK1/WK2 layout test results are diverging
ossy@webkit.org [Thu, 5 Apr 2012 15:32:12 +0000 (15:32 +0000)]
[Qt] WK1/WK2 layout test results are diverging
https://bugs.webkit.org/show_bug.cgi?id=82720

The resolving of default font families was altered in Qt5.
This directly affects the font picked by DRT for layout
tests. Since we want to keep the Qt4 and Qt5 results in line,
we can trick DRT in picking the same font as before for now.

Patch by Pierre Rossi <pierre.rossi@gmail.com> on 2012-04-05
Reviewed by Csaba Osztrogonác.

* DumpRenderTree/qt/QtInitializeTestFonts.cpp:
(WebKit::initializeTestFonts):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoHide datalist element
keishi@webkit.org [Thu, 5 Apr 2012 14:44:26 +0000 (14:44 +0000)]
Hide datalist element
https://bugs.webkit.org/show_bug.cgi?id=82874

Source/WebCore:

The datalist element should be hidden when ENABLE_DATALIST is on.

Reviewed by Kent Tamura.

Tests: fast/forms/datalist/datalist-fallback-content-expected.html
       fast/forms/datalist/datalist-fallback-content.html

* css/html.css:
(datalist): Added display:none.

LayoutTests:

Reviewed by Kent Tamura.

* fast/forms/datalist/datalist-fallback-content-expected.html: Added.
* fast/forms/datalist/datalist-fallback-content.html: Added. Tests that fallback content is hidden.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdjust max bisection search iterations for TouchpadFlingGestureCurve.
wjmaclean@chromium.org [Thu, 5 Apr 2012 13:49:09 +0000 (13:49 +0000)]
Adjust max bisection search iterations for TouchpadFlingGestureCurve.
https://bugs.webkit.org/show_bug.cgi?id=83166

Reviewed by James Robinson.

Covered by existing tests.

* platform/TouchpadFlingPlatformGestureCurve.cpp:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: CodeGeneratorInspector.py: switch FileSystem, Profiler and Worker...
commit-queue@webkit.org [Thu, 5 Apr 2012 13:25:04 +0000 (13:25 +0000)]
Web Inspector: CodeGeneratorInspector.py: switch FileSystem, Profiler and Worker domains to typed API
https://bugs.webkit.org/show_bug.cgi?id=83069

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-04-05
Reviewed by Yury Semikhatsky.

Domains are switched to 'strict' mode. However, hardly any changes were needed in C++ code because
only basic types are currently used in Inspector.json.

* inspector/CodeGeneratorInspector.py:
* inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::getProfileHeaders):
(WebCore):
(WebCore::InspectorProfilerAgent::getObjectByHeapObjectId):
* inspector/InspectorProfilerAgent.h:
(InspectorProfilerAgent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDOM measurement APIs should operate on pixel snapped values.
leviw@chromium.org [Thu, 5 Apr 2012 12:49:20 +0000 (12:49 +0000)]
DOM measurement APIs should operate on pixel snapped values.
https://bugs.webkit.org/show_bug.cgi?id=83138

Reviewed by Julien Chaffraix.

DOM measurement APIs return unscaled integers. In an effort to return the best possible values (and
most consistent with current behavior) when we use sub-pixel values for Layout, we want to adjust
the actual on-screen position and size values for scaling, not the sub-pixel values.

No new tests. No change in behavior.

* dom/Element.cpp:
(WebCore::adjustForLocalZoom): Needs to return an integer, since this is what the DOM API calls for.
(WebCore::Element::offsetWidth): Using pixel snapped values for all the following functions.
(WebCore::Element::offsetHeight):
(WebCore::Element::clientLeft):
(WebCore::Element::clientTop):
(WebCore::Element::clientWidth):
(WebCore::Element::clientHeight):
* html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::width):
(WebCore::HTMLImageElement::height):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: [chromium] clean up WDTFC::saveAs after migration to save()
pfeldman@chromium.org [Thu, 5 Apr 2012 12:32:41 +0000 (12:32 +0000)]
Web Inspector: [chromium] clean up WDTFC::saveAs after migration to save()
https://bugs.webkit.org/show_bug.cgi?id=83271

Reviewed by Yury Semikhatsky.

* public/WebDevToolsFrontendClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: add ability to copy resource URL from web inspector's resources page.
pfeldman@chromium.org [Thu, 5 Apr 2012 12:22:25 +0000 (12:22 +0000)]
Web Inspector: add ability to copy resource URL from web inspector's resources page.
https://bugs.webkit.org/show_bug.cgi?id=83175

Reviewed by Yury Semikhatsky.

Added requested context menu item.

* inspector/front-end/ResourcesPanel.js:
(WebInspector.FrameResourceTreeElement.prototype._handleContextMenuEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: display frame duration instead of time ruler in Timeline panel's frame...
caseq@chromium.org [Thu, 5 Apr 2012 12:19:01 +0000 (12:19 +0000)]
Web Inspector: display frame duration instead of time ruler in Timeline panel's frame mode
https://bugs.webkit.org/show_bug.cgi?id=83184

Reviewed by Pavel Feldman.

* inspector/front-end/TimelineFrameController.js:
(WebInspector.TimelineFrameController): Maintain reference to TimelinePresentationModel
(WebInspector.TimelineFrameController.prototype._flushFrame): Report frames to TimelinePresentationModel (only real ones)
* inspector/front-end/TimelineGrid.js:
(WebInspector.TimelineGrid.prototype.removeDividers): remove time marks/labels from upper time ruler
* inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewPane.prototype._updateEventDividers): Updated call site of createEventDivider
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._updateEventDividers):
(WebInspector.TimelinePanel.prototype._shouldShowFrames):
(WebInspector.TimelinePanel.prototype._updateFrames): Frame bars rendering logic.
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline.addTimestampRecords): Do not keep frames in the panel any more.
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
(WebInspector.TimelinePanel.prototype._refresh): Moved updateDividers() call here...
(WebInspector.TimelinePanel.prototype._refreshRecords):  ... from here.
* inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.createEventDivider): Use type & title, not entire record.
(WebInspector.TimelinePresentationModel.prototype.frames): Maintain frames in the TimelinePresentationModel.
(WebInspector.TimelinePresentationModel.prototype.reset): ditto.
(WebInspector.TimelinePresentationModel.prototype.addFrame): ditto.
(WebInspector.TimelinePresentationModel.Record): Fix title for timestamp events (drive by).
* inspector/front-end/timelinePanel.css:
(.timeline-frame-strip):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[WinCE] Remove unnecessary function decleration
paroga@webkit.org [Thu, 5 Apr 2012 11:56:14 +0000 (11:56 +0000)]
[WinCE] Remove unnecessary function decleration
https://bugs.webkit.org/show_bug.cgi?id=83155

Reviewed by Kentaro Hara.

Source/JavaScriptCore:

* runtime/JSDateMath.cpp:

Source/WTF:

* wtf/DateMath.cpp:
* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoIsCommentNode flags is a waste.
morrita@google.com [Thu, 5 Apr 2012 11:50:35 +0000 (11:50 +0000)]
IsCommentNode flags is a waste.
https://bugs.webkit.org/show_bug.cgi?id=83251

Reviewed by Ryosuke Niwa.

Effectively nobody uses it. To save a precious NodeFlags bit, this
change removes NodeFlags::IsCommentFlag and its companion mehtod
Node::isCommentNode().

No new tests. No behaviour change.

* dom/CharacterData.h:
(WebCore::CharacterData::CharacterData):
* dom/Comment.cpp:
(WebCore::Comment::Comment):
* dom/Node.h:
* rendering/RenderTreeAsText.cpp:
(WebCore::getTagName):
This was the only client of Node::isCommentNode(). Replaced it with nodeType() call.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt][WK2] Skip tests that still failing after implementing layoutTestController.setPa...
ossy@webkit.org [Thu, 5 Apr 2012 11:45:07 +0000 (11:45 +0000)]
[Qt][WK2] Skip tests that still failing after implementing layoutTestController.setPageVisibility()
https://bugs.webkit.org/show_bug.cgi?id=83263
[Qt] Moving already skipped test to right place and skip new SHADOW_DOM test.
https://bugs.webkit.org/show_bug.cgi?id=82607

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-04-05
Reviewed by Csaba Osztrogonác.

* platform/qt-5.0-wk2/Skipped:
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[EFL][DRT] Remove layer-related passing tests from test_expectations.txt
commit-queue@webkit.org [Thu, 5 Apr 2012 10:58:30 +0000 (10:58 +0000)]
[EFL][DRT] Remove layer-related passing tests from test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=83262

Unreviewed gardening

Fixing test expectations file - some of these cases already pass.

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-05

* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[BlackBerry] Clear local storage won't take effect until browser exit and relaunch
commit-queue@webkit.org [Thu, 5 Apr 2012 10:52:47 +0000 (10:52 +0000)]
[BlackBerry] Clear local storage won't take effect until browser exit and relaunch
https://bugs.webkit.org/show_bug.cgi?id=83253

Patch by Jonathan Dong <jonathan.dong@torchmobile.com.cn> on 2012-04-05
Reviewed by Rob Buis.

.:

RIM PR: #146871
Added a manual test case to test the behavior when press
button "Clear Local Storage" from browser settings.
It has to be a manual test as it requires user interaction.

* ManualTests/blackberry/clear-localstorage.html: Added.

Source/WebKit/blackberry:

RIM PR: #146871
Cleared the local storage namespace of a WebPage's PageGroup
when WebPage::clearLocalStorage() get called.
Also deleted unused global function clearLocalStorage().

* Api/BlackBerryGlobal.cpp:
* Api/BlackBerryGlobal.h:
(WebKit):
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::clearLocalStorage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoLayout Test fast/text/international/font-fallback-to-common-script.html has flaky...
commit-queue@webkit.org [Thu, 5 Apr 2012 10:41:07 +0000 (10:41 +0000)]
Layout Test fast/text/international/font-fallback-to-common-script.html has flaky image results on all Chromium bots
https://bugs.webkit.org/show_bug.cgi?id=81544

Patch by Matt Falkenhagen <falken@chromium.org> on 2012-04-05
Reviewed by Kent Tamura.

Skip embed-bidi-style-in-isolate-crash.html, which seems to cause the
subsequent layout test to fail (bug https://bugs.webkit.org/show_bug.cgi?id=83260).

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agowebkit_unit_tests build fix.
hans@chromium.org [Thu, 5 Apr 2012 10:14:43 +0000 (10:14 +0000)]
webkit_unit_tests build fix.
https://bugs.webkit.org/show_bug.cgi?id=83261

Unreviewed, webkit_unit_tests buildfix.

The CCLayerTreeHostTestEmptyContentsShouldNotDraw.runMultiThread test
stopped working after r113254.

Disable it for now.

Source/WebCore:

* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::canDraw):

Source/WebKit/chromium:

* tests/CCLayerTreeHostTest.cpp:
(WTF):
(WTF::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Remove a wrong expectation file for hebrew-vowels.html.
tkent@chromium.org [Thu, 5 Apr 2012 10:10:09 +0000 (10:10 +0000)]
[Chromium] Remove a wrong expectation file for hebrew-vowels.html.
https://bugs.webkit.org/show_bug.cgi?id=81544

* platform/chromium-mac-snowleopard/fast/text/international/hebrew-vowels-expected.txt: Removed.
* platform/chromium-mac/fast/text/international/hebrew-vowels-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[GTK][DRT] Fail fast/filesystem/flags-passing.html on JSC
commit-queue@webkit.org [Thu, 5 Apr 2012 09:25:20 +0000 (09:25 +0000)]
[GTK][DRT] Fail fast/filesystem/flags-passing.html on JSC
https://bugs.webkit.org/show_bug.cgi?id=83137

Patch by ChangSeok Oh <shivamidow@gmail.com> on 2012-04-05
Reviewed by Kentaro Hara.

fast/filesystem/flags-passing.html is failed on webkitgtk+ applied FileSystem API patch
for bug58443. 'testsList' is a global array object, but it's accessed in runNextTest
function object like this, "this[testsList[testCounter++]]();". I'm not familiar
with JavaScript and V8, but in my understanding, it looks a bit strange.
'this' in the statement means runNextTest function object which doesn't have
testList array object. (It's a global scope variable.) This test might be able to
pass on V8 JS engine, but not on JSC at least my try.
'testsList' is changed from a function name array to a function array.

* fast/filesystem/script-tests/flags-passing.js:
(runNextTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, GTK test_expectations update after r113292.
philn@webkit.org [Thu, 5 Apr 2012 09:13:34 +0000 (09:13 +0000)]
Unreviewed, GTK test_expectations update after r113292.

* platform/gtk/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Unreviewed gardening after r113279
kkristof@inf.u-szeged.hu [Thu, 5 Apr 2012 09:08:45 +0000 (09:08 +0000)]
[Qt] Unreviewed gardening after r113279

* platform/qt/Skipped: Skip a new failing test because ENABLE(MUTATION_OBSERVERS) is disabled.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Unreviewed gardening
kkristof@inf.u-szeged.hu [Thu, 5 Apr 2012 08:58:42 +0000 (08:58 +0000)]
[Qt] Unreviewed gardening
https://bugs.webkit.org/show_bug.cgi?id=82607
Skip V8 specific test that currently not supported on Qt bots

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-04-05

* platform/qt/Skipped: fast/dom/shadow/selection-shouldnt-expose-shadow-dom.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Only shut down V8 if we actually initialized it
jochen@chromium.org [Thu, 5 Apr 2012 08:53:05 +0000 (08:53 +0000)]
[chromium] Only shut down V8 if we actually initialized it
https://bugs.webkit.org/show_bug.cgi?id=83159

Reviewed by Pavel Feldman.

* src/WebKit.cpp:
(WebKit::initialize):
(WebKit::shutdown):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[EFL] keycode translation is wrong for function keys
commit-queue@webkit.org [Thu, 5 Apr 2012 08:47:21 +0000 (08:47 +0000)]
[EFL] keycode translation is wrong for function keys
https://bugs.webkit.org/show_bug.cgi?id=82738

Source/WebCore:

This patch fixes keycode translation for function keys.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-05
Reviewed by Philippe Normand.

Test: fast/events/keydown-function-keys.html

* platform/efl/EflKeyboardUtilities.cpp:
(WebCore::createWindowsKeyMap):

LayoutTests:

Unskip fast/events/keydown-function-keys.html

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-05
Reviewed by Philippe Normand.

* platform/efl/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWork around an entity parsing bug in libxml2 2.7.3 (supplied with Lion) and unskip...
zimmermann@webkit.org [Thu, 5 Apr 2012 08:18:07 +0000 (08:18 +0000)]
Work around an entity parsing bug in libxml2 2.7.3 (supplied with Lion) and unskip tests
https://bugs.webkit.org/show_bug.cgi?id=82577

Reviewed by Filip Pizlo.

Source/WebCore:

Work-around entity expansion bug that affects several SVG tests on Lion.

Sample test document which is currently broken:
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1 Basic//EN" "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11-basic.dtd" [
<!ENTITY Smile "<rect x='.5' y='.5' width='29' height='39' fill='black' stroke='red'/>">
]>

<svg xmlns="http://www.w3.org/2000/svg">&Smile;</svg>

The expanded rect carries no namespace, thus an Element will be created for it, instead of a SVGRectElement.
libxml2 2.7.4 fixed this bug (https://bugzilla.gnome.org/show_bug.cgi?id=502960) in 2009 already, but Lion
still ships with 2.7.3, so we need to find a work-around for the problem. It works like this:
- When an entity is requested (getEntityHandler) determine whether the entity is being declared (while the <!ENTITY.. parses)
  or wheter its references (when the &Smile; is parsed). If its referenced, record the current depth of the libxml2 parser.
- When startElementNs is called while we're expanding entities, be sure to transfer the namespace of the parent node
  to the new node, but only do this if the current depth() is greater than the depth() at the time where entity expansion started.
  This way we only apply our workaround for elements inside entities, that get expanded at the insertion point.
- When endElementNs is called, and our current depth() is less than our equal to the depth() where entity expansion started,
  clear the recorded detph(), and stop executing the workaround.

It requires storing an extra integer & boolean in XMLDocumentParser, which is only used for this work-around.

* xml/parser/XMLDocumentParser.h:
(XMLDocumentParser):
(WebCore::XMLDocumentParser::isParsingEntityDeclaration):
(WebCore::XMLDocumentParser::setIsParsingEntityDeclaration):
(WebCore::XMLDocumentParser::depthTriggeringEntityExpansion):
(WebCore::XMLDocumentParser::setDepthTriggeringEntityExpansion):
* xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::XMLDocumentParser):
(WebCore::hackAroundLibXMLEntityParsingBug):
(WebCore::XMLDocumentParser::startElementNs):
(WebCore::XMLDocumentParser::endElementNs):
(WebCore::entityDeclarationHandler):
(WebCore::getEntityHandler):
(WebCore::XMLDocumentParser::initializeParserContext):

LayoutTests:

Unskip several test on Lion, now that the libxml2 bug doesn't affect us anymore.

* platform/mac-lion/Skipped:
* platform/mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png:
* platform/mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt:
* platform/mac/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.png:
* platform/mac/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt:
* platform/mac/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
* platform/mac/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt:
* platform/mac/svg/custom/preserve-aspect-ratio-syntax-expected.png:
* platform/mac/svg/custom/preserve-aspect-ratio-syntax-expected.txt:
* platform/mac/svg/custom/viewbox-syntax-expected.png:
* platform/mac/svg/custom/viewbox-syntax-expected.txt:
* platform/mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png:
* platform/mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
* platform/mac/svg/zoom/text/zoom-coords-viewattr-01-b-expected.png:
* platform/mac/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd JavaScript and CSS code for the calendar picker implementation
tkent@chromium.org [Thu, 5 Apr 2012 07:30:51 +0000 (07:30 +0000)]
Add JavaScript and CSS code for the calendar picker implementation
https://bugs.webkit.org/show_bug.cgi?id=83011

Reviewed by Hajime Morita.

.:

* ManualTests/forms/calendar-picker.html: Added.

Source/WebCore:

Add calendarPicker.js and calendarPicker.css, and add a build rule to
generate a C++ file. This change doesn't make any behavior change
because the code is wrapped by ENABLE(CALENDAR_PICKER).

Tests: ManualTests/forms/calendar-picker.html

* Resources/calendarPicker.css: Added.
* Resources/calendarPicker.js: Added.
* WebCore.gyp/WebCore.gyp: Generate CalendarPicker.{cpp,h} from calendarPicker.{css,js}.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoExpose DataTransferItem.getAsEntry() to allow users access dropped files as FileEntry
kinuko@chromium.org [Thu, 5 Apr 2012 07:29:28 +0000 (07:29 +0000)]
Expose DataTransferItem.getAsEntry() to allow users access dropped files as FileEntry
https://bugs.webkit.org/show_bug.cgi?id=82592

Reviewed by David Levin.

Source/WebCore:

For now the method is prefixed thus it is to be exposed as 'webkitGetAsEntry'.

The API is proposed and discussed in the following whatwg thread:
http://lists.whatwg.org/pipermail/whatwg-whatwg.org/2011-November/033814.html

Add DataTransferItemFilesystem under Modules/filesystem and implemented the bridging part for chromium.

Test: editing/pasteboard/data-transfer-items-drag-drop-entry.html

* Modules/filesystem/DataTransferItemFileSystem.h: Added.
(DataTransferItemFileSystem):
* Modules/filesystem/DataTransferItemFileSystem.idl: Added for DataTransferItem.getAsEntry which is only exposed if filesystem is enabled.
* Modules/filesystem/chromium/DataTransferItemFileSystemChromium.cpp: Added for chromium implementation.
* Modules/filesystem/chromium/DataTransferItemFileSystemChromium.h: Added.
* Modules/filesystem/chromium/DraggedIsolatedFileSystem.cpp: Added.
* Modules/filesystem/chromium/DraggedIsolatedFileSystem.h: Added.
* WebCore.gypi:
* platform/chromium/ChromiumDataObject.cpp:
* platform/chromium/ChromiumDataObject.h:
(WebCore::ChromiumDataObject::filesystemId): Added.
(WebCore::ChromiumDataObject::setFilesystemId): Added.
* platform/chromium/ClipboardChromium.cpp:

Source/WebKit/chromium:

* src/WebDragData.cpp:
(WebKit::WebDragData::filesystemId): Added implementation.
(WebKit::WebDragData::setFilesystemId): Added implementation.

Tools:

Added filesystem hook support in EventSender.beginDragWithFiles() for DumpRenderTree.

* DumpRenderTree/chromium/EventSender.cpp:
(EventSender::beginDragWithFiles):

LayoutTests:

* editing/pasteboard/data-transfer-items-drag-drop-entry-expected.txt: Added.
* editing/pasteboard/data-transfer-items-drag-drop-entry.html: Added.
* editing/pasteboard/resources/test_directory/test.txt: Added.
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, GTK rebaseline after r113279.
philn@webkit.org [Thu, 5 Apr 2012 07:21:36 +0000 (07:21 +0000)]
Unreviewed, GTK rebaseline after r113279.

* platform/gtk/fast/dom/Window/window-properties-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113296 268f45cc-cd09-0410-ab3c-d52691b4dbfc